- 15 Feb, 2011 40 commits
-
-
tkent@chromium.org authored
Unreviewed, test expectation update. Chromium-Mac-Leopard baseline files for r78677. * platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added. * platform/chromium-mac-leopard/fast/forms/input-appearance-spinbutton-layer-expected.png: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Unreviewed, test expectation update. Chromium baseline files for a new test of r78677. * platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added. * platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.png: Added. * platform/chromium-linux/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added. * platform/chromium-win-xp/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added. * platform/chromium-win-xp/fast/forms/input-appearance-spinbutton-layer-expected.png: Added. * platform/chromium-win-xp/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by David Levin. Remove the artificial -32px shift for media controls in mediaDocuments so that they overlap the canvas as they do in non-mediaDocuments. This also fixes test_shell failing to update the media slider (see linked crbug below). https://bugs.webkit.org/show_bug.cgi?id=27798 http://crbug.com/72623 Test: media/video-controls-in-media-document.html Added a render test that asserts that the controls show up in the expected spot (0,208) instead of below the canvas (0,240). * css/mediaControlsChromium.css: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Reviewed by Darin Adler. Extract a function to process ancestor and their sibling nodes from processContents https://bugs.webkit.org/show_bug.cgi?id=54425 Extracted processAncestorsAndTheirSiblings. * dom/Range.cpp: (WebCore::Range::processContents): Calls processContents. (WebCore::Range::processAncestorsAndTheirSiblings): Extracted from processContents. * dom/Range.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by David Levin. WebURLRequest, WebURLResponse properties should be passed to WebCore Layer https://bugs.webkit.org/show_bug.cgi?id=54489 No tests needed, exposes no new functionality * src/WebURLRequest.cpp: (WebKit::WebURLRequestPrivateImpl::WebURLRequestPrivateImpl): (WebKit::WebURLRequest::downloadToFile): (WebKit::WebURLRequest::setDownloadToFile): * src/WebURLRequestPrivate.h: (WebKit::WebURLRequestPrivate::WebURLRequestPrivate): * src/WebURLResponse.cpp: (WebKit::WebURLResponsePrivateImpl::WebURLResponsePrivateImpl): (WebKit::WebURLResponse::downloadFilePath): (WebKit::WebURLResponse::setDownloadFilePath): * src/WebURLResponsePrivate.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=54427 Reviewed by Darin Fisher. Source/WebCore: Test: fast/forms/input-appearance-spinbutton-layer.html * rendering/RenderThemeChromiumWin.cpp: Add checks for multiple ThemePainter instances. (WebCore::RenderThemeChromiumWin::paintInnerSpinButton): Avoid to create multiple ThemePainter instances. LayoutTests: * fast/forms/input-appearance-spinbutton-layer.html: Added. * platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.checksum: Added. * platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.png: Added. * platform/mac/fast/forms/input-appearance-spinbutton-layer-expected.txt: Added. * platform/gtk/Skipped: * platform/qt/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Sam Weinig. WebPluginSiteDataManager should work with plug-in process https://bugs.webkit.org/show_bug.cgi?id=54523 <rdar://problem/8689312> * PluginProcess/PluginProcess.cpp: (WebKit::PluginProcess::removeWebProcessConnection): Call startShutdownTimerIfNecessary(). (WebKit::PluginProcess::getSitesWithData): Ask the plug-in module for the sites with data and send them back in a PluginProcessProxy::DidGetSitesWithData message. (WebKit::PluginProcess::clearSiteData): Clear site data and send back a DidClearSiteData message. (WebKit::PluginProcess::startShutdownTimerIfNecessary): Factor code out from removeWebProcessConnection. * PluginProcess/PluginProcess.messages.in: Add new messages. * UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::plugins): New function for getting all plug-ins. * UIProcess/Plugins/PluginProcessManager.cpp: (WebKit::PluginProcessManager::getPluginProcessConnection): Call getOrCreatePluginProcess. (WebKit::PluginProcessManager::getSitesWithData): Get a plug-in process proxy and call getSitesWithData. (WebKit::PluginProcessManager::clearSiteData): Get a plug-in process proxy and call clearSiteData. (WebKit::PluginProcessManager::getOrCreatePluginProcess): Factor code to create a plug-in process out into a separate function. * UIProcess/Plugins/PluginProcessProxy.cpp: (WebKit::PluginProcessProxy::getSitesWithData): (WebKit::PluginProcessProxy::clearSiteData): Update the pending reply struct. If the process is still launching, enqueue the request. Otherwise, just send the message. (WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch): Make sure that pending replies are sent out. (WebKit::PluginProcessProxy::didFinishLaunching): Send our pending requests. (WebKit::PluginProcessProxy::didGetSitesWithData): (WebKit::PluginProcessProxy::didClearSiteData): Call down to the plug-in site data manager. * UIProcess/Plugins/PluginProcessProxy.messages.in: Add DidGetSitesWithData and DidClearSiteData messages. * UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::GetSitesWithDataState::GetSitesWithDataState): Initialize the state. (WebKit::WebPluginSiteDataManager::GetSitesWithDataState::getSitesWithDataForNextPlugin): If the plug-in queue is empty, call didGetSitesWithDataForAllPlugins. Otherwise, ask the plug-in process manager to get sites for the next plug-in. (WebKit::WebPluginSiteDataManager::GetSitesWithDataState::didGetSitesWithDataForSinglePlugin): Update the sites set and get sites for the next plug-in. (WebKit::WebPluginSiteDataManager::ClearSiteDataState::ClearSiteDataState): Initialize the state. (WebKit::WebPluginSiteDataManager::ClearSiteDataState::clearSiteDataForNextPlugin): If the plug-in queue is empty, call didClearSiteDataForAllPlugins. Otherwise, ask the plug-in process manager to get sites for the next plug-in. (WebKit::WebPluginSiteDataManager::ClearSiteDataState::didClearSiteDataForSinglePlugin): Update the sites set and ask the next plug-in to clear site data. (WebKit::WebPluginSiteDataManager::~WebPluginSiteDataManager): Assert that all maps are empty. (WebKit::WebPluginSiteDataManager::invalidate): Delete and clear the pending state maps. (WebKit::WebPluginSiteDataManager::getSitesWithData): In the ENABLE(PLUGIN_PROCESS) case, allocate a new GetSitesWithDataState object and tell it to get sites for the next plug-in. Otherwise, make sure that the web process is alive before sending a GetSitesWithPluginData message. (WebKit::WebPluginSiteDataManager::clearSiteData): In the ENABLE(PLUGIN_PROCESS) case, allocate a new ClearSiteDataState object and tell it to get sites for the next plug-in. Otherwise, make sure that the web process is alive before sending a ClearPluginSiteData message. (WebKit::WebPluginSiteDataManager::didGetSitesWithDataForSinglePlugin): Call down to the GetSitesWithDataState object. (WebKit::WebPluginSiteDataManager::didGetSitesWithDataForAllPlugins): Free the GetSitesWithDataState object and invoke the callback. (WebKit::WebPluginSiteDataManager::didClearSiteDataForSinglePlugin): Call down to the GetSitesWithDataState object. (WebKit::WebPluginSiteDataManager::didClearSiteDataForAllPlugins): Free the GetSitesWithDataState object and invoke the callback. * UIProcess/WebContext.cpp: (WebKit::WebContext::processDidClose): Don't invalidate the plug-in site data manager if we're using a plug-in process. * WebProcess/WebProcess.cpp: (WebKit::WebProcess::getSitesWithPluginData): (WebKit::WebProcess::clearPluginSiteData): Call shutdownIfPossible(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Skip all Hixie SVG performance tests on GTK+. They seem to be timing out on the GTK+ debug bots. * platform/gtk/Skipped: Skip Hixie SVG performance tests. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ddkilzer@apple.com authored
<http://webkit.org/b/54505> Move -[WebDynamicScrollBarsView inProgrammaticScroll] to WebDynamicScrollBarsViewInternal.h Reviewed by Darin Adler. * WebView/WebDynamicScrollBarsView.h: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Removed declaration. * WebView/WebDynamicScrollBarsView.mm: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Moved implementation into correct category. * WebView/WebDynamicScrollBarsViewInternal.h: (-[WebDynamicScrollBarsView inProgrammaticScroll]): Added declaration. * WebView/WebHTMLView.mm: Included WebDynamicScrollBarsViewInternal.h instead of WebDynamicScrollBarsView.h. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jhoneycutt@apple.com authored
Rubber-stamped by Alice Liu. * win/WebKit2Generated.make: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sfalken@apple.com authored
Tracked by https://bugs.webkit.org/show_bug.cgi?id=54519 * platform/win/Skipped: Skip fast/xmlhttprequest/xmlhttprequest-responsetype-arraybuffer.html git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
crogers@google.com authored
Reviewed by Kenneth Russell. Fix race condition in JavaScriptAudioNode https://bugs.webkit.org/show_bug.cgi?id=54518 No new tests since audio API is not yet implemented. * webaudio/JavaScriptAudioNode.cpp: (WebCore::JavaScriptAudioNode::process): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pkasting@chromium.org authored
Remove line with dupe expectations. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Darin Adler. Implement WKPluginSiteDataManagerClearSiteData https://bugs.webkit.org/show_bug.cgi?id=54512 <rdar://problem/8689312> * UIProcess/API/C/WKPluginSiteDataManager.cpp: (WKPluginSiteDataManagerGetTypeID): Implement this. (toNPClearSiteDataFlags): Convert WKClearSiteDataFlags to NPP_ClearSiteData flags. (WKPluginSiteDataManagerClearSiteData): (WKPluginSiteDataManagerClearAllSiteData): Call through to WebPluginSiteDataManager::clearSiteData. * UIProcess/API/C/WKPluginSiteDataManager.h: Change the clear functions to take a completion callback. * UIProcess/Plugins/WebPluginSiteDataManager.cpp: (WebKit::WebPluginSiteDataManager::clearSiteData): Ask the plug-in info store for all plug-in paths and send a ClearPluginSiteData message to the web process. (WebKit::WebPluginSiteDataManager::didClearSiteData): call the callback. * UIProcess/WebContext.cpp: (WebKit::WebContext::didClearPluginSiteData): Call through to the plug-in site data manager. * UIProcess/WebContext.messages.in: Add ClearPluginSiteData message. * WebProcess/WebProcess.cpp: (WebKit::WebProcess::clearPluginSiteData): Iterate over all the plug-in paths, creating plug-in modules and calling clearSiteData for each one. * WebProcess/WebProcess.h: * WebProcess/WebProcess.messages.in: Add DidClearPluginSiteData message. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mihaip@chromium.org authored
Unreviewed chromium-gpu-linux rebaseline of compositing/geometry/vertical-scroll-composited.html. * platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.checksum: * platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pkasting@chromium.org authored
* platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jorlow@chromium.org authored
Reviewed by Nate Chapin. Throwing in an IndexedDB error or success event should lead to the transaction aborting https://bugs.webkit.org/show_bug.cgi?id=54249 * storage/indexeddb/exception-in-event-aborts-expected.txt: Added. * storage/indexeddb/exception-in-event-aborts.html: Added. tests new feature * storage/indexeddb/queued-commands-expected.txt: * storage/indexeddb/queued-commands.html: cleaned up (while debuggign something else) * storage/indexeddb/request-event-propagation-expected.txt: * storage/indexeddb/request-event-propagation.html: a few additional tests + cleanup * storage/indexeddb/transaction-event-propagation-expected.txt: * storage/indexeddb/transaction-event-propagation.html: a few additional tests + cleanup 2011-02-10 Jeremy Orlow <jorlow@chromium.org> Reviewed by Nate Chapin. Throwing in an IndexedDB error or success event should lead to the transaction aborting https://bugs.webkit.org/show_bug.cgi?id=54249 When an exception is thrown but not handled within an IDBRequests success/error event, we should abort the transaction. Test: storage/indexeddb/exception-in-event-aborts.html * bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::handleEvent): * bindings/js/JSEventTarget.cpp: (WebCore::toJS): * bindings/v8/V8AbstractEventListener.cpp: (WebCore::V8AbstractEventListener::invokeEventHandler): * dom/EventTarget.cpp: (WebCore::EventTarget::uncaughtExceptionInEventHandler): * dom/EventTarget.h: * storage/IDBRequest.cpp: (WebCore::IDBRequest::uncaughtExceptionInEventHandler): * storage/IDBRequest.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jhoneycutt@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=54415 * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Remove deleted files. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Darin Adler. To determine image properties, CG allocates memory which isn't included in CachedImage's decoded size https://bugs.webkit.org/show_bug.cgi?id=53281 When determining properties of an image (such as its size), CG ends up decoding part of the image. This patch adds accounting for this extra decoded size so a cache prune can clean up the allocations. * platform/graphics/BitmapImage.cpp: (WebCore::BitmapImage::BitmapImage): (WebCore::BitmapImage::destroyMetadataAndNotify): Clearing the source destroys the extra decoded data. Report this change in decoded size to the image observer. (WebCore::BitmapImage::cacheFrame): The first decoded frame subsumes the data decoded when determining image properties, so we subtract it out here. (WebCore::BitmapImage::didDecodeProperties): Reports the extra decoded size to the image's observer. (WebCore::BitmapImage::size): (WebCore::BitmapImage::currentFrameSize): (WebCore::BitmapImage::getHotSpot): (WebCore::BitmapImage::frameCount): (WebCore::BitmapImage::isSizeAvailable): (WebCore::BitmapImage::repetitionCount): * platform/graphics/BitmapImage.h: * platform/graphics/ImageSource.cpp: (WebCore::ImageSource::bytesDecodedToDetermineProperties): The default value is 0 to match the current behavior on other platforms. * platform/graphics/ImageSource.h: * platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::bytesDecodedToDetermineProperties): Add a constant value for bytesDecodedToDetermineProperties(), measured by tracing malloc/calloc calls while asking an image source for its properties. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sfalken@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=54506 * platform/win/fast/inline: Added. * platform/win/fast/inline/inline-box-background-expected.txt: Added. * platform/win/fast/inline/inline-box-background-long-image-expected.txt: Added. * platform/win/fast/inline/inline-box-background-repeat-x-expected.txt: Added. * platform/win/fast/inline/inline-box-background-repeat-y-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mihaip@chromium.org authored
Unreviewed chromium-gpu rebaseline. Rebaseline tests that were unskipped after r78619 as well as some lingering Mac rebaselines. * platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.png: Added. * platform/chromium-gpu-linux/compositing/color-matching/image-color-matching-expected.txt: Added. * platform/chromium-gpu-linux/compositing/geometry/abs-position-inside-opacity-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/geometry/abs-position-inside-opacity-expected.png: Added. * platform/chromium-gpu-linux/compositing/geometry/abs-position-inside-opacity-expected.txt: Added. * platform/chromium-gpu-linux/compositing/masks/direct-image-mask-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/masks/direct-image-mask-expected.png: Added. * platform/chromium-gpu-linux/compositing/masks/direct-image-mask-expected.txt: Added. * platform/chromium-gpu-linux/compositing/overflow/ancestor-overflow-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/overflow/ancestor-overflow-expected.png: Added. * platform/chromium-gpu-linux/compositing/overflow/ancestor-overflow-expected.txt: Added. * platform/chromium-gpu-linux/compositing/repaint/composited-document-element-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/repaint/composited-document-element-expected.png: Added. * platform/chromium-gpu-linux/compositing/repaint/composited-document-element-expected.txt: Added. * platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.checksum: Added. * platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.png: Added. * platform/chromium-gpu-linux/compositing/shadows/shadow-drawing-expected.txt: Added. * platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.checksum: Added. * platform/chromium-gpu-mac/compositing/color-matching/image-color-matching-expected.png: Added. * platform/chromium-gpu-mac/compositing/geometry/abs-position-inside-opacity-expected.checksum: Added. * platform/chromium-gpu-mac/compositing/geometry/abs-position-inside-opacity-expected.png: Added. * platform/chromium-gpu-mac/compositing/masks/direct-image-mask-expected.checksum: Added. * platform/chromium-gpu-mac/compositing/masks/direct-image-mask-expected.png: Added. * platform/chromium-gpu-mac/compositing/overflow/overflow-scroll-expected.checksum: Added. * platform/chromium-gpu-mac/compositing/overflow/overflow-scroll-expected.png: Added. * platform/chromium-gpu-mac/compositing/repaint/composited-document-element-expected.checksum: Added. * platform/chromium-gpu-mac/compositing/repaint/composited-document-element-expected.png: Added. * platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute2-expected.checksum: Added. * platform/chromium-gpu-mac/compositing/repaint/opacity-between-absolute2-expected.png: Added. * platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.checksum: Added. * platform/chromium-gpu-mac/compositing/shadows/shadow-drawing-expected.png: Added. * platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.checksum: Added. * platform/chromium-gpu-mac/compositing/text-on-large-layer-expected.png: Added. * platform/chromium-gpu-mac/compositing/tiling/constrained-layer-size-expected.checksum: Added. * platform/chromium-gpu-mac/compositing/tiling/constrained-layer-size-expected.png: Added. * platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.checksum: Added. * platform/chromium-gpu-mac/compositing/transitions/scale-transition-no-start-expected.png: Added. * platform/chromium-gpu-mac/compositing/z-order/negative-z-index-expected.checksum: Added. * platform/chromium-gpu-mac/compositing/z-order/negative-z-index-expected.png: Added. * platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.checksum: Added. * platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.png: Added. * platform/chromium-gpu-win/compositing/color-matching/image-color-matching-expected.txt: Added. * platform/chromium-gpu-win/compositing/geometry/abs-position-inside-opacity-expected.checksum: Added. * platform/chromium-gpu-win/compositing/geometry/abs-position-inside-opacity-expected.png: Added. * platform/chromium-gpu-win/compositing/geometry/abs-position-inside-opacity-expected.txt: Added. * platform/chromium-gpu-win/compositing/masks/direct-image-mask-expected.checksum: Added. * platform/chromium-gpu-win/compositing/masks/direct-image-mask-expected.png: Added. * platform/chromium-gpu-win/compositing/masks/direct-image-mask-expected.txt: Added. * platform/chromium-gpu-win/compositing/overflow/ancestor-overflow-expected.checksum: Added. * platform/chromium-gpu-win/compositing/overflow/ancestor-overflow-expected.png: Added. * platform/chromium-gpu-win/compositing/overflow/ancestor-overflow-expected.txt: Added. * platform/chromium-gpu-win/compositing/repaint/composited-document-element-expected.checksum: Added. * platform/chromium-gpu-win/compositing/repaint/composited-document-element-expected.png: Added. * platform/chromium-gpu-win/compositing/repaint/composited-document-element-expected.txt: Added. * platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.checksum: Added. * platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.png: Added. * platform/chromium-gpu-win/compositing/shadows/shadow-drawing-expected.txt: Added. * platform/chromium-gpu-win/compositing/tiling/constrained-layer-size-expected.checksum: Added. * platform/chromium-gpu-win/compositing/tiling/constrained-layer-size-expected.png: Added. * platform/chromium-gpu-win/compositing/z-order/negative-z-index-expected.checksum: Added. * platform/chromium-gpu-win/compositing/z-order/negative-z-index-expected.png: Added. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jamesr@google.com authored
Reviewed by Alexey Proskuryakov. requestAnimationFrame callbacks should not fire within a modal dialog https://bugs.webkit.org/show_bug.cgi?id=53188 Tests that requestAnimationFrame callbacks are suspended while a modal dialog is showing. * fast/animation/request-animation-frame-during-modal-expected.txt: Added. * fast/animation/request-animation-frame-during-modal.html: Added. 2011-02-15 James Robinson <jamesr@chromium.org> Reviewed by Alexey Proskuryakov. requestAnimationFrame callbacks should not fire within a modal dialog https://bugs.webkit.org/show_bug.cgi?id=53188 requestAnimationFrame callbacks shouldn't fire while a modal dialog is up (like a window.alert()). This matches Firefox and other async APIs. This patch moves the callback servicing into its own controller class which receives notifications on suspend/resume. Test: fast/animation/request-animation-frame-during-modal.html * WebCore.gypi: * bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::setJavaScriptPaused): * dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::suspendScriptedAnimationControllerCallbacks): (WebCore::Document::resumeScriptedAnimationControllerCallbacks): (WebCore::Document::webkitRequestAnimationFrame): (WebCore::Document::webkitCancelRequestAnimationFrame): (WebCore::Document::serviceScriptedAnimations): * dom/Document.h: * dom/ScriptExecutionContext.h: (WebCore::ScriptExecutionContext::suspendScriptedAnimationControllerCallbacks): (WebCore::ScriptExecutionContext::resumeScriptedAnimationControllerCallbacks): * dom/ScriptedAnimationController.cpp: Added. (WebCore::ScriptedAnimationController::ScriptedAnimationController): (WebCore::ScriptedAnimationController::suspend): (WebCore::ScriptedAnimationController::resume): (WebCore::ScriptedAnimationController::registerCallback): (WebCore::ScriptedAnimationController::cancelCallback): (WebCore::ScriptedAnimationController::serviceScriptedAnimations): * dom/ScriptedAnimationController.h: Added. (WebCore::ScriptedAnimationController::create): * history/CachedFrame.cpp: (WebCore::CachedFrameBase::restore): (WebCore::CachedFrame::CachedFrame): * page/PageGroupLoadDeferrer.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Jon Honeycutt. Implement WKPluginSiteDataManagerGetSitesWithData https://bugs.webkit.org/show_bug.cgi?id=54510 <rdar://problem/8689312> * UIProcess/API/C/WKContext.cpp: (WKContextGetPluginSiteDataManager): Call WebContext::pluginSiteDataManager. * UIProcess/API/C/WKPluginSiteDataManager.cpp: (WKPluginSiteDataManagerGetSitesWithData): Call WebPluginSiteDataManager::getSitesWithData. * UIProcess/Plugins/PluginInfoStore.cpp: (WebKit::PluginInfoStore::getPluginPaths): * UIProcess/Plugins/PluginInfoStore.h: Populate the paths argument with the paths of all plug-ins. * UIProcess/Plugins/WebPluginSiteDataManager.cpp: Added. (WebKit::WebPluginSiteDataManager::invalidate): Invalidate the callbacks map. (WebKit::WebPluginSiteDataManager::getSitesWithData): Ask the plug-in info store for all plug-in paths and send a GetSitesWithPluginData message to the web process. (WebKit::WebPluginSiteDataManager::didGetSitesWithPluginData): Call the callback. * UIProcess/Plugins/WebPluginSiteDataManager.h: Added. (WebKit::WebPluginSiteDataManager::clearContext): Clear the context. * UIProcess/WebContext.cpp: (WebKit::WebContext::WebContext): Initialize m_pluginSiteDataManager. (WebKit::WebContext::~WebContext): Invalidate the plug-in site data manager and clear its context. (WebKit::WebContext::processDidClose): Invalidate the plug-in site data manager. (WebKit::WebContext::didGetSitesWithPluginData): Call through to the plug-in site data manager. * UIProcess/WebContext.h: * UIProcess/WebContext.messages.in: Add GetSitesWithPluginData message. * WebKit2.pro: * WebKit2.xcodeproj/project.pbxproj: * win/WebKit2.vcproj: Add new files. * WebProcess/WebProcess.cpp: (WebKit::WebProcess::getSitesWithPluginData): Iterate over all plug-in paths and get the sites from all plug-ins. * WebProcess/WebProcess.h: * WebProcess/WebProcess.messages.in: Add DidGetSitesWithPluginData. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kalman@chromium.org authored
Reviewed by Darin Adler. Clean up results for editing/selection/extend-selection-home-end layout test https://bugs.webkit.org/show_bug.cgi?id=54508 Line up results in columns, remove unused pixel test results from qt. * editing/selection/extend-selection-home-end-expected.txt: * editing/selection/extend-selection-home-end.html: * platform/mac/editing/selection/extend-selection-home-end-expected.txt: * platform/qt/editing/selection/extend-selection-home-end-expected.checksum: Removed. * platform/qt/editing/selection/extend-selection-home-end-expected.png: Removed. * platform/win/editing/selection/extend-selection-home-end-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jorlow@chromium.org authored
Reviewed by Darin Fisher. Add initial support for per-origin quotas to IndexedDB https://bugs.webkit.org/show_bug.cgi?id=54421 Add support for non-persistent per-origin quotas. If one is specified, it overrides the default. No tests as this is only exposed via the Chromium webkit API. * storage/IDBFactoryBackendImpl.cpp: (WebCore::IDBFactoryBackendImpl::open): (WebCore::IDBFactoryBackendImpl::setQuota): * storage/IDBFactoryBackendImpl.h: * storage/IDBFactoryBackendInterface.h: 2011-02-14 Jeremy Orlow <jorlow@chromium.org> Reviewed by Darin Fisher. Add initial support for per-origin quotas to IndexedDB https://bugs.webkit.org/show_bug.cgi?id=54421 * public/WebIDBFactory.h: (WebKit::WebIDBFactory::setQuota): * src/AssertMatchingEnums.cpp: * src/IDBFactoryBackendProxy.cpp: (WebCore::IDBFactoryBackendProxy::setQuota): * src/IDBFactoryBackendProxy.h: * src/WebIDBFactoryImpl.cpp: (WebKit::WebIDBFactoryImpl::setQuota): * src/WebIDBFactoryImpl.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Darin Adler. XSLT with output method HTML and images crashes in debug mode https://bugs.webkit.org/show_bug.cgi?id=54462 http://trac.webkit.org/changeset/75577 created Document::setContent but didn't notice that the code paths combined into Document::setContent were subtly different. In particular, some of the code paths called parser->finish() whereas other did not. The difference is that an explicit call to parser->finish() is required in the case where there is no frame because explicitClose doesn't call endIfNotLoadingMainResource if there is no frame. This patch moves that logic inside explicitClose, which is more natural. This patch also removes removeAllChildren, which has not effect in this situation and should never have been added in the first place. Test: fast/parser/xslt-with-html.xml * dom/Document.cpp: (WebCore::Document::setContent): (WebCore::Document::explicitClose): 2011-02-15 Adam Barth <abarth@webkit.org> Reviewed by Darin Adler. XSLT with output method HTML and images crashes in debug mode https://bugs.webkit.org/show_bug.cgi?id=54462 Test that we don't try to prepare to stop twice when pasing HTML generated from an XSLT. * fast/parser/resources/xslt-with-html.xsl: Added. * fast/parser/xslt-with-html-expected.txt: Added. * fast/parser/xslt-with-html.xml: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kbr@google.com authored
Unreviewed. Remove whitespace-only change from http://trac.webkit.org/changeset/78620 (https://bugs.webkit.org/show_bug.cgi?id=54312) now that the patch has passed the Windows build bots. * Interfaces/WebKit.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrobinson@webkit.org authored
Rebaseline some GTK+ tests which have different results on the bots. Skip a test which appears to be timing out intermittently. * platform/gtk/Skipped: Skip a test which has been timing out. * platform/gtk/svg/custom/use-nested-transform-expected.txt: * platform/gtk/svg/hixie/perf/001-expected.txt: * platform/gtk/svg/hixie/perf/002-expected.txt: * platform/gtk/svg/hixie/perf/007-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=52221 <rdar://problem/8663399> Patch by Jia Pu <jpu@apple.com> on 2011-02-15 Reviewed by Darin Adler. Rebaselined tests affected by code change. * platform/mac/editing/spelling/autocorrection-contraction-expected.txt: * platform/mac/editing/spelling/autocorrection-delete-expected.txt: * platform/mac/editing/spelling/autocorrection-removing-underline-after-paste-expected.txt: * platform/mac/editing/spelling/autocorrection-removing-underline-expected.txt: * platform/mac/editing/spelling/autocorrection-simple-expected.txt: * platform/mac/editing/spelling/delete-autocorrected-word-1-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
* WebKit2.pro: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
Fix EFL build for https://bugs.webkit.org/show_bug.cgi?id=54415 * CMakeLists.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
* win/WebKit2.vcproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
Fix EFL build for https://bugs.webkit.org/show_bug.cgi?id=54415 * CMakeLists.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
http://webkit.org/b/54487ddkilzer@apple.com authored
Reviewed by Darin Adler. * rendering/RenderLayerBacking.cpp: Remove unused WebGLRenderingContext.h header, and move GraphicsContext3D.h into a #if ENABLE(WEBGL) || ENABLE(ACCELERATED_2D_CANVAS)/#endif block. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pkasting@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=40147 https://bugs.webkit.org/show_bug.cgi?id=48029 https://bugs.webkit.org/show_bug.cgi?id=53740 https://bugs.webkit.org/show_bug.cgi?id=54387 https://bugs.webkit.org/show_bug.cgi?id=54418 https://bugs.webkit.org/show_bug.cgi?id=54499 Remove a couple erroneously-added baselines, unmark some now-passing tests, bug numbers, etc. * platform/chromium-linux/http/tests/xmlhttprequest: Removed. * platform/chromium-linux/http/tests/xmlhttprequest/cache-override-expected.txt: Removed. * platform/chromium-win/fast/gradients/css3-repeating-end-fill-expected.txt: Removed. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
Reviewed by Gavin Barraclough and Geoff Garen. Refactor handles and weak pointers to become nicer and more automatic https://bugs.webkit.org/show_bug.cgi?id=54415 Move to a true handle based mechanism for GC value protection. This also allows us to switch to a more sensible behaviour for weak pointers in which weak pointers are automatically updated. This allows us to remove the old (and convoluted) that required all objects that may be held by a weak reference to be aware of the reference and manually clear them in their destructors. This also adds a few new data types to JSC that we use to efficiently allocate and return the underlying handle storage. This patch is largely renaming and removing now unnecessary destructors from objects. * API/JSClassRef.cpp: (OpaqueJSClass::create): (OpaqueJSClassContextData::OpaqueJSClassContextData): (OpaqueJSClass::contextData): (OpaqueJSClass::prototype): * API/JSClassRef.h: * CMakeLists.txt: * GNUmakefile.am: * JavaScriptCore.exp: * JavaScriptCore.gypi: * JavaScriptCore.pro: * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: * JavaScriptCore.vcproj/WTF/WTF.vcproj: * JavaScriptCore.vcproj/jsc/jscCommon.vsprops: * JavaScriptCore.xcodeproj/project.pbxproj: * collector/handles/Global.h: Added. New Global handle type used to keep gc objects live, even if they're not marked. (JSC::Global::Global): (JSC::Global::~Global): (JSC::Global::set): We can only assign directly to a global from another global. In all other cases we need the JSGlobalData to be provided explicitly so we use a set function. (JSC::Global::operator=): (JSC::Global::clear): (JSC::Global::isHashTableDeletedValue): (JSC::Global::internalSet): * collector/handles/Handle.h: Added. Root "Handle" type used for immutable handles and to provide the basic APIs needed for pointer-like behaviour. (JSC::HandleBase::operator!): (JSC::HandleBase::operator UnspecifiedBoolType*): (JSC::HandleBase::isEmpty): (JSC::HandleBase::HandleBase): (JSC::HandleBase::slot): (JSC::HandleBase::invalidate): (JSC::HandleBase::setSlot): (JSC::HandleTypes::getFromSlot): (JSC::HandleTypes::toJSValue): (JSC::HandleTypes::validateUpcast): (JSC::HandleConverter::operator->): (JSC::HandleConverter::operator*): (JSC::Handle::Handle): (JSC::Handle::get): (JSC::Handle::wrapSlot): (JSC::operator==): (JSC::operator!=): * collector/handles/HandleHeap.cpp: Added. New heap for global handles. (JSC::HandleHeap::HandleHeap): (JSC::HandleHeap::grow): (JSC::HandleHeap::markStrongHandles): (JSC::HandleHeap::updateAfterMark): (JSC::HandleHeap::clearWeakPointers): (JSC::HandleHeap::writeBarrier): * collector/handles/HandleHeap.h: Added. (JSC::HandleHeap::heapFor): (JSC::HandleHeap::toHandle): (JSC::HandleHeap::toNode): (JSC::HandleHeap::allocate): (JSC::HandleHeap::deallocate): (JSC::HandleHeap::makeWeak): Convert a hard handle into weak handle that does not protect the object it points to. (JSC::HandleHeap::makeSelfDestroying): Converts a handle to a weak handle that will be returned to the free list when the referenced object dies. (JSC::HandleHeap::Node::Node): (JSC::HandleHeap::Node::slot): (JSC::HandleHeap::Node::handleHeap): (JSC::HandleHeap::Node::setFinalizer): (JSC::HandleHeap::Node::makeWeak): (JSC::HandleHeap::Node::isWeak): (JSC::HandleHeap::Node::makeSelfDestroying): (JSC::HandleHeap::Node::isSelfDestroying): (JSC::HandleHeap::Node::finalizer): (JSC::HandleHeap::Node::setPrev): (JSC::HandleHeap::Node::prev): (JSC::HandleHeap::Node::setNext): (JSC::HandleHeap::Node::next): * interpreter/Interpreter.cpp: (JSC::Interpreter::Interpreter): * interpreter/Interpreter.h: * interpreter/RegisterFile.cpp: (JSC::RegisterFile::globalObjectCollected): * interpreter/RegisterFile.h: (JSC::RegisterFile::RegisterFile): * runtime/GCHandle.cpp: Removed. * runtime/GCHandle.h: Removed. * runtime/Heap.cpp: (JSC::Heap::Heap): (JSC::Heap::destroy): (JSC::Heap::markRoots): * runtime/Heap.h: (JSC::Heap::allocateGlobalHandle): (JSC::Heap::reportExtraMemoryCost): * runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): * runtime/JSGlobalData.h: (JSC::JSGlobalData::allocateGlobalHandle): * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::~JSGlobalObject): * runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::create): (JSC::JSPropertyNameIterator::~JSPropertyNameIterator): * runtime/JSPropertyNameIterator.h: (JSC::JSPropertyNameIterator::createStructure): (JSC::Structure::setEnumerationCache): (JSC::Structure::clearEnumerationCache): * runtime/Protect.h: * runtime/Structure.cpp: (JSC::Structure::~Structure): * runtime/Structure.h: * runtime/WeakGCPtr.h: (JSC::WeakGCPtrBase::get): (JSC::WeakGCPtrBase::clear): (JSC::WeakGCPtrBase::operator!): (JSC::WeakGCPtrBase::operator UnspecifiedBoolType*): (JSC::WeakGCPtrBase::~WeakGCPtrBase): (JSC::WeakGCPtrBase::WeakGCPtrBase): (JSC::WeakGCPtrBase::internalSet): (JSC::LazyWeakGCPtr::LazyWeakGCPtr): (JSC::LazyWeakGCPtr::set): (JSC::WeakGCPtr::WeakGCPtr): (JSC::WeakGCPtr::operator=): * runtime/WriteBarrier.h: * wtf/BlockStack.h: Added. (WTF::::BlockStack): (WTF::::~BlockStack): (WTF::::blocks): (WTF::::grow): (WTF::::shrink): * wtf/SentinelLinkedList.h: Added. (WTF::::SentinelLinkedList): (WTF::::begin): (WTF::::end): (WTF::::push): (WTF::::remove): * wtf/SinglyLinkedList.h: Added. (WTF::::SinglyLinkedList): (WTF::::isEmpty): (WTF::::push): (WTF::::pop): 2011-02-14 Oliver Hunt <oliver@apple.com> Reviewed by Gavin Barraclough and Geoff Garen. Refactor handles and weak pointers to become nicer and more automatic https://bugs.webkit.org/show_bug.cgi?id=54415 Update to use new Global<> type * JSRun.cpp: (JSRun::JSRun): (JSRun::GlobalObject): * JSRun.h: * JSValueWrapper.cpp: (JSValueWrapper::JSValueWrapper): * JSValueWrapper.h: 2011-02-14 Oliver Hunt <oliver@apple.com> Reviewed by Gavin Barraclough and Geoff Garen. Refactor handles and weak pointers to become nicer and more automatic https://bugs.webkit.org/show_bug.cgi?id=54415 Update WebCore to use the new Global<> type rather than ProtectedJSValue and gc[Un]Protect. Also update to use new WeakGCPtr APIs, and remove now unnecessary destructors. * ForwardingHeaders/collector/handles/Global.h: Added. * WebCore.vcproj/WebCore.vcproj: * WebCore.vcproj/copyForwardingHeaders.cmd: * bindings/js/JSCallbackData.h: (WebCore::JSCallbackData::JSCallbackData): * bindings/js/JSCustomVoidCallback.h: * bindings/js/JSDOMBinding.cpp: (WebCore::forgetDOMNode): (WebCore::cacheDOMNodeWrapper): * bindings/js/JSDOMWindowBase.h: * bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::setWindow): * bindings/js/JSDataGridDataSource.h: * bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): * bindings/js/JSEventListener.h: (WebCore::JSEventListener::setWrapper): * bindings/js/JSLazyEventListener.cpp: (WebCore::JSLazyEventListener::initializeJSFunction): * bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::executeFunctionInContext): * bindings/js/ScheduledAction.h: (WebCore::ScheduledAction::ScheduledAction): * bindings/js/ScriptCachedFrameData.cpp: (WebCore::ScriptCachedFrameData::ScriptCachedFrameData): (WebCore::ScriptCachedFrameData::restore): * bindings/js/ScriptCachedFrameData.h: * bindings/js/ScriptCallStackFactory.cpp: (WebCore::createScriptArguments): * bindings/js/ScriptController.cpp: (WebCore::ScriptController::createWindowShell): (WebCore::ScriptController::evaluateInWorld): (WebCore::ScriptController::clearWindowShell): (WebCore::ScriptController::attachDebugger): * bindings/js/ScriptController.h: * bindings/js/ScriptFunctionCall.cpp: (WebCore::ScriptFunctionCall::call): (WebCore::ScriptCallback::call): * bindings/js/ScriptObject.cpp: (WebCore::ScriptObject::ScriptObject): * bindings/js/ScriptObject.h: * bindings/js/ScriptState.cpp: (WebCore::ScriptStateProtectedPtr::ScriptStateProtectedPtr): (WebCore::ScriptStateProtectedPtr::get): * bindings/js/ScriptState.h: * bindings/js/ScriptValue.cpp: (WebCore::ScriptValue::isFunction): (WebCore::ScriptValue::deserialize): * bindings/js/ScriptValue.h: (WebCore::ScriptValue::ScriptValue): (WebCore::ScriptValue::hasNoValue): * bindings/js/ScriptWrappable.h: (WebCore::ScriptWrappable::ScriptWrappable): (WebCore::ScriptWrappable::setWrapper): * bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::WorkerScriptController): (WebCore::WorkerScriptController::~WorkerScriptController): (WebCore::WorkerScriptController::initScript): (WebCore::WorkerScriptController::evaluate): * bindings/js/WorkerScriptController.h: (WebCore::WorkerScriptController::workerContextWrapper): * bindings/scripts/CodeGeneratorJS.pm: * bridge/NP_jsobject.cpp: (_NPN_InvokeDefault): (_NPN_Invoke): (_NPN_Evaluate): (_NPN_Construct): * bridge/jsc/BridgeJSC.cpp: (JSC::Bindings::Instance::Instance): (JSC::Bindings::Instance::~Instance): (JSC::Bindings::Instance::willDestroyRuntimeObject): (JSC::Bindings::Instance::willInvalidateRuntimeObject): * bridge/jsc/BridgeJSC.h: * bridge/runtime_object.cpp: (JSC::Bindings::RuntimeObject::invalidate): * bridge/runtime_root.cpp: (JSC::Bindings::RootObject::RootObject): (JSC::Bindings::RootObject::invalidate): (JSC::Bindings::RootObject::globalObject): (JSC::Bindings::RootObject::updateGlobalObject): * bridge/runtime_root.h: * dom/EventListener.h: * dom/EventTarget.h: (WebCore::EventTarget::markJSEventListeners): * xml/XMLHttpRequest.cpp: Qt bindings courtesy of Csaba Osztrogonác * bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeConnectionMethod::call): (JSC::Bindings::QtConnectionObject::QtConnectionObject): (JSC::Bindings::QtConnectionObject::execute): (JSC::Bindings::QtConnectionObject::match): * bridge/qt/qt_runtime.h: 2011-02-14 Oliver Hunt <oliver@apple.com> Reviewed by Gavin Barraclough and Geoff Garen. Refactor handles and weak pointers to become nicer and more automatic https://bugs.webkit.org/show_bug.cgi?id=54415 Update to use Global<> instead of ProtectedPtr, and refactored slightly to get global data to places it's needed for when we're assigning to Global<>s * ForwardingHeaders/collector/handles/Global.h: Added. * Plugins/Hosted/NetscapePluginInstanceProxy.h: * Plugins/Hosted/NetscapePluginInstanceProxy.mm: (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::get): (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::idForObject): (WebKit::NetscapePluginInstanceProxy::LocalObjectMap::forget): (WebKit::NetscapePluginInstanceProxy::getWindowNPObject): (WebKit::NetscapePluginInstanceProxy::getPluginElementNPObject): (WebKit::NetscapePluginInstanceProxy::evaluate): (WebKit::NetscapePluginInstanceProxy::invoke): (WebKit::NetscapePluginInstanceProxy::invokeDefault): (WebKit::NetscapePluginInstanceProxy::construct): (WebKit::NetscapePluginInstanceProxy::addValueToArray): * WebView/WebScriptDebugger.h: * WebView/WebScriptDebugger.mm: (WebScriptDebugger::WebScriptDebugger): 2011-02-14 Oliver Hunt <oliver@apple.com> Reviewed by Gavin Barraclough and Geoff Garen. Refactor handles and weak pointers to become nicer and more automatic https://bugs.webkit.org/show_bug.cgi?id=54415 Update code to new Global<> API, and refactor to get global data to necessary points. * WebProcess/Plugins/Netscape/NPJSObject.cpp: (WebKit::NPJSObject::create): (WebKit::NPJSObject::NPJSObject): (WebKit::NPJSObject::initialize): (WebKit::NPJSObject::invokeDefault): (WebKit::NPJSObject::construct): (WebKit::NPJSObject::invoke): * WebProcess/Plugins/Netscape/NPJSObject.h: * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: (WebKit::NPRuntimeObjectMap::getOrCreateNPObject): (WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant): (WebKit::NPRuntimeObjectMap::evaluate): * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h: * WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::windowScriptNPObject): (WebKit::PluginView::pluginElementNPObject): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
Reviewed by Jon Honeycutt. Add stubbed out WKPluginSiteDataManagerRef API https://bugs.webkit.org/show_bug.cgi?id=54504 * Shared/API/c/WKBase.h: * Shared/APIObject.h: * UIProcess/API/C/WKAPICast.h: * UIProcess/API/C/WKContext.cpp: (WKContextGetPluginSiteDataManager): * UIProcess/API/C/WKContext.h: * UIProcess/API/C/WKPluginSiteDataManager.cpp: Added. (WKPluginSiteDataManagerGetTypeID): (WKPluginSiteDataManagerGetSitesWithData): (WKPluginSiteDataManagerClearSiteData): (WKPluginSiteDataManagerClearAllSiteData): * UIProcess/API/C/WKPluginSiteDataManager.h: Added. * WebKit2.pro: * WebKit2.xcodeproj/project.pbxproj: * win/WebKit2.vcproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
Reviewed by Darin Adler. Autocorrection should respect undo. https://bugs.webkit.org/show_bug.cgi?id=52221 <rdar://problem/8663399> Please see WebCore/ChangeLog for detailed description. * WebCoreSupport/WebEditorClient.cpp: (WebFrameImpl::replaceSelection): Adopted new signature of ReplaceSelectionCommand::create(). 2011-02-15 Jia Pu <jpu@apple.com> Reviewed by Darin Adler. Autocorrection should respect undo. https://bugs.webkit.org/show_bug.cgi?id=52221 <rdar://problem/8663399> Please see WebCore/ChangeLog for detailed description. * WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient. * WebCoreSupport/WebEditorClient.mm: (WebEditorClient::recordAutocorrectionResponse): Ditto. * WebView/WebFrame.mm: (-[WebFrame _replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Adopted new signature of ReplaceSelectionCommand::create(). 2011-02-15 Jia Pu <jpu@apple.com> Reviewed by Darin Adler. Autocorrection should respect undo. https://bugs.webkit.org/show_bug.cgi?id=52221 <rdar://problem/8663399> Manual test: manual-tests/autocorrection/undo-autocorrection.html When user undoes an autocorrection, we need to do four things: 1. Revert the change in text that has been made by correction. 2. Revert the selection to pre-correction state so that user can immediately continue typing. 3. Add appropriate markers to reverted text so that it won't be corrected again and/or shown as misspelled. 4. If applicable, notify spell checking service to record this reversion. To achieve these, this patch introduces following changes: 1. Created SpellingCorrectionCommand so that correction can be undone in similar way as any other editing command. SpellingCorrectionCommand is a composition of SetSelectionCommand, SpellingCorrectionRecordUndoCommand and ReplaceSelectionCommand. 2. Created SetSelectionCommand so that undo command can restore selection state. 3. Added member function recordAutocorrectionResponse() to editor client. To improve readability, this patch also consolidates various boolean arguments in SelectionController::setSelection() and ReplaceSelectionCommand::ReplaceSelectionCommand(). These boolean arguments have been replaced by enum variable. * WebCore.exp.in: Updated for changes in Editor and ReplaceSelectionCommand. * WebCore.xcodeproj/project.pbxproj: Updated for new source files. * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Adopted new signature of ReplaceSelectionCommand::create(). * editing/Editor.cpp: (WebCore::Editor::replaceSelectionWithFragment): Ditto. (WebCore::Editor::unappliedEditing): Cleaned up trailing whitespace. (WebCore::Editor::reappliedEditing): Ditto. (WebCore::Editor::selectComposition): Adopted new signature of SelectionController::setSelection(). (WebCore::Editor::confirmComposition): Ditto. (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Rearranged code to reduce the level of deeply nested if statement. Adopted SpellingCorrectionCommand. (WebCore::Editor::applyCorrectionPanelInfo): Adopted SpellingCorrectionCommand. (WebCore::Editor::unappliedSpellCorrection): Function for adding markers to reverted text and for notifiying editor client about undone correction. (WebCore::Editor::changeSelectionAfterCommand): Adopted new signature of SelectionController::setSelection(). (WebCore::Editor::respondToChangedSelection): Use SelectionController::SetSelectionOptions instead of boolean variables. * editing/Editor.h: Added Editor::unappliedSpellCorrection(). * editing/EditorCommand.cpp: (WebCore::executeInsertFragment): Adopted new signature of ReplaceSelectionCommand::create(). * editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::doApply): Ditto. * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Replaced all boolean arguments with an enum value. * editing/ReplaceSelectionCommand.h: (WebCore::ReplaceSelectionCommand::create): Ditto. * editing/SelectionController.cpp: Adopted new signature of SelectionController::setSelection(). (WebCore::SelectionController::moveTo): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::respondToNodeModification): (WebCore::SelectionController::setBase): (WebCore::SelectionController::setExtent): (WebCore::SelectionController::setSelectedRange): * editing/SelectionController.h: (WebCore::SelectionController::setSelection): Replaced all boolean arguments with an enum value. * editing/SetSelectionCommand.cpp: Added. (WebCore::SetSelectionCommand::SetSelectionCommand): (WebCore::SetSelectionCommand::doApply): (WebCore::SetSelectionCommand::doUnapply): * editing/SetSelectionCommand.h: Added. (WebCore::SetSelectionCommand::create): * editing/mac/SpellingCorrectionCommand.cpp: Added. (WebCore::SpellingCorrectionRecordUndoCommand::create): (WebCore::SpellingCorrectionRecordUndoCommand::SpellingCorrectionRecordUndoCommand): (WebCore::SpellingCorrectionRecordUndoCommand::doApply): (WebCore::SpellingCorrectionRecordUndoCommand::doUnapply): (WebCore::SpellingCorrectionCommand::SpellingCorrectionCommand): (WebCore::SpellingCorrectionCommand::doApply): * editing/mac/SpellingCorrectionCommand.h: Added. (WebCore::SpellingCorrectionCommand::create): * loader/EmptyClients.h: Updated for the new function declared in EditorClient. (WebCore::EmptyEditorClient::recordAutocorrectionResponse): * manual-tests/autocorrection/undo-autocorrection.html: Added. * page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Adopted new signature of ReplaceSelectionCommand::create(). * page/DragController.cpp: (WebCore::DragController::concludeEditDrag): Ditto. * page/EditorClient.h: Added EditorClient::recordAutocorrectionResponse(). 2011-02-15 Jia Pu <jpu@apple.com> Reviewed by Darin Adler. Autocorrection should respect undo. https://bugs.webkit.org/show_bug.cgi?id=52221 <rdar://problem/8663399> Please see WebCore/ChangeLog for detailed description. * WebProcess/WebCoreSupport/WebEditorClient.h: Updated for the new function declared in EditorClient. * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm: (WebKit::WebEditorClient::recordAutocorrectionResponse): Ditto. * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::replaceSelectionWithText): Adopted new signature of ReplaceSelectionCommand::create(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sfalken@apple.com authored
Failing since r78562. * platform/win/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rdar://problem/8998498bdakin@apple.com authored
8 crashes in WebProcess calling setOverlayScrollerState:forceImmediately: Reviewed by Darin Adler. My best guess is that this is crashing because willRemoveVerticalScrollbar()/Horizontal was not being called properly from the RenderLayer destructor. Call willRemoveVerticalScrollbar()/Horizontal from destroyScrollbar() so that all current and future scrollbar-destroyers will properly call this function. And only do it for native scrollers. (WebCore::RenderLayer::destroyScrollbar): (WebCore::RenderListBox::destroyScrollbar): For consistency's sake, I also moved didAddVerticalScrollbar() /Horizontal to createScrollbar(). Again, only call for native scrollers. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderListBox::createScrollbar): These functions no longer call didAdd/willRemove. (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): * rendering/RenderListBox.cpp: (WebCore::RenderListBox::setHasVerticalScrollbar): Remove unnecessary ScrollableArea::-prefix * platform/ScrollView.cpp: (WebCore::ScrollView::setHasHorizontalScrollbar): (WebCore::ScrollView::setHasVerticalScrollbar): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-