1. 27 Jun, 2011 40 commits
    • rniwa@webkit.org's avatar
      2011-06-27 Ryosuke Niwa <rniwa@webkit.org> · e1d2109c
      rniwa@webkit.org authored
              Build fix attempt after r89885.
      
              * JavaScriptCore.exp:
              * jsc.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89887 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1d2109c
    • rniwa@webkit.org's avatar
      2011-06-27 Ryosuke Niwa <rniwa@webkit.org> · 6403c49f
      rniwa@webkit.org authored
              Fix r89879.
      
              * platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.png: Removed.
              * platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.txt: Removed.
              * platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.png: Copied from LayoutTests/platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.png.
              * platform/chromium-win/fast/text/international/unicode-bidi-plaintext-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.txt.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89886 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6403c49f
    • oliver@apple.com's avatar
      2011-06-27 Oliver Hunt <oliver@apple.com> · 1db480d3
      oliver@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Support throwing away non-running code even while other code is running
              https://bugs.webkit.org/show_bug.cgi?id=63485
      
              Add a function to CodeBlock to support unlinking direct linked callsites,
              and then with that in place add logic to discard code from any function
              that is not currently on the stack.
      
              The unlinking completely reverts any optimized call sites, such that they
              may be relinked again in future.
      
              * JavaScriptCore.exp:
              * bytecode/CodeBlock.cpp:
              (JSC::CodeBlock::unlinkCalls):
              (JSC::CodeBlock::clearEvalCache):
              * bytecode/CodeBlock.h:
              (JSC::CallLinkInfo::CallLinkInfo):
              (JSC::CallLinkInfo::unlink):
              * bytecode/EvalCodeCache.h:
              (JSC::EvalCodeCache::clear):
              * heap/Heap.cpp:
              (JSC::Heap::getConservativeRegisterRoots):
              * heap/Heap.h:
              * jit/JIT.cpp:
              (JSC::JIT::privateCompile):
              * jit/JIT.h:
              * jit/JITCall.cpp:
              (JSC::JIT::compileOpCall):
              * jit/JITWriteBarrier.h:
              (JSC::JITWriteBarrierBase::clear):
              * jsc.cpp:
              (GlobalObject::GlobalObject):
              (functionReleaseExecutableMemory):
              * runtime/Executable.cpp:
              (JSC::EvalExecutable::unlinkCalls):
              (JSC::ProgramExecutable::unlinkCalls):
              (JSC::FunctionExecutable::discardCode):
              (JSC::FunctionExecutable::unlinkCalls):
              * runtime/Executable.h:
              * runtime/JSGlobalData.cpp:
              (JSC::SafeRecompiler::returnValue):
              (JSC::SafeRecompiler::operator()):
              (JSC::JSGlobalData::releaseExecutableMemory):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89885 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1db480d3
    • leviw@chromium.org's avatar
      2011-06-27 Levi Weintraub <leviw@chromium.org> · 95b9e082
      leviw@chromium.org authored
              Unreviewed.
      
              Renaming incorrectly named linux test expectation.
      
              * platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-actual.png: Removed.
              * platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-expected.png: Copied 
              from LayoutTests/platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-actual.png.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89884 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95b9e082
    • commit-queue@webkit.org's avatar
      2011-06-27 Wyatt Carss <wcarss@chromium.org> · 705e5064
      commit-queue@webkit.org authored
              Reviewed by Ryosuke Niwa.
      
              convert editing/deleting/5156801-2.html to dumpAsText and rename
              https://bugs.webkit.org/show_bug.cgi?id=63359
      
              converted editing/deleting/5156801-2.html to dump-as-markup test, with
              new results. Renamed 5156801.html to delete-node-after-DOMNodeRemoved,
              and 5156801-2.html to delete-table-cell-contents.html; they were only
              noticeably related by their rdar number, which is now included in each.
      
              * editing/deleting/5156801.html: Removed.
              * editing/deleting/5156801-expected.txt: Removed.
              * editing/deleting/5156801-2.html: Removed.
              * editing/deleting/delete-node-after-DOMNodeRemoved.html: Added.
              * editing/deleting/delete-node-after-DOMNodeRemoved-expected.txt: Added.
              * editing/deleting/delete-table-cell-contents.html: Added.
              * editing/deleting/delete-table-cell-contents-expected.txt: Added.
              * platform/chromium-linux/editing/deleting/5156801-2-expected.png: Removed.
              * platform/chromium-win/editing/deleting/5156801-2-expected.png: Removed.
              * platform/chromium-win/editing/deleting/5156801-2-expected.txt: Removed.
              * platform/gtk/editing/deleting/5156801-2-expected.txt: Removed.
              * platform/mac-leopard/editing/deleting/5156801-2-expected.png: Removed.
              * platform/mac/editing/deleting/5156801-2-expected.png: Removed.
              * platform/mac/editing/deleting/5156801-2-expected.txt: Removed.
              * platform/qt/editing/deleting/5156801-2-expected.png: Removed.
              * platform/qt/editing/deleting/5156801-2-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      705e5064
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=63497 · e47f6de1
      barraclough@apple.com authored
      Add DEBUG_WITH_BREAKPOINT support to the DFG JIT.
      
      Reviewed by Oliver Hunt.
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::parseBlock):
      * dfg/DFGNode.h:
      * dfg/DFGNonSpeculativeJIT.cpp:
      (JSC::DFG::NonSpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89882 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e47f6de1
    • abarth@webkit.org's avatar
      2011-06-27 Adam Barth <abarth@webkit.org> · 5f4c2d1b
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              NRWT should wait for ReportCrash
              https://bugs.webkit.org/show_bug.cgi?id=63495
      
              When a test crashes on Mac, ReportCrash confuses us into thinking the
              test times out.
      
              I'm not sure how to test this in a meaningful way in our current test
              harness...
      
              * Scripts/webkitpy/common/system/crashlogs.py:
              * Scripts/webkitpy/common/system/crashlogs_unittest.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
              * Scripts/webkitpy/layout_tests/port/base.py:
              * Scripts/webkitpy/layout_tests/port/mac.py:
              * Scripts/webkitpy/layout_tests/port/server_process.py:
              * Scripts/webkitpy/tool/commands/queries.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f4c2d1b
    • bweinstein@apple.com's avatar
      Fix the WebCore vcproj file after r89851. · b14b0976
      bweinstein@apple.com authored
      * WebCore.vcproj/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b14b0976
    • leviw@chromium.org's avatar
      2011-06-27 Levi Weintraub <leviw@chromium.org> · 3924343c
      leviw@chromium.org authored
              Unreviewed.
      
              Windows rebaseline for my commit r89864.
      
              * platform/win/fast/text/international/unicode-bidi-plaintext-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89879 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3924343c
    • joepeck@webkit.org's avatar
      2011-06-27 Joseph Pecoraro <joepeck@webkit.org> · 9a6f9413
      joepeck@webkit.org authored
              Reviewed by Darin Adler.
      
              Allow non-main thread text drawing in ICU ports
              https://bugs.webkit.org/show_bug.cgi?id=63482
      
              Some ports allow multiple threads to draw strings.
              LineBreakIteratorPool is not thread safe and the existing
              ASSERT caught cases where multiple threads were trying
              to access the shared pool. This makes the pool a lazily
              created per-thread pool to allow for thread safe pool use.
      
              * platform/ThreadGlobalData.h:
              * platform/ThreadGlobalData.cpp:
              (WebCore::ThreadGlobalData::ThreadGlobalData): start with null.
              (WebCore::ThreadGlobalData::lineBreakIteratorPool): lazily create.
              (WebCore::ThreadGlobalData::destroy): delete.
              Manage the lifetime of the per-thread pool instance.
      
              * platform/text/LineBreakIteratorPoolICU.h:
              (WebCore::LineBreakIteratorPool::sharedPool):
              Use the per-thread pool instance and remove the ASSERT that
              this needs to be on the main thread.
      
              (WebCore::LineBreakIteratorPool::create):
              Create a PassOwnPtr so we can use OwnPtr on pools.
      
              (WebCore::LineBreakIteratorPool::LineBreakIteratorPool):
              Private now that there is a public create function.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89878 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a6f9413
    • leviw@chromium.org's avatar
      2011-06-27 Levi Weintraub <leviw@chromium.org> · 788b8b87
      leviw@chromium.org authored
              Unreviewed.
      
              Chromium rebaselines for my commit r89864
      
              * platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-actual.png: Added.
              * platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.png: Added.
              * platform/chromium-win/fast/text/international/unicode-bidi-plaintext-actual.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89877 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      788b8b87
    • commit-queue@webkit.org's avatar
      2011-06-27 Joe Wild <joseph.wild@nokia.com> · 10098ae4
      commit-queue@webkit.org authored
              Reviewed by Simon Fraser.
      
              Crash on www.crave.cnet.com in FrameView::windowClipRect()
              https://bugs.webkit.org/show_bug.cgi?id=56393
      
              Tests that a plugin of a swf file in a hidden iframe will not
              crash. This test required more than 1 content file and a
              timeout or else it would not repeat the error condition.
      
              This test will only crash on platforms (like Symbian) that
              don't allow nonvirtual functions to have a null this pointer.
      
              * plugins/hidden-iframe-with-swf-plugin-expected.txt: Added.
              * plugins/hidden-iframe-with-swf-plugin.html: Added.
              * plugins/resources/iframe-content-with-swf-plugin.html: Added.
      2011-06-27  Joe Wild  <joseph.wild@nokia.com>
      
              Reviewed by Simon Fraser.
      
              Crash on www.crave.cnet.com in FrameView::windowClipRect()
              https://bugs.webkit.org/show_bug.cgi?id=56393
      
              Check for a null renderer to fix a crash. This situation can
              arise when external content/plugins is referenced from html
              elements with style="display:none".
      
              Test: plugins/hidden-iframe-with-swf-plugin.html
      
              * page/FrameView.cpp:
              (WebCore::FrameView::windowClipRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      10098ae4
    • commit-queue@webkit.org's avatar
      2011-06-27 Juan C. Montemayor <jmont@apple.com> · c31d353e
      commit-queue@webkit.org authored
              Reviewed by Mark Rowe.
      
              Indirectly including TextPosition.h and XPathGrammar.h causes compile errors
              https://bugs.webkit.org/show_bug.cgi?id=63392
      
              When both TextPosition.h and XPathGrammar.h are included a compile-error
              is caused, since XPathGrammar.h defines a macro called NUMBER and
              TextPosition has a typedef named NUMBER.
      
              * wtf/text/TextPosition.h:
              (WTF::TextPosition::TextPosition):
              (WTF::TextPosition::minimumPosition):
              (WTF::TextPosition::belowRangePosition):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c31d353e
    • commit-queue@webkit.org's avatar
      2011-06-27 Raymes Khoury <raymes@chromium.org> · 6d0b51b1
      commit-queue@webkit.org authored
              Reviewed by Tony Chang.
      
              WebCore fails to compile in thumb mode when neon instructions are
              enabled.
      
              There are two files (FELightingNEON.cpp and FEGaussianBlur.cpp)
              which fail to build when -mthumb is passed to gcc. These contain inline
              assembly for neon instructions on arm. This patch forces the -marm flag
              to be passed when compiling these files to work around this.
      
              https://bugs.webkit.org/show_bug.cgi?id=62916
      
              Built WebKit in Chromium and checked that -marm is passed
              only when building these files.
      
              https://bugs.webkit.org/show_bug.cgi?id=62916
      
              * WebCore.gyp/WebCore.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89874 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d0b51b1
    • abarth@webkit.org's avatar
      2011-06-27 Adam Barth <abarth@webkit.org> · 469c86e2
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              new-run-webkit-tests should upload crash logs
              https://bugs.webkit.org/show_bug.cgi?id=55907
      
              * fast/harness/resources/results-test.js:
              * fast/harness/results.html:
      2011-06-27  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              new-run-webkit-tests should upload crash logs
              https://bugs.webkit.org/show_bug.cgi?id=55907
      
              NRWT used to have a different name for crash logs.  I've changed the
              name to patch ORWT.
      
              * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      469c86e2
    • rniwa@webkit.org's avatar
      2011-06-27 Ryosuke Niwa <rniwa@webkit.org> · cf789009
      rniwa@webkit.org authored
              Rolled DEPS.
      
              * DEPS:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf789009
    • japhet@chromium.org's avatar
      2011-06-27 Nate Chapin <japhet@chromium.org> · 8009868d
      japhet@chromium.org authored
              Unreviewed, Chromium expectations update.
      
              * platform/chromium/fast/js/recursion-limit-equal-expected.txt: Rebaseline after r89842.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8009868d
    • adamk@chromium.org's avatar
      2011-06-27 Adam Klein <adamk@chromium.org> · 06593d85
      adamk@chromium.org authored
              Reviewed by Adam Barth.
      
              Fix filesystem-no-callback-null-ptr-crash.html test to reference proper file api methods
              https://bugs.webkit.org/show_bug.cgi?id=63486
      
              * fast/filesystem/filesystem-no-callback-null-ptr-crash.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06593d85
    • jcivelli@chromium.org's avatar
      2011-06-27 Jay Civelli <jcivelli@chromium.org> · 9fe2f6a6
      jcivelli@chromium.org authored
              Reviewed by Darin Fisher.
      
              Adding binary part support to MHTML.
              https://bugs.webkit.org/show_bug.cgi?id=63310
      
              * mhtml/multi_frames_binary.mht: Added.
              * platform/chromium/mhtml/multi_frames_binary-expected.txt: Added.
      2011-06-27  Jay Civelli  <jcivelli@chromium.org>
      
              Reviewed by Darin Fisher.
      
              Adding binary part support to MHTML.
              https://bugs.webkit.org/show_bug.cgi?id=63310
      
              * loader/archive/mhtml/MHTMLArchive.cpp:
              (WebCore::MHTMLArchive::generateMHTMLData):
              (WebCore::MHTMLArchive::generateMHTMLDataUsingBinaryEncoding):
              * loader/archive/mhtml/MHTMLArchive.h:
              * loader/archive/mhtml/MHTMLParser.cpp:
              (WebCore::MHTMLParser::parseNextPart):
              * platform/SharedBuffer.cpp:
              (WebCore::SharedBuffer::append):
              * platform/SharedBuffer.h:
              * platform/network/MIMEHeader.cpp:
              (WebCore::MIMEHeader::parseContentTransferEncoding):
              * platform/network/MIMEHeader.h:
      2011-06-27  Jay Civelli  <jcivelli@chromium.org>
      
              Reviewed by Darin Fisher.
      
              Adding binary part support to MHTML.
              https://bugs.webkit.org/show_bug.cgi?id=63310
      
              * public/WebPageSerializer.h:
              * src/WebPageSerializer.cpp:
              (WebKit::WebPageSerializer::serializeToMHTML):
              (WebKit::WebPageSerializer::serializeToMHTMLUsingBinaryEncoding):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9fe2f6a6
    • eric@webkit.org's avatar
      2011-06-27 Eric Seidel <eric@webkit.org> · 9ac7ad2f
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              new-run-webkit-tests needs a --webkit-test-runner option
              https://bugs.webkit.org/show_bug.cgi?id=63439
      
              NRWT doesn't actually know how to run with the WebKitTestRunner yet
              but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.
      
              There is a bunch of other little cleanup in this patch which I added as I
              took a tour through all of our hard-coded DumpRenderTree strings.
      
              * Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
              * Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
              * Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
              * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
              * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
              * Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
              * Scripts/webkitpy/layout_tests/port/config.py:
               - build_dumprendertree had no business in this class, removed it.
               - Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
               - Exposed _script_path as script_path() (this probably belongs elsewhere).
              * Scripts/webkitpy/layout_tests/port/config_unittest.py:
               - Moved these tests to webkit_unittests.
              * Scripts/webkitpy/layout_tests/port/webkit.py:
               - Now respects the --webkit-test-runner option.
               - setup_test_run is empty in base.py too, no need to override it.
              * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
               - Test the new hotness.
               - Bad, bad, bad!  The old code was using a real Executive during unit-testing!
                 I think this code is still hitting disk during the unit tests. :(
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
               - Add the option.
              * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
               - Remove optional args option.
              * Scripts/webkitpy/tool/commands/commandtest.py:
               - Remove optional args option.
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
               - Remove optional args option.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ac7ad2f
    • jeffm@apple.com's avatar
      Really fix the revision number in the last entry · 31871732
      jeffm@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31871732
    • jeffm@apple.com's avatar
      Fix revision number that I referenced in my last checkin · da6520d5
      jeffm@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da6520d5
    • jeffm@apple.com's avatar
      Web process always pauses on launch · 05b1a3ca
      jeffm@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=63487
              
      Reviewed by Oliver Hunt.
      
      In the absence of the WEBKIT2_PAUSE_WEB_PROCESS_ON_LAUNCH environment variable, only pause the web process on
      launch if the shift, control, and alt keys are all held down. This regressed in r89865, which always caused the
      web process to pause if the shift and alt keys were not held down.
      
      * WebProcess/WebKitMain.cpp:
      (pauseProcessIfNeeded): Add some parentheses.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05b1a3ca
    • leviw@chromium.org's avatar
      2011-06-27 Levi Weintraub <leviw@chromium.org> · 7781b6aa
      leviw@chromium.org authored
              Reviewed by Eric Seidel.
      
              Add support for unicode-bidi:plaintext CSS property
              https://bugs.webkit.org/show_bug.cgi?id=50949
              Adding support for the 'plaintext' mode of unicode-bidi.
      
              * fast/text/international/unicode-bidi-plaintext.html: Added.
              * platform/chromium-linux/fast/text/international/unicode-bidi-plaintext-expected.txt: added
              * platform/mac/fast/text/international/unicode-bidi-plaintext-expected.png: Added.
              * platform/mac/fast/text/international/unicode-bidi-plaintext-expected.txt: Added.
      2011-06-27  Levi Weintraub  <leviw@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Add support for unicode-bidi:plaintext CSS property
              https://bugs.webkit.org/show_bug.cgi?id=50949
      
              Adding support for unicode-bidi: plaintext. This involves invoking P2 and P3
              of the Unicode BiDi algorithm on each paragraph of a block with that style.
              This is similar to dir=auto but done per-paragraph instead of per element.
      
              Test: fast/text/international/unicode-bidi-plaintext.html
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue):  Added plaintext.
              * css/CSSPrimitiveValueMappings.h:
              (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Ditto.
              (WebCore::CSSPrimitiveValue::operator EUnicodeBidi): Ditto.
              * css/CSSValueKeywords.in: Ditto.
              * html/HTMLElement.cpp:
              (WebCore::unicodeBidiAttributeForDirAuto): Helper to map elements with dir=auto
              to their proper unicode-bidi attribute.
              (WebCore::HTMLElement::parseMappedAttribute): Assign plaintext to pre and textarea
              when dir=auto.
              * platform/text/UnicodeBidi.h: Added plaintext.
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::determineParagraphDirection): Determines the direction of a paragraph
              based on the first strong character. Stops at first paragraph separator.
              (WebCore::RenderBlock::layoutInlineChildren): Uses determineParagraphDirection
              when in unicode-bidi: plaintext mode (and operating at the block's BidiContext)
              to set each paragraph to the proper base BidiContext.
              (WebCore::RenderBlock::determineStartPosition): Ditto.
              * rendering/style/RenderStyle.h: Gave _unicodebidi another bit to accomodate
              for plaintext.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7781b6aa
    • jberlin@webkit.org's avatar
      Add Windows-specific results for the test added in r89745. · 97c078b7
      jberlin@webkit.org authored
      I checked these results with Rob - they are not failing expected results.
      
      * platform/win/svg/custom/linking-uri-01-b-expected.png: Added.
      * platform/win/svg/custom/linking-uri-01-b-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97c078b7
    • commit-queue@webkit.org's avatar
      2011-06-27 Wyatt Carss <wcarss@chromium.org> · 139fd522
      commit-queue@webkit.org authored
              Reviewed by Ryosuke Niwa.
      
              convert editing/deleting/whitespace-pre-1.html to dumpAsText
              https://bugs.webkit.org/show_bug.cgi?id=63372
      
              converted editing/deleting/whitespace-pre-1.html to dump-as-markup, removed
              old baselines, and added the new one.
      
              * editing/deleting/whitespace-pre-1-expected.txt: Added.
              * editing/deleting/whitespace-pre-1.html:
              * platform/chromium-linux/editing/deleting/whitespace-pre-1-expected.png: Removed.
              * platform/chromium-win/editing/deleting/whitespace-pre-1-expected.png: Removed.
              * platform/chromium-win/editing/deleting/whitespace-pre-1-expected.txt: Removed.
              * platform/gtk/editing/deleting/whitespace-pre-1-expected.png: Removed.
              * platform/gtk/editing/deleting/whitespace-pre-1-expected.txt: Removed.
              * platform/mac-leopard/editing/deleting/whitespace-pre-1-expected.png: Removed.
              * platform/mac/editing/deleting/whitespace-pre-1-expected.png: Removed.
              * platform/mac/editing/deleting/whitespace-pre-1-expected.txt: Removed.
              * platform/qt/editing/deleting/whitespace-pre-1-expected.png: Removed.
              * platform/qt/editing/deleting/whitespace-pre-1-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      139fd522
    • commit-queue@webkit.org's avatar
      2011-06-27 Filip Pizlo <fpizlo@apple.com> · 0df040ee
      commit-queue@webkit.org authored
              Reviewed by Gavin Barraclough.
      
              DFG JIT does not perform put_by_id caching.
              https://bugs.webkit.org/show_bug.cgi?id=63409
      
              * bytecode/StructureStubInfo.h:
              * dfg/DFGJITCodeGenerator.cpp:
              (JSC::DFG::JITCodeGenerator::cachedPutById):
              * dfg/DFGJITCodeGenerator.h:
              * dfg/DFGJITCompiler.cpp:
              (JSC::DFG::JITCompiler::compileFunction):
              * dfg/DFGJITCompiler.h:
              (JSC::DFG::JITCompiler::addPropertyAccess):
              (JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
              * dfg/DFGNonSpeculativeJIT.cpp:
              (JSC::DFG::NonSpeculativeJIT::compile):
              * dfg/DFGOperations.cpp:
              * dfg/DFGOperations.h:
              * dfg/DFGRepatch.cpp:
              (JSC::DFG::dfgRepatchByIdSelfAccess):
              (JSC::DFG::tryCacheGetByID):
              (JSC::DFG::appropriatePutByIdFunction):
              (JSC::DFG::tryCachePutByID):
              (JSC::DFG::dfgRepatchPutByID):
              * dfg/DFGRepatch.h:
              * dfg/DFGSpeculativeJIT.cpp:
              (JSC::DFG::SpeculativeJIT::compile):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0df040ee
    • alexis.menard@openbossa.org's avatar
      2011-06-27 Alexis Menard <alexis.menard@openbossa.org> · 2ef0005c
      alexis.menard@openbossa.org authored
              Reviewed by Darin Adler.
      
              Use specific headers includes rather than full system headers.
              https://bugs.webkit.org/show_bug.cgi?id=63475
      
              Use only needed headers rather than system headers.
      
              No new tests, it's just a little cosmetic change.
      
              * platform/mac/WebVideoFullscreenController.h:
              * platform/mac/WebVideoFullscreenHUDWindowController.h:
      2011-06-27  Alexis Menard  <alexis.menard@openbossa.org>
      
              Reviewed by Darin Adler.
      
              Use specific headers includes rather than full system headers.
              https://bugs.webkit.org/show_bug.cgi?id=63475
      
              Use only needed headers rather than system headers.
      
              * WebCoreSupport/QTKitFullScreenVideoHandler.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ef0005c
    • jberlin@webkit.org's avatar
      Add Windows-specific results for the test added in r89769. · 00b04757
      jberlin@webkit.org authored
      I checked these results with Dan - they are not failing expected results.
      
      * platform/win/fast/text/midword-break-before-surrogate-pair-expected.png: Added.
      * platform/win/fast/text/midword-break-before-surrogate-pair-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00b04757
    • abarth@webkit.org's avatar
      2011-06-27 Adam Barth <abarth@webkit.org> · 684ea071
      abarth@webkit.org authored
              Reviewed by Dirk Pranke.
      
              new-run-webkit-tests does not report stderr output
              https://bugs.webkit.org/show_bug.cgi?id=37739
      
              Almost all the infrastructure appears to be in place to report stderr
              in results.html.  We just need to wire up a bool to tell results.html
              to create the hyperlink.
      
              * Scripts/webkitpy/layout_tests/layout_package/manager.py:
              * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
              * Scripts/webkitpy/layout_tests/port/base.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      684ea071
    • abarth@webkit.org's avatar
      2011-06-27 Adam Barth <abarth@webkit.org> · 6dae420f
      abarth@webkit.org authored
              Reviewed by Dirk Pranke.
      
              webkitpy unit tests should have more descriptive names than just "Test"
              https://bugs.webkit.org/show_bug.cgi?id=63479
      
              Luckily we kept these classes in separate namespaces in the harness so
              we were actually running them all even though they had the same name.
      
              * Scripts/webkitpy/common/system/stack_utils_unittest.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6dae420f
    • joepeck@webkit.org's avatar
      2011-06-27 Joseph Pecoraro <joepeck@webkit.org> · 7c4810e8
      joepeck@webkit.org authored
              Reviewed by Darin Adler.
      
              Extract LineBreakIteratorPool class into its own file
              https://bugs.webkit.org/show_bug.cgi?id=63471
      
              * GNUmakefile.list.am:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              Add the new file to builds that used TextBreakIteratorPoolICU.h.
      
              * platform/text/LineBreakIteratorPoolICU.h: Added.
              (WebCore::LineBreakIteratorPool::sharedPool):
              (WebCore::LineBreakIteratorPool::LineBreakIteratorPool):
              Expose the constructor so it can be used by others.
      
              * platform/text/TextBreakIteratorICU.cpp:
              Remove the old LineBreakIteratorPool implementation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c4810e8
    • jberlin@webkit.org's avatar
      WebKitTestRunner needs an implemenation of allowRoundingHacks. · c5be1633
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=63477
      
      Add platform/mac/fast/text/rounding-hacks.html to the mac-wk2 skipped list to get the bots
      green.
      
      * platform/mac-wk2/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5be1633
    • leviw@chromium.org's avatar
      2011-06-27 Greg Simon <gregsimon@chromium.org> · 93305e62
      leviw@chromium.org authored
              No review necessary.
      
              Add email addr to contributor list
              https://bugs.webkit.org/show_bug.cgi?id=63478
      
              * Scripts/webkitpy/common/config/committers.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93305e62
    • commit-queue@webkit.org's avatar
      2011-06-27 Sheriff Bot <webkit.review.bot@gmail.com> · 1ae3af53
      commit-queue@webkit.org authored
              Unreviewed, rolling out r89834.
              http://trac.webkit.org/changeset/89834
              https://bugs.webkit.org/show_bug.cgi?id=63476
      
              Broke test-webkitpy (Requested by abarth on #webkit).
      
              * Scripts/webkitpy/common/net/layouttestresults.py:
              * Scripts/webkitpy/common/system/outputcapture.py:
              * Scripts/webkitpy/layout_tests/layout_package/manager.py:
              * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
              * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
              * Scripts/webkitpy/layout_tests/port/base.py:
              * Scripts/webkitpy/layout_tests/port/config.py:
              * Scripts/webkitpy/layout_tests/port/config_unittest.py:
              * Scripts/webkitpy/layout_tests/port/webkit.py:
              * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
              * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
              * Scripts/webkitpy/tool/commands/commandtest.py:
              * Scripts/webkitpy/tool/commands/queues_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ae3af53
    • jeffm@apple.com's avatar
      2011-06-27 Jeff Miller <jeffm@apple.com> · df85c228
      jeffm@apple.com authored
              Reviewed by Adam Roben.
      
              Stop copying obsolete WebKit libraries on Windows
              https://bugs.webkit.org/show_bug.cgi?id=63474
              
              Don't copy obsolete WebKit library directories and files on Windows, they no longer exist and just generate extraneous warnings. These include the CharacterSets directory, dnssd.dll, and icudt40.dll.
      
              * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
              * MiniBrowser/MiniBrowserPostBuild.cmd:
              * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df85c228
    • inferno@chromium.org's avatar
      2011-06-27 Abhishek Arya <inferno@chromium.org> · 7e7706fa
      inferno@chromium.org authored
              Unreviewed.
      
              Chromium rebaselines for my commit r89836.
      
              * platform/chromium-linux/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
              * platform/chromium-linux/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
              * platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
              * platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
              * platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
              * platform/chromium-linux/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
              * platform/chromium-linux/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
              * platform/chromium-linux/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
              * platform/chromium-linux/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
              * platform/chromium-linux/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
              * platform/chromium-linux/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
              * platform/chromium-linux/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
              * platform/chromium-mac-leopard/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
              * platform/chromium-mac-leopard/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
              * platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
              * platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
              * platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
              * platform/chromium-mac-leopard/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
              * platform/chromium-mac-leopard/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
              * platform/chromium-mac-leopard/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
              * platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
              * platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
              * platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
              * platform/chromium-mac-leopard/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
              * platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png: Added.
              * platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.txt: Added.
              * platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png: Added.
              * platform/chromium-win/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.txt: Added.
              * platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.png: Added.
              * platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position-expected.txt: Added.
              * platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.png: Added.
              * platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-absolute-position2-expected.txt: Added.
              * platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.png: Added.
              * platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position-expected.txt: Added.
              * platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.png: Added.
              * platform/chromium-win/fast/block/float/intruding-float-remove-from-sibling-block-on-fixed-position2-expected.txt: Added.
              * platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block-expected.png: Added.
              * platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block-expected.txt: Added.
              * platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png: Added.
              * platform/chromium-win/fast/block/float/overhanging-float-add-in-static-position-block2-expected.txt: Added.
              * platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png: Added.
              * platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.txt: Added.
              * platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png: Added.
              * platform/chromium-win/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.txt: Added.
              * platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.png: Added.
              * platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block-expected.txt: Added.
              * platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.png: Added.
              * platform/chromium-win/fast/block/float/overhanging-float-remove-from-fixed-position-block2-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e7706fa
    • rniwa@webkit.org's avatar
      2011-06-27 Ryosuke Niwa <rniwa@webkit.org> · 96c61ef5
      rniwa@webkit.org authored
              Add Wyatt Carss to the list of non-committer contributors.
      
              * Scripts/webkitpy/common/config/committers.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96c61ef5
    • justin.garcia@apple.com's avatar
      2011-06-27 Justin Garcia <justin.garcia@apple.com> · 065ec8ca
      justin.garcia@apple.com authored
              Reviewed by Ryosuke Niwa.
      
              CompositeEditCommand::inputText(const String& text, bool selectedInsertText) is unused
              https://bugs.webkit.org/show_bug.cgi?id=62921
      
              * editing/CompositeEditCommand.cpp:
              * editing/CompositeEditCommand.h:
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::input):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      065ec8ca
    • abarth@webkit.org's avatar
      2011-06-27 Adam Barth <abarth@webkit.org> · bdfd8c42
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              webkitpy should understand crash logs
              https://bugs.webkit.org/show_bug.cgi?id=63468
      
              We're planning to use this functionality to upload crash logs along
              with test results for new-run-webkit-tests.
      
              * Scripts/webkitpy/common/system/crashlog.py: Added.
              * Scripts/webkitpy/common/system/crashlog_unittest.py: Added.
              * Scripts/webkitpy/common/system/executive.py:
              * Scripts/webkitpy/common/system/executive_unittest.py:
              * Scripts/webkitpy/common/system/filesystem.py:
              * Scripts/webkitpy/common/system/filesystem_mock.py:
              * Scripts/webkitpy/tool/commands/queries.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@89843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bdfd8c42