1. 14 Oct, 2006 1 commit
    • bdash's avatar
      2006-10-14 Krzysztof Kowalczyk <kkowalczyk@gmail.com> · e0bfe232
      bdash authored
              Reviewed by Maciej.
      
              Define KXMLCORE_USE_CURL for platforms that wish to use CURL as
              networking, and set it for GDK build
      
              * wtf/Platform.h:
      
      2006-10-14  Krzysztof Kowalczyk  <kkowalczyk@gmail.com>
      
              Reviewed by Maciej.
      
              Fix GDK build by defining FrameGdkClient() constructor as non-virtual.
              Pure virtual classes require non-pure destructor, who knew.
      
              Make CURL networking dependent on USE(CURL) instead of PLATFORM(GDK),
              so that other platforms can also use CURL, if they wish.
      
              Silence compiler warning about unused variable in SharedTimerLinux.cpp
      
              * platform/ResourceLoaderInternal.h:
              (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
              * platform/gdk/FrameGdk.h:
              (WebCore::FrameGdkClient::~FrameGdkClient):
              * platform/gdk/ResourceLoaderManager.cpp:
              (WebCore::ResourceLoaderManager::downloadTimerCallback):
              * platform/gdk/SharedTimerLinux.cpp:
              (WebCore::stopSharedTimer):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0bfe232
  2. 13 Oct, 2006 26 commits
    • bdakin's avatar
      Reviewed by Geoff. · 8a2bb060
      bdakin authored
              Build fix from my last check-in. Make hasOutlineAnnotation() non-
              inline so that we don't have to include Document.h in 
              RenderObject.h
              Doing so causes a build failure in WebKit, and it probably isn't a 
              good idea anyway.
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::hasOutlineAnnotation):
              * rendering/RenderObject.h:
              (WebCore::RenderObject::hasOutline):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a2bb060
    • ggaren's avatar
      Reviewed by Beth. · f1dbe6ac
      ggaren authored
              
              Split build, run, and debug steps into separate pages. Darin recommended
              this a while back.
      
              * building/build.html:
              * building/checkout.html:
              * building/debug.html: Added.
              * building/run.html: Added.
              * nav.inc:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1dbe6ac
    • bdakin's avatar
      Patch written mostly by Ken Kraisler, but also by me. · 6e760ffb
      bdakin authored
              Reviewed by Hyatt.
      
              Fix for http://bugs.webkit.org/show_bug.cgi?id=10216 and <rdar://
              problem/3391162> PDF created by printing should have live 
              hyperlinks
      
              * platform/GraphicsContext.cpp:
              (WebCore::GraphicsContext::focusRingBoundingRect):
              * platform/GraphicsContext.h:
              * platform/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::setURLForRect):
              * platform/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::setURLForRect): Implement method to add 
              URL link to PDF document.
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::paint): Ask hasOutline() instead of 
              querying the outline width
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintObject): Same as above.
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::paintLines): Call the new paintOutline()
              (WebCore::RenderFlow::paintOutline): Take care of focus ring and 
              pdf url rects, and outline painting.
              * rendering/RenderFlow.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::addPDFURLRect): Declaration to apply a PDF 
              link to a rectanglular region.
              (WebCore::RenderObject::paintOutline): Take care of pdf rects as 
              well as focus ring painting.
              * rendering/RenderObject.h:
              (WebCore::RenderObject::hasOutlineAnnotation): Returns true is the 
              element is a link and we are printing.
              (WebCore::RenderObject::hasOutline): Returns true is the style has 
              an outline and hasOutlineAnnotation() is true.
              * rendering/RenderStyle.h:
              (WebCore::RenderStyle::hasOutline): Returns true if outlineWidth is 
              greater than 0 and outlineStyle is greater than BHIDDEN.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e760ffb
    • justing's avatar
      LayoutTests: · 9763f319
      justing authored
              Reviewed by ggaren and harrison
              
              <rdar://problem/4744008>
              9A270: Mail crashes when I try to paste large items from Safari
              
              * editing/pasteboard/4744008-expected.txt: Added.
              * editing/pasteboard/4744008.html: Added.
      
      WebCore:
      
              Reviewed by ggaren and harrison
              
              <rdar://problem/4744008>
              9A270: Mail crashes when I try to paste large items from Safari
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
              Even though we put nodes in the hash map in pre-order, they don't necessary
              come out of the iterator that way.  If a node is a redundant style span
              and one of its pruned ancestors comes off the hash map after it, and that
              ancestor is a redundant style span or font tag, we will try to remove it
              even though it has already been removed and we'll crash.
              The test case added with the fix depends on our hash map implementation
              because it requires that a particular redundant style span come out of 
              the iterator before its parent. So, it may eventually not provide 
              coverage for the fix.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9763f319
    • mjs's avatar
      Reviewed by Darin. · 159df82d
      mjs authored
              - split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/kjs_window.cpp:
              (KJS::createNewWindow):
              (KJS::WindowFunc::callAsFunction):
              * bridge/BrowserExtension.h:
              * bridge/mac/BrowserExtensionMac.h:
              * bridge/mac/BrowserExtensionMac.mm:
              (WebCore::BrowserExtensionMac::createNewWindow):
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::submitForm):
              (WebCore::FrameMac::openURLRequest):
              (WebCore::FrameMac::urlSelected):
              * bridge/win/BrowserExtensionWin.h:
              * page/Frame.cpp:
              (WebCore::Frame::changeLocation):
              (WebCore::Frame::urlSelected):
              (WebCore::Frame::requestFrame):
              (WebCore::Frame::submitForm):
              * page/Frame.h:
              * page/FrameLoadRequest.h: Added.
              (WebCore::FrameLoadRequest::FrameLoadRequest):
              (WebCore::FrameLoadRequest::lockHistory):
              (WebCore::FrameLoadRequest::setLockHistory):
              * page/ResourceRequest.h:
              (WebCore::ResourceRequest::ResourceRequest):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      159df82d
    • sullivan's avatar
      Reviewed by Maciej · 9118e5a7
      sullivan authored
              * loader/mac/WebFrameLoader.mm:
              (-[WebFrameLoader loadDocumentLoader:]):
              Replace ASSERT(!policyDocumentLoader) with code that handles this case. This can
              happen when loading a page during a decidePolicyForNavigationAction callback.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9118e5a7
    • mjs's avatar
      Not reviewed, build fix. · 064f0b51
      mjs authored
              
              * icu/unicode/putil.h: Added - needed for build if you don't have apple internal headers.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      064f0b51
    • mjs's avatar
      Not reviewed, build fix. · 83593159
      mjs authored
              
              * icu/unicode/ustring.h: Added - needed for build if you don't have apple internal headers.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83593159
    • hyatt's avatar
      Transparency layer work. · d3b68ca5
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3b68ca5
    • mjs's avatar
      Reviewed by Anders. · c34d8df3
      mjs authored
              
              - add a bunch of casts to get this compiling with older Xcode versions
              
              (I used static_cast so it will be easier to find and remove these once we have completely moved
              on to a new enough compiler version.)
      
              * Plugins/WebBaseNetscapePluginView.m:
              (+[WebBaseNetscapePluginView getCarbonEvent:]):
              (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]):
              (-[WebBaseNetscapePluginView fixWindowPort]):
              (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
              (-[WebBaseNetscapePluginView _createWindowlessAGLContext]):
              (-[WebBaseNetscapePluginView _reshapeAGLWindow]):
              (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c34d8df3
    • rwlbuis's avatar
      Reviewed by Mitz. · 60957636
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=11217
              Cleanup svg coding style
      
              Cleanup coding style in svg paint server classes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60957636
    • ggaren's avatar
      LayoutTests: · 31614e2f
      ggaren authored
              Tests for accessing renderer-dependent properties from a javascript: URL.
              
              * fast/frames/frame-js-url-clientWidth-expected.txt: Added.
              * fast/frames/frame-js-url-clientWidth.html: Added.
              * fast/frames/iframe-js-url-clientWidth-expected.txt: Added.
              * fast/frames/iframe-js-url-clientWidth.html: Added.
      
      WebCore:
      
              Reviewed by Darin, John.
      
              - Merged more frame and iframe code
              - Fixed a bug where iframes returned incorrect values for renderer-dependent 
              properties during javascript: loads because they didn't have renderers at 
              load time
              
              PLT insists this is a small performance win. Don't believe its lies.
      
              * bindings/js/kjs_html.cpp:
              (KJS::JSHTMLElement::frameGetter): Renamed frameWidth and frameHeight to
              width and height, for consistency with the rest of the DOM.
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::queuePostAttachCallback): Added a post-attach callback
              queue that gets drained after the render tree is fully constructed. Currently,
              this is only used for frame loading.
              (WebCore::ContainerNode::attach):
              * dom/ContainerNode.h:
              * html/HTMLFrameElement.cpp:
              (WebCore::HTMLFrameElement::insertedIntoDocument): Removed frame loading from
              attach() because loading iframes during attach() causes a crash. 
              Moved frame loading logic into insertedIntoDocument(). That's a more 
              logical place for it because  document insertion is what 
              triggers frame loading. Made frame loading a post-attach callback, instead
              of an immediate action, to fix the incorrect values bug.
              (WebCore::HTMLFrameElement::attach): Added setWidget call that used to be
              in HTMLIFrameElement::attach. IFRAME requires this call. FRAME will soon 
              require this call, once I remove the call from WebKit.
              (WebCore::HTMLFrameElement::setLocation):
              (WebCore::HTMLFrameElement::width):
              (WebCore::HTMLFrameElement::height):
              * html/HTMLFrameElement.h: Made openURL non-virtual to avoid the unnecessary
              killing of puppies.
              * html/HTMLIFrameElement.cpp: Merged code into HTMLFrameElement
              (WebCore::HTMLIFrameElement::rendererIsNeeded):
              (WebCore::HTMLIFrameElement::createRenderer):
              (WebCore::HTMLIFrameElement::insertedIntoDocument):
              (WebCore::HTMLIFrameElement::removedFromDocument):
              (WebCore::HTMLIFrameElement::attach):
              * page/FrameView.h: Removed unused method.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31614e2f
    • rwlbuis's avatar
      Reviewed by Eric. · 26d03c90
      rwlbuis authored
              Force --no-http on Qt/Linux.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26d03c90
    • rwlbuis's avatar
      2d0b4758
    • kmccullo's avatar
      Reviewed by Kevin McCullough. · dee1af24
      kmccullo authored
              Fixes http://bugs.webkit.org/show_bug.cgi?id=11283
              Fixes Qt/Linux and Windows build
      
              * kjs/DateMath.cpp:
              * kjs/DateMath.h:
              * kjs/date_object.cpp:
              (KJS::DateProtoFunc::callAsFunction):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dee1af24
    • harrison's avatar
      LayoutTests: · 6b7c5c2d
      harrison authored
              Reviewed by Justin.
      
              <rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)
      
              * editing/style/style-boundary-005.html: Added. Matches steps from bug.
              * editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
              * editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
              * editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
              * editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).
      
      WebCore:
      
              Reviewed by Justin.
      
              <rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)
      
              Tests added or changed:
              * editing/style/style-boundary-005.html: Added. Matches steps from bug.
              * editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
              * editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
              * editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
              * editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).
      
              * dom/Text.cpp:
              (WebCore::Text::splitText):
              Comment changes.
              
              * editing/ApplyStyleCommand.cpp:
              (WebCore::isUnstyledStyleSpan):
              Renamed from isEmptyStyleSpan.
              
              (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
              Rename emptySpans local to unstyledSpans.
              
              (WebCore::dummySpanAncestorForNode):
              New. To locate Apple style span created when splitting a text node.
              
              (WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):
              Renamed from cleanUpEmptyStyleSpans. Algorithm changed to scan children
              of dummy span's parents, rather than traversing up from start and
              end locations. Old algorithm would miss empty spans in the bug case.
              
              (WebCore::ApplyStyleCommand::applyInlineStyle):
              Use dummySpanAncestorForNode() and cleanupUnstyledAppleStyleSpans().
              
              (WebCore::ApplyStyleCommand::removeCSSStyle):
              Renamed isEmptyStyleSpan() to isUnstyledStyleSpan().
              
              (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
              Comment changes.
              
              * editing/ApplyStyleCommand.h:
              Renamed cleanUpEmptyStyleSpans() to cleanupUnstyledAppleStyleSpans().
                
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
              Allow for Apple style span to be unstyled, because old email may have this in the DOM.
              Use !node->hasChildNodes() instead of !node->firstChild().
              
              * editing/SplitTextNodeCommand.cpp:
              (WebCore::SplitTextNodeCommand::doApply):
              Comment changes.
              
              * rendering/RenderTreeAsText.cpp:
              (WebCore::isEmptyOrUnstyledAppleStyleSpan):
              (WebCore::operator<<):
              Flag empty or unstyled AppleStyleSpa nbecause we never want to leave them in the DOM
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b7c5c2d
    • rwlbuis's avatar
      06ed7178
    • adele's avatar
      Reviewed by Eric. · 11988cff
      adele authored
              Fix Qt/Linux build after Adele's popup menu changes.
      
              * CMakeLists.txt:
              * platform/qt/FileChooserQt.cpp:
              (WebCore::FileChooser::disconnectUploadControl):
              * platform/qt/PopupMenuQt.cpp: Added.
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::clear):
              (WebCore::PopupMenu::populate):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::addSeparator):
              (WebCore::PopupMenu::addGroupLabel):
              (WebCore::PopupMenu::addOption):
              * platform/qt/RenderPopupMenuQt.cpp: Removed.
              * platform/qt/RenderPopupMenuQt.h: Removed.
              * platform/qt/RenderThemeQt.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11988cff
    • kmccullo's avatar
      Reviewed by Adam. · 35aecd6b
      kmccullo authored
              Gets JavaScripCore tests running on windows.
      
              * Scripts/run-javascriptcore-tests:
              * Scripts/webkitdirs.pm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35aecd6b
    • kmccullo's avatar
      Reviewed by Darin. · aa6252b3
      kmccullo authored
              fixed build failure 
      
              * WebCore.xcodeproj/project.pbxproj:
              * loader/mac/WebFrameLoader.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa6252b3
    • kmccullo's avatar
      Reviewed by Adam, Geoff, Darin. · a1376154
      kmccullo authored
             Fixed displaying the UTC offset and time zone string, as well as renamed the GregorianDateTime structure and clean up. 
      
              * ChangeLog:
              * kjs/DateMath.cpp:
              (KJS::getUTCOffset):
              (KJS::getDSTOffsetSimple):
              (KJS::gregorianDateTimeToMS):
              (KJS::msToGregorianDateTime):
              * kjs/DateMath.h:
              (KJS::GregorianDateTime::GregorianDateTime):
              (KJS::GregorianDateTime::~GregorianDateTime):
              (KJS::GregorianDateTime::toTM):
              * kjs/date_object.cpp:
              (KJS::gmtoffset):
              (KJS::formatDate):
              (KJS::formatDateUTCVariant):
              (KJS::formatTime):
              (KJS::fillStructuresUsingTimeArgs):
              (KJS::fillStructuresUsingDateArgs):
              (KJS::DateInstance::getTime):
              (KJS::DateInstance::getUTCTime):
              (KJS::DateProtoFunc::callAsFunction):
              (KJS::DateObjectImp::construct):
              (KJS::DateObjectImp::callAsFunction):
              (KJS::DateObjectFuncImp::callAsFunction):
              (KJS::parseDate):
              * kjs/date_object.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1376154
    • kmccullo's avatar
      Changed by Darin, reviewed by me. · 0e3565ed
      kmccullo authored
              * Plugins/WebNetscapePluginStream.m: Fixed case of import so we can compile on
              case-sensitive file system.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e3565ed
    • darin's avatar
      WebCore: · 9ab4ef2b
      darin authored
              Reviewed by Adele.
      
              - converted WebFormState from Objective-C to C++
      
              * WebCore.exp: Added a new symbol, changed one symbol from C to C++.
      
              * WebCore.xcodeproj/project.pbxproj: Made lots of headers "private" instead of "project".
              Added UChar.h and FrameLoaderTypes.h.
      
              * loader/FrameLoaderTypes.h: Added. Has enums from WebFrameLoader.h.
      
              * loader/mac/WebFormState.h: Converted class to C++.
              * loader/mac/WebFormState.mm: Ditto.
      
              * loader/mac/WebFrameLoader.h:
              * loader/mac/WebFrameLoader.mm:
              (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
              (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]):
              (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
              (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]):
              (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]):
              (-[WebFrameLoader continueAfterNewWindowPolicy:]):
              (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]):
              (-[WebFrameLoader continueAfterNavigationPolicy:]):
              (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]):
              (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]):
              (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]):
              (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
              Changed Objective-C WebFormState uses to C++ WebCore::FormState.
      
      WebKit:
      
              Reviewed by Adele.
      
              - converted WebFormState from Objective-C to C++
      
              * ForwardingHeaders: Added an entire copy of WebCore's forwarding headers here.
              We should eventually come up with a more-elegant solution.
      
              * WebKit.xcodeproj/project.pbxproj: Added ForwardingHeaders to the include paths.
              Converted many files from Objective-C to Objective-C++. In a later check-in, I'll
              rename them to .mm instead of .m. Removed C-only warning options for now. In a
              later check-in I will add these back in a way that omits them for C++.
      
              * Plugins/WebPluginContainerCheck.m: Updated for header changes.
      
              * WebView/WebFrameInternal.h: Updated for header changes. Removed WebFrameLoaderClient category
              so this file can still be used by Objective-C code (not just Objective-C++).
      
              * WebView/WebFrame.m: Put WebFrameLoaderClient category in here.
              (-[WebFrame _loadItem:withLoadType:]): Changed to use 0 instead of nil for FormState and fixed
              enum code for C++ compatibility.
              (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added call to setFrameLoaderClient: here.
              (-[WebFrame _updateHistoryForCommit]): Fixed enum code for C++ compatibility.
              (-[WebFrame _updateHistoryForReload]): Ditto.
      
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Removed call to setFrameLoaderClient:.
              (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto.
              (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Fixed enum code for C++ compatibility.
              (-[WebFrameBridge runModal]): Changed code to not use "namespace" as a local variable name.
      
              * WebView/WebPDFView.m: Added extern "C" so this can compile as Objective-C++.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9ab4ef2b
    • adele's avatar
      Reviewed by Maciej. · d08517f2
      adele authored
              - Fix for <rdar://problem/4768591> REGRESSION: List box selection color should just be a darker version of regular selection color
      
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::paintItemForeground):
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
              (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
              (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
              (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
              * rendering/RenderThemeMac.h:
              * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d08517f2
    • rwlbuis's avatar
      Reviewed by Mitz. · 7ccc98a6
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=11217
              Cleanup svg coding style
      
              Cleanup coding style in svg structure classes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ccc98a6
    • adele's avatar
      LayoutTests: · 65d91c70
      adele authored
              Reviewed by Anders.
      
              - Test for http://bugs.webkit.org/show_bug.cgi?id=11172
                REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/
      
              * fast/forms/listbox-width-change-expected.txt: Added.
              * fast/forms/listbox-width-change-expected.png: Added.
              * fast/forms/listbox-width-change-expected.checksum: Added.
              * fast/forms/listbox-width-change.html: Added.
      
      WebCore:
      
              Reviewed by Anders.
      
              - Fix for http://bugs.webkit.org/show_bug.cgi?id=11172
                REGRESSION (NativeListBox): OPTION text paints over the edge of the select element at http://jobs.apple.com/
              
               Test: fast/forms/listbox-width-change.html
      
              * rendering/RenderListBox.cpp: (WebCore::RenderListBox::updateFromElement):
                When the options change, call setNeedsLayoutAndMinMaxRecalc.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65d91c70
  3. 12 Oct, 2006 13 commits
    • mjs's avatar
      WebCore: · 16a7cee0
      mjs authored
              Reviewed by Oliver.
      
              - moved a bunch of WebFrameBridge code down to WebCoreFrameBridge, now that it no longer has any WebKit dependencies
      
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (stringByCollapsingNonPrintingCharacters):
              (-[WebCoreFrameBridge setTitle:]):
              (-[WebCoreFrameBridge didFirstLayout]):
              (-[WebCoreFrameBridge notifyIconChanged:]):
              (-[WebCoreFrameBridge originalRequestURL]):
              (-[WebCoreFrameBridge isLoadTypeReload]):
              (-[WebCoreFrameBridge frameDetached]):
              (-[WebCoreFrameBridge tokenizerProcessedData]):
              (-[WebCoreFrameBridge receivedData:textEncodingName:]):
              (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
              (-[WebCoreFrameBridge objectLoadedFromCacheWithURL:response:data:]):
              (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
              (-[WebCoreFrameBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
              (-[WebCoreFrameBridge reportClientRedirectCancelled:]):
              (-[WebCoreFrameBridge loadURL:referrer:reload:userGesture:target:triggeringEvent:form:formValues:]):
              (-[WebCoreFrameBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]):
              (-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
              (-[WebCoreFrameBridge incomingReferrer]):
              (-[WebCoreFrameBridge isReloading]):
              (-[WebCoreFrameBridge handledOnloadEvents]):
              (-[WebCoreFrameBridge mainResourceURLResponse]):
              (-[WebCoreFrameBridge loadEmptyDocumentSynchronously]):
              * loader/mac/LoaderNSURLExtras.h:
              * loader/mac/LoaderNSURLRequestExtras.h: Added.
              * loader/mac/LoaderNSURLRequestExtras.m: Added.
              (isConditionalRequest):
              (setHTTPReferrer):
              * loader/mac/WebFrameLoader.mm:
              * loader/mac/WebSubresourceLoader.mm:
      
      WebKit:
      
              Reviewed by Oliver.
              
              - liberate more WebKit code down to WebCore
      
              * WebCoreSupport/WebFrameBridge.h:
              * WebCoreSupport/WebFrameBridge.m:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16a7cee0
    • adele's avatar
      RS by Geoff. · 2f3613b4
      adele authored
              Renamed menuListIsDetaching to disconnectMenuList, 
              uploadControlDetaching to disconnectUploadControl, and fileChooserDetachingSoon to disconnectFileChooser.  
              These names match similar methods in WebCore a little better.
      
              * platform/FileChooser.h:
              * platform/PopupMenu.h: (WebCore::PopupMenu::disconnectMenuList):
              * platform/mac/FileChooserMac.mm: (-[OpenPanelController disconnectFileChooser]):
              (WebCore::FileChooser::disconnectUploadControl):
              * platform/win/TemporaryLinkStubs.cpp: (FileChooser::disconnectUploadControl):
              * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::~RenderFileUploadControl):
              * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f3613b4
    • adele's avatar
      WebCore: · bac8761d
      adele authored
              Reviewed by Maciej.
      
              WebCore part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML
      
              Added private delegate method for clients that want access to a PopupMenu's NSMenu.
      
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm: (WebCore::FrameMac::willPopupMenu):
              * bridge/mac/WebCoreFrameBridge.h:
      
              * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Calls willPopupMenu with the NSMenu about to be popped up.
      
      WebKit:
      
              Reviewed by Maciej.
      
              WebKit part of fix for <rdar://problem/4450613> need a means to attach user data to any menu that is popuped up in HTML
      
              Added private delegate method for clients that want access to a PopupMenu's NSMenu.
      
              * DefaultDelegates/WebDefaultUIDelegate.m: (-[NSApplication webView:willPopupMenu:]):
              * WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge willPopupMenu:]):
              * WebView/WebUIDelegatePrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bac8761d
    • adele's avatar
      Reviewed by Alice. · 7c051086
      adele authored
              - Fix for <rdar://problem/4707372> 
                After timers fix, crash in -[NSMenu performActionForItemAtIndex:] after moving/detroying active popup menu
      
              * platform/PopupMenu.h: (WebCore::PopupMenu::menuListIsDetaching): Added. Zeros out the pointer to the menu list.
              * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls menuListIsDetaching.
              * platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show): Added a RefPtr to protect the PopupMenu while the NSMenu is up,
                in case the RenderMenuList goes away.  Also, checks the pointer to the menu list immediately afterwards.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c051086
    • bdash's avatar
      2006-10-12 Nikolas Zimmermann <zimmermann@kde.org> · 6d5e3d2c
      bdash authored
              Reviewed by Maciej.
      
              Exclude some tests which crash or hang from Qt/Linux DRT.
              These are known to fail, and will be fixed at some point :-)
      
              * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp:
              (WebCore::DumpRenderTree::DumpRenderTree):
              (WebCore::DumpRenderTree::open):
              (WebCore::DumpRenderTree::readStdin):
              (WebCore::DumpRenderTree::readSkipFile):
              (WebCore::DumpRenderTree::checkLoaded):
              * DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
              * DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d5e3d2c
    • bdash's avatar
      2006-10-12 Nikolas Zimmermann <zimmermann@kde.org> · e2617412
      bdash authored
              Reviewed by Maciej.
      
              Trying to fix "DRT hangs on certain testcases" like fast/dom/Document/document-reopen.html
              document.open(); document.write(..); and NO document.close(). On the Qt platform this
              leaves a HTMLDocument which is still in parsing mode (parsing() always returns true).
              DRT waits forever, but m_frame->isComplete() is never true due the parsing mode problem.
      
              Hmpf, this took me nine hours to debug today.
              Result: Couldn't find the real fix, going for a workaround for now.
              
              540 minutes, 1 line of code changed after all -> 0,0019 lines per minute.
      
              * platform/qt/FrameQt.cpp:
              (WebCore::FrameQt::handledOnloadEvents): Call endIfNotLoading() manually.
              * platform/qt/FrameQtClient.cpp:
              (WebCore::FrameQtClientDefault::receivedData): Use write() again instead of addData().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2617412
    • aroben's avatar
      Reviewed by Adele. · 77a68e52
      aroben authored
              Move popup menu code out of rendering/ and into platform/.
              RenderPopupMenu becomes PopupMenu, the
              RenderPopupMenuMac/RenderPopupMenuWin subclasses and all the associated
              virtual methods go away, RenderTheme gets to stop worrying about popup
              menus, PopupMenu becomes ref-counted, and everyone becomes happy.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj: Move files within project.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * html/HTMLSelectElement.cpp: Remove unnecessary #include.
              * platform/PopupMenu.cpp: Moved from rendering/RenderPopupMenu.cpp.
              Also renamed showPopup()/hidePopup() to show()/hide() to disambiguate
              from RenderMenuList::showPopup/hidePopup.
              (WebCore::PopupMenu::create): New static creation method to hand back a
              PassRefPtr<PopupMenu>.
              (WebCore::PopupMenu::addItems): This platform-independent method should
              be called by PopupMenu::populate when the platform-specific
              implementation is ready to receive the menu items. Fixed an ASSERT
              while I was at it.
              * platform/PopupMenu.h: Moved from rendering/RenderPopupMenu.h. No more
              need for virtual methods.
              (WebCore::PopupMenu::wasClicked):
              (WebCore::PopupMenu::setWasClicked):
              (WebCore::PopupMenu::popupHandle):
              * platform/mac/PopupMenuMac.mm: Moved from
              rendering/RenderPopupMenuMac.mm. Much renaming ensues.
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::clear):
              (WebCore::PopupMenu::populate):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::addSeparator):
              (WebCore::PopupMenu::addGroupLabel): Since we don't have our own
              RenderStyle anymore, just pick up the style from our RenderMenuList.
              (WebCore::PopupMenu::addOption): Ditto.
              * platform/win/TemporaryLinkStubs.cpp: Rename-fest.
              (PopupMenu::PopupMenu):
              (PopupMenu::~PopupMenu):
              (PopupMenu::clear):
              (PopupMenu::populate):
              (PopupMenu::show):
              (PopupMenu::hide):
              (PopupMenu::addSeparator):
              (PopupMenu::addGroupLabel):
              (PopupMenu::addOption):
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::~RenderMenuList):
              (WebCore::RenderMenuList::showPopup): Use nice new simple
              PopupMenu::create to make the popup.
              (WebCore::RenderMenuList::hidePopup):
              * rendering/RenderMenuList.h: Hold a RefPtr<PopupMenu> instead of a
              RenderPopupMenu*.
              (WebCore::RenderMenuList::popup):
              * rendering/RenderPopupMenu.cpp: Removed.
              * rendering/RenderPopupMenu.h: Removed.
              * rendering/RenderPopupMenuMac.h: Removed.
              * rendering/RenderPopupMenuMac.mm: Removed.
              * rendering/RenderPopupMenuWin.h: Removed.
              * rendering/RenderTheme.cpp: Get rid of createPopupMenu() method.
              * rendering/RenderTheme.h: Ditto.
              * rendering/RenderThemeMac.h: Ditto.
              * rendering/RenderThemeMac.mm: Ditto.
              * rendering/RenderThemeWin.cpp: Ditto.
              * rendering/RenderThemeWin.h: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77a68e52
    • adele's avatar
      Reviewed by Dave Harrison. · 9a5b6071
      adele authored
              - Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)
      
              * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout):
              Make subtree layouts work for textareas as well as text fields.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a5b6071
    • ggaren's avatar
      Reviewed by Maciej. · 20b23b1e
      ggaren authored
              
              Removed JSObjectMakeWithPrototype, clarified some comments. We really
              don't want people to manage their own prototypes, so we don't want an
              extra function in the API devoted to just that. People can still manage
              their own prototypes if they really want by using JSObjectSetPrototype.
      
              * API/JSClassRef.cpp:
              (OpaqueJSClass::createNoAutomaticPrototype):
              (OpaqueJSClass::create):
              * API/JSClassRef.h:
              * API/JSObjectRef.cpp:
              (JSClassCreate):
              (JSObjectMake):
              * API/JSObjectRef.h:
              * API/testapi.c:
              (main):
              * JavaScriptCore.exp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20b23b1e
    • rwlbuis's avatar
      Reviewed by MacDome. · bfc8bffa
      rwlbuis authored
              Finally found a way to remove our begin() trickery in FrameQt.
              The (probably misnamed) Frame::setEncoding() function automatically
              calls Frame::receivedFirstData() which calls being on the working
              url, which has been passed to didOpenUrl(). Took me some hours
              to figure out that the missing charset logic, forced us to do hacks.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfc8bffa
    • kmccullo's avatar
      Reviewed by Adam. · d1f6f7a7
      kmccullo authored
              Build breakage fix
      
              * kjs/DateMath.cpp:
              (KJS::msToTM):
              * kjs/date_object.cpp:
              (KJS::gmtoffset):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1f6f7a7
    • aroben's avatar
      Reviewed by Hyatt. · 7c77dd17
      aroben authored
              Bandaid-ing a null-dereference crash until a real fix is made.
      
              * page/FrameView.cpp:
              (WebCore::FrameView::windowClipRect):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c77dd17
    • aroben's avatar
      2006-10-12 MorganL <morganl.webkit@yahoo.com> · 854d34d8
      aroben authored
              Reviewed/landed by Adam.
      
              Fixes http://bugs.webkit.org/show_bug.cgi?id=11264
              Windows build busted
      
              * COM/WebFrame.cpp:
              (WebFrame::receivedResponse):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      854d34d8