GitLab

        CSS @import statements can cause DocLoader to use
        a dead Frame pointer.
        https://bugs.webkit.org/show_bug.cgi?id=19618

        The fix is to get rid of the Frame pointer on DocLoader.

        I also took this opportunity to clean up Document::detach
        a little to make it clear why we clear the m_frame pointer
        there, and to note that in the future we should stop
        using Node::detach to mean "tear down the whole rendering
        tree and detach from the frame".

        Test: I don't know how to make a good test for this, the test
        we have is network timing dependent and does not make a good
        layout test.

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::detach):
        (WebCore::Document::clearFramePointer):
        * dom/Document.h:
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::frame):
        * loader/DocLoader.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Update result after adding new progress events to XMLHttpRequest.

        * fast/dom/xmlhttprequest-get-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Anders.

        This is a speculative fix for the failing layout test on the build 
        bot. It seems that the problem that the Build Bot is having is 
        Tiger-specific. On Tiger, [NSValue description] was not very smart. 
        So I replaced our call to description with a hand-rolled equivalent 
        that will match on both platforms. 

        * DumpRenderTree/mac/AccessibilityControllerMac.mm:
        (descriptionOfValue):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-06-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add MainThreadObjectDeallocator to sources.
        
        * WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-06-26  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin.

        Add a new MainThreadObjectDeallocator which can schedule dealloc calls on the main thread
        if necessary. Use this for the WebView class. 
                
        * WebView/MainThreadObjectDeallocator.h: Added.
        * WebView/MainThreadObjectDeallocator.mm: Added.
        (deallocCallback):
        (scheduleDeallocateOnMainThread):
        * WebView/WebView.mm:
        (-[WebViewPrivate dealloc]):
        (+[WebView initialize]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Brady.

        Don't enumerate document.applets trying to determine if a page contains applets.
        Instead, set m_containsPlugIns to true when an applet has been created.
        
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::canCachePage):
        (WebCore::FrameLoader::createJavaAppletWidget):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Make JSGlobalData per-thread.

        No change on SunSpider total.

        * wtf/ThreadSpecific.h: Re-enabled the actual implementation.

        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::~JSGlobalObject): Re-added a JSLock-related assertion. We'll probably
        want to preserve these somehow to keep legacy behavior in working condition.
        (KJS::JSGlobalObject::init): Initialize globalData pointer earlier, so that it is ready
        when updating JSGlobalObject linked list.

        * kjs/JSGlobalObject.h: (KJS::JSGlobalObject::head): Changed head() to be non-static, and
        to use JSGlobalData associated with the current object.

        * kjs/InitializeThreading.cpp: (KJS::initializeThreadingOnce): Removed a no longer needed
        Heap::registerAsMainThread() call.

        * kjs/JSGlobalData.h: Removed a lying lie comment - parserObjectExtraRefCounts is not
        transient, and while newParserObjects may conceptually be such, there is still some node
        manipulation going on outside Parser::parse which touches it.

        * kjs/JSGlobalData.cpp:
        (KJS::JSGlobalData::~JSGlobalData): Delete recently added members.
        (KJS::JSGlobalData::sharedInstance): Actually use a separate instance.

        * kjs/collector.cpp:
        (KJS::Heap::Heap):
        (KJS::Heap::~Heap): Added a destructor, which unconditionally deletes everything.
        (KJS::Heap::sweep): Removed code related to "collect on main thread only" logic.
        (KJS::Heap::collect): Ditto.
        (KJS::Heap::globalObjectCount): Explicitly use per-thread instance of JSGlobalObject linked
        list now that JSGlobalObject::head() is not static. Curently, WebCoreStatistics methods only
        work with the main thread currently anyway.
        (KJS::Heap::protectedGlobalObjectCount): Ditto.

        * kjs/collector.h: Removed code related to "collect on main thread only" logic.

        * JavaScriptCore.exp: Removed Heap::collectOnMainThreadOnly.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        https://bugs.webkit.org/show_bug.cgi?id=19767
        REGRESSION: Crash in sort() when visiting http://www.onnyturf.com/subway/

        * kjs/JSArray.cpp: (KJS::AVLTreeAbstractorForArrayCompare::set_balance_factor):
        Made changing balance factor from -1 to +1 work correctly.

        * wtf/AVLTree.h: (KJS::AVLTreeDefaultBSet::operator[]): Added an assertion that catches
        this slightly earlier.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Simon.

        [svg] Disable plugins for SVG images
        The Qt platform allows to have a plugin factory per Page. Now SVG Images
        are using a Page and dummy/empty clients for Chrome. The only way to get
        the kit from the WebCore::Page is to go through the ChromeClient but this
        is not possible when the ChromeClient is an empty client. This leads to a
        crash in PluginDataQt.cpp. One way to avoid this would have been the
        addition of a rtti like field to ChromeClient to see if it is an empty
        client. The other possibility is to not enable plugins for images.

        The SVGImage relies on the fact that the document is a SVGDocument and
        that the rootElement is a SVGSVGElement. If plugins are used we could
        end up with a PluginDocument and crash badly. Do not try to use plugins
        if plugins are disabled for the WebCore::Page.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Simon.

        CodingStyle fixes

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Simon.

        [svg] Make QtWebKit build more of the SVG support
        Add the proper defines and files, update SVGResourceFilterQt.cpp
        to be enabled by the filter option and not by experimental svg support

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Mark.

        <rdar://problem/5984270> 
        REGRESSION (Tiger only) : Mail crashes because message load is being processed on a secondary thread
        
        * WebView/WebView.mm:
        (tigerMailReleaseIMP):
        New method that makes sure that the final release happens on the main thread.
        
        (-[WebView release]):
        New method that just calls [super release];
        
        (+[WebView initialize]):
        When running under Tiger mail, replace the release method with tigerMailReleaseIMP.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Not reviewed, web site fix.
        
        Remove blank lines in an attempt to fix feeds.

        * blog/wp-content/themes/webkit/index.php:
        * blog/wp-content/themes/webkit/links.php:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Geoffrey Garen.

        - https://bugs.webkit.org/show_bug.cgi?id=19581
          Disable hanging test

        * dom/xhtml/level2/html/HTMLFrameElement09.xhtml: Removed.
        * dom/xhtml/level2/html/HTMLFrameElement09.xhtml-disabled: Copied from LayoutTests/dom/xhtml/level2/html/HTMLFrameElement09.xhtml.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-06-25  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam Weinig.

        This patch adds support to the AccessibilityController to query the 
        following attributes specifically, without a full attribute dump: 
        AXRole, AXTitle, and AXDescription.

        * DumpRenderTree/AccessibilityController.cpp:
        (allAttributesForFocusedElementCallback):
        (roleOfFocusedElementCallback):
        (titleOfFocusedElementCallback):
        (descriptionOfFocusedElementCallback):
        (AccessibilityController::staticFunctions):
        * DumpRenderTree/AccessibilityController.h:
        * DumpRenderTree/mac/AccessibilityControllerMac.mm:
        (AccessibilityController::allAttributesForFocusedElement):
        (concatenateAttributeAndValue):
        (AccessibilityController::roleOfFocusedElement):
        (AccessibilityController::titleOfFocusedElement):
        (AccessibilityController::descriptionOfFocusedElement):

LayoutTests:

2008-06-25  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam Weinig.

        New tests that exercise the ability to query the following 
        accessibility attributes individually: role, title, and 
        description.

        * accessibility/aria-describedby-on-input-expected.txt: Added.
        * accessibility/aria-describedby-on-input.html: Added.
        * accessibility/aria-labelledby-on-input-expected.txt: Added.
        * accessibility/aria-labelledby-on-input.html: Added.
        * accessibility/aria-roles-expected.txt: Added.
        * accessibility/aria-roles.html: Added.
        * accessibility/document-attributes.html:
        * accessibility/resources: Added.
        * accessibility/resources/cake.png: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Brady Eidson.

        Move XMLHttpRequestState enum into XMLHttpRequest and rename to State.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::readyState):
        (WebCore::XMLHttpRequest::changeState):
        (WebCore::XMLHttpRequest::open):
        * xml/XMLHttpRequest.h:
        (WebCore::XMLHttpRequest::create):
        (WebCore::XMLHttpRequest::):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        with the same name inside the same function/program.

        Reviewed by Kevin McCullough.

        * profiler/Profile.cpp:
        (KJS::Profile::Profile): Initialize m_stoppedCallDepth to zero.
        (KJS::Profile::stopProfiling): Set the current node to the parent,
        because we are in a call that will not get a didExecute call.
        (KJS::Profile::removeProfile): Increment m_stoppedCallDepth to
        account for didExecute not being called for profile.
        (KJS::Profile::willExecute): Increment m_stoppedCallDepth if stopped.
        (KJS::Profile::didExecute): Decrement m_stoppedCallDepth if stopped and
        greater than zero, and return early.
        * profiler/Profile.h: Added stoppedProfiling().
        * profiler/Profiler.cpp:
        (KJS::Profiler::findProfile): Removed.
        (KJS::Profiler::startProfiling): Don't return early for stopped profiles.
        (KJS::Profiler::stopProfiling): Skipp stopped profiles.
        (KJS::Profiler::didFinishAllExecution): Code clean-up.
        * profiler/Profiler.h: Removed findProfile.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-06-25  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <rdar://problem/5994480> Line break lost on some pastes
        
        Merging the the first paragraph of inserted content with the content that came
        before the selection that was pasted into would also move content after 
        the selection that was pasted into if:
        
        1) Only one paragraph was being pasted, and it was not wrapped in a block
        2) The selection that was pasted into ended at the end of a block
        3) The next paragraph didn't start at the start of a block.
        
        Insert a line break just after the inserted content to separate it from what 
        comes after and prevent that from happening.
        
        Doing this exposed a bug in deletion where it would insert an unnecessary placeholder
        when deleting a paragraph that started or ended with an input element.  This was
        because its m_startBlock and m_endBlock were still computed with the old deprecated
        enclosingBlockFlowOrTableElement().
        
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializePositionData): Use the new method for
        getting an enclosing block.
        (WebCore::DeleteSelectionCommand::doApply): The new method for getting an enclosing
        block will return 0 if it reaches the root editable element before finding a block,
        so if we're deleting inside an inline editable root, m_start/endBlock will
        be 0.  Removed an early return for this case (we already have test coverage for it).
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Insert a line break just after the inserted 
        content to separate it from what comes after.
        * dom/Node.h: Removed enclosingBlockFlowOrTableElement().
        * dom/Node.cpp: Ditto.

LayoutTests:

2008-06-25  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.
        
        <rdar://problem/5994480> Line break lost on some pastes
        
        These demonstrate fixes:
        * editing/inserting/5994480.html: Added.
        * editing/inserting/5994480-expected.txt: Added.
        * editing/inserting/5994480-2.html: Added.
        * editing/inserting/5994480-2-expected.txt: Added.
        
        The changes made in this fix caused more of the unrendered text from the original 
        file to be preserved and show up in the test results.  We insert a line break after
        inserted content to separate it from content that comes after and prevent it from
        being merged.  In these what came after was unrendered whitespace that was previously
        clobbered by the merge:
        * platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-010-expected.txt:
        * platform/mac/editing/pasteboard/smart-paste-001-expected.txt:
        * platform/mac/editing/style/style-boundary-005-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Part of Bug 19290: More patches not handled by PrettyPatch.rb
        <https://bugs.webkit.org/show_bug.cgi?id=19290>

        Reviewed by Adam.

        * PrettyPatch/PrettyPatch.rb:
        (PrettyPatch.DIFF_HEADER_FORMATS): Added regular expression to
        match on "+++ " lines for patches with no "Index" or "diff" header.
        (PrettyPatch.FileDiff.initialize): Look for filename on "+++ " line
        when the first line of a patch has no "Index" or "diff" header.
        (PrettyPatch.FileDiff.parse): Added haveSeenDiffHeader state
        variable to determine when no "Index" or "diff" header has been
        found, but a new patch has started with a "--- " line.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dave Hyatt.

        Fix refcount leak in CSSVariablesRule.

        * css/CSSParser.cpp:
        (WebCore::CSSParser::createVariablesRule):
        * css/CSSVariablesRule.h:
        (WebCore::CSSVariablesRule::create):
        (WebCore::CSSVariablesRule::setDeclaration):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-06-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        <rdar://problem/6007111> 
        https://bugs.webkit.org/show_bug.cgi?id=19516
        DOM modification causes Access Violation (NULL pointer?)
        
        Null check the document element.
        
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError):

LayoutTests:

2008-06-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mitz.

        <rdar://problem/6007111> 
        https://bugs.webkit.org/show_bug.cgi?id=19516
        DOM modification causes Access Violation (NULL pointer?)

        * fast/dom/HTMLHtmlElement/duplicate-html-element-crash-expected.txt: Added.
        * fast/dom/HTMLHtmlElement/duplicate-html-element-crash.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5873639> REGRESSION (r31620): css2.1/t1506-c525-font-wt-00-b fails on Windows

        - fix https://bugs.webkit.org/show_bug.cgi?id=18863
          <rdar://problem/5908890> weight mappings with @font-face aren't consistent

        Tests: fast/css/font-face-locally-installed.html
               fast/css/font-face-multiple-faces.html

        * WebCore.vcproj/WebCore.vcproj: Added FontTraitsMask.h.

        * WebCore.xcodeproj/project.pbxproj: Ditto.

        * css/CSSFontFace.h:
        Made CSSFontFace store descriptors from the @font-face rule, as follows:
        (WebCore::CSSFontFace::create): Added a FontTraitsMask argument.
        (WebCore::CSSFontFace::traitsMask): Added this accessor.
        (WebCore::CSSFontFace::addRange): Added.
        (WebCore::CSSFontFace::ranges): Added.
        (WebCore::CSSFontFace::UnicodeRange::UnicodeRange):
        (WebCore::CSSFontFace::UnicodeRange::from):
        (WebCore::CSSFontFace::UnicodeRange::to):
        (WebCore::CSSFontFace::CSSFontFace): Added a FontTraitsMask and a vector
        of UnicodeRanges as member variables.

        * css/CSSFontFaceSource.cpp:
        Changed the hash key from the font size alone to the font size and
        the synthetic style bits, needed if the same source supplies different
        synthesized versions.
        (WebCore::CSSFontFaceSource::pruneTable):
        (WebCore::CSSFontFaceSource::getFontData):

        * css/CSSFontFaceSource.h:

        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::~CSSFontSelector): Added code to delete
        the contents of the font face, locally-installed font face and segmented
        font tables.
        (WebCore::CSSFontSelector::addFontFaceRule): Changed this function to
        not create segmented font faces, but instead just collect font faces
        and annotate them with descriptors (traits and unicode ranges).
        (WebCore::compareFontFaces): Added. Used in getFontData() to sort the
        font faces by proximity to the desired traits.
        (WebCore::CSSFontSelector::getFontData): Changed to create the segmented
        font face here and cache it.

        * css/CSSFontSelector.h:

        * css/CSSSegmentedFontFace.cpp:
        Changed to keep a vector of font faces instead of font face ranges, as
        font faces now know their Unicode ranges.
        (WebCore::CSSSegmentedFontFace::~CSSSegmentedFontFace):
        (WebCore::CSSSegmentedFontFace::isLoaded):
        (WebCore::CSSSegmentedFontFace::isValid):
        (WebCore::CSSSegmentedFontFace::appendFontFace):
        (WebCore::CSSSegmentedFontFace::getFontData): Removed the synthetic
        traits parameters, and instead changed to set them on each FontData
        separately based on the difference between the desired traits and
        the font face's traits.

        * css/CSSSegmentedFontFace.h:

        * platform/graphics/FontCache.h:
        Removed fontExists() and added getTraitsInFamily().

        * platform/graphics/FontDescription.cpp:
        (WebCore::FontDescription::traitsMask): Added.

        * platform/graphics/FontDescription.h:

        * platform/graphics/FontTraitsMask.h: Added.

        * platform/graphics/GlyphPageTreeNode.cpp:
        (WebCore::GlyphPageTreeNode::initializePage): Changed to fill in with
        glyphs from all fonts in the segmented font, using each font in turn to
        fill in characters not covered by earlier fonts.

        * platform/graphics/gtk/FontCacheGtk.cpp:
        (WebCore::FontCache::getTraitsInFamily): Added a stub.

        * platform/graphics/mac/FontCacheMac.mm:
        (WebCore::FontCache::getTraitsInFamily): Added.

        * platform/graphics/qt/FontCacheQt.cpp:
        (WebCore::FontCache::getTraitsInFamily): Added a stub.

        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData): Added.
        (WebCore::traitsInFamilyEnumProc): Added.
        (WebCore::FontCache::getTraitsInFamily): Added.

        * platform/graphics/wx/FontCacheWx.cpp:
        (WebCore::FontCache::getTraitsInFamily): Added a stub.

        * platform/mac/WebFontCache.h:
        * platform/mac/WebFontCache.mm:
        (toTraitsMask): Added.
        (+[WebFontCache getTraits:inFamily:]): Added.

LayoutTests:

        Reviewed by Dave Hyatt.

        - tests for https://bugs.webkit.org/show_bug.cgi?id=18863
          <rdar://problem/5908890> weight mappings with @font-face aren't consistent

        * fast/css/font-face-locally-installed.html: Added.
        * fast/css/font-face-multiple-faces.html: Added.
        * platform/mac/fast/css/font-face-locally-installed-expected.checksum: Added.
        * platform/mac/fast/css/font-face-locally-installed-expected.png: Added.
        * platform/mac/fast/css/font-face-locally-installed-expected.txt: Added.
        * platform/mac/fast/css/font-face-multiple-faces-expected.checksum: Added.
        * platform/mac/fast/css/font-face-multiple-faces-expected.png: Added.
        * platform/mac/fast/css/font-face-multiple-faces-expected.txt: Added.
        * platform/win/Skipped: Removed css2.1/t1506-c525-font-wt-00-b.html.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Alexey Proskuryakov.

        Attempt to fix Windows debug build. The compiler gives a warning when
        Structured Exception Handling and destructors are used in the same
        function. Using manual locking and unlocking instead of constructors
        and destructors should fix the warning.

        * kjs/Shell.cpp:
        (main):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        * kjs/JSGlobalData.cpp:
        (KJS::JSGlobalData::JSGlobalData):
        * kjs/JSGlobalData.h:
        * kjs/nodes.cpp:
        (KJS::ParserRefCounted::ParserRefCounted):
        (KJS::ParserRefCounted::ref):
        (KJS::ParserRefCounted::deref):
        (KJS::ParserRefCounted::hasOneRef):
        (KJS::ParserRefCounted::deleteNewObjects):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Remove more threadInstance() calls.

        * kjs/JSFunction.cpp:
        (KJS::JSFunction::getParameterName):
        (KJS::IndexToNameMap::unMap):
        (KJS::Arguments::deleteProperty):
        * kjs/JSFunction.h:
        Access nullIdentifier without going to thread specific storage.

        * JavaScriptCore.exp:
        * kjs/JSGlobalData.cpp:
        (KJS::JSGlobalData::JSGlobalData):
        * kjs/JSGlobalData.h:
        * kjs/Parser.cpp:
        (KJS::Parser::parse):
        * kjs/Parser.h:
        (KJS::ParserRefCountedData::ParserRefCountedData):
        (KJS::Parser::parse):
        * kjs/grammar.y:
        * kjs/nodes.cpp:
        (KJS::ParserRefCounted::ParserRefCounted):
        (KJS::ParserRefCounted::ref):
        (KJS::ParserRefCounted::deref):
        (KJS::ParserRefCounted::hasOneRef):
        (KJS::ParserRefCounted::deleteNewObjects):
        (KJS::Node::Node):
        (KJS::StatementNode::StatementNode):
        (KJS::BreakpointCheckStatement::BreakpointCheckStatement):
        (KJS::ConstDeclNode::ConstDeclNode):
        (KJS::BlockNode::BlockNode):
        (KJS::ForInNode::ForInNode):
        (KJS::ScopeNode::ScopeNode):
        (KJS::ProgramNode::ProgramNode):
        (KJS::ProgramNode::create):
        (KJS::EvalNode::EvalNode):
        (KJS::EvalNode::create):
        (KJS::FunctionBodyNode::FunctionBodyNode):
        (KJS::FunctionBodyNode::create):
        * kjs/nodes.h:
        (KJS::ExpressionNode::):
        (KJS::NullNode::):
        (KJS::BooleanNode::):
        (KJS::NumberNode::):
        (KJS::ImmediateNumberNode::):
        (KJS::StringNode::):
        (KJS::RegExpNode::):
        (KJS::ThisNode::):
        (KJS::ResolveNode::):
        (KJS::ElementNode::):
        (KJS::ArrayNode::):
        (KJS::PropertyNode::):
        (KJS::PropertyListNode::):
        (KJS::ObjectLiteralNode::):
        (KJS::BracketAccessorNode::):
        (KJS::DotAccessorNode::):
        (KJS::ArgumentListNode::):
        (KJS::ArgumentsNode::):
        (KJS::NewExprNode::):
        (KJS::EvalFunctionCallNode::):
        (KJS::FunctionCallValueNode::):
        (KJS::FunctionCallResolveNode::):
        (KJS::FunctionCallBracketNode::):
        (KJS::FunctionCallDotNode::):
        (KJS::PrePostResolveNode::):
        (KJS::PostIncResolveNode::):
        (KJS::PostDecResolveNode::):
        (KJS::PostfixBracketNode::):
        (KJS::PostIncBracketNode::):
        (KJS::PostDecBracketNode::):
        (KJS::PostfixDotNode::):
        (KJS::PostIncDotNode::):
        (KJS::PostDecDotNode::):
        (KJS::PostfixErrorNode::):
        (KJS::DeleteResolveNode::):
        (KJS::DeleteBracketNode::):
        (KJS::DeleteDotNode::):
        (KJS::DeleteValueNode::):
        (KJS::VoidNode::):
        (KJS::TypeOfResolveNode::):
        (KJS::TypeOfValueNode::):
        (KJS::PreIncResolveNode::):
        (KJS::PreDecResolveNode::):
        (KJS::PrefixBracketNode::):
        (KJS::PreIncBracketNode::):
        (KJS::PreDecBracketNode::):
        (KJS::PrefixDotNode::):
        (KJS::PreIncDotNode::):
        (KJS::PreDecDotNode::):
        (KJS::PrefixErrorNode::):
        (KJS::UnaryOpNode::UnaryOpNode):
        (KJS::UnaryPlusNode::):
        (KJS::NegateNode::):
        (KJS::BitwiseNotNode::):
        (KJS::LogicalNotNode::):
        (KJS::BinaryOpNode::BinaryOpNode):
        (KJS::ReverseBinaryOpNode::ReverseBinaryOpNode):
        (KJS::MultNode::):
        (KJS::DivNode::):
        (KJS::ModNode::):
        (KJS::AddNode::):
        (KJS::SubNode::):
        (KJS::LeftShiftNode::):
        (KJS::RightShiftNode::):
        (KJS::UnsignedRightShiftNode::):
        (KJS::LessNode::):
        (KJS::GreaterNode::):
        (KJS::LessEqNode::):
        (KJS::GreaterEqNode::):
        (KJS::InstanceOfNode::):
        (KJS::InNode::):
        (KJS::EqualNode::):
        (KJS::NotEqualNode::):
        (KJS::StrictEqualNode::):
        (KJS::NotStrictEqualNode::):
        (KJS::BitAndNode::):
        (KJS::BitOrNode::):
        (KJS::BitXOrNode::):
        (KJS::LogicalAndNode::):
        (KJS::LogicalOrNode::):
        (KJS::ConditionalNode::):
        (KJS::ReadModifyResolveNode::):
        (KJS::AssignResolveNode::):
        (KJS::ReadModifyBracketNode::):
        (KJS::AssignBracketNode::):
        (KJS::AssignDotNode::):
        (KJS::ReadModifyDotNode::):
        (KJS::AssignErrorNode::):
        (KJS::CommaNode::):
        (KJS::VarDeclCommaNode::):
        (KJS::ConstStatementNode::):
        (KJS::SourceElements::SourceElements):
        (KJS::EmptyStatementNode::):
        (KJS::DebuggerStatementNode::):
        (KJS::ExprStatementNode::):
        (KJS::VarStatementNode::):
        (KJS::IfNode::):
        (KJS::IfElseNode::):
        (KJS::DoWhileNode::):
        (KJS::WhileNode::):
        (KJS::ForNode::):
        (KJS::ContinueNode::):
        (KJS::BreakNode::):
        (KJS::ReturnNode::):
        (KJS::WithNode::):
        (KJS::LabelNode::):
        (KJS::ThrowNode::):
        (KJS::TryNode::):
        (KJS::ParameterNode::):
        (KJS::FuncExprNode::):
        (KJS::FuncDeclNode::):
        (KJS::CaseClauseNode::):
        (KJS::ClauseListNode::):
        (KJS::CaseBlockNode::):
        (KJS::SwitchNode::):
        Changed ParserRefCounted to hold a JSGlobalData pointer, and used it to replace
        threadInstance calls.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Alexey Proskuryakov.

        Make the JavaScript shell collect the heap from main() instead of
        jscmain() to suppress leak messages in debug builds.

        * kjs/Shell.cpp:
        (main):
        (jscmain):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-06-24  Anonymous

        Reviewed by Darin Adler.  Committed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=19470

        Check for a null documentElement() to fix four crashes.

        * WebCore/dom/Document.cpp:
        * WebCore/dom/Node.cpp:

LayoutTests:

2008-06-24  Anonymous

        Reviewed by Darin Adler.  Committed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=19470

        Check for a null documentElement() to fix four crashes.

        * LayoutTests/fast/dom/documentElement-null-expected.txt: Added.
        * LayoutTests/fast/dom/documentElement-null.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-06-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Fix <https://bugs.webkit.org/show_bug.cgi?id=19597>

        Correctly parse <!-- </textarea> --> inside a <textarea>, matching
        Internet Explorer, Firefox, Opera, and HTML 5.

        Tests: fast/parser/comment-in-script-tricky.html
               fast/parser/comment-in-style.html
               fast/parser/comment-in-textarea.html
               fast/parser/comment-in-title.html

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseSpecial):

LayoutTests:

2008-06-24  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=19597

        Test that we correctly parse comments containing end tags in CDATA and
        RCDATA contexts.

        * fast/parser/comment-in-script-tricky-expected.txt: Added.
        * fast/parser/comment-in-script-tricky.html: Added.
        * fast/parser/comment-in-style.html: Added.
        * fast/parser/comment-in-textarea.html: Added.
        * fast/parser/comment-in-title-expected.txt: Added.
        * fast/parser/comment-in-title.html: Added.
        * platform/mac/fast/parser/comment-in-style-expected.checksum: Added.
        * platform/mac/fast/parser/comment-in-style-expected.png: Added.
        * platform/mac/fast/parser/comment-in-style-expected.txt: Added.
        * platform/mac/fast/parser/comment-in-textarea-expected.checksum: Added.
        * platform/mac/fast/parser/comment-in-textarea-expected.png: Added.
        * platform/mac/fast/parser/comment-in-textarea-expected.txt: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - add another test using remote fonts to the Tiger skipped list

        * platform/mac-tiger/Skipped: Added fast/css/font-weight-1.html.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Exclude the newly-added accessibilityController from the dumped window properties.

        * fast/dom/Window/window-properties.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Maciej.

        Make the conversion of the pair (less, jtrue) to jless use register
        reference counting information for safety instead of requiring callers
        to decide whether it is safe.

        No changes on SunSpider codegen.

        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::emitJumpIfTrue):
        * VM/CodeGenerator.h:
        * kjs/nodes.cpp:
        (KJS::DoWhileNode::emitCode):
        (KJS::WhileNode::emitCode):
        (KJS::ForNode::emitCode):
        (KJS::CaseBlockNode::emitCodeForBlock):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        - move the linker flags from the debug configuration in the project
          to the shared configuration

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        * DumpRenderTree/mac/AccessibilityControllerMac.mm:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Rubber stamped by Oliver.

        Roll out r34777 due to multiple assertion failures on tests.

        * ChangeLog:
        * VM/CodeGenerator.cpp:
        (KJS::CodeGenerator::emitJump):
        (KJS::CodeGenerator::emitJumpIfTrueMayCombine):
        (KJS::CodeGenerator::emitJumpIfTrue):
        (KJS::CodeGenerator::emitJumpIfFalse):
        (KJS::CodeGenerator::emitJumpScopes):
        * VM/LabelID.h:
        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):
        * VM/Machine.h:
        * VM/Opcode.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-06-24  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <rdar://problem/6026335> REGRESSION: Caret disappears after deleting a particular selection involving a ToDo
        
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphs): If asked to preserveStyle, we
        apply styles from the moved paragraph to the destination with applyStyle, which
        does selection preservation when it needs to apply block styles.  Selection preservation 
        uses relatively untested code in TextIterator to count VisiblePositions which fails in 
        this particular test case because it doesn't handle changes in editability properly.  
        We can avoid this bug by not applying block styles from moved paragraphs.  This is 
        something that should be done anyway, since the moved paragraph should assume the 
        block styles of the destination.
        * editing/EditCommand.cpp:
        (WebCore::EditCommand::styleAtPosition): Added a FIXME about how it is misleading for
        this function to also include the typing style.
        * editing/TextIterator.h: Added a FIXME about how the code path used for selection preservation
        is buggy and should be phased out when we rewrite moveParagraphs.

LayoutTests:

2008-06-24  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by John.

        <rdar://problem/6026335> REGRESSION: Caret disappears after deleting a particular selection involving a ToDo

        * editing/deleting/6026335-expected.txt: Added.
        * editing/deleting/6026335.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        -Added a manual test for the profiler.

        * manual-tests/inspector/profiler-test-compare-multiple-profiles.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Tim.

        <rdar://problem/6031594> JSProfiler: Profiler goes into an infinite
        loop sometimes.
        <rdar://problem/6031603> JSProfiler: Profiler asserts in debug and
        give the wrong times in release

        Fixed two issues found by Tim in the same test.

        * profiler/Profile.cpp:
        (KJS::Profile::removeProfileStart): No longer take profile's time from
        all ancestors, but instead attribute it to its parent.  Also add an
        Assert to ensure we only delete the child we mean to.
        (KJS::Profile::removeProfileEnd): Ditto for profileEnd.
        (KJS::Profile::didExecute): Cleaned up the execution order and correctly
        attribute all of the parent's time to the new node.
        * profiler/ProfileNode.cpp: If this node does not have a startTime it
        should not get a giant total time, but instead be 0.
        (KJS::ProfileNode::endAndRecordCall):
        * profiler/ProfileNode.h:
        (KJS::ProfileNode::removeChild): Should reset the sibling pointers since
        one of them has been removed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Cameron.

Add special loop opcodes as groundwork for slow script
termination.  Also added a few assertions to prevent us
from accidentally coalescing conditional jump operands
in a way that might bypass the slow script opcodes.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2008-06-24  Sam Weinig and Beth Dakin  <bdakin@apple.com and sam@webkit.org>

        Reviewed by Darin.

        Fix for <rdar://problem/5884881> Make DumpRenderTree support 
        accessibility tests

        This patch adds some basic support for accessibility layout tests 
        on the Mac.

        * DumpRenderTree/AccessibilityController.cpp: Added.
        (AccessibilityController::AccessibilityController):
        (AccessibilityController::~AccessibilityController):
        (dumpCurrentAttributesCallback):
        (AccessibilityController::makeWindowObject):
        (AccessibilityController::getJSClass):
        (AccessibilityController::staticFunctions):
        * DumpRenderTree/AccessibilityController.h: Added.
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/mac/AccessibilityControllerMac.mm: Added.
        (descriptionOfValue):
        (AccessibilityController::dumpCurrentAttributes):
        * DumpRenderTree/mac/DumpRenderTree.mm:
        * DumpRenderTree/mac/FrameLoadDelegate.h:
        * DumpRenderTree/mac/FrameLoadDelegate.mm:
        (-[FrameLoadDelegate init]):
        (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]):

LayoutTests:

2008-06-24  Sam Weinig and Beth Dakin  <bdakin@apple.com and sam@webkit.org>

        Reviewed by Darin.
        
        First test for <rdar://problem/5884881> Make DumpRenderTree support 
        accessibility tests

        * accessibility: Added.
        * accessibility/document-attributes-expected.txt: Added.
        * accessibility/document-attributes.html: Added.
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34776 268f45cc-cd09-0410-ab3c-d52691b4dbfc