1. 12 May, 2011 40 commits
    • jberlin@webkit.org's avatar
      [Windows WebKit2] Use cookies set in WebKit1 · e09492e9
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=60274
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      Make sure any Private Browsing session is based off the default session.
      
      * platform/network/cf/ResourceHandleCFNet.cpp:
      (WebCore::ResourceHandle::createPrivateBrowsingStorageSession):
      
      Source/WebKit2: 
      
      Properly handle the case where there is no serialized default storage session by not trying
      to encode or decode 0, while still making sure to decode any valid storage session.
      
      * Shared/WebProcessCreationParameters.cpp:
      (WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
      (WebKit::WebProcessCreationParameters::encode):
      Only encode the storage session if there is one to encode.
      (WebKit::WebProcessCreationParameters::decode):
      Only decode the storage session there is one to decode.
      * Shared/WebProcessCreationParameters.h:
      
      WebKitLibraries: 
      
      Update WKSI with the changes to wkCreatePrivateStorageSession.
      
      * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
      * win/lib/WebKitSystemInterface.lib:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e09492e9
    • atwilson@chromium.org's avatar
      Unreviewed expectations update for Chromium. · bd01e397
      atwilson@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd01e397
    • atwilson@chromium.org's avatar
      Unreviewed expectations update for chromium. · b7bac222
      atwilson@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7bac222
    • jeffm@apple.com's avatar
      Ignore Visual Studio *.user files. · 555643e0
      jeffm@apple.com authored
      * gtest/msvc: Added property svn:ignore.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      555643e0
    • rwlbuis@webkit.org's avatar
      2011-05-12 Rob Buis <rbuis@rim.com> · e12e3d44
      rwlbuis@webkit.org authored
              Reviewed by Eric Seidel.
      
              SVGStyledElement::resolveStyle(RenderStyle*) must be removed/fixed!
              https://bugs.webkit.org/show_bug.cgi?id=15479
      
              Finally remove resolveStyle, it is not used anymore.
      
              * svg/SVGStyledElement.cpp:
              (WebCore::SVGStyledElement::childrenChanged):
              * svg/SVGStyledElement.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e12e3d44
    • abarth@webkit.org's avatar
      2011-05-12 Adam Barth <abarth@webkit.org> · c4d1975d
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              REGRESSION (r65868): createContextualFragment does not work with <style>
              https://bugs.webkit.org/show_bug.cgi?id=60155
      
              These test results match Firefox.
      
              * fast/parser/style-in-create-contextual-fragment-expected.txt: Added.
              * fast/parser/style-in-create-contextual-fragment-head-expected.txt: Added.
              * fast/parser/style-in-create-contextual-fragment-head.html: Added.
              * fast/parser/style-in-create-contextual-fragment.html: Added.
      2011-05-12  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Darin Adler.
      
              REGRESSION (r65868): createContextualFragment does not work with <style>
              https://bugs.webkit.org/show_bug.cgi?id=60155
      
              createContextualFragment doesn't have a spec, so it's hard to tell what
              we're supposed to do exactly.  This patch appears to make our behavior
              more like Firefox and should fix the compat issue with this site.
      
              Tests: fast/parser/style-in-create-contextual-fragment-head.html
                     fast/parser/style-in-create-contextual-fragment.html
      
              * dom/Element.cpp:
              (WebCore::Element::deprecatedCreateContextualFragment):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4d1975d
    • commit-queue@webkit.org's avatar
      2011-05-12 David Grogan <dgrogan@chromium.org> · 2f975c92
      commit-queue@webkit.org authored
              Reviewed by Nate Chapin.
      
              IndexedDB: fix up database-quota.html layout test
              https://bugs.webkit.org/show_bug.cgi?id=60519
      
              Remove commitAndContinue idiom; translate some missed instances of
              event.code to event.target.errorCode from bug 54331
      
              * storage/indexeddb/database-quota-expected.txt:
              * storage/indexeddb/database-quota.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f975c92
    • jam@chromium.org's avatar
      Fix mismatched virtual function from previous checkin · 0d3fbb94
      jam@chromium.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d3fbb94
    • mrobinson@webkit.org's avatar
      2011-05-12 Martin Robinson <mrobinson@igalia.com> · 018621b6
      mrobinson@webkit.org authored
              Attempt to fix the GTK+ unit test testwebview on the 32-bit Release
              bot which appears to be more sensitive to timing issues than the
              other bots.
      
              * tests/testwebview.c: Add another short pause waiting for adjustments to update.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      018621b6
    • rniwa@webkit.org's avatar
      2011-05-12 Ryosuke Niwa <rniwa@webkit.org> · 67a06f94
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              WebKit inserts base, link, meta, style, and title elements into an editable region
              when pasting table cells from Excel
              https://bugs.webkit.org/show_bug.cgi?id=60644
      
              Added a test to ensure WebKit strips the said elements prior to inserting HTML.
      
              * editing/pasteboard/paste-head-contents-expected.txt: Added.
              * editing/pasteboard/paste-head-contents.html: Added.
      2011-05-12  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Darin Adler.
      
              WebKit inserts base, link, meta, style, and title elements into an editable region
              when pasting table cells from Excel
              https://bugs.webkit.org/show_bug.cgi?id=60644
      
              Strip base, link, meta, style, and tile elements from the fragment to be pasted prior
              to the merge. We don't have to strip these elements in performTrivialReplace because
              the function only handles a fragment that consists of exactly one text node.
      
              Test: editing/pasteboard/paste-head-contents.html
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::removeHeadContents): Added.
              (WebCore::ReplaceSelectionCommand::doApply): Calls removeHeadContents before handing
              style spans.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67a06f94
    • leviw@chromium.org's avatar
      2011-05-12 Levi Weintraub <leviw@chromium.org> · 61516486
      leviw@chromium.org authored
              Reviewed by Simon Fraser.
      
              Switch calculateBackgroundImageGeometry to use IntRect
              https://bugs.webkit.org/show_bug.cgi?id=60671
      
              Replacing the four ints passed into calculateBackgroundImageGeometry with an IntRect.
      
              No new tests since this is just refactoring.
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::maskClipRect):
              (WebCore::RenderBox::repaintLayerRectsForImage):
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintFillLayerExtended):
              (WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
              * rendering/RenderBoxModelObject.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61516486
    • inferno@chromium.org's avatar
      2011-05-12 Carol Szabo <carol@webkit.org> · a0b824e8
      inferno@chromium.org authored
              Reviewed by David Hyatt.
      
              Fix reparenting and destruction of counter nodes. 
              https://bugs.webkit.org/show_bug.cgi?id=57929
      
              Fixed several issues related to not met assertions.
              See below in the per file description.
      
              Test: fast/css/counters/element-removal-crash.xhtml
      
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::removeChildren):
              Fixed the fact that Node::detach() used to be called
              while the DOM tree was in an inconsistent state.
              * rendering/RenderCounter.cpp:
              (WebCore::RenderCounter::rendererRemovedFromTree):
              Introduced this function to remove counters from
              descendents of renderers removed from the renderer
              tree not only from the removed renderers themselves.
              * rendering/RenderCounter.h:
              * rendering/RenderObjectChildList.cpp:
              (WebCore::RenderObjectChildList::removeChildNode):
              Changed to call RenderCounter::rendererRemovedFromTree
              instead of RenderCounter::destroyCounters.
      2011-05-08 Abhishek Arya <inferno@chromium.org> and Carol Szabo  <carol@webkit.org>
      
              Reviewed by David Hyatt.
      
              Fix reparenting and destruction of counter nodes.
              https://bugs.webkit.org/show_bug.cgi?id=57929
      
              * fast/css/counters/element-removal-crash-expected.txt: Added.
              * fast/css/counters/element-removal-crash.xhtml: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0b824e8
    • commit-queue@webkit.org's avatar
      2011-05-12 Chang Shu <cshu@webkit.org> · 8a4754eb
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              Rebaseline editing/inserting tests that work
              https://bugs.webkit.org/show_bug.cgi?id=60702
      
              * platform/qt/Skipped:
              * platform/qt/editing/inserting/4278698-expected.png: Added.
              * platform/qt/editing/inserting/4278698-expected.txt:
              * platform/qt/editing/inserting/editable-html-element-expected.png: Added.
              * platform/qt/editing/inserting/editable-html-element-expected.txt:
              * platform/qt/editing/inserting/editing-empty-divs-expected.png: Added.
              * platform/qt/editing/inserting/editing-empty-divs-expected.txt:
              * platform/qt/editing/inserting/insert-div-023-expected.png: Added.
              * platform/qt/editing/inserting/insert-div-023-expected.txt:
              * platform/qt/editing/inserting/multiple-lines-selected-expected.png: Added.
              * platform/qt/editing/inserting/multiple-lines-selected-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a4754eb
    • jam@chromium.org's avatar
      2011-05-11 John Abd-El-Malek <jam@chromium.org> · f939504c
      jam@chromium.org authored
              Reviewed by James Robinson.
      
              [chromium] Make openFileSystem check for permission first
              https://bugs.webkit.org/show_bug.cgi?id=60683
      
              * public/WebCommonWorkerClient.h:
              (WebKit::WebCommonWorkerClient::allowFileSystem):
              * public/WebPermissionClient.h:
              (WebKit::WebPermissionClient::allowFileSystem):
              * src/LocalFileSystemChromium.cpp:
              (WebCore::openFileSystemNotAllowed):
              (WebCore::openFileSystemHelper):
              * src/WebWorkerBase.cpp:
              (WebKit::WebWorkerBase::allowFileSystem):
              * src/WebWorkerBase.h:
              * src/WebWorkerClientImpl.h:
              (WebKit::WebWorkerClientImpl::allowFileSystem):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f939504c
    • commit-queue@webkit.org's avatar
      2011-05-12 Luke Macpherson <macpherson@chromium.org> · 05f4918d
      commit-queue@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Merge ApplyPropertyExpanding and ApplyPropertyExpandingSuppressValue classes using template.
              https://bugs.webkit.org/show_bug.cgi?id=60691
      
              No new tests - refactoring only.
      
              * css/CSSStyleApplyProperty.cpp:
              (WebCore::ApplyPropertyExpanding::applyValue):
              Use new template parameter to early exit if needed.
              (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
              Specify template parameters for ApplyPropertyExpanding.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05f4918d
    • bweinstein@apple.com's avatar
      Source/WebKit2: After relaunching an unresponsive web process, web page stops... · ff211541
      bweinstein@apple.com authored
      Source/WebKit2: After relaunching an unresponsive web process, web page stops responding to mouse movement
      https://bugs.webkit.org/show_bug.cgi?id=60669
      <rdar://problem/9409934>
      
      Reviewed by Anders Carlsson.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::processDidCrash): Set m_processingMouseMoveEvent to false when the WebProcess
          crashes.
      
      Tools: After relaunching an unresponsive web process, web page stops responding to mouse movement
      https://bugs.webkit.org/show_bug.cgi?id=60669
      <rdar://problem/9409934>
              
      Reviewed by Anders Carlsson.
      
      This test follows the steps needed to reproduce this bug:
      1) Hang the web process
      2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
      3) Kill and restart the WebProcess
      4) Move the mouse
              
      We are testing that we receive mouse move events after the WebProcess has restarted.
      
      * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
      (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
      (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
      (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
      (TestWebKitAPI::setPageLoaderClient):
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
      (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
      (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
      * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
      
      * TestWebKitAPI/PlatformWebView.h:
      * TestWebKitAPI/mac/PlatformWebViewMac.mm:
      (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
      * TestWebKitAPI/win/PlatformWebViewWin.cpp:
      (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
      
      Add new files.
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/win/TestWebKitAPI.vcproj:
      * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
      * TestWebKitAPI/win/copy-resources.cmd:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff211541
    • simon.fraser@apple.com's avatar
      2011-05-12 Simon Fraser <simon.fraser@apple.com> · 0f8a9043
      simon.fraser@apple.com authored
              Followup to r86351; give the vectors some inline capacity
              to avoid heap allocations in most cases.
      
              * page/animation/AnimationBase.cpp:
              (WebCore::PropertyWrapperShadow::blendMismatchedShadowLists):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f8a9043
    • rwlbuis@webkit.org's avatar
      2011-05-12 Rob Buis <rwlbuis@gmail.com> · 234a1acd
      rwlbuis@webkit.org authored
              Reviewed by Darin Adler.
      
              REGRESSION(79985): Changes in fill-opacity should trigger repaint but don't
              https://bugs.webkit.org/show_bug.cgi?id=59941
      
              Improve test to not need a click. Offer a stroke-opacity variant as well.
      
              * platform/mac/svg/custom/fill-opacity-update-expected.png:
              * platform/mac/svg/custom/fill-opacity-update-expected.txt:
              * platform/mac/svg/custom/stroke-opacity-update-expected.png: Added.
              * platform/mac/svg/custom/stroke-opacity-update-expected.txt: Added.
              * svg/custom/fill-opacity-update.svg:
              * svg/custom/stroke-opacity-update.svg: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      234a1acd
    • simon.fraser@apple.com's avatar
      2011-05-12 Simon Fraser <simon.fraser@apple.com> · 2b1c9808
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein.
      
              Mismatched multiple box-shadows do not transition as expected
              https://bugs.webkit.org/show_bug.cgi?id=60137
      
              When animating between two sets of shadows of different lengths, we need
              to walk the ShadowData list backwards, since it stores the shadows in
              reverse order relative to the CSS (so that painting is back-to-front).
      
              This progresses the behavior of the transitions/multiple-shadow-transitions.html
              test, which is given new expected results.
      
              Test: transitions/mismatched-shadow-transitions.html
      
              * page/animation/AnimationBase.cpp:
              (WebCore::shadowListLength): Utility to walk the list of ShadowData and count the number
              of shadows.
              (WebCore::shadowForBlending): Return a ShadowData* that is useful as a blending target,
              based on the shadow type, and whether it's a -webkit-box-shadow.
              (WebCore::PropertyWrapperShadow::blend): Call one of the specialized blend methods.
              (WebCore::PropertyWrapperShadow::blendSimpleOrMatchedShadowLists): Fast path
              for shadow blending, when the list lengths match, or both are single or null shadows.
              (WebCore::PropertyWrapperShadow::blendMismatchedShadowLists): Slower path that builds
              vectors for each list to reverse them.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b1c9808
    • antonm@chromium.org's avatar
      2011-05-12 Anton Muhin <antonnm@chromium.org> · 6f82bb95
      antonm@chromium.org authored
              Unreviewed.
      
              Chromium expectations.
      
              * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f82bb95
    • commit-queue@webkit.org's avatar
      2011-05-12 Tomasz Morawski <t.morawski@samsung.com> · d2de2f25
      commit-queue@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [EFL] Added initialization/shutdown for ecore_file library
              https://bugs.webkit.org/show_bug.cgi?id=60457
      
              Added initialization and shuthown for ecore_file library and replaced
              realpath function to ecore_file_realpath.
      
              * EWebLauncher/main.c:
              (quit):
              (findThemePath):
              (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2de2f25
    • antonm@chromium.org's avatar
      2011-05-12 Anton Muhin <antonnm@chromium.org> · 9a0bff2c
      antonm@chromium.org authored
              Unreviewed.
      
              Chromium expectations.
      
              * platform/chromium/test_expectations.txt:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a0bff2c
    • aroben@apple.com's avatar
      Windows production build fix · 070683e8
      aroben@apple.com authored
      * gtest/msvc/gtest-md.vcproj: Fix the OutputDirectory and IntermediateDirectory attributes
      for all configurations.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      070683e8
    • antonm@chromium.org's avatar
      2011-05-12 Anton Muhin <antonnm@chromium.org> · 01e71c91
      antonm@chromium.org authored
              Unreviewed.
      
              Fixed typo.
      
              * platform/chromium/test_expectations.txt:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01e71c91
    • antonm@chromium.org's avatar
      2011-05-12 Anton Muhin <antonnm@chromium.org> · fd196640
      antonm@chromium.org authored
              Unreviewed.
      
              Chromium expectations.
      
              * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd196640
    • philn@webkit.org's avatar
      2011-05-12 Philippe Normand <pnormand@igalia.com> · 4ea0a388
      philn@webkit.org authored
              Unreviewed, GTK baselines for new tests.
      
              * platform/gtk/fast/block/positioning/hiding-inside-relpositioned-inline-expected.png: Added.
              * platform/gtk/fast/block/positioning/hiding-inside-relpositioned-inline-expected.txt: Added.
              * platform/gtk/fast/borders/outline-alpha-block-expected.png: Added.
              * platform/gtk/fast/borders/outline-alpha-block-expected.txt: Added.
              * platform/gtk/fast/borders/outline-alpha-inline-expected.png: Added.
              * platform/gtk/fast/borders/outline-alpha-inline-expected.txt: Added.
              * platform/gtk/fast/inline/nested-top-alignment-expected.png: Added.
              * platform/gtk/fast/inline/nested-top-alignment-expected.txt: Added.
              * platform/gtk/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
              * platform/gtk/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
              * platform/gtk/svg/custom/fill-opacity-update-expected.png: Added.
              * platform/gtk/svg/custom/fill-opacity-update-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ea0a388
    • aroben@apple.com's avatar
      Attempted WinCairo build fix after r86169, part II · 3aa7af3c
      aroben@apple.com authored
      * platform/network/curl/CredentialStorageCurl.cpp: Added a missing #include.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3aa7af3c
    • antonm@chromium.org's avatar
      2011-05-12 Anton Muhin <antonnm@chromium.org> · c27ba04a
      antonm@chromium.org authored
              Unreviewed.
      
              Chromium GPU suppressions.
      
              * platform/chromium/test_expectations.txt:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c27ba04a
    • aroben@apple.com's avatar
      Update Windows results after r86315 · 5bbbb623
      aroben@apple.com authored
      * platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
      * platform/win/fast/dom/prototype-inheritance-expected.txt:
      * platform/win/fast/js/global-constructors-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5bbbb623
    • aroben@apple.com's avatar
      Fix linker warnings in Production builds · 4ae18f7d
      aroben@apple.com authored
      * WebCore.vcproj/WebCore.vcproj: Exclude JSSVGFEDropShadowElement.cpp from the build in the
      Production configuration, just like in the other configurations. Let VS resort some files
      (again).
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ae18f7d
    • philn@webkit.org's avatar
      2011-05-12 Philippe Normand <pnormand@igalia.com> · 3d7a0f43
      philn@webkit.org authored
              Reviewed by Adam Roben.
      
              Autocorrection persists after deleting and retyping the same word at same location.
              https://bugs.webkit.org/show_bug.cgi?id=60555
      
              Follow-up fix for the 3 editing/deleting tests crashing on GTK,
              Leopard and Windows XP. Don't create the Range if the start of the
              selection has no next position.
      
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d7a0f43
    • aroben@apple.com's avatar
      Attempted WinCairo build fix after r86169 · c4365eec
      aroben@apple.com authored
      * WebCore.vcproj/WebCore.vcproj: Added CredentialStorageCurl.cpp. Also let VS do what it
      wants.
      
      * platform/network/curl/CredentialStorageCurl.cpp: Added.
      (WebCore::CredentialStorage::getFromPersistentStorage): Stubbed out.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4365eec
    • aroben@apple.com's avatar
      Build fixes after r86325 · 3c7f1a0c
      aroben@apple.com authored
      * editing/SpellingCorrectionController.cpp:
      * editing/SpellingCorrectionController.h:
      Added missing declarations/#includes.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c7f1a0c
    • aroben@apple.com's avatar
      A little gtest cleanup after r86287 · 99c3a4d4
      aroben@apple.com authored
      Source/ThirdParty:
      
      * gtest/msvc/gtest-md.vcproj: Added Debug_All and Production configurations to match our
      other projects. (At some point all the settings should be moved into .vsprops files to match
      our other projects, too.)
      
      Source/WebKit/win:
      
      * WebKit.vcproj/WebKit.sln:
          - Move gtest into the Tools folder
          - Make gtest build just before TestWebKitAPIGenerated
          - Use gtest's new Debug_All and Production configurations as appropriate
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99c3a4d4
    • zimmermann@webkit.org's avatar
      2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com> · aa696027
      zimmermann@webkit.org authored
              Not reviewed.
      
              Revert r86334, it broke the win build. WinCE build is fixed even without this patch. WinCairo remains broken atm, everything else works.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa696027
    • zimmermann@webkit.org's avatar
      2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com> · dbca63ef
      zimmermann@webkit.org authored
              Not reviewed.
      
              String operator+ reallocates unnecessarily when concatting > 2 strings
              https://bugs.webkit.org/show_bug.cgi?id=58420
      
              Try to fix WinCE/WinCairo linking by exporting three symbols, not sure whether it's correct though. Win worked just fine before.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbca63ef
    • zimmermann@webkit.org's avatar
      2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com> · 37643bf4
      zimmermann@webkit.org authored
              Not reviewed.
      
              String operator+ reallocates unnecessary when concatting > 2 strings
              https://bugs.webkit.org/show_bug.cgi?id=58420
      
              Attempt to fix the WinCE build. WinCE/WinCairo still won't link because of unresolved symbols, hmm. If we had EWS for those, I would have caught the problem earlier.
      
              * platform/wince/FileSystemWinCE.cpp:
              (WebCore::listDirectory):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37643bf4
    • zimmermann@webkit.org's avatar
      2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com> · 256315ac
      zimmermann@webkit.org authored
              Not reviewed.
      
              String operator+ reallocates unnecessary when concatting > 2 strings
              https://bugs.webkit.org/show_bug.cgi?id=58420
      
              Fix fast/forms/input-image-submit.html regression, seens on the bots - by removing a last-minute typo: s/!!/!/
      
              * html/ImageInputType.cpp:
              (WebCore::ImageInputType::appendFormData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      256315ac
    • rwlbuis@webkit.org's avatar
      2011-05-12 Rob Buis <rwlbuis@gmail.com> · c823d24d
      rwlbuis@webkit.org authored
              Reviewed by Eric Seidel.
      
              REGRESSION(79985): Changes in fill-opacity should trigger repaint but don't
              https://bugs.webkit.org/show_bug.cgi?id=59941
      
              Also consider fill-opacity when determining whether StyleDifferenceRepaint is needed.
      
              Test: svg/custom/fill-opacity-update.svg
      
              * rendering/style/SVGRenderStyle.cpp:
              (WebCore::SVGRenderStyle::diff):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c823d24d
    • zimmermann@webkit.org's avatar
      2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com> · 6da15387
      zimmermann@webkit.org authored
              Reviewed by Darin Adler.
      
              String operator+ reallocates unnecessarily when concatting > 2 strings
              https://bugs.webkit.org/show_bug.cgi?id=58420
      
              Provide a faster String append operator.
              Up until now, "String operator+(const String& a, const String& b)" copied String a into a temporary
              object, and used a.append(b), which reallocates a new buffer of aLength+bLength. When concatting
              N strings using operator+, this leads to N-1 reallocations.
      
              Replace this with a flexible operator+ implementation, that avoids these reallocations.
              When concatting a 'String' with any string type (char*, UChar, Vector<char>, String, AtomicString, etc..)
              a StringAppend<String, T> object is created, which holds the intermediate string objects, and delays
              creation of the final string, until operator String() is invoked.
      
              template<typename T>
              StringAppend<String, T> operator+(const String& string1, T string2)
              {
                  return StringAppend<String, T>(string1, string2);
              }
      
              template<typename U, typename V, typename W>
              StringAppend<U, StringAppend<V, W> > operator+(U string1, const StringAppend<V, W>& string2)
              {
                  return StringAppend<U, StringAppend<V, W> >(string1, string2);
              }
      
              When concatting three strings - "String a, b, c; String result = a + b + c;" following happens:
              first a StringAppend<String, String> object is created by operator+(const String& string1, String string2).
              Then operator+(String string1, const StringAppend<String, String>& string2) is invoked, which returns
              a StringAppend<String, StringAppend<String, String> > object.
              Then operator String() is invoked, which allocates a StringImpl object, once, large enough to hold the
              final string - it uses tryMakeString provided by StringConcatenate.h under the hoods, which guards us
              against too big string allocations, etc.
      
              Note that the second template, defines a recursive way to concat an arbitary number of strings
              into a single String with just one allocation.
      
              * GNUmakefile.list.am: Add StringOperators.h to build.
              * JavaScriptCore.exp: Export WTF::emptyString(). Remove no longer needed symbols.
              * JavaScriptCore.gypi: Add StringOperators.h to build.
              * JavaScriptCore.vcproj/WTF/WTF.vcproj: Ditto.
              * JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
              * wtf/text/AtomicString.h: Pull in StringConcatenate.h at the end of the file.
              * wtf/text/StringConcatenate.h: Conditionally include AtomicString.h to avoid a cyclic dependency. Pull in StringOperators.h at the end of the file.
              * wtf/text/StringOperators.h: Added. This is never meant to be included directly, including either WTFString.h or AtomicString.h automatically pulls in this file.
              (WTF::StringAppend::StringAppend):
              (WTF::StringAppend::operator String):
              (WTF::StringAppend::operator AtomicString):
              (WTF::StringAppend::writeTo):
              (WTF::StringAppend::length):
              (WTF::operator+):
              * wtf/text/WTFString.cpp: Remove operator+ implementations that use String::append(). 
              (WTF::emptyString): Add new shared empty string free function.
              * wtf/text/WTFString.h: Replace operator+ implementations by StringAppend template solution. Pull in AtomicString.h at the end of the file.
      
      2011-05-12  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Darin Adler.
      
              String operator+ reallocates unnecessary when concatting > 2 strings
              https://bugs.webkit.org/show_bug.cgi?id=58420
      
              Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
      
              * dom/XMLDocumentParserLibxml2.cpp:
              (WebCore::handleElementAttributes):
              * editing/MarkupAccumulator.cpp:
              (WebCore::MarkupAccumulator::shouldAddNamespaceElement):
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::hash):
              (WebCore::HTMLAnchorElement::search):
              * html/ImageInputType.cpp:
              (WebCore::ImageInputType::appendFormData):
              * html/parser/HTMLTreeBuilder.cpp:
              * loader/CrossOriginAccessControl.cpp:
              (WebCore::passesAccessControlCheck):
              * page/Location.cpp:
              (WebCore::Location::search):
              (WebCore::Location::hash):
              * page/NavigatorBase.cpp:
              (WebCore::NavigatorBase::platform):
              * platform/chromium/ClipboardChromium.cpp:
              (WebCore::writeImageToDataObject):
              * platform/gtk/PasteboardHelper.cpp:
              (WebCore::PasteboardHelper::fillSelectionData):
              * platform/network/cf/ResourceHandleCFNet.cpp:
              (WebCore::encodeBasicAuthorization):
              * platform/network/cf/SocketStreamHandleCFNet.cpp:
              (WebCore::SocketStreamHandle::copyCFStreamDescription):
              * platform/network/mac/ResourceHandleMac.mm:
              (WebCore::encodeBasicAuthorization):
              * workers/WorkerLocation.cpp:
              (WebCore::WorkerLocation::search):
              (WebCore::WorkerLocation::hash):
      
      2011-05-12  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Darin Adler.
      
              String operator+ reallocates unnecessarily when concatting > 2 strings
              https://bugs.webkit.org/show_bug.cgi?id=58420
      
              Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
      
              * src/WebAccessibilityObject.cpp:
              (WebKit::WebAccessibilityObject::keyboardShortcut): Cast to String first, before trying to convert to platform dependant type.
              * src/WebHTTPLoadInfo.cpp:
              (WebKit::addHeader): Don't pass WebString to makeString, explicit cast to String first.
              * tests/IDBLevelDBCodingTest.cpp: Cast to String first, to avoid conflicting with gtests global templatified operator+.
              (IDBLevelDBCoding::TEST):
      
      2011-05-12  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Darin Adler.
      
              String operator+ reallocates unnecessarily when concatting > 2 strings
              https://bugs.webkit.org/show_bug.cgi?id=58420
      
              Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
      
              * WebView/WebFrame.mm: Explicitely cast to Strings first, so operator NSString*() can be invoked.
              (-[WebFrame _stringWithDocumentTypeStringAndMarkupString:]):
      
      2011-05-12  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Darin Adler.
      
              String operator+ reallocates unnecessarily when concatting > 2 strings
              https://bugs.webkit.org/show_bug.cgi?id=58420
      
              Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
      
              * AccessibleBase.cpp:
              (AccessibleBase::get_accKeyboardShortcut): Explicitely cast to Strings first, so operator BString() can be invoked.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6da15387