Skip to content

GitLab

Switch branch/tag
  1. 29 Mar, 2013 14 commits
    • charles.wei@torchmobile.com.cn's avatar
      [BlackBerry] Context menu doesn't showup anymore after rebase. · e0741c6b
      charles.wei@torchmobile.com.cn authored 
      https://bugs.webkit.org/show_bug.cgi?id=113570

Reviewed by George Staikos.

The upstreaming patch for bug: 103058, reverses the return value of
Node::dispatchMouseEvent() to be consistent with Node::dispatchEvent(),
so we should reverse our logic in webkit part that calls it also.

This only applys to master_41 which is a new rebase, don't apply it to master_40.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0741c6b
    • commit-queue@webkit.org's avatar
      Fix build warning after r147022 · 43622b80
      commit-queue@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=113567

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-03-29
Reviewed by Kentaro Hara.

Use UNUSED_PARAM macro to fix -Wunused-parameter build warning.
No new tests, no change on behavior.

* page/EventHandler.cpp:
(WebCore::expandSelectionToRespectUserSelectAll):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43622b80
    • commit-queue@webkit.org's avatar
      Web Inspector: ability to use AnchorBox as an anchor for Popover · 1196dbd0
      commit-queue@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=113563

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-29
Reviewed by Pavel Feldman.

No new test: no change in behaviour.

- Ability to pass AnchorBox instead of Element for popover anchor.

* inspector/front-end/Popover.js:
(WebInspector.Popover.prototype._positionElement):
(WebInspector.PopoverHelper.prototype._eventInHoverElement):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1196dbd0
    • caseq@chromium.org's avatar
      Web Inspector: assign Scroll events to rendering category (was painting) · c859375c
      caseq@chromium.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=113564

Reviewed by Pavel Feldman.

* inspector/front-end/TimelinePresentationModel.js: /ScrollLayer.*category/s/painting/rendering/
(WebInspector.TimelinePresentationModel._initRecordStyles):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c859375c
    • zarvai@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Skip failing test after r147205. · 977d2368
      zarvai@inf.u-szeged.hu authored 
      * platform/qt-5.0-wk1/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      977d2368
    • philn@webkit.org's avatar
      [GStreamer] playback gets bumpy sometimes when on-disk buffering is slow · 7c38184f
      philn@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=113512

Reviewed by Martin Robinson.

When the HTTP source element is slow downloading data for on-disk
buffering the playback position might reach an unbuffered region
and have bad consequences, pausing the pipeline beforehand
prevents this case to happen.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::processBufferingStats):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c38184f
    • keishi@webkit.org's avatar
      Add the event handler content attributes that are defined in the spec to HTMLElement · b61c383f
      keishi@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=86363

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/events/event-attribute.html

We are missing some event handler content attributes from HTMLElement that are defined in the spec.
http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#event-handlers-on-elements,-document-objects,-and-window-objects

* html/HTMLElement.cpp:
(WebCore::HTMLElement::eventNameForAttributeName): Returns event name for a given attribute name by looking it up on a HashMap.
(WebCore::HTMLElement::parseAttribute): Sets up event listeners for content attributes.
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::parseAttribute): Removed event listener content attributes that was added to HTMLElement.
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseAttribute): Ditto.
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute): Ditto.
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseAttribute): Ditto.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseAttribute): Ditto.
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::parseAttribute): Ditto.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseAttribute): Ditto.
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::parseAttribute): Ditto.
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::parseAttribute): Ditto.
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::parseAttribute): Ditto.

LayoutTests:

* fast/events/event-attribute-expected.txt: Added.
* fast/events/event-attribute.html: Added. Tests that setting attribute creates event listeners.
* fast/events/form-onchange-expected.txt: Added.
* fast/events/form-onchange.html: Added. Test for Bug 24516.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b61c383f
    • caseq@chromium.org's avatar
      Web Inspector: timeline paint rectangles are off for transformed layers · 5f0ea769
      caseq@chromium.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=112919

Reviewed by Pavel Feldman.

Source/WebCore:

- pass RenderObject instead of Frame to InspectorInstrumentation::didPaint;
- take transforms into account and convert paint clip rect into quad;
- emit quads, not rects as Paint and Layout record data;
- adjust client to using quads, compute width/height from quad coords.

* inspector/InspectorInstrumentation.cpp: Pass RenderObject, not frame to {will,did}Paint.
(WebCore):
(WebCore::InspectorInstrumentation::willPaintImpl):
(WebCore::InspectorInstrumentation::didPaintImpl):
(WebCore::InspectorInstrumentation::instrumentingAgentsForRenderer): Added.
* inspector/InspectorInstrumentation.h:
(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willPaint):
(WebCore::InspectorInstrumentation::didPaint):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didLayout):
(WebCore::InspectorTimelineAgent::didPaint):
(WebCore::InspectorTimelineAgent::localToPageQuad): Convert local clip rect to transformed quad.
(WebCore):
* inspector/InspectorTimelineAgent.h:
(WebCore):
(InspectorTimelineAgent):
* inspector/TimelineRecordFactory.cpp: Emit quads as Paint and Layout records data.
(WebCore::createQuad):
(WebCore):
(WebCore::TimelineRecordFactory::createPaintData):
(WebCore::TimelineRecordFactory::createLayoutData):
* inspector/TimelineRecordFactory.h:
(WebCore):
(TimelineRecordFactory):
* inspector/front-end/TimelinePanel.js: Highlight a quad iff formatted record has highlightQuad field.
(WebInspector.TimelinePanel.prototype._mouseOut):
(WebInspector.TimelinePanel.prototype._mouseMove):
(WebInspector.TimelinePanel.prototype._highlightQuad):
(WebInspector.TimelinePanel.prototype._hideQuadHighlight):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record): Set highlightQuad for Paint and Layout
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.Record.prototype._getRecordDetails):
(WebInspector.TimelinePresentationModel.quadWidth):
(WebInspector.TimelinePresentationModel.quadHeight):
* page/FrameView.cpp:
(WebCore::FrameView::paintContents):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintContents):

LayoutTests:

- adjust to changed record format;
- simplify test using InspectorTest.evaluateWithTimeline().

* http/tests/inspector/timeline-test.js:
* inspector/timeline/timeline-layout-expected.txt:
* inspector/timeline/timeline-paint-expected.txt:
* inspector/timeline/timeline-paint.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f0ea769
    • zarvai@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. · 1e8ff9ad
      zarvai@inf.u-szeged.hu authored 
      * platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Rebaseline after r147164.
* platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Rebaseline after r147164.
* platform/qt/TestExpectations:
* platform/qt/compositing/contents-opaque/control-layer-expected.txt: Rebaseline after r147127.
* platform/qt/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Rebaseline after r147164.
* platform/qt/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Rebaseline after r147164.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e8ff9ad
    • caseq@chromium.org's avatar
      Web Inspector: generalize InspectorDOMAgent::highlightRect() to highlightQuad() · 6891828a
      caseq@chromium.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=112911

Reviewed by Pavel Feldman.

- added Quad type and DOMAgent.highlightQuad() to protocol;
- retained DOMAgent.highlightRect(), but implement it via highlightQuad.

* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::parseQuad):
(WebCore):
(WebCore::InspectorDOMAgent::highlightRect):
(WebCore::InspectorDOMAgent::highlightQuad):
(WebCore::InspectorDOMAgent::innerHighlightQuad):
* inspector/InspectorDOMAgent.h:
(InspectorDOMAgent):
* inspector/InspectorOverlay.cpp: Mostly just renames of rect to quad.
(WebCore::InspectorOverlay::paint):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::hideHighlight):
(WebCore::InspectorOverlay::highlightQuad):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::drawQuadHighlight):
(WebCore::InspectorOverlay::reportMemoryUsage):
* inspector/InspectorOverlay.h:
(InspectorOverlay):
* inspector/InspectorOverlayPage.html: Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6891828a
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 40ba0c40
      zandobersek@gmail.com authored 
      * platform/gtk/TestExpectations: Adding a crashing expectation for the
ttp/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html layout test. Skipping the perf/ tests when
using the debug build.
* platform/gtk/fast/text/shaping/shaping-selection-rect-expected.txt: Rebaselining after r147156.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40ba0c40
    • commit-queue@webkit.org's avatar
      [EFL] New baselines for accessibility tests. · e8979e1d
      commit-queue@webkit.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=113510

Unreviewed, EFL gardening.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-03-29

* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/efl/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added.
* platform/efl/accessibility/aria-checkbox-text-expected.txt: Added.
* platform/efl/accessibility/aria-combobox-expected.txt: Added.
* platform/efl/accessibility/aria-fallback-roles-expected.txt: Added.
* platform/efl/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Added.
* platform/efl/accessibility/aria-menubar-menuitems-expected.txt: Added.
* platform/efl/accessibility/aria-roles-expected.txt: Added.
* platform/efl/accessibility/aria-tables-expected.txt: Added.
* platform/efl/accessibility/aria-toggle-button-with-title-expected.txt: Added.
* platform/efl/accessibility/canvas-description-and-role-expected.txt: Added.
* platform/efl/accessibility/div-within-anchors-causes-crash-expected.txt: Added.
* platform/efl/accessibility/image-link-expected.txt: Added.
* platform/efl/accessibility/image-map1-expected.txt: Added.
* platform/efl/accessibility/image-map2-expected.txt: Added.
* platform/efl/accessibility/img-alt-tag-only-whitespace-expected.txt: Added.
* platform/efl/accessibility/legend-expected.txt: Added.
* platform/efl/accessibility/menu-list-sends-change-notification-expected.txt: Added.
* platform/efl/accessibility/notification-listeners-expected.txt: Added.
* platform/efl/accessibility/svg-image-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8979e1d
    • commit-queue@webkit.org's avatar
      REGRESSION(r143102): Ignore table cell's height attribute when checking if... · 463bddeb
      commit-queue@webkit.org authored 
      REGRESSION(r143102): Ignore table cell's height attribute when checking if containing block has auto height.
https://bugs.webkit.org/show_bug.cgi?id=113526

Source/WebCore:

It matches shipping Safari and Firefox behaviour.

Patch by Zalan Bujtas <zalan@apple.com> on 2013-03-29
Reviewed by Antti Koivisto.

Test: fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight):

LayoutTests:

Patch by Zalan Bujtas <zalan@apple.com> on 2013-03-29
Reviewed by Antti Koivisto.

* fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height-expected.txt: Added.
* fast/replaced/iframe-with-percentage-height-within-table-with-table-cell-ignore-height.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      463bddeb
    • eustas@chromium.org's avatar
      Web Inspector: [Cookies] CookiesTable should integrate with DataGrid context menu. · c777e938
      eustas@chromium.org authored 
      https://bugs.webkit.org/show_bug.cgi?id=113496

Reviewed by Pavel Feldman.

Integrate CookiesTable with DataGrid context menu
instead of overriding it.

* inspector/front-end/CookiesTable.js:
Pass context menu callback to DataGrid constructor.
* inspector/front-end/DataGrid.js:
Added context menu callback constructor parameter. Fixed JSDoc.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c777e938
  3. 28 Mar, 2013 26 commits