1. 23 May, 2007 14 commits
  2. 22 May, 2007 18 commits
    • weinig's avatar
      Rubber stamped by Adam. · a0c15a43
      weinig authored
              Fix license.
      
              * bindings/js/JSHTMLAnchorElementCustom.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0c15a43
    • weinig's avatar
      LayoutTests: · 40d22abd
      weinig authored
              Reviewed by Adam.
      
              Update tests for http://bugs.webkit.org/show_bug.cgi?id=13833
              Add ObjC DOM binding for HTMLMarqeeElement
      
              * fast/dom/wrapper-classes-expected.txt:
              * fast/dom/wrapper-classes.html: HTMLMarqueeElement now is a 
              DOMHTMLMarqueeElement
      
      WebCore:
      
              Reviewed by Adam.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
              Add ObjC DOM binding for HTMLMarqeeElement
      
              - Also adds missing DOMHTMLFramePrivate.
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/objc/DOM.mm:
              (WebCore::createElementClassMap):
              * bindings/objc/DOMHTML.h:
              * bindings/objc/DOMInternal.h:
              * bindings/objc/DOMPrivate.h:
              * bindings/objc/PublicDOMInterfaces.h:
      
      WebKit:
      
              Reviewed by Adam.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
              Add ObjC DOM binding for HTMLMarqeeElement
      
              - Also adds missing DOMHTMLFramePrivate.
      
              * MigrateHeaders.make:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40d22abd
    • justing's avatar
      LayoutTests: · bac741c4
      justing authored
              Reviewed by darin
              
              http://bugs.webkit.org/show_bug.cgi?id=13804
              REGRESSION(r21611): Several new layout test pixel failures (misspelling markers)
      
              * editing/selection/13804-expected.checksum: Added.
              * editing/selection/13804-expected.png: Added.
              * editing/selection/13804-expected.txt: Added.
              * editing/selection/13804.html: Added.
              These were missing:
              * editing/selection/5076323-1-expected.png: Added.
              * editing/selection/5076323-2-expected.png: Added.
              * editing/selection/5076323-3-expected.png: Added.
      
      WebCore:
      
              Reviewed by darin, who found the fix independently.
      
              http://bugs.webkit.org/show_bug.cgi?id=13804
              REGRESSION(r21611): Several new layout test pixel failures (misspelling markers)
              
              r21611 exposed a bug in the way removeMarkers computes
              the end of the range to remove markers from.  It also
              introduced a bug: removeMarkers expects a startOffset
              and a length, not a startOffset and an endOffset (added 
              a layout test).
      
              * dom/Document.cpp:
              (WebCore::Document::removeMarkers): The other removeMarkers
              expects a startOffset and a length, not a startOffset and
              an endOffset.
              (WebCore::Document::removeMarkers): Fixed the endOffset
              from length and startOffset calculation.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bac741c4
    • hyatt's avatar
      Add layout test for better background dumping. · bb21e287
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb21e287
    • hyatt's avatar
      Fix for bug 13802, background colors can't be reset to default · 0beef8a8
      hyatt authored
              color.  Fix the value cssText method to do the right thing for background
              and background-position values.
      
              Reviewed by beth
      
              fast/dom/background-shorthand-csstext.html
      
              * css/CSSInitialValue.h:
              (WebCore::CSSInitialValue:::m_implicit):
              (WebCore::CSSInitialValue::isImplicitInitialValue):
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
              (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
              * css/CSSMutableStyleDeclaration.h:
              * css/CSSValue.h:
              (WebCore::CSSValue::isImplicitInitialValue):
              * css/cssparser.cpp:
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseBackgroundShorthand):
              (WebCore::CSSParser::parseShorthand):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0beef8a8
    • darin's avatar
      LayoutTests: · cc06b695
      darin authored
              Reviewed by Geoff.
      
              - test for <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong
      
              * fast/dom/iframe-document.html: Updated test to expect no document property.
              * fast/dom/iframe-document-expected.txt: Updated.
      
              * fast/forms/focus2.html: Changed test to use ownerDocument instead of document.
      
      WebCore:
      
              Reviewed by Geoff.
      
              - fix <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong
      
              The code on ebay was looking for the "document" property on a iframe.
              We changed that to be the ownerDocument rather than the contentDocument,
              which was not what ebay was expecting. The best fix seems to be removing
              the document property altogether.
      
              Test: fast/dom/iframe-document.html
      
              * bindings/js/kjs_html.h: Remove ElementDocument.
              * bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): Ditto.
      
      WebKit:
      
              Reviewed by Geoff.
      
              * WebInspector/webInspector/treeoutline.js: Use ownerDocument instead of non-standard
              document property.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc06b695
    • adele's avatar
      Reviewed by Darin. · e1787a6a
      adele authored
              A little cleanup from my last checkin.
      
              * page/Chrome.h: Formatting change.
              * page/mac/ChromeMac.mm: Fixed copyright.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1787a6a
    • adele's avatar
      LayoutTests: · 82c11d19
      adele authored
              Reviewed by Darin.
      
              Test for http://bugs.webkit.org/show_bug.cgi?id=13796
              Crash in [NSInputContext currentInputContext] when you click on this map
      
              * fast/frames/frame-display-none-focus-expected.txt: Added.
              * fast/frames/frame-display-none-focus.html: Added.
              * fast/frames/resources/iframe-focus.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              Fix for http://bugs.webkit.org/show_bug.cgi?id=13796
              Crash in [NSInputContext currentInputContext] when you click on this map
      
              This is another case of <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts
      
              Test: fast/frames/frame-display-none-focus.html
      
              * WebCore.xcodeproj/project.pbxproj: Added ChromeMac.mm
              * page/Chrome.h:
              * page/mac/ChromeMac.mm: Added.
              (WebCore::Chrome::focusNSView): Moved code from Widget::setFocus so it can be used whenever we need to make a view the first responder.
              * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView): Calls focusNSView.
              * platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): Calls focusNSView.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82c11d19
    • justing's avatar
      LayoutTests: · 384cf314
      justing authored
              Reviewed by darin
              
              <rdar://problem/4875189> List is deleted when replacing contents with Chinese/Japanese characters
      
              Moved from unsupported-content because we've supported editing lists
              for a while now:
              * editing/deleting/4875189-expected.checksum: Added.
              * editing/deleting/4875189-expected.png: Added.
              * editing/deleting/4875189-expected.txt: Added.
              * editing/deleting/4875189.html: Added.
              * editing/unsupported-content/list-delete-002-expected.checksum: Removed.
              * editing/unsupported-content/list-delete-002-expected.png: Removed.
              * editing/unsupported-content/list-delete-002-expected.txt: Removed.
              * editing/unsupported-content/list-delete-002.html: Removed.
              
              Reflects new behavior:
              * editing/deleting/delete-select-all-003-expected.checksum:
              * editing/deleting/delete-select-all-003-expected.png:
              * editing/deleting/delete-select-all-003-expected.txt:
              
              Ditto and also removed a FIXME:
              * editing/deleting/list-item-1-expected.checksum:
              * editing/deleting/list-item-1-expected.png:
              * editing/deleting/list-item-1-expected.txt:
              * editing/deleting/list-item-1.html:
      
      WebCore:
      
              Reviewed by darin
              
              <rdar://problem/4875189> 
              List is deleted when replacing contents with Chinese/Japanese characters
      
              * editing/htmlediting.cpp:
              (WebCore::isSpecialElement): Lists are no longer special.
              They can be removed by removing their content and then 
              then hitting delete inside of the empty list item that's 
              left over. Even when that list item is the first thing 
              in the editable region.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      384cf314
    • adele's avatar
      Reviewed by Darin. · 6793e484
      adele authored
              Adding some asserts to help detect other cases of <rdar://problem/5171145>
      
              * WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge makeFirstResponder:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6793e484
    • darin's avatar
      Reviewed by Tim Hatcher. · da7cd15c
      darin authored
              - fix <rdar://problem/5206089> REGRESSION: hovering over amazon.com "product categories"
                tab makes page content disappear
      
              The contentWindow property was doing a cross-frame security check, but it shouldn't.
              Window objects are responsible for protecting themselves from cross-frame activity.
              Because contentWindow returned undefined, we then ended up setting visibility on the
              body of the main frame to "hidden".
      
              No layout test yet. When we make cross-domain tests, we should include this one.
      
              * html/HTMLFrameElement.idl: Removed CheckFrameSecurity attribute from contentWindow.
              * html/HTMLIFrameElement.idl: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da7cd15c
    • kmccullo's avatar
      Reviewed by. · e3681b65
      kmccullo authored
              - Forgot to checkin for fix for rdar://problem/4981886
      
              * fast/dom/open-and-close-by-DOM-expected.txt: Added.
              * fast/dom/open-and-close-by-DOM.html: Added.
              * fast/dom/resources/close.html: Added.
              * fast/dom/resources/middle.html: Added.
              * http/tests/security/local-image-from-remote.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3681b65
    • justing's avatar
      LayoutTests: · 00b7e557
      justing authored
              Reviewed by oliver
      
              <rdar://problem/5213963> 
              REGRESSION(r21467): Active selection remains in text field after clicking on a button
      
              Demonstrates bug:
              * editing/selection/5213963-expected.checksum: Added.
              * editing/selection/5213963-expected.png: Added.
              * editing/selection/5213963-expected.txt: Added.
              * editing/selection/5213963.html: Added.
              We now clear the selection on mouse down (but not before
              the mousedown event is fired):
              * fast/forms/focus-selection-input-expected.txt:
              * fast/forms/focus-selection-textarea-expected.txt:
      
      WebCore:
      
              Reviewed by oliver
      
              <rdar://problem/5213963>
              REGRESSION(r21467): Active selection remains in text field after clicking on a button
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dispatchMouseEvent): Call
              FocusController::setFocusedNode, because Document::setFocusedNode
              no longer clears the selection.
              Begin passing the new focused frame to 
              FocusController::setFocusedNode, because when the 
              new focus node is null, the selection should only be 
              cleared if the focused frame isn't changing.
              (WebCore::Element::focus): Begin passing the new focused
              frame.
              (WebCore::Element::blur): Ditto.
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::focus): Ditto.
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::focus): Ditto.
              * page/Frame.cpp:
              (WebCore::Frame::setFocusedNodeIfNeeded): Ditto.
              * page/FocusController.cpp:
              (WebCore::clearSelectionIfNeeded): Take in the new
              focused frame.  If it's not changing, don't clear the
              selection.
              (WebCore::FocusController::setFocusedNode): Take
              in the new focused frame.
              * page/FocusController.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00b7e557
    • beidson's avatar
      Reviewed by Kevin (Sarge) · cc652ea3
      beidson authored
              <rdar://problem/5219885> - Crash after closing a inline popup ad at http://news.yahoo.com/
      
              This regressed in http://trac.webkit.org/projects/webkit/changeset/21618
      
              * WebView/WebFrame.mm:
              (-[WebFrame dataSource]): Null check the frameloader
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc652ea3
    • staikos's avatar
      back this out for zack · df04993a
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df04993a
    • zack's avatar
      Path implementing more Cliboard from Marius Bugge Monsen. · 329e627d
      zack authored
      Adding implementations of some of the missing methods.
      r=me
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      329e627d
    • hausmann's avatar
      Fix http headers for POST. · 088e3448
      hausmann authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      088e3448
    • justing's avatar
      Updating expected results for r21074. · 18125c04
      justing authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18125c04
  3. 21 May, 2007 8 commits
    • oliver's avatar
      2007-05-21 Oliver Hunt <oliver@apple.com> · 7fa2f31b
      oliver authored
      LayoutTests:
      
              Reviewed by Sam.
              
              Layout test for http://bugs.webkit.org/show_bug.cgi?id=13789
      
              * svg/custom/getscreenctm-in-mixed-content-expected.checksum: Added.
              * svg/custom/getscreenctm-in-mixed-content-expected.png: Added.
              * svg/custom/getscreenctm-in-mixed-content-expected.txt: Added.
              * svg/custom/getscreenctm-in-mixed-content.xhtml: Added.
      
      WebCore:
      
              Reviewed by Sam.
              
              Fix for http://bugs.webkit.org/show_bug.cgi?id=13789 
              -- SVGLocatable::getScreenCTM() faulty
              
              Needed to update SVGLength to handle the case where the SVGElement is
              not the root document element -- we do this by falling back on the 
              renderer for the context.
              
              For <svg> elements embedded as mixed content in xhtml we consider the
              absolutePosition of the parent to be the origin for the <svg> element.
      
              * ksvg2/svg/SVGLength.cpp:
              (WebCore::SVGLength::PercentageOfViewport):
              * ksvg2/svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::getScreenCTM):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fa2f31b
    • thatcher's avatar
      Reviewed by Adam. · 428cde24
      thatcher authored
              <rdar://problem/5084400> -[DOMRange lineBoxRects] returns an empty array when the DOM nodes have just been created
      
              Do a updateLayoutIgnorePendingStylesheets before asking the Node or Range for it's box rects.
      
              * bindings/objc/DOM.mm:
              (-[DOMNode boundingBox]):
              (-[DOMNode lineBoxRects]):
              (-[DOMRange boundingBox]):
              (-[DOMRange lineBoxRects]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      428cde24
    • weinig's avatar
      Reviewed by George Staikos. · 151497a0
      weinig authored
              Fix Qt build.
      
              * WebCore.pro: add missing IDL files.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      151497a0
    • weinig's avatar
      LayoutTests: · 4d7ce9a5
      weinig authored
              Reviewed by Darin.
      
              - update tests and results for http://bugs.webkit.org/show_bug.cgi?id=13803
                to account for the new JSHTMLMarquee that is being autogenerated and
                can now produce a constructor.
      
              * fast/dom/Window/element-constructors-on-window-expected.txt:
              * fast/dom/Window/element-constructors-on-window.html:
              * fast/dom/Window/window-properties-expected.txt:
      
      WebCore:
      
              Reviewed by Darin.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13803
              Autogenerate the JS bindings for the HTMLMarqueeElement.
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              * bindings/js/kjs_css.cpp:
              (KJS::DOMCSSRule::getOwnPropertySlot): Fix possible null pointer issue.
              (KJS::DOMCSSRule::put): Fix possible null pointer issue.
              * bindings/js/kjs_html.cpp:
              (KJS::):
              (KJS::JSHTMLElement::classInfo):
              (KJS::JSHTMLElement::accessors):
              (KJS::JSHTMLElement::getOwnPropertySlot): Fix null pointer issue.
              (KJS::HTMLElementFunction::callAsFunction):
              (KJS::JSHTMLElement::put):
              * bindings/js/kjs_html.h:
              (KJS::JSHTMLElement::):
              * html/HTMLMarqueeElement.cpp:
              (WebCore::HTMLMarqueeElement::start):
              (WebCore::HTMLMarqueeElement::stop):
              * html/HTMLMarqueeElement.h: Add start() and stop() functions.
              * html/HTMLMarqueeElement.idl: Added.
              * page/DOMWindow.idl: Add marquee constructor.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d7ce9a5
    • adele's avatar
      WebCore: · dd237c40
      adele authored
              Fix by Darin, reviewed by me.
      
              Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts
      
              * platform/mac/WidgetMac.mm:
              (WebCore::safeRemoveFromSuperview): Added. If the view is the window's first responder, then 
               set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it.
              (WebCore::Widget::setFocus): Don't attempt to focus the view if it has no window.
              (WebCore::Widget::removeFromSuperview): Call safeRemoveFromSuperview.
              (WebCore::Widget::afterMouseDown): ditto.
      
      WebKit:
      
              Fix by Darin, reviewed by me.
      
              Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts
      
              * WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): If the old view is the first responder,
              then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd237c40
    • weinig's avatar
      · b3baea79
      weinig authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3baea79
    • hyatt's avatar
      Make a line gutter backdrop so that tiny view source docs don't look · 52b9b637
      hyatt authored
              bad.
      
              Reviewed by aroben
      
              * css/view-source.css:
              * html/HTMLViewSourceDocument.cpp:
              (WebCore::HTMLViewSourceDocument::createContainingTable):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52b9b637
    • hyatt's avatar
      Make sure to distinguish between links to internal resources and · 339df964
      hyatt authored
              real links (anchors) in view source mode.
      
              Reviewed by aroben
      
              * css/view-source.css:
              * html/HTMLViewSourceDocument.cpp:
              (WebCore::HTMLViewSourceDocument::addViewSourceToken):
              (WebCore::HTMLViewSourceDocument::addLink):
              * html/HTMLViewSourceDocument.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      339df964