1. 15 Nov, 2002 12 commits
    • darin's avatar
      * kwq/KWQWindowWidget.mm: (KWQWindowWidget::setFrameGeometry): · df95e87e
      darin authored
      	Oops. Make that display:YES.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df95e87e
    • darin's avatar
      - fixed 3090219 -- Window jumps up and down when loading nikon page · 3cbec6d6
      darin authored
              * kwq/KWQWindowWidget.mm: (KWQWindowWidget::setFrameGeometry):
      	Don't pass display:NO when resizing the window.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cbec6d6
    • darin's avatar
      61200eb4
    • mjs's avatar
      - fixed 3102016 - REGRESSION: Command-clicking on a link can open _two_ windows. · b8cae6d0
      mjs authored
              * WebView.subproj/WebDataSourcePrivate.h:
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSource _setJustOpenedForTargetedLink:]):
              (-[WebDataSource _justOpenedForTargetedLink]):
              * WebView.subproj/WebFrame.m:
              (-[WebFrame findOrCreateFramedNamed:]):
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _continueAfterNavigationPolicy:]):
              (-[WebFrame _loadDataSource:withLoadType:]):
              (-[WebFrame _downloadRequest:toPath:]):
              (-[WebFrame _setJustOpenedForTargetedLink:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8cae6d0
    • kocienda's avatar
      Remove characters RFC 2396 describes as "unwise" from the · c911ccf5
      kocienda authored
      	BadChar character class. This causes them to remain unescaped
      	in KURL objects. As a result, some extra escaping needed to
      	be added into the getNSURL() function to enable NSURL
      	objects to be created using a KURL.
      
      	This enables me to fix this bug:
      	Radar 3050437 (Clicking link leads to page with garbled content)
      
      	Note, however, that my fix for 3050437 relies on this bug remaining unfixed:
      
      	Radar 3102332 (Square bracket characters "sneak through" CFURL illegal character checks)
      
              * kwq/KWQKURL.mm:
              (KURL::getNSURL)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c911ccf5
    • darin's avatar
      * WebView.subproj/WebFramePrivate.m: · 960f8f20
      darin authored
              (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):
      	Give the listener a slightly longer lifetime, to make this API a bit more foolproof.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      960f8f20
    • darin's avatar
      Tools: · 56fdc7dc
      darin authored
              * Scripts/update-alex-localizable-strings: Fix it so that the line
      	numbers in error messages will be accurate.
      
      WebCore:
      
      	- fixed 3027460 -- text areas don't have focus rectangles
      	- fixed 2937204 -- text areas have solid black borders
      
              * kwq/KWQSignal.mm: (KWQSignal::disconnect):
      	Add a special case so we don't hear about finishedParsing all the time.
      
              * kwq/KWQTextArea.mm:
              (-[KWQTextArea initWithFrame:]): Use a bezel border, not a line border.
              (-[KWQTextArea getCursorPositionAsIndex:inParagraph:]): Fix bug where it would
      	return a bogus value for an empty text area.
              (-[KWQTextArea setCursorPositionToIndex:inParagraph:]): Use setSelectedRange:
      	ratherr than setMarkedText:selectedRange:.
              (-[KWQTextArea drawRect:]): Draw a focus ring if our text view is first responder.
              (-[KWQTextArea _KWQ_setKeyboardFocusRingNeedsDisplay]): Added.
              (-[KWQTextAreaTextView becomeFirstResponder]): Call _KWQ_setKeyboardFocusRingNeedsDisplay.
              (-[KWQTextAreaTextView resignFirstResponder]): Call _KWQ_setKeyboardFocusRingNeedsDisplay.
              (-[NSView _KWQ_setKeyboardFocusRingNeedsDisplay]): Calls the same thing on parent.
      
              * WebCore.pbproj/project.pbxproj: PB is a cruel master.
      
      WebBrowser:
      
      	- fixed problem I introduced where text would get too close to the right button
      
              * LocationTextField.m: (-[LocationTextField didShowOrHideRightButton]):
      	Add back logic to adjust the right border. I removed this because it was incompatible
      	with my changes, but now I made a new compatible version by adding a new method.
      
              * TextFieldWithControls.h: Rename showRightButton: to setIsShowingRightButton:,
      	and added isShowingRightButton, and didShowOrHideRightButton methods.
              * TextFieldWithControls.m:
              (-[TextFieldWithControls isShowingRightButton]): Added.
              (-[TextFieldWithControls didShowOrHideRightButton]): Added.
              (-[TextFieldWithControls setIsShowingRightButton:]): Call didShowOrHideRightButton at
      	the right moment so we can properly respond to any changes it makes to the cell.
      
              * BrowserWindowController.m: (-[BrowserWindowController updateSnapBackButtons]):
      	Update for method name change.
      
              * WebBrowser.pbproj/project.pbxproj: PB is a cruel master.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56fdc7dc
    • mjs's avatar
      Fix world leak I introduced, and also add an early return when needed. · 4e042174
      mjs authored
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]):
              (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e042174
    • mjs's avatar
      * khtml/html/html_formimpl.cpp: · ab1f48ef
      mjs authored
              (HTMLInputElementImpl::attach): Removed a stray printf.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab1f48ef
    • mjs's avatar
      WebKit: · 62074c91
      mjs authored
      	Make navigation policy asynchronous for real.
      
              * WebKit.pbproj/project.pbxproj:
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebControllerPolicyDelegate.m:
              (-[WebPolicyDecisionListenerPrivate initWithTarget:action:]):
              (-[WebPolicyDecisionListenerPrivate dealloc]):
              (-[WebPolicyDecisionListener usePolicy:]):
              (-[WebPolicyDecisionListener _initWithTarget:action:]):
              (-[WebPolicyDecisionListener dealloc]):
              (-[WebPolicyDecisionListener _invalidate]):
              * WebView.subproj/WebControllerPolicyDelegatePrivate.h: Added.
              * WebView.subproj/WebDefaultPolicyDelegate.m:
              (-[WebDefaultPolicyDelegate decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
              * WebView.subproj/WebFrame.m:
              (-[WebFrame stopLoading]):
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFramePrivate dealloc]):
              (-[WebFrame _invalidatePendingPolicyDecisionCallingDefaultAction:]):
              (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):
              (-[WebFrame _continueAfterNavigationPolicy:]):
              (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):
              (-[WebFrame _loadDataSource:withLoadType:]):
      
      WebBrowser:
      
      	Make navigation policy asynchronous.
      
              * BrowserWebController.m:
              (-[BrowserWebController decideNavigationPolicyForAction:andRequest:inFrame:decisionListener:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62074c91
    • mjs's avatar
      Wrap content policy invocation to look asynchronous. · 252d3fe7
      mjs authored
              * WebView.subproj/WebBaseResourceHandleDelegate.h:
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient continueAfterContentPolicy:response:]):
              (-[WebMainResourceClient checkContentPolicyForResponse:andCallSelector:]):
              (-[WebMainResourceClient handle:didReceiveResponse:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      252d3fe7
    • mjs's avatar
      Refactor so that all invocations of navigation policy are set up · 604b1965
      mjs authored
      	to be asynchronous. However, the actually delegate method is not
      	async yet.
      
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _checkNavigationPolicyForRequest:dataSource:andCall:withSelector:]):
              (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:request:]):
              (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):
              (-[WebFrame _continueLoadRequestAfterNavigationPolicy:request:]):
              (-[WebFrame _loadDataSource:withLoadType:]):
              * WebView.subproj/WebMainResourceClient.h:
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient stopLoadingForPolicyChange]):
              (-[WebMainResourceClient continueAfterNavigationPolicy:request:]):
              (-[WebMainResourceClient handle:willSendRequest:]):
              (-[WebMainResourceClient handle:didReceiveResponse:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      604b1965
  2. 14 Nov, 2002 17 commits
    • darin's avatar
      WebCore: · bd6a1fde
      darin authored
      	- fixed most of the problems with OPTGROUP
      
              * khtml/html/htmlparser.cpp: (KHTMLParser::insertNode):
      	Make OPTGROUPs pop out of other unclosed OPTGROUPs, not just out of options.
      
              * kwq/KWQListBox.h: Add private member function.
              * kwq/KWQListBox.mm:
              (QListBox::insertItem): Use shared insertItem function.
              (QListBox::insertGroupLabel): Create an attributed string for the group label,
      	with bold font.
              (-[KWQListBoxTableViewDelegate tableView:shouldSelectRow:]): Return YES only
      	for the plain strings, that way you can't select the group labels.
      
              * WebCore.pbproj/project.pbxproj: Let PB do its thing.
      
      WebBrowser:
      
              * BrowserDocument.h: Remove unused BrowserDocumentPageTitleChangedNotification.
              * BrowserDocument.m:
              (-[BrowserDocument _pageTitleHasChanged]): Remove unused notification.
              (-[BrowserDocument goToBugReportingPage:]): Escape URL so it works in the form parameters.
      
              * PoofAnimator.m: (-[PoofAnimator init]): Remove use of private _setHasShadow:
      	which is just the same thing as the public setHasShadow:.
      
              * BrowserWindowController.m: Tweak formatting.
              * Preferences.subproj/GeneralPreferences.m: Tweak.
      
              * WebBrowser.pbproj/project.pbxproj: Let PB do its thing.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd6a1fde
    • mjs's avatar
      Refactor things a bit so all loads bottleneck through a single · 7a17f0c4
      mjs authored
      	method (_loadDataSource:withLoadType:).
      
              * WebView.subproj/WebFrame.m:
              (-[WebFrame loadRequest:]):
              (-[WebFrame reload]):
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _loadItem:fromItem:withLoadType:]):
              (-[WebFrame _loadRequest:triggeringAction:loadType:]):
              (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):
              (-[WebFrame _postWithURL:data:contentType:triggeringEvent:]):
              (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]):
              (-[WebFrame _loadDataSource:withLoadType:]):
              (-[WebFrame _downloadRequest:toPath:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a17f0c4
    • mjs's avatar
      WebKit: · 6a96e2b0
      mjs authored
      	Change things so the public interface to loading is loadRequest:
      	and everything else is private.
      
              * Plugins.subproj/WebBaseNetscapePluginView.m:
              (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]):
              * Plugins.subproj/WebPluginController.m:
              (-[WebPluginController showURL:inFrame:]):
              * WebView.subproj/WebController.h:
              * WebView.subproj/WebController.m:
              (-[WebController init]):
              * WebView.subproj/WebControllerPrivate.m:
              (-[WebController _createFrameNamed:inParent:allowsScrolling:]):
              (-[WebController _downloadURL:toPath:]):
              * WebView.subproj/WebFrame.h:
              * WebView.subproj/WebFrame.m:
              (-[WebFrame init]):
              (-[WebFrame initWithName:webView:controller:]):
              (-[WebFrame loadRequest:]):
              (-[WebFrame reload]):
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _timedLayout:]):
              (-[WebFrame _clearProvisionalDataSource]):
              (-[WebFrame _loadItem:fromItem:withLoadType:]):
              (-[WebFrame _loadRequest:triggeringAction:]):
              (-[WebFrame _reloadAllowingStaleDataWithOverrideEncoding:]):
              (-[WebFrame _itemForRestoringDocState]):
              (-[WebFrame _setProvisionalDataSource:]):
              (-[WebFrame _startLoading]):
              (-[WebFrame _downloadRequest:toPath:]):
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient handle:willSendRequest:]):
              (-[WebMainResourceClient stopLoadingAfterContentPolicy]):
              (-[WebMainResourceClient handle:didReceiveResponse:]):
              * WebView.subproj/WebView.m:
              (-[WebView concludeDragOperation:]):
      
      WebBrowser:
      
      	Change things so the public interface to loading is loadRequest:
      	and everything else is private.
      
              * BrowserDocument.m:
              (-[BrowserDocument goToRequest:]):
              * BrowserWebController.m:
              (-[BrowserWebController initWithBrowserDocument:]):
              * Debug/SnippetController.h:
              * Debug/SnippetController.m:
              (-[SnippetController dealloc]):
              (-[SnippetController windowWillClose:]):
              (-[SnippetController load]):
              (-[SnippetController loadComplete]):
              (-[SnippetController mainDataSource]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a96e2b0
    • hyatt's avatar
      Fix spinner.com mislayout on the PLT. Make sure · 5ee8b596
      hyatt authored
      	<input type=image> honors the width attribute and
      	make sure that its render object calls updateFromElement.
      
              * khtml/html/html_formimpl.cpp:
              (HTMLInputElementImpl::parseAttribute):
              (HTMLInputElementImpl::attach):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ee8b596
    • hyatt's avatar
      Move text measurement and layout beyond onload. This · d4a14ac7
      hyatt authored
      	shoudl speed up i-bench substantially and morrison's
      	PLT test slightly.  Note that the adjustFrames layout
      	stuff has been removed from isLoadComplete.
      
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _timedLayout:]):
              (-[WebFrame _isLoadComplete]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4a14ac7
    • hyatt's avatar
      Move text measurement and layout beyond onload. This · 5159d9c2
      hyatt authored
      	shoudl speed up i-bench substantially and morrison's
      	PLT test slightly.
      
      	Also allow <table>s as children of <p> and <h1>-<h6>.
      	This fixes floats on slashdot.org (the left side) and
      	the floating tables in articles on wired.com.
      
              * khtml/html/dtd.cpp:
              (DOM::checkChild):
              * khtml/html/html_documentimpl.cpp:
              (HTMLDocumentImpl::HTMLDocumentImpl):
              (HTMLDocumentImpl::close):
              * khtml/html/html_documentimpl.h:
              * khtml/html/htmlparser.cpp:
              (KHTMLParser::insertNode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5159d9c2
    • rjw's avatar
      Fixed 3099505. With the recent white space changes, multiple slaves may · 852d80b2
      rjw authored
              be created for contiguous text on the same line.  The fix changes the
              iteration order of over the slave array.  Now, when searching for the end
              point of a line we'll always find the last slave on a line first.
      
              * khtml/khtml_part.cpp:
              (lastSlaveAt):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      852d80b2
    • darin's avatar
      - fixed 3095854 -- small select boxes get no scrollbar · 5e10a7c6
      darin authored
              * kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines):
      	Always use a minimum of 4 lines.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e10a7c6
    • darin's avatar
      WebFoundation: · 726fa2c5
      darin authored
              * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
      
      WebKit:
      
              * English.lproj/Localizable.strings: Updated to include the new
      	error messages that Maciej just added. I wonder what effect this
      	will have if we see those errors in Alex-32?
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      726fa2c5
    • sheridan's avatar
      Alex-32 stamp · 98191978
      sheridan authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98191978
    • darin's avatar
      - fixed 3101243 -- excite passes date that can't be parsed, results in bogus... · 64f2d797
      darin authored
      	- fixed 3101243 -- excite passes date that can't be parsed, results in bogus date at top right corner
      
              * kjs/date_object.cpp: (KJS::KRFCDate_parseDate): Handle errors from strtol
      	by checking errno. Check the "string in a haystack" to be sure it's a multiple
      	of 3. Add case that allows year to be after time.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64f2d797
    • darin's avatar
      - fixed 3101191 -- REGRESSION: Hang loading excite.com · 4fb58d6d
      darin authored
              * kjs/date_object.cpp:
              (mktimeUsingCF): Pick an arbitrary cutoff of 3000, and return -1 if the
      	year passed in is that big so we don't infinite loop. Also validate the
      	rest of the date with CFGregorianDateIsValid.
              (DateProtoFuncImp::call): Handle a -1 result from mktime.
              (DateObjectImp::construct): Check for NaN before calling mktime, and also
      	handle a -1 result from mktime.
              (DateObjectFuncImp::call): Check for NaN before calling mktime, and also
      	handle a -1 result from mktime.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4fb58d6d
    • gramps's avatar
      * WebView.subproj/WebControllerPolicyDelegate.h: · 76387d3c
      gramps authored
      Added missing semi-colon in definition of WebPolicyDecisionListener to
      fix build error.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76387d3c
    • mjs's avatar
      WebKit: · 61d1c337
      mjs authored
      	Combined file URL policy with content policy. We don't actually
      	bother to ask earlier for file URLs yet, since that will make
      	things more complicated.
      
              * Misc.subproj/WebKitErrors.h:
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebDefaultPolicyDelegate.m:
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _handleUnimplementablePolicy:errorCode:forURL:]):
              (-[WebFrame _continueAfterNavigationPolicyForRequest:dataSource:]):
              * WebView.subproj/WebMainResourceClient.h:
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient stopLoadingAfterContentPolicy]):
              (-[WebMainResourceClient handle:didReceiveResponse:]):
              * WebView.subproj/WebView.m:
              (+[WebView initialize]):
      
      WebBrowser:
      
      	Combined file URL policy with content policy. Also adjusted error
      	handling to continue to handle file errors well.
      
              * BrowserWebController.m:
              (-[BrowserWebController unableToImplementPolicy:error:forURL:inFrame:]):
              (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]):
              * LocationChangeError.m:
              (-[LocationChangeHandler specializedTitleForError:]):
              (-[LocationChangeHandler specializedMessageForError:]):
              * LocationChangeHandler.m:
              (-[LocationChangeHandler locationChangeDone:forDataSource:]):
              * WebBrowser.pbproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61d1c337
    • darin's avatar
      WebCore: · 043758d8
      darin authored
      	- fixed 3099240 -- REGRESSION: repro assert d->m_doc->parsing
      
      	Don't force all redirects to be reloads, because the ones from JavaScript must
      	not be. Maybe a better solution post-Alex-32 will be to pass a flag that distinguishes
      	redirects from other location changes.
      
              * khtml/khtml_part.cpp: (KHTMLPart::slotRedirect): Don't ignore the anchor when
      	comparing URLs to see if they should be a reload. We'll still do a reload if the URLs
      	are actually equal, but if they differ in anchor we will just go to the anchor.
      	This is the bug fix.
      
              * kwq/WebCoreBridge.h: Add reload parameter.
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge openURL:reload:headers:]): Stuff the reload
      	parameter into the URLArgs.
      
      WebKit:
      
      	- fixed 3099240 -- REGRESSION: repro assert d->m_doc->parsing
      
      	Make the reload flag pass across the bridge.
      
              * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]):
      	Pass a reload flag, based on the load type, to the bridge.
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]): Pass a
      	reload flag of NO in the anchor case. Preserve reload load types even when
      	doing client redirects (have to talk with Trey about this tomorrow).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      043758d8
    • darin's avatar
      WebCore: · 3866e312
      darin authored
      	- fixed 3100235 -- nil-deference in khtml::RenderTable at money.cnn.com
      
              * kwq/WebCoreBridge.h: Add needsLayout.
              * kwq/WebCoreBridge.mm: (-[WebCoreBridge needsLayout]): Return true if the render
      	tree root says "layouted" is false. It would be more elegant to use more of this
      	WebCore layout logic and have less of our own on the WebKit side.
      
              * WebCore.pbproj/project.pbxproj: Oh, that Project Builder.
      
      WebKit:
      
      	- fixed 3100235 -- nil-deference in khtml::RenderTable at money.cnn.com
      
              * WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):
      	If the WebCore side needs layout, then do layout before trying to draw.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3866e312
    • trey's avatar
      Fixed client redirects, some more. The upshot is that they do not · 3a55cfde
      trey authored
      	generate two items in the back-forward list.  iBench still works.
      
              * WebCoreSupport.subproj/WebBridge.m:
              (-[WebBridge reportClientRedirectTo:delay:fireDate:]):  Call straight to the frame for all impl.
              (-[WebBridge reportClientRedirectCancelled]):  Call straight to the frame for all impl.
              (-[WebBridge loadURL:reload:triggeringEvent:isFormSubmission:]):
      	clientRedirect param removed when sending _loadURL: to frame.
              * WebView.subproj/WebFramePrivate.h:
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _loadURL:loadType:triggeringEvent:isFormSubmission:]):
      	clientRedirect param  removed. Check our own ivar to know if we are in client redirect case.
              (-[WebFrame _loadURL:intoChild:]):
      	clientRedirect param removed when sending _loadURL: .
              (-[WebFrame _clientRedirectedTo:delay:fireDate:]):
      	Note that we are doing a redirect if time=0 and we're not completed.  Also includes
      	previous impl moved from Bridge.
              (-[WebFrame _clientRedirectCancelled]):  Previous impl moved from Bridge.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a55cfde
  3. 13 Nov, 2002 11 commits
    • darin's avatar
      - fixed 3100895 -- REGRESSION: Crash (was assertion) on http://www.w3.org/Style/CSS/ · 53a8ad15
      darin authored
              * khtml/rendering/render_text.h: Add an optional arena parameter to deleteSlaves.
              * khtml/rendering/render_text.cpp:
              (RenderText::detach): Pass the render arena in to deleteSlaves.
              (RenderText::deleteSlaves): Use the passed-in arena.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53a8ad15
    • darin's avatar
      WebFoundation: · 82240090
      darin authored
              * Misc.subproj/WebAssertions.m: (vprintf_stderr_objc):
      	Don't use displayableString. Makes us able to build on Panther.
      
              * WebFoundation.pbproj/project.pbxproj: Project Builder wanted to touch this.
      
      WebCore:
      
      	- fixed another crash on http://www.w3.org/Style/CSS/, but still not done
      
              * khtml/rendering/render_box.cpp: (RenderBox::setStyle): Call renderArena()
      	from RenderObject rather than going at the document directly. Safer because
      	it works even when we don't have a node yet.
              * khtml/rendering/render_flow.cpp: (RenderFlow::addChild): Ditto.
              * khtml/rendering/render_layer.cpp:
              (RenderLayer::paint): Ditto.
              (RenderLayer::nodeAtPoint): Ditto.
              (RenderLayer::constructZTree): Ditto.
              * khtml/rendering/render_list.cpp:
              (RenderListItem::setStyle): Ditto.
              * khtml/rendering/render_text.cpp:
              (RenderText::deleteSlaves): Ditto.
              (RenderText::position): Ditto. This is the one that actually crashed.
      
              * khtml/misc/makeattrs: Fixed handling of failure case.
              * khtml/misc/maketags: Ditto.
      
              * WebCore.pbproj/project.pbxproj: Project Builder wanted to touch this.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82240090
    • darin's avatar
      - fixed 3100895 -- REGRESSION: Assertion on http://www.w3.org/Style/CSS/ · aed62356
      darin authored
      	A few arena-related fixes.
      
              * khtml/rendering/bidi.h: Don't define the operator new without the arena parameter.
      	That way, we get a link failure if we use it by accident, rather than an assert at runtime.
      	It would be even better to get a compile-time error, but I don't know how to make that happen.
              * khtml/rendering/render_layer.h: Ditto.
              * khtml/rendering/render_object.h: Ditto.
              * khtml/rendering/render_text.h: Ditto.
      
              * khtml/rendering/render_container.cpp:
              (RenderContainer::addChild): Create the RenderTable with the appropriate arena.
              (RenderContainer::insertPseudoChild): Create the RenderFlow objects with the appropriate arena.
      
              * khtml/rendering/render_text.cpp: (RenderText::deleteSlaves): Don't try to get the arena
      	when there are no slaves. This can happen after the element is nil, and in that case we will
      	do a nil-dereference.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aed62356
    • darin's avatar
      WebCore: · 9aa61f37
      darin authored
              * kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth):
      	Use the "0" instead of the "x" as the canonical character for width.
      	This is slightly wider and is better for credit card numbers, for example.
      
              * WebCore.pbproj/project.pbxproj: Tweak.
      
      WebBrowser:
      
              * English.lproj/StringsNotToBeLocalized.txt: Let the script sort this file.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9aa61f37
    • darin's avatar
      - fixed 3099930 -- dates/times without time zones are parsed as UTC by kjs, · 65d708f3
      darin authored
      	local time by other browsers
      
              * kjs/date_object.cpp:
              (DateProtoFuncImp::call): Handle the NaN case better, like Mozilla and OmniWeb.
              (DateObjectFuncImp::call): Return NaN rather than Undefined() for bad dates.
              (KJS::parseDate): Return NaN rather than Undefined() or 0 for bad dates.
              (KJS::KRFCDate_parseDate): Return -1 rather than 0 for bad dates.
      	Assume local time if no time zone is passed. Don't return 1 if we parse 0.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65d708f3
    • mjs's avatar
      WebKit: · 065a97f9
      mjs authored
      	Pass mime type instead of full response to content policy delegate
      	method, in preparation for merging it with the file URL policy.
      
              * WebView.subproj/WebControllerPolicyDelegate.h:
              * WebView.subproj/WebDefaultPolicyDelegate.m:
              * WebView.subproj/WebMainResourceClient.m:
              (-[WebMainResourceClient handle:didReceiveResponse:]):
      
      WebBrowser:
      
      	Pass mime type instead of full response to content policy delegate
      	method, in preparation for merging it with the file URL policy.
      
              * BrowserWebController.m:
              (-[BrowserWebController contentPolicyForMIMEType:andRequest:inFrame:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      065a97f9
    • vicki's avatar
      tiny change made by rjw to fix build breakage · f44c6e70
      vicki authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f44c6e70
    • darin's avatar
      WebCore: · aa70db1b
      darin authored
      	- fixed 3083982 -- Logging into AOL gives null view
      
      	Turns out AOL was using a refresh header, which we were not supporting.
      
              * khtml/khtml_part.h: Declare receivedFirstData, a private member function.
              * khtml/khtml_part.cpp:
              (KHTMLPart::receivedFirstData): Separate out the part of slotData we
      	want to share, which really seems kinda separate anyway.
              (KHTMLPart::slotData): More of the same.
      
              * kwq/KWQKHTMLPart.h: Declare addMetaData.
              * kwq/KWQKHTMLPart.mm:
              (KWQKHTMLPart::slotData): Call receivedFirstData instead of doing the same
      	thing ourselves.
              (KWQKHTMLPart::addMetaData): Added. Puts metadata into the job.
      
              * kwq/KWQKHTMLPartBrowserExtension.mm:
              (KHTMLPartBrowserExtension::createNewWindow): Fix bug where this was calling
      	openURL: but meant to call loadURL:.
      
              * kwq/WebCoreBridge.h: Add headers to openURL method. Remove setContentType.
              * kwq/WebCoreBridge.mm:
              (-[WebCoreBridge openURL:withHeaders:]): Handle Content-Type and Refresh.
      	This method is big enough that I should probably move the guts to KWQKHTMLPart.
      
      	- other things
      
              * kwq/KWQListImpl.mm: (KWQListImpl::~KWQListImpl): I overlooked something
      	while doing my "bug fix" in here a while back. Change an assignment statement
      	to an assert.
      
      WebKit:
      
      	- fixed 3083982 -- Logging into AOL gives null view
      
      	Turns out AOL was using a refresh header, which we were not supporting.
      
              * WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]):
      	Call openURL: and pass headers in.
      
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:isFormSubmission:]):
      	Pass nil for headers in this case, since we know it's just an anchor change.
      
      	- other things
      
              * WebCoreSupport.subproj/WebBridge.h: Remove dataSourceChanged and dataSource
      	methods. We try to keep the bridge methods down to actual bridging.
              * WebCoreSupport.subproj/WebBridge.m: Remove dataSourceChanged altogether,
      	and move dataSource up in the file.
      
              * WebView.subproj/WebHTMLRepresentation.m:
              (-[WebHTMLRepresentation setDataSource:]): Keep the data source around, so we
      	don't need to ask the bridge for it.
              (-[WebHTMLRepresentation documentSource]): Use it here.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa70db1b
    • hyatt's avatar
      Fix for floats. Force relayout if collapsing margins · c6ead7fe
      hyatt authored
      	have to adjust the position of an object.
      
              * khtml/rendering/render_flow.cpp:
              (RenderFlow::layoutBlockChildren):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6ead7fe
    • trey's avatar
      Fixed 3100084 - REGRESSION: web page is not first responder after visiting web page · 3795ae7e
      trey authored
              * WebView.subproj/WebDataSourcePrivate.m:
              (-[WebDataSource _commitIfReady]):  Make the rep before _transitionToCommitted.  This is the way it used to be.
              (-[WebDataSource _makeRepresentation]):  Don't make the docView here.
      
              * WebView.subproj/WebFramePrivate.m:
              (-[WebFrame _transitionToCommitted]):  Make the docView here, after we save the scroll state but before notifying the delegate.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3795ae7e
    • hyatt's avatar
      Rewrite cellpadding to not use the style system at all and · 80844874
      hyatt authored
      	to make table cells just get the padding from the table
      	itself (overriding style).
      
              * khtml/html/html_tableimpl.cpp:
              (HTMLTableElementImpl::HTMLTableElementImpl):
              (HTMLTableElementImpl::attach):
              (HTMLTableElementImpl::parseAttribute):
              (HTMLTableCellElementImpl::init):
              * khtml/html/html_tableimpl.h:
              * khtml/rendering/bidi.cpp:
              (RenderFlow::layoutInlineChildren):
              * khtml/rendering/render_box.cpp:
              (RenderBox::contentWidth):
              (RenderBox::contentHeight):
              * khtml/rendering/render_flow.cpp:
              (RenderFlow::layoutBlockChildren):
              (RenderFlow::leftOffset):
              (RenderFlow::rightOffset):
              (RenderFlow::calcMinMaxWidth):
              * khtml/rendering/render_object.h:
              * khtml/rendering/render_table.cpp:
              (RenderTable::RenderTable):
              (RenderTableCell::paddingTop):
              (RenderTableCell::paddingBottom):
              (RenderTableCell::paddingLeft):
              (RenderTableCell::paddingRight):
              * khtml/rendering/render_table.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@2657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80844874