1. 15 Aug, 2013 1 commit
    • andersca@apple.com's avatar
      <https://webkit.org/b/119859> Frame::loader() should return a reference · df550b96
      andersca@apple.com authored
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::willOpenSocketStream):
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::press):
      * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
      (-[WebAccessibilityObjectWrapper remoteAccessibilityParentObject]):
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::canExecuteScripts):
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::initScript):
      * css/CSSFontSelector.cpp:
      (WebCore::CSSFontSelector::beginLoadTimerFired):
      * dom/DOMImplementation.cpp:
      (WebCore::DOMImplementation::createDocument):
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::setVisualUpdatesAllowed):
      (WebCore::Document::updateTitle):
      (WebCore::Document::open):
      (WebCore::Document::explicitClose):
      (WebCore::Document::implicitClose):
      (WebCore::Document::userAgent):
      (WebCore::Document::canNavigate):
      (WebCore::Document::processHttpEquiv):
      (WebCore::Document::referrer):
      (WebCore::Document::documentDidResumeFromPageCache):
      (WebCore::Document::openSearchDescriptionURL):
      (WebCore::Document::finishedParsing):
      (WebCore::Document::addIconURL):
      (WebCore::Document::initSecurityContext):
      (WebCore::Document::updateURLForPushOrReplaceState):
      (WebCore::Document::loadEventDelayTimerFired):
      (WebCore::Document::loader):
      (WebCore::Document::decrementActiveParserCount):
      * history/CachedFrame.cpp:
      (WebCore::CachedFrameBase::CachedFrameBase):
      (WebCore::CachedFrameBase::restore):
      (WebCore::CachedFrame::CachedFrame):
      (WebCore::CachedFrame::open):
      (WebCore::CachedFrame::destroy):
      * history/PageCache.cpp:
      (WebCore::logCanCacheFrameDecision):
      (WebCore::logCanCachePageDecision):
      (WebCore::PageCache::canCachePageContainingThisFrame):
      (WebCore::PageCache::canCache):
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::handleClick):
      * html/HTMLAppletElement.cpp:
      (WebCore::HTMLAppletElement::updateWidget):
      * html/HTMLElement.cpp:
      (WebCore::HTMLElement::rendererIsNeeded):
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::updateWidget):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::prepareForSubmission):
      (WebCore::HTMLFormElement::submit):
      * html/HTMLFrameElementBase.cpp:
      (WebCore::HTMLFrameElementBase::openURL):
      * html/HTMLFrameOwnerElement.cpp:
      (WebCore::HTMLFrameOwnerElement::disconnectContentFrame):
      * html/HTMLFrameSetElement.cpp:
      (WebCore::HTMLFrameSetElement::insertedInto):
      (WebCore::HTMLFrameSetElement::removedFrom):
      * html/HTMLHtmlElement.cpp:
      (WebCore::HTMLHtmlElement::insertedByParser):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::createRenderer):
      (WebCore::HTMLMediaElement::attach):
      (WebCore::HTMLMediaElement::loadResource):
      (WebCore::HTMLMediaElement::getPluginProxyParams):
      (WebCore::HTMLMediaElement::createMediaPlayerProxy):
      (WebCore::HTMLMediaElement::updateWidget):
      (WebCore::HTMLMediaElement::mediaPlayerReferrer):
      (WebCore::HTMLMediaElement::mediaPlayerUserAgent):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::parametersForPlugin):
      (WebCore::HTMLObjectElement::updateWidget):
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::isImageType):
      (WebCore::HTMLPlugInImageElement::wouldLoadAsNetscapePlugin):
      (WebCore::HTMLPlugInImageElement::restartSimilarPlugIns):
      * html/HTMLVideoElement.cpp:
      (WebCore::HTMLVideoElement::setDisplayMode):
      * html/ImageDocument.cpp:
      (WebCore::ImageDocumentParser::appendBytes):
      (WebCore::ImageDocumentParser::finish):
      (WebCore::ImageDocument::createDocumentStructure):
      * html/MediaDocument.cpp:
      (WebCore::MediaDocumentParser::createDocumentStructure):
      * html/PluginDocument.cpp:
      (WebCore::PluginDocumentParser::createDocumentStructure):
      (WebCore::PluginDocumentParser::appendBytes):
      (WebCore::PluginDocument::detach):
      (WebCore::PluginDocument::cancelManualPluginLoad):
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore::WebGLRenderingContext::create):
      (WebCore::WebGLRenderingContext::loseContextImpl):
      (WebCore::WebGLRenderingContext::maybeRestoreContext):
      * html/parser/HTMLConstructionSite.cpp:
      (WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded):
      (WebCore::HTMLConstructionSite::insertHTMLBodyElement):
      * html/parser/HTMLParserOptions.cpp:
      (WebCore::HTMLParserOptions::HTMLParserOptions):
      * html/parser/XSSAuditor.cpp:
      (WebCore::XSSAuditor::init):
      * html/parser/XSSAuditorDelegate.cpp:
      (WebCore::XSSAuditorDelegate::generateViolationReport):
      (WebCore::XSSAuditorDelegate::didBlockScript):
      * inspector/InspectorApplicationCacheAgent.cpp:
      (WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus):
      (WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
      * inspector/InspectorFrontendClientLocal.cpp:
      (WebCore::InspectorFrontendClientLocal::openInNewTab):
      * inspector/InspectorFrontendHost.cpp:
      (WebCore::InspectorFrontendHost::loadResourceSynchronously):
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::overlayPage):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::mainResourceContent):
      (WebCore::InspectorPageAgent::reload):
      (WebCore::InspectorPageAgent::navigate):
      (WebCore::allResourcesURLsForFrame):
      (WebCore::InspectorPageAgent::searchInResource):
      (WebCore::InspectorPageAgent::assertDocumentLoader):
      (WebCore::InspectorPageAgent::buildObjectForFrame):
      * inspector/InspectorResourceAgent.cpp:
      (WebCore::InspectorResourceAgent::didFailLoading):
      * loader/CookieJar.cpp:
      (WebCore::networkingContext):
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::frameLoader):
      (WebCore::DocumentLoader::document):
      (WebCore::DocumentLoader::stopLoading):
      (WebCore::DocumentLoader::removeSubresourceLoader):
      (WebCore::DocumentLoader::subresourceLoaderFinishedLoadingOnePart):
      (WebCore::DocumentLoader::iconLoadDecisionAvailable):
      (WebCore::DocumentLoader::continueIconLoadWithDecision):
      * loader/DocumentThreadableLoader.cpp:
      (WebCore::DocumentThreadableLoader::didReceiveResponse):
      (WebCore::DocumentThreadableLoader::didFinishLoading):
      (WebCore::DocumentThreadableLoader::didFail):
      (WebCore::DocumentThreadableLoader::preflightFailure):
      (WebCore::DocumentThreadableLoader::loadRequest):
      * loader/DocumentWriter.cpp:
      (WebCore::DocumentWriter::replaceDocument):
      (WebCore::DocumentWriter::createDocument):
      (WebCore::DocumentWriter::begin):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::~FrameLoader):
      (WebCore::FrameLoader::allChildrenAreComplete):
      (WebCore::FrameLoader::allAncestorsAreComplete):
      (WebCore::FrameLoader::loadURLIntoChildFrame):
      (WebCore::FrameLoader::outgoingReferrer):
      (WebCore::FrameLoader::setOpener):
      (WebCore::FrameLoader::completed):
      (WebCore::FrameLoader::started):
      (WebCore::FrameLoader::loadFrameRequest):
      (WebCore::FrameLoader::loadURL):
      (WebCore::FrameLoader::load):
      (WebCore::FrameLoader::loadWithDocumentLoader):
      (WebCore::FrameLoader::stopAllLoaders):
      (WebCore::FrameLoader::closeOldDataSources):
      (WebCore::FrameLoader::subframeIsLoading):
      (WebCore::FrameLoader::subresourceCachePolicy):
      (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
      (WebCore::FrameLoader::detachChildren):
      (WebCore::FrameLoader::checkLoadComplete):
      (WebCore::FrameLoader::detachFromParent):
      (WebCore::FrameLoader::loadPostRequest):
      (WebCore::FrameLoader::loadResourceSynchronously):
      (WebCore::FrameLoader::shouldClose):
      (WebCore::FrameLoader::handleBeforeUnloadEvent):
      (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
      (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
      (WebCore::createWindow):
      * loader/HistoryController.cpp:
      (WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
      (WebCore::HistoryController::restoreScrollPositionAndViewState):
      (WebCore::HistoryController::saveDocumentState):
      (WebCore::HistoryController::saveDocumentAndScrollState):
      (WebCore::isAssociatedToRequestedHistoryItem):
      (WebCore::HistoryController::restoreDocumentState):
      (WebCore::HistoryController::shouldStopLoadingForHistoryItem):
      (WebCore::HistoryController::goToItem):
      (WebCore::HistoryController::updateForBackForwardNavigation):
      (WebCore::HistoryController::updateForReload):
      (WebCore::HistoryController::updateForStandardLoad):
      (WebCore::HistoryController::updateForRedirectWithLockedBackForwardList):
      (WebCore::HistoryController::updateForClientRedirect):
      (WebCore::HistoryController::updateForCommit):
      (WebCore::HistoryController::recursiveUpdateForCommit):
      (WebCore::HistoryController::updateForSameDocumentNavigation):
      (WebCore::HistoryController::recursiveUpdateForSameDocumentNavigation):
      (WebCore::HistoryController::initializeItem):
      (WebCore::HistoryController::createItemTree):
      (WebCore::HistoryController::recursiveSetProvisionalItem):
      (WebCore::HistoryController::recursiveGoToItem):
      (WebCore::HistoryController::updateBackForwardListClippedAtTarget):
      (WebCore::HistoryController::updateCurrentItem):
      (WebCore::HistoryController::pushState):
      (WebCore::HistoryController::replaceState):
      * loader/ImageLoader.cpp:
      (WebCore::pageIsBeingDismissed):
      * loader/MixedContentChecker.cpp:
      (WebCore::MixedContentChecker::client):
      * loader/NavigationScheduler.cpp:
      (WebCore::ScheduledURLNavigation::fire):
      (WebCore::ScheduledURLNavigation::didStartTimer):
      (WebCore::ScheduledURLNavigation::didStopTimer):
      (WebCore::ScheduledRedirect::shouldStartTimer):
      (WebCore::ScheduledRedirect::fire):
      (WebCore::ScheduledRefresh::fire):
      (WebCore::ScheduledHistoryNavigation::fire):
      (WebCore::ScheduledFormSubmission::fire):
      (WebCore::ScheduledFormSubmission::didStartTimer):
      (WebCore::ScheduledFormSubmission::didStopTimer):
      (WebCore::NavigationScheduler::mustLockBackForwardList):
      (WebCore::NavigationScheduler::scheduleLocationChange):
      (WebCore::NavigationScheduler::scheduleFormSubmission):
      (WebCore::NavigationScheduler::scheduleRefresh):
      (WebCore::NavigationScheduler::schedule):
      * loader/PingLoader.cpp:
      (WebCore::PingLoader::loadImage):
      (WebCore::PingLoader::sendPing):
      (WebCore::PingLoader::sendViolationReport):
      (WebCore::PingLoader::PingLoader):
      * loader/PolicyChecker.cpp:
      (WebCore::PolicyChecker::checkNavigationPolicy):
      (WebCore::PolicyChecker::checkNewWindowPolicy):
      (WebCore::PolicyChecker::checkContentPolicy):
      (WebCore::PolicyChecker::cancelCheck):
      (WebCore::PolicyChecker::stopCheck):
      (WebCore::PolicyChecker::cannotShowMIMEType):
      (WebCore::PolicyChecker::continueLoadAfterWillSubmitForm):
      (WebCore::PolicyChecker::continueAfterNavigationPolicy):
      (WebCore::PolicyChecker::continueAfterNewWindowPolicy):
      (WebCore::PolicyChecker::handleUnimplementablePolicy):
      * loader/ProgressTracker.cpp:
      (WebCore::ProgressTracker::progressStarted):
      (WebCore::ProgressTracker::progressCompleted):
      (WebCore::ProgressTracker::finalProgressComplete):
      (WebCore::ProgressTracker::incrementProgress):
      (WebCore::ProgressTracker::progressHeartbeatTimerFired):
      * loader/ResourceLoadNotifier.cpp:
      (WebCore::ResourceLoadNotifier::didReceiveAuthenticationChallenge):
      (WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge):
      (WebCore::ResourceLoadNotifier::willSendRequest):
      (WebCore::ResourceLoadNotifier::didFailToLoad):
      (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
      (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
      (WebCore::ResourceLoadNotifier::dispatchDidReceiveResponse):
      (WebCore::ResourceLoadNotifier::dispatchDidReceiveData):
      (WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
      (WebCore::ResourceLoadNotifier::dispatchDidFailLoading):
      * loader/ResourceLoader.cpp:
      (WebCore::ResourceLoader::ResourceLoader):
      (WebCore::ResourceLoader::start):
      (WebCore::ResourceLoader::frameLoader):
      (WebCore::ResourceLoader::willSendRequest):
      * loader/SubframeLoader.cpp:
      (WebCore::SubframeLoader::pluginIsLoadable):
      (WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
      (WebCore::SubframeLoader::createJavaAppletWidget):
      (WebCore::SubframeLoader::loadOrRedirectSubframe):
      (WebCore::SubframeLoader::loadSubframe):
      (WebCore::SubframeLoader::allowPlugins):
      (WebCore::SubframeLoader::shouldUsePlugin):
      (WebCore::SubframeLoader::loadPlugin):
      * loader/appcache/ApplicationCacheGroup.cpp:
      (WebCore::ApplicationCacheGroup::selectCache):
      (WebCore::ApplicationCacheGroup::selectCacheWithoutManifestURL):
      (WebCore::ApplicationCacheGroup::update):
      (WebCore::ApplicationCacheGroup::createResourceHandle):
      (WebCore::ApplicationCacheGroup::didReceiveResponse):
      (WebCore::ApplicationCacheGroup::didFinishLoading):
      (WebCore::ApplicationCacheGroup::didFail):
      (WebCore::ApplicationCacheGroup::addEntry):
      (WebCore::CallCacheListenerTask::performTask):
      (WebCore::ApplicationCacheGroup::postListenerTask):
      * loader/appcache/DOMApplicationCache.cpp:
      (WebCore::DOMApplicationCache::applicationCacheHost):
      * loader/archive/cf/LegacyWebArchive.cpp:
      (WebCore::LegacyWebArchive::create):
      (WebCore::LegacyWebArchive::createFromSelection):
      * loader/cache/CachedResource.cpp:
      (WebCore::CachedResource::addAdditionalRequestHeaders):
      (WebCore::CachedResource::load):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::requestImage):
      (WebCore::CachedResourceLoader::checkInsecureContent):
      (WebCore::CachedResourceLoader::canRequest):
      (WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):
      (WebCore::CachedResourceLoader::requestResource):
      (WebCore::CachedResourceLoader::clientDefersImage):
      (WebCore::CachedResourceLoader::cachePolicy):
      (WebCore::CachedResourceLoader::loadDone):
      * loader/icon/IconController.cpp:
      (WebCore::IconController::commitToDatabase):
      (WebCore::IconController::startLoader):
      (WebCore::IconController::continueLoadWithDecision):
      * loader/icon/IconLoader.cpp:
      (WebCore::IconLoader::startLoading):
      (WebCore::IconLoader::notifyFinished):
      * page/Chrome.cpp:
      (WebCore::canRunModalIfDuringPageDismissal):
      * page/ContextMenuController.cpp:
      (WebCore::openNewWindow):
      (WebCore::ContextMenuController::contextMenuItemSelected):
      (WebCore::ContextMenuController::populate):
      (WebCore::ContextMenuController::checkOrEnableIfNeeded):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents):
      (WebCore::DOMWindow::postMessageTimerFired):
      (WebCore::DOMWindow::close):
      (WebCore::DOMWindow::print):
      (WebCore::DOMWindow::stop):
      (WebCore::DOMWindow::setName):
      (WebCore::DOMWindow::opener):
      (WebCore::DOMWindow::dispatchLoadEvent):
      (WebCore::DOMWindow::setLocation):
      (WebCore::DOMWindow::createWindow):
      (WebCore::DOMWindow::open):
      * page/DOMWindowExtension.cpp:
      (WebCore::DOMWindowExtension::disconnectFrameForPageCache):
      (WebCore::DOMWindowExtension::reconnectFrameFromPageCache):
      (WebCore::DOMWindowExtension::willDestroyGlobalObjectInCachedFrame):
      (WebCore::DOMWindowExtension::willDestroyGlobalObjectInFrame):
      (WebCore::DOMWindowExtension::willDetachGlobalObjectFromFrame):
      * page/DragController.cpp:
      (WebCore::DragController::performDrag):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::keyEvent):
      * page/Frame.cpp:
      (WebCore::Frame::~Frame):
      (WebCore::Frame::setView):
      (WebCore::Frame::injectUserScripts):
      (WebCore::Frame::willDetachPage):
      * page/Frame.h:
      (WebCore::Frame::loader):
      * page/FrameView.cpp:
      (WebCore::FrameView::mediaType):
      (WebCore::FrameView::setFixedVisibleContentRect):
      (WebCore::FrameView::shouldUseLoadTimeDeferredRepaintDelay):
      (WebCore::FrameView::performPostLayoutTasks):
      (WebCore::FrameView::autoSizeIfEnabled):
      (WebCore::FrameView::scrollTo):
      (WebCore::FrameView::shouldSuspendScrollAnimations):
      (WebCore::FrameView::qualifiesAsVisuallyNonEmpty):
      (WebCore::FrameView::wheelEvent):
      (WebCore::FrameView::firePaintRelatedMilestones):
      * page/History.cpp:
      (WebCore::History::stateInternal):
      (WebCore::History::stateObjectAdded):
      * page/Location.cpp:
      (WebCore::Location::setLocation):
      * page/Navigator.cpp:
      (WebCore::Navigator::userAgent):
      * page/Page.cpp:
      (WebCore::Page::goToItem):
      (WebCore::Page::refreshPlugins):
      (WebCore::Page::setDefersLoading):
      (WebCore::Page::setMemoryCacheClientCallsEnabled):
      (WebCore::Page::addRelevantRepaintedObject):
      * page/Performance.cpp:
      (WebCore::Performance::now):
      * page/PerformanceNavigation.cpp:
      (WebCore::PerformanceNavigation::type):
      (WebCore::PerformanceNavigation::redirectCount):
      * page/PerformanceResourceTiming.cpp:
      (WebCore::monotonicTimeToDocumentMilliseconds):
      * page/mac/PageMac.cpp:
      (WebCore::Page::addSchedulePair):
      (WebCore::Page::removeSchedulePair):
      * platform/ios/PasteboardIOS.mm:
      (WebCore::documentFragmentWithImageResource):
      (WebCore::documentFragmentWithRTF):
      (WebCore::Pasteboard::documentFragmentForPasteboardItemAtIndex):
      * platform/mac/HTMLConverter.mm:
      (-[WebHTMLConverter _addAttachmentForElement:URL:needsParagraph:usePlaceholder:]):
      (-[WebHTMLConverter _loadFromDOMRange]):
      * platform/mac/PasteboardMac.mm:
      (WebCore::documentFragmentWithImageResource):
      (WebCore::documentFragmentWithRTF):
      (WebCore::fragmentFromWebArchive):
      * plugins/DOMMimeType.cpp:
      (WebCore::DOMMimeType::enabledPlugin):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollTo):
      * svg/SVGAElement.cpp:
      (WebCore::SVGAElement::defaultEventHandler):
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImage::~SVGImage):
      (WebCore::SVGImage::dataChanged):
      * testing/Internals.cpp:
      (WebCore::Internals::formControlStateOfPreviousHistoryItem):
      (WebCore::Internals::setFormControlStateOfPreviousHistoryItem):
      (WebCore::Internals::getReferencedFilePaths):
      (WebCore::Internals::forceReload):
      * xml/XSLTProcessorLibxslt.cpp:
      (WebCore::docLoaderFunc):
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      (WebCore::openFunc):
      (WebCore::XMLDocumentParser::startElementNs):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::load):
      (BlackBerry::WebKit::WebPagePrivate::loadString):
      (BlackBerry::WebKit::WebPagePrivate::stopCurrentLoad):
      (BlackBerry::WebKit::closeURLRecursively):
      (BlackBerry::WebKit::WebPage::dispatchBeforeUnloadEvent):
      (BlackBerry::WebKit::WebPagePrivate::shouldSendResizeEvent):
      (BlackBerry::WebKit::WebPagePrivate::zoomToInitialScaleOnLoad):
      (BlackBerry::WebKit::WebPage::reload):
      (BlackBerry::WebKit::WebPage::reloadFromCache):
      (BlackBerry::WebKit::WebPage::textEncoding):
      (BlackBerry::WebKit::WebPage::forcedTextEncoding):
      (BlackBerry::WebKit::WebPage::setForcedTextEncoding):
      (BlackBerry::WebKit::WebPage::title):
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore::ChromeClientBlackBerry::createWindow):
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidChangeLocationWithinPage):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForResponse):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
      (WebCore::FrameLoaderClientBlackBerry::delayPolicyCheckUntilFragmentExists):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNewWindowAction):
      (WebCore::FrameLoaderClientBlackBerry::createPlugin):
      (WebCore::FrameLoaderClientBlackBerry::receivedData):
      (WebCore::FrameLoaderClientBlackBerry::createDocumentLoader):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidCommitLoad):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
      (WebCore::FrameLoaderClientBlackBerry::dispatchWillSubmitForm):
      (WebCore::FrameLoaderClientBlackBerry::createFrame):
      (WebCore::FrameLoaderClientBlackBerry::dispatchDidLayout):
      (WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
      (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
      (WebCore::FrameLoaderClientBlackBerry::startDownload):
      (WebCore::FrameLoaderClientBlackBerry::canCachePage):
      (WebCore::FrameLoaderClientBlackBerry::didRestoreFromPageCache):
      * WebKitSupport/PagePopup.cpp:
      (BlackBerry::WebKit::PagePopup::initialize):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (kit):
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      (DumpRenderTreeSupportEfl::callShouldCloseOnWebView):
      (DumpRenderTreeSupportEfl::clearOpener):
      (DumpRenderTreeSupportEfl::frameChildren):
      (DumpRenderTreeSupportEfl::responseMimeType):
      (DumpRenderTreeSupportEfl::provisionalURL):
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::callPolicyFunction):
      (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNewWindowAction):
      (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
      (WebCore::FrameLoaderClientEfl::updateGlobalHistoryRedirectLinks):
      (WebCore::FrameLoaderClientEfl::updateGlobalHistory):
      * ewk/ewk_frame.cpp:
      (_ewk_frame_loader_efl_get):
      (_ewk_frame_smart_del):
      (_ewk_frame_contents_set_internal):
      (ewk_frame_stop):
      (ewk_frame_reload):
      (ewk_frame_reload_full):
      (ewk_frame_child_add):
      * ewk/ewk_view.cpp:
      (ewk_view_frame_focused_get):
      (ewk_view_setting_user_agent_set):
      (ewk_view_setting_encoding_custom_get):
      (ewk_view_setting_encoding_custom_set):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::clearOpener):
      (DumpRenderTreeSupportGtk::shouldClose):
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::dispatchWillSubmitForm):
      (WebKit::FrameLoaderClient::committedLoad):
      (WebKit::FrameLoaderClient::dispatchDecidePolicyForResponse):
      (WebKit::FrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
      (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
      (WebKit::FrameLoaderClient::createFrame):
      (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_finalize):
      (webkit_web_frame_load_uri):
      (webkit_web_frame_load_data):
      (webkit_web_frame_load_request):
      (webkit_web_frame_stop_loading):
      (webkit_web_frame_reload):
      (webkit_web_frame_get_data_source):
      (webkit_web_frame_get_provisional_data_source):
      (webkit_web_frame_get_response_mime_type):
      (webkit_web_frame_get_network_response):
      (WebKit::kit):
      * webkit/webkitwebpolicydecision.cpp:
      (webkit_web_policy_decision_use):
      (webkit_web_policy_decision_ignore):
      (webkit_web_policy_decision_download):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_dispose):
      (webkit_web_view_reload):
      (webkit_web_view_reload_bypass_cache):
      (webkit_web_view_stop_loading):
      (webkit_web_view_can_show_mime_type):
      (webkit_web_view_set_custom_encoding):
      (webkit_web_view_get_custom_encoding):
      (webkit_web_view_get_subresources):
      
      Source/WebKit/mac:
      
      * Plugins/Hosted/HostedNetscapePluginStream.mm:
      (WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::performRequest):
      (WebKit::NetscapePluginInstanceProxy::loadRequest):
      * Plugins/Hosted/WebHostedNetscapePluginView.mm:
      (-[WebHostedNetscapePluginView pluginView:receivedResponse:]):
      * Plugins/WebBaseNetscapePluginView.mm:
      (-[WebBaseNetscapePluginView requestWithURLCString:]):
      * Plugins/WebNetscapePluginStream.mm:
      (WebNetscapePluginStream::WebNetscapePluginStream):
      * Plugins/WebNetscapePluginView.mm:
      (-[WebNetscapePluginView loadStream]):
      (-[WebNetscapePluginView pluginView:receivedResponse:]):
      (-[WebNetscapePluginView loadPluginRequest:]):
      (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
      * Plugins/WebPluginController.mm:
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
      (WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
      (WebFrameLoaderClient::dispatchWillSubmitForm):
      (WebFrameLoaderClient::updateGlobalHistory):
      (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
      (WebFrameLoaderClient::restoreViewState):
      (WebFrameLoaderClient::transitionToCommittedForNewPage):
      (WebFrameLoaderClient::createFrame):
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      (WebFrameNetworkingContext::blockedError):
      * WebCoreSupport/WebPlatformStrategies.mm:
      (WebPlatformStrategies::getPluginInfo):
      * WebView/WebFrame.mm:
      (kit):
      (-[WebFrame _dataSource]):
      (-[WebFrame _canProvideDocumentSource]):
      (-[WebFrame _commitData:]):
      (-[WebFrame _firstLayoutDone]):
      (-[WebFrame _loadType]):
      (-[WebFrame _cacheabilityDictionary]):
      (-[WebFrame _clearOpener]):
      (-[WebFrame provisionalDataSource]):
      (-[WebFrame dataSource]):
      (-[WebFrame loadRequest:]):
      (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]):
      (-[WebFrame loadArchive:]):
      (-[WebFrame stopLoading]):
      (-[WebFrame reload]):
      (-[WebFrame reloadFromOrigin]):
      * WebView/WebHTMLRepresentation.mm:
      (-[WebHTMLRepresentation receivedData:withDataSource:]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
      * WebView/WebPDFView.mm:
      (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
      * WebView/WebRenderLayer.mm:
      (-[WebRenderLayer initWithWebFrame:]):
      * WebView/WebRenderNode.mm:
      (-[WebRenderNode _initWithCoreFrame:]):
      * WebView/WebView.mm:
      (-[WebView _close]):
      (-[WebView _loadBackForwardListFromOtherView:]):
      (-[WebView _cachedResponseForURL:]):
      (-[WebView setCustomTextEncodingName:]):
      (-[WebView shouldClose]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::closeWindowSoon):
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::shouldClose):
      (DumpRenderTreeSupportQt::responseMimeType):
      (DumpRenderTreeSupportQt::clearOpener):
      (DumpRenderTreeSupportQt::thirdPartyCookiePolicyAllows):
      (DumpRenderTreeSupportQt::setAlternateHtml):
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::callPolicyFunction):
      (WebCore::FrameLoaderClientQt::dispatchDidStartProvisionalLoad):
      (WebCore::FrameLoaderClientQt::updateGlobalHistory):
      (WebCore::FrameLoaderClientQt::updateGlobalHistoryRedirectLinks):
      (WebCore::FrameLoaderClientQt::callErrorPageExtension):
      (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNewWindowAction):
      (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
      (WebCore::FrameLoaderClientQt::startDownload):
      (WebCore::FrameLoaderClientQt::createFrame):
      (WebCore::FrameLoaderClientQt::objectContentType):
      * WebCoreSupport/QWebFrameAdapter.cpp:
      (QWebFrameAdapter::load):
      (QWebFrameAdapter::setContent):
      (QWebFrameAdapter::setHtml):
      (QWebFrameAdapter::kit):
      (QWebFrameAdapter::title):
      (QWebFrameAdapter::clearCoreFrame):
      * WebCoreSupport/QWebPageAdapter.cpp:
      (frameLoadRequest):
      (openNewWindow):
      (QWebPageAdapter::triggerAction):
      (QWebPageAdapter::currentFrame):
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebContextMenuClient.cpp:
      (WebContextMenuClient::searchWithGoogle):
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::updateGlobalHistory):
      (WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
      (WebFrameLoaderClient::savePlatformDataToCachedFrame):
      (WebFrameLoaderClient::createFrame):
      (WebFrameLoaderClient::dispatchDidFailToStartPlugin):
      * WebCoreSupport/WebFrameNetworkingContext.cpp:
      (WebFrameNetworkingContext::blockedError):
      (WebFrameNetworkingContext::referrer):
      * WebElementPropertyBag.cpp:
      (WebElementPropertyBag::Read):
      * WebFrame.cpp:
      (kit):
      (WebFrame::reloadFromOrigin):
      (WebFrame::loadRequest):
      (WebFrame::loadData):
      (WebFrame::dataSource):
      (WebFrame::provisionalDataSource):
      (WebFrame::stopLoading):
      (WebFrame::reload):
      (WebFrame::firstLayoutDone):
      (WebFrame::loadType):
      (WebFrame::clearOpener):
      (WebFrame::dispatchWillSubmitForm):
      (WebFrame::receivedPolicyDecision):
      (WebFrame::dispatchDecidePolicyForResponse):
      (WebFrame::dispatchDecidePolicyForNewWindowAction):
      (WebFrame::dispatchDecidePolicyForNavigationAction):
      (WebFrame::createJavaAppletWidget):
      * WebFramePolicyListener.cpp:
      (WebFramePolicyListener::receivedPolicyDecision):
      * WebView.cpp:
      (WebView::close):
      (WebView::canShowMIMEType):
      (WebView::setCustomTextEncodingName):
      (WebView::loadBackForwardListFromOtherView):
      (WebView::shouldClose):
      
      Source/WebKit/wince:
      
      * WebCoreSupport/FrameLoaderClientWinCE.cpp:
      (WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForResponse):
      (WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNewWindowAction):
      (WebKit::FrameLoaderClientWinCE::dispatchDecidePolicyForNavigationAction):
      (WebKit::FrameLoaderClientWinCE::dispatchWillSubmitForm):
      * WebCoreSupport/FrameNetworkingContextWinCE.cpp:
      (WebKit::FrameNetworkingContextWinCE::referrer):
      * WebView.cpp:
      (WebView::createFrame):
      (WebView::load):
      (WebView::reload):
      (WebView::stop):
      
      Source/WebKit2:
      
      * Shared/WebRenderLayer.cpp:
      (WebKit::WebRenderLayer::create):
      * Shared/WebRenderObject.cpp:
      (WebKit::WebRenderObject::create):
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      (WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      (WKBundleFrameGetFrameLoadState):
      (WKBundleFrameClearOpener):
      (WKBundleFrameCallShouldCloseOnWebView):
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      (WebKit::InjectedBundleNodeHandle::documentFrame):
      (WebKit::InjectedBundleNodeHandle::htmlFrameElementContentFrame):
      (WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      (WebKit::InjectedBundleDOMWindowExtension::frame):
      * WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
      (WebKit::InjectedBundleHitTestResult::frame):
      (WebKit::InjectedBundleHitTestResult::targetFrame):
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      (WebKit::PDFPlugin::clickedLink):
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::webPage):
      (WebKit::PluginView::didFailToInitializePlugin):
      (WebKit::PluginView::performFrameLoadURLRequest):
      (WebKit::PluginView::userAgent):
      (WebKit::PluginView::loadURL):
      (WebKit::PluginView::cancelManualStreamLoad):
      (WebKit::PluginView::proxiesForURL):
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::focusedElementChanged):
      (WebKit::WebChromeClient::focusedFrameChanged):
      (WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
      (WebKit::WebChromeClient::closeWindowSoon):
      (WebKit::WebChromeClient::runJavaScriptAlert):
      (WebKit::WebChromeClient::runJavaScriptConfirm):
      (WebKit::WebChromeClient::runJavaScriptPrompt):
      (WebKit::WebChromeClient::unavailablePluginButtonClicked):
      (WebKit::WebChromeClient::print):
      (WebKit::WebChromeClient::exceededDatabaseQuota):
      (WebKit::WebChromeClient::runOpenPanel):
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      (WebKit::WebContextMenuClient::searchWithGoogle):
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::textFieldDidBeginEditing):
      (WebKit::WebEditorClient::textFieldDidEndEditing):
      (WebKit::WebEditorClient::textDidChangeInTextField):
      (WebKit::WebEditorClient::textDidChangeInTextArea):
      (WebKit::WebEditorClient::doTextFieldCommandFromEvent):
      (WebKit::WebEditorClient::textWillBeDeletedInTextField):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
      (WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
      (WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
      (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
      (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
      (WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
      (WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):
      (WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
      (WebKit::WebFrameLoaderClient::updateGlobalHistory):
      (WebKit::WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
      (WebKit::WebFrameLoaderClient::restoreViewState):
      (WebKit::WebFrameLoaderClient::createFrame):
      (WebKit::WebFrameLoaderClient::createJavaAppletWidget):
      (WebKit::WebFrameLoaderClient::objectContentType):
      * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
      (WebKit::WebPlatformStrategies::getPluginInfo):
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      (WebKit::WebFrameNetworkingContext::blockedError):
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::didReceivePolicyDecision):
      (WebKit::WebFrame::startDownload):
      (WebKit::WebFrame::source):
      (WebKit::WebFrame::contentsAsString):
      (WebKit::WebFrame::url):
      (WebKit::WebFrame::parentFrame):
      (WebKit::WebFrame::childFrames):
      (WebKit::WebFrame::stopLoading):
      (WebKit::WebFrame::frameForContext):
      (WebKit::WebFrame::provisionalURL):
      (WebKit::WebFrame::suggestedFilenameForResourceWithURL):
      (WebKit::WebFrame::mimeTypeForResourceWithURL):
      (WebKit::WebFrameFilter::shouldIncludeSubframe):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::createPlugin):
      (WebKit::WebPage::close):
      (WebKit::WebPage::tryClose):
      (WebKit::WebPage::loadURLRequest):
      (WebKit::WebPage::loadDataImpl):
      (WebKit::WebPage::linkClicked):
      (WebKit::WebPage::stopLoadingFrame):
      (WebKit::WebPage::stopLoading):
      (WebKit::WebPage::reload):
      (WebKit::WebPage::tryRestoreScrollPosition):
      (WebKit::WebPage::getMainResourceDataOfFrame):
      (WebKit::resourceDataForFrame):
      (WebKit::shouldReuseCommittedSandboxExtension):
      (WebKit::WebPage::SandboxExtensionTracker::didStartProvisionalLoad):
      (WebKit::WebPage::hasLocalDataForURL):
      (WebKit::WebPage::setCustomTextEncodingName):
      (WebKit::WebPage::canPluginHandleResponse):
      (WebKit::WebPage::canShowMIMEType):
      (WebKit::WebPage::didCommitLoad):
      * WebProcess/WebPage/mac/WebPageMac.mm:
      (WebKit::WebPage::platformHasLocalDataForURL):
      (WebKit::cachedResponseForURL):
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::downloadRequest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df550b96
  2. 01 Jul, 2013 1 commit
    • jochen@chromium.org's avatar
      Remove support for consumable user gestures · 4f58f490
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118247
      
      Reviewed by Geoffrey Garen.
      
      Source/WebCore:
      
      The features was not enabled on any port, and is meanwhile broken, so we
      should delete it.
      
      No new tests, just deleting dead code.
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::increment):
      (WebCore::AccessibilityNodeObject::decrement):
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::press):
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::executeScript):
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::executeScriptInWorld):
      * dom/UserGestureIndicator.cpp:
      (WebCore::isDefinite):
      (WebCore::UserGestureIndicator::UserGestureIndicator):
      (WebCore::UserGestureIndicator::~UserGestureIndicator):
      * dom/UserGestureIndicator.h:
      (WebCore::UserGestureIndicator::processingUserGesture):
      * inspector/InspectorFrontendClientLocal.cpp:
      (WebCore::InspectorFrontendClientLocal::openInNewTab):
      * inspector/InspectorFrontendHost.cpp:
      (WebCore::FrontendMenuProvider::contextMenuItemSelected):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::navigate):
      * loader/NavigationScheduler.cpp:
      (WebCore::ScheduledURLNavigation::fire):
      (WebCore::ScheduledURLNavigation::didStartTimer):
      (WebCore::ScheduledRedirect::fire):
      (WebCore::ScheduledRefresh::fire):
      (WebCore::ScheduledHistoryNavigation::fire):
      (WebCore::ScheduledFormSubmission::fire):
      (WebCore::ScheduledFormSubmission::didStartTimer):
      * page/DOMTimer.cpp:
      (WebCore::DOMTimer::DOMTimer):
      (WebCore::DOMTimer::fired):
      * page/DOMTimer.h:
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::showModalDialog):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::clear):
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::handleMouseReleaseEvent):
      * page/EventHandler.h:
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::toggleMediaFullscreenState):
      (WebCore::HitTestResult::enterFullscreenForVideo):
      
      Source/WebKit/blackberry:
      
      * WebKitSupport/NotificationManager.cpp:
      (BlackBerry::WebKit::NotificationManager::notificationClicked):
      
      Source/WebKit/mac:
      
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::evaluate):
      * Plugins/WebNetscapePluginView.mm:
      (-[WebNetscapePluginView sendEvent:isDrawRect:]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      (WebCore::NotificationPresenterClientQt::notificationClicked):
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebContextMenuClient.cpp:
      (WebContextMenuClient::searchWithGoogle):
      
      Source/WebKit2:
      
      * WebProcess/Notifications/WebNotificationManager.cpp:
      (WebKit::WebNotificationManager::didClickNotification):
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::performFrameLoadURLRequest):
      (WebKit::PluginView::evaluate):
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      (WebKit::WebContextMenuClient::searchWithGoogle):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@152238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f58f490
  3. 30 May, 2013 1 commit
    • mkwst@chromium.org's avatar
      Rename 'KURL::elidedString' and inspector's 'String.prototype.trimMiddle' for clarity. · 6f6d9bc9
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111700
      
      Reviewed by Darin Adler.
      
      Darin suggested that 'KURL::elidedString' is inaccurately named[1], this
      patch is an attempt to do better. It additionally brings the Inspector's
      'String.prototype.trimMiddle' method into line, as the two methods do
      more or less the same thing.
      
      After a bit of discussion with Maciej and Daniel Bates on IRC, I've
      settled on 'KURL::stringCenterEllipsizedToLength(unsigned)' and
      'String.prototype.centerEllipsizedToLength(number)' respectively.
      
      No new tests are added, as this patch shouldn't have any visible effect
      on the web. It's strictly an internal refactoring.
      
      * Modules/websockets/WebSocket.cpp:
      (WebCore::WebSocket::connect):
      (WebCore::WebSocket::send):
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::send):
      (WebCore::WebSocketChannel::fail):
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::canExecuteScripts):
      * dom/Document.cpp:
      (WebCore::Document::processHttpEquiv):
      * dom/ScriptElement.cpp:
      (WebCore::ScriptElement::executeScript):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::canPlayType):
      (WebCore::HTMLMediaElement::isSafeToLoadURL):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::submitForm):
      (WebCore::FrameLoader::loadFrameRequest):
      (WebCore::FrameLoader::commitProvisionalLoad):
      (WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
      (WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
      (WebCore::createWindow):
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::willSendRequest):
      (WebCore::MainResourceLoader::responseReceived):
      * loader/MixedContentChecker.cpp:
      (WebCore::MixedContentChecker::logWarning):
      * loader/appcache/ApplicationCacheGroup.cpp:
      (WebCore::ApplicationCacheGroup::didReceiveResponse):
      (WebCore::ApplicationCacheGroup::didFail):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::canRequest):
      (WebCore::CachedResourceLoader::requestResource):
      (WebCore::CachedResourceLoader::loadResource):
      (WebCore::CachedResourceLoader::printAccessDeniedMessage):
      * page/ContentSecurityPolicy.cpp:
      (WebCore::CSPDirectiveList::checkSourceAndReportViolation):
      (WebCore::CSPDirectiveList::allowScriptNonce):
      (WebCore::CSPDirectiveList::allowPluginType):
      * platform/KURL.cpp:
      (WebCore::KURL::stringCenterEllipsizedToLength):
      * platform/KURL.h:
          Rename 'KURL::elidedString' to 'KURL::stringCenterEllipsizedToLength',
          and adjust callsites accordingly.
      * inspector/front-end/CallStackSidebarPane.js:
      (WebInspector.CallStackSidebarPane.Placard.prototype._update):
      * inspector/front-end/ElementsTreeOutline.js:
      (WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):
      * inspector/front-end/HeapSnapshotGridNodes.js:
      (WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
      * inspector/front-end/Linkifier.js:
      (WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor):
      * inspector/front-end/ResourceUtils.js:
      (WebInspector.linkifyURLAsNode):
      * inspector/front-end/TabbedEditorContainer.js:
      (WebInspector.TabbedEditorContainer.prototype._titleForFile):
      * inspector/front-end/utilities.js:
          Rename 'String.prototype.trimMiddle' to 'String.prototype.centerEllipsizedToLength'
          and adjust callsites accordingly.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f6d9bc9
  4. 05 Apr, 2013 1 commit
    • ggaren@apple.com's avatar
      Made USE(JSC) unconditional · 95708e2b
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114058
      
      Reviewed by Anders Carlsson.
      
      ../JavaScriptCore: 
      
      * config.h:
      
      ../ThirdParty: 
      
      * gtest/include/gtest/internal/gtest-port.h:
      
      ../WebCore: 
      
      * Modules/webdatabase/Database.cpp:
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::executeIfJavaScriptURL):
      * bindings/js/JavaScriptCallFrame.cpp:
      * bindings/js/JavaScriptCallFrame.h:
      * bindings/scripts/InFilesCompiler.pm:
      (generateHeadersHeader):
      * css/MediaQueryListListener.cpp:
      (WebCore::MediaQueryListListener::queryChanged):
      * dom/ContainerNode.cpp:
      (WebCore::dispatchChildRemovalEvents):
      * dom/EventListener.h:
      (EventListener):
      (WebCore::EventListener::visitJSFunction):
      * dom/EventTarget.h:
      (EventTarget):
      (WebCore):
      (WebCore::EventTarget::visitJSEventListeners):
      * dom/Node.cpp:
      * dom/Node.h:
      * dom/ScriptExecutionContext.cpp:
      (WebCore):
      (WebCore::ScriptExecutionContext::globalData):
      * dom/ScriptExecutionContext.h:
      (ScriptExecutionContext):
      * html/HTMLCanvasElement.cpp:
      (WebCore::HTMLCanvasElement::createImageBuffer):
      * html/HTMLImageLoader.cpp:
      (WebCore::HTMLImageLoader::notifyFinished):
      * inspector/InjectedScriptHost.h:
      (InjectedScriptHost):
      (WebCore::InjectedScriptHost::evaluateReturnsEvalFunction):
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      (WebCore::InspectorInstrumentation::didCommitLoadImpl):
      * page/Frame.cpp:
      * page/Settings.cpp:
      (WebCore):
      (WebCore::Settings::shouldRespectPriorityInCSSAttributeSetters):
      * page/Settings.h:
      (Settings):
      * plugins/PluginView.cpp:
      (WebCore::PluginView::start):
      (WebCore::PluginView::stop):
      (WebCore::PluginView::performRequest):
      (WebCore::PluginView::npObject):
      (WebCore):
      (WebCore::PluginView::bindingInstance):
      (WebCore::PluginView::privateBrowsingStateChanged):
      * plugins/PluginView.h:
      (PluginView):
      * plugins/PluginViewBase.h:
      (PluginViewBase):
      (WebCore::PluginViewBase::scriptObject):
      * plugins/PluginViewNone.cpp:
      (WebCore):
      (WebCore::PluginView::bindingInstance):
      * plugins/qt/PluginViewQt.cpp:
      (WebCore::PluginView::dispatchNPEvent):
      (WebCore::PluginView::setNPWindowIfNeeded):
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::dropProtection):
      
      ../WebKit/efl: 
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_script_execute):
      
      ../WebKit/qt: 
      
      * Api/qwebscriptworld.cpp:
      (QWebScriptWorld::QWebScriptWorld):
      
      ../WebKit2: 
      
      * Shared/linux/WebMemorySamplerLinux.cpp:
      (WebKit::WebMemorySampler::sampleWebKit):
      * config.h:
      
      ../WTF: 
      
      * wtf/ThreadRestrictionVerifier.h:
      (WTF):
      * wtf/WTFThreadData.cpp:
      (WTF::WTFThreadData::WTFThreadData):
      (WTF::WTFThreadData::~WTFThreadData):
      * wtf/WTFThreadData.h:
      (WTFThreadData):
      * wtf/text/StringImpl.cpp:
      (WTF::StringImpl::~StringImpl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95708e2b
  5. 12 Mar, 2013 1 commit
    • jochen@chromium.org's avatar
      Rename DefinitelyProcessingUserGesture to DefinitelyProcessingNewUserGesture · 03ba0510
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111959
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore:
      
      The rationale is that the UserGestureIndicator will increase the number
      of consumable user gestures when it's invoked with what is now
      DefinitelyProcessingNewUserGesture.
      
      In a follow-up change I will reintroduce DefinitelyProcessingUserGesture
      which will only increase the consumable user gesture count if we are
      not already processing a user gesture.
      
      No new tests, no change in functionality.
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::increment):
      (WebCore::AccessibilityNodeObject::decrement):
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::press):
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::executeScript):
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::executeScriptInWorld):
      * bindings/v8/NPV8Object.cpp:
      (_NPN_EvaluateHelper):
      * dom/UserGestureIndicator.cpp:
      (WebCore::isDefinite):
      (WebCore::UserGestureIndicator::UserGestureIndicator):
      (WebCore::UserGestureIndicator::processingUserGesture):
      * dom/UserGestureIndicator.h:
      * inspector/InspectorFrontendClientLocal.cpp:
      (WebCore::InspectorFrontendClientLocal::openInNewTab):
      * inspector/InspectorFrontendHost.cpp:
      (WebCore::FrontendMenuProvider::contextMenuItemSelected):
      * inspector/InspectorPageAgent.cpp:
      (WebCore::InspectorPageAgent::navigate):
      * loader/NavigationScheduler.cpp:
      (WebCore::ScheduledURLNavigation::fire):
      (WebCore::ScheduledURLNavigation::didStartTimer):
      (WebCore::ScheduledRedirect::fire):
      (WebCore::ScheduledRefresh::fire):
      (WebCore::ScheduledHistoryNavigation::fire):
      (WebCore::ScheduledFormSubmission::fire):
      (WebCore::ScheduledFormSubmission::didStartTimer):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleMousePressEvent):
      (WebCore::EventHandler::handleMouseDoubleClickEvent):
      (WebCore::EventHandler::handleMouseReleaseEvent):
      (WebCore::EventHandler::keyEvent):
      (WebCore::EventHandler::handleTouchEvent):
      * platform/chromium/PopupContainer.cpp:
      (WebCore::PopupContainer::handleMouseDownEvent):
      (WebCore::PopupContainer::handleMouseMoveEvent):
      (WebCore::PopupContainer::handleMouseReleaseEvent):
      (WebCore::PopupContainer::handleWheelEvent):
      (WebCore::PopupContainer::handleKeyEvent):
      
      Source/WebKit/blackberry:
      
      * WebKitSupport/NotificationManager.cpp:
      (BlackBerry::WebKit::NotificationManager::notificationClicked):
      
      Source/WebKit/chromium:
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::executeScriptAndReturnValue):
      * src/WebNotification.cpp:
      (WebKit::WebNotification::dispatchClickEvent):
      * src/WebPluginContainerImpl.cpp:
      (WebKit::WebPluginContainerImpl::handleEvent):
      (WebKit::WebPluginContainerImpl::loadFrameRequest):
      * src/WebScopedUserGesture.cpp:
      (WebKit::WebScopedUserGesture::initialize):
      * tests/WebUserGestureTokenTest.cpp:
      (WebCore::TEST):
      
      Source/WebKit/mac:
      
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::evaluate):
      * Plugins/WebNetscapePluginView.mm:
      (-[WebNetscapePluginView sendEvent:isDrawRect:]):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      (WebCore::NotificationPresenterClientQt::notificationClicked):
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebContextMenuClient.cpp:
      (WebContextMenuClient::searchWithGoogle):
      
      Source/WebKit2:
      
      * WebProcess/Notifications/WebNotificationManager.cpp:
      (WebKit::WebNotificationManager::didClickNotification):
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::evaluate):
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      (WebKit::WebContextMenuClient::searchWithGoogle):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@145453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03ba0510
  6. 06 Mar, 2013 1 commit
    • commit-queue@webkit.org's avatar
      Introduce new message sources for logging. · c79ed84a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=110968
      
      Patch by Dmitry Zvorygin <zvorygin@chromium.org> on 2013-03-06
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Added SecurityMessageSource, RenderingMessageSource, StorageMessageSource, AppCacheMessageSource, CSSMessageSource.
      Changed some logging lines to contain more descriptive message source.
      
      * Modules/webdatabase/DatabaseBase.cpp:
      (WebCore::DatabaseBase::logErrorMessage):
      * Modules/webdatabase/DatabaseManager.cpp:
      (WebCore::DatabaseManager::logErrorMessage):
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::fail):
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::canExecuteScripts):
      * css/MediaList.cpp:
      (WebCore::addResolutionWarningMessageToConsole):
      * dom/Document.cpp:
      (WebCore::Document::processHttpEquiv):
      * dom/ScriptElement.cpp:
      (WebCore::ScriptElement::executeScript):
      (WebCore::ScriptElement::notifyFinished):
      * dom/ViewportArguments.cpp:
      (WebCore::reportViewportWarning):
      * html/HTMLFormControlElement.cpp:
      (WebCore::shouldAutofocus):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::validateInteractively):
      * html/HTMLIFrameElement.cpp:
      (WebCore::HTMLIFrameElement::parseAttribute):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::getImageData):
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      (WebCore::WebGLRenderingContext::printWarningToConsole):
      * html/parser/XSSAuditor.cpp:
      (WebCore::XSSAuditor::init):
      * html/parser/XSSAuditorDelegate.cpp:
      (WebCore::XSSAuditorDelegate::didBlockScript):
      * inspector/ConsoleMessage.cpp:
      (WebCore::messageSourceValue):
      * inspector/Inspector.json:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::submitForm):
      (WebCore::FrameLoader::reportLocalLoadFailed):
      (WebCore::createWindow):
      * loader/ImageLoader.cpp:
      (WebCore::ImageLoader::notifyFinished):
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::responseReceived):
      * loader/MixedContentChecker.cpp:
      (WebCore::MixedContentChecker::logWarning):
      * loader/TextTrackLoader.cpp:
      (WebCore::TextTrackLoader::corsPolicyPreventedLoad):
      * loader/appcache/ApplicationCacheGroup.cpp:
      (WebCore::ApplicationCacheGroup::abort):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::printAccessDeniedMessage):
      * page/Console.cpp:
      (WebCore::printMessageSourceAndLevelPrefix):
      * page/ConsoleTypes.h:
      * page/ContentSecurityPolicy.cpp:
      (WebCore::ContentSecurityPolicy::logToConsole):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::dispatchMessageEventWithOriginCheck):
      * page/PointerLockController.cpp:
      (WebCore::PointerLockController::requestPointerLock):
      * svg/SVGDocumentExtensions.cpp:
      (WebCore::reportMessage):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebChromeClient.mm:
      * WebView/WebUIDelegatePrivate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c79ed84a
  7. 04 Mar, 2013 1 commit
    • mkwst@chromium.org's avatar
      Long URLs in error messages should be shortened · d3d99564
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111133
      
      Reviewed by Jochen Eisinger.
      
      When generating console messages, we're often copying the page's URL
      in order to add detail about where the error occurred. Generally, this
      is fine, but in edge cases (multi-meg 'data:' URLs), we're using far
      more memory than we should, and impacting performance.
      
      This patch adds an 'elidedString()' method to KURL for use in this
      sort of case; when generating console messages, we should insert the
      elided URL rather than the full URL.
      
      This shouldn't change any visible behavior; we're already visually
      eliding URLs in console messages for URLs above 150 characters. This
      patch simply changes the underlying string to ensure that no URL is
      over 1k in length to begin with.
      
      * platform/KURL.cpp:
      (WebCore::KURL::elidedString): Added.
      * platform/KURL.h:
          An exciting new method that gives you the same result as string()
          for URLs less than 1k long, and elides the middle of URLs longer
          than 1k by replacing everything but the first and last 0.5k with
          "...".
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::canExecuteScripts):
      * Modules/websockets/WebSocket.cpp:
      (WebCore::WebSocket::connect):
      (WebCore::WebSocket::send):
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::send):
      (WebCore::WebSocketChannel::fail):
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::canExecuteScripts):
      * dom/Document.cpp:
      (WebCore::Document::processHttpEquiv):
      * dom/ScriptElement.cpp:
      (WebCore::ScriptElement::executeScript):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::canPlayType):
      (WebCore::HTMLMediaElement::isSafeToLoadURL):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::submitForm):
      (WebCore::FrameLoader::loadFrameRequest):
      (WebCore::FrameLoader::commitProvisionalLoad):
      (WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
      (WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
      (WebCore::createWindow):
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::willSendRequest):
      (WebCore::MainResourceLoader::responseReceived):
      * loader/appcache/ApplicationCacheGroup.cpp:
      (WebCore::ApplicationCacheGroup::didReceiveResponse):
      (WebCore::ApplicationCacheGroup::didFail):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::canRequest):
      (WebCore::CachedResourceLoader::requestResource):
      (WebCore::CachedResourceLoader::loadResource):
      (WebCore::CachedResourceLoader::printAccessDeniedMessage):
      * page/ContentSecurityPolicy.cpp:
      (WebCore::CSPDirectiveList::checkSourceAndReportViolation):
      (WebCore::CSPDirectiveList::allowScriptNonce):
      (WebCore::CSPDirectiveList::allowPluginType):
          Use 'KURL::elidedString()' rather than 'KURL::string()'
      * loader/MixedContentChecker.cpp:
      (WebCore::MixedContentChecker::logWarning):
          Here, we're doing the same as above, but it enables us to throw
          away the asUTF8() function entirely by switching to makeString
          rather than String::format.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3d99564
  8. 03 Mar, 2013 2 commits
    • abarth@webkit.org's avatar
      Unreviewed attempted build fix. Adds back some includes removed in · 401a3791
      abarth@webkit.org authored
      http://trac.webkit.org/changeset/144565.
      
      Source/WebCore: 
      
      * Modules/mediastream/RTCPeerConnection.cpp:
      * bindings/ScriptControllerBase.cpp:
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      (WebCore):
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/FrameLoader.cpp:
      * loader/MainResourceLoader.cpp:
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/cache/CachedResource.cpp:
      * loader/icon/IconController.cpp:
      * page/DOMWindowExtension.cpp:
      * page/Frame.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginView.cpp:
      * rendering/HitTestResult.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResource.cpp:
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      (WebCore):
      
      Source/WebKit/chromium: 
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      (WebCore):
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/mac: 
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2: 
      
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      401a3791
    • abarth@webkit.org's avatar
      Unreviewed rollout of http://trac.webkit.org/r144530 · fa616dd3
      abarth@webkit.org authored
      As described in https://bugs.webkit.org/show_bug.cgi?id=111167 and
      https://bugs.webkit.org/show_bug.cgi?id=111035, this patch caused a
      large number of ASSERTs in chromium-win.
      
      Source/WebCore: 
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCPeerConnection.cpp:
      * Modules/notifications/Notification.cpp:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/ScriptControllerBase.cpp:
      * bindings/js/JSNodeCustom.cpp:
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptSourceCode.h:
      (WebCore):
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSCrossfadeValue.h:
      (WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
      (WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
      * css/CSSFontFaceSource.h:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * css/WebKitCSSSVGDocumentValue.h:
      (WebCore):
      * dom/Clipboard.cpp:
      (WebCore::Clipboard::Clipboard):
      * dom/ContainerNode.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/HTMLScriptRunner.h:
      * html/parser/XSSAuditor.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      (WebCore):
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      (WebCore):
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/CrossOriginAccessControl.h:
      (WebCore):
      * loader/CrossOriginPreflightResultCache.h:
      * loader/DocumentThreadableLoader.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::FrameLoader):
      * loader/FrameLoader.h:
      (WebCore):
      (WebCore::FrameLoader::policyChecker):
      * loader/ImageLoader.cpp:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      (WebCore):
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      (WebCore):
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/PolicyChecker.h:
      (WebCore):
      * loader/ProgressTracker.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/TextTrackLoader.cpp:
      * loader/TextTrackLoader.h:
      (WebCore):
      * loader/ThreadableLoader.h:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheGroup.h:
      (WebCore):
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedFont.h:
      (CachedFontClient):
      (WebCore::CachedFontClient::~CachedFontClient):
      (WebCore::CachedFontClient::expectedType):
      (WebCore::CachedFontClient::resourceClientType):
      (WebCore::CachedFontClient::fontLoaded):
      (WebCore):
      * loader/cache/CachedFontClient.h: Removed.
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedRawResource.cpp:
      * loader/cache/CachedRawResource.h:
      (WebCore):
      (CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::~CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::expectedType):
      (WebCore::CachedRawResourceClient::resourceClientType):
      (WebCore::CachedRawResourceClient::dataSent):
      (WebCore::CachedRawResourceClient::responseReceived):
      (WebCore::CachedRawResourceClient::dataReceived):
      (WebCore::CachedRawResourceClient::redirectReceived):
      (WebCore::CachedRawResourceClient::dataDownloaded):
      * loader/cache/CachedRawResourceClient.h: Removed.
      * loader/cache/CachedResource.cpp:
      * loader/cache/CachedResourceHandle.cpp:
      (WebCore):
      * loader/cache/CachedResourceHandle.h:
      (WebCore):
      (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
      (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
      * loader/cache/CachedSVGDocument.h:
      (CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::expectedType):
      (WebCore::CachedSVGDocumentClient::resourceClientType):
      (WebCore):
      * loader/cache/CachedSVGDocumentClient.h: Removed.
      * loader/cache/CachedSVGDocumentReference.cpp: Removed.
      * loader/cache/CachedSVGDocumentReference.h:
      (WebCore):
      (WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
      (WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
      * loader/cache/CachedStyleSheetClient.h:
      (WebCore):
      * loader/cache/MemoryCache.h:
      (WebCore):
      (MemoryCache):
      * loader/chromium/CachedRawResourceChromium.cpp:
      * loader/icon/IconController.cpp:
      * loader/icon/IconLoader.h:
      * loader/mac/ResourceLoaderMac.mm:
      * page/DOMWindowExtension.cpp:
      * page/Frame.cpp:
      (WebCore::Frame::Frame):
      (WebCore):
      (WebCore::Frame::reportMemoryUsage):
      * page/Frame.h:
      (WebCore):
      (Frame):
      (WebCore::Frame::init):
      (WebCore::Frame::loader):
      * page/PerformanceNavigation.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/Settings.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/filters/FilterOperation.cpp:
      (WebCore):
      * platform/graphics/filters/FilterOperation.h:
      (WebCore):
      (WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
      (WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PasteboardMac.mm:
      * platform/network/AuthenticationChallengeBase.cpp:
      * platform/network/cf/CookieJarCFNet.cpp:
      * platform/network/cf/ResourceRequestCFNet.cpp:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginRequest.h: Removed.
      * plugins/PluginStream.h:
      (PluginStreamClient):
      (WebCore::PluginStreamClient::~PluginStreamClient):
      (WebCore::PluginStreamClient::streamDidFinishLoading):
      (WebCore):
      * plugins/PluginStreamClient.h: Removed.
      * plugins/PluginView.cpp:
      * plugins/PluginView.h:
      (WebCore):
      (PluginRequest):
      (WebCore::PluginRequest::PluginRequest):
      (WebCore::PluginRequest::frameLoadRequest):
      (WebCore::PluginRequest::notifyData):
      (WebCore::PluginRequest::sendNotification):
      (WebCore::PluginRequest::shouldAllowPopups):
      * rendering/HitTestResult.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/RenderBox.cpp:
      * rendering/RenderEmbeddedObject.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResource.cpp:
      (WebCore::RenderImageResource::RenderImageResource):
      (WebCore):
      * rendering/RenderImageResource.h:
      (WebCore::RenderImageResource::image):
      (WebCore::RenderImageResource::errorOccurred):
      (WebCore::RenderImageResource::usesImageContainerSize):
      (WebCore::RenderImageResource::imageHasRelativeWidth):
      (WebCore::RenderImageResource::imageHasRelativeHeight):
      (WebCore::RenderImageResource::imageSize):
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerFilterInfo.h:
      (WebCore):
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderSnapshottedPlugIn.cpp:
      * rendering/RenderTableCol.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/style/StyleCachedShader.h:
      * rendering/style/StyleCustomFilterProgram.cpp: Removed.
      * rendering/style/StyleCustomFilterProgram.h:
      (WebCore):
      (WebCore::StyleCustomFilterProgram::vertexShaderString):
      (StyleCustomFilterProgram):
      (WebCore::StyleCustomFilterProgram::fragmentShaderString):
      (WebCore::StyleCustomFilterProgram::isLoaded):
      (WebCore::StyleCustomFilterProgram::willHaveClients):
      (WebCore::StyleCustomFilterProgram::didRemoveLastClient):
      (WebCore::StyleCustomFilterProgram::notifyFinished):
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      (SVGFontFaceUriElement):
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * svg/SVGUseElement.h:
      * svg/graphics/SVGImageCache.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      (WebCore):
      * xml/XSLTProcessorLibxslt.cpp:
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      
      Source/WebKit/chromium: 
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      (WebCore):
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/gtk: 
      
      * webkit/webkitwebpolicydecision.cpp:
      
      Source/WebKit/mac: 
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2: 
      
      * NetworkProcess/HostRecord.h:
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      * NetworkProcess/NetworkResourceLoader.h:
      (WebCore):
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa616dd3
  9. 02 Mar, 2013 1 commit
    • ap@apple.com's avatar
      Reduce amount of rebuilding when touching networking headers · fc363ce1
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=111035
      
              Reviewed by Eric Seidel.
      
              This uses a number of common unsurprising techniques. One interesting observation
              is that including CachedResource related headers is very expensive. We can usually
              get away with their Client counterparts, and with CachedResourceHandle.
      
              * page/Frame.cpp:
              * page/Frame.h:
              Don't include FrameLoader, greatly reducing include graph for most non-loader files.
              This required making Frame::init() non-inline - I'm not sure why it ever was.
      
              * loader/FrameLoader.cpp:
              * loader/FrameLoader.h:
              Even though FrameLoader is logically on loading side of WebCore, it's included in
              too many places. Not including PolicyChecker.h and ResourceHandle.h was among the
              largest wins. As a future improvement, we should probably convert other members
              to OwnPtrs.
      
              * css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a
              definition of a class it holds, but default construction does not.
      
              * loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h,
              not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
      
              * loader/cache/CachedFont.h:
              * loader/cache/CachedFontClient.h: Added.
              * loader/cache/CachedRawResource.h:
              * loader/cache/CachedRawResourceClient.h: Added.
              * loader/cache/CachedSVGDocument.h:
              * loader/cache/CachedSVGDocumentClient.h: Added.
              These types were defining client types in the same headers, making it impossible
              to avoid including networking headers through CachedResource. Moved clients into
              separate files.
      
              * plugins/PluginStream.h:
              * plugins/PluginStreamClient.h: Added.
              Similar situation here.
      
              * loader/cache/CachedResourceHandle.cpp:
              * loader/cache/CachedResourceHandle.h:
              Moved functions that need to know about CachedResource to .cpp file. This is another
              huge win. Added a destructor, so that CachedResource woudn't be needed in all files
              that include CachedResourceHandle.
      
              * loader/cache/CachedSVGDocumentReference.cpp: Added.
              * loader/cache/CachedSVGDocumentReference.h:
              Moved constructor and virtual function implementations to a .cpp file - they need
              not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
      
              * platform/graphics/filters/FilterOperation.cpp:
              * platform/graphics/filters/FilterOperation.h:
              Avoid including CachedSVGDocumentReference.h. This is not such a big win now that
              CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly
              rendering code that it seems best to cut any ties with resources and loading.
              Added a virtual destrutor in .cpp file, because inline destructors in polymorphic
              classes are generally harmful (due to code bloat).
      
              * plugins/PluginRequest.h: Added.
              * plugins/PluginView.h:
              Moved PluginRequest into a separate file, it was out of place in a view hierarchy
              class file.
      
              * rendering/RenderImageResource.cpp:
              * rendering/RenderImageResource.h:
              Moved definitions of virtual functions to a .cpp file. Thre is no win from having
              them inline, and now we don't need CachedImage.h in the header.
      
              * rendering/style/StyleCustomFilterProgram.cpp: Added.
              * rendering/style/StyleCustomFilterProgram.h:
              Ditto.
      
              * CMakeLists.txt:
              * GNUmakefile.list.am:
              * Modules/mediastream/RTCPeerConnection.cpp:
              * Modules/notifications/Notification.cpp:
              * Target.pri:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcxproj/WebCore.vcxproj:
              * WebCore.vcxproj/WebCore.vcxproj.filters:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/ScriptControllerBase.cpp:
              * bindings/js/JSNodeCustom.cpp:
              * bindings/js/ScriptController.cpp:
              * bindings/js/ScriptSourceCode.h:
              * bindings/objc/DOM.mm:
              * bindings/v8/ScriptController.cpp:
              * bindings/v8/V8DOMWindowShell.cpp:
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              * css/CSSFontFaceSource.h:
              * css/CSSFontSelector.cpp:
              * css/WebKitCSSSVGDocumentValue.cpp:
              * css/WebKitCSSSVGDocumentValue.h:
              * dom/Clipboard.cpp:
              * dom/ContainerNode.cpp:
              * dom/DOMImplementation.cpp:
              * dom/PendingScript.h:
              * dom/ScriptElement.cpp:
              * dom/ScriptElement.h:
              * history/CachedFrame.cpp:
              * html/DOMURL.cpp:
              * html/HTMLAnchorElement.cpp:
              * html/HTMLAppletElement.cpp:
              * html/HTMLElement.cpp:
              * html/HTMLEmbedElement.cpp:
              * html/HTMLFrameSetElement.cpp:
              * html/HTMLHtmlElement.cpp:
              * html/HTMLImageElement.cpp:
              * html/HTMLObjectElement.cpp:
              * html/HTMLPlugInElement.cpp:
              * html/ImageDocument.cpp:
              * html/ImageInputType.cpp:
              * html/MediaDocument.cpp:
              * html/PluginDocument.cpp:
              * html/canvas/WebGLRenderingContext.cpp:
              * html/parser/HTMLConstructionSite.cpp:
              * html/parser/HTMLParserOptions.cpp:
              * html/parser/HTMLScriptRunner.h:
              * html/parser/XSSAuditor.cpp:
              * html/parser/XSSAuditorDelegate.cpp:
              * inspector/InspectorDebuggerAgent.cpp:
              * inspector/InspectorFileSystemAgent.cpp:
              * inspector/InspectorFrontendHost.cpp:
              * inspector/InspectorInstrumentation.h:
              * inspector/InspectorPageAgent.cpp:
              * inspector/NetworkResourcesData.cpp:
              * inspector/NetworkResourcesData.h:
              * loader/CookieJar.cpp:
              * loader/CrossOriginAccessControl.cpp:
              * loader/CrossOriginPreflightResultCache.h:
              * loader/DocumentThreadableLoader.h:
              * loader/ImageLoader.cpp:
              * loader/ImageLoader.h:
              * loader/LinkLoader.h:
              * loader/MainResourceLoader.cpp:
              * loader/MainResourceLoader.h:
              * loader/MixedContentChecker.cpp:
              * loader/PingLoader.cpp:
              * loader/PolicyChecker.h:
              * loader/ProgressTracker.cpp:
              * loader/SubframeLoader.cpp:
              * loader/SubresourceLoader.cpp:
              * loader/TextTrackLoader.cpp:
              * loader/TextTrackLoader.h:
              * loader/ThreadableLoader.h:
              * loader/appcache/ApplicationCacheGroup.cpp:
              * loader/appcache/ApplicationCacheGroup.h:
              * loader/appcache/ApplicationCacheHost.cpp:
              * loader/archive/cf/LegacyWebArchive.cpp:
              * loader/cache/CachedFont.cpp:
              * loader/cache/CachedImage.cpp:
              * loader/cache/CachedRawResource.cpp:
              * loader/cache/CachedResource.cpp:
              * loader/cache/CachedStyleSheetClient.h:
              * loader/cache/MemoryCache.cpp:
              * loader/cache/MemoryCache.h:
              * loader/chromium/CachedRawResourceChromium.cpp:
              * loader/icon/IconController.cpp:
              * loader/icon/IconLoader.h:
              * loader/mac/ResourceLoaderMac.mm:
              * page/DOMWindowExtension.cpp:
              * page/DragController.cpp:
              * page/PerformanceNavigation.cpp:
              * page/PerformanceTiming.cpp:
              * page/PointerLockController.cpp:
              * page/Settings.cpp:
              * page/animation/CSSPropertyAnimation.cpp:
              * platform/chromium/PasteboardChromium.cpp:
              * platform/efl/ErrorsEfl.cpp:
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
              * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
              * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
              * platform/gtk/ErrorsGtk.cpp:
              * platform/gtk/PasteboardGtk.cpp:
              * platform/gtk/PasteboardHelper.h:
              * platform/mac/ClipboardMac.h:
              * platform/mac/ClipboardMac.mm:
              * platform/mac/HTMLConverter.mm:
              * platform/mac/PasteboardMac.mm:
              * platform/network/AuthenticationChallengeBase.cpp:
              * platform/network/cf/CookieJarCFNet.cpp:
              * platform/network/cf/ResourceRequestCFNet.cpp:
              * platform/network/mac/CookieStorageMac.mm:
              * platform/qt/PasteboardQt.cpp:
              * plugins/DOMMimeType.cpp:
              * plugins/PluginView.cpp:
              * rendering/HitTestResult.cpp:
              * rendering/InlineFlowBox.cpp:
              * rendering/RenderBox.cpp:
              * rendering/RenderEmbeddedObject.cpp:
              * rendering/RenderImage.cpp:
              * rendering/RenderImageResourceStyleImage.cpp:
              * rendering/RenderLayer.cpp:
              * rendering/RenderLayerBacking.cpp:
              * rendering/RenderLayerFilterInfo.h:
              * rendering/RenderListItem.cpp:
              * rendering/RenderListMarker.cpp:
              * rendering/RenderSnapshottedPlugIn.cpp:
              * rendering/RenderTableCol.cpp:
              * rendering/RenderTableRow.cpp:
              * rendering/RenderTableSection.cpp:
              * rendering/style/StyleCachedShader.h:
              * svg/SVGFEImageElement.h:
              * svg/SVGFontFaceUriElement.h:
              * svg/SVGImageLoader.cpp:
              * svg/SVGUseElement.cpp:
              * svg/SVGUseElement.h:
              * svg/graphics/SVGImageCache.cpp:
              * testing/MockPagePopupDriver.cpp:
              * xml/XSLStyleSheet.h:
              * xml/XSLTProcessorLibxslt.cpp:
              * xml/parser/XMLDocumentParser.cpp:
              * xml/parser/XMLDocumentParser.h:
              * xml/parser/XMLDocumentParserLibxml2.cpp:
              Many self-evident changes - removing unnecessary header includes, adding smaller
              more local ones that are now necessary.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc363ce1
  10. 01 Mar, 2013 2 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r144422 and r144424. · 0b87a6c7
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/144422
      http://trac.webkit.org/changeset/144424
      https://bugs.webkit.org/show_bug.cgi?id=111167
      
      Caused over 20 tests to fail assertion on Chromium Win port as
      ASSERTION FAILED: m_platformRequestUpdated (Requested by
      toyoshim on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-01
      
      Source/WebCore:
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCPeerConnection.cpp:
      * Modules/notifications/Notification.cpp:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/ScriptControllerBase.cpp:
      * bindings/js/JSNodeCustom.cpp:
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptSourceCode.h:
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSCrossfadeValue.h:
      (WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
      (WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
      * css/CSSFontFaceSource.h:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * css/WebKitCSSSVGDocumentValue.h:
      (WebCore):
      * dom/Clipboard.cpp:
      (WebCore::Clipboard::Clipboard):
      * dom/ContainerNode.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/HTMLScriptRunner.h:
      * html/parser/XSSAuditor.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      (WebCore):
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      (WebCore):
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/CrossOriginAccessControl.h:
      (WebCore):
      * loader/CrossOriginPreflightResultCache.h:
      * loader/DocumentThreadableLoader.h:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::FrameLoader):
      * loader/FrameLoader.h:
      (WebCore):
      (WebCore::FrameLoader::policyChecker):
      * loader/ImageLoader.cpp:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/PolicyChecker.h:
      (WebCore):
      * loader/ProgressTracker.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/TextTrackLoader.cpp:
      * loader/TextTrackLoader.h:
      * loader/ThreadableLoader.h:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheGroup.h:
      (WebCore):
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedFont.h:
      (CachedFontClient):
      (WebCore::CachedFontClient::~CachedFontClient):
      (WebCore::CachedFontClient::expectedType):
      (WebCore::CachedFontClient::resourceClientType):
      (WebCore::CachedFontClient::fontLoaded):
      (WebCore):
      * loader/cache/CachedFontClient.h: Removed.
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedRawResource.cpp:
      * loader/cache/CachedRawResource.h:
      (WebCore):
      (CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::~CachedRawResourceClient):
      (WebCore::CachedRawResourceClient::expectedType):
      (WebCore::CachedRawResourceClient::resourceClientType):
      (WebCore::CachedRawResourceClient::dataSent):
      (WebCore::CachedRawResourceClient::responseReceived):
      (WebCore::CachedRawResourceClient::dataReceived):
      (WebCore::CachedRawResourceClient::redirectReceived):
      (WebCore::CachedRawResourceClient::dataDownloaded):
      * loader/cache/CachedRawResourceClient.h: Removed.
      * loader/cache/CachedResource.cpp:
      * loader/cache/CachedResourceHandle.cpp:
      * loader/cache/CachedResourceHandle.h:
      (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
      (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
      * loader/cache/CachedSVGDocument.h:
      (CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::expectedType):
      (WebCore::CachedSVGDocumentClient::resourceClientType):
      (WebCore):
      * loader/cache/CachedSVGDocumentClient.h: Removed.
      * loader/cache/CachedSVGDocumentReference.cpp: Removed.
      * loader/cache/CachedSVGDocumentReference.h:
      (WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
      (WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
      * loader/cache/CachedStyleSheetClient.h:
      * loader/cache/MemoryCache.cpp:
      * loader/cache/MemoryCache.h:
      (WebCore):
      (MemoryCache):
      * loader/chromium/CachedRawResourceChromium.cpp:
      * loader/icon/IconController.cpp:
      * loader/icon/IconLoader.h:
      * loader/mac/ResourceLoaderMac.mm:
      * page/DOMWindowExtension.cpp:
      * page/DragController.cpp:
      * page/Frame.cpp:
      (WebCore::Frame::Frame):
      (WebCore::Frame::reportMemoryUsage):
      * page/Frame.h:
      (WebCore):
      (Frame):
      (WebCore::Frame::init):
      (WebCore::Frame::loader):
      * page/PerformanceNavigation.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/Settings.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/filters/FilterOperation.cpp:
      * platform/graphics/filters/FilterOperation.h:
      (WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
      (WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PasteboardMac.mm:
      * platform/network/AuthenticationChallengeBase.cpp:
      * platform/network/cf/CookieJarCFNet.cpp:
      * platform/network/cf/ResourceRequestCFNet.cpp:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginRequest.h: Removed.
      * plugins/PluginStream.h:
      (PluginStreamClient):
      (WebCore::PluginStreamClient::~PluginStreamClient):
      (WebCore::PluginStreamClient::streamDidFinishLoading):
      (WebCore):
      * plugins/PluginStreamClient.h: Removed.
      * plugins/PluginView.cpp:
      * plugins/PluginView.h:
      (WebCore):
      (PluginRequest):
      (WebCore::PluginRequest::PluginRequest):
      (WebCore::PluginRequest::frameLoadRequest):
      (WebCore::PluginRequest::notifyData):
      (WebCore::PluginRequest::sendNotification):
      (WebCore::PluginRequest::shouldAllowPopups):
      * rendering/HitTestResult.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/RenderBox.cpp:
      * rendering/RenderEmbeddedObject.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResource.cpp:
      (WebCore::RenderImageResource::RenderImageResource):
      * rendering/RenderImageResource.h:
      (WebCore::RenderImageResource::image):
      (WebCore::RenderImageResource::errorOccurred):
      (WebCore::RenderImageResource::usesImageContainerSize):
      (WebCore::RenderImageResource::imageHasRelativeWidth):
      (WebCore::RenderImageResource::imageHasRelativeHeight):
      (WebCore::RenderImageResource::imageSize):
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerFilterInfo.h:
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderSnapshottedPlugIn.cpp:
      * rendering/RenderTableCol.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/style/StyleCachedShader.h:
      * rendering/style/StyleCustomFilterProgram.cpp: Removed.
      * rendering/style/StyleCustomFilterProgram.h:
      (WebCore):
      (WebCore::StyleCustomFilterProgram::vertexShaderString):
      (StyleCustomFilterProgram):
      (WebCore::StyleCustomFilterProgram::fragmentShaderString):
      (WebCore::StyleCustomFilterProgram::isLoaded):
      (WebCore::StyleCustomFilterProgram::willHaveClients):
      (WebCore::StyleCustomFilterProgram::didRemoveLastClient):
      (WebCore::StyleCustomFilterProgram::notifyFinished):
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      (SVGFontFaceUriElement):
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * svg/SVGUseElement.h:
      * svg/graphics/SVGImageCache.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      * xml/XSLTProcessorLibxslt.cpp:
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      
      Source/WebKit/chromium:
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      (WebCore):
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl:
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebpolicydecision.cpp:
      
      Source/WebKit/mac:
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt:
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2:
      
      * NetworkProcess/HostRecord.h:
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      * NetworkProcess/NetworkResourceLoader.h:
      (WebCore):
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b87a6c7
    • ap@apple.com's avatar
      Reduce amount of rebuilding when touching networking headers · b2f13721
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=111035
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      This uses a number of common unsurprising techniques. One interesting observation
      is that including CachedResource related headers is very expensive. We can usually
      get away with their Client counterparts, and with CachedResourceHandle.
      
      * page/Frame.cpp:
      * page/Frame.h:
      Don't include FrameLoader, greatly reducing include graph for most non-loader files.
      This required making Frame::init() non-inline - I'm not sure why it ever was.
      
      * loader/FrameLoader.cpp:
      * loader/FrameLoader.h:
      Even though FrameLoader is logically on loading side of WebCore, it's included in
      too many places. Not including PolicyChecker.h and ResourceHandle.h was among the
      largest wins. As a future improvement, we should probably convert other members
      to OwnPtrs.
      
      * css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a
      definition of a class it holds, but default construction does not.
      
      * loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h,
      not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.
      
      * loader/cache/CachedFont.h:
      * loader/cache/CachedFontClient.h: Added.
      * loader/cache/CachedRawResource.h:
      * loader/cache/CachedRawResourceClient.h: Added.
      * loader/cache/CachedSVGDocument.h:
      * loader/cache/CachedSVGDocumentClient.h: Added.
      These types were defining client types in the same headers, making it impossible
      to avoid including networking headers through CachedResource. Moved clients into
      separate files.
      
      * plugins/PluginStream.h:
      * plugins/PluginStreamClient.h: Added.
      Similar situation here.
      
      * loader/cache/CachedResourceHandle.cpp:
      * loader/cache/CachedResourceHandle.h:
      Moved functions that need to know about CachedResource to .cpp file. This is another
      huge win. Added a destructor, so that CachedResource woudn't be needed in all files
      that include CachedResourceHandle.
      
      * loader/cache/CachedSVGDocumentReference.cpp: Added.
      * loader/cache/CachedSVGDocumentReference.h:
      Moved constructor and virtual function implementations to a .cpp file - they need
      not inlining, and this lets us avoid including CachedSVGDocument.h in the header.
      
      * platform/graphics/filters/FilterOperation.cpp:
      * platform/graphics/filters/FilterOperation.h:
      Avoid including CachedSVGDocumentReference.h. This is not such a big win now that
      CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly
      rendering code that it seems best to cut any ties with resources and loading.
      Added a virtual destrutor in .cpp file, because inline destructors in polymorphic
      classes are generally harmful (due to code bloat).
      
      * plugins/PluginRequest.h: Added.
      * plugins/PluginView.h:
      Moved PluginRequest into a separate file, it was out of place in a view hierarchy
      class file.
      
      * rendering/RenderImageResource.cpp:
      * rendering/RenderImageResource.h:
      Moved definitions of virtual functions to a .cpp file. Thre is no win from having
      them inline, and now we don't need CachedImage.h in the header.
      
      * rendering/style/StyleCustomFilterProgram.cpp: Added.
      * rendering/style/StyleCustomFilterProgram.h:
      Ditto.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Modules/mediastream/RTCPeerConnection.cpp:
      * Modules/notifications/Notification.cpp:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/ScriptControllerBase.cpp:
      * bindings/js/JSNodeCustom.cpp:
      * bindings/js/ScriptController.cpp:
      * bindings/js/ScriptSourceCode.h:
      * bindings/objc/DOM.mm:
      * bindings/v8/ScriptController.cpp:
      * bindings/v8/V8DOMWindowShell.cpp:
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      * css/CSSFontFaceSource.h:
      * css/CSSFontSelector.cpp:
      * css/WebKitCSSSVGDocumentValue.cpp:
      * css/WebKitCSSSVGDocumentValue.h:
      * dom/Clipboard.cpp:
      * dom/ContainerNode.cpp:
      * dom/DOMImplementation.cpp:
      * dom/PendingScript.h:
      * dom/ScriptElement.cpp:
      * dom/ScriptElement.h:
      * history/CachedFrame.cpp:
      * html/DOMURL.cpp:
      * html/HTMLAnchorElement.cpp:
      * html/HTMLAppletElement.cpp:
      * html/HTMLElement.cpp:
      * html/HTMLEmbedElement.cpp:
      * html/HTMLFrameSetElement.cpp:
      * html/HTMLHtmlElement.cpp:
      * html/HTMLImageElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLPlugInElement.cpp:
      * html/ImageDocument.cpp:
      * html/ImageInputType.cpp:
      * html/MediaDocument.cpp:
      * html/PluginDocument.cpp:
      * html/canvas/WebGLRenderingContext.cpp:
      * html/parser/HTMLConstructionSite.cpp:
      * html/parser/HTMLParserOptions.cpp:
      * html/parser/HTMLScriptRunner.h:
      * html/parser/XSSAuditor.cpp:
      * html/parser/XSSAuditorDelegate.cpp:
      * inspector/InspectorDebuggerAgent.cpp:
      * inspector/InspectorFileSystemAgent.cpp:
      * inspector/InspectorFrontendHost.cpp:
      * inspector/InspectorInstrumentation.h:
      * inspector/InspectorPageAgent.cpp:
      * inspector/NetworkResourcesData.cpp:
      * inspector/NetworkResourcesData.h:
      * loader/CookieJar.cpp:
      * loader/CrossOriginAccessControl.cpp:
      * loader/CrossOriginPreflightResultCache.h:
      * loader/DocumentThreadableLoader.h:
      * loader/ImageLoader.cpp:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      * loader/MainResourceLoader.cpp:
      * loader/MainResourceLoader.h:
      * loader/MixedContentChecker.cpp:
      * loader/PingLoader.cpp:
      * loader/PolicyChecker.h:
      * loader/ProgressTracker.cpp:
      * loader/SubframeLoader.cpp:
      * loader/SubresourceLoader.cpp:
      * loader/TextTrackLoader.cpp:
      * loader/TextTrackLoader.h:
      * loader/ThreadableLoader.h:
      * loader/appcache/ApplicationCacheGroup.cpp:
      * loader/appcache/ApplicationCacheGroup.h:
      * loader/appcache/ApplicationCacheHost.cpp:
      * loader/archive/cf/LegacyWebArchive.cpp:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedImage.cpp:
      * loader/cache/CachedRawResource.cpp:
      * loader/cache/CachedResource.cpp:
      * loader/cache/CachedStyleSheetClient.h:
      * loader/cache/MemoryCache.cpp:
      * loader/cache/MemoryCache.h:
      * loader/chromium/CachedRawResourceChromium.cpp:
      * loader/icon/IconController.cpp:
      * loader/icon/IconLoader.h:
      * loader/mac/ResourceLoaderMac.mm:
      * page/DOMWindowExtension.cpp:
      * page/DragController.cpp:
      * page/PerformanceNavigation.cpp:
      * page/PerformanceTiming.cpp:
      * page/PointerLockController.cpp:
      * page/Settings.cpp:
      * page/animation/CSSPropertyAnimation.cpp:
      * platform/chromium/PasteboardChromium.cpp:
      * platform/efl/ErrorsEfl.cpp:
      * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
      * platform/gtk/ErrorsGtk.cpp:
      * platform/gtk/PasteboardGtk.cpp:
      * platform/gtk/PasteboardHelper.h:
      * platform/mac/ClipboardMac.h:
      * platform/mac/ClipboardMac.mm:
      * platform/mac/HTMLConverter.mm:
      * platform/mac/PasteboardMac.mm:
      * platform/network/AuthenticationChallengeBase.cpp:
      * platform/network/cf/CookieJarCFNet.cpp:
      * platform/network/cf/ResourceRequestCFNet.cpp:
      * platform/network/mac/CookieStorageMac.mm:
      * platform/qt/PasteboardQt.cpp:
      * plugins/DOMMimeType.cpp:
      * plugins/PluginView.cpp:
      * rendering/HitTestResult.cpp:
      * rendering/InlineFlowBox.cpp:
      * rendering/RenderBox.cpp:
      * rendering/RenderEmbeddedObject.cpp:
      * rendering/RenderImage.cpp:
      * rendering/RenderImageResourceStyleImage.cpp:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayerBacking.cpp:
      * rendering/RenderLayerFilterInfo.h:
      * rendering/RenderListItem.cpp:
      * rendering/RenderListMarker.cpp:
      * rendering/RenderSnapshottedPlugIn.cpp:
      * rendering/RenderTableCol.cpp:
      * rendering/RenderTableRow.cpp:
      * rendering/RenderTableSection.cpp:
      * rendering/style/StyleCachedShader.h:
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      * svg/SVGImageLoader.cpp:
      * svg/SVGUseElement.cpp:
      * svg/SVGUseElement.h:
      * svg/graphics/SVGImageCache.cpp:
      * testing/MockPagePopupDriver.cpp:
      * xml/XSLStyleSheet.h:
      * xml/XSLTProcessorLibxslt.cpp:
      * xml/parser/XMLDocumentParser.cpp:
      * xml/parser/XMLDocumentParser.h:
      * xml/parser/XMLDocumentParserLibxml2.cpp:
      Many self-evident changes - removing unnecessary header includes, adding smaller
      more local ones that are now necessary.
      
      Source/WebKit/chromium:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * src/ApplicationCacheHost.cpp:
      * src/AssociatedURLLoader.cpp:
      * src/EditorClientImpl.cpp:
      * src/SharedWorkerRepository.cpp:
      * src/WebDataSourceImpl.cpp:
      * src/WebFrameImpl.h:
      * src/WebNode.cpp:
      * src/WebSharedWorkerImpl.cpp:
      * tests/FrameLoaderClientImplTest.cpp:
      
      Source/WebKit/efl:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
      * ewk/ewk_frame.cpp:
      
      Source/WebKit/gtk:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * webkit/webkitwebpolicydecision.cpp:
      
      Source/WebKit/mac:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * DOM/WebDOMOperations.mm:
      * Misc/WebNSPasteboardExtras.mm:
      * WebCoreSupport/WebFrameNetworkingContext.mm:
      * WebView/WebRenderLayer.mm:
      * WebView/WebRenderNode.mm:
      
      Source/WebKit/qt:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * WebCoreSupport/NotificationPresenterClientQt.cpp:
      * WebCoreSupport/QWebPageAdapter.cpp:
      
      Source/WebKit2:
      
      Adding includes that are now necessary because WebCore headers don't have them
      any more.
      
      * NetworkProcess/HostRecord.h:
      * NetworkProcess/NetworkResourceLoadScheduler.h:
      * NetworkProcess/NetworkResourceLoader.h:
      * Shared/WebRenderLayer.cpp:
      * Shared/WebRenderObject.cpp:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      * WebProcess/Plugins/PDF/PDFPlugin.mm:
      * WebProcess/Plugins/PluginView.cpp:
      * WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
      * WebProcess/WebPage/mac/WebPageMac.mm:
      * WebProcess/WebProcess.cpp:
      * WebProcess/soup/WebProcessSoup.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2f13721
  11. 25 Jan, 2013 1 commit
    • mkwst@chromium.org's avatar
      Source/WebCore: ScriptController::executeIfJavaScriptURL incorrectly checks viewsource mode. · aa58886a
      mkwst@chromium.org authored
      incorrectly blocks execution based on the frame's viewsource state.
      https://bugs.webkit.org/show_bug.cgi?id=101683
      
      Reviewed by Adam Barth.
      
      ScriptController::executeIfJavaScriptURL currently checks whether the
      frame in which a 'javascript:' URL might be executed is in viewsource
      mode. This incorrectly handles the case where the viewsource attribute
      is added after a document loads: the _frame_ is in viewsource mode, the
      _document_ is not. The latter should control execution, not the former.
      
      This patch drops the inViewSourceMode check from executeIfJavaScriptURL
      entirely, as the document's viewsource state is checked in
      canExecuteScripts, which is already called when the 'javascript:' URL is
      passed to executeScript. The checks should remain centralized there.
      
      Test: http/tests/security/view-source-javascript-url-in-document.html
      
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::executeIfJavaScriptURL):
          Drop the incorrect check against the Frame's viewsource mode. The
          correct check against the Document's viewsource mode is performed
          in canExecuteScripts (which is called via executeScript).
      
      LayoutTests: Merge isViewSource checks in ScriptController::executeIfJavaScriptURL and ScriptController::canExecuteScripts.
      https://bugs.webkit.org/show_bug.cgi?id=101683
      
      Reviewed by Adam Barth.
      
      * http/tests/security/view-source-javascript-url-in-document-expected.txt: Added.
      * http/tests/security/view-source-javascript-url-in-document.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa58886a
  12. 11 Dec, 2012 1 commit
    • mkwst@chromium.org's avatar
      Web Inspector: ConsoleTypes should not expose MessageType - it should be private to inspector. · 236e8984
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66371
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      We can simplify console message generation a bit, as nothing outside the
      Console object itself will generate messages of any type other than
      LogMessageType. This patch refactors the externally-facing API endpoints
      on ScriptExecutionContext and Console to drop the MessageType parameter,
      moves the MessageType enum into a new InspectorConsoleTypes.h header,
      and updates all the call sites (and ChromeClients) to drop the parameter
      from their interfaces.
      
      As a temporary bandage for ports using this interface, this patch
      includes aliases for the new methods that retain the old interface.
      I'll remove them in a future patch.
      
      Here, we only refactor an internal interface. No tests should break.
      
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
          We added a new file! OMG!
      * Modules/webaudio/AudioBufferSourceNode.cpp:
      (WebCore::AudioBufferSourceNode::looping):
      (WebCore::AudioBufferSourceNode::setLooping):
      * Modules/webdatabase/AbstractDatabase.cpp:
      (WebCore::AbstractDatabase::logErrorMessage):
      * Modules/websockets/WebSocket.cpp:
      (WebCore::WebSocket::connect):
      (WebCore::WebSocket::send):
      (WebCore::WebSocket::close):
      (WebCore::WebSocket::setBinaryType):
      * Modules/websockets/WebSocketChannel.cpp:
      (WebCore::WebSocketChannel::fail):
      (WebCore::WebSocketChannel::didFailSocketStream):
      * bindings/js/JSCustomXPathNSResolver.cpp:
      (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
      * bindings/v8/custom/V8CustomXPathNSResolver.cpp:
      (WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):
      * css/MediaList.cpp:
      (WebCore::addResolutionWarningMessageToConsole):
      * dom/Document.cpp:
      (WebCore::Document::logExceptionToConsole):
      (WebCore::Document::processHttpEquiv):
      (WebCore::Document::addMessage):
      * dom/Document.h:
      (Document):
      * dom/ScriptElement.cpp:
      (WebCore::ScriptElement::notifyFinished):
      * dom/ScriptExecutionContext.cpp:
      (WebCore::ScriptExecutionContext::AddConsoleMessageTask::performTask):
      (WebCore::ScriptExecutionContext::addConsoleMessage):
      * dom/ScriptExecutionContext.h:
      (ScriptExecutionContext):
      (WebCore::ScriptExecutionContext::AddConsoleMessageTask::create):
      (WebCore::ScriptExecutionContext::AddConsoleMessageTask::AddConsoleMessageTask):
      * dom/ViewportArguments.cpp:
      (WebCore::reportViewportWarning):
      * fileapi/WebKitBlobBuilder.cpp:
      (WebCore::BlobBuilder::append):
      * html/HTMLFormControlElement.cpp:
      (WebCore::shouldAutofocus):
      * html/HTMLFormElement.cpp:
      (WebCore::HTMLFormElement::validateInteractively):
      * html/HTMLIFrameElement.cpp:
      (WebCore::HTMLIFrameElement::parseAttribute):
      * html/HTMLTrackElement.cpp:
      (WebCore::HTMLTrackElement::canLoadUrl):
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::getImageData):
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore):
      (WebCore::WebGLRenderingContext::printWarningToConsole):
      * html/parser/XSSAuditor.cpp:
      (WebCore::XSSAuditor::init):
      (WebCore::XSSAuditor::filterToken):
      * inspector/ConsoleAPITypes.h: Added.
      (WebCore):
      * inspector/ConsoleMessage.h:
      * inspector/InspectorConsoleAgent.h:
      * inspector/InspectorDebuggerAgent.h:
      * inspector/InspectorInstrumentation.cpp:
      (WebCore):
      * inspector/InspectorInstrumentation.h:
      * inspector/InspectorProfilerAgent.cpp:
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::addMessageToConsole):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::reportLocalLoadFailed):
      (WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
      * loader/ImageLoader.cpp:
      (WebCore::ImageLoader::notifyFinished):
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::didReceiveResponse):
      * loader/MixedContentChecker.cpp:
      (WebCore::MixedContentChecker::logWarning):
      * loader/TextTrackLoader.cpp:
      (WebCore::TextTrackLoader::corsPolicyPreventedLoad):
      * loader/appcache/ApplicationCacheGroup.cpp:
      (WebCore::ApplicationCacheGroup::abort):
      (WebCore::ApplicationCacheGroup::didReceiveResponse):
      (WebCore::ApplicationCacheGroup::didFinishLoading):
      (WebCore::ApplicationCacheGroup::didFail):
      (WebCore::ApplicationCacheGroup::didReceiveManifestResponse):
      (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
      (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::printAccessDeniedMessage):
      * page/ChromeClient.h:
      (ChromeClient):
          Drop LogMessageType from everywhere.
      * page/Console.cpp:
      (WebCore::Console::addMessage):
      (WebCore::internalAddMessage):
      (WebCore::Console::error):
      (WebCore::Console::log):
      (WebCore::Console::warn):
      (WebCore::Console::dir):
      (WebCore::Console::dirxml):
      (WebCore::Console::clear):
      (WebCore::Console::trace):
      (WebCore::Console::assertCondition):
      * page/Console.h:
      (Console):
          Create a new internalAddMessage that's used for the various
          Console message types. Everything else routes through
          ::addMessage.
      * page/ConsoleTypes.h:
          Drop MessageTypes from this file, add it to ConsoleAPIType.h
      * page/ContentSecurityPolicy.cpp:
      (WebCore::ContentSecurityPolicy::logToConsole):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::dispatchMessageEventWithOriginCheck):
      (WebCore::DOMWindow::printErrorMessage):
      * page/EventSource.cpp:
      (WebCore::EventSource::didReceiveResponse):
      * svg/SVGDocumentExtensions.cpp:
      (WebCore::reportMessage):
      * workers/DefaultSharedWorkerRepository.cpp:
      (SharedWorkerProxy):
      (WebCore::postConsoleMessageTask):
      (WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
      * workers/SharedWorkerContext.cpp:
      (WebCore::SharedWorkerContext::logExceptionToConsole):
      * workers/WorkerContext.cpp:
      (WebCore::WorkerContext::addMessage):
      (WebCore::WorkerContext::addMessageToWorkerConsole):
      * workers/WorkerContext.h:
      (WorkerContext):
      * workers/WorkerMessagingProxy.cpp:
      (WebCore::postConsoleMessageTask):
      (WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
      * workers/WorkerMessagingProxy.h:
      (WorkerMessagingProxy):
      * workers/WorkerReportingProxy.h:
      (WorkerReportingProxy):
      * xml/XMLHttpRequest.cpp:
      (WebCore::logConsoleError):
      (WebCore::XMLHttpRequest::send):
      * xml/XSLTProcessorLibxslt.cpp:
      (WebCore::XSLTProcessor::parseErrorFunc):
      * xml/XSLTProcessorQt.cpp:
      (WebCore::XSLTMessageHandler::handleMessage):
          Drop LogMessageType from everywhere.
      
      Source/WebKit/blackberry:
      
      Drops WebCore::MessageType from the addMessageToConsole method.
      
      * WebCoreSupport/ChromeClientBlackBerry.cpp:
      (WebCore::ChromeClientBlackBerry::addMessageToConsole):
      * WebCoreSupport/ChromeClientBlackBerry.h:
      (ChromeClientBlackBerry):
      
      Source/WebKit/chromium:
      
      Drops WebCore::MessageType from the addMessageToConsole method, and all
      the ancilliary places it touches.
      
      Aliases postConsoleMessageToWorkerObject with the old interface in
      order to maintain back-compat. Will remove it in a future patch once
      Chromium is updated.
      
      * public/WebSharedWorkerClient.h:
      (WebSharedWorkerClient):
      (WebKit::WebSharedWorkerClient::postConsoleMessageToWorkerObject):
      * src/ChromeClientImpl.cpp:
      * src/ChromeClientImpl.h:
      (ChromeClientImpl):
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::addMessageToConsole):
      * src/WebPagePopupImpl.cpp:
      * src/WebSharedWorkerImpl.cpp:
      (WebKit::WebSharedWorkerImpl::postConsoleMessageToWorkerObject):
      (WebKit::WebSharedWorkerImpl::postConsoleMessageTask):
      * src/WebSharedWorkerImpl.h:
      (WebSharedWorkerImpl):
      * src/WebWorkerClientImpl.cpp:
      (WebKit::WebWorkerClientImpl::postConsoleMessageToWorkerObject):
      * src/WebWorkerClientImpl.h:
      (WebWorkerClientImpl):
      
      Source/WebKit/efl:
      
      Drops WebCore::MessageType from the addMessageToConsole method.
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::addMessageToConsole):
      * WebCoreSupport/ChromeClientEfl.h:
      (ChromeClientEfl):
      
      Source/WebKit/gtk:
      
      Drops WebCore::MessageType from the addMessageToConsole method.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::addMessageToConsole):
      * WebCoreSupport/ChromeClientGtk.h:
      (ChromeClient):
      
      Source/WebKit/mac:
      
      Drops WebCore::MessageType from the addMessageToConsole method.
      
      * WebCoreSupport/WebChromeClient.h:
      (WebChromeClient):
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::addMessageToConsole):
      
      Source/WebKit/qt:
      
      Drops WebCore::MessageType from the addMessageToConsole method.
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::addMessageToConsole):
      * WebCoreSupport/ChromeClientQt.h:
      (ChromeClientQt):
      
      Source/WebKit/win:
      
      Drops WebCore::MessageType from the addMessageToConsole method.
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::addMessageToConsole):
      * WebCoreSupport/WebChromeClient.h:
      (WebChromeClient):
      
      Source/WebKit/wince:
      
      Drops WebCore::MessageType from the addMessageToConsole method.
      
      * WebCoreSupport/ChromeClientWinCE.cpp:
      (WebKit::ChromeClientWinCE::addMessageToConsole):
      * WebCoreSupport/ChromeClientWinCE.h:
      (ChromeClientWinCE):
      
      Source/WebKit2:
      
      Drops WebCore::MessageLevel from the addMessageToConsole method.
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::addMessageToConsole):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      (WebChromeClient):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      236e8984
  13. 10 Dec, 2012 1 commit
    • mkwst@chromium.org's avatar
      Log to console when script is blocked by sandbox attributes. · 498242cb
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104365
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Adds a console message to cover script execution blocked within the
      context of a sandboxed frame which lacks the 'allow-scripts' permission.
      
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::canExecuteScripts):
          Log a warning when sandboxing flags block script execution.
      
      Tools:
      
      * Scripts/webkitpy/performance_tests/perftest.py:
      (PerfTest):
          Ignoring the new console message in perftests, as it broke parsing
          for the Parser/html-parser.html microbenchmark.
      
      LayoutTests:
      
      * fast/frames/sandboxed-iframe-attribute-parsing-expected.txt:
      * fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
      * fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
      * fast/frames/sandboxed-iframe-scripting-expected.txt:
      * http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
      * http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
      * http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
      * http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
      * http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
      * http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
      * http/tests/security/sandbox-inherit-to-initial-document-2-expected.txt:
      * media/video-controls-no-scripting-expected.txt:
          Rebaselining tests with new expectations.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137180 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      498242cb
  14. 09 Dec, 2012 2 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r137053. · 32e3eb15
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/137053
      https://bugs.webkit.org/show_bug.cgi?id=104471
      
      Broke PerformanceTests/Parser/html-parser.html (Requested by
      mkwst_ on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-09
      
      Source/WebCore:
      
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::canExecuteScripts):
      
      LayoutTests:
      
      * fast/frames/sandboxed-iframe-attribute-parsing-expected.txt:
      * fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
      * fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
      * fast/frames/sandboxed-iframe-scripting-expected.txt:
      * http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
      * http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
      * http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
      * http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
      * http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
      * http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
      * http/tests/security/sandbox-inherit-to-initial-document-2-expected.txt:
      * media/video-controls-no-scripting-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32e3eb15
    • mkwst@chromium.org's avatar
      Log to console when script is blocked by sandbox attributes. · 47f1c6e1
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104365
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Adds a console message to cover script execution blocked within the
      context of a sandboxed frame which lacks the 'allow-scripts' permission.
      
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::canExecuteScripts):
          Log a warning when sandboxing flags block script execution.
      
      LayoutTests:
      
      * fast/frames/sandboxed-iframe-attribute-parsing-expected.txt:
      * fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
      * fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
      * fast/frames/sandboxed-iframe-scripting-expected.txt:
      * http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
      * http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
      * http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
      * http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
      * http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
      * http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
      * http/tests/security/sandbox-inherit-to-initial-document-2-expected.txt:
      * media/video-controls-no-scripting-expected.txt:
          Rebaselining tests with new expectations.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47f1c6e1
  15. 22 Oct, 2012 1 commit
    • kling@webkit.org's avatar
      Remove Page::javaScriptURLsAreAllowed setting. · 7d22c9e5
      kling@webkit.org authored
      <http://webkit.org/b/99944>
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore:
      
      This setting was exposed through internal WebView API in Apple's WebKit1.
      There are no longer any clients of that API.
      
      This is a step towards preventing elements from modifying their own attributes
      below attributeChanged().
      
      * WebCore.exp.in:
      * WebCore.order:
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::executeIfJavaScriptURL):
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::parseAttribute):
      * page/Page.cpp:
      (WebCore::Page::Page):
      * page/Page.h:
      (Page):
      
      Source/WebKit/mac:
      
      * WebKit.order:
      * WebView/WebView.mm:
      * WebView/WebViewPrivate.h:
      
      Source/WebKit/win:
      
      Have WebView::setJavaScriptURLsAreAllowed() do nothing and return E_NOTIMPL
      to prevent COM ABI breakage.
      
      * WebView.cpp:
      (WebView::setJavaScriptURLsAreAllowed):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d22c9e5
  16. 25 May, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Inline script and style blocked by Content Security Policy should provide more... · fae2ea21
      commit-queue@webkit.org authored
      Inline script and style blocked by Content Security Policy should provide more detailed console errors.
      https://bugs.webkit.org/show_bug.cgi?id=86848
      
      Patch by Mike West <mkwst@chromium.org> on 2012-05-25
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      This change adds a URL and line number for context to each call to
      `ContentSecurityPolicy::allowInline*`, and pipes it through to the
      console message generation in `CSPDirectiveList::reportViolation`.
      
      Line numbers are not added for injected scripts (`document.write(...)`,
      `document.body.appendChild`, and etc.).
      
      Tests: http/tests/security/contentSecurityPolicy/injected-inline-script-allowed.html
             http/tests/security/contentSecurityPolicy/injected-inline-script-blocked.html
             http/tests/security/contentSecurityPolicy/injected-inline-style-allowed.html
             http/tests/security/contentSecurityPolicy/injected-inline-style-blocked.html
      
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::executeIfJavaScriptURL):
      * bindings/js/JSLazyEventListener.cpp:
      (WebCore::JSLazyEventListener::initializeJSFunction):
      * bindings/v8/V8LazyEventListener.cpp:
      (WebCore::V8LazyEventListener::prepareListenerObject):
      * dom/ScriptElement.cpp:
      (WebCore::ScriptElement::ScriptElement):
      (WebCore::ScriptElement::executeScript):
      * dom/ScriptElement.h:
      (ScriptElement):
      * dom/StyleElement.cpp:
      (WebCore::StyleElement::StyleElement):
      (WebCore::StyleElement::createSheet):
      * dom/StyleElement.h:
      (StyleElement):
      * dom/StyledElement.cpp:
      (WebCore::StyledElement::StyledElement):
      (WebCore):
      (WebCore::StyledElement::style):
      (WebCore::StyledElement::styleAttributeChanged):
      * dom/StyledElement.h:
      (StyledElement):
      * page/ContentSecurityPolicy.cpp:
      (CSPDirectiveList):
      (WebCore::CSPDirectiveList::reportViolation):
      (WebCore::CSPDirectiveList::checkInlineAndReportViolation):
      (WebCore::CSPDirectiveList::checkEvalAndReportViolation):
      (WebCore::CSPDirectiveList::allowJavaScriptURLs):
      (WebCore::CSPDirectiveList::allowInlineEventHandlers):
      (WebCore::CSPDirectiveList::allowInlineScript):
      (WebCore::CSPDirectiveList::allowInlineStyle):
      (WebCore::CSPDirectiveList::allowEval):
      (WebCore):
      (WebCore::isAllowedByAllWithCallStack):
      (WebCore::isAllowedByAllWithContext):
      (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
      (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
      (WebCore::ContentSecurityPolicy::allowInlineScript):
      (WebCore::ContentSecurityPolicy::allowInlineStyle):
      * page/ContentSecurityPolicy.h:
      (WTF):
      
      LayoutTests:
      
      * http/tests/security/contentSecurityPolicy/combine-multiple-policies-expected.txt:
      * http/tests/security/contentSecurityPolicy/default-src-inline-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/injected-inline-script-allowed-expected.txt: Added.
      * http/tests/security/contentSecurityPolicy/injected-inline-script-allowed.html: Added.
      * http/tests/security/contentSecurityPolicy/injected-inline-script-blocked-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt.
      * http/tests/security/contentSecurityPolicy/injected-inline-script-blocked.html: Added.
      * http/tests/security/contentSecurityPolicy/injected-inline-style-allowed-expected.txt: Added.
      * http/tests/security/contentSecurityPolicy/injected-inline-style-allowed.html: Added.
      * http/tests/security/contentSecurityPolicy/injected-inline-style-blocked-expected.txt: Added.
      * http/tests/security/contentSecurityPolicy/injected-inline-style-blocked.html: Added.
      * http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
      * http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
      * http/tests/security/contentSecurityPolicy/inline-style-attribute-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/inline-style-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-only-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
      * http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
      * http/tests/security/contentSecurityPolicy/resources/inject-script.js: Added.
      * http/tests/security/contentSecurityPolicy/resources/inject-style.js: Added.
      * http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt:
      * http/tests/security/contentSecurityPolicy/srcdoc-doesnt-bypass-script-src-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fae2ea21
  17. 26 Jan, 2012 1 commit
    • jamesr@google.com's avatar
      We shouldn't synchronously update styles on all documents after running script · 2b55f694
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=46761
      
      Reviewed by Simon Fraser.
      
      Currently we call Document::updateStyleForAllDocuments() after invoking any event or timeout handler. This is
      slow since it iterates over the entire document tree and defeats our recalcStyle timer batching. It is
      unnecessary as any code that depends on styles or the render tree being up to date must call
      updateStyleIfNeeded() on the document it is accessing.
      
      The first reference I can find to this code is in r798 in the file WebCore/khtml/xml/domnode_impl.cpp. It's been
      cargo culted forward ever since.
      
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::executeScript):
      * bindings/js/ScheduledAction.cpp:
      (WebCore::ScheduledAction::execute):
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::ScriptController):
      (WebCore::ScriptController::executeScriptInWorld):
      * bindings/js/ScriptController.h:
      * bindings/v8/ScheduledAction.cpp:
      (WebCore::ScheduledAction::execute):
      * bindings/v8/ScriptController.cpp:
      (WebCore::ScriptController::ScriptController):
      * bindings/v8/ScriptController.h:
      * dom/ScriptElement.cpp:
      (WebCore::ScriptElement::executeScript):
      * inspector/InspectorClient.cpp:
      (WebCore::InspectorClient::doDispatchMessageOnFrontendPage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b55f694
  18. 05 Nov, 2011 1 commit
    • abarth@webkit.org's avatar
      JavaScript URLs execute in sandboxed iframes · 29f0c1ad
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71599
      
      Reviewed by Eric Seidel.
      
      Source/WebCore: 
      
      This patch fixes the intentional regression I introduced earlier today
      by moving the sandbox bits from SecurityOrigin to Document. In the
      process, I renamed SecurityOrigin::createEmpty to
      SecurityOrigin::createUnique to better align with HTML5 terminology.
      
      * WebCore.exp.in:
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::canExecuteScripts):
      * dom/Document.cpp:
      (WebCore::Document::setIsViewSource):
      (WebCore::Document::initSecurityContext):
      * dom/ScriptExecutionContext.cpp:
      (WebCore::ScriptExecutionContext::ScriptExecutionContext):
      * dom/ScriptExecutionContext.h:
      (WebCore::ScriptExecutionContext::sandboxFlags):
      (WebCore::ScriptExecutionContext::enforceSandboxFlags):
      (WebCore::ScriptExecutionContext::isSandboxed):
      * html/HTMLAppletElement.cpp:
      (WebCore::HTMLAppletElement::canEmbedJava):
      * loader/DocumentWriter.cpp:
      (WebCore::DocumentWriter::begin):
      * loader/FrameLoader.cpp:
      (WebCore::isDocumentSandboxed):
      (WebCore::FrameLoader::addHTTPOriginIfNeeded):
      * loader/PolicyChecker.cpp:
      (WebCore::PolicyChecker::checkNewWindowPolicy):
      * loader/SubframeLoader.cpp:
      (WebCore::SubframeLoader::requestPlugin):
      * page/SecurityOrigin.cpp:
      (WebCore::SecurityOrigin::SecurityOrigin):
      (WebCore::SecurityOrigin::create):
      (WebCore::SecurityOrigin::createUnique):
      * page/SecurityOrigin.h:
      
      LayoutTests: 
      
      Update results to show progression.
      
      * fast/frames/sandboxed-iframe-scripting-expected.txt:
      * fast/frames/sandboxed-iframe-scripting.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29f0c1ad
  19. 04 Nov, 2011 1 commit
    • abarth@webkit.org's avatar
      Delete FrameLoader::isSandboxed · c9bb4877
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71591
      
      Reviewed by Eric Seidel.
      
      Source/WebCore: 
      
      We should always use document->securityOrigin()->isSandboxed because
      that picks up the sandbox bits that are frozen on the document rather
      than the ones that could change on the Frame.
      
      This patch starts preparing us to implement the CSP sandbox directive,
      which will cause use to have document sandbox bits without any attribute.
      
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::canExecuteScripts):
          - This call site was the only functional site left where these two
            could be different. This patch causes one progression and one
            regression. The progression is that we now correctly freeze the
            allow-scripts bit when a document is created, but the regression
            is we now allow the execution of JavaScript URLs, as noted in 
            fast/frames/sandboxed-iframe-scripting.html. That's even more of
            an edge case, so I think it's a win overall.
      * loader/DocumentWriter.cpp:
      (WebCore::DocumentWriter::begin):
          - I don't think this part of the change is testable. There's no
            time to execute script between when the bits get copied off the
            Frame and when they're checked, so there's no time to change them.
      * loader/FrameLoader.cpp:
          - Update FIXME comment that is now fixed.
      * loader/FrameLoader.h:
          - Remove wrong API.
      
      LayoutTests: 
      
      This patch updates this test to check a few more cases and notes a bug
      in our current implementation.
      
      * fast/frames/resources/sandboxed-iframe-script-dynamic.html:
      * fast/frames/sandboxed-iframe-scripting-expected.txt:
      * fast/frames/sandboxed-iframe-scripting.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9bb4877
  20. 28 Oct, 2011 1 commit
    • jochen@chromium.org's avatar
      Rename a number of methods mentioning JavaScript to just Script instead · 849e8da9
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71105
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      * WebCore.exp.in:
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::canExecuteScripts):
      * bindings/v8/V8Proxy.cpp:
      (WebCore::V8Proxy::handleOutOfMemory):
      * loader/FrameLoaderClient.h:
      (WebCore::FrameLoaderClient::allowScript):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::canRequest):
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      (WebCore::Settings::setScriptEnabled):
      * page/Settings.h:
      (WebCore::Settings::isScriptEnabled):
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImage::dataChanged):
      
      Source/WebKit/chromium:
      
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::allowScript):
      * src/FrameLoaderClientImpl.h:
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::collectGarbage):
      * src/WebSettingsImpl.cpp:
      (WebKit::WebSettingsImpl::setJavaScriptEnabled):
      
      Source/WebKit/efl:
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::dispatchDidClearWindowObjectInWorld):
      * ewk/ewk_view.cpp:
      (_ewk_view_priv_new):
      (ewk_view_setting_enable_scripts_set):
      
      Source/WebKit/gtk:
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::dispatchDidClearWindowObjectInWorld):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_update_settings):
      (webkit_web_view_settings_notify):
      
      Source/WebKit/mac:
      
      * WebView/WebView.mm:
      (-[WebView _preferencesChanged:]):
      
      Source/WebKit/qt:
      
      * Api/qwebsettings.cpp:
      (QWebSettingsPrivate::apply):
      
      Source/WebKit/win:
      
      * WebFrame.cpp:
      (WebFrame::dispatchDidClearWindowObjectInWorld):
      * WebView.cpp:
      (WebView::notifyPreferencesChanged):
      
      Source/WebKit/wince:
      
      * WebView.cpp:
      (WebView::WebView):
      
      Source/WebKit/wx:
      
      * WebSettings.cpp:
      (wxWebSettings::SetJavaScriptEnabled):
      (wxWebSettings::IsJavaScriptEnabled):
      * WebView.cpp:
      (wxWebView::Create):
      
      Source/WebKit2:
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::updatePreferences):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@98730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      849e8da9
  21. 12 Oct, 2011 1 commit
  22. 11 Oct, 2011 1 commit
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r97087. · 63dab8b4
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/97087
      https://bugs.webkit.org/show_bug.cgi?id=69805
      
      failing assert on debug builds (Requested by simonjam on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-10
      
      Source/WebCore:
      
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::executeIfJavaScriptURL):
      * loader/DocumentWriter.cpp:
      (WebCore::DocumentWriter::replaceDocument):
      (WebCore::DocumentWriter::begin):
      * loader/DocumentWriter.h:
      
      Source/WebKit/chromium:
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::loadJavaScriptURL):
      
      LayoutTests:
      
      * http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url-expected.txt: Removed.
      * http/tests/security/xss-DENIED-synchronous-frame-load-in-javascript-url.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@97110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63dab8b4
  23. 10 Oct, 2011 1 commit
  24. 08 Sep, 2011 1 commit
  25. 16 Jun, 2011 1 commit
    • abarth@webkit.org's avatar
      2011-06-15 Adam Barth <abarth@webkit.org> · f913d402
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Remove forceUserGesture bool in favor of UserGestureIndicator
              https://bugs.webkit.org/show_bug.cgi?id=62702
      
              This patch is an intermediate step towards removing the
              forceUserGesture bool.  In this patch, we use the user gesture
              indicator to store the gesture state instead of encoding it in the URL
              of the script source code.  In a future patch, we'll push the indicator
              higher up the stack, closer to the reason for setting it.
      
              * bindings/ScriptControllerBase.cpp:
              (WebCore::ScriptController::executeScript):
              (WebCore::ScriptController::executeIfJavaScriptURL):
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::executeScriptInWorld):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f913d402
  26. 13 Jun, 2011 1 commit
    • abarth@webkit.org's avatar
      2011-06-13 Adam Barth <abarth@webkit.org> · 71a4b6d5
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              anyPageIsProcessingUserGesture is not longer needed because user gesture state is static
              https://bugs.webkit.org/show_bug.cgi?id=62601
      
              Previously, our user-gesture state was per-frame.  Code needed to check
              the "global" user gesture state called anyPageIsProcessingUserGesture()
              to iterate through all the frames and look for one that was processing
              a user gesture.  Since we changed the user gesture state to be static,
              iterating over every frame in existence isn't needed.
      
              This patch also cleans up a couple other user-gesture callsites I saw
              while I was in this code.  Code should just call
              ScriptController::processingUserGesture directly instead of
              trampolining through other functions.
      
              * bindings/ScriptControllerBase.cpp:
              (WebCore::ScriptController::executeScript):
              * bindings/generic/BindingSecurity.h:
              (WebCore::::allowPopUp):
              * bindings/js/JSDOMBinding.cpp:
              * bindings/js/JSDOMBinding.h:
              * bindings/js/JSDocumentCustom.cpp:
              (WebCore::JSDocument::setLocation):
              * bindings/js/ScriptController.cpp:
              * bindings/js/ScriptController.h:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/ScriptController.cpp:
              * bindings/v8/ScriptController.h:
              (WebCore::ScriptController::setProcessingTimerCallback):
              * bindings/v8/V8Utilities.cpp:
              * bindings/v8/V8Utilities.h:
              * bindings/v8/specialization/V8BindingState.cpp:
              * bindings/v8/specialization/V8BindingState.h:
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::submitFromJavaScript):
              (WebCore::HTMLFormElement::submit):
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::setLocation):
              (WebCore::DOMWindow::createWindow):
              (WebCore::DOMWindow::open):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88731 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71a4b6d5
  27. 02 Jun, 2011 1 commit
    • beidson@apple.com's avatar
      <rdar://problem/9539920> and https://bugs.webkit.org/show_bug.cgi?id=61950 · 17328e0d
      beidson@apple.com authored
      Repro crash loading certain webarchives after r87566.
      
      Reviewed by Oliver Hunt.
      
      Source/WebCore: 
      
      Test: webarchive/loading/javascript-url-iframe-crash.html
      
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::executeIfJavaScriptURL): DocumentWriter::replaceDocument can
        cause the DocumentLoader to be destroyed, so protect it with a Ref here.
      
      LayoutTests: 
      
      * webarchive/loading/javascript-url-iframe-crash-expected.txt: Added.
      * webarchive/loading/javascript-url-iframe-crash.html: Added.
      * webarchive/loading/resources/javascript-url-iframe-crash.webarchive: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17328e0d
  28. 31 May, 2011 1 commit
    • beidson@apple.com's avatar
      Another swipe at resolving <rdar://problem/9125145> and... · 197fbd30
      beidson@apple.com authored
      Another swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494
              
      Reviewed by Darin Adler.
      
      Re-land http://trac.webkit.org/changeset/87566 with invalid ASSERTs removed.
      
      No new tests. No change in behavior.
      
      Instead of storing the DocumentLoader at construction and never changing it,
      always calculate it based on the FrameLoader's current DocumentLoader:
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::suggestedMIMEType):
      (WebCore::Document::lastModified):
      (WebCore::Document::initSecurityContext):
      (WebCore::Document::updateURLForPushOrReplaceState):
      (WebCore::Document::loader):
      * dom/Document.h:
      
      Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::executeIfJavaScriptURL):
      * html/MediaDocument.cpp:
      (WebCore::MediaDocument::replaceMediaElementTimerFired):
      * html/PluginDocument.cpp:
      (WebCore::PluginDocumentParser::createDocumentStructure):
      * platform/mac/HTMLConverter.mm:
      (fileWrapperForElement):
      
      * WebCore.exp.in:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      197fbd30
  29. 29 May, 2011 1 commit
    • commit-queue@webkit.org's avatar
      2011-05-29 Sheriff Bot <webkit.review.bot@gmail.com> · 3ff33222
      commit-queue@webkit.org authored
              Unreviewed, rolling out r87566.
              http://trac.webkit.org/changeset/87566
              https://bugs.webkit.org/show_bug.cgi?id=61702
      
              It made all tests assert on Qt in debug mode (Requested by
              Ossy_weekend on #webkit).
      
              * WebCore.exp.in:
              * bindings/ScriptControllerBase.cpp:
              (WebCore::ScriptController::executeIfJavaScriptURL):
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::suggestedMIMEType):
              (WebCore::Document::lastModified):
              (WebCore::Document::initSecurityContext):
              (WebCore::Document::updateURLForPushOrReplaceState):
              * dom/Document.h:
              (WebCore::Document::setDocumentLoader):
              (WebCore::Document::loader):
              * html/MediaDocument.cpp:
              (WebCore::MediaDocument::replaceMediaElementTimerFired):
              * html/PluginDocument.cpp:
              (WebCore::PluginDocumentParser::createDocumentStructure):
              * platform/mac/HTMLConverter.mm:
              (fileWrapperForElement):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ff33222
  30. 27 May, 2011 1 commit
    • beidson@apple.com's avatar
      First swipe at resolving <rdar://problem/9125145> and https://bugs.webkit.org/show_bug.cgi?id=61494 · fdf7571f
      beidson@apple.com authored
              
      Reviewed by Darin Adler.
      
      Make the Document be intelligent about returning its DocumentLoader, including the possibility that
      the DocumentLoader will be null.
      
      No new tests. No change in behavior.
      
      Instead of storing the DocumentLoader at construction and never changing it,
      always calculate it based on the FrameLoader's current DocumentLoader:
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::suggestedMIMEType):
      (WebCore::Document::lastModified):
      (WebCore::Document::initSecurityContext):
      (WebCore::Document::updateURLForPushOrReplaceState):
      (WebCore::Document::loader):
      * dom/Document.h:
      
      Null-check or ASSERT that the DocumentLoader exists (or both) depending on the scenario:
      * bindings/ScriptControllerBase.cpp:
      (WebCore::ScriptController::executeIfJavaScriptURL):
      * html/MediaDocument.cpp:
      (WebCore::MediaDocument::replaceMediaElementTimerFired):
      * html/PluginDocument.cpp:
      (WebCore::PluginDocumentParser::createDocumentStructure):
      * platform/mac/HTMLConverter.mm:
      (fileWrapperForElement):
      
      * WebCore.exp.in:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdf7571f
  31. 25 May, 2011 1 commit
    • japhet@chromium.org's avatar
      2011-05-25 Nate Chapin <japhet@chromium.org> · 0d6b1dea
      japhet@chromium.org authored
              Reviewed by Adam Barth.
      
              Put view-source documents in a unique origin and always allow them to run scripts. This ensures tools like
              XMLViewer work even when scripts are disabled, while still providing the protections expected when scripts are disabled.
              https://bugs.webkit.org/show_bug.cgi?id=59113
      
              * bindings/ScriptControllerBase.cpp:
              (WebCore::ScriptController::canExecuteScripts): Check whether the document is viewing source, and allow scripts in that case.
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::matchUARules):
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::setIsViewSource): Renamed from setUsesViewSourceStyles(), set's a unique security origin if we are viewing source.
              * dom/Document.h:
              (WebCore::Document::isViewSource): Renamed from usesViewSourceStyles().
              * html/HTMLViewSourceDocument.cpp:
              (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::receivedFirstData):
              * xml/XMLTreeViewer.cpp:
              (WebCore::XMLTreeViewer::transformDocumentToTreeView):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87309 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d6b1dea
  32. 27 Apr, 2011 1 commit
    • mihaip@chromium.org's avatar
      2011-04-27 Mihai Parparita <mihaip@chromium.org> · 3c16b0c1
      mihaip@chromium.org authored
              Reviewed by Eric Seidel.
      
              Frame.h shouldn't include Document.h
              https://bugs.webkit.org/show_bug.cgi?id=59560
      
              Frame can use a forward-declared Document if we move
              Frame::displayStringModifiedByEncoding's implementation out of the
              header.
                                      Size  #includes  Size * #includes
              Before: page/Frame.h:   0.746       653           487.138
                      dom/Document.h: 0.220      1306           287.320
      
              After:  page/Frame.h:   0.646       653           421.838
                      dom/Document.h: 0.220      1189           261.580
      
              * WebCore.exp.in:
              * bindings/ScriptControllerBase.cpp:
              * bindings/generic/BindingSecurityBase.cpp:
              * bindings/v8/V8Proxy.cpp:
              * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
              * dom/CharacterData.cpp:
              * dom/UserTypingGestureIndicator.cpp:
              * editing/chromium/SelectionControllerChromium.cpp:
              * inspector/InspectorDOMStorageResource.cpp:
              * inspector/InspectorInstrumentation.h:
              * loader/PingLoader.cpp:
              * loader/SubresourceLoader.cpp:
              * loader/appcache/DOMApplicationCache.cpp:
              * loader/cache/CachedResourceRequest.cpp:
              * page/Frame.cpp:
              (WebCore::Frame::displayStringModifiedByEncoding):
              * page/Frame.h:
              * page/Geolocation.cpp:
              * page/Location.cpp:
              * page/Navigator.cpp:
              * page/PageGroupLoadDeferrer.cpp:
              * page/PerformanceTiming.cpp:
              * xml/XSLTProcessorLibxslt.cpp:
      2011-04-27  Mihai Parparita  <mihaip@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Frame.h shouldn't include Document.h
              https://bugs.webkit.org/show_bug.cgi?id=59560
      
              Add Document.h #includes for files that were relying on transitive
              #includes via Frame.h.
      
              * src/LocalFileSystemChromium.cpp:
              * src/StorageEventDispatcherImpl.cpp:
              * src/WebFrameImpl.h:
              * src/WebWorkerBase.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c16b0c1
  33. 26 Mar, 2011 1 commit
    • abarth@webkit.org's avatar
      2011-03-26 Adam Barth <abarth@webkit.org> · f921dee2
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Teach Content Security Policy how to parse source-list
              https://bugs.webkit.org/show_bug.cgi?id=54799
      
              Test a variety of source-list parsing cases.  There's a bunch more
              cases we could be testing.  We'll add more over time.
      
              * http/tests/security/contentSecurityPolicy/source-list-parsing-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/source-list-parsing.html: Added.
      2011-03-26  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Teach Content Security Policy how to parse source-list
              https://bugs.webkit.org/show_bug.cgi?id=54799
      
              This patch is larger than I would like, but I wasn't sure how to make
              it any smaller while still being reasonably testable.  I've left out
              some features (such as host wildcarding and 'self') so I can add them
              in later patches with tests.
      
              Test: http/tests/security/contentSecurityPolicy/source-list-parsing.html
      
              * bindings/ScriptControllerBase.cpp:
              * dom/ScriptElement.cpp:
              * html/parser/HTMLDocumentParser.cpp:
              * loader/FrameLoader.cpp:
                  - Add include explicitly now that we're not spamming the include
                    everywhere.
              * dom/Document.cpp:
              (WebCore::Document::initSecurityContext):
                  - We need to pass the SecurityOrigin object to
                    ContentSecurityPolicy so that it can resolve implicit parts of
                    source patterns, such as the scheme.
              * dom/Document.h:
                  - Forward declare ContentSecurityPolicy rather than including the
                    header.  Technically this could be a separate change, but I was
                    getting annoyed at the world re-builds.
              * page/ContentSecurityPolicy.cpp:
              (WebCore::skipExactly):
              (WebCore::skipUtil):
              (WebCore::skipWhile):
                  - Clean up these parser helper functions.  We might consider moving
                    them to a more general location.  They're very helpful for
                    writing secure HTTP header parsers.
              (WebCore::CSPSource::CSPSource):
                  - New class to represent one source in a source-list.
              (WebCore::CSPSource::matches):
              (WebCore::CSPSource::schemeMatches):
              (WebCore::CSPSource::hostMatches):
              (WebCore::CSPSource::portMatches):
              (WebCore::CSPSource::isSchemeOnly):
                  - Currently we represent scheme-only sources using with an empty
                    m_host.  Another approach I considered was using another bool,
                    but that seemed slighly messier.
              (WebCore::CSPSourceList::CSPSourceList):
                  - CSPSourceList doesn't need to ref SecurityOrigin because
                    CSPSourceList is owned by ContentSecurityPolicy, which holds a
                    ref.
              (WebCore::CSPSourceList::parse):
              (WebCore::CSPSourceList::matches):
              (WebCore::CSPSourceList::parseSource):
              (WebCore::CSPSourceList::parseScheme):
              (WebCore::CSPSourceList::parseHost):
              (WebCore::CSPSourceList::parsePort):
                  - A basic "segment and recurse" parser.  This parser causes us to
                    take more branches than we need, but I don't think we need to
                    squeeze every last ouch of performance out of this parser.  This
                    approach is more simple than some of the other approaches I
                    tried.
              (WebCore::CSPSourceList::addSourceSelf):
              (WebCore::CSPDirective::CSPDirective):
              (WebCore::CSPDirective::allows):
              (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
              (WebCore::ContentSecurityPolicy::parse):
              (WebCore::ContentSecurityPolicy::parseDirective):
              (WebCore::ContentSecurityPolicy::addDirective):
                  - I couldn't resist re-writing this parser to use the helper
                    functions and to match the style of the source-list parser.
              * page/ContentSecurityPolicy.h:
              (WebCore::ContentSecurityPolicy::create):
                  - Accept a SecurityOrigin context object.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f921dee2
  34. 24 Feb, 2011 1 commit
    • abarth@webkit.org's avatar
      2011-02-24 Adam Barth <abarth@webkit.org> · d27ac26b
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              CSP's script-src should block JavaScript URLs
              https://bugs.webkit.org/show_bug.cgi?id=54787
      
              Test how various CSP policies affect JavaScript URLs.  We could test
              more contexts in the future, but this is a start.
      
              * http/tests/security/contentSecurityPolicy/javascript-url-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/javascript-url.html: Added.
              * http/tests/security/contentSecurityPolicy/resources/javascript-url.pl: Added.
      2011-02-24  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              CSP's script-src should block JavaScript URLs
              https://bugs.webkit.org/show_bug.cgi?id=54787
      
              Blocking JavaScript URLs required some re-architecting of the lifetime
              of the ContentSecurityPolicy object.  We now manage the lifetime the
              same way we manage the lifetime of the SecurityOrigin object.  In
              particular, when SecurityOrigin inherits into an about:blank iframe, we
              inherit the CSP object as well.  (This is covered by the test added in
              this patch.) In the future, we might consider making
              ContentSecurityPolicy a component of SecurityOrigin instead of a
              component of Document.
      
              I noted the trickiness in
              http://www.w3.org/Security/wiki/Content_Security_Policies so that we'll
              make sure it gets defined properly in the spec.
      
              Test: http/tests/security/contentSecurityPolicy/javascript-url.html
      
              * bindings/ScriptControllerBase.cpp:
              (WebCore::ScriptController::executeIfJavaScriptURL):
              * dom/Document.cpp:
              (WebCore::Document::initSecurityContext):
              * dom/Document.h:
              (WebCore::Document::contentSecurityPolicy):
              * page/ContentSecurityPolicy.cpp:
              (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
              * page/ContentSecurityPolicy.h:
              (WebCore::ContentSecurityPolicy::create):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d27ac26b
  35. 19 Feb, 2011 1 commit
  36. 11 Feb, 2011 1 commit
    • japhet@chromium.org's avatar
      2011-02-10 Nate Chapin <japhet@chromium.org> · af889b91
      japhet@chromium.org authored
              Reviewed by Adam Barth.
      
              Make DocumentWriter a member of DocumentLoader
              instead of FrameLoader.
              https://bugs.webkit.org/show_bug.cgi?id=50489
      
              Refactor, no new tests.
      
              * bindings/ScriptControllerBase.cpp:
              (WebCore::ScriptController::executeIfJavaScriptURL):
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::explicitClose):
              (WebCore::Document::lastModified):
              (WebCore::Document::initSecurityContext):
              (WebCore::Document::updateURLForPushOrReplaceState):
              * dom/Document.h:
              (WebCore::Document::setDocumentLoader):
              (WebCore::Document::loader):
              * html/MediaDocument.cpp:
              (WebCore::MediaDocument::replaceMediaElementTimerFired):
              * html/PluginDocument.cpp:
              (WebCore::PluginDocumentParser::createDocumentStructure):
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::DocumentLoader):
              (WebCore::DocumentLoader::finishedLoading):
              (WebCore::DocumentLoader::commitData):
              (WebCore::DocumentLoader::setupForReplaceByMIMEType):
              (WebCore::DocumentLoader::setFrame):
              * loader/DocumentLoader.h:
              (WebCore::DocumentLoader::writer):
              * loader/DocumentWriter.cpp:
              (WebCore::DocumentWriter::begin):
              * loader/DocumentWriter.h:
              (WebCore::DocumentWriter::setFrame):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::FrameLoader):
              (WebCore::FrameLoader::init):
              (WebCore::FrameLoader::clear):
              (WebCore::FrameLoader::receivedFirstData):
              (WebCore::FrameLoader::transitionToCommitted):
              (WebCore::FrameLoader::open):
              (WebCore::FrameLoader::finishedLoadingDocument):
              (WebCore::FrameLoader::addExtraFieldsToRequest):
              * loader/FrameLoader.h:
              (WebCore::FrameLoader::notifier):
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::dataChanged):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af889b91
  37. 06 Feb, 2011 1 commit
    • abarth@webkit.org's avatar
      2011-02-05 Adam Barth <abarth@webkit.org> · 25ef4a1f
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Remove unused parameter related to XSSAuditor
              https://bugs.webkit.org/show_bug.cgi?id=53862
      
              * WebCore.exp.in:
              * bindings/ScriptControllerBase.cpp:
              (WebCore::ScriptController::executeScript):
              (WebCore::ScriptController::executeIfJavaScriptURL):
              * bindings/ScriptControllerBase.h:
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::evaluateInWorld):
              (WebCore::ScriptController::evaluate):
              (WebCore::ScriptController::executeScriptInWorld):
              * bindings/js/ScriptController.h:
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::evaluate):
              * bindings/v8/ScriptController.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77755 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25ef4a1f