1. 16 Jul, 2010 18 commits
    • mnaganov@chromium.org's avatar
      2010-07-16 Mikhail Naganov <mnaganov@chromium.org> · df0fa0d5
      mnaganov@chromium.org authored
      	Reviewed by Pavel Feldman.
      
      	Make JS memory stats available via 'Performance' object (Web Timing).
      	This statistics is populated only if 'WebKitMemoryInfoEnabled'
      	preference is set.
      
      	'console.memory' is kept until Web Timing object becomes visible by
      	default (currently it is hidden under compile-time flag).  These stats
      	are guarded with the same preference.
      
      	https://bugs.webkit.org/show_bug.cgi?id=41617
      
      	* bindings/js/JSConsoleCustom.cpp:
      	* bindings/v8/custom/V8ConsoleCustom.cpp:
      	* page/Console.cpp:
      	(WebCore::Console::disconnectFrame):
      	(WebCore::Console::memory):
      	* page/Console.h:
      	* page/Console.idl:
      	* page/MemoryInfo.cpp:
      	(WebCore::MemoryInfo::MemoryInfo):
      	* page/MemoryInfo.h:
      	(WebCore::MemoryInfo::create):
      	* page/Performance.cpp:
      	(WebCore::Performance::disconnectFrame):
      	(WebCore::Performance::memory):
      	* page/Performance.h:
      	* page/Performance.idl:
      	* page/Settings.cpp:
      	(WebCore::Settings::Settings):
      	* page/Settings.h:
      	(WebCore::Settings::setMemoryInfoEnabled):
      	(WebCore::Settings::memoryInfoEnabled):
      
      	* public/WebSettings.h:
      	* src/WebSettingsImpl.cpp:
      	(WebKit::WebSettingsImpl::setMemoryInfoEnabled):
      	* src/WebSettingsImpl.h:
      
      	* WebKit.order:
      	* WebView/WebPreferenceKeysPrivate.h:
      	* WebView/WebPreferences.mm:
      	(+[WebPreferences initialize]):
      	(-[WebPreferences memoryInfoEnabled]):
      	(-[WebPreferences setMemoryInfoEnabled:]):
      	* WebView/WebPreferencesPrivate.h:
      	* WebView/WebView.mm:
      	(-[WebView _preferencesChangedNotification:]):
      
      	* Interfaces/IWebPreferencesPrivate.idl:
      	* WebPreferenceKeysPrivate.h:
      	* WebPreferences.cpp:
      	(WebPreferences::initializeDefaultSettings):
      	(WebPreferences::memoryInfoEnabled):
      	(WebPreferences::setMemoryInfoEnabled):
      	* WebPreferences.h:
      	* WebView.cpp:
      	(WebView::notifyPreferencesChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df0fa0d5
    • zimmermann@webkit.org's avatar
      2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com> · 7d66fdd4
      zimmermann@webkit.org authored
              Reviewed by Dirk Schulze.
      
              Add possibility to dumpAsText and generate a pixel test result
              https://bugs.webkit.org/show_bug.cgi?id=42374
      
              Add optional parameter to setDumpAsText() to allow generating a pixel test result even if dumpAsText mode.
              setDumpAsText(true) will also generate a pixel test result now, when running run-webkit-tests --pixel-tests.
      
              This is needed for the svg/dynamic-updates tests, which don't want render tree dumps but text dumps + a pixel test result.
              At some point DRT changed to not generate pixel test results when using dumpAsText - which makes sense, but breaks the svg/dynamic-updates test.
      
              Implemented for all DRT platforms, except Qt, as it's not clear how arguments to functions like "setDumpAsText" are handled.
              (Qt always dumps pixel tests when using --pixel-tests mode, so it does not break anything)
      
              * DumpRenderTree/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (dumpAsTextAndPixelsCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              (LayoutTestController::dumpAsTextAndPixels):
              (LayoutTestController::setDumpAsTextAndPixels):
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (LayoutTestController::dumpAsTextAndPixels):
              (LayoutTestController::reset):
              * DumpRenderTree/chromium/LayoutTestController.h:
              (LayoutTestController::shouldDumpAsTextAndPixels):
              * DumpRenderTree/chromium/TestShell.cpp:
              (TestShell::dump):
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (dump):
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (dump):
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::dump):
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (dump):
              * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
              (dump):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d66fdd4
    • zimmermann@webkit.org's avatar
      2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com> · 4e10c835
      zimmermann@webkit.org authored
              Reviewed by Dirk Schulze.
      
              Convolution computation causes bad alpha channel values
              https://bugs.webkit.org/show_bug.cgi?id=42273
      
              Unbreak the convolve matrix filter, fixing svg/W3C-SVG-1.1/filters-conv-01-f.svg.
      
              1) Fix clamping the rgb values:
              "image->set(pixel++, clampRGBAValue(totals[0], maxAlpha));" totals[0] -> totals[i].
      
              2) Don't apply the divisior divison and bias addition multiple times, accumulated!
          
              * svg/graphics/filters/SVGFEConvolveMatrix.cpp:
              (WebCore::setDestinationPixels): Fix two evil bugs, breaking feConvolveMatrix.
      
      2010-07-16  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Dirk Schulze.
      
              Convolution computation causes bad alpha channel values
              https://bugs.webkit.org/show_bug.cgi?id=42273
      
              Unbreak the convolve matrix filter, fixing svg/W3C-SVG-1.1/filters-conv-01-f.svg.
              Update convolution-crash.svg results.
      
              * platform/mac/svg/custom/convolution-crash-expected.checksum:
              * platform/mac/svg/custom/convolution-crash-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e10c835
    • zimmermann@webkit.org's avatar
      2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com> · e46ef2a4
      zimmermann@webkit.org authored
              Not reviewed. Rebaseline two results which seemed to be corrupt (DRT warns).
      
              * platform/mac/svg/custom/convolution-crash-expected.checksum:
              * platform/mac/svg/custom/convolution-crash-expected.png:
              * platform/mac/svg/custom/mask-colorspace-expected.checksum:
              * platform/mac/svg/custom/mask-colorspace-expected.png:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e46ef2a4
    • zimmermann@webkit.org's avatar
      2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com> · 0bcf8c1f
      zimmermann@webkit.org authored
              Not reviewed. Add missing layout test results for fast/js/numeric-compare.html, which landed in r63515.
      
              * fast/js/numeric-compare-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bcf8c1f
    • kent.hansen@nokia.com's avatar
      2010-07-16 Kent Hansen <kent.hansen@nokia.com> · fc590591
      kent.hansen@nokia.com authored
              Unreviewed. Adding myself as committer.
      
              * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc590591
    • zimmermann@webkit.org's avatar
      2010-07-16 Nikolas Zimmermann <nzimmermann@rim.com> · 5bed57fa
      zimmermann@webkit.org authored
              Reviewed by Dirk Schulze.
      
              relative positioning does not work for radialGradient after window resize
              https://bugs.webkit.org/show_bug.cgi?id=41249
      
              Redesign the way resources are invalidated. No longer utilize the DOM tree, specifically SVGStyledElement::svgAttributeChanged(), to invalidate
              all resources in the ancestor chain (including itself) when any attribute changes. rect.setAttribute("foo", "bar") should never invalidate the
              resources. Also the old approach didn't work correctly if the root layout changed (eg. window size change) - we failed to invalidate the resources,
              thus leading to wrong renderings.
      
              Instead of calling setNeedsLayout(true) from the SVG*Element classes, call RenderSVGResource::markForLayoutAndParentResourceInvalidation(), which
              does the same thing and invalidates all resources in the ancestor chain (removing the cached results from the HashMaps). This only happens from
              the various svgAttributeChanged() methods, if we know which attribute changed, and what action has to be taken.
      
              All SVG renderers now invalidate their own resources on layout() if the layout changed (selfNeedsLayout()=true). The resources will be recreated
              and cached during the following paint() call.
      
              Tests: svg/custom/marker-child-changes-css.svg
                     svg/custom/relative-sized-content-with-resources.xhtml
      
              * rendering/RenderForeignObject.cpp:
              (WebCore::RenderForeignObject::layout): If our layout changed, invalidate our resources, by calling RenderSVGResource::invalidateAllResourcesOfRenderer().
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::layout): Ditto.
              * rendering/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::layout): Ditto.
              * rendering/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::layout): Ditto.
              * rendering/RenderSVGModelObject.cpp:
              (WebCore::RenderSVGModelObject::styleDidChange): Added, to invalidate resources on CSS changes, covered by new svg/custom/marker-child-changes-css.svg test.
              * rendering/RenderSVGModelObject.h:
              * rendering/RenderSVGResource.cpp:
              (WebCore::RenderSVGResource::markForLayoutAndResourceInvalidation): Add new "needsBoundaries" parameter, calling setNeedsBoundaries() on the target render object,
                                                                                  simplifying all RenderSVGResource* code.
              (WebCore::RenderSVGResource::markForLayoutAndParentResourceInvalidation): New static method used from DOM tree to invalidate all cached resources in the ancestor chain
                                                                                        for a render object. Also marks the renderer for layout, if needed. 
              * rendering/RenderSVGResource.h:
              * rendering/RenderSVGResourceClipper.cpp: Simplify code, remove no longer needed hacks, as invalidation is now carried out by render tree.
              (WebCore::RenderSVGResourceClipper::RenderSVGResourceClipper): Add m_invalidationBlocked hack, to avoid invalidations, while we're mutating the render styles (which is a hack!).
              (WebCore::RenderSVGResourceClipper::invalidateClients): Don't do anything if m_invalidationBlocked=true.
              (WebCore::RenderSVGResourceClipper::invalidateClient): Ditto.
              (WebCore::RenderSVGResourceClipper::createClipData): Set m_invalidationBlocked before mutating render styles, as they are restored immediately after creating the clip image.
              (WebCore::RenderSVGResourceClipper::resourceBoundingBox): Remove no longer needed hack to initialize ClipperData earlier than applyResource() would do.
              * rendering/RenderSVGResourceClipper.h:
              * rendering/RenderSVGResourceFilter.cpp:
              (WebCore::RenderSVGResourceFilter::invalidateClients): Simplify code using markForLayoutAndResourceInvalidation.
              (WebCore::RenderSVGResourceFilter::invalidateClient): Remove wrong assertion.
              * rendering/RenderSVGResourceGradient.cpp:
              (WebCore::RenderSVGResourceGradient::invalidateClients): Simplify code using markForLayoutAndResourceInvalidation.
              (WebCore::RenderSVGResourceGradient::invalidateClient): Remove wrong assertion.
              * rendering/RenderSVGResourceMarker.cpp:
              (WebCore::RenderSVGResourceMarker::invalidateClients): Simplify code using markForLayoutAndResourceInvalidation.
              (WebCore::RenderSVGResourceMarker::invalidateClient): Remove wrong assertion.
              * rendering/RenderSVGResourceMasker.cpp:
              (WebCore::RenderSVGResourceMasker::invalidateClients): Simplify code using markForLayoutAndResourceInvalidation.
              (WebCore::RenderSVGResourceMasker::invalidateClient): Remove wrong assertion.
              (WebCore::RenderSVGResourceMasker::resourceBoundingBox): Remove no longer needed hack to initializer MaskerData earlier than applyResource() would do.
              * rendering/RenderSVGResourcePattern.cpp:
              (WebCore::RenderSVGResourcePattern::invalidateClients): Simplify code using markForLayoutAndResourceInvalidation.
              (WebCore::RenderSVGResourcePattern::invalidateClient): Remove wrong assertion.
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::layout): If our layout changed, invalidate our resources, by calling RenderSVGResource::invalidateAllResourcesOfRenderer().
              * svg/SVGAnimateMotionElement.cpp:
              (WebCore::SVGAnimateMotionElement::applyResultsToTarget): Call RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer) instead of renderer->setNeedsLayout(true).
              * svg/SVGAnimateTransformElement.cpp:
              (WebCore::SVGAnimateTransformElement::applyResultsToTarget): Ditto.
              * svg/SVGCircleElement.cpp:
              (WebCore::SVGCircleElement::svgAttributeChanged): Ditto.
              * svg/SVGEllipseElement.cpp:
              (WebCore::SVGEllipseElement::svgAttributeChanged): Ditto.
              * svg/SVGFEImageElement.cpp:
              (WebCore::SVGFEImageElement::notifyFinished): Ditto.
              * svg/SVGForeignObjectElement.cpp:
              (WebCore::SVGForeignObjectElement::svgAttributeChanged): Ditto.
              * svg/SVGGElement.cpp:
              (WebCore::SVGGElement::svgAttributeChanged): Ditto.
              * svg/SVGImageElement.cpp:
              (WebCore::SVGImageElement::svgAttributeChanged): Ditto.
              * svg/SVGLineElement.cpp:
              (WebCore::SVGLineElement::svgAttributeChanged): Ditto.
              * svg/SVGPathElement.cpp:
              (WebCore::SVGPathElement::svgAttributeChanged): Ditto.
              * svg/SVGPolyElement.cpp:
              (WebCore::SVGPolyElement::svgAttributeChanged): Ditto.
              * svg/SVGRectElement.cpp:
              (WebCore::SVGRectElement::svgAttributeChanged): Ditto.
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::setCurrentScale): Ditto.
              (WebCore::SVGSVGElement::svgAttributeChanged): Ditto.
              (WebCore::SVGSVGElement::inheritViewAttributes): Ditto.
              * svg/SVGStopElement.cpp:
              (WebCore::SVGStopElement::SVGStopElement): Changed m_offset initialization from 0.0f to 0.
              (WebCore::SVGStopElement::svgAttributeChanged): Add missing implementation, calling RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer) on offsetAttr changes.
              * svg/SVGStopElement.h:
              * svg/SVGStyledElement.cpp:
              (WebCore::SVGStyledElement::svgAttributeChanged): Don't call invalidateResourceInAncestorChain() on every attribute change, do it in all classes inheriting from us,
                                                                for specific attributes. Also stop calling RenderSVGResource::invalidateAllResourcesOfRenderer(), all handled in the render tree now.
              (WebCore::SVGStyledElement::invalidateResourceClients): Early exit, if document is still parsing.
              * svg/SVGStyledElement.h:
              * svg/SVGTRefElement.cpp:
              (WebCore::SVGTRefElement::svgAttributeChanged): Call RenderSVGResource::markForLayoutAndParentResourceInvalidation(renderer) instead of renderer->setNeedsLayout(true).
              * svg/SVGTextElement.cpp:
              (WebCore::SVGTextElement::svgAttributeChanged): Ditto.
              * svg/SVGTextPathElement.cpp:
              (WebCore::SVGTextPathElement::svgAttributeChanged): Ditto.
              * svg/SVGTextPositioningElement.cpp:
              (WebCore::SVGTextPositioningElement::svgAttributeChanged): Ditto.
              * svg/SVGUseElement.cpp:
              (WebCore::SVGUseElement::svgAttributeChanged): Ditto.
              (WebCore::SVGUseElement::updateContainerSizes): Ditto.
              (WebCore::SVGUseElement::updateContainerOffsets): Ditto.
      
      2010-07-16  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Dirk Schulze.
      
              relative positioning does not work for radialGradient after window resize
              https://bugs.webkit.org/show_bug.cgi?id=41249
      
              * platform/mac/svg/custom/marker-child-changes-css-expected.checksum: Added.
              * platform/mac/svg/custom/marker-child-changes-css-expected.png: Added.
              * platform/mac/svg/custom/marker-child-changes-css-expected.txt: Added.
              * platform/mac/svg/custom/relative-sized-content-with-resources-expected.checksum: Added.
              * platform/mac/svg/custom/relative-sized-content-with-resources-expected.png: Added.
              * platform/mac/svg/custom/relative-sized-content-with-resources-expected.txt: Added.
              * svg/custom/marker-child-changes-css.svg: Added.
              * svg/custom/relative-sized-content-with-resources.xhtml: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5bed57fa
    • commit-queue@webkit.org's avatar
      2010-07-16 Cosmin Truta <ctruta@chromium.org> · dc7fd1c5
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              Some SVGs with empty <g> elements crash Chromium on Linux
              https://bugs.webkit.org/show_bug.cgi?id=41175
      
              This is a SVG with an empty <g> within a <g>, to which a filter is applied by reference.
              The rendered image is all blank.
      
              * platform/mac/svg/filters/filter-empty-g-expected.checksum: Added
              * platform/mac/svg/filters/filter-empty-g-expected.png: Added
              * platform/mac/svg/filters/filter-empty-g-expected.txt: Added
              * svg/filters/filter-empty-g.svg: Added
      2010-07-16  Cosmin Truta  <ctruta@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Some SVGs with empty <g> elements crash Chromium on Linux
              https://bugs.webkit.org/show_bug.cgi?id=41175
      
              Avoid painting of zero-sized image buffers. Skia can't handle it.
      
              Test: svg/filters/filter-empty-g.svg
      
              * WebCore/platform/graphics/skia/ImageBufferSkia.cpp:
              (ImageBuffer::ImageBuffer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc7fd1c5
    • hamaji@chromium.org's avatar
      2010-07-16 Shinichiro Hamaji <hamaji@chromium.org> · df73ae46
      hamaji@chromium.org authored
              Reviewed by Darin Adler.
      
              Printing test results differ between machines, we should use ImageDiff instead
              https://bugs.webkit.org/show_bug.cgi?id=20011
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df73ae46
    • japhet@chromium.org's avatar
      2010-07-16 Nate Chapin <japhet@chromium.org> · f00dffa6
      japhet@chromium.org authored
              Reviewed by Darin Fisher.
      
              Regression in r63100: Don't clear m_loadType in
              FrameLoader::handledOnloadEvents, as it is used
              to make some decisions after the load has actually
              completed.
      
              Tickling this bug requires manipulation
              via the API (layout tests don't appear to traverse
              the correct codepath), so no layout test.
      
              https://bugs.webkit.org/show_bug.cgi?id=42298
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::handledOnloadEvents): Don't reset m_loadType.
              (WebCore::FrameLoader::addExtraFieldsToRequest): Set subresource cache
                 policy in one place and don't depend on m_loadType.
      2010-07-16  Nate Chapin  <japhet@chromium.org>
      
              Reviewed by Darin Fisher.
      
              Uncomment an assert that broke due to r63100.
      
              https://bugs.webkit.org/show_bug.cgi?id=42298
      
              * tests/testwebview.c:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f00dffa6
    • hamaji@chromium.org's avatar
      2010-07-16 Shinichiro Hamaji <hamaji@chromium.org> · fc798cb9
      hamaji@chromium.org authored
              Another uneviewed attempt to fix build.
      
              Printing test results differ between machines, we should use ImageDiff instead
              https://bugs.webkit.org/show_bug.cgi?id=20011
      
              * DumpRenderTree/mac/PixelDumpSupportMac.mm:
              (createPagedBitmapContext):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc798cb9
    • hamaji@chromium.org's avatar
      2010-07-16 Shinichiro Hamaji <hamaji@chromium.org> · ea744e8a
      hamaji@chromium.org authored
              Unreviewed tiger build fix.
      
              Printing test results differ between machines, we should use ImageDiff instead
              https://bugs.webkit.org/show_bug.cgi?id=20011
      
              * DumpRenderTree/mac/PixelDumpSupportMac.mm:
              (createBitmapContext):
              (createBitmapContextFromWebView):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea744e8a
    • hamaji@chromium.org's avatar
      2010-07-15 Shinichiro Hamaji <hamaji@chromium.org> · 67795693
      hamaji@chromium.org authored
              Unreviewed build fix.
      
              Printing test results differ between machines, we should use ImageDiff instead
              https://bugs.webkit.org/show_bug.cgi?id=20011
      
              * DumpRenderTree/PixelDumpSupport.cpp:
              (dumpWebViewAsPixelsAndCompareWithExpected):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67795693
    • commit-queue@webkit.org's avatar
      2010-07-15 Yuta Kitamura <yutak@chromium.org> · 4be32de4
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              WebSocket: Put echo-challenge_wsh.py under workers/resources directory
              https://bugs.webkit.org/show_bug.cgi?id=42439
      
              I have realized that tests under workers/ directory should not depend on
              a pywebsocket script in a directory above.
      
              Putting *_wsh.py files under resources/ directory also benefits Chromium's
              worker test which only copies the contents under workers/resources directory
              when running WebSocket worker tests.
      
              * websocket/tests/workers/resources/echo-challenge_wsh.py: Copied from LayoutTests/websocket/tests/echo-challenge_wsh.py.
              * websocket/tests/workers/resources/worker-handshake-challenge-randomness.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4be32de4
    • hamaji@chromium.org's avatar
      2010-07-15 Shinichiro Hamaji <hamaji@chromium.org> · 984dc810
      hamaji@chromium.org authored
              Unreviewed fix for chromium's expectation.
      
              Printing test results differ between machines, we should use ImageDiff instead
              https://bugs.webkit.org/show_bug.cgi?id=20011
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      984dc810
    • hamaji@chromium.org's avatar
      2010-07-15 Shinichiro Hamaji <hamaji@chromium.org> · 93fae26e
      hamaji@chromium.org authored
              Unreviewed fix for expected images.
      
              Printing test results differ between machines, we should use ImageDiff instead
              https://bugs.webkit.org/show_bug.cgi?id=20011
      
              * platform/mac/printing/page-rule-in-media-query-expected.checksum:
              * platform/mac/printing/page-rule-in-media-query-expected.png:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93fae26e
    • hamaji@chromium.org's avatar
      2010-07-15 Shinichiro Hamaji <hamaji@chromium.org> · d58d8e04
      hamaji@chromium.org authored
              Reviewed by Darin Adler.
      
              Printing test results differ between machines, we should use ImageDiff instead
              https://bugs.webkit.org/show_bug.cgi?id=20011
      
              Added printing/setPrinting.html to check there is the page boundary.
      
              Enabled printing/composite-layer-printing.html with setPrinting.
      
              The result of printing/media-queries-print.html shrunk because of
              PrintingMinimumShrinkFactor in PrintContext::begin().
      
              * platform/mac/Skipped:
              * platform/mac/printing/compositing-layer-printing-expected.checksum: Added.
              * platform/mac/printing/compositing-layer-printing-expected.png: Added.
              * platform/mac/printing/compositing-layer-printing-expected.txt: Added.
              * platform/mac/printing/media-queries-print-expected.checksum:
              * platform/mac/printing/media-queries-print-expected.png:
              * platform/mac/printing/setPrinting-expected.checksum: Added.
              * platform/mac/printing/setPrinting-expected.png: Added.
              * platform/mac/printing/setPrinting-expected.txt: Added.
              * printing/compositing-layer-printing.html:
              * printing/setPrinting.html: Added.
      2010-07-15  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Printing test results differ between machines, we should use ImageDiff instead
              https://bugs.webkit.org/show_bug.cgi?id=20011
      
              Added spoolAllPagesWithBoundaries into PrintContext.
      
              Test: printing/setPrinting.html
      
              * WebCore.base.exp:
              * page/PrintContext.cpp:
              (WebCore::PrintContext::spoolAllPagesWithBoundaries):
              * page/PrintContext.h:
      2010-07-15  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Printing test results differ between machines, we should use ImageDiff instead
              https://bugs.webkit.org/show_bug.cgi?id=20011
      
              * Misc/WebCoreStatistics.h:
              * Misc/WebCoreStatistics.mm:
              (-[WebFrame printToCGContext:cgContext:pageWidthInPixels:]):
      2010-07-15  Shinichiro Hamaji  <hamaji@chromium.org>
      
              Reviewed by Darin Adler.
      
              Printing test results differ between machines, we should use ImageDiff instead
              https://bugs.webkit.org/show_bug.cgi?id=20011
      
              * DumpRenderTree/PixelDumpSupport.cpp:
              (dumpWebViewAsPixelsAndCompareWithExpected):
              * DumpRenderTree/PixelDumpSupport.h:
              * DumpRenderTree/mac/PixelDumpSupportMac.mm:
              (createBitmapContext): This function was added to share bitmap context creation code.
              (createBitmapContextFromWebView):
              (createPagedBitmapContext):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d58d8e04
    • morrita@google.com's avatar
      2010-07-15 MORITA Hajime <morrita@google.com> · 5ebefd7c
      morrita@google.com authored
              Unrviewed, added missing expectations.
      
              [chromium] r63422 caused svg/custom/svg-fonts-without-missing-glyph.xhtml to fail on Linux and Windows
              https://bugs.webkit.org/show_bug.cgi?id=42402
      
              * platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.checksum: Added.
              * platform/chromium-linux/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
              * platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.checksum: Added.
              * platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.png: Added.
              * platform/chromium-win/svg/custom/svg-fonts-without-missing-glyph-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ebefd7c
  2. 15 Jul, 2010 22 commits
    • abarth@webkit.org's avatar
      2010-07-15 Adam Barth <abarth@webkit.org> · e8a9477e
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              fast/frames/contentWindow_Frame.html shouldn't depend on <body> before <frameset>
              https://bugs.webkit.org/show_bug.cgi?id=42349
      
              * fast/frames/contentWindow_Frame.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8a9477e
    • tkent@chromium.org's avatar
      2010-07-15 Kent Tamura <tkent@chromium.org> · 8ee798e4
      tkent@chromium.org authored
              Unreviewed, small style fixes.
      
              * platform/chromium/ThemeChromiumMac.mm:
              (WebCore::ThemeChromiumMac::inflateControlPaintRect):
              * platform/mac/ThemeMac.mm:
              (WebCore::ThemeMac::inflateControlPaintRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ee798e4
    • abarth@webkit.org's avatar
      2010-07-15 Adam Barth <abarth@webkit.org> · 92bbe599
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Update LegacyHTMLTreeBuilder to insert whitespace between </head> and <body>
              https://bugs.webkit.org/show_bug.cgi?id=42431
      
              Insert these whitespace text nodes into the HTML element between <head>
              and <body>, as required by HTML5.  Previously, we just dropped them on
              the floor.
      
              * html/LegacyHTMLTreeBuilder.cpp:
              (WebCore::LegacyHTMLTreeBuilder::handleError):
      2010-07-15  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Update LegacyHTMLTreeBuilder to insert whitespace between </head> and <body>
              https://bugs.webkit.org/show_bug.cgi?id=42431
      
              Update expected results.  These results match the HTML5 parser.
      
              * editing/deleting/delete-br-in-last-table-cell-expected.txt:
              * fast/innerHTML/005-expected.txt:
              * html5lib/resources/webkit01.dat:
              * html5lib/runner-expected.txt:
              * http/tests/webarchive/cross-origin-stylesheet-crash-expected.webarchive:
              * http/tests/webarchive/test-css-url-encoding-expected.webarchive:
              * http/tests/webarchive/test-css-url-encoding-shift-jis-expected.webarchive:
              * http/tests/webarchive/test-css-url-encoding-utf-8-expected.webarchive:
              * platform/mac/css2.1/t1204-root-e-expected.txt:
              * platform/mac/fast/css/empty-generated-content-expected.txt:
              * traversal/exception-forwarding-expected.txt:
              * traversal/script-tests/exception-forwarding.js:
              * webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive:
              * webarchive/adopt-attribute-styled-node-webarchive-expected.webarchive:
              * webarchive/adopt-inline-styled-node-webarchive-expected.webarchive:
              * webarchive/archive-empty-frame-dom-expected.webarchive:
              * webarchive/archive-with-unencoded-url-expected.webarchive:
              * webarchive/test-body-background-expected.webarchive:
              * webarchive/test-css-import-expected.webarchive:
              * webarchive/test-css-url-resources-in-stylesheets-expected.webarchive:
              * webarchive/test-css-url-resources-inline-styles-expected.webarchive:
              * webarchive/test-duplicate-resources-expected.webarchive:
              * webarchive/test-frameset-expected.webarchive:
              * webarchive/test-img-src-expected.webarchive:
              * webarchive/test-input-src-expected.webarchive:
              * webarchive/test-link-href-expected.webarchive:
              * webarchive/test-link-rel-icon-expected.webarchive:
              * webarchive/test-object-data-expected.webarchive:
              * webarchive/test-script-src-expected.webarchive:
              * webarchive/test-table-background-expected.webarchive:
              * webarchive/test-td-background-expected.webarchive:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92bbe599
    • victorw@chromium.org's avatar
      2010-07-15 Victor Wang <victorw@chromium.org> · f1d37f99
      victorw@chromium.org authored
              Reviewed by David Levin.
      
              [Chromium] Disable c4291 for chromium windows multi dll build.
      
              https://bugs.webkit.org/show_bug.cgi?id=42177
      
              * JavaScriptCore.gyp/JavaScriptCore.gyp:
      2010-07-15  Victor Wang  <victorw@chromium.org>
      
              Reviewed by David Levin.
      
             [Chromium] Chromium webkit dll updates:
              -. Fix WEBKIT_IMPLEMENTATION in WebCommon so
                 dllimport works as expected.
              -. Update webkit.gyp so targets that depend on webkit
                 has correct macros defined.
      
              https://bugs.webkit.org/show_bug.cgi?id=42177
      
              * WebKit.gyp:
              * public/WebCommon.h:
      2010-07-15  Victor Wang  <victorw@chromium.org>
      
              Reviewed by David Levin.
      
              [chromium] update KURLGoogle decodeURLEscapeSequences to
              use googleurl public api so it does not access functions in
              url_canon_internal. This is for chromium multi-dll build.
      
              https://bugs.webkit.org/show_bug.cgi?id=42177
      
              Test: (unittest) WebKit\chromium\tests\KURLTest.cpp
      
              * platform/KURLGoogle.cpp:
              (WebCore::decodeURLEscapeSequences):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1d37f99
    • ggaren@apple.com's avatar
      2010-07-15 Geoffrey Garen <ggaren@apple.com> · 7426f925
      ggaren@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              Crash entering mail.yahoo.com
              https://bugs.webkit.org/show_bug.cgi?id=42394
          
              * bytecompiler/BytecodeGenerator.cpp:
              (JSC::BytecodeGenerator::argumentNumberFor): Added a NULL check. If the
              identifier we're resolving is not a local variable, registerFor returns
              NULL.
      
              * bytecompiler/NodesCodegen.cpp:
              (JSC::FunctionBodyNode::emitBytecode): Unrelated to the crash, but I
              noticed this while working on it: No need to NULL-check returnNode,
              since an early return has already done so.
      2010-07-15  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              Test for https://bugs.webkit.org/show_bug.cgi?id=42394
              Crash entering mail.yahoo.com
      
              * fast/js/numeric-compare.html: Added.
              * fast/js/script-tests/numeric-compare.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7426f925
    • tkent@chromium.org's avatar
      2010-07-15 Kent Tamura <tkent@chromium.org> · 46d9f573
      tkent@chromium.org authored
              Reviewed by Eric Seidel.
      
              [Chromium] Update ThemeChromiumMac.mm for the recent changes of ThemeMac.mm
              https://bugs.webkit.org/show_bug.cgi?id=41932
      
              Sync with ThemeMac.mm r61760.
              This change doesn't contain r54299, r57603, r57734, r57741, and
              r58533 because they conflict with Chromium change for
              FlippedView().
      
              * platform/chromium/ThemeChromiumMac.mm:
              (WebCore::sizeFromNSControlSize):
              (WebCore::sizeFromFont):
              (WebCore::controlSizeFromPixelSize):
              (WebCore::setControlSize):
              (WebCore::convertControlStatesToThemeDrawState):
              (WebCore::stepperSizes):
              (WebCore::stepperControlSizeForFont):
              (WebCore::paintStepper):
              (WebCore::ThemeChromiumMac::controlSize):
              (WebCore::ThemeChromiumMac::minimumControlSize):
              (WebCore::ThemeChromiumMac::inflateControlPaintRect):
              (WebCore::ThemeChromiumMac::paint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46d9f573
    • abarth@webkit.org's avatar
      2010-07-15 Adam Barth <abarth@webkit.org> · 95cdc030
      abarth@webkit.org authored
              Followup to https://bugs.webkit.org/show_bug.cgi?id=42214
      
              Rebaseline GTK and Qt.
      
              * platform/gtk/fast/canvas/toDataURL-alpha-expected.txt: Added.
              * platform/qt/fast/canvas/toDataURL-alpha-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95cdc030
    • abarth@webkit.org's avatar
      2010-07-15 Adam Barth <abarth@webkit.org> · 64f71b38
      abarth@webkit.org authored
              Followup to https://bugs.webkit.org/show_bug.cgi?id=42214
      
              Move toDataURL-alpha-expected.txt to the platform, where it belongs.
      
              * fast/canvas/toDataURL-alpha-expected.txt: Removed.
              * platform/mac/fast/canvas/toDataURL-alpha-expected.txt: Copied from LayoutTests/fast/canvas/toDataURL-alpha-expected.txt.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64f71b38
    • morrita@google.com's avatar
      2010-07-15 MORITA Hajime <morrita@google.com> · 23716bcc
      morrita@google.com authored
              Reviewed by David Levin.
      
              [Chromium][Win] Crashes with <keygen> with huge padding.
              https://bugs.webkit.org/show_bug.cgi?id=41737
      
              * fast/forms/large-parts-expected.txt: Added.
              * fast/forms/large-parts.html: Added.
      2010-07-15  MORITA Hajime  <morrita@google.com>
      
              Reviewed by David Levin.
      
              [Chromium][Win] Crashes with <keygen> with huge padding.
              https://bugs.webkit.org/show_bug.cgi?id=41737
      
              When we try to draw a large region, TransparencyWin can fail to
              allocate a temporal buffer for composition.  This change adds a
              fallback path to ThemePainter to handle the buffer allocation
              failure.
      
              ThemePainter is no longer a subclass of TransparencyWin.  It has
              a TransparencyWin as a member.
      
              Test: fast/forms/large-parts.html
      
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::ThemePainter): Added a fallback path.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23716bcc
    • yuzo@google.com's avatar
      2010-07-15 Yuzo Fujishima <yuzo@google.com> · d4048869
      yuzo@google.com authored
              Reviewed by Darin Adler.
      
              Fix for Bug 42362 - CSSSegmentedFontFace::isLoaded() const is not used anywhere
              Remove the method.
              https://bugs.webkit.org/show_bug.cgi?id=42362
      
              No new tests because of no behavior changes.
      
              * css/CSSSegmentedFontFace.cpp:
              * css/CSSSegmentedFontFace.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4048869
    • arv@chromium.org's avatar
      2010-07-15 Erik Arvidsson <arv@chromium.org> · eb1cf1ea
      arv@chromium.org authored
              Reviewed by David Levin.
      
              Add directional property enums to the switch in applyProperty
              https://bugs.webkit.org/show_bug.cgi?id=42438
      
              Build fix for chromium mac.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb1cf1ea
    • commit-queue@webkit.org's avatar
      2010-07-15 Yuta Kitamura <yutak@chromium.org> · 05769caa
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              Pull in pywebsocket-0.5.1
              https://bugs.webkit.org/show_bug.cgi?id=42353
      
              pywebsocket-0.5.1 contains a small bug fix (*) that should fix a worker test
              in Chromium. There is no other functional change.
      
              (*) http://code.google.com/p/pywebsocket/source/detail?r=265
      
              * Scripts/webkitpy/thirdparty/__init__.py: Bump pywebsocket version to 0.5.1.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05769caa
    • zmo@google.com's avatar
      Adding my freenode irc id to committers' list. · 1da44dc2
      zmo@google.com authored
      Unreviewed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1da44dc2
    • zmo@google.com's avatar
      Fix the error in the WebCore/ChangeLog. · 7fb83cd7
      zmo@google.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fb83cd7
    • zmo@google.com's avatar
      2010-07-15 Jay Civelli <jcivelli@chromium.org> · 8d07a942
      zmo@google.com authored
              Reviewed by David Levin.
      
              [chromium] Making the popup label color visible when the item is
              selected.
              https://bugs.webkit.org/show_bug.cgi?id=42271
      
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupListBox::paintRow): paint the label text with a
              different color when it is selected. 
      2010-07-13  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Nate Chapin.
      
              bufferData and bufferSubData generate wrong error when null buffer is bound
              https://bugs.webkit.org/show_bug.cgi?id=42125
      
              * fast/canvas/webgl/buffer-data-array-buffer-expected.txt:
              * fast/canvas/webgl/buffer-data-array-buffer.html: Test against the case where bound buffer is 0.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d07a942
    • jcivelli@chromium.org's avatar
      2010-07-15 Jay Civelli <jcivelli@chromium.org> · 3170586b
      jcivelli@chromium.org authored
              Reviewed by David Levin.
      
              [chromium] Making the popup label color visible when the item is
              selected.
              https://bugs.webkit.org/show_bug.cgi?id=42271
      
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupListBox::paintRow): paint the label text with a
              different color when it is selected.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3170586b
    • ojan@chromium.org's avatar
      2010-07-15 Ojan Vafai <ojan@chromium.org> · 706b03c8
      ojan@chromium.org authored
              Unreviewed. Fix expected failure for test from r63494.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      706b03c8
    • zmo@google.com's avatar
      2010-07-13 Zhenyao Mo <zmo@google.com> · 54d574e2
      zmo@google.com authored
              Reviewed by Nate Chapin.
      
              WebGL rendering results must be made available to Canvas.toDataURL and 2D drawImage
              https://bugs.webkit.org/show_bug.cgi?id=34719
      
              * src/GraphicsContext3D.cpp:
              (WebCore::GraphicsContext3DInternal::paintRenderingResultsToCanvas): Implement paintRenderingResultsToCanvas().
              (WebCore::GraphicsContext3DInternal::beginPaint): Just use paintRenderingResultsToCanvas().
      2010-07-13  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Nate Chapin.
      
              WebGL rendering results must be made available to Canvas.toDataURL and 2D drawImage
              https://bugs.webkit.org/show_bug.cgi?id=34719
      
              Tests: fast/canvas/webgl/canvas-test.html
                     fast/canvas/webgl/gl-pixelstorei.html
      
              * html/HTMLCanvasElement.cpp:
              (WebCore::HTMLCanvasElement::makeRenderingResultsAvailable): Paint the WebGL rendering results to canvas if it's 3d.
              (WebCore::HTMLCanvasElement::toDataURL): Paint the WebGL rendering results to canvas if it's 3d.
              * html/canvas/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::drawImage): Paint the WebGL rendering results to canvas if it's 3d before drawing.
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::markContextChanged): Mark it always for canvas2d.drawImage purpose.
              (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas): Paint the WebGL rendering results to canvas if it's dirty.
              * html/canvas/WebGLRenderingContext.h: Declare paintRenderingResultsToCanvas().
              * platform/graphics/GraphicsContext3D.h: Declare paintRenderingResultsToCanvas() & paintToCanvas().
              * platform/graphics/cg/GraphicsContext3DCG.cpp:
              (WebCore::GraphicsContext3D::paintToCanvas): Paint the rendered image pixels to the canvas.
              * platform/graphics/mac/GraphicsContext3DMac.mm:
              (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): Implement paintRenderingResultsToCanvas().
              * platform/graphics/qt/GraphicsContext3DQt.cpp:
              (WebCore::GraphicsContext3D::beginPaint): Just call paintRenderingResultsToCanvas().
              (WebCore::GraphicsContext3D::endPaint):
              (WebCore::GraphicsContext3D::paintRenderingResultsToCanvas): Implement paintRenderingResultsToCanvas().
      2010-07-13  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Nate Chapin.
      
              WebGL rendering results must be made available to Canvas.toDataURL and 2D drawImage
              https://bugs.webkit.org/show_bug.cgi?id=34719
      
              * fast/canvas/webgl/canvas-test-expected.txt: Added.
              * fast/canvas/webgl/canvas-test.html: Added.
              * fast/canvas/webgl/gl-pixelstorei-expected.txt: Added.
              * fast/canvas/webgl/gl-pixelstorei.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54d574e2
    • ojan@chromium.org's avatar
      2010-07-15 Ojan Vafai <ojan@chromium.org> · 62263ef7
      ojan@chromium.org authored
              Unreviewed.
      
              Update expected failures for tests to green chromium build.
              Bugs are filed with all the relevant owners.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62263ef7
    • andersca@apple.com's avatar
      Set notifyData to the stream's notification data · 1afe467c
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=42429
      
      Reviewed by Dan Bernstein.
      
      * WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
      (WebKit::NetscapePluginStream::start):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1afe467c
    • mjs@apple.com's avatar
      Add some tests that hang or crash, and remove some that don't any more · 65e5d2fe
      mjs@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=42411
      
      Reviewed by Darin Adler.
      
      * platform/mac-wk2/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65e5d2fe
    • ojan@chromium.org's avatar
      2010-07-15 Ojan Vafai <ojan@chromium.org> · bff87d17
      ojan@chromium.org authored
              Unreviewed.
      
              Chromium expected results after r63472
              https://bugs.webkit.org/show_bug.cgi?id=42425
      
              * platform/chromium-linux/fast/invalid/residual-style-expected.txt:
              * platform/chromium-mac/html5lib/runner-expected.txt:
              * platform/chromium-win/fast/invalid/residual-style-expected.txt:
              * platform/chromium-win/fast/table/border-collapsing/002-expected.txt:
              * platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
              * platform/chromium-win/fast/table/cell-width-auto-expected.txt:
              * platform/chromium-win/fast/table/colgroup-preceded-by-caption-expected.txt:
              * platform/chromium-win/html5lib/runner-expected.txt:
              * platform/chromium-win/tables/mozilla/bugs/bug100334-expected.txt:
              * platform/chromium-win/tables/mozilla/bugs/bug139524-1-expected.txt:
              * platform/chromium-win/tables/mozilla/bugs/bug139524-4-expected.txt:
              * platform/chromium-win/tables/mozilla/bugs/bug25367-expected.txt:
              * platform/chromium-win/tables/mozilla/bugs/bug29058-3-expected.txt:
              * platform/chromium-win/tables/mozilla/bugs/bug43039-expected.txt:
              * platform/chromium-win/tables/mozilla/bugs/bug43854-1-expected.txt:
              * platform/chromium-win/tables/mozilla/bugs/bug7471-expected.txt:
              * platform/chromium-win/tables/mozilla/core/misc-expected.txt:
              * platform/chromium-win/tables/mozilla/dom/deleteCol1-expected.txt:
              * platform/chromium-win/tables/mozilla/dom/deleteCol2-expected.txt:
              * platform/chromium-win/tables/mozilla/dom/deleteCol3-expected.txt:
              * platform/chromium-win/tables/mozilla/dom/insertCols1-expected.txt:
              * platform/chromium-win/tables/mozilla/dom/insertCols2-expected.txt:
              * platform/chromium-win/tables/mozilla/dom/insertCols3-expected.txt:
              * platform/chromium-win/tables/mozilla/marvin/col_span-expected.txt:
              * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
              * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug47163-expected.txt:
              * platform/chromium-win/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
              * platform/chromium-win/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
              * platform/chromium-win/tables/mozilla_expected_failures/core/col_span2-expected.txt:
              * platform/chromium-win/tables/mozilla_expected_failures/core/cols1-expected.txt:
              * platform/chromium-win/tables/mozilla_expected_failures/core/columns-expected.txt:
              * platform/chromium-win/tables/mozilla_expected_failures/core/conflicts-expected.txt:
              * platform/chromium-win/tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bff87d17