1. 24 May, 2007 3 commits
  2. 23 May, 2007 5 commits
    • darin's avatar
      LayoutTests: · 258af4a1
      darin authored
              Reviewed by Hyatt.
      
              - updated the many tests with an extra newline or two at the end
                because of the bug where plain-text serialization will consider
                nodes that are not rendered
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix problems where unrendered nodes were affecting on plain text serialization
      
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::advance): Don't call handleXXX functions or exitNode for
              nodes without renderers.
              (WebCore::shouldEmitNewlineAfterNode): Only consider rendered nodes when deciding
              if this is the last node in the document.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      258af4a1
    • kmccullo's avatar
      LayoutTests: · ef9bbdef
      kmccullo authored
              Reviewed by Darin.
      
              Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of 
              the rest of HTMLElement
      
              - Corrects prototype chain for JSHTMLDocument and adds test
                for HTMLFormElement.
      
              * fast/dom/prototype-chain-expected.txt:
              * fast/dom/prototype-chain.html:
      
      WebCore:
      
              Reviewed by Darin.
      
              - rdar://problem/5183523
              - We now check the document's URL to see if it can load a resource in the case of a URL click, instead of checking the referrer, which is blank for local files.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::load):
              (WebCore::FrameLoader::open):
              * platform/PlatformString.h:
              (WebCore::debugPrintString):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef9bbdef
    • weinig's avatar
      LayoutTests: · 661a37fc
      weinig authored
              Reviewed by Darin.
      
              Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of 
              the rest of HTMLElement
      
              - Corrects prototype chain for JSHTMLDocument and adds test
                for HTMLFormElement.
      
              * fast/dom/prototype-chain-expected.txt:
              * fast/dom/prototype-chain.html:
      
      WebCore:
      
              Reviewed by Darin.
      
              Part two of patch for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of the rest
              of HTMLElement
      
              - Just the HTMLDocument part.
      
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLDocumentCustom.cpp: Added.
              (WebCore::JSHTMLDocument::canGetItemsForName):
              (WebCore::JSHTMLDocument::nameGetter):
              (WebCore::JSHTMLDocument::all):
              (WebCore::JSHTMLDocument::setAll):
              (WebCore::JSHTMLDocument::location):
              (WebCore::JSHTMLDocument::setLocation):
              (WebCore::JSHTMLDocument::open):
              (WebCore::writeHelper):
              (WebCore::JSHTMLDocument::write):
              (WebCore::JSHTMLDocument::writeln):
              (WebCore::JSHTMLDocument::clear):
              * bindings/js/kjs_dom.cpp:
              (KJS::toJS):
              * bindings/js/kjs_dom.h:
              * bindings/js/kjs_html.cpp:
              * bindings/js/kjs_html.h:
              * bindings/objc/DOMPrivate.h:
              * bindings/scripts/CodeGeneratorJS.pm: Add [Deletable] property
              for Document.all and fix HasOverridingNameGetter to allow correct
              prototype chain
              * dom/Document.cpp:
              (WebCore::Document::plugins): adds alias to embeds() for bindings
              * dom/Document.h:
              * html/HTMLDocument.cpp:
              (WebCore::HTMLDocument::width):
              (WebCore::HTMLDocument::height):
              (WebCore::HTMLDocument::dir):
              (WebCore::HTMLDocument::setDir):
              (WebCore::HTMLDocument::designMode):
              (WebCore::HTMLDocument::setDesignMode):
              (WebCore::HTMLDocument::bgColor):
              (WebCore::HTMLDocument::setBgColor):
              (WebCore::HTMLDocument::fgColor):
              (WebCore::HTMLDocument::setFgColor):
              (WebCore::HTMLDocument::alinkColor):
              (WebCore::HTMLDocument::setAlinkColor):
              (WebCore::HTMLDocument::linkColor):
              (WebCore::HTMLDocument::setLinkColor):
              (WebCore::HTMLDocument::vlinkColor):
              (WebCore::HTMLDocument::setVlinkColor):
              (WebCore::HTMLDocument::captureEvents):
              (WebCore::HTMLDocument::releaseEvents):
              * html/HTMLDocument.h:
              * html/HTMLDocument.idl:
      
      WebKit:
      
              Reviewed by Darin.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of the rest
              of HTMLElement
      
              * MigrateHeaders.make: add DOMHTMLDocumentPrivate.h
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      661a37fc
    • kmccullo's avatar
      Reviewed by. · 649a9edd
      kmccullo authored
              - Fixed build breakage.
      
              * fast/dom/open-and-close-by-DOM-expected.txt: Added.
              * fast/dom/open-and-close-by-DOM.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      649a9edd
    • kmccullo's avatar
      Reviewed by. · 5fd81f18
      kmccullo authored
              - Removing failing tests until I've fixed them.
      
              * fast/dom/open-and-close-by-DOM-expected.txt: Removed.
              * fast/dom/open-and-close-by-DOM.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fd81f18
  3. 22 May, 2007 4 commits
    • weinig's avatar
      LayoutTests: · 40d22abd
      weinig authored
              Reviewed by Adam.
      
              Update tests for http://bugs.webkit.org/show_bug.cgi?id=13833
              Add ObjC DOM binding for HTMLMarqeeElement
      
              * fast/dom/wrapper-classes-expected.txt:
              * fast/dom/wrapper-classes.html: HTMLMarqueeElement now is a 
              DOMHTMLMarqueeElement
      
      WebCore:
      
              Reviewed by Adam.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
              Add ObjC DOM binding for HTMLMarqeeElement
      
              - Also adds missing DOMHTMLFramePrivate.
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/objc/DOM.mm:
              (WebCore::createElementClassMap):
              * bindings/objc/DOMHTML.h:
              * bindings/objc/DOMInternal.h:
              * bindings/objc/DOMPrivate.h:
              * bindings/objc/PublicDOMInterfaces.h:
      
      WebKit:
      
              Reviewed by Adam.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
              Add ObjC DOM binding for HTMLMarqeeElement
      
              - Also adds missing DOMHTMLFramePrivate.
      
              * MigrateHeaders.make:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40d22abd
    • hyatt's avatar
      Add layout test for better background dumping. · bb21e287
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb21e287
    • darin's avatar
      LayoutTests: · cc06b695
      darin authored
              Reviewed by Geoff.
      
              - test for <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong
      
              * fast/dom/iframe-document.html: Updated test to expect no document property.
              * fast/dom/iframe-document-expected.txt: Updated.
      
              * fast/forms/focus2.html: Changed test to use ownerDocument instead of document.
      
      WebCore:
      
              Reviewed by Geoff.
      
              - fix <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong
      
              The code on ebay was looking for the "document" property on a iframe.
              We changed that to be the ownerDocument rather than the contentDocument,
              which was not what ebay was expecting. The best fix seems to be removing
              the document property altogether.
      
              Test: fast/dom/iframe-document.html
      
              * bindings/js/kjs_html.h: Remove ElementDocument.
              * bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): Ditto.
      
      WebKit:
      
              Reviewed by Geoff.
      
              * WebInspector/webInspector/treeoutline.js: Use ownerDocument instead of non-standard
              document property.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc06b695
    • kmccullo's avatar
      Reviewed by. · e3681b65
      kmccullo authored
              - Forgot to checkin for fix for rdar://problem/4981886
      
              * fast/dom/open-and-close-by-DOM-expected.txt: Added.
              * fast/dom/open-and-close-by-DOM.html: Added.
              * fast/dom/resources/close.html: Added.
              * fast/dom/resources/middle.html: Added.
              * http/tests/security/local-image-from-remote.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3681b65
  4. 21 May, 2007 2 commits
    • weinig's avatar
      LayoutTests: · 4d7ce9a5
      weinig authored
              Reviewed by Darin.
      
              - update tests and results for http://bugs.webkit.org/show_bug.cgi?id=13803
                to account for the new JSHTMLMarquee that is being autogenerated and
                can now produce a constructor.
      
              * fast/dom/Window/element-constructors-on-window-expected.txt:
              * fast/dom/Window/element-constructors-on-window.html:
              * fast/dom/Window/window-properties-expected.txt:
      
      WebCore:
      
              Reviewed by Darin.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13803
              Autogenerate the JS bindings for the HTMLMarqueeElement.
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              * bindings/js/kjs_css.cpp:
              (KJS::DOMCSSRule::getOwnPropertySlot): Fix possible null pointer issue.
              (KJS::DOMCSSRule::put): Fix possible null pointer issue.
              * bindings/js/kjs_html.cpp:
              (KJS::):
              (KJS::JSHTMLElement::classInfo):
              (KJS::JSHTMLElement::accessors):
              (KJS::JSHTMLElement::getOwnPropertySlot): Fix null pointer issue.
              (KJS::HTMLElementFunction::callAsFunction):
              (KJS::JSHTMLElement::put):
              * bindings/js/kjs_html.h:
              (KJS::JSHTMLElement::):
              * html/HTMLMarqueeElement.cpp:
              (WebCore::HTMLMarqueeElement::start):
              (WebCore::HTMLMarqueeElement::stop):
              * html/HTMLMarqueeElement.h: Add start() and stop() functions.
              * html/HTMLMarqueeElement.idl: Added.
              * page/DOMWindow.idl: Add marquee constructor.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d7ce9a5
    • weinig's avatar
      LayoutTests: · 16885ff7
      weinig authored
              Reviewed by Adam and Darin.
      
              - update results for http://bugs.webkit.org/show_bug.cgi?id=13791
                to account for new JSHTMLElements that are being autogenerated and
                can now produce constructors.
      
              * fast/dom/Window/element-constructors-on-window-expected.txt:
              * fast/dom/Window/window-properties-expected.txt:
      
      WebCore:
      
              Reviewed by Adam and Darin.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13791
              Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement.
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLAnchorElementCustom.cpp:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              * bindings/js/kjs_html.cpp:
              (KJS::):
              (KJS::JSHTMLElement::classInfo):
              (KJS::JSHTMLElement::accessors):
              (KJS::HTMLElementFunction::callAsFunction):
              * bindings/js/kjs_html.h:
              (KJS::JSHTMLElement::):
              * bindings/scripts/CodeGeneratorJS.pm:
              * html/HTMLFrameElement.idl:
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::location):
              * html/HTMLFrameElementBase.h:
              * html/HTMLFrameOwnerElement.h:
              (WebCore::HTMLFrameOwnerElement::contentWindow):
              * html/HTMLIFrameElement.idl:
              * page/DOMWindow.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16885ff7
  5. 18 May, 2007 3 commits
    • hyatt's avatar
      Fix more malformed test cases. · affe5907
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      affe5907
    • weinig's avatar
      LayoutTests: · a211a4ba
      weinig authored
              Reviewed by Geoff.
      
              - update results to account for new JSHTMLElements that are being
                auto-generated and can now produce Constructors.
      
              * fast/dom/Window/element-constructors-on-window-expected.txt:
              * fast/dom/Window/window-properties-expected.txt:
      
      WebCore:
      
              Reviewed by Geoff.
      
              Autogenerate the JS bindings for the HTMLTableElement, HTMLTableCaptionElement,
              HTMLTableCellElement, HTMLTableColElement, HTMLTableRowElement, HTMLTableSectionElement.
      
              * DerivedSources.make:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              (WebCore::createJSHTMLWrapper):
              * bindings/js/kjs_html.cpp:
              (KJS::):
              (KJS::JSHTMLElement::classInfo):
              (KJS::JSHTMLElement::accessors):
              (KJS::HTMLElementFunction::callAsFunction):
              * bindings/js/kjs_html.h:
              (KJS::JSHTMLElement::):
              * html/HTMLTableCaptionElement.idl:
              * html/HTMLTableCellElement.idl:
              * html/HTMLTableColElement.idl:
              * html/HTMLTableElement.idl:
              * html/HTMLTableRowElement.idl:
              * html/HTMLTableSectionElement.idl:
              * page/DOMWindow.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a211a4ba
    • mjs's avatar
      Not Reviewed, buildbot test fix. · 62aca5a3
      mjs authored
              
              - updated results for the last fiew checkins.
              
              * fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt:
              * fast/dom/replaceChild-expected.txt:
              * http/tests/loading/bad-scheme-subframe-expected.txt:
              * webarchive/loading/test-loading-archive-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62aca5a3
  6. 17 May, 2007 1 commit
    • weinig's avatar
      LayoutTests: · 7e935edd
      weinig authored
              Reviewed by Adam.
      
              Tests for <rdar://problem/5201423> REGRESSION: Links in 
              sidebar don't work on Honda website
      
              * fast/dom/anchor-toString-expected.txt: Added.
              * fast/dom/anchor-toString.html: Added.
              * fast/forms/focus2.html:
      
      WebCore:
      
              Reviewed by Adam.
      
              Fix for <rdar://problem/5201423> REGRESSION: Links in 
              sidebar don't work on Honda website
      
              Anchor elements need to have the same behavior for implicit and 
              explicit toString() calls.
      
              Test: fast/dom/anchor-toString.html
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLAnchorElementCustom.cpp: Added.
              (WebCore::JSHTMLAnchorElement::toString):
              * html/HTMLAnchorElement.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e935edd
  7. 16 May, 2007 1 commit
  8. 15 May, 2007 6 commits
    • weinig's avatar
      LayoutTests: · 0d6b1ca0
      weinig authored
              Reviewed by Oliver.
      
              - Yet more tests for http://bugs.webkit.org/show_bug.cgi?id=13722
                Finish testing and fixing the setting of DOM attributes to JS null
      
                Tests for SVG attributes that take a DOMString.
      
              * fast/dom/svg-element-attribute-js-null-expected.txt: Added.
              * fast/dom/svg-element-attribute-js-null.xhtml: Added.
      
      WebCore:
      
              Reviewed by Oliver.
      
              - Patch for http://bugs.webkit.org/show_bug.cgi?id=13722
                Finish testing and fixing the setting of DOM attributes to JS null
      
                Convert JS null to null string for SVG attributes.
      
              Test: fast/dom/svg-element-attribute-js-null.xhtml
      
              * ksvg2/svg/SVGAngle.idl:
              * ksvg2/svg/SVGElement.idl:
              * ksvg2/svg/SVGLength.idl:
              * ksvg2/svg/SVGScriptElement.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d6b1ca0
    • weinig's avatar
      LayoutTests: · a05c3091
      weinig authored
              Reviewed by Oliver.
      
              - More Tests for http://bugs.webkit.org/show_bug.cgi?id=13722
                Finish testing and fixing the setting of DOM attributes to JS null
      
                Tests for CanvasRenderingContext2D attributes that take a DOMString.
      
              * fast/dom/canvasContext2d-element-attribute-js-null-expected.txt: Added.
              * fast/dom/canvasContext2d-element-attribute-js-null.html: Added.
      
      WebCore:
      
              Reviewed by Oliver.
      
              - Patch for http://bugs.webkit.org/show_bug.cgi?id=13722
                Finish testing and fixing the setting of DOM attributes to JS null
      
                Convert JS null to null string for CanvasRenderingContext2D attributes.
      
              Test: fast/dom/canvasContext2d-element-attribute-js-null.html
      
              * html/CanvasRenderingContext2D.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a05c3091
    • weinig's avatar
      LayoutTests: · 0895cdf0
      weinig authored
              Reviewed by Oliver.
      
              - More Tests for http://bugs.webkit.org/show_bug.cgi?id=13722
                Finish testing and fixing the setting of DOM attributes to JS null
      
                Tests for CSSOM attributes that take a DOMString.
      
              * fast/dom/css-element-attribute-js-null-expected.txt: Added.
              * fast/dom/css-element-attribute-js-null.html: Added.
      
      WebCore:
      
              Reviewed by Oliver.
      
              - Second Patch for http://bugs.webkit.org/show_bug.cgi?id=13722
                Finish testing and fixing the setting of DOM attributes to JS null
      
                Convert JS null to null string for remaining CSSOM attributes.
      
              Test: fast/dom/css-element-attribute-js-null.html
      
              * bindings/js/kjs_css.cpp:
              (KJS::DOMCSSStyleDeclaration::put):
              (KJS::DOMMediaList::put):
              (KJS::DOMCSSRule::putValueProperty):
              (KJS::DOMCSSValue::put):
              * css/CSSPageRule.idl:
              * css/CSSRule.idl:
              * css/CSSStyleDeclaration.idl:
              * css/CSSStyleRule.idl:
              * css/CSSValue.idl:
              * css/MediaList.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0895cdf0
    • justing's avatar
      Updating expected results for r21074. · a39edf72
      justing authored
              * css1/cascade/cascade_order-expected.checksum:
              * css1/cascade/cascade_order-expected.png:
              * css2.1/t0402-c71-fwd-parsing-02-f-expected.checksum:
              * css2.1/t0402-c71-fwd-parsing-02-f-expected.png:
              * css2.1/t0505-c16-descendant-01-e-expected.checksum:
              * css2.1/t0505-c16-descendant-01-e-expected.png:
              * css2.1/t050803-c14-classes-00-e-expected.checksum:
              * css2.1/t050803-c14-classes-00-e-expected.png:
              * css2.1/t0509-c15-ids-01-e-expected.checksum:
              * css2.1/t0509-c15-ids-01-e-expected.png:
              * css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
              * css2.1/t0805-c5518-brdr-t-01-e-expected.png:
              * css2.1/t0805-c5519-brdr-r-02-e-expected.checksum:
              * css2.1/t0805-c5519-brdr-r-02-e-expected.png:
              * css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
              * css2.1/t0805-c5520-brdr-b-01-e-expected.png:
              * css2.1/t0805-c5521-brdr-l-02-e-expected.checksum:
              * css2.1/t0805-c5521-brdr-l-02-e-expected.png:
              * css2.1/t1205-c563-list-type-00-b-expected.checksum:
              * css2.1/t1205-c563-list-type-00-b-expected.png:
              * css2.1/t1205-c564-list-img-00-b-g-expected.checksum:
              * css2.1/t1205-c564-list-img-00-b-g-expected.png:
              * fast/backgrounds/repeat/noRepeatCorrectClip-expected.checksum:
              * fast/backgrounds/repeat/noRepeatCorrectClip-expected.png:
              * fast/block/float/014-expected.checksum:
              * fast/block/float/014-expected.png:
              * fast/css/001-expected.checksum:
              * fast/css/001-expected.png:
              * fast/css/css2-system-fonts-expected.checksum:
              * fast/css/css2-system-fonts-expected.png:
              * fast/doctypes/001-expected.checksum:
              * fast/doctypes/001-expected.png:
              * fast/doctypes/002-expected.checksum:
              * fast/doctypes/002-expected.png:
              * fast/doctypes/003-expected.checksum:
              * fast/doctypes/003-expected.png:
              * fast/doctypes/004-expected.checksum:
              * fast/doctypes/004-expected.png:
              * fast/dom/Window/window-onFocus-expected.checksum:
              * fast/dom/Window/window-onFocus-expected.png:
              * fast/events/keydown-1-expected.checksum:
              * fast/events/keydown-1-expected.png:
              * fast/lists/002-expected.checksum:
              * fast/lists/002-expected.png:
              * fast/lists/003-expected.checksum:
              * fast/lists/003-expected.png:
              * fast/lists/005-expected.checksum:
              * fast/lists/005-expected.png:
              * fast/lists/007-expected.checksum:
              * fast/lists/007-expected.png:
              * fast/lists/008-expected.checksum:
              * fast/lists/008-expected.png:
              * fast/lists/big-list-marker-expected.checksum:
              * fast/lists/big-list-marker-expected.png:
              * fast/lists/dynamic-marker-crash-expected.checksum:
              * fast/lists/dynamic-marker-crash-expected.png:
              * fast/lists/item-not-in-list-line-wrapping-expected.checksum:
              * fast/lists/item-not-in-list-line-wrapping-expected.png:
              * fast/lists/marker-image-error-expected.checksum:
              * fast/lists/marker-image-error-expected.png:
              * fast/lists/ol-display-types-expected.checksum:
              * fast/lists/ol-display-types-expected.png:
              * fast/lists/scrolled-marker-paint-expected.checksum:
              * fast/lists/scrolled-marker-paint-expected.png:
              * fast/overflow/overflow-rtl-expected.checksum:
              * fast/overflow/overflow-rtl-expected.png:
              * fast/repaint/list-marker-2-expected.checksum:
              * fast/repaint/list-marker-2-expected.png:
              * fast/repaint/list-marker-expected.checksum:
              * fast/repaint/list-marker-expected.png:
              * fast/selectors/001-expected.checksum:
              * fast/selectors/001-expected.png:
              * fast/selectors/013-expected.checksum:
              * fast/selectors/013-expected.png:
              * fast/selectors/015-expected.checksum:
              * fast/selectors/015-expected.png:
              * fast/selectors/166-expected.checksum:
              * fast/selectors/166-expected.png:
              * tables/mozilla/bugs/bug23235-expected.checksum:
              * tables/mozilla/bugs/bug23235-expected.png:
              * tables/mozilla/bugs/bug30692-expected.checksum:
              * tables/mozilla/bugs/bug30692-expected.png:
              * tables/mozilla/bugs/bug3191-expected.checksum:
              * tables/mozilla/bugs/bug3191-expected.png:
              * tables/mozilla/marvin/backgr_index-expected.checksum:
              * tables/mozilla/marvin/backgr_index-expected.png:
              * tables/mozilla/marvin/backgr_layers-opacity-expected.checksum:
              * tables/mozilla/marvin/backgr_layers-opacity-expected.png:
              * tables/mozilla_expected_failures/bugs/bug1010-expected.checksum:
              * tables/mozilla_expected_failures/bugs/bug1010-expected.png:
              * tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
              * tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a39edf72
    • weinig's avatar
      LayoutTests: · 9b41ea8f
      weinig authored
              Reviewed by Darin.
      
              - Test for http://bugs.webkit.org/show_bug.cgi?id=13722
                Finish testing and fixing the setting of DOM attributes to JS null
      
                Tests for Core DOM attributes.
      
              * fast/dom/coreDOM-element-attribute-js-null-expected.txt: Added.
              * fast/dom/coreDOM-element-attribute-js-null.xhtml: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              - Patch for http://bugs.webkit.org/show_bug.cgi?id=13722
                Finish testing and fixing the setting of DOM attributes to JS null
      
                Convert JS null to null string for remaining Core DOM attributes.
      
              Test: fast/dom/coreDOM-element-attribute-js-null.xhtml
      
              * dom/Attr.cpp:
              (WebCore::Attr::setValue): Don't throw an expection for null values as this
              is not in the spec and Firefox does not do it either.
              * dom/Attr.idl:
              * dom/CharacterData.idl:
              * dom/ProcessingInstruction.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b41ea8f
    • andersca's avatar
      LayoutTests: · 6639238f
      andersca authored
              Reviewed by Maciej.
      
              <rdar://problem/5183685>
              http://bugs.webkit.org/show_bug.cgi?id=13301
              ASSERT or null value when trying to use a getter defined on a window object
              
              Add tests.
      
              * fast/dom/getter-on-window-object-expected.txt: Added.
              * fast/dom/getter-on-window-object.html: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              <rdar://problem/5183685>
              http://bugs.webkit.org/show_bug.cgi?id=13301
              ASSERT or null value when trying to use a getter defined on a window object
      
              Handle the case where the value returned is a getter/setter object.
              
              * bindings/js/kjs_window.cpp:
              (KJS::Window::getOverridePropertySlot):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6639238f
  9. 14 May, 2007 1 commit
    • weinig's avatar
      LayoutTests: · 650fde25
      weinig authored
              Reviewed by Alice.
      
              - Tests for http://bugs.webkit.org/show_bug.cgi?id=13541
                REGRESSION: Setting a DOMString attribute to JS null in the 
                JS bindings should default to converting to the empty string
      
              * fast/dom/document-attribute-js-null-expected.txt: Added.
              * fast/dom/document-attribute-js-null.html: Added.
              * fast/dom/element-attribute-js-null-expected.txt: Added.
              * fast/dom/element-attribute-js-null.html: Added.
              * fast/forms/input-null-expected.txt: Removed.
              * fast/forms/input-null.html: Removed.
      
      WebCore:
      
              Reviewed by Alice!
      
              - Patch for http://bugs.webkit.org/show_bug.cgi?id=13541
                REGRESSION: Setting a DOMString attribute to JS null in the 
                JS bindings should default to converting to the empty string
      
                Convert JS null to the empty string when passing it to an attribute that takes
                a DOMString.
      
              Test: fast/dom/document-attribute-js-null.html
              Test: fast/dom/element-attribute-js-null.html
      
              * bindings/js/kjs_dom.cpp:
              (KJS::DOMNode::putValueProperty):
              * bindings/js/kjs_html.cpp:
              (KJS::JSHTMLDocument::putValueProperty):
              (KJS::JSHTMLElement::objectSetter):
              (KJS::JSHTMLElement::embedSetter):
              (KJS::JSHTMLElement::tableSetter):
              (KJS::JSHTMLElement::tableCaptionSetter):
              (KJS::JSHTMLElement::tableColSetter):
              (KJS::JSHTMLElement::tableSectionSetter):
              (KJS::JSHTMLElement::tableRowSetter):
              (KJS::JSHTMLElement::tableCellSetter):
              (KJS::JSHTMLElement::frameSetSetter):
              (KJS::JSHTMLElement::frameSetter):
              (KJS::JSHTMLElement::iFrameSetter):
              (KJS::JSHTMLElement::marqueeSetter):
              (KJS::JSHTMLElement::putValueProperty):
              * bindings/js/kjs_html.h:
              * dom/Document.idl:
              * dom/Node.idl:
              * html/HTMLAnchorElement.idl:
              * html/HTMLAppletElement.idl:
              * html/HTMLAreaElement.idl:
              * html/HTMLBRElement.idl:
              * html/HTMLBaseElement.idl:
              * html/HTMLBaseFontElement.idl:
              * html/HTMLBlockquoteElement.idl:
              * html/HTMLBodyElement.idl:
              * html/HTMLButtonElement.idl:
              * html/HTMLDivElement.idl:
              * html/HTMLDocument.idl:
              * html/HTMLElement.idl:
              * html/HTMLEmbedElement.idl:
              * html/HTMLFontElement.idl:
              * html/HTMLFormElement.idl:
              * html/HTMLFrameElement.idl:
              * html/HTMLFrameSetElement.idl:
              * html/HTMLHRElement.idl:
              * html/HTMLHeadElement.idl:
              * html/HTMLHeadingElement.idl:
              * html/HTMLHtmlElement.idl:
              * html/HTMLIFrameElement.idl:
              * html/HTMLImageElement.idl:
              * html/HTMLInputElement.idl:
              * html/HTMLIsIndexElement.idl:
              * html/HTMLLIElement.idl:
              * html/HTMLLabelElement.idl:
              * html/HTMLLegendElement.idl:
              * html/HTMLLinkElement.idl:
              * html/HTMLMapElement.idl:
              * html/HTMLMetaElement.idl:
              * html/HTMLModElement.idl:
              * html/HTMLOListElement.idl:
              * html/HTMLObjectElement.idl:
              * html/HTMLOptGroupElement.idl:
              * html/HTMLOptionElement.idl:
              * html/HTMLParagraphElement.idl:
              * html/HTMLParamElement.idl:
              * html/HTMLQuoteElement.idl:
              * html/HTMLScriptElement.idl:
              * html/HTMLSelectElement.idl:
              * html/HTMLStyleElement.idl:
              * html/HTMLTableCaptionElement.idl:
              * html/HTMLTableCellElement.idl:
              * html/HTMLTableColElement.idl:
              * html/HTMLTableElement.idl:
              * html/HTMLTableRowElement.idl:
              * html/HTMLTableSectionElement.idl:
              * html/HTMLTextAreaElement.idl:
              * html/HTMLTitleElement.idl:
              * html/HTMLUListElement.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      650fde25
  10. 11 May, 2007 2 commits
    • ggaren's avatar
      LayoutTests: · 2344a57d
      ggaren authored
              Reviewed by Darin Adler.
      
              Updated test a little bit now that +[WebScriptObject scriptObjectForJSObject:frame:]
              is gone.
      
              * fast/dom/wrapper-round-tripping.html:
      
      WebCore:
      
              Reviewed by Darin Adler.
      
              Removed +[WebScriptObject scriptObjectForJSObject:frame:] because the
              WebScriptObject API has some serious limitations that make it not ready
              to be used everywhere the C API is used. Hopefully we can add a good
              ObjC API in the future that doesn't suffer from this problem.
              
              Preliminary notes about these limitations are in <rdar://problem/4876466>.
      
              * bindings/objc/WebScriptObject.mm:
              * bindings/objc/WebScriptObjectPendingPublic.h:
      
      WebKitTools:
      
              Reviewed by Darin Adler.
      
              Updated test now that +[WebScriptObject scriptObjectForJSObject:frame:] 
              is gone.
      
              * DumpRenderTree/DumpRenderTree.m:
              (-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]):
              (+[LayoutTestController isSelectorExcludedFromWebScript:]):
              (+[LayoutTestController webScriptNameForSelector:]):
              (-[LayoutTestController testWrapperRoundTripping:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2344a57d
    • bdash's avatar
      2007-05-11 Mitz Pettel <mitz@webkit.org> · d7878ff0
      bdash authored
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=13635
                REGRESSION: Cannot log in to webmail.co.za account
      
              Test: fast/dom/HTMLOptionElement/option-text.html
      
              Despite the specification that the 'text' attribute of HTMLOptionElement
              is "the text contained within the option element", other browsers return
              the text as displayed in the list box or popup, which is without leading,
              trailing and collapsible whitespace.
      
              * html/HTMLOptionElement.cpp:
              (WebCore::HTMLOptionElement::text): Moved the code to trim and collapse
              whitespace and replace backslashes with the currency symbol into this
              function.
              (WebCore::HTMLOptionElement::optionText): Left only the code that adds
              the leading spaces for grouped options. Removed code that, in quirks mode,
              displayed the label if the option element contained no text. That behavior
              did not match WinIE and the description of the expected behavior in
              fast/forms/HTMLOptionElement_label06.html.
      
      2007-05-11  Mitz Pettel  <mitz@webkit.org>
      
              Reviewed by Darin.
      
              - test and updated results for http://bugs.webkit.org/show_bug.cgi?id=13635
                REGRESSION: Cannot log in to webmail.co.za account
      
              * fast/dom/HTMLOptionElement/option-text-expected.txt: Added.
              * fast/dom/HTMLOptionElement/option-text.html: Added.
              * fast/forms/HTMLOptionElement_label06-expected.checksum:
              * fast/forms/HTMLOptionElement_label06-expected.png:
              * fast/forms/HTMLOptionElement_label06-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7878ff0
  11. 10 May, 2007 2 commits
    • mjs's avatar
      LayoutTests: · 8d620d5e
      mjs authored
              Reviewed by Oliver.
              
              - new test case for:
              <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load)
              <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)
      
              (The test case covers both scenarios.)
      
              * http/tests/misc/frame-access-during-load-expected.checksum: Added.
              * http/tests/misc/frame-access-during-load-expected.png: Added.
              * http/tests/misc/frame-access-during-load-expected.txt: Added.
              * http/tests/misc/frame-access-during-load.html: Added.
      
              - test results beneficially or harmlessly changed as a result of the above fixes
      
              * css2.1/t0801-c412-hz-box-00-b-a-expected.checksum:
              * css2.1/t0801-c412-hz-box-00-b-a-expected.png:
              * css2.1/t0801-c412-hz-box-00-b-a-expected.txt: This reflects an <object> containing
              an image now creating an image renderer.
      
              * dom/xhtml/level2/html/HTMLIFrameElement11-expected.txt: This is updated to a slightly
              less bad failure for access to a frame that's not loaded yet.
      
              The following test results now reflect the frame removal that the test was testing:
              
              * fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum:
              * fast/dom/clientWidthAfterDocumentIsRemoved-expected.png:
              * fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt:
              * fast/dom/replaceChild-expected.checksum:
              * fast/dom/replaceChild-expected.png:
              * fast/dom/replaceChild-expected.txt:
      
              The following tests results now reflect empty document content for iframes that never load anything:
              
              * fast/events/focusingUnloadedFrame-expected.txt:
              * tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt:
              * tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt:
      
      WebCore:
      
              Reviewed by Oliver.
      
              - WebCore part of fix for:
              <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load)
              <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)
      
              The basic approach is to have Frames start out containing an empty document instead of absolutely nothing,
              so there is no need to initialize them on demand. Various side effects of that cause both of these bugs.
              
              However, this caused many regressions so I had to fix the fallout.
              
              * WebCore.exp: fix symbol exports
              * bindings/js/kjs_window.cpp:
              (KJS::createNewWindow): useless "created" bool (we don't need it here)
              (KJS::WindowFunc::callAsFunction): detect if we created a new frame, because if so,
              we need to initialize the domain (can't count on it not having a document), also
              don't try to make a new document for it.
              Also, stop properly.
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::CSSStyleSelector): don't count on document having a view here
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::isImageType): Ask client, to match how other <object> renderer
              decisions are made.
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::FrameLoader): Initialize new data members
              (WebCore::FrameLoader::init): Do the slightly tricky sequence of steps to properly make
              an empty document with everything hooked up.
              (WebCore::FrameLoader::createWindow): Added "created" bool.
              (WebCore::FrameLoader::stopLoading): (whitespace change)
              (WebCore::FrameLoader::begin): Don't try to create an empty document.
              (WebCore::FrameLoader::finishedParsing): If creating an initial empty document, don't
              do any of this work.
              (WebCore::FrameLoader::checkCompleted): Do checkLoadComplete() as well.
              (WebCore::FrameLoader::baseURL): don't check for null document
              (WebCore::FrameLoader::baseTarget): ditto
              (WebCore::FrameLoader::completeURL): ditto
              (WebCore::FrameLoader::didTellBridgeAboutLoad): ditto
              (WebCore::FrameLoader::scheduleLocationChange): determine duringLoad differently; doc won't
              be null.
              (WebCore::FrameLoader::gotoAnchor): don't check for null document
              (WebCore::FrameLoader::canTarget): don't check for null document
              (WebCore::FrameLoader::stopForUserCancel): new method for explicit stops like window.stop().
              (WebCore::FrameLoader::transitionToCommitted): check for pre-loaded state properly
              (WebCore::FrameLoader::createEmptyDocument): removed
              (WebCore::FrameLoader::checkLoadCompleteForThisFrame): don't send delegate callbacks when making initial
              doc.
              (WebCore::FrameLoader::tokenizerProcessedData): Assume document; just checkCompleted now that it
              does checkLoadComplete.
              (WebCore::FrameLoader::receivedMainResourceError): assume document
              (WebCore::FrameLoader::saveDocumentState): Assume there's a document except during initial load
              (WebCore::FrameLoader::mainReceivedCompleteError): do checkCompleted, not checkLoadComplete
              (WebCore::FrameLoader::continueLoadWithData): assume document
              * loader/FrameLoader.h:
              * loader/MainResourceLoader.cpp:
              (WebCore::MainResourceLoader::receivedError): Add more ref protection and do things in a slightly
              different order.
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::document): don't force document creation, just assert there is one.
              * page/Frame.cpp:
              (WebCore::Frame::init): Added init method.
              (WebCore::Frame::pageDestroyed): when a frame is removed, make sure to check if the parent is
              done loading.
              * page/Frame.h:
              * page/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): No need to force
              document.
              (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): ditto
              * platform/graphics/svg/SVGImage.cpp:
              (WebCore::SVGImage::dataChanged): init the frame
              * rendering/RenderPart.cpp:
              (WebCore::RenderPart::updateWidgetPosition): If a subframe needs layout, then lay it out even
              if the bounds did not change; the content size might be wrong.
              * rendering/RenderTreeAsText.cpp:
              (WebCore::externalRepresentation): Don't crash if the frame lacks a view.
      
      WebKit:
      
              Reviewed by Oliver.
      
              - WebKit part of fix for:
              <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load)
              <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)
      
              The basic approach is to have Frames start out containing an empty document instead of absolutely nothing,
              so there is no need to initialize them on demand. Various side effects of that cause both of these bugs.
              
              However, this caused many regressions so I had to fix the fallout.
      
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::takeFocus): Avoid focus cycle problems (can happen in DumpRenderTree
              with initial empty document now).
              * WebCoreSupport/WebFrameBridge.mm:
              (-[WebFrameBridge finishInitializingWithPage:frameName:frameView:ownerElement:]): init the frame.
              (-[WebFrameBridge determineObjectFromMIMEType:URL:]): return image type when appropriate
              * WebView/WebFrame.mm:
              (-[WebFrame stopLoading]): use stopForUserCancel().
              * WebView/WebFrameView.mm:
              (-[WebFrameView _makeDocumentViewForDataSource:]): assume html when no mime type available.
              * WebView/WebView.mm:
              (-[WebView becomeFirstResponder]): Track whether we are becoming first responder from
              outside the view.
              (-[WebView _becomingFirstResponderFromOutside]): Return this value.
              * WebView/WebViewInternal.h:
      
      WebKitTools:
      
              Reviewed by Oliver.
              
              - don't clear events whenever an EventSendingController goes away, only do it at predictable times, 
              since destroying a subframe can make one go away
              
              (Discovered while fixing:
              
              <rdar://problem/5063277> blank screen after login to Citibank Online (accessing document before frame starts loading cancels load)
              <rdar://problem/5159541> REGRESSION (r20972): Wall Street Journal pages replaced by advertisements (13465)
      
              * DumpRenderTree/DumpRenderTree.m:
              (runTest): explicitly clear saved events after every page load
              * DumpRenderTree/EventSendingController.h:
              * DumpRenderTree/EventSendingController.m:
              (-[EventSendingController dealloc]): don't clear saved events here...
              (+[EventSendingController clearSavedEvents]): do it here
              * Scripts/check-for-global-initializers:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d620d5e
    • ggaren's avatar
      LayoutTests: · 54f8e1b6
      ggaren authored
              Reviewed by Maciej Stachowiak.
              
              Tests for more fix-ups to the WebScriptObject/WebScripting APIs, related to
              <rdar://problem/5140447> API for fetching JSGlobalContextRef from WebView 
              or WebFrame
      
              * fast/dom/wrapper-classes-expected.txt:
              * fast/dom/wrapper-classes.html: Added cases to test the wrapper classes
              for different data types sent across the JS/ObjC bridge.
              * fast/dom/wrapper-round-tripping-expected.txt: Added.
              * fast/dom/wrapper-round-tripping.html: Added. New test to verify that
              you can round-trip between a JSObjectRef and a WebScriptObject.
      
      WebCore:
      
              Reviewed by Maciej Stachowiak.
              
              More fix-ups to the WebScriptObject/WebScripting APIs, related to
              <rdar://problem/5140447> API for fetching JSGlobalContextRef from WebView 
              or WebFrame
      
              * bindings/objc/WebScriptObject.h: Fully specified the surprising rules for
              type conversion between JavaScript and ObjC.
              * bindings/objc/WebScriptObject.mm: Added up-call accessor to WebFrame.
              This is kind of stinky, but I'm OK with it because eventually all of this
              code should move up into WebKit.
              (+[WebScriptObject scriptObjectForJSObject:frame:]):
              (-[WebScriptObject valueForKey:]):
              (-[WebScriptObject JSObject]): 
                  - Added _rootObject check because if _rootObject returns NULL it means 
                  that _imp is no longer GC protected, so it's not safe to use. 
                  - Added _isSafeScript check because that's what WebScriptObject methods
                  typically do, even though the value of doing so isn't clear to me.
              * bindings/objc/WebScriptObjectPendingPublic.h: Added WebFrame* parameter
              to -scriptObjectForJSObject:. This is required to wrap JS objects that
              are not already in the wrapper cache. It would be nice to remove this
              limitation of WebScriptObject some day.
              * page/mac/FrameMac.mm:
              (WebCore::Frame::cleanupPlatformScriptObjects): Force removal of m_windowScriptObject
              from the cache, to avoid retrieving the m_windowScriptObject from the previous
              page on a new page load. (It would be non-functional in that case.)
      
      WebKitTools:
      
              Reviewed by Maciej Stachowiak.
              
              Added support for testing ObjC/JS type bridging.
              
              Added ASSERT that -JSObject returns nil when the underlying JSObject
              is no longer GC protected.
      
              * DumpRenderTree/DumpRenderTree.m:
              (returnThisCallback):
              (returnThisClass):
              (-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]):
              (+[LayoutTestController isSelectorExcludedFromWebScript:]):
              (+[LayoutTestController webScriptNameForSelector:]):
              (-[LayoutTestController accessStoredWebScriptObject]):
              (-[LayoutTestController testWrapperRoundTripping]):
              (-[LayoutTestController objCClassNameOf:]):
              (-[LayoutTestController objCObjectOfClass:]):
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54f8e1b6
  12. 08 May, 2007 2 commits
    • ggaren's avatar
      LayoutTests: · ec17dbf7
      ggaren authored
              Reviewed by Darin Adler.
      
              Added test to verify that you get back the same JS/ObjC wrapper when
              you access the same object twice.
      
              * fast/dom/wrapper-identity-expected.txt: Added.
              * fast/dom/wrapper-identity.html: Added.
      
      WebCore:
      
              Reviewed by Darin Adler.
              
              More fix-ups to the WebScriptObject/WebScripting APIs, related to
              <rdar://problem/5140447> API for fetching JSGlobalContextRef from WebView 
              or WebFrame
              
              1. Added -scriptObjectForJSObject: SPI so you can bridge back from JavaScriptCore
              to WebScriptObject.
              
              2. Fixed WebScriptObject bridging so that you always get the same WebScriptObject
              for a JSObject (like in the DOM). This makes -scriptObjectForJSObject: a
              lot more coherent as an API.
      
              * bindings/objc/DOMInternal.mm: Renamed wrapperCache to DOMWrapperCache
              to distinguish from the JSWrapperCache. Added typedef for readability.
              (WebCore::getDOMWrapper):
              (WebCore::addDOMWrapper):
              (WebCore::removeDOMWrapper):
              * bindings/objc/WebScriptObject.mm: Added JSWrapperCache, which works just
              like the DOMWrapperCache.
              (WebCore::getJSWrapper):
              (WebCore::addJSWrapper):
              (WebCore::removeJSWrapper):
              (WebCore::createJSWrapper):
              (+[WebScriptObject scriptObjectForJSObject:]): This is the new API. It attempts
              to return a specific DOM wrapper object, or, barring that, it returns a 
              generic WebScriptObject.
              (+[WebScriptObject scriptObjectForJSObject:originRootObject:rootObject:]):
              Added this method to support our old WebScriptObject security and leak 
              checking model, even though it doesn't work very well. 
              (-[WebScriptObject _setImp:originRootObject:rootObject:]):
              (-[WebScriptObject dealloc]):
              (-[WebScriptObject finalize]):
              (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
              * bindings/objc/WebScriptObjectPendingPublic.h:
              * bindings/objc/WebScriptObjectPrivate.h:
              * page/mac/FrameMac.mm:
              (WebCore::Frame::windowScriptObject): Changed to use the new API. This
              fixes a bug where the object sent to -windowScriptObjectAvailable: and returned
              from -windowScriptObject could not be round-tripped.
      
      WebKitTools:
      
              Reviewed by Darin Adler.
              
              Added support for testing ObjC object identity.
              
              Added ASSERT to verify that you can round-trip the object passed to you
              in -didClearWindowObject:forFrame:.
      
              * DumpRenderTree/DumpRenderTree.m:
              (-[WaitUntilDoneDelegate webView:didClearWindowObject:forFrame:]):
              (+[LayoutTestController isSelectorExcludedFromWebScript:]):
              (+[LayoutTestController webScriptNameForSelector:]):
              (-[LayoutTestController accessStoredWebScriptObject]):
              (-[LayoutTestController objCIdentityIsEqual::]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec17dbf7
    • ap's avatar
      Reviewed by Hyatt. · 104861ed
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=13480
              window.Attr is undefined
      
              Test: fast/dom/Window/attr-constructor.html
      
              * dom/Attr.idl:
              * dom/CDATASection.idl:
              * dom/CharacterData.idl:
              * dom/Comment.idl:
              * dom/DOMImplementation.idl:
              * dom/DocumentType.idl:
              * dom/Entity.idl:
              * dom/EntityReference.idl:
              * dom/Notation.idl:
              * dom/ProcessingInstruction.idl:
              * dom/Text.idl:
              Added GenerateConstructor.
      
              * page/DOMWindow.idl: Added constructor properties for DOM interfaces.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21308 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      104861ed
  13. 07 May, 2007 2 commits
    • darin's avatar
      Removed files. Not sure why they didn't get removed before. · 67506875
      darin authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67506875
    • darin's avatar
      LayoutTests: · e15d96b7
      darin authored
              Reviewed by Hyatt.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=13602
                Amazon product pages keep repainting over and over again
      
              * fast/dom/HTMLElement/set-inner-outer-optimization-expected.txt: Added.
              * fast/dom/HTMLElement/set-inner-outer-optimization.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=13602
                Amazon product pages keep repainting over and over again
      
              Optimize setInnerHTML, setOuterHTML, and setInnerText so they don't change the DOM at all
              if they don't need to.
      
              Test: fast/dom/HTMLElement/set-inner-outer-optimization.html
      
              * html/HTMLElement.cpp:
              (WebCore::equal): Added. Helper function that compares two Text nodes or two NamedAttrMap
              attribute maps.
              (WebCore::shallowEqual): Added. Helper function that compares two Element nodes or two
              arbitrary nodes.
              (WebCore::replaceChildrenWithFragment): Added. Helper function used by setInnerHTML and
              setInnerText. Optimizes the cases where all the nodes are the same, where both the current
              and the new content are single text nodes, and where the current content is a single node
              that can be replaced with replaceChild.
              (WebCore::replaceChildrenWithText): Added. Helper function used by setInnerText. Optimizes
              the case where the current content is a single text node or a single node that can be
              replaced with replaceChild.
              (WebCore::HTMLElement::setInnerHTML): Changed to call replaceChildrenWithFragment.
              (WebCore::HTMLElement::setOuterHTML): Added special case to optimize when the new content
              exactly matches the current node.
              (WebCore::HTMLElement::setInnerText): Changed to call replaceChildrenWithText in a few
              cases instead of doing removeChildren/appendChild. Changed code that was using
              DeprecatedString to instead use String. Changed general case to use a document fragment
              and replaceChildrenWithFragment.
      
              * dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent):
              Fixed bug where we would not dispatch the DOMSubtreeModified event unless someone
              was registered for the DOMCharacterDataModified event. Caused trouble in the test.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e15d96b7
  14. 28 Apr, 2007 2 commits
    • ap's avatar
      Reviewed by Darin. · e79b3398
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=13514
              REGRESSION (r20997-21003): Crash in WebCore::Node::document
      
              Test: fast/dom/NodeList/childNodes-reset-cache.html
      
              * dom/Node.cpp:
              (WebCore::Node::notifyLocalNodeListsChildrenChanged): Reset the common caches for child node
              lists. We cannot rely on notifications, since there may be no list objects left around.
      
              * dom/ChildNodeList.cpp:
              (WebCore::ChildNodeList::rootNodeChildrenChanged):
              * dom/ChildNodeList.h:
              Override rootNodeChildrenChanged() with an empty implementation, now that caches are reset
              in Node::notifyLocalNodeListsChildrenChanged().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21169 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e79b3398
    • darin's avatar
      LayoutTests: · c8537b58
      darin authored
              Reviewed by Adele.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=6216
                REGRESSION: getElementsByTagNameNS with empty namespace doesn't work
      
              * fast/dom/namespaces-1-expected.txt: Added.
              * fast/dom/namespaces-1.html: Added.
      
      WebCore:
      
              Reviewed by Adele.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=6216
                REGRESSION: getElementsByTagNameNS with empty namespace doesn't work
      
              * dom/Node.cpp:
              (WebCore::TagNodeList::TagNodeList): Changed parameter to PassRefPtr, tweaked formatting.
              (WebCore::TagNodeList::item): Tweaked formatting.
              (WebCore::TagNodeList::nodeMatches): Tweaked formatting.
              (WebCore::Node::setPrefix): Tweaked formatting.
              (WebCore::Node::getElementsByTagNameNS): Added special case to turn empty namespaces into
              null namespaces.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21167 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8537b58
  15. 26 Apr, 2007 2 commits
  16. 21 Apr, 2007 2 commits
    • ap's avatar
      2007-04-21 Lamar Goddard <lamargoddard@gmail.com> · ccd29fda
      ap authored
              Reviewed by Darin.
      
              Fix for http://bugs.webkit.org/show_bug.cgi?id=5262
              <rdar://problem/5018778>
              XMLSerializer drops Namespace information
      
      WebCore:
              Updated WebCore::markup to output namespace information for elements/attributes whose namespace information
              doesn't appear in its scope in the output.
      
              * WebCore/editing/markup.cpp:
              (WebCore::createMarkup(const Node*, ...)): Changed call to WebCore::markup to match parameters
              (WebCore::markup): Changed recursive call to match tree structure, removed ASSERT and no longer needed includeSiblings parameter.
              (WebCore::startMarkup): Added optional parameter to track namespaces in the current scope.
              (WebCore::addNamespace): Function to add namespace information to markup.
              (WebCore::shouldAddNamespaceAttr):
              (WebCore::shouldAddNamespaceElem): Functions that test whether namespace information should be added for a given node.
              * WebCore/dom/Document.idl:
              (createElementNS):
              (createAttributeNS):
              (getElementsByTagNameNS): Added [ConvertNullToNullString] to namespaceURI parameter.
              * WebCore/dom/Node.cpp:
              (Node::getElementsByTagNameNS): removed test for namespaceURI being null as null can be a valid namespace.
      
      LayoutTests:
              * fast/dom/serialize-nodes-expected.txt: Added.
              * fast/dom/serialize-nodes.xhtml: Added.
              * dom/xhtml/level3/core/nodeisequalnode14-expected.txt: This test fails because 
              createAttribute is supposed to create an Attr with localName of null.
              * dom/xhtml/level3/core/nodeisequalnode15-expected.txt: Now succeeds.
              * fast/innerHTML/004-expected.txt: Added namespace information to head and body nodes
              as xhtml nodes now serialize with namespace information.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccd29fda
    • bdash's avatar
      2007-04-21 Mitz Pettel <mitz@webkit.org> · 1c0caa7f
      bdash authored
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=13417
                Repro crash when the first argument to getMatchedCSSRules is not an element
      
              Test: fast/dom/Window/getMatchedCSSRules-null-crash.html
      
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::styleRulesForElement): Added null check.
      
      2007-04-21  Mitz Pettel  <mitz@webkit.org>
      
              Reviewed by Darin.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=13417
                Repro crash when the first argument to getMatchedCSSRules is not an element
      
              * fast/dom/Window/getMatchedCSSRules-null-crash-expected.txt: Added.
              * fast/dom/Window/getMatchedCSSRules-null-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c0caa7f