1. 24 May, 2007 4 commits
  2. 23 May, 2007 11 commits
    • hyatt's avatar
      Add a table test for comment nodes. · fe679e1b
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe679e1b
    • hyatt's avatar
      Land optgroup DTD test. · c1f254d0
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1f254d0
    • hyatt's avatar
      Add gigantic z-index test. · e64a85d6
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e64a85d6
    • ddkilzer's avatar
      LayoutTests: · 27a28d44
      ddkilzer authored
              Reviewed by David Hyatt.
      
              - tests for http://bugs.webkit.org/show_bug.cgi?id=13563
                REGRESSION: Crash loading message in Yahoo! Mail
      
              * fast/css/stale-style-selector-crash-1-expected.txt: Added.
              * fast/css/stale-style-selector-crash-1.html: Added.
              * fast/css/stale-style-selector-crash-2-expected.txt: Added.
              * fast/css/stale-style-selector-crash-2.html: Added.
      
      WebCore:
      
              Reviewed by David Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=13563
                REGRESSION: Crash loading message in Yahoo! Mail
      
              Tests: fast/css/stale-style-selector-crash-1.html
                     fast/css/stale-style-selector-crash-2.html
      
              * dom/Document.cpp:
              (WebCore::Document::Document): Initialize the m_didCalculateStyleSelector
              flag to 'false'.
              (WebCore::Document::updateStyleSelector): Do not bail out if we have ever
              calculated a non-trivial style selector, even if at the moment we are
              pending style sheets. We could have calculated a non-trivial selector
              already either because at some point there were no pending style sheets
              (so the currently pending ones were added dynamically) or because we were
              forced to do a layout ignoring pending style sheets. Either way, once
              there is a style selector, we need to keep it up to date, otherwise we can
              crash under recalcStyle() during updateRendering() or simply not recalculate
              style correctly for dynamic changes.
              (WebCore::Document::recalcStyleSelector): Set m_didCalculateStyleSelector
              to 'true' when creating a new style selector.
              * dom/Document.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27a28d44
    • darin's avatar
      LayoutTests: · 258af4a1
      darin authored
              Reviewed by Hyatt.
      
              - updated the many tests with an extra newline or two at the end
                because of the bug where plain-text serialization will consider
                nodes that are not rendered
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix problems where unrendered nodes were affecting on plain text serialization
      
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::advance): Don't call handleXXX functions or exitNode for
              nodes without renderers.
              (WebCore::shouldEmitNewlineAfterNode): Only consider rendered nodes when deciding
              if this is the last node in the document.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      258af4a1
    • kmccullo's avatar
      LayoutTests: · ef9bbdef
      kmccullo authored
              Reviewed by Darin.
      
              Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of 
              the rest of HTMLElement
      
              - Corrects prototype chain for JSHTMLDocument and adds test
                for HTMLFormElement.
      
              * fast/dom/prototype-chain-expected.txt:
              * fast/dom/prototype-chain.html:
      
      WebCore:
      
              Reviewed by Darin.
      
              - rdar://problem/5183523
              - We now check the document's URL to see if it can load a resource in the case of a URL click, instead of checking the referrer, which is blank for local files.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::load):
              (WebCore::FrameLoader::open):
              * platform/PlatformString.h:
              (WebCore::debugPrintString):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef9bbdef
    • weinig's avatar
      LayoutTests: · 661a37fc
      weinig authored
              Reviewed by Darin.
      
              Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of 
              the rest of HTMLElement
      
              - Corrects prototype chain for JSHTMLDocument and adds test
                for HTMLFormElement.
      
              * fast/dom/prototype-chain-expected.txt:
              * fast/dom/prototype-chain.html:
      
      WebCore:
      
              Reviewed by Darin.
      
              Part two of patch for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of the rest
              of HTMLElement
      
              - Just the HTMLDocument part.
      
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLDocumentCustom.cpp: Added.
              (WebCore::JSHTMLDocument::canGetItemsForName):
              (WebCore::JSHTMLDocument::nameGetter):
              (WebCore::JSHTMLDocument::all):
              (WebCore::JSHTMLDocument::setAll):
              (WebCore::JSHTMLDocument::location):
              (WebCore::JSHTMLDocument::setLocation):
              (WebCore::JSHTMLDocument::open):
              (WebCore::writeHelper):
              (WebCore::JSHTMLDocument::write):
              (WebCore::JSHTMLDocument::writeln):
              (WebCore::JSHTMLDocument::clear):
              * bindings/js/kjs_dom.cpp:
              (KJS::toJS):
              * bindings/js/kjs_dom.h:
              * bindings/js/kjs_html.cpp:
              * bindings/js/kjs_html.h:
              * bindings/objc/DOMPrivate.h:
              * bindings/scripts/CodeGeneratorJS.pm: Add [Deletable] property
              for Document.all and fix HasOverridingNameGetter to allow correct
              prototype chain
              * dom/Document.cpp:
              (WebCore::Document::plugins): adds alias to embeds() for bindings
              * dom/Document.h:
              * html/HTMLDocument.cpp:
              (WebCore::HTMLDocument::width):
              (WebCore::HTMLDocument::height):
              (WebCore::HTMLDocument::dir):
              (WebCore::HTMLDocument::setDir):
              (WebCore::HTMLDocument::designMode):
              (WebCore::HTMLDocument::setDesignMode):
              (WebCore::HTMLDocument::bgColor):
              (WebCore::HTMLDocument::setBgColor):
              (WebCore::HTMLDocument::fgColor):
              (WebCore::HTMLDocument::setFgColor):
              (WebCore::HTMLDocument::alinkColor):
              (WebCore::HTMLDocument::setAlinkColor):
              (WebCore::HTMLDocument::linkColor):
              (WebCore::HTMLDocument::setLinkColor):
              (WebCore::HTMLDocument::vlinkColor):
              (WebCore::HTMLDocument::setVlinkColor):
              (WebCore::HTMLDocument::captureEvents):
              (WebCore::HTMLDocument::releaseEvents):
              * html/HTMLDocument.h:
              * html/HTMLDocument.idl:
      
      WebKit:
      
              Reviewed by Darin.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13830
              Auto-generate JS DOM bindings for HTMLDocument and most of the rest
              of HTMLElement
      
              * MigrateHeaders.make: add DOMHTMLDocumentPrivate.h
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      661a37fc
    • kmccullo's avatar
      Reviewed by. · 649a9edd
      kmccullo authored
              - Fixed build breakage.
      
              * fast/dom/open-and-close-by-DOM-expected.txt: Added.
              * fast/dom/open-and-close-by-DOM.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      649a9edd
    • kmccullo's avatar
      Reviewed by. · 5fd81f18
      kmccullo authored
              - Removing failing tests until I've fixed them.
      
              * fast/dom/open-and-close-by-DOM-expected.txt: Removed.
              * fast/dom/open-and-close-by-DOM.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fd81f18
    • rwlbuis's avatar
      Reviewed by Dave Hyatt. · a215bbc6
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=13174
              line-height in font shorthand does not override a previously stated line-height property
      
              Make sure line-height is calculated against definite font-size and
              uses the last set line-height, ie. directly or through font shorthand.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a215bbc6
    • rwlbuis's avatar
      Reviewed by Darin. · abbef99e
      rwlbuis authored
              http://bugs.webkit.org/show_bug.cgi?id=13784
              REGRESSION (r13744-13750): Crash with empty gradient when drawing to canvas
      
              Fix crash by testing for zero stops, and returning transparent black
              in this case.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abbef99e
  3. 22 May, 2007 6 commits
    • weinig's avatar
      LayoutTests: · 40d22abd
      weinig authored
              Reviewed by Adam.
      
              Update tests for http://bugs.webkit.org/show_bug.cgi?id=13833
              Add ObjC DOM binding for HTMLMarqeeElement
      
              * fast/dom/wrapper-classes-expected.txt:
              * fast/dom/wrapper-classes.html: HTMLMarqueeElement now is a 
              DOMHTMLMarqueeElement
      
      WebCore:
      
              Reviewed by Adam.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
              Add ObjC DOM binding for HTMLMarqeeElement
      
              - Also adds missing DOMHTMLFramePrivate.
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/objc/DOM.mm:
              (WebCore::createElementClassMap):
              * bindings/objc/DOMHTML.h:
              * bindings/objc/DOMInternal.h:
              * bindings/objc/DOMPrivate.h:
              * bindings/objc/PublicDOMInterfaces.h:
      
      WebKit:
      
              Reviewed by Adam.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13833
              Add ObjC DOM binding for HTMLMarqeeElement
      
              - Also adds missing DOMHTMLFramePrivate.
      
              * MigrateHeaders.make:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40d22abd
    • hyatt's avatar
      Add layout test for better background dumping. · bb21e287
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb21e287
    • darin's avatar
      LayoutTests: · cc06b695
      darin authored
              Reviewed by Geoff.
      
              - test for <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong
      
              * fast/dom/iframe-document.html: Updated test to expect no document property.
              * fast/dom/iframe-document-expected.txt: Updated.
      
              * fast/forms/focus2.html: Changed test to use ownerDocument instead of document.
      
      WebCore:
      
              Reviewed by Geoff.
      
              - fix <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong
      
              The code on ebay was looking for the "document" property on a iframe.
              We changed that to be the ownerDocument rather than the contentDocument,
              which was not what ebay was expecting. The best fix seems to be removing
              the document property altogether.
      
              Test: fast/dom/iframe-document.html
      
              * bindings/js/kjs_html.h: Remove ElementDocument.
              * bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): Ditto.
      
      WebKit:
      
              Reviewed by Geoff.
      
              * WebInspector/webInspector/treeoutline.js: Use ownerDocument instead of non-standard
              document property.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc06b695
    • adele's avatar
      LayoutTests: · 82c11d19
      adele authored
              Reviewed by Darin.
      
              Test for http://bugs.webkit.org/show_bug.cgi?id=13796
              Crash in [NSInputContext currentInputContext] when you click on this map
      
              * fast/frames/frame-display-none-focus-expected.txt: Added.
              * fast/frames/frame-display-none-focus.html: Added.
              * fast/frames/resources/iframe-focus.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              Fix for http://bugs.webkit.org/show_bug.cgi?id=13796
              Crash in [NSInputContext currentInputContext] when you click on this map
      
              This is another case of <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts
      
              Test: fast/frames/frame-display-none-focus.html
      
              * WebCore.xcodeproj/project.pbxproj: Added ChromeMac.mm
              * page/Chrome.h:
              * page/mac/ChromeMac.mm: Added.
              (WebCore::Chrome::focusNSView): Moved code from Widget::setFocus so it can be used whenever we need to make a view the first responder.
              * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView): Calls focusNSView.
              * platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): Calls focusNSView.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82c11d19
    • kmccullo's avatar
      Reviewed by. · e3681b65
      kmccullo authored
              - Forgot to checkin for fix for rdar://problem/4981886
      
              * fast/dom/open-and-close-by-DOM-expected.txt: Added.
              * fast/dom/open-and-close-by-DOM.html: Added.
              * fast/dom/resources/close.html: Added.
              * fast/dom/resources/middle.html: Added.
              * http/tests/security/local-image-from-remote.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3681b65
    • justing's avatar
      LayoutTests: · 00b7e557
      justing authored
              Reviewed by oliver
      
              <rdar://problem/5213963> 
              REGRESSION(r21467): Active selection remains in text field after clicking on a button
      
              Demonstrates bug:
              * editing/selection/5213963-expected.checksum: Added.
              * editing/selection/5213963-expected.png: Added.
              * editing/selection/5213963-expected.txt: Added.
              * editing/selection/5213963.html: Added.
              We now clear the selection on mouse down (but not before
              the mousedown event is fired):
              * fast/forms/focus-selection-input-expected.txt:
              * fast/forms/focus-selection-textarea-expected.txt:
      
      WebCore:
      
              Reviewed by oliver
      
              <rdar://problem/5213963>
              REGRESSION(r21467): Active selection remains in text field after clicking on a button
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dispatchMouseEvent): Call
              FocusController::setFocusedNode, because Document::setFocusedNode
              no longer clears the selection.
              Begin passing the new focused frame to 
              FocusController::setFocusedNode, because when the 
              new focus node is null, the selection should only be 
              cleared if the focused frame isn't changing.
              (WebCore::Element::focus): Begin passing the new focused
              frame.
              (WebCore::Element::blur): Ditto.
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::focus): Ditto.
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::focus): Ditto.
              * page/Frame.cpp:
              (WebCore::Frame::setFocusedNodeIfNeeded): Ditto.
              * page/FocusController.cpp:
              (WebCore::clearSelectionIfNeeded): Take in the new
              focused frame.  If it's not changing, don't clear the
              selection.
              (WebCore::FocusController::setFocusedNode): Take
              in the new focused frame.
              * page/FocusController.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00b7e557
  4. 21 May, 2007 4 commits
    • weinig's avatar
      LayoutTests: · 4d7ce9a5
      weinig authored
              Reviewed by Darin.
      
              - update tests and results for http://bugs.webkit.org/show_bug.cgi?id=13803
                to account for the new JSHTMLMarquee that is being autogenerated and
                can now produce a constructor.
      
              * fast/dom/Window/element-constructors-on-window-expected.txt:
              * fast/dom/Window/element-constructors-on-window.html:
              * fast/dom/Window/window-properties-expected.txt:
      
      WebCore:
      
              Reviewed by Darin.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13803
              Autogenerate the JS bindings for the HTMLMarqueeElement.
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              * bindings/js/kjs_css.cpp:
              (KJS::DOMCSSRule::getOwnPropertySlot): Fix possible null pointer issue.
              (KJS::DOMCSSRule::put): Fix possible null pointer issue.
              * bindings/js/kjs_html.cpp:
              (KJS::):
              (KJS::JSHTMLElement::classInfo):
              (KJS::JSHTMLElement::accessors):
              (KJS::JSHTMLElement::getOwnPropertySlot): Fix null pointer issue.
              (KJS::HTMLElementFunction::callAsFunction):
              (KJS::JSHTMLElement::put):
              * bindings/js/kjs_html.h:
              (KJS::JSHTMLElement::):
              * html/HTMLMarqueeElement.cpp:
              (WebCore::HTMLMarqueeElement::start):
              (WebCore::HTMLMarqueeElement::stop):
              * html/HTMLMarqueeElement.h: Add start() and stop() functions.
              * html/HTMLMarqueeElement.idl: Added.
              * page/DOMWindow.idl: Add marquee constructor.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d7ce9a5
    • weinig's avatar
      · b3baea79
      weinig authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3baea79
    • weinig's avatar
      LayoutTests: · 16885ff7
      weinig authored
              Reviewed by Adam and Darin.
      
              - update results for http://bugs.webkit.org/show_bug.cgi?id=13791
                to account for new JSHTMLElements that are being autogenerated and
                can now produce constructors.
      
              * fast/dom/Window/element-constructors-on-window-expected.txt:
              * fast/dom/Window/window-properties-expected.txt:
      
      WebCore:
      
              Reviewed by Adam and Darin.
      
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13791
              Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement.
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLAnchorElementCustom.cpp:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              * bindings/js/kjs_html.cpp:
              (KJS::):
              (KJS::JSHTMLElement::classInfo):
              (KJS::JSHTMLElement::accessors):
              (KJS::HTMLElementFunction::callAsFunction):
              * bindings/js/kjs_html.h:
              (KJS::JSHTMLElement::):
              * bindings/scripts/CodeGeneratorJS.pm:
              * html/HTMLFrameElement.idl:
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::location):
              * html/HTMLFrameElementBase.h:
              * html/HTMLFrameOwnerElement.h:
              (WebCore::HTMLFrameOwnerElement::contentWindow):
              * html/HTMLIFrameElement.idl:
              * page/DOMWindow.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16885ff7
    • hyatt's avatar
      Add new layout test for spanning colgroup rules=groups bug. · 870142ec
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      870142ec
  5. 19 May, 2007 5 commits
    • bdash's avatar
      2007-05-19 Mitz Pettel <mitz@webkit.org> · 97b9586a
      bdash authored
              Reviewed by Dave Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12729
                box-shadow disappears when scrolling a div that it falls on/under
      
              Tests: fast/repaint/box-shadow-dynamic.html
                     fast/repaint/box-shadow-h.html
                     fast/repaint/box-shadow-v.html
      
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::placeBoxesHorizontally): Factor in box shadow.
              (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
              (WebCore::InlineFlowBox::paint): Account for box shadow when checking if
              the damage rect intersects.
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::overflowHeight): For overflow areas, when asked
              for the "exterior" overflow, add box shadow overflow.
              (WebCore::RenderBlock::overflowWidth): Ditto.
              (WebCore::RenderBlock::overflowLeft): Ditto.
              (WebCore::RenderBlock::overflowTop): Ditto.
              (WebCore::RenderBlock::overflowRect): Ditto.
              (WebCore::RenderBlock::layoutBlock): Factor box shadow into visual overflow.
              * rendering/RenderFlexibleBox.cpp:
              (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::lowestPosition): For overflow areas, when asked for
              the "exterior" extreme position, add box shadow.
              (WebCore::RenderFlow::rightmostPosition): Ditto.
              (WebCore::RenderFlow::leftmostPosition): Ditto.
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::calculateRects): Avoid clipping out box shadow.
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Make sure to paint
              the box shadow when an edge with a shadow moves.
              (WebCore::RenderObject::adjustRectForOutlineAndShadow): Helper function
              that expands a given rectangle to encompass outline and box shadow.
              (WebCore::RenderObject::absoluteOutlineBox): Changed to include box shadow.
              * rendering/RenderObject.h:
      
      2007-05-19  Mitz Pettel  <mitz@webkit.org>
      
              Reviewed by Dave Hyatt.
      
              - repaint tests and updated results for http://bugs.webkit.org/show_bug.cgi?id=12729
                box-shadow disappears when scrolling a div that it falls on/under
      
              * fast/box-shadow/basic-shadows-expected.checksum:
              * fast/box-shadow/basic-shadows-expected.png:
              * fast/box-shadow/basic-shadows-expected.txt:
              * fast/repaint/box-shadow-dynamic-expected.checksum: Added.
              * fast/repaint/box-shadow-dynamic-expected.png: Added.
              * fast/repaint/box-shadow-dynamic-expected.txt: Added.
              * fast/repaint/box-shadow-dynamic.html: Added.
              * fast/repaint/box-shadow-h-expected.checksum: Added.
              * fast/repaint/box-shadow-h-expected.png: Added.
              * fast/repaint/box-shadow-h-expected.txt: Added.
              * fast/repaint/box-shadow-h.html: Added.
              * fast/repaint/box-shadow-v-expected.checksum: Added.
              * fast/repaint/box-shadow-v-expected.png: Added.
              * fast/repaint/box-shadow-v-expected.txt: Added.
              * fast/repaint/box-shadow-v.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97b9586a
    • bdash's avatar
      2007-05-20 Mark Rowe <mrowe@apple.com> · 42db1e6f
      bdash authored
              Update test results after r21597.
      
              * fast/frames/viewsource-attribute-expected.checksum:
              * fast/frames/viewsource-attribute-expected.png:
              * fast/frames/viewsource-attribute-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42db1e6f
    • bdash's avatar
      2007-05-19 Mitz Pettel <mitz@webkit.org> · 7746786d
      bdash authored
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=13774
                REGRESSION: Crash emailing blog entry using Google Reader
      
              Test: fast/table/stale-grid-crash.html
      
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::recalcSections): Made const and replaced
              setNeedsLayout(true) with an assertion that the table is already
              marked for layout.
              (WebCore::RenderTable::sectionAbove): Added call to recalcSectionsIfNeeded().
              (WebCore::RenderTable::sectionBelow): Ditto.
              (WebCore::RenderTable::cellAbove): Ditto.
              (WebCore::RenderTable::cellBelow): Ditto.
              (WebCore::RenderTable::cellBefore): Ditto.
              (WebCore::RenderTable::cellAfter): Ditto.
              * rendering/RenderTable.h:
              Made some private member variables which are used in section recalc mutable.
              (WebCore::RenderTable::setNeedsSectionRecalc): Moved the call to
              setNeedsLayout() from recalcSections() into here, because I made
              recalcSections() const.
              (WebCore::RenderTable::recalcSectionsIfNeeded): Made const.
      
      2007-05-19  Mitz Pettel  <mitz@webkit.org>
      
              Reviewed by Darin.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=13774
                REGRESSION: Crash emailing blog entry using Google Reader
      
              * fast/table/stale-grid-crash-expected.checksum: Added.
              * fast/table/stale-grid-crash-expected.png: Added.
              * fast/table/stale-grid-crash-expected.txt: Added.
              * fast/table/stale-grid-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7746786d
    • bdash's avatar
      2007-05-19 Mitz Pettel <mitz@webkit.org> · 71b3ce0c
      bdash authored
              Reviewed by Darin.
      
              - http://bugs.webkit.org/show_bug.cgi?id=13320
                rounded corners with drop shadows are really slow
      
              Test for a rendering bug fixed by this patch:
                  fast/box-shadow/border-radius-big.html
      
              No test for the performance ingredient.
      
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContext::addRoundedRectClip): Made cross-platform.
              Changed to use a single clipping path. If all the radii cannot be
              accommodated, clips to a rect.
              (WebCore::GraphicsContext::clipOutRoundedRect): Changed to use a single
              clipping path. If all the radii cannot be accommodated, clips out a rect.
              * platform/graphics/GraphicsContext.h: Added clipOut(const Path&).
              * platform/graphics/Path.cpp:
              (WebCore::Path::createRoundedRectangle): Added. Returns a rounded rectangle
              with the specified radii. If all the radii cannot be accommodated, returns
              a rectangular path.
              * platform/graphics/Path.h:
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::clipOut): Added.
              * platform/graphics/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::fillRoundedRect): Changed to use a single path.
              (WebCore::GraphicsContext::clipOut): Added.
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::clipOut): Added.
      
      2007-05-19  Mitz Pettel  <mitz@webkit.org>
      
              Reviewed by Darin.
      
              - http://bugs.webkit.org/show_bug.cgi?id=13320
                rounded corners with drop shadows are really slow
      
              * fast/box-shadow/border-radius-big-expected.checksum: Added.
              * fast/box-shadow/border-radius-big-expected.png: Added.
              * fast/box-shadow/border-radius-big-expected.txt: Added.
              * fast/box-shadow/border-radius-big.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71b3ce0c
    • andersca's avatar
      LayoutTests: · 44b89c45
      andersca authored
              Reviewed by Mitz.
      
              http://bugs.webkit.org/show_bug.cgi?id=13771
              Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester
              
              * fast/frames/inline-object-inside-frameset-expected.txt: Added.
              * fast/frames/inline-object-inside-frameset.html: Added.
      
      WebCore:
      
              Reviewed by Mitz.
      
              Test: fast/frames/inline-object-inside-frameset.html
              
              http://bugs.webkit.org/show_bug.cgi?id=13771
              Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester
      
              Don't paint inline objects.
              
              * rendering/RenderFrameSet.cpp:
              (WebCore::RenderFrameSet::paint):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44b89c45
  6. 18 May, 2007 7 commits
  7. 17 May, 2007 3 commits
    • weinig's avatar
      LayoutTests: · 7e935edd
      weinig authored
              Reviewed by Adam.
      
              Tests for <rdar://problem/5201423> REGRESSION: Links in 
              sidebar don't work on Honda website
      
              * fast/dom/anchor-toString-expected.txt: Added.
              * fast/dom/anchor-toString.html: Added.
              * fast/forms/focus2.html:
      
      WebCore:
      
              Reviewed by Adam.
      
              Fix for <rdar://problem/5201423> REGRESSION: Links in 
              sidebar don't work on Honda website
      
              Anchor elements need to have the same behavior for implicit and 
              explicit toString() calls.
      
              Test: fast/dom/anchor-toString.html
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLAnchorElementCustom.cpp: Added.
              (WebCore::JSHTMLAnchorElement::toString):
              * html/HTMLAnchorElement.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e935edd
    • adele's avatar
      LayoutTests: · 5f1d9b77
      adele authored
              Reviewed by Mitz.
      
              Test for <rdar://problem/5096035> REGRESSION: rtl text should be left-aligned in <select>s
      
              * fast/text/international/bidi-menulist-expected.checksum: Added.
              * fast/text/international/bidi-menulist-expected.png: Added.
              * fast/text/international/bidi-menulist-expected.txt: Added.
              * fast/text/international/bidi-menulist.html: Added.
      
      WebCore:
      
              Reviewed by Mitz.
      
              Fix for <rdar://problem/5096035> REGRESSION: rtl text should be left-aligned in <select>s
      
              Test: fast/text/international/bidi-menulist.html
      
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::adjustInnerStyle): Set the inner block style to direction: ltr, and text-align: left.  This means that
               we will ignore those settings in the button to match the way the text is displayed in the popup menu.
              (WebCore::RenderMenuList::createInnerBlock): Call adjustInnerStyle.
              (WebCore::RenderMenuList::setStyle): ditto.
              * rendering/RenderMenuList.h: Added adjustInnerStyle.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f1d9b77
    • hyatt's avatar
      Update the lone view source mode layout test. · d8918121
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8918121