- 24 May, 2007 5 commits
-
-
weinig authored
Reviewed by Anders. - update results to account for the new JSHTMLFrameSetElement that is being autogenerated and can now produce a constructor. * fast/dom/Window/element-constructors-on-window-expected.txt: * fast/dom/Window/window-properties-expected.txt: WebCore: Reviewed by Anders. Uncomment HTMLFramesSetElement constructor now that it exists. * page/DOMWindow.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ddkilzer authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 23 May, 2007 12 commits
-
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ddkilzer authored
Reviewed by David Hyatt. - tests for http://bugs.webkit.org/show_bug.cgi?id=13563 REGRESSION: Crash loading message in Yahoo! Mail * fast/css/stale-style-selector-crash-1-expected.txt: Added. * fast/css/stale-style-selector-crash-1.html: Added. * fast/css/stale-style-selector-crash-2-expected.txt: Added. * fast/css/stale-style-selector-crash-2.html: Added. WebCore: Reviewed by David Hyatt. - fix http://bugs.webkit.org/show_bug.cgi?id=13563 REGRESSION: Crash loading message in Yahoo! Mail Tests: fast/css/stale-style-selector-crash-1.html fast/css/stale-style-selector-crash-2.html * dom/Document.cpp: (WebCore::Document::Document): Initialize the m_didCalculateStyleSelector flag to 'false'. (WebCore::Document::updateStyleSelector): Do not bail out if we have ever calculated a non-trivial style selector, even if at the moment we are pending style sheets. We could have calculated a non-trivial selector already either because at some point there were no pending style sheets (so the currently pending ones were added dynamically) or because we were forced to do a layout ignoring pending style sheets. Either way, once there is a style selector, we need to keep it up to date, otherwise we can crash under recalcStyle() during updateRendering() or simply not recalculate style correctly for dynamic changes. (WebCore::Document::recalcStyleSelector): Set m_didCalculateStyleSelector to 'true' when creating a new style selector. * dom/Document.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
Reviewed by Hyatt. - updated the many tests with an extra newline or two at the end because of the bug where plain-text serialization will consider nodes that are not rendered WebCore: Reviewed by Hyatt. - fix problems where unrendered nodes were affecting on plain text serialization * editing/TextIterator.cpp: (WebCore::TextIterator::advance): Don't call handleXXX functions or exitNode for nodes without renderers. (WebCore::shouldEmitNewlineAfterNode): Only consider rendered nodes when deciding if this is the last node in the document. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kmccullo authored
Reviewed by Darin. Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830 Auto-generate JS DOM bindings for HTMLDocument and most of the rest of HTMLElement - Corrects prototype chain for JSHTMLDocument and adds test for HTMLFormElement. * fast/dom/prototype-chain-expected.txt: * fast/dom/prototype-chain.html: WebCore: Reviewed by Darin. - rdar://problem/5183523 - We now check the document's URL to see if it can load a resource in the case of a URL click, instead of checking the referrer, which is blank for local files. * loader/FrameLoader.cpp: (WebCore::FrameLoader::load): (WebCore::FrameLoader::open): * platform/PlatformString.h: (WebCore::debugPrintString): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig authored
Reviewed by Darin. Update tests for http://bugs.webkit.org/show_bug.cgi?id=13830 Auto-generate JS DOM bindings for HTMLDocument and most of the rest of HTMLElement - Corrects prototype chain for JSHTMLDocument and adds test for HTMLFormElement. * fast/dom/prototype-chain-expected.txt: * fast/dom/prototype-chain.html: WebCore: Reviewed by Darin. Part two of patch for http://bugs.webkit.org/show_bug.cgi?id=13830 Auto-generate JS DOM bindings for HTMLDocument and most of the rest of HTMLElement - Just the HTMLDocument part. * WebCore.pro: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSHTMLDocumentCustom.cpp: Added. (WebCore::JSHTMLDocument::canGetItemsForName): (WebCore::JSHTMLDocument::nameGetter): (WebCore::JSHTMLDocument::all): (WebCore::JSHTMLDocument::setAll): (WebCore::JSHTMLDocument::location): (WebCore::JSHTMLDocument::setLocation): (WebCore::JSHTMLDocument::open): (WebCore::writeHelper): (WebCore::JSHTMLDocument::write): (WebCore::JSHTMLDocument::writeln): (WebCore::JSHTMLDocument::clear): * bindings/js/kjs_dom.cpp: (KJS::toJS): * bindings/js/kjs_dom.h: * bindings/js/kjs_html.cpp: * bindings/js/kjs_html.h: * bindings/objc/DOMPrivate.h: * bindings/scripts/CodeGeneratorJS.pm: Add [Deletable] property for Document.all and fix HasOverridingNameGetter to allow correct prototype chain * dom/Document.cpp: (WebCore::Document::plugins): adds alias to embeds() for bindings * dom/Document.h: * html/HTMLDocument.cpp: (WebCore::HTMLDocument::width): (WebCore::HTMLDocument::height): (WebCore::HTMLDocument::dir): (WebCore::HTMLDocument::setDir): (WebCore::HTMLDocument::designMode): (WebCore::HTMLDocument::setDesignMode): (WebCore::HTMLDocument::bgColor): (WebCore::HTMLDocument::setBgColor): (WebCore::HTMLDocument::fgColor): (WebCore::HTMLDocument::setFgColor): (WebCore::HTMLDocument::alinkColor): (WebCore::HTMLDocument::setAlinkColor): (WebCore::HTMLDocument::linkColor): (WebCore::HTMLDocument::setLinkColor): (WebCore::HTMLDocument::vlinkColor): (WebCore::HTMLDocument::setVlinkColor): (WebCore::HTMLDocument::captureEvents): (WebCore::HTMLDocument::releaseEvents): * html/HTMLDocument.h: * html/HTMLDocument.idl: WebKit: Reviewed by Darin. Patch for http://bugs.webkit.org/show_bug.cgi?id=13830 Auto-generate JS DOM bindings for HTMLDocument and most of the rest of HTMLElement * MigrateHeaders.make: add DOMHTMLDocumentPrivate.h * WebKit.xcodeproj/project.pbxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kmccullo authored
- Fixed build breakage. * fast/dom/open-and-close-by-DOM-expected.txt: Added. * fast/dom/open-and-close-by-DOM.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kmccullo authored
- Removing failing tests until I've fixed them. * fast/dom/open-and-close-by-DOM-expected.txt: Removed. * fast/dom/open-and-close-by-DOM.html: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rwlbuis authored
http://bugs.webkit.org/show_bug.cgi?id=13174 line-height in font shorthand does not override a previously stated line-height property Make sure line-height is calculated against definite font-size and uses the last set line-height, ie. directly or through font shorthand. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rwlbuis authored
http://bugs.webkit.org/show_bug.cgi?id=13784 REGRESSION (r13744-13750): Crash with empty gradient when drawing to canvas Fix crash by testing for zero stops, and returning transparent black in this case. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rwlbuis authored
http://bugs.webkit.org/show_bug.cgi?id=13801 Crash when loading nonexisting symbol Check for referenced element and when not found just return. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 22 May, 2007 9 commits
-
-
weinig authored
Reviewed by Adam. Update tests for http://bugs.webkit.org/show_bug.cgi?id=13833 Add ObjC DOM binding for HTMLMarqeeElement * fast/dom/wrapper-classes-expected.txt: * fast/dom/wrapper-classes.html: HTMLMarqueeElement now is a DOMHTMLMarqueeElement WebCore: Reviewed by Adam. Patch for http://bugs.webkit.org/show_bug.cgi?id=13833 Add ObjC DOM binding for HTMLMarqeeElement - Also adds missing DOMHTMLFramePrivate. * DerivedSources.make: * WebCore.xcodeproj/project.pbxproj: * bindings/objc/DOM.mm: (WebCore::createElementClassMap): * bindings/objc/DOMHTML.h: * bindings/objc/DOMInternal.h: * bindings/objc/DOMPrivate.h: * bindings/objc/PublicDOMInterfaces.h: WebKit: Reviewed by Adam. Patch for http://bugs.webkit.org/show_bug.cgi?id=13833 Add ObjC DOM binding for HTMLMarqeeElement - Also adds missing DOMHTMLFramePrivate. * MigrateHeaders.make: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
justing authored
Reviewed by darin http://bugs.webkit.org/show_bug.cgi?id=13804 REGRESSION(r21611): Several new layout test pixel failures (misspelling markers) * editing/selection/13804-expected.checksum: Added. * editing/selection/13804-expected.png: Added. * editing/selection/13804-expected.txt: Added. * editing/selection/13804.html: Added. These were missing: * editing/selection/5076323-1-expected.png: Added. * editing/selection/5076323-2-expected.png: Added. * editing/selection/5076323-3-expected.png: Added. WebCore: Reviewed by darin, who found the fix independently. http://bugs.webkit.org/show_bug.cgi?id=13804 REGRESSION(r21611): Several new layout test pixel failures (misspelling markers) r21611 exposed a bug in the way removeMarkers computes the end of the range to remove markers from. It also introduced a bug: removeMarkers expects a startOffset and a length, not a startOffset and an endOffset (added a layout test). * dom/Document.cpp: (WebCore::Document::removeMarkers): The other removeMarkers expects a startOffset and a length, not a startOffset and an endOffset. (WebCore::Document::removeMarkers): Fixed the endOffset from length and startOffset calculation. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin authored
Reviewed by Geoff. - test for <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong * fast/dom/iframe-document.html: Updated test to expect no document property. * fast/dom/iframe-document-expected.txt: Updated. * fast/forms/focus2.html: Changed test to use ownerDocument instead of document. WebCore: Reviewed by Geoff. - fix <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong The code on ebay was looking for the "document" property on a iframe. We changed that to be the ownerDocument rather than the contentDocument, which was not what ebay was expecting. The best fix seems to be removing the document property altogether. Test: fast/dom/iframe-document.html * bindings/js/kjs_html.h: Remove ElementDocument. * bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): Ditto. WebKit: Reviewed by Geoff. * WebInspector/webInspector/treeoutline.js: Use ownerDocument instead of non-standard document property. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
adele authored
Reviewed by Darin. Test for http://bugs.webkit.org/show_bug.cgi?id=13796 Crash in [NSInputContext currentInputContext] when you click on this map * fast/frames/frame-display-none-focus-expected.txt: Added. * fast/frames/frame-display-none-focus.html: Added. * fast/frames/resources/iframe-focus.html: Added. WebCore: Reviewed by Darin. Fix for http://bugs.webkit.org/show_bug.cgi?id=13796 Crash in [NSInputContext currentInputContext] when you click on this map This is another case of <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts Test: fast/frames/frame-display-none-focus.html * WebCore.xcodeproj/project.pbxproj: Added ChromeMac.mm * page/Chrome.h: * page/mac/ChromeMac.mm: Added. (WebCore::Chrome::focusNSView): Moved code from Widget::setFocus so it can be used whenever we need to make a view the first responder. * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView): Calls focusNSView. * platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): Calls focusNSView. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
justing authored
Reviewed by darin <rdar://problem/4875189> List is deleted when replacing contents with Chinese/Japanese characters Moved from unsupported-content because we've supported editing lists for a while now: * editing/deleting/4875189-expected.checksum: Added. * editing/deleting/4875189-expected.png: Added. * editing/deleting/4875189-expected.txt: Added. * editing/deleting/4875189.html: Added. * editing/unsupported-content/list-delete-002-expected.checksum: Removed. * editing/unsupported-content/list-delete-002-expected.png: Removed. * editing/unsupported-content/list-delete-002-expected.txt: Removed. * editing/unsupported-content/list-delete-002.html: Removed. Reflects new behavior: * editing/deleting/delete-select-all-003-expected.checksum: * editing/deleting/delete-select-all-003-expected.png: * editing/deleting/delete-select-all-003-expected.txt: Ditto and also removed a FIXME: * editing/deleting/list-item-1-expected.checksum: * editing/deleting/list-item-1-expected.png: * editing/deleting/list-item-1-expected.txt: * editing/deleting/list-item-1.html: WebCore: Reviewed by darin <rdar://problem/4875189> List is deleted when replacing contents with Chinese/Japanese characters * editing/htmlediting.cpp: (WebCore::isSpecialElement): Lists are no longer special. They can be removed by removing their content and then then hitting delete inside of the empty list item that's left over. Even when that list item is the first thing in the editable region. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kmccullo authored
- Forgot to checkin for fix for rdar://problem/4981886 * fast/dom/open-and-close-by-DOM-expected.txt: Added. * fast/dom/open-and-close-by-DOM.html: Added. * fast/dom/resources/close.html: Added. * fast/dom/resources/middle.html: Added. * http/tests/security/local-image-from-remote.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
justing authored
Reviewed by oliver <rdar://problem/5213963> REGRESSION(r21467): Active selection remains in text field after clicking on a button Demonstrates bug: * editing/selection/5213963-expected.checksum: Added. * editing/selection/5213963-expected.png: Added. * editing/selection/5213963-expected.txt: Added. * editing/selection/5213963.html: Added. We now clear the selection on mouse down (but not before the mousedown event is fired): * fast/forms/focus-selection-input-expected.txt: * fast/forms/focus-selection-textarea-expected.txt: WebCore: Reviewed by oliver <rdar://problem/5213963> REGRESSION(r21467): Active selection remains in text field after clicking on a button * page/EventHandler.cpp: (WebCore::EventHandler::dispatchMouseEvent): Call FocusController::setFocusedNode, because Document::setFocusedNode no longer clears the selection. Begin passing the new focused frame to FocusController::setFocusedNode, because when the new focus node is null, the selection should only be cleared if the focused frame isn't changing. (WebCore::Element::focus): Begin passing the new focused frame. (WebCore::Element::blur): Ditto. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): Ditto. * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::focus): Ditto. * page/Frame.cpp: (WebCore::Frame::setFocusedNodeIfNeeded): Ditto. * page/FocusController.cpp: (WebCore::clearSelectionIfNeeded): Take in the new focused frame. If it's not changing, don't clear the selection. (WebCore::FocusController::setFocusedNode): Take in the new focused frame. * page/FocusController.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
justing authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 21 May, 2007 6 commits
-
-
oliver authored
LayoutTests: Reviewed by Sam. Layout test for http://bugs.webkit.org/show_bug.cgi?id=13789 * svg/custom/getscreenctm-in-mixed-content-expected.checksum: Added. * svg/custom/getscreenctm-in-mixed-content-expected.png: Added. * svg/custom/getscreenctm-in-mixed-content-expected.txt: Added. * svg/custom/getscreenctm-in-mixed-content.xhtml: Added. WebCore: Reviewed by Sam. Fix for http://bugs.webkit.org/show_bug.cgi?id=13789 -- SVGLocatable::getScreenCTM() faulty Needed to update SVGLength to handle the case where the SVGElement is not the root document element -- we do this by falling back on the renderer for the context. For <svg> elements embedded as mixed content in xhtml we consider the absolutePosition of the parent to be the origin for the <svg> element. * ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::PercentageOfViewport): * ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::getScreenCTM): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig authored
Reviewed by Darin. - update tests and results for http://bugs.webkit.org/show_bug.cgi?id=13803 to account for the new JSHTMLMarquee that is being autogenerated and can now produce a constructor. * fast/dom/Window/element-constructors-on-window-expected.txt: * fast/dom/Window/element-constructors-on-window.html: * fast/dom/Window/window-properties-expected.txt: WebCore: Reviewed by Darin. Patch for http://bugs.webkit.org/show_bug.cgi?id=13803 Autogenerate the JS bindings for the HTMLMarqueeElement. * DerivedSources.make: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSHTMLElementWrapperFactory.cpp: * bindings/js/kjs_css.cpp: (KJS::DOMCSSRule::getOwnPropertySlot): Fix possible null pointer issue. (KJS::DOMCSSRule::put): Fix possible null pointer issue. * bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot): Fix null pointer issue. (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::put): * bindings/js/kjs_html.h: (KJS::JSHTMLElement::): * html/HTMLMarqueeElement.cpp: (WebCore::HTMLMarqueeElement::start): (WebCore::HTMLMarqueeElement::stop): * html/HTMLMarqueeElement.h: Add start() and stop() functions. * html/HTMLMarqueeElement.idl: Added. * page/DOMWindow.idl: Add marquee constructor. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig authored
Reviewed by Adam and Darin. - update results for http://bugs.webkit.org/show_bug.cgi?id=13791 to account for new JSHTMLElements that are being autogenerated and can now produce constructors. * fast/dom/Window/element-constructors-on-window-expected.txt: * fast/dom/Window/window-properties-expected.txt: WebCore: Reviewed by Adam and Darin. Patch for http://bugs.webkit.org/show_bug.cgi?id=13791 Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement. * DerivedSources.make: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSHTMLAnchorElementCustom.cpp: * bindings/js/JSHTMLElementWrapperFactory.cpp: * bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::HTMLElementFunction::callAsFunction): * bindings/js/kjs_html.h: (KJS::JSHTMLElement::): * bindings/scripts/CodeGeneratorJS.pm: * html/HTMLFrameElement.idl: * html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::location): * html/HTMLFrameElementBase.h: * html/HTMLFrameOwnerElement.h: (WebCore::HTMLFrameOwnerElement::contentWindow): * html/HTMLIFrameElement.idl: * page/DOMWindow.idl: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 19 May, 2007 5 commits
-
-
bdash authored
Reviewed by Dave Hyatt. - fix http://bugs.webkit.org/show_bug.cgi?id=12729 box-shadow disappears when scrolling a div that it falls on/under Tests: fast/repaint/box-shadow-dynamic.html fast/repaint/box-shadow-h.html fast/repaint/box-shadow-v.html * rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Factor in box shadow. (WebCore::InlineFlowBox::placeBoxesVertically): Ditto. (WebCore::InlineFlowBox::paint): Account for box shadow when checking if the damage rect intersects. * rendering/RenderBlock.cpp: (WebCore::RenderBlock::overflowHeight): For overflow areas, when asked for the "exterior" overflow, add box shadow overflow. (WebCore::RenderBlock::overflowWidth): Ditto. (WebCore::RenderBlock::overflowLeft): Ditto. (WebCore::RenderBlock::overflowTop): Ditto. (WebCore::RenderBlock::overflowRect): Ditto. (WebCore::RenderBlock::layoutBlock): Factor box shadow into visual overflow. * rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): Ditto. * rendering/RenderFlow.cpp: (WebCore::RenderFlow::lowestPosition): For overflow areas, when asked for the "exterior" extreme position, add box shadow. (WebCore::RenderFlow::rightmostPosition): Ditto. (WebCore::RenderFlow::leftmostPosition): Ditto. * rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateRects): Avoid clipping out box shadow. * rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Make sure to paint the box shadow when an edge with a shadow moves. (WebCore::RenderObject::adjustRectForOutlineAndShadow): Helper function that expands a given rectangle to encompass outline and box shadow. (WebCore::RenderObject::absoluteOutlineBox): Changed to include box shadow. * rendering/RenderObject.h: 2007-05-19 Mitz Pettel <mitz@webkit.org> Reviewed by Dave Hyatt. - repaint tests and updated results for http://bugs.webkit.org/show_bug.cgi?id=12729 box-shadow disappears when scrolling a div that it falls on/under * fast/box-shadow/basic-shadows-expected.checksum: * fast/box-shadow/basic-shadows-expected.png: * fast/box-shadow/basic-shadows-expected.txt: * fast/repaint/box-shadow-dynamic-expected.checksum: Added. * fast/repaint/box-shadow-dynamic-expected.png: Added. * fast/repaint/box-shadow-dynamic-expected.txt: Added. * fast/repaint/box-shadow-dynamic.html: Added. * fast/repaint/box-shadow-h-expected.checksum: Added. * fast/repaint/box-shadow-h-expected.png: Added. * fast/repaint/box-shadow-h-expected.txt: Added. * fast/repaint/box-shadow-h.html: Added. * fast/repaint/box-shadow-v-expected.checksum: Added. * fast/repaint/box-shadow-v-expected.png: Added. * fast/repaint/box-shadow-v-expected.txt: Added. * fast/repaint/box-shadow-v.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Update test results after r21597. * fast/frames/viewsource-attribute-expected.checksum: * fast/frames/viewsource-attribute-expected.png: * fast/frames/viewsource-attribute-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Reviewed by Darin. - fix http://bugs.webkit.org/show_bug.cgi?id=13774 REGRESSION: Crash emailing blog entry using Google Reader Test: fast/table/stale-grid-crash.html * rendering/RenderTable.cpp: (WebCore::RenderTable::recalcSections): Made const and replaced setNeedsLayout(true) with an assertion that the table is already marked for layout. (WebCore::RenderTable::sectionAbove): Added call to recalcSectionsIfNeeded(). (WebCore::RenderTable::sectionBelow): Ditto. (WebCore::RenderTable::cellAbove): Ditto. (WebCore::RenderTable::cellBelow): Ditto. (WebCore::RenderTable::cellBefore): Ditto. (WebCore::RenderTable::cellAfter): Ditto. * rendering/RenderTable.h: Made some private member variables which are used in section recalc mutable. (WebCore::RenderTable::setNeedsSectionRecalc): Moved the call to setNeedsLayout() from recalcSections() into here, because I made recalcSections() const. (WebCore::RenderTable::recalcSectionsIfNeeded): Made const. 2007-05-19 Mitz Pettel <mitz@webkit.org> Reviewed by Darin. - test for http://bugs.webkit.org/show_bug.cgi?id=13774 REGRESSION: Crash emailing blog entry using Google Reader * fast/table/stale-grid-crash-expected.checksum: Added. * fast/table/stale-grid-crash-expected.png: Added. * fast/table/stale-grid-crash-expected.txt: Added. * fast/table/stale-grid-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bdash authored
Reviewed by Darin. - http://bugs.webkit.org/show_bug.cgi?id=13320 rounded corners with drop shadows are really slow Test for a rendering bug fixed by this patch: fast/box-shadow/border-radius-big.html No test for the performance ingredient. * platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::addRoundedRectClip): Made cross-platform. Changed to use a single clipping path. If all the radii cannot be accommodated, clips to a rect. (WebCore::GraphicsContext::clipOutRoundedRect): Changed to use a single clipping path. If all the radii cannot be accommodated, clips out a rect. * platform/graphics/GraphicsContext.h: Added clipOut(const Path&). * platform/graphics/Path.cpp: (WebCore::Path::createRoundedRectangle): Added. Returns a rounded rectangle with the specified radii. If all the radii cannot be accommodated, returns a rectangular path. * platform/graphics/Path.h: * platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clipOut): Added. * platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRoundedRect): Changed to use a single path. (WebCore::GraphicsContext::clipOut): Added. * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clipOut): Added. 2007-05-19 Mitz Pettel <mitz@webkit.org> Reviewed by Darin. - http://bugs.webkit.org/show_bug.cgi?id=13320 rounded corners with drop shadows are really slow * fast/box-shadow/border-radius-big-expected.checksum: Added. * fast/box-shadow/border-radius-big-expected.png: Added. * fast/box-shadow/border-radius-big-expected.txt: Added. * fast/box-shadow/border-radius-big.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca authored
Reviewed by Mitz. http://bugs.webkit.org/show_bug.cgi?id=13771 Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester * fast/frames/inline-object-inside-frameset-expected.txt: Added. * fast/frames/inline-object-inside-frameset.html: Added. WebCore: Reviewed by Mitz. Test: fast/frames/inline-object-inside-frameset.html http://bugs.webkit.org/show_bug.cgi?id=13771 Assertion failure ASSERT(m_layer) when running Hamachi fuzz tester Don't paint inline objects. * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::paint): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 18 May, 2007 3 commits
-
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-