1. 02 Dec, 2009 25 commits
  2. 01 Dec, 2009 15 commits
    • levin@chromium.org's avatar
      Incorrect code in WebGLRenderingContext.cpp · dbff04db
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=32046
      
      Reviewed by Eric Seidel.
      
      Fix incorrect code that happened to work. != has higher precendence than &.
      The simplest fix is to remove the "!= 0" which violates WebKit style
      guidelines anyway.
      
      Also added periods to few comments in the same function.
      
      * html/canvas/WebGLRenderingContext.cpp:
      (WebCore::WebGLRenderingContext::validateIndexArray):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbff04db
    • eric@webkit.org's avatar
      2009-12-01 Chris Jerdonek <chris.jerdonek@gmail.com> · 0dd54ad2
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Added clarifications to the web site regarding coding style and
              code cleanup--
      
              https://bugs.webkit.org/show_bug.cgi?id=31618
      
              Changes include the following:
      
              - Expanded the style guidelines regarding "using" statements.
              - Made the style guidelines page validate as HTML.
              - Added that legacy WebKit components should not be cleaned up.
              - Added that it is more acceptable to update style when already
                touching code.
      
              * coding/coding-style.html:
              * coding/contributing.html:
              * projects/cleanup/index.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0dd54ad2
    • hamaji@chromium.org's avatar
      2009-12-01 Shinichiro Hamaji <hamaji@chromium.org> · 285d949b
      hamaji@chromium.org authored
              Reviewed by Eric Seidel.
      
              Update expectations of css2.1/t1205-c56* for Qt
              https://bugs.webkit.org/show_bug.cgi?id=32015
      
              * platform/qt/Skipped:
              * platform/qt/css2.1/t1205-c561-list-displ-00-b-expected.txt:
              * platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.txt:
              * platform/qt/css2.1/t1205-c566-list-stl-00-e-ag-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      285d949b
    • eric@webkit.org's avatar
      2009-12-01 Yaar Schnitman <yaar@chromium.org> · 70a75528
      eric@webkit.org authored
              build-webkit: Remove flex,bison,gperf check for chromium
              https://bugs.webkit.org/show_bug.cgi?id=32043
      
              * Scripts/webkitdirs.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70a75528
    • eric@webkit.org's avatar
      2009-12-01 Kent Tamura <tkent@chromium.org> · 26d4a7e3
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Change [Reflect] to [ConvertNullToNullString, Reflect] for min, max,
              pattern and step attributes of HTMLInputElement.
              https://bugs.webkit.org/show_bug.cgi?id=31708
      
              * fast/forms/input-minmax-expected.txt:
              * fast/forms/input-pattern-expected.txt: Added.
              * fast/forms/input-pattern.html: Added.
              * fast/forms/input-step-expected.txt:
              * fast/forms/script-tests/input-minmax.js: Add tests for null/undefined/non-string.
              * fast/forms/script-tests/input-pattern.js: Added.
              * fast/forms/script-tests/input-step.js: Change the result for null.
      2009-12-01  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Darin Adler.
      
              Change [Reflect] to [ConvertNullToNullString, Reflect] for min, max,
              pattern and step attributes of HTMLInputElement.
              https://bugs.webkit.org/show_bug.cgi?id=31708
      
              * html/HTMLInputElement.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26d4a7e3
    • cfleizach@apple.com's avatar
      Build fixage for Windows/GTK for DumpRenderTree. · d1b4e8fd
      cfleizach@apple.com authored
      WAI-ARIA: implement support for ARIA drag and drop
      https://bugs.webkit.org/show_bug.cgi?id=32007
      
      * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
      (AccessibilityUIElement::ariaIsGrabbed):
      (AccessibilityUIElement::ariaDropEffects):
      * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
      (AccessibilityUIElement::ariaIsGrabbed):
      (AccessibilityUIElement::ariaDropEffects):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1b4e8fd
    • cfleizach@apple.com's avatar
      WAI-ARIA: implement support for ARIA drag and drop · b012c5ea
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=32007
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Test: platform/mac/accessibility/aria-drag-drop.html
      
      * accessibility/AccessibilityObject.h:
      (WebCore::AccessibilityObject::supportsARIADropping):
      (WebCore::AccessibilityObject::supportsARIADragging):
      (WebCore::AccessibilityObject::isARIAGrabbed):
      (WebCore::AccessibilityObject::setARIAGrabbed):
      (WebCore::AccessibilityObject::determineARIADropEffects):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::supportsARIADropping):
      (WebCore::AccessibilityRenderObject::supportsARIADragging):
      (WebCore::AccessibilityRenderObject::isARIAGrabbed):
      (WebCore::AccessibilityRenderObject::setARIAGrabbed):
      (WebCore::AccessibilityRenderObject::determineARIADropEffects):
      * accessibility/AccessibilityRenderObject.h:
      * accessibility/mac/AccessibilityObjectWrapper.mm:
      (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
      (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      (-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
      (-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
      * html/HTMLAttributeNames.in:
      
      WebKitTools: 
      
      * DumpRenderTree/AccessibilityUIElement.cpp:
      (getARIADropEffectsCallback):
      (getARIAIsGrabbedCallback):
      (AccessibilityUIElement::getJSClass):
      * DumpRenderTree/AccessibilityUIElement.h:
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (AccessibilityUIElement::ariaIsGrabbed):
      (AccessibilityUIElement::ariaDropEffects):
      
      LayoutTests: 
      
      * platform/mac/accessibility/aria-drag-drop-expected.txt: Added.
      * platform/mac/accessibility/aria-drag-drop.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b012c5ea
    • abarth@webkit.org's avatar
      Typo fix. · 344da20d
      abarth@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      344da20d
    • abarth@webkit.org's avatar
      2009-12-01 Adam Barth <abarth@webkit.org> · 345d17f8
      abarth@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=21288
      
              Unreviewed port of @sandbox to V8.
      
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::isEnabled):
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              (WebCore::createWindow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      345d17f8
    • abarth@webkit.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=21288 · 8c5918e6
      abarth@webkit.org authored
      Reviewed by Darin Adler.
      
      Add sneaky test that has tabs.
      
      * fast/frames/sandboxed-iframe-attribute-parsing-expected.txt: Added.
      * fast/frames/sandboxed-iframe-attribute-parsing.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c5918e6
    • bweinstein@apple.com's avatar
      Change unsigned to int to fix the Windows build. · 18d381ea
      bweinstein@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18d381ea
    • abarth@webkit.org's avatar
      2009-12-01 Patrik Persson <patrik.j.persson@ericsson.com> · b8a10552
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Implement HTML5 sandbox attribute for iframes.
              http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox
              https://bugs.webkit.org/show_bug.cgi?id=21288
      
              * fast/frames/resources/non-sandboxed-iframe-navigation.html: Added.
              * fast/frames/resources/sandboxed-iframe-attribute-parsing-allowed.html: Added.
              * fast/frames/resources/sandboxed-iframe-attribute-parsing-disallowed.html: Added.
              * fast/frames/resources/sandboxed-iframe-form-allowed.html: Added.
              * fast/frames/resources/sandboxed-iframe-form-disallowed.html: Added.
              * fast/frames/resources/sandboxed-iframe-navigated.html: Added.
              * fast/frames/resources/sandboxed-iframe-navigation-child.html: Added.
              * fast/frames/resources/sandboxed-iframe-navigation-navigated.html: Added.
              * fast/frames/resources/sandboxed-iframe-navigation-parent.html: Added.
              * fast/frames/resources/sandboxed-iframe-navigation-source.html: Added.
              * fast/frames/resources/sandboxed-iframe-navigation-targetlink.html: Added.
              * fast/frames/resources/sandboxed-iframe-navigation-windowopen.html: Added.
              * fast/frames/resources/sandboxed-iframe-plugins-frame-applet.html: Added.
              * fast/frames/resources/sandboxed-iframe-plugins-frame-embed.html: Added.
              * fast/frames/resources/sandboxed-iframe-plugins-frame-object.html: Added.
              * fast/frames/resources/sandboxed-iframe-script-dynamic.html: Added.
              * fast/frames/resources/sandboxed-iframe-storage-allowed.html: Added.
              * fast/frames/resources/sandboxed-iframe-storage-disallowed.html: Added.
              * fast/frames/sandboxed-iframe-attribute-parsing-expected.txt: Added.
              * fast/frames/sandboxed-iframe-attribute-parsing.html: Added.
              * fast/frames/sandboxed-iframe-forms-expected.txt: Added.
              * fast/frames/sandboxed-iframe-forms.html: Added.
              * fast/frames/sandboxed-iframe-navigation-allowed-expected.txt: Added.
              * fast/frames/sandboxed-iframe-navigation-allowed.html: Added.
              * fast/frames/sandboxed-iframe-navigation-parent-expected.txt: Added.
              * fast/frames/sandboxed-iframe-navigation-parent.html: Added.
              * fast/frames/sandboxed-iframe-navigation-targetlink-expected.txt: Added.
              * fast/frames/sandboxed-iframe-navigation-targetlink.html: Added.
              * fast/frames/sandboxed-iframe-navigation-windowopen-expected.txt: Added.
              * fast/frames/sandboxed-iframe-navigation-windowopen.html: Added.
              * fast/frames/sandboxed-iframe-plugins-expected.txt: Added.
              * fast/frames/sandboxed-iframe-plugins.html: Added.
              * fast/frames/sandboxed-iframe-scripting-expected.txt: Added.
              * fast/frames/sandboxed-iframe-scripting.html: Added.
              * fast/frames/sandboxed-iframe-storage-expected.txt: Added.
              * fast/frames/sandboxed-iframe-storage.html: Added.
              * http/tests/security/resources/sandboxed-iframe-document-cookie-read-denied.html: Added.
              * http/tests/security/resources/sandboxed-iframe-modify-self.html: Added.
              * http/tests/security/resources/xss-DENIED-sandboxed-iframe-attacker.html: Added.
              * http/tests/security/sandboxed-iframe-document-cookie-expected.txt: Added.
              * http/tests/security/sandboxed-iframe-document-cookie.html: Added.
              * http/tests/security/sandboxed-iframe-modify-self-expected.txt: Added.
              * http/tests/security/sandboxed-iframe-modify-self.html: Added.
              * http/tests/security/xss-DENIED-sandboxed-iframe-expected.txt: Added.
              * http/tests/security/xss-DENIED-sandboxed-iframe.html: Added.
              * http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-expected.txt: Added.
              * http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html: Added.
              * http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt: Added.
              * http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt: Added.
              * http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard.html: Added.
              * http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied.html: Added.
              * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow-iframe.html: Added.
              * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow.cgi: Added.
              * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-iframe.html: Added.
              * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-without-wildcard-iframe.html: Added.
              * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-without-wildcard.cgi: Added.
              * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied.cgi: Added.
      2009-12-01  Patrik Persson  <patrik.j.persson@ericsson.com>
      
              Reviewed by Darin Adler.
      
              Implement HTML5 sandbox attribute for iframes.
              http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox
              https://bugs.webkit.org/show_bug.cgi?id=21288
      
              Tests: fast/frames/sandboxed-iframe-attribute-parsing.html
                     fast/frames/sandboxed-iframe-forms.html
                     fast/frames/sandboxed-iframe-navigation-allowed.html
                     fast/frames/sandboxed-iframe-navigation-parent.html
                     fast/frames/sandboxed-iframe-navigation-targetlink.html
                     fast/frames/sandboxed-iframe-navigation-windowopen.html
                     fast/frames/sandboxed-iframe-plugins.html
                     fast/frames/sandboxed-iframe-scripting.html
                     fast/frames/sandboxed-iframe-storage.html
                     http/tests/security/sandboxed-iframe-document-cookie.html
                     http/tests/security/sandboxed-iframe-modify-self.html
                     http/tests/security/xss-DENIED-sandboxed-iframe.html
                     http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html
                     http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard.html
                     http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied.html
      
              * bindings/js/JSDOMWindowCustom.cpp: sandboxing navigation
              (WebCore::createWindow):
              * bindings/js/ScriptController.cpp: sandboxing scripts
              (WebCore::ScriptController::isEnabled):
              * dom/Document.cpp:
              (WebCore::Document::processHttpEquiv):
              (WebCore::Document::cookie): raise exception when accessed from sandbox
              (WebCore::Document::setCookie): raise exception when accessed from sandbox
              (WebCore::Document::initSecurityContext): updae sandbox status
              (WebCore::Document::updateSandboxFlags):
              * dom/Document.h:
              * dom/Document.idl:
              * html/HTMLAppletElement.cpp: sandboxing applets
              (WebCore::HTMLAppletElement::createRenderer):
              (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
              (WebCore::HTMLAppletElement::canEmbedJava):
              * html/HTMLAppletElement.h:
              * html/HTMLAttributeNames.in:
              * html/HTMLFrameOwnerElement.cpp: management of sandbox flags as stated in attribute
              (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
              (WebCore::HTMLFrameOwnerElement::setSandboxFlags):
              * html/HTMLFrameOwnerElement.h:
              (WebCore::HTMLFrameOwnerElement::sandboxFlags):
              * html/HTMLIFrameElement.cpp: sandbox attribute parsing
              (WebCore::parseSandboxAttribute):
              (WebCore::HTMLIFrameElement::parseMappedAttribute):
              * html/HTMLIFrameElement.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::getCookies):
              * loader/CrossOriginAccessControl.cpp:
              (WebCore::passesAccessControlCheck):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::FrameLoader):
              (WebCore::FrameLoader::init):
              (WebCore::FrameLoader::submitForm): sandboxing forms
              (WebCore::FrameLoader::requestObject): sandboxing plugins
              (WebCore::FrameLoader::shouldAllowNavigation): sandboxing navigation
              (WebCore::FrameLoader::updateSandboxFlags): propagation of sandbox flags
              * loader/FrameLoader.h:
              (WebCore::FrameLoader::ownerElementSandboxFlagsChanged):
              (WebCore::FrameLoader::isSandboxed):
              (WebCore::FrameLoader::sandboxFlags):
              * loader/FrameLoaderTypes.h:
              (WebCore::):
              * page/DOMWindow.cpp: disable storage and databases in sandboxed frames
              (WebCore::DOMWindow::sessionStorage):
              (WebCore::DOMWindow::localStorage):
              (WebCore::DOMWindow::openDatabase):
              * page/SecurityOrigin.cpp: added sandboxing status
              (WebCore::SecurityOrigin::SecurityOrigin):
              (WebCore::SecurityOrigin::canAccess):
              (WebCore::SecurityOrigin::canRequest):
              (WebCore::SecurityOrigin::toString):
              * page/SecurityOrigin.h:
              (WebCore::SecurityOrigin::setSandboxFlags):
              (WebCore::SecurityOrigin::isSandboxed):
              (WebCore::SecurityOrigin::canAccessDatabase):
              (WebCore::SecurityOrigin::canAccessStorage):
              * websockets/WebSocketChannel.cpp:
              (WebCore::WebSocketChannel::didReceiveData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8a10552
    • cfleizach@apple.com's avatar
      ARIA: support a way to create a static text object · bd43f07d
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=32030
      
      Reviewed by David Kilzer.
      
      WebCore: 
      
      Test: accessibility/aria-text-role.html
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::createARIARoleMap):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::stringValue):
      (WebCore::AccessibilityRenderObject::isDescendantOfBarrenParent):
      (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
      (WebCore::AccessibilityRenderObject::text):
      * accessibility/AccessibilityRenderObject.h:
      
      LayoutTests: 
      
      * accessibility/aria-text-role-expected.txt: Added.
      * accessibility/aria-text-role.html: Added.
      * platform/gtk/Skipped:
      * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd43f07d
    • zimmermann@webkit.org's avatar
      Not reviewed. GTK DRT try 2. · 0067edb7
      zimmermann@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0067edb7
    • zimmermann@webkit.org's avatar
      Not reviewed. Try to fix gtk DRT build. · 03e0a333
      zimmermann@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03e0a333