1. 29 Mar, 2007 10 commits
  2. 28 Mar, 2007 11 commits
    • oliver's avatar
      2007-03-28 Oliver Hunt <oliver@apple.com> · 1c8a4876
      oliver authored
              Reviewed by Anders and Steve.
              Add a flag to DocLoader to prevent it from reloading 
              when performing a paste or drop operation.
              Remove m_cachePolicy from CachedResource as it is never used
              Fixes rdar://problem/5044366 : REGRESSION: Repro ASSERT failures 
              dragging image into GMail message in _web_writeImage and 
              * editing/Editor.cpp:
                prevent the docloader from reloading resources on paste
              * html/HTMLImageLoader.cpp:
              * loader/Cache.cpp:
              * loader/CachedCSSStyleSheet.cpp:
              * loader/CachedCSSStyleSheet.h:
              * loader/CachedImage.cpp:
              * loader/CachedImage.h:
              * loader/CachedResource.cpp:
              * loader/CachedResource.h:
              * loader/CachedScript.cpp:
              * loader/CachedScript.h:
              * loader/CachedXBLDocument.cpp:
              * loader/CachedXBLDocument.h:
              * loader/CachedXSLStyleSheet.cpp:
              * loader/CachedXSLStyleSheet.h:
              * loader/DocLoader.cpp:
                 Tidy up constructor initialise new field
                 Prevent reload when pasting
              * loader/DocLoader.h:
                new field and setter
              * page/DragController.cpp:
                prevent the docloader from reloading resources on drop
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • kjk's avatar
      Not reviewed - fix typo in gdk build. · b6a0acea
      kjk authored
              * platform/gdk/ScrollViewGdk.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mjs's avatar
      LayoutTests: · 14590a57
      mjs authored
              Reviewed by Darin.
              - <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
              * fast/overflow/scrollRevealButton-expected.checksum:
              * fast/overflow/scrollRevealButton-expected.png:
              * fast/overflow/scrollRevealButton-expected.txt:
              Reviewed by Darin.
              - fixed <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
              Handle scrolling external scrollviews around the webview during
              autoscroll or when scrolling into view.
              This should also restore performance on BenchJS test 6 lost due to Tim's partial fix.
              * page/FrameView.cpp:
              * page/FrameView.h:
              * platform/ScrollView.h:
              * platform/gdk/ScrollViewGdk.cpp:
              * platform/mac/ScrollViewMac.mm:
              * platform/qt/ScrollViewQt.cpp:
              * platform/win/ScrollViewWin.cpp:
              * platform/win/TemporaryLinkStubs.cpp:
              * rendering/RenderLayer.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele's avatar
      Reviewed by Brady. · 1d3bb180
      adele authored
              Update to last fix.
              * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK.
              * WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]):
              Added check to only use the VitalSource workaround if the app is not linked on or after
              the defined WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK version number.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed and landed by Darin · 993602c1
      darin authored
              Get rid of some misuses of |islower| and |tolower| for non-ASCII characters.
              * platform/StringImpl.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • antti's avatar
      Reviewed by Hyatt. · 60c2cceb
      antti authored
              Fix <rdar://problem/5092653>
              REGRESSION: Image decoding making scrolling slow
              If decoder gave back a null frame (which I think happens regularly if you don't have full frame 
              data yet for image that does not decode incrementally) m_decodedSize was incremented anyway. This
              led to massive growth in calculated image size and eventually made cache prune constantly. 
              No test, I don't know how to make one for this.
              * platform/graphics/BitmapImage.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele's avatar
      WebCore: · cc025d83
      adele authored
              Reviewed by Kevin M.
              WebCore part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString
              * page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
              Convert return value to a string.  This matches the behavior in Safari 2.0.
              Reviewed by Kevin M.
              WebKit part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString
              Added an app specific workaround for VitalSource Bookshelf that strips "return" from the beginning of their script strings.  We used to allow this
              but now we throw a JavaScript exception for return statements that aren't in functions.
              Filed this evangelism bug so we can notify VitalSource of the problem:
              <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString
              * WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • ap's avatar
      Reviewed by Darin. · 16c9b5f7
      ap authored
              XPath incorrectly handles namespaces on attributes
              * xml/XPathStep.cpp:
              (WebCore::XPath::Step::nodesInAxis): Added a special case for faster attribute lookup; gives a slight but 
              measurable performance improvement for bug 13021.
              (WebCore::XPath::Step::nodeMatches): Fixed NameTest for attribute nodes.
              * xml/XPathStep.h:
              Move m_namespaceURI to NodeTest, where it belongs. Removed unused m_nodeTestData (oops!).
              * xml/XPathGrammar.y:
              * xml/XPathPath.cpp:
              Accounted for the above change.
              * fast/xpath/attr-namespace-expected.txt: Added.
              * fast/xpath/attr-namespace.html: Added.
              * fast/xpath/xpath-namespaces-expected.txt:
              * fast/xpath/xpath-namespaces.html:
              Cleaned up; added a couple more cases (which passed anyway, but weren't tested for).
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • antti's avatar
      Update libWebKitSystemInterface, previous version was out of date. · 6ef858f4
      antti authored
              * libWebKitSystemInterface.a:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • oliver's avatar
      2007-03-28 Oliver Hunt <oliver@apple.com> · 1c0320b6
      oliver authored
              Rollout local changes :-/
              * loader/Cache.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • oliver's avatar
      2007-03-28 Oliver Hunt <oliver@apple.com> · 97c1d600
      oliver authored
              Reviewed by Hyatt.
              Roll out r20511 due to incredible badness
              * loader/Cache.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. 27 Mar, 2007 19 commits
    • darin's avatar
      * svg/hixie/text/003-expected.txt: Updated results for this one test that now has · 2a254a04
      darin authored
              different results due to the painting Adele added to DumpRenderTree. Long term,
              we just have to fix SVG so that painting doesn't cause changes to the render tree!
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • oliver's avatar
      2007-03-27 Oliver Hunt <oliver@apple.com> · 798912f8
      oliver authored
              Reviewed by Adam.
              Don't enforce text-selection drag delay when we are
              going to drag an image anyway.
              Fixes rdar://problem/4668935
              * page/EventHandler.cpp:
      Layout tests:
              Test to ensure there is no delay forced when dragging a selected image
              * editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum: Added.
              * editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Added.
              * editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
              * editing/pasteboard/drag-selected-image-to-contenteditable.html: Added.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • andersca's avatar
      JavaScriptCore: · d74e433f
      andersca authored
              Reviewed by Geoff.
              * bindings/NP_jsobject.cpp:
              Call JSObject:call for native JavaScript objects.
              Reviewed by Geoff.
              Add NPN_InvokeDefault test.
              * plugins/netscape-invoke-default-expected.txt: Added.
              * plugins/netscape-invoke-default.html: Added.
              Reviewed by Geoff.
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
              Add new function which takes a function and calls it using NPN_InvokeDefault.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • justing's avatar
      Build fix · 7eaa01a4
      justing authored
              * editing/markup.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • justing's avatar
      LayoutTests: · 7d3dbfed
      justing authored
              Reviewed by darin
              <rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family
              Demonstrates the bug fixed:
              * editing/style/5091898-expected.checksum: Added.
              * editing/style/5091898-expected.png: Added.
              * editing/style/5091898-expected.txt: Added.
              * editing/style/5091898.html: Added.
              Demonstrates a related bug fixed (deleting
              the line break before a paragraph could remove
              its underlining):
              * editing/deleting/5091898-expected.checksum: Added.
              * editing/deleting/5091898-expected.png: Added.
              * editing/deleting/5091898-expected.txt: Added.
              * editing/deleting/5091898.html: Added.
              Demonstrates that a link now (correctly) exists, 
              instead of just underlined text:
              * editing/pasteboard/4840662-expected.txt:
              Reviewed by darin
              <rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family
              createMarkup skipped elements if they were blocks
              when called from moveParagraphs (because that function 
              must receive only inline content).  This patch adds 
              code to inline these blocks instead of skipping them 
              so that we don't lose any of the style that they 
              contribute to the copied markup.
              * editing/markup.cpp:
              (WebCore::startMarkup): Add an inlineBlocks option.
              Make sure to overwrite display:block coming from
              a style sheet or the inline style declaration.
              (WebCore::createMarkup): Don't refuse to include a 
              specialCommonAncestor that's a block if we were asked 
              to include only inline content, since we can now inline 
              block elements in startMarkup.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele's avatar
      Oops- my comment was missing a word. · 97ab9364
      adele authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele's avatar
      Adding comment. · ad634f59
      adele authored
              * DumpRenderTree/DumpRenderTree.m:
              (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele's avatar
      Fix svg tests by calling displayIfNeeded. · 37405f5e
      adele authored
              * DumpRenderTree/DumpRenderTree.m:
              (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • sullivan's avatar
      Reviewed by Tim · 93cf3a55
      sullivan authored
              - fixed <rdar://problem/5092556> Default UA spoofing is always off until explicitly toggled
              * WebView/WebView.mm:
              (-[WebView _commonInitializationWithFrameName:groupName:]):
              initialize the cached value of _private->useSiteSpecificSpoofing here; formerly it would not
              be initialized correctly in the common case of WebViews that use [WebPreferences standardPreferences]
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele's avatar
      Reviewed by Hyatt. · 7c2f10dc
      adele authored
              Fix for <rdar://problem/5026141> REGRESSION: Aperture Viewer Flashes when switching from Index Page to Detail page in Web Gallery
              This disables the paint that occurs after WebCore finishes loading the document.  We should reenable this when we
              move the dispatchDidFinishLoad delegate callback to happen around the same time as the JS onload call.  See <rdar://problem/5092361>.
              * dom/Document.cpp: (WebCore::Document::implicitClose):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • justing's avatar
      LayoutTests: · dcdb2794
      justing authored
              Reviewed by darin
              <rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
              <rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
              <rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
              <rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented
              * editing/pasteboard/5065605-expected.checksum: Added.
              * editing/pasteboard/5065605-expected.png: Added.
              * editing/pasteboard/5065605-expected.txt: Added.
              * editing/pasteboard/5065605.html: Added.
              * editing/style/4916887-expected.checksum: Added.
              * editing/style/4916887-expected.png: Added.
              * editing/style/4916887-expected.txt: Added.
              * editing/style/4916887.html: Added.
              * editing/style/5065910-expected.checksum: Added.
              * editing/style/5065910-expected.png: Added.
              * editing/style/5065910-expected.txt: Added.
              * editing/style/5065910.html: Added.
              * editing/style/5084241-expected.checksum: Added.
              * editing/style/5084241-expected.png: Added.
              * editing/style/5084241-expected.txt: Added.
              * editing/style/5084241.html: Added.
              Reviewed by darin
              <rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
              <rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
              <rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
              <rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented
              * css/CSSComputedStyleDeclaration.cpp:
              If a node's text fill color is invalid, then its children use 
              their font-color as their text fill color (they don't inherit 
              it).  Likewise for stroke color.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • andersca's avatar
      * platform/ScrollBar.h: · c3c0159f
      andersca authored
              Use wtf/MathExtras.h instead of math.h
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • bdash's avatar
      2007-03-27 Mark Rowe <mrowe@apple.com> · 68cd801b
      bdash authored
              Reviewed by Dave Harrison.
              * Configurations/WebKit.xcconfig: Include UMBRELLA_FRAMEWORKS_DIR in framework search path.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • zack's avatar
      Fix the build · ad1986b4
      zack authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • oliver's avatar
      2007-03-27 Oliver Hunt <oliver@apple.com> · 93990f86
      oliver authored
              Reviewed by Maciej.
              The WebArchiver needs all the subresources of a document to be accessible
              through the DocLoader, so we can't remove a CachedResource simultaneously
              from the global Cache and all DocLoaders, just because it needs to be 
              reloaded in one.
              Fixes rdar://problem/5044366
              * loader/Cache.cpp:
                 Don't evict the resource from all DocLoaders
              * manual-tests/test-iframes-loading-the-same-resource.html: Added.
                 Alas it wasn't possible to make a nice layout test, even this manual test
                 is not entirely deterministic
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • bdash's avatar
      2007-03-27 Mark Rowe <mrowe@apple.com> · 0b93c7ef
      bdash authored
              Build fix.
              * platform/GlyphBuffer.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • zack's avatar
      Fix the rendering crashes due to triggered · e44b3300
      zack authored
      asserts and improve a bit the layout scheduling in the
      Qt port
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Add support for glyph offsets to the GlyphBuffer. · 701900a4
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • antti's avatar
      Keep buildbot happy. · 4e73c473
      antti authored
              * platform/mac/PlatformScrollBarMac.mm:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20507 268f45cc-cd09-0410-ab3c-d52691b4dbfc