1. 04 Sep, 2012 1 commit
  2. 29 Aug, 2012 1 commit
    • commit-queue@webkit.org's avatar
      [chromium] Implement disambiguation popup (a.k.a. Link Preview) · dffbcdaf
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94182
      
      Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-08-29
      Reviewed by Adam Barth.
      
      In this new implementation, we add a new WebViewClient::handleDisambiguationPopup delegate.
      The disambiguation sequence will be initiated by the gesture event handler
      in WebViewImpl if an ambiguous tap is detected, then
      m_client->handleDisambiguationPopup will be called, so the embedder can
      decide whether to swallow the touch event and show a popup.
      
      New test: WebFrameTest.DisambiguationPopupTest
      
      * WebKit.gyp:
      * features.gypi:
      * public/WebInputEvent.h:
      (WebGestureEvent):
      (WebKit::WebGestureEvent::WebGestureEvent):
      * public/WebTouchCandidatesInfo.h: Removed.
      * public/WebView.h:
      (WebKit):
      * public/WebViewClient.h:
      (WebKit):
      (WebViewClient):
      (WebKit::WebViewClient::triggersLinkPreview):
      * src/WebInputEvent.cpp:
      (SameSizeAsWebGestureEvent):
      * src/WebViewImpl.cpp:
      (WebKit):
      (WebKit::WebViewImpl::handleGestureEventWithLinkPreview):
      (WebKit::WebViewImpl::handleGestureEvent):
      * src/WebViewImpl.h:
      (WebViewImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127095 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dffbcdaf
  3. 21 Aug, 2012 1 commit
    • leandrogracia@chromium.org's avatar
      [Chromium] Find-in-page coordinates should use containingBlock · 974cf5e2
      leandrogracia@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94343
      
      Reviewed by Julien Chaffraix.
      
      The current implementation uses the container method to climb the render tree.
      However, it would be more correct and convenient to use containingBlock instead.
      Also, this patch introduces new tests for find-in-page coordinates in tables.
      
      * src/FindInPageCoordinates.cpp:
      (WebKit::toNormalizedRect): use containingBlock and get rid of the output parameter as it's not required now.
      (WebKit::findInPageRectFromAbsoluteRect): use containingBlock introduce some simplifications.
      * tests/WebFrameTest.cpp: add new tests for tables.
      * tests/data/find_in_page.html:
      * tests/data/find_in_page_frame.html: new tests for tables.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      974cf5e2
  4. 14 Aug, 2012 1 commit
    • commit-queue@webkit.org's avatar
      [chromium] Add a test to WebFrameTest for selectRange and visiblePositionForWindowPoint. · 19f16304
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93108
      
      Patch by Iain Merrick <husky@chromium.org> on 2012-08-14
      Reviewed by Adam Barth.
      
      Adds a new test WebFrameTest.SelectRange. This tests WebFrameImpl::selectRange,
      and also serves to test WebFrameImpl::visiblePositionForWindowPoint as it is
      used by selectRange.
      
      The test uses sample files that contain selected text on load. The test uses
      WebViewImpl::selectionBounds to get the coordinates, deselects all, then
      calls WebFrameImpl::selectRange to attempt to reselect the same text.
      
      Four cases are tested:
      - the basic case
      - the case where the selected text is offscreen due to a scroll
      - the case where the selected text is in an iframe
      - the case where the selected text is in an editable element
      
      * tests/WebFrameTest.cpp:
      * tests/data/select_range_basic.html: Added.
      * tests/data/select_range_editable.html: Added.
      * tests/data/select_range_iframe.html: Added.
      * tests/data/select_range_scroll.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19f16304
  5. 12 Aug, 2012 1 commit
    • leandrogracia@chromium.org's avatar
      [Chromium] Implement the find-in-page match rects API · 5b94144f
      leandrogracia@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93111
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Introduce the find-in-page coordinate system. This system tries to solve
      the unintuitive tickmark results presented in pages with multiple frames
      and scrolled contents where the find results might not be in the visible
      area of a frame, which might lead to tickmarks below the container frame.
      
      To achieve this, this coordinate system goes up the render tree
      normalizing the coordinates by the actual contents size of its container.
      This leads to tickmarks scaled to the visible size of their frame
      independently of its scroll. This coordinate system supports also CSS
      scroll:overflow, transforms and the different positions.
      
      Also add an auxiliary method to Range in order to provide a transform
      friendly way to retrieve the absolute coordinates of the enclosing
      bounding box without the adjustment operations that the existing
      enclosingRect method does.
      
      Tested by WebFrameTest WebKit unit test.
      
      * dom/Range.cpp:
      (WebCore::Range::transformFriendlyBoundingBox): add a transform-friendly equivalent of boundingBox.
      (WebCore):
      * dom/Range.h: move boundingBox to the group of non-transform-friendly methods.
      (Range):
      
      Source/WebKit/chromium:
      
      Implement the funcionality of the find-in-page match rects API in WebFrame.
      These methods keep a cache of the match rects in a special coordinate system
      (find-in-page coordinates) and update them on size changes. They also allow
      to recover the match closest to a given point, therefore enabling to move
      to find matches when tapping on their corresponding tickmarks.
      
      * WebKit.gyp: add FindInPageCoordinates.h / cpp.
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::contentsSizeChanged): propagate didChangeContentsSize to WebFrameImpl.
      * src/FindInPageCoordinates.cpp: Added.
      (WebKit):
      (WebKit::toNormalizedRect): auxiliary internal function.
      (WebKit::findInPageRectFromAbsoluteRect): main coordinate conversion function.
      (WebKit::findInPageRectFromRange): convenience conversion function for Ranges.
      * src/FindInPageCoordinates.h: Added.
      (WebCore):
      (WebKit):
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::FindMatch::FindMatch): find matches cache constructor.
      (WebKit):
      (WebKit::WebFrameImpl::find): clear match cache when appropriate and zoom into results on the Android port.
      (WebKit::WebFrameImpl::stopFinding): clear matches cache.
      (WebKit::WebFrameImpl::scopeStringMatches): add new results to the matches cache.
      (WebKit::WebFrameImpl::increaseMatchCount): update the matches cache version.
      (WebKit::WebFrameImpl::resetMatchCount): update the matches cache version.
      (WebKit::WebFrameImpl::findMatchMarkersVersion): new API providing the matches cache version.
      (WebKit::WebFrameImpl::clearFindMatchesCache): internal utility method to reset the matches cache.
      (WebKit::WebFrameImpl::isActiveMatchFrameValid): internal utility method to check if the local frame is still in the frame tree.
      (WebKit::WebFrameImpl::updateFindMatchRects): internal utility method to update the match result rects if required.
      (WebKit::WebFrameImpl::activeFindMatchRect): new API providing the active find match rect in find-in-page coordinates.
      (WebKit::WebFrameImpl::findMatchRects): new API returning the valid match rects in find-in-page coordinates.
      (WebKit::WebFrameImpl::appendFindMatchRects): internal utility method to concatenate the match results of multiple frames.
      (WebKit::WebFrameImpl::selectNearestFindMatch): new API selecting the find match closer to a point in find-in-page coordinates.
      (WebKit::WebFrameImpl::nearestFindMatch): internal utility method to find the nearest find match to a point in a frame.
      (WebKit::WebFrameImpl::selectFindMatch): internal utility method to select a match in the cache.
      (WebKit::WebFrameImpl::WebFrameImpl): initialization of new variables.
      (WebKit::WebFrameImpl::didChangeContentsSize): invalidate the cached match rect coordinates on frame content size changes.
      * src/WebFrameImpl.h:
      (WebCore):
      (WebFrameImpl):
      (WebKit::WebFrameImpl::activeMatchFrame): remove unrequired const.
      (WebKit::WebFrameImpl::activeMatch): expose the range of the active match to allow testing.
      (FindMatch): cache structure for find matches.
      * tests/WebFrameTest.cpp: new test case for find-in-page match rects.
      * tests/data/find_in_page.html: Added. Test case layout.
      * tests/data/find_in_page_frame.html: Added. Test case layout.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b94144f
  6. 08 Aug, 2012 1 commit
    • abarth@webkit.org's avatar
      Crash when reloading a Chromium "platform" app · 67996f4a
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93497
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      The framework for Chromium "platform" apps executes a big blob of
      script during the didCreateScriptContext callback. This blob of scripts
      interacts with a bunch of JavaScript objects and triggers a number of
      security checks.
      
      When reloading a frame, the didCreateScriptContext is called during
      Frame::setDocument (as a consequence of calling
      ScriptController::updateDocument). At that time, the SecurityOrigin
      object hasn't yet been copied over to the DOMWindow, and we crash
      trying to grab it.
      
      The long-term fix for this bug is to fix
      https://bugs.webkit.org/show_bug.cgi?id=75793, at which point there
      will no longer be a SecurityOrigin object on DOMWindow. In the
      meantime, however, we can fix this crash by null checking the
      DOMWindow's SecurityOrigin object.
      
      * bindings/generic/BindingSecurity.cpp:
      (WebCore::canAccessDocument):
      
      Source/WebKit/chromium:
      
      Test that we don't crash when executing script during the
      didCreateScriptContext callback.
      
      * tests/WebFrameTest.cpp:
      * tests/data/hello_world.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67996f4a
  7. 06 Aug, 2012 1 commit
    • commit-queue@webkit.org's avatar
      Adding APIs to Chromium WebKit API to allow for creating and monitoring frame hierarchy. · 358d5c87
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=93127
      
      Patch by Nasko Oskov <nasko@chromium.org> on 2012-08-06
      Reviewed by Adam Barth.
      
      Add support in the API to monitor and create frame hierarchy to allow replicating it
      across different instances of WebKit.
      
      * public/WebDocument.h:
      (WebDocument): Added createElement.
      * public/WebFrame.h: Added assignedName.
      * public/WebFrameClient.h:
      (WebFrameClient):
      (WebKit::WebFrameClient::didCreateFrame): Added to allow embedders to know when frames are created.
      (WebKit::WebFrameClient::willCheckAndDispatchMessageEvent): Added the target frame as a parameter.
      * public/WebNode.h:
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::willCheckAndDispatchMessageEvent):
      * src/WebDocument.cpp:
      (WebKit::WebDocument::createElement): Added to allow for creating frame elements.
      (WebKit):
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::uniqueName): Added to migrate callers to the matching WebCore API.
      (WebKit):
      (WebKit::WebFrameImpl::assignedName): Returns the name given to a frame, as opposed
      to the unique name, generated by WebKit.
      (WebKit::WebFrameImpl::createChildFrame): Added call to the frame client's didCreateFrame.
      * src/WebFrameImpl.h:
      (WebFrameImpl):
      * src/WebNode.cpp:
      (WebKit::WebNode::appendChild): Added to allow for adding elements to the DOM.
      (WebKit):
      * tests/WebFrameTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@124790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      358d5c87
  8. 03 Aug, 2012 2 commits
  9. 11 Jul, 2012 1 commit
    • shawnsingh@chromium.org's avatar
      [chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests · f9027df3
      shawnsingh@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90094
      
      Reviewed by Adrienne Walker.
      
      This patch adds the WEBKIT_IMPLEMENTATION = 1 define to
      WebKitUnitTests.gyp. To get it to compile correctly, some string
      and URL code was refactored and fixed, in particular GURL usage is
      replaced with KURL usage.
      
      * WebKit.gyp:
      added WEBKIT_IMPLEMENTATION == 1 for unit test code when in shared library
      added URLTestHelpers to exclusion in shared library build, because it depends on webkit_support
      
      * WebKit.gypi:
      added URLTestHelpers.h and .cpp to the build process
      
      * WebKitUnitTests.gyp:
      added WEBKIT_IMPLEMENTATION == 1 for unit test code when not in shared library.
      note that in shared library build, RunAllTests.cpp does not have WEBKIT_IMPLEMENTATION == 1.
      
      * public/WebDOMMessageEvent.h:
      (WebKit::WebDOMMessageEvent::WebDOMMessageEvent):
      * tests/AssociatedURLLoaderTest.cpp:
      * tests/EventListenerTest.cpp:
      * tests/FrameTestHelpers.cpp:
      (WebKit::FrameTestHelpers::loadFrame):
      * tests/FrameTestHelpers.h:
      * tests/ListenerLeakTest.cpp:
      (WebKit::ListenerLeakTest::RunTest):
      * tests/PopupMenuTest.cpp:
      * tests/RunAllTests.cpp:
      * tests/URLTestHelpers.cpp: Added.
      (URLTestHelpers):
      (WebKit::URLTestHelpers::registerMockedURLFromBaseURL):
      (WebKit::URLTestHelpers::registerMockedURLLoad):
      * tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h.
      (WebKit):
      (URLTestHelpers):
      (WebKit::URLTestHelpers::toKURL):
      * tests/WebFrameTest.cpp:
      * tests/WebPageNewSerializerTest.cpp:
      * tests/WebPageSerializerTest.cpp:
      * tests/WebViewTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9027df3
  10. 09 Jul, 2012 2 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r122161. · 0078b1b9
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/122161
      https://bugs.webkit.org/show_bug.cgi?id=90837
      
      failed to compile on chromium webkit linux bot (Requested by
      shawnsingh on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-09
      
      * WebKit.gypi:
      * WebKitUnitTests.gyp:
      * public/WebDOMMessageEvent.h:
      * tests/AssociatedURLLoaderTest.cpp:
      (WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest):
      (WebKit::AssociatedURLLoaderTest::SetUp):
      (WebKit::AssociatedURLLoaderTest::CheckMethodFails):
      (WebKit::AssociatedURLLoaderTest::CheckHeaderFails):
      (WebKit::AssociatedURLLoaderTest::CheckAccessControlHeaders):
      (WebKit::TEST_F):
      * tests/EventListenerTest.cpp:
      * tests/FrameTestHelpers.cpp:
      (WebKit::FrameTestHelpers::registerMockedURLLoad):
      (FrameTestHelpers):
      (WebKit::FrameTestHelpers::loadFrame):
      * tests/FrameTestHelpers.h:
      (FrameTestHelpers):
      * tests/ListenerLeakTest.cpp:
      (WebKit::ListenerLeakTest::RunTest):
      * tests/PopupMenuTest.cpp:
      (WebKit::SelectPopupMenuTest::registerMockedURLLoad):
      (WebKit::SelectPopupMenuTest::loadFrame):
      (WebKit::TEST_F):
      * tests/RunAllTests.cpp:
      * tests/URLTestHelpers.cpp: Removed.
      * tests/URLTestHelpers.h: Removed.
      * tests/WebFrameTest.cpp:
      (WebKit::WebFrameTest::registerMockedHttpURLLoad):
      (WebKit::WebFrameTest::registerMockedChromeURLLoad):
      (WebKit::TEST_F):
      * tests/WebPageNewSerializerTest.cpp:
      (WebKit::WebPageNewSerializeTest::registerMockedURLLoad):
      (WebPageNewSerializeTest):
      (WebKit::WebPageNewSerializeTest::setUpCSSTestPage):
      (WebKit::WebPageNewSerializeTest::loadURLInTopFrame):
      (WebKit::WebPageNewSerializeTest::resourceVectorContains):
      (WebKit::TEST_F):
      * tests/WebPageSerializerTest.cpp:
      (WebKit::WebPageSerializerTest::registerMockedURLLoad):
      (WebKit::WebPageSerializerTest::loadURLInTopFrame):
      (WebKit::WebPageSerializerTest::webVectorContains):
      (WebKit::TEST_F):
      * tests/WebViewTest.cpp:
      (WebKit::TEST_F):
      (WebKit::WebViewTest::testAutoResize):
      (WebKit::WebViewTest::testTextInputType):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122171 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0078b1b9
    • shawnsingh@chromium.org's avatar
      [chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests · d08a857d
      shawnsingh@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90094
      
      Reviewed by Adam Barth.
      
      This patch adds the WEBKIT_IMPLEMENTATION = 1 define to
      WebKitUnitTests.gyp. To get it to compile correctly, some string
      and URL code was refactored, and GURL types were replaced with KURL types.
      
      * WebKit.gypi:
      * WebKitUnitTests.gyp:
      * public/WebDOMMessageEvent.h:
      (WebKit::WebDOMMessageEvent::WebDOMMessageEvent):
      * tests/AssociatedURLLoaderTest.cpp:
      * tests/EventListenerTest.cpp:
      * tests/FrameTestHelpers.cpp:
      (WebKit::FrameTestHelpers::loadFrame):
      * tests/FrameTestHelpers.h:
      * tests/ListenerLeakTest.cpp:
      (WebKit::ListenerLeakTest::RunTest):
      * tests/PopupMenuTest.cpp:
      * tests/RunAllTests.cpp:
      * tests/URLTestHelpers.cpp: Added.
      (URLTestHelpers):
      (WebKit::URLTestHelpers::registerMockedURLFromBaseURL):
      (WebKit::URLTestHelpers::registerMockedURLLoad):
      * tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h.
      (WebKit):
      (URLTestHelpers):
      (WebKit::URLTestHelpers::toKURL):
      * tests/WebFrameTest.cpp:
      * tests/WebPageNewSerializerTest.cpp:
      * tests/WebPageSerializerTest.cpp:
      * tests/WebViewTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122161 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d08a857d
  11. 28 Jun, 2012 3 commits
    • hclam@chromium.org's avatar
      Unreviewed, rolling out r121463. · c5bcada8
      hclam@chromium.org authored
      http://trac.webkit.org/changeset/121463
      https://bugs.webkit.org/show_bug.cgi?id=90094
      
      Broke Windows build.
      
      * WebKit.gypi:
      * WebKitUnitTests.gyp:
      * public/WebDOMMessageEvent.h:
      * tests/AssociatedURLLoaderTest.cpp:
      (WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest):
      (WebKit::AssociatedURLLoaderTest::SetUp):
      (WebKit::AssociatedURLLoaderTest::CheckMethodFails):
      (WebKit::AssociatedURLLoaderTest::CheckHeaderFails):
      (WebKit::AssociatedURLLoaderTest::CheckAccessControlHeaders):
      (WebKit::TEST_F):
      * tests/EventListenerTest.cpp:
      * tests/FrameTestHelpers.cpp:
      (WebKit::FrameTestHelpers::registerMockedURLLoad):
      (FrameTestHelpers):
      (WebKit::FrameTestHelpers::loadFrame):
      * tests/FrameTestHelpers.h:
      (FrameTestHelpers):
      * tests/ListenerLeakTest.cpp:
      (WebKit::ListenerLeakTest::RunTest):
      * tests/PopupMenuTest.cpp:
      (WebKit::SelectPopupMenuTest::registerMockedURLLoad):
      (WebKit::SelectPopupMenuTest::loadFrame):
      (WebKit::TEST_F):
      * tests/RunAllTests.cpp:
      * tests/URLTestHelpers.cpp: Removed.
      * tests/URLTestHelpers.h: Removed.
      * tests/WebFrameTest.cpp:
      (WebKit::WebFrameTest::registerMockedHttpURLLoad):
      (WebKit::WebFrameTest::registerMockedChromeURLLoad):
      (WebKit::TEST_F):
      * tests/WebPageNewSerializerTest.cpp:
      (WebKit::WebPageNewSerializeTest::registerMockedURLLoad):
      (WebPageNewSerializeTest):
      (WebKit::WebPageNewSerializeTest::setUpCSSTestPage):
      (WebKit::WebPageNewSerializeTest::loadURLInTopFrame):
      (WebKit::WebPageNewSerializeTest::resourceVectorContains):
      (WebKit::TEST_F):
      * tests/WebPageSerializerTest.cpp:
      (WebKit::WebPageSerializerTest::registerMockedURLLoad):
      (WebKit::WebPageSerializerTest::loadURLInTopFrame):
      (WebKit::WebPageSerializerTest::webVectorContains):
      (WebKit::TEST_F):
      * tests/WebViewTest.cpp:
      (WebKit::TEST_F):
      (WebKit::WebViewTest::testAutoResize):
      (WebKit::WebViewTest::testTextInputType):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5bcada8
    • shawnsingh@chromium.org's avatar
      [chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests · a16f48a6
      shawnsingh@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90094
      
      Reviewed by Adam Barth.
      
      This patch adds the WEBKIT_IMPLEMENTATION = 1 define to
      WebKitUnitTests.gyp. To get it to compile correctly, some string
      and URL code was refactored and fixed.
      
      * WebKit.gypi:
      * WebKitUnitTests.gyp:
      * public/WebDOMMessageEvent.h:
      (WebKit::WebDOMMessageEvent::WebDOMMessageEvent):
      * tests/AssociatedURLLoaderTest.cpp:
      * tests/EventListenerTest.cpp:
      * tests/FrameTestHelpers.cpp:
      (WebKit::FrameTestHelpers::loadFrame):
      * tests/FrameTestHelpers.h:
      * tests/ListenerLeakTest.cpp:
      (WebKit::ListenerLeakTest::RunTest):
      * tests/PopupMenuTest.cpp:
      * tests/RunAllTests.cpp:
      * tests/URLTestHelpers.cpp: Added.
      (URLTestHelpers):
      (WebKit::URLTestHelpers::registerMockedURLFromBaseURL):
      (WebKit::URLTestHelpers::registerMockedURLLoad):
      * tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h.
      (WebKit):
      (URLTestHelpers):
      (WebKit::URLTestHelpers::toKURL):
      * tests/WebFrameTest.cpp:
      * tests/WebPageNewSerializerTest.cpp:
      * tests/WebPageSerializerTest.cpp:
      * tests/WebViewTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a16f48a6
    • commit-queue@webkit.org's avatar
      [chromium] Introduce way to reload a page using the original request URL · 2090e275
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89788
      
      Patch by Dan Alcantara <dfalcantara@chromium.org> on 2012-06-28
      Reviewed by Adam Barth.
      
      Adds a new reload method for cases where we need to override the URL
      when reloading a page. This is needed for situations where a server
      redirects navigation based on information that may have changed since
      the last time the page was loaded.
      
      User agents, for example, can cause a server to redirect to the mobile
      version of a page.  Changing to the desktop version by switching user agents
      requires loading a URL from before the redirect occurred.
      
      Also adds a unit test to confirm that scroll position and page scale are
      saved when the reload occurs.
      
      * public/WebFrame.h:
      (WebFrame):
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::reloadWithGivenURL):
      (WebKit):
      * src/WebFrameImpl.h:
      (WebFrameImpl):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::WebViewImpl):
      (WebKit::WebViewImpl::setClearPageScaleFactorOnLoad):
      (WebKit):
      (WebKit::WebViewImpl::didCommitLoad):
      * src/WebViewImpl.h:
      (WebViewImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2090e275
  12. 27 Jun, 2012 2 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r121405. · 83ed30cf
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/121405
      https://bugs.webkit.org/show_bug.cgi?id=90135
      
      broke windows build (Requested by shawnsingh_ on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-27
      
      * WebKit.gypi:
      * WebKitUnitTests.gyp:
      * public/WebDOMMessageEvent.h:
      * tests/AssociatedURLLoaderTest.cpp:
      (WebKit::AssociatedURLLoaderTest::AssociatedURLLoaderTest):
      (WebKit::AssociatedURLLoaderTest::SetUp):
      (WebKit::AssociatedURLLoaderTest::CheckMethodFails):
      (WebKit::AssociatedURLLoaderTest::CheckHeaderFails):
      (WebKit::AssociatedURLLoaderTest::CheckAccessControlHeaders):
      (WebKit::TEST_F):
      * tests/EventListenerTest.cpp:
      * tests/FrameTestHelpers.cpp:
      (WebKit::FrameTestHelpers::registerMockedURLLoad):
      (FrameTestHelpers):
      (WebKit::FrameTestHelpers::loadFrame):
      * tests/FrameTestHelpers.h:
      (FrameTestHelpers):
      * tests/ListenerLeakTest.cpp:
      (WebKit::ListenerLeakTest::RunTest):
      * tests/PopupMenuTest.cpp:
      (WebKit::SelectPopupMenuTest::registerMockedURLLoad):
      (WebKit::SelectPopupMenuTest::loadFrame):
      * tests/RunAllTests.cpp:
      * tests/URLTestHelpers.cpp: Removed.
      * tests/URLTestHelpers.h: Removed.
      * tests/WebFrameTest.cpp:
      (WebKit::WebFrameTest::registerMockedHttpURLLoad):
      (WebKit::WebFrameTest::registerMockedChromeURLLoad):
      (WebKit::TEST_F):
      * tests/WebPageNewSerializerTest.cpp:
      (WebKit::WebPageNewSerializeTest::registerMockedURLLoad):
      (WebPageNewSerializeTest):
      (WebKit::WebPageNewSerializeTest::setUpCSSTestPage):
      (WebKit::WebPageNewSerializeTest::loadURLInTopFrame):
      (WebKit::WebPageNewSerializeTest::resourceVectorContains):
      (WebKit::TEST_F):
      * tests/WebPageSerializerTest.cpp:
      (WebKit::WebPageSerializerTest::registerMockedURLLoad):
      (WebKit::WebPageSerializerTest::loadURLInTopFrame):
      (WebKit::WebPageSerializerTest::webVectorContains):
      (WebKit::TEST_F):
      * tests/WebViewTest.cpp:
      (WebKit::TEST_F):
      (WebKit::WebViewTest::testAutoResize):
      (WebKit::WebViewTest::testTextInputType):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83ed30cf
    • shawnsingh@chromium.org's avatar
      [chromium] Use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests · e85ac740
      shawnsingh@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=90094
      
      Reviewed by James Robinson.
      
      This patch adds the WEBKIT_IMPLEMENTATION = 1 define to
      WebKitUnitTests.gyp. To get it to compile correctly, some string
      and URL code was refactored and fixed.
      
      * WebKit.gypi:
      * WebKitUnitTests.gyp:
      * public/WebDOMMessageEvent.h:
      (WebKit::WebDOMMessageEvent::WebDOMMessageEvent):
      * tests/AssociatedURLLoaderTest.cpp:
      * tests/EventListenerTest.cpp:
      * tests/FrameTestHelpers.cpp:
      (WebKit::FrameTestHelpers::loadFrame):
      * tests/FrameTestHelpers.h:
      * tests/ListenerLeakTest.cpp:
      (WebKit::ListenerLeakTest::RunTest):
      * tests/PopupMenuTest.cpp:
      * tests/RunAllTests.cpp:
      * tests/URLTestHelpers.cpp: Added.
      (URLTestHelpers):
      (WebKit::URLTestHelpers::registerMockedURLFromBaseURL):
      (WebKit::URLTestHelpers::registerMockedURLLoad):
      * tests/URLTestHelpers.h: Copied from Source/WebKit/chromium/public/WebDOMMessageEvent.h.
      (WebKit):
      (URLTestHelpers):
      (WebKit::URLTestHelpers::toKURL):
      * tests/WebFrameTest.cpp:
      * tests/WebPageNewSerializerTest.cpp:
      * tests/WebPageSerializerTest.cpp:
      * tests/WebViewTest.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e85ac740
  13. 25 Jun, 2012 3 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r121206. · d2e42dea
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/121206
      https://bugs.webkit.org/show_bug.cgi?id=89935
      
      [chromium] webkit_unit_tests
      WebViewTest.MHTMLWithMissingResourceFinishesLoading crash
      (Requested by ukai on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-25
      
      Source/WebCore:
      
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::scheduleArchiveLoad):
      
      Source/WebKit/chromium:
      
      * tests/EventListenerTest.cpp:
      * tests/FrameTestHelpers.cpp:
      (WebKit::FrameTestHelpers::registerMockedURLLoad):
      (WebKit::FrameTestHelpers::createWebViewAndLoad):
      * tests/FrameTestHelpers.h:
      (FrameTestHelpers):
      * tests/ListenerLeakTest.cpp:
      (WebKit::ListenerLeakTest::RunTest):
      * tests/WebFrameTest.cpp:
      (WebKit::WebFrameTest::registerMockedHttpURLLoad):
      (WebKit::WebFrameTest::registerMockedChromeURLLoad):
      * tests/WebViewTest.cpp:
      (WebKit::TEST_F):
      (WebKit::WebViewTest::testAutoResize):
      (WebKit::WebViewTest::testTextInputType):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2e42dea
    • abarth@webkit.org's avatar
      [Chromium] Let the embedder override the max page scale factor set by the page · b602feab
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=89406
      
      Reviewed by James Robinson.
      
      Chrome on Android has an option to force the web site to allow page
      scaling (for accessibility). This patch adds
      WebView::setIgnoreViewportTagMaximumScale, which instructs the WebView
      to ignore the maximum scale factor supplied by by the page in the
      viewport meta tag.
      
      This patch is a bit different from how this is implemented on the
      chromium-android branch, but I'll clean up the branch once this patch
      lands.
      
      * public/WebView.h:
      (WebView):
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::WebViewImpl):
      (WebKit::WebViewImpl::setIgnoreViewportTagMaximumScale):
      (WebKit):
      * src/WebViewImpl.h:
      (WebViewImpl):
      (WebKit::WebViewImpl::ignoreViewportTagMaximumScale):
      * tests/WebFrameTest.cpp:
      (WebKit::TEST_F):
      (WebKit):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b602feab
    • jcivelli@chromium.org's avatar
      Fix progress load reporting for MHTML documents. · cc49998c
      jcivelli@chromium.org authored
      MHTML documents containing references to resources they don't include
      never finish loading.
      https://bugs.webkit.org/show_bug.cgi?id=71859
      
      Reviewed by Nate Chapin.
      
      Source/WebCore:
      
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::scheduleArchiveLoad):
      
      Source/WebKit/chromium:
      
      * tests/EventListenerTest.cpp:
      * tests/FrameTestHelpers.cpp:
      (FrameTestHelpers):
      (WebKit::FrameTestHelpers::registerMockedURLLoad):
      (WebKit::FrameTestHelpers::registerMockedURLLoadAsHTML):
      (WebKit::FrameTestHelpers::createWebViewAndLoad):
      * tests/FrameTestHelpers.h:
      (FrameTestHelpers):
      * tests/ListenerLeakTest.cpp:
      (WebKit::ListenerLeakTest::RunTest):
      * tests/WebFrameTest.cpp:
      (WebKit::WebFrameTest::registerMockedHttpURLLoad):
      (WebKit::WebFrameTest::registerMockedChromeURLLoad):
      * tests/WebViewTest.cpp:
      (WebKit::TEST_F):
      (WebKit::WebViewTest::testAutoResize):
      (WebKit::WebViewTest::testTextInputType):
      (TestWebViewClient):
      (WebKit::TestWebViewClient::TestWebViewClient):
      (WebKit::TestWebViewClient::didStartLoading):
      (WebKit::TestWebViewClient::didStopLoading):
      (WebKit::TestWebViewClient::didChangeLoadProgress):
      (WebKit::TestWebViewClient::loadingStarted):
      (WebKit::TestWebViewClient::loadingStopped):
      (WebKit::TestWebViewClient::loadProgress):
      (WebKit):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc49998c
  14. 14 Jun, 2012 1 commit
  15. 07 Jun, 2012 1 commit
    • abarth@webkit.org's avatar
      Settings::defaultDeviceScaleFactor is redundant with Page::deviceScaleFactor · 9a476fa5
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=88375
      
      Reviewed by James Robinson.
      
      .: 
      
      This symbol no longer exists.
      
      * Source/autotools/symbols.filter:
      
      Source/WebCore: 
      
      This patch removes Settings::defaultDeviceScaleFactor because it is
      redundant with Page::deviceScaleFactor now that we no longer support
      target-densitydpi.  Page::deviceScaleFactor is the canonical place to
      store the device scale factor.
      
      * WebCore.exp.in:
      * page/Settings.cpp:
      (WebCore::Settings::Settings):
      (WebCore):
      * page/Settings.h:
      (Settings):
      * testing/InternalSettings.cpp:
      (WebCore::InternalSettings::setDeviceScaleFactor):
      
      Source/WebKit/chromium: 
      
      * public/WebSettings.h:
      (WebKit::WebSettings::setDefaultDeviceScaleFactor):
      (WebSettings):
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
      * src/WebSettingsImpl.cpp:
      (WebKit):
      * src/WebSettingsImpl.h:
      (WebSettingsImpl):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
      * tests/WebFrameTest.cpp:
      (WebKit::TEST_F):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@119752 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a476fa5
  16. 30 May, 2012 1 commit
  17. 22 May, 2012 1 commit
    • commit-queue@webkit.org's avatar
      [chromium] Apply viewport tag initial-scale only once · 81eef312
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=82949
      
      Patch by Alexandre Elias <aelias@google.com> on 2012-05-22
      Reviewed by Adam Barth.
      
      First, check that isPageScaleFactorSet return false before setting
      initial-scale. We need to call dispatchViewportPropertiesDidChange()
      when the viewport width changes, since that's an input to the viewport
      tag calculation. When this happens, we shouldn't pop back to initial
      scale.
      
      Second, check that isNewNavigation is true when deciding to clear
      isPageScaleFactorIsSet in didCommitLoad. We only want to clear it on
      the very first commit, otherwise we'll pop back to initial scale if
      the user zooms in before the load is complete.
      
      New test WebFrameTest::FixedLayoutInitializeAtMinimumPageScale.
      
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::didCommitLoad):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81eef312
  18. 17 May, 2012 1 commit
    • danakj@chromium.org's avatar
      [chromium] Scale all compositor output by the defaultDeviceScaleFactor · e06f9e4b
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=86051
      
      Reviewed by James Robinson.
      
      Source/Platform:
      
      * chromium/public/WebLayerTreeView.h:
      (WebKit::WebLayerTreeView::Settings::Settings):
      (Settings):
      
      Source/WebCore:
      
      On initialization, give the defaultDeviceScaleFactor to the compositor
      to have it scale all output from WebCore's layout size to physical
      pixels. This allows us to scale up to high-dpi devices without using
      fixed-layout, so we can leave the WebCore frame size in layout pixels,
      while drawing the frame into a larger physical pixel size.
      
      CCLayerTreeHost becomes aware of the deviceScaleFactor and scales all
      output by this factor by scaling the viewport and all drawing
      transforms.
      
      Anything that works in physical pixels (content space), uses the
      deviceViewportSize() in place of the viewportSize(), since when
      deviceScaleFactor != 1 in CCLayerTreeHost, the WebCore viewport
      is no longer physical pixels.
      
      Scroll positions are in layout pixels, and must be scaled to/from
      content space within the compositor.
      
      Unit tests: CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers
      
      * platform/graphics/chromium/LayerRendererChromium.h:
      (LayerRendererChromiumClient):
      (WebCore::LayerRendererChromium::viewportSize):
      (WebCore::LayerRendererChromium::viewportWidth):
      (WebCore::LayerRendererChromium::viewportHeight):
      (LayerRendererChromium):
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      (WebCore::CCLayerTreeHost::initializeLayerRenderer):
      (WebCore::CCLayerTreeHost::setViewportSize):
      (WebCore::CCLayerTreeHost::updateLayers):
      (WebCore::CCLayerTreeHost::paintLayerContents):
      * platform/graphics/chromium/cc/CCLayerTreeHost.h:
      (WebCore::CCSettings::CCSettings):
      (CCSettings):
      (CCLayerTreeHost):
      (WebCore::CCLayerTreeHost::deviceViewportSize):
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
      (WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
      (WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
      (WebCore::CCLayerTreeHostImpl::setViewportSize):
      (WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
      (WebCore::CCLayerTreeHostImpl::scrollBegin):
      (WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
      (WebCore::CCLayerTreeHostImpl::viewportSize):
      (CCLayerTreeHostImpl):
      
      Source/WebKit/chromium:
      
      Add the applyDefaultDeviceScaleInCompositor setting. When enabled, we
      apply the scale factor during compositing instead of applying it through
      the pageScaleFactor.
      
      NonCompositedContentHost is the GraphicLayerClient for the GraphicsLayer
      containing the document's body. It needs to report the page/device scale
      that should be used when scaling the contents of the GraphicsLayer, and
      when changes occur to them such that its contentsSize or contentsScale
      is affected.
      
      Store the deviceScaleFactor being used in the compositor. The remainder
      of the deviceScaleFactor() is being applied to the pageScale.
      
      * public/WebSettings.h:
      * src/NonCompositedContentHost.cpp:
      (WebKit::NonCompositedContentHost::NonCompositedContentHost):
      (WebKit::NonCompositedContentHost::setViewport):
      * src/NonCompositedContentHost.h:
      (NonCompositedContentHost):
      * src/WebLayerTreeView.cpp:
      (WebKit::WebLayerTreeView::Settings::operator CCSettings):
      * src/WebSettingsImpl.cpp:
      (WebKit::WebSettingsImpl::setApplyDefaultDeviceScaleFactorInCompositor):
      (WebKit):
      * src/WebSettingsImpl.h:
      (WebSettingsImpl):
      (WebKit::WebSettingsImpl::applyDefaultDeviceScaleFactorInCompositor):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::WebViewImpl):
      (WebKit::WebViewImpl::setPageScaleFactor):
      (WebKit::WebViewImpl::setDeviceScaleFactor):
      (WebKit::WebViewImpl::enableFixedLayoutMode):
      (WebKit::WebViewImpl::computePageScaleFactorLimits):
      (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
      (WebKit::WebViewImpl::updateLayerTreeViewport):
      * src/WebViewImpl.h:
      * tests/CCLayerTreeHostTest.cpp:
      (MockLayerTreeHostImpl):
      (WTF::MockLayerTreeHost::createLayerTreeHostImpl):
      (CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
      (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers):
      (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::beginTest):
      (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::commitCompleteOnCCThread):
      (WTF::CCLayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers::afterTest):
      (WTF):
      (WTF::TEST_F):
      * tests/LayerRendererChromiumTest.cpp:
      * tests/WebFrameTest.cpp:
      (WebKit::TEST_F):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e06f9e4b
  19. 15 May, 2012 1 commit
    • commit-queue@webkit.org's avatar
      [chromium] Fix unsafe viewport tag dispatch · 61f4720c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=80554
      
      Patch by Alexandre Elias <aelias@google.com> on 2012-05-15
      Reviewed by Adam Barth.
      
      In some uncommon situations (such as window.open() new tab on
      Android), dispatchViewportPropertiesDidChange may early-return without
      setting the page scale because the window size is not yet
      available from the embedder.  At that point, the previous behavior was
      to call it again in layoutUpdated(), but this is unsafe since it
      leaves a pending needsLayout.
      
      I moved the dispatch call into WebViewImpl::didChangeContentsSize and
      WebViewImpl::resize() instead -- these represent more explicitly the
      situations where the inputs to the viewport tag calculation change.  I
      removed the other dispatch call from setFrameRect as it's now
      redundant.
      
      Covered by FixedLayoutInitializeAtMinimumPageScale test introduced
      in http://webk.it/82949 (an assertion will fire there without
      this fix).
      
      Source/WebCore:
      
      * page/FrameView.cpp:
      (WebCore::FrameView::setFrameRect):
      
      Source/WebKit/chromium:
      
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::layoutUpdated):
      (WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::resize):
      (WebKit::WebViewImpl::didChangeContentsSize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117170 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61f4720c
  20. 10 May, 2012 1 commit
  21. 09 May, 2012 1 commit
  22. 25 Apr, 2012 1 commit
  23. 10 Apr, 2012 1 commit
  24. 20 Mar, 2012 1 commit
  25. 27 Feb, 2012 1 commit
  26. 24 Feb, 2012 1 commit
    • jamesr@google.com's avatar
      [chromium] Make WebViewImpl depend on WebLayerTreeView instead of CCLayerTreeHost · 34c89f0e
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=75591
      
      Reviewed by Kenneth Russell.
      
      This converts WebViewImpl from depending on CCLayerTreeHost to WebLayerTreeView in order to provide better
      isolation and allow for future refactorings. The changes to WebViewImpl are mostly mechanical. The
      WebLayerTreeView and WebLayerTreeViewClient interfaces have both grown and changed slightly:
      
      - Setup path for WebLayerTreeView changed to expose an initialize() function instead of a create() factory
      function. The new model is that a WebLayerTreeView when constructed is in a null state. Calling initialize()
      attempts to re-initialize the WLTV, which can either fail or succeed.  All other functions must be called on a
      successfully initialized view.
      
      - WebLayerTreeView expanded to include functionality that CCLayerTreeHost exposes but WebLayerTreeView did not.
      Some of this is only valid for the single thread case and will be removed when we invert the scheduling control
      logic, these bits are commented.
      
      - WebLayerTreeViewClient expanded with some flow-control related APIs.
      
      Refactor only, no change in behavior.
      
      * public/platform/WebLayerTreeView.h:
      (WebKit::WebLayerTreeView::Settings::Settings):
      (WebKit::WebLayerTreeView::isNull):
      * public/platform/WebLayerTreeViewClient.h:
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::scheduleCompositingLayerSync):
      * src/WebLayerTreeView.cpp:
      (WebKit::WebLayerTreeView::initialize):
      (WebKit::WebLayerTreeView::compositorIdentifier):
      (WebKit::WebLayerTreeView::setVisible):
      (WebKit::WebLayerTreeView::setNeedsAnimate):
      (WebKit::WebLayerTreeView::updateAnimations):
      (WebKit::WebLayerTreeView::setNeedsRedraw):
      (WebKit::WebLayerTreeView::setPageScaleFactorAndLimits):
      (WebKit::WebLayerTreeView::startPageScaleAnimation):
      (WebKit::WebLayerTreeView::finishAllRendering):
      (WebKit::WebLayerTreeView::context):
      (WebKit::WebLayerTreeView::loseCompositorContext):
      * src/WebLayerTreeViewImpl.cpp:
      (WebKit::WebLayerTreeViewImpl::didRecreateGraphicsContext):
      (WebKit::WebLayerTreeViewImpl::didCommitAndDrawFrame):
      (WebKit::WebLayerTreeViewImpl::didCompleteSwapBuffers):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::animate):
      (WebKit::WebViewImpl::doPixelReadbackToCanvas):
      (WebKit::WebViewImpl::paint):
      (WebKit::WebViewImpl::composite):
      (WebKit::WebViewImpl::loseCompositorContext):
      (WebKit::WebViewImpl::computePageScaleFactorLimits):
      (WebKit::WebViewImpl::addPageOverlay):
      (WebKit::WebViewImpl::removePageOverlay):
      (WebKit::WebViewImpl::setRootGraphicsLayer):
      (WebKit::WebViewImpl::scheduleCompositingLayerSync):
      (WebKit::WebViewImpl::scrollRootLayerRect):
      (WebKit::WebViewImpl::invalidateRootLayerRect):
      (WebKit::WebViewImpl::scheduleAnimation):
      (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
      (WebKit::WebViewImpl::createContext3D):
      (WebKit::WebViewImpl::applyScrollAndScale):
      (WebKit::WebViewImpl::didRebindGraphicsContext):
      (WebKit::WebViewImpl::updateLayerTreeViewport):
      (WebKit::WebViewImpl::graphicsContext3D):
      (WebKit::WebViewImpl::setVisibilityState):
      * src/WebViewImpl.h:
      * tests/WebLayerTest.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@108883 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34c89f0e
  27. 16 Feb, 2012 1 commit
  28. 03 Feb, 2012 1 commit
  29. 01 Feb, 2012 1 commit
  30. 30 Jan, 2012 1 commit
    • tkent@chromium.org's avatar
      [Chromium] REGRESSION(r87067): WebFrame::setFindEndstateFocusAndSelection() · 4bbeb2be
      tkent@chromium.org authored
      doesn't set the selection for <input> and <textarea>
      https://bugs.webkit.org/show_bug.cgi?id=77186
      
      Reviewed by Hajime Morita.
      
      When the find-in-page box is closed, WebFrame::stopFinding(false) is
      called. It calls setFindEndstateFocusAndSelection(). Before r87067,
      m_activeMatch was stored as the normal selection in <input> or
      <textarea> by accident. r87067 stopped this accidental behavior.
      
      However the behavior of pre-r87067 is useful and we should support it
      for contentEditable elements too.
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::setFindEndstateFocusAndSelection):
      - Add special handing for <input> and <textarea> to find a focusable parent.
      - Sets the active match as the selection even if a focusable parent is found.
      * tests/WebFrameTest.cpp:
      (WebKit::TEST_F): Add tests for find() and stopFinding().
      * tests/data/find.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bbeb2be
  31. 11 Nov, 2011 1 commit
    • tonyg@chromium.org's avatar
      Unreviewed, rolling out r99826. · 5a5eafb9
      tonyg@chromium.org authored
      http://trac.webkit.org/changeset/99826
      https://bugs.webkit.org/show_bug.cgi?id=72109
      
      "Likely causing test flakiness" (Requested by tonyg-cr on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-11-11
      
      Source/WebCore:
      
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::scheduleArchiveLoad):
      
      Source/WebKit/chromium:
      
      * tests/FrameTestHelpers.cpp:
      (WebKit::FrameTestHelpers::registerMockedURLLoad):
      (WebKit::FrameTestHelpers::createWebViewAndLoad):
      * tests/FrameTestHelpers.h:
      * tests/WebFrameTest.cpp:
      (WebKit::WebFrameTest::registerMockedHttpURLLoad):
      (WebKit::WebFrameTest::registerMockedChromeURLLoad):
      (WebKit::TEST_F):
      * tests/WebViewTest.cpp:
      (WebKit::TEST_F):
      * tests/data/page_with_image.mht: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a5eafb9
  32. 10 Nov, 2011 1 commit
    • jcivelli@chromium.org's avatar
      Fix progress load reporting for MHTML documents. · 75384897
      jcivelli@chromium.org authored
      MHTML documents containing references to resources they don't include
      never finish loading.
      https://bugs.webkit.org/show_bug.cgi?id=71859
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::scheduleArchiveLoad):
      
      Source/WebKit/chromium:
      
      * tests/FrameTestHelpers.cpp:
      (WebKit::FrameTestHelpers::registerMockedURLLoadAsHTML):
      (WebKit::FrameTestHelpers::registerMockedURLLoad):
      (WebKit::FrameTestHelpers::createWebViewAndLoad):
      * tests/FrameTestHelpers.h:
      * tests/WebFrameTest.cpp:
      (WebKit::WebFrameTest::registerMockedHttpURLLoad):
      (WebKit::WebFrameTest::registerMockedChromeURLLoad):
      (WebKit::TEST_F):
      * tests/WebViewTest.cpp:
      (WebKit::TEST_F):
      * tests/data/page_with_image.mht: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75384897
  33. 07 Oct, 2011 1 commit
    • japhet@chromium.org's avatar
      Always call setActive() in WebViewImpl::setFocus(), · 06e83632
      japhet@chromium.org authored
      not just when enabling focus.
      https://bugs.webkit.org/show_bug.cgi?id=65220
      
      Reviewed by Darin Fisher.
      
      * WebKit.gyp:
      * WebKit.gypi:
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::setFocus):
      * tests/FrameTestHelpers.cpp: Added, refactored out of WebFrameTest.cpp.
      (WebKit::FrameTestHelpers::registerMockedURLLoad):
      (WebKit::FrameTestHelpers::loadFrame):
      (WebKit::FrameTestHelpers::defaultWebFrameClient):
      (WebKit::FrameTestHelpers::defaultWebViewClient):
      (WebKit::FrameTestHelpers::createWebViewAndLoad):
      * tests/FrameTestHelpers.h: Added, refactored out of WebFrameTest.cpp.
      * tests/WebFrameTest.cpp:
      * tests/WebViewTest.cpp: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@96912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06e83632