1. 20 Aug, 2013 37 commits
    • rniwa@webkit.org's avatar
      Mark fast/css/giant-stylesheet-crash.html as slow after r154246 · dc6b9938
      rniwa@webkit.org authored
      since allocating 2GB of RAM takes a long time sometimes.
      
      * TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc6b9938
    • mhahnenberg@apple.com's avatar
      <https://webkit.org/b/119919> Concurrent JIT crashes in various fast/js/dfg-*... · 25e78934
      mhahnenberg@apple.com authored
      <https://webkit.org/b/119919> Concurrent JIT crashes in various fast/js/dfg-* tests while the main thread is setting innerHTML
      
      Reviewed by Geoffrey Garen.
      
      More fixes for WriteBarrier deferral during concurrent JIT-ing. This patch makes the use of DesiredWriteBarriers class and the 
      initializeLazyWriteBarrierFor* wrapper functions more sane. 
      
      Refactored DesiredWriteBarrier to require an owner, a type, a CodeBlock, and an index. The type indicates how to use the CodeBlock
      and index when triggering the WriteBarrier at the end of compilation. 
      
      The client code of initializeLazy* is now responsible for creating the WriteBarrier that will be initialized as well as passing
      in the relevant index to be used at the end of compilation. Things were kind of muddled before in that one function did a 
      little extra work that really shouldn't have been its responsibility.
      
      * dfg/DFGByteCodeParser.cpp:
      (JSC::DFG::ByteCodeParser::addConstant):
      (JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
      * dfg/DFGDesiredWriteBarriers.cpp:
      (JSC::DFG::DesiredWriteBarrier::DesiredWriteBarrier):
      (JSC::DFG::DesiredWriteBarrier::trigger):
      * dfg/DFGDesiredWriteBarriers.h:
      (JSC::DFG::DesiredWriteBarriers::add):
      (JSC::DFG::initializeLazyWriteBarrierForInlineCallFrameExecutable):
      (JSC::DFG::initializeLazyWriteBarrierForInlineCallFrameCallee):
      (JSC::DFG::initializeLazyWriteBarrierForConstant):
      * dfg/DFGFixupPhase.cpp:
      (JSC::DFG::FixupPhase::truncateConstantToInt32):
      * dfg/DFGGraph.h:
      (JSC::DFG::Graph::constantRegisterForConstant):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25e78934
    • dbates@webkit.org's avatar
      Build fix after <http://trac.webkit.org/changeset/154260> (https://webkit.org/b/119949); · 6f7f26cc
      dbates@webkit.org authored
      declare Clipboard::hasData() when building with and without drag support
      
      * dom/Clipboard.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f7f26cc
    • hmuller@adobe.com's avatar
      <https://webkit.org/b/119849> [CSS Shapes] Complete RasterShape::firstIncludedIntervalLogicalTop() · c9a0f733
      hmuller@adobe.com authored
      Reviewed by Alexandru Chiculita.
      
      Source/WebCore:
      
      Completed the implementation of RasterShape::firstIncludedIntervalLogicalTop(). The
      method now computes first logical top location where a line segment can be laid
      out within a RasterShape, i.e. a shape derived from an image valued URL resource.
      
      A detailed description of the algorithm can be found in
      http://hansmuller-webkit.blogspot.com/2013/08/first-fit-location-for-image-shapes.html.
      
      The new tests exposed a bug in the existing getIncludedIntervals() method. A shape
      with a vertical gap that spans the entire line now causes the method to short circuit
      and return an empty interval list.
      
      Tests: fast/shapes/shape-inside/shape-inside-image-003.html
             fast/shapes/shape-inside/shape-inside-image-004.html
             fast/shapes/shape-inside/shape-inside-image-005.html
      
      * rendering/shapes/RasterShape.cpp:
      (WebCore::RasterShapeIntervals::firstIncludedIntervalY):
      (WebCore::RasterShapeIntervals::getIncludedIntervals):
      (WebCore::RasterShape::firstIncludedIntervalLogicalTop):
      * rendering/shapes/RasterShape.h:
      
      LayoutTests:
      
      Verify that the first fit algorithm works correctly for complex image shapes.
      For this set of tests the image is specified with an SVG file.
      
      * fast/shapes/resources/svg-shape-001.svg: Added.
      * fast/shapes/shape-inside/shape-inside-image-003-expected.html: Added.
      * fast/shapes/shape-inside/shape-inside-image-003.html: Added.
      * fast/shapes/shape-inside/shape-inside-image-004-expected.html: Added.
      * fast/shapes/shape-inside/shape-inside-image-004.html: Added.
      * fast/shapes/shape-inside/shape-inside-image-005-expected.html: Added.
      * fast/shapes/shape-inside/shape-inside-image-005.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9a0f733
    • psolanki@apple.com's avatar
      <https://webkit.org/b/120029> Document::markers() should return a reference · 469f39e9
      psolanki@apple.com authored
      Reviewed by Andreas Kling.
      
      Document::m_markers is never NULL so return a reference from Document::markers(). Also mark
      m_markers as const and initialize it in member initialization.
      
      Source/WebCore:
      
      * dom/Document.cpp:
      (WebCore::Document::Document):
      * dom/Document.h:
      (WebCore::Document::markers):
      * editing/AlternativeTextController.cpp:
      (WebCore::AlternativeTextController::isSpellingMarkerAllowed):
      (WebCore::AlternativeTextController::applyAlternativeTextToRange):
      (WebCore::AlternativeTextController::respondToUnappliedSpellCorrection):
      (WebCore::AlternativeTextController::handleAlternativeTextUIResult):
      (WebCore::AlternativeTextController::respondToChangedSelection):
      (WebCore::AlternativeTextController::respondToAppliedEditing):
      (WebCore::AlternativeTextController::respondToUnappliedEditing):
      (WebCore::AlternativeTextController::markReversed):
      (WebCore::AlternativeTextController::markCorrection):
      (WebCore::AlternativeTextController::recordSpellcheckerResponseForModifiedCorrection):
      (WebCore::AlternativeTextController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand):
      (WebCore::AlternativeTextController::processMarkersOnTextToBeReplacedByResult):
      (WebCore::AlternativeTextController::applyDictationAlternative):
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
      * editing/DeleteSelectionCommand.cpp:
      (WebCore::DeleteSelectionCommand::originalStringForAutocorrectionAtBeginningOfSelection):
      * editing/DictationCommand.cpp:
      (WebCore::DictationMarkerSupplier::addMarkersToTextNode):
      * editing/Editor.cpp:
      (WebCore::Editor::ignoreSpelling):
      (WebCore::Editor::learnSpelling):
      (WebCore::Editor::advanceToNextMisspelling):
      (WebCore::Editor::clearMisspellingsAndBadGrammar):
      (WebCore::Editor::markAndReplaceFor):
      (WebCore::Editor::changeBackToReplacedString):
      (WebCore::Editor::updateMarkersForWordsAffectedByEditing):
      (WebCore::Editor::countMatchesForText):
      (WebCore::Editor::setMarkedTextMatchesAreHighlighted):
      (WebCore::Editor::respondToChangedSelection):
      (WebCore::Editor::selectionStartHasMarkerFor):
      * editing/SpellChecker.cpp:
      (WebCore::SpellChecker::didCheckSucceed):
      * editing/SplitTextNodeCommand.cpp:
      (WebCore::SplitTextNodeCommand::doApply):
      (WebCore::SplitTextNodeCommand::doUnapply):
      * editing/TextCheckingHelper.cpp:
      (WebCore::TextCheckingHelper::findFirstMisspelling):
      (WebCore::TextCheckingHelper::findFirstGrammarDetail):
      * page/FrameView.cpp:
      (WebCore::FrameView::getTickmarks):
      (WebCore::FrameView::paintContents):
      * page/Page.cpp:
      (WebCore::Page::unmarkAllTextMatches):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::spellingToolTip):
      (WebCore::HitTestResult::replacedString):
      (WebCore::HitTestResult::dictationAlternatives):
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::paintDocumentMarkers):
      * rendering/svg/SVGInlineFlowBox.cpp:
      (WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
      * testing/Internals.cpp:
      (WebCore::Internals::markerCountForNode):
      (WebCore::Internals::markerAt):
      (WebCore::Internals::addTextMatchMarker):
      
      Source/WebKit/blackberry:
      
      * WebKitSupport/InPageSearchManager.cpp:
      (BlackBerry::WebKit::InPageSearchManager::findAndMarkText):
      (BlackBerry::WebKit::InPageSearchManager::setActiveMatchAndMarker):
      (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::shouldRequestSpellCheckingOptionsForPoint):
      (BlackBerry::WebKit::InputHandler::addAttributedTextMarker):
      (BlackBerry::WebKit::InputHandler::removeAttributedTextMarker):
      
      Source/WebKit/efl:
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_text_matches_unmark_all):
      (ewk_frame_text_matches_nth_pos_get):
      
      Source/WebKit/mac:
      
      * WebView/WebFrame.mm:
      (-[WebFrame _unmarkAllBadGrammar]):
      (-[WebFrame _unmarkAllMisspellings]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView unmarkAllTextMatches]):
      (-[WebHTMLView rectsForTextMatches]):
      
      Source/WebKit/win:
      
      * WebFrame.cpp:
      (WebFrame::unmarkAllMisspellings):
      (WebFrame::unmarkAllBadGrammar):
      * WebView.cpp:
      (WebView::rectsForTextMatches):
      
      Source/WebKit2:
      
      * WebProcess/WebPage/FindController.cpp:
      (WebKit::FindController::rectsForTextMatches):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::unmarkAllMisspellings):
      (WebKit::WebPage::unmarkAllBadGrammar):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      469f39e9
    • psolanki@apple.com's avatar
      <https://webkit.org/b/119875> localeToScriptCodeForFontSelection should use... · 6bd8bfa8
      psolanki@apple.com authored
      <https://webkit.org/b/119875> localeToScriptCodeForFontSelection should use hash tables with larger default capacity
      
      Reviewed by Darin Adler.
      
      The two static hash tables used in this file have 106 and 198 entries. Set a minimumTableSize for
      these hash tables so we don't have to expand them during initialization.
      
      No new tests because no functional changes.
      
      * platform/text/LocaleToScriptMappingDefault.cpp:
      (WebCore::scriptNameToCode):
      (WebCore::localeToScriptCodeForFontSelection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bd8bfa8
    • msaboff@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=120075 · 4759dfe7
      msaboff@apple.com authored
      REGRESSION (r128400): BBC4 website not displaying pictures
      
      Reviewed by Oliver Hunt.
      
      Source/JavaScriptCore: 
      
      * runtime/RegExpMatchesArray.h:
      (JSC::RegExpMatchesArray::createStructure): Changed the array IndexingType to be ArrayWithSlowPutArrayStorage
      so that the match results will be reified before any other modification to the results array.
      
      LayoutTests: 
      
      Added regression tests for fix.
      
      * fast/js/regress/regexp-match-reify-before-putbyval-expected.txt: Added.
      * fast/js/regress/regexp-match-reify-before-putbyval.html: Added.
      * fast/js/regress/script-tests/regexp-match-reify-before-putbyval.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4759dfe7
    • eric.carlson@apple.com's avatar
      <https://webkit.org/b/120068> Media controls can be attached lazily · 4f5721d8
      eric.carlson@apple.com authored
      Reviewed by Jer Noble.
      
      Merge https://chromium.googlesource.com/chromium/blink/+/28a995486a675992f2e72f81bfabdfff05688a31.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::createMediaControls): Add AttachLazily to appendChild().
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f5721d8
    • fpizlo@apple.com's avatar
      Incorrect behavior on emscripten-compiled cube2hash · 4f2ad8a1
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120033
      
      Source/JavaScriptCore: 
      
      Reviewed by Mark Hahnenberg.
              
      If PutClosureVar is may-aliased to another PutClosureVar or GetClosureVar
      then we should bail attempts to CSE.
      
      * dfg/DFGCSEPhase.cpp:
      (JSC::DFG::CSEPhase::scopedVarLoadElimination):
      (JSC::DFG::CSEPhase::scopedVarStoreElimination):
      
      LayoutTests: 
      
      Reviewed by Mark Hahnenberg.
              
      Add the test that actually failed as a JSRegress test. We should track its
      performance anyway.
              
      Add a regression test for the actual failure.
              
      Add .html and -expected.txt files for a JSRegress test that is already in
      the repo.
      
      * fast/js/dfg-get-closure-var-put-closure-var-interference.html: Added.
      * fast/js/dfg-get-closure-var-put-closure-var-interference-expected.txt: Added.
      * fast/js/regress/array-nonarray-polymorhpic-access-expected.txt: Added.
      * fast/js/regress/array-nonarray-polymorhpic-access.html: Added.
      * fast/js/regress/emscripten-cube2hash-expected.txt: Added.
      * fast/js/regress/emscripten-cube2hash.html: Added.
      * fast/js/regress/script-tests/emscripten-cube2hash.js: Added.
      (.Module.string_appeared_here):
      (else.Module.string_appeared_here):
      (else.else.Module.string_appeared_here):
      (else.else):
      (globalEval):
      (Runtime.stackSave):
      (Runtime.stackRestore):
      (Runtime.forceAlign):
      (Runtime.isNumberType):
      (Runtime.isPointerType):
      (Runtime.isStructType):
      (or64):
      (and64):
      (xor64):
      (getNativeTypeSize):
      (getNativeFieldSize):
      (dedup):
      (.set var):
      (getAlignSize):
      (calculateStructAlignment):
      (.else.alignment):
      (generateStructInfo):
      (dynCall):
      (addFunction):
      (removeFunction):
      (warnOnce):
      (.Runtime.funcWrappers.func):
      (getFuncWrapper):
      (UTF8Processor.this.processCChar):
      (UTF8Processor.this.processJSString):
      (UTF8Processor):
      (stackAlloc):
      (staticAlloc):
      (dynamicAlloc):
      (alignMemory):
      (makeBigInt):
      (assert):
      (ccall):
      (getCFunc):
      (.toC):
      (.fromC):
      (ccallFunc):
      (setValue):
      (getValue):
      (.set else):
      (.set return):
      (allocate):
      (Pointer_stringify):
      (alignMemoryPage):
      (enlargeMemory):
      (callRuntimeCallbacks):
      (preRun):
      (ensureInitRuntime):
      (preMain):
      (exitRuntime):
      (postRun):
      (addOnPreRun):
      (addOnInit):
      (addOnPreMain):
      (addOnExit):
      (addOnPostRun):
      (intArrayFromString):
      (intArrayToString):
      (writeStringToMemory):
      (writeArrayToMemory):
      (unSign):
      (reSign):
      (Math.string_appeared_here):
      (addRunDependency):
      (removeRunDependency):
      (loadMemoryInitializer.applyData):
      (loadMemoryInitializer.set addOnPreRun):
      (__ATINIT__.push):
      (STATIC_BASE):
      (copyTempDouble):
      (___setErrNo):
      (PATH.splitPath):
      (PATH.normalizeArray):
      (PATH.normalize.join):
      (PATH.normalize):
      (PATH.dirname):
      (PATH.basename):
      (PATH.join):
      (PATH.trim):
      (PATH.relative):
      (TTY.register):
      (TTY.stream_ops.open):
      (TTY.stream_ops.close):
      (TTY.stream_ops.read):
      (TTY.stream_ops.write):
      (TTY.default_tty_ops.get_char):
      (TTY.default_tty_ops.put_char):
      (TTY.default_tty1_ops.put_char):
      (MEMFS.mount):
      (MEMFS.create_node):
      (MEMFS.node_ops.getattr):
      (MEMFS.node_ops.setattr):
      (MEMFS.node_ops.lookup):
      (MEMFS.node_ops.mknod):
      (MEMFS.node_ops.rename):
      (MEMFS.node_ops.unlink):
      (MEMFS.node_ops.rmdir):
      (MEMFS.node_ops.readdir):
      (MEMFS.node_ops.symlink):
      (MEMFS.node_ops.readlink):
      (MEMFS.stream_ops.set else):
      (MEMFS.stream_ops.read):
      (MEMFS.stream_ops.write):
      (MEMFS.stream_ops.llseek):
      (MEMFS.stream_ops.allocate):
      (MEMFS.stream_ops.set return):
      (MEMFS.stream_ops.mmap):
      (_fflush):
      (FS.ErrnoError):
      (FS.handleFSError):
      (FS.hashName):
      (FS.hashAddNode):
      (FS.hashRemoveNode):
      (FS.lookupNode):
      (FS.):
      (FS.destroyNode):
      (FS.isRoot):
      (FS.isMountpoint):
      (FS.isFile):
      (FS.isDir):
      (FS.isLink):
      (FS.isChrdev):
      (FS.isBlkdev):
      (FS.isFIFO):
      (FS.cwd):
      (FS.var):
      (FS.lookupPath):
      (FS.getPath):
      (FS.modeStringToFlags):
      (FS.flagsToPermissionString):
      (FS.nodePermissions):
      (FS.mayLookup):
      (FS.mayMknod):
      (FS.mayCreate):
      (FS.mayDelete):
      (FS.mayOpen):
      (FS.chrdev_stream_ops.open):
      (FS.chrdev_stream_ops.llseek):
      (FS.major):
      (FS.minor):
      (FS.makedev):
      (FS.registerDevice):
      (FS.getDevice):
      (FS.nextfd):
      (FS.getStream):
      (FS.closeStream):
      (FS.getMode):
      (FS.joinPath):
      (FS.absolutePath):
      (FS.standardizePath):
      (FS.findObject):
      (FS.analyzePath):
      (FS.createFolder):
      (FS.createPath):
      (FS.createFile):
      (FS.createDataFile):
      (FS.createDevice):
      (FS.createLink):
      (FS.forceLoadFile):
      (FS.LazyUint8Array):
      (FS.LazyUint8Array.prototype.get if):
      (FS.LazyUint8Array.prototype):
      (FS.LazyUint8Array.prototype.setDataGetter):
      (FS.LazyUint8Array.prototype.cacheLength.doXHR):
      (FS.LazyUint8Array.prototype.cacheLength):
      (FS.get Object):
      (FS.get var):
      (FS.keys.forEach):
      (FS.processData.finish):
      (FS.processData):
      (FS.else):
      (FS.createPreloadedFile):
      (FS.createDefaultDirectories):
      (FS.createDefaultDevices.):
      (FS.createDefaultDevices):
      (FS.createStandardStreams):
      (FS.staticInit):
      (FS.init):
      (FS.quit):
      (FS.mount):
      (FS.lookup):
      (FS.mknod):
      (FS.create):
      (FS.mkdir):
      (FS.mkdev):
      (FS.symlink):
      (FS.rename):
      (FS.rmdir):
      (FS.readdir):
      (FS.unlink):
      (FS.readlink):
      (FS.stat):
      (FS.lstat):
      (FS.chmod):
      (FS.lchmod):
      (FS.fchmod):
      (FS.chown):
      (FS.lchown):
      (FS.fchown):
      (FS.truncate):
      (FS.ftruncate):
      (FS.utime):
      (FS.open):
      (FS.close):
      (FS.llseek):
      (FS.read):
      (FS.write):
      (FS.allocate):
      (FS.mmap):
      (_send):
      (_pwrite):
      (_write):
      (_fwrite):
      (__reallyNegative):
      (.getNextArg):
      (.switch.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.break):
      (.switch.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.case.string_appeared_here.break):
      (_fprintf):
      (_printf):
      (_fputs):
      (_fputc):
      (_puts):
      (_abort):
      (___errno_location):
      (_sbrk.Runtime.dynamicAlloc):
      (_sbrk):
      (_sysconf):
      (_time):
      (Browser.mainLoop.pause):
      (Browser.mainLoop.resume):
      (Browser.mainLoop.updateStatus):
      (Browser.init.imagePlugin.string_appeared_here):
      (Browser.init.img.onload):
      (Browser.init.img.onerror):
      (Browser.init.audioPlugin.string_appeared_here):
      (Browser.init.finish):
      (Browser.init.fail):
      (Browser.init.audio.onerror.encode64):
      (Browser.init.audio.onerror):
      (Browser.init.audio):
      (Browser.init.else):
      (Browser.init.pointerLockChange):
      (Browser.init.canvas):
      (Browser.init):
      (Browser.destroyContext):
      (Browser.fullScreenChange):
      (Browser.requestFullScreen):
      (Browser.requestAnimationFrame):
      (Browser.safeRequestAnimationFrame):
      (Browser.safeSetTimeout):
      (Browser.safeSetInterval):
      (Browser.getMimetype):
      (Browser.getUserMedia):
      (Browser.getMovementX):
      (Browser.getMovementY):
      (Browser.calculateMouseEvent):
      (Browser.xhr.onload):
      (Browser.xhrLoad):
      (Browser.updateResizeListeners):
      (Browser.setCanvasSize):
      (Browser.setFullScreenCanvasSize):
      (Browser.setWindowedCanvasSize):
      (__ATINIT__.unshift):
      (__ATMAIN__.push):
      (__ATEXIT__.push):
      (Module.string_appeared_here):
      (invoke_ii):
      (invoke_v):
      (invoke_iii):
      (invoke_vi):
      (asmPrintInt):
      (asmPrintFloat):
      (asm):
      (Runtime.stackAlloc):
      (i64Math):
      (i64Math.):
      (Module.string_appeared_here.Module.callMain.callMain.pad):
      (Module.string_appeared_here.Module.callMain):
      (run.doRun):
      (run.else):
      (run):
      (exit):
      (abort):
      * fast/js/script-tests/dfg-get-closure-var-put-closure-var-interference.js: Added.
      (foo):
      (thingy.return.bar):
      (thingy.return.baz):
      (thingy):
      (runIt):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f2ad8a1
    • dbates@webkit.org's avatar
      <https://webkit.org/b/120072> Use nullAtom instead of defining static local in · 620c79bc
      dbates@webkit.org authored
      Accessibility{Object, RenderObject}::actionVerb()
      
      Reviewed by Chris Fleizach.
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::actionVerb):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::actionVerb):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      620c79bc
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=120073 · 53c52751
      barraclough@apple.com authored
      Remove use of GOPD from JSFunction::defineProperty
      
      Reviewed by Oliver Hunt.
      
      Call getOwnPropertySlot to check for existing properties instead.
      
      * runtime/JSFunction.cpp:
      (JSC::JSFunction::defineOwnProperty):
          - getOwnPropertyDescriptor -> getOwnPropertySlot
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53c52751
    • dbates@webkit.org's avatar
      <https://webkit.org/b/119914> [iOS] Upstream changes to WebCore/accessibility · 903c4d7e
      dbates@webkit.org authored
      Reviewed by Darin Adler and Chris Fleizach.
      
      * accessibility/AccessibilityMenuList.cpp:
      (WebCore::AccessibilityMenuList::press):
      (WebCore::AccessibilityMenuList::isCollapsed):
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::headingElementForNode):
      (WebCore::AccessibilityObject::actionVerb):
      * accessibility/AccessibilityObject.h:
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::boundsForVisiblePositionRange):
      (WebCore::AccessibilityRenderObject::actionVerb):
      * accessibility/AccessibilityTableColumn.cpp:
      (WebCore::AccessibilityTableColumn::computeAccessibilityIsIgnored):
      * accessibility/AccessibilityTableHeaderContainer.cpp:
      (WebCore::AccessibilityTableHeaderContainer::computeAccessibilityIsIgnored):
      * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      903c4d7e
    • bruno.d@partner.samsung.com's avatar
      [css3-text] Implement CSS3 text-decoration shorthand · d88be043
      bruno.d@partner.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=92000
      
      Implements the text-decoration shorthand (with -webkit- prefix), as specified by the CSS3 Text Decoration specification:
      http://dev.w3.org/csswg/css-text-decor-3/#text-decoration-property
      
      Backported from Blink:
      https://src.chromium.org/viewvc/blink?revision=156266&view=revision
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d88be043
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=120067 · 904726e7
      barraclough@apple.com authored
      Remove getPropertyDescriptor
      
      Reviewed by Oliver Hunt.
      
      This is used by lookupGetter/lookupSetter - this can easily bee replaced by getPropertySlot.
      Since we'll be getting the GetterSetter from the slot in the setter case, rename isGetter() to isAccessor().
      
      * runtime/JSObject.cpp:
      * runtime/JSObject.h:
          - remove getPropertyDescriptor
      * runtime/ObjectPrototype.cpp:
      (JSC::objectProtoFuncLookupGetter):
      (JSC::objectProtoFuncLookupSetter):
          - replace call to getPropertyDescriptor with getPropertySlot
      * runtime/PropertyDescriptor.h:
      * runtime/PropertySlot.h:
      (JSC::PropertySlot::isAccessor):
      (JSC::PropertySlot::isCacheableGetter):
      (JSC::PropertySlot::getterSetter):
          - rename isGetter() to isAccessor()
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      904726e7
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=120054 · e25699e6
      barraclough@apple.com authored
      Remove some dead code following getOwnPropertyDescriptor cleanup
      
      Reviewed by Oliver Hunt.
      
      ../JavaScriptCore: 
      
      * runtime/Lookup.h:
      (JSC::getStaticFunctionSlot):
          - remove getStaticPropertyDescriptor, getStaticFunctionDescriptor, getStaticValueDescriptor.
      
      ../WebCore: 
      
      * bindings/js/JSPluginElementFunctions.cpp:
      * bindings/js/JSPluginElementFunctions.h:
          - remove runtimeObjectCustomGetOwnPropertyDescriptor, pluginElementCustomGetOwnPropertyDescriptor
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e25699e6
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=120053 · ff3cff75
      barraclough@apple.com authored
      Remove custom getOwnPropertyDescriptor for JSNPObject
      
      Reviewed by Oliver Hunt.
      
      Think this is the last one!
      
      * WebProcess/Plugins/Netscape/JSNPObject.cpp:
          - Remove custom getOwnPropertyDescriptor implementation.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff3cff75
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=120052 · 25614ab6
      barraclough@apple.com authored
      Remove custom getOwnPropertyDescriptor for JSProxy
      
      Reviewed by Geoff Garen.
      
      GET_OWN_PROPERTY_DESCRIPTOR_IMPL runs afoul with JSProxy due to the workaround for JSDOMWindow's broken behavior.
      Because the window object incorrectly searches the prototype chain in getOwnPropertySlot we check that the base
      object matches, but in the case of JSProxy we can end up comparing the window object to the window shell & falsely
      assuming this is a prototype property. Add toThis conversion to correctly identify proxied own access. I've kept
      the original slotBase check as a fast case, and also so that direct access on JSDOMWindow still works.
      
      * runtime/JSProxy.cpp:
          - Remove custom getOwnPropertyDescriptor implementation.
      * runtime/PropertyDescriptor.h:
          - Modify own property access check to perform toThis conversion.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25614ab6
    • achristensen@apple.com's avatar
      Use PlatformArchitecture to distinguish between 32-bit and 64-bit builds on Windows. · 64923f13
      achristensen@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119512
      
      Reviewed by Brent Fulgham.
      
      Source/JavaScriptCore: 
      
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
      * JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
      * JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj:
      * JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj:
      * JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj:
      * JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractorCommon.props:
      Replaced obj32, bin32, and lib32 with macros for 64-bit build.
      
      Source/ThirdParty: 
      
      * gtest/msvc/gtest-md.vcxproj:
      Replaced obj32, bin32, and lib32 with macros for 64-bit build.
      
      Source/WebCore: 
      
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.vcxproj/WebCoreCommon.props:
      * WebCore.vcxproj/WebCoreGeneratedCommon.props:
      * WebCore.vcxproj/WebCoreTestSupport.vcxproj:
      * WebCore.vcxproj/WebCoreTestSupport.vcxproj.filters:
      Replaced obj32, bin32, and lib32 with macros for 64-bit build.
      
      Source/WebKit: 
      
      * WebKit.vcxproj/Interfaces/InterfacesCommon.props:
      * WebKit.vcxproj/WebKit/WebKit.vcxproj:
      * WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
      * WebKit.vcxproj/WebKit/WebKitCommon.props:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj:
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.filters:
      * WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj:
      * WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters:
      * WebKit.vcxproj/WebKitGUID/WebKitGUIDCommon.props:
      Replaced obj32, bin32, and lib32 with macros for 64-bit build.
      
      Source/WTF: 
      
      * WTF.vcxproj/WTFGeneratedCommon.props:
      Replaced obj32, bin32, and lib32 with macros for 64-bit build.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64923f13
    • dbates@webkit.org's avatar
      <https://webkit.org/b/120032> Add DRT test to ensure that AccessibilityObject::stringValue() · cc030563
      dbates@webkit.org authored
      of <input type="file"> is meaningful
      
      Reviewed by Chris Fleizach.
      
      Adds a DRT test to ensure that AccessibilityObject::stringValue() returns a meaningful string
      for a single file- and multiple files-file upload control.
      
      * accessibility/file-upload-button-stringvalue.html: Added.
      * platform/mac-wk2/accessibility/file-upload-button-stringvalue-expected.txt: Added.
      * platform/mac/accessibility/file-upload-button-stringvalue-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc030563
    • jberlin@webkit.org's avatar
      Remove a string no longer used after r154251. · cbe678d0
      jberlin@webkit.org authored
      Rubber-stamped by Brady Eidson.
      
      * English.lproj/Localizable.strings:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cbe678d0
    • commit-queue@webkit.org's avatar
      [BlackBerry] Avoid an assertion from calling releaseBufferDrawable(nullptr) · 227c97ef
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119862
      JIRA 470760
      
      Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-08-20
      Reviewed by Antonio Gomes.
      
      destroyBuffer() finds a null pointer valid but
      releaseBufferDrawable() does not. Fix by adding a
      null pointer check.
      
      No new tests, caught by existing layout test runs.
      
      * platform/graphics/blackberry/ImageBufferBlackBerry.cpp:
      (WebCore::ImageBuffer::~ImageBuffer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      227c97ef
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/119487> [Gtk] Cancel authentication on load failed · 7a65b1a4
      commit-queue@webkit.org authored
      Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-08-20
      Reviewed by Martin Robinson.
      
      Added callback to handle load-failed event in default authentication dialog.
      Authentication request gets cancelled and the dialog widget gets destroyed.
      
      * UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:
      (pageLoadFailed):
      (webkitAuthenticationDialogInitialize):
      (webkitAuthenticationDialogDispose):
      (webkit_authentication_dialog_class_init):
      (webkitAuthenticationDialogNew):
      * UIProcess/API/gtk/WebKitAuthenticationDialog.h:
      * UIProcess/API/gtk/WebKitWebView.cpp:
      (webkitWebViewAuthenticate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a65b1a4
    • kov@webkit.org's avatar
      <https://webkit.org/b/120048> [GTK] Add stubs for APIs that went missing in the DOM bindings · 39952866
      kov@webkit.org authored
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      No new tests, these are just stubs for the DOM bindings API.
      
      * bindings/gobject/WebKitDOMCustom.cpp:
      (webkit_dom_bar_info_get_property):
      (webkit_dom_bar_info_class_init):
      (webkit_dom_bar_info_init):
      (webkit_dom_bar_info_get_visible):
      (webkit_dom_console_get_memory):
      (webkit_dom_css_style_declaration_get_property_css_value):
      (webkit_dom_document_get_webkit_hidden):
      (webkit_dom_document_get_webkit_visibility_state):
      (webkit_dom_html_document_open):
      (webkit_dom_html_element_set_item_id):
      (webkit_dom_html_element_get_item_id):
      (webkit_dom_html_element_get_item_ref):
      (webkit_dom_html_element_get_item_prop):
      (webkit_dom_html_element_set_item_scope):
      (webkit_dom_html_element_get_item_scope):
      (webkit_dom_html_element_get_item_type):
      (webkit_dom_html_properties_collection_get_property):
      (webkit_dom_html_properties_collection_class_init):
      (webkit_dom_html_properties_collection_init):
      (webkit_dom_html_properties_collection_item):
      (webkit_dom_html_properties_collection_named_item):
      (webkit_dom_html_properties_collection_get_length):
      (webkit_dom_html_properties_collection_get_names):
      (webkit_dom_node_get_attributes):
      (webkit_dom_node_has_attributes):
      (webkit_dom_memory_info_get_property):
      (webkit_dom_memory_info_class_init):
      (webkit_dom_memory_info_init):
      (webkit_dom_memory_info_get_total_js_heap_size):
      (webkit_dom_memory_info_get_used_js_heap_size):
      (webkit_dom_memory_info_get_js_heap_size_limit):
      (webkit_dom_micro_data_item_value_class_init):
      (webkit_dom_micro_data_item_value_init):
      (webkit_dom_performance_get_memory):
      (webkit_dom_property_node_list_get_property):
      (webkit_dom_property_node_list_class_init):
      (webkit_dom_property_node_list_init):
      (webkit_dom_property_node_list_item):
      (webkit_dom_property_node_list_get_length):
      * bindings/gobject/WebKitDOMCustom.h:
      
      Tools:
      
      * Scripts/webkitpy/style/checker.py: add the bindings custom implementation files to be exempt
      from naming/enum_casing rules, since it needs to provide GObject-style APIs.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39952866
    • antti@apple.com's avatar
      <https://webkit.org/b/120017> Remove NodeRenderingTraversal::ParentDetails · b4267a36
      antti@apple.com authored
      Reviewed by Andreas Kling.
      
      Remove this oddly factored type that is used to optionally collect some data during ComposedShadowTreeWalker parent traversal.
              
      Also removed support for reset-style-inheritance attribute in InsertionPoint. We don't use or expose it.
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::State::initForStyleResolve):
      (WebCore::StyleResolver::styleForElement):
      * css/StyleResolver.h:
      (WebCore::StyleResolver::State::State):
      (WebCore::StyleResolver::State::elementLinkState):
              
          Remove m_distributedToInsertionPoint State field. We never hit the cases where it was used.
      
      * dom/ComposedShadowTreeWalker.cpp:
      (WebCore::ComposedShadowTreeWalker::traverseSiblingOrBackToInsertionPoint):
      (WebCore::ComposedShadowTreeWalker::traverseNodeEscapingFallbackContents):
      (WebCore::ComposedShadowTreeWalker::traverseParent):
              
          Return null instead of setting childWasOutOfComposition to details object. That's what would happen anyway in the caller.
      
      (WebCore::ComposedShadowTreeWalker::traverseParentInCurrentTree):
      (WebCore::ComposedShadowTreeWalker::traverseParentBackToShadowRootOrHost):
      * dom/ComposedShadowTreeWalker.h:
      * dom/Node.cpp:
      (WebCore::Node::insertionParentForBinding):
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::NodeRenderingContext):
      (WebCore::NodeRenderingContext::isOnEncapsulationBoundary):
              
          Make this look up InsertionPoint directly intead of relying it being populated in m_parentDetails. The function is used only in
          a few non-performance critical places.
      
      (WebCore::NodeRenderingContext::resetStyleInheritance):
              
          Return parent ShadowRoots resetStyleInheritance() flag instead of using m_parentDetails.
      
      * dom/NodeRenderingContext.h:
      * dom/NodeRenderingTraversal.cpp:
      (WebCore::NodeRenderingTraversal::parentSlow):
      * dom/NodeRenderingTraversal.h:
      (WebCore::NodeRenderingTraversal::parent):
              
          Remove ParentDetails.
      
      * html/HTMLAttributeNames.in:
      * html/shadow/InsertionPoint.cpp:
              
          Remove unused resetStyleInheritance attribute.
      
      (WebCore::InsertionPoint::removedFrom):
      (WebCore::findInsertionPointOf):
              
          Renamed for clarity.
      
      * html/shadow/InsertionPoint.h:
      * testing/Internals.cpp:
      (WebCore::Internals::includerFor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4267a36
    • antti@apple.com's avatar
      <https://webkit.org/b/120025> REGRESSION (r154254):... · 927b66db
      antti@apple.com authored
      <https://webkit.org/b/120025> REGRESSION (r154254): fast/frames/frameset-frameborder-inheritance.html failing on Apple MountainLion Debug WK1 (Tests)
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      * html/HTMLDocument.cpp:
      (WebCore::HTMLDocument::isFrameSet):
      * html/HTMLFrameElement.cpp:
      (WebCore::HTMLFrameElement::didAttachRenderers):
              
          Make helper public in HTMLFrameSetElement.
      
      * html/HTMLFrameSetElement.cpp:
      (WebCore::HTMLFrameSetElement::findContaining):
              
          Static function for finding containing frameset, if any.
      
      (WebCore::HTMLFrameSetElement::willAttachRenderers):
              
          This broke in refactoring. We should exit the loop when the first containing frameset is found. Fix by refactoring more.
      
      * html/HTMLFrameSetElement.h:
      (WebCore::isHTMLFrameSetElement):
      (WebCore::toHTMLFrameSetElement):
              
          Add casting functions.
      
      * rendering/RenderFrameSet.cpp:
      (WebCore::RenderFrameSet::frameSet):
      
      LayoutTests: 
      
      * platform/mac/TestExpectations: Unskip.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      927b66db
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/120056> [GTK][ARM] enable DFG_JIT · 6a0bf880
      commit-queue@webkit.org authored
      Patch by Víctor Manuel Jáquez Leal <vjaquez@igalia.com> on 2013-08-20
      Reviewed by Martin Robinson.
      
      Enable DFG_JIT in GTK+ platform for ARM/Thumb architecture
      
      * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a0bf880
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/120062> Missing ensureSpace call in sh4 baseline JIT. · 97f763a0
      commit-queue@webkit.org authored
      Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-08-20
      Reviewed by Allan Sandfeld Jensen.
      
      branchPtrWithPatch() of baseline JIT must ensure that space is available for its
      instructions and two constants now DFG is enabled for sh4 architecture.
      These missing ensureSpace calls lead to random crashes.
      
      * assembler/MacroAssemblerSH4.h:
      (JSC::MacroAssemblerSH4::branchPtrWithPatch):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97f763a0
    • antti@apple.com's avatar
      <https://webkit.org/b/120023> REGRESSION(r154257): svg/custom/bug78807.svg and... · 3ae23fe9
      antti@apple.com authored
      <https://webkit.org/b/120023> REGRESSION(r154257): svg/custom/bug78807.svg and svg/custom/use-invalid-style.svg failing
      
      Source/WebCore: 
      
      Reviewed by Andreas Kling.
      
      * xml/XMLErrors.cpp:
      (WebCore::XMLErrors::insertErrorMessageBlock): "reattach" had accidentally turned into "detach" in refactoring.
      
      LayoutTests: 
      
      Reviewed by by Andreas Kling.
      
      * TestExpectations: Unskip.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ae23fe9
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/120009> [GTK] Stop button should be added to MiniBrowser · 71c09a7b
      commit-queue@webkit.org authored
      Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-08-20
      Reviewed by Martin Robinson.
      
      Added stop button in MiniBrowser
      
      * MiniBrowser/gtk/BrowserWindow.c:
      (reloadOrStopCallback): Callback to handle stop or reload button click.
      (webViewLoadProgressChanged): Update reload or stop button icon.
      (browser_window_init): Save button pointer for further icon updates.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71c09a7b
    • allan.jensen@digia.com's avatar
      [Qt][WK2] Doesn't build without Plugin-process · 4ad11389
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120060
      
      Reviewed by Jocelyn Turcotte.
      
      Disable netscape plugin api in WebKit2 when the plugin architecture is unsupported for WebKit2.
      
      * Target.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ad11389
    • antti@apple.com's avatar
      <https://webkit.org/b/119969> REGRESSION (r154232): Crash on the japantimes.co.jp · 3cf260a2
      antti@apple.com authored
      Source/WebCore: 
      
      Reviewed by Andreas Kling.
              
      PseudoElement no longer has parent and calling Element::insertedInto for them crashes as it tries to access it.
      
      Normally there are no pseudo elements when Element::insertedInto() is invoked as they get detached and attached
      along with rendering. However in this case the page inserts a <style> that uses ::before along with an element
      that it applies to. Stylesheet insertion triggers synchronous style recalc that attaches rendering to all newly
      insered elements. Later Element::insertedInto gets called for the element that has pseudo element and we crash.
      
      Test: fast/css-generated-content/insert-stylesheet-and-pseudo-crash.html
      
      * dom/Element.cpp:
      (WebCore::Element::insertedInto):
      (WebCore::Element::removedFrom):
              
          Remove calls to insertedInto/removedFrom for pseudo elements. They are not considered to be in document.
          When they are added normally during render tree attach these calls don't happen either.
      
      LayoutTests: 
      
      Reviewed by Andreas Kling.
      
      * fast/css-generated-content/insert-stylesheet-and-pseudo-crash-expected.txt: Added.
      * fast/css-generated-content/insert-stylesheet-and-pseudo-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154320 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cf260a2
    • simon.pena@samsung.com's avatar
      Added missing Reviewed By line. · d0e29b01
      simon.pena@samsung.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0e29b01
    • simon.pena@samsung.com's avatar
      <https://webkit.org/b/117584> [GTK][WK1]... · 6ee4f8a3
      simon.pena@samsung.com authored
      <https://webkit.org/b/117584> [GTK][WK1] http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html is failing
      
      Update DumpRenderTree to handle the WEBKIT_LOAD_FAILED status,
      printing didFailLoadWithError.
      
      Tools:
      
      Behave like other ports, and handle WEBKIT_LOAD_FAILED status in
      DumpRenderTree, printing didFailLoadWithError.
      
      * DumpRenderTree/gtk/DumpRenderTree.cpp:
      (webFrameLoadStatusNotified):
      
      LayoutTests:
      
      Adding that print makes
      http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html
      and
      http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html,
      although it requires to modify the expected results for
      http/tests/loading/pdf-commit-load-callbacks.html.
      
      * platform/gtk-wk1/TestExpectations: Unskip
      http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html
      and
      http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html
      * platform/gtk/http/tests/loading/pdf-commit-load-callbacks-expected.txt:
      Update the expected results.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ee4f8a3
    • rniwa@webkit.org's avatar
      Windows build fix after r154314. · 8ceaac2f
      rniwa@webkit.org authored
      * platform/graphics/cg/PathCG.cpp:
      (WebCore::Path::platformAddPathForRoundedRect):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ceaac2f
    • commit-queue@webkit.org's avatar
      [Cairo] Canvas putImageData is not working as expected · dc967a9c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119992
      
      Patch by Hurnjoo Lee <hurnjoo.lee@samsung.com> on 2013-08-19
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      ImageBufferCairo::putImageArray didn't perform pre-multiply in case of zero alpha value.
      If the alpha value is not 255, image data should always be pre-multiplied.
      
      Test: fast/canvas/canvas-putImageData-zero-alpha.html
      
      * platform/graphics/cairo/ImageBufferCairo.cpp:
      (WebCore::ImageBuffer::putByteArray):
      
      LayoutTests:
      
      Add a ref test that ensures that putImageData of canvas with zero alpha work correctly.
      
      * fast/canvas/canvas-putImageData-zero-alpha-expected.html: Added.
      * fast/canvas/canvas-putImageData-zero-alpha.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154316 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc967a9c
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/119991> change usage of... · 11174a2c
      commit-queue@webkit.org authored
      <https://webkit.org/b/119991> change usage of calculateUTCOffset()/calculateDSTOffset  to calculateLocalTimeOffset
      
      Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-08-19
      Reviewed by Darin Adler.
      
      Resolving code error.
      
      * html/BaseDateAndTimeInputType.cpp:
      (WebCore::BaseDateAndTimeInputType::defaultValueForStepUp):
      * html/MonthInputType.cpp:
      (WebCore::MonthInputType::defaultValueForStepUp):
      * html/TimeInputType.cpp:
      (WebCore::TimeInputType::defaultValueForStepUp):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154315 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11174a2c
    • rniwa@webkit.org's avatar
      <https://webkit.org/b/120049> Delete code for Snow Leopard · 3feac41c
      rniwa@webkit.org authored
      Reviewed by Benjamin Poulain.
      
      Source/WebCore:
      
      Delete all the code for Mac OS 10.6. Nobody builds on Snow Leopard at this point.
      
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      * editing/mac/EditorMac.mm:
      (WebCore::Editor::pasteWithPasteboard):
      * page/ContextMenuController.cpp:
      (WebCore::ContextMenuController::populate):
      * platform/LocalizedStrings.cpp:
      (WebCore::truncatedStringForLookupMenuItem):
      (WebCore::contextMenuItemTagSearchWeb):
      (WebCore::contextMenuItemTagLookUpInDictionary):
      * platform/MemoryPressureHandler.cpp:
      * platform/audio/mac/AudioBusMac.mm:
      (WebCore::AudioBus::loadPlatformResource):
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
      * platform/graphics/ca/PlatformCALayer.h:
      * platform/graphics/ca/mac/PlatformCALayerMac.mm:
      (PlatformCALayer::acceleratesDrawing):
      (PlatformCALayer::setAcceleratesDrawing):
      (PlatformCALayer::contentsScale):
      (PlatformCALayer::setContentsScale):
      (PlatformCALayer::synchronouslyDisplayTilesInRect):
      * platform/graphics/ca/mac/TileController.mm:
      (WebCore::TileController::setScale):
      (WebCore::TileController::setAcceleratesDrawing):
      (WebCore::TileController::createTileLayer):
      * platform/graphics/cg/ImageBufferDataCG.cpp:
      (WebCore::ImageBufferData::getData):
      (WebCore::ImageBufferData::putData):
      * platform/graphics/cg/ImageBufferDataCG.h:
      * platform/graphics/cg/PathCG.cpp:
      (WebCore::Path::platformAddPathForRoundedRect):
      * platform/graphics/cocoa/FontPlatformDataCocoa.mm:
      (WebCore::FontPlatformData::FontPlatformData):
      (WebCore::FontPlatformData::setFont):
      * platform/graphics/mac/FontMac.mm:
      (WebCore::showGlyphsWithAdvances):
      * platform/graphics/mac/GraphicsContextMac.mm:
      (WebCore::GraphicsContext::drawLineForDocumentMarker):
      * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
      (WebCore::MediaPlayerPrivateQTKit::createQTMovie):
      (WebCore::MediaPlayerPrivateQTKit::layerHostChanged):
      * platform/graphics/mac/WebLayer.mm:
      (drawLayerContents):
      * platform/mac/CursorMac.mm:
      (WebCore::Cursor::ensurePlatformCursor):
      * platform/mac/EmptyProtocolDefinitions.h: Removed.
      * platform/mac/MemoryPressureHandlerMac.mm:
      (WebCore::MemoryPressureHandler::releaseMemory):
      * platform/mac/NSScrollerImpDetails.h:
      * platform/mac/PlatformEventFactoryMac.mm:
      (WebCore::momentumPhaseForEvent):
      (WebCore::phaseForEvent):
      * platform/mac/ScrollAnimatorMac.mm:
      * platform/mac/SharedTimerMac.mm:
      * platform/mac/WebCoreSystemInterface.h:
      * platform/mac/WebCoreSystemInterface.mm:
      * platform/network/mac/ResourceHandleMac.mm:
      * platform/network/mac/ResourceRequestMac.mm:
      (WebCore::ResourceRequest::doUpdateResourceRequest):
      (WebCore::ResourceRequest::doUpdatePlatformRequest):
      * platform/text/cf/HyphenationCF.cpp:
      * platform/text/mac/HyphenationMac.mm: Removed.
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::containsPaintedContent):
      * rendering/RenderThemeMac.mm:
      (WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
      
      Source/WebKit/mac:
      
      * DefaultDelegates/WebDefaultContextMenuDelegate.mm:
      (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):
      (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
      * Misc/WebNSControlExtras.m:
      (-[NSControl sizeToFitAndAdjustWindowHeight]):
      * Misc/WebNSFileManagerExtras.mm:
      * WebCoreSupport/WebEditorClient.mm:
      (WebEditorClient::shouldEraseMarkersAfterChangeSelection):
      (WebEditorClient::getGuessesForWord):
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::dispatchDidLayout):
      (WebFrameLoaderClient::provisionalLoadStarted):
      * WebCoreSupport/WebSystemInterface.mm:
      (InitWebCoreSystemInterface):
      * WebKitPrefix.h:
      * WebView/WebDynamicScrollBarsView.mm:
      (-[WebDynamicScrollBarsView scrollWheel:]):
      * WebView/WebFullScreenController.mm:
      (convertRectToScreen):
      (-[WebFullScreenController finishedEnterFullScreenAnimation:]):
      (-[WebFullScreenController exitFullScreen]):
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]):
      (-[WebHTMLView removeMouseMovedObserver]):
      (-[WebHTMLView windowDidBecomeKey:]):
      (-[WebHTMLView windowDidResignKey:]):
      * WebView/WebView.mm:
      (-[WebView _deviceScaleFactor]):
      
      Source/WebKit2:
      
      * NetworkProcess/mac/NetworkProcessMac.mm:
      (WebKit::overrideSystemProxies):
      (WebKit::NetworkProcess::platformInitializeNetworkProcess):
      * WebKit2Prefix.h:
      
      Source/WTF:
      
      * wtf/FastMalloc.cpp:
      (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
      * wtf/FeatureDefines.h:
      * wtf/Platform.h:
      
      Tools:
      
      * DumpRenderTree/mac/CheckedMalloc.cpp:
      (protectionOfRegion):
      (makeLargeMallocFailSilently):
      * DumpRenderTree/mac/DumpRenderTree.mm:
      (resetDefaultsToConsistentValues):
      * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
      (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
      * DumpRenderTree/mac/FrameLoadDelegate.mm:
      (testPathFromURL):
      (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
      * DumpRenderTree/mac/LayoutTestHelper.m:
      * DumpRenderTree/mac/TestRunnerMac.mm:
      * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
      (WTR::InjectedBundle::platformInitialize):
      * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
      (WTR::testPathFromURL):
      (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3feac41c
  2. 19 Aug, 2013 3 commits