1. 01 Feb, 2013 40 commits
    • mhahnenberg@apple.com's avatar
      Structure should have a StructureRareData field to save space · dc3d148e
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=108659
      
      Reviewed by Oliver Hunt.
      
      Many of the fields in Structure are used in a subset of all total Structures; however, all Structures must 
      pay the memory cost of those fields, regardless of whether they use them or not. Since we can have potentially 
      many Structures on a single page (e.g. bing.com creates ~1500 Structures), it would be profitable to 
      refactor Structure so that not every Structure has to pay the memory costs for these infrequently used fields.
      
      To accomplish this, we can create a new StructureRareData class to house these seldom used fields which we 
      can allocate on demand whenever a Structure requires it. This StructureRareData can itself be a JSCell, and 
      can do all the marking of the fields for the Structure. The StructureRareData field will be part of a union 
      with m_previous to minimize overhead. We'll add a new field to JSTypeInfo to indicate that the Structure has 
      a StructureRareData field. During transitions, a Structure will clone its previous Structure's StructureRareData 
      if it has one. There could be some potential for optimizing this process, but the initial implementation will 
      be dumb since we'd be paying these overhead costs for each Structure anyways.
      
      Initially we'll only put two fields in the StructureRareData to avoid a memory regression. Over time we'll 
      continue to move fields from Structure to StructureRareData. Optimistically, this could potentially reduce our 
      Structure memory footprint by up to around 75%. It could also clear the way for removing destructors from 
      Structures (and into StructureRareData).
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * Target.pri:
      * dfg/DFGRepatch.cpp: Includes for linking purposes.
      * jit/JITStubs.cpp:
      * jsc.cpp:
      * llint/LLIntSlowPaths.cpp:
      * runtime/JSCellInlines.h: Added ifdef guards.
      * runtime/JSGlobalData.cpp: New Structure for StructureRareData class.
      (JSC::JSGlobalData::JSGlobalData):
      * runtime/JSGlobalData.h:
      (JSGlobalData):
      * runtime/JSGlobalObject.h:
      * runtime/JSTypeInfo.h: New flag to indicate whether or not a Structure has a StructureRareData field.
      (JSC::TypeInfo::flags):
      (JSC::TypeInfo::structureHasRareData):
      * runtime/ObjectPrototype.cpp:
      * runtime/Structure.cpp: We use a combined WriteBarrier<JSCell> field m_previousOrRareData to avoid compiler issues.
      (JSC::Structure::dumpStatistics):
      (JSC::Structure::Structure): 
      (JSC::Structure::materializePropertyMap):
      (JSC::Structure::addPropertyTransition):
      (JSC::Structure::nonPropertyTransition):
      (JSC::Structure::pin):
      (JSC::Structure::allocateRareData): Handles allocating a brand new StructureRareData field.
      (JSC::Structure::cloneRareDataFrom): Handles cloning a StructureRareData field from another. Used during Structure 
      transitions.
      (JSC::Structure::visitChildren): We no longer have to worry about marking m_objectToStringValue.
      * runtime/Structure.h:
      (JSC::Structure::previousID): Checks the structureHasRareData flag to see where it should get the previous Structure.
      (JSC::Structure::objectToStringValue): Reads the value from the StructureRareData. If it doesn't exist, returns 0.
      (JSC::Structure::setObjectToStringValue): Ensures that we have a StructureRareData field, then forwards the function 
      call to it.
      (JSC::Structure::materializePropertyMapIfNecessary):
      (JSC::Structure::setPreviousID): Checks for StructureRareData and forwards if necessary.
      (Structure):
      (JSC::Structure::clearPreviousID): Ditto.
      (JSC::Structure::create):
      * runtime/StructureRareData.cpp: Added. All of the basic functionality of a JSCell with the fields that we've moved 
      from Structure and the functions required to access/modify those fields as Structure would have done.
      (JSC):
      (JSC::StructureRareData::createStructure):
      (JSC::StructureRareData::create):
      (JSC::StructureRareData::clone):
      (JSC::StructureRareData::StructureRareData):
      (JSC::StructureRareData::visitChildren):
      * runtime/StructureRareData.h: Added.
      (JSC):
      (StructureRareData):
      * runtime/StructureRareDataInlines.h: Added.
      (JSC):
      (JSC::StructureRareData::previousID):
      (JSC::StructureRareData::setPreviousID):
      (JSC::StructureRareData::clearPreviousID):
      (JSC::Structure::previous): Handles the ugly casting to get the value of the right type of m_previousOrRareData.
      (JSC::Structure::rareData): Ditto.
      (JSC::StructureRareData::objectToStringValue):
      (JSC::StructureRareData::setObjectToStringValue):
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * Target.pri:
      * dfg/DFGRepatch.cpp:
      * jit/JITStubs.cpp:
      * jsc.cpp:
      * llint/LLIntSlowPaths.cpp:
      * runtime/JSCellInlines.h:
      * runtime/JSGlobalData.cpp:
      (JSC::JSGlobalData::JSGlobalData):
      * runtime/JSGlobalData.h:
      (JSGlobalData):
      * runtime/JSGlobalObject.h:
      * runtime/JSTypeInfo.h:
      (JSC):
      (JSC::TypeInfo::flags):
      (JSC::TypeInfo::structureHasRareData):
      * runtime/ObjectPrototype.cpp:
      * runtime/Structure.cpp:
      (JSC::Structure::dumpStatistics):
      (JSC::Structure::Structure):
      (JSC::Structure::materializePropertyMap):
      (JSC::Structure::addPropertyTransition):
      (JSC::Structure::nonPropertyTransition):
      (JSC::Structure::pin):
      (JSC::Structure::allocateRareData):
      (JSC):
      (JSC::Structure::cloneRareDataFrom):
      (JSC::Structure::visitChildren):
      * runtime/Structure.h:
      (JSC::Structure::previousID):
      (JSC::Structure::objectToStringValue):
      (JSC::Structure::setObjectToStringValue):
      (JSC::Structure::materializePropertyMapIfNecessary):
      (JSC::Structure::setPreviousID):
      (Structure):
      (JSC::Structure::clearPreviousID):
      (JSC::Structure::previous):
      (JSC::Structure::rareData):
      (JSC::Structure::create):
      * runtime/StructureRareData.cpp: Added.
      (JSC):
      (JSC::StructureRareData::createStructure):
      (JSC::StructureRareData::create):
      (JSC::StructureRareData::clone):
      (JSC::StructureRareData::StructureRareData):
      (JSC::StructureRareData::visitChildren):
      * runtime/StructureRareData.h: Added.
      (JSC):
      (StructureRareData):
      * runtime/StructureRareDataInlines.h: Added.
      (JSC):
      (JSC::StructureRareData::previousID):
      (JSC::StructureRareData::setPreviousID):
      (JSC::StructureRareData::clearPreviousID):
      (JSC::StructureRareData::objectToStringValue):
      (JSC::StructureRareData::setObjectToStringValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc3d148e
    • commit-queue@webkit.org's avatar
      Source/WebKit/chromium: [Chromium] Ignore punctuation in spellcheck · 003eb25d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108511
      
      Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
      Reviewed by Tony Chang.
      
      * src/ContextMenuClientImpl.cpp:
      (WebKit::IsWhiteSpaceOrPunctuation): Added utility function to detect whitespace or punctuation.
      (WebKit::selectMisspellingAsync): Ignore punctuation when selecting the misspelling.
      
      LayoutTests: [Chromium] Expect spellcheck to ignore punctuation
      https://bugs.webkit.org/show_bug.cgi?id=108511
      
      Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
      Reviewed by Tony Chang.
      
      * platform/chromium/TestExpectations: Expect spellcheck to ignore punctuation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      003eb25d
    • mark.lam@apple.com's avatar
      Clean up calls to DatabaseTracker::add/removeOpenDatabase(). · 6ab8cc44
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=108431
      
      Reviewed by Geoffrey Garen.
      
      Also adapted the chromium port to work with this new code.
      Chromium parts reviewed by Michael Nordman and David Levin.
      
      This is part of the webdatabase refactoring effort.
      
      No new tests.
      
      * Modules/webdatabase/AbstractDatabaseServer.h:
      (AbstractDatabaseServer):
      * Modules/webdatabase/Database.cpp:
      (WebCore::Database::openAndVerifyVersion):
      (WebCore::Database::close):
      * Modules/webdatabase/DatabaseBackend.cpp:
      (WebCore::DatabaseBackend::DatabaseBackend):
      (WebCore::DatabaseBackend::closeDatabase):
      (DoneCreatingDatabaseOnExitCaller):
      (WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
      (WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
      (WebCore::DatabaseBackend::performOpenAndVerify):
      * Modules/webdatabase/DatabaseManager.cpp:
      (WebCore::DatabaseManager::openDatabase):
      (WebCore::DatabaseManager::openDatabaseSync):
      * Modules/webdatabase/DatabaseManager.h:
      (DatabaseManager):
      * Modules/webdatabase/DatabaseServer.cpp:
      * Modules/webdatabase/DatabaseServer.h:
      * Modules/webdatabase/DatabaseSync.cpp:
      (WebCore::DatabaseSync::~DatabaseSync):
      (WebCore::DatabaseSync::openAndVerifyVersion):
      (WebCore::DatabaseSync::closeImmediately):
      * Modules/webdatabase/DatabaseSync.h:
      (DatabaseSync):
      * Modules/webdatabase/DatabaseTracker.cpp:
      (WebCore::DatabaseTracker::doneCreatingDatabase):
      (WebCore::DatabaseTracker::addOpenDatabase):
      * Modules/webdatabase/DatabaseTracker.h:
      (DatabaseTracker):
      * Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:
      (WebCore::DatabaseTracker::addOpenDatabase):
      (WebCore::DatabaseTracker::prepareToOpenDatabase):
      (WebCore::DatabaseTracker::failedToOpenDatabase):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ab8cc44
    • andersca@apple.com's avatar
      More work on UI side storage · ee87f391
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=108700
      
      Reviewed by Sam Weinig.
      
      * DerivedSources.make:
      Add StorageManager.messages.in.
      
      * Platform/CoreIPC/HandleMessage.h:
      (CoreIPC::callMemberFunction):
      Add new overload.
      
      * UIProcess/Storage/StorageManager.cpp:
      (WebKit::StorageManager::didReceiveMessageOnConnectionWorkQueue):
      Call the right function.
      
      (WebKit::StorageManager::createStorageArea):
      (WebKit::StorageManager::destroyStorageArea):
      Add stubs.
      
      * UIProcess/Storage/StorageManager.messages.in: Added.
      Add new messages files.
      
      * WebKit2.xcodeproj/project.pbxproj:
      Add new files.
      
      * WebProcess/Storage/StorageAreaProxy.cpp:
      (WebKit::StorageAreaProxy::~StorageAreaProxy):
      Add another FIXME.
      
      (WebKit::StorageAreaProxy::canAccessStorage):
      (WebKit::StorageAreaProxy::incrementAccessCount):
      (WebKit::StorageAreaProxy::decrementAccessCount):
      Implement these.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee87f391
    • commit-queue@webkit.org's avatar
      Web Inspector: remove extra padding around overlay highlight. · 02823a4c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108679
      
      Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-01
      Reviewed by Alexander Pavlov.
      
      Source/WebCore:
      
      No new tests: no change in behaviour.
      
      Remove extraWidth from overlay highlight spans.
      
      * inspector/front-end/DefaultTextEditor.js:
      (WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
      
      LayoutTests:
      
      Update layout test expectations to correspond to updated overlay highlight style.
      
      * inspector/editor/text-editor-highlight-api-expected.txt:
      * inspector/editor/text-editor-highlight-token-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02823a4c
    • commit-queue@webkit.org's avatar
      Allow prettify.rb to be run from any directory, and don't hard-code the system ruby path · f4432b76
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108569
      
      Patch by Nathan de Vries <ndevries@apple.com> on 2013-02-01
      Reviewed by Joseph Pecoraro.
      
      * PrettyPatch/prettify.rb:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4432b76
    • pdr@google.com's avatar
      Prevent skipped repaints for children of inner SVG elements · 530a782e
      pdr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=108429
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      This patch fixes a bug caused by r108699 and r133786 where we would not repaint children
      of inner SVG elements because "m_didTransformToRootUpdate" was never reset on viewport
      containers. The stale m_didTransformToRootUpdate variable caused us to skip child repaints.
      
      I verified that the Robohornet SVG benchmark performance gains in r133786 are not regressed
      with this patch.
      
      Test: svg/repaint/svgsvgelement-repaint-children.html
      
      * rendering/svg/RenderSVGViewportContainer.cpp:
      (WebCore::RenderSVGViewportContainer::calcViewport):
      
          This can be removed because setNeedsTransformUpdate() will set m_needsTransformUpdate.
      
      (WebCore::RenderSVGViewportContainer::calculateLocalTransform):
      
          This change is straightforward and is similar to the equivalent assignment in
          RenderSVGTransformableContainer::calculateLocalTransform().
      
      LayoutTests:
      
      Need to update expectations for a single file (just a 1px difference).
      
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      * svg/repaint/svgsvgelement-repaint-children-expected.png: Added.
      * svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
      * svg/repaint/svgsvgelement-repaint-children.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      530a782e
    • pdr@google.com's avatar
      [Chromium] Unreviewed gardening of two svg/zoom/page tests. · 8829609e
      pdr@google.com authored
      This change rebaselines two tests for WK108108.
      
      Unreviewed update of test expectations.
      
      * platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
      * platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8829609e
    • roger_fong@apple.com's avatar
      Unreviewed. Fix webkitpy tests since a build_style is not specified in some cases. · 09ae9414
      roger_fong@apple.com authored
      * Scripts/webkitpy/tool/steps/runtests.py:
      (RunTests.run):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09ae9414
    • fmalita@chromium.org's avatar
      [Chromium] Unreviewed gardening. · 2d4b7df6
      fmalita@chromium.org authored
      Skip a test added in r14618 that uses setAutomaticLinkDetectionEnabled.
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d4b7df6
    • commit-queue@webkit.org's avatar
      offlineasm BaseIndex handling is broken on ARM due to MIPS changes · c54d3283
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108261
      
      Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-02-01
      Reviewed by Filip Pizlo.
      
      offlineasm BaseIndex handling fix on MIPS.
      
      * offlineasm/mips.rb:
      * offlineasm/risc.rb:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c54d3283
    • caio.oliveira@openbossa.org's avatar
      [Gtk] [WK2] Fix build after r141619 · 73ab78c5
      caio.oliveira@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108687
      
      Reviewed by Benjamin Poulain.
      
      Take a reference instead of a pointer for decoding functions.
      
      * Platform/gtk/SharedMemoryGtk.cpp:
      (WebKit::SharedMemory::Handle::decode):
      * Shared/gtk/ArgumentCodersGtk.cpp:
      (CoreIPC::decodeImage):
      (CoreIPC::decodeDataObject):
      (CoreIPC::::decode):
      (CoreIPC::decodeGKeyFile):
      (CoreIPC::decode):
      * Shared/gtk/ArgumentCodersGtk.h:
      * Shared/gtk/LayerTreeContextGtk.cpp:
      (WebKit::LayerTreeContext::decode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73ab78c5
    • caio.oliveira@openbossa.org's avatar
      [EFL] [WK2] Fix build after r141619 · 56298f91
      caio.oliveira@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108683
      
      Reviewed by Benjamin Poulain.
      
      Take a reference instead of a pointer for decoding functions.
      
      * Shared/WebBatteryStatus.cpp:
      (WebKit::WebBatteryStatus::Data::decode):
      * Shared/WebBatteryStatus.h:
      (Data):
      * Shared/WebNetworkInfo.cpp:
      (WebKit::WebNetworkInfo::Data::decode):
      * Shared/WebNetworkInfo.h:
      (Data):
      * Shared/cairo/LayerTreeContextCairo.cpp:
      (WebKit::LayerTreeContext::decode):
      * Shared/efl/LayerTreeContextEfl.cpp:
      (WebKit::LayerTreeContext::decode):
      * Shared/soup/PlatformCertificateInfo.cpp:
      (WebKit::PlatformCertificateInfo::decode):
      * Shared/soup/PlatformCertificateInfo.h:
      (PlatformCertificateInfo):
      * Shared/soup/WebCoreArgumentCodersSoup.cpp:
      (CoreIPC::::decodePlatformData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56298f91
    • commit-queue@webkit.org's avatar
      [Mac] Layout test fast/parser/parser-yield-timing.html is flaky on debug bots · f236e4df
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108677
      
      Patch by David Farler <dfarler@apple.com> on 2013-02-01
      Reviewed by Tim Horton.
      
      * platform/mac/TestExpectations:
      Mark fast/parser/parser-yield-timing.html as [ Pass Failure ]
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f236e4df
    • pdr@google.com's avatar
      Change hasAlpha to isKnownToBeOpaque and correct the return value for SVG images. · ebc67c61
      pdr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=106966
      
      Reviewed by Stephen White.
      
      Source/WebCore:
      
      Previously, Image::currentFrameHasAlpha's default implementation returned false so SVG
      images always returned false for currentFrameHasAlpha. Additionally, currentFrameHasAlpha
      was treated as returning whether the frame had alpha when it would actually conservatively
      return true.
      
      This patch renames hasAlpha and currentFrameHasAlpha to isKnownToBeOpaque and
      currentFrameIsKnownToBeOpaque, respectively. This rename better describes the actual
      functionality. This patch also makes Image::isKnownToBeOpaque a pure virtual function and
      correctly implements it for SVG images.
      
      All users of isKnownToBeOpaque access SVG images using CachedImage::imageForRenderer which
      currently returns a cached bitmap image. Therefore, this patch will not affect existing
      functionality. A regression test has been added that will catch if this changes in the
      future (e.g., WK106159 which proposes not returning cached bitmaps). The now unnecessary
      isBitmapImage() calls have been removed in this patch.
      
      image-box-shadow.html has been modified to test SVG images.
      
      * css/CSSCrossfadeValue.cpp:
      (WebCore::subimageKnownToBeOpaque):
      (WebCore::CSSCrossfadeValue::knownToBeOpaque):
      
          Mostly straightforward rename but note the logic has been slightly altered: AND -> OR.
      
      * css/CSSCrossfadeValue.h:
      (CSSCrossfadeValue):
      * css/CSSGradientValue.cpp:
      (WebCore::CSSGradientValue::knownToBeOpaque):
      * css/CSSGradientValue.h:
      (CSSGradientValue):
      * css/CSSImageGeneratorValue.cpp:
      (WebCore::CSSImageGeneratorValue::knownToBeOpaque):
      * css/CSSImageGeneratorValue.h:
      (CSSImageGeneratorValue):
      * css/CSSImageValue.cpp:
      (WebCore::CSSImageValue::knownToBeOpaque):
      * css/CSSImageValue.h:
      (CSSImageValue):
      * loader/cache/CachedImage.cpp:
      (WebCore::CachedImage::currentFrameKnownToBeOpaque):
      * loader/cache/CachedImage.h:
      (CachedImage):
      * platform/graphics/BitmapImage.cpp:
      (WebCore::BitmapImage::currentFrameKnownToBeOpaque):
      * platform/graphics/BitmapImage.h:
      (BitmapImage):
      * platform/graphics/GeneratedImage.h:
      (GeneratedImage):
      * platform/graphics/Image.h:
      
          Note: now a pure virtual function!
      
      (Image):
      * platform/graphics/blackberry/LayerTiler.cpp:
      (WebCore::LayerTiler::updateTextureContentsIfNeeded):
      
          Removed unnecessary isBitmapImage() checks.
      
      * platform/graphics/cg/GraphicsContext3DCG.cpp:
      (WebCore::GraphicsContext3D::ImageExtractor::extractImage):
      
          Removed unnecessary isBitmapImage() checks.
      
      * platform/graphics/cg/PDFDocumentImage.h:
      (PDFDocumentImage):
      * platform/graphics/chromium/GraphicsLayerChromium.cpp:
      
          Removed unnecessary isBitmapImage() checks.
      
      (WebCore::GraphicsLayerChromium::setContentsToImage):
      * platform/graphics/qt/StillImageQt.cpp:
      (WebCore::StillImage::currentFrameKnownToBeOpaque):
      * platform/graphics/qt/StillImageQt.h:
      (StillImage):
      * platform/graphics/skia/BitmapImageSingleFrameSkia.cpp:
      (WebCore::BitmapImageSingleFrameSkia::currentFrameKnownToBeOpaque):
      * platform/graphics/skia/BitmapImageSingleFrameSkia.h:
      (BitmapImageSingleFrameSkia):
      * platform/graphics/texmap/TextureMapperBackingStore.cpp:
      (WebCore::TextureMapperTile::updateContents):
      (WebCore::TextureMapperTiledBackingStore::updateContents):
      * platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
      (WebCore::CoordinatedImageBacking::update):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::backgroundIsObscured):
      
          Removed unnecessary isBitmapImage() checks and slightly reworked the logic.
      
      * rendering/style/FillLayer.cpp:
      (WebCore::FillLayer::hasOpaqueImage):
      * rendering/style/StyleCachedImage.cpp:
      (WebCore::StyleCachedImage::knownToBeOpaque):
      * rendering/style/StyleCachedImage.h:
      (StyleCachedImage):
      * rendering/style/StyleCachedImageSet.cpp:
      (WebCore::StyleCachedImageSet::knownToBeOpaque):
      * rendering/style/StyleCachedImageSet.h:
      (StyleCachedImageSet):
      * rendering/style/StyleGeneratedImage.cpp:
      (WebCore::StyleGeneratedImage::knownToBeOpaque):
      * rendering/style/StyleGeneratedImage.h:
      (StyleGeneratedImage):
      * rendering/style/StyleImage.h:
      (StyleImage):
      * rendering/style/StylePendingImage.h:
      (WebCore::StylePendingImage::knownToBeOpaque):
      * svg/graphics/SVGImage.h:
      (SVGImage):
      
      Source/WebKit/chromium:
      
      * tests/DragImageTest.cpp:
      (WebCore::TestImage::currentFrameKnownToBeOpaque):
      (TestImage):
      * tests/ImageLayerChromiumTest.cpp:
      (WebCore::TestImage::currentFrameKnownToBeOpaque):
      * tests/PlatformContextSkiaTest.cpp:
      (WebCore::TEST):
      
      Source/WebKit/win:
      
      * WebKit.vcproj/WebKitExports.def.in:
      
      LayoutTests:
      
      An SVG image has been added to this test to check for regressions.
      
      * fast/box-shadow/image-box-shadow-expected.html:
      * fast/box-shadow/image-box-shadow.html:
      
          Add an SVG image and correct a small mistake in the test that used values of 256
          instead of 255.
      
      * fast/box-shadow/resources/green.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ebc67c61
    • philn@webkit.org's avatar
      Unreviewed, GTK TestExpectations update. · ba1118af
      philn@webkit.org authored
      * platform/gtk/TestExpectations: Flag some new media tests
      crashing until a fix is figured out.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba1118af
    • beidson@apple.com's avatar
      Clean up WebArchive loading with the NetworkProcess · 59cc75f4
      beidson@apple.com authored
      <rdar://problem/12695840> and https://bugs.webkit.org/show_bug.cgi?id=108673
      
      Reviewed by Alexey Proskuryakov.
      
      Source/WebCore:
      
      No new tests (No change in WebCore behavior).
      
      Remove a now unneeded function and add a needed export.
      
      * WebCore.exp.in:
      * loader/ResourceLoadScheduler.cpp:
      * loader/ResourceLoadScheduler.h:
      
      Source/WebKit2:
      
      * NetworkProcess/HostRecord.cpp:
      (WebKit::HostRecord::servePendingRequestsForQueue):  Add new logging.
      (WebKit::HostRecord::servePendingRequests): Tweak existing logging.
      
      * NetworkProcess/NetworkResourceLoadScheduler.cpp:
      (WebKit::NetworkResourceLoadScheduler::servePendingRequests): Tweak existing logging.
      
      * WebProcess/Network/WebResourceLoadScheduler.cpp:
      (WebKit::WebResourceLoadScheduler::scheduleLoad): Handle archive resource scheduling better,
        and add new logging to better explore archive loading behavior in the future.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59cc75f4
    • alokp@chromium.org's avatar
      Print GraphicsLayer::m_contentsOpaque if non-default (true) · 85b0c5e6
      alokp@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108354
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      No new tests. This change facilitates testing of GraphicsLayer opaqueness.
      
      * platform/graphics/GraphicsLayer.cpp:
      (WebCore::GraphicsLayer::dumpProperties):
      
      LayoutTests:
      
      * compositing/absolute-inside-out-of-view-fixed-expected.txt:
      * compositing/backing/no-backing-for-clip-expected.txt:
      * compositing/backing/no-backing-for-clip-overlap-expected.txt:
      * compositing/backing/no-backing-for-perspective-expected.txt:
      * compositing/bounds-in-flipped-writing-mode-expected.txt:
      * compositing/clip-child-by-non-stacking-ancestor-expected.txt:
      * compositing/columns/composited-in-paginated-expected.txt:
      * compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
      * compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
      * compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
      * compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
      * compositing/geometry/ancestor-overflow-change-expected.txt:
      * compositing/geometry/bounds-clipped-composited-child-expected.txt:
      * compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
      * compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt:
      * compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
      * compositing/geometry/bounds-ignores-hidden-expected.txt:
      * compositing/geometry/clip-expected.txt:
      * compositing/geometry/clip-inside-expected.txt:
      * compositing/geometry/composited-in-columns-expected.txt:
      * compositing/geometry/fixed-position-composited-switch-expected.txt:
      * compositing/geometry/flipped-writing-mode-expected.txt:
      * compositing/geometry/foreground-layer-expected.txt:
      * compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
      * compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
      * compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
      * compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
      * compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
      * compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
      * compositing/geometry/limit-layer-bounds-positioned-expected.txt:
      * compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
      * compositing/geometry/limit-layer-bounds-transformed-expected.txt:
      * compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
      * compositing/geometry/preserve-3d-switching-expected.txt:
      * compositing/iframes/become-composited-nested-iframes-expected.txt:
      * compositing/iframes/become-overlapped-iframe-expected.txt:
      * compositing/iframes/composited-parent-iframe-expected.txt:
      * compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
      * compositing/iframes/connect-compositing-iframe-expected.txt:
      * compositing/iframes/connect-compositing-iframe2-expected.txt:
      * compositing/iframes/connect-compositing-iframe3-expected.txt:
      * compositing/iframes/enter-compositing-iframe-expected.txt:
      * compositing/iframes/iframe-resize-expected.txt:
      * compositing/iframes/iframe-size-from-zero-expected.txt:
      * compositing/iframes/invisible-nested-iframe-hide-expected.txt:
      * compositing/iframes/invisible-nested-iframe-show-expected.txt:
      * compositing/iframes/overlapped-iframe-expected.txt:
      * compositing/iframes/overlapped-iframe-iframe-expected.txt:
      * compositing/iframes/overlapped-nested-iframes-expected.txt:
      * compositing/iframes/page-cache-layer-tree-expected.txt:
      * compositing/iframes/scrolling-iframe-expected.txt:
      * compositing/images/clip-on-directly-composited-image-expected.txt:
      * compositing/layer-creation/animation-overlap-with-children-expected.txt:
      * compositing/layer-creation/fixed-position-and-transform-expected.txt:
      * compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
      * compositing/layer-creation/fixed-position-out-of-view-expected.txt:
      * compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
      * compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
      * compositing/layer-creation/fixed-position-under-transform-expected.txt:
      * compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt:
      * compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
      * compositing/layer-creation/overflow-scroll-overlap-expected.txt:
      * compositing/layer-creation/overlap-animation-clipping-expected.txt:
      * compositing/layer-creation/overlap-animation-container-expected.txt:
      * compositing/layer-creation/overlap-animation-expected.txt:
      * compositing/layer-creation/overlap-child-layer-expected.txt:
      * compositing/layer-creation/overlap-clipping-expected.txt:
      * compositing/layer-creation/overlap-transformed-3d-expected.txt:
      * compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
      * compositing/layer-creation/overlap-transformed-layer-expected.txt:
      * compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
      * compositing/layer-creation/overlap-transforms-expected.txt:
      * compositing/layer-creation/rotate3d-overlap-expected.txt:
      * compositing/layer-creation/scroll-partial-update-expected.txt:
      * compositing/layer-creation/spanOverlapsCanvas-expected.txt:
      * compositing/layer-creation/stacking-context-overlap-expected.txt:
      * compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
      * compositing/layer-creation/translatez-overlap-expected.txt:
      * compositing/masks/mask-layer-size-expected.txt:
      * compositing/overflow-trumps-transform-style-expected.txt:
      * compositing/overflow/clip-descendents-expected.txt:
      * compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
      * compositing/overflow/content-gains-scrollbars-expected.txt:
      * compositing/overflow/content-loses-scrollbars-expected.txt:
      * compositing/overflow/overflow-auto-with-touch-expected.txt:
      * compositing/overflow/overflow-auto-with-touch-toggle-expected.txt:
      * compositing/overflow/overflow-overlay-with-touch-expected.txt:
      * compositing/overflow/overflow-scrollbar-layers-expected.txt:
      * compositing/overflow/resize-painting-expected.txt:
      * compositing/overflow/scrolling-content-clip-to-viewport-expected.txt:
      * compositing/overflow/scrolling-without-painting-expected.txt:
      * compositing/overflow/textarea-scroll-touch-expected.txt:
      * compositing/overflow/updating-scrolling-content-expected.txt:
      * compositing/plugins/no-backing-store-expected.txt:
      * compositing/plugins/small-to-large-composited-plugin-expected.txt:
      * compositing/repaint/invalidations-on-composited-layers-expected.txt:
      * compositing/repaint/resize-repaint-expected.txt:
      * compositing/rtl/rtl-absolute-expected.txt:
      * compositing/rtl/rtl-absolute-overflow-expected.txt:
      * compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
      * compositing/rtl/rtl-fixed-expected.txt:
      * compositing/rtl/rtl-fixed-overflow-expected.txt:
      * compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
      * compositing/rtl/rtl-iframe-absolute-expected.txt:
      * compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
      * compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
      * compositing/rtl/rtl-iframe-fixed-expected.txt:
      * compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
      * compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
      * compositing/rtl/rtl-iframe-relative-expected.txt:
      * compositing/rtl/rtl-relative-expected.txt:
      * compositing/tiled-layers-hidpi-expected.txt:
      * compositing/tiling/backface-preserve-3d-tiled-expected.txt:
      * compositing/tiling/crash-reparent-tiled-layer-expected.txt:
      * compositing/tiling/huge-layer-add-remove-child-expected.txt:
      * compositing/tiling/huge-layer-expected.txt:
      * compositing/tiling/huge-layer-img-expected.txt:
      * compositing/tiling/huge-layer-resize-expected.txt:
      * compositing/tiling/huge-layer-with-layer-children-expected.txt:
      * compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
      * compositing/tiling/rotated-tiled-clamped-expected.txt:
      * compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
      * compositing/tiling/tile-cache-zoomed-expected.txt:
      * compositing/tiling/tiled-layer-resize-expected.txt:
      * compositing/visibility/layer-visible-content-expected.txt:
      * compositing/visibility/visibility-image-layers-dynamic-expected.txt:
      * compositing/visible-rect/2d-transformed-expected.txt:
      * compositing/visible-rect/3d-transform-style-expected.txt:
      * compositing/visible-rect/3d-transformed-expected.txt:
      * compositing/visible-rect/animated-expected.txt:
      * compositing/visible-rect/animated-from-none-expected.txt:
      * compositing/visible-rect/clipped-by-viewport-expected.txt:
      * compositing/visible-rect/clipped-visible-rect-expected.txt:
      * compositing/visible-rect/iframe-and-layers-expected.txt:
      * compositing/visible-rect/iframe-no-layers-expected.txt:
      * compositing/visible-rect/nested-transform-expected.txt:
      * compositing/visible-rect/scrolled-expected.txt:
      * css3/compositing/should-have-compositing-layer-expected.txt:
      * css3/filters/filtered-compositing-descendant-expected.txt:
      * platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt:
      * platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
      * platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
      * platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
      * platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
      * platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
      * platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
      * platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
      * platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
      * platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
      * platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
      * platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
      * platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
      * platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
      * platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
      * platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
      * platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
      * platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
      * platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
      * platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
      * platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
      * platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
      * platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
      * platform/chromium-mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
      * platform/chromium-mac/css3/filters/composited-during-animation-layertree-expected.txt:
      * platform/chromium-mac/css3/filters/composited-during-transition-layertree-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
      * platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
      * platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
      * platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
      * platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
      * platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
      * platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
      * platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
      * platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt:
      * platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt:
      * platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
      * platform/chromium-win/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
      * platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
      * platform/chromium-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
      * platform/chromium-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
      * platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
      * platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
      * platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
      * platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
      * platform/chromium-win/compositing/layer-creation/scroll-partial-update-expected.txt:
      * platform/chromium-win/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
      * platform/chromium-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
      * platform/chromium-win/compositing/tiling/huge-layer-expected.txt:
      * platform/chromium-win/compositing/tiling/huge-layer-resize-expected.txt:
      * platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-expected.txt:
      * platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
      * platform/chromium-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
      * platform/chromium-win/css3/filters/composited-during-animation-layertree-expected.txt:
      * platform/chromium-win/css3/filters/composited-during-transition-layertree-expected.txt:
      * platform/chromium/TestExpectations:
      * platform/chromium/compositing/backing/no-backing-for-clip-expected.txt:
      * platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt:
      * platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt:
      * platform/chromium/compositing/canvas/accelerated-canvas-compositing-expected.txt:
      * platform/chromium/compositing/columns/composited-in-paginated-expected.txt:
      * platform/chromium/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
      * platform/chromium/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
      * platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt:
      * platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer-expected.txt:
      * platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer-expected.txt:
      * platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing-expected.txt:
      * platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer-expected.txt:
      * platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing-expected.txt:
      * platform/chromium/compositing/geometry/ancestor-overflow-change-expected.txt:
      * platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
      * platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
      * platform/chromium/compositing/geometry/clip-expected.txt:
      * platform/chromium/compositing/geometry/clip-inside-expected.txt:
      * platform/chromium/compositing/geometry/composited-in-columns-expected.txt:
      * platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt:
      * platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt:
      * platform/chromium/compositing/geometry/foreground-layer-expected.txt:
      * platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
      * platform/chromium/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
      * platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
      * platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt:
      * platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
      * platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt:
      * platform/chromium/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
      * platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt:
      * platform/chromium/compositing/iframes/become-composited-nested-iframes-expected.txt:
      * platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
      * platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
      * platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
      * platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
      * platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
      * platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
      * platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
      * platform/chromium/compositing/iframes/iframe-resize-expected.txt:
      * platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
      * platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt:
      * platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
      * platform/chromium/compositing/iframes/overlapped-iframe-iframe-expected.txt:
      * platform/chromium/compositing/iframes/overlapped-nested-iframes-expected.txt:
      * platform/chromium/compositing/iframes/resizer-expected.txt:
      * platform/chromium/compositing/iframes/scrolling-iframe-expected.txt:
      * platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt:
      * platform/chromium/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
      * platform/chromium/compositing/layer-creation/fixed-position-out-of-view-expected.txt:
      * platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
      * platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
      * platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt:
      * platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
      * platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt:
      * platform/chromium/compositing/layer-creation/overlap-animation-clipping-expected.txt:
      * platform/chromium/compositing/layer-creation/overlap-animation-container-expected.txt:
      * platform/chromium/compositing/layer-creation/overlap-animation-expected.txt:
      * platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt:
      * platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt:
      * platform/chromium/compositing/layer-creation/overlap-transformed-3d-expected.txt:
      * platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
      * platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt:
      * platform/chromium/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
      * platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt:
      * platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt:
      * platform/chromium/compositing/layer-creation/spanOverlapsCanvas-expected.txt:
      * platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt:
      * platform/chromium/compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
      * platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt:
      * platform/chromium/compositing/overflow-trumps-transform-style-expected.txt:
      * platform/chromium/compositing/overflow/clip-descendents-expected.txt:
      * platform/chromium/compositing/overflow/content-gains-scrollbars-expected.txt:
      * platform/chromium/compositing/overflow/content-loses-scrollbars-expected.txt:
      * platform/chromium/compositing/overflow/overflow-scrollbar-layers-expected.txt:
      * platform/chromium/compositing/overflow/resize-painting-expected.txt:
      * platform/chromium/compositing/rtl/rtl-absolute-expected.txt:
      * platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt:
      * platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
      * platform/chromium/compositing/rtl/rtl-fixed-expected.txt:
      * platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt:
      * platform/chromium/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
      * platform/chromium/compositing/rtl/rtl-iframe-absolute-expected.txt:
      * platform/chromium/compositing/rtl/rtl-iframe-fixed-expected.txt:
      * platform/chromium/compositing/rtl/rtl-iframe-relative-expected.txt:
      * platform/chromium/compositing/rtl/rtl-relative-expected.txt:
      * platform/chromium/compositing/tiling/huge-layer-img-expected.txt:
      * platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt:
      * platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/content-gains-scrollbars-expected.txt:
      * platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt:
      * platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-scrollbar-layers-expected.txt:
      * platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/resize-painting-expected.txt:
      * platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
      * platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt:
      * platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
      * platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
      * platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/content-gains-scrollbars-expected.txt:
      * platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/overflow-scrollbar-layers-expected.txt:
      * platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/resize-painting-expected.txt:
      * platform/efl/compositing/geometry/foreground-layer-expected.txt:
      * platform/efl/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
      * platform/efl/compositing/repaint/invalidations-on-composited-layers-expected.txt:
      * platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
      * platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
      * platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt:
      * platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:
      * platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
      * platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
      * platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
      * platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
      * platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
      * platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:
      * platform/mac/TestExpectations:
      * platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt:
      * platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt:
      * platform/mac/compositing/iframes/resizer-expected.txt:
      * platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
      * platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
      * platform/mac/compositing/tiling/backface-preserve-3d-tiled-expected.txt:
      * platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
      * platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
      * platform/mac/compositing/tiling/huge-layer-expected.txt:
      * platform/mac/compositing/tiling/huge-layer-img-expected.txt:
      * platform/mac/compositing/tiling/huge-layer-resize-expected.txt:
      * platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
      * platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
      * platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
      * platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
      * platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
      * platform/mac/compositing/tiling/tiled-layer-resize-expected.txt:
      * platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
      * platform/mac/css3/filters/composited-during-animation-layertree-expected.txt:
      * platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
      * platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/leave-compositing-iframe-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
      * platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt:
      * platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
      * platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
      * platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
      * platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
      * platform/qt-5.0-wk2/compositing/overflow/content-gains-scrollbars-expected.txt:
      * platform/qt-5.0-wk2/compositing/overflow/overflow-scrollbar-layers-expected.txt:
      * platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
      * platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
      * platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
      * platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
      * platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
      * platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
      * platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
      * platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
      * platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
      * platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
      * platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
      * platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
      * platform/qt-5.0-wk2/css3/filters/composited-during-animation-layertree-expected.txt:
      * platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
      * platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
      * platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
      * platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
      * platform/qt/compositing/iframes/invisible-nested-iframe-show-expected.txt:
      * platform/qt/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
      * platform/qt/compositing/layer-creation/overlap-animation-container-expected.txt:
      * platform/qt/compositing/overflow/clip-descendents-expected.txt:
      * platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
      * platform/qt/css3/compositing/should-have-compositing-layer-expected.txt:
      * platform/qt/css3/filters/composited-during-transition-layertree-expected.txt:
      * platform/win/compositing/iframes/composited-iframe-expected.txt:
      * platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
      * platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
      * platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
      * platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt:
      * platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85b0c5e6
    • tonyg@chromium.org's avatar
      Continue making XSSAuditor thread safe: Remove dependency on parser's Document URL · 818ef9fe
      tonyg@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108655
      
      Reviewed by Adam Barth.
      
      No new tests because no new functionality.
      
      * html/parser/XSSAuditor.cpp:
      (WebCore::XSSAuditor::XSSAuditor):
      (WebCore::XSSAuditor::init):
      (WebCore::XSSAuditor::isLikelySafeResource):
      * html/parser/XSSAuditor.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      818ef9fe
    • caio.oliveira@openbossa.org's avatar
      [Qt] [WK2] Fix build after r141619 · b1f974f5
      caio.oliveira@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108680
      
      Reviewed by Benjamin Poulain.
      
      Take a reference instead of a pointer for decoding functions.
      
      * Platform/unix/SharedMemoryUnix.cpp:
      (WebKit::SharedMemory::Handle::decode):
      * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
      (CoreIPC::::decode):
      (CoreIPC::decodeTimingFunction):
      * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
      * Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
      (WebKit::WebCoordinatedSurface::Handle::decode):
      * Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
      (Handle):
      * Shared/qt/ArgumentCodersQt.cpp:
      (CoreIPC::::decode):
      * Shared/qt/ArgumentCodersQt.h:
      (CoreIPC):
      * Shared/qt/LayerTreeContextQt.cpp:
      (WebKit::LayerTreeContext::decode):
      * Shared/qt/PlatformCertificateInfo.h:
      (WebKit::PlatformCertificateInfo::decode):
      * Shared/qt/QtNetworkReplyData.cpp:
      (WebKit::QtNetworkReplyData::decode):
      * Shared/qt/QtNetworkReplyData.h:
      (QtNetworkReplyData):
      * Shared/qt/QtNetworkRequestData.cpp:
      (WebKit::QtNetworkRequestData::decode):
      * Shared/qt/QtNetworkRequestData.h:
      (QtNetworkRequestData):
      * Shared/qt/WebCoreArgumentCodersQt.cpp:
      (CoreIPC::::decodePlatformData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1f974f5
    • roger_fong@apple.com's avatar
      Unreviewed. Re-try enabling Win-EWS tests for the third time. · b5064cea
      roger_fong@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107968
      
      * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
      (WinEWS):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5064cea
    • jer.noble@apple.com's avatar
      REGRESSION (r141281): Navigating to this HTTP Live Streaming... · 8559ffd6
      jer.noble@apple.com authored
      REGRESSION (r141281): Navigating to this HTTP Live Streaming (application/vnd.apple.mpegurl) URL downloads a file instead of playing it in the browser
      https://bugs.webkit.org/show_bug.cgi?id=108674
      <rdar://problem/13133595>
      
      Reviewed by Eric Carlson.
      
      When passed a HashSet of available MIME types to fill out, QTKit was overwriting the contents, which were
      AVFoundation's supported types. Instead, it should be appending to the list of supported types.
      
      * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
      (WebCore::concatenateHashSets): Added static utility function.
      (WebCore::MediaPlayerPrivateQTKit::getSupportedTypes): Concatenate instead of overwriting the passed in MIME types.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8559ffd6
    • roger_fong@apple.com's avatar
      094c0108
    • roger_fong@apple.com's avatar
      Fix test scripts for EWS bots to get them running once and for all. · 7f0efde6
      roger_fong@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=108422
      
      Reviewed by Timothy Horton.
      
      Disabling --quiet option on Windows for now because that fails when we try to use /dev/null.
      runtests.py was not passing in a configuration to run-webkit-tests which causes DRT to build in release by default.
      However, we build in Debug only on the EWS Windows bots, which caused the build to fail.
      
      * Scripts/webkitpy/tool/steps/runtests.py:
      (RunTests.options):
      (RunTests.run):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f0efde6
    • jberlin@webkit.org's avatar
      WTR needs an implementation of setAutomaticLinkDetectionEnabled · d6f4bd89
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=87162
      
      Skip a test on wk2 added in r14618 that uses setAutomaticLinkDetectionEnabled.
      
      * platform/wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6f4bd89
    • zhajiang@rim.com's avatar
      [BlackBerry] Zooming in during page load of non-scalable webpage results in fixed magnification · 703cab54
      zhajiang@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=108252
      
      Patch by Jacky Jiang  <zhajiang@rim.com>.
      Reviewed by Yong Li.
      Internally reviewed by Konrad Piascik.
      
      PR: 284828
      We got float layoutSize(342.284122, 521.448467) and
      m_maximumScale(2.243750) after computing viewport meta based on the
      device pixel ratio and laid out the contents at IntSize(342, 521).
      Therefore, zoomToFitScale(2.245681) would be a bit larger than
      m_maximumScale based on that contents size and resulted in
      maximumScale()!=minimumScale(), which made the non-scalable page
      scalable.
      Return zoomToFitScale for maximumScale() in such kind of case.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::maximumScale):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      703cab54
    • bdakin@apple.com's avatar
      Another speculative windows build fix. · 0fdc947a
      bdakin@apple.com authored
      * platform/ScrollAnimator.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fdc947a
    • krit@webkit.org's avatar
      [canvas] Add more constructors to Path · 7297c623
      krit@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108587
      
      Patch by Dirk Schulze <krit@webkit.org> on 2013-01-31
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      Add more constructors to Path object to make it possible
      to copy Path objects and parse SVG strings into a Path
      object that can be used on the canvas context afterwards.
      
      Test: fast/canvas/canvas-path-constructors.html
      
      * html/canvas/DOMPath.h: New constructors for Path.
      (WebCore::DOMPath::create):
      (WebCore::DOMPath::DOMPath):
      * html/canvas/DOMPath.idl: Ditto.
      
      LayoutTests:
      
      Add tests for new constructors of Path objects.
      Since the feature is behind a flag, the test is skipped on
      all platforms for now.
      
      * fast/canvas/canvas-path-constructors-expected.txt: Added.
      * fast/canvas/canvas-path-constructors.html: Added.
      * fast/canvas/script-tests/canvas-path-constructors.js: Added.
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/win/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7297c623
    • commit-queue@webkit.org's avatar
      [BlackBerry] InputHandler status is not restored when page history goes back · 0e9f093d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108448
      
      Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2013-02-01
      Reviewed by Yong Li.
      
      PR288406 Internally reviewed by Mike Fenton
      
      When webpage goes back, it restores the old frame's selection and focused node,
      but we don't save the InputHandler's status, it becomes non-input mode when page
      goes back. When it restores the focus, since the new focus node is same as the old
      document focused node, webcore will not notify client to update the input handler.
      
      This patch updates the input handler's status by notifying it focus node changed.
      
      * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
      (WebCore::FrameLoaderClientBlackBerry::restoreViewState):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::restoreViewState):
      (WebKit):
      * WebKitSupport/InputHandler.h:
      (InputHandler):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e9f093d
    • zandobersek@gmail.com's avatar
      [GTK] Add WTFURL source files to the build · 050d2e2f
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=108215
      
      Reviewed by Benjamin Poulain.
      
      .: 
      
      * Source/autotools/symbols.filter: Force the export of the KURL::string() symbol.
      This is required when using the WTFURL backend but otherwise doesn't affect the build.
      
      Source/WebCore: 
      
      * platform/KURLWTFURL.cpp:
      (WebCore): Only use the stub implementation of the fileSystemPath method for the
      Apple ports, other ports should for now still rely on their platform-specific implementations.
      
      Source/WTF: 
      
      The WTFURL implementation sources are all still guarded by the USE(WTFURL) guard,
      meaning that the GTK port still uses the default KURL backend. To use the WTFURL
      backend instead, one would have to define WTF_USE_WTFURL in Platform.h.
      
      * GNUmakefile.am: List the directories from which source headers will be included.
      Plenty of WTFURL code currently just includes the required header by name rather
      than specifying the header path as relative to Source/WTF. In the future all the inclusions
      should probaby be changed to include the header through the path relative to Source/WTF.
      * GNUmakefile.list.am: Add build targets for the WTFURL source files.
      * wtf/url/api/ParsedURL.cpp: Specify the complete path to the required headers and
      reorder the inclusions.
      * wtf/url/src/URLCanon.h: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      050d2e2f
    • mkwst@chromium.org's avatar
      Remove call to SecurityOrigin::canAccessDatabase from IDB constructor. · b404544f
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108477
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      This change removes the 'SecurityOrigin::canAccessDatabase' check from
      the constructor for the 'indexedDB' property on both DOMWindow and
      WorkerContext. After the patch for http://wkbug.com/94171 this check
      is redundant, as all the entry points to IDB are now gated on access
      being granted.
      
      As a side-effect, dropping the check in WorkerContextIndexedDatabase
      allows us to stop holding a pointer to the ScriptExecutionContext we're
      extending, which can only be a good thing.
      
      The tests in storage/indexeddb should continue to pass.
      
      * Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
      (WebCore::DOMWindowIndexedDatabase::indexedDB):
          Drop the SecurityOrigin::canAccessDatabase check.
      * Modules/indexeddb/WorkerContextIndexedDatabase.cpp:
      (WebCore::WorkerContextIndexedDatabase::WorkerContextIndexedDatabase):
      (WebCore::WorkerContextIndexedDatabase::from):
          Drop the ScriptExecutionContext parameter from the class's
          constructor and callsites.
      (WebCore::WorkerContextIndexedDatabase::indexedDB):
          Drop the SecurityOrigin::canAccessDatabase check.
      * Modules/indexeddb/WorkerContextIndexedDatabase.h:
      (WorkerContextIndexedDatabase):
          Drop the stored pointer to ScriptExecutionContext, as we no longer
          need it in ::indexedDB.
      
      LayoutTests:
      
      * http/tests/security/no-indexeddb-from-sandbox-expected.txt:
      * http/tests/security/no-indexeddb-from-sandbox.html:
          This test expected the 'webkitIndexedDB' property to be missing
          entirely inside a sandbox. The expectation has been updated to
          expect 'webkitIndexedDB.open()' to throw a SECURITY_ERR.
      * platform/efl/TestExpectations:
      * platform/mac-snowleopard/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
          This test was accidentally passing on a variety of platforms that
          don't yet implement IndexedDB. Now that failure is distinguishable
          we should skip it on a variety of platforms.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b404544f
    • bdakin@apple.com's avatar
      Speculative Windows build fix. · e388519e
      bdakin@apple.com authored
      * platform/ScrollAnimator.h:
      (WebCore):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e388519e
    • andersca@apple.com's avatar
      Message decoding functions should take a MessageDecoder reference · ea151935
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=108669
      
      Reviewed by Andreas Kling.
      
      Message encoding functions already take a reference instead of a pointer, so
      make the decoding functions take a reference as well.
      
      * Platform/CoreIPC/ArgumentCoder.h:
      (CoreIPC::ArgumentCoder::decode):
      * Platform/CoreIPC/ArgumentCoders.cpp:
      (CoreIPC::::decode):
      (CoreIPC::decodeStringText):
      * Platform/CoreIPC/ArgumentCoders.h:
      (CoreIPC::SimpleArgumentCoder::decode):
      * Platform/CoreIPC/ArgumentDecoder.h:
      (CoreIPC::ArgumentDecoder::decode):
      * Platform/CoreIPC/Arguments.h:
      (CoreIPC::Arguments0::decode):
      (CoreIPC::Arguments1::decode):
      (CoreIPC::Arguments2::decode):
      (CoreIPC::Arguments3::decode):
      (CoreIPC::Arguments4::decode):
      (CoreIPC::Arguments5::decode):
      (CoreIPC::Arguments6::decode):
      (CoreIPC::Arguments7::decode):
      (CoreIPC::Arguments8::decode):
      (CoreIPC::Arguments10::decode):
      * Platform/CoreIPC/Attachment.cpp:
      (CoreIPC::Attachment::decode):
      * Platform/CoreIPC/Attachment.h:
      (Attachment):
      * Platform/CoreIPC/DataReference.cpp:
      (CoreIPC::DataReference::decode):
      * Platform/CoreIPC/DataReference.h:
      (DataReference):
      * Platform/CoreIPC/StringReference.cpp:
      (CoreIPC::StringReference::decode):
      * Platform/CoreIPC/StringReference.h:
      (StringReference):
      * Platform/CoreIPC/mac/MachPort.h:
      (CoreIPC::MachPort::decode):
      * Platform/SharedMemory.h:
      (Handle):
      * Platform/mac/SharedMemoryMac.cpp:
      (WebKit::SharedMemory::Handle::decode):
      * PluginProcess/PluginCreationParameters.cpp:
      (WebKit::PluginCreationParameters::decode):
      * PluginProcess/PluginCreationParameters.h:
      (PluginCreationParameters):
      * Shared/DictionaryPopupInfo.cpp:
      (WebKit::DictionaryPopupInfo::decode):
      * Shared/DictionaryPopupInfo.h:
      (DictionaryPopupInfo):
      * Shared/EditorState.cpp:
      (WebKit::EditorState::decode):
      * Shared/EditorState.h:
      (EditorState):
      * Shared/FontInfo.cpp:
      (WebKit::FontInfo::decode):
      * Shared/FontInfo.h:
      (FontInfo):
      * Shared/LayerTreeContext.h:
      (LayerTreeContext):
      * Shared/Network/NetworkProcessCreationParameters.cpp:
      (WebKit::NetworkProcessCreationParameters::decode):
      * Shared/Network/NetworkProcessCreationParameters.h:
      (NetworkProcessCreationParameters):
      * Shared/Network/NetworkResourceLoadParameters.cpp:
      (WebKit::NetworkResourceLoadParameters::decode):
      * Shared/Network/NetworkResourceLoadParameters.h:
      (NetworkResourceLoadParameters):
      * Shared/OriginAndDatabases.cpp:
      (WebKit::OriginAndDatabases::decode):
      * Shared/OriginAndDatabases.h:
      (OriginAndDatabases):
      * Shared/PlatformPopupMenuData.cpp:
      (WebKit::PlatformPopupMenuData::decode):
      * Shared/PlatformPopupMenuData.h:
      (PlatformPopupMenuData):
      * Shared/Plugins/NPIdentifierData.cpp:
      (WebKit::NPIdentifierData::decode):
      * Shared/Plugins/NPIdentifierData.h:
      (NPIdentifierData):
      * Shared/Plugins/NPVariantData.cpp:
      (WebKit::NPVariantData::decode):
      * Shared/Plugins/NPVariantData.h:
      (NPVariantData):
      * Shared/Plugins/PluginProcessCreationParameters.cpp:
      (WebKit::PluginProcessCreationParameters::decode):
      * Shared/Plugins/PluginProcessCreationParameters.h:
      (PluginProcessCreationParameters):
      * Shared/PrintInfo.cpp:
      (WebKit::PrintInfo::decode):
      * Shared/PrintInfo.h:
      (PrintInfo):
      * Shared/SandboxExtension.h:
      (Handle):
      (HandleArray):
      (WebKit::SandboxExtension::Handle::decode):
      (WebKit::SandboxExtension::HandleArray::decode):
      * Shared/SecurityOriginData.cpp:
      (WebKit::SecurityOriginData::decode):
      * Shared/SecurityOriginData.h:
      (SecurityOriginData):
      * Shared/SessionState.cpp:
      (WebKit::SessionState::decode):
      * Shared/SessionState.h:
      (SessionState):
      * Shared/ShareableBitmap.cpp:
      (WebKit::ShareableBitmap::Handle::decode):
      * Shared/ShareableBitmap.h:
      (Handle):
      * Shared/ShareableResource.cpp:
      (WebKit::ShareableResource::Handle::decode):
      * Shared/ShareableResource.h:
      (Handle):
      * Shared/SharedWorkerProcessCreationParameters.cpp:
      (WebKit::SharedWorkerProcessCreationParameters::decode):
      * Shared/SharedWorkerProcessCreationParameters.h:
      (SharedWorkerProcessCreationParameters):
      * Shared/StatisticsData.cpp:
      (WebKit::StatisticsData::decode):
      * Shared/StatisticsData.h:
      (StatisticsData):
      * Shared/StringPairVector.h:
      (WebKit::StringPairVector::decode):
      * Shared/UpdateInfo.cpp:
      (WebKit::UpdateInfo::decode):
      * Shared/UpdateInfo.h:
      (UpdateInfo):
      * Shared/UserMessageCoders.h:
      (WebKit::UserMessageDecoder::baseDecode):
      * Shared/WebContextMenuItemData.cpp:
      (WebKit::WebContextMenuItemData::decode):
      * Shared/WebContextMenuItemData.h:
      (WebContextMenuItemData):
      * Shared/WebCoreArgumentCoders.cpp:
      (CoreIPC::::decode):
      (CoreIPC::decodeImage):
      * Shared/WebCoreArgumentCoders.h:
      * Shared/WebEvent.cpp:
      (WebKit::WebEvent::decode):
      * Shared/WebEvent.h:
      (WebEvent):
      (WebMouseEvent):
      (WebWheelEvent):
      (WebKeyboardEvent):
      (WebGestureEvent):
      (WebPlatformTouchPoint):
      (WebTouchEvent):
      * Shared/WebGeolocationPosition.cpp:
      (WebKit::WebGeolocationPosition::Data::decode):
      * Shared/WebGeolocationPosition.h:
      (Data):
      * Shared/WebGestureEvent.cpp:
      (WebKit::WebGestureEvent::decode):
      * Shared/WebHitTestResult.cpp:
      (WebKit::WebHitTestResult::Data::decode):
      * Shared/WebHitTestResult.h:
      (Data):
      * Shared/WebKeyboardEvent.cpp:
      (WebKit::WebKeyboardEvent::decode):
      * Shared/WebMouseEvent.cpp:
      (WebKit::WebMouseEvent::decode):
      * Shared/WebNavigationDataStore.h:
      (WebKit::WebNavigationDataStore::decode):
      * Shared/WebPageCreationParameters.cpp:
      (WebKit::WebPageCreationParameters::decode):
      * Shared/WebPageCreationParameters.h:
      (WebPageCreationParameters):
      * Shared/WebPageGroupData.cpp:
      (WebKit::WebPageGroupData::decode):
      * Shared/WebPageGroupData.h:
      (WebPageGroupData):
      * Shared/WebPlatformTouchPoint.cpp:
      (WebKit::WebPlatformTouchPoint::decode):
      * Shared/WebPopupItem.cpp:
      (WebKit::WebPopupItem::decode):
      * Shared/WebPopupItem.h:
      * Shared/WebPreferencesStore.cpp:
      (WebKit::WebPreferencesStore::decode):
      * Shared/WebPreferencesStore.h:
      (WebPreferencesStore):
      * Shared/WebProcessCreationParameters.cpp:
      (WebKit::WebProcessCreationParameters::decode):
      * Shared/WebProcessCreationParameters.h:
      (WebProcessCreationParameters):
      * Shared/WebTouchEvent.cpp:
      (WebKit::WebTouchEvent::decode):
      * Shared/WebWheelEvent.cpp:
      (WebKit::WebWheelEvent::decode):
      * Shared/cf/ArgumentCodersCF.cpp:
      (CoreIPC::decode):
      * Shared/cf/ArgumentCodersCF.h:
      (CoreIPC):
      * Shared/mac/ArgumentCodersMac.h:
      (CoreIPC):
      * Shared/mac/ArgumentCodersMac.mm:
      (CoreIPC::decode):
      * Shared/mac/AttributedString.h:
      (AttributedString):
      * Shared/mac/AttributedString.mm:
      (WebKit::AttributedString::decode):
      * Shared/mac/ColorSpaceData.h:
      (ColorSpaceData):
      * Shared/mac/ColorSpaceData.mm:
      (WebKit::ColorSpaceData::decode):
      * Shared/mac/LayerTreeContextMac.mm:
      (WebKit::LayerTreeContext::decode):
      * Shared/mac/ObjCObjectGraphCoders.h:
      (WebContextObjCObjectGraphDecoder):
      (InjectedBundleObjCObjectGraphDecoder):
      * Shared/mac/ObjCObjectGraphCoders.mm:
      (WebKit::ObjCObjectGraphDecoder::baseDecode):
      (WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
      (WebKit::InjectedBundleObjCObjectGraphDecoderImpl::decode):
      (WebKit::WebContextObjCObjectGraphDecoder::decode):
      (WebKit::InjectedBundleObjCObjectGraphDecoder::decode):
      * Shared/mac/PlatformCertificateInfo.h:
      (PlatformCertificateInfo):
      * Shared/mac/PlatformCertificateInfo.mm:
      (WebKit::PlatformCertificateInfo::decode):
      * Shared/mac/RemoteLayerTreeTransaction.h:
      (LayerProperties):
      (RemoteLayerTreeTransaction):
      * Shared/mac/RemoteLayerTreeTransaction.mm:
      (WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
      (WebKit::RemoteLayerTreeTransaction::decode):
      * Shared/mac/SandboxExtensionMac.mm:
      (WebKit::SandboxExtension::Handle::decode):
      (WebKit::SandboxExtension::HandleArray::decode):
      * Shared/mac/SecItemRequestData.cpp:
      (WebKit::SecItemRequestData::decode):
      * Shared/mac/SecItemRequestData.h:
      * Shared/mac/SecItemResponseData.cpp:
      (WebKit::SecItemResponseData::decode):
      * Shared/mac/SecItemResponseData.h:
      (SecItemResponseData):
      * Shared/mac/WebCoreArgumentCodersMac.mm:
      (CoreIPC::::decodePlatformData):
      (CoreIPC::::decode):
      * UIProcess/WebContextUserMessageCoders.h:
      (WebKit::WebContextUserMessageDecoder::decode):
      * WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
      (WebKit::InjectedBundleUserMessageDecoder::decode):
      * WebProcess/Plugins/Plugin.cpp:
      (WebKit::Plugin::Parameters::decode):
      * WebProcess/Plugins/Plugin.h:
      (Parameters):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea151935
    • rniwa@webkit.org's avatar
      Smart link can erroneously move caret after an URL when typing immediately before it · 663721f2
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=92812
      
      Reviewed by Enrica Casucci.
      
      Source/WebCore: 
      
      The bug was caused by smart link being triggered even when a user finished typing a word
      immediately before an URL. We already had a logic to avoid smart-linking an URL when the caret
      was after the URL but we were missing a check for when the caret is before the URL.
      
      Fixed the bug by adding this check.
      
      Test: editing/inserting/smart-link-when-caret-is-moved-before-URL.html
      
      * editing/Editor.cpp:
      (WebCore::Editor::markAndReplaceFor):
      
      LayoutTests: 
      
      Add a regression for typing immediately before an URL while smart link is enabled.
      WebKit should not be moving the caret erroneously.
      
      * editing/inserting/smart-link-when-caret-is-moved-before-URL-expected.txt: Added.
      * editing/inserting/smart-link-when-caret-is-moved-before-URL.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      663721f2
    • roger_fong@apple.com's avatar
      Unreviewed. Windows build fix. FloatSize.cpp was not included in the project. · 0807ae61
      roger_fong@apple.com authored
      * WebCore.vcproj/WebCore.vcproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0807ae61
    • jchaffraix@webkit.org's avatar
      [CSS Grid Layout] computePreferredLogicalWidths doesn't handle minmax tracks · 9fcc15ce
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108403
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Test: fast/css-grid-layout/grid-preferred-logical-widths.html
      
      The code before this change was only handling minmax() with 2 fixed widths.
      The new code was updated to remove this artificial limitation and we now
      support all combination of minmax().
      
      * rendering/RenderGrid.cpp:
      (WebCore::RenderGrid::computePreferredLogicalWidths):
      Updated to use computePreferredTrackWidth..
      
      (WebCore::RenderGrid::computePreferredTrackWidth):
      Added this helper function that implements the core of the preferred width
      computation.
      
      * rendering/RenderGrid.h: Added computePreferredTrackWidth.
      
      LayoutTests:
      
      * fast/css-grid-layout/grid-preferred-logical-widths-expected.txt: Added.
      * fast/css-grid-layout/grid-preferred-logical-widths.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9fcc15ce
    • japhet@chromium.org's avatar
      Cached main resources report a zero identifer on 304s · 089b649f
      japhet@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108402
      
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Test: http/tests/cache/iframe-304-crash.html
      
      * loader/MainResourceLoader.cpp:
      (WebCore::MainResourceLoader::responseReceived): Throughout, check m_identifierForLoadWithoutResourceLoader
          instead of !loader() to determine whether MainResourceLoader needs to synthesize resource load callbacks.
      (WebCore::MainResourceLoader::dataReceived):
      (WebCore::MainResourceLoader::didFinishLoading):
      
      LayoutTests:
      
      * http/tests/cache/iframe-304-crash-expected.txt: Added.
      * http/tests/cache/iframe-304-crash.html: Added.
      * http/tests/cache/resources/iframe304.php: Added.
      * platform/chromium/TestExpectations: New test requires main resource caching, which isn't supported on chromium at the moment.
      * platform/mac/TestExpectations: New test requires main resource caching, which isn't supported on mac at the moment.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      089b649f
    • thakis@chromium.org's avatar
      [chromium] Build webkit with enable_web_intents set to 0. · 49f0f7f3
      thakis@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108408
      
      Reviewed by Tony Chang.
      
      I'll then make chromium build fine with that, then switch
      enable_web_intents to 0, roll that into webkit, and then
      actually remove the code hidden behind this flag.
      
      Source/WebCore:
      
      * bindings/v8/custom/V8IntentCustom.cpp:
      
      Source/WebKit/chromium:
      
      The features.gypi bit depends on https://codereview.chromium.org/12143002/
      and will disable web intents support on android. Since common.gypi
      sets enable_web_intents to 0 explicitly, it seems this is currently on
      by accident anyway.
      
      While it looks like this CL just removes ENABLE_WEB_INTENTS=1 from
      features.gypi completely, it's still set further down the file if
      enable_web_intents is on.
      
      * WebKit.gyp:
      * features.gypi:
      * src/WebFrameImpl.cpp:
      
      Tools:
      
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
      (WebTestRunner::TestRunner::TestRunner):
      * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
      (WebTestRunner::WebTestProxyBase::registerIntentService):
      (WebTestRunner::WebTestProxyBase::dispatchIntent):
      * DumpRenderTree/chromium/WebViewHost.cpp:
      * DumpRenderTree/chromium/WebViewHost.h:
      (WebViewHost):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49f0f7f3
    • pfeldman@chromium.org's avatar
      Web Inspector: make console object state hint non-active · 32fae905
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=108642
      
      Reviewed by Vsevolod Vlasov.
      
      Otherwise it seems like an active element user could click.
      
      * inspector/front-end/inspector.css:
      (.object-info-state-note):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32fae905
    • commit-queue@webkit.org's avatar
      Zero size gradient should paint nothing on canvas · bb8267dd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=102654
      
      Patch by Rashmi Shyamasundar <rashmi.s2@samsung.com> on 2013-02-01
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      The functions fill(), fillText(), stroke(), strokeRect() and strokeText()
      should paint nothing on canvas when the canvas fillStyle/strokeStyle
      is set to a zero size gradient.
      
      Tests: fast/canvas/canvas-fill-zeroSizeGradient.html
             fast/canvas/canvas-fillRect-zeroSizeGradient.html
             fast/canvas/canvas-fillText-zeroSizeGradient.html
             fast/canvas/canvas-stroke-zeroSizeGradient.html
             fast/canvas/canvas-strokeRect-zeroSizeGradient.html
             fast/canvas/canvas-strokeText-zeroSizeGradient.html
      
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::fill):
      (WebCore::CanvasRenderingContext2D::stroke):
      (WebCore::CanvasRenderingContext2D::strokeRect):
      (WebCore::CanvasRenderingContext2D::drawTextInternal):
      
      LayoutTests:
      
      The functions fill(), fillText(), stroke(), strokeRect() and strokeText()
      should paint nothing on canvas when the canvas fillStyle/strokeStyle
      is set to a zero size gradient.
      
      * fast/canvas/canvas-fill-zeroSizeGradient-expected.txt: Added.
      * fast/canvas/canvas-fill-zeroSizeGradient.html: Added.
      * fast/canvas/canvas-fillRect-zeroSizeGradient-expected.txt: Added.
      * fast/canvas/canvas-fillRect-zeroSizeGradient.html: Added.
      * fast/canvas/canvas-fillText-zeroSizeGradient-expected.txt: Added.
      * fast/canvas/canvas-fillText-zeroSizeGradient.html: Added.
      * fast/canvas/canvas-stroke-zeroSizeGradient-expected.txt: Added.
      * fast/canvas/canvas-stroke-zeroSizeGradient.html: Added.
      * fast/canvas/canvas-strokeRect-zeroSizeGradient-expected.txt: Added.
      * fast/canvas/canvas-strokeRect-zeroSizeGradient.html: Added.
      * fast/canvas/canvas-strokeText-zeroSizeGradient-expected.txt: Added.
      * fast/canvas/canvas-strokeText-zeroSizeGradient.html: Added.
      * fast/canvas/script-tests/canvas-fill-zeroSizeGradient.js: Added.
      * fast/canvas/script-tests/canvas-fillRect-zeroSizeGradient.js: Added.
      * fast/canvas/script-tests/canvas-fillText-zeroSizeGradient.js: Added.
      * fast/canvas/script-tests/canvas-stroke-zeroSizeGradient.js: Added.
      * fast/canvas/script-tests/canvas-strokeRect-zeroSizeGradient.js: Added.
      * fast/canvas/script-tests/canvas-strokeText-zeroSizeGradient.js: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@141612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb8267dd