1. 24 Mar, 2011 19 commits
    • dglazkov@chromium.org's avatar
      2011-03-24 Dimitri Glazkov <dglazkov@chromium.org> · db5d9dc3
      dglazkov@chromium.org authored
              Reviewed by Darin Adler.
      
              Move media controls subtree creation into one method.
              https://bugs.webkit.org/show_bug.cgi?id=56969
      
              Mechanical move, no changes in functionality.
      
              The purpose of this patch is to align existing code closer with its
              future version, when MediaControls is an element whose tree is created
              at the instantiation.
      
              * html/shadow/MediaControls.cpp:
              (WebCore::MediaControls::create): Added, consolidating all subtree generation logic into one place.
              (WebCore::MediaControls::update): Replaced methods with one call.
              * html/shadow/MediaControls.h: Updated decls.
              * rendering/MediaControlElements.cpp:
              (WebCore::MediaControlTimelineElement::create): Moved setting of attributes here.
              (WebCore::MediaControlVolumeSliderElement::create): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db5d9dc3
    • sfalken@apple.com's avatar
      Use proper string method to generate webloc string. · 798acf15
      sfalken@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=57028
      <rdar://problem/9181955>
      
      Reviewed by Darin Adler.
      
      * platform/win/ClipboardUtilitiesWin.cpp:
      (WebCore::getWebLocData):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      798acf15
    • aroben@apple.com's avatar
      Add Windows WebKit2 results for fast/css/pseudo-any.html · 156c7b0a
      aroben@apple.com authored
      This test passes on Windows but fails on Mac. <http://webkit.org/b/56988> tracks the Mac
      failure.
      
      * platform/win-wk2/fast/css/pseudo-any-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      156c7b0a
    • commit-queue@webkit.org's avatar
      2011-03-24 Ben Taylor <bentaylor.solx86@gmail.com> · e38c9faf
      commit-queue@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              https://bugs.webkit.org/show_bug.cgi?id=32821
              Fix conditionals which had an int for one case and a pointer for another.
              Fix is similar to https://bugs.webkit.org/show_bug.cgi?id=56198
      
              No new tests. Fix compilation on Solaris 10 with SunStudio 12 C++
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::valueForShadow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e38c9faf
    • commit-queue@webkit.org's avatar
      2011-03-24 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> · 6b1f3e19
      commit-queue@webkit.org authored
              Reviewed by Benjamin Poulain.
      
              [Qt] Resetting the URL property of a QWebView results in the current directory being set as file::-type URL
              https://bugs.webkit.org/show_bug.cgi?id=29595
      
              Qt Designer resets the URL by setting it to QUrl(). The bug was caused by
              ensureAbsoluteUrl() helper function treating the empty URL as a relative URL, and
              prepending the current directory.
      
              By fixing this, now we can pass QUrl() invalid and empty URLs to WebCore layer, which
              will end up loading "about:blank", but keeping it as a requested URL.
      
              This patch also simplifies the logic for requestedUrl(), since m_lastRequestedUrl
              is filled for the loaded URLs as well, we can use it in every case.
      
              Three new autotests were added, to better cover the expected behavior of setting
              the QUrl() in a QWebFrame.
      
              * Api/qwebframe.cpp:
              (ensureAbsoluteUrl): do not treat invalid URLs (empty included) as relative.
              (QWebFrame::requestedUrl): always use m_lastRequestedUrl.
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::dispatchDidFinishLoad): do not clear m_lastRequestedUrl
              anymore, since we always rely on it even for loaded frames.
      
              * tests/qwebframe/tst_qwebframe.cpp:
              (tst_QWebFrame::setUrlToEmpty): verify the behavior of setting empty URLs. This includes
              the reduction of the bug report.
              (tst_QWebFrame::setUrlToInvalid): setting invalid, but not necessarily empty, URLs.
              (tst_QWebFrame::setUrlHistory): to verify how setting empty URLs affect history.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b1f3e19
    • podivilov@chromium.org's avatar
      2011-03-24 Pavel Podivilov <podivilov@chromium.org> · ef7dc6ab
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: provide live edit callback to source frame delegate.
              https://bugs.webkit.org/show_bug.cgi?id=57003
      
              * inspector/debugger/live-edit.html:
      2011-03-24  Pavel Podivilov  <podivilov@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: provide live edit callback to source frame delegate.
              https://bugs.webkit.org/show_bug.cgi?id=57003
      
              * inspector/front-end/DebuggerModel.js:
              (WebInspector.DebuggerModel.prototype.editScriptSource):
              (WebInspector.DebuggerModel.prototype._didEditScriptSource):
              * inspector/front-end/DebuggerPresentationModel.js:
              (WebInspector.DebuggerPresentationModel):
              (WebInspector.DebuggerPresentationModel.prototype.canEditScriptSource):
              (WebInspector.DebuggerPresentationModel.prototype.editScriptSource.didEditScriptSource):
              (WebInspector.DebuggerPresentationModel.prototype.editScriptSource):
              (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
              (WebInspector.DebuggerPresentationModel.prototype._scriptForSourceFileId):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype._createSourceFrame):
              (WebInspector.SourceFrameDelegateForScriptsPanel):
              (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource):
              (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.editScriptSource):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef7dc6ab
    • ossy@webkit.org's avatar
      [Qt] Some Unicode tests fail with Qt version >= 4.7.0 · 46cf8492
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=46251
      
      Patch by Joe Wild <joseph.wild@nokia.com> on 2011-03-24
      Reviewed by Csaba Osztrogonác.
      
      Updated tests the print out character 0xFFFF for Qt Platform.
      QString.toUtf8() converts non-defined Unicode char values, like
      0xFFFF to a replacement character ('?') as documented.  Other
      platforms leave the character as 0xFFFF (but utf8 encoded).
      Converting to a real printable char seems reasonable and may
      be more reliable.
      
      * platform/qt/Skipped:
      * platform/qt/fast/js/regexp-range-bound-ffff-expected.txt: Added.
      * platform/qt/fast/js/switch-behaviour-expected.txt: Added.
      * platform/qt/fast/url: Added.
      * platform/qt/fast/url/anchor-expected.txt: Added.
      * platform/qt/fast/url/path-expected.txt: Added.
      * platform/qt/http/tests/websocket: Added.
      * platform/qt/http/tests/websocket/tests: Added.
      * platform/qt/http/tests/websocket/tests/bad-sub-protocol-non-ascii-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46cf8492
    • pfeldman@chromium.org's avatar
      2011-03-24 Pavel Feldman <pfeldman@chromium.org> · 16addaf5
      pfeldman@chromium.org authored
              Not reviewed: removing newly added inspector test that fails on release bots.
      
              * http/tests/inspector/network/network-redirect-expected.txt: Removed.
              * http/tests/inspector/network/network-redirect.html: Removed.
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16addaf5
    • pfeldman@chromium.org's avatar
      2011-03-24 Pavel Feldman <pfeldman@chromium.org> · 539f9ea3
      pfeldman@chromium.org authored
              Not reviewed: updated chromium expectations.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      539f9ea3
    • benjamin.poulain@nokia.com's avatar
      2011-03-24 Benjamin Poulain <benjamin.poulain@nokia.com> · db522b7e
      benjamin.poulain@nokia.com authored
              Reviewed by Andreas Kling.
      
              Regression: WebKit does not build with Python 3 following 56807
              https://bugs.webkit.org/show_bug.cgi?id=56923
      
              The module string does not have the function replace in Python 3. The str.replace function
              can do the same operation in this case and works with the versions 2 and 3.
      
              * inspector/generate-inspector-idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db522b7e
    • pfeldman@chromium.org's avatar
      2011-03-24 Pavel Feldman <pfeldman@chromium.org> · c0c22b97
      pfeldman@chromium.org authored
              Not reviewed: fix chromium compilation.
      
              * public/WebDevToolsAgent.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0c22b97
    • pfeldman@chromium.org's avatar
      2011-03-24 Pavel Feldman <pfeldman@chromium.org> · af98bd0f
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: brush up Network agent API.
              https://bugs.webkit.org/show_bug.cgi?id=57001
      
              * http/tests/inspector/network/network-redirect-expected.txt: Added.
              * http/tests/inspector/network/network-redirect.html: Added.
              * inspector/timeline/timeline-network-resource-expected.txt:
              * platform/chromium/inspector/timeline/timeline-network-resource-expected.txt:
      2011-03-24  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: brush up Network agent API.
              https://bugs.webkit.org/show_bug.cgi?id=57001
      
              * inspector/Inspector.json:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::willSendRequestImpl):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::willSendRequest):
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::buildObjectForResourceRequest):
              (WebCore::buildObjectForResourceResponse):
              (WebCore::buildObjectForCachedResource):
              (WebCore::InspectorResourceAgent::willSendRequest):
              (WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
              (WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
              (WebCore::InspectorResourceAgent::setExtraHeaders):
              * inspector/InspectorResourceAgent.h:
              * inspector/TimelineRecordFactory.cpp:
              (WebCore::TimelineRecordFactory::createResourceReceiveResponseData):
              * inspector/front-end/NetworkManager.js:
              (WebInspector.NetworkDispatcher.prototype._updateResourceWithRequest):
              (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
              (WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource):
              (WebInspector.NetworkDispatcher.prototype.willSendRequest):
              (WebInspector.NetworkDispatcher.prototype.didReceiveWebSocketHandshakeResponse):
              (WebInspector.NetworkDispatcher.prototype.didCloseWebSocket):
              * inspector/front-end/Resource.js:
              * inspector/front-end/TimelinePanel.js:
              (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
              * loader/ResourceLoadNotifier.cpp:
              (WebCore::ResourceLoadNotifier::assignIdentifierToInitialRequest):
              (WebCore::ResourceLoadNotifier::dispatchWillSendRequest):
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::createResourceHandle):
      2011-03-24  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: brush up Network agent API.
              https://bugs.webkit.org/show_bug.cgi?id=57001
      
              * public/WebDevToolsAgent.h:
              * src/WebDevToolsAgentImpl.cpp:
              (WebKit::WebDevToolsAgentImpl::identifierForInitialRequest):
              (WebKit::WebDevToolsAgentImpl::willSendRequest):
              * src/WebDevToolsAgentImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af98bd0f
    • steveblock@google.com's avatar
      2011-03-11 Steve Block <steveblock@google.com> · 6c7e8883
      steveblock@google.com authored
              Reviewed by Jeremy Orlow.
      
              JNIType is not specific to JNI so should be renamed
              https://bugs.webkit.org/show_bug.cgi?id=56197
      
              This patch renames JNIType to JavaType, renames the values of
              the enum, and moves it out of JNIUtility.h to its own file.
              Also renames the corresponding JavaField and JavaMethod getters.
      
              No new tests, refactoring only.
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/jni/JNIUtility.cpp:
              (JSC::Bindings::javaTypeFromClassName):
              (JSC::Bindings::signatureFromJavaType):
              (JSC::Bindings::javaTypeFromPrimitiveType):
              (JSC::Bindings::getJNIField):
              (JSC::Bindings::callJNIMethod):
              * bridge/jni/JNIUtility.h:
              * bridge/jni/JavaMethod.cpp:
              (JavaMethod::JavaMethod):
              (JavaMethod::signature):
              * bridge/jni/JavaMethod.h:
              (JSC::Bindings::JavaMethod::returnTypeClassName):
              (JSC::Bindings::JavaMethod::returnType):
              * bridge/jni/JavaType.h: Copied from Source/WebCore/bridge/jni/JavaMethod.h.
              * bridge/jni/jni_jsobject.mm:
              (JavaJSObject::toString):
              * bridge/jni/jni_objc.mm:
              (JSC::Bindings::dispatchJNICall):
              * bridge/jni/jsc/JNIUtilityPrivate.cpp:
              (JSC::Bindings::convertArrayInstanceToJavaArray):
              (JSC::Bindings::convertValueToJValue):
              * bridge/jni/jsc/JNIUtilityPrivate.h:
              * bridge/jni/jsc/JavaArrayJSC.cpp:
              (JavaArray::setValueAt):
              (JavaArray::valueAt):
              * bridge/jni/jsc/JavaClassJSC.cpp:
              * bridge/jni/jsc/JavaFieldJSC.cpp:
              (JavaField::JavaField):
              (JavaField::dispatchValueFromInstance):
              (JavaField::valueFromInstance):
              (JavaField::dispatchSetValueToInstance):
              (JavaField::setValueToInstance):
              * bridge/jni/jsc/JavaFieldJSC.h:
              (JSC::Bindings::JavaField::typeClassName):
              (JSC::Bindings::JavaField::type):
              * bridge/jni/jsc/JavaInstanceJSC.cpp:
              (JavaInstance::invokeMethod):
              * bridge/jni/v8/JNIUtilityPrivate.cpp:
              (JSC::Bindings::convertNPVariantToJValue):
              (JSC::Bindings::convertJValueToNPVariant):
              * bridge/jni/v8/JNIUtilityPrivate.h:
              * bridge/jni/v8/JavaFieldV8.cpp:
              (JavaField::JavaField):
              * bridge/jni/v8/JavaFieldV8.h:
              (JSC::Bindings::JavaField::typeClassName):
              (JSC::Bindings::JavaField::type):
              * bridge/jni/v8/JavaInstanceV8.cpp:
              (JavaInstance::invokeMethod):
              (JavaInstance::getField):
              * bridge/jni/v8/JavaNPObjectV8.cpp:
              (JSC::Bindings::JavaNPObjectInvoke):
              (JSC::Bindings::JavaNPObjectGetProperty):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c7e8883
    • philn@webkit.org's avatar
      2011-03-24 Philippe Normand <pnormand@igalia.com> · 86a7919d
      philn@webkit.org authored
              Unreviewed, skipping 3 xmlhttprequest tests timing out on GTK, see
              also bug 33026.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86a7919d
    • philn@webkit.org's avatar
      2011-03-24 Philippe Normand <pnormand@igalia.com> · e75e7eb1
      philn@webkit.org authored
              Unreviewed, new GTK fast/block/lineboxcontain baselines after
              r81684 and r81608.
      
              * editing/selection/fake-drag-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/block-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/block-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/block-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/block-font-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/block-font-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/block-font-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/block-glyphs-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/block-glyphs-replaced-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/block-replaced-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/block-replaced-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/font-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/font-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/font-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/font-replaced-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/font-replaced-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/glyphs-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/glyphs-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/glyphs-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-replaced-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-vertical-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-vertical-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-box-vertical-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/inline-replaced-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/none-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/none-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/none-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.txt: Added.
              * platform/gtk/fast/block/lineboxcontain/replaced-expected.checksum: Added.
              * platform/gtk/fast/block/lineboxcontain/replaced-expected.png: Added.
              * platform/gtk/fast/block/lineboxcontain/replaced-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e75e7eb1
    • commit-queue@webkit.org's avatar
      2011-03-24 Noel Gordon <noel.gordon@gmail.com> · 6b481b6b
      commit-queue@webkit.org authored
              Reviewed by Ojan Vafai.
      
              [chromium] WebBindings::getRangeImpl() should NULL check its NPObject argument
              https://bugs.webkit.org/show_bug.cgi?id=56996
      
              * src/WebBindings.cpp:
              (WebKit::getRangeImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b481b6b
    • ojan@chromium.org's avatar
      2011-03-24 Ojan Vafai <ojan@chromium.org> · 9637c9a0
      ojan@chromium.org authored
              Was being a little braindead when I committed this.
              Only simple selectors are allowed, but sibling selectors
              are sibling selectors.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::collectFeaturesFromList):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9637c9a0
    • morrita@google.com's avatar
      2011-03-23 MORITA Hajime <morrita@google.com> · 102429ef
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              Spellcheck feature specific symbols should be defined.
              https://bugs.webkit.org/show_bug.cgi?id=56818
      
              * Introduced USE(UNIFIED_TEXT_CHECKING), USE(GRAMMAR_CHECKING) and USE(AUTOMATIC_TEXT_REPLACEMENT)
              * Replaced a part of of BUILDING_ON_* conditionals with them.
      
              Note that small amount of code path on Editor.cpp is now compiled under USE(GRAMMAR_CHECKING)
              because these code path is already built under non-Mac ports and
              Keeping them buildable for such platforms reduces the build breakage risk.
              These path is guarded by Settings thus should never get reached.
      
              No new tests. No behavioral change.
      
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * editing/Editor.cpp:
              (WebCore::Editor::advanceToNextMisspelling):
              (WebCore::Editor::isSelectionUngrammatical):
              (WebCore::Editor::guessesForUngrammaticalSelection):
              (WebCore::Editor::guessesForMisspelledOrUngrammaticalSelection):
              (WebCore::Editor::markMisspellingsAfterTypingToWord):
              (WebCore::Editor::markMisspellingsOrBadGrammar):
              (WebCore::Editor::markBadGrammar):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::changeBackToReplacedString):
              (WebCore::Editor::markMisspellingsAndBadGrammar):
              * editing/Editor.h:
              * editing/TextCheckingHelper.cpp:
              (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
              (WebCore::TextCheckingHelper::findFirstGrammarDetail):
              (WebCore::TextCheckingHelper::findFirstBadGrammar):
              (WebCore::TextCheckingHelper::isUngrammatical):
              (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
              (WebCore::TextCheckingHelper::markAllBadGrammar):
              * loader/EmptyClients.h:
              * platform/text/TextCheckerClient.h:
              * platform/text/TextChecking.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      102429ef
    • commit-queue@webkit.org's avatar
      2011-03-23 Noel Gordon <noel.gordon@gmail.com> · 07c080f6
      commit-queue@webkit.org authored
              Reviewed by Ojan Vafai.
      
              [chromium] WebBindings{.h,.cpp}: should use consistent argument naming
              https://bugs.webkit.org/show_bug.cgi?id=56898
      
              Address FIXME I noted/added in r81676.  Wanted to just copy/paste the checking
              code from elsewhere in the file, but inconsistent argument naming made it more
              difficult than it need be, so first step: use consistent naming.
      
              * public/WebBindings.h:
              * src/WebBindings.cpp:
              (WebKit::WebBindings::construct):
              (WebKit::WebBindings::enumerate):
              (WebKit::WebBindings::evaluate):
              (WebKit::WebBindings::evaluateHelper):
              (WebKit::WebBindings::getProperty):
              (WebKit::WebBindings::hasMethod):
              (WebKit::WebBindings::hasProperty):
              (WebKit::WebBindings::invoke):
              (WebKit::WebBindings::invokeDefault):
              (WebKit::WebBindings::releaseObject):
              (WebKit::WebBindings::removeProperty):
              (WebKit::WebBindings::retainObject):
              (WebKit::WebBindings::setException):
              (WebKit::WebBindings::setProperty):
              (WebKit::WebBindings::unregisterObject):
              (WebKit::WebBindings::extractIdentifierData):
              (WebKit::getRangeImpl):
              (WebKit::getElementImpl):
              (WebKit::makeIntArrayImpl):
              (WebKit::WebBindings::getRange):
              (WebKit::WebBindings::makeIntArray):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07c080f6
  2. 23 Mar, 2011 21 commits
    • tkent@chromium.org's avatar
      [Chromium] Force to make validation bubble DIV position:absolute · 9a74a07b
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=56901
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      Test: fast/forms/interactive-validation-crash-by-style-override.html
      
      * html/ValidationMessage.cpp:
      (WebCore::ValidationMessage::buildBubbleTree): Add position:absolute
        because we need to move the validation message to a good position.
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::addChild):
      
      LayoutTests:
      
      * fast/forms/interactive-validation-crash-by-style-override-expected.txt: Added.
      * fast/forms/interactive-validation-crash-by-style-override.html: Added.
      * platform/gtk/Skipped: Skip the new test because the interactive
        validation feature is not enabled.
      * platform/mac/Skipped: ditto.
      * platform/qt/Skipped: ditto.
      * platform/win/Skipped: ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a74a07b
    • ojan@chromium.org's avatar
      2011-03-23 Ojan Vafai <ojan@chromium.org> · 6a7876bc
      ojan@chromium.org authored
              Add failing result for WebKit2. All tests that require
              focus fail on WebKit2. See https://bugs.webkit.org/show_bug.cgi?id=56988.
      
              * platform/mac-wk2/fast/css/pseudo-any-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a7876bc
    • commit-queue@webkit.org's avatar
      2011-03-23 Mike Lawther <mikelawther@chromium.org> · dd9ee4ca
      commit-queue@webkit.org authored
              Reviewed by Ojan Vafai.
      
              flex/bison tokens and grammar for CSS calc
              https://bugs.webkit.org/show_bug.cgi?id=54412
      
              Only the 'errors' tests pass as ultimately intended right now. As of this
              patch, none of the actual calculations are expected to work, since only
              the lexing/grammar stage is present.
      
              * css3/calc/calc-errors-expected.txt: Added.
              * css3/calc/calc-errors.html: Added.
              * css3/calc/minmax-errors-expected.txt: Added.
              * css3/calc/minmax-errors.html: Added.
              * css3/calc/simple-calcs-expected.txt: Added.
              * css3/calc/simple-calcs.html: Added.
              * css3/calc/simple-minmax-expected.txt: Added.
              * css3/calc/simple-minmax.html: Added.
      2011-03-23  Mike Lawther  <mikelawther@chromium.org>
      
              Reviewed by Ojan Vafai.
      
              flex/bison tokens and grammar for CSS calc
              https://bugs.webkit.org/show_bug.cgi?id=54412
      
              Tests: css3/calc/calc-errors.html
                     css3/calc/minmax-errors.html
                     css3/calc/simple-calcs.html
                     css3/calc/simple-minmax.html
      
              * css/CSSGrammar.y:
              * css/CSSParserValues.cpp:
              (WebCore::CSSParserValueList::insertValueAt):
              (WebCore::CSSParserValueList::extend):
              * css/CSSParserValues.h:
              * css/tokenizer.flex:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd9ee4ca
    • commit-queue@webkit.org's avatar
      2011-03-23 Adam Klein <adamk@chromium.org> · 52e8892f
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              Fix resolveLocalFileSystemURL (and sync version) error codes to match the spec
              https://bugs.webkit.org/show_bug.cgi?id=56961
      
              * http/tests/filesystem/resolve-uri-expected.txt:
              * http/tests/filesystem/script-tests/resolve-uri.js:
              Added three tests to exercise SECURITY_ERR:
              (runWrongDomain):
              (runWrongPort):
              (runWrongScheme):
              And updated four tests to test error codes:
              (runBogusURL):
              (runWrongProtocol):
              (runNotEnoughSlashes):
              (runNotEnoughSlashes2):
              * http/tests/filesystem/workers/resolve-url-expected.txt:
              * http/tests/filesystem/workers/resolve-url-sync-expected.txt:
              * http/tests/filesystem/workers/script-tests/resolve-url-sync.js:
              Added three tests to exercise SECURITY_ERR:
              (runWrongDomain):
              (runWrongPort):
              (runWrongScheme):
              And updated four tests to test error codes:
              (runBogusURL):
              (runWrongProtocol):
              (runNotEnoughSlashes):
              (runNotEnoughSlashes2):
      2011-03-23  Adam Klein  <adamk@chromium.org>
      
              Reviewed by David Levin.
      
              Fix resolveLocalFileSystemURL (and sync version) error codes to match the spec
              https://bugs.webkit.org/show_bug.cgi?id=56961
      
              See error code listing in the Files & Directories spec:
              http://dev.w3.org/2009/dap/file-system/file-dir-sys.html#widl-LocalFileSystemSync-resolveLocalFileSystemSyncURL
      
              Note that the spec currently only specifies errors for the sync
              version; I've used the same codes for the async version.
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::resolveLocalFileSystemURL):
              * workers/WorkerContext.cpp:
              (WebCore::WorkerContext::resolveLocalFileSystemURL):
              (WebCore::WorkerContext::resolveLocalFileSystemSyncURL):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52e8892f
    • commit-queue@webkit.org's avatar
      2011-03-23 Jia Pu <jpu@apple.com> · b5484ecd
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              Hook up new AppKit autocorrection UI with WK2.
              https://bugs.webkit.org/show_bug.cgi?id=56055
              <rdar://problem/8947463>
      
              Please see WebCore/ChangeLog for detail.
      
              * platform/mac-wk2/Skipped: Enable autocorrection tests for WK2.
      2011-03-23  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Hook up new AppKit autocorrection UI with WK2.
              https://bugs.webkit.org/show_bug.cgi?id=56055
              <rdar://problem/8947463>
      
              This patch is to enable WK2 to utilize autocorrection UI on Mac OS X. It contains following
              major changes:
      
              1. All but one autocorrection related message is synchronous. Since dismissing autocorrection
              panel can potentially cause editing to occur, a synchronous dismissCorrectionPanelSoon() function
              is introduced to ensure all editing commands occur in correct order.
      
              2. Additional condition variable is needed to implement dismissCorrectionPanelSoon().
              To improve maintainability, CorrectionPanel class is introduced to manage the
              internal state related to correction panel. This change is applied to both WK1 and WK2.
      
              3. EditorClient::isShowingCorrectionPanel() has been removed. The original purpose is to allow
              editor to know when to handle ESC key event. Now this is handled internally in AppKit, so
              EditorClient::isShowingCorrectionPanel() isn't necessary anymore.
      
              4. The Editor* argument in EditorClient::showCorrectionPanel() has been removed, since we can
              access object via WebView or WKView.
      
              * editing/Editor.cpp:
              (WebCore::Editor::markMisspellingsAfterTypingToWord):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::correctionPanelTimerFired):
              (WebCore::Editor::dismissCorrectionPanel):
              (WebCore::Editor::dismissCorrectionPanelSoon):
              (WebCore::Editor::applyAutocorrectionBeforeTypingIfAppropriate):
              * editing/Editor.h:
              * editing/EditorCommand.cpp:
              (WebCore::createCommandMap):
              * loader/EmptyClients.h:
              (WebCore::EmptyEditorClient::showCorrectionPanel):
              (WebCore::EmptyEditorClient::dismissCorrectionPanelSoon):
              * manual-tests/autocorrection/close-window-when-correction-is-shown.html: Added.
              * page/EditorClient.h:
      2011-03-23  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Hook up new AppKit autocorrection UI with WK2.
              https://bugs.webkit.org/show_bug.cgi?id=56055
              <rdar://problem/8947463>
      
              Please see WebCore/ChangeLog for detail.
      
              * WebKit.xcodeproj/project.pbxproj:
      2011-03-23  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Hook up new AppKit autocorrection UI with WK2.
              https://bugs.webkit.org/show_bug.cgi?id=56055
              <rdar://problem/8947463>
      
              Please see WebCore/ChangeLog for detail.
      
              * WebCoreSupport/CorrectionPanel.h: Added.
              (CorrectionPanel::isShowing):
              * WebCoreSupport/CorrectionPanel.mm: Added.
              (correctionBubbleType):
              (CorrectionPanel::CorrectionPanel):
              (CorrectionPanel::~CorrectionPanel):
              (CorrectionPanel::show):
              (CorrectionPanel::dismiss):
              (CorrectionPanel::dismissSoon):
              (CorrectionPanel::dismissInternal):
              (CorrectionPanel::recordAutocorrectionResponse):
              * WebCoreSupport/WebEditorClient.h:
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::WebEditorClient):
              (WebEditorClient::showCorrectionPanel):
              (WebEditorClient::dismissCorrectionPanel):
              (WebEditorClient::dismissCorrectionPanelSoon):
              (WebEditorClient::recordAutocorrectionResponse):
              * WebView/WebView.mm:
              (-[WebView handleCorrectionPanelResult:]):
              * WebView/WebViewPrivate.h:
      2011-03-23  Jia Pu  <jpu@apple.com>
      
              Reviewed by Darin Adler.
      
              Hook up new AppKit autocorrection UI with WK2.
              https://bugs.webkit.org/show_bug.cgi?id=56055
              <rdar://problem/8947463>
      
              Please see WebCore/ChangeLog for detail.
      
              The calls to AppKit are implemented in PageClientImpl. Other changes are necessary for the
              plumbing work.
      
              * UIProcess/API/mac/PageClientImpl.h:
              * UIProcess/API/mac/PageClientImpl.mm:
              (WebKit::PageClientImpl::showCorrectionPanel):
              (WebKit::PageClientImpl::dismissCorrectionPanel):
              (WebKit::PageClientImpl::dismissCorrectionPanelSoon):
              (WebKit::PageClientImpl::recordAutocorrectionResponse):
              * UIProcess/API/mac/WKView.mm:
              (-[WKView spellCheckerDocumentTag]):
              (-[WKView handleCorrectionPanelResult:]):
              * UIProcess/API/mac/WKViewPrivate.h:
              * UIProcess/PageClient.h:
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::didCommitLoadForFrame):
              (WebKit::WebPageProxy::showCorrectionPanel):
              (WebKit::WebPageProxy::dismissCorrectionPanel):
              (WebKit::WebPageProxy::dismissCorrectionPanelSoon):
              (WebKit::WebPageProxy::recordAutocorrectionResponse):
              (WebKit::WebPageProxy::handleCorrectionPanelResult):
              * UIProcess/WebPageProxy.h:
              * UIProcess/WebPageProxy.messages.in:
              * UIProcess/mac/CorrectionPanel.h: Added.
              (WebKit::CorrectionPanel::isShowing):
              * UIProcess/mac/CorrectionPanel.mm: Added.
              (correctionBubbleType):
              (WebKit::CorrectionPanel::CorrectionPanel):
              (WebKit::CorrectionPanel::~CorrectionPanel):
              (WebKit::CorrectionPanel::show):
              (WebKit::CorrectionPanel::dismiss):
              (WebKit::CorrectionPanel::dismissSoon):
              (WebKit::CorrectionPanel::dismissInternal):
              (WebKit::CorrectionPanel::recordAutocorrectionResponse):
              * WebKit2.xcodeproj/project.pbxproj:
              * WebProcess/WebCoreSupport/WebEditorClient.h:
              * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
              (WebKit::WebEditorClient::showCorrectionPanel):
              (WebKit::WebEditorClient::dismissCorrectionPanel):
              (WebKit::WebEditorClient::dismissCorrectionPanelSoon):
              (WebKit::WebEditorClient::recordAutocorrectionResponse):
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::handleCorrectionPanelResult):
              * WebProcess/WebPage/WebPage.h:
              * WebProcess/WebPage/WebPage.messages.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5484ecd
    • jcivelli@chromium.org's avatar
      2011-03-23 Jay Civelli <jcivelli@chromium.org> · 2de77018
      jcivelli@chromium.org authored
              Reviewed by David Levin.
      
              Relanding:
              Moving the method that is used to retrieve all the resources in
              a page from the Chromium code (dom_operations.cc) to WebKit.
              https://bugs.webkit.org/show_bug.cgi?id=55859
      
              * WebKit.gyp:
              * public/WebPageSerializer.h:
              * public/WebURL.h:
              (WebKit::operator==):
              (WebKit::operator!=):
              * public/WebVector.h:
              (WebKit::WebVector::contains):
              * src/WebDataSourceImpl.cpp:
              (WebKit::WebDataSourceImpl::WebDataSourceImpl):
              * src/WebPageSerializer.cpp:
              (WebCore::getSubResourceURLFromElement):
              (WebCore::retrieveResourcesForElement):
              (WebCore::retrieveResourcesForFrame):
              (WebKit::WebPageSerializer::retrieveAllResources):
              * tests/WebFrameTest.cpp:
              * tests/WebPageSerializerTest.cpp: Added.
              * tests/data/pageserialization/awesome.png: Added.
              * tests/data/pageserialization/embed_iframe.html: Added.
              * tests/data/pageserialization/object_iframe.html: Added.
              * tests/data/pageserialization/simple_iframe.html: Added.
              * tests/data/pageserialization/simple_page.html: Added.
              * tests/data/pageserialization/top_frame.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2de77018
    • ojan@chromium.org's avatar
      2011-03-22 Ojan Vafai <ojan@chromium.org> · ce99e9f8
      ojan@chromium.org authored
              Reviewed by Antti Koivisto.
      
              move :not over to using selectorList instead of simpleSelector
              https://bugs.webkit.org/show_bug.cgi?id=56894
      
              Saves memory and simplifies code.
      
              No new tests since existing tests cover this code.
      
              * css/CSSGrammar.y:
              Also removed extranenous calls to updateLastSelectorLineAndPosition in
              simple_selector_list. These happened to work, but are only actually
              needed in selector_list.
              * css/CSSParserValues.h:
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::specificityForOneSelector):
              Removed null-check. The parser null-checks, I don't see why we need to here.
              (WebCore::CSSSelector::selectorText):
              Ditto.
              (WebCore::CSSSelector::setArgument):
              (WebCore::CSSSelector::isSimple):
              * css/CSSSelector.h:
              * css/CSSSelectorList.cpp:
              (WebCore::forEachTagSelector):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
              (WebCore::collectFeaturesFromSelector):
              (WebCore::collectFeaturesFromList):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce99e9f8
    • carol.szabo@nokia.com's avatar
      2011-03-23 Carol Szabo <carol.szabo@nokia.com> · d7917f7f
      carol.szabo@nokia.com authored
              Reviewed by David Hyatt.
      
              This test verifies the correct update of a second renderer that
              displays the same CounterNode.
      
              Assertion and incorrect rendering of counters.
              https://bugs.webkit.org/show_bug.cgi?id=56896
      
              * fast/css/counters/2displays-expected.txt: Added.
              * fast/css/counters/2displays.html: Added.
      2011-03-23  Carol Szabo  <carol.szabo@nokia.com>
      
              Reviewed by David Hyatt.
      
              Made sure that renderers displaying counters are invalidated upon
              counter destruction.
      
              Assertion and incorrect rendering of counters.
              https://bugs.webkit.org/show_bug.cgi?id=56896
      
              Test: fast/css/counters/2displays.html
      
              * rendering/CounterNode.cpp:
              (WebCore::CounterNode::~CounterNode):
              Added to make sure that its display renderers are always reset when
              the node is deleted.
              (WebCore::CounterNode::resetRenderers):
              Fixed bug that would prevent reset of second and subsequent
              display renderers.
              * rendering/CounterNode.h:
              * rendering/RenderCounter.cpp:
              (WebCore::destroyCounterNodeWithoutMapRemoval):
              removed unnecessary calls to resetRenderers() as the CounterNode
              destructor takes care of that now.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7917f7f
    • commit-queue@webkit.org's avatar
      2011-03-23 Leandro Gracia Gil <leandrogracia@chromium.org> · 0e9c20ff
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              Media Stream API: fix the order of the options in build-webkit.
              https://bugs.webkit.org/show_bug.cgi?id=56949
      
              Fix the order of the options in build-webkit.
      
              * Scripts/build-webkit:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e9c20ff
    • bweinstein@apple.com's avatar
      WebKit2: Need API to manage the Media Cache · 5ad3f0fb
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=56878
      <rdar://problem/9082503>
      
      Reviewed by Maciej Stachowiak.
      
      Source/WebCore: 
      
      Add functions that need to be exported.
      
      * WebCore.exp.in:
      
      Source/WebKit2: 
      
      Call through to HTMLMediaElement functions to manage the WebCore media cache.
      
      * WebProcess/MediaCache/WebMediaCacheManager.cpp:
      (WebKit::WebMediaCacheManager::getHostnamesWithMediaCache):
      (WebKit::WebMediaCacheManager::clearCacheForHostname):
      (WebKit::WebMediaCacheManager::clearCacheForAllHostnames):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ad3f0fb
    • commit-queue@webkit.org's avatar
      2011-03-23 Robert Kroeger <rjkroege@chromium.org> · bcc5bdbc
      commit-queue@webkit.org authored
              Reviewed by James Robinson.
      
              Correct use of ENABLE() Macro
      
              In http://trac.webkit.org/changeset/81618, I mis-used the ENABLE()
              macro. This patch corrects.
      
              https://bugs.webkit.org/show_bug.cgi?id=56964
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::EventHandler):
              (WebCore::EventHandler::handleTouchEvent):
              * page/EventHandler.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81835 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcc5bdbc
    • commit-queue@webkit.org's avatar
      2011-03-23 Adam Klein <adamk@chromium.org> · 7ff880d3
      commit-queue@webkit.org authored
              Reviewed by Mihai Parparita.
      
              Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
              https://bugs.webkit.org/show_bug.cgi?id=56884
      
              This option will be utilized by Chromium's ui_tests to allow
              referencing js-test-resources from a layout test over HTTP.
      
              * Scripts/new-run-webkit-httpd:
              Added --layout_tests_dir option.
              * Scripts/webkitpy/layout_tests/port/http_server.py:
              Plumbed through as layout_tests_dir param.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ff880d3
    • jer.noble@apple.com's avatar
      2011-03-23 Jer Noble <jer.noble@apple.com> · c36751c2
      jer.noble@apple.com authored
              Reviewed by Simon Fraser.
      
              Scrubbing <video> with HTTP Live Stream resizes element to 0x0
              https://bugs.webkit.org/show_bug.cgi?id=55702
      
              QTKit will occasionally set the natural size of a QTMovie to 0x0 while scrubbing
              an HTTP Live Stream.  So we will cache the last valid value returned by QTKit
              and use that as our naturalSize until a new valid value is returned.
      
              Unfortunately, QTKit will also fail to generate a notification when the natural size
              changes, so we are forced to cache the natural size from within naturalSize(), which
              is a const function, necessitating a const_cast to set m_cachedNaturalSize.
      
              * platform/graphics/mac/MediaPlayerPrivateQTKit.h: Added m_cachedNaturalSize.
              * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
              (WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit): Initialize m_cachedNaturalSize.
              (WebCore::MediaPlayerPrivateQTKit::naturalSize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c36751c2
    • ap@apple.com's avatar
      Build fix. · 421e9a1f
      ap@apple.com authored
              * loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
              Removed a stray parenthesis.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      421e9a1f
    • ap@apple.com's avatar
      Reviewed by Maciej Stachowiak. · 09535d15
      ap@apple.com authored
              REGRESSION: Infinite recursion in recursiveCheckLoadComplete()/checkLoadCompleteForThisFrame()/stopLoading()
              https://bugs.webkit.org/show_bug.cgi?id=56978
              <rdar://problem/9041670>
      
              No new tests, because there is no known way to reproduce.
      
              Removed strange code that was trying to stop a non-loading provisional document loader and
              even its subframes (?!). Added assertions to catch it if we can actually be loading here in
              some sense.
              Rewrote a condition for clarity - starting with r43148, it was acting as an opposite of a
              recursion guard (but that didn't cause immediate problems then).
      
              * loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09535d15
    • beidson@apple.com's avatar
      Attempt to fix the build for platforms that have the icon database · eae99225
      beidson@apple.com authored
      disabled but still provide settings API for it...?
      
      * loader/icon/IconDatabase.h:
      (WebCore::IconDatabase::defaultDatabaseFilename):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eae99225
    • kbr@google.com's avatar
      2011-03-23 Kenneth Russell <kbr@google.com> · 74ea68db
      kbr@google.com authored
              Rolled forward Chromium DEPS again to fix DumpRenderTree build
              failure caused by r81821.
      
              * DEPS:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81829 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74ea68db
    • enrica@apple.com's avatar
      Services menu item to convert selected Simplified/Traditional Chinese Text is not working. · 01e44667
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=56974
      <rdar://problem/8284642>
      
      Reviewed by Alexey Proskuryakov.
      
      This fixes a regression introduced by http://trac.webkit.org/changeset/61794
      where readSelectionFromPasteboard was accidentally removed.
      This method and writeSelectionToPasteboard are needed to support Mac OS X
      services.
              
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _pasteAsPlainTextWithPasteboard:]): Added.
      (-[WebHTMLView readSelectionFromPasteboard:]): Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01e44667
    • mrowe@apple.com's avatar
      Fix the build. · df5deaf1
      mrowe@apple.com authored
      * WebCore.exp.in: Export the new version of IconDatabase::open.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df5deaf1
    • mrowe@apple.com's avatar
      <rdar://problem/7959320> Threads that use APIs above the BSD layer must be... · 3cae7938
      mrowe@apple.com authored
      <rdar://problem/7959320> Threads that use APIs above the BSD layer must be registered with the Obj-C GC.
      
      Reviewed by Darin Adler.
      
      * wtf/ThreadingPthreads.cpp:
      (WTF::initializeCurrentThreadInternal):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cae7938
    • beidson@apple.com's avatar
      Change IconDatabase opening to allow for arbitrary filenames · 0d601961
      beidson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=56977
      
      Reviewed by Sam Weinig.
      
      ../WebCore: 
      
      * WebCore.exp.in:
      * loader/icon/IconDatabase.cpp:
      (WebCore::IconDatabase::open):
      * loader/icon/IconDatabase.h:
      * loader/icon/IconDatabaseBase.cpp:
      (WebCore::IconDatabaseBase::open):
      * loader/icon/IconDatabaseBase.h:
      * loader/icon/IconDatabaseClient.h:
      
      ../WebKit/efl: 
      
      * ewk/ewk_settings.cpp:
      (ewk_settings_icon_database_path_set):
      
      ../WebKit/gtk: 
      
      * webkit/webkiticondatabase.cpp:
      (webkit_icon_database_set_path):
      
      ../WebKit/mac: 
      
      * Misc/WebIconDatabase.mm:
      (-[WebIconDatabase _startUpIconDatabase]):
      
      ../WebKit/qt: 
      
      * Api/qwebsettings.cpp:
      (QWebSettings::setIconDatabasePath):
      
      ../WebKit/win: 
      
      * WebIconDatabase.cpp:
      (WebIconDatabase::startUpIconDatabase):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@81824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d601961