1. 14 Sep, 2012 40 commits
    • commit-queue@webkit.org's avatar
      [chromium] add touch area to gestureTapDown data · da4fc77b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96806
      
      Patch by Rick Byers <rbyers@chromium.org> on 2012-09-14
      Reviewed by Adam Barth.
      
      Add width/height for GestureTapDown as for GestureTap/LongPress so that
      we can eventually do fuzzing on it.
      * public/WebInputEvent.h:
      * src/WebInputEventConversion.cpp:
      (WebKit::PlatformGestureEventBuilder::PlatformGestureEventBuilder):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da4fc77b
    • jamesr@google.com's avatar
      Unreviewed, rolling out r128627. · cd3fc72f
      jamesr@google.com authored
      http://trac.webkit.org/changeset/128627
      https://bugs.webkit.org/show_bug.cgi?id=96575
      
      Breaks indexeddb content_browsertests in chromium
      
      Source/WebCore:
      
      * Modules/indexeddb/IDBDatabase.cpp:
      (WebCore::IDBDatabase::IDBDatabase):
      (WebCore::IDBDatabase::setVersion):
      * Modules/indexeddb/IDBDatabase.h:
      (IDBDatabase):
      
      LayoutTests:
      
      * http/tests/inspector/indexeddb/database-data-expected.txt:
      * http/tests/inspector/indexeddb/database-structure-expected.txt:
      * http/tests/inspector/indexeddb/resources-panel-expected.txt:
      * storage/indexeddb/create-and-remove-object-store-expected.txt:
      * storage/indexeddb/create-object-store-options-expected.txt:
      * storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
      * storage/indexeddb/createObjectStore-null-name-expected.txt:
      * storage/indexeddb/cursor-added-bug-expected.txt:
      * storage/indexeddb/cursor-advance-expected.txt:
      * storage/indexeddb/cursor-continue-dir-expected.txt:
      * storage/indexeddb/cursor-continue-expected.txt:
      * storage/indexeddb/cursor-continue-validity-expected.txt:
      * storage/indexeddb/cursor-delete-expected.txt:
      * storage/indexeddb/cursor-inconsistency-expected.txt:
      * storage/indexeddb/cursor-index-delete-expected.txt:
      * storage/indexeddb/cursor-key-order-expected.txt:
      * storage/indexeddb/cursor-overloads-expected.txt:
      * storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
      * storage/indexeddb/cursor-primary-key-order-expected.txt:
      * storage/indexeddb/cursor-reverse-bug-expected.txt:
      * storage/indexeddb/cursor-skip-deleted-expected.txt:
      * storage/indexeddb/cursor-update-expected.txt:
      * storage/indexeddb/cursor-update-value-argument-required-expected.txt:
      * storage/indexeddb/cursor-value-expected.txt:
      * storage/indexeddb/data-corruption-expected.txt:
      * storage/indexeddb/database-basics-expected.txt:
      * storage/indexeddb/database-close-expected.txt:
      * storage/indexeddb/database-closepending-flag-expected.txt:
      * storage/indexeddb/database-deletepending-flag-expected.txt:
      * storage/indexeddb/delete-closed-database-object-expected.txt:
      * storage/indexeddb/delete-range-expected.txt:
      * storage/indexeddb/deleteIndex-expected.txt:
      * storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
      * storage/indexeddb/deleteObjectStore-null-name-expected.txt:
      * storage/indexeddb/deleted-objects-expected.txt:
      * storage/indexeddb/deletedatabase-transaction-expected.txt:
      * storage/indexeddb/duplicates-expected.txt:
      * storage/indexeddb/error-causes-abort-by-default-expected.txt:
      * storage/indexeddb/exception-in-event-aborts-expected.txt:
      * storage/indexeddb/exceptions-expected.txt:
      * storage/indexeddb/factory-deletedatabase-expected.txt:
      * storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
      * storage/indexeddb/get-keyrange-expected.txt:
      * storage/indexeddb/index-basics-expected.txt:
      * storage/indexeddb/index-basics-workers-expected.txt:
      * storage/indexeddb/index-count-expected.txt:
      * storage/indexeddb/index-cursor-expected.txt:
      * storage/indexeddb/index-duplicate-keypaths-expected.txt:
      * storage/indexeddb/index-get-key-argument-required-expected.txt:
      * storage/indexeddb/index-multientry-expected.txt:
      * storage/indexeddb/index-population-expected.txt:
      * storage/indexeddb/index-unique-expected.txt:
      * storage/indexeddb/intversion-and-setversion-expected.txt:
      * storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt:
      * storage/indexeddb/intversion-long-queue-expected.txt:
      * storage/indexeddb/invalid-keys-expected.txt:
      * storage/indexeddb/key-generator-expected.txt:
      * storage/indexeddb/key-sort-order-across-types-expected.txt:
      * storage/indexeddb/key-sort-order-date-expected.txt:
      * storage/indexeddb/key-type-array-expected.txt:
      * storage/indexeddb/key-type-infinity-expected.txt:
      * storage/indexeddb/keypath-arrays-expected.txt:
      * storage/indexeddb/keypath-basics-expected.txt:
      * storage/indexeddb/keypath-edges-expected.txt:
      * storage/indexeddb/keypath-fetch-key-expected.txt:
      * storage/indexeddb/keypath-intrinsic-properties-expected.txt:
      * storage/indexeddb/lazy-index-population-expected.txt:
      * storage/indexeddb/legacy-constants-expected.txt:
      * storage/indexeddb/list-ordering-expected.txt:
      * storage/indexeddb/metadata-expected.txt:
      * storage/indexeddb/mozilla/add-twice-failure-expected.txt:
      * storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
      * storage/indexeddb/mozilla/bad-keypath-expected.txt:
      * storage/indexeddb/mozilla/clear-expected.txt:
      * storage/indexeddb/mozilla/create-index-unique-expected.txt:
      * storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
      * storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
      * storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
      * storage/indexeddb/mozilla/cursor-mutation-expected.txt:
      * storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
      * storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
      * storage/indexeddb/mozilla/cursors-expected.txt:
      * storage/indexeddb/mozilla/delete-result-expected.txt:
      * storage/indexeddb/mozilla/event-source-expected.txt:
      * storage/indexeddb/mozilla/global-data-expected.txt:
      * storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
      * storage/indexeddb/mozilla/indexes-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
      * storage/indexeddb/mozilla/object-cursors-expected.txt:
      * storage/indexeddb/mozilla/object-identity-expected.txt:
      * storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
      * storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
      * storage/indexeddb/mozilla/objectstorenames-expected.txt:
      * storage/indexeddb/mozilla/odd-result-order-expected.txt:
      * storage/indexeddb/mozilla/put-get-values-expected.txt:
      * storage/indexeddb/mozilla/readonly-transactions-expected.txt:
      * storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
      * storage/indexeddb/mozilla/readyState-expected.txt:
      * storage/indexeddb/mozilla/remove-index-expected.txt:
      * storage/indexeddb/mozilla/remove-objectstore-expected.txt:
      * storage/indexeddb/mozilla/versionchange-abort-expected.txt:
      * storage/indexeddb/mozilla/versionchange-expected.txt:
      * storage/indexeddb/mutating-cursor-expected.txt:
      * storage/indexeddb/noblobs-expected.txt:
      * storage/indexeddb/objectStore-required-arguments-expected.txt:
      * storage/indexeddb/objectstore-autoincrement-expected.txt:
      * storage/indexeddb/objectstore-basics-expected.txt:
      * storage/indexeddb/objectstore-basics-workers-expected.txt:
      * storage/indexeddb/objectstore-clear-expected.txt:
      * storage/indexeddb/objectstore-count-expected.txt:
      * storage/indexeddb/objectstore-cursor-expected.txt:
      * storage/indexeddb/objectstore-removeobjectstore-expected.txt:
      * storage/indexeddb/odd-strings-expected.txt:
      * storage/indexeddb/open-close-version-expected.txt:
      * storage/indexeddb/open-cursor-expected.txt:
      * storage/indexeddb/open-during-transaction-expected.txt:
      * storage/indexeddb/opencursor-key-expected.txt:
      * storage/indexeddb/pending-activity-expected.txt:
      * storage/indexeddb/pending-activity-workers-expected.txt:
      * storage/indexeddb/pending-version-change-on-exit-expected.txt:
      * storage/indexeddb/persistence-expected.txt:
      * storage/indexeddb/prefetch-bugfix-108071-expected.txt:
      * storage/indexeddb/queued-commands-expected.txt:
      * storage/indexeddb/readonly-expected.txt:
      * storage/indexeddb/readonly-properties-expected.txt:
      * storage/indexeddb/request-continue-abort-expected.txt:
      * storage/indexeddb/request-event-propagation-expected.txt:
      * storage/indexeddb/setVersion-null-expected.txt:
      * storage/indexeddb/set_version_blocked-expected.txt:
      * storage/indexeddb/set_version_queue-expected.txt:
      * storage/indexeddb/structured-clone-expected.txt:
      * storage/indexeddb/three-setversion-calls-expected.txt:
      * storage/indexeddb/transaction-abort-expected.txt:
      * storage/indexeddb/transaction-active-flag-expected.txt:
      * storage/indexeddb/transaction-after-close-expected.txt:
      * storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
      * storage/indexeddb/transaction-basics-expected.txt:
      * storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt:
      * storage/indexeddb/transaction-complete-with-js-recursion-expected.txt:
      * storage/indexeddb/transaction-complete-workers-expected.txt:
      * storage/indexeddb/transaction-crash-on-abort-expected.txt:
      * storage/indexeddb/transaction-error-expected.txt:
      * storage/indexeddb/transaction-event-propagation-expected.txt:
      * storage/indexeddb/transaction-read-only-expected.txt:
      * storage/indexeddb/transaction-rollback-expected.txt:
      * storage/indexeddb/transaction-storeNames-required-expected.txt:
      * storage/indexeddb/tutorial-expected.txt:
      * storage/indexeddb/two-version-changes-expected.txt:
      * storage/indexeddb/value-undefined-expected.txt:
      * storage/indexeddb/values-odd-types-expected.txt:
      * storage/indexeddb/version-change-abort-expected.txt:
      * storage/indexeddb/version-change-exclusive-expected.txt:
      * storage/indexeddb/versionchangerequest-activedomobject-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd3fc72f
    • achicu@adobe.com's avatar
      [CSS Shaders] Refactor FECustomFilter to make it usable from platform dependent implementations · bd6e70c5
      achicu@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96801
      
      Reviewed by Dean Jackson.
      
      I've refactored the FECustomFilter to allow FECustomFilterSkia.cpp to use the rendering part
      from outside.
      
      Also removed the Texture class as it is not available on some platforms.
      
      The changes for Skia will land in a different patch:
      https://bugs.webkit.org/show_bug.cgi?id=96579
      
      No new tests, the existing custom filters tests should already cover this.
      
      * platform/graphics/filters/CustomFilterGlobalContext.cpp:
      (WebCore::CustomFilterGlobalContext::prepareContextIfNeeded):
      * platform/graphics/filters/FECustomFilter.cpp:
      (WebCore::FECustomFilter::FECustomFilter):
      (WebCore::FECustomFilter::deleteRenderBuffers):
      (WebCore::FECustomFilter::drawFilterMesh):
      (WebCore):
      (WebCore::FECustomFilter::prepareForDrawing):
      (WebCore::FECustomFilter::programNeedsInputTexture):
      (WebCore::FECustomFilter::applyShader):
      (WebCore::FECustomFilter::initializeContext):
      (WebCore::FECustomFilter::ensureInputTexture):
      (WebCore::FECustomFilter::uploadInputTexture):
      (WebCore::FECustomFilter::ensureFrameBuffer):
      (WebCore::FECustomFilter::resizeContextIfNeeded):
      (WebCore::FECustomFilter::resizeContext):
      (WebCore::FECustomFilter::bindProgramAndBuffers):
      * platform/graphics/filters/FECustomFilter.h:
      (FECustomFilter):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd6e70c5
    • ojan@chromium.org's avatar
      Comment out bug URL. This fixes a lint warning. · 6211ccfd
      ojan@chromium.org authored
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6211ccfd
    • ojan@chromium.org's avatar
      Update all the MISSING lines in chromium's TestExpectations. · 2c9525af
      ojan@chromium.org authored
      If the test always passed, removed the line. In some cases, they just needed
      obvious rebaselines. In others, they haven't reported MISSING in the past
      500 runs on the bots, so removed that expectation.
      
      * platform/chromium-linux-x86/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
      * platform/chromium-linux-x86/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
      * platform/chromium-linux/css3/masking/clip-path-circle-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-circle-filter-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-circle-overflow-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-ellipse-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-polygon-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
      * platform/chromium-linux/css3/masking/clip-path-rectangle-expected.png: Added.
      * platform/chromium-linux/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
      * platform/chromium-linux/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
      * platform/chromium-linux/fast/overflow/paged-x-with-column-gap-expected.png: Added.
      * platform/chromium-linux/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
      * platform/chromium-linux/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/overflow/paged-x-with-column-gap-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-circle-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-circle-filter-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-circle-overflow-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-ellipse-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-polygon-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
      * platform/chromium-mac/css3/masking/clip-path-rectangle-expected.png: Added.
      * platform/chromium-mac/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
      * platform/chromium-mac/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
      * platform/chromium-mac/fast/overflow/paged-x-with-column-gap-expected.png: Added.
      * platform/chromium-win-xp/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
      * platform/chromium-win-xp/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
      * platform/chromium-win/css3/masking/clip-path-circle-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-circle-filter-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-circle-overflow-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-circle-overflow-hidden-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-circle-relative-overflow-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-ellipse-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-polygon-evenodd-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-polygon-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-polygon-nonzero-expected.png: Added.
      * platform/chromium-win/css3/masking/clip-path-rectangle-expected.png: Added.
      * platform/chromium-win/fast/frames/iframe-scaling-with-scroll-expected.png: Added.
      * platform/chromium-win/fast/overflow/paged-x-div-with-column-gap-expected.png: Added.
      * platform/chromium-win/fast/overflow/paged-x-div-with-column-gap-expected.txt: Added.
      * platform/chromium-win/fast/overflow/paged-x-with-column-gap-expected.png: Added.
      * platform/chromium-win/fast/overflow/paged-x-with-column-gap-expected.txt: Added.
      * platform/chromium-win/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png: Added.
      * platform/chromium-win/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt: Added.
      * platform/chromium/TestExpectations:
      * platform/chromium/perf/nested-combined-selectors-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c9525af
    • ap@apple.com's avatar
      [WK2] webarchive/loading/javascript-url-iframe-crash.html fails · e4d7ad10
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=96817
      
              Reviewed by Kenneth Rohde Christiansen.
      
              * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
              (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
              got overlooked when adding logging elsewhere.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4d7ad10
    • ap@apple.com's avatar
      REGRESSION(r126717): It made inspector/styles/media-queries.html fail/flakey · 763a19de
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=95070
      
              Roll out r126717, and another change that depends on it.
              r126717: Remove parent pointer from StyleSheetContents and StyleRuleImport
              r127123: Cache and share parsed imported stylesheets
      
              * css/CSSImportRule.cpp:
              * css/CSSImportRule.h:
              * css/CSSStyleSheet.cpp:
              (WebCore::CSSStyleSheet::willMutateRules):
              (WebCore::CSSStyleSheet::reattachChildRuleCSSOMWrappers):
              (WebCore::CSSStyleSheet::insertRule):
              (WebCore::CSSStyleSheet::ownerDocument):
              * css/CSSStyleSheet.h:
              (WebCore::CSSStyleSheet::clearOwnerRule):
              * css/StyleRuleImport.cpp:
              (WebCore::StyleRuleImport::StyleRuleImport):
              (WebCore::StyleRuleImport::~StyleRuleImport):
              (WebCore::StyleRuleImport::setCSSStyleSheet):
              (WebCore::StyleRuleImport::isLoading):
              (WebCore::StyleRuleImport::requestStyleSheet):
              * css/StyleRuleImport.h:
              (WebCore::StyleRuleImport::parentStyleSheet):
              (WebCore::StyleRuleImport::setParentStyleSheet):
              (WebCore::StyleRuleImport::clearParentStyleSheet):
              (ImportedStyleSheetClient):
              (WebCore::StyleRuleImport::ImportedStyleSheetClient::ImportedStyleSheetClient):
              (WebCore::StyleRuleImport::ImportedStyleSheetClient::~ImportedStyleSheetClient):
              (WebCore::StyleRuleImport::ImportedStyleSheetClient::setCSSStyleSheet):
              * css/StyleSheetContents.cpp:
              (WebCore::StyleSheetContents::StyleSheetContents):
              (WebCore::StyleSheetContents::isCacheable):
              (WebCore::StyleSheetContents::parserAppendRule):
              (WebCore::StyleSheetContents::clearRules):
              (WebCore::StyleSheetContents::wrapperInsertRule):
              (WebCore::StyleSheetContents::wrapperDeleteRule):
              (WebCore::StyleSheetContents::parseAuthorStyleSheet):
              (WebCore::StyleSheetContents::parseStringAtLine):
              (WebCore::StyleSheetContents::checkLoaded):
              (WebCore::StyleSheetContents::notifyLoadedSheet):
              (WebCore::StyleSheetContents::startLoadingDynamicSheet):
              (WebCore::StyleSheetContents::rootStyleSheet):
              (WebCore::StyleSheetContents::singleOwnerNode):
              (WebCore::StyleSheetContents::singleOwnerDocument):
              (WebCore::StyleSheetContents::parentStyleSheet):
              * css/StyleSheetContents.h:
              (WebCore::StyleSheetContents::create):
              (StyleSheetContents):
              (WebCore::StyleSheetContents::ownerRule):
              (WebCore::StyleSheetContents::clearOwnerRule):
              * dom/ProcessingInstruction.cpp:
              (WebCore::ProcessingInstruction::parseStyleSheet):
              * dom/StyleElement.cpp:
              (WebCore::StyleElement::createSheet):
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::setCSSStyleSheet):
              * loader/cache/CachedCSSStyleSheet.cpp:
              (WebCore::CachedCSSStyleSheet::saveParsedStyleSheet):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      763a19de
    • commit-queue@webkit.org's avatar
      [EFL] RefPtr<Evas_Object> unit tests fails · a8149ebf
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96809
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14
      Reviewed by Kenneth Rohde Christiansen.
      
      Added missing return.
      
      * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
      (EWK2UnitTest::EWK2UnitTestBase::canvas):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8149ebf
    • ojan@chromium.org's avatar
      Complete forgotten rebaseline. See https://bugs.webkit.org/show_bug.cgi?id=96751. · 1add1d00
      ojan@chromium.org authored
      The results all look like they pass.
      
      * platform/chromium-linux/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
      * platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
      * platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
      * platform/chromium/TestExpectations:
      * platform/chromium/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1add1d00
    • ojan@chromium.org's avatar
      Complete some forgotten rebaselines. See https://bugs.webkit.org/show_bug.cgi?id=94916. · 2d098aef
      ojan@chromium.org authored
      All the differences were anti-aliasing/form-controls.
      
      * platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
      * platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
      * platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
      * platform/chromium-mac-snowleopard/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
      * platform/chromium-win-xp/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Removed.
      * platform/chromium-win/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
      * platform/chromium-win/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
      * platform/chromium-win/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d098aef
    • ojan@chromium.org's avatar
      Simplify some code in RenderBox::computePercentageLogicalHeight · 106981c2
      ojan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96704
      
      Reviewed by Tony Chang.
      
      This is strictly code cleanup. No behavior change.
      Also removed some comments that were what comments and/or were
      getting stale.
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::skipContainingBlockForPercentHeightCalculation):
      (WebCore):
      (WebCore::RenderBox::computePercentageLogicalHeight):
      * rendering/RenderBox.h:
      (RenderBox):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      106981c2
    • peter@chromium.org's avatar
      [Chromium] Build fix for DumpRenderTree following r128628 · 439dffb1
      peter@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96808
      
      Reviewed by Tony Chang.
      
      When building DumpRenderTree from the Chromium project, a compile error
      shows up because including the header ForwardIOStreamsAndroid.h cannot
      be located. TestWebKitAPI does this correctly.
      
      * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      439dffb1
    • danakj@chromium.org's avatar
      Change cc-bugs@google.com watchlist to cc-bugs@chromium.org · 04bbffca
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96805
      
      Reviewed by Dirk Pranke.
      
      * Scripts/webkitpy/common/config/committers.py:
      * Scripts/webkitpy/common/config/watchlist:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04bbffca
    • danakj@chromium.org's avatar
      [chromium] Add the ubercomp WebDelegatedRendererLayer · 5a473d21
      danakj@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94145
      
      Reviewed by Adrienne Walker.
      
      Expose a WebDelegatedRendererLayer to allow the browser compositor to
      embed such a layer in its tree. This layer will be connected to IPC
      machinery in the compositor that is yet TBD which will give a set of
      RenderPasses with DrawQuads to the impl copy of the layer.
      
      * Platform.gypi:
      * chromium/public/WebCompositorSupport.h:
      (WebKit):
      (WebKit::WebCompositorSupport::createDelegatedRendererLayer):
      (WebCompositorSupport):
      * chromium/public/WebDelegatedRendererLayer.h: Added.
      (WebKit):
      (WebDelegatedRendererLayer):
      (WebKit::WebDelegatedRendererLayer::~WebDelegatedRendererLayer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a473d21
    • tkent@chromium.org's avatar
      Unreviewed, a workaround for a mysterious crash on Apple Windows port. · 3e304c72
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96636
      
      * testing/InternalSettings.cpp:
      Touch RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled only if
      ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
      (WebCore::InternalSettings::Backup::Backup):
      (WebCore::InternalSettings::Backup::restoreTo):
      (WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
      * testing/InternalSettings.h:
      (Backup):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e304c72
    • peter@chromium.org's avatar
      [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests · 741e8122
      peter@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96687
      
      Reviewed by Tony Chang.
      
      Android's DumpRenderTree currently supports these arguments, implemented
      as part of TestShellAndroid:
      http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
      
      They're used by the layout test runner to get the STDOUT and STDERR while
      a layout test run is in process, which is a safer alternative to parsing
      all the logcat output manually. The implementation can be seen here:
      http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
      
      This patch generalizes parsing of and applying the effects of these arguments
      so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
      After this patch, this will make it possible to pull out the output-reading
      code from Android's layout test port and generalize it so it can be re-used
      in the new test-runner for the other two test suites.
      
      This has no effect when compiling and running these tests as part of Chromium
      code, which has a much more advanced test-runner that does parse complete log
      output, but also directly depends on code licensed under Apache 2.
      
      Source/WebKit/chromium:
      
      * WebKit.gypi:
      * tests/ForwardIOStreamsAndroid.cpp: Added.
      (WebKit):
      (WebKit::maybeInitIOStreamForwardingForAndroid):
      * tests/ForwardIOStreamsAndroid.h: Added.
      (WebKit):
      * tests/RunAllTests.cpp:
      (main):
      
      Tools:
      
      * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
      * DumpRenderTree/chromium/TestShellAndroid.cpp:
      (platformInit):
      * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      741e8122
    • dgrogan@chromium.org's avatar
      IndexedDB: Print console warning about setVersion · 6ad96a41
      dgrogan@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96575
      
      Reviewed by Tony Chang.
      
      Source/WebCore:
      
      setVersion has been out of the spec for almost a year but there are
      still a lot of users.
      
      We show the warning once per database object as an approximation for
      once per page.
      
      No new tests, but 150-something rebaselines.
      
      * Modules/indexeddb/IDBDatabase.cpp:
      (WebCore::IDBDatabase::IDBDatabase):
      (WebCore::IDBDatabase::setVersion):
      * Modules/indexeddb/IDBDatabase.h:
      (IDBDatabase):
      
      LayoutTests:
      
      * http/tests/inspector/indexeddb/database-data-expected.txt:
      * http/tests/inspector/indexeddb/database-structure-expected.txt:
      * http/tests/inspector/indexeddb/resources-panel-expected.txt:
      * storage/indexeddb/create-and-remove-object-store-expected.txt:
      * storage/indexeddb/create-object-store-options-expected.txt:
      * storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
      * storage/indexeddb/createObjectStore-null-name-expected.txt:
      * storage/indexeddb/cursor-added-bug-expected.txt:
      * storage/indexeddb/cursor-advance-expected.txt:
      * storage/indexeddb/cursor-continue-dir-expected.txt:
      * storage/indexeddb/cursor-continue-expected.txt:
      * storage/indexeddb/cursor-continue-validity-expected.txt:
      * storage/indexeddb/cursor-delete-expected.txt:
      * storage/indexeddb/cursor-inconsistency-expected.txt:
      * storage/indexeddb/cursor-index-delete-expected.txt:
      * storage/indexeddb/cursor-key-order-expected.txt:
      * storage/indexeddb/cursor-overloads-expected.txt:
      * storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
      * storage/indexeddb/cursor-primary-key-order-expected.txt:
      * storage/indexeddb/cursor-reverse-bug-expected.txt:
      * storage/indexeddb/cursor-skip-deleted-expected.txt:
      * storage/indexeddb/cursor-update-expected.txt:
      * storage/indexeddb/cursor-update-value-argument-required-expected.txt:
      * storage/indexeddb/cursor-value-expected.txt:
      * storage/indexeddb/data-corruption-expected.txt:
      * storage/indexeddb/database-basics-expected.txt:
      * storage/indexeddb/database-close-expected.txt:
      * storage/indexeddb/database-closepending-flag-expected.txt:
      * storage/indexeddb/database-deletepending-flag-expected.txt:
      * storage/indexeddb/delete-closed-database-object-expected.txt:
      * storage/indexeddb/delete-range-expected.txt:
      * storage/indexeddb/deleteIndex-expected.txt:
      * storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
      * storage/indexeddb/deleteObjectStore-null-name-expected.txt:
      * storage/indexeddb/deleted-objects-expected.txt:
      * storage/indexeddb/deletedatabase-transaction-expected.txt:
      * storage/indexeddb/duplicates-expected.txt:
      * storage/indexeddb/error-causes-abort-by-default-expected.txt:
      * storage/indexeddb/exception-in-event-aborts-expected.txt:
      * storage/indexeddb/exceptions-expected.txt:
      * storage/indexeddb/factory-deletedatabase-expected.txt:
      * storage/indexeddb/factory-deletedatabase-interactions-expected.txt:
      * storage/indexeddb/get-keyrange-expected.txt:
      * storage/indexeddb/index-basics-expected.txt:
      * storage/indexeddb/index-basics-workers-expected.txt:
      * storage/indexeddb/index-count-expected.txt:
      * storage/indexeddb/index-cursor-expected.txt:
      * storage/indexeddb/index-duplicate-keypaths-expected.txt:
      * storage/indexeddb/index-get-key-argument-required-expected.txt:
      * storage/indexeddb/index-multientry-expected.txt:
      * storage/indexeddb/index-population-expected.txt:
      * storage/indexeddb/index-unique-expected.txt:
      * storage/indexeddb/intversion-and-setversion-expected.txt:
      * storage/indexeddb/intversion-invalid-setversion-has-no-side-effects-expected.txt:
      * storage/indexeddb/intversion-long-queue-expected.txt:
      * storage/indexeddb/invalid-keys-expected.txt:
      * storage/indexeddb/key-generator-expected.txt:
      * storage/indexeddb/key-sort-order-across-types-expected.txt:
      * storage/indexeddb/key-sort-order-date-expected.txt:
      * storage/indexeddb/key-type-array-expected.txt:
      * storage/indexeddb/key-type-infinity-expected.txt:
      * storage/indexeddb/keypath-arrays-expected.txt:
      * storage/indexeddb/keypath-basics-expected.txt:
      * storage/indexeddb/keypath-edges-expected.txt:
      * storage/indexeddb/keypath-fetch-key-expected.txt:
      * storage/indexeddb/keypath-intrinsic-properties-expected.txt:
      * storage/indexeddb/lazy-index-population-expected.txt:
      * storage/indexeddb/legacy-constants-expected.txt:
      * storage/indexeddb/list-ordering-expected.txt:
      * storage/indexeddb/metadata-expected.txt:
      * storage/indexeddb/mozilla/add-twice-failure-expected.txt:
      * storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
      * storage/indexeddb/mozilla/bad-keypath-expected.txt:
      * storage/indexeddb/mozilla/clear-expected.txt:
      * storage/indexeddb/mozilla/create-index-unique-expected.txt:
      * storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
      * storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
      * storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
      * storage/indexeddb/mozilla/cursor-mutation-expected.txt:
      * storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
      * storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
      * storage/indexeddb/mozilla/cursors-expected.txt:
      * storage/indexeddb/mozilla/delete-result-expected.txt:
      * storage/indexeddb/mozilla/event-source-expected.txt:
      * storage/indexeddb/mozilla/global-data-expected.txt:
      * storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
      * storage/indexeddb/mozilla/indexes-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
      * storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
      * storage/indexeddb/mozilla/object-cursors-expected.txt:
      * storage/indexeddb/mozilla/object-identity-expected.txt:
      * storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
      * storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
      * storage/indexeddb/mozilla/objectstorenames-expected.txt:
      * storage/indexeddb/mozilla/odd-result-order-expected.txt:
      * storage/indexeddb/mozilla/put-get-values-expected.txt:
      * storage/indexeddb/mozilla/readonly-transactions-expected.txt:
      * storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
      * storage/indexeddb/mozilla/readyState-expected.txt:
      * storage/indexeddb/mozilla/remove-index-expected.txt:
      * storage/indexeddb/mozilla/remove-objectstore-expected.txt:
      * storage/indexeddb/mozilla/versionchange-abort-expected.txt:
      * storage/indexeddb/mozilla/versionchange-expected.txt:
      * storage/indexeddb/mutating-cursor-expected.txt:
      * storage/indexeddb/noblobs-expected.txt:
      * storage/indexeddb/objectStore-required-arguments-expected.txt:
      * storage/indexeddb/objectstore-autoincrement-expected.txt:
      * storage/indexeddb/objectstore-basics-expected.txt:
      * storage/indexeddb/objectstore-basics-workers-expected.txt:
      * storage/indexeddb/objectstore-clear-expected.txt:
      * storage/indexeddb/objectstore-count-expected.txt:
      * storage/indexeddb/objectstore-cursor-expected.txt:
      * storage/indexeddb/objectstore-removeobjectstore-expected.txt:
      * storage/indexeddb/odd-strings-expected.txt:
      * storage/indexeddb/open-close-version-expected.txt:
      * storage/indexeddb/open-cursor-expected.txt:
      * storage/indexeddb/open-during-transaction-expected.txt:
      * storage/indexeddb/opencursor-key-expected.txt:
      * storage/indexeddb/pending-activity-expected.txt:
      * storage/indexeddb/pending-activity-workers-expected.txt:
      * storage/indexeddb/pending-version-change-on-exit-expected.txt:
      * storage/indexeddb/persistence-expected.txt:
      * storage/indexeddb/prefetch-bugfix-108071-expected.txt:
      * storage/indexeddb/queued-commands-expected.txt:
      * storage/indexeddb/readonly-expected.txt:
      * storage/indexeddb/readonly-properties-expected.txt:
      * storage/indexeddb/request-continue-abort-expected.txt:
      * storage/indexeddb/request-event-propagation-expected.txt:
      * storage/indexeddb/setVersion-null-expected.txt:
      * storage/indexeddb/set_version_blocked-expected.txt:
      * storage/indexeddb/set_version_queue-expected.txt:
      * storage/indexeddb/structured-clone-expected.txt:
      * storage/indexeddb/three-setversion-calls-expected.txt:
      * storage/indexeddb/transaction-abort-expected.txt:
      * storage/indexeddb/transaction-active-flag-expected.txt:
      * storage/indexeddb/transaction-after-close-expected.txt:
      * storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
      * storage/indexeddb/transaction-basics-expected.txt:
      * storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt:
      * storage/indexeddb/transaction-complete-with-js-recursion-expected.txt:
      * storage/indexeddb/transaction-complete-workers-expected.txt:
      * storage/indexeddb/transaction-crash-on-abort-expected.txt:
      * storage/indexeddb/transaction-error-expected.txt:
      * storage/indexeddb/transaction-event-propagation-expected.txt:
      * storage/indexeddb/transaction-read-only-expected.txt:
      * storage/indexeddb/transaction-rollback-expected.txt:
      * storage/indexeddb/transaction-storeNames-required-expected.txt:
      * storage/indexeddb/tutorial-expected.txt:
      * storage/indexeddb/two-version-changes-expected.txt:
      * storage/indexeddb/value-undefined-expected.txt:
      * storage/indexeddb/values-odd-types-expected.txt:
      * storage/indexeddb/version-change-abort-expected.txt:
      * storage/indexeddb/version-change-exclusive-expected.txt:
      * storage/indexeddb/versionchangerequest-activedomobject-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ad96a41
    • michelangelo@webkit.org's avatar
      Use arrays in shaders · 0c8994e6
      michelangelo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95223
      
      Reviewed by Dean Jackson.
      
      Source/WebCore:
      
      Custom Filters' support for array() is introduced. Values within
      the array() function will be passed as uniforms to shaders.
      
      Values within array() are comma-separated; the specification will be
      updated accordingly: https://www.w3.org/Bugs/Public/show_bug.cgi?id=18839
      
      Test: css3/filters/custom/custom-filter-array.html
      
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::valueForCustomFilterArrayParameter):
      (WebCore):
      (WebCore::valueForCustomFilterParameter):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::collectMatchingRulesForList):
      * css/StyleResolver.h:
      (StyleResolver):
      * platform/graphics/filters/CustomFilterArrayParameter.h: Container for array()
      parameter values.
      (WebCore):
      (CustomFilterArrayParameter):
      (WebCore::CustomFilterArrayParameter::create):
      (WebCore::CustomFilterArrayParameter::size):
      (WebCore::CustomFilterArrayParameter::valueAt):
      (WebCore::CustomFilterArrayParameter::addValue):
      (WebCore::CustomFilterArrayParameter::blend):
      (WebCore::CustomFilterArrayParameter::operator==):
      (WebCore::CustomFilterArrayParameter::CustomFilterArrayParameter):
      * platform/graphics/filters/CustomFilterParameter.h:
      * platform/graphics/filters/FECustomFilter.cpp:
      (WebCore::FECustomFilter::bindProgramArrayParameters):
      (WebCore):
      (WebCore::FECustomFilter::bindProgramParameters):
      * platform/graphics/filters/FECustomFilter.h:
      (WebCore):
      (FECustomFilter):
      
      LayoutTests:
      
      New tests have been added for checking the correctness of array()
      within shaders.
      
      * css3/filters/custom/custom-filter-array-expected.html: Added.
      * css3/filters/custom/custom-filter-array.html: Added.
      * css3/filters/custom/custom-filter-property-computed-style-expected.txt:
      * css3/filters/custom/custom-filter-property-parsing-invalid-expected.txt:
      * css3/filters/resources/fragment-color.fs: Added.
      * css3/filters/script-tests/custom-filter-property-computed-style.js:
      * css3/filters/script-tests/custom-filter-property-parsing-invalid.js:
      * platform/chromium/css3/filters/custom/custom-filter-property-computed-style-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c8994e6
    • commit-queue@webkit.org's avatar
      Always send mouse events on pages that don't scroll even if there · 42835557
      commit-queue@webkit.org authored
      is no mouse move listener attatched.
      PR #208228
      https://bugs.webkit.org/show_bug.cgi?id=96800
      
      Patch by Genevieve Mak <gmak@rim.com> on 2012-09-14
      Reviewed by Antonio Gomes.
      
      Reviewed Internally By Antonio Gomes.
      
      * WebKitSupport/TouchEventHandler.cpp:
      (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42835557
    • zoltan@webkit.org's avatar
      check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros · a0d0994d
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96656
      
      Reviewed by Adam Barth.
      
      We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
      macros in 1 line.
      
      * Scripts/webkitpy/style/checkers/cpp.py:
      (check_style.definitions):
      (check_style): Add rule.
      * Scripts/webkitpy/style/checkers/cpp_unittest.py:
      (WebKitStyleTest.test_line_breaking): Add unittest.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0d0994d
    • commit-queue@webkit.org's avatar
      WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks · 4c837870
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57570
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-14
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebKit2:
      
      Add new didExceedDatabaseQuota callback to WKBundlePageUIClient
      and call it from WebChromeClient::exceededDatabaseQuota().
      This is needed by WebKitTestRunner to dump information about
      database callbacks.
      
      * Shared/APIClientTraits.h:
      * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::setDatabaseQuota): Call WebDatabaseManager::setQuotaForOrigin()
      with "file__0" instead of "file:///" as origin identifier. WebDatabaseManager expects
      a database identifier, not a string representation of the security origin. "file__0" is
      the string that is used as databaseIdentifier of local files. This bug was causing the
      database quota not to be set. The test cases would therefore fail due to the quota being
      0 instead of the value explicitly set.
      * WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
      (WebKit::InjectedBundlePageUIClient::didExceedDatabaseQuota):
      (WebKit):
      * WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
      (InjectedBundlePageUIClient):
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::exceededDatabaseQuota):
      
      Tools:
      
      Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
      and dump the information expected by the test cases.
      
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
      (WTR::InjectedBundle::beginTesting): Explicitly set the default
      database quota.
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
      (WTR::securityOriginToStr): New convenience function to convert
      a security origin to the string expected in test results.
      (WTR):
      (WTR::InjectedBundlePage::InjectedBundlePage):
      (WTR::InjectedBundlePage::didExceedDatabaseQuota):
      (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
      refactoring to share code with didExceedDatabaseQuota.
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
      (InjectedBundlePage):
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR::TestRunner::TestRunner):
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      (WTR::TestRunner::dumpDatabaseCallbacks):
      (WTR::TestRunner::shouldDumpDatabaseCallbacks):
      (TestRunner):
      
      LayoutTests:
      
      Unskip several test cases which require implementation of
      testRunner.dumpDatabaseCallbacks in WebKitTestRunner.
      
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c837870
    • mifenton@rim.com's avatar
      [BlackBerry] Update the minimum zoom scale when focusing an input field. · d863be30
      mifenton@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96789
      
      Reviewed by Antonio Gomes.
      
      PR 188751.
      
      Increase the minimum font fix and base it on mm instead of pixels.
      
      Reviewed Internally by Gen Mak.
      
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d863be30
    • commit-queue@webkit.org's avatar
      [EFL] Gardening of the WK2 Debug Bot failing tests · 808cdde9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96795
      
      Unreviewed EFL gardening.
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14
      
      * platform/efl-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      808cdde9
    • sergio@webkit.org's avatar
      [GTK] [WK2] Unreviewed gardening. · 89d8408a
      sergio@webkit.org authored
      Added a bunch of tests failing in the WK2 tests bot to the Skipped
      list with the proper links to each bug.
      
      * platform/gtk-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89d8408a
    • vestbo@webkit.org's avatar
      [Qt] Set force_static_libs_as_shared early enough to be caught by configure · 79dbdf13
      vestbo@webkit.org authored
      Rubber-stamped by Simon Hausmann.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79dbdf13
    • vestbo@webkit.org's avatar
      [Qt] Remove old cruft from the qmake build system · a498b0ec
      vestbo@webkit.org authored
      Rubber-stamped by Simon Hausmann.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a498b0ec
    • vestbo@webkit.org's avatar
      [Qt] Enable force_static_libs_as_shared for development · 1bd86b3b
      vestbo@webkit.org authored
      Not enabled for buildbots or production-builds (part of Qt5)
      
      Reviewed by Simon Hausmann.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bd86b3b
    • vestbo@webkit.org's avatar
      [Qt] Make force_static_libs_as_shared work on Mac OS · 8de23a30
      vestbo@webkit.org authored
      We had to move a few LIBS += around that were in the wrong place,
      and not caught when everything was just linked into the final
      QtWebKit library.
      
      Reviewed by Simon Hausmann.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8de23a30
    • commit-queue@webkit.org's avatar
      Gesture events sent to wrong node when page is scrolled · 585f6a68
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96788
      
      Patch by Rick Byers <rbyers@chromium.org> on 2012-09-14
      Reviewed by Antonio Gomes.
      
      Source/WebCore:
      
      Adjust the co-ordinate space correctly when doing hit testing for
      gesture events (as for all other event handling code here).
      
      Test: platform/chromium/plugins/gesture-events-scrolled.html
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleGestureEvent):
      
      LayoutTests:
      
      Add layout test based on gesture-events.html which tests the case when
      the document is scrolled (so that client co-ordinates don't equal page
      co-ordinates).
      * platform/chromium/plugins/gesture-events-scrolled-expected.txt: Added.
      * platform/chromium/plugins/gesture-events-scrolled.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      585f6a68
    • hausmann@webkit.org's avatar
      [Qt] Fix handling of debug/release/debug_and_release/build_all · 67066198
      hausmann@webkit.org authored
      We now pick up the defaults from Qt, in default_pre (CONFIG already
      contains the appropriate values for debug and release). We then let
      the command line arguments to qmake, or the project files themselves,
      override the configuration, and finally we sanitize the configuration
      in default_post.
      
      Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2012-09-14
      Reviewed by Simon Hausmann.
      
      * Source/api.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67066198
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Unskip test cases that are now passing · 7cff57c4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96762
      
      Unreviewed EFL gardening, unskip now passing tests.
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14
      
      * platform/efl-wk2/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cff57c4
    • commit-queue@webkit.org's avatar
      WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads · 29bba910
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=42691
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-14
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebKit2:
      
      Add WKBundleFrame private API to stop loading of a frame.
      This is needed by WebKitTestRunner to implement
      testrunner.setStopProvisionalFrameLoads.
      
      Original patch by Alexey Proskuryakov.
      
      * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
      (WKBundleFrameStopLoading):
      * WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::stopLoading):
      (WebKit):
      * WebProcess/WebPage/WebFrame.h:
      (WebFrame):
      
      Tools:
      
      Add implementation for testrunner.setStopProvisionalFrameLoads()
      in WebKitTestRunner.
      
      Original patch by Alexey Proskuryakov.
      
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
      (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR::TestRunner::TestRunner):
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      (TestRunner):
      (WTR::TestRunner::setStopProvisionalFrameLoads):
      (WTR::TestRunner::shouldStopProvisionalFrameLoads):
      
      LayoutTests:
      
      Unskip fast/loader/stop-provisional-loads.html now that WebKitTestRunner
      implements testrunner.setStopProvisionalFrameLoads().
      
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29bba910
    • hausmann@webkit.org's avatar
      Fix interpreter build · afc84378
      hausmann@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96617
      
      Patch by Kevin Funk <kevin.funk@kdab.com> on 2012-09-14
      Reviewed by Simon Hausmann.
      
      Make compile.
      
      * interpreter/Interpreter.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afc84378
    • kenneth@webkit.org's avatar
      [EFL] Add unit test for RefPtr<Evas_Object> · 3fd587b0
      kenneth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96776
      
      Reviewed by Simon Hausmann.
      
      Basic testing of the new EFL specific RefPtr type.
      
      * PlatformEfl.cmake:
      * UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
      (EWK2UnitTest::EWK2UnitTestBase::backingStore):
      (EWK2UnitTest::EWK2UnitTestBase::canvas):
      
          Add some new accessors for Ecore_Evas and Evas*.
      
      * UIProcess/API/efl/tests/test_ewk2_refptr_evas_object.cpp: Added.
      (TEST_F):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fd587b0
    • loislo@chromium.org's avatar
      Web Inspector: NMI: convert template versions of String*::reportMemoryUsage... · 0008bc53
      loislo@chromium.org authored
      Web Inspector: NMI: convert template versions of String*::reportMemoryUsage functions to normal functions.
      https://bugs.webkit.org/show_bug.cgi?id=96759
      
      Reviewed by Yury Semikhatsky.
      
      Now when MemoryInstrumentation.h is a part of WTF we can move reportMemoryUsage functions to cpp file.
      
      * wtf/text/AtomicString.cpp:
      (WTF::AtomicString::reportMemoryUsage):
      (WTF):
      * wtf/text/AtomicString.h:
      (WTF):
      (AtomicString):
      * wtf/text/StringImpl.cpp:
      (WTF::StringImpl::reportMemoryUsage):
      (WTF):
      * wtf/text/StringImpl.h:
      (WTF):
      (StringImpl):
      * wtf/text/WTFString.cpp:
      (WTF::String::reportMemoryUsage):
      (WTF):
      * wtf/text/WTFString.h:
      (WTF):
      (String):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0008bc53
    • vestbo@webkit.org's avatar
      [Qt] Move .mm file to OBJECTIVE_SOURCES · e9866ba9
      vestbo@webkit.org authored
      Reviewed by Simon Hausmann.
      
      * Target.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9866ba9
    • commit-queue@webkit.org's avatar
      [EFL] Attempt to create a theme for 0 sized element leads to assertion hit · 62681d7b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96743
      
      Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-09-14
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebCore:
      
      RenderThemeEfl was not supposed to be created for the elements with '0' size and had an assertion
      on that causing crash in debug mode.
      
      Test: fast/forms/range/slider-zero-size-crash.html
      
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore::RenderThemeEfl::ThemePartCacheEntry::create):
      
      LayoutTests:
      
      RenderThemeEfl was not supposed to be created for the elements with '0' size and had an assertion
      on that causing crash in debug mode.
      
      * fast/forms/range/slider-zero-size-crash-expected.txt: Added.
      * fast/forms/range/slider-zero-size-crash.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62681d7b
    • vestbo@webkit.org's avatar
      [Qt] Fix handling of debug/release/debug_and_release/build_all · bb5e6bef
      vestbo@webkit.org authored
      We now pick up the defaults from Qt, in default_pre (CONFIG already
      contains the appropriate values for debug and release). We then let
      the command line arguments to qmake, or the project files themselves,
      override the configuration, and finally we sanitize the configuration
      in default_post.
      
      Reviewed by Simon Hausmann.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb5e6bef
    • commit-queue@webkit.org's avatar
      [EFL] Gardening of failing tests · 98aed1f2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96646
      
      Unreviewed EFL gardening of flaky tests on wk1.
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14
      
      * platform/efl-wk1/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98aed1f2
    • commit-queue@webkit.org's avatar
      WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements · 45d63361
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=42687
      
      Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-14
      Reviewed by Kenneth Rohde Christiansen.
      
      Source/WebKit2:
      
      Implement testRunner.setTabKeyCyclesThroughElements for
      WebKitTestRunner.
      
      * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
      (WKBundleSetTabKeyCyclesThroughElements):
      * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::setTabKeyCyclesThroughElements):
      (WebKit):
      * WebProcess/InjectedBundle/InjectedBundle.h:
      (InjectedBundle):
      
      Tools:
      
      Implement testRunner.setTabKeyCyclesThroughElements for
      WebKitTestRunner.
      
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
      (WTR::InjectedBundle::beginTesting):
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR::TestRunner::setTabKeyCyclesThroughElements):
      (WTR):
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      (TestRunner):
      
      LayoutTests:
      
      fast/events/keypress-insert-tab.html is passing now on wk2. So, unskip
      in common skipped files and re-skip it on efl-wk1 until WK82864 is fixed.
      
      * platform/efl-wk1/TestExpectations:
      * platform/efl/Skipped:
      * platform/wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45d63361