1. 30 Apr, 2009 33 commits
  2. 29 Apr, 2009 7 commits
    • mrowe@apple.com's avatar
      More build fixing after r43037. · f247361a
      mrowe@apple.com authored
      * Plugins/Hosted/NetscapePluginInstanceProxy.h:
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::invoke):
      (WebKit::NetscapePluginInstanceProxy::invokeDefault):
      (WebKit::NetscapePluginInstanceProxy::construct):
      (WebKit::NetscapePluginInstanceProxy::demarshalValues):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f247361a
    • mitz@apple.com's avatar
      WebCore: · 3d9a5082
      mitz@apple.com authored
              Reviewed by Simon Fraser.
      
              - WebCore part of <rdar://problem/6609509> Select All and then Delete
                should put Mail editing back into the same state as a new message
      
              Test: editing/deleting/in-visibly-empty-root.html
      
              * WebCore.base.exp: Exported VisibleSelection::isAll(bool).
              * editing/SelectionController.h:
              (WebCore::SelectionController::isAll): Added. Calls through to
              VisibleSelection.
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::makeEditableRootEmpty): Added. Removes all children
              of the root editable element the selection is in, other than a
              placeholder. Returns true iff it did anything.
              (WebCore::TypingCommand::deleteKeyPressed): When there is only a single
              visible position in the root editable element, but it has children other
              than a placeholder, remove those children.
              * editing/TypingCommand.h:
              * editing/VisiblePosition.h:
              Added a StayInEditableContent enum and a FIXME.
              * editing/VisibleSelection.cpp:
              (WebCore::VisibleSelection::isAll): Added. Returns whether the
              selection encompasses all visible positions, either in the document or
              in the editable root.
              * editing/VisibleSelection.h:
      
      WebKit/mac:
      
              Reviewed by Simon Fraser.
      
              - WebKit part of <rdar://problem/6609509> Select All and then Delete
                should put Mail editing back into the same state as a new message
      
              * WebView/WebView.mm:
              (-[WebView _selectionIsCaret]): Added.
              (-[WebView _selectionIsAll]): Added. Returns whether the selection
              encompasses the entire document.
              * WebView/WebViewPrivate.h:
      
      LayoutTests:
      
              Reviewed by Simon Fraser.
      
              - test and updated results for <rdar://problem/6609509> Select All and
                then Delete should put Mail editing back into the same state as a new
                message
      
              * editing/deleting/in-visibly-empty-root-expected.txt: Added.
              * editing/deleting/in-visibly-empty-root.html: Added.
              * platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d9a5082
    • weinig@apple.com's avatar
      2009-04-29 Sam Weinig <sam@webkit.org> · 8b951c5d
      weinig@apple.com authored
              Another attempt to fix the windows build.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b951c5d
    • weinig@apple.com's avatar
      2009-04-29 Sam Weinig <sam@webkit.org> · e8326652
      weinig@apple.com authored
              Fix style nit.
      
              * editing/visible_units.cpp:
              (WebCore::getLeafBoxesInLogicalOrder):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8326652
    • weinig@apple.com's avatar
      2009-04-29 Sam Weinig <sam@webkit.org> · fabba890
      weinig@apple.com authored
              Try and fix the windows build.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fabba890
    • hyatt@apple.com's avatar
      2009-04-29 David Hyatt <hyatt@apple.com> · c0f8885b
      hyatt@apple.com authored
              Reviewed by Dan Bernstein.
      
              For now just drop the deferred layout on the floor, since it causes an infinite hang in mail.  Even
              trying to schedule a relayout for later leaves you in a state where you hit the needsLayout painting
              assertions.
      
              Basically what Mail is doing is crazy, and we can't support it other than to just drop the last layout
              and not do it (which is basically what was happening before).
      
              * page/FrameView.cpp:
              (WebCore::FrameView::setContentsSize):
              (WebCore::FrameView::needsLayout):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0f8885b
    • justin.garcia@apple.com's avatar
      WebCore: · 2ac9a817
      justin.garcia@apple.com authored
      2009-04-29  Douglas Davidson  <ddavidso@apple.com>
      
              Reviewed by Justin Garcia.
      
              <rdar://problem/6836921> Mail exhibits issues with text checking, e.g. menu items not always validated correctly
              
              Updates to the text checking code to enable text checking even if spellchecking is turned off 
              and fix an off-by-one error in selection handling.
      
              * editing/Editor.cpp:
              (WebCore::Editor::markMisspellingsAfterTypingToPosition):
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
              (WebCore::Editor::markMisspellingsAndBadGrammar):
              * editing/Editor.h:
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::markMisspellingsAfterTyping):
      
      WebKit/mac:
      
      2009-04-29  Douglas Davidson  <ddavidso@apple.com>
      
              Reviewed by Justin Garcia.
              
              <rdar://problem/6836921> Mail exhibits issues with text checking, e.g. menu items not always validated correctly
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]):
              (-[WebHTMLView orderFrontSubstitutionsPanel:]):
              * WebView/WebView.mm:
              (-[WebView validateUserInterfaceItemWithoutDelegate:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2ac9a817