1. 15 Apr, 2010 40 commits
    • jianli@chromium.org's avatar
      Support using FormData to send a sliced file via XHR. · d8be2d18
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=36678
      
      Reviewed by Dmitry Titov.
      
      WebCore:
      
      Tests: http/tests/local/formdata/send-form-data-with-sliced-file.html
      
      * html/Blob.h:
      (WebCore::Blob::isFile):
      * html/DOMFormData.cpp:
      (WebCore::DOMFormData::append):
      * html/File.h:
      (WebCore::File::isFile):
      * html/FormDataList.h:
      (WebCore::FormDataList::appendBlob):
      (WebCore::FormDataList::Item::Item):
      (WebCore::FormDataList::Item::blob):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::appendFormData):
      * platform/network/FormData.cpp:
      (WebCore::FormData::appendDOMFormData):
      * platform/network/mac/FormDataStreamMac.mm:
      (WebCore::closeCurrentStream):
      
      LayoutTests:
      
      Move common functionality to test sending FormData into a helper file
      so that it can be shared by FormData layout tests.
      Also move the form data testing files to a new subdirectory formdata/.
      
      * http/tests/local/formdata/resources/send-form-data-common.js: Added.
      * http/tests/local/formdata/script-tests/TEMPLATE.html: Added.
      * http/tests/local/formdata/script-tests/send-form-data-with-sliced-file.js: Added.
      * http/tests/local/formdata/script-tests/send-form-data.js: Added.
      * http/tests/local/formdata/send-form-data-expected.txt: Renamed from LayoutTests/http/tests/local/send-form-data-expected.txt.
      * http/tests/local/formdata/send-form-data-with-sliced-file-expected.txt: Added.
      * http/tests/local/formdata/send-form-data-with-sliced-file.html: Added.
      * http/tests/local/formdata/send-form-data.html: Added.
      * http/tests/local/resources/send-form-data.js: Removed.
      * http/tests/local/send-form-data.html: Removed.
      * platform/gtk/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8be2d18
    • eric@webkit.org's avatar
      2010-04-15 Zhenyao Mo <zmo@google.com> · d8853559
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization
              https://bugs.webkit.org/show_bug.cgi?id=37178
      
              * fast/canvas/webgl/point-size-expected.txt: Added.
              * fast/canvas/webgl/point-size.html: Added.
      2010-04-15  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization
              https://bugs.webkit.org/show_bug.cgi?id=37178
      
              Test: fast/canvas/webgl/point-size.html
      
              * platform/graphics/mac/GraphicsContext3DMac.cpp: Enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization.
              (WebCore::GraphicsContext3D::GraphicsContext3D):
      2010-04-15  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Must enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization
              https://bugs.webkit.org/show_bug.cgi?id=37178
      
              * src/WebGraphicsContext3DDefaultImpl.cpp: Enable GL_VERTEX_PROGRAM_POINT_SIZE during initialization.
              (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8853559
    • mrowe@apple.com's avatar
      <rdar://problem/7870651> WebDynamicScrollBarsView.h generates compile errors... · 8f419a56
      mrowe@apple.com authored
      <rdar://problem/7870651> WebDynamicScrollBarsView.h generates compile errors when included in plain Objective-C files.
      
      Reviewed by Sam Weinig.
      
      * WebView/WebDynamicScrollBarsView.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f419a56
    • weinig@apple.com's avatar
      Fix crash when trying to load an invalid URL. · 83924893
      weinig@apple.com authored
      Reviewed by Adam Roben.
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::loadURL): Use constructor for ResourceRequest
      that takes a KURL instead of the one that takes a String. The one
      that takes a string expects a valid URL.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83924893
    • eric@webkit.org's avatar
      2010-04-15 Kent Tamura <tkent@chromium.org> · 7634f5cc
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              [DRT/Chromium] Add LayoutTestHelper for Mac
              https://bugs.webkit.org/show_bug.cgi?id=37668
      
              LayouTestHelper.mm is based on webkit/tools/test_shell/mac/layout_test_helper.mm
              of Chromium.
      
              * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
              * DumpRenderTree/chromium/LayoutTestHelper.mm: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7634f5cc
    • weinig@apple.com's avatar
      Make tooltips work. Thanks Adam! · 304fe1dc
      weinig@apple.com authored
      Reviewed by Adam Roben.
      
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::toolTipChanged): Pass the WebView's HWND, not the tooltip's.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      304fe1dc
    • eric@webkit.org's avatar
      2010-04-15 Eric Uhrhane <ericu@chromium.org> · 638b891c
      eric@webkit.org authored
              Reviewed by Dmitry Titov.
      
              Add bindings for async DB API in Workers.
              https://bugs.webkit.org/show_bug.cgi?id=34992
      
              * storage/change-version-handle-reuse.html: Refactored to share code with the worker version of the test.
              * storage/change-version-handle-reuse-expected.html: Removed reference to reloading, which this test doesn't do.
              * storage/change-version-handle-reuse.js: This is the extracted shared core of the test.
              * storage/execute-sql-args.html: Refactored to share code with the worker version of the test.
              * storage/execute-sql-args.js: This is the extracted shared core of the test.
      
              These are the worker versions of the tests; they're tiny shims around shared code.
              * fast/workers/execute-sql-args-worker-expected.txt: Added.
              * fast/workers/execute-sql-args-worker.html: Added.
              * fast/workers/change-version-handle-reuse-worker-expected.txt: Added.
              * fast/workers/change-version-handle-reuse-worker.html: Added.
              This file gets included from worker database tests; it does all the boilerplate that's needed on the DOM side.
              * fast/workers/resources/database-worker-controller.js: Added.
              This file is the boilerplate for the worker side of the database tests.  It will import and run the actual test on command, and will report back completion and exceptions.
              * fast/workers/resources/database-worker.js: Added.
      2010-04-15  Eric Uhrhane  <ericu@chromium.org>
      
              Reviewed by Dmitry Titov.
      
              Add bindings for async DB API in Workers.
              https://bugs.webkit.org/show_bug.cgi?id=34992
      
              Tests: storage/change-version-handle-reuse-worker.html
                     storage/execute-sql-args-worker.html
      
              * bindings/js/JSWorkerContextCustom.cpp: Add openDatabase binding.
              (WebCore::JSWorkerContext::openDatabase):
      
              * bindings/v8/custom/V8WorkerContextCustom.cpp: Add openDatabase stub; Chromium will need work both in V8 and in the browser process before we can turn this on there.
              (WebCore::V8WorkerContext::openDatabaseCallback):
      
              Add NoStaticTables flags to all objects now shared with workers.
              * storage/Database.idl:
              * storage/SQLError.idl:
              * storage/SQLResultSet.idl:
              * storage/SQLResultSetRowList.idl:
              * storage/SQLTransaction.idl:
      
              * workers/WorkerContext.h: Add databaseExceededQuota.
              * workers/WorkerContext.cpp:
              (WebCore::WorkerContext::databaseExceededQuota): Add stub implementation for testing; you just get 5MB for now.
              (WebCore::WorkerContext::openDatabase): Remove invalid assertion.
      
              Add the IDL for the call to openDatabase.
              * workers/WorkerContext.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      638b891c
    • eric@webkit.org's avatar
      2010-04-15 Nicolas Weber <thakis@chromium.org> · 1633f6c2
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Fix drag image thumbnails for indexed images.
              https://bugs.webkit.org/show_bug.cgi?id=37621
      
              * platform/chromium/DragImageChromiumMac.cpp:
              (WebCore::scaleDragImage): Always use RGB color space.
              (WebCore::dissolveDragImageToFraction): Always use RGB color space.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1633f6c2
    • andersca@apple.com's avatar
      Fix build dependencies. · 71cd0e90
      andersca@apple.com authored
      Reviewed by Adam Roben.
      
      * WebKit2.sln:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71cd0e90
    • ap@apple.com's avatar
      Reviewed by Geoff Garen. · 2c325cd2
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=37494
              <rdar://problem/7857060> REGRESSION (r57340): fast/events/mouse-drag-from-frame-to-other-frame.html
              fails on Windows
      
              * DumpRenderTree/win/EventSender.cpp: (makeEventSender):
              * DumpRenderTree/win/EventSender.h:
              Tell EventSender if it's being created for a top frame.
              
              * DumpRenderTree/win/FrameLoadDelegate.cpp:
              (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld): We only want to reset
              EventSender machinery when a new test is loaded, not when an iframe (or just its global
              object) is created.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c325cd2
    • weinig@apple.com's avatar
      Fix Windows WebKit2 build. · 616c3782
      weinig@apple.com authored
      WebKit2: 
      
      Patch by Adam Roben <aroben@apple.com> on 2010-04-15
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::processDidExit):
      * win/WebKit2Generated.make:
      
      WebKitTools: 
      
      Patch by Adam Roben <aroben@apple.com> on 2010-04-15
      * MiniBrowser/win/MiniBrowser.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      616c3782
    • aroben@apple.com's avatar
      Export WebUserContentURLPattern from WebKit · 413784f5
      aroben@apple.com authored
      Rubber-stamped by Mark Rowe.
      
      * WebKit.exp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      413784f5
    • mitz@apple.com's avatar
      Made consecutive calls to -[WebHTMLView _beginPrintModeWithPageWidth:shrinkToFit:] work · 30969463
      mitz@apple.com authored
      without intermediate calls -[WebHTMLView _endPrintMode].
      
      Reviewed by Simon Fraser.
      
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30969463
    • cfleizach@apple.com's avatar
      Unreviewed. · 8407cf7b
      cfleizach@apple.com authored
      Layout test fix for new test that works differently on leopard v. snow leopard.
      
      AXHelp is being appended from ancestors incorrectly
      https://bugs.webkit.org/show_bug.cgi?id=37659
      
      * platform/mac/accessibility/unexpected-help-text-expected.txt:
      * platform/mac/accessibility/unexpected-help-text.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8407cf7b
    • aroben@apple.com's avatar
      Expose UserContentURLPattern as WebKit SPI · cc912cec
      aroben@apple.com authored
      Fixes <http://webkit.org/b/37354>.
      
      Reviewed by Tim Hatcher.
      
      WebCore:
      
      * WebCore.base.exp: Export UserContentURLPattern::parse, and sorted
      the file.
      
      * WebCore.xcodeproj/project.pbxproj: Marked UserContentURLPattern.h as
      "Private".
      
      * page/UserContentURLPattern.h:
      (WebCore::UserContentURLPattern::UserContentURLPattern): Added a
      default constructor.
      (WebCore::UserContentURLPattern::isValid): Added this getter.
      
      WebKit:
      
      * WebKit.xcodeproj/project.pbxproj: Add WebUserContentURLPattern.
      
      WebKit/mac:
      
      * Misc/WebUserContentURLPattern.h: Added.
      
      * Misc/WebUserContentURLPattern.mm: Added.
      (-[WebUserContentURLPattern initWithPatternString:]): Initialize
      _private and then parse the passed-in string into a
      UserContentURLPattern.
      (-[WebUserContentURLPattern dealloc]): Release _private.
      
      (-[WebUserContentURLPattern isValid]):
      (-[WebUserContentURLPattern scheme]):
      (-[WebUserContentURLPattern host]):
      (-[WebUserContentURLPattern matchesSubdomains]):
      Call through to UserContentURLPattern.
      
      WebKit/win:
      
      * Interfaces/IWebUserContentURLPattern.idl: Added.
      
      * Interfaces/WebKit.idl: Added WebUserContentURLPattern.
      
      * WebKit.vcproj/Interfaces.vcproj: Added IWebUserContentURLPattern.
      
      * WebKit.vcproj/WebKit.vcproj: Added WebUserContentURLPattern.
      
      * WebUserContentURLPattern.cpp: Added.
      (WebUserContentURLPattern::WebUserContentURLPattern):
      (WebUserContentURLPattern::~WebUserContentURLPattern):
      (WebUserContentURLPattern::createInstance):
      (WebUserContentURLPattern::AddRef):
      (WebUserContentURLPattern::Release):
      (WebUserContentURLPattern::QueryInterface):
      Standard COM implementations.
      
      (WebUserContentURLPattern::parse): Parse the string into a
      UserContentURLPattern and store it.
      
      (WebUserContentURLPattern::isValid):
      (WebUserContentURLPattern::scheme):
      (WebUserContentURLPattern::host):
      (WebUserContentURLPattern::matchesSubdomains):
      Call through to UserContentURLPattern.
      
      * WebUserContentURLPattern.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc912cec
    • ojan@chromium.org's avatar
      2010-04-15 Ojan Vafai <ojan@chromium.org> · ad36374a
      ojan@chromium.org authored
              Reviewed by Adam Barth.
      
              Include codereview issue number in patch description
              https://bugs.webkit.org/show_bug.cgi?id=37677
      
              This lets us know which rietveld issue this patch is tied to.
      
              Also, make it so that --fancy-review overrides --no-review.
      
              * Scripts/webkitpy/tool/steps/postcodereview.py:
              * Scripts/webkitpy/tool/steps/postdiff.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad36374a
    • aroben@apple.com's avatar
      Make --exit-after-n-failures work when all tests are timing out or crashing · 54b86c01
      aroben@apple.com authored
      Fixes <http://webkit.org/b/37679>.
      
      Reviewed by Jon Honeycutt.
      
      * Scripts/run-webkit-tests:
      (top level): When a test crashes or times out, break out of the main loop if
      stopRunningTestsEarlyIfNeeded returns true. Moved some code from the bottom of the main loop
      from here...
      (stopRunningTestsEarlyIfNeeded): ...to here.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54b86c01
    • ajwong@chromium.org's avatar
      Not reviewed, sheriffing. · 54644fef
      ajwong@chromium.org authored
      [Chromium] Update chromium layout tests expecataions with new baselines. Remove expectations for some tests that seem to be passing now.
      
      * platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.checksum:
      * platform/chromium-win/fast/backgrounds/svg-as-background-1-expected.png:
      * platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.checksum:
      * platform/chromium-win/fast/backgrounds/svg-as-background-3-expected.png:
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54644fef
    • weinig@apple.com's avatar
      Add WebHistoryClient support. · 9d2da683
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=37671
      
      Reviewed by Anders Carlsson.
      
      WebKit2: 
      
      Adds the following callbacks:
          didNavigateWithNavigationData
          didPerformClientRedirect
          didPerformServerRedirect
          didUpdateHistoryTitle
      
      * Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
      (WebPageProxyMessage::):
      * Shared/WebNavigationDataStore.h: Added.
      * UIProcess/API/C/WKAPICast.h:
      * UIProcess/API/C/WKBase.h:
      * UIProcess/API/C/WKNavigationData.cpp: Added.
      * UIProcess/API/C/WKNavigationData.h: Added.
      * UIProcess/API/C/WKPage.cpp:
      * UIProcess/API/C/WKPage.h:
      * UIProcess/API/C/WebKit2.h:
      * UIProcess/WebHistoryClient.cpp: Copied from UIProcess/WebUIClient.cpp.
      * UIProcess/WebHistoryClient.h: Copied from UIProcess/WebUIClient.h.
      * UIProcess/WebNavigationData.cpp: Added.
      * UIProcess/WebNavigationData.h: Added.
      * UIProcess/WebPageProxy.cpp:
      * UIProcess/WebPageProxy.h:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      * win/WebKit2.vcproj:
      
      WebKitTools: 
      
      Add HistoryClient logging.
      
      * MiniBrowser/mac/BrowserWindowController.m:
      (_didNavigateWithNavigationData):
      (_didPerformClientRedirect):
      (_didPerformServerRedirect):
      (_didUpdateHistoryTitle):
      (-[BrowserWindowController awakeFromNib]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d2da683
    • andersca@apple.com's avatar
      2010-04-15 Anders Carlsson <andersca@apple.com> · c7e9f460
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Start the mini browser in threaded mode if shift is pressed during startup.
              https://bugs.webkit.org/show_bug.cgi?id=37670
      
              * MiniBrowser/mac/AppDelegate.m:
              (-[BrowserAppDelegate init]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7e9f460
    • cfleizach@apple.com's avatar
      AXHelp is being appended from ancestors incorrectly · 8cc07b6e
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=37659
      
      Reviewed by Beth Dakin.
      
      WebCore: 
      
      Test: platform/mac/accessibility/unexpected-help-text.html
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::helpText):
      
      WebKitTools: 
      
      * DumpRenderTree/AccessibilityUIElement.cpp:
      (getHelpTextCallback):
      (AccessibilityUIElement::getJSClass):
      * DumpRenderTree/AccessibilityUIElement.h:
      * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
      (AccessibilityUIElement::helpText):
      * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      (AccessibilityUIElement::helpText):
      * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
      (AccessibilityUIElement::helpText):
      
      LayoutTests: 
      
      * platform/mac/accessibility/table-attributes-expected.txt:
      * platform/mac/accessibility/table-sections-expected.txt:
           Update tests because they were wrong. AXCells should not have their AXHelp come from the AXTable.
      * platform/mac/accessibility/unexpected-help-text-expected.txt: Added.
      * platform/mac/accessibility/unexpected-help-text.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cc07b6e
    • dpranke@chromium.org's avatar
      2010-04-15 Dirk Pranke <dpranke@chromium.org> · 7d8a58a5
      dpranke@chromium.org authored
              Reviewed by Adam Barth.
      
              Re-format run-webkit-tests to fit in 80-columns for PEP-8 compliance.
              (broken by r57463 and r57381, at least). I've also filed bug 37477
              to fix check-webkit-style to catch these things.
      
              https://bugs.webkit.org/show_bug.cgi?id=38586
      
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d8a58a5
    • dpranke@chromium.org's avatar
      2010-04-15 Dirk Pranke <dpranke@chromium.org> · 4dbf52b4
      dpranke@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Add a way to override the user-visible name for the test binary since
              some ports don't call it DumpRenderTree (e.g., Chromium Win uses
              test_shell, Chromium Mac uses TestShell) by adding a driver_name()
              method to the Port interface.
      
              https://bugs.webkit.org/show_bug.cgi?id=37631
      
              * Scripts/webkitpy/layout_tests/port/base.py:
              * Scripts/webkitpy/layout_tests/port/chromium.py:
              * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4dbf52b4
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=37669, REGRESSION: visited styles... · e38285dd
      hyatt@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=37669, REGRESSION: visited styles don't work right when only the visited path specifies
      a pseudoelement.
              
      Reviewed by Anders Carlsson.
      
      Rework the pseudo cache on RenderStyles to support nesting, i.e., a pseudo hanging off a pseudo.  The existing model gets
      confused by this concept, since it relies on a singly linked list of chained pseudo styles (instead of a Vector owned by a primary
      style).  I changed the style cache to be a Vector instead.
              
      Reworked both styleForElement and pseudoStyleForElement to resolve visited styles first, since in the pseudoStyleForElement case
      you need to do this in order to know to allocate an unvisited pseudo style even if one shouldn't normally exist.
      
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::styleForElement):
      (WebCore::CSSStyleSelector::pseudoStyleForElement):
      * dom/Element.cpp:
      (WebCore::Element::pseudoStyleCacheIsInvalid):
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::getCachedPseudoStyle):
      (WebCore::RenderStyle::addCachedPseudoStyle):
      * rendering/style/RenderStyle.h:
      (WebCore::):
      (WebCore::InheritedFlags::cachedPseudoStyles):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e38285dd
    • ajwong@chromium.org's avatar
      2010-04-15 Albert J. Wong <ajwong@chromium.org> · 53eeaefa
      ajwong@chromium.org authored
              Unreviewed, rolling out r57660.
              http://trac.webkit.org/changeset/57660
              https://bugs.webkit.org/show_bug.cgi?id=37604
      
              Broke a large number of inspector layout tests in chromium.
      
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::createInjectedScript):
              * bindings/v8/ScriptDebugServer.cpp:
              * bindings/v8/ScriptDebugServer.h:
              (WebCore::ScriptDebugServer::addListener):
              (WebCore::ScriptDebugServer::removeListener):
              (WebCore::ScriptDebugServer::setBreakpoint):
              (WebCore::ScriptDebugServer::removeBreakpoint):
              (WebCore::ScriptDebugServer::clearBreakpoints):
              (WebCore::ScriptDebugServer::setBreakpointsActivated):
              (WebCore::ScriptDebugServer::pauseOnExceptionsState):
              (WebCore::ScriptDebugServer::setPauseOnExceptionsState):
              (WebCore::ScriptDebugServer::continueProgram):
              (WebCore::ScriptDebugServer::stepIntoStatement):
              (WebCore::ScriptDebugServer::stepOverStatement):
              (WebCore::ScriptDebugServer::stepOutOfFunction):
              (WebCore::ScriptDebugServer::currentCallFrameState):
              (WebCore::ScriptDebugServer::ScriptDebugServer):
              * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::createInjectedScript):
              (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
              (WebCore::V8InjectedScriptHost::isActivationCallback):
              * inspector/front-end/InjectedScript.js:
              (injectedScriptConstructor):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
      2010-04-15  Albert J. Wong  <ajwong@chromium.org>
      
              Unreviewed, rolling out r57660.
              http://trac.webkit.org/changeset/57660
              https://bugs.webkit.org/show_bug.cgi?id=37604
      
              Broke a large number of inspector layout tests in chromium.
      
              * WebKit.gypi:
              * src/DebuggerAgent.h:
              * src/DebuggerAgentImpl.cpp:
              * src/DebuggerAgentImpl.h:
              * src/DebuggerAgentManager.cpp:
              (WebKit::DebuggerAgentManager::debugAttach):
              (WebKit::DebuggerAgentManager::debugDetach):
              (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
              * src/DebuggerAgentManager.h:
              * src/InspectorFrontendClientImpl.cpp:
              (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
              * src/js/DebuggerScript.js: Removed.
              * src/js/DevTools.js:
              (WebInspector.loaded):
              (WebInspector.UnresolvedPropertyValue):
              ():
              * src/js/DevToolsHostStub.js:
              * src/js/InspectorControllerImpl.js:
              (devtools.InspectorBackendImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53eeaefa
    • eric@webkit.org's avatar
      2010-04-15 Kent Hansen <kent.hansen@nokia.com> · 8054d390
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Mark QWebFrame::overloadedSlots autotest as expected failure
      
              https://bugs.webkit.org/show_bug.cgi?id=37319
      
              * tests/qwebframe/tst_qwebframe.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8054d390
    • dumi@chromium.org's avatar
      DatabaseTracker refactoring: remove the dependency on · fa884475
      dumi@chromium.org authored
      OriginQuotaManager from DatabaseTracker.h
      https://bugs.webkit.org/show_bug.cgi?id=31482
      
      Reviewed by Dimitri Glazkov.
      
      * storage/DatabaseTracker.cpp:
      (WebCore::DatabaseTracker::DatabaseTracker):
      (WebCore::DatabaseTracker::~DatabaseTracker):
      (WebCore::DatabaseTracker::canEstablishDatabase):
      (WebCore::DatabaseTracker::hasEntryForOrigin):
      (WebCore::DatabaseTracker::getMaxSizeForDatabase):
      (WebCore::DatabaseTracker::databaseChanged):
      (WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
      (WebCore::DatabaseTracker::fullPathForDatabase):
      (WebCore::DatabaseTracker::populateOrigins):
      (WebCore::DatabaseTracker::origins):
      (WebCore::DatabaseTracker::databaseNamesForOrigin):
      (WebCore::DatabaseTracker::addOpenDatabase):
      (WebCore::DatabaseTracker::removeOpenDatabase):
      (WebCore::DatabaseTracker::usageForOriginNoLock):
      (WebCore::DatabaseTracker::usageForOrigin):
      (WebCore::DatabaseTracker::quotaForOrigin):
      (WebCore::DatabaseTracker::setQuota):
      (WebCore::DatabaseTracker::deleteOrigin):
      (WebCore::DatabaseTracker::deleteDatabase):
      (WebCore::DatabaseTracker::deleteDatabaseFile):
      * storage/DatabaseTracker.h:
      * storage/SQLTransactionClient.cpp:
      (WebCore::SQLTransactionClient::didExecuteStatement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa884475
    • weinig@apple.com's avatar
      Remove empty file configurations. · 39cb0759
      weinig@apple.com authored
      Reviewed by Adam Roben.
      
      * win/WebKit2.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39cb0759
    • eric@webkit.org's avatar
      2010-04-15 Anton Muhin <antonm@chromium.org> · f4ca683f
      eric@webkit.org authored
              Reviewed by David Levin.
      
              [v8] mark Array.prototype.sort tests which verify if sorting is stable as passing for Chromium
              https://bugs.webkit.org/show_bug.cgi?id=37655
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4ca683f
    • eric@webkit.org's avatar
      2010-04-15 Leandro Pereira <leandro@profusion.mobi> · b828cdd1
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Add EFL port files to efl/WebCoreSupport.
              http://webkit.org/b/35918
      
              * efl/WebCoreSupport/EditorClientEfl.cpp: Added.
              * efl/WebCoreSupport/EditorClientEfl.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b828cdd1
    • eric@webkit.org's avatar
      2010-04-15 Zhenyao Mo <zmo@google.com> · 532f943e
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Several tests in fast/canvas/webgl/ failed randomly on Leopard Commit Bot
              This fixes an uninitialized variable bug and restores a glFinish call that used to be present.
              https://bugs.webkit.org/show_bug.cgi?id=36908
      
              * platform/graphics/mac/GraphicsContext3DMac.cpp:
              (WebCore::GraphicsContext3D::GraphicsContext3D): Initialize width/height to 0/0.
              (WebCore::GraphicsContext3D::prepareTexture): Restore glFinish() in every path.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      532f943e
    • tonikitoo@webkit.org's avatar
      Spatial Navigation: make hasOffscreenRect() to earlier return 'true' if... · 453ceea0
      tonikitoo@webkit.org authored
      Spatial Navigation: make hasOffscreenRect() to earlier return 'true' if absoluteClippedOverflowRect() gives an empty rect
      https://bugs.webkit.org/show_bug.cgi?id=37635
      
      Reviewed by Simon Fraser.
      Patch by Antonio Gomes <tonikitoo@webkit.org>
      
      absoluteClippedOverflowRect method of RenderObject does return an empty IntRect for offscreen nodes.
      So hasOffscreenRect method (SpatialNavigation.cpp) can safily bail out earlier in such cases.
      
      * page/SpatialNavigation.cpp:
      (WebCore::hasOffscreenRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      453ceea0
    • tonikitoo@webkit.org's avatar
      Spatial Navigation: remove unnecessery assignment in... · 03c23a7e
      tonikitoo@webkit.org authored
      Spatial Navigation: remove unnecessery assignment in updateFocusCandidateIfCloser method https://bugs.webkit.org/show_bug.cgi?id=37634
      
      Reviewed by Simon Fraser.
      Patch by Antonio Gomes <tonikitoo@webkit.org>
      
      This assignment line is not longer needed after r57061, bug that refactored all
      assignment logic to happen lines below in the method.
      
      * page/FocusController.cpp:
      (WebCore::updateFocusCandidateIfCloser):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03c23a7e
    • weinig@apple.com's avatar
      Fix WebKit2s build. Don't return temporaries. · 605078a1
      weinig@apple.com authored
      Reviewed by Anders Carlsson.
      
      * UIProcess/API/C/cf/WKStringCF.cpp:
      (WKStringCreateWithCFString):
      * UIProcess/API/C/cf/WKURLCF.cpp:
      (WKURLCreateWithCFURL):
      (WKURLCopyCFURL):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      605078a1
    • yurys@chromium.org's avatar
      2010-04-15 Yury Semikhatsky <yurys@google.com> · c958ae77
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
          
              Support basic debugging capabilities including step in/over/out in v8
              implementation of ScriptDebugServer.
      
              https://bugs.webkit.org/show_bug.cgi?id=37604
      
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::createInjectedScript):
              * bindings/v8/ScriptDebugServer.cpp:
              (WebCore::ScriptDebugServer::ScriptDebugServer):
              (WebCore::ScriptDebugServer::setDebuggerScriptSource):
              (WebCore::ScriptDebugServer::addListener):
              (WebCore::ScriptDebugServer::removeListener):
              (WebCore::ScriptDebugServer::setBreakpoint):
              (WebCore::ScriptDebugServer::removeBreakpoint):
              (WebCore::ScriptDebugServer::clearBreakpoints):
              (WebCore::ScriptDebugServer::setBreakpointsActivated):
              (WebCore::ScriptDebugServer::continueProgram):
              (WebCore::ScriptDebugServer::stepIntoStatement):
              (WebCore::ScriptDebugServer::stepOverStatement):
              (WebCore::ScriptDebugServer::stepOutOfFunction):
              (WebCore::ScriptDebugServer::currentCallFrameState):
              (WebCore::ScriptDebugServer::currentCallFrameV8):
              (WebCore::ScriptDebugServer::onV8DebugMessage):
              (WebCore::ScriptDebugServer::onV8DebugHostDispatch):
              (WebCore::ScriptDebugServer::handleV8DebugHostDispatch):
              (WebCore::ScriptDebugServer::handleV8DebugMessage):
              (WebCore::ScriptDebugServer::dispatchDidParseSource):
              (WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
              (WebCore::ScriptDebugServer::didResume):
              * bindings/v8/ScriptDebugServer.h:
              (WebCore::ScriptDebugServer::pauseOnExceptionsState):
              (WebCore::ScriptDebugServer::setPauseOnExceptionsState):
              (WebCore::ScriptDebugServer::setMessageLoopDispatchHandler):
              * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::createInjectedScript):
              (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
              (WebCore::V8InjectedScriptHost::isActivationCallback):
              * inspector/front-end/InjectedScript.js:
              (injectedScriptConstructor):
              (injectedScriptConstructor.):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
      
      2010-04-15  Yury Semikhatsky  <yurys@google.com>
      
              Reviewed by Pavel Feldman.
      
              Support basic debugging capabilities including step in/over/out in v8
              implementation of ScriptDebugServer.
      
              https://bugs.webkit.org/show_bug.cgi?id=37604
      
              * WebKit.gypi:
              * src/DebuggerAgent.h:
              * src/DebuggerAgentImpl.cpp:
              (WebKit::DebuggerAgentImpl::setDebuggerScriptSource):
              * src/DebuggerAgentImpl.h:
              * src/DebuggerAgentManager.cpp:
              (WebKit::DebuggerAgentManager::hostDispatchHandler):
              (WebKit::DebuggerAgentManager::debugAttach):
              (WebKit::DebuggerAgentManager::debugDetach):
              (WebKit::DebuggerAgentManager::setMessageLoopDispatchHandler):
              * src/DebuggerAgentManager.h:
              * src/InspectorFrontendClientImpl.cpp:
              (WebKit::InspectorFrontendClientImpl::windowObjectCleared):
              * src/js/DebuggerScript.js: Added.
              (debuggerScriptConstructor.DebuggerScript.getAfterCompileScript):
              (debuggerScriptConstructor.DebuggerScript.getScripts):
              (debuggerScriptConstructor.DebuggerScript._formatScript):
              (debuggerScriptConstructor.DebuggerScript.setBreakpoint):
              (debuggerScriptConstructor.DebuggerScript.removeBreakpoint):
              (debuggerScriptConstructor.DebuggerScript.currentCallFrame):
              (debuggerScriptConstructor.DebuggerScript.stepIntoStatement):
              (debuggerScriptConstructor.DebuggerScript.stepOverStatement):
              (debuggerScriptConstructor.DebuggerScript.stepOutOfFunction):
              (debuggerScriptConstructor.DebuggerScript.clearBreakpoints):
              (debuggerScriptConstructor.DebuggerScript.setBreakpointsActivated):
              (debuggerScriptConstructor.DebuggerScript._frameMirrorToJSCallFrame):
              (debuggerScriptConstructor.DebuggerScript._webkitToV8LineNumber):
              (debuggerScriptConstructor.DebuggerScript._v8ToWwebkitLineNumber):
              (debuggerScriptConstructor):
              * src/js/DevTools.js:
              (WebInspector.loaded):
              (.):
              ():
              * src/js/DevToolsHostStub.js:
              (.RemoteDebuggerAgentStub.prototype.setDebuggerScriptSource):
              * src/js/InspectorControllerImpl.js:
              (devtools.InspectorBackendImpl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c958ae77
    • zimmermann@webkit.org's avatar
      2010-04-15 Nikolas Zimmermann <nzimmermann@rim.com> · bf49dc51
      zimmermann@webkit.org authored
              Reviewed by Beth Dakin.
      
              RenderSVGResource <-> id mapping should be cached
              https://bugs.webkit.org/show_bug.cgi?id=37575
      
              Test: svg/custom/clip-path-id-changes.svg
      
              * rendering/RenderSVGResource.h:
              (WebCore::RenderSVGResource::RenderSVGResource):
              (WebCore::RenderSVGResource::~RenderSVGResource):
              (WebCore::RenderSVGResource::idChanged):
              (WebCore::getRenderSVGResourceById):
              * svg/SVGDocumentExtensions.cpp:
              (WebCore::SVGDocumentExtensions::addResource):
              (WebCore::SVGDocumentExtensions::removeResource):
              (WebCore::SVGDocumentExtensions::resourceById):
              * svg/SVGDocumentExtensions.h:
              * svg/SVGStyledElement.cpp:
              (WebCore::SVGStyledElement::svgAttributeChanged):
      2010-04-15  Nikolas Zimmermann  <nzimmermann@rim.com>
      
              Reviewed by Beth Dakin.
      
              RenderSVGResource <-> id mapping should be cached
              https://bugs.webkit.org/show_bug.cgi?id=37575
      
              * platform/mac/svg/custom/clip-path-id-changes-expected.checksum: Added.
              * platform/mac/svg/custom/clip-path-id-changes-expected.png: Added.
              * platform/mac/svg/custom/clip-path-id-changes-expected.txt: Added.
              * svg/custom/clip-path-id-changes.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf49dc51
    • ajwong@chromium.org's avatar
      2010-04-15 Justin Schuh <jschuh@chromium.org> · 49820426
      ajwong@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              LayoutTest breakage in V8 bindings after r57627
              https://bugs.webkit.org/show_bug.cgi?id=37660
      
              Fixes breakage of the following tests due to an error in V8 bindings for
              NamedNodeMap:
              hc_namednodemapinuseattributeerr.html
              hc_namednodemapsetnameditemreturnvalue.html
              hc_namednodemapwrongdocumenterr.html
              hc_namednodemapinvalidtype1.html
              NamedNodeMap-setNamedItem-crash.html
      
              * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
              (WebCore::V8NamedNodeMap::setNamedItemNSCallback):
              (WebCore::V8NamedNodeMap::setNamedItemCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49820426
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=37567, :first-letter inside a :visited... · c41168d0
      hyatt@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=37567, :first-letter inside a :visited link is wrong color.  Make sure
      that the pseudo style caching allows visited link styles to hang off other pseudo styles.
      
      Reviewed by Anders Carlsson.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::updateFirstLetter):
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::getCachedPseudoStyle):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c41168d0
    • tonikitoo@webkit.org's avatar
      REGRESSION(r56552): Broken scrollbars size https://bugs.webkit.org/show_bug.cgi?id=36853 · 3284231f
      tonikitoo@webkit.org authored
      Reviewed by Kenneth Christiansen and Tor Arne Vestbø.
      Patch by Antonio Gomes <tonikitoo@webkit.org>
      
      The regression was caused by r56552, which introduced a fix to bug
      webkit.org/b/21300. The bug solved an issue with the resize handle on mac,
      but did it in a way that affected all Qt platforms and thus broke the behavior
      on non-mac platforms.
      
      This patch makes the mac specific change ifdef'ed and only applied for the mac
      platform.
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::windowResizerRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3284231f
    • benm@google.com's avatar
      2010-04-15 Ben Murdoch <benm@google.com> · 90a94364
      benm@google.com authored
              Unreviewed, rolling out r57652.
              http://trac.webkit.org/changeset/57652
              https://bugs.webkit.org/show_bug.cgi?id=37609
      
              Caused a build break on Chromium Mac and Layout Test fail on
              Qt
      
              * src/WebInputEventConversion.cpp:
              (WebKit::toPlatformTouchPointState):
      2010-04-15  Ben Murdoch  <benm@google.com>
      
              Unreviewed, rolling out r57652.
              http://trac.webkit.org/changeset/57652
              https://bugs.webkit.org/show_bug.cgi?id=37609
      
              Caused a build break on Chromium Mac and Layout Test fail on
              Qt
      
              * platform/PlatformTouchPoint.h:
              (WebCore::PlatformTouchPoint::):
              * platform/qt/PlatformTouchPointQt.cpp:
              (WebCore::PlatformTouchPoint::PlatformTouchPoint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90a94364