1. 21 Jan, 2011 40 commits
    • weinig@apple.com's avatar
      Part 2 of "Cleanup Scrollbar/ScrollbarClient relationship" · d7d77c3e
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52779
      
      Reviewed by Anders Carlsson.
      
      Rename ScrollbarClient -> ScrollableArea.
      
      Source/WebCore: 
      
      - Also replaces Scrollbar::setClient with Scrollbar::disconnectFromScrollableArea
        since that was its only use case.
      
      * CMakeLists.txt:
      * GNUmakefile.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/AccessibilityScrollbar.cpp:
      (WebCore::AccessibilityScrollbar::setValue):
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
      * page/FrameView.h:
      * platform/PopupMenuClient.h:
      * platform/ScrollAnimator.cpp:
      (WebCore::ScrollAnimator::create):
      (WebCore::ScrollAnimator::ScrollAnimator):
      (WebCore::ScrollAnimator::scroll):
      (WebCore::ScrollAnimator::notityPositionChanged):
      * platform/ScrollAnimator.h:
      * platform/ScrollAnimatorWin.cpp:
      (WebCore::ScrollAnimator::create):
      (WebCore::ScrollAnimatorWin::ScrollAnimatorWin):
      (WebCore::ScrollAnimatorWin::scroll):
      * platform/ScrollAnimatorWin.h:
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::scroll):
      (WebCore::ScrollView::updateScrollbars):
      (WebCore::ScrollView::wheelEvent):
      * platform/ScrollView.h:
      * platform/ScrollableArea.cpp: Copied from WebCore/platform/ScrollbarClient.cpp.
      (WebCore::ScrollableArea::ScrollableArea):
      (WebCore::ScrollableArea::~ScrollableArea):
      (WebCore::ScrollableArea::scroll):
      (WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
      (WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation):
      (WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation):
      (WebCore::ScrollableArea::setScrollOffsetFromAnimation):
      * platform/ScrollableArea.h: Copied from WebCore/platform/ScrollbarClient.h.
      * platform/Scrollbar.cpp:
      (WebCore::Scrollbar::createNativeScrollbar):
      (WebCore::Scrollbar::Scrollbar):
      (WebCore::Scrollbar::offsetDidChange):
      (WebCore::Scrollbar::autoscrollPressedPart):
      (WebCore::Scrollbar::moveThumb):
      (WebCore::Scrollbar::mouseMoved):
      (WebCore::Scrollbar::isWindowActive):
      (WebCore::Scrollbar::invalidateRect):
      (WebCore::Scrollbar::convertToContainingView):
      (WebCore::Scrollbar::convertFromContainingView):
      * platform/Scrollbar.h:
      (WebCore::Scrollbar::disconnectFromScrollableArea):
      (WebCore::Scrollbar::scrollableArea):
      * platform/ScrollbarClient.cpp: Removed.
      * platform/ScrollbarClient.h: Removed.
      * platform/ScrollbarThemeComposite.cpp:
      * platform/chromium/FramelessScrollView.h:
      * platform/chromium/ScrollbarThemeChromium.cpp:
      (WebCore::ScrollbarThemeChromium::paintTickmarks):
      * platform/efl/ScrollbarEfl.cpp:
      (Scrollbar::createNativeScrollbar):
      (ScrollbarEfl::ScrollbarEfl):
      (scrollbarEflEdjeMessage):
      * platform/efl/ScrollbarEfl.h:
      * platform/gtk/MainFrameScrollbarGtk.cpp:
      (MainFrameScrollbarGtk::create):
      (MainFrameScrollbarGtk::MainFrameScrollbarGtk):
      (MainFrameScrollbarGtk::gtkValueChanged):
      * platform/gtk/MainFrameScrollbarGtk.h:
      * platform/mac/ScrollAnimatorMac.h:
      * platform/mac/ScrollAnimatorMac.mm:
      (WebCore::ScrollAnimator::create):
      (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
      (WebCore::ScrollAnimatorMac::scroll):
      * platform/mac/ScrollbarThemeMac.mm:
      (WebCore::ScrollbarThemeMac::paint):
      * platform/qt/ScrollbarQt.cpp:
      (WebCore::Scrollbar::contextMenu):
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenuWin::scrollToRevealSelection):
      (WebCore::PopupMenuWin::wndProc):
      * platform/win/PopupMenuWin.h:
      * platform/win/ScrollbarThemeSafari.cpp:
      (WebCore::ScrollbarThemeSafari::paintTrackBackground):
      (WebCore::ScrollbarThemeSafari::paintButton):
      (WebCore::ScrollbarThemeSafari::paintThumb):
      * platform/wx/ScrollbarThemeWx.cpp:
      (WebCore::ScrollbarThemeWx::paint):
      * rendering/RenderDataGrid.h:
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollToOffset):
      (WebCore::RenderLayer::destroyScrollbar):
      (WebCore::RenderLayer::scroll):
      * rendering/RenderLayer.h:
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
      (WebCore::RenderListBox::scroll):
      (WebCore::RenderListBox::logicalScroll):
      (WebCore::RenderListBox::setScrollTop):
      (WebCore::RenderListBox::destroyScrollbar):
      * rendering/RenderListBox.h:
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::createScrollbar):
      * rendering/RenderMenuList.h:
      * rendering/RenderScrollbar.cpp:
      (WebCore::RenderScrollbar::createCustomScrollbar):
      (WebCore::RenderScrollbar::RenderScrollbar):
      * rendering/RenderScrollbar.h:
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::createScrollbar):
      * rendering/RenderTextControlSingleLine.h:
      
      Source/WebKit/chromium: 
      
      * src/AutoFillPopupMenuClient.cpp:
      (WebKit::AutoFillPopupMenuClient::createScrollbar):
      * src/AutoFillPopupMenuClient.h:
      * src/WebScrollbarImpl.cpp:
      (WebKit::WebScrollbarImpl::WebScrollbarImpl):
      (WebKit::WebScrollbarImpl::scroll):
      (WebKit::WebScrollbarImpl::onMouseWheel):
      (WebKit::WebScrollbarImpl::onKeyDown):
      * src/WebScrollbarImpl.h:
      * tests/PopupMenuTest.cpp:
      (WebKit::TestPopupMenuClient::createScrollbar):
      
      Source/WebKit/qt: 
      
      * Api/qwebframe.cpp:
      (QWebFrame::setScrollBarValue):
      
      Source/WebKit/win: 
      
      * WebScrollBar.cpp:
      (WebScrollBar::scroll):
      * WebScrollBar.h:
      
      Source/WebKit2: 
      
      * UIProcess/win/WebPopupMenuProxyWin.cpp:
      (WebKit::WebPopupMenuProxyWin::onMouseWheel):
      (WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):
      * UIProcess/win/WebPopupMenuProxyWin.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7d77c3e
    • commit-queue@webkit.org's avatar
      2011-01-21 Sailesh Agrawal <sail@chromium.org> · ff98e4a3
      commit-queue@webkit.org authored
              Reviewed by Ryosuke Niwa.
      
              [chromium] Notify WebFrameClient when spellcheck state changes
              https://bugs.webkit.org/show_bug.cgi?id=52680
      
              * public/WebFrameClient.h:
              (WebKit::WebFrameClient::continuousSpellCheckingEnabledStateChanged):
              * src/EditorClientImpl.cpp:
              (WebKit::EditorClientImpl::toggleContinuousSpellChecking):
              * src/WebFrameImpl.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff98e4a3
    • commit-queue@webkit.org's avatar
      2011-01-21 Peter Gal <galpeter@inf.u-szeged.hu> · 8ca47cd9
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              REGRESSION(r76177): All JavaScriptCore tests fail on ARM
              https://bugs.webkit.org/show_bug.cgi?id=52814
      
              Get the approximateByteSize value before releasing the OwnPtr.
      
              * parser/JSParser.cpp:
              (JSC::JSParser::parseFunctionInfo):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ca47cd9
    • darin@apple.com's avatar
      Fix Leopard build. · 97d36822
      darin@apple.com authored
      * rendering/mathml/RenderMathMLFraction.cpp:
      (WebCore::RenderMathMLFraction::layout): Use ceilf instead of ceil.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97d36822
    • simon.fraser@apple.com's avatar
      2011-01-21 Simon Fraser <simon.fraser@apple.com> · a9ad1f49
      simon.fraser@apple.com authored
              Reviewed by Sam Weinig.
      
              GraphicsLayer should be non-copyable
              https://bugs.webkit.org/show_bug.cgi?id=52909
      
              Use WTF_MAKE_NONCOPYABLE on GraphicsLayer, and WTF_MAKE_FAST_ALLOCATED
              on that and KeyframeValueList.
      
              * platform/graphics/GraphicsLayer.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76374 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9ad1f49
    • antonm@chromium.org's avatar
      2011-01-21 Anton Muhin <antonm@chromium.org> · 3b2e204b
      antonm@chromium.org authored
              Reviewed by Nate Chapin.
      
              [v8] Properly deal with the case when conversion to string throws an exception for HTMLCollection accessors
              https://bugs.webkit.org/show_bug.cgi?id=52901
      
              * fast/dom/htmlcollection-conversion-throws-exception-expected.txt: Added.
              * fast/dom/htmlcollection-conversion-throws-exception.html: Added.
      2011-01-21  Anton Muhin  <antonm@chromium.org>
      
              Reviewed by Nate Chapin.
      
              [v8] Properly deal with the case when conversion to string throws an exception for HTMLCollection accessors
              https://bugs.webkit.org/show_bug.cgi?id=52901
      
              Test: fast/dom/htmlcollection-conversion-throws-exception.html
      
              * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
              (WebCore::getItem):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76373 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b2e204b
    • aroben@apple.com's avatar
      Separate flushing layer changes from rendering in CACFLayerTreeHost · 77cc9c57
      aroben@apple.com authored
      Old model:
        1) A change is made to a GraphicsLayer.
        2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which schedules the
           render timer.
        3) The timer fires, which calls through to CACFLayerTreeHost::render, which performs the
           flush and then renders.
      
      New model:
        1) A change is made to a GraphicsLayer.
        2) CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon is called, which tells the new
           LayerChangesFlusher singleton that this host has changes that need to be flushed.
        3) LayerChangesFlusher sets up a Windows hook that will get called on the next iteration
           of the message loop.
        4) LayerChangesFlusher's hook is called, which calls through to
           CACFLayerTreeHost::flushPendingLayerChangesNow.
        5) CACFLayerTreeHost::flushPendingLayerChangesNow schedules the render timer so the changes
           that were just flushed to the context will be rendered.
      
      When a change is made to a PlatformCALayer that doesn't have a corresponding GraphicsLayer
      (e.g., for rendering <video>), CACFLayerTreeHost::layerTreeDidChange takes care of
      scheduling the flush.
      
      This change has three advantages:
        1) Whenever we flush layer changes, we first update layout. This can cause the page to
           leave compositing mode, which in turn can cause all references to the CACFLayerTreeHost
           to be dropped. By separating flushing (and thus updating layout) from rendering, we no
           longer have to worry about this happen during rendering.
        2) The new model is much more similar to how things work on the Mac, so will hopefully
           reduce the number of platform-specific bugs.
        3) CACFLayerTreeHost::shouldRender, which was used to make sure we didn't render while a
           layout was pending, is no longer needed. It actually hasn't been needed since at least
           r75987, but removing it before now would have resulted in a crash whenever a page came
           out of compositing mode due to (1).
      
      Fixes <http://webkit.org/b/52852> Flushing layer changes and rendering are intertwined in
      CACFLayerTreeHost, but shouldn't be
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      * WebCore.vcproj/WebCore.vcproj: Added LayerChangesFlusher.
      
      * platform/graphics/ca/win/CACFLayerTreeHost.cpp: Added new #include, sorted existing
       #includes.
      (WebCore::CACFLayerTreeHost::CACFLayerTreeHost): Initialize new member.
      (WebCore::CACFLayerTreeHost::layerTreeDidChange): If we aren't already flushing changes,
      schedule a flush. Removed the call to renderSoon(), which now happens when the flush is
      finished.
      (WebCore::CACFLayerTreeHost::destroyRenderer): Cancel any pending flush we had scheduled. Also
      fixed a bug where we'd fail to clear the context's layer.
      (WebCore::CACFLayerTreeHost::render): Removed code to ask the client if we should render, which
      is no longer needed. Moved code to flush layer changes from here to
      flushPendingLayerChangesNow, which is called via the above-described mechanism.
      (WebCore::CACFLayerTreeHost::flushPendingGraphicsLayerChangesSoon): Schedule a flush. Removed
      code to schedule a render, which now happens after we've flushed.
      (WebCore::CACFLayerTreeHost::flushPendingLayerChangesNow): Added. Some of this code came from
      render(). First we flush GraphicsLayer changes from GraphicsLayers to their underlying
      PlatformCALayers, then we flush changes from PlatformCALayers to the context, then we
      schedule a render so that the changes will be rendered to the screen.
      
      * platform/graphics/ca/win/CACFLayerTreeHost.h: Removed
      CACFLayerTreeHostClient::shouldRender. Added flushPendingLayerChangesNow and
      m_isFlushingLayerChanges.
      
      * platform/graphics/ca/win/LayerChangesFlusher.cpp: Added.
      (WebCore::LayerChangesFlusher::shared):
      (WebCore::LayerChangesFlusher::LayerChangesFlusher):
      (WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon):
      (WebCore::LayerChangesFlusher::cancelPendingFlush):
      (WebCore::LayerChangesFlusher::hookCallback):
      (WebCore::LayerChangesFlusher::hookFired):
      (WebCore::LayerChangesFlusher::setHook):
      (WebCore::LayerChangesFlusher::removeHook):
      
      * platform/graphics/ca/win/LayerChangesFlusher.cpp: Added.
      (WebCore::LayerChangesFlusher::shared): Returns the singleton.
      (WebCore::LayerChangesFlusher::LayerChangesFlusher): Initialize our members.
      (WebCore::LayerChangesFlusher::flushPendingLayerChangesSoon): Add the host to the set of
      hosts with changes that need to be flushed, and set up our hook if we haven't already.
      (WebCore::LayerChangesFlusher::cancelPendingFlush): Remove the host from the set of hosts
      with changes that need to be flushed. If we have no more such hosts, remove our hook, unless
      we're currently in the process of calling out to our hosts, in which case we'll take care of
      the hook once we're done calling out.
      (WebCore::LayerChangesFlusher::hookCallback): This is the function that Windows calls when
      our hook fires. Just calls through to hookFired on the singleton.
      (WebCore::LayerChangesFlusher::hookFired): Tell all the hosts with changes that needed to be
      flushed that it's time to flush. If no hosts re-added themselves to our set during this
      process, remove our hook.
      (WebCore::LayerChangesFlusher::setHook): Calls through to ::SetWindowsHookExW.
      (WebCore::LayerChangesFlusher::removeHook): Calls through to ::UnhookWindowsHookEx.
      
      * platform/graphics/ca/win/LayerChangesFlusher.h: Added.
      
      Source/WebKit/win:
      
      Update for CACFLayerTreeHost changes
      
      * WebView.cpp:
      (WebView::paint): Changed to flush layer changes via CACFLayerTreeHost, which will call back
      to our own flushing function if needed.
      
      * WebView.h: Removed shouldRender, which is no longer used or needed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77cc9c57
    • simon.fraser@apple.com's avatar
      2011-01-21 Simon Fraser <simon.fraser@apple.com> · 9574a22e
      simon.fraser@apple.com authored
              Reviewed by Sam Weinig.
      
              Report the sized used by canvases and types arrays
              https://bugs.webkit.org/show_bug.cgi?id=52856
      
              Report the memory cost associated with canvas elements,
              and typed arrays to JavaScript as extraCost, so that it
              can figure this into its GC behavior.
      
              * bindings/js/JSArrayBufferViewHelper.h:
              (WebCore::toJSArrayBufferView): New templatized function, similar
              to getDOMObjectWrapper() but calls reportExtraMemoryCost() with
              the byteLength of the array.
      
              * bindings/js/JSFloat32ArrayCustom.cpp:
              (WebCore::toJS): Use toJSArrayBufferView.
              * bindings/js/JSInt16ArrayCustom.cpp:
              (WebCore::toJS): Use toJSArrayBufferView.
              * bindings/js/JSInt32ArrayCustom.cpp:
              (WebCore::toJS): Use toJSArrayBufferView.
              * bindings/js/JSInt8ArrayCustom.cpp:
              (WebCore::toJS): Use toJSArrayBufferView.
              * bindings/js/JSUint16ArrayCustom.cpp:
              (WebCore::toJS): Use toJSArrayBufferView.
              * bindings/js/JSUint32ArrayCustom.cpp:
              (WebCore::toJS): Use toJSArrayBufferView.
              * bindings/js/JSUint8ArrayCustom.cpp:
              (WebCore::toJS): Use toJSArrayBufferView.
      
              * html/HTMLCanvasElement.cpp:
              (WebCore::HTMLCanvasElement::createImageBuffer): Call heap.reportExtraMemoryCost()
              with the size of the canvas backing store.
      
              * html/canvas/TypedArrayBase.h:
              (WebCore::TypedArrayBase::byteLength): byteLength needs to
              be public.
      
              * platform/graphics/ImageBuffer.h: Add dataSize() method.
      
              * platform/graphics/cairo/ImageBufferCairo.cpp:
              (WebCore::ImageBuffer::dataSize): Implement dataSize().
              * platform/graphics/cg/ImageBufferCG.cpp:
              (WebCore::ImageBuffer::dataSize): Implement dataSize().
              * platform/graphics/haiku/ImageBufferHaiku.cpp:
              (WebCore::ImageBuffer::dataSize): Implement dataSize().
              * platform/graphics/qt/ImageBufferQt.cpp:
              (WebCore::ImageBuffer::dataSize): Implement dataSize().
              * platform/graphics/skia/ImageBufferSkia.cpp:
              (WebCore::ImageBuffer::dataSize): Implement dataSize().
              * platform/graphics/wince/ImageBufferWinCE.cpp:
              (WebCore::ImageBuffer::dataSize): Implement dataSize().
              * platform/graphics/wx/ImageBufferWx.cpp:
              (WebCore::ImageBuffer::dataSize): Implement dataSize().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9574a22e
    • aroben@apple.com's avatar
      Rename WKCACFLayerRenderer[Client] to CACFLayerTreeHost[Client] · d0defa32
      aroben@apple.com authored
      Also renamed a few functions and data members to match.
      
      Fixes <http://webkit.org/b/52898> WKCACFLayerRenderer sounds like a render object, but isn't
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      * WebCore.vcproj/WebCore.vcproj: Updated files' names and paths.
      
      * WebCore.vcproj/WebCoreQuartzCore.vsprops: Added platform/graphics/ca/win to the include
      path.
      
      * WebCore.vcproj/copyForwardingHeaders.cmd: Copy headers from platform/graphics/ca/win, too.
      
      * platform/graphics/ca/win/CACFLayerTreeHost.cpp: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp.
      * platform/graphics/ca/win/CACFLayerTreeHost.h: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.h.
      
      * platform/graphics/ca/win/PlatformCALayerWin.cpp:
      * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
      * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
      Updated for renames.
      
      Source/WebKit/win:
      
      Update for WKCACFLayerRenderer -> CACFLayerTreeHost rename
      
      Also renamed WebView::m_layerRenderer to WebView::m_layerTreeHost to match.
      
      * WebPreferences.cpp:
      * WebView.cpp:
      (WebView::setAcceleratedCompositing): Also made sure to remove our HWND from the layer tree
      host before we get rid of the layer tree host itself.
      * WebView.h:
      
      Source/WebKit2:
      
      Update for WKCACFLayerRenderer -> CACFLayerView rename
      
      * WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp: Just removed all the unnecessary
       #includes.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0defa32
    • xan@webkit.org's avatar
      2011-01-21 Xan Lopez <xlopez@igalia.com> · e08a35f7
      xan@webkit.org authored
              Reviewed by Martin Robinson.
      
              Remove unnecessary <stdio.h> include
              https://bugs.webkit.org/show_bug.cgi?id=52884
      
              * jit/JIT.cpp: remove unnecessary include.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e08a35f7
    • commit-queue@webkit.org's avatar
      2011-01-21 Patrick Gansterer <paroga@paroga.com> · 6e0c4d42
      commit-queue@webkit.org authored
              Original patch from François Sausset  <sausset@gmail.com>
      
              Reviewed by Darin Adler.
      
              Code cleaning in rendering/mathml/RenderMathMLFraction.cpp
              https://bugs.webkit.org/show_bug.cgi?id=52201
      
              Replace unneeded doubles by floats and remove unneeded casts.
      
              * rendering/mathml/RenderMathMLFraction.cpp:
              (WebCore::RenderMathMLFraction::paint):
              * rendering/mathml/RenderMathMLFraction.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e0c4d42
    • levin@chromium.org's avatar
      Proposal: Require cross-organizational seconds for reviewer nominations · 306fbc54
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=47597
      
      Reviewed by Darin Adler.
      
      This changes the committer/reviewer policy to require an additional
      reviewer supporting a reviewer nomination to work for a different
      company and different project affiliation from the nominee.
      
      This means reviewer nominations would require four supporting reviewers,
      one of which knows the reviewer through the community (irc, email, bugs)
      ensuring that the nominee has the open-source collaboration skills
      we so highly value here in WebKit.
      
      * coding/commit-review-policy.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      306fbc54
    • dglazkov@chromium.org's avatar
      2011-01-21 Dimitri Glazkov <dglazkov@chromium.org> · b06e5712
      dglazkov@chromium.org authored
              Reviewed by Darin Adler.
      
              REGRESSION(r73618): Clicking on a search input causes a crash.
              https://bugs.webkit.org/show_bug.cgi?id=52905
      
              * fast/dom/search-shadow-host-crash-expected.txt: Added.
              * fast/dom/search-shadow-host-crash.html: Added.
      2011-01-21  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              REGRESSION(r73618): Clicking on a search input causes a crash.
              https://bugs.webkit.org/show_bug.cgi?id=52905
      
              The problem is caused by TextControlInnerElement being used both as
              shadow root and an element in a shadow subtree. The code assumed it is
              only used as a shadow root.
      
              Since this code is all just workaround for in-progress conversion to
              new shadow DOM, I am just adding a check. This code will disappear
              completely once bug 52788 is fixed.
      
              Test: fast/dom/search-shadow-host-crash.html
      
              * dom/Node.cpp:
              (WebCore::Node::setShadowHost): Added an ASSERT for early detection
                  of attempting to stomp on the parentNode.
              * rendering/TextControlInnerElements.cpp:
              (WebCore::TextControlInnerElement::detach): Added a check to only
                  clear shadow host if we have one.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b06e5712
    • dglazkov@chromium.org's avatar
      2011-01-21 Dimitri Glazkov <dglazkov@chromium.org> · 4bfecc51
      dglazkov@chromium.org authored
              Updated slider expectations after r76147.
      
              * platform/chromium/test_expectations.txt: Removed test that will start passing.
              * platform/chromium-win/fast/forms/slider-mouse-events-expected.txt: Updated expectation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bfecc51
    • xji@chromium.org's avatar
      2011-01-21 Xiaomei Ji <xji@chromium.org> · 28bc4e4e
      xji@chromium.org authored
              Unreviewed.
      
              Rebaseline for leopard after r76319.
      
              * platform/mac-leopard/fast/dom/52776-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28bc4e4e
    • tony@chromium.org's avatar
      2011-01-21 Tony Chang <tony@chromium.org> · 9cb4c57a
      tony@chromium.org authored
              Unreviewed, updating chromium DEPS so we can pull in linux theme changes.
      
              * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cb4c57a
    • darin@apple.com's avatar
      Fix Mac build. · 09706441
      darin@apple.com authored
      * MiniBrowser/mac/BrowserWindowController.m:
      (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09706441
    • darin@apple.com's avatar
      WebKit2: Implement showModalDialog · 3ed100bb
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52855
      
      Reviewed by Dan Bernstein.
      
      Source/WebKit2: 
      
      * Shared/WebPageCreationParameters.h: Added canRunModal.
      
      * UIProcess/API/C/WKPage.h: Added a runModal function pointer to
      WKPageUIClient. Also removed a lot of redundant typedefs and added
      a new one, WKPageCallback, for callbacks without arguments or return
      values.
      
      * UIProcess/API/qt/qwkpage.cpp:
      (QWKPage::QWKPage): Added a runModal function pointer of 0.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::creationParameters): Set canRunModal
      based on return value of WebUIClient::canRunModal.
      
      * UIProcess/WebPageProxy.h: Added runModal.
      Calls WebUIClient::runModal.
      
      * UIProcess/WebPageProxy.messages.in: Added RunModal message.
      Also removed the periods from the phrases in the comments
      as Maciej requested a while back.
      
      * UIProcess/WebUIClient.cpp:
      (WebKit::WebUIClient::canRunModal): Added. Returns true or false
      based on whether a runModal function was supplied in the
      WKPageUIClient structure.
      (WebKit::WebUIClient::runModal): Added. Calls the runModal
      function from the WKPageUIClient structure.
      * UIProcess/WebUIClient.h: Declared the above functions.
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::canRunModal): Call through to WebPage.
      (WebKit::WebChromeClient::runModal): Ditto.
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage): Initialize m_canRunModal based on the
      creation parameters. Initialize m_isRunningModal to false.
      (WebKit::WebPage::close): Stop the nested run loop if we are running modal.
      (WebKit::WebPage::runModal): Send a message to ask the UI process to run
      modal and then start a nested run loop. It gets stopped when the page is closed.
      * WebProcess/WebPage/WebPage.h: Defined the canRunModal function
      and declared the runModal function.
      
      Tools: 
      
      This fixes WebKitTestRunner to compile, but more work is probably
      needed to get it to pass the tests.
      
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::runModal): Added. Calls through to the
      platform-specific version of runModal.
      (WTR::TestController::createOtherPage): Changed to be a private
      static member function so it can refer to runModal, which is
      a private static member function.
      (WTR::TestController::initialize): Pass 0 for the runModal
      function since we don't need to run the main window modal.
      I suspect this is wrong and will need to change.
      * WebKitTestRunner/TestController.h: Added declarations for
      the functions added above.
      * WebKitTestRunner/mac/TestControllerMac.mm:
      (WTR::TestController::runModal): Added. Untested implementation.
      * WebKitTestRunner/qt/TestControllerQt.cpp:
      (WTR::TestController::runModal): Added.
      * WebKitTestRunner/win/TestControllerWin.cpp:
      (WTR::TestController::runModal): Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ed100bb
    • commit-queue@webkit.org's avatar
      2011-01-21 Kenji Imasaki <imasaki@chromium.org> · f3809d85
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              remove non-flaky tests from test expectation file
              https://bugs.webkit.org/show_bug.cgi?id=52746
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3809d85
    • aroben@apple.com's avatar
      Replace some "sync compositing state" terminology with "flush pending GraphicsLayer changes" · 4b7ddcc7
      aroben@apple.com authored
      This seems to be the direction in which our code is moving. I chose "GraphicsLayer" as
      opposed to just "layer" because there are cases where we flush changes to CACFLayers that
      don't have a corresponding GraphicsLayer.
      
      Fixes <http://webkit.org/b/52894> "Sync compositing state" terminology in
      WKCACFLayerRenderer and friends is confusing
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      * platform/graphics/win/WKCACFLayerRenderer.cpp:
      (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
      (WebCore::WKCACFLayerRenderer::render):
      Updated for renames.
      
      (WebCore::WKCACFLayerRenderer::flushPendingGraphicsLayerChangesSoon): Renamed from
      syncCompositingStateSoon, and updated for other renames.
      
      * platform/graphics/win/WKCACFLayerRenderer.h: Renamed m_syncLayerChanges to
      * m_shouldFlushPendingGraphicsLayerChanges.
      (WebCore::WKCACFLayerRendererClient::flushPendingGraphicsLayerChanges): Renamed from
      syncCompositingState.
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::scheduleCompositingLayerSync): Updated for WebView changes.
      
      * WebView.cpp:
      (WebView::paint): Updated for rename.
      (WebView::flushPendingGraphicsLayerChangesSoon): Renamed from scheduleCompositingLayerSync.
      (WebView::notifySyncRequired): Updated for rename.
      (WebView::flushPendingGraphicsLayerChanges): Renamed from syncCompositingState.
      
      * WebView.h: Did the renames.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b7ddcc7
    • aroben@apple.com's avatar
      Clean up PlatformCAAnimationWin · 9b984730
      aroben@apple.com authored
      Fixes <http://webkit.org/b/52904> PlatformCAAnimationWin is leaky and inefficient
      
      Reviewed by Simon Fraser.
      
      * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
      (toCACFFillModeType):
      (fromCACFFillModeType):
      (toCACFValueFunctionType):
      (fromCACFValueFunctionType):
      Changed to take and return CFStringRefs. There's no need to convert to WebCore::String just
      so we can later convert back to CFStringRef.
      
      (toCACFTimingFunction): Fixed leaks by changing this to return a RetainPtr and adopting the
      results of CACFTimingFunctionCreate.
      (PlatformCAAnimation::PlatformCAAnimation): Changed not to needlessly roundtrip through
      WebCore::String. Also changed an ASSERT(0) to ASSERT_NOT_REACHED().
      
      (PlatformCAAnimation::setFillMode):
      (PlatformCAAnimation::setTimingFunction):
      (PlatformCAAnimation::setValueFunction):
      (PlatformCAAnimation::setTimingFunctions):
      Updated for changes to the above conversion functions.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b984730
    • commit-queue@webkit.org's avatar
      2011-01-21 Charlie Reis <creis@chromium.org> · 987fd772
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
              https://bugs.webkit.org/show_bug.cgi?id=48812
      
              Test that we avoid updating back/forward list on a canceled navigation
              if a new navigation is already in process.  Also update forward-and-cancel
              to go forward, ensuring back/forward state is reset if user clicks stop.
      
              * http/tests/navigation/back-twice-without-commit-expected.txt: Added.
              * http/tests/navigation/back-twice-without-commit.html: Added.
              * http/tests/navigation/forward-and-cancel-expected.txt:
              * http/tests/navigation/forward-and-cancel.html: Go forward after stop, not back.
              * http/tests/navigation/resources/back-twice-page-2.html: Added.
              * http/tests/navigation/resources/back-twice-page-3.html: Added.
              * http/tests/navigation/resources/forward-and-cancel-frames.html: Reduced delay.
      2011-01-21  Charlie Reis  <creis@chromium.org>
      
              Reviewed by Darin Fisher.
      
              FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
              https://bugs.webkit.org/show_bug.cgi?id=48812
      
              Most calls to stopAllLoaders now clear the history's provisional item(s).
              We can now avoid resetting the back/forward state if a new navigation
              is in progress.
      
              Test: http/tests/navigation/back-twice-without-commit.html
              Test: http/tests/navigation/forward-and-cancel.html
      
              * loader/FrameLoader.cpp:
              * loader/FrameLoader.h:
              * loader/FrameLoaderTypes.h:
              * WebCore.exp.in: Update stopAllLoaders signature.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      987fd772
    • mihaip@chromium.org's avatar
      2011-01-20 Mihai Parparita <mihaip@chromium.org> · f6cc8ed6
      mihaip@chromium.org authored
              Reviewed by Eric Seidel.
      
              [Chromium] Update expectations for compositing/geometry/limit-layer-bounds-overflow-repaint.html
              https://bugs.webkit.org/show_bug.cgi?id=52860
      
              The test hasn't had a timeout in a while, remove that expectation so
              that we can more easily see if this re-occurs.
      
              Also rebaseline for chromium-gpu-mac (it has the green as 0,128,0, just
              like chromium-gpu-win and -linux, for some reason the mac expectation
              has it as 17,128,4).
      
              * platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Removed.
              * platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Removed.
              * platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum.
              * platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png.
              * platform/chromium-gpu/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6cc8ed6
    • rniwa@webkit.org's avatar
      2011-01-21 Ryosuke Niwa <rniwa@webkit.org> · f1183874
      rniwa@webkit.org authored
              Unreviewed; Reverted the last change to the text expectation.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1183874
    • rniwa@webkit.org's avatar
      2011-01-21 Ryosuke Niwa <rniwa@webkit.org> · 77f00f66
      rniwa@webkit.org authored
              Unreviewed Chromium test expectation update.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77f00f66
    • rniwa@webkit.org's avatar
      2011-01-21 Ryosuke Niwa <rniwa@webkit.org> · ba438915
      rniwa@webkit.org authored
              Unreviewed Chromium rebaselines for 76319.
      
              * platform/chromium-linux/fast/dom/52776-expected.checksum: Added.
              * platform/chromium-linux/fast/dom/52776-expected.png: Added.
              * platform/chromium-linux/fast/dom/52776-expected.txt: Added.
              * platform/chromium-mac/fast/dom/52776-expected.checksum: Added.
              * platform/chromium-mac/fast/dom/52776-expected.png: Added.
              * platform/chromium-mac/fast/dom/52776-expected.txt: Added.
              * platform/chromium-win/fast/dom/52776-expected.checksum: Added.
              * platform/chromium-win/fast/dom/52776-expected.png: Added.
              * platform/chromium-win/fast/dom/52776-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba438915
    • tony@chromium.org's avatar
      2011-01-21 Tony Chang <tony@chromium.org> · 41456563
      tony@chromium.org authored
              Unreviewed, these tests were fixed in r76330.  Still one unknown
              failure.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41456563
    • carlosgc@webkit.org's avatar
      2011-01-21 Carlos Garcia Campos <cgarcia@igalia.com> · 2988e573
      carlosgc@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Show caps lock indicator in password fields
              https://bugs.webkit.org/show_bug.cgi?id=52878
      
              Test: manual-tests/password-caps-lock.html
      
              * platform/gtk/KeyEventGtk.cpp:
              (WebCore::PlatformKeyboardEvent::currentCapsLockState): Implement
              currentCapsLockState() using GDK API.
              * platform/gtk/RenderThemeGtk.cpp:
              (WebCore::RenderThemeGtk::paintCapsLockIndicator): Paint an icon
              in the password field when the caps lock modifier is locked.
              * platform/gtk/RenderThemeGtk.h:
      2011-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Show caps lock indicator in password fields
              https://bugs.webkit.org/show_bug.cgi?id=52878
      
              Test: manual-tests/password-caps-lock.html
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_key_release_event): Call
              capsLockStateMayHaveChanged() when caps lock key is pressed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2988e573
    • jberlin@webkit.org's avatar
      Modify the Windows-specific results after http://trac.webkit.org/changeset/76208 in order to · 955e4a72
      jberlin@webkit.org authored
      get the bots green. Unreviewed.
      https://bugs.webkit.org/show_bug.cgi?id=52557
      
      * platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
      * platform/win/fast/dom/prototype-inheritance-2-expected.txt:
      * platform/win/fast/dom/prototype-inheritance-expected.txt:
      * platform/win/fast/js/global-constructors-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      955e4a72
    • jberlin@webkit.org's avatar
      Add Windows-specific results for fast/dom/52776.html to get the bot green. Unreviewed. · 189e1c7d
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=52776
      
      * platform/win/fast/dom/52776-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      189e1c7d
    • podivilov@chromium.org's avatar
      2011-01-21 Pavel Podivilov <podivilov@chromium.org> · f949fa7f
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: move sticky breakpoints management from InspectorController to InspectorBrowserDebuggerAgent.
              https://bugs.webkit.org/show_bug.cgi?id=52874
      
              This is the first step of debugger api refactoring (see bug 52879).
              JavaScript breakpoints are still in the same list as native breakpoints and are restored by InspectorBrowserDebuggerAgent.
              The second step will be to move sticky JavaScript breakpoints to InspectorDebuggerAgent.
      
              * inspector/Inspector.idl:
              * inspector/InspectorBrowserDebuggerAgent.cpp:
              (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
              (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
              (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
              (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
              (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
              (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
              (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
              * inspector/InspectorBrowserDebuggerAgent.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::restoreInspectorStateFromCookie):
              (WebCore::InspectorController::connectFrontend):
              (WebCore::InspectorController::didCommitLoad):
              (WebCore::InspectorController::enableDebugger):
              (WebCore::InspectorController::resume):
              (WebCore::InspectorController::inspectedURL):
              * inspector/InspectorController.h:
              * inspector/InspectorState.cpp:
              (WebCore::InspectorState::InspectorState):
              * inspector/InspectorState.h:
              * inspector/front-end/BreakpointManager.js:
              (WebInspector.BreakpointManager):
              (WebInspector.BreakpointManager.prototype._saveBreakpoints):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f949fa7f
    • jknotten@chromium.org's avatar
      2011-01-21 John Knottenbelt <jknotten@chromium.org> · 5fca8891
      jknotten@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              Turn off uninitialized errors for ARM linux build.
              https://bugs.webkit.org/show_bug.cgi?id=52893
      
              Fix ARM compiler breakage.
      
              * WebCore.gyp/WebCore.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fca8891
    • mnaganov@chromium.org's avatar
      2011-01-21 Mikhail Naganov <mnaganov@chromium.org> · 8c8802b9
      mnaganov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Add layout test for the CPU profiler.
      
              This test replaces DevToolsSanityTest.TestProfilerTab from
              Chromium's interactive_ui_tests.
      
              https://bugs.webkit.org/show_bug.cgi?id=52634
      
              * inspector/cpu-profiler-profiling-expected.txt: Added.
              * inspector/cpu-profiler-profiling.html: Added.
      
      [Relanding, this time the test should work in Chromium]
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c8802b9
    • mnaganov@chromium.org's avatar
      2011-01-21 Mikhail Naganov <mnaganov@chromium.org> · 83d221f9
      mnaganov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: [Chromium] REGRESSION: Using the "Back" button
              while profiling causes renderer crash.
      
              https://bugs.webkit.org/show_bug.cgi?id=52808
      
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
              (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83d221f9
    • loislo@chromium.org's avatar
      2011-01-20 Ilya Tikhonovsky <loislo@chromium.org> · 043f7d3c
      loislo@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.
      
              There are some places in WebCore where we still using direct InspectorController calls.
              The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
              Inspector facade for WebCore.
      
              https://bugs.webkit.org/show_bug.cgi?id=52869
      
              * inspector/InspectorController.cpp:
              * inspector/InspectorController.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::addProfileImpl):
              (WebCore::InspectorInstrumentation::profilerEnabledImpl):
              (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::addProfile):
              (WebCore::InspectorInstrumentation::profilerEnabled):
              (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
              * page/Console.cpp:
              (WebCore::Console::profile):
              (WebCore::Console::profileEnd):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      043f7d3c
    • ossy@webkit.org's avatar
      Unreviewed. · 7a5a5b6f
      ossy@webkit.org authored
      [Qt] editing/selection/rtl-move-selection-right-left.html fails
      https://bugs.webkit.org/show_bug.cgi?id=52883
      
      * platform/qt/Skipped: editing/selection/rtl-move-selection-right-left.html added until fix.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a5a5b6f
    • sergio@webkit.org's avatar
      2011-01-21 Sergio Villar Senin <svillar@igalia.com> · 42aa7803
      sergio@webkit.org authored
              Unreviewed.
      
              [GTK] http/tests/security/drag-drop-same-unique-origin.html fails on bots.
              https://bugs.webkit.org/show_bug.cgi?id=52882
      
              Skipping http/tests/security/drag-drop-same-unique-origin.html for gtk.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42aa7803
    • podivilov@chromium.org's avatar
      2011-01-12 Pavel Podivilov <podivilov@chromium.org> · 2343e67d
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: breakpoints are restored incorrectly when reverting live edit.
              https://bugs.webkit.org/show_bug.cgi?id=52300
      
              Fix breakpoints restoring when reverting to old revision by using text diff.
              Move live edit logic from ScriptsPanel to DebuggerModel.
              Eliminate unnecessary editLine delegate in TextViewer.
      
              * inspector/front-end/DebuggerModel.js:
              (WebInspector.DebuggerModel):
              (WebInspector.DebuggerModel.prototype.reset):
              (WebInspector.DebuggerModel.prototype.editScriptSource):
              (WebInspector.DebuggerModel.prototype._updateScriptSource):
              (WebInspector.DebuggerModel.prototype.get callFrames):
              (WebInspector.DebuggerModel.prototype.pausedScript):
              (WebInspector.DebuggerModel.prototype.resumedScript):
              * inspector/front-end/Script.js:
              (WebInspector.Script.prototype.get source):
              * inspector/front-end/ScriptView.js:
              (WebInspector.ScriptView):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame):
              (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
              (WebInspector.SourceFrame.prototype._doubleClick.didEditLine):
              (WebInspector.SourceFrame.prototype._doubleClick):
              * inspector/front-end/SourceView.js:
              (WebInspector.SourceView):
              * inspector/front-end/TextViewer.js:
              (WebInspector.TextViewer):
              (WebInspector.TextViewer.prototype._handleKeyDown):
              (WebInspector.TextViewer.prototype.editLine.finishEditing):
              (WebInspector.TextViewer.prototype.editLine):
              (WebInspector.TextChunk.prototype._createRow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2343e67d
    • commit-queue@webkit.org's avatar
      2011-01-21 Adam Klein <adamk@chromium.org> · 4ceaac17
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              [chromium] Rename ChromiumBridge to PlatformBridge
              https://bugs.webkit.org/show_bug.cgi?id=52471
      
              No tests added as this is a rename; no change in behavior.
      
              * WebCore.gypi:
              * bindings/v8/V8DOMWindowShell.cpp:
              (WebCore::reportFatalErrorInV8):
              * page/PageGroup.cpp:
              (WebCore::PageGroup::isLinkVisited):
              * platform/android/PlatformBridge.h:
              * platform/audio/chromium/AudioBusChromium.cpp:
              (WebCore::createBusFromInMemoryAudioFile):
              * platform/chromium/ChromiumBridge.h: Removed.
              * platform/chromium/ChromiumDataObjectLegacy.cpp:
              (WebCore::ChromiumDataObjectLegacy::getData):
              * platform/chromium/DragDataChromium.cpp:
              (WebCore::DragData::asURL):
              * platform/chromium/FileSystemChromium.cpp:
              (WebCore::deleteFile):
              (WebCore::deleteEmptyDirectory):
              (WebCore::getFileSize):
              (WebCore::getFileModificationTime):
              (WebCore::revealFolderInOS):
              (WebCore::directoryName):
              (WebCore::pathByAppendingComponent):
              (WebCore::makeAllDirectories):
              (WebCore::fileExists):
              (WebCore::openFile):
              (WebCore::closeFile):
              (WebCore::seekFile):
              (WebCore::truncateFile):
              (WebCore::readFromFile):
              (WebCore::writeToFile):
              * platform/chromium/LanguageChromium.cpp:
              (WebCore::platformDefaultLanguage):
              * platform/chromium/LinkHashChromium.cpp:
              (WebCore::visitedLinkHash):
              * platform/chromium/MIMETypeRegistryChromium.cpp:
              (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
              (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
              (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
              (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
              (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
              * platform/chromium/PasteboardChromium.cpp:
              (WebCore::Pasteboard::writeSelection):
              (WebCore::Pasteboard::writePlainText):
              (WebCore::Pasteboard::writeURL):
              (WebCore::Pasteboard::writeImage):
              (WebCore::Pasteboard::canSmartReplace):
              (WebCore::Pasteboard::plainText):
              (WebCore::Pasteboard::documentFragment):
              * platform/chromium/PlatformBridge.h:
              * platform/chromium/PlatformScreenChromium.cpp:
              (WebCore::screenDepth):
              (WebCore::screenDepthPerComponent):
              (WebCore::screenIsMonochrome):
              (WebCore::screenRect):
              (WebCore::screenAvailableRect):
              * platform/chromium/ReadableDataObject.cpp:
              (WebCore::ReadableDataObject::getData):
              (WebCore::ReadableDataObject::urlTitle):
              (WebCore::ReadableDataObject::htmlBaseUrl):
              (WebCore::ReadableDataObject::filenames):
              (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
              * platform/chromium/SSLKeyGeneratorChromium.cpp:
              (WebCore::signedPublicKeyAndChallengeString):
              * platform/chromium/ScrollbarThemeChromium.cpp:
              * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
              (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
              (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
              (WebCore::ScrollbarThemeChromiumLinux::paintButton):
              (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
              (WebCore::ScrollbarThemeChromiumLinux::buttonSize):
              (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
              * platform/chromium/ScrollbarThemeChromiumMac.mm:
              (WebCore::scrollbarStateToThemeState):
              (WebCore::ScrollbarThemeChromiumMac::paint):
              * platform/chromium/ScrollbarThemeChromiumWin.cpp:
              (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
              (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
              (WebCore::ScrollbarThemeChromiumWin::paintButton):
              (WebCore::ScrollbarThemeChromiumWin::paintThumb):
              (WebCore::ScrollbarThemeChromiumWin::buttonSize):
              * platform/chromium/SharedTimerChromium.cpp:
              (WebCore::setSharedTimerFiredFunction):
              (WebCore::setSharedTimerFireTime):
              (WebCore::stopSharedTimer):
              * platform/chromium/SuddenTerminationChromium.cpp:
              (WebCore::disableSuddenTermination):
              (WebCore::enableSuddenTermination):
              * platform/chromium/SystemTimeChromium.cpp:
              (WebCore::currentTime):
              * platform/chromium/WritableDataObject.cpp:
              (WebCore::WritableDataObject::setData):
              * platform/graphics/chromium/CrossProcessFontLoading.mm:
              * platform/graphics/chromium/FontCacheChromiumWin.cpp:
              (WebCore::fontContainsCharacter):
              (WebCore::FillLogFont):
              * platform/graphics/chromium/FontCacheLinux.cpp:
              (WebCore::FontCache::getFontDataForCharacters):
              * platform/graphics/chromium/FontChromiumWin.cpp:
              (WebCore::Font::drawGlyphs):
              * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
              (WebCore::FontPlatformData::scriptFontProperties):
              * platform/graphics/chromium/FontPlatformDataLinux.cpp:
              (WebCore::FontPlatformData::querySystemForRenderStyle):
              * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
              (WebCore::fillBMPGlyphs):
              * platform/graphics/chromium/ImageChromium.cpp:
              (WebCore::Image::loadPlatformResource):
              * platform/graphics/chromium/ImageChromiumMac.mm:
              (WebCore::Image::loadPlatformResource):
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              (WebCore::SimpleFontData::platformInit):
              (WebCore::SimpleFontData::determinePitch):
              (WebCore::SimpleFontData::platformWidthForGlyph):
              * platform/graphics/chromium/UniscribeHelperTextRun.cpp:
              (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
              * platform/graphics/skia/FontCustomPlatformData.cpp:
              (WebCore::FontCustomPlatformData::fontPlatformData):
              * platform/network/chromium/CookieJarChromium.cpp:
              (WebCore::setCookies):
              (WebCore::cookies):
              (WebCore::cookieRequestHeaderFieldValue):
              (WebCore::cookiesEnabled):
              (WebCore::getRawCookies):
              (WebCore::deleteCookie):
              * platform/network/chromium/DNSChromium.cpp:
              (WebCore::prefetchDNS):
              * platform/qt/PlatformBridge.h:
              * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
              (WebCore::SQLiteFileSystem::deleteDatabaseFile):
              (WebCore::SQLiteFileSystem::getDatabaseFileSize):
              * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
              (chromiumOpen):
              (chromiumDelete):
              (chromiumAccess):
              * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
              * plugins/chromium/PluginDataChromium.cpp:
              (WebCore::PluginCache::plugins):
              * rendering/RenderThemeChromiumMac.mm:
              (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
              * rendering/RenderThemeChromiumSkia.cpp:
              (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
              (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
              (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
              (WebCore::RenderThemeChromiumWin::systemColor):
              (WebCore::RenderThemeChromiumWin::paintButton):
              (WebCore::RenderThemeChromiumWin::paintSliderTrack):
              (WebCore::menuListButtonWidth):
              (WebCore::RenderThemeChromiumWin::paintMenuList):
              (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
              (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
              (WebCore::RenderThemeChromiumWin::paintProgressBar):
              * storage/chromium/IDBFactoryBackendInterface.cpp:
              (WebCore::IDBFactoryBackendInterface::create):
              (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
              * storage/chromium/IDBKeyPathBackendImpl.cpp:
              (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
      2011-01-21  Adam Klein  <adamk@chromium.org>
      
              Reviewed by Eric Seidel.
      
              [chromium] Rename ChromiumBridge to PlatformBridge
              https://bugs.webkit.org/show_bug.cgi?id=52471
      
              * WebKit.gyp:
              * src/AssertMatchingEnums.cpp:
              * src/PlatformBridge.cpp:
              (WebCore::toChromeClientImpl):
              (WebCore::toWebWidgetClient):
              (WebCore::getCookieJar):
              (WebCore::PlatformBridge::cacheMetadata):
              (WebCore::PlatformBridge::clipboardIsFormatAvailable):
              (WebCore::PlatformBridge::clipboardReadPlainText):
              (WebCore::PlatformBridge::clipboardReadHTML):
              (WebCore::PlatformBridge::clipboardWriteSelection):
              (WebCore::PlatformBridge::clipboardWritePlainText):
              (WebCore::PlatformBridge::clipboardWriteURL):
              (WebCore::PlatformBridge::clipboardWriteImage):
              (WebCore::PlatformBridge::clipboardWriteData):
              (WebCore::PlatformBridge::clipboardReadAvailableTypes):
              (WebCore::PlatformBridge::clipboardReadData):
              (WebCore::PlatformBridge::clipboardReadFilenames):
              (WebCore::PlatformBridge::setCookies):
              (WebCore::PlatformBridge::cookies):
              (WebCore::PlatformBridge::cookieRequestHeaderFieldValue):
              (WebCore::PlatformBridge::rawCookies):
              (WebCore::PlatformBridge::deleteCookie):
              (WebCore::PlatformBridge::cookiesEnabled):
              (WebCore::PlatformBridge::prefetchDNS):
              (WebCore::PlatformBridge::fileExists):
              (WebCore::PlatformBridge::deleteFile):
              (WebCore::PlatformBridge::deleteEmptyDirectory):
              (WebCore::PlatformBridge::getFileSize):
              (WebCore::PlatformBridge::revealFolderInOS):
              (WebCore::PlatformBridge::getFileModificationTime):
              (WebCore::PlatformBridge::directoryName):
              (WebCore::PlatformBridge::pathByAppendingComponent):
              (WebCore::PlatformBridge::makeAllDirectories):
              (WebCore::PlatformBridge::getAbsolutePath):
              (WebCore::PlatformBridge::isDirectory):
              (WebCore::PlatformBridge::filePathToURL):
              (WebCore::PlatformBridge::openFile):
              (WebCore::PlatformBridge::closeFile):
              (WebCore::PlatformBridge::seekFile):
              (WebCore::PlatformBridge::truncateFile):
              (WebCore::PlatformBridge::readFromFile):
              (WebCore::PlatformBridge::writeToFile):
              (WebCore::PlatformBridge::ensureFontLoaded):
              (WebCore::PlatformBridge::getFontFamilyForCharacters):
              (WebCore::PlatformBridge::getRenderStyleForStrike):
              (WebCore::PlatformBridge::loadFont):
              (WebCore::PlatformBridge::databaseOpenFile):
              (WebCore::PlatformBridge::databaseDeleteFile):
              (WebCore::PlatformBridge::databaseGetFileAttributes):
              (WebCore::PlatformBridge::databaseGetFileSize):
              (WebCore::PlatformBridge::idbFactory):
              (WebCore::PlatformBridge::idbShutdown):
              (WebCore::PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath):
              (WebCore::PlatformBridge::signedPublicKeyAndChallengeString):
              (WebCore::PlatformBridge::computedDefaultLanguage):
              (WebCore::PlatformBridge::layoutTestMode):
              (WebCore::PlatformBridge::isSupportedImageMIMEType):
              (WebCore::PlatformBridge::isSupportedJavaScriptMIMEType):
              (WebCore::PlatformBridge::isSupportedNonImageMIMEType):
              (WebCore::PlatformBridge::mimeTypeForExtension):
              (WebCore::PlatformBridge::mimeTypeFromFile):
              (WebCore::PlatformBridge::preferredExtensionForMIMEType):
              (WebCore::PlatformBridge::plugins):
              (WebCore::PlatformBridge::pluginScriptableObject):
              (WebCore::PlatformBridge::loadPlatformImageResource):
              (WebCore::PlatformBridge::loadPlatformAudioResource):
              (WebCore::PlatformBridge::decodeAudioFileData):
              (WebCore::PlatformBridge::sandboxEnabled):
              (WebCore::PlatformBridge::setSharedTimerFiredFunction):
              (WebCore::PlatformBridge::setSharedTimerFireTime):
              (WebCore::PlatformBridge::stopSharedTimer):
              (WebCore::PlatformBridge::decrementStatsCounter):
              (WebCore::PlatformBridge::incrementStatsCounter):
              (WebCore::PlatformBridge::histogramCustomCounts):
              (WebCore::PlatformBridge::histogramEnumeration):
              (WebCore::PlatformBridge::suddenTerminationChanged):
              (WebCore::PlatformBridge::currentTime):
              (WebCore::PlatformBridge::paintButton):
              (WebCore::PlatformBridge::paintMenuList):
              (WebCore::PlatformBridge::paintScrollbarArrow):
              (WebCore::PlatformBridge::paintScrollbarThumb):
              (WebCore::PlatformBridge::paintScrollbarTrack):
              (WebCore::PlatformBridge::paintSpinButton):
              (WebCore::PlatformBridge::paintTextField):
              (WebCore::PlatformBridge::paintTrackbar):
              (WebCore::PlatformBridge::paintProgressBar):
              (WebCore::WebThemePart):
              (WebCore::WebThemeState):
              (WebCore::GetWebThemeExtraParams):
              (WebCore::PlatformBridge::getThemePartSize):
              (WebCore::PlatformBridge::paintThemePart):
              (WebCore::PlatformBridge::traceEventBegin):
              (WebCore::PlatformBridge::traceEventEnd):
              (WebCore::PlatformBridge::visitedLinkHash):
              (WebCore::PlatformBridge::isLinkVisited):
              (WebCore::PlatformBridge::notifyJSOutOfMemory):
              (WebCore::PlatformBridge::memoryUsageMB):
              (WebCore::PlatformBridge::actualMemoryUsageMB):
              (WebCore::PlatformBridge::screenDepth):
              (WebCore::PlatformBridge::screenDepthPerComponent):
              (WebCore::PlatformBridge::screenIsMonochrome):
              (WebCore::PlatformBridge::screenRect):
              (WebCore::PlatformBridge::screenAvailableRect):
              (WebCore::PlatformBridge::popupsAllowed):
              (WebCore::WorkerContextProxy::create):
              * src/ResourceHandle.cpp:
              (WebCore::ResourceHandle::cacheMetadata):
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::WebFrameImpl):
              (WebKit::WebFrameImpl::~WebFrameImpl):
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ceaac17
    • eric@webkit.org's avatar
      2011-01-21 Eric Seidel <eric@webkit.org> · 7a1babed
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Split Host object off from WebKitPatch for easier re-use
              https://bugs.webkit.org/show_bug.cgi?id=52284
      
              new-run-webkit-tests and other tools are eventually going to want one of these.
              Basically you need to inherit from this class if you want to pretend to be a
              self.tool object for Steps/Commands.
      
              * Scripts/webkitpy/common/host.py: Added.
              * Scripts/webkitpy/tool/main.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a1babed