1. 20 May, 2010 40 commits
    • eric@webkit.org's avatar
      2010-05-20 Zhenyao Mo <zmo@google.com> · d687633b
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
              https://bugs.webkit.org/show_bug.cgi?id=39077
      
              * fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Add the test cases for color renderbuffer creation and attachment to framebuffer.
              * fast/canvas/webgl/framebuffer-object-attachment.html: Ditto.
      2010-05-20  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
              https://bugs.webkit.org/show_bug.cgi?id=39077
      
              * platform/graphics/mac/GraphicsContext3DMac.cpp:
              (WebCore::GraphicsContext3D::renderbufferStorage): Mapping the enums.
      2010-05-20  Zhenyao Mo  <zmo@google.com>
      
              Reviewed by Dimitri Glazkov.
      
              Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
              https://bugs.webkit.org/show_bug.cgi?id=39077
      
              * src/WebGraphicsContext3DDefaultImpl.cpp:
              (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage): Mapping the enums.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59888 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d687633b
    • mitz@apple.com's avatar
      <rdar://problem/8007953> Textarea using custom font appears blank · 55bf8727
      mitz@apple.com authored
      Reviewed by Dave Hyatt.
      
      WebCore: 
      
      Test: fast/css/font-face-in-shadow-DOM.html
      
      When a remote font is loaded, CSSFontSelector forces a style recalc, which replaces all
      RenderSyles that have FontFallbackLists referencing the placeholder font with fresh
      RenderStyles. However, it does not descend into shadow DOM trees, so those may end up with
      styles that still reference the placeholder font.
      
      The fix is to add RenderObject::requiresForcedStyleRecalcPropagation() and have it return
      true from renderers that maintain shadow DOM trees or otherwise keep their own RenderStyles.
      
      * dom/Element.cpp:
      (WebCore::Element::recalcStyle): Check if forced style recalc needs to propagated.
      * rendering/RenderButton.h:
      (WebCore::RenderButton::requiresForcedStyleRecalcPropagation):
      * rendering/RenderDataGrid.h:
      (WebCore::RenderDataGrid::requiresForcedStyleRecalcPropagation):
      * rendering/RenderFileUploadControl.h:
      (WebCore::RenderFileUploadControl::requiresForcedStyleRecalcPropagation):
      * rendering/RenderListItem.h:
      (WebCore::RenderListItem::requiresForcedStyleRecalcPropagation):
      * rendering/RenderMedia.h:
      (WebCore::RenderMedia::requiresForcedStyleRecalcPropagation):
      * rendering/RenderMenuList.h:
      (WebCore::RenderMenuList::RenderMenuList::requiresForcedStyleRecalcPropagation):
      * rendering/RenderObject.h:
      (WebCore::RenderObject::requiresForcedStyleRecalcPropagation):
      * rendering/RenderProgress.h:
      (WebCore::RenderProgress::requiresForcedStyleRecalcPropagation):
      * rendering/RenderSlider.h:
      (WebCore::RenderSlider::requiresForcedStyleRecalcPropagation):
      * rendering/RenderTextControl.h:
      (WebCore::RenderTextControl::requiresForcedStyleRecalcPropagation):
      
      LayoutTests: 
      
      * fast/css/font-face-in-shadow-DOM.html: Added.
      * platform/mac/fast/css/font-face-in-shadow-DOM-expected.checksum: Added.
      * platform/mac/fast/css/font-face-in-shadow-DOM-expected.png: Added.
      * platform/mac/fast/css/font-face-in-shadow-DOM-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55bf8727
    • jer.noble@apple.com's avatar
      No review; build fix only. · 7ec68a55
      jer.noble@apple.com authored
      When WTF_USE_ACCELERATED_COMPOSITING is turned off, MediaPlayerPrivateQuickTimeVisualContext.cpp
      must include CoreGraphics/CGContext.h.
      
      * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59873 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ec68a55
    • mrobinson@webkit.org's avatar
      2010-05-20 Martin Robinson <mrobinson@igalia.com> · a3dd3427
      mrobinson@webkit.org authored
              Not reviewed.
      
              Tests that use Geolocation.getCurrentPosition fail
              https://bugs.webkit.org/show_bug.cgi?id=39454
      
              * platform/gtk/Skipped: Skip failing tests until this bug is resolved.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3dd3427
    • jer.noble@apple.com's avatar
      2010-05-20 Jer Noble <jer.noble@apple.com> · 657a41a2
      jer.noble@apple.com authored
              Reviewed by Sam Weinig.
      
              Video elements show no video on Windows machines that do not support accelerated compositing
              https://bugs.webkit.org/show_bug.cgi?id=39446
              rdar://problem/7999794
      
              Implement the paint() method in MediaPlayerPrivateQuickTimeVisualContext.  The visual context should
              be set up in load() and torn down in the destructor (as opposed to setUpVideoRendering and 
              tearDownVideoRendering, which won't get called in a non-accelerated compositing case).
              
              * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
              (WebCore::MediaPlayerPrivateQuickTimeVisualContext::~MediaPlayerPrivateQuickTimeVisualContext):
              (WebCore::MediaPlayerPrivateQuickTimeVisualContext::load):
              (WebCore::MediaPlayerPrivateQuickTimeVisualContext::paint):
              (WebCore::MediaPlayerPrivateQuickTimeVisualContext::visualContextTimerFired):
              (WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):
              (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpVideoRendering):
              (WebCore::MediaPlayerPrivateQuickTimeVisualContext::tearDownVideoRendering):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      657a41a2
    • victorw@chromium.org's avatar
      2010-05-20 Abhishek Arya <inferno@chromium.org> · 96b6e18b
      victorw@chromium.org authored
              Reviewed by Adam Barth.
      
              Added method to WebSecurityOrigin for invoking
              SecurityOrigin::canAccessPasswordManager.
              https://bugs.webkit.org/show_bug.cgi?id=38916
      
              * public/WebSecurityOrigin.h:
              * src/WebSecurityOrigin.cpp:
              (WebKit::WebSecurityOrigin::canAccessPasswordManager):
      2010-05-20  Abhishek Arya  <inferno@chromium.org>
      
              Reviewed by Adam Barth.
      
              Added a method to check if the security origin can access
              password manager.
              https://bugs.webkit.org/show_bug.cgi?id=38916
      
              * page/SecurityOrigin.h:
              (WebCore::SecurityOrigin::canAccessPasswordManager):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59870 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96b6e18b
    • victorw@chromium.org's avatar
      2010-05-20 Victor Wang <victorw@chromium.org> · a9776086
      victorw@chromium.org authored
              Unreviewed. Update test expectations for chromium.
      
              * platform/chromium-mac/svg/filters/feLighting-crash-expected.checksum: Added.
              * platform/chromium-mac/svg/filters/feLighting-crash-expected.png: Added.
              * platform/chromium-win/svg/filters/feLighting-crash-expected.checksum: Added.
              * platform/chromium-win/svg/filters/feLighting-crash-expected.png: Added.
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9776086
    • darin@apple.com's avatar
      2010-05-20 Darin Adler <darin@apple.com> · 1ec7cbbc
      darin@apple.com authored
              Reviewed by Eric Seidel.
      
              Fix warnings seen on the buildbots today
              https://bugs.webkit.org/show_bug.cgi?id=39368
      
              * profiler/ProfileNode.cpp:
              (JSC::getCount): Removed unneeded initialization of global variable.
              These are all initialized to zero anyway, so no need to try to initialize
              it and get a warning.
      
              * wtf/CurrentTime.cpp:
              (WTF::currentTime): Removed unused global variable.
      2010-05-20  Darin Adler  <darin@apple.com>
      
              Reviewed by Eric Seidel.
      
              Fix warnings seen on the buildbots today
              https://bugs.webkit.org/show_bug.cgi?id=39368
      
              * loader/icon/IconDatabase.cpp:
              (WebCore::IconDatabase::pruneUnretainedIcons): Use the type "long long" for
              things being printed with "%lli". There is no guaranteed that int64_t is the
              same thing as long long.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEvent): Added parentheses as suggested
              by warnings in newer versions of GCC.
      
              * platform/ContextMenu.cpp: Fix #if around the functions to match the #if
              around the call sites to avoid unused function warning.
      
              * platform/graphics/gtk/ImageGtk.cpp:
              (WebCore::Image::loadPlatformResource): Use NULL to end a variable argument list
              rather than 0. This is a case where the WebKit "use 0 instead of NULL" guideline
              is incorrect and won't work properly.
      
              * platform/win/SystemTimeWin.cpp:
              (WebCore::userIdleTime): Removed unnecessary initialization of LASTINPUTINFO.
      
              * platform/win/WebCoreInstanceHandle.h: Added property svn:eol-style.
              Made functions inline instead of static. It's not correct to have functions with
              internal linkage in a header file. Marking them inline makes more sense.
      
              * plugins/win/PluginMessageThrottlerWin.cpp:
              (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin): Reordered the
              initializers to match the order of the data members from the class definition.
      
              * plugins/win/PluginViewWin.cpp:
              (WebCore::PluginView::paintIntoTransformedContext): Initialized all the fields
              of WINDOWPOS. I know this goes against the traditions of Windows programming,
              but it's correct and silences the warning. Also removed the unneeded separate
              code path for non-WinCE platforms that translates only the corner of the window
              rectangle; the WinCE version is correct for normal Windows as well. Not sure
              why this wasn't caught when the code was originally checked in.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59868 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ec7cbbc
    • mrobinson@webkit.org's avatar
      2010-05-20 Martin Robinson <mrobinson@igalia.com> · d07f9bea
      mrobinson@webkit.org authored
              Not reviewed.
      
              https://bugs.webkit.org/show_bug.cgi?id=39388
              Re-enable geolocation tests on GTK+ now that this bug is closed.
      
              * platform/gtk/Skipped: Re-enable geolocation tests.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59867 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d07f9bea
    • yaar@chromium.org's avatar
      2010-05-20 Justin Schuh <jschuh@chromium.org> · 37eb477c
      yaar@chromium.org authored
              Reviewed by Adam Barth.
      
              Moving frame.src checks out of the bindings
              https://bugs.webkit.org/show_bug.cgi?id=37815
      
              Moved JavaScript frame.src checks out of bindings and into
              HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
              so ExecState is available inside core DOM. Updated affected bindings
              (except for GObject, which will need to be updated to avoid origin
              failures inside native code).
      
              * Android.jscbindings.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSBindingsAllInOne.cpp:
              * bindings/js/JSCallbackData.cpp:
              (WebCore::JSCallbackData::invokeCallback):
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSEventListener::handleEvent):
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::InjectedScriptHost::createInjectedScript):
              * bindings/js/JSMainThreadExecState.cpp: Added.
              * bindings/js/JSMainThreadExecState.h: Added.
              (WebCore::JSMainThreadExecState::currentState):
              (WebCore::JSMainThreadExecState::call):
              (WebCore::JSMainThreadExecState::evaluate):
              (WebCore::JSMainThreadExecState::JSMainThreadExecState):
              (WebCore::JSMainThreadExecState::~JSMainThreadExecState):
              (WebCore::JSMainThreadNullState::JSMainThreadNullState):
              * bindings/js/ScheduledAction.cpp:
              (WebCore::ScheduledAction::executeFunctionInContext):
              (WebCore::ScheduledAction::execute):
              * bindings/js/ScheduledAction.h:
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::evaluateInWorld):
              (WebCore::ScriptController::canAccessFromCurrentOrigin):
              * bindings/js/ScriptController.h:
              * bindings/js/ScriptFunctionCall.cpp:
              (WebCore::ScriptFunctionCall::call):
              * bindings/objc/ObjCEventListener.mm:
              * bindings/objc/WebScriptObject.mm:
              (-[WebScriptObject callWebScriptMethod:withArguments:]):
              (-[WebScriptObject evaluateWebScript:]):
              * bindings/scripts/CodeGeneratorObjC.pm:
              * bindings/scripts/test/ObjC/DOMTestCallback.mm:
              (-[DOMTestCallback callbackWithClass1Param:]):
              (-[DOMTestCallback callbackWithClass2Param:strArg:]):
              (-[DOMTestCallback callbackWithNonBoolReturnType:]):
              (-[DOMTestCallback customCallback:class6Param:]):
              * bindings/scripts/test/ObjC/DOMTestInterface.mm:
              * bindings/scripts/test/ObjC/DOMTestObj.mm:
              (-[DOMTestObj readOnlyIntAttr]):
              (-[DOMTestObj readOnlyStringAttr]):
              (-[DOMTestObj readOnlyTestObjAttr]):
              (-[DOMTestObj intAttr]):
              (-[DOMTestObj setIntAttr:]):
              (-[DOMTestObj longLongAttr]):
              (-[DOMTestObj setLongLongAttr:]):
              (-[DOMTestObj unsignedLongLongAttr]):
              (-[DOMTestObj setUnsignedLongLongAttr:]):
              (-[DOMTestObj stringAttr]):
              (-[DOMTestObj setStringAttr:]):
              (-[DOMTestObj testObjAttr]):
              (-[DOMTestObj setTestObjAttr:]):
              (-[DOMTestObj attrWithException]):
              (-[DOMTestObj setAttrWithException:]):
              (-[DOMTestObj attrWithSetterException]):
              (-[DOMTestObj setAttrWithSetterException:]):
              (-[DOMTestObj attrWithGetterException]):
              (-[DOMTestObj setAttrWithGetterException:]):
              (-[DOMTestObj customAttr]):
              (-[DOMTestObj setCustomAttr:]):
              (-[DOMTestObj scriptStringAttr]):
              (-[DOMTestObj voidMethod]):
              (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj intMethod]):
              (-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj objMethod]):
              (-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj methodThatRequiresAllArgs:objArg:]):
              (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
              (-[DOMTestObj serializedValue:]):
              (-[DOMTestObj methodWithException]):
              (-[DOMTestObj customMethod]):
              (-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
              (-[DOMTestObj customArgsAndException:]):
              (-[DOMTestObj addEventListener:listener:useCapture:]):
              (-[DOMTestObj removeEventListener:listener:useCapture:]):
              (-[DOMTestObj withDynamicFrame]):
              (-[DOMTestObj withDynamicFrameAndArg:]):
              (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
              (-[DOMTestObj withDynamicFrameAndUserGesture:]):
              (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
              (-[DOMTestObj withScriptStateVoid]):
              (-[DOMTestObj withScriptStateObj]):
              (-[DOMTestObj withScriptStateVoidException]):
              (-[DOMTestObj withScriptStateObjException]):
              (-[DOMTestObj methodWithOptionalArg:]):
              (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
              (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::canAccessFromCurrentOrigin):
              * bindings/v8/ScriptController.h:
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::isURLAllowed):
      2010-05-20  Justin Schuh  <jschuh@chromium.org>
      
              Reviewed by Adam Barth.
      
              Moving frame.src checks out of the bindings
              https://bugs.webkit.org/show_bug.cgi?id=37815
      
              * http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
              * http/tests/security/xss-DENIED-iframe-src-alias.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37eb477c
    • kdecker@apple.com's avatar
      Reviewed by Anders Carlsson. · 333ad92d
      kdecker@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=39441
              <rdar://problem/7985715> Flash context menu is both horizontally and vertically offset from point of click
              <rdar://problem/7986109> Youtube video controller UI entirely missing
              <rdar://problem/7986154> Flash content paints at horizontally and vertically shifted locations (within the plug-in region)
      
              * Plugins/Hosted/WebHostedNetscapePluginView.mm:
              (-[WebHostedNetscapePluginView updateAndSetWindow]): The base coordinates of a window and
               it's contentView happen to be the equal at a userSpaceScaleFactor of 1. For non-1.0 scale
               factors this assumption is false. Accordingly we now convert to the window contentView
              coordinate system when computing bounds in "window" and the visible rect.
              * Plugins/WebNetscapePluginView.mm:
              (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      333ad92d
    • aroben@apple.com's avatar
      Fix an HRGN leak in WKCACFLayerRenderer · 9af8414b
      aroben@apple.com authored
      Fixes <http://webkit.org/b/39312> <rdar://problem/7998728> REGRESSION
      (r53686-r55990): Graphics corruption when watching video (affects
      youtube.com)
      
      Reviewed by Darin Adler.
      
      * platform/graphics/win/WKCACFLayerRenderer.cpp:
      (WebCore::getDirtyRects): Use an OwnPtr to hold the HRGN we allocate.
      That way we don't have to remember to destroy it (as we were
      forgetting to do) when we bail out of this function early.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9af8414b
    • ggaren@apple.com's avatar
      2010-05-20 Geoffrey Garen <ggaren@apple.com> · 544432d4
      ggaren@apple.com authored
              Reviewed by Darin Adler.
      
              Removed some reliance on callFame[CodeBlock] by storing CodeBlock in a
              local variable in the Interpreter.
              https://bugs.webkit.org/show_bug.cgi?id=39447
      
              Small speedup on SunSpider in Interpreter mode.
      
              * interpreter/Interpreter.cpp:
              (JSC::Interpreter::privateExecute):
              * jsc.cpp:
              * wtf/Platform.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      544432d4
    • darin@chromium.org's avatar
      2010-05-20 Darin Fisher <darin@chromium.org> · 2bb6803c
      darin@chromium.org authored
              Reviewed by Nate Chapin.
      
              [chromium] Provide a way to catch exceptions thrown while interacting
              with a NPObject via WebBindings methods.
              https://bugs.webkit.org/show_bug.cgi?id=39378
      
              This change also includes a small bit of cleanup in V8NPObject and
              friends.  I moved code into the WebCore namespace where appropriate.
              
              In _NPN_Invoke, I also moved the call to _NPN_Evaluate outside of the
              context scope.  I did this to avoid having nested ExceptionCatcher
              objects, which is not strictly necessary, but it seemed cleaner.
              _NPN_Evaluate already takes care of creating a context scope.
      
              * bindings/v8/NPV8Object.cpp:
              (WebCore::v8ObjectToNPObject):
              (WebCore::npCreateV8ScriptObject):
              (_NPN_Invoke):
              (_NPN_InvokeDefault):
              (_NPN_Evaluate):
              (_NPN_EvaluateHelper):
              (_NPN_GetProperty):
              (_NPN_SetProperty):
              (_NPN_RemoveProperty):
              (_NPN_HasProperty):
              (_NPN_HasMethod):
              (_NPN_SetException):
              (_NPN_Enumerate):
              (_NPN_Construct):
              * bindings/v8/NPV8Object.h:
              * bindings/v8/V8NPObject.cpp:
              * bindings/v8/V8NPObject.h:
              * bindings/v8/V8NPUtils.cpp:
              (WebCore::convertV8ObjectToNPVariant):
              (WebCore::pushExceptionHandler):
              (WebCore::popExceptionHandler):
              (WebCore::ExceptionCatcher::ExceptionCatcher):
              (WebCore::ExceptionCatcher::~ExceptionCatcher):
              * bindings/v8/V8NPUtils.h:
              * bindings/v8/npruntime.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bb6803c
    • mrobinson@webkit.org's avatar
      2010-05-20 Martin Robinson <mrobinson@igalia.com> · a6d6b6cd
      mrobinson@webkit.org authored
              Reviewed by Eric Seidel.
      
              editingBehavior settings needs to be set back to a reasonable default between tests
              https://bugs.webkit.org/show_bug.cgi?id=39433
      
              For now, hard code the default setting during reset, so that the serialized
              version of the setting stays in sync with expectations.
      
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetDefaultsToConsistentValues): Reset editing behavior to the appropriate platform default.
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (resetDefaultsToConsistentValues): Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6d6b6cd
    • barraclough@apple.com's avatar
      Bug 39408 - Unify JIT/interpreter return behaviour. · c73ede7f
      barraclough@apple.com authored
      Reviewed by Oliver Hunt.
      
      Presently the JIT and the interpreter have differing implementations in how
      they handle storing the result of a function call back to the register file.
      In both cases the op_call ( / _eval / _varargs / op_construct) opcode has an
      operand indicating the VM register in which the result should be stored.
      The JIT plants code after the call to store the result, so the value will be
      stored as soon as the callee has returned.  In the interpreter the call
      passes the return value register id into the callee via the callee callframe,
      and the callee is responsible for writing the result back into its callers
      register file after it has restored the parents callframe pointer, but before
      returning.
      
      Instead, move the task of writing the call result to the register file into a
      new opcode (op_call_put_result), and after returning the callee should leave
      the return value in a canonical location.  In the case of the interpreter,
      this canonical location is a local variable in privateExecute
      (functionReturnValue), in the case of the JIT this is the normal return value
      registers (regT0, or regT1:regT0 in JSVALUE32_64).  op_call_put_result stores
      the result from the canonical location to the registerfile.
      
      In addition to unifying JIT & interpreter behaviour this change allows us to
      remove a slot from the callframe, omit the write of the result where the
      return value from the call is not used, and provides a 2% speedup on sunspider
      in the interpreter.
      
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::dump):
      * bytecode/Opcode.h:
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::emitCall):
      (JSC::BytecodeGenerator::emitCallVarargs):
      (JSC::BytecodeGenerator::emitConstruct):
      * bytecompiler/BytecodeGenerator.h:
      (JSC::BytecodeGenerator::finalDestinationOrIgnored):
      * bytecompiler/NodesCodegen.cpp:
      (JSC::NewExprNode::emitBytecode):
      (JSC::FunctionCallValueNode::emitBytecode):
      (JSC::FunctionCallResolveNode::emitBytecode):
      (JSC::FunctionCallBracketNode::emitBytecode):
      (JSC::FunctionCallDotNode::emitBytecode):
      (JSC::CallFunctionCallDotNode::emitBytecode):
      (JSC::ApplyFunctionCallDotNode::emitBytecode):
      * interpreter/CallFrame.h:
      (JSC::ExecState::init):
      (JSC::ExecState::noCaller):
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::dumpRegisters):
      (JSC::Interpreter::throwException):
      (JSC::Interpreter::privateExecute):
      * interpreter/RegisterFile.h:
      (JSC::RegisterFile::):
      * jit/JIT.cpp:
      (JSC::JIT::privateCompileMainPass):
      * jit/JIT.h:
      * jit/JITCall.cpp:
      (JSC::JIT::compileOpCallSetupArgs):
      (JSC::JIT::compileOpConstructSetupArgs):
      (JSC::JIT::emit_op_call_put_result):
      (JSC::JIT::compileOpCallVarargs):
      (JSC::JIT::compileOpCallVarargsSlowCase):
      (JSC::JIT::compileOpCall):
      (JSC::JIT::compileOpCallSlowCase):
      (JSC::JIT::compileOpCallVarargsSetupArgs):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c73ede7f
    • steveblock@google.com's avatar
      2010-05-20 Marcus Bulach <bulach@chromium.org> · 4959f3e5
      steveblock@google.com authored
              Reviewed by Steve Block.
      
              Ensure timers are stopped on Geolocation::disconnectFrame()
              https://bugs.webkit.org/show_bug.cgi?id=39388
      
              fast/dom/Geolocation/notimer-after-unload.html, plus it should be possible to re-enable Gtk LayoutTests.
      
              * page/Geolocation.cpp:
              (WebCore::Geolocation::disconnectFrame):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4959f3e5
    • bfulgham@webkit.org's avatar
      Build fix. No review. · 7b4abfd1
      bfulgham@webkit.org authored
      The WebKitAPITest targets do not use the "_debug" suffix needed
      by the WinCairo port.  Added Debug_Cairo target to correct this.
      
      * WebKitAPITest/WebKitAPITest.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b4abfd1
    • mrobinson@webkit.org's avatar
      2010-05-20 Martin Robinson <mrobinson@igalia.com> · bf8254cc
      mrobinson@webkit.org authored
              Unreviewed.
      
              editingBehavior settings needs to be set back to a reasonable default between tests
              https://bugs.webkit.org/show_bug.cgi?id=39433
      
              I forgot to revert the expected results for this test after reverting it.
      
              * editing/selection/extend-selection-after-double-click-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf8254cc
    • jamesr@google.com's avatar
      2010-05-20 James Robinson <jamesr@chromium.org> · 3ba18e88
      jamesr@google.com authored
              Reviewed by Eric Seidel.
      
              Ensures styles are up-to-date before determining selection
              https://bugs.webkit.org/show_bug.cgi?id=39389
      
              This adds a call to document::updateStyleIfNeeded() to
              Frame::notifyRendererOfSelectionChange(). Without this call, if there
              is a pending style update that will detach part of the DOM and the
              the selection is within that part of the DOM when
              notifyRendererOfSeletionChange is called, the rootEditableElement
              algorithm ends up walking through detached parts of the render tree.
      
              Test: editing/selection/focus-and-display-none.html
      
              * page/Frame.cpp:
              (WebCore::Frame::notifyRendererOfSelectionChange):
      2010-05-20  James Robinson  <jamesr@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Tests putting focus into a textarea and setting display:none
              https://bugs.webkit.org/show_bug.cgi?id=39389
      
              * editing/selection/focus-and-display-none-expected.txt: Added.
              * editing/selection/focus-and-display-none.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ba18e88
    • bfulgham@webkit.org's avatar
      [WinCairo] Correct scaling for print preview · f86100ad
      bfulgham@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=39329
      
      Reviewed by Adam Roben.
      
      Cairo does not properly deal with Windows HDCs that have been
      scaled using MM_ANISOTROPIC mapping mode, and a WindowExt and
      ViewportExt setting.
      (see http://bugs.freedesktop.org/show_bug.cgi?id=28161)
      
      Instead, reset the HDC's WorldTransform to be unscaled, then
      scale the cairo context to the desired scaling, and perform
      the drawing operation.
      
      * WebFrame.cpp:
      (WebFrame::drawHeader): Use pre-positioned context to simplify 
        this method.
      (WebFrame::drawFooter): Use pre-positioned context to simplify
        this method.
      (WebFrame::spoolPage): Revise scaling logic to turn off HDC
        scaling, and scale using only Cairo.  Revert scaling at end
        so that user-defined GDI-based routines (e.g., header/footer)
        will draw in the right position.
      (WebFrame::spoolPages): Identify print preview case, and
        retrieve scaling factors from preview context.  Set the
        Cairo context to use these factors during the spoolPage
        operation.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f86100ad
    • aroben@apple.com's avatar
      Remove code that fetched, but did nothing useful with, a CFDictionary in... · 7c809b4b
      aroben@apple.com authored
      Remove code that fetched, but did nothing useful with, a CFDictionary in MediaPlayerPrivateQuickTimeVisualContext
      
      I also removed the code in QTPixelBuffer that vended the dictionary.
      
      Fixes <http://webkit.org/b/39435> <rdar://problem/8009278>
      QTPixelBuffer passes CFDictionaries across the DLL boundary, which can
      lead to crashes
      
      Reviewed by Darin Adler.
      
      * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
      (WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):
      Deleted code that fetched the attachments dictionary, which was never
      used other than to pass it to CFRetain/CFRelease, which could be
      enough to cause a crash due to incompatible copies of
      CoreFoundation.dll.
      
      * platform/graphics/win/QTMovieVisualContext.h: Added a now-needed
      forward declaration.
      
      * platform/graphics/win/QTPixelBuffer.cpp:
      * platform/graphics/win/QTPixelBuffer.h:
      Removed the now-unused attachments function.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c809b4b
    • aroben@apple.com's avatar
      Fix a CFData leak in MediaPlayerPrivateQuickTimeVisualContext · 5423b9c2
      aroben@apple.com authored
      Fixes <http://webkit.org/b/39432> <rdar://problem/8008992>
      
      Reviewed by Ada Chan
      
      * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
      (WebCore::QTCFDictionaryCreateWithDataCallback): Use a RetainPtr to
      hold the CFData we allocate so it will get released when this function
      is exited. Also pass kCFAllocatorNull as the bytes deallocator to
      CFDataCreateWithBytesNoCopy so that CF doesn't try to deallocate the
      bytes we pass to it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5423b9c2
    • mrobinson@webkit.org's avatar
      2010-05-20 Martin Robinson <mrobinson@igalia.com> · 3c25fb48
      mrobinson@webkit.org authored
              Reviewed by Ojan Vafai.
      
              editingBehavior settings needs to be set back to a reasonable default between tests
              https://bugs.webkit.org/show_bug.cgi?id=39433
      
              Revert the changes from r59840 to this test until there is a method
              in the WebKit APIs to consistently reset the editingBehavior setting
              to a reasonable default.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c25fb48
    • jianli@chromium.org's avatar
      Rename GenericTask* to CrossThreadTask* in CrossThreadTask.h. · 1e7a1745
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=39437
      
      Reviewed by David Levin.
      
      * dom/CrossThreadTask.h:
      (WebCore::):
      (WebCore::CrossThreadTask1::create):
      (WebCore::CrossThreadTask1::CrossThreadTask1):
      (WebCore::CrossThreadTask2::create):
      (WebCore::CrossThreadTask2::CrossThreadTask2):
      (WebCore::CrossThreadTask3::create):
      (WebCore::CrossThreadTask3::CrossThreadTask3):
      (WebCore::CrossThreadTask4::create):
      (WebCore::CrossThreadTask4::CrossThreadTask4):
      (WebCore::CrossThreadTask5::create):
      (WebCore::CrossThreadTask5::CrossThreadTask5):
      (WebCore::CrossThreadTask6::create):
      (WebCore::CrossThreadTask6::CrossThreadTask6):
      (WebCore::CrossThreadTask7::create):
      (WebCore::CrossThreadTask7::CrossThreadTask7):
      (WebCore::CrossThreadTask8::create):
      (WebCore::CrossThreadTask8::CrossThreadTask8):
      (WebCore::createCallbackTask):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e7a1745
    • victorw@chromium.org's avatar
      2010-05-20 Victor Wang <victorw@chromium.org> · 505fdbc2
      victorw@chromium.org authored
              Unreviewed. Update test expectations from chromium.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      505fdbc2
    • jianli@chromium.org's avatar
      Rename GenericWorkerTask.h to CrossThreadTask.h and move it to dom directory. · 765ee5a5
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=39135
      
      Reviewed by David Levin.
      
      WebCore:
      
      * GNUmakefile.am:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * dom/CrossThreadTask.h: Renamed from WebCore/workers/GenericWorkerTask.h.
      * html/FileStreamProxy.cpp:
      * loader/WorkerThreadableLoader.cpp:
      * websockets/WorkerThreadableWebSocketChannel.cpp:
      * workers/DefaultSharedWorkerRepository.cpp:
      * workers/WorkerMessagingProxy.cpp:
      * workers/WorkerScriptLoader.cpp:
      
      WebKit/chromium:
      
      * src/WebSharedWorkerImpl.cpp:
      * src/WebWorkerBase.cpp:
      * src/WebWorkerClientImpl.cpp:
      * src/WebWorkerImpl.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      765ee5a5
    • adele@apple.com's avatar
      Remove the Safari welcome page site-specific quirk, since its no longer needed. · 80741ef5
      adele@apple.com authored
      Reviewed by Mark Rowe.
      
      * css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80741ef5
    • steveblock@google.com's avatar
      2010-05-20 Steve Block <steveblock@google.com> · 2f4e6fc9
      steveblock@google.com authored
              Reviewed by Jeremy Orlow.
      
              Provide bindings for DeviceOrientation
              https://bugs.webkit.org/show_bug.cgi?id=39210
      
              Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled.
      
              * Configurations/FeatureDefines.xcconfig:
      2010-05-20  Steve Block  <steveblock@google.com>
      
              Reviewed by Jeremy Orlow.
      
              Provide bindings for DeviceOrientation
              https://bugs.webkit.org/show_bug.cgi?id=39210
      
              Adds ENABLE_DEVICE_ORIENTATION to VisualStudio project files, always disabled.
      
              * win/tools/vsprops/FeatureDefines.vsprops:
              * win/tools/vsprops/FeatureDefinesCairo.vsprops:
      2010-05-20  Steve Block  <steveblock@google.com>
      
              Reviewed by Jeremy Orlow.
      
              Provide bindings for DeviceOrientation
              https://bugs.webkit.org/show_bug.cgi?id=39210
      
              Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled.
      
              * Configurations/FeatureDefines.xcconfig:
      2010-05-20  Steve Block  <steveblock@google.com>
      
              Reviewed by Jeremy Orlow.
      
              Provide bindings for DeviceOrientation
              https://bugs.webkit.org/show_bug.cgi?id=39210
      
              Tests: fast/dom/DeviceOrientation/window-property.html
                     fast/dom/Window/window-properties-on-device-orientation.html
      
              Adds bindings for DeviceOrientation as defined in
              http://dev.w3.org/geo/api/spec-source-orientation.html
              This is guarded by ENABLE(DEVICE_ORIENTATION) which is currently disabled on
              all platforms but Android.
      
              * Android.derived.jscbindings.mk:
              * Android.derived.v8bindings.mk:
              * Android.mk:
              * Configurations/FeatureDefines.xcconfig:
              * DerivedSources.cpp:
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pri:
              * WebCore.pro:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSEventCustom.cpp:
              (WebCore::toJS):
              * bindings/v8/custom/V8EventCustom.cpp:
              (WebCore::toV8):
              * dom/DeviceOrientationEvent.cpp: Added.
              (WebCore::DeviceOrientationEvent::DeviceOrientationEvent):
              (WebCore::DeviceOrientationEvent::initDeviceOrientationEvent):
              * dom/DeviceOrientationEvent.h: Added.
              (WebCore::DeviceOrientationEvent::create):
              (WebCore::DeviceOrientationEvent::alpha):
              (WebCore::DeviceOrientationEvent::beta):
              (WebCore::DeviceOrientationEvent::gamma):
              (WebCore::DeviceOrientationEvent::isDeviceOrientationEvent):
              * dom/DeviceOrientationEvent.idl: Added.
              * dom/Event.cpp:
              (WebCore::Event::isDeviceOrientationEvent):
              * dom/Event.h:
              * dom/EventNames.h:
              * page/DOMWindow.h:
              * page/DOMWindow.idl:
      2010-05-20  Steve Block  <steveblock@google.com>
      
              Reviewed by Jeremy Orlow.
      
              Provide bindings for DeviceOrientation
              https://bugs.webkit.org/show_bug.cgi?id=39210
      
              Modifies existing fast/dom/Window tests to skip window.ondeviceorientation until
              it is widely supported.
              Adds new fast/dom/Window/window-properties-on-device-orientation.html to test
              type and presence of window.ondeviceorientation.
              Adds new fast/dom/DeviceOrientation directory and initial test.
              Adds all DeviceOrientation tests to all skipped lists.
      
              * fast/dom/DeviceOrientation: Added.
              * fast/dom/DeviceOrientation/script-tests: Added.
              * fast/dom/DeviceOrientation/script-tests/TEMPLATE.html: Added.
              * fast/dom/DeviceOrientation/script-tests/window-property.js: Added.
              (hasOnDeviceOrientationProperty):
              * fast/dom/DeviceOrientation/window-property-expected.txt: Added.
              * fast/dom/DeviceOrientation/window-property.html: Added.
              * fast/dom/Window/script-tests/window-property-descriptors.js:
              * fast/dom/Window/window-properties-on-device-orientation-expected.txt: Added.
              * fast/dom/Window/window-properties-on-device-orientation.html: Added.
              * fast/dom/Window/window-properties.html:
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f4e6fc9
    • kenneth@webkit.org's avatar
      Use 0.15 as text drag delay when Q_WS_MAC is defined, which is · fb767332
      kenneth@webkit.org authored
      consistent with the Mac OS X platform.
      
      Rubberstamped by Antti Koivisto.
      
      * page/qt/EventHandlerQt.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb767332
    • mrobinson@webkit.org's avatar
      2010-05-20 Martin Robinson <mrobinson@igalia.com> · d83ba07a
      mrobinson@webkit.org authored
              Unreviewed.
      
              Touch WebKit.idl to ensure that interfaces rebuild.
      
              * Interfaces/WebKit.idl: Touched.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d83ba07a
    • mrobinson@webkit.org's avatar
      2010-05-20 Martin Robinson <mrobinson@igalia.com> · 9a8b9fb4
      mrobinson@webkit.org authored
              Reviewed by Ojan Vafai.
      
              editing/selection/extend-selection-after-double-click.html crashes on the Leopard Intel release bot
              https://bugs.webkit.org/show_bug.cgi?id=39431
      
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setEditingBehavior):
              Prevent a double-free by not having this variable be in the auto-release pool.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a8b9fb4
    • mrobinson@webkit.org's avatar
      2010-05-20 Martin Robinson <mrobinson@igalia.com> · 17975f00
      mrobinson@webkit.org authored
              Reviewed by Adam Roben.
      
              Fix the Windows build and move new IDL declarations to the bottom of the file.
      
              * Interfaces/IWebPreferences.idl: Move new API to the bottom of the IDL file to prevent vtable mismatch.
              * WebPreferences.cpp:
              (WebPreferences::setEditingBehavior): Change the type of the parameter to setEditingBehavior to the proper type.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17975f00
    • mrobinson@webkit.org's avatar
      2010-05-20 Martin Robinson <mrobinson@igalia.com> · f328a36c
      mrobinson@webkit.org authored
              Unreviewed.
      
              Fix the Windows build.
      
              * WebView.cpp:
              (WebView::notifyPreferencesChanged): Change behavior to 'editingBehavior'.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f328a36c
    • tkent@chromium.org's avatar
      Unreviewed. Touch WebKit.idl as usual. · 6fcd18d7
      tkent@chromium.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fcd18d7
    • mrobinson@webkit.org's avatar
      2010-05-20 Martin Robinson <mrobinson@webkit.org> · 255a8cf1
      mrobinson@webkit.org authored
              Reviewed by Ojan Vafai.
      
              Expose the editing behavior setting in DRT to test all editing code paths
              https://bugs.webkit.org/show_bug.cgi?id=38603
      
              * editing/selection/extend-selection-after-double-click.html: Use the new DRT support for changing editing behavior.
              * editing/selection/extend-selection-after-double-click-expected.txt: Update expected results to reflect both behaviors.
      2010-05-20  Martin Robinson  <mrobinson@webkit.org>
      
              Reviewed by Ojan Vafai.
      
              Expose the editing behavior setting in DRT to test all editing code paths
              https://bugs.webkit.org/show_bug.cgi?id=38603
      
              * public/WebSettings.h:
              (WebKit::WebSettings::): Added an enum for EditingBehavior types.
              * src/WebSettingsImpl.cpp:
              (WebKit::WebSettingsImpl::setEditingBehavior): Added.
              * src/WebSettingsImpl.h:
      2010-05-20  Martin Robinson  <mrobinson@webkit.org>
      
              Reviewed by Ojan Vafai.
      
              Expose the editing behavior setting in DRT to test all editing code paths
              https://bugs.webkit.org/show_bug.cgi?id=38603
      
              * WebView/WebFrame.mm:
              (core):
              * WebView/WebFrameInternal.h: Added a conversion method from the API enum to the WebCore enum.
              * WebView/WebPreferenceKeysPrivate.h: Added a preference key for the new setting.
              * WebView/WebPreferences.mm:
              (+[WebPreferences initialize]): Initialize the EditingBehavior to Mac style.
              (-[WebPreferences editingBehavior]): Added.
              (-[WebPreferences setEditingBehavior:]): Added.
              * WebView/WebPreferencesPrivate.h: Added the new API points to the private API.
              * WebView/WebView.mm:
              (-[WebView _preferencesChangedNotification:]): Set the editing behavior via the WebPreferences setting.
      2010-05-20  Martin Robinson  <mrobinson@webkit.org>
      
              Reviewed by Ojan Vafai.
      
              Expose the editing behavior setting in DRT to test all editing code paths
              https://bugs.webkit.org/show_bug.cgi?id=38603
      
              Expose the EditingBehavior setting in the Windows API.
      
              * Interfaces/IWebPreferences.idl: Add the API point for setting the editing behavior.
              * WebPreferenceKeysPrivate.h: Add a key for the editing behavior setting.
              * WebPreferences.cpp:
              (WebPreferences::editingBehavior): Added.
              (WebPreferences::setEditingBehavior): Added.
              * WebPreferences.h: Add method declarations.
              * WebView.cpp:
              (WebView::notifyPreferencesChanged): Update the WebCore setting based on the WebPreferences setting.
      2010-05-20  Martin Robinson  <mrobinson@webkit.org>
      
              Reviewed by Ojan Vafai.
      
              Expose the editing behavior setting in DRT to test all editing code paths
              https://bugs.webkit.org/show_bug.cgi?id=38603
      
              * DumpRenderTree/LayoutTestController.cpp:
              (setEditingBehaviorCallback): Added.
              (LayoutTestController::staticFunctions): Expose the setEditingBehaviorCallback function.
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.cpp: Add callback method for setting editing behavior.
              * DumpRenderTree/chromium/LayoutTestController.h: Declaration for this method.
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setEditingBehavior): Implementation of editing behavior control.
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setEditingBehavior): Ditto
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::setEditingBehavior): Added stub implementation of editing behavior control.
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              (LayoutTestController::setEditingBehavior): Add slot for controlling editor behavior.
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setEditingBehavior): Implementation of editing behavior control.
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              (LayoutTestController::setEditingBehavior): Added stub implementation of editing behavior control.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      255a8cf1
    • tkent@chromium.org's avatar
      2010-05-20 Kent Tamura <tkent@chromium.org> · dce4a0eb
      tkent@chromium.org authored
              Reviewed by Eric Seidel.
      
              [DRT/Chromium] Increase the time out value
              https://bugs.webkit.org/show_bug.cgi?id=39203
      
              Change the time out value of Chromium DRT to 30 seconds, which is
              the same as other ports.
              If a DRT process exits before new-run-webkit-tests detects time
              out, new-run-webkit-tests assumes the DRT process crashed.
      
              * DumpRenderTree/chromium/TestShell.cpp:
              (TestShell::layoutTestTimeout):
                Change the time out value from 10 seconds to 30 seconds.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dce4a0eb
    • eric@webkit.org's avatar
      2010-05-20 Janne Koskinen <janne.p.koskinen@digia.com> · 38db4a8e
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] WINSCW compile fix for qwebframe test
              https://bugs.webkit.org/show_bug.cgi?id=38722
      
              WINSCW cannot determine template type up the hierarchy
              to common base class.
      
              * tests/qwebframe/tst_qwebframe.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59838 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38db4a8e
    • hausmann@webkit.org's avatar
      Fix painting when using clipToImageBuffer() · c7c442b5
      hausmann@webkit.org authored
      Reviewed by Simon Hausmann.
      
      When we apply the transform of the parent painter to the painter of
      the transparency layer, we adopt its coordinate system, thus offset
      should not be in page coordinates, but in the coordinate system of
      the parent painter.
      
      * platform/graphics/qt/GraphicsContextQt.cpp:
      (WebCore::TransparencyLayer::TransparencyLayer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59837 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7c442b5
    • eric@webkit.org's avatar
      2010-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 2f9ea455
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Remove unused "old style" private APIs
      
              These symbols were introduced after QtWebKit v4.6
              so no-one should be using them
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f9ea455