- 13 Sep, 2012 22 commits
-
-
apavlov@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=96615 Reviewed by Yury Semikhatsky. The CSS agent is put into and removed from the instrumenting agents set upon enable() and disable(), respectively. Tests will be shortly landed as a part of the new pure protocol testing harness. * inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::setFrontend): (WebCore::InspectorCSSAgent::clearFrontend): (WebCore::InspectorCSSAgent::reset): (WebCore): (WebCore::InspectorCSSAgent::resetNonPersistentData): (WebCore::InspectorCSSAgent::enable): (WebCore::InspectorCSSAgent::disable): * inspector/InspectorCSSAgent.h: (InspectorCSSAgent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
http://trac.webkit.org/changeset/128409 https://bugs.webkit.org/show_bug.cgi?id=96622 It broke Chromium browser_tests (Requested by tkent on #webkit). Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-13 * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::scopeStringMatches): (WebKit::WebFrameImpl::shouldScopeMatches): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
Testing whether indexing type is ArrayWithArrayStorage should not compare against ArrayWithArrayStorage https://bugs.webkit.org/show_bug.cgi?id=96611 Reviewed by Gavin Barraclough. * dfg/DFGRepatch.cpp: (JSC::DFG::tryCacheGetByID): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::checkArray): * jit/JITPropertyAccess.cpp: (JSC::JIT::privateCompilePatchGetArrayLength): * jit/JITPropertyAccess32_64.cpp: (JSC::JIT::privateCompilePatchGetArrayLength): * llint/LowLevelInterpreter32_64.asm: * llint/LowLevelInterpreter64.asm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=96607 Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-13 Reviewed by Kenneth Rohde Christiansen. Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain and enable all-in-one-files optimizations. * qmake/mkspecs/features/production_build.prf: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yosin@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=96612 Reviewed by Kent Tamura. This patch adds two tests for clicking spin button in iframe for input type "number" and input type "time" with multiple fields UI. These tests are added for catching regression caused by r127876. * fast/forms/number/number-spinbutton-click-in-iframe-expected.txt: Added. * fast/forms/number/number-spinbutton-click-in-iframe.html: Added. * fast/forms/resources/common-spinbutton-click-in-iframe.js: Added. (getSpinButton): Extracts spin button in shadow DOM tree. (mouseClick): Simulates mouse click. (mouseMoveTo): Simulates mouse pointer move. (runIFrameLoaded): Checking spin button clicked. (testClickSpinButtonInIFrame): Creates and populates iframe. * fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-click-in-iframe-expected.txt: Added. * fast/forms/time-multiple-fields/time-multiple-fields-spinbutton-click-in-iframe.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=96608 Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2012-09-13 Reviewed by Kenneth Rohde Christiansen. When cross-compiling it is not safe to just use system(pkg-config), because there is a high probability that it will find packages in the host system instead of in the target one. Instead use qmake's new packagesExist() function that takes care of this delicate aspect of cross compilation by setting PKG_CONFIG_SYSROOT_DIR and PKG_CONFIG_LIBDIR accordingly. * qmake/mkspecs/features/features.prf: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=96609 Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-13 Reviewed by Kenneth Rohde Christiansen. Update StringBuilder usage in InjectedBundlePage to follow the latest recommandations for efficient string handling: http://trac.webkit.org/wiki/EfficientStrings This involves using appendLiteral() or appendNumber() instead of append() whenever possible. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::dumpPath): (WTR::rangeToStr): (WTR::styleDecToStr): (WTR::frameToStr): (WTR::dumpResourceURL): (WTR): (WTR::dumpFrameDescriptionSuitableForTestResult): (WTR::dumpRequestDescriptionSuitableForTestResult): (WTR::dumpResponseDescriptionSuitableForTestResult): (WTR::dumpErrorDescriptionSuitableForTestResult): (WTR::InjectedBundlePage::didReceiveIntentForFrame): (WTR::InjectedBundlePage::registerIntentServiceForFrame): (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame): (WTR::InjectedBundlePage::didCommitLoadForFrame): (WTR::InjectedBundlePage::didFinishProgress): (WTR::dumpFrameScrollPosition): (WTR::dumpFrameText): (WTR::dumpDescendantFramesText): (WTR::InjectedBundlePage::didFinishLoadForFrame): (WTR::InjectedBundlePage::didReceiveTitleForFrame): (WTR::InjectedBundlePage::didCancelClientRedirectForFrame): (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame): (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame): (WTR::InjectedBundlePage::willSendRequestForFrame): (WTR::InjectedBundlePage::didReceiveResponseForResource): (WTR::InjectedBundlePage::didFinishLoadForResource): (WTR::InjectedBundlePage::didFailLoadForResource): (WTR::InjectedBundlePage::shouldCacheResponse): (WTR::InjectedBundlePage::decidePolicyForNavigationAction): (WTR::InjectedBundlePage::willAddMessageToConsole): (WTR::InjectedBundlePage::willSetStatusbarText): (WTR::InjectedBundlePage::willRunJavaScriptAlert): (WTR::InjectedBundlePage::willRunJavaScriptConfirm): (WTR::InjectedBundlePage::willRunJavaScriptPrompt): (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): (WTR::InjectedBundlePage::shouldBeginEditing): (WTR::InjectedBundlePage::shouldEndEditing): (WTR::InjectedBundlePage::shouldInsertNode): (WTR::InjectedBundlePage::shouldInsertText): (WTR::InjectedBundlePage::shouldDeleteRange): (WTR::InjectedBundlePage::shouldChangeSelectedRange): (WTR::InjectedBundlePage::shouldApplyStyle): (WTR::InjectedBundlePage::didBeginEditing): (WTR::InjectedBundlePage::didEndEditing): (WTR::InjectedBundlePage::didChange): (WTR::InjectedBundlePage::didChangeSelection): (WTR::InjectedBundlePage::supportsFullScreen): (WTR::InjectedBundlePage::enterFullScreenForElement): (WTR::InjectedBundlePage::exitFullScreenForElement): (WTR::InjectedBundlePage::beganEnterFullScreen): (WTR::InjectedBundlePage::beganExitFullScreen): (WTR::InjectedBundlePage::closeFullScreen): (WTR::dumpBackForwardListItem): (WTR::InjectedBundlePage::dumpBackForwardList): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
Rebaselining two tests after r128375. * platform/gtk/TestExpectations: * platform/gtk/fast/table/height-percent-test-vertical-expected.png: Added. * platform/gtk/fast/table/height-percent-test-vertical-expected.txt: * platform/gtk/fast/writing-mode/percentage-height-orthogonal-writing-modes-quirks-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128420 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=96603 Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-09-13 Reviewed by Csaba Osztrogonác. Fix memory leaks in Qt's TestRunner code by adopting WKString created with WKStringCreateWithUTF8CString(). * WebKitTestRunner/qt/TestControllerQt.cpp: (WTR::TestController::initializeInjectedBundlePath): (WTR::TestController::initializeTestPluginDirectory): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
loislo@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=96511 Reviewed by Yury Semikhatsky. After moving core NMI code to WTF namespace I removed forward declarations of MemoryObjectInfo and MemoryInstrumentation from WebCore headers and add forward declaration into wtf/Forward.h Source/WebCore: * bindings/v8/DOMDataStore.h: (WebCore): * bindings/v8/ScriptProfiler.h: (WebCore): * bindings/v8/V8DOMMap.h: (WebCore): * bindings/v8/V8PerIsolateData.h: (WebCore): * bindings/v8/V8ValueCache.h: (WebCore): * css/CSSProperty.h: * css/CSSRule.h: (WebCore): * css/CSSSelectorList.h: (WebCore): * css/CSSStyleDeclaration.h: (WebCore): * css/CSSStyleSheet.h: (WebCore): * css/CSSValue.h: * css/MediaList.h: (WebCore): * css/MediaQuery.h: * css/MediaQueryExp.h: * css/StylePropertySet.h: (WebCore): * css/StyleResolver.h: * css/StyleRule.h: (WebCore): * css/StyleRuleImport.h: (WebCore): * css/StyleSheetContents.h: (WebCore): * css/WebKitCSSKeyframeRule.h: * css/WebKitCSSKeyframesRule.h: (WebCore): * css/WebKitCSSMixFunctionValue.h: * dom/DocumentEventQueue.h: (WebCore): * dom/ElementAttributeData.h: (WebCore): * dom/Event.h: (WebCore): * dom/Node.h: (WebCore): * dom/WebCoreMemoryInstrumentation.cpp: (WTF): (WTF::WebCore::KURL): * dom/WebCoreMemoryInstrumentation.h: (WebCore): (WTF): * inspector/MemoryInstrumentationImpl.h: * loader/DocumentLoader.h: (WebCore): * loader/FrameLoader.h: (WebCore): * loader/ResourceLoader.h: (WebCore): * loader/SubstituteData.h: * loader/cache/CachedCSSStyleSheet.h: (WebCore): * loader/cache/CachedRawResource.h: (WebCore): * loader/cache/CachedResource.h: (WebCore): * loader/cache/CachedResourceHandle.h: * loader/cache/CachedResourceLoader.h: (WebCore): * loader/cache/CachedScript.h: (WebCore): * loader/cache/CachedShader.h: * loader/cache/CachedXSLStyleSheet.h: (WebCore): * loader/cache/MemoryCache.h: (WebCore): * page/Frame.h: (WebCore): * platform/SharedBuffer.h: * platform/graphics/CrossfadeGeneratedImage.h: (WebCore): * platform/graphics/Image.h: (WebCore): * platform/network/FormData.h: (WebCore): * platform/network/ResourceRequestBase.h: * platform/network/ResourceResponseBase.h: * rendering/style/RenderStyle.h: (WebCore): * rendering/style/StyleRareInheritedData.h: (WebCore): * rendering/style/StyleRareNonInheritedData.h: (WebCore): Source/WTF: * wtf/Forward.h: (WTF): * wtf/MemoryInstrumentation.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
Removing expectation for fast/canvas/canvas-css-crazy.html, the test was fixed in r128411. Marking fast/events/popup-blocking-timers.html as slow and adding a timeout expectation for touchadjustment/iframe-boundary.html. * platform/gtk/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=78493 Patch by Raul Hudea <rhudea@adobe.com> on 2012-09-13 Reviewed by David Hyatt. Source/WebCore: Implement the getRegionFlowRanges function from the CSS Regions spec. It is implemented by iterating over the content nodes and figuring out which nodes have boundingBox intersecting the region box and figuring out the start and end positions. Tests: fast/regions/get-region-flow-ranges-absolute-pos.html fast/regions/get-region-flow-ranges-content-nodes.html fast/regions/get-region-flow-ranges-display-none.html fast/regions/get-region-flow-ranges-empty-regions.html fast/regions/get-region-flow-ranges-fixed-pos.html fast/regions/get-region-flow-ranges-horiz-bt.html fast/regions/get-region-flow-ranges-inline-only.html fast/regions/get-region-flow-ranges-text-vert-lr.html fast/regions/get-region-flow-ranges-text.html fast/regions/get-region-flow-ranges-vert-lr.html fast/regions/get-region-flow-ranges-vert-rl.html fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr.html fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr.html fast/regions/get-region-flow-ranges.html * dom/Element.cpp: (WebCore::Element::webkitGetRegionFlowRanges): (WebCore): * dom/Element.h: * dom/Element.idl: added the webkitGetRegionFlowRanges method * rendering/RenderBlock.cpp: (WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed) (WebCore::RenderBlock::hasNextPage): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed) (WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage): Added a slower path which works without LayoutState (WebCore::RenderBlock::clampToStartAndEndRegions): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed) * rendering/RenderBox.cpp: (WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed) (WebCore::RenderBox::containingBlockAvailableLineWidthInRegion): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed) (WebCore::computeInlineStaticDistance): Use the logicalTopOfFlowThreadContentRect instead of offsetFromLogicalTopOfFirstPage (renamed) * rendering/RenderNamedFlowThread.cpp: (WebCore::isContainedInNodes): (WebCore): (WebCore::boxIntersectsRegion): (WebCore::RenderNamedFlowThread::getRanges): returns a vector of Ranges that contains Node that are part of a region * rendering/RenderNamedFlowThread.h: (RenderNamedFlowThread): * rendering/RenderRegion.cpp: (WebCore::RenderRegion::logicalTopOfFlowThreadContentRect): Returns the logical top of a rectangle inside the flow thread content (WebCore): (WebCore::RenderRegion::logicalBottomOfFlowThreadContentRect): Returns the logical bottom of a rectangle inside the flow thread content (WebCore::RenderRegion::getRanges): proxy the getRanges call to its named flow thread * rendering/RenderRegion.h: (RenderRegion): (WebCore::RenderRegion::logicalTopForFlowThreadContent): Renamed from offsetFromLogicalTopOfFirstPage (WebCore::RenderRegion::logicalBottomForFlowThreadContent): Returns the logical bottom of the FlowThreadContent rect LayoutTests: Add tests for getRegionFlowRanges call. * fast/regions/get-region-flow-ranges-absolute-pos-expected.txt: Added. * fast/regions/get-region-flow-ranges-absolute-pos.html: Added. * fast/regions/get-region-flow-ranges-content-nodes-expected.txt: Added. * fast/regions/get-region-flow-ranges-content-nodes.html: Added. * fast/regions/get-region-flow-ranges-display-none-expected.txt: Added. * fast/regions/get-region-flow-ranges-display-none.html: Added. * fast/regions/get-region-flow-ranges-empty-regions-expected.txt: Added. * fast/regions/get-region-flow-ranges-empty-regions.html: Added. * fast/regions/get-region-flow-ranges-expected.txt: Added. * fast/regions/get-region-flow-ranges-fixed-pos-expected.txt: Added. * fast/regions/get-region-flow-ranges-fixed-pos.html: Added. * fast/regions/get-region-flow-ranges-horiz-bt-expected.txt: Added. * fast/regions/get-region-flow-ranges-horiz-bt.html: Added. * fast/regions/get-region-flow-ranges-inline-only-expected.txt: Added. * fast/regions/get-region-flow-ranges-inline-only.html: Added. * fast/regions/get-region-flow-ranges-text-expected.txt: Added. * fast/regions/get-region-flow-ranges-text-vert-lr-expected.txt: Added. * fast/regions/get-region-flow-ranges-text-vert-lr.html: Added. * fast/regions/get-region-flow-ranges-text.html: Added. * fast/regions/get-region-flow-ranges-vert-lr-expected.txt: Added. * fast/regions/get-region-flow-ranges-vert-lr.html: Added. * fast/regions/get-region-flow-ranges-vert-rl-expected.txt: Added. * fast/regions/get-region-flow-ranges-vert-rl.html: Added. * fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr-expected.txt: Added. * fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr.html: Added. * fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr-expected.txt: Added. * fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr.html: Added. * fast/regions/get-region-flow-ranges.html: Added. * fast/regions/resources/helper.js: (getName): (getRangeAt): (compareArrays): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128416 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=96601 Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-09-13 Reviewed by Kent Tamura. m_webFrame might be already deleted after terminateWorkerContext call. This patch ensure it be NULL and change to avoid using it. Test: fast/filesystem/workers/detached-frame-crash.html * src/WebWorkerClientImpl.cpp: (WebKit::WebWorkerClientImpl::terminateWorkerContext): (WebKit::WebWorkerClientImpl::openFileSystem): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128415 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
https://bugs.webkit.org/show_bug.cgi?id=96506 Reviewed by Dirk Pranke. Tools: Lower the timeout value to 6 seconds for release configuration and 12 seconds for debug configuration. These are the same values the Chromium port uses. Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and the layout tests under WebKit2 generally) requires more attention and gardening than what the current effort produces. The unit test is updated as well to test these changes. * Scripts/webkitpy/layout_tests/port/gtk.py: (GtkPort.default_timeout_ms): * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: (GtkPortTest.test_default_timeout_ms): (GtkPortTest.assertLinesEqual): LayoutTests: Create a new section for slow tests. Tests listed here pass (or at least work as expected or reliably) but require more than 6 or 12 seconds to run. More tests are added into the timeout section. These are primarily tests that used to take half a minute to run just to be interrupted by the watchdog in DumpRenderTree and were then reported as text mismatch failures. Now they will be timing out which is (arguably) a more proper way for them to fail. * platform/gtk/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=96604 Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-13 Reviewed by Gyuyoung Kim. Make _ref() functions return the ref'd object to make them more convenient to use. Also fix their usage to make use of the newly returned value. This change is consistent with eina_stringshare_ref() in EFL and g_object_ref() in glib. * UIProcess/API/efl/ewk_back_forward_list.cpp: (createEinaList): * UIProcess/API/efl/ewk_back_forward_list_item.cpp: (ewk_back_forward_list_item_ref): * UIProcess/API/efl/ewk_back_forward_list_item.h: * UIProcess/API/efl/ewk_context.cpp: (ewk_context_download_job_add): * UIProcess/API/efl/ewk_download_job.cpp: (ewk_download_job_ref): (ewk_download_job_response_set): * UIProcess/API/efl/ewk_download_job.h: * UIProcess/API/efl/ewk_form_submission_request.cpp: (ewk_form_submission_request_ref): * UIProcess/API/efl/ewk_form_submission_request.h: * UIProcess/API/efl/ewk_intent.cpp: (ewk_intent_ref): * UIProcess/API/efl/ewk_intent.h: * UIProcess/API/efl/ewk_intent_service.cpp: (ewk_intent_service_ref): * UIProcess/API/efl/ewk_intent_service.h: * UIProcess/API/efl/ewk_navigation_policy_decision.cpp: (ewk_navigation_policy_decision_ref): * UIProcess/API/efl/ewk_navigation_policy_decision.h: * UIProcess/API/efl/ewk_url_request.cpp: (ewk_url_request_ref): * UIProcess/API/efl/ewk_url_request.h: * UIProcess/API/efl/ewk_url_response.cpp: (ewk_url_response_ref): * UIProcess/API/efl/ewk_url_response.h: * UIProcess/API/efl/ewk_url_scheme_request.cpp: (ewk_url_scheme_request_ref): * UIProcess/API/efl/ewk_url_scheme_request.h: * UIProcess/API/efl/ewk_view.cpp: (ewk_view_resource_load_initiated): * UIProcess/API/efl/ewk_web_resource.cpp: (ewk_web_resource_ref): * UIProcess/API/efl/ewk_web_resource.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128413 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
slewis@apple.com authored
fast/table/bad-replaced-sizing-preferred-logical-widths.html is failing on Mac, Chromium-Mac, GTK, EFL. https://bugs.webkit.org/show_bug.cgi?id=96594. Unreviewed. Update TestExpectations. * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128412 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=96582 Reviewed by Csaba Osztrogonác. We represent 0 pointers with null, not undefined. Test: fast/canvas/canvas-css-crazy.html * bindings/js/JSCanvasRenderingContextCustom.cpp: (WebCore::toJS): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128411 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=96308 * platform/chromium-mac/fast/table/height-percent-test-vertical-expected.png: Rebaseline for http://trac.webkit.org/changeset/128375. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128410 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
leandrogracia@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=96402 Fix some issues in the WebKit implementation that prevented to send a final reportFindInPageMatchCount message. Reviewed by Adam Barth. * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::scopeStringMatches): (WebKit::WebFrameImpl::shouldScopeMatches): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128409 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
Removing crash expectations for accessibility tests that were added in r128342. The offending commit was reverted in r128353. Adding text mismatch expectations for two tests that probably require rebaselining, failing since r128375. Adding failure expectations for other regressions: - fast/canvas/canvas-css-crazy.html after r128374 - fast/table/bad-replaced-sizing-preferred-logical-widths.html after r128389 - fast/js/primitive-property-access-edge-cases.html after r128400 * platform/gtk/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128408 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
apavlov@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=96482 Reviewed by Vsevolod Vlasov. Source/WebCore: Update the Styles pane even if there is a pending rebuild update for the same current node. * inspector/front-end/StylesSidebarPane.js: (WebInspector.StylesSidebarPane.prototype._rebuildUpdate): LayoutTests: * inspector/styles/force-pseudo-state.html: * inspector/styles/force-pseudo-state-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128407 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
slewis@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=94372. Unreviewed. Update TestExpectations. * platform/mac-wk2/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 12 Sep, 2012 18 commits
-
-
cfleizach@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=96341 Unreviewed. Build fix for non-SVG ports. * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::determineAccessibilityRole): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128405 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yosin@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=96032 Reviewed by Chris Fleizach. Source/WebCore: This patch adds accessibility support into multiple fields time input UI by setting "role" HTML attribute of DateTimeFieldElement to "spinbutton" and changing ARIA attributes to post value change notification. This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS. Tests: fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification.html * html/shadow/DateTimeFieldElement.cpp: (WebCore::DateTimeFieldElement::DateTimeFieldElement): Changed to set "role" HTML attribute to "spinbutton". (WebCore::DateTimeFieldElement::initialize): Changed to set new parameter axHelpText to aria-help attribute and set aria-valuemax and aria-valuemin attributes. (WebCore::DateTimeFieldElement::updateVisibleValue): Changed to set aria-valuetext and aria-valuenow attributes. * html/shadow/DateTimeFieldElement.h: (DateTimeFieldElement): Changed to add new parameter axHelpText to initialize(). * html/shadow/DateTimeFieldElements.cpp: (WebCore::DateTimeAMPMFieldElement::create): Changed to add new argument. (WebCore::DateTimeHourFieldElement::create): ditto. (WebCore::DateTimeMillisecondFieldElement::create): ditto. (WebCore::DateTimeMinuteFieldElement::create): ditto. (WebCore::DateTimeSecondFieldElement::create): ditto. * html/shadow/DateTimeNumericFieldElement.cpp: (WebCore::DateTimeNumericFieldElement::maximum): Added for DateTimeFieldElement::initialize(). (WebCore::DateTimeNumericFieldElement::minimum): ditto. * html/shadow/DateTimeNumericFieldElement.h: (DateTimeNumericFieldElement): Added maximum() and minimum() declarations. * html/shadow/DateTimeSymbolicFieldElement.cpp: (WebCore::DateTimeSymbolicFieldElement::maximum): Added for DateTimeFieldElement::initialize(). (WebCore::DateTimeSymbolicFieldElement::minimum): ditto. * html/shadow/DateTimeSymbolicFieldElement.h: (DateTimeSymbolicFieldElement): Added maximum() and minimum() declarations. LayoutTests: This patch adds two tests for checking accessibility functionalities in multiple fields time input UI. This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS. * fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes-expected.txt: Added. * fast/forms/time-multiple-fields/time-multiple-fields-ax-aria-attributes.html: Added to check ARIA attributes used in multiple fields time input UI. * fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification-expected.txt: Added. * fast/forms/time-multiple-fields/time-multiple-fields-ax-value-changed-notification.html: Added to check accessibility notification supports in multiple fields time input UI. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
http://trac.webkit.org/changeset/127876 https://bugs.webkit.org/show_bug.cgi?id=96600 mouse click doesn't work for spin button if spin button in iframe (Requested by yosin on #webkit). Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-12 .: * Source/autotools/symbols.filter: Source/WebCore: * WebCore.exp.in: * WebCore.order: * dom/Document.cpp: (WebCore::Document::nodesFromRect): * dom/Document.h: (Document): * page/ContextMenuController.cpp: (WebCore::ContextMenuController::createContextMenu): * page/DragController.cpp: (WebCore::DragController::canProcessDrag): (WebCore::DragController::startDrag): * page/EventHandler.cpp: (WebCore::EventHandler::updateAutoscrollRenderer): (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleGestureEvent): (WebCore::EventHandler::bestClickableNodeForTouchPoint): (WebCore::EventHandler::bestContextMenuNodeForTouchPoint): (WebCore::EventHandler::bestZoomableAreaForTouchPoint): (WebCore::EventHandler::handleTouchEvent): * page/EventHandler.h: (EventHandler): * page/FocusController.cpp: (WebCore::updateFocusCandidateIfNeeded): * page/Frame.cpp: (WebCore::Frame::visiblePositionForPoint): (WebCore::Frame::documentAtPoint): * page/TouchDisambiguation.cpp: (WebCore::findGoodTouchTargets): * rendering/HitTestRequest.h: * testing/Internals.cpp: (WebCore::Internals::nodesFromRect): Source/WebKit/blackberry: * Api/WebPage.cpp: (BlackBerry::WebKit::WebPagePrivate::contextNode): (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint): (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent): (BlackBerry::WebKit::WebPage::nodeAtPoint): * WebKitSupport/FatFingers.cpp: (BlackBerry::WebKit::FatFingers::getNodesFromRect): (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint): * WebKitSupport/SelectionHandler.cpp: (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping): Source/WebKit/chromium: * src/ContextMenuClientImpl.cpp: (WebKit::selectMisspelledWord): * src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction): * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::characterIndexForPoint): * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::isRectTopmost): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::handleMouseUp): (WebKit::WebViewImpl::computeBlockBounds): Source/WebKit/efl: * ewk/ewk_frame.cpp: (ewk_frame_hit_test_new): Source/WebKit/mac: * WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary): * WebView/WebHTMLView.mm: (-[WebHTMLView elementAtPoint:allowShadowContent:]): Source/WebKit/qt: * Api/qwebframe.cpp: (QWebFrame::hitTestContent): * Api/qwebpage.cpp: (QWebPagePrivate::handleSoftwareInputPanel): (QWebPagePrivate::TouchAdjuster::findCandidatePointForTouch): (QWebPage::updatePositionDependentActions): * WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction): Source/WebKit/win: * WebActionPropertyBag.cpp: (WebActionPropertyBag::Read): * WebView.cpp: (WebView::handleContextMenuEvent): (WebView::elementAtPoint): Source/WebKit/wx: * WebFrame.cpp: (WebKit::WebFrame::HitTest): Source/WebKit2: * WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp: (WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction): * WebProcess/WebPage/WebPage.cpp: (WebKit::handleContextMenuEvent): (WebKit::WebPage::highlightPotentialActivation): (WebKit::WebPage::findZoomableAreaForPoint): * WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::characterIndexForPoint): (WebKit::WebPage::performDictionaryLookupAtLocation): (WebKit::WebPage::shouldDelayWindowOrderingEvent): (WebKit::WebPage::acceptsFirstMouse): * win/WebKit2.def: * win/WebKit2CFLite.def: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128403 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=96308 * platform/chromium-win/fast/table/height-percent-test-vertical-expected.png: Rebaseline for http://trac.webkit.org/changeset/128375. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128402 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
* WTF.xcodeproj/project.pbxproj: Removed the reference to CONTRIBUTORS.pthreads-win32. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128401 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=91933 Reviewed by Geoffrey Garen. Source/JavaScriptCore: This changes the JSC object model. Previously, all objects had fast lookup for named properties. Integer indexed properties were only fast if you used a JSArray. With this change, all objects have fast indexed properties. This is accomplished without any space overhead by using a bidirectional object layout, aka butterflies. Each JSObject has a m_butterfly pointer where previously it had a m_outOfLineStorage pointer. To the left of the location pointed to by m_butterfly, we place all named out-of-line properties. To the right, we place all indexed properties along with indexing meta-data. Though, some indexing meta-data is placed in the 8-byte word immediately left of the pointed-to location; this is in anticipation of the indexing meta-data being small enough in the common case that m_butterfly always points to the first indexed property. This is performance neutral, except on tests that use indexed properties on plain objects, where the speed-up is in excess of an order of magnitude. One notable aspect of what this change brings is that it allows indexing storage to morph over time. Currently this is only used to allow all non-array objects to start out without any indexed storage. But it could be used for some kinds of array type inference in the future. * API/JSCallbackObject.h: (JSCallbackObject): * API/JSCallbackObjectFunctions.h: (JSC::::getOwnPropertySlotByIndex): (JSC): (JSC::::getOwnNonIndexPropertyNames): * API/JSObjectRef.cpp: * CMakeLists.txt: * GNUmakefile.list.am: * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: * JavaScriptCore.xcodeproj/project.pbxproj: * Target.pri: * bytecode/ArrayProfile.h: (JSC): (JSC::arrayModeFromStructure): * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::emitDirectPutById): * dfg/DFGAbstractState.cpp: (JSC::DFG::AbstractState::execute): * dfg/DFGAdjacencyList.h: (JSC::DFG::AdjacencyList::AdjacencyList): (AdjacencyList): * dfg/DFGArrayMode.cpp: (JSC::DFG::fromObserved): (JSC::DFG::modeAlreadyChecked): (JSC::DFG::modeToString): * dfg/DFGArrayMode.h: (DFG): (JSC::DFG::modeUsesButterfly): (JSC::DFG::modeIsJSArray): (JSC::DFG::isInBoundsAccess): (JSC::DFG::modeSupportsLength): * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::handleGetByOffset): (JSC::DFG::ByteCodeParser::parseBlock): * dfg/DFGCSEPhase.cpp: (JSC::DFG::CSEPhase::getPropertyStorageLoadElimination): (JSC::DFG::CSEPhase::performNodeCSE): * dfg/DFGFixupPhase.cpp: (JSC::DFG::FixupPhase::fixupNode): (JSC::DFG::FixupPhase::addNode): (FixupPhase): (JSC::DFG::FixupPhase::checkArray): * dfg/DFGGraph.h: (JSC::DFG::Graph::byValIsPure): * dfg/DFGNode.h: (JSC::DFG::Node::Node): (Node): * dfg/DFGNodeType.h: (DFG): * dfg/DFGOperations.cpp: (JSC::DFG::putByVal): * dfg/DFGOperations.h: * dfg/DFGPredictionPropagationPhase.cpp: (JSC::DFG::PredictionPropagationPhase::propagate): * dfg/DFGRepatch.cpp: (JSC::DFG::generateProtoChainAccessStub): (JSC::DFG::tryCacheGetByID): (JSC::DFG::tryBuildGetByIDList): (JSC::DFG::emitPutReplaceStub): (JSC::DFG::emitPutTransitionStub): (JSC::DFG::tryBuildPutByIdList): * dfg/DFGSpeculativeJIT.cpp: (JSC::DFG::SpeculativeJIT::checkArray): (JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage): (JSC::DFG::SpeculativeJIT::compileGetArrayLength): (JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage): (JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage): * dfg/DFGSpeculativeJIT.h: (JSC::DFG::SpeculativeJIT::callOperation): (JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject): * dfg/DFGSpeculativeJIT32_64.cpp: (JSC::DFG::SpeculativeJIT::cachedGetById): (JSC::DFG::SpeculativeJIT::cachedPutById): (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGSpeculativeJIT64.cpp: (JSC::DFG::SpeculativeJIT::cachedGetById): (JSC::DFG::SpeculativeJIT::cachedPutById): (JSC::DFG::SpeculativeJIT::compile): * dfg/DFGStructureCheckHoistingPhase.cpp: (JSC::DFG::StructureCheckHoistingPhase::run): * heap/CopiedSpace.h: (CopiedSpace): * jit/JIT.h: * jit/JITInlineMethods.h: (JSC::JIT::emitAllocateBasicJSObject): (JSC::JIT::emitAllocateBasicStorage): (JSC::JIT::emitAllocateJSArray): * jit/JITOpcodes.cpp: (JSC::JIT::emit_op_new_array): (JSC::JIT::emitSlow_op_new_array): * jit/JITPropertyAccess.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::privateCompilePatchGetArrayLength): * jit/JITPropertyAccess32_64.cpp: (JSC::JIT::emit_op_get_by_val): (JSC::JIT::emit_op_put_by_val): (JSC::JIT::compileGetByIdHotPath): (JSC::JIT::emit_op_put_by_id): (JSC::JIT::compilePutDirectOffset): (JSC::JIT::compileGetDirectOffset): (JSC::JIT::privateCompilePatchGetArrayLength): * jit/JITStubs.cpp: (JSC::DEFINE_STUB_FUNCTION): * jsc.cpp: * llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL): * llint/LowLevelInterpreter.asm: * llint/LowLevelInterpreter32_64.asm: * llint/LowLevelInterpreter64.asm: * runtime/Arguments.cpp: (JSC::Arguments::deletePropertyByIndex): (JSC::Arguments::defineOwnProperty): * runtime/ArrayConstructor.cpp: * runtime/ArrayConventions.h: Added. (JSC): (JSC::isDenseEnoughForVector): (JSC::indexingHeaderForArray): (JSC::baseIndexingHeaderForArray): * runtime/ArrayPrototype.cpp: (JSC::ArrayPrototype::create): (JSC): (JSC::ArrayPrototype::ArrayPrototype): (JSC::arrayProtoFuncToString): (JSC::arrayProtoFuncJoin): (JSC::arrayProtoFuncSort): (JSC::arrayProtoFuncFilter): (JSC::arrayProtoFuncMap): (JSC::arrayProtoFuncEvery): (JSC::arrayProtoFuncForEach): (JSC::arrayProtoFuncSome): (JSC::arrayProtoFuncReduce): (JSC::arrayProtoFuncReduceRight): * runtime/ArrayPrototype.h: (ArrayPrototype): (JSC::ArrayPrototype::createStructure): * runtime/ArrayStorage.h: Added. (JSC): (ArrayStorage): (JSC::ArrayStorage::ArrayStorage): (JSC::ArrayStorage::from): (JSC::ArrayStorage::butterfly): (JSC::ArrayStorage::indexingHeader): (JSC::ArrayStorage::length): (JSC::ArrayStorage::setLength): (JSC::ArrayStorage::vectorLength): (JSC::ArrayStorage::setVectorLength): (JSC::ArrayStorage::copyHeaderFromDuringGC): (JSC::ArrayStorage::inSparseMode): (JSC::ArrayStorage::lengthOffset): (JSC::ArrayStorage::vectorLengthOffset): (JSC::ArrayStorage::numValuesInVectorOffset): (JSC::ArrayStorage::vectorOffset): (JSC::ArrayStorage::indexBiasOffset): (JSC::ArrayStorage::sparseMapOffset): (JSC::ArrayStorage::sizeFor): * runtime/Butterfly.h: Added. (JSC): (Butterfly): (JSC::Butterfly::Butterfly): (JSC::Butterfly::totalSize): (JSC::Butterfly::fromBase): (JSC::Butterfly::offsetOfIndexingHeader): (JSC::Butterfly::offsetOfPublicLength): (JSC::Butterfly::offsetOfVectorLength): (JSC::Butterfly::indexingHeader): (JSC::Butterfly::propertyStorage): (JSC::Butterfly::indexingPayload): (JSC::Butterfly::arrayStorage): (JSC::Butterfly::offsetOfPropertyStorage): (JSC::Butterfly::indexOfPropertyStorage): (JSC::Butterfly::base): * runtime/ButterflyInlineMethods.h: Added. (JSC): (JSC::Butterfly::createUninitialized): (JSC::Butterfly::create): (JSC::Butterfly::createUninitializedDuringCollection): (JSC::Butterfly::base): (JSC::Butterfly::growPropertyStorage): (JSC::Butterfly::growArrayRight): (JSC::Butterfly::resizeArray): (JSC::Butterfly::unshift): (JSC::Butterfly::shift): * runtime/ClassInfo.h: (MethodTable): (JSC): * runtime/IndexingHeader.h: Added. (JSC): (IndexingHeader): (JSC::IndexingHeader::offsetOfIndexingHeader): (JSC::IndexingHeader::offsetOfPublicLength): (JSC::IndexingHeader::offsetOfVectorLength): (JSC::IndexingHeader::IndexingHeader): (JSC::IndexingHeader::vectorLength): (JSC::IndexingHeader::setVectorLength): (JSC::IndexingHeader::publicLength): (JSC::IndexingHeader::setPublicLength): (JSC::IndexingHeader::from): (JSC::IndexingHeader::fromEndOf): (JSC::IndexingHeader::propertyStorage): (JSC::IndexingHeader::arrayStorage): (JSC::IndexingHeader::butterfly): * runtime/IndexingHeaderInlineMethods.h: Added. (JSC): (JSC::IndexingHeader::preCapacity): (JSC::IndexingHeader::indexingPayloadSizeInBytes): * runtime/IndexingType.h: Added. (JSC): (JSC::hasIndexingHeader): * runtime/JSActivation.cpp: (JSC::JSActivation::JSActivation): (JSC::JSActivation::visitChildren): (JSC::JSActivation::getOwnNonIndexPropertyNames): * runtime/JSActivation.h: (JSActivation): (JSC::JSActivation::tearOff): * runtime/JSArray.cpp: (JSC): (JSC::createArrayButterflyInDictionaryIndexingMode): (JSC::JSArray::setLengthWritable): (JSC::JSArray::defineOwnProperty): (JSC::JSArray::getOwnPropertySlot): (JSC::JSArray::getOwnPropertyDescriptor): (JSC::JSArray::put): (JSC::JSArray::deleteProperty): (JSC::JSArray::getOwnNonIndexPropertyNames): (JSC::JSArray::unshiftCountSlowCase): (JSC::JSArray::setLength): (JSC::JSArray::pop): (JSC::JSArray::push): (JSC::JSArray::shiftCount): (JSC::JSArray::unshiftCount): (JSC::JSArray::sortNumeric): (JSC::JSArray::sort): (JSC::JSArray::fillArgList): (JSC::JSArray::copyToArguments): (JSC::JSArray::compactForSorting): * runtime/JSArray.h: (JSC): (JSArray): (JSC::JSArray::JSArray): (JSC::JSArray::length): (JSC::JSArray::createStructure): (JSC::JSArray::isLengthWritable): (JSC::createArrayButterfly): (JSC::JSArray::create): (JSC::JSArray::tryCreateUninitialized): * runtime/JSBoundFunction.cpp: (JSC::boundFunctionCall): (JSC::boundFunctionConstruct): (JSC::JSBoundFunction::finishCreation): * runtime/JSCell.cpp: (JSC::JSCell::getOwnNonIndexPropertyNames): (JSC): * runtime/JSCell.h: (JSCell): * runtime/JSFunction.cpp: (JSC::JSFunction::getOwnPropertySlot): (JSC::JSFunction::getOwnPropertyDescriptor): (JSC::JSFunction::getOwnNonIndexPropertyNames): (JSC::JSFunction::defineOwnProperty): * runtime/JSFunction.h: (JSFunction): * runtime/JSGlobalData.cpp: (JSC::JSGlobalData::JSGlobalData): * runtime/JSGlobalData.h: (JSGlobalData): * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset): * runtime/JSONObject.cpp: (JSC::Stringifier::Holder::appendNextProperty): (JSC::Walker::walk): * runtime/JSObject.cpp: (JSC): (JSC::JSObject::visitButterfly): (JSC::JSObject::visitChildren): (JSC::JSFinalObject::visitChildren): (JSC::JSObject::getOwnPropertySlotByIndex): (JSC::JSObject::put): (JSC::JSObject::putByIndex): (JSC::JSObject::enterDictionaryIndexingModeWhenArrayStorageAlreadyExists): (JSC::JSObject::enterDictionaryIndexingMode): (JSC::JSObject::createArrayStorage): (JSC::JSObject::createInitialArrayStorage): (JSC::JSObject::ensureArrayStorageExistsAndEnterDictionaryIndexingMode): (JSC::JSObject::putDirectAccessor): (JSC::JSObject::deleteProperty): (JSC::JSObject::deletePropertyByIndex): (JSC::JSObject::getOwnPropertyNames): (JSC::JSObject::getOwnNonIndexPropertyNames): (JSC::JSObject::preventExtensions): (JSC::JSObject::fillGetterPropertySlot): (JSC::JSObject::putIndexedDescriptor): (JSC::JSObject::defineOwnIndexedProperty): (JSC::JSObject::allocateSparseIndexMap): (JSC::JSObject::deallocateSparseIndexMap): (JSC::JSObject::putByIndexBeyondVectorLengthWithArrayStorage): (JSC::JSObject::putByIndexBeyondVectorLength): (JSC::JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage): (JSC::JSObject::putDirectIndexBeyondVectorLength): (JSC::JSObject::getNewVectorLength): (JSC::JSObject::increaseVectorLength): (JSC::JSObject::checkIndexingConsistency): (JSC::JSObject::growOutOfLineStorage): (JSC::JSObject::getOwnPropertyDescriptor): (JSC::putDescriptor): (JSC::JSObject::putDirectMayBeIndex): (JSC::JSObject::defineOwnNonIndexProperty): (JSC::JSObject::defineOwnProperty): (JSC::JSObject::getOwnPropertySlotSlow): * runtime/JSObject.h: (JSC::JSObject::getArrayLength): (JSObject): (JSC::JSObject::getVectorLength): (JSC::JSObject::putDirectIndex): (JSC::JSObject::canGetIndexQuickly): (JSC::JSObject::getIndexQuickly): (JSC::JSObject::canSetIndexQuickly): (JSC::JSObject::setIndexQuickly): (JSC::JSObject::initializeIndex): (JSC::JSObject::completeInitialization): (JSC::JSObject::inSparseIndexingMode): (JSC::JSObject::butterfly): (JSC::JSObject::outOfLineStorage): (JSC::JSObject::offsetForLocation): (JSC::JSObject::indexingShouldBeSparse): (JSC::JSObject::butterflyOffset): (JSC::JSObject::butterflyAddress): (JSC::JSObject::arrayStorage): (JSC::JSObject::arrayStorageOrZero): (JSC::JSObject::ensureArrayStorage): (JSC::JSObject::checkIndexingConsistency): (JSC::JSNonFinalObject::JSNonFinalObject): (JSC): (JSC::JSObject::setButterfly): (JSC::JSObject::setButterflyWithoutChangingStructure): (JSC::JSObject::JSObject): (JSC::JSObject::inlineGetOwnPropertySlot): (JSC::JSObject::putDirectInternal): (JSC::JSObject::setStructureAndReallocateStorageIfNecessary): (JSC::JSObject::putDirectWithoutTransition): (JSC::offsetInButterfly): (JSC::offsetRelativeToPatchedStorage): (JSC::indexRelativeToBase): (JSC::offsetRelativeToBase): * runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::create): * runtime/JSSymbolTableObject.cpp: (JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames): * runtime/JSSymbolTableObject.h: (JSSymbolTableObject): * runtime/JSTypeInfo.h: (JSC): (JSC::TypeInfo::interceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero): (JSC::TypeInfo::overridesGetPropertyNames): * runtime/LiteralParser.cpp: (JSC::::parse): * runtime/ObjectConstructor.cpp: * runtime/ObjectPrototype.cpp: (JSC::ObjectPrototype::ObjectPrototype): (JSC): * runtime/ObjectPrototype.h: (ObjectPrototype): * runtime/PropertyOffset.h: (JSC::offsetInOutOfLineStorage): * runtime/PropertyStorage.h: Added. (JSC): * runtime/PutDirectIndexMode.h: Added. (JSC): * runtime/RegExpMatchesArray.cpp: (JSC::RegExpMatchesArray::RegExpMatchesArray): (JSC): (JSC::RegExpMatchesArray::create): (JSC::RegExpMatchesArray::finishCreation): * runtime/RegExpMatchesArray.h: (RegExpMatchesArray): (JSC::RegExpMatchesArray::createStructure): * runtime/RegExpObject.cpp: (JSC::RegExpObject::getOwnNonIndexPropertyNames): * runtime/RegExpObject.h: (RegExpObject): * runtime/Reject.h: Added. (JSC): (JSC::reject): * runtime/SparseArrayValueMap.cpp: Added. (JSC): * runtime/SparseArrayValueMap.h: Added. (JSC): (SparseArrayEntry): (JSC::SparseArrayEntry::SparseArrayEntry): (SparseArrayValueMap): (JSC::SparseArrayValueMap::sparseMode): (JSC::SparseArrayValueMap::setSparseMode): (JSC::SparseArrayValueMap::lengthIsReadOnly): (JSC::SparseArrayValueMap::setLengthIsReadOnly): (JSC::SparseArrayValueMap::find): (JSC::SparseArrayValueMap::remove): (JSC::SparseArrayValueMap::notFound): (JSC::SparseArrayValueMap::isEmpty): (JSC::SparseArrayValueMap::contains): (JSC::SparseArrayValueMap::size): (JSC::SparseArrayValueMap::begin): (JSC::SparseArrayValueMap::end): * runtime/SparseArrayValueMapInlineMethods.h: Added. (JSC): (JSC::SparseArrayValueMap::SparseArrayValueMap): (JSC::SparseArrayValueMap::~SparseArrayValueMap): (JSC::SparseArrayValueMap::finishCreation): (JSC::SparseArrayValueMap::create): (JSC::SparseArrayValueMap::destroy): (JSC::SparseArrayValueMap::createStructure): (JSC::SparseArrayValueMap::add): (JSC::SparseArrayValueMap::putEntry): (JSC::SparseArrayValueMap::putDirect): (JSC::SparseArrayEntry::get): (JSC::SparseArrayEntry::getNonSparseMode): (JSC::SparseArrayValueMap::visitChildren): * runtime/StorageBarrier.h: Removed. * runtime/StringObject.cpp: (JSC::StringObject::putByIndex): (JSC): (JSC::StringObject::deletePropertyByIndex): * runtime/StringObject.h: (StringObject): * runtime/StringPrototype.cpp: * runtime/Structure.cpp: (JSC::Structure::Structure): (JSC::Structure::materializePropertyMap): (JSC::Structure::nonPropertyTransition): (JSC): * runtime/Structure.h: (Structure): (JSC::Structure::indexingType): (JSC::Structure::indexingTypeIncludingHistory): (JSC::Structure::indexingTypeOffset): (JSC::Structure::create): * runtime/StructureTransitionTable.h: (JSC): (JSC::toAttributes): (JSC::newIndexingType): (JSC::StructureTransitionTable::Hash::hash): * tests/mozilla/js1_6/Array/regress-304828.js: Source/WebCore: Teach the DOM that to intercept get/put on indexed properties, you now have to override getOwnPropertySlotByIndex and putByIndex. No new tests because no new behavior. One test was rebased because indexed property iteration order now matches other engines (indexed properties always come first). * bindings/js/ArrayValue.cpp: (WebCore::ArrayValue::get): * bindings/js/JSBlobCustom.cpp: (WebCore::JSBlobConstructor::constructJSBlob): * bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::setWebkitLineDash): * bindings/js/JSDOMStringListCustom.cpp: (WebCore::toDOMStringList): * bindings/js/JSDOMStringMapCustom.cpp: (WebCore::JSDOMStringMap::deletePropertyByIndex): (WebCore): * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getOwnPropertySlot): (WebCore::JSDOMWindow::getOwnPropertySlotByIndex): (WebCore): (WebCore::JSDOMWindow::putByIndex): (WebCore::JSDOMWindow::deletePropertyByIndex): * bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::getOwnPropertySlotByIndex): (WebCore): (WebCore::JSDOMWindowShell::putByIndex): (WebCore::JSDOMWindowShell::deletePropertyByIndex): * bindings/js/JSDOMWindowShell.h: (JSDOMWindowShell): * bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::deletePropertyByIndex): (WebCore): * bindings/js/JSInspectorFrontendHostCustom.cpp: (WebCore::populateContextMenuItems): * bindings/js/JSLocationCustom.cpp: (WebCore::JSLocation::deletePropertyByIndex): (WebCore): * bindings/js/JSStorageCustom.cpp: (WebCore::JSStorage::deletePropertyByIndex): (WebCore): * bindings/js/JSWebSocketCustom.cpp: (WebCore::JSWebSocketConstructor::constructJSWebSocket): * bindings/js/ScriptValue.cpp: (WebCore::jsToInspectorValue): * bindings/js/SerializedScriptValue.cpp: (WebCore::CloneSerializer::serialize): * bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader): (GenerateImplementation): * bridge/runtime_array.cpp: (JSC::RuntimeArray::RuntimeArray): * bridge/runtime_array.h: (JSC::RuntimeArray::createStructure): (RuntimeArray): LayoutTests: Modify the JSON test to indicate that iterating over properties now returns indexed properties first. This is a behavior change that makes us more compliant with other implementations. Also check in new expected file for the edge cases of indexed property access with prototype accessors. This changeset introduces a known regression in that department, which is tracked here: https://bugs.webkit.org/show_bug.cgi?id=96596 * fast/js/resources/JSON-stringify.js: * platform/mac/fast/js/primitive-property-access-edge-cases-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128400 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=85887 Reviewed by Dirk Pranke. * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org. (ConfigureBuild.start): (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/ (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/ (Factory.__init__): (BuildFactory.__init__): (TestFactory.__init__): (BuildAndTestFactory.__init__): (BuildAndPerfTestFactory.__init__): (BuildAndPerfTestWebKit2Factory.__init__): (DownloadAndPerfTestFactory.__init__): (DownloadAndPerfTestWebKit2Factory.__init__): (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: (SVNMirrorTest): (SVNMirrorTest.setUp): Load config.json once at startup. (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave. (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added. (getLatestSVNRevision): Get the latest SVN revison from the given server. (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the SVN revision is empty (force build triggered without revision) or the server is unavailable. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128399 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=96594 * platform/chromium/TestExpectations: fast/table/bad-replaced-sizing-preferred-logical-widths.html fails on Mac. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dgrogan@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=96591 Reviewed by Kent Tamura. Needed to pass IndexedDBLayoutTest.BasicTests in content_browsertests after 128370. * storage/indexeddb/basics-shared-workers-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
slewis@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=96583 Unreviewed. Update TestExpectations * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=81606 Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-12 Reviewed by Tim Horton. Tools: 6 seconds is harsh for some jquery test cases. Therefore, adjust the value to match DumpRenderTree. * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR): LayoutTests: Unskip jQuery tests which will now consistently pass due to the increased waitUntilDone timeout. * platform/wk2/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=96238 Reviewed by Hajime Morita. ValidationMessageClient interface is responsible to operate validation message UI for interactive form validation. If a Page object has a ValidtionMessageClient, ValidationMessae class uses ValidtionMessageClient instead of Shadow DOM. No new tests because of no behavior changes. * GNUmakefile.list.am: Add ValidtionMessageClient.h. * Target.pri: ditto. * WebCore.gypi: ditto. * WebCore.xcodeproj/project.pbxproj: ditto. * html/ValidationMessage.cpp: (WebCore::ValidationMessage::~ValidationMessage): Hide a validation message via ValidationMessageClient if it is available. (WebCore::ValidationMessage::validationMessageClient): A helper function to get Page::validationMessageClient. (WebCore::ValidationMessage::updateValidationMessage): Adding title attribute is not neeeded if ValidationMessageClient is used. It shoudl be handled in a ValidtionMessageClient implementation. (WebCore::ValidationMessage::setMessage): Show a validation message via ValidationMessageClient if it is available. (WebCore::ValidationMessage::setMessageDOMAndStartTimer): Add an assertion that ValidationMessageClient should not be available. (WebCore::ValidationMessage::buildBubbleTree): ditto. (WebCore::ValidationMessage::requestToHideMessage): Hide a validation message via ValidationMessageClient if it is available. (WebCore::ValidationMessage::shadowTreeContains): Always returns false if ValidationMessageClient is available, it means no Shadow DOM. (WebCore::ValidationMessage::deleteBubbleTree): Add an assertion that ValidationMessageClient should not be available. (WebCore::ValidationMessage::isVisible): Ask ValidationMessageClient for visibility if it is available. * html/ValidationMessage.h: (WebCore): Add a comment. (ValidationMessage): Add validtionMessageClient member function. * page/Page.cpp: (WebCore::Page::Page): Initialize m_validationMessageClient. (WebCore::Page::PageClients::PageClients): Initialize validationMessageClient member with 0. So, existing code makes Page::m_validationMessageClient 0. * page/Page.h: (PageClients): Add validationMessageClient member. (WebCore::Page::validationMessageClient): Added. Accessor for m_validationMessageClient. (Page): Add m_validationMessageClient. * page/Settings.h: (Settings): Updated the comment for setInteractiveFormValidationEnabled. * page/ValidationMessageClient.h: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128394 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=96462 Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-09-12 Reviewed by Gyuyoung Kim. .: * Source/cmake/OptionsEfl.cmake: Enable DOWNLOAD_ATTRIBUTE feature. Source/WebKit/efl: Add suggested_name field on _Ewk_Download and set it on startDownload to get suggested name passed as a download attribute. * WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::download): (WebCore::FrameLoaderClientEfl::startDownload): * ewk/ewk_view.h: Tools: Enable DOWNLOAD_ATTRIBUTE feature for EFL port, and add "download,request" callback to the DumpRenderTree for EFL. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: (DumpRenderTreeChrome::createView): (DumpRenderTreeChrome::onDownloadRequest): * DumpRenderTree/efl/DumpRenderTreeChrome.h: (DumpRenderTreeChrome): * Scripts/webkitperl/FeatureList.pm: LayoutTests: * platform/efl/Skipped: Unskip test cases related to download attributes. * platform/efl-wk2/TestExpectations: Add test cases related to download attributes because they are still failed for WK2 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
slewis@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=94372. Unreviewed. * platform/mac-wk2/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
slewis@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=95906 Reviewed by Dirk Pranke. The wk2 testers on Mountain Lion are getting stuck and timing out. The problem appears to be due to resource contention. Reducing the number of processes alleviates the issue. Starting by reducing 25%. * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort.default_child_processes): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128391 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dimich@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=96459 Reviewed by David Levin. Added memory checks to the locations in Workers code that are about to invoke the next JS block. * bindings/v8/ScheduledAction.cpp: (WebCore::ScheduledAction::execute): * bindings/v8/V8GCController.cpp: (WebCore): (WebCore::workingSetEstimateMBMutex): Added a Mutex-protected accessors to a static caching WS estimate. (WebCore::V8GCController::gcEpilogue): (WebCore::V8GCController::checkMemoryUsage): * bindings/v8/V8GCController.h: (V8GCController): * bindings/v8/V8WorkerContextEventListener.cpp: (WebCore::V8WorkerContextEventListener::callListenerFunction): * bindings/v8/WorkerContextExecutionProxy.cpp: (WebCore::WorkerContextExecutionProxy::evaluate): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128390 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jchaffraix@webkit.org authored
REGRESSION(r122501): replaced elements with percent width are wrongly size when inserted inside an auto-table layout https://bugs.webkit.org/show_bug.cgi?id=95892 Reviewed by Ojan Vafai. Source/WebCore: r122501 exposed an issue in how preferred logical widths are computed on replaced objects. The code relies on the logical width computation methods. Unfortunately the previous code relies on the layout information, which may not be up-to-date during preferred logical width computation. Test: fast/table/bad-replaced-sizing-preferred-logical-widths.html fast/replaced/vertical-writing-mode-max-logical-width.html * rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::computeMaxPreferredLogicalWidth): Added this helper method. The main difference with the old code is that it handles the percent logical width properly before calling the old code path. This is not totally right but before forking the whole code, it's better to have more evidence that forking preferred logical widths and logical width computation is the way to go. (WebCore::RenderReplaced::computePreferredLogicalWidths): Changed to call computeMaxPreferredLogicalWidth. Also fixed an existing bug in vertical-writing modes where we would add the wrong paddings and borders. * rendering/RenderReplaced.h: (RenderReplaced): Added computeMaxPreferredLogicalWidth. LayoutTests: * fast/replaced/vertical-writing-mode-max-logical-width-replaced-expected.txt: Added. * fast/replaced/vertical-writing-mode-max-logical-width-replaced.html: Added. * fast/table/bad-replaced-sizing-preferred-logical-widths-expected.txt: Added. * fast/table/bad-replaced-sizing-preferred-logical-widths.html: Added. * fast/table/resources/iframe.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
beidson@apple.com authored
<rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576 Reviewed by Anders Carlsson. Source/WebKit2: Most of the NPN_* API calls have a plug-in protector during the calls. NPN_Invoke and NPN_InvokeDefault do not. * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp: (WebKit::NPN_Invoke): Protect the plug-in during this call. (WebKit::NPN_InvokeDefault): Ditto. Tools: Expose NPN_Invoke to plug-in tests: * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: (PluginTest::NPN_Invoke): * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: (PluginTest): Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element: * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added. (InvokeDestroysPluginWithinNPP_New): (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New): (InvokeDestroysPluginWithinNPP_New::NPP_New): * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: LayoutTests: * platform/mac-wk2/plugins/destroy-during-async-npp-new-expected.txt: Added. * platform/mac-wk2/plugins/destroy-during-async-npp-new.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-