- 23 Aug, 2013 7 commits
-
-
allan.jensen@digia.com authored
https://bugs.webkit.org/show_bug.cgi?id=120206 Reviewed by Anders Carlsson. * docs/qtwebkit.qdoc: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
a.bah@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=120006 Patch by Arpita Bahuguna <a.bah@samsung.com> on 2013-08-23 Reviewed by Ryosuke Niwa. Source/WebCore: deleteSelectionCommand does not handle the case when a <br> element is inlined after some non-textual content (input controls, image etc.). When doing a back-delete at the start of a line following such a <br> the two contiguous lines should merge and the <br> should get deleted. Currently, even though the <br> is deleted, another placeholder <br> is incorrectly inserted at the same point, thus effectively there is no change. We are incorrectly computing the inline <br> to be at the start of an empty line even though the line is not empty. Test: editing/deleting/delete-inline-br.html * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Adding a check to verify that the inline <br> is not on an empty line if the end node is not a <br> element itself and it's previous sibling is the start <br> element. Basically we check whether there is another node (end node) following the <br>, that the node is not a <br> itself, and that the end node's previous node is the start <br>. LayoutTests: * editing/deleting/delete-inline-br-expected.txt: Added. * editing/deleting/delete-inline-br.html: Added. Added a testcase that verifies that the caret is placed at the correct position after performing a back-delete operation. * editing/deleting/delete-before-block-image-2-expected.txt: * platform/mac/editing/deleting/delete-br-004-expected.txt: * platform/mac/editing/deleting/delete-br-005-expected.txt: * platform/mac/editing/deleting/delete-br-006-expected.txt: * platform/qt/editing/deleting/delete-br-004-expected.txt: * platform/qt/editing/deleting/delete-br-005-expected.txt: * platform/qt/editing/deleting/delete-br-006-expected.txt: Rebaselining existing tests. No visual change in behavior for these tests. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=118306 Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-08-23 Reviewed by Christophe Dumez. Tools: Check for the text/plain mimetype and if true then mark it as text dump. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump): LayoutTests: Unskipping http/tests/multipart/load-last-non-html-frame.php. Now the result should match the expectation. * platform/wk2/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.pena@samsung.com authored
* platform/gtk/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
reni@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120159 Reviewed by Ryosuke Niwa. Source/WebCore: Null-check parentRenderer in HTMLFormElement::rendererIsNeeded() and early return. Test: fast/forms/missing-parentrenderer-crash.html * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::rendererIsNeeded): LayoutTests: Test for the handling of null parentRederer. * fast/forms/missing-parentrenderer-crash-expected.txt: Added. * fast/forms/missing-parentrenderer-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zalan@apple.com authored
MathML: ASSERTION FAILED: !isPreferredLogicalHeightDirty() in RenderMathMLBlock::preferredLogicalHeight() const https://bugs.webkit.org/show_bug.cgi?id=120157 Reviewed by Antti Koivisto. RenderListMarker needs to be inserted to the render tree before we start computing the preferred logical widths for the associated RenderListItem. Source/WebCore: Test: mathml/mn-as-list-item-assert.html * rendering/RenderListItem.cpp: (WebCore::RenderListItem::insertOrMoveMarkerRendererIfNeeded): (WebCore::RenderListItem::layout): (WebCore::RenderListItem::computePreferredLogicalWidths): * rendering/RenderListItem.h: LayoutTests: * mathml/mn-as-list-item-assert-expected.txt: Added. * mathml/mn-as-list-item-assert.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120199 Reviewed by Gustavo Noronha Silva. * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp: (webkitWebPageCreate): Use kWKBundlePageLoaderClientCurrentVersion instead of kWKBundlePageResourceLoadClientCurrentVersion in loader client initialization. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 22 Aug, 2013 33 commits
-
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120182 <rdar://problem/14814461> Patch by Simon Cooper <scooper@apple.com> on 2013-08-22 Reviewed by Alexey Proskuryakov. When not in a sandbox do not enable the FakeSYSVSHIM. This allows LocalConnection to work when Flash Player is run in "Unsafe Mode". * PluginProcess/mac/PluginProcessShim.mm: (WebKit::shim_disabled): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
gyuyoung.kim@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=120154 Reviewed by Andreas Kling. As a step to clean-up static_cast<SVGXXX>, toSVGLinearGradientElement() is added to clean-up static_cast<SVGLinearGradientElement*>. * rendering/svg/RenderSVGResourceLinearGradient.cpp: (WebCore::RenderSVGResourceLinearGradient::collectGradientAttributes): * rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeSVGResourceContainer): * svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientAttributes): * svg/SVGLinearGradientElement.h: (WebCore::toSVGLinearGradientElement): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mhahnenberg@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120179 Reviewed by Geoffrey Garen. There are many places in the code for JSObject and JSArray where they are manipulating their Butterfly/Structure, e.g. after expanding their out-of-line backing storage via allocating. Within these places there are certain "critical sections" where a GC would be disastrous. Gen GC looks like it will make this dance even more intricate. To make everybody's lives easier we should use the DeferGC mechanism in these functions to make these GC critical sections both obvious in the code and trivially safe. Deferring collections will usually only last marginally longer, thus we should not incur any additional overhead. * heap/Heap.h: * runtime/JSArray.cpp: (JSC::JSArray::unshiftCountSlowCase): * runtime/JSObject.cpp: (JSC::JSObject::enterDictionaryIndexingModeWhenArrayStorageAlreadyExists): (JSC::JSObject::createInitialUndecided): (JSC::JSObject::createInitialInt32): (JSC::JSObject::createInitialDouble): (JSC::JSObject::createInitialContiguous): (JSC::JSObject::createArrayStorage): (JSC::JSObject::convertUndecidedToArrayStorage): (JSC::JSObject::convertInt32ToArrayStorage): (JSC::JSObject::convertDoubleToArrayStorage): (JSC::JSObject::convertContiguousToArrayStorage): (JSC::JSObject::increaseVectorLength): (JSC::JSObject::ensureLengthSlow): * runtime/JSObject.h: (JSC::JSObject::putDirectInternal): (JSC::JSObject::setStructureAndReallocateStorageIfNecessary): (JSC::JSObject::putDirectWithoutTransition): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=119825 Source/WebCore: Reviewed by Tim Horton. r137526 and some earlier commits attempted to avoid unconditionally repainting layers when their size changes, because this was causing TiledBacking layers to repaint when the document size changed. However, the approach required that we have good information about whether size changes require a repaint, which in some cases is hard to determine, especially when RenderLayer changes affect our decisions about which layers are composited. Fix by pushing the decision about whether to repaint on size change into GraphicsLayer. The default is to repaint on size change, but GraphicsLayer provides a function that can be overridden to modify this behavior; GraphicsLayerCA does so to avoid repaints when layers with TiledBackings get resized. Test: compositing/repaint/repaint-on-layer-grouping-change.html * WebCore.exp.in: WebKit2 needs GraphicsLayer::setSize, which is no longer inline. * platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setOffsetFromRenderer): (WebCore::GraphicsLayer::setSize): * platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::shouldRepaintOnSizeChange): * platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::shouldRepaintOnSizeChange): * platform/graphics/ca/GraphicsLayerCA.h: * rendering/RenderLayerBacking.h: No longer need m_boundsConstrainedByClipping * rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::updateCompositedBounds): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): setSize takes care of repainting for us now, so we can remove all the conditional code. LayoutTests: Reviewed by Tim Horton. Test that dumps repaint rects on layers after visibility changes affect the layer hierarchy. * compositing/repaint/repaint-on-layer-grouping-change-expected.txt: Added. * compositing/repaint/repaint-on-layer-grouping-change.html: Added. * compositing/repaint/resize-repaint-expected.txt: Update result. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120176 Reviewed by Beth Dakin. Sometimes the repaint counters are not in the corner of the compositing layer; they are either inset, or partially or entirely outside the layer. Fix by making sure that we restore the CGContext before drawing the counter, since the WebCore code may have translated the CTM. The counter-painting code saves and restores the context itself, so this is safe. * platform/graphics/mac/WebLayer.mm: (drawLayerContents): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120184 Reviewed by Mark Hahnenberg. Source/JavaScriptCore: * dfg/DFGPlan.cpp: (JSC::DFG::Plan::compileInThreadImpl): Tools: * ReducedFTL/build.sh: * Scripts/configure-llvm: Added. * Scripts/copy-webkitlibraries-to-product-directory: * Scripts/export-llvm-build: WebKitLibraries: Updated binary drops to r189066. * LLVMIncludesMountainLion.tar.bz2: * LLVMLibrariesMountainLion.tar.bz2: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://webkit.org/b/120180aestes@apple.com authored
Reviewed by David Kilzer. Source/WebKit2: Adding ld flags for ASAN overwrote the unexported symbol flags we were previously specifying. Since the unexported symbol ld flags are only needed for the framework target, move them to WebKit2.xcconfig where we can add them to OTHER_LDFLAGS along with the ASAN values inherited from DebugRelease.xcconfig (and other values). * Configurations/Base.xcconfig: Removed the unexported symbol ld flags. * Configurations/WebKit2.xcconfig: ... and moved them here. Tools: * TestWebKitAPI/Configurations/Base.xcconfig: Removed the definition of OTHER_CPLUSPLUSFLAGS since -ftemplate-depth=256 is already set in DebugRelease.xcconfig and TestWebKitAPI isn't built in Production. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120174 Reviewed by Geoff Garen. We currently always allocate registers for new global variables, but these are wasted when the variable is being redeclared. Only allocate new registers when necessary. No performance impact. * interpreter/Interpreter.cpp: (JSC::Interpreter::execute): * runtime/Executable.cpp: (JSC::ProgramExecutable::initializeGlobalProperties): - Don't allocate the register here. * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::addGlobalVar): - Allocate the register here instead. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120177 <rdar://problem/14811951> Reviewed by Kevin Decker. Move the unavailable plug-in indicator text up one pixel. * rendering/RenderEmbeddedObject.cpp: (WebCore::RenderEmbeddedObject::paintReplaced): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ch.dumez@sisa.samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=107386 Reviewed by Andreas Kling. Source/WebCore: Merge SVGStyledElement into SVGElement to simplify the SVG inheritance model and match the SVG2 specification: https://svgwg.org/svg2-draft/single-page.html#types-InterfaceSVGElement Test: svg/dom/svg2-inheritance.html * CMakeLists.txt: * DerivedSources.cpp: * DerivedSources.make: * DerivedSources.pri: * GNUmakefile.list.am: * Target.pri: * WebCore.order: * WebCore.vcxproj/WebCore.vcxproj: * WebCore.vcxproj/WebCore.vcxproj.filters: * WebCore.xcodeproj/project.pbxproj: * accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::alternativeText): (WebCore::AccessibilityNodeObject::accessibilityDescription): * css/SVGCSSStyleSelector.cpp: * rendering/style/SVGRenderStyle.cpp: * rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::RenderSVGContainer): * rendering/svg/RenderSVGContainer.h: * rendering/svg/RenderSVGHiddenContainer.cpp: (Web...
-
barraclough@apple.com authored
Remove putDirectVirtual Unreviewed, checked in commented out code. :-( * interpreter/Interpreter.cpp: (JSC::Interpreter::execute): - delete commented out code git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120171 Reviewed by Oliver Hunt. Breaks ECMA tests. Source/JavaScriptCore: * runtime/ErrorInstance.cpp: (JSC::ErrorInstance::finishCreation): - None -> DontEnum LayoutTests: * fast/js/exception-properties-expected.txt: * fast/js/script-tests/exception-properties.js: - Update test expectations. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Remove putDirectVirtual Reviewed by Sam Weinig. This could most generously be described as 'vestigial'. No performance impact. * API/JSObjectRef.cpp: (JSObjectSetProperty): - changed to use defineOwnProperty * debugger/DebuggerActivation.cpp: * debugger/DebuggerActivation.h: - remove putDirectVirtual * interpreter/Interpreter.cpp: (JSC::Interpreter::execute): - changed to use defineOwnProperty * runtime/ClassInfo.h: * runtime/JSActivation.cpp: * runtime/JSActivation.h: * runtime/JSCell.cpp: * runtime/JSCell.h: * runtime/JSGlobalObject.cpp: * runtime/JSGlobalObject.h: * runtime/JSObject.cpp: * runtime/JSObject.h: * runtime/JSProxy.cpp: * runtime/JSProxy.h: * runtime/JSSymbolTableObject.cpp: * runtime/JSSymbolTableObject.h: - remove putDirectVirtual * runtime/PropertyDescriptor.h: (JSC::PropertyDescriptor::PropertyDescriptor): - added constructor for convenience git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
<https://webkit.org/b/120163> Reviewed by Anders Carlsson. Rehued by Anders Carlsson. FrameLoader::m_history is never null, so make history() return a reference. Also made HistoryController::m_frame a reference, since HistoryController's lifetime is tied to FrameLoader, which is tied to the Frame. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=119812 Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-22 Reviewed by Geoffrey Garen. Added a check to make sure that the JSValue was an object before casting it as an object. Also, in case the parameterized JSValue has no type, the function now returns the empty string. * runtime/ExceptionHelpers.cpp: (JSC::errorDescriptionForValue): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://webkit.org/b/120165commit-queue@webkit.org authored
Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-08-22 Reviewed by Andy Estes. * Tools/PrettyPrinting/codemirror.css: * Tools/PrettyPrinting/codemirror.js: * Tools/PrettyPrinting/css.js: * Tools/PrettyPrinting/javascript.js: * UserInterface/External/CodeMirror/codemirror.css: * UserInterface/External/CodeMirror/codemirror.js: * UserInterface/External/CodeMirror/css.js: * UserInterface/External/CodeMirror/javascript.js: * UserInterface/External/CodeMirror/xml.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=119377 Reviewed by Anders Carlson. RenderVideo should not claim that it's foreground is opaque unless it has a video frame to display. * rendering/RenderVideo.cpp: (WebCore::RenderVideo::foregroundIsKnownToBeOpaqueInRect): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
* WebDataSource.cpp: (WebDataSource::subresourceForURL): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=115248 Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-08-22 Reviewed by Alexandru Chiculita. * fast/regions/region-min-max-width-support-expected.txt: Added. * fast/regions/region-min-max-width-support.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
* rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
* WebCoreSupport/ChromeClientEfl.cpp: (kit): Source/WebKit/win: Windows build juice. * WebDataSource.cpp: (WebDataSource::representation): (WebDataSource::webFrame): * WebElementPropertyBag.cpp: (WebElementPropertyBag::Read): * WebFramePolicyListener.cpp: (WebFramePolicyListener::receivedPolicyDecision): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120146 Reviewed by Andreas Kling. For the upcoming replacement for webkit-test-results.appspot.com, new-run-webkit-tests needs to use a new JSON format that contains the full summary of the test run including information about passed tests. Add this ability to NRWT so that I can start testing this feature. This patch adds the following optoins to NRWT: --build-slave --got-revision --results-server-host The last option is somewhat ambigious with --test-results-server but we're intending to deprecate the old server so we should be able to delete --test-results-server in time. * Scripts/webkitpy/layout_tests/controllers/manager.py: (Manager.run): (Manager._upload_json_files): (Manager): (Manager.upload_results): * Scripts/webkitpy/layout_tests/models/test_run_results.py: (summarize_results): * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: (summarized_results): (SummarizedResultsTest.test_summarized_results_wontfix): (SummarizedResultsTest): (SummarizedResultsTest.test_summarized_results_include_passes): * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
<https://webkit.org/b/120158> Reviewed by Anders Carlsson. These two are never null so change them to return references. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
* Scripts/webkitpy/tool/bot/irc_command.py: (Hi.execute): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abucur@adobe.com authored
https://bugs.webkit.org/show_bug.cgi?id=119923 Reviewed by Antti Koivisto. Port of https://chromium.googlesource.com/chromium/blink/+/949d7d7e7b8685454742a55cf0ca912bb9a7b177. Original patch by Elliott Sprehn. RenderNamedFlowThread should not create NodeRenderingContext objects RenderNamedFlowThread is using NodeRenderingContext to get the original parent renderer, but should just be using NodeRenderingTraversal::parent instead (which is what NodeRenderingContext does internally anyway). Tests: No change in functionality. No new tests. * rendering/RenderNamedFlowThread.cpp: (WebCore::RenderNamedFlowThread::isChildAllowed): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Update the test expectation accordingly. * platform/mac-wk2/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
Add the failing test expectation to webaudio/codec-tests/mp3/128kbps-44khz.html on Lion Release WK2. The failure is tracked by the bug 120161. * platform/mac-wk2/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
allan.jensen@digia.com authored
https://bugs.webkit.org/show_bug.cgi?id=120151 Reviewed by Simon Hausmann. Since QtInstance had an implementation of getOwnPropertySlot and not getOwnPropertyDescriptor, the behavior of getOwnPropertyDescriptor changed when it got implemented using getOwnPropertySlot in r154300. DRT relied on getOwnPropertyDescriptor returning undefined for JS set properties to distinguish between native Qt methods and JSC bound methods. This patch changes the check to see if the property is writable since the Qt methods are ReadOnly. * DumpRenderTree/qt/DumpRenderTreeQt.cpp: (DumpRenderTree::initJSObjects): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ch.dumez@sisa.samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=120155 Reviewed by Andreas Kling. Introduce a SVGUnknownElement class and have it override rendererIsNeeded() to return false. We now use SVGUnknownElement type (instead of SVGElement) for unknown SVG elements: - Unknown Elements in SVG namespace - Registered custom tag elements in SVG namespace: http://www.w3.org/TR/2013/WD-custom-elements-20130514/#registering-custom-elements As a consequence, SVGElement::rendererIsNeeded() is not longer required to return false and it will be able to behave as SVGStyledElement::rendererIsNeeded() once we merge SVGStyledElement into SVGElement. This is a pre-requirement to merging SVGStyledElement into SVGElement. No new tests, no behavior change. * GNUmakefile.list.am: * Target.pri: * WebCore.vcxproj/WebCore.vcxproj: * WebCore.vcxproj/WebCore.vcxproj.filters: * dom/CustomElementConstructor.cpp: (WebCore::CustomElementConstructor::createElementInternal): * dom/make_names.pl: (defaultParametersHash): (printJSElementIncludes): (printWrapperFunctions): (printWrapperFactoryCppFile): * svg/SVGElement.cpp: * svg/SVGElement.h: * svg/SVGUnknownElement.h: Added. (WebCore::SVGUnknownElement::create): (WebCore::SVGUnknownElement::SVGUnknownElement): * svg/svgtags.in: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120107 Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-08-22 Reviewed by Yong Li. EncodedJSValue parameters must be aligned to even registers for MIPS and ARM EABI. * dfg/DFGSpeculativeJIT.h: (JSC::DFG::SpeculativeJIT::callOperation): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rwlbuis@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=118056 Reviewed by Ryosuke Niwa. Source/WebCore: The assert is hit in Debug mode because the DocumentOrderedMap in HTMLDocument::m_windowNamedItem includes matched SVG elements, but the WindowNameCollection used to collect the elements does not. This means the HTMLCollection stripped of SVG elements could end up hitting the empty or single item assertion, which the testcase verifies. To fix this change WindowNameCollection to include both SVG and HTML elements so it matches DocumentOrderedMap. Tests: svg/custom/document-all-includes-svg.html svg/custom/window-named-item-lookup.html * html/HTMLCollection.cpp: (WebCore::isMatchingElement): (WebCore::HTMLCollection::updateNameCache): LayoutTests: Add test to verify that SVG and HTML elements with id's are both found when using document.all or named properties. * svg/custom/document-all-includes-svg-expected.txt: Added. * svg/custom/document-all-includes-svg.html: Added. * svg/custom/window-named-item-lookup-expected.txt: Added. * svg/custom/window-named-item-lookup.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
gyuyoung.kim@samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=120153 Reviewed by Andreas Kling. As a step to clean-up static_cast<SVGXXX>, toSVGRadialGradientElement() is added to clean-up static_cast<SVGRadialGradientElement*>. * rendering/svg/RenderSVGResourceRadialGradient.cpp: (WebCore::RenderSVGResourceRadialGradient::collectGradientAttributes): * rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::writeSVGResourceContainer): * svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientAttributes): * svg/SVGRadialGradientElement.h: (WebCore::toSVGRadialGradientElement): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
reni@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=119672 Reviewed by Darin Adler. Source/WebCore: The last extractedStyle parameter of removeInlineStyleFromElement() is not mandatory and it's set to default 0. This way we have to check its existence before the usage. Test: editing/execCommand/extracted_style_assert.html * editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): LayoutTests: Test with NULL extractedStyle. * editing/execCommand/extracted_style_assert-expected.txt: Added. * editing/execCommand/extracted_style_assert.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-