1. 23 Aug, 2013 7 commits
  2. 22 Aug, 2013 33 commits
    • commit-queue@webkit.org's avatar
      Need to disable FakeSYSVSHM when sandboxing is not enabled · 9171471c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120182
      <rdar://problem/14814461>
      
      Patch by Simon Cooper <scooper@apple.com> on 2013-08-22
      Reviewed by Alexey Proskuryakov.
      
      When not in a sandbox do not enable the FakeSYSVSHIM. This
      allows LocalConnection to work when Flash Player is run in
      "Unsafe Mode".
      
      * PluginProcess/mac/PluginProcessShim.mm:
      (WebKit::shim_disabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9171471c
    • gyuyoung.kim@samsung.com's avatar
      Introduce toSVGLinearGradientElement(), and use it · 340b3c2a
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120154
      
      Reviewed by Andreas Kling.
      
      As a step to clean-up static_cast<SVGXXX>, toSVGLinearGradientElement() is added to clean-up
      static_cast<SVGLinearGradientElement*>.
      
      * rendering/svg/RenderSVGResourceLinearGradient.cpp:
      (WebCore::RenderSVGResourceLinearGradient::collectGradientAttributes):
      * rendering/svg/SVGRenderTreeAsText.cpp:
      (WebCore::writeSVGResourceContainer):
      * svg/SVGLinearGradientElement.cpp:
      (WebCore::SVGLinearGradientElement::collectGradientAttributes):
      * svg/SVGLinearGradientElement.h:
      (WebCore::toSVGLinearGradientElement):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      340b3c2a
    • mhahnenberg@apple.com's avatar
      JSObject and JSArray code shouldn't have to tiptoe around garbage collection · af9d9722
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120179
      
      Reviewed by Geoffrey Garen.
      
      There are many places in the code for JSObject and JSArray where they are manipulating their
      Butterfly/Structure, e.g. after expanding their out-of-line backing storage via allocating. Within
      these places there are certain "critical sections" where a GC would be disastrous. Gen GC looks
      like it will make this dance even more intricate. To make everybody's lives easier we should use
      the DeferGC mechanism in these functions to make these GC critical sections both obvious in the
      code and trivially safe. Deferring collections will usually only last marginally longer, thus we
      should not incur any additional overhead.
      
      * heap/Heap.h:
      * runtime/JSArray.cpp:
      (JSC::JSArray::unshiftCountSlowCase):
      * runtime/JSObject.cpp:
      (JSC::JSObject::enterDictionaryIndexingModeWhenArrayStorageAlreadyExists):
      (JSC::JSObject::createInitialUndecided):
      (JSC::JSObject::createInitialInt32):
      (JSC::JSObject::createInitialDouble):
      (JSC::JSObject::createInitialContiguous):
      (JSC::JSObject::createArrayStorage):
      (JSC::JSObject::convertUndecidedToArrayStorage):
      (JSC::JSObject::convertInt32ToArrayStorage):
      (JSC::JSObject::convertDoubleToArrayStorage):
      (JSC::JSObject::convertContiguousToArrayStorage):
      (JSC::JSObject::increaseVectorLength):
      (JSC::JSObject::ensureLengthSlow):
      * runtime/JSObject.h:
      (JSC::JSObject::putDirectInternal):
      (JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
      (JSC::JSObject::putDirectWithoutTransition):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af9d9722
    • simon.fraser@apple.com's avatar
      compositing/geometry/bounds-ignores-hidden-dynamic.html has incorrect initial rendering · bd93c753
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119825
      
      Source/WebCore:
      
      Reviewed by Tim Horton.
      
      r137526 and some earlier commits attempted to avoid unconditionally
      repainting layers when their size changes, because this was causing
      TiledBacking layers to repaint when the document size changed.
      
      However, the approach required that we have good information about
      whether size changes require a repaint, which in some cases is hard
      to determine, especially when RenderLayer changes affect our
      decisions about which layers are composited.
      
      Fix by pushing the decision about whether to repaint on size change
      into GraphicsLayer. The default is to repaint on size change,
      but GraphicsLayer provides a function that can be overridden to
      modify this behavior; GraphicsLayerCA does so to avoid repaints
      when layers with TiledBackings get resized.
      
      Test: compositing/repaint/repaint-on-layer-grouping-change.html
      
      * WebCore.exp.in: WebKit2 needs GraphicsLayer::setSize, which is no longer inline.
      * platform/graphics/GraphicsLayer.cpp:
      (WebCore::GraphicsLayer::setOffsetFromRenderer):
      (WebCore::GraphicsLayer::setSize):
      * platform/graphics/GraphicsLayer.h:
      (WebCore::GraphicsLayer::shouldRepaintOnSizeChange):
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::shouldRepaintOnSizeChange):
      * platform/graphics/ca/GraphicsLayerCA.h:
      * rendering/RenderLayerBacking.h: No longer need m_boundsConstrainedByClipping
      * rendering/RenderLayerBacking.cpp:
      (WebCore::RenderLayerBacking::RenderLayerBacking):
      (WebCore::RenderLayerBacking::updateCompositedBounds):
      (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): setSize takes
      care of repainting for us now, so we can remove all the conditional code.
      
      LayoutTests:
      
      Reviewed by Tim Horton.
      
      Test that dumps repaint rects on layers after visibility changes affect
      the layer hierarchy.
      
      * compositing/repaint/repaint-on-layer-grouping-change-expected.txt: Added.
      * compositing/repaint/repaint-on-layer-grouping-change.html: Added.
      * compositing/repaint/resize-repaint-expected.txt: Update result.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd93c753
    • simon.fraser@apple.com's avatar
      Repaint counters are sometimes not in the corner of the compositing layer · efa2c800
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120176
      
      Reviewed by Beth Dakin.
      
      Sometimes the repaint counters are not in the corner of the compositing layer;
      they are either inset, or partially or entirely outside the layer.
      
      Fix by making sure that we restore the CGContext before drawing
      the counter, since the WebCore code may have translated the CTM.
      
      The counter-painting code saves and restores the context itself,
      so this is safe.
      
      * platform/graphics/mac/WebLayer.mm:
      (drawLayerContents):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efa2c800
    • fpizlo@apple.com's avatar
      Update LLVM binary drops and scripts to the latest version from SVN · 35e061d8
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120184
      
      Reviewed by Mark Hahnenberg.
      
      Source/JavaScriptCore: 
      
      * dfg/DFGPlan.cpp:
      (JSC::DFG::Plan::compileInThreadImpl):
      
      Tools: 
      
      * ReducedFTL/build.sh:
      * Scripts/configure-llvm: Added.
      * Scripts/copy-webkitlibraries-to-product-directory:
      * Scripts/export-llvm-build:
      
      WebKitLibraries: 
      
      Updated binary drops to r189066.
      
      * LLVMIncludesMountainLion.tar.bz2:
      * LLVMLibrariesMountainLion.tar.bz2:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35e061d8
    • aestes@apple.com's avatar
      <https://webkit.org/b/120180> Fix issues with OTHER_LDFLAGS in various .xcconfig files · 80801e7b
      aestes@apple.com authored
      Reviewed by David Kilzer.
      
      Source/WebKit2:
      
      Adding ld flags for ASAN overwrote the unexported symbol flags we were
      previously specifying. Since the unexported symbol ld flags are only
      needed for the framework target, move them to WebKit2.xcconfig where we
      can add them to OTHER_LDFLAGS along with the ASAN values inherited from
      DebugRelease.xcconfig (and other values).
      
      * Configurations/Base.xcconfig: Removed the unexported symbol ld flags.
      * Configurations/WebKit2.xcconfig: ... and moved them here.
      
      Tools:
      
      * TestWebKitAPI/Configurations/Base.xcconfig: Removed the definition of
      OTHER_CPLUSPLUSFLAGS since -ftemplate-depth=256 is already set in
      DebugRelease.xcconfig and TestWebKitAPI isn't built in Production.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80801e7b
    • barraclough@apple.com's avatar
      Don't leak registers for redeclared variables · 6962a520
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120174
      
      Reviewed by Geoff Garen.
      
      We currently always allocate registers for new global variables, but these are wasted when the variable is being redeclared.
      Only allocate new registers when necessary.
      
      No performance impact.
      
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::execute):
      * runtime/Executable.cpp:
      (JSC::ProgramExecutable::initializeGlobalProperties):
          - Don't allocate the register here.
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::addGlobalVar):
          - Allocate the register here instead.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6962a520
    • timothy_horton@apple.com's avatar
      Unavailable plug-in indicator text is one pixel too low · 3e8b8d11
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120177
      <rdar://problem/14811951>
      
      Reviewed by Kevin Decker.
      
      Move the unavailable plug-in indicator text up one pixel.
      
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::RenderEmbeddedObject::paintReplaced):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e8b8d11
    • ch.dumez@sisa.samsung.com's avatar
      [SVG2] Merge SVGStyledElement and SVGElement · 7dd31bf9
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107386
      
      Reviewed by Andreas Kling.
      
      Source/WebCore:
      
      Merge SVGStyledElement into SVGElement to simplify the SVG inheritance
      model and match the SVG2 specification:
      https://svgwg.org/svg2-draft/single-page.html#types-InterfaceSVGElement
      
      Test: svg/dom/svg2-inheritance.html
      
      * CMakeLists.txt:
      * DerivedSources.cpp:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.order:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::alternativeText):
      (WebCore::AccessibilityNodeObject::accessibilityDescription):
      * css/SVGCSSStyleSelector.cpp:
      * rendering/style/SVGRenderStyle.cpp:
      * rendering/svg/RenderSVGContainer.cpp:
      (WebCore::RenderSVGContainer::RenderSVGContainer):
      * rendering/svg/RenderSVGContainer.h:
      * rendering/svg/RenderSVGHiddenContainer.cpp:
      (WebCore::RenderSVGHiddenContainer::RenderSVGHiddenContainer):
      * rendering/svg/RenderSVGHiddenContainer.h:
      * rendering/svg/RenderSVGModelObject.cpp:
      (WebCore::RenderSVGModelObject::RenderSVGModelObject):
      (WebCore::getElementCTM):
      * rendering/svg/RenderSVGModelObject.h:
      * rendering/svg/RenderSVGResourceClipper.cpp:
      (WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
      (WebCore::RenderSVGResourceClipper::calculateClipContentRepaintRect):
      (WebCore::RenderSVGResourceClipper::hitTestClipContent):
      * rendering/svg/RenderSVGResourceContainer.cpp:
      (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
      * rendering/svg/RenderSVGResourceContainer.h:
      * rendering/svg/RenderSVGResourceFilter.cpp:
      * rendering/svg/RenderSVGResourceFilterPrimitive.h:
      * rendering/svg/RenderSVGResourceMarker.cpp:
      * rendering/svg/RenderSVGResourceMarker.h:
      * rendering/svg/RenderSVGResourceMasker.cpp:
      (WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
      (WebCore::RenderSVGResourceMasker::calculateMaskContentRepaintRect):
      * rendering/svg/RenderSVGResourcePattern.cpp:
      (WebCore::RenderSVGResourcePattern::createTileImage):
      * rendering/svg/RenderSVGRoot.cpp:
      (WebCore::RenderSVGRoot::RenderSVGRoot):
      * rendering/svg/RenderSVGRoot.h:
      * rendering/svg/RenderSVGViewportContainer.cpp:
      (WebCore::RenderSVGViewportContainer::RenderSVGViewportContainer):
      * rendering/svg/RenderSVGViewportContainer.h:
      * rendering/svg/SVGRenderSupport.cpp:
      (WebCore::SVGRenderSupport::layoutChildren):
      * rendering/svg/SVGRenderTreeAsText.cpp:
      * rendering/svg/SVGResources.cpp:
      (WebCore::registerPendingResource):
      * rendering/svg/SVGResourcesCache.cpp:
      * svg/SVGAElement.cpp:
      (WebCore::SVGAElement::title):
      * svg/SVGAllInOne.cpp:
      * svg/SVGAltGlyphDefElement.h:
      * svg/SVGAltGlyphItemElement.h:
      * svg/SVGAnimateElement.cpp:
      * svg/SVGAnimatedType.cpp:
      (WebCore::SVGAnimatedType::valueAsString):
      (WebCore::SVGAnimatedType::setValueAsString):
      * svg/SVGAnimationElement.cpp:
      (WebCore::SVGAnimationElement::isTargetAttributeCSSProperty):
      (WebCore::SVGAnimationElement::computeCSSPropertyValue):
      (WebCore::SVGAnimationElement::adjustForInheritance):
      (WebCore::inheritsFromProperty):
      * svg/SVGComponentTransferFunctionElement.h:
      * svg/SVGCursorElement.h:
      * svg/SVGDescElement.cpp:
      (WebCore::SVGDescElement::SVGDescElement):
      * svg/SVGDescElement.h:
      * svg/SVGDescElement.idl:
      * svg/SVGElement.cpp:
      (WebCore::mapAttributeToCSSProperty):
      (WebCore::cssPropertyToTypeMap):
      (WebCore::SVGElement::SVGElement):
      (WebCore::SVGElement::~SVGElement):
      (WebCore::SVGElement::removedFrom):
      (WebCore::SVGElement::parseAttribute):
      (WebCore::SVGElement::animatedPropertyTypeForAttribute):
      (WebCore::collectInstancesForSVGElement):
      (WebCore::SVGElement::isAnimatableAttribute):
      (WebCore::SVGElement::title):
      (WebCore::SVGElement::rendererIsNeeded):
      (WebCore::SVGElement::cssPropertyIdForSVGAttributeName):
      (WebCore::SVGElement::isAnimatableCSSProperty):
      (WebCore::SVGElement::isPresentationAttribute):
      (WebCore::SVGElement::collectStyleForPresentationAttribute):
      (WebCore::SVGElement::isKnownAttribute):
      (WebCore::SVGElement::svgAttributeChanged):
      (WebCore::SVGElement::insertedInto):
      (WebCore::SVGElement::buildPendingResourcesIfNeeded):
      (WebCore::SVGElement::childrenChanged):
      (WebCore::SVGElement::getPresentationAttribute):
      (WebCore::SVGElement::instanceUpdatesBlocked):
      (WebCore::SVGElement::setInstanceUpdatesBlocked):
      (WebCore::SVGElement::localCoordinateSpaceTransform):
      (WebCore::SVGElement::updateRelativeLengthsInformation):
      (WebCore::SVGElement::isMouseFocusable):
      (WebCore::SVGElement::isKeyboardFocusable):
      * svg/SVGElement.h:
      (WebCore::SVGElement::supportsMarkers):
      (WebCore::SVGElement::hasRelativeLengths):
      (WebCore::SVGElement::needsPendingResourceHandling):
      (WebCore::SVGElement::selfHasRelativeLengths):
      (WebCore::SVGElement::updateRelativeLengthsInformation):
      * svg/SVGElement.idl:
      * svg/SVGElementInstance.cpp:
      (WebCore::SVGElementInstance::invalidateAllInstancesOfElement):
      (WebCore::SVGElementInstance::InstanceUpdateBlocker::InstanceUpdateBlocker):
      * svg/SVGElementInstance.h:
      * svg/SVGFEBlendElement.idl:
      * svg/SVGFEColorMatrixElement.idl:
      * svg/SVGFEComponentTransferElement.idl:
      * svg/SVGFECompositeElement.idl:
      * svg/SVGFEConvolveMatrixElement.idl:
      * svg/SVGFEDiffuseLightingElement.idl:
      * svg/SVGFEDisplacementMapElement.idl:
      * svg/SVGFEDropShadowElement.idl:
      * svg/SVGFEFloodElement.idl:
      * svg/SVGFEGaussianBlurElement.idl:
      * svg/SVGFEImageElement.idl:
      * svg/SVGFELightElement.h:
      * svg/SVGFEMergeElement.idl:
      * svg/SVGFEMergeNodeElement.h:
      * svg/SVGFEMorphologyElement.idl:
      * svg/SVGFEOffsetElement.idl:
      * svg/SVGFESpecularLightingElement.idl:
      * svg/SVGFETileElement.idl:
      * svg/SVGFETurbulenceElement.idl:
      * svg/SVGFilterElement.cpp:
      (WebCore::SVGFilterElement::SVGFilterElement):
      (WebCore::SVGFilterElement::parseAttribute):
      (WebCore::SVGFilterElement::svgAttributeChanged):
      (WebCore::SVGFilterElement::childrenChanged):
      * svg/SVGFilterElement.h:
      * svg/SVGFilterElement.idl:
      * svg/SVGFilterPrimitiveStandardAttributes.cpp:
      (WebCore::SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes):
      (WebCore::SVGFilterPrimitiveStandardAttributes::parseAttribute):
      (WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
      (WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):
      (WebCore::SVGFilterPrimitiveStandardAttributes::rendererIsNeeded):
      * svg/SVGFilterPrimitiveStandardAttributes.h:
      * svg/SVGFontElement.cpp:
      (WebCore::SVGFontElement::SVGFontElement):
      * svg/SVGFontElement.h:
      * svg/SVGFontFaceElement.cpp:
      * svg/SVGFontFaceElement.h:
      * svg/SVGFontFaceFormatElement.h:
      * svg/SVGFontFaceNameElement.h:
      * svg/SVGFontFaceSrcElement.h:
      * svg/SVGFontFaceUriElement.h:
      * svg/SVGGElement.cpp:
      (WebCore::SVGGElement::rendererIsNeeded):
      * svg/SVGGlyphElement.cpp:
      (WebCore::SVGGlyphElement::SVGGlyphElement):
      (WebCore::SVGGlyphElement::parseAttribute):
      (WebCore::SVGGlyphElement::insertedInto):
      (WebCore::SVGGlyphElement::removedFrom):
      * svg/SVGGlyphElement.h:
      * svg/SVGGlyphRefElement.cpp:
      (WebCore::SVGGlyphRefElement::SVGGlyphRefElement):
      (WebCore::SVGGlyphRefElement::parseAttribute):
      * svg/SVGGlyphRefElement.h:
      * svg/SVGGlyphRefElement.idl:
      * svg/SVGGradientElement.cpp:
      (WebCore::SVGGradientElement::SVGGradientElement):
      (WebCore::SVGGradientElement::parseAttribute):
      (WebCore::SVGGradientElement::svgAttributeChanged):
      (WebCore::SVGGradientElement::childrenChanged):
      * svg/SVGGradientElement.h:
      * svg/SVGGradientElement.idl:
      * svg/SVGGraphicsElement.cpp:
      (WebCore::SVGGraphicsElement::SVGGraphicsElement):
      (WebCore::SVGGraphicsElement::parseAttribute):
      (WebCore::SVGGraphicsElement::svgAttributeChanged):
      * svg/SVGGraphicsElement.h:
      * svg/SVGGraphicsElement.idl:
      * svg/SVGLocatable.cpp:
      (WebCore::SVGLocatable::computeCTM):
      * svg/SVGMPathElement.h:
      * svg/SVGMarkerElement.cpp:
      (WebCore::SVGMarkerElement::SVGMarkerElement):
      (WebCore::SVGMarkerElement::parseAttribute):
      (WebCore::SVGMarkerElement::svgAttributeChanged):
      (WebCore::SVGMarkerElement::childrenChanged):
      * svg/SVGMarkerElement.h:
      * svg/SVGMarkerElement.idl:
      * svg/SVGMaskElement.cpp:
      (WebCore::SVGMaskElement::SVGMaskElement):
      (WebCore::SVGMaskElement::parseAttribute):
      (WebCore::SVGMaskElement::svgAttributeChanged):
      (WebCore::SVGMaskElement::childrenChanged):
      * svg/SVGMaskElement.h:
      * svg/SVGMaskElement.idl:
      * svg/SVGMetadataElement.h:
      * svg/SVGMissingGlyphElement.cpp:
      (WebCore::SVGMissingGlyphElement::SVGMissingGlyphElement):
      * svg/SVGMissingGlyphElement.h:
      * svg/SVGMissingGlyphElement.idl:
      * svg/SVGPatternElement.cpp:
      (WebCore::SVGPatternElement::SVGPatternElement):
      (WebCore::SVGPatternElement::parseAttribute):
      (WebCore::SVGPatternElement::svgAttributeChanged):
      (WebCore::SVGPatternElement::childrenChanged):
      * svg/SVGPatternElement.h:
      * svg/SVGPatternElement.idl:
      * svg/SVGScriptElement.h:
      * svg/SVGStopElement.cpp:
      (WebCore::SVGStopElement::SVGStopElement):
      (WebCore::SVGStopElement::parseAttribute):
      (WebCore::SVGStopElement::svgAttributeChanged):
      * svg/SVGStopElement.h:
      * svg/SVGStopElement.idl:
      * svg/SVGStyleElement.h:
      * svg/SVGStyledElement.cpp: Removed.
      * svg/SVGStyledElement.h: Removed.
      * svg/SVGStyledElement.idl: Removed.
      * svg/SVGSymbolElement.cpp:
      (WebCore::SVGSymbolElement::SVGSymbolElement):
      (WebCore::SVGSymbolElement::parseAttribute):
      (WebCore::SVGSymbolElement::svgAttributeChanged):
      * svg/SVGSymbolElement.h:
      * svg/SVGSymbolElement.idl:
      * svg/SVGTRefElement.cpp:
      (WebCore::SVGTRefElement::insertedInto):
      (WebCore::SVGTRefElement::removedFrom):
      * svg/SVGTitleElement.cpp:
      (WebCore::SVGTitleElement::SVGTitleElement):
      (WebCore::SVGTitleElement::insertedInto):
      * svg/SVGTitleElement.h:
      * svg/SVGTitleElement.idl:
      * svg/SVGTransformable.cpp:
      * svg/SVGUseElement.cpp:
      (WebCore::SVGUseElement::selfHasRelativeLengths):
      * svg/SVGViewElement.cpp:
      (WebCore::SVGViewElement::SVGViewElement):
      (WebCore::SVGViewElement::parseAttribute):
      * svg/SVGViewElement.h:
      * svg/animation/SVGSMILElement.h:
      * svg/graphics/filters/SVGFEImage.cpp:
      (WebCore::FEImage::platformApplySoftware):
      
      LayoutTests:
      
      Add layout test to validate the SVG2 inheritance model.
      
      * svg/dom/svg2-inheritance-expected.txt: Added.
      * svg/dom/svg2-inheritance.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dd31bf9
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=120128 · 7fb93c58
      barraclough@apple.com authored
      Remove putDirectVirtual
      
      Unreviewed, checked in commented out code. :-(
      
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::execute):
          - delete commented out code
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fb93c58
    • barraclough@apple.com's avatar
      Error.stack should not be enumerable · a928469d
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120171
      
      Reviewed by Oliver Hunt.
      
      Breaks ECMA tests.
      
      Source/JavaScriptCore: 
      
      * runtime/ErrorInstance.cpp:
      (JSC::ErrorInstance::finishCreation):
          - None -> DontEnum
      
      LayoutTests: 
      
      * fast/js/exception-properties-expected.txt:
      * fast/js/script-tests/exception-properties.js:
          - Update test expectations.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a928469d
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=120128 · dd40a7eb
      barraclough@apple.com authored
      Remove putDirectVirtual
      
      Reviewed by Sam Weinig.
      
      This could most generously be described as 'vestigial'.
      No performance impact.
      
      * API/JSObjectRef.cpp:
      (JSObjectSetProperty):
          - changed to use defineOwnProperty
      * debugger/DebuggerActivation.cpp:
      * debugger/DebuggerActivation.h:
          - remove putDirectVirtual
      * interpreter/Interpreter.cpp:
      (JSC::Interpreter::execute):
          - changed to use defineOwnProperty
      * runtime/ClassInfo.h:
      * runtime/JSActivation.cpp:
      * runtime/JSActivation.h:
      * runtime/JSCell.cpp:
      * runtime/JSCell.h:
      * runtime/JSGlobalObject.cpp:
      * runtime/JSGlobalObject.h:
      * runtime/JSObject.cpp:
      * runtime/JSObject.h:
      * runtime/JSProxy.cpp:
      * runtime/JSProxy.h:
      * runtime/JSSymbolTableObject.cpp:
      * runtime/JSSymbolTableObject.h:
          - remove putDirectVirtual
      * runtime/PropertyDescriptor.h:
      (JSC::PropertyDescriptor::PropertyDescriptor):
          - added constructor for convenience
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd40a7eb
    • akling@apple.com's avatar
      FrameLoader::history() should return a reference. · 672cb851
      akling@apple.com authored
      <https://webkit.org/b/120163>
      
      Reviewed by Anders Carlsson.
      
      Rehued by Anders Carlsson.
      
      FrameLoader::m_history is never null, so make history() return a reference.
      Also made HistoryController::m_frame a reference, since HistoryController's
      lifetime is tied to FrameLoader, which is tied to the Frame.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      672cb851
    • commit-queue@webkit.org's avatar
      errorDescriptionForValue() should not assume error value is an Object · ac4bd2b4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119812
      
      Patch by Chris Curtis <chris_curtis@apple.com> on 2013-08-22
      Reviewed by Geoffrey Garen.
      
      Added a check to make sure that the JSValue was an object before casting it as an object. Also, in case the parameterized JSValue
      has no type, the function now returns the empty string.
      * runtime/ExceptionHelpers.cpp:
      (JSC::errorDescriptionForValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac4bd2b4
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/120165> Web Inspector: Update CodeMirror to 3.16.1 · ecd377bf
      commit-queue@webkit.org authored
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-08-22
      Reviewed by Andy Estes.
      
      * Tools/PrettyPrinting/codemirror.css:
      * Tools/PrettyPrinting/codemirror.js:
      * Tools/PrettyPrinting/css.js:
      * Tools/PrettyPrinting/javascript.js:
      * UserInterface/External/CodeMirror/codemirror.css:
      * UserInterface/External/CodeMirror/codemirror.js:
      * UserInterface/External/CodeMirror/css.js:
      * UserInterface/External/CodeMirror/javascript.js:
      * UserInterface/External/CodeMirror/xml.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ecd377bf
    • simon.fraser@apple.com's avatar
      Reloading this video test shows garbage briefly · ed839845
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119377
      
      Reviewed by Anders Carlson.
      
      RenderVideo should not claim that it's foreground is opaque
      unless it has a video frame to display.
      
      * rendering/RenderVideo.cpp:
      (WebCore::RenderVideo::foregroundIsKnownToBeOpaqueInRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed839845
    • akling@apple.com's avatar
      Another Windows build fix. · 03ddc910
      akling@apple.com authored
      * WebDataSource.cpp:
      (WebDataSource::subresourceForURL):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03ddc910
    • commit-queue@webkit.org's avatar
      [CSSRegions] Min-width and max-width for a region should support values other than length · 48e1efd2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115248
      
      Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-08-22
      Reviewed by Alexandru Chiculita.
      
      * fast/regions/region-min-max-width-support-expected.txt: Added.
      * fast/regions/region-min-max-width-support.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48e1efd2
    • akling@apple.com's avatar
      Remove accidental cruft from r154449. · 7817de29
      akling@apple.com authored
      * rendering/RenderWidget.cpp:
      (WebCore::RenderWidget::destroy):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7817de29
    • akling@apple.com's avatar
      Source/WebKit/efl: EFL build juice. · 0ffb633d
      akling@apple.com authored
      * WebCoreSupport/ChromeClientEfl.cpp:
      (kit):
      
      Source/WebKit/win: Windows build juice.
      
      * WebDataSource.cpp:
      (WebDataSource::representation):
      (WebDataSource::webFrame):
      * WebElementPropertyBag.cpp:
      (WebElementPropertyBag::Read):
      * WebFramePolicyListener.cpp:
      (WebFramePolicyListener::receivedPolicyDecision):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ffb633d
    • rniwa@webkit.org's avatar
      NRWT: Add the ability to upload test results to new test results server · 8f2f2889
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120146
      
      Reviewed by Andreas Kling.
              
      For the upcoming replacement for webkit-test-results.appspot.com, new-run-webkit-tests needs to use a new JSON format
      that contains the full summary of the test run including information about passed tests.
      
      Add this ability to NRWT so that I can start testing this feature. This patch adds the following optoins to NRWT:
      --build-slave
      --got-revision
      --results-server-host
      
      The last option is somewhat ambigious with --test-results-server but we're intending to deprecate the old server
      so we should be able to delete --test-results-server in time.
      
      * Scripts/webkitpy/layout_tests/controllers/manager.py:
      (Manager.run):
      (Manager._upload_json_files):
      (Manager):
      (Manager.upload_results):
      * Scripts/webkitpy/layout_tests/models/test_run_results.py:
      (summarize_results):
      * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
      (summarized_results):
      (SummarizedResultsTest.test_summarized_results_wontfix):
      (SummarizedResultsTest):
      (SummarizedResultsTest.test_summarized_results_include_passes):
      * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
      (parse_args):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f2f2889
    • akling@apple.com's avatar
      FrameLoader: frame() and client() should return references. · 7f50aae5
      akling@apple.com authored
      <https://webkit.org/b/120158>
      
      Reviewed by Anders Carlsson.
      
      These two are never null so change them to return references.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f50aae5
    • rniwa@webkit.org's avatar
      WKR build fix. Somehow tool.bugs.quips() doesn't work in WKR so work around that. · 88bb5399
      rniwa@webkit.org authored
      * Scripts/webkitpy/tool/bot/irc_command.py:
      (Hi.execute):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88bb5399
    • abucur@adobe.com's avatar
      RenderNamedFlowThread should not create NodeRenderingContext objects · 948ea290
      abucur@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119923
      
      Reviewed by Antti Koivisto.
      
      Port of https://chromium.googlesource.com/chromium/blink/+/949d7d7e7b8685454742a55cf0ca912bb9a7b177.
      Original patch by Elliott Sprehn.
      
      RenderNamedFlowThread should not create NodeRenderingContext objects
      
      RenderNamedFlowThread is using NodeRenderingContext to get the original
      parent renderer, but should just be using NodeRenderingTraversal::parent
      instead (which is what NodeRenderingContext does internally anyway).
      
      Tests: No change in functionality. No new tests.
      
      * rendering/RenderNamedFlowThread.cpp:
      (WebCore::RenderNamedFlowThread::isChildAllowed):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      948ea290
    • rniwa@webkit.org's avatar
      Actually, this test is failing on Debug builds as well. · d79fd74a
      rniwa@webkit.org authored
      Update the test expectation accordingly.
      
      * platform/mac-wk2/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d79fd74a
    • rniwa@webkit.org's avatar
      Add the failing test expectation to... · a1c40807
      rniwa@webkit.org authored
      Add the failing test expectation to webaudio/codec-tests/mp3/128kbps-44khz.html on Lion Release WK2.
      The failure is tracked by the bug 120161.
      
      * platform/mac-wk2/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1c40807
    • allan.jensen@digia.com's avatar
      [Qt] DRT bug revealed/caused by r154300 · 7c45fdba
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120151
      
      Reviewed by Simon Hausmann.
      
      Since QtInstance had an implementation of getOwnPropertySlot and not getOwnPropertyDescriptor,
      the behavior of getOwnPropertyDescriptor changed when it got implemented using getOwnPropertySlot
      in r154300.
      
      DRT relied on getOwnPropertyDescriptor returning undefined for JS set properties to distinguish
      between native Qt methods and JSC bound methods. This patch changes the check to see if the
      property is writable since the Qt methods are ReadOnly.
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (DumpRenderTree::initJSObjects):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c45fdba
    • ch.dumez@sisa.samsung.com's avatar
      Introduce a SVGUnknownElement class for unknown SVG elements · eebecacc
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120155
      
      Reviewed by Andreas Kling.
      
      Introduce a SVGUnknownElement class and have it override rendererIsNeeded() to return false.
      We now use SVGUnknownElement type (instead of SVGElement) for unknown SVG elements:
      - Unknown Elements in SVG namespace
      - Registered custom tag elements in SVG namespace:
        http://www.w3.org/TR/2013/WD-custom-elements-20130514/#registering-custom-elements
      
      As a consequence, SVGElement::rendererIsNeeded() is not longer required to return false and
      it will be able to behave as SVGStyledElement::rendererIsNeeded() once we merge
      SVGStyledElement into SVGElement.
      
      This is a pre-requirement to merging SVGStyledElement into SVGElement.
      
      No new tests, no behavior change.
      
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * dom/CustomElementConstructor.cpp:
      (WebCore::CustomElementConstructor::createElementInternal):
      * dom/make_names.pl:
      (defaultParametersHash):
      (printJSElementIncludes):
      (printWrapperFunctions):
      (printWrapperFactoryCppFile):
      * svg/SVGElement.cpp:
      * svg/SVGElement.h:
      * svg/SVGUnknownElement.h: Added.
      (WebCore::SVGUnknownElement::create):
      (WebCore::SVGUnknownElement::SVGUnknownElement):
      * svg/svgtags.in:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eebecacc
    • commit-queue@webkit.org's avatar
      Fix P_DFGOperation_EJS call for MIPS and ARM EABI. · 1d087101
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120107
      
      Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-08-22
      Reviewed by Yong Li.
      
      EncodedJSValue parameters must be aligned to even registers for MIPS and ARM EABI.
      
      * dfg/DFGSpeculativeJIT.h:
      (JSC::DFG::SpeculativeJIT::callOperation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d087101
    • rwlbuis@webkit.org's avatar
      REGRESSION: Assertion failure !collection->hasExactlyOneItem() in WebCore::namedItemGetter · f02f5da6
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118056
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      The assert is hit in Debug mode because the DocumentOrderedMap in HTMLDocument::m_windowNamedItem
      includes matched SVG elements, but the WindowNameCollection used to collect the elements does not.
      This means the HTMLCollection stripped of SVG elements could end up hitting the empty or single item
      assertion, which the testcase verifies.
      To fix this change WindowNameCollection to include both SVG and HTML elements so it matches DocumentOrderedMap.
      
      Tests: svg/custom/document-all-includes-svg.html
             svg/custom/window-named-item-lookup.html
      
      * html/HTMLCollection.cpp:
      (WebCore::isMatchingElement):
      (WebCore::HTMLCollection::updateNameCache):
      
      LayoutTests:
      
      Add test to verify that SVG and HTML elements with id's are both found when using document.all or named properties.
      
      * svg/custom/document-all-includes-svg-expected.txt: Added.
      * svg/custom/document-all-includes-svg.html: Added.
      * svg/custom/window-named-item-lookup-expected.txt: Added.
      * svg/custom/window-named-item-lookup.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f02f5da6
    • gyuyoung.kim@samsung.com's avatar
      Introduce toSVGRadialGradientElement(), and use it · da36125d
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120153
      
      Reviewed by Andreas Kling.
      
      As a step to clean-up static_cast<SVGXXX>, toSVGRadialGradientElement() is added to clean-up
      static_cast<SVGRadialGradientElement*>.
      
      * rendering/svg/RenderSVGResourceRadialGradient.cpp:
      (WebCore::RenderSVGResourceRadialGradient::collectGradientAttributes):
      * rendering/svg/SVGRenderTreeAsText.cpp:
      (WebCore::writeSVGResourceContainer):
      * svg/SVGRadialGradientElement.cpp:
      (WebCore::SVGRadialGradientElement::collectGradientAttributes):
      * svg/SVGRadialGradientElement.h:
      (WebCore::toSVGRadialGradientElement):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da36125d
    • reni@webkit.org's avatar
      ASSERTION FAILED: extractedStyle in WebCore::ApplyStyleCommand::removeInlineStyleFromElement · 82857b28
      reni@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119672
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      The last extractedStyle parameter of removeInlineStyleFromElement() is not mandatory and it's set
      to default 0. This way we have to check its existence before the usage.
      
      Test: editing/execCommand/extracted_style_assert.html
      
      * editing/ApplyStyleCommand.cpp:
      (WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
      
      LayoutTests:
      
      Test with NULL extractedStyle.
      
      * editing/execCommand/extracted_style_assert-expected.txt: Added.
      * editing/execCommand/extracted_style_assert.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82857b28