1. 03 Mar, 2010 40 commits
    • ukai@chromium.org's avatar
      2010-03-03 Yuta Kitamura <yutak@chromium.org> · d60141d7
      ukai@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              Add a new class that stores information about Web Socket handshake request.
      
              Instances of this class contain the necessary information to send a Web Socket
              handshake request. In the future, this class will provide request information
              to the Web Inspector.
      
              WebSocketHandshake needs to provide request information
              https://bugs.webkit.org/show_bug.cgi?id=34784
      
              No new tests, since the current tests will suffice (LayoutTests/websocket/*).
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * websockets/WebSocketChannel.cpp:
              * websockets/WebSocketHandshake.cpp:
              (WebCore::WebSocketHandshake::clientHandshakeMessage):
              (WebCore::WebSocketHandshake::clientHandshakeRequest):
              * websockets/WebSocketHandshake.h:
              * websockets/WebSocketHandshakeRequest.cpp: Added.
              (WebCore::WebSocketHandshakeRequest::WebSocketHandshakeRequest):
              (WebCore::WebSocketHandshakeRequest::~WebSocketHandshakeRequest):
              (WebCore::WebSocketHandshakeRequest::addExtraHeaderField):
              (WebCore::WebSocketHandshakeRequest::headerFields):
              (WebCore::WebSocketHandshakeRequest::host):
              * websockets/WebSocketHandshakeRequest.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d60141d7
    • eric@webkit.org's avatar
      2010-03-03 Laszlo Gombos <laszlo.1.gombos@nokia.com> · f0abe7b4
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Build fix after r55452.
      
              No new tests, this is a build fix.
      
              * page/Settings.cpp:
              (WebCore::Settings::setDatabasesEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0abe7b4
    • alice.liu@apple.com's avatar
      Add a way to get an iframe's content frame · b0b564f6
      alice.liu@apple.com authored
      Reviewed by Jon Honeycutt.
      
      * DOMCoreClasses.cpp:
      (DOMElement::createInstance):
      Added case for DOMHTMLIFrameElement
      * DOMHTMLClasses.cpp:
      Adding the few DOMHTMLIFrameElement functions definitions that have 
      distinct implementations (all others just call parent implementation)
      (DOMHTMLIFrameElement::QueryInterface):
      (DOMHTMLIFrameElement::contentFrame):
      * DOMHTMLClasses.h:
      Most of these function declarations have definitions that just call the parent implementation
      (DOMHTMLIFrameElement::DOMHTMLIFrameElement):
      (DOMHTMLIFrameElement::AddRef):
      (DOMHTMLIFrameElement::Release):
      (DOMHTMLIFrameElement::throwException):
      (DOMHTMLIFrameElement::callWebScriptMethod):
      (DOMHTMLIFrameElement::evaluateWebScript):
      (DOMHTMLIFrameElement::removeWebScriptKey):
      (DOMHTMLIFrameElement::stringRepresentation):
      (DOMHTMLIFrameElement::webScriptValueAtIndex):
      (DOMHTMLIFrameElement::setWebScriptValueAtIndex):
      (DOMHTMLIFrameElement::setException):
      (DOMHTMLIFrameElement::nodeName):
      (DOMHTMLIFrameElement::nodeValue):
      (DOMHTMLIFrameElement::setNodeValue):
      (DOMHTMLIFrameElement::nodeType):
      (DOMHTMLIFrameElement::parentNode):
      (DOMHTMLIFrameElement::childNodes):
      (DOMHTMLIFrameElement::firstChild):
      (DOMHTMLIFrameElement::lastChild):
      (DOMHTMLIFrameElement::previousSibling):
      (DOMHTMLIFrameElement::nextSibling):
      (DOMHTMLIFrameElement::attributes):
      (DOMHTMLIFrameElement::ownerDocument):
      (DOMHTMLIFrameElement::insertBefore):
      (DOMHTMLIFrameElement::replaceChild):
      (DOMHTMLIFrameElement::removeChild):
      (DOMHTMLIFrameElement::appendChild):
      (DOMHTMLIFrameElement::hasChildNodes):
      (DOMHTMLIFrameElement::cloneNode):
      (DOMHTMLIFrameElement::normalize):
      (DOMHTMLIFrameElement::isSupported):
      (DOMHTMLIFrameElement::namespaceURI):
      (DOMHTMLIFrameElement::prefix):
      (DOMHTMLIFrameElement::setPrefix):
      (DOMHTMLIFrameElement::localName):
      (DOMHTMLIFrameElement::hasAttributes):
      (DOMHTMLIFrameElement::isSameNode):
      (DOMHTMLIFrameElement::isEqualNode):
      (DOMHTMLIFrameElement::textContent):
      (DOMHTMLIFrameElement::setTextContent):
      (DOMHTMLIFrameElement::tagName):
      (DOMHTMLIFrameElement::getAttribute):
      (DOMHTMLIFrameElement::setAttribute):
      (DOMHTMLIFrameElement::removeAttribute):
      (DOMHTMLIFrameElement::getAttributeNode):
      (DOMHTMLIFrameElement::setAttributeNode):
      (DOMHTMLIFrameElement::removeAttributeNode):
      (DOMHTMLIFrameElement::getElementsByTagName):
      (DOMHTMLIFrameElement::getAttributeNS):
      (DOMHTMLIFrameElement::setAttributeNS):
      (DOMHTMLIFrameElement::removeAttributeNS):
      (DOMHTMLIFrameElement::getAttributeNodeNS):
      (DOMHTMLIFrameElement::setAttributeNodeNS):
      (DOMHTMLIFrameElement::getElementsByTagNameNS):
      (DOMHTMLIFrameElement::hasAttribute):
      (DOMHTMLIFrameElement::hasAttributeNS):
      (DOMHTMLIFrameElement::focus):
      (DOMHTMLIFrameElement::blur):
      (DOMHTMLIFrameElement::idName):
      (DOMHTMLIFrameElement::setIdName):
      (DOMHTMLIFrameElement::title):
      (DOMHTMLIFrameElement::setTitle):
      (DOMHTMLIFrameElement::lang):
      (DOMHTMLIFrameElement::setLang):
      (DOMHTMLIFrameElement::dir):
      (DOMHTMLIFrameElement::setDir):
      (DOMHTMLIFrameElement::className):
      (DOMHTMLIFrameElement::setClassName):
      (DOMHTMLIFrameElement::innerHTML):
      (DOMHTMLIFrameElement::setInnerHTML):
      (DOMHTMLIFrameElement::innerText):
      (DOMHTMLIFrameElement::setInnerText):
      * Interfaces/DOMHTML.idl:
      Added IDOMHTMLIFrameElement interface
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0b564f6
    • eric@webkit.org's avatar
      2010-03-03 Jedrzej Nowacki <jedrzej.nowacki@nokia.com> · 91d07a69
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              QScriptValue::isObject fix.
      
              Fix broken internal state evaluation from JSValue to JSNative / JSObject.
              New function was introduced which should take care about promoting
              JSValue state inside QScriptValuePrivate. It should be used instead of a
              direct JSC C API call.
      
              The bug exposed a weakness in autotest suite, as the QScriptValuePrivate
              is based on state machine with lazy state evaluation, there is a possibility
              that serial sequencial calls to the same public const function could return
              different results. The patch fix the issue.
      
              [Qt] Sometimes QScriptValue::isObject returns an incorrect value
              https://bugs.webkit.org/show_bug.cgi?id=35387
      
              * qt/api/qscriptvalue_p.h:
              (QScriptValuePrivate::isBool):
              (QScriptValuePrivate::isNumber):
              (QScriptValuePrivate::isNull):
              (QScriptValuePrivate::isString):
              (QScriptValuePrivate::isUndefined):
              (QScriptValuePrivate::isError):
              (QScriptValuePrivate::isObject):
              (QScriptValuePrivate::isFunction):
              (QScriptValuePrivate::call):
              (QScriptValuePrivate::refineJSValue):
              * qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp:
              (tst_QScriptValue::initScriptValues):
              (tst_QScriptValue::isValid_makeData):
              (tst_QScriptValue::isValid_test):
              (tst_QScriptValue::isBool_makeData):
              (tst_QScriptValue::isBool_test):
              (tst_QScriptValue::isBoolean_makeData):
              (tst_QScriptValue::isBoolean_test):
              (tst_QScriptValue::isNumber_makeData):
              (tst_QScriptValue::isNumber_test):
              (tst_QScriptValue::isFunction_test):
              (tst_QScriptValue::isNull_makeData):
              (tst_QScriptValue::isNull_test):
              (tst_QScriptValue::isString_makeData):
              (tst_QScriptValue::isString_test):
              (tst_QScriptValue::isUndefined_makeData):
              (tst_QScriptValue::isUndefined_test):
              (tst_QScriptValue::isObject_makeData):
              (tst_QScriptValue::isObject_test):
              (tst_QScriptValue::toString_makeData):
              (tst_QScriptValue::toString_test):
              (tst_QScriptValue::toNumber_makeData):
              (tst_QScriptValue::toNumber_test):
              (tst_QScriptValue::toBool_makeData):
              (tst_QScriptValue::toBool_test):
              (tst_QScriptValue::toBoolean_makeData):
              (tst_QScriptValue::toBoolean_test):
              (tst_QScriptValue::toInteger_makeData):
              (tst_QScriptValue::toInteger_test):
              (tst_QScriptValue::toInt32_makeData):
              (tst_QScriptValue::toInt32_test):
              (tst_QScriptValue::toUInt32_makeData):
              (tst_QScriptValue::toUInt32_test):
              (tst_QScriptValue::toUInt16_makeData):
              (tst_QScriptValue::toUInt16_test):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91d07a69
    • eric@webkit.org's avatar
      2010-03-03 Diego Gonzalez <diego.gonzalez@openbossa.org> · 70b14116
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Make keyIdentifierForQtKeyCode return the unicode backspace value on Qt PlatformKeyboardEvent
      
              LayoutTests:
                  fast/events/key-events-in-input-text.html
                  fast/events/special-key-events-in-input-text.html
      
              [Qt] Return the unicode backspace value in keyIdentifierForQtKeyCode on Qt PlatformKeyboardEvent
              https://bugs.webkit.org/show_bug.cgi?id=35694
      
              * platform/qt/Skipped:
      2010-03-03  Diego Gonzalez  <diego.gonzalez@openbossa.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Make keyIdentifierForQtKeyCode return the unicode backspace value on Qt PlatformKeyboardEvent
      
              LayoutTests:
                  fast/events/key-events-in-input-text.html
                  fast/events/special-key-events-in-input-text.html
      
              [Qt] Return the unicode backspace value in keyIdentifierForQtKeyCode on Qt PlatformKeyboardEvent
              https://bugs.webkit.org/show_bug.cgi?id=35694
      
              * platform/qt/PlatformKeyboardEventQt.cpp:
              (WebCore::keyIdentifierForQtKeyCode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70b14116
    • eric@webkit.org's avatar
      2010-03-03 Chao-ying Fu <fu@mips.com> · 19100841
      eric@webkit.org authored
              Reviewed by Gavin Barraclough.
      
              MIPS JIT Supports
              https://bugs.webkit.org/show_bug.cgi?id=30144
      
              The following changes enable MIPS YARR and YARR_JIT.
      
              * assembler/AbstractMacroAssembler.h:
              (JSC::AbstractMacroAssembler::Imm32::Imm32):
              * assembler/MIPSAssembler.h: Added.
              (JSC::MIPSRegisters::):
              (JSC::MIPSAssembler::MIPSAssembler):
              (JSC::MIPSAssembler::):
              (JSC::MIPSAssembler::JmpSrc::JmpSrc):
              (JSC::MIPSAssembler::JmpDst::JmpDst):
              (JSC::MIPSAssembler::JmpDst::isUsed):
              (JSC::MIPSAssembler::JmpDst::used):
              (JSC::MIPSAssembler::emitInst):
              (JSC::MIPSAssembler::nop):
              (JSC::MIPSAssembler::loadDelayNop):
              (JSC::MIPSAssembler::copDelayNop):
              (JSC::MIPSAssembler::move):
              (JSC::MIPSAssembler::li):
              (JSC::MIPSAssembler::lui):
              (JSC::MIPSAssembler::addiu):
              (JSC::MIPSAssembler::addu):
              (JSC::MIPSAssembler::subu):
              (JSC::MIPSAssembler::mult):
              (JSC::MIPSAssembler::mfhi):
              (JSC::MIPSAssembler::mflo):
              (JSC::MIPSAssembler::mul):
              (JSC::MIPSAssembler::andInsn):
              (JSC::MIPSAssembler::andi):
              (JSC::MIPSAssembler::nor):
              (JSC::MIPSAssembler::orInsn):
              (JSC::MIPSAssembler::ori):
              (JSC::MIPSAssembler::xorInsn):
              (JSC::MIPSAssembler::xori):
              (JSC::MIPSAssembler::slt):
              (JSC::MIPSAssembler::sltu):
              (JSC::MIPSAssembler::sltiu):
              (JSC::MIPSAssembler::sll):
              (JSC::MIPSAssembler::sllv):
              (JSC::MIPSAssembler::sra):
              (JSC::MIPSAssembler::srav):
              (JSC::MIPSAssembler::lw):
              (JSC::MIPSAssembler::lwl):
              (JSC::MIPSAssembler::lwr):
              (JSC::MIPSAssembler::lhu):
              (JSC::MIPSAssembler::sw):
              (JSC::MIPSAssembler::jr):
              (JSC::MIPSAssembler::jalr):
              (JSC::MIPSAssembler::jal):
              (JSC::MIPSAssembler::bkpt):
              (JSC::MIPSAssembler::bgez):
              (JSC::MIPSAssembler::bltz):
              (JSC::MIPSAssembler::beq):
              (JSC::MIPSAssembler::bne):
              (JSC::MIPSAssembler::bc1t):
              (JSC::MIPSAssembler::bc1f):
              (JSC::MIPSAssembler::newJmpSrc):
              (JSC::MIPSAssembler::appendJump):
              (JSC::MIPSAssembler::addd):
              (JSC::MIPSAssembler::subd):
              (JSC::MIPSAssembler::muld):
              (JSC::MIPSAssembler::lwc1):
              (JSC::MIPSAssembler::ldc1):
              (JSC::MIPSAssembler::swc1):
              (JSC::MIPSAssembler::sdc1):
              (JSC::MIPSAssembler::mtc1):
              (JSC::MIPSAssembler::mfc1):
              (JSC::MIPSAssembler::truncwd):
              (JSC::MIPSAssembler::cvtdw):
              (JSC::MIPSAssembler::ceqd):
              (JSC::MIPSAssembler::cngtd):
              (JSC::MIPSAssembler::cnged):
              (JSC::MIPSAssembler::cltd):
              (JSC::MIPSAssembler::cled):
              (JSC::MIPSAssembler::cueqd):
              (JSC::MIPSAssembler::coled):
              (JSC::MIPSAssembler::coltd):
              (JSC::MIPSAssembler::culed):
              (JSC::MIPSAssembler::cultd):
              (JSC::MIPSAssembler::label):
              (JSC::MIPSAssembler::align):
              (JSC::MIPSAssembler::getRelocatedAddress):
              (JSC::MIPSAssembler::getDifferenceBetweenLabels):
              (JSC::MIPSAssembler::size):
              (JSC::MIPSAssembler::executableCopy):
              (JSC::MIPSAssembler::getCallReturnOffset):
              (JSC::MIPSAssembler::linkJump):
              (JSC::MIPSAssembler::linkCall):
              (JSC::MIPSAssembler::linkPointer):
              (JSC::MIPSAssembler::relinkJump):
              (JSC::MIPSAssembler::relinkCall):
              (JSC::MIPSAssembler::repatchInt32):
              (JSC::MIPSAssembler::repatchPointer):
              (JSC::MIPSAssembler::repatchLoadPtrToLEA):
              (JSC::MIPSAssembler::relocateJumps):
              (JSC::MIPSAssembler::linkWithOffset):
              (JSC::MIPSAssembler::linkCallInternal):
              * assembler/MacroAssembler.h:
              * assembler/MacroAssemblerMIPS.h: Added.
              (JSC::MacroAssemblerMIPS::MacroAssemblerMIPS):
              (JSC::MacroAssemblerMIPS::):
              (JSC::MacroAssemblerMIPS::add32):
              (JSC::MacroAssemblerMIPS::and32):
              (JSC::MacroAssemblerMIPS::lshift32):
              (JSC::MacroAssemblerMIPS::mul32):
              (JSC::MacroAssemblerMIPS::not32):
              (JSC::MacroAssemblerMIPS::or32):
              (JSC::MacroAssemblerMIPS::rshift32):
              (JSC::MacroAssemblerMIPS::sub32):
              (JSC::MacroAssemblerMIPS::xor32):
              (JSC::MacroAssemblerMIPS::load32):
              (JSC::MacroAssemblerMIPS::load32WithUnalignedHalfWords):
              (JSC::MacroAssemblerMIPS::load32WithAddressOffsetPatch):
              (JSC::MacroAssemblerMIPS::loadPtrWithPatchToLEA):
              (JSC::MacroAssemblerMIPS::loadPtrWithAddressOffsetPatch):
              (JSC::MacroAssemblerMIPS::load16):
              (JSC::MacroAssemblerMIPS::store32WithAddressOffsetPatch):
              (JSC::MacroAssemblerMIPS::store32):
              (JSC::MacroAssemblerMIPS::supportsFloatingPoint):
              (JSC::MacroAssemblerMIPS::supportsFloatingPointTruncate):
              (JSC::MacroAssemblerMIPS::pop):
              (JSC::MacroAssemblerMIPS::push):
              (JSC::MacroAssemblerMIPS::move):
              (JSC::MacroAssemblerMIPS::swap):
              (JSC::MacroAssemblerMIPS::signExtend32ToPtr):
              (JSC::MacroAssemblerMIPS::zeroExtend32ToPtr):
              (JSC::MacroAssemblerMIPS::branch32):
              (JSC::MacroAssemblerMIPS::branch32WithUnalignedHalfWords):
              (JSC::MacroAssemblerMIPS::branch16):
              (JSC::MacroAssemblerMIPS::branchTest32):
              (JSC::MacroAssemblerMIPS::jump):
              (JSC::MacroAssemblerMIPS::branchAdd32):
              (JSC::MacroAssemblerMIPS::branchMul32):
              (JSC::MacroAssemblerMIPS::branchSub32):
              (JSC::MacroAssemblerMIPS::breakpoint):
              (JSC::MacroAssemblerMIPS::nearCall):
              (JSC::MacroAssemblerMIPS::call):
              (JSC::MacroAssemblerMIPS::ret):
              (JSC::MacroAssemblerMIPS::set32):
              (JSC::MacroAssemblerMIPS::setTest32):
              (JSC::MacroAssemblerMIPS::moveWithPatch):
              (JSC::MacroAssemblerMIPS::branchPtrWithPatch):
              (JSC::MacroAssemblerMIPS::storePtrWithPatch):
              (JSC::MacroAssemblerMIPS::tailRecursiveCall):
              (JSC::MacroAssemblerMIPS::makeTailRecursiveCall):
              (JSC::MacroAssemblerMIPS::loadDouble):
              (JSC::MacroAssemblerMIPS::storeDouble):
              (JSC::MacroAssemblerMIPS::addDouble):
              (JSC::MacroAssemblerMIPS::subDouble):
              (JSC::MacroAssemblerMIPS::mulDouble):
              (JSC::MacroAssemblerMIPS::convertInt32ToDouble):
              (JSC::MacroAssemblerMIPS::insertRelaxationWords):
              (JSC::MacroAssemblerMIPS::branchTrue):
              (JSC::MacroAssemblerMIPS::branchFalse):
              (JSC::MacroAssemblerMIPS::branchEqual):
              (JSC::MacroAssemblerMIPS::branchNotEqual):
              (JSC::MacroAssemblerMIPS::branchDouble):
              (JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32):
              (JSC::MacroAssemblerMIPS::linkCall):
              (JSC::MacroAssemblerMIPS::repatchCall):
              * jit/ExecutableAllocator.h:
              (JSC::ExecutableAllocator::cacheFlush):
              * wtf/Platform.h:
              * yarr/RegexJIT.cpp:
              (JSC::Yarr::RegexGenerator::generateEnter):
              (JSC::Yarr::RegexGenerator::generateReturn):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55500 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19100841
    • eric@webkit.org's avatar
      2010-03-03 Chad Faragher <wyck@chromium.org> · 1d30efea
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Changed the double-click framework code to pass adjusted page
              coordinates for zoomed pages.  Added a new test to expose
              mistreatment of mouse click coordinates during a double-click.
      
              https://bugs.webkit.org/show_bug.cgi?id=35690
      
              * fast/events/zoom-dblclick-expected.txt: Added.
              * fast/events/zoom-dblclick.html: Added.
      2010-03-03  Chad Faragher  <wyck@chromium.org>
      
              Reviewed by Darin Adler.
              Changed the double-click framework code to pass adjusted page
              coordinates for zoomed pages.  Added a new test to expose
              mistreatment of mouse click coordinates during a double-click.
      
              https://bugs.webkit.org/show_bug.cgi?id=35690
      
              Test: fast/events/zoom-dblclick.html
      
              * dom/Node.cpp:
              (WebCore::Node::dispatchMouseEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55499 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d30efea
    • eric@webkit.org's avatar
      2010-03-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> · 9c148d3c
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Add a missing 'm_' to class variables names.
      
              [Qt] QtLauncher is not respecting class variable names
              https://bugs.webkit.org/show_bug.cgi?id=35542
      
              * QtLauncher/main.cpp:
              (LauncherWindow::LauncherWindow):
              (LauncherWindow::init):
              (LauncherWindow::sendTouchEvent):
              (LauncherWindow::eventFilter):
              (LauncherWindow::zoomIn):
              (LauncherWindow::zoomOut):
              (LauncherWindow::resetZoom):
              (LauncherWindow::setEditable):
              (LauncherWindow::setTouchMocking):
              (LauncherWindow::initializeView):
              (LauncherWindow::createChrome):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55498 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c148d3c
    • sfalken@apple.com's avatar
      Windows build fix. · b00c935e
      sfalken@apple.com authored
      * JavaScriptCore.vcproj/jsc/jsc.vcproj:
      * JavaScriptCore.vcproj/jsc/jscCommon.vsprops:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b00c935e
    • sfalken@apple.com's avatar
      Windows build fix. · 8e4acc98
      sfalken@apple.com authored
      * JavaScriptCore.vcproj/jsc/jsc.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e4acc98
    • levin@chromium.org's avatar
      No review, rolling out r55474. · ab8390da
      levin@chromium.org authored
      The patch broke fast/frames/sandboxed-iframe-storage.html
      
      Last one (I hope).
      
      * WebCore.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab8390da
    • dumi@chromium.org's avatar
      Making database-lock-after-reload.html a bit more robust and · 49c07970
      dumi@chromium.org authored
      cleaning up some style issues.
      
      Reviewed by Dimitri Glazkov.
      
      * storage/database-lock-after-reload.html:
      * storage/resources/database-lock-after-reload-2.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49c07970
    • ap@apple.com's avatar
      Rubber-stamped by Mark Rowe. · 7c36f065
      ap@apple.com authored
              Exclude leaks in Java that build bot complains about.
      
              * Scripts/run-webkit-tests:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c36f065
    • levin@chromium.org's avatar
      No review, rolling out r55474. · 9aac0415
      levin@chromium.org authored
      The patch broke fast/frames/sandboxed-iframe-storage.html
      
      Unfortunately, (the webkit-patch rollout and) I missed these in r55485.
      
      WebCore:
      
      * bindings/js/JSDatabaseCallback.cpp: Removed.
      * bindings/js/JSDatabaseCallback.h: Removed.
      * bindings/v8/custom/V8DatabaseCallback.cpp: Removed.
      * bindings/v8/custom/V8DatabaseCallback.h: Removed.
      * storage/DatabaseCallback.h: Removed.
      
      LayoutTests:
      
      * storage/open-database-creation-callback-expected.txt: Removed.
      * storage/open-database-creation-callback-isolated-world-expected.txt: Removed.
      * storage/open-database-creation-callback-isolated-world.html: Removed.
      * storage/open-database-creation-callback.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9aac0415
    • dumi@chromium.org's avatar
      Fix a bug that could lead to a crash. Some parts of · 3187f511
      dumi@chromium.org authored
      SQLTransaction::checkAndHandleClosedDatabase() should only be run
      when that method is invoked on the DB thread.
      
      Reviewed by Dimitri Glazkov.
      
      We cannot test this fix with a test, because the crash happens
      only when all of the following conditions are met:
      1. A database is closing.
      2. A transaction on that database is in progress.
      3. The transaction is in a state where a statement/transaction
      success/error callback needs to be invoked (so there's a task for
      this transaction pending on the main thread).
      4. The DB thread finished processing all its tasks and called
      SQLTransactionCoordinator::shutdown() before the main thread go to
      that task.
      
      The closest thing we have to a test is running
      LayoutTests/storage/database-lock-after-reload.html 1000 times in
      a row. Without the patch, the probability of a crash happening in
      one of the runs is very high. With the patch, the test should
      reliably run 1000 times in a row without a single crash.
      
      https://bugs.webkit.org/show_bug.cgi?id=35624
      
      * storage/SQLTransaction.cpp:
      (WebCore::SQLTransaction::checkAndHandleClosedDatabase):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3187f511
    • darin@chromium.org's avatar
      2010-03-03 Darin Fisher <darin@chromium.org> · c273e671
      darin@chromium.org authored
              Reviewed by Mark Rowe.
      
              Page should not care about Chromium plug-in implementation details
              https://bugs.webkit.org/show_bug.cgi?id=35623
      
              * WebCore.gypi: Compile PluginViewNone.cpp
              * page/Page.cpp:
              (WebCore::Page::privateBrowsingStateChanged): Remove conditional
              compilation for PLATFORM(CHROMIUM).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c273e671
    • levin@chromium.org's avatar
      2010-03-03 David Levin <levin@chromium.org> · fb077e5f
      levin@chromium.org authored
              No review, rolling out r55474.
              http://trac.webkit.org/changeset/55480
      
              The patch broke fast/frames/sandboxed-iframe-storage.html
      
              * Android.jscbindings.mk:
              * Android.v8bindings.mk:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * bindings/js/JSDOMWindowCustom.cpp:
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              * dom/Document.cpp:
              (WebCore::Document::postTask):
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::openDatabase):
              * page/DOMWindow.h:
              * page/DOMWindow.idl:
              * storage/Database.cpp:
              (WebCore::Database::openDatabase):
              (WebCore::Database::Database):
              (WebCore::Database::performOpenAndVerify):
              * storage/Database.h:
              * workers/WorkerContext.cpp:
              (WebCore::WorkerContext::openDatabase):
              * workers/WorkerContext.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb077e5f
    • levin@chromium.org's avatar
      2010-03-03 David Levin <levin@chromium.org> · 1bc093fb
      levin@chromium.org authored
              No review, rolling out r55480.
              http://trac.webkit.org/changeset/55480
      
              The patch broke fast/frames/sandboxed-iframe-storage.html
      
              * storage/Database.cpp:
              * storage/Database.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bc093fb
    • mrowe@apple.com's avatar
      Add virtual memory tags for TCMalloc and WebCore's purgeable buffers. · 2b0fad29
      mrowe@apple.com authored
      Reviewed by Geoff Garen.
      
      JavaScriptCore:
      
      * wtf/TCSystemAlloc.cpp:
      (TryMmap): Use the VM tag.
      * wtf/VMTags.h: Make use of VM_MEMORY_TCMALLOC and VM_MEMORY_WEBCORE_PURGEABLE_BUFFERS.
      
      WebCore:
      
      * platform/mac/PurgeableBufferMac.cpp:
      (WebCore::PurgeableBuffer::create):  Use the VM tag.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b0fad29
    • ap@apple.com's avatar
      Not reviewed. · 801ded60
      ap@apple.com authored
              Try better to fix Java tests on Tiger bot.
      
              * platform/mac-tiger/Skipped:
              * platform/mac-tiger/java/lc3/JavaArray/ToString-001-expected.txt: Removed.
              This test gets different resultson each run when it fails, so it needs to be disabled on
              Tiger.
      
              * platform/mac-tiger/java/lc3/JavaObject/JavaObjectToString-001-expected.txt: Added a
              newline I didn't get when copying actual results from buildbot.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      801ded60
    • cmarrin@apple.com's avatar
    • dumi@chromium.org's avatar
      Move #include "DatabaseCallback.h" from Database.h to · ae4b74f0
      dumi@chromium.org authored
      Database.cpp.
      
      Reviewed by nobody, build fix.
      
      * storage/Database.cpp:
      * storage/Database.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae4b74f0
    • ossy@webkit.org's avatar
      [Qt] Skip new test introduced in r55474, because of · b2625d66
      ossy@webkit.org authored
      missing layoutTestController.evaluateScriptInIsolatedWorld()
      
      * platform/qt/Skipped: storage/open-database-creation-callback-isolated-world.html skipped.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2625d66
    • darin@apple.com's avatar
      Fixed Mac build. · 8adba0d3
      darin@apple.com authored
      * WebCore.xcodeproj/project.pbxproj: Marked a couple of headers "private" so they can
      be used in the WebKit project.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8adba0d3
    • ap@apple.com's avatar
      Rubber-stamped by Dan Bernstein. · 0525fe5e
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=35700
              Some of the newly added Java tests fail randomly on buildbot
      
              * fast/js/resources/js-test-post-async.js: Added a version that calls notifyDone(). I first
              wanted to add a notifyDone() call to js-test-post.js, but it turns out that multiple tests
              dump results after "TEST COMPLETE", and we need to get bots back to green fast.
      
              * java/lc3: (Many files). Don't load two scripts dynamically, WebKit has issues with order of
              execution in this case.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0525fe5e
    • sfalken@apple.com's avatar
      Rubber stamped by Adam Roben. · 26a5a25b
      sfalken@apple.com authored
      Fix bogus xcopy that was polluting source tree at build time.
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26a5a25b
    • ap@apple.com's avatar
      Reviewed by Adele Peterson. · 9a3ec0a6
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=35044
              Crash in XML tokenizer reloading zoom-coords-viewattr-01-b.svg
      
              I'm often getting a crash even when opening the test for the first time in Safari, but it
              doesn't seem to crash in DumpRenderTree. Still, I can't think of a stronger way to test for
              this condition, so no new regression test.
      
              * dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::end): Be prepared that parsing remaining
              input will pause parsing.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a3ec0a6
    • dumi@chromium.org's avatar
      WebCore: Adding support for the optional creation callback that could be · 2d346ae6
      dumi@chromium.org authored
      passed to openDatabase().
      
      Reviewed by Adam Barth.
      
      Test: storage/open-database-creation-callback.html
      
      https://bugs.webkit.org/show_bug.cgi?id=34726
      
      * Android.jscbindings.mk
      * Android.v8bindings.mk
      * GNUmakefile.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::openDatabase):
      * bindings/js/JSDatabaseCallback.cpp: Added.
      (WebCore::JSDatabaseCallback::JSDatabaseCallback):
      (WebCore::JSDatabaseCallback::~JSDatabaseCallback):
      (WebCore::JSDatabaseCallback::handleEvent):
      * bindings/js/JSDatabaseCallback.h: Added.
      (WebCore::JSDatabaseCallback::create):
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      (WebCore::V8DOMWindow::openDatabaseCallback):
      * bindings/v8/custom/V8DatabaseCallback.cpp: Added.
      (WebCore::V8DatabaseCallback::V8DatabaseCallback):
      (WebCore::V8DatabaseCallback::~V8DatabaseCallback):
      (WebCore::V8DatabaseCallback::handleEvent):
      * bindings/v8/custom/V8DatabaseCallback.h: Added.
      (WebCore::V8DatabaseCallback::create):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::openDatabase):
      * page/DOMWindow.h:
      * page/DOMWindow.idl:
      * storage/Database.cpp:
      (WebCore::DatabaseCreationCallbackTask::create):
      (WebCore::DatabaseCreationCallbackTask::performTask):
      (WebCore::DatabaseCreationCallbackTask::DatabaseCreationCallbackTask):
      (WebCore::Database::openDatabase):
      (WebCore::Database::Database):
      (WebCore::Database::performOpenAndVerify):
      (WebCore::Database::performCreationCallback):
      * storage/Database.h:
      (WebCore::Database::isNew):
      * storage/DatabaseCallback.h: Added.
      (WebCore::DatabaseCallback::~DatabaseCallback):
      * workers/WorkerContext.cpp:
      (WebCore::WorkerContext::openDatabase):
      * workers/WorkerContext.h:
      
      LayoutTests: Adding a test to test the creation callback passed to
      openDatabase() and another one to make sure it is executed in the
      correct world.
      
      Reviewed by Adam Barth.
      
      https://bugs.webkit.org/show_bug.cgi?id=34726
      
      * storage/open-database-creation-callback-expected.txt: Added.
      * storage/open-database-creation-callback.html: Added.
      * storage/open-database-creation-callback-isolated-world-expected.txt: Added.
      * storage/open-database-creation-callback-isolated-world.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d346ae6
    • cmarrin@apple.com's avatar
      35f875b4
    • bweinstein@apple.com's avatar
      Touch WebKit.idl to force a rebuild · 3852e2c5
      bweinstein@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3852e2c5
    • ap@apple.com's avatar
      Not reviewed. · 9b2c01fb
      ap@apple.com authored
              Two newly added Java tests fail on Tiger build bot.
      
              Just land actual results as expected. I don't even know which behavior is more correct.
      
              * platform/mac-tiger/java: Added.
              * platform/mac-tiger/java/lc3: Added.
              * platform/mac-tiger/java/lc3/JavaArray: Added.
              * platform/mac-tiger/java/lc3/JavaArray/ToString-001-expected.txt: Added.
              * platform/mac-tiger/java/lc3/JavaObject: Added.
              * platform/mac-tiger/java/lc3/JavaObject/JavaObjectToString-001-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b2c01fb
    • ap@apple.com's avatar
      Reviewed by Timothy Hatcher. · 0c647c45
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=35692
              <rdar://problem/7703622> Crash when calling abort() on an XHR while in a windowless WebView
      
              * Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]):
              Retain the challenge, just like it's done for sheet.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c647c45
    • ap@apple.com's avatar
      Reviewed by Darin Adler. · fd21c99f
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=35617
              Import Mozilla LiveConnect 3 test suite
      
              * java/lc3/sources: Added (many files). Sources for Mozilla test applet.
      
              * java/jstests.jar: Added in compiled form, since it's unlikely that we'll ever need to
              modify the above sources.
      
              * java/lc3.java: Added.
              (lc3): This is a small wrapper around jstests.jar. The latter only adds some classes, but
              WebKit needs an actual applet to call into Java.
              (lc3.createQAObject): Instantiate a class defined in jstests.jar by name.
              (lc3.stringToByteArray): A helper to make a byte array out of string. Tests originally
              relied on window.java package interface to do this, but it's not available in WebKit. We
              need more functions like this to work around other uses of window.java, but this is one I
              wrote for now.
      
              * java/Makefile: Link test applets to Mozilla's jstests.jar. This is not needed for tests
              other than ones imported here, but it's also harmless, and I don't know how to write good
              makefiles.
      
              * java/lc3: Added (many files). Tests were heavily reworked to run to completion, but PASS/FAIL
              results should not be generally relied upon. All html wrappers are identical.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd21c99f
    • eric.carlson@apple.com's avatar
      2010-03-03 Eric Carlson <eric.carlson@apple.com> · a22e7d94
      eric.carlson@apple.com authored
              Unreviewed, build fix.
      
              Update expected results for fast/js/custom-constructors-expected.txt
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a22e7d94
    • cmarrin@apple.com's avatar
    • apavlov@chromium.org's avatar
      2010-03-03 Alexander Pavlov <apavlov@chromium.org> · 6c34e6d6
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: resources panel only shows uncompressed resource size.
              https://bugs.webkit.org/show_bug.cgi?id=35403
      
              * English.lproj/localizedStrings.js:
              * inspector/InspectorResource.cpp:
              (WebCore::InspectorResource::updateScriptObject):
              * inspector/front-end/AbstractTimelinePanel.js:
              (WebInspector.AbstractTimelinePanel.prototype.refresh):
              * inspector/front-end/AuditRules.js:
              (WebInspector.AuditRules.GzipRule.prototype.doRun):
              (WebInspector.AuditRules.GzipRule.prototype._shouldCompress):
              * inspector/front-end/ImageView.js:
              (WebInspector.ImageView):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype.get resourceSize):
              (WebInspector.Resource.prototype.set resourceSize):
              (WebInspector.Resource.prototype.get transferSize):
              (WebInspector.Resource.CompareBySize):
              (WebInspector.Resource.CompareByTransferSize):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel.prototype.populateSidebar):
              (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels):
              (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels):
              (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphPercentages):
              (WebInspector.ResourceTransferSizeCalculator.prototype._value):
              (WebInspector.ResourceTransferSizeCalculator.prototype._networkBytes):
              (WebInspector.ResourceSidebarTreeElement.CompareByDescendingTransferSize):
              (WebInspector.ResourceGraph.prototype.refreshLabelPositions):
              (WebInspector.ResourceGraph.prototype.refresh):
              * inspector/front-end/inspector.css:
              * inspector/front-end/inspector.js:
              (WebInspector.updateResource):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c34e6d6
    • mitz@apple.com's avatar
      Build fix. · 829eca9c
      mitz@apple.com authored
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::removeChildren):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      829eca9c
    • pfeldman@chromium.org's avatar
      2010-03-03 Pavel Feldman <pfeldman@chromium.org> · 6ad21836
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Get rid of synchronous debuggerEnabled, profilerEnabled calls.
      
              https://bugs.webkit.org/show_bug.cgi?id=32331
      
              * inspector/InspectorBackend.cpp:
              * inspector/InspectorBackend.h:
              * inspector/InspectorBackend.idl:
              * inspector/front-end/BreakpointsSidebarPane.js:
              (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
              (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint):
              (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel):
              (WebInspector.ProfilesPanel.prototype.profilerWasEnabled):
              (WebInspector.ProfilesPanel.prototype.profilerWasDisabled):
              (WebInspector.ProfilesPanel.prototype._updateInterface):
              (WebInspector.ProfilesPanel.prototype._enableProfiling):
              (WebInspector.ProfilesPanel.prototype._toggleProfiling):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
              (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled):
              (WebInspector.ScriptsPanel.prototype.reset):
              (WebInspector.ScriptsPanel.prototype.canShowSourceLine):
              (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
              (WebInspector.ScriptsPanel.prototype._enableDebugging):
              (WebInspector.ScriptsPanel.prototype._toggleDebugging):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ad21836
    • eric.carlson@apple.com's avatar
      2010-03-03 Eric Carlson <eric.carlson@apple.com> · 9f8dbf40
      eric.carlson@apple.com authored
              Reviewed by Adele Peterson.
      
              Replace 'autobuffer' attribute with 'preload' to align with spec revision 4811.
              https://bugs.webkit.org/show_bug.cgi?id=35385
              rdar://problem/7689602
      
              Tests: media/audio-constructor-preload.html
                     media/video-dom-preload.html
      
              * html/HTMLAttributeNames.in: Remove autobuffer, add preload
      
              * html/HTMLAudioElement.cpp:
              (WebCore::HTMLAudioElement::createForJSConstructor): set preload to 'auto' instead of 
                  autobuffer to true.
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_preload.
              (WebCore::HTMLMediaElement::parseMappedAttribute): Deal with 'preload' attribute.
              (WebCore::HTMLMediaElement::loadResource): Call setPreload() on the newly created MediaPlayer,
                  before calling load() so it can pass the setting through to the media engine.
              (WebCore::HTMLMediaElement::preload): New.
              (WebCore::HTMLMediaElement::setPreload): Ditto
              * html/HTMLMediaElement.h:
              * html/HTMLMediaElement.idl:
      
              * platform/graphics/MediaPlayer.cpp:
              (WebCore::MediaPlayer::MediaPlayer): Initialize m_preload.
              (WebCore::MediaPlayer::load): Pass m_preload to newly created media engine.
              (WebCore::MediaPlayer::preload): New, return m_preload.
              (WebCore::MediaPlayer::setPreload): New, set m_preload.
              * platform/graphics/MediaPlayer.h:
              (WebCore::MediaPlayer::):
              * platform/graphics/MediaPlayerPrivate.h:
              (WebCore::MediaPlayerPrivateInterface::setPreload):
      
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::MediaPlayerPrivate::setPreload): Renamed from setAutoplay, fix logic for preload.
              * platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
      
      2010-03-03  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Adele Peterson.
      
              Replace 'autobuffer' attribute with 'preload' to align with spec revision 4811.
              https://bugs.webkit.org/show_bug.cgi?id=35385
              rdar://problem/7689602
      
              * media/audio-constructor-autobuffer-expected.txt: Removed.
              * media/audio-constructor-autobuffer.html: Removed.
              * media/audio-constructor-preload-expected.txt: Added.
              * media/audio-constructor-preload.html: Added.
              * media/video-dom-autobuffer-expected.txt: Removed.
              * media/video-dom-autobuffer.html: Removed.
              * media/video-dom-preload-expected.txt: Added.
              * media/video-dom-preload.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f8dbf40
    • mitz@apple.com's avatar
      <rdar://problem/7682756> Assertion failure when replacing the contents of a <select> · 1aa6c4d3
      mitz@apple.com authored
      Reviewed by Sam Weinig.
      
      WebCore: 
      
      Test: fast/dom/remove-children-notification-order.html
      
      * dom/ContainerNode.cpp:
      (WebCore::ContainerNode::removeChildren): Changed to call childrenChanged()
      before calling removedFromDocument() on each removed child, which matches
      the order removeChild() does things, and avoids the assertion. This required
      temporarily storing the removed children in a vector.
      Also added comments about other discrepancies between this function and
      removeChild().
      
      LayoutTests: 
      
      * fast/dom/remove-children-notification-order-expected.txt: Added.
      * fast/dom/remove-children-notification-order.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1aa6c4d3