1. 10 Nov, 2007 19 commits
    • zimmermann@webkit.org's avatar
      Reviewed by Eric. · d5ab4fa9
      zimmermann@webkit.org authored
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=15937 (Add glyph-orientation-horizontal/vertical support)
      Fixes: http://bugs.webkit.org/show_bug.cgi?id=13971 (text-anchor support on vertical text seems slightly off)
      
      Add glyph-orientation-* support for text & textPath. (90/180/270 and 'auto')
      Also fix all vertical text handling - for text & textPath! (especially latin1 characters auto orientation in vertical writing modes)
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5ab4fa9
    • zimmermann@webkit.org's avatar
      Rubberstamped by Eric. · 436422be
      zimmermann@webkit.org authored
      Update some SVG pixel test results - which show changes lately -> repainting fixes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      436422be
    • darin@apple.com's avatar
      JavaScriptCore: · 42667586
      darin@apple.com authored
              Reviewed by Sam.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=15927
                REGRESSION(r27487): delete a.c followed by __defineGetter__("c", ...) incorrectly deletes another property
                and <rdar://problem/5586384> REGRESSION (r27487): Can't switch out of Edit HTML Source mode on Leopard Wiki
      
              Test: fast/js/delete-then-put.html
      
              * kjs/property_map.cpp:
              (KJS::PropertyMap::put): Added a missing "- 1"; code to find an empty slot was not working.
              (KJS::PropertyMap::checkConsistency): Added a missing range check that would have caught this
              problem before.
      
              - roll out a last-minute change to my evaluateToBoolean patch that was incorrect.
      
              * kjs/nodes.h: (KJS::ExprStatementNode::ExprStatementNode): Take out call to
              optimizeForUnnecessaryResult, since the result is used in some cases.
      
      LayoutTests:
      
              Reviewed by Sam.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=15927
                delete a.c followed by __defineGetter__("c", ...) incorrectly deletes another property
      
              * fast/js/delete-then-put-expected.txt: Added.
              * fast/js/delete-then-put.html: Added.
              * fast/js/resources/delete-then-put.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42667586
    • timothy@apple.com's avatar
      Reviewed by Sam Weinig. · 75c3d576
      timothy@apple.com authored
              * page/inspector/StylesSidebarPane.js: Fix the wording of a comment
                and switch over to use getUniqueProperties in another place.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75c3d576
    • weinig@apple.com's avatar
      WebKitTools: · 0be8d5fe
      weinig@apple.com authored
              Reviewed by Tim Hatcher.
      
              Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
              attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
              is turned on)
      
              - Add LayoutTestController.setPrivateBrowsingEnabled(bool) (stub out implementation for windows)
      
              Added test: http/tests/security/cross-frame-access-private-browsing.html
      
              * DumpRenderTree/LayoutTestController.cpp:
              (setPrivateBrowsingEnabledCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (runTest): Default to private browsing disabled.
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setPrivateBrowsingEnabled):
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setPrivateBrowsingEnabled):
      
      LayoutTests:
      
              Reviewed by Tim Hatcher.
      
              Follow up to <rdar://problem/5394877> Safari should not log unsafe JavaScript 
              attempts when in private browsing mode (only an issue if Log JavaScript Exceptions 
              is turned on)
      
              Test using the new LayoutTestController.setPrivateBrowsingEnabled(bool)
      
              * http/tests/security/cross-frame-access-private-browsing-expected.txt: Added.
              * http/tests/security/cross-frame-access-private-browsing.html: Added.
              * platform/win/Skipped: Add new test to windows skip list until we have an
              implementation of LayoutTestController.setPrivateBrowsingEnabled(bool) for it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0be8d5fe
    • sullivan@apple.com's avatar
      Reviewed by Sam Weinig · 194b9ac8
      sullivan@apple.com authored
              Rest of fix for 5394877
      
              * bindings/js/kjs_window.cpp:
              (KJS::Window::isSafeScript):
              Don't log unsafe JavaScript attempts in the other version of isSafeScript() if in
              private browsing mode either.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      194b9ac8
    • zimmermann@webkit.org's avatar
      Reviewed by Oliver. · 8f20e561
      zimmermann@webkit.org authored
      Fix function name difference - header said 'unicodeRangeForCharacter', actually
      implemented function is 'findCharUnicodeRange'. They are not compiled yet.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f20e561
    • hausmann's avatar
      When populating the context menu with sub-menus don't add sub-menus if they're empty. · 98da69cf
      hausmann authored
      Signed-off-by: Nikolas
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98da69cf
    • hausmann's avatar
      Added support for the Bold/Italic/Underline toggle actions. · 7f28eacb
      hausmann authored
      Signed-off-by: Nikolas
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f28eacb
    • hausmann's avatar
      Before adding an action to the context menu call checkOrEnableIfNeeded for each action · 63f4d94f
      hausmann authored
      to update the enable/checked state correctly.
      
      Signed-off-by: Nikolas
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63f4d94f
    • hausmann's avatar
      Mark the text direction actions as checkable actions. · a242e374
      hausmann authored
      Signed-off-by: Nikolas
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a242e374
    • aroben@apple.com's avatar
      Windows build fix · 98745f91
      aroben@apple.com authored
              Roll out some changes that were (seemingly accidentally) checked in
              with r27664.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98745f91
    • mitz@apple.com's avatar
      Reviewed by Darin Adler. · bb707344
      mitz@apple.com authored
              - fix <rdar://problem/5450655> Control-clicking text in a link can surprisingly select only part of the link, should select entire link
      
              No test because context menu events cannot be tested in DumpRenderTree.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::selectClosestWordOrLinkFromMouseEvent): Added.
              If the click occurred in an active link, selects the entire link
              element. Otherwise selects the closest word.
              (WebCore::EventHandler::sendContextMenuEvent): Call
              selectClosestWordOrLinkFromMouseEvent().
              * page/EventHandler.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb707344
    • sullivan@apple.com's avatar
      Reviewed by Tim Hatcher · 4b5a82dc
      sullivan@apple.com authored
              - fixed <rdar://problem/5394877> Safari should not log unsafe JavaScript attempts when 
                in private browsing mode (only an issue if Log JavaScript Exceptions is turned on)
      
              * bindings/js/kjs_window.cpp:
              (KJS::Window::isSafeScript):
              Don't log unsafe JavaScript attempts to console or chromeClient if in private browsing mode
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b5a82dc
    • ap@webkit.org's avatar
      Reviewed by Darin. · e962e996
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=15922
              Implement more of Mozilla Selection API
      
              Tests: editing/selection/containsNode.html
                     editing/selection/deleteFromDocument.html
                     editing/selection/extend.html
                     editing/selection/selectAllChildren.html
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::deleteFromDocument):
              (WebCore::SelectionController::containsNode):
              (WebCore::SelectionController::selectAllChildren):
              (WebCore::SelectionController::extend):
              * editing/SelectionController.h:
              Added deleteFromDocument(), containsNode(), and selectAllChildren(). Reimplemented extend(),
              which existed, but didn't match Firefox behavior and wasn't exposed via bindings.
              Removed a comment mentioning removeRange(), as this method makes no sense without multiple
              selection range support.
      
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::extend):
              (WebCore::DOMSelection::deleteFromDocument):
              (WebCore::DOMSelection::containsNode):
              (WebCore::DOMSelection::selectAllChildren):
              * page/DOMSelection.h:
              * page/DOMSelection.idl:
              Exposed the new methods.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e962e996
    • ap@webkit.org's avatar
      Reviewed by Darin. · fa296d6a
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=15892
              DOM Range operations are not implemented for ProcessingInstruction nodes
      
              Test: fast/dom/Range/range-processing-instructions.html
      
              * dom/Range.cpp:
              (WebCore::Range::processContents): Implemented ProcessingInstruction cases.
              (WebCore::Range::checkNodeWOffset): Removed a FIXME - yes, I think that we are supposed
              to use ProcessingInstruction.data.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa296d6a
    • darin@apple.com's avatar
      Reviewed by Sam. · 30fc0f4a
      darin@apple.com authored
              - http://bugs.webkit.org/show_bug.cgi?id=15915
                add an evaluation path for booleans like the one we have for numbers
      
              Gives 1.1% on SunSpider.
      
              * kjs/grammar.y: Create TrueNode and FalseNode instead of BooleanNode.
      
              * kjs/nodes.h: Changed to use Noncopyable. Moved optimizeForUnnecessaryResult
              down from Node to ExpressionNode. Changed some classes to not inherit from
              ExpressionNode where not necessary, and removed unnneeded evaluate functions
              as well as evaluate functions that need not be virtual. Call the
              optimizeForUnnecessaryResult function on the start of a for loop too.
              * kjs/nodes.cpp:
              (KJS::ExpressionNode::evaluateToBoolean): Added.
              (KJS::FalseNode::evaluate): Added.
              (KJS::TrueNode::evaluate): Added.
              (KJS::NumberNode::evaluateToBoolean): Added.
              (KJS::StringNode::evaluateToBoolean): Added.
              (KJS::LocalVarAccessNode::evaluateToBoolean): Added.
              (KJS::BracketAccessorNode::evaluateToBoolean): Added.
              (KJS::LogicalNotNode::evaluate): Changed to call evaluateToBoolean.
              (KJS::LogicalNotNode::evaluateToBoolean): Added.
              (KJS::lessThan): Changed to return bool.
              (KJS::lessThanEq): Ditto.
              (KJS::LessNode::evaluate): Changed since lessThan returns bool.
              (KJS::LessNode::evaluateToBoolean): Added.
              (KJS::GreaterNode::evaluate): Changed since lessThanEq returns bool.
              (KJS::GreaterNode::evaluateToBoolean): Added.
              (KJS::LessEqNode::evaluate): Changed since lessThanEq returns bool.
              (KJS::LessEqNode::evaluateToBoolean): Added.
              (KJS::GreaterEqNode::evaluate): Changed since lessThan returns bool.
              (KJS::GreaterEqNode::evaluateToBoolean): Added.
              (KJS::InstanceOfNode::evaluateToBoolean): Added.
              (KJS::InNode::evaluateToBoolean): Added.
              (KJS::EqualNode::evaluateToBoolean): Added.
              (KJS::NotEqualNode::evaluateToBoolean): Added.
              (KJS::StrictEqualNode::evaluateToBoolean): Added.
              (KJS::NotStrictEqualNode::evaluateToBoolean): Added.
              (KJS::ConditionalNode::evaluate): Changed to call evaluateToBoolean.
              (KJS::IfNode::execute): Ditto.
              (KJS::DoWhileNode::execute): Ditto.
              (KJS::WhileNode::execute): Ditto.
              (KJS::ForNode::execute): Ditto.
      
              * kjs/nodes2string.cpp:
              (KJS::FalseNode::streamTo): Added.
              (KJS::TrueNode::streamTo): Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30fc0f4a
    • timothy@apple.com's avatar
      Reviewed by Mark Rowe. · ea89623b
      timothy@apple.com authored
              Bug 12054: Ability to serialize an element subtree (into clipboard?) from the DOM inspector
              http://bugs.webkit.org/show_bug.cgi?id=12054
      
              - Add support code for routing copy events to the focused element.
              - Implement copying the currently selected DOM node. The node
                and it's subtree is copied to the clipboard. If the node has no
                outerHTML, the nodeValue is copied (text nodes, etc.)
              - Implement copy for the resource sidebar. The URL is copied for the
                currently selected resource.
      
              * page/inspector/DocumentPanel.js:
              * page/inspector/inspector.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea89623b
    • ap@webkit.org's avatar
      Reviewed by Darin. · 37198feb
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=15925
              SunSpider should check for Shark being installed
      
              * sunspider: Explicitly test that shark command line tool is installed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37198feb
  2. 09 Nov, 2007 21 commits
    • honeycutt's avatar
      2007-11-09 Jon Honeycutt <jhoneycutt@apple.com> · 6ef9d628
      honeycutt authored
              Reviewed by Sam.
      
              <rdar://5585900>: Safari crashes when selected in context menu to open
              audio format files (au, aif) with QT 7.3
      
              The crash occurred on a machine where QT 7.3 was failing to initialize.
              The fix is to avoid sending streams to full-page plugins that've failed 
              to load
      
              * WebFrame.cpp:
              (WebFrame::finishedLoading): Check plugin status before calling manual
              stream methods
              (WebFrame::setMainDocumentError): Same
              (WebFrame::committedLoad): Same
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ef9d628
    • antti's avatar
      Rubber stamped by bdash. · bee98fe2
      antti authored
              
              Add directory for blog resources (and one image).
      
              * blog-files: Added.
              * blog-files/touch-poster.png: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bee98fe2
    • antti's avatar
      Reviewed by Adele. · 8eecdc68
      antti authored
              Fix occasional blank video with poster attribute.
      
              * ChangeLog:
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::load):
              (WebCore::HTMLMediaElement::didRestoreFromCache):
              Just calling updateFromElement() does the right thing for both poster image and video.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8eecdc68
    • alp@webkit.org's avatar
      2007-11-09 Xan Lopez <xan@gnome.org> · 657aafdb
      alp@webkit.org authored
              Reviewed by Alp.
      
              Fix http://bugs.webkit.org/show_bug.cgi?id=15926
              [GTK] WebKitPage map handler is redundant.
      
              * Api/webkitgtkpage.cpp:
              The map handler for WebKitPage is redundant, GtkContainer does
              the same (and more correctly).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      657aafdb
    • tristan's avatar
      Reviewed by Sam Weinig. · 5decd396
      tristan authored
              * fast/dom/Window/window-resize-nan.html: Removed.
              * fast/dom/Window/window-resize-nan.html-disabled: Copied from fast/dom/Window/window-resize-nan.html.
              
              Disabled nan test until window resize issues can be resolved.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5decd396
    • weinig's avatar
      Rubber stamped by Oliver. · 957c105f
      weinig authored
              Make WebCore a dependency of Interfaces.
      
              * WebKit.vcproj/WebKit.sln:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      957c105f
    • weinig's avatar
      WebCore: · 38baa376
      weinig authored
              Reviewed by Adam Roben.
      
              <rdar://problem/5435940>
              The COM bindings for the DOM should be autogenerated like the other DOM bindings
      
              Initial commit of the autogeneration of the COM DOM Bindings.  No behavior change
              is being introduced in this patch and to insure that no conflicts arise, a temporary
              prefix of "GEN_" has been used for all the new classes.
      
              The build architecture for these bindings differs slightly from the other autogenerated
              bindings.  Instead of building in WebCore and migrating the resuting code to WebKit (as
              is done for the Objective-C bindigs currently), the IDLs and generation scripts are
              migrated to WebKit and built there.  This is done with a series of scripts and Makefiles.
      
              This commit includes:
                  - Hand rolled root class/Interface GEN_DOMObject used to facilated object creation
                    and ref-counting.
                  - Generating all of the Core DOM and most of HTML and CSS
                  - Generating Event, EventTarget, and EventListener
      
              * WebCore.vcproj/MigrateIDLAndScripts.make: Added.
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.vcproj/migrate-idls.sh: Added.
              * bindings/scripts/CodeGenerator.pm:
              * bindings/scripts/CodeGeneratorCOM.pm: Added.
              * dom/EventListener.h: Make the isWindowEvent parameter default to false
              to allow autogeneration based on the IDL.
      
      WebKit/win:
      
              Reviewed by Adam Roben.
      
              <rdar://problem/5435940>
              The COM bindings for the DOM should be autogenerated like the other DOM bindings
      
              Initial commit of the autogeneration of the COM DOM Bindings.  No behavior change
              is being introduced in this patch and to insure that no conflicts arise, a temporary
              prefix of "GEN_" has been used for all the new classes.
      
              The build architecture for these bindings differs slightly from the other autogenerated
              bindings.  Instead of building in WebCore and migrating the resuting code to WebKit (as
              is done for the Objective-C bindigs currently), the IDLs and generation scripts are
              migrated to WebKit and built there.  This is done with a series of scripts and Makefiles.
      
              This commit includes:
                  - Hand rolled root class/Interface GEN_DOMObject used to facilated object creation
                    and ref-counting.
                  - Generating all of the Core DOM and most of HTML and CSS
                  - Generating Event, EventTarget, and EventListener
      
              * DOMCreateInstance.cpp: Added.
              (domWrapperCache):
              (getDOMWrapper):
              (setDOMWrapper):
              (removeDOMWrapper):
              (GEN_DOMNode::createInstance):
              (GEN_DOMImplementation::createInstance):
              (GEN_DOMCSSRule::createInstance):
              (GEN_DOMStyleSheet::createInstance):
              (GEN_DOMCSSValue::createInstance):
              * DOMCreateInstance.h: Added.
              Temporary location for createInstance/object caching methods.  This will be broken up
              into seperate files in the near future.
      
              * GEN_DOMObject.cpp: Added.
              (GEN_DOMObject::GEN_DOMObject):
              (GEN_DOMObject::~GEN_DOMObject):
              (GEN_DOMObject::QueryInterface):
              (GEN_DOMObject::AddRef):
              (GEN_DOMObject::Release):
              * GEN_DOMObject.h: Added.
              Hand rolled base class.
      
              * Interfaces/IGEN_DOMObject.idl: Added. 
              Hand rolled base interface.
      
              * WebKit.vcproj/DerivedSources.make: Added.
              * WebKit.vcproj/FixMIDLHeaders.pl: Added.
              This script is required because MIDL is producing un-buildable code due to
              circular dependencies.
      
              * WebKit.vcproj/Interfaces.vcproj:
              * WebKit.vcproj/WebKit.vcproj:
              * WebKit.vcproj/WebKitGUID.vcproj:
              * WebKit.vcproj/build-generated-files.sh: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38baa376
    • tristan's avatar
      mac: · 7489b5a6
      tristan authored
              Reviewed by Timothy Hatcher.
              
              This patch is for the WebKit side of <rdar://problem/5591115>.
              We need a way to tell context menu navigations, such as "Open in New Window"
              to override any sort of browser preference for tab based navigation.
      
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::createWindow):
              Pass up the new preferredType parameter as a string.
      
      WebCore:
      
              Reviewed by Timothy Hatcher.
              
              This patch is for the WebKit side of <rdar://problem/5591115>.
              We need a way to tell context menu navigations, such as "Open in New Window"
              to override any sort of browser preference for tab based navigation.
      
              * bridge/WindowFeatures.h:
              (WebCore::WindowFeatures::WindowFeatures):
              Added a new struct member var, preferredType
              and an accompanying enum type PreferredType
              to send a window type recommendation up to the Chrome. 
              
              * page/ContextMenuController.cpp:
              (WebCore::openNewWindow):
              Set the window features to recommend a new Window for
              "Open in New Window" context menu action.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7489b5a6
    • timothy@apple.com's avatar
      Reviewed by John. · 016eed14
      timothy@apple.com authored
              <rdar://problem/5103720> REGRESSION: [WebView stringByEvaluatingJavaScriptFromString:] fails if "return" is used
      
              Extend the linked on or after check to every application when a script passed to
              stringByEvaluatingJavaScriptFromString: has a return statement. Before the check
              was limited to VitalSource Bookshelf, but other developers are running into this.
      
              * Misc/WebKitVersionChecks.h: Add the WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK define.
              * WebView/WebDocumentLoaderMac.mm:
              (needsDataLoadWorkaround): Use WEBKIT_FIRST_VERSION_WITHOUT_ADOBE_INSTALLER_QUIRK sicne the
                WebKitLinkedOnOrAfter check here was about the Adobe installer, not VitalSource.
              * WebView/WebView.mm:
              (-[WebView stringByEvaluatingJavaScriptFromString:]): Remove the bundle ID check and use
                WEBKIT_FIRST_VERSION_WITHOUT_JAVASCRIPT_RETURN_QUIRK for the WebKitLinkedOnOrAfter call.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      016eed14
    • aroben@apple.com's avatar
      Fix <rdar://5483519> Pressing Enter on selected buttons should fire onclick · 745cedc5
      aroben@apple.com authored
       LayoutTests:
      
               Add a test for <rdar://5483519> Pressing Enter on selected buttons should fire onclick
      
               Reviewed by Adele.
      
               * fast/forms/enter-clicks-buttons-expected.txt: Added.
               * fast/forms/enter-clicks-buttons.html: Added.
      
       WebCore:
      
               Fix <rdar://5483519> Pressing Enter on selected buttons should fire onclick
      
               We now match the behavior of Firefox and IE, which is to always just
               send a click event to the focused button when the Enter key is pressed
               (previously we were submitting forms directly in some cases).
      
               Reviewed by Adele.
      
               Test: fast/forms/enter-clicks-buttons.html
      
               * html/HTMLButtonElement.cpp:
               (WebCore::HTMLButtonElement::defaultEventHandler): Don't do anything
               fancy when Enter is pressed on a <button type=button> -- just send a
               click event like we do for other button types.
               * html/HTMLInputElement.cpp:
               (WebCore::HTMLInputElement::defaultEventHandler): Treat type=button
               the same way we treat type=submit and type=reset: just send a click
               event when Enter is pressed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      745cedc5
    • mitz@apple.com's avatar
      WebCore: · 5a4bdf3e
      mitz@apple.com authored
              Reviewed by Antti Koivisto.
      
              - fix a bug in invisible layer culling: dynamically changing a 
                descendant of an invisible layer to be visible did not work
      
              Test: fast/layers/layer-content-visibility-change.html
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::setHasVisibleContent): If we got visible content,
              make sure that our stacking context rebuilds its z-order lists to
              include us.
      
      LayoutTests:
      
              Reviewed by Antti Koivisto.
      
              - test that dynamically changing a descendant of an invisible layer to
                be visible works
      
              * fast/layers/layer-content-visibility-change.html: Added.
              * platform/mac/fast/layers/layer-content-visibility-change-expected.checksum: Added.
              * platform/mac/fast/layers/layer-content-visibility-change-expected.png: Added.
              * platform/mac/fast/layers/layer-content-visibility-change-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a4bdf3e
    • hyatt's avatar
      Clean up matrix() parsing. Make sure the first four arguments can be... · 356b4e99
      hyatt authored
              Clean up matrix() parsing.  Make sure the first four arguments can be lengths or numbers.  The last two
              args can be lengths or numbers or percents.
      
              Reviewed by Beth
      
              * WebCore.xcodeproj/project.pbxproj:
              * css/CSSParser.cpp:
              (WebCore::TransformOperationInfo::TransformOperationInfo):
              (WebCore::CSSParser::parseTransform):
              * rendering/RenderStyle.h:
              (WebCore::MatrixTransformOperation::apply):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      356b4e99
    • bdakin@apple.com's avatar
      WebCore: · 58730d7c
      bdakin@apple.com authored
              Reviewed by Oliver.
      
              Fix for <rdar://problem/5586370> CSS Transform - incorrect matrix 
              math leads to crazy problems
      
              Transform matrices accept the first four parameters as CSS lengths. 
              CSS lengths get mapped into WebCore::Lengths as percents by 
              WebCore::convertToLength(). Percent lengths cannot call value(). It 
              does not yield a correct result and it asserts on Debug builds. 
      
              * rendering/RenderStyle.h:
              (WebCore::MatrixTransformOperation::apply): Instead of calling 
              value() on the lengths, call calcValue. This fixes the assert and 
              the bad rendering. 
      
      LayoutTests:
      
              Reviewed by Oliver.
      
              Test for <rdar://problem/5586370> CSS Transform - incorrect matrix 
              math leads to crazy problems
      
              * fast/transforms/identity-matrix.html: Added.
              * platform/mac/fast/transforms/identity-matrix-expected.checksum: Added.
              * platform/mac/fast/transforms/identity-matrix-expected.png: Added.
              * platform/mac/fast/transforms/identity-matrix-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58730d7c
    • aroben@apple.com's avatar
      Windows build fix · 1e4fcfd2
      aroben@apple.com authored
              Reviewed by Darin.
      
              * kjs/value.h:
              (KJS::jsNumber): Add some explicit casts.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e4fcfd2
    • sfalken's avatar
      Roll out r27641 since the same bug was already fixed by r27568. · bd242c87
      sfalken authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd242c87
    • hausmann's avatar
      userIdleTime() is stubbed in win/SystemTimeWin.cpp, so don't · 9057719a
      hausmann authored
      define it twice for the Qt/Windows build.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9057719a
    • hausmann's avatar
      Implemented the webcore actions for changing the text direction. · d95fbbf9
      hausmann authored
      Signed-off-by: Holger
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d95fbbf9
    • hausmann's avatar
      Fix ContextMenu allocation in the Qt port. · 0c88dfa8
      hausmann authored
      Store all items and submenus value based in ContextMenu and ContextMenuItem.
      That fixes the crashes when the context menu was populated with sub-menus because
      of the use of temporary ContextMenu objects like this:
      
      ContextMenu subMenu(...);
      subMenu.appendItem(...);
      subMenu.appendItem(...);
      
      subMenuItem.setSubMenu(&subMenu); // temporary pointer, need to _copy_ contents
      
      Signed-off-by: Holger
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c88dfa8
    • hausmann's avatar
      Renamed QWebPage::NumWebActions to QWebPage::WebActionCount (for consistency) and fixed its value. · 4c654395
      hausmann authored
      Signed-off-by: Holger
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c654395
    • mrowe@apple.com's avatar
      2007-11-09 Peter Kasting <zerodpx@gmail.com> · fc4c5a8e
      mrowe@apple.com authored
              Reviewed by Mark Rowe.
      
              http://bugs.webkit.org/show_bug.cgi?id=15909
              Malformed GIFs should not result in memory corruption.
      
              * platform/image-decoders/gif/GIFImageDecoder.cpp:
              (WebCore::GIFImageDecoder::haveDecodedRow):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc4c5a8e
    • sfalken's avatar
      Initialize WindowFeatures struct before using it. · 77648a3d
      sfalken authored
              
              Reviewed by Oliver.
      
              * page/ContextMenuController.cpp:
              (WebCore::openNewWindow):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77648a3d