1. 12 Mar, 2010 40 commits
    • dpranke@chromium.org's avatar
      2010-03-12 Dirk Pranke <dpranke@chromium.org> · d5415dfd
      dpranke@chromium.org authored
              Reviewed by Adam Barth.
      
              new-run-webkit-tests --new-baseline doesn't work at all.
      
              It attempts to call a method that isn't defined. To fix it, I
              removed the unnecessary and unnecessarily confusing 'platform'
              argument to the test_type constructor and use the Port object that
              is passed in instead, since we are only ever generating a baseline
              from the port that is currently executing.
      
              https://bugs.webkit.org/show_bug.cgi?id=36046
      
              * Scripts/webkitpy/layout_tests/port/mac.py:
              * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
              * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
              * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5415dfd
    • dpranke@chromium.org's avatar
      2010-03-12 Dirk Pranke <dpranke@chromium.org> · f00c0851
      dpranke@chromium.org authored
              Reviewed by Adam Barth.
      
              Fix new-run-webkit-tests --run-singly
      
              This script option is currently broken - the script attempts to
              dereference methods and variables that don't exist, which causes
              the Chromium Linux valgrind bot to be quite unhappy. This has been
              broken since r54449 when I renamed Port.start_test_driver to
              Port.start_driver.
      
              https://bugs.webkit.org/show_bug.cgi?id=36042
      
              * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f00c0851
    • krit@webkit.org's avatar
      2010-03-12 Dirk Schulze <krit@webkit.org> · d1efe04a
      krit@webkit.org authored
              Unreviewed LayoutTest update.
      
              Result was not updated with r55930.
      
              * platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1efe04a
    • mitz@apple.com's avatar
      <rdar://problem/7709115> REGRESSION: toolbar is missing at http://www.glom.org/ · 83571990
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=35507
      
      Reviewed by Alexey Proskuryakov.
      
      * css/CSSImportRule.cpp:
      (WebCore::CSSImportRule::setCSSStyleSheet): Extend the change made in
      <http://trac.webkit.org/changeset/48818> to detect the two variants of
      KHTMLFixes.css in @import rules as well as in <link> elements.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55935 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83571990
    • barraclough@apple.com's avatar
      Bug 36052 - [Qt] REGRESSION(55878) 63 test cases crash · dc9d96ff
      barraclough@apple.com authored
      Reviewed by Geoff Garen.
      
      r55878 changed UStringImpl::empty()->characters() to be non-null,
      so TextBreakIteratorQt.cpp now should check the length of strings
      (previously was assuming all strings with a non-null data pointer
      had a length of at least 1).
      
      * platform/text/qt/TextBreakIteratorQt.cpp:
      (WebCore::wordBreakIterator):
      (WebCore::characterBreakIterator):
      (WebCore::lineBreakIterator):
      (WebCore::sentenceBreakIterator):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc9d96ff
    • abarth@webkit.org's avatar
      2010-03-12 Garret Kelly <gdk@chromium.org> · 0ea4f58a
      abarth@webkit.org authored
              Unreiviewed.
      
              Fix Chromium Mac build. Last patch did not apply properly.
              (Garret assures me this patch will actually work.)
      
              * src/WebInputEventConversion.cpp:
              (WebKit::toPlatformTouchEventType):
              (WebKit::toPlatformTouchPointState):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ea4f58a
    • abarth@webkit.org's avatar
      2010-03-12 Garret Kelly <gdk@chromium.org> · ba24f910
      abarth@webkit.org authored
              Unreviewed.
      
              Fix Chromium Mac build. This time, with actual fixing goodness.
      
              * src/WebInputEventConversion.cpp:
              (WebKit::toPlatformTouchEventType):
              (WebKit::toPlatformTouchPointState):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba24f910
    • beidson@apple.com's avatar
      Expose WebPDFView's underlying PDFDocument. · 4ed289bf
      beidson@apple.com authored
      Patch by Andy Estes <aestes@apple.com> on 2010-03-12
      Reviewed by Brady Eidson.
      
      https://bugs.webkit.org/show_bug.cgi?id=36045
      
      * WebView/WebDocumentPrivate.h: Create a new protocol called
      WebDocumentPDF.
      * WebView/WebPDFView.h: Have WebPDFView implement said protocol.
      * WebView/WebPDFView.mm:
      (-[WebPDFView PDFDocument]): Expose WebPDFView's underlying
      PDFDocument by implementing -(PDFDocument*)PDFDocument from
      WebDocumentPDF.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55931 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ed289bf
    • krit@webkit.org's avatar
      2010-03-12 Dirk Schulze <krit@webkit.org> · ad448306
      krit@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              SVG fallback color doesn't work for bogus gradients.
              https://bugs.webkit.org/show_bug.cgi?id=35479
      
              Use a given fallback color on ignored gradients if present. Gradients
              must be ignored, if one dimension of the objects boundingBox is zero.
      
              Test: svg/custom/gradient-with-1d-boundingbox.svg
      
              * svg/graphics/SVGPaintServer.cpp:
              (WebCore::SVGPaintServer::strokePaintServer):
              * svg/graphics/SVGPaintServerGradient.cpp:
              (WebCore::SVGPaintServerGradient::setup):
      2010-03-12  Dirk Schulze  <krit@webkit.org>
      
              Reviewed by Nikolas Zimmermann.
      
              SVG fallback color doesn't work for bogus gradients.
              https://bugs.webkit.org/show_bug.cgi?id=35479
      
              We now use a fallback color on ignored gradients for one dimensional objects,
              either a given fallback color or black as default.
              This causes a change of one LayoutTest, because it was done manually in the
              gradient PaintServer, without respecting a given fallback color.
      
              * platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
              * platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.checksum: Added.
              * platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.png: Added.
              * platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt: Added.
              * svg/custom/gradient-with-1d-boundingbox.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad448306
    • abarth@webkit.org's avatar
      2010-03-12 Garret Kelly <gdk@chromium.org> · 37aceac7
      abarth@webkit.org authored
              Unreviewed.
      
              Fix Chromium Mac build.
      
              * src/WebInputEventConversion.cpp:
              (WebKit::toPlatformTouchEventType):
              (WebKit::toPlatformTouchPointState):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      37aceac7
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=36069 · 9f47d581
      hyatt@apple.com authored
              
      Reviewed by Dan Bernstein.
      
      Eliminate InlineRunBox.
      
      * WebCore.xcodeproj/project.pbxproj:
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::adjustPosition):
      (WebCore::InlineFlowBox::paintFillLayer):
      (WebCore::InlineFlowBox::paintBoxDecorations):
      (WebCore::InlineFlowBox::paintMask):
      * rendering/InlineFlowBox.h:
      (WebCore::InlineFlowBox::InlineFlowBox):
      (WebCore::InlineFlowBox::prevLineBox):
      (WebCore::InlineFlowBox::nextLineBox):
      (WebCore::InlineFlowBox::setNextLineBox):
      (WebCore::InlineFlowBox::setPreviousLineBox):
      * rendering/InlineRunBox.h: Removed.
      * rendering/InlineTextBox.h:
      (WebCore::InlineTextBox::InlineTextBox):
      (WebCore::InlineTextBox::prevTextBox):
      (WebCore::InlineTextBox::nextTextBox):
      (WebCore::InlineTextBox::setNextTextBox):
      (WebCore::InlineTextBox::setPreviousTextBox):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::destroy):
      (WebCore::RenderBlock::rightmostPosition):
      (WebCore::RenderBlock::leftmostPosition):
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::destroy):
      (WebCore::RenderInline::absoluteRects):
      (WebCore::RenderInline::absoluteQuads):
      (WebCore::RenderInline::linesBoundingBox):
      (WebCore::RenderInline::linesVisibleOverflowBoundingBox):
      (WebCore::RenderInline::addFocusRingRects):
      (WebCore::RenderInline::paintOutline):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::localBoundingBox):
      * rendering/RenderLineBoxList.cpp:
      (WebCore::RenderLineBoxList::deleteLineBoxTree):
      (WebCore::RenderLineBoxList::extractLineBox):
      (WebCore::RenderLineBoxList::attachLineBox):
      (WebCore::RenderLineBoxList::removeLineBox):
      (WebCore::RenderLineBoxList::deleteLineBoxes):
      (WebCore::RenderLineBoxList::dirtyLineBoxes):
      (WebCore::RenderLineBoxList::paint):
      (WebCore::RenderLineBoxList::hitTest):
      (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
      (WebCore::RenderLineBoxList::checkConsistency):
      * rendering/RenderSVGInline.cpp:
      (WebCore::RenderSVGInline::absoluteRects):
      (WebCore::RenderSVGInline::absoluteQuads):
      * rendering/RenderSVGText.cpp:
      (WebCore::RenderSVGText::absoluteRects):
      (WebCore::RenderSVGText::absoluteQuads):
      (WebCore::RenderSVGText::objectBoundingBox):
      * rendering/RenderText.cpp:
      (WebCore::RenderText::extractTextBox):
      (WebCore::RenderText::attachTextBox):
      (WebCore::RenderText::removeTextBox):
      (WebCore::RenderText::createInlineTextBox):
      (WebCore::RenderText::positionLineBox):
      * rendering/RootInlineBox.h:
      (WebCore::RootInlineBox::nextRootBox):
      (WebCore::RootInlineBox::prevRootBox):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f47d581
    • kov@webkit.org's avatar
      2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · df1a34bb
      kov@webkit.org authored
              Reviewed by Eric Carlson.
      
              media/video-preload.html fails
              https://bugs.webkit.org/show_bug.cgi?id=35793
      
              Only effectively load, and start buffering when playing, or when
              the preload attribute is set.
      
              Test: media/video-preload.html
      
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
              (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
              (WebCore::MediaPlayerPrivate::load):
              (WebCore::MediaPlayerPrivate::commitLoad):
              (WebCore::MediaPlayerPrivate::prepareToPlay):
              (WebCore::MediaPlayerPrivate::setPreload):
              * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df1a34bb
    • dimich@chromium.org's avatar
      Not reviewed, build fix. · 39cfce0a
      dimich@chromium.org authored
      Reverts 55920 and 55921. Landing for Jian Li.
      
      WebCore:
      
      * Android.derived.jscbindings.mk:
      * Android.derived.v8bindings.mk:
      * DerivedSources.cpp:
      * DerivedSources.make:
      * GNUmakefile.am:
      * WebCore.gypi:
      * WebCore.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSDOMFormDataCustom.cpp: Removed.
      * bindings/js/JSXMLHttpRequestCustom.cpp:
      (WebCore::JSXMLHttpRequest::send):
      * bindings/scripts/CodeGeneratorJS.pm:
      * bindings/v8/V8Index.h:
      * bindings/v8/custom/V8DOMFormDataCustom.cpp: Removed.
      * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
      (WebCore::V8XMLHttpRequest::sendCallback):
      * html/DOMFormData.idl: Removed.
      * page/DOMWindow.idl:
      
      LayoutTests:
      
      * fast/dom/Window/window-properties-expected.txt:
      * fast/dom/Window/window-property-descriptors-expected.txt:
      * fast/dom/constructed-objects-prototypes-expected.txt:
      * fast/dom/prototype-inheritance-2-expected.txt:
      * fast/dom/prototype-inheritance-expected.txt:
      * fast/js/global-constructors-expected.txt:
      * http/tests/local/resources/send-form-data.js: Removed.
      * http/tests/local/send-form-data-expected.txt: Removed.
      * http/tests/local/send-form-data.html: Removed.
      * http/tests/xmlhttprequest/resources/multipart-post-echo.php: Removed.
      * platform/gtk/Skipped:
      * platform/gtk/fast/dom/Window/window-properties-expected.txt:
      * platform/qt/Skipped:
      * platform/qt/fast/dom/Window/window-properties-expected.txt:
      * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
      * platform/qt/fast/dom/prototype-inheritance-expected.txt:
      * platform/qt/fast/js/global-constructors-expected.txt:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39cfce0a
    • kov@webkit.org's avatar
      2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · bdc49f6e
      kov@webkit.org authored
              Fix critical being printed to stderr on every test. This is
              because the jar is only being created when soup hits the HTTP
              path. We should reconsider the time of its creation.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (resetDefaultsToConsistentValues):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bdc49f6e
    • tonikitoo@webkit.org's avatar
      Make the timeout in 'snav-unit-overflow-and-scroll-in-direction.html' 10x... · 9e8aa46d
      tonikitoo@webkit.org authored
      Make the timeout in 'snav-unit-overflow-and-scroll-in-direction.html' 10x shorter (from 500ms to 50ms)
      
      Rubber-stamped by Kenneth Christiansen.
      Patch by Antonio Gomes <tonikitoo@webkit.org>
      
      * fast/events/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e8aa46d
    • jpetsovits@rim.com's avatar
      2010-03-12 Jakob Petsovits <jpetsovits@rim.com> · 6c324697
      jpetsovits@rim.com authored
              Reviewed by Dirk Schulze.
      
              [OpenVG] Add support for drawing text to PainterOpenVG
              https://bugs.webkit.org/show_bug.cgi?id=35581
      
              Doesn't come with any actual font classes, as OpenVG
              by itself doesn't provide any access to platform fonts
              but just the means to draw glyphs that have been loaded
              manually before.
      
              * platform/graphics/openvg/PainterOpenVG.cpp:
              (WebCore::PlatformPainterState::PlatformPainterState):
              (WebCore::PlatformPainterState::copyPaintState):
              (WebCore::PainterOpenVG::textDrawingMode):
              (WebCore::PainterOpenVG::setTextDrawingMode):
              (WebCore::PainterOpenVG::drawText):
              * platform/graphics/openvg/PainterOpenVG.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c324697
    • jpetsovits@rim.com's avatar
      2010-03-12 Jakob Petsovits <jpetsovits@rim.com> · 5cfb2d7b
      jpetsovits@rim.com authored
              Reviewed by Dirk Schulze.
      
              [OpenVG] Use masks to implement non-rectilinear clipping
              https://bugs.webkit.org/show_bug.cgi?id=35544
      
              Requires some additional context switching logic to
              make sure the right context is current when dealing
              with the mask, because we don't store it by ourselves.
      
              Initial version of this code was written by
              Eli Fidler <efidler@rim.com>, I did a couple of
              bug fixes and efficiency improvements since then.
      
              * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
              (WebCore::GraphicsContext::clipPath):
              (WebCore::GraphicsContext::clip):
              (WebCore::GraphicsContext::clipOut):
              (WebCore::GraphicsContext::clipOutEllipseInRect):
              (WebCore::GraphicsContext::addInnerRoundedRectClip):
              * platform/graphics/openvg/PainterOpenVG.cpp:
              (WebCore::PlatformPainterState::PlatformPainterState):
              (WebCore::PlatformPainterState::~PlatformPainterState):
              (WebCore::PlatformPainterState::maskingEnabled):
              (WebCore::PlatformPainterState::applyState):
              (WebCore::PlatformPainterState::saveMaskIfNecessary):
              (WebCore::PainterOpenVG::intersectClipRect):
              (WebCore::PainterOpenVG::clipPath):
              (WebCore::PainterOpenVG::save):
              * platform/graphics/openvg/PainterOpenVG.h:
              (WebCore::PainterOpenVG::):
              * platform/graphics/openvg/SurfaceOpenVG.cpp:
              (WebCore::SurfaceOpenVG::makeCurrent):
              (WebCore::SurfaceOpenVG::makeCompatibleCurrent):
              * platform/graphics/openvg/SurfaceOpenVG.h:
              (WebCore::SurfaceOpenVG::):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cfb2d7b
    • jianli@chromium.org's avatar
      [v8] Add V8 bindings for DOMFormData. · 00ffa87a
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=36026
      
      Reviewed by Nate Chapin.
      
      Test: http/tests/local/send-form-data.html
      
      * WebCore.gypi:
      * bindings/v8/V8Index.h:
      * bindings/v8/custom/V8DOMFormDataCustom.cpp: Added.
      (WebCore::V8DOMFormData::appendCallback):
      * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
      (WebCore::V8XMLHttpRequest::sendCallback):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00ffa87a
    • jianli@chromium.org's avatar
      WebCore: Add DOMFormData.idl to expose FormData interface. · 9f776cb4
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=36024
      
      Reviewed by Sam Weinig.
      
      The implementation is based on XMLHttpRequest 2 spec:
      http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#formdata
      
      Test: http/tests/local/send-form-data.html
      
      * Android.derived.jscbindings.mk:
      * Android.derived.v8bindings.mk:
      * DerivedSources.cpp:
      * DerivedSources.make:
      * GNUmakefile.am:
      * WebCore.pri:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSDOMFormDataCustom.cpp: Added.
      * bindings/js/JSXMLHttpRequestCustom.cpp:
      (WebCore::JSXMLHttpRequest::send):
      * bindings/scripts/CodeGeneratorJS.pm:
      * html/DOMFormData.idl: Added.
      * page/DOMWindow.idl:
      
      LayoutTests: Add DOMFormData.idl to expose FormData interface
      https://bugs.webkit.org/show_bug.cgi?id=36024
      
      Reviewed by Sam Weinig.
      
      Add a layout test to test sending FormData via XMLHttpRequest. Also
      changed all test results that are affected by exposing FormData.
      
      * fast/dom/Window/window-properties-expected.txt:
      * fast/dom/Window/window-property-descriptors-expected.txt:
      * fast/dom/constructed-objects-prototypes-expected.txt:
      * fast/dom/prototype-inheritance-2-expected.txt:
      * fast/dom/prototype-inheritance-expected.txt:
      * fast/js/global-constructors-expected.txt:
      * http/tests/local/resources/send-form-data.js: Added.
      * http/tests/local/send-form-data-expected.txt: Added.
      * http/tests/local/send-form-data.html: Added.
      * http/tests/xmlhttprequest/resources/multipart-post-echo.php: Added.
      * platform/gtk/Skipped:
      * platform/gtk/fast/dom/Window/window-properties-expected.txt:
      * platform/qt/Skipped:
      * platform/qt/fast/dom/Window/window-properties-expected.txt:
      * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
      * platform/qt/fast/dom/prototype-inheritance-expected.txt:
      * platform/qt/fast/js/global-constructors-expected.txt:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f776cb4
    • jpetsovits@rim.com's avatar
      2010-03-12 Jakob Petsovits <jpetsovits@rim.com> · bbc48b80
      jpetsovits@rim.com authored
              Reviewed by Dirk Schulze.
      
              [OpenVG] Add a SurfaceOpenVG constructor for EGL client buffer surfaces
              https://bugs.webkit.org/show_bug.cgi?id=35538
      
              SurfaceOpenVG can now not only encapsulate pbuffer
              and window surfaces but also VGImage-based ones.
      
              * platform/graphics/openvg/EGLDisplayOpenVG.cpp:
              (WebCore::EGLDisplayOpenVG::createPbufferFromClientBuffer):
              * platform/graphics/openvg/EGLDisplayOpenVG.h:
              * platform/graphics/openvg/SurfaceOpenVG.cpp:
              (WebCore::SurfaceOpenVG::SurfaceOpenVG):
              * platform/graphics/openvg/SurfaceOpenVG.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55919 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbc48b80
    • aroben@apple.com's avatar
      Teach prepare-ChangeLog to find modified selectors in CSS files · ec7621d6
      aroben@apple.com authored
      Reviewed by Tim Hatcher.
      
      Fixes <http://webkit.org/b/36064> prepare-ChangeLog should extract
      modified selectors from CSS files
      
      * Scripts/prepare-ChangeLog:
      (get_function_line_ranges): Call get_selector_line_ranges_for_css for
      .css files.
      (get_selector_line_ranges_for_css): Added. Finds selectors and their
      line ranges and returns them.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec7621d6
    • eric@webkit.org's avatar
      2010-03-12 Alpha Lam <hclam@chromium.org> · 46d3d32f
      eric@webkit.org authored
              Reviewed by Eric Carlson.
      
              HTMLMediaElement crash when it is used after resource loading is canceled.
              https://bugs.webkit.org/show_bug.cgi?id=35992
      
              Adding a test to access the duration property of a video element after
              resource loading was canceled.
      
              * http/tests/media/video-cancel-load-expected.txt: Added.
              * http/tests/media/video-cancel-load.html: Added.
      2010-03-12  Alpha Lam  <hclam@chromium.org>
      
              Reviewed by Eric Carlson.
      
              Fix a crash when resource loading of media element is canceled.
              https://bugs.webkit.org/show_bug.cgi?id=35992
      
              Use of HTMLMediaElement::duration() after resource loading was canceled
              will cause a crash. This is because HTMLMediaElement::m_player is used
              when NULL.
              Test: http/tests/media/video-cancel-load.html
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::duration):
              Avoid calling to m_player when it is null.
              (WebCore::HTMLMediaElement::userCancelledLoad):
              Set m_readyState to HAVE_NOTHING.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46d3d32f
    • eric@webkit.org's avatar
      2010-03-12 Garret Kelly <gdk@chromium.org> · 48ec7beb
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Enable touch events in Chromium features gypi file.
              https://bugs.webkit.org/show_bug.cgi?id=35994
      
              * features.gypi:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48ec7beb
    • kov@webkit.org's avatar
      2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · f1c8507d
      kov@webkit.org authored
              Rubber-stamped by Kenneth Rohde Christiansen.
      
              Misc documentation fixes. Fixes (almost) all warnings emitted by
              the documentation build process. Only the broken references to JSC
              objects remain.
      
              * webkit/webkitsecurityorigin.cpp:
              * webkit/webkitwebbackforwardlist.cpp:
              * webkit/webkitwebdatasource.cpp:
              * webkit/webkitwebframe.cpp:
              * webkit/webkitwebhistoryitem.cpp:
              * webkit/webkitwebinspector.cpp:
              (webkit_web_inspector_class_init):
              * webkit/webkitwebsettings.cpp:
              (webkit_web_settings_class_init):
              * webkit/webkitwebview.cpp:
              (DNDContentsRequest::webkit_web_view_class_init):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1c8507d
    • mitz@apple.com's avatar
      <rdar://problem/7725534> CSSPrimitiveValue::parserValue() returns deleted memory · 6cfb0bee
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=20069
      
      Reviewed by Darin Adler.
      
      No test added, since with the CSS variables feature disabled, the pointer
      to the freed memory is never dereferenced.
      
      * css/CSSPrimitiveValue.cpp:
      (WebCore::valueOrPropertyName): Changed to return a const AtomicString& from
      a static table.
      (WebCore::CSSPrimitiveValue::parserValue): Updated for the above change.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cfb0bee
    • ojan@chromium.org's avatar
      2010-03-05 Ojan Vafai <ojan@chromium.org> · 0b530eb8
      ojan@chromium.org authored
              Reviewed by David Levin.
      
              Tests for smartdelete should only occur after double-click
              https://bugs.webkit.org/show_bug.cgi?id=35314
      
              Fixes the tests to make selections using the mouse in order
              to force smart-delete. It also adds/modifies tests to have them correctly
              identify cases where we are smart-deleting, but shouldn't be.
      
              Fixing to smart-delete only on mouse-based selections will be a followup patch.
      
              * editing/deleting/5390681-2.html:
              * editing/deleting/non-smart-delete.html: Added.
              * editing/deleting/smart-delete-001.html:
              * editing/deleting/smart-delete-002.html:
              * editing/deleting/smart-delete-003.html:
              * editing/deleting/smart-delete-004.html:
              * editing/editing.js:
              (doubleClick):
              (doubleClickAtSelectionStart):
              * editing/pasteboard/4944770-2.html:
              * editing/pasteboard/drag-drop-modifies-page.html:
              * editing/pasteboard/smart-drag-drop.html: Added.
              * editing/pasteboard/smart-paste-001.html:
              * editing/pasteboard/smart-paste-002.html:
              * editing/pasteboard/smart-paste-003.html:
              * editing/pasteboard/smart-paste-004.html:
              * editing/pasteboard/smart-paste-005.html:
              * editing/pasteboard/smart-paste-007.html:
              * editing/pasteboard/smart-paste-008.html:
              * editing/selection/delete-word-granularity-text-control-expected.txt: Added.
              * editing/selection/delete-word-granularity-text-control.html: Added.
              * editing/selection/script-tests/delete-word-granularity-text-control.js: Added.
              * editing/style/style-boundary-005.html:
              * platform/mac/editing/deleting/non-smart-delete-expected.checksum: Added.
              * platform/mac/editing/deleting/non-smart-delete-expected.png: Added.
              * platform/mac/editing/deleting/non-smart-delete-expected.txt: Added.
              * platform/mac/editing/deleting/smart-delete-001-expected.txt:
              * platform/mac/editing/deleting/smart-delete-002-expected.txt:
              * platform/mac/editing/deleting/smart-delete-003-expected.txt:
              * platform/mac/editing/deleting/smart-delete-004-expected.txt:
              * platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.checksum:
              * platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
              * platform/mac/editing/pasteboard/drag-drop-modifies-page-expected.txt:
              * platform/mac/editing/pasteboard/smart-drag-drop-expected.checksum: Added.
              * platform/mac/editing/pasteboard/smart-drag-drop-expected.png: Added.
              * platform/mac/editing/pasteboard/smart-drag-drop-expected.txt: Added.
              * platform/mac/editing/pasteboard/smart-paste-001-expected.txt:
              * platform/mac/editing/pasteboard/smart-paste-002-expected.txt:
              * platform/mac/editing/pasteboard/smart-paste-003-expected.txt:
              * platform/mac/editing/pasteboard/smart-paste-004-expected.txt:
              * platform/mac/editing/pasteboard/smart-paste-005-expected.txt:
              * platform/mac/editing/pasteboard/smart-paste-007-expected.txt:
              * platform/mac/editing/pasteboard/smart-paste-008-expected.txt:
              * platform/mac/editing/style/style-boundary-005-expected.checksum:
              * platform/mac/editing/style/style-boundary-005-expected.png:
              * platform/mac/editing/style/style-boundary-005-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b530eb8
    • darin@chromium.org's avatar
      2010-03-12 Darin Fisher <darin@chromium.org> · f4afd14e
      darin@chromium.org authored
              Fix Chromium build bustage.
      
              Wrap usage of WebPrivatePtr from WebNode.h in a #if
              WEBKIT_IMPLEMENTATION guard.
      
              * public/WebNode.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4afd14e
    • mitz@apple.com's avatar
      Build fix. · 96f79664
      mitz@apple.com authored
      * platform/chromium/PlatformKeyboardEventChromium.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96f79664
    • ap@apple.com's avatar
      Fixing an embarrassing typo in ChangeLog. · 71f0c598
      ap@apple.com authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71f0c598
    • mitz@apple.com's avatar
      <rdar://problem/7694674> Hover states not updated when overflow section... · b5a56888
      mitz@apple.com authored
      <rdar://problem/7694674> Hover states not updated when overflow section scrolls under stationary mouse pointer
      https://bugs.webkit.org/show_bug.cgi?id=35949
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Test: fast/events/overflow-scroll-fake-mouse-move.html
      
      Soon after an overflow section scrolls under the mouse pointer, dispatch
      a fake mouse move event. This is similar to how frame scrolling is handled
      in WebKit, and has the effect of updating hover state, dispatching DOM mouse
      events, and updating the tool tip.
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::EventHandler): Initialize m_fakeMouseMoveEventTimer.
      (WebCore::EventHandler::~EventHandler): Assert that the timer is not active.
      (WebCore::EventHandler::clear): Stop the timer.
      (WebCore::EventHandler::handleMousePressEvent): Cancel pending fake mouse
      move events.
      (WebCore::EventHandler::handleMouseMoveEvent): Ditto.
      (WebCore::EventHandler::dispatchFakeMouseMoveEventSoonInQuad): If the mouse
      is in the passed-in quad, ensure that a fake mouse move event is scheduled
      to fire soon.
      (WebCore::EventHandler::cancelFakeMouseMoveEvent): Does what the name says.
      (WebCore::EventHandler::fakeMouseMoveEventTimerFired): Constructs a
      PlatformMouseEvent with the current mouse location, modifier key state and
      time stamp and calls mouseMoved().
      * page/EventHandler.h:
      * platform/PlatformKeyboardEvent.h: Declared getCurrentModifierState().
      * platform/android/KeyEventAndroid.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.
      * platform/brew/PlatformKeyboardEventBrew.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
      * platform/chromium/PlatformKeyboardEventChromium.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.
      * platform/efl/PlatformKeyboardEventEfl.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.
      * platform/gtk/KeyEventGtk.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
      * platform/haiku/PlatformKeyboardEventHaiku.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.
      * platform/mac/KeyEventMac.mm:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
      * platform/qt/PlatformKeyboardEventQt.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Stubbed out.
      * platform/win/KeyEventWin.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Added.
      * platform/wx/KeyboardEventWx.cpp:
      (WebCore::PlatformKeyboardEvent::getCurrentModifierState): Ditto.
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollToOffset): Call
      EventHandler::dispatchFakeMouseMoveEventSoonInQuad(). Moved things around
      a little to avoid computing the repaint rect twice.
      
      LayoutTests: 
      
      * fast/events/overflow-scroll-fake-mouse-move-expected.txt: Added.
      * fast/events/overflow-scroll-fake-mouse-move.html: Added.
      * fast/events/touch/basic-multi-touch-events.html:
      * fast/events/touch/basic-single-touch-events.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5a56888
    • eric@webkit.org's avatar
      2010-03-12 Nicolas Weber <thakis@chromium.org> · 57bd3a33
      eric@webkit.org authored
              Reviewed by David Levin.
      
              [Chromium] Cmd-clicking submit buttons should submit in new tab
              https://bugs.webkit.org/show_bug.cgi?id=36023
      
              Take modifiers into account when clicking form buttons. E.g.
              cmd-clicking a submit button will submit in a new background tab,
              cmd-shift-clicking in a new foreground tab, shift-clicking in a new
              window. (On windows/linux, it's ctrl instead of cmd.)
      
              * src/FrameLoaderClientImpl.cpp:
              (WebKit::FrameLoaderClientImpl::actionSpecifiesNavigationPolicy):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57bd3a33
    • ossy@webkit.org's avatar
      2010-03-12 Csaba Osztrogonác <ossy@webkit.org> · b9229f7b
      ossy@webkit.org authored
              [Qt] css1/box_properties/acid_test.html failed in release mode (32 bit).
              But it passes in debug mode (32 and 64 bit) and in release mode (64 bit).
      
              https://bugs.webkit.org/show_bug.cgi?id=33834
      
              * platform/qt/Skipped: css1/box_properties/acid_test.html skipped again.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9229f7b
    • eric@webkit.org's avatar
      2010-03-12 Kavita Kanetkar <kkanetkar@chromium.org> · 48486986
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              [chromium] Fix memory leak in WebImageDecoder API
              https://bugs.webkit.org/show_bug.cgi?id=35946
      
              * src/WebImageDecoder.cpp:
              (WebKit::WebImageDecoder::setData):
              (WebKit::WebImageDecoder::getFrameAtIndex):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48486986
    • kov@webkit.org's avatar
      Build fix (for EWS). Make sure the new code builds on older soup. · e0f402b5
      kov@webkit.org authored
      Thanks to Dan Winship.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0f402b5
    • kov@webkit.org's avatar
      2010-03-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 4c27e4cd
      kov@webkit.org authored
              Reviewed by Eric Carlson.
      
              [GTK] DRT does not handle cookie policy setting
              https://bugs.webkit.org/show_bug.cgi?id=36056
      
              Implement cookie accept policy setting for GTK+'s LayoutTestController.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (resetDefaultsToConsistentValues):
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setAlwaysAcceptCookies):
      
      LayoutTests
      
      2010-03-12  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
      
              Reviewed by Eric Carlson.
      
              [GTK] DRT does not handle cookie policy setting
              https://bugs.webkit.org/show_bug.cgi?id=36056
      
              Fix tests to request that the cookie acceptance policy always allows cookies.
      
              * http/tests/media/video-cookie.html:
              * http/tests/media/video-referer.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4c27e4cd
    • eric@webkit.org's avatar
      2010-03-12 Adam Langley <agl@chromium.org> · 06761bbf
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              [chromium]: update Linux layout test scripts for RedHat like systems.
      
              (Tested on Fedora 12.)
      
              https://bugs.webkit.org/show_bug.cgi?id=35867
      
              * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06761bbf
    • ossy@webkit.org's avatar
      [Qt] Now css1/box_properties/acid_test.html passes, so we can unskip it. · 6efbe325
      ossy@webkit.org authored
      original bug: https://bugs.webkit.org/show_bug.cgi?id=33834
      
      * platform/qt/Skipped: css1/box_properties/acid_test.html unskipped.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6efbe325
    • eric@webkit.org's avatar
      2010-03-12 Andy Estes <aestes@apple.com> · 70589ea1
      eric@webkit.org authored
              Reviewed by Brady Eidson.
      
              Remove an unused method.
      
              https://bugs.webkit.org/show_bug.cgi?id=35940
      
              * Plugins/WebPluginController.mm:
              removed - (void)showURL:(NSURL *) inFrame:(NSString *)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70589ea1
    • eric@webkit.org's avatar
      2010-03-12 Peter Varga <pvarga@inf.u-szeged.hu> · cf816e06
      eric@webkit.org authored
              Reviewed by David Levin.
      
              Two functions tryConsumeCharacter() and tryConsumeCharacterClass() are
              removed from yarr/RegexInterpreter.cpp because they are never called.
      
              * yarr/RegexInterpreter.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf816e06
    • ossy@webkit.org's avatar
      [Qt] DRT failing on test introduced in r55499 · 7db0f0c8
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=35729
      
      Now fast/events/zoom-dblclick.html passes, so we can unskip it.
      
      * platform/qt/Skipped: fast/events/zoom-dblclick.html unskipped.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55899 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7db0f0c8