1. 12 Jul, 2010 7 commits
    • hamaji@chromium.org's avatar
      2010-07-12 Shinichiro Hamaji <hamaji@chromium.org> · d4bf4b83
      hamaji@chromium.org authored
              Unreviewed. Put wrong results for Mac and Win instead of Skipped list.
      
              Results for editing/pasteboard/5761530-1.html are wrong
              https://bugs.webkit.org/show_bug.cgi?id=38437
      
              * platform/mac/Skipped:
              * platform/mac/editing/pasteboard/5761530-1-expected.txt: Copied from LayoutTests/platform/chromium/editing/pasteboard/5761530-1-expected.txt.
              * platform/win/editing/pasteboard/5761530-1-expected.txt: Copied from LayoutTests/platform/chromium/editing/pasteboard/5761530-1-expected.txt.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4bf4b83
    • pfeldman@chromium.org's avatar
      2010-07-12 Pavel Feldman <pfeldman@chromium.org> · 88f2beca
      pfeldman@chromium.org authored
              Not reviewed. Chromium tests fix.
      
              [Chromium, V8] r63057 regressed url tests.
      
              https://bugs.webkit.org/show_bug.cgi?id=42063
      
              * bindings/scripts/CodeGeneratorV8.pm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88f2beca
    • steveblock@google.com's avatar
      2010-07-12 Steve Block <steveblock@google.com> · fbe6b1ad
      steveblock@google.com authored
              Reviewed by Alexey Proskuryakov.
      
              XPath substring function does not correctly handle non-positive values for the position argument
              https://bugs.webkit.org/show_bug.cgi?id=41913
      
              This patch changes the behavior of the XPath evaluate function when a non-positive
              position argument is supplied and no length argument is supplied. In this case,
              we reset the position to 1. This follows the spec and matches the current behaviour
              when a length argument is supplied.
      
              Test: fast/xpath/substring-non-positive-postion.html
      
              * xml/XPathFunctions.cpp:
              (WebCore::XPath::FunSubstring::evaluate):
      2010-07-12  Steve Block  <steveblock@google.com>
      
              Reviewed by Alexey Proskuryakov.
      
              XPath substring function does not correctly handle non-positive values for the position argument
              https://bugs.webkit.org/show_bug.cgi?id=41913
      
              * fast/xpath/substring-non-positive-postion-expected.txt: Added.
              * fast/xpath/substring-non-positive-postion.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbe6b1ad
    • jorlow@chromium.org's avatar
      2010-07-12 Jeremy Orlow <jorlow@chromium.org> · 871589da
      jorlow@chromium.org authored
              Build fix.  Add an include.
      
              * public/WebCommon.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      871589da
    • jorlow@chromium.org's avatar
      2010-06-27 Jeremy Orlow <jorlow@chromium.org> · a815bc8c
      jorlow@chromium.org authored
              Reviewed by Dumitru Daniliuc.
      
              Implement IDBObjectStore.get/set/remove
              https://bugs.webkit.org/show_bug.cgi?id=41250
      
              Modify existing test to provide basic coverage for get/put/remove functions.
      
              * storage/indexeddb/script-tests/idb-objectstore-request.js:
              (test):
              (openSuccess):
              (createSuccess):
              (addSuccess):
              (getSuccess):
              (removeSuccess):
      2010-06-27  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Dumitru Daniliuc.
      
              Implement IDBObjectStore.get/set/remove
              https://bugs.webkit.org/show_bug.cgi?id=41250
      
              Implement these functions in IDBObjectStore,
              add plumbing, teach IDBAny/Callbacks how to deal
              with IDBKey, and a few small bits of cleanup.
      
              Test: Modified existing test to provide basic coverage.
                    Will add much more extensive layout test coverage
                    in future patches.
      
              * Android.derived.jscbindings.mk:
              * Android.derived.v8bindings.mk:
              * Android.jscbindings.mk:
              * Android.mk:
              * Android.v8bindings.mk:
              * CMakeLists.txt:
              * WebCore.gypi:
              * WebCore.pri:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSIDBAnyCustom.cpp:
              (WebCore::toJS):
              * bindings/v8/custom/V8IDBAnyCustom.cpp:
              (WebCore::toV8):
              * storage/IDBAny.cpp:
              (WebCore::IDBAny::idbKey):
              (WebCore::IDBAny::set):
              * storage/IDBAny.h:
              (WebCore::IDBAny::):
              * storage/IDBAny.idl:
              * storage/IDBCallbacks.h:
              * storage/IDBDatabaseRequest.h:
              * storage/IDBDatabaseRequest.idl:
              * storage/IDBKeyRange.h:
              * storage/IDBObjectStore.h:
              (WebCore::IDBObjectStore::):
              * storage/IDBObjectStoreImpl.cpp:
              (WebCore::IDBObjectStoreImpl::IDBObjectStoreImpl):
              (WebCore::IDBObjectStoreImpl::get):
              (WebCore::IDBObjectStoreImpl::set):
              (WebCore::IDBObjectStoreImpl::remove):
              * storage/IDBObjectStoreImpl.h:
              * storage/IDBObjectStoreRequest.cpp:
              (WebCore::IDBObjectStoreRequest::get):
              (WebCore::IDBObjectStoreRequest::add):
              (WebCore::IDBObjectStoreRequest::modify):
              (WebCore::IDBObjectStoreRequest::addOrModify):
              (WebCore::IDBObjectStoreRequest::remove):
              * storage/IDBObjectStoreRequest.h:
              * storage/IDBObjectStoreRequest.idl:
              * storage/IDBRequest.cpp:
              (WebCore::IDBRequest::onSuccess):
              * storage/IDBRequest.h:
      2010-06-27  Jeremy Orlow  <jorlow@chromium.org>
      
              Reviewed by Dumitru Daniliuc.
      
              Implement IDBObjectStore.get/set/remove
              https://bugs.webkit.org/show_bug.cgi?id=41250
      
              Plumbing for new features, IDBKey, and added support
              for both invalid (i.e. not serializable) and null
              (i.e. the RefPtr was 0) to SerializedScriptValue.
      
              * WebKit.gyp:
              * public/WebIDBCallbacks.h:
              (WebKit::WebIDBCallbacks::onSuccess):
              * public/WebIDBKey.h: Added.
              (WebKit::WebIDBKey::WebIDBKey):
              (WebKit::WebIDBKey::operator=):
              (WebKit::WebIDBKey::):
              * public/WebIDBObjectStore.h:
              (WebKit::WebIDBObjectStore::get):
              (WebKit::WebIDBObjectStore::set):
              (WebKit::WebIDBObjectStore::remove):
              (WebKit::WebIDBObjectStore::createIndex):
              (WebKit::WebIDBObjectStore::index):
              (WebKit::WebIDBObjectStore::removeIndex):
              * public/WebSerializedScriptValue.h:
              * src/IDBCallbacksProxy.cpp:
              (WebCore::IDBCallbacksProxy::onSuccess):
              * src/IDBCallbacksProxy.h:
              * src/IDBObjectStoreProxy.cpp:
              (WebCore::IDBObjectStoreProxy::get):
              (WebCore::IDBObjectStoreProxy::set):
              (WebCore::IDBObjectStoreProxy::remove):
              * src/IDBObjectStoreProxy.h:
              * src/WebIDBCallbacksImpl.cpp:
              (WebCore::WebIDBCallbacksImpl::onSuccess):
              * src/WebIDBCallbacksImpl.h:
              * src/WebIDBKey.cpp: Added.
              (WebKit::WebIDBKey::~WebIDBKey):
              (WebKit::WebIDBKey::createNull):
              (WebKit::WebIDBKey::createInvalid):
              (WebKit::WebIDBKey::assign):
              (WebKit::WebIDBKey::assignNull):
              (WebKit::WebIDBKey::assignInvalid):
              (WebKit::WebIDBKey::type):
              (WebKit::WebIDBKey::string):
              (WebKit::WebIDBKey::number):
              (WebKit::WebIDBKey::WebIDBKey):
              (WebKit::WebIDBKey::operator=):
              (WebKit::WebIDBKey::operator PassRefPtr<IDBKey>):
              * src/WebIDBObjectStoreImpl.cpp:
              (WebKit::WebIDBObjectStoreImpl::get):
              (WebKit::WebIDBObjectStoreImpl::set):
              (WebKit::WebIDBObjectStoreImpl::remove):
              * src/WebIDBObjectStoreImpl.h:
              * src/WebSerializedScriptValue.cpp:
              (WebKit::WebSerializedScriptValue::createInvalid):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a815bc8c
    • mjs@apple.com's avatar
      2010-07-11 Maciej Stachowiak <mjs@apple.com> · 5c2308c3
      mjs@apple.com authored
              Reviewed by Dan Bernstein.
      
              Implement animation-related methods for WebKitTestRunner
              https://bugs.webkit.org/show_bug.cgi?id=42053
      
              * WebCore.exp.in: Export Document::getElementById for WebKit2's benefit.
      2010-07-11  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Implement animation-related methods for WebKitTestRunner
              https://bugs.webkit.org/show_bug.cgi?id=42053
              
              Implemented numberOfActiveAnimatiosn and pauseAnimationAtTimeOnElementWithId. Many
              animation tests were hanging otherwise.
      
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::numberOfActiveAnimations):
              (WTR::LayoutTestController::pauseAnimationAtTimeOnElementWithId):
              (WTR::numberOfActiveAnimationsCallback):
              (WTR::pauseAnimationAtTimeOnElementWithIdCallback):
              (WTR::LayoutTestController::staticFunctions):
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      2010-07-11  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Implement animation-related methods for WebKitTestRunner
              https://bugs.webkit.org/show_bug.cgi?id=42053
      
              Implemented some helpers for WebKitTestRunner;
              
              * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
              (WKBundleFrameGetNumberOfActiveAnimations):
              (WKBundleFramePauseAnimationOnElementWithId):
              * WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
              * WebProcess/WebPage/WebFrame.cpp:
              (WebKit::WebFrame::numberOfActiveAnimations):
              (WebKit::WebFrame::pauseAnimationOnElementWithId):
              * WebProcess/WebPage/WebFrame.h:
              * mac/WebKit2.exp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c2308c3
    • dbates@webkit.org's avatar
      2010-07-11 Daniel Bates <dbates@rim.com> · 4ba135e5
      dbates@webkit.org authored
              Reviewed by David Kilzer.
      
              Enable executable support for svn-apply and svn-unapply
              https://bugs.webkit.org/show_bug.cgi?id=39409
      
              Connect up the Git and SVN executable bit support in parseDiff() so that
              executable bit changes are propagated via the returned diff hash to the
              patch function in svn-apply and svn-unapply.
      
              * Scripts/VCSUtils.pm:
                - Modified parseDiff() to call parseSvnDiffProperties when
                  it finds the start of an SVN property change diff.
                - Removed FIXME comment above parseSvnDiffProperties() since
                  it is now being used by parseDiff().
                - Export method scmToggleExecutableBit() now that we added the
                  executableBitDelta hash key. (This should have been exported
                  when we added this function in Bug #38423 <https://bugs.webkit.org/show_bug.cgi?id=38423>).
              * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
                - Updated results for:
                  "rename (with executable bit change)"
                    - Test value of executableBitDelta (now that we have support).
                  "SVN: binary file (isBinary true)"
                    - Remove the property change diff from svnConvertedText. We plan
                      to remove svnConvertedText in the future. So, we decided
                      against adding such support to any new code, such as the
                      property parsing routines. Therefore, we do not keep SVN
                      converted text for property change diffs.
                - Added unit tests:
                  "SVN: file change diff with property change diff"
                  "SVN: file change diff, followed by property change diff on different file"
                  "SVN: property diff, followed by file change diff"
                  "SVN: copied file with property change"
                  "SVN: two consecutive property diffs"
                  "SVN: binary file with executable bit change"
                  "SVN: binary file followed by property change on different file"
                  "SVN: binary file followed by file change on different file"
                  "SVN: file change diff with property change, followed by property change diff"
                  "SVN: file change diff with property change, followed by file change diff"
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ba135e5
  2. 11 Jul, 2010 5 commits
    • mjs@apple.com's avatar
      2010-07-11 Maciej Stachowiak <mjs@apple.com> · a494786b
      mjs@apple.com authored
              Reviewed by Dan Bernstein.
      
              Implement waitUntilDone and notifyDone for WebKitTestRunner
              https://bugs.webkit.org/show_bug.cgi?id=42049
      
              With this fix, most of the DOM tests pass.
              
              * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
              (WTR::InjectedBundle::didCreatePage): Track the main page. Not
              a great way to do it in the future case where we may get multiple
              pages - we really need a way to send it over from the ui process.
              * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
              (WTR::InjectedBundle::page): A way to get the main page.
              * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
              (WTR::InjectedBundlePage::InjectedBundlePage): Initialize m_isLoading to false.
              (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Track that we
              are loading.
              (WTR::InjectedBundlePage::dump): Factor into a method so this can be
              called by the layout test controller. Also, cancel any pending watchdogs.
              (WTR::InjectedBundlePage::didFinishLoadForFrame): Note that we are done loading.
              (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame): Ditto.
              * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
              (WTR::InjectedBundlePage::isLoading): A way to track if we are loading.
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::LayoutTestController): Initialize m_waitToDump
              to false.
              (WTR::LayoutTestController::invalidateWaitToDumpWatchdog): Invalidate 
              the watchdog.
              (WTR::waitUntilDoneWatchdogFired): Static helper for the watchdog timer.
              (WTR::LayoutTestController::setWaitToDump): Set the flag.
              (WTR::LayoutTestController::waitToDumpWatchdogTimerFired): Handle the case
              where waitUntilDone times out.
              (WTR::LayoutTestController::notifyDone): Dump, if loading is done.
              (WTR::waitUntilDoneCallback): JS glue for waitUntilDone.
              (WTR::notifyDoneCallback): JS glue for notifyDone.
              (WTR::LayoutTestController::staticFunctions): Add waitUntilDone and notifyDone
              to the layoutController.
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
              (WTR::LayoutTestController::waitToDump): Inline method to get the wait state.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a494786b
    • commit-queue@webkit.org's avatar
      2010-07-11 Gyuyoung Kim <gyuyoung.kim@samsung.com> · fdaf2412
      commit-queue@webkit.org authored
              Reviewed by Adam Barth.
      
              [EFL] Fix style errors in ewk_private.h.
              https://bugs.webkit.org/show_bug.cgi?id=41742
      
              * efl/ewk/ewk_private.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fdaf2412
    • abarth@webkit.org's avatar
      2010-07-11 Adam Barth <abarth@webkit.org> · 1a214bc0
      abarth@webkit.org authored
              Rubber-stamped by Eric Seidel
      
              Add a complete list of the HTML5 entities in JSON format.
      
              * html/HTMLEntityNames.json: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a214bc0
    • mrobinson@webkit.org's avatar
      2010-07-11 Martin Robinson <mrobinson@igalia.com> · 04db5ce5
      mrobinson@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] WebKitWebView should support drops
              https://bugs.webkit.org/show_bug.cgi?id=39843
      
              Add support for dropping content onto GTK+ WebViews.
      
              No new tests, as the DRT does not support simulating drops yet.
      
              * platform/gtk/ClipboardUtilitiesGtk.cpp:
              (WebCore::dragOperationToGdkDragAction): Added.
              (WebCore::gdkDragActionToDragOperation): Properly detect DragOperationEvery.
              * platform/gtk/ClipboardUtilitiesGtk.h: Add declaration for dragOperationToGdkDragAction.
              * platform/gtk/PasteboardHelper.cpp:
              Add new target atom and rename the markup target type to match the others.
              Add a method which fills a data object from drop data.
              (WebCore::PasteboardHelper::initializeTargetList): Add support for new atoms.
              (WebCore::selectionDataToUTF8String): Added this helper.
              (WebCore::PasteboardHelper::getClipboardContents): Use the selectionDataToUTF8String helper.
              (WebCore::PasteboardHelper::targetListForDataObject): Change to reflect markup atom rename.
              (WebCore::PasteboardHelper::fillDataObjectFromDropData): Added.
              (WebCore::PasteboardHelper::dropAtoms): Added.
              * platform/gtk/PasteboardHelper.h: Add declarations of new methods.
      2010-07-11  Martin Robinson  <mrobinson@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] WebKitWebView should support drops
              https://bugs.webkit.org/show_bug.cgi?id=39843
      
              Add support for dropping content onto GTK+ WebViews.
      
              * webkit/webkitprivate.h:
              Add a DroppingContext struct to keep track of drop data while the drop is
              in progress. Have WebKitWebView keep a map of GdkDragContexts to DroppingContexts.
              * webkit/webkitwebview.cpp: Add necessary includes and globalPointForClientPoint helper.
              (webkit_web_view_popup_menu_handler): Use globalPointForClientPoint helper.
              (webkit_web_view_dispose): Properly clean up droppingContexts member.
              (webkit_web_view_finalize): Delete droppingContext member.
              (globalPointForClientPoint): Added.
              (doDragLeaveLater): Added.
              (webkit_web_view_drag_leave): Added.
              (webkit_web_view_drag_motion): Added.
              (webkit_web_view_drag_data_received): Added.
              (webkit_web_view_drag_drop): Added.
              (webkit_web_view_class_init): Connect new drop signal handlers to the widget definition.
              (webkit_web_view_init): Set up the widget as a drop destination and initialize droppingContexts.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04db5ce5
    • darin@apple.com's avatar
      2010-07-10 Darin Adler <darin@apple.com> · ccb6ba37
      darin@apple.com authored
              Reviewed by Anders Carlsson.
      
              Enhance content attribute reflection for URL attributes, including adding a non-empty option
              https://bugs.webkit.org/show_bug.cgi?id=42040
      
              Test: fast/dom/URL-attribute-reflection.html
      
              Changed syntax from [ReflectURL] to [Reflect,URL] and also added support for
              a new option, NonEmpty, which implements the non-empty URL concept from the
              HTML5 specification.
      
              * bindings/scripts/CodeGenerator.pm: Changed code to expect the Reflect and URL
              extended attributes to come in separately. The URL one simply means "the string
              of this attribute is a URL", since we don't have a distinct type for URL. Also
              added a new NonEmpty extended attribute.
      
              * bindings/scripts/CodeGeneratorJS.pm: Removed now-unneeded code to handle ReflectURL.
              * bindings/scripts/CodeGeneratorV8.pm: Ditto.
      
              * bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated for new added test cases
              and the fix I made to the reflectedCustomURLAttr test.
              * bindings/scripts/test/CPP/WebDOMTestObj.h: Ditto.
              * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Ditto.
              * bindings/scripts/test/GObject/WebKitDOMTestObj.h: Ditto.
              * bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
              * bindings/scripts/test/JS/JSTestObj.h: Ditto.
              * bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
              * bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
              * bindings/scripts/test/V8/V8TestObj.cpp: Ditto. Also, for some reason the V8
              bindig writes out the keywords into the generated file as comments, so the keyword
              change had a direct efffect on the output file.
      
              * bindings/scripts/test/TestObj.idl: Changed the test cases for ReflectURL to use
              the new syntax. Added test cases for NonEmpty. Fixed the name of
              reflectedNonEmptyURLAttr, which accidentally was repeating reflectedURLAttr
              instead; never noticed because we never compile the test output.
      
              * dom/Element.cpp:
              (WebCore::Element::getNonEmptyURLAttribute): Added. For use by NonEmpty and also
              by any code that wants to implement the non-empty URL content attribute semantic.
              * dom/Element.h: Ditto.
      
              * html/HTMLAnchorElement.idl: Use Reflect,URL instead of ReflectURL.
              * html/HTMLAreaElement.idl: Ditto.
              * html/HTMLFrameElement.idl: Ditto.
              * html/HTMLImageElement.idl: Ditto.
              * html/HTMLInputElement.idl: Ditto.
              * html/HTMLLinkElement.idl: Ditto.
              * html/HTMLMediaElement.idl: Ditto.
              * html/HTMLObjectElement.idl: Ditto.
              * html/HTMLScriptElement.idl: Ditto.
              * html/HTMLVideoElement.idl: Ditto.
      2010-07-10  Darin Adler  <darin@apple.com>
      
              Reviewed by Anders Carlsson.
      
              Enhance content attribute reflection for URL attributes, including adding a non-empty option
              https://bugs.webkit.org/show_bug.cgi?id=42040
      
              The current test results show many failures, and we should follow up with fixes
              either to the DOM implementation, or to the test result expectations.
      
              * fast/dom/URL-attribute-reflection-expected.txt: Added.
              * fast/dom/URL-attribute-reflection.html: Added.
              * fast/dom/script-tests/URL-attribute-reflection.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccb6ba37
  3. 10 Jul, 2010 15 commits
    • oliver@apple.com's avatar
      2010-07-10 Oliver Hunt <oliver@apple.com> · 563fc0a7
      oliver@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              HAVE_COMPUTED_GOTO is dependent on the interpreter being enabled
              https://bugs.webkit.org/show_bug.cgi?id=42039
      
              Separate the existence of computed goto support in the compiler
              from whether or not we are using the interpreter.  All the current
              HAVE(COMPUTED_GOTO) guards are for the interpreter, but I'd like
              the option of using it elsewhere.  The interpreter now uses
              ENABLE(COMPUTED_GOTO_INTERPRETER)
      
              * bytecode/Instruction.h:
              (JSC::Instruction::Instruction):
              * bytecode/Opcode.h:
              * interpreter/Interpreter.cpp:
              (JSC::Interpreter::Interpreter):
              (JSC::Interpreter::isOpcode):
              (JSC::Interpreter::privateExecute):
              * interpreter/Interpreter.h:
              (JSC::Interpreter::getOpcode):
              (JSC::Interpreter::getOpcodeID):
              * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      563fc0a7
    • oliver@apple.com's avatar
      2010-07-10 Oliver Hunt <oliver@apple.com> · e3c2546b
      oliver@apple.com authored
              Reviewed by Gavin Barraclough.
      
              Remove switches from inner expression loops in the parser
              https://bugs.webkit.org/show_bug.cgi?id=42035
      
              Use bitmasks and flags on the token types to identify unary and
              binary operators, rather than switching on the token type to
              identify them.
      
              * parser/JSParser.cpp:
              (JSC::isUnaryOp):
              (JSC::JSParser::isBinaryOperator):
              * parser/JSParser.h:
              (JSC::):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3c2546b
    • tonyg@chromium.org's avatar
      2010-07-10 Tony Gentilcore <tonyg@chromium.org> · f027163b
      tonyg@chromium.org authored
              Reviewed by Darin Adler.
      
              Add missing derrived sources to xcode project
              https://bugs.webkit.org/show_bug.cgi?id=42034
      
              This allows --web-timing to work with build-webkit on OSX with JSC.
              This should have been done in bug 41442.
      
              No new tests because no new functionality.
      
              * WebCore.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f027163b
    • andersca@apple.com's avatar
      Don't initialize plug-ins until allowed by the page · 6058feac
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=42033
      
      Reviewed by Sam Weinig.
      
      WebCore:
      
      * WebCore.exp.in:
      Export Document::addMediaCanStartListener and Document::removeMediaCanStartListener.
      
      WebKit2:
      
      * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
      (WebKit::NetscapePlugin::paint):
      (WebKit::NetscapePlugin::geometryDidChange):
      Assert that the plug-in is started.
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::PluginView):
      Initialize m_isWaitingUntilMediaCanStart.
      
      (WebKit::PluginView::~PluginView):
      If necessary, remove the plug-in view as a MediaCanStartListener.
      
      (WebKit::PluginView::initializePlugin):
      If we're not allowed to initialize the plug-in, add the plug-in view as a MediaCanStartListener.
      
      (WebKit::PluginView::paint):
      Check that the plug-in is initialized.
      
      (WebKit::PluginView::viewGeometryDidChange):
      Ditto.
      
      (WebKit::PluginView::mediaCanStart):
      Initialize the plug-in.
      
      * WebProcess/Plugins/PluginView.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6058feac
    • andersca@apple.com's avatar
      Have the plug-in view initialize the plug-in · 1b0dd381
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=42030
      
      Reviewed by Dan Bernstein.
      
      * WebProcess/Plugins/DummyPlugin.cpp:
      (WebKit::DummyPlugin::initialize):
      * WebProcess/Plugins/DummyPlugin.h:
      Plugin::initialize now takes a struct.
      
      * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
      (WebKit::NetscapePlugin::initialize):
      * WebProcess/Plugins/Netscape/NetscapePlugin.h:
      Plugin::initialize now takes a struct.
      
      * WebProcess/Plugins/Plugin.h:
      Add Parameters struct.
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::PluginView):
      Add Parameters parameter.
      
      (WebKit::PluginView::~PluginView):
      Add m_plugin null check.
      
      (WebKit::PluginView::initializePlugin):
      Try to initialize the plug-in and zero out the plug-in if initialization fails.
      
      (WebKit::PluginView::paint):
      Add m_plugin null check.
      
      (WebKit::PluginView::setParent):
      Initialize the plug-in.
      
      * WebProcess/Plugins/PluginView.h:
      (WebKit::PluginView::create):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::createPlugin):
      Don't initialize the plug-in here.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b0dd381
    • weinig@apple.com's avatar
      WebCore: Patch for https://bugs.webkit.org/show_bug.cgi?id=42021 · 93d0aedd
      weinig@apple.com authored
      isEqualNode should work for DocumentType nodes
      
      Reviewed by Anders Carlsson.
      
      Test: fast/dom/Node/isEqualNode.html
      
      * dom/Node.cpp:
      (WebCore::Node::isEqualNode): Add DocumentType logic from the DOM3 spec.
      
      LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=42021
      isEqualNode should work for DocumentType nodes
      
      Reviewed by Anders Carlsson.
      
      * fast/dom/Node/isEqualNode-expected.txt: Added.
      * fast/dom/Node/isEqualNode.html: Added.
      * fast/dom/Node/script-tests/isEqualNode.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93d0aedd
    • dbates@webkit.org's avatar
      2010-07-10 Daniel Bates <dbates@rim.com> · c4737d8b
      dbates@webkit.org authored
              Reviewed by Adam Barth.
      
              Move enum ReasonForCallingCanExecuteScripts to header ScriptControllerBase.h
              https://bugs.webkit.org/show_bug.cgi?id=39339
      
              Moved the enum ReasonForCallingCanExecuteScripts, which was
              defined in both the JSC and V8 ScriptController.h file, into
              a shared file called ScriptControllerBase.h.
      
              No functionality was changed, so no new tests.
      
              * GNUmakefile.am: Added file bindings/ScriptControllerBase.h.
              * WebCore.gypi: Ditto.
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.vcproj/WebCoreCommon.vsprops: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * bindings/ScriptControllerBase.h: Added.
              (WebCore::):
              * bindings/js/ScriptController.h: #include ScriptControllerBase.h
              * bindings/v8/ScriptController.h: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4737d8b
    • andersca@apple.com's avatar
      Call Page::canStartMedia when the WKView is added to/removed from a window · 4ced5a03
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=42029
      
      Reviewed by Oliver Hunt.
      
      * Shared/CoreIPCSupport/WebPageMessageKinds.h:
      (WebPageMessage::):
      Add SetIsInWindow.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView initWithFrame:pageNamespaceRef:]):
      Call setIsInWindow.
      
      (-[WKView _updateVisibility]):
      Call setIsInWindow.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::WebPageProxy):
      Initialize m_isInWindow.
      
      (WebKit::WebPageProxy::setIsInWindow):
      Send WebPageMessage::SetIsInWindow.
      
      * UIProcess/WebPageProxy.h:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::setIsInWindow):
      Call Page::canStartMedia.
      
      (WebKit::WebPage::didReceiveMessage):
      Handle the SetIsInWindow message.
      
      * WebProcess/WebPage/WebPage.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ced5a03
    • mitz@apple.com's avatar
      <rdar://problem/8153214> Continuation outlines in layers do not paint correctly · e21c59ac
      mitz@apple.com authored
      Reviewed by Anders Carlsson.
      
      WebCore: 
      
      Test: fast/inline/continuation-outlines-with-layers-2.html
      
      Continuation outlines are normally painted by the containing block. However, when the
      block and the inline are not enclosed by the same self-painting layer, the inline has to
      paint its own outlines. This was handled correctly only for the case where the inline had
      its own self-painting layer, but now when an ancestor inline had the self-painting layer.
      
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::paint): Instead of testing for having a self-painting layer, test
      whether any intermediate box between the inline and the containing block has a self-painting
      layer.
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::paintObject): Ditto.
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::enclosingBoxModelObject): Added this utility method.
      * rendering/RenderObject.h:
      
      LayoutTests: 
      
      * fast/inline/continuation-outlines-with-layers-2.html: Added.
      * platform/mac/fast/inline/continuation-outlines-with-layers-2-expected.checksum: Added.
      * platform/mac/fast/inline/continuation-outlines-with-layers-2-expected.png: Added.
      * platform/mac/fast/inline/continuation-outlines-with-layers-2-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e21c59ac
    • andersca@apple.com's avatar
      Reuse initialized NetscapePluginModules, pass parameters to NPP_New · 2e82b231
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=42028
      
      Reviewed by Dan Bernstein.
      
      * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
      (WebKit::NetscapePlugin::NetscapePlugin):
      Let the plug-in module know that a plug-in has been created.
      
      (WebKit::NetscapePlugin::~NetscapePlugin):
      Let the plug-in module know that a plug-in has been destroyed.
      
      (WebKit::NetscapePlugin::initialize):
      Pass the MIME type and parameters to the plug-in.
      
      * WebProcess/Plugins/Netscape/NetscapePluginModule.cpp:
      (WebKit::initializedNetscapePluginModules):
      Add list of initialized plug-in modules.
      
      (WebKit::NetscapePluginModule::NetscapePluginModule):
      Initialize m_pluginCount to 0.
      
      (WebKit::NetscapePluginModule::~NetscapePluginModule):
      Assert that we're not in the list of initialized plug-ins.
      
      (WebKit::NetscapePluginModule::pluginCreated):
      Increment the plug-in count.
      
      (WebKit::NetscapePluginModule::pluginDestroyed):
      Decrement the plug-in count and call shutdown if it's 0.
      
      (WebKit::NetscapePluginModule::shutdown):
      Call NP_Shutdown and remove the plug-in from the list of initialized plug-ins.
      
      (WebKit::NetscapePluginModule::getOrCreate):
      Look for an already initialized plug-in module before creating one.
      
      (WebKit::NetscapePluginModule::load):
      Set m_isInitialized to true.
      
      * WebProcess/Plugins/Netscape/mac/NetscapePluginModuleMac.cpp:
      (WebKit::NetscapePluginModule::unload):
      Leak the CFBundleRef to avoid possible crashes.
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::createPlugin):
      Call getOrCreate instead of create.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e82b231
    • commit-queue@webkit.org's avatar
      2010-07-10 François Sausset <sausset@gmail.com> · ea43d9a6
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Build fix: syntax and typo issues
              https://bugs.webkit.org/show_bug.cgi?id=41859
      
              * html/HTMLTreeBuilder.cpp:
              (WebCore::HTMLTreeBuilder::processStartTagForInBody):
              (WebCore::HTMLTreeBuilder::processStartTag):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea43d9a6
    • eric@webkit.org's avatar
      2010-07-10 Eric Seidel <eric@webkit.org> · c3cde884
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              HTMLTreeBuilder needs adjustForeignAttributes support
              https://bugs.webkit.org/show_bug.cgi?id=42022
      
              * html5lib/runner-expected-html5.txt:
               - We now pass 3 more tests.
      2010-07-10  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Adam Barth.
      
              HTMLTreeBuilder needs adjustForeignAttributes support
              https://bugs.webkit.org/show_bug.cgi?id=42022
      
              To add adjust foreign attributes support I had to add an
              AtomicString (prefixed name) to QualifiedName hash.  Once I had
              done that, I decided it would be best for the other "adjust" functions
              to share the same hash logic, so I moved them to using the same
              AtomicString -> QualifiedName hash as well.
      
              Tested by html5lib/runner.html
      
              * dom/Attribute.h:
              (WebCore::Attribute::parserSetName):
              * html/HTMLTreeBuilder.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3cde884
    • rwlbuis@webkit.org's avatar
      2010-07-10 Rob Buis <rwlbuis@gmail.com> · eca7f184
      rwlbuis@webkit.org authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=41978
              Remove namespace prefixes from idl files
      
              No new tests, idl syntax fixes.
      
              * css/CSSImportRule.idl:
              * css/CSSMediaRule.idl:
              * css/CSSStyleSheet.idl:
              * css/CSSVariablesRule.idl:
              * svg/SVGAnimatedString.idl:
              * svg/SVGColor.idl:
              * svg/SVGDocument.idl:
              * svg/SVGLangSpace.idl:
              * svg/SVGSVGElement.idl:
              * svg/SVGStringList.idl:
              * svg/SVGStylable.idl:
              * svg/SVGStyleElement.idl:
              * svg/SVGTests.idl:
              * svg/SVGZoomEvent.idl:
              * xml/XPathEvaluator.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eca7f184
    • dumi@chromium.org's avatar
      Unreviewed, GTK build fix. · bb7b0878
      dumi@chromium.org authored
      * bindings/gobject/GObjectEventListener.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb7b0878
    • dumi@chromium.org's avatar
      Remove unnecessary includes in header files in WebCore/dom. · a7b1b353
      dumi@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=41941
      
      Reviewed by Darin Adler.
      
      * css/StyleMedia.h:
      * dom/BeforeLoadEvent.h:
      * dom/CustomEvent.h:
      * dom/DOMStringMap.h:
      * dom/DeviceOrientationEvent.h:
      * dom/EventListener.h:
      * dom/MessagePort.h:
      * dom/Node.cpp:
      * dom/NodeFilter.h:
      * dom/NodeRareData.h:
      * dom/RegisteredEventListener.h:
      * dom/SelectorNodeList.cpp:
      * dom/SelectorNodeList.h:
      * dom/StyleElement.h:
      * dom/Traversal.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7b1b353
  4. 09 Jul, 2010 13 commits
    • bweinstein@apple.com's avatar
      Windows testers running Windows 7 were hanging during test_kill_process. Changing the · 17ca0fb7
      bweinstein@apple.com authored
      number of attempts from 3 to 10 fixes the problem on the new bots (and doesn't seem to
      slow down the tests).
      
      Rubber-stamped by Dan Bernstein.
      
      * Scripts/webkitpy/common/system/executive.py:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17ca0fb7
    • jam@chromium.org's avatar
      2010-07-09 John Abd-El-Malek <jam@chromium.org> · c72ab915
      jam@chromium.org authored
              Reviewed by Darin Fisher.
      
              [chromium] Take out WebPlugin::supportsFind since we can accomplish the same thing by having a return value on startFind
              https://bugs.webkit.org/show_bug.cgi?id=42011
      
              * public/WebPlugin.h:
              (WebKit::WebPlugin::startFind):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c72ab915
    • tony@chromium.org's avatar
      2010-07-09 Tony Chang <tony@chromium.org> · 7c6786c3
      tony@chromium.org authored
              Reviewed by Ojan Vafai.
      
              crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting pre
              https://bugs.webkit.org/show_bug.cgi?id=38231
      
              * editing/execCommand/indent-pre-expected.txt: Added.
              * editing/execCommand/indent-pre.html: Added.
      2010-07-09  Tony Chang  <tony@chromium.org>
      
              Reviewed by Ojan Vafai.
      
              crash in WebCore::CompositeEditCommand::splitTreeToNode when indenting pre
              https://bugs.webkit.org/show_bug.cgi?id=38231
      
              Test: editing/execCommand/indent-pre.html
      
              * editing/IndentOutdentCommand.cpp:
              (WebCore::countParagraphs):
              (WebCore::IndentOutdentCommand::indentRegion): Split text nodes into one node per paragraph
                                                             so moveParagraph doesn't get confused.
              (WebCore::IndentOutdentCommand::splitTextNodes):
              * editing/IndentOutdentCommand.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c6786c3
    • arv@chromium.org's avatar
      2010-07-09 Erik Arvidsson <arv@chromium.org> · 26b6d1b9
      arv@chromium.org authored
              Reviewed by Darin Adler.
      
              Computed style is not implemented for padding-start, padding-end, margin-start, margin-end
              https://bugs.webkit.org/show_bug.cgi?id=41496
      
              * fast/css/margin-start-end-expected.txt:
              * fast/css/padding-start-end-expected.txt:
              * fast/css/script-tests/margin-start-end.js: Added tests for computed style.
              * fast/css/script-tests/padding-start-end.js: Added tests for computed style.
      2010-07-09  Erik Arvidsson  <arv@chromium.org>
      
              Reviewed by Darin Adler.
      
              Computed style is not implemented for padding-start, padding-end, margin-start, margin-end
              https://bugs.webkit.org/show_bug.cgi?id=41496
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/CSSProperty.cpp:
              (WebCore::CSSProperty::resolveDirectionAwareProperty): This function resolves the property ID for a direction aware property.
              * css/CSSProperty.h:
              * css/CSSStyleSelector.cpp: Use helper function.
              (WebCore::CSSStyleSelector::applyProperty):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26b6d1b9
    • abarth@webkit.org's avatar
      2010-07-09 Adam Barth <abarth@webkit.org> · 8aec81f3
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              HTML5 tree builder should pass some LayoutTests
              https://bugs.webkit.org/show_bug.cgi?id=41991
      
              Before this patch, we weren't attaching text nodes to the render tree,
              which turns out to be important.  :)
      
              This patch fixes more than 10,000 LayoutTests.
      
              * html/HTMLConstructionSite.cpp:
              (WebCore::HTMLConstructionSite::attach):
              (WebCore::HTMLConstructionSite::attachAtSite):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8aec81f3
    • commit-queue@webkit.org's avatar
      2010-07-09 Patrick Gansterer <paroga@paroga.com> · ae021f37
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              [WINCE] Buildfix for TextEncodingRegistry
              https://bugs.webkit.org/show_bug.cgi?id=41992
      
              Renamed TextCodecWince to TextCodecWinCE.
      
              * platform/text/TextEncodingRegistry.cpp:
              (WebCore::buildBaseTextCodecMaps):
              (WebCore::extendTextCodecMaps):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae021f37
    • commit-queue@webkit.org's avatar
      2010-07-09 Luiz Agostini <luiz.agostini@openbossa.org> · a0dd4842
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Mac build fix
              https://bugs.webkit.org/show_bug.cgi?id=41967
      
              Adding file PluginObjectMac.mm and frameworks Cocoa and QuartzCore.
      
              * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0dd4842
    • dbates@webkit.org's avatar
      2010-07-09 Daniel Bates <dbates@rim.com> · 6a76e9f5
      dbates@webkit.org authored
              Reviewed by Darin Adler.
      
              Clean up: Move dump-list.js utility script from LayoutTests/fast/lists
              to LayoutTests/fast/lists/resources
              https://bugs.webkit.org/show_bug.cgi?id=42016
      
              Move fast/lists/dump-list.js to fast/lists/resources since it
              is a utility script and not a test case.
      
              * fast/lists/dump-list.js: Removed. Moved to fast/lists/resources.
              * fast/lists/ol-nested-items-dynamic-insert.html: Modified to look
                for dump-list.js in new location.
              * fast/lists/ol-nested-items-dynamic-remove.html: Ditto.
              * fast/lists/ol-nested-items.html: Ditto.
              * fast/lists/ol-nested-list-dynamic-insert.html: Ditto.
              * fast/lists/ol-nested-list-dynamic-remove.html: Ditto.
              * fast/lists/ol-nested-list.html: Ditto.
              * fast/lists/resources/dump-list.js: Copied from LayoutTests/fast/lists/dump-list.js.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a76e9f5
    • diegohcg@webkit.org's avatar
      2010-07-09 Diego Gonzalez <diegohcg@webkit.org> · b88accad
      diegohcg@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [Qt] [WebKit2] Add navigation actions to MiniBrowser toolbar
              https://bugs.webkit.org/show_bug.cgi?id=41966
      
              * MiniBrowser/qt/BrowserWindow.cpp:
              (BrowserWindow::BrowserWindow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b88accad
    • commit-queue@webkit.org's avatar
      2010-07-09 Leon Clarke <leonclarke@google.com> · a67f42c4
      commit-queue@webkit.org authored
              Reviewed by Adam Barth.
      
              add support for link prefetching
              https://bugs.webkit.org/show_bug.cgi?id=3652
      
              * Configurations/FeatureDefines.xcconfig:
      2010-07-09  Leon Clarke  <leonclarke@google.com>
      
              Reviewed by Adam Barth.
      
              add support for link prefetching
              https://bugs.webkit.org/show_bug.cgi?id=3652
      
              * fast/dom/HTMLLinkElement/prefetch-expected.txt: Added.
              * fast/dom/HTMLLinkElement/prefetch.html: Added.
              * fast/dom/HTMLLinkElement/prefetch.link: Added.
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      2010-07-09  Leon Clarke  <leonclarke@google.com>
      
              Reviewed by Adam Barth.
      
              add support for link prefetching
              https://bugs.webkit.org/show_bug.cgi?id=3652
      
              Test: fast/dom/HTMLLinkElement/prefetch.html
      
              * Configurations/FeatureDefines.xcconfig:
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::tokenizeRelAttribute):
              (WebCore::HTMLLinkElement::process):
              * html/HTMLLinkElement.h:
              (WebCore::HTMLLinkElement::RelAttribute::RelAttribute):
              * loader/Cache.cpp:
              (WebCore::createResource):
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::data):
              (WebCore::CachedResource::didAddClient):
              * loader/CachedResource.h:
              (WebCore::CachedResource::):
              (WebCore::CachedResource::error):
              (WebCore::CachedResource::isPrefetch):
              (WebCore::CachedResource::schedule):
              * loader/CachedScript.cpp:
              * loader/CachedScript.h:
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::requestLinkPrefetch):
              (WebCore::DocLoader::canRequest):
              (WebCore::DocLoader::incrementRequestCount):
              (WebCore::DocLoader::decrementRequestCount):
              * loader/DocLoader.h:
              * loader/loader.cpp:
              (WebCore::cachedResourceTypeToTargetType):
              (WebCore::Loader::determinePriority):
              (WebCore::Loader::load):
              (WebCore::Loader::Host::servePendingRequests):
              (WebCore::Loader::Host::didFinishLoading):
              (WebCore::Loader::Host::didFail):
              (WebCore::Loader::Host::didReceiveResponse):
              (WebCore::Loader::Host::cancelPendingRequests):
              * loader/loader.h:
              (WebCore::Loader::):
              * platform/network/ResourceRequestBase.h:
              (WebCore::ResourceRequestBase::):
      2010-07-09  Leon Clarke  <leonclarke@google.com>
      
              Reviewed by Adam Barth.
      
              add support for link prefetching
              https://bugs.webkit.org/show_bug.cgi?id=3652
      
              * public/WebURLRequest.h:
              (WebKit::WebURLRequest::):
      2010-07-09  Leon Clarke  <leonclarke@google.com>
      
              Reviewed by Adam Barth.
      
              add support for link prefetching
              https://bugs.webkit.org/show_bug.cgi?id=3652
      
              * Configurations/FeatureDefines.xcconfig:
      2010-07-09  Leon Clarke  <leonclarke@google.com>
      
              Reviewed by Adam Barth.
      
              add support for link prefetching
              https://bugs.webkit.org/show_bug.cgi?id=3652
      
              * Configurations/FeatureDefines.xcconfig:
      2010-07-09  Leon Clarke  <leonclarke@google.com>
      
              Reviewed by Adam Barth.
      
              add support for link prefetching
              https://bugs.webkit.org/show_bug.cgi?id=3652
      
              * Scripts/build-webkit:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a67f42c4
    • jamesr@google.com's avatar
      2010-07-09 James Robinson <jamesr@chromium.org> · d911c43e
      jamesr@google.com authored
              Unreviewed build fix.  Add #include to pick up ExceptionCode values for config (like Qt) where it's not picked up indirectly.
      
              * html/HTMLCanvasElement.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d911c43e
    • jamesr@google.com's avatar
      2010-07-09 James Robinson <jamesr@chromium.org> · f0fc0049
      jamesr@google.com authored
              Reviewed by Darin Adler.
      
              Removes CanvasSurface and moves all of its functionality to HTMLCanvasElement.
              https://bugs.webkit.org/show_bug.cgi?id=42005
      
              http://trac.webkit.org/changeset/55201 introduced a new base class for HTMLCanvasElement called CanvasSurface.
              The intention was that this would allow for code sharing with the then-proposed OffscreenCanvas.  However,
              there is no OffscreenCanvas and there's unlikely to be one soon.  Additionally CanvasSurface breaks
              encapsulation pretty badly by doing "static_cast<HTMLCanvasElement* const>(this)".  Until an abstraction is
              really needed we should just use HTMLCanvasElement when we want to talk about a canvas.
      
              This patch moves all of CanvasSurface's functionality back up to HTMLCanvasElement and reorders the header
              to be a bit more logical.
      
              Refactor with no behavior change, thus no new tests.
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * dom/CanvasSurface.cpp: Removed.
              * dom/CanvasSurface.h: Removed.
              * html/HTMLCanvasElement.cpp:
              (WebCore::HTMLCanvasElement::HTMLCanvasElement):
              (WebCore::HTMLCanvasElement::willDraw):
              (WebCore::HTMLCanvasElement::setSurfaceSize):
              (WebCore::HTMLCanvasElement::toDataURL):
              (WebCore::HTMLCanvasElement::convertLogicalToDevice):
              (WebCore::HTMLCanvasElement::securityOrigin):
              (WebCore::HTMLCanvasElement::styleSelector):
              (WebCore::HTMLCanvasElement::createImageBuffer):
              (WebCore::HTMLCanvasElement::drawingContext):
              (WebCore::HTMLCanvasElement::buffer):
              (WebCore::HTMLCanvasElement::baseTransform):
              * html/HTMLCanvasElement.h:
              (WebCore::HTMLCanvasElement::setObserver):
              (WebCore::HTMLCanvasElement::width):
              (WebCore::HTMLCanvasElement::height):
              (WebCore::HTMLCanvasElement::size):
              (WebCore::HTMLCanvasElement::toDataURL):
              (WebCore::HTMLCanvasElement::setOriginTainted):
              (WebCore::HTMLCanvasElement::originClean):
              (WebCore::HTMLCanvasElement::hasCreatedImageBuffer):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0fc0049
    • oliver@apple.com's avatar
      Tidy up lexer token ids · 2cb5aac7
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=42014
      
      Reviewed by Darin Adler
      
      Stop using character literals to identify single character tokens
      and instead use symbolic names for all tokens.
      
      * parser/ASTBuilder.h:
      (JSC::ASTBuilder::makeBinaryNode):
      * parser/JSParser.cpp:
      (JSC::JSParser::consume):
      (JSC::JSParser::match):
      (JSC::JSParser::autoSemiColon):
      (JSC::JSParser::JSParser):
      (JSC::JSParser::parseProgram):
      (JSC::JSParser::allowAutomaticSemicolon):
      (JSC::JSParser::parseDoWhileStatement):
      (JSC::JSParser::parseWhileStatement):
      (JSC::JSParser::parseVarDeclarationList):
      (JSC::JSParser::parseConstDeclarationList):
      (JSC::JSParser::parseForStatement):
      (JSC::JSParser::parseReturnStatement):
      (JSC::JSParser::parseWithStatement):
      (JSC::JSParser::parseSwitchStatement):
      (JSC::JSParser::parseSwitchClauses):
      (JSC::JSParser::parseSwitchDefaultClause):
      (JSC::JSParser::parseTryStatement):
      (JSC::JSParser::parseDebuggerStatement):
      (JSC::JSParser::parseStatement):
      (JSC::JSParser::parseFormalParameters):
      (JSC::JSParser::parseFunctionInfo):
      (JSC::JSParser::parseExpressionOrLabelStatement):
      (JSC::JSParser::parseIfStatement):
      (JSC::JSParser::parseExpression):
      (JSC::JSParser::parseAssignmentExpression):
      (JSC::JSParser::parseConditionalExpression):
      (JSC::isUnaryOp):
      (JSC::JSParser::isBinaryOperator):
      (JSC::JSParser::parseBinaryExpression):
      (JSC::JSParser::parseProperty):
      (JSC::JSParser::parseObjectLiteral):
      (JSC::JSParser::parseStrictObjectLiteral):
      (JSC::JSParser::parseArrayLiteral):
      (JSC::JSParser::parsePrimaryExpression):
      (JSC::JSParser::parseArguments):
      (JSC::JSParser::parseMemberExpression):
      (JSC::JSParser::parseUnaryExpression):
      * parser/JSParser.h:
      (JSC::):
      * parser/Lexer.cpp:
      (JSC::):
      (JSC::Lexer::lex):
      * parser/Lexer.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2cb5aac7