1. 28 May, 2013 31 commits
    • barraclough@apple.com's avatar
      String(new Date(2010,10,1)) is wrong in KRAT, YAKT · d4900677
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=106750
      
      Reviewed by Darin Adler.
      
      First part of a fix, simplfy date handling code, instead of operating separately
      on the UTC-standard and standard-DST offsets, just generate a combined UTC-local
      offset (this is what we actually need, and what the OS gives us).
      
      ../JavaScriptCore: 
      
      * runtime/JSDateMath.cpp:
      (JSC::getLocalTimeOffset):
          - removed getUTCOffset, converted getDSTOffset -> getLocalTimeOffset
      (JSC::gregorianDateTimeToMS):
      (JSC::msToGregorianDateTime):
      (JSC::parseDateFromNullTerminatedCharacters):
          - call getLocalTimeOffset instead of getUTCOffset/getDSTOffset
      * runtime/VM.cpp:
      (JSC::VM::resetDateCache):
          - removed cachedUTCOffset, converted DSTOffsetCache -> LocalTimeOffsetCache
      * runtime/VM.h:
      (JSC::LocalTimeOffsetCache::LocalTimeOffsetCache):
      (JSC::LocalTimeOffsetCache::reset):
      (LocalTimeOffsetCache):
          - removed cachedUTCOffset, converted DSTOffsetCache -> LocalTimeOffsetCache
      
      ../WTF: 
      
      * wtf/DateMath.cpp:
      (WTF::calculateUTCOffset):
      (WTF::calculateDSTOffset):
          - made static, now not called from outside of this file.
      (WTF::calculateLocalTimeOffset):
          - This combines the 2038 related adjustment from calculateDSTOffset with the
            maxUnixTime adjustment from calculateDSTOffsetSimple. Then, if HAVE(TM_GMTOFF)
            just call getLocalTime, if not use calculateUTCOffset/calculateDSTOffset.
      (WTF::parseDateFromNullTerminatedCharacters):
          - call calculateLocalTimeOffset instead of calculateUTCOffset/calculateDSTOffset
      * wtf/DateMath.h:
      (WTF::LocalTimeOffset::LocalTimeOffset):
      (LocalTimeOffset):
      (WTF::LocalTimeOffset::operator==):
          - new struct type, a tuple of UTC-local offset & isDST flag.
          - replaced calculateUTCOffset/calculateDSTOffset with calculateLocalTimeOffset
      * wtf/GregorianDateTime.cpp:
      (WTF::GregorianDateTime::setToCurrentLocalTime):
          - call calculateLocalTimeOffset instead of calculateUTCOffset/calculateDSTOffset
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150833 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4900677
    • mhahnenberg@apple.com's avatar
      r150199 is very wrong · 239349ed
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116876
      
      JSValue needs to protect its internal JSValueRef.
      
      Reviewed by Darin Adler.
      
      * API/JSValue.mm:
      (-[JSValue initWithValue:inContext:]):
      (-[JSValue dealloc]):
      * API/tests/testapi.mm: Added a simple test to make sure that we protect the
      underlying JavaScript value across garbage collections.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      239349ed
    • bfulgham@apple.com's avatar
      [Windows] Silence a few failures to get bot green. · 7ee9096a
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116564
      
      * platform/win/TestExpectations: Disable some tests.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150830 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ee9096a
    • jer.noble@apple.com's avatar
      Crash in DumpRenderTree at com.apple.WebCore:... · 511a6fa4
      jer.noble@apple.com authored
      Crash in DumpRenderTree at com.apple.WebCore: WebCore::RenderTextTrackCue::repositionGenericCue + 154
      https://bugs.webkit.org/show_bug.cgi?id=116882
      
      Reviewed by Eric Carlson.
      
      Remove an inappropriate assert. No cues coming through repositionGenericCue will be WebVTT ones.
      
      * rendering/RenderTextTrackCue.cpp:
      (WebCore::RenderTextTrackCue::repositionGenericCue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      511a6fa4
    • robert@webkit.org's avatar
      Fix line endings in test added in r150602 · ba96b494
      robert@webkit.org authored
      Unreviewed.
      
      * fast/css/text-overflow-ellipsis-behind-floats.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba96b494
    • commit-queue@webkit.org's avatar
      [BlackBerry] GraphicsContext: add missing definitions. · 59fc67ef
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115515
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-28
      Reviewed by Rob Buis.
      
      * platform/graphics/GraphicsContext.h:
      (Graphics):
      Add definition for PlatformGraphicsContext.
      * platform/graphics/blackberry/GraphicsContextBlackBerry.cpp:
      Include RoundedRect.h
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59fc67ef
    • anilsson@rim.com's avatar
      [BlackBerry] Fix style issues in BlackBerry accelerated compositing backend · ad805ed2
      anilsson@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116604
      
      Reviewed by Carlos Garcia Campos.
      
      Source/WebCore:
      
      PR 273550, 99638
      
      Remove the "get" prefix from getters in the WebKit- and compositing-
      thread layer classes, as well as LayerRendererSurface. Clarify which
      geometry-related getters return normalized device coordinates by adding
      a comment.
      
      Also remove dead code related to LayerData::m_holePunchClipRect, which
      was part of an eventually disabled fix for video clipping in iframes,
      PR 99638. Since we now use AC layers for iframes, the bug is no longer
      reproducible, and the dead code will never need to be enabled again.
      
      No change in behavior, no new tests.
      
      * platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:
      (WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
      * platform/graphics/blackberry/LayerCompositingThread.cpp:
      (WebCore::LayerCompositingThread::setDrawTransform):
      (WebCore::LayerCompositingThread::transformedHolePunchRect):
      (WebCore::LayerCompositingThread::drawTextures):
      (WebCore::LayerCompositingThread::drawSurface):
      * platform/graphics/blackberry/LayerCompositingThread.h:
      (WebCore::LayerCompositingThread::sublayers): Removed "get" prefix
      (LayerCompositingThread):
      (WebCore::LayerCompositingThread::boundingBox): Renamed from "getDrawRect"
      (WebCore::LayerCompositingThread::transformedBounds): Removed "get" prefix
      (WebCore::LayerCompositingThread::transformedHolePunchRect): Removed "get" prefix
      * platform/graphics/blackberry/LayerData.h:
      (LayerData): Removed unused data member "m_holePunchClipRect"
      * platform/graphics/blackberry/LayerFilterRenderer.cpp:
      (WebCore::LayerFilterRenderer::applyActions):
      * platform/graphics/blackberry/LayerRenderer.cpp:
      (WebCore::LayerRenderer::compositeLayers):
      (WebCore::LayerRenderer::drawDebugBorder):
      (WebCore::LayerRenderer::drawHolePunchRect):
      (WebCore::LayerRenderer::prepareFrameRecursive):
      (WebCore::LayerRenderer::updateLayersRecursive):
      (WebCore::collect3DPreservingLayers):
      (WebCore::LayerRenderer::compositeLayersRecursive):
      * platform/graphics/blackberry/LayerRendererSurface.cpp:
      (WebCore::LayerRendererSurface::boundingBox):
      * platform/graphics/blackberry/LayerRendererSurface.h:
      (WebCore::LayerRendererSurface::boundingBox): Renamed from "drawRect" because that sounds like a verb, and this is a getter
      * platform/graphics/blackberry/LayerWebKitThread.h:
      (WebCore::LayerWebKitThread::sublayers): Removed "get" prefix
      * platform/graphics/blackberry/VideoLayerWebKitThread.cpp:
      (WebCore::VideoLayerWebKitThread::setHolePunchRect):
      (WebCore::VideoLayerWebKitThread::boundsChanged):
      
      Source/WebKit/blackberry:
      
      Adapt to the removal of "get" prefix from getters in the WebKit- and
      compositing-thread layer classes.
      
      * Api/WebOverlay.cpp:
      (BlackBerry::WebKit::WebOverlayPrivateCompositingThread::pixelViewportRect):
      * Api/WebPageCompositor.cpp:
      (BlackBerry::WebKit::WebPageCompositorPrivate::attachOverlays):
      (BlackBerry::WebKit::WebPageCompositorPrivate::removeOverlay):
      (BlackBerry::WebKit::WebPageCompositorPrivate::findFixedElementRect):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad805ed2
    • jer.noble@apple.com's avatar
      Made AudioNode an EventTarget · 79da806f
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116871
      
      Source/WebCore:
      
      Merge: https://chromium.googlesource.com/chromium/blink/+/ef37484162ddb95d677dcfdcdd778ec60590928b
      
      Reviewed by Darin Adler.
      
      Tests: webaudio/audionode-expected.txt:
             webaudio/audionode.html:
      
      Add the requisite boilerplate to allow AudioNode to become an EventTarget. Remove
      all that same boilerplate from ScriptProcessorNode now that it's base class
      is an EventTarget.
      
      * Modules/webaudio/AudioNode.cpp:
      (WebCore::AudioNode::interfaceName): Added boilerplate.
      (WebCore::AudioNode::scriptExecutionContext): Return the AudioContext's context.
      (WebCore::AudioNode::processIfNecessary): Whitespace.
      * Modules/webaudio/AudioNode.h:
      * Modules/webaudio/AudioNode.idl: Make AudioNode an EventTarget.
      * Modules/webaudio/ScriptProcessorNode.cpp: Remove EventTarget boilerplate.
      * Modules/webaudio/ScriptProcessorNode.h: Ditto.
      * Modules/webaudio/ScriptProcessorNode.idl: Ditto.
      * dom/EventTarget.h: Mark AudioNode as an EventTarget.
      * dom/EventTargetFactory.in: Ditto.
      
      LayoutTests:
      
      Reviewed by Darin Adler.
      
      * webaudio/audionode-expected.txt:
      * webaudio/audionode.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79da806f
    • anilsson@rim.com's avatar
      [BlackBerry] backface-visibility: hidden doesn't work properly with masks and filters · dea46093
      anilsson@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116616
      
      Reviewed by Carlos Garcia Campos.
      
      The BlackBerry::Platform::Graphics::GraphicsContext generates geometry
      with a different winding order than the accelerated compositing backend
      of the BlackBerry port. So, when we switched from Skia to this new
      rendering engine, we switched from glFrontFace(GL_CCW) to
      glFrontFace(GL_CW), and all was well when drawing display lists.
      However, we forgot to update the winding order of geometry generated
      within the accelerated compositing backend, which is used for masks and
      filters, so they were getting erroneously culled out when
      backface-visibility: hidden was applied to them. Fixed by switching the
      winding order of all geometry generated up here, which has the added
      benefit of enabling us to use TransformationMatrix::mapQuad instead of
      transforming point-by-point.
      
      To further complicate matters, a right-side up transform is used when
      drawing layers into surfaces, reversing the winding order and requiring
      us to switch back to glFrontFace(GL_CCW) temporarily, when drawing
      layers to surfaces, or the layers will get culled out inside the
      surface.
      
      Also fix spelling error, "drawed" should be "drawn".
      
      No new tests, this is only detectable by pixel tests, which the
      BlackBerry port currently doesn't support.
      
      PR 341945.
      
      * platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:
      (WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
      * platform/graphics/blackberry/LayerCompositingThread.cpp:
      (WebCore::LayerCompositingThread::setDrawTransform):
      (WebCore::getTransformedRect):
      (WebCore::LayerCompositingThread::drawTextures):
      (WebCore::LayerCompositingThread::drawSurface):
      * platform/graphics/blackberry/LayerCompositingThread.h:
      (LayerCompositingThread):
      (WebCore::LayerCompositingThread::origin):
      * platform/graphics/blackberry/LayerFilterRenderer.cpp:
      (WebCore):
      * platform/graphics/blackberry/LayerRenderer.cpp:
      (WebCore::LayerRenderer::compositeLayers):
      (WebCore):
      (WebCore::LayerRenderer::drawLayersOnSurfaces):
      * platform/graphics/blackberry/LayerRendererSurface.cpp:
      (WebCore::LayerRendererSurface::drawRect):
      (WebCore::LayerRendererSurface::transformedBounds):
      * platform/graphics/blackberry/LayerRendererSurface.h:
      (WebCore::LayerRendererSurface::origin):
      (LayerRendererSurface):
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
      (WebCore):
      (WebCore::loadBufferingImageData):
      (WebCore::MediaPlayerPrivate::drawBufferingAnimation):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dea46093
    • lauro.neto@openbossa.org's avatar
      [GTK] Connection issues in repeated WebProcess crash/reloads. · f2e17ea5
      lauro.neto@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115880
      
      Reviewed by Anders Carlsson.
      
      When stressing the WebProcess creation/destruction, WebKitGTK can
      often run into socket issues like bad file descriptor errors or
      polling a socket indefinitely.
      
      Currently WebKitGTK has three places where a socket can be
      closed.
      
      - childFinishedFunction (in ProcessLauncherGtk.cpp)
      - Connection::platformInvalidate (in ConnectionUnix.cpp)
      - WorkQueue EventSource destruction (in WorkQueueGtk.cpp)
      
      To avoid these race conditions, socket closing will be handled
      by the event source callback in WorkQueueGtk.cpp.
      
      * Platform/CoreIPC/unix/ConnectionUnix.cpp:
      (CoreIPC::Connection::platformInvalidate): Do not close the socket
      when the connection is invalidated, the socket event source is
      unregistered in this method and the socket is closed when the
      GSocket associated to the event source is destroyed.
      * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
      (WebKit::ProcessLauncher::launchProcess): Do not monitor child
      process to close the connection on termination. This was needed in
      the past when we used DGRAM sockets, we currently use always
      connection oriented sockets, so that when the other end closes
      the connection we are notified and the connection is invalidated.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2e17ea5
    • mrobinson@webkit.org's avatar
      Fix GTK+ CMake build · 0ce322fb
      mrobinson@webkit.org authored
      Source/WebKit2:
      
      * PlatformGTK.cmake: After r150336, the name of the WebKit2
      library target is simply "WebKit2."
      
      Tools:
      
      * MiniBrowser/gtk/CMakeLists.txt: After r150336, the name of the WebKit2
      library target is simply "WebKit2."
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ce322fb
    • akling@apple.com's avatar
      Move Node::dispatchChangeEvent() to HTMLFormControlElement. · 39f58f5c
      akling@apple.com authored
      <http://webkit.org/b/116866>
      
      Reviewed by Anders Carlsson.
      
      ...and devirtualize it, since it had no overrides.
      
      * dom/Node.h:
      * dom/Node.cpp:
      * html/HTMLFormControlElement.h:
      * html/HTMLFormControlElement.cpp:
      (WebCore::HTMLFormControlElement::dispatchChangeEvent):
      (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
      * html/FileInputType.cpp:
      (WebCore::FileInputType::setFiles):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      39f58f5c
    • sergio@webkit.org's avatar
      Refactoring CSS grammar · 3537f50c
      sergio@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116679
      
      Reviewed by Andreas Kling.
      
      From Blink r149948 by <serya@chromium.org>
      
      Added "closing_parenthesis:" and "error_recovery:" to avoid code
      duplication in a couple of error recovery rules. Some other rules
      were also refactored which allows to reduce the the number of
      shift/reduce conflicts by 2.
      
      No new tests required as this is just a refactoring, no new
      functionality added.
      
      * css/CSSGrammar.y.in:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3537f50c
    • sergio@webkit.org's avatar
      Invalid block doesn't make declaration invalid · 5a36aff0
      sergio@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=115709
      
      Reviewed by Andreas Kling.
      
      From Blink r149446 by <serya@chromium.org>
      
      Source/WebCore:
      
      Added a new rule "declaration_recovery:" which covers any kind of
      "invalid_block_list maybe_space" sequence. By appending this new
      rule to every rule reductable to "declaration:" we can remove some
      redundant rules and improve error recovery of some others that
      were only accepting exactly one error.
      
      One of the rules being removed was preventing invalid blocks in a
      declaration to invalidate the whole declaration. The rule was
      reporting the syntax error but at the same time accepting the
      invalid block as part of a valid declaration.
      
      * css/CSSGrammar.y.in:
      
      LayoutTests:
      
      * fast/css/parsing-error-recovery.html: Added 2 new test cases.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a36aff0
    • marcelo.lira@openbossa.org's avatar
      [WK2][CoordinatedGraphics] DrawingArea's visible content area must be updated... · f71ef685
      marcelo.lira@openbossa.org authored
      [WK2][CoordinatedGraphics] DrawingArea's visible content area must be updated when contents size changes
      https://bugs.webkit.org/show_bug.cgi?id=116845
      
      Reviewed by Noam Rosenthal.
      
      * UIProcess/CoordinatedGraphics/WebView.cpp:
      (WebKit::WebView::didChangeContentsSize):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f71ef685
    • akling@apple.com's avatar
      Move dispatching of focus-related events from Node to Element. · ea93f029
      akling@apple.com authored
      <http://webkit.org/b/116864>
      
      Reviewed by Antti Koivisto.
      
      ...and pass around pointers to Element instead of Node.
      
      * dom/Node.cpp:
      * dom/Node.h:
      * dom/Element.h:
      * dom/Element.cpp:
      (WebCore::Element::dispatchFocusInEvent):
      (WebCore::Element::dispatchFocusOutEvent):
      (WebCore::Element::dispatchFocusEvent):
      (WebCore::Element::dispatchBlurEvent):
      
          Moved here from Node.
      
      * html/HTMLFormControlElement.h:
      * html/HTMLFormControlElement.cpp:
      (WebCore::HTMLFormControlElement::dispatchBlurEvent):
      * html/HTMLSelectElement.h:
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::dispatchFocusEvent):
      (WebCore::HTMLSelectElement::dispatchBlurEvent):
      * html/HTMLTextFormControlElement.h:
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
      (WebCore::HTMLTextFormControlElement::dispatchBlurEvent):
      
          Update subclass overrides and sprinkle OVERRIDE/FINAL.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea93f029
    • zandobersek@gmail.com's avatar
      [webkitpy] Explicitly specify the reference file extensions · 5d9b9e3a
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116333
      
      Reviewed by Benjamin Poulain.
      
      Explicitly specify the extensions that are valid for the reference files. This helps to differentiate
      between valid reference files required by reftests and text baselines that have the same extension as
      potential test files (specifically the current MHTML tests in the .mht files and the future .mht baselines
      that were until this change recognized as reference files).
      
      Covered by existing tests and the new test_is_reference_html_file test in webkitpy.port.base_unittest.
      
      * Scripts/webkitpy/port/base.py:
      (Port.reference_files): Iterate through the _supported_reference_extensions set.
      (Port): Rename the _supported_file_extensions set to _supported_test_extensions. Add the
      _supported_reference_extensions set, containing the extensions allowed for reference files.
      (Port.is_reference_html_file): Return False if the file's extension is not a supported reference file extension.
      (Port._has_supported_extension): Use _supported_test_extensions.
      * Scripts/webkitpy/port/base_unittest.py:
      (PortTest.test_is_reference_html_file): Add the unit test, testing various test cases around the
      Port.is_reference_html_file method.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d9b9e3a
    • zandobersek@gmail.com's avatar
      Remove CachedResourceRequest::initiatorElement · 6200d000
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116862
      
      Reviewed by Andreas Kling.
      
      The CachedResourceRequest::initiatorElement method is not used anywhere and should be removed.
      
      * loader/cache/CachedResourceRequest.cpp: Remove the initiatorElement method definition.
      * loader/cache/CachedResourceRequest.h:
      (CachedResourceRequest): Remove the initiatorElement method declaration.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6200d000
    • commit-queue@webkit.org's avatar
      [Qt] REGRESSION(r149292): broke scrolling in Qt WK2 desktop mode · 541b4237
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116597
      
      ScrollingCoordinatorCoordinatedGraphics is tailored specifically for
      fixedLayout mode. When fixedLayout is not set, it should be turned off.
      
      Patch by Noam Rosenthal <noam@webkit.org> on 2013-05-28
      Reviewed by Allan Sandfeld Jensen.
      
      * WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
      (WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      541b4237
    • kadam@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Unskip now passing tests. · f6bc0f1a
      kadam@inf.u-szeged.hu authored
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6bc0f1a
    • akling@apple.com's avatar
      Document::setFocusedNode() should be setFocusedElement(). · 2d7fedc2
      akling@apple.com authored
      <http://webkit.org/b/116857>
      
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      Only Elements can be focused, so tighten Document's idea of what's focused.
      
      Most of this patch is just updating call sites for the new names and removing
      now-unnecessary isElementNode() checks and casts.
      
      * WebCore.exp.in:
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::focusedUIElementForPage):
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::canSetFocusAttribute):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::isFocused):
      (WebCore::AccessibilityRenderObject::setFocused):
      (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
      * bindings/objc/DOM.mm:
      (-[DOMElement isFocused]):
      * dom/Document.cpp:
      (WebCore::Document::dispose):
      (WebCore::Document::detach):
      (WebCore::Document::focusedNodeRemoved):
      (WebCore::Document::removeFocusedNodeOfSubtree):
      (WebCore::Document::setFocusedElement):
      (WebCore::Document::updateFocusAppearanceTimerFired):
      (WebCore::eventTargetNodeForDocument):
      * dom/Document.h:
      (Document):
      (WebCore::Document::focusedElement):
      * dom/Element.cpp:
      (WebCore::Element::attach):
      (WebCore::Element::focus):
      (WebCore::Element::blur):
      (WebCore::Element::cancelFocusAppearanceUpdate):
      * dom/Node.cpp:
      (WebCore::Node::rendererIsEditable):
      * dom/TreeScope.cpp:
      (WebCore::TreeScope::focusedElement):
      * dom/UserTypingGestureIndicator.cpp:
      (WebCore::UserTypingGestureIndicator::UserTypingGestureIndicator):
      * editing/Editor.cpp:
      (WebCore::Editor::setBaseWritingDirection):
      (WebCore::Editor::setComposition):
      (WebCore::Editor::guessesForMisspelledOrUngrammatical):
      * editing/EditorCommand.cpp:
      (WebCore::verticalScrollDistance):
      * editing/FrameSelection.cpp:
      (WebCore::FrameSelection::selectAll):
      (WebCore::FrameSelection::focusedOrActiveStateChanged):
      (WebCore::FrameSelection::setFocusedElementIfNeeded):
      (WebCore::FrameSelection::currentForm):
      * history/CachedPage.cpp:
      (WebCore::CachedPage::restore):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::updateType):
      (WebCore::HTMLInputElement::attach):
      * html/HTMLTextAreaElement.cpp:
      (WebCore::HTMLTextAreaElement::setValueCommon):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
      (WebCore::HTMLTextFormControlElement::selectionStart):
      (WebCore::HTMLTextFormControlElement::selectionEnd):
      (WebCore::HTMLTextFormControlElement::selectionDirection):
      * html/RadioInputType.cpp:
      (WebCore::RadioInputType::handleKeydownEvent):
      (WebCore::RadioInputType::isKeyboardFocusable):
      * html/shadow/DateTimeEditElement.cpp:
      (WebCore::DateTimeEditElement::focusedFieldIndex):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::stopLoading):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::focus):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::scrollOverflow):
      (WebCore::EventHandler::logicalScrollOverflow):
      (WebCore::EventHandler::dispatchMouseEvent):
      (WebCore::EventHandler::sendContextMenuEventForKey):
      (WebCore::EventHandler::capsLockStateMayHaveChanged):
      * page/FocusController.cpp:
      (WebCore::dispatchEventsOnWindowAndFocusedNode):
      (WebCore::FocusController::advanceFocusInDocumentOrder):
      (WebCore::FocusController::setFocusedElement):
      (WebCore::FocusController::findFocusCandidateInContainer):
      (WebCore::FocusController::advanceFocusDirectionallyInContainer):
      (WebCore::FocusController::advanceFocusDirectionally):
      * page/FrameView.cpp:
      (WebCore::FrameView::scrollToAnchor):
      * plugins/PluginView.cpp:
      (WebCore::PluginView::focusPluginElement):
      * plugins/efl/PluginViewEfl.cpp:
      (WebCore::PluginView::setFocus):
      * plugins/mac/PluginViewMac.mm:
      (WebCore::PluginView::platformStart):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::paintAreaElementFocusRing):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::paintItemForeground):
      (WebCore::RenderListBox::paintItemBackground):
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::capsLockStateMayHaveChanged):
      (WebCore::RenderTextControlSingleLine::textShouldBeTruncated):
      * rendering/RenderTheme.cpp:
      (WebCore::RenderTheme::isFocused):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::focusNodeRect):
      (BlackBerry::WebKit::WebPagePrivate::contextNode):
      (BlackBerry::WebKit::WebPagePrivate::clearFocusNode):
      (BlackBerry::WebKit::WebPage::setNodeFocus):
      * WebCoreSupport/EditorClientBlackBerry.cpp:
      (WebCore::EditorClientBlackBerry::shouldSpellCheckFocusedField):
      (WebCore::EditorClientBlackBerry::shouldChangeSelectedRange):
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::focusedNodeChanged):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::setCaretPosition):
      (BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
      (BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
      (BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
      (BlackBerry::WebKit::SelectionHandler::inputNodeOverridesTouch):
      (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
      
      Source/WebKit/efl:
      
      * ewk/ewk_frame.cpp:
      (ewk_frame_focused_element_geometry_get):
      * ewk/ewk_view.cpp:
      (ewk_view_input_method_state_set):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebview.cpp:
      (getFocusedNode):
      
      Source/WebKit/mac:
      
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView clearFocus]):
      (-[WebHTMLView becomeFirstResponder]):
      
      Source/WebKit/qt:
      
      * Api/qwebelement.cpp:
      (QWebElement::hasFocus):
      (QWebElement::setFocus):
      * WebCoreSupport/EditorClientQt.cpp:
      (WebCore::EditorClientQt::setInputMethodState):
      * WebCoreSupport/QWebPageAdapter.cpp:
      (QWebPageAdapter::mousePressEvent):
      (QWebPageAdapter::handleSoftwareInputPanel):
      (QWebPageAdapter::inputMethodQuery):
      (QWebPageAdapter::hasFocusedNode):
      
      Source/WebKit/win:
      
      * DOMCoreClasses.cpp:
      (DOMElement::isFocused):
      * WebView.cpp:
      (WebView::setInitialFocus):
      
      Source/WebKit2:
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::PluginView::focusPluginElement):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::focusedPluginViewForFrame):
      (WebKit::WebPage::setInitialFocus):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d7fedc2
    • carlosgc@webkit.org's avatar
      Unreviewed. Fix BlackBerry debug build after r150756. · 6b2e4223
      carlosgc@webkit.org authored
      * WebKitSupport/PagePopup.cpp:
      (BlackBerry::WebKit::PagePopup::writeDocument): Fix typo in
      assert.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b2e4223
    • ossy@webkit.org's avatar
      Unskip now passing tests. · accb12ff
      ossy@webkit.org authored
      * platform/qt-arm/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      accb12ff
    • kadam@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Skip failing tests after parallel gc is enabled. · a17070cc
      kadam@inf.u-szeged.hu authored
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a17070cc
    • gyuyoung.kim@samsung.com's avatar
      [EFL][WK2] Clean up duplicated include files. · d00491b2
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116851
      
      Reviewed by Christophe Dumez.
      
      Remove some of duplicated include file in ewk files.
      
      * UIProcess/API/efl/EwkView.h:
      * UIProcess/API/efl/ewk_color_picker.cpp:
      * UIProcess/API/efl/ewk_context_menu.cpp:
      * UIProcess/API/efl/ewk_security_origin_private.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d00491b2
    • sergio@webkit.org's avatar
      Web Inspector: Enable CSS logging · 4d25b460
      sergio@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113401
      
      Reviewed by Benjamin Poulain.
      
      From Blink r149265 by <serya@chromium.org>
      
      Source/WebCore:
      
      CSS logging was disabled in r147028 to prevent message overflow in
      the inspector console. This change restores it by modifying the
      CSS grammar in order to reduce as much consecutive errors as
      possible in 'declaration_list' and 'decl_list' rules.
      
      This way, for rules like 'x { color: ### }' only the first '#'
      will be reported as error (instead of 3 identical errors).
      
      The rule 'declaration' still produces multiple errors, because it
      does not eat as much errors as possible. So in order not to create
      a complex risky patch we just disable logging in the parser for
      that rule.
      
      * css/CSSGrammar.y.in:
      * css/CSSParser.cpp:
      (WebCore::CSSParser::CSSParser):
      (WebCore::CSSParser::parseSheet):
      (WebCore::CSSParser::syntaxError):
      (WebCore::CSSParser::isLoggingErrors):
      (WebCore::CSSParser::rewriteSpecifiers):
      * css/CSSParser.h:
      (CSSParser):
      
      LayoutTests:
      
      Unskipped console-css-warnings.html now that it's working.
      
      * TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d25b460
    • ryuan.choi@samsung.com's avatar
      [EFL] pc files should have harfbuzz dependency. · f3e51a11
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116852
      
      Reviewed by Gyuyoung Kim.
      
      Source/WebKit/efl:
      
      * ewebkit.pc.in: Added harfbuzz as Required package.
      
      Source/WebKit2:
      
      * efl/ewebkit2.pc.in: Added harfbuzz as Required package.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3e51a11
    • paroga@webkit.org's avatar
      Build fix for WinCE after r150730. · f385a8a5
      paroga@webkit.org authored
      * platform/graphics/FontFallbackList.cpp:
      (WebCore::FontGlyphs::glyphDataAndPageForCharacter):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f385a8a5
    • paroga@webkit.org's avatar
      Build fix for WinCE after r150772. · 4b8271de
      paroga@webkit.org authored
      * platform/win/ClipboardWin.cpp:
      (WebCore):
      * platform/win/PasteboardWin.cpp:
      (WebCore::Pasteboard::readFilenames):
      (WebCore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b8271de
    • gyuyoung.kim@samsung.com's avatar
      [EFL][WK2] Remove unneeded WebCore namespace use in ewk · 2e7ba92a
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116707
      
      Reviewed by Christophe Dumez.
      
      * UIProcess/API/efl/ewk_security_origin.cpp: Remove "using namespace WebCore".
      * UIProcess/API/efl/ewk_text_checker.cpp: ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e7ba92a
    • paroga@webkit.org's avatar
      Use correct stack size on Solaris and OpenBSD · ccb581ad
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114978
      
      Recommit after wrong rollout in r150621.
      
      * wtf/StackBounds.cpp:
      (WTF):
      (WTF::StackBounds::initialize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccb581ad
  2. 27 May, 2013 9 commits
    • jonlee@apple.com's avatar
      [WK2] Notifications clobber each other with multiple processes · 15f7784b
      jonlee@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116428
      <rdar://problem/13935191>
      
      Reviewed by Darin Adler.
      
      .:
      
      * ManualTests/notification-in-multiple-windows.html: Added.
      
      Source/WebKit2:
      
      With multiple processes, the notification IDs, when passed up to the UI process, can clobber
      each other. To fix this, we need to maintain a global map of notification IDs. This map is
      keyed by its own unique notification ID, and maps to a pair containing the web page ID and that
      web page's ID for the notification.
      
      Now that we maintain groups of notifications based on the web page, we no longer send IPC messages
      from WebNotificationManager to WebNotificationManagerProxy; instead we send messages to the
      WebPageProxy. This removes the need for WebNotificationManagerProxy to be a message receiver.
      
      When a page closes, all of the web notifications are cleared out. However, by the time the
      WebPage::close() is called, the connection between WebPage and WebPageProxy is destroyed. Since
      the WebPage is told to close from the UI process anyway, we clear out the notifications separately,
      instead of waiting for a message from the WebPage.
      
      * UIProcess/Notifications/WebNotificationManagerProxy.h: Update to take into account the
      notification's web page. Remove inheritance of CoreIPC::MessageReceiver. Expose the original message
      handlers as public functions, since they will be called from WebPageProxy. Add a new map that
      associates a global ID with a notification ID that came from a web page.
          There are now two flavors of clearNotifications(). One clears out all notifications associated
      with a web page. This is called when the page is closed. The other clears out a subset of
      notifications associated with a web page. This is called when notifications associated with a sub-frame
      is closed.
      * UIProcess/Notifications/WebNotificationManagerProxy.messages.in: Removed. All messages from
      the web process go to WebPageProxy now.
      
      * UIProcess/Notifications/WebNotificationManagerProxy.cpp: Update to take into account the
      notification's web page.
      
      (WebKit::generateGlobalNotificationID): The manager proxy now maintains its own global notification
      ID generator.
      (WebKit::WebNotificationManagerProxy::WebNotificationManagerProxy): The proxy is no longer a
      message receiver. Remove code that registers it as such.
      
      (WebKit::WebNotificationManagerProxy::show): Refactor to differentiate between the notification ID
      that came from the web process, and the global notification ID the proxy maintains. Add the mapping
      from the global ID to the (web page ID, notification ID) pair.
      (WebKit::WebNotificationManagerProxy::cancel): Refactor to take into consideration the web page.
      (WebKit::WebNotificationManagerProxy::didDestroyNotification): Refactor to take into consideration
      the web page. Fixes a leak where we did not remove the item from the maps. This function is called
      from the web process, when the ScriptExecutionContext is destroyed, so we remove it from our maps
      before we pass the message along to the provider.
      
      Helper functions that evaluate when a given notification in the map matches the desired parameters.
      (WebKit::pageIDsMatch): The notification is associated with the provided page.
      (WebKit::pageAndNotificationIDsMatch): The notification is associated with the provided page and is
      contained within the list of provided notifications.
      
      (WebKit::WebNotificationManagerProxy::clearNotifications): Changed to only remove notifications
      associated with the provided web page, and could include a specific list of notifications. This latter
      situation occurs if notifications were associated with an iframe, and that iframe was removed.
      There is an O(n) walk that could be make more efficient using another hash map, but that's overhead
      for a map that should be small in size anyway.
      
      (WebKit::WebNotificationManagerProxy::providerDidShowNotification): Refactor to take into
      consideration the web page.
      (WebKit::WebNotificationManagerProxy::providerDidClickNotification): Refactor to take into
      consideration the web page.
      (WebKit::WebNotificationManagerProxy::providerDidCloseNotifications): Now we need to comb through
      the list of global IDs and put them in buckets based on the notification's web pages. After that
      is done we can send the DidCloseNotifications() to those pages' processes. There is a possible
      extra optimization here where we group based on the page's process instead, to reduce the number
      of messages sent to processes.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::close): When a web page is closed, we clear the notifications associated
      with the page.
      (WebKit::WebPageProxy::cancelNotification): Forward call to WebNotificationManagerProxy.
      (WebKit::WebPageProxy::clearNotifications): Ditto.
      (WebKit::WebPageProxy::didDestroyNotification): Ditto.
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      
      * WebProcess/Notifications/NotificationPermissionRequestManager.cpp:
      * WebProcess/Notifications/WebNotificationManager.cpp:
      (WebKit::WebNotificationManager::cancel):
      (WebKit::WebNotificationManager::clearNotifications):
      (WebKit::WebNotificationManager::didDestroyNotification):
      * WebProcess/Notifications/NotificationPermissionRequestManager.cpp: Remove extraneous include.
      
      * CMakeLists.txt: Remove WebNotificationManagerProxy.messages.in and related files.
      * DerivedSources.pri: Ditto.
      * DerivedSources.make: Ditto.
      * GNUmakefile.list.am: Ditto.
      * WebKit2.xcodeproj/project.pbxproj: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15f7784b
    • darin@apple.com's avatar
      Fix typo that broke the build. · b02ea073
      darin@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b02ea073
    • darin@apple.com's avatar
      Move hasNonEmptyBoundingBox from Node to HTMLAnchorElement · 1c7d595c
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116842
      
      Reviewed by Antti Koivisto.
      
      * dom/Node.cpp: Removed hasNonEmptyBoundingBox.
      * dom/Node.h: Ditto.
      
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::isMouseFocusable): Fixed #if to be more readable and
      added more-explicit clearer comments. No behavior change.
      (WebCore::hasNonEmptyBox): Added.  Has the same code that was in
      Node::hasNonEmptyBoundingBox with some additional comments.
      (WebCore::HTMLAnchorElement::isKeyboardFocusable): Call hasNonEmptyBox.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c7d595c
    • darin@apple.com's avatar
      Move isBlockFlowElement and related functions out of the Node class into editing code · 5ca2f8c1
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116846
      
      Reviewed by Antti Koivisto.
      
      * dom/Node.cpp: Removed isBlockFlowElement, enclosingBlockFlowElement, and
      inSameContainingBlockFlowElement. These are all editing functions that don't
      belong in the Node class, and mostly-deprecated ones to boot.
      * dom/Node.h: Ditto.
      
      * dom/Position.cpp:
      (WebCore::inSameEnclosingBlockFlowElement): Added. This editing-specific function
      is used only here, so put it here.
      (WebCore::Position::rendersInDifferentPosition): Updated to call new function above.
      (WebCore::Position::leadingWhitespacePosition): Ditto.
      
      * editing/InsertLineBreakCommand.cpp:
      (WebCore::InsertLineBreakCommand::insertNodeAfterPosition): Use
      deprecatedEnclosingBlockFlowElement at its new location.
      (WebCore::InsertLineBreakCommand::insertNodeBeforePosition): Ditto.
      
      * editing/InsertListCommand.cpp:
      (WebCore::InsertListCommand::doApplyForSingleParagraph): use
      isBlockFlowElement at its new location.
      * editing/ReplaceSelectionCommand.cpp:
      (WebCore::enclosingInline): Ditto.
      
      * editing/VisiblePosition.cpp:
      (WebCore::VisiblePosition::canonicalPosition): Use deprecatedEnclosingBlockFlowElement
      at its new location.
      (WebCore::enclosingBlockFlowElement): Ditto. Also added FIXME.
      * editing/VisibleSelection.cpp:
      (WebCore::makeSearchRange): Ditto.
      
      * editing/htmlediting.cpp:
      (WebCore::isBlockFlowElement): Added. Same as the Node::isBlockFlowElement
      function, but here because this is an editing function, not suitable as a Node member.
      (WebCore::deprecatedEnclosingBlockFlowElement): Ditto. Added "deprecated" to the name
      since the Node member function had a comment saying it was deprecated. Also changed so
      it tolerates a 0 for an argument, which made it easier for one caller.
      
      * editing/htmlediting.h: Added the two new functions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ca2f8c1
    • benjamin@webkit.org's avatar
      Add a balanced benchmark for QuerySelector · 6943fd3b
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116811
      
      Reviewed by Sam Weinig.
      
      The goal of this benchmark is to have an overview of querySelector as typically used
      by webpages.
      
      It uses queries similar to what is used by popular websites and applies somewhat
      similar weighting for each type of query.
      
      The tree used for the queries is intentionally kept simple to ensure we measure QuerySelector
      a not purely the overhead of traversal.
      
      * CSS/QuerySelector.html: Added.
      * CSS/resources/query-selector.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6943fd3b
    • commit-queue@webkit.org's avatar
      [BlackBerry] Clear supression flag when caret changes aren't propogated through · 38b8dd27
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116840
      
      Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-05-27
      Reviewed by Rob Buis.
      
      Internally reviewed by Mike Fenton.
      
      PR339965
      We set and clear the flag upon every use. This leaves us vulnerable if
      1. midway through processing the selection change event is dismissed and
      2. we don't receive a TouchRelease event
      One example of this is while dragging the FCC handle we start typing. To
      safeguard against this, if the process change guard is set during a
      selection change event, we send out to clear the flag status before returning.
      
      * Api/WebPageClient.h:
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::selectionChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38b8dd27
    • commit-queue@webkit.org's avatar
      Add guard around paintForFixedRootBackground · 0e0ea522
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116754
      
      Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-05-27
      Reviewed by Simon Fraser.
      
      paintForFixedRootBackground is only used when ACCELERATED_COMPOSITING is enabled.
      
      No new tests, no behavior change.
      
      * rendering/RenderLayer.cpp:
      (WebCore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e0ea522
    • commit-queue@webkit.org's avatar
      Remove a leftover Pagepoup from PickerIndicatorElement.h · 97e7235c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116801
      
      Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-05-27
      Reviewed by Anders Carlsson.
      
      No new tests, no behavior change.
      
      * html/shadow/PickerIndicatorElement.h:
      (WebCore):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97e7235c
    • csaavedra@igalia.com's avatar
      [CSS] -webkit-var prefix is case-sensitive · 4a326189
      csaavedra@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116829
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Tests: Added case to fast/css/variables/case-sensitive.html
      
      * css/CSSParser.cpp:
      (WebCore::isEqualToCSSCaseSensitiveIdentifier): Add variant to
      IsEqualToCSSIdentifier that respects case-sensitivity.
      (WebCore::CSSParser::realLex): Use the above method for CSS
      variable declarations.
      
      LayoutTests:
      
      * fast/css/variables/case-sensitive.html: Add a
      check for case-sensitiveness of the prefix of
      variable declarations.
      * fast/css/variables/case-sensitive-expected.html: Update.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a326189