1. 30 Jan, 2011 2 commits
  2. 28 Jan, 2011 2 commits
    • rniwa@webkit.org's avatar
      2011-01-28 Sheriff Bot <webkit.review.bot@gmail.com> · 3857b1ea
      rniwa@webkit.org authored
              Unreviewed, rolling out r77006 and r77020.
              http://trac.webkit.org/changeset/77006
              http://trac.webkit.org/changeset/77020
              https://bugs.webkit.org/show_bug.cgi?id=53360
      
              "Broke Windows tests" (Requested by rniwa on #webkit).
      
              * API/JSCallbackObject.h:
              (JSC::JSCallbackObjectData::setPrivateProperty):
              (JSC::JSCallbackObjectData::JSPrivatePropertyMap::getPrivateProperty):
              (JSC::JSCallbackObjectData::JSPrivatePropertyMap::setPrivateProperty):
              (JSC::JSCallbackObjectData::JSPrivatePropertyMap::markChildren):
              (JSC::JSCallbackObject::setPrivateProperty):
              * API/JSCallbackObjectFunctions.h:
              (JSC::::put):
              (JSC::::staticFunctionGetter):
              * API/JSObjectRef.cpp:
              (JSObjectMakeConstructor):
              (JSObjectSetPrivateProperty):
              * API/JSWeakObjectMapRefInternal.h:
              * JavaScriptCore.exp:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * bytecode/CodeBlock.cpp:
              (JSC::CodeBlock::markAggregate):
              * bytecode/CodeBlock.h:
              (JSC::CodeBlock::globalObject):
              * bytecompiler/BytecodeGenerator.cpp:
              (JSC::BytecodeGenerator::BytecodeGenerator):
              (JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
              (JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
              (JSC::BytecodeGenerator::findScopedProperty):
              * debugger/Debugger.cpp:
              (JSC::evaluateInGlobalCallFrame):
              * debugger/DebuggerActivation.cpp:
              (JSC::DebuggerActivation::DebuggerActivation):
              (JSC::DebuggerActivation::markChildren):
              * debugger/DebuggerActivation.h:
              * debugger/DebuggerCallFrame.cpp:
              (JSC::DebuggerCallFrame::evaluate):
              * interpreter/CallFrame.h:
              (JSC::ExecState::exception):
              * interpreter/Interpreter.cpp:
              (JSC::Interpreter::resolve):
              (JSC::Interpreter::resolveSkip):
              (JSC::Interpreter::resolveGlobal):
              (JSC::Interpreter::resolveGlobalDynamic):
              (JSC::Interpreter::resolveBaseAndProperty):
              (JSC::Interpreter::unwindCallFrame):
              (JSC::appendSourceToError):
              (JSC::Interpreter::execute):
              (JSC::Interpreter::tryCacheGetByID):
              (JSC::Interpreter::privateExecute):
              * jit/JITStubs.cpp:
              (JSC::JITThunks::tryCacheGetByID):
              (JSC::DEFINE_STUB_FUNCTION):
              * jsc.cpp:
              (GlobalObject::GlobalObject):
              * runtime/ArgList.cpp:
              (JSC::MarkedArgumentBuffer::markLists):
              * runtime/Arguments.cpp:
              (JSC::Arguments::markChildren):
              (JSC::Arguments::getOwnPropertySlot):
              (JSC::Arguments::getOwnPropertyDescriptor):
              (JSC::Arguments::put):
              * runtime/Arguments.h:
              (JSC::Arguments::setActivation):
              (JSC::Arguments::Arguments):
              * runtime/ArrayConstructor.cpp:
              (JSC::ArrayConstructor::ArrayConstructor):
              (JSC::constructArrayWithSizeQuirk):
              * runtime/ArrayPrototype.cpp:
              (JSC::arrayProtoFuncSplice):
              * runtime/BatchedTransitionOptimizer.h:
              (JSC::BatchedTransitionOptimizer::BatchedTransitionOptimizer):
              (JSC::BatchedTransitionOptimizer::~BatchedTransitionOptimizer):
              * runtime/BooleanConstructor.cpp:
              (JSC::BooleanConstructor::BooleanConstructor):
              (JSC::constructBoolean):
              (JSC::constructBooleanFromImmediateBoolean):
              * runtime/BooleanPrototype.cpp:
              (JSC::BooleanPrototype::BooleanPrototype):
              * runtime/ConservativeSet.cpp:
              (JSC::ConservativeSet::grow):
              * runtime/ConservativeSet.h:
              (JSC::ConservativeSet::~ConservativeSet):
              (JSC::ConservativeSet::mark):
              * runtime/DateConstructor.cpp:
              (JSC::DateConstructor::DateConstructor):
              * runtime/DateInstance.cpp:
              (JSC::DateInstance::DateInstance):
              * runtime/DatePrototype.cpp:
              (JSC::dateProtoFuncSetTime):
              (JSC::setNewValueFromTimeArgs):
              (JSC::setNewValueFromDateArgs):
              (JSC::dateProtoFuncSetYear):
              * runtime/ErrorConstructor.cpp:
              (JSC::ErrorConstructor::ErrorConstructor):
              * runtime/ErrorInstance.cpp:
              (JSC::ErrorInstance::ErrorInstance):
              * runtime/ErrorPrototype.cpp:
              (JSC::ErrorPrototype::ErrorPrototype):
              * runtime/FunctionConstructor.cpp:
              (JSC::FunctionConstructor::FunctionConstructor):
              * runtime/FunctionPrototype.cpp:
              (JSC::FunctionPrototype::FunctionPrototype):
              * runtime/GetterSetter.cpp:
              (JSC::GetterSetter::markChildren):
              * runtime/GetterSetter.h:
              (JSC::GetterSetter::GetterSetter):
              (JSC::GetterSetter::getter):
              (JSC::GetterSetter::setGetter):
              (JSC::GetterSetter::setter):
              (JSC::GetterSetter::setSetter):
              * runtime/GlobalEvalFunction.cpp:
              (JSC::GlobalEvalFunction::GlobalEvalFunction):
              (JSC::GlobalEvalFunction::markChildren):
              * runtime/GlobalEvalFunction.h:
              (JSC::GlobalEvalFunction::cachedGlobalObject):
              * runtime/Heap.cpp:
              (JSC::Heap::markProtectedObjects):
              (JSC::Heap::markTempSortVectors):
              (JSC::Heap::markRoots):
              * runtime/InternalFunction.cpp:
              (JSC::InternalFunction::InternalFunction):
              * runtime/JSAPIValueWrapper.h:
              (JSC::JSAPIValueWrapper::value):
              (JSC::JSAPIValueWrapper::JSAPIValueWrapper):
              * runtime/JSActivation.cpp:
              (JSC::JSActivation::markChildren):
              (JSC::JSActivation::put):
              * runtime/JSArray.cpp:
              (JSC::JSArray::JSArray):
              (JSC::JSArray::getOwnPropertySlot):
              (JSC::JSArray::getOwnPropertyDescriptor):
              (JSC::JSArray::put):
              (JSC::JSArray::putSlowCase):
              (JSC::JSArray::deleteProperty):
              (JSC::JSArray::increaseVectorLength):
              (JSC::JSArray::setLength):
              (JSC::JSArray::pop):
              (JSC::JSArray::push):
              (JSC::JSArray::unshiftCount):
              (JSC::JSArray::sort):
              (JSC::JSArray::fillArgList):
              (JSC::JSArray::copyToRegisters):
              (JSC::JSArray::compactForSorting):
              * runtime/JSArray.h:
              (JSC::JSArray::getIndex):
              (JSC::JSArray::setIndex):
              (JSC::JSArray::uncheckedSetIndex):
              (JSC::JSArray::markChildrenDirect):
              * runtime/JSByteArray.cpp:
              (JSC::JSByteArray::JSByteArray):
              * runtime/JSCell.h:
              (JSC::JSCell::JSValue::toThisObject):
              (JSC::JSCell::MarkStack::append):
              * runtime/JSFunction.cpp:
              (JSC::JSFunction::JSFunction):
              (JSC::JSFunction::getOwnPropertySlot):
              * runtime/JSGlobalData.h:
              * runtime/JSGlobalObject.cpp:
              (JSC::markIfNeeded):
              (JSC::JSGlobalObject::reset):
              (JSC::JSGlobalObject::resetPrototype):
              (JSC::JSGlobalObject::markChildren):
              * runtime/JSGlobalObject.h:
              (JSC::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
              (JSC::JSGlobalObject::regExpConstructor):
              (JSC::JSGlobalObject::errorConstructor):
              (JSC::JSGlobalObject::evalErrorConstructor):
              (JSC::JSGlobalObject::rangeErrorConstructor):
              (JSC::JSGlobalObject::referenceErrorConstructor):
              (JSC::JSGlobalObject::syntaxErrorConstructor):
              (JSC::JSGlobalObject::typeErrorConstructor):
              (JSC::JSGlobalObject::URIErrorConstructor):
              (JSC::JSGlobalObject::evalFunction):
              (JSC::JSGlobalObject::objectPrototype):
              (JSC::JSGlobalObject::functionPrototype):
              (JSC::JSGlobalObject::arrayPrototype):
              (JSC::JSGlobalObject::booleanPrototype):
              (JSC::JSGlobalObject::stringPrototype):
              (JSC::JSGlobalObject::numberPrototype):
              (JSC::JSGlobalObject::datePrototype):
              (JSC::JSGlobalObject::regExpPrototype):
              (JSC::JSGlobalObject::methodCallDummy):
              (JSC::Structure::prototypeForLookup):
              (JSC::constructArray):
              * runtime/JSONObject.cpp:
              (JSC::Stringifier::Holder::object):
              (JSC::Stringifier::markAggregate):
              (JSC::Stringifier::stringify):
              (JSC::Stringifier::Holder::appendNextProperty):
              (JSC::Walker::callReviver):
              (JSC::Walker::walk):
              * runtime/JSObject.cpp:
              (JSC::JSObject::defineGetter):
              (JSC::JSObject::defineSetter):
              (JSC::JSObject::removeDirect):
              (JSC::JSObject::putDirectFunction):
              (JSC::JSObject::putDirectFunctionWithoutTransition):
              (JSC::putDescriptor):
              (JSC::JSObject::defineOwnProperty):
              * runtime/JSObject.h:
              (JSC::JSObject::getDirectOffset):
              (JSC::JSObject::putDirectOffset):
              (JSC::JSObject::flattenDictionaryObject):
              (JSC::JSObject::putDirectInternal):
              (JSC::JSObject::putDirect):
              (JSC::JSObject::putDirectFunction):
              (JSC::JSObject::putDirectWithoutTransition):
              (JSC::JSObject::putDirectFunctionWithoutTransition):
              (JSC::JSValue::putDirect):
              (JSC::JSObject::allocatePropertyStorageInline):
              (JSC::JSObject::markChildrenDirect):
              * runtime/JSPropertyNameIterator.cpp:
              (JSC::JSPropertyNameIterator::JSPropertyNameIterator):
              (JSC::JSPropertyNameIterator::get):
              * runtime/JSPropertyNameIterator.h:
              * runtime/JSStaticScopeObject.cpp:
              (JSC::JSStaticScopeObject::markChildren):
              * runtime/JSString.cpp:
              (JSC::StringObject::create):
              * runtime/JSValue.h:
              * runtime/JSWrapperObject.cpp:
              (JSC::JSWrapperObject::markChildren):
              * runtime/JSWrapperObject.h:
              (JSC::JSWrapperObject::internalValue):
              (JSC::JSWrapperObject::setInternalValue):
              * runtime/LiteralParser.cpp:
              (JSC::LiteralParser::parse):
              * runtime/Lookup.cpp:
              (JSC::setUpStaticFunctionSlot):
              * runtime/Lookup.h:
              (JSC::lookupPut):
              * runtime/MarkStack.h:
              (JSC::MarkStack::appendValues):
              * runtime/MathObject.cpp:
              (JSC::MathObject::MathObject):
              * runtime/NativeErrorConstructor.cpp:
              (JSC::NativeErrorConstructor::NativeErrorConstructor):
              * runtime/NativeErrorPrototype.cpp:
              (JSC::NativeErrorPrototype::NativeErrorPrototype):
              * runtime/NumberConstructor.cpp:
              (JSC::NumberConstructor::NumberConstructor):
              (JSC::constructWithNumberConstructor):
              * runtime/NumberObject.cpp:
              (JSC::constructNumber):
              * runtime/NumberPrototype.cpp:
              (JSC::NumberPrototype::NumberPrototype):
              * runtime/ObjectConstructor.cpp:
              (JSC::ObjectConstructor::ObjectConstructor):
              (JSC::objectConstructorGetOwnPropertyDescriptor):
              * runtime/Operations.h:
              (JSC::normalizePrototypeChain):
              (JSC::resolveBase):
              * runtime/PrototypeFunction.cpp:
              (JSC::PrototypeFunction::PrototypeFunction):
              * runtime/PutPropertySlot.h:
              (JSC::PutPropertySlot::setExistingProperty):
              (JSC::PutPropertySlot::setNewProperty):
              (JSC::PutPropertySlot::base):
              * runtime/RegExpConstructor.cpp:
              (JSC::RegExpConstructor::RegExpConstructor):
              * runtime/ScopeChain.cpp:
              (JSC::ScopeChainNode::print):
              * runtime/ScopeChain.h:
              (JSC::ScopeChainNode::~ScopeChainNode):
              (JSC::ScopeChainIterator::operator*):
              (JSC::ScopeChainIterator::operator->):
              (JSC::ScopeChain::top):
              * runtime/ScopeChainMark.h:
              (JSC::ScopeChain::markAggregate):
              * runtime/SmallStrings.cpp:
              (JSC::isMarked):
              (JSC::SmallStrings::markChildren):
              * runtime/SmallStrings.h:
              (JSC::SmallStrings::emptyString):
              (JSC::SmallStrings::singleCharacterString):
              (JSC::SmallStrings::singleCharacterStrings):
              * runtime/StringConstructor.cpp:
              (JSC::StringConstructor::StringConstructor):
              * runtime/StringObject.cpp:
              (JSC::StringObject::StringObject):
              * runtime/StringObject.h:
              * runtime/StringPrototype.cpp:
              (JSC::StringPrototype::StringPrototype):
              * runtime/Structure.cpp:
              (JSC::Structure::Structure):
              (JSC::Structure::addPropertyTransition):
              (JSC::Structure::toDictionaryTransition):
              (JSC::Structure::flattenDictionaryStructure):
              * runtime/Structure.h:
              (JSC::Structure::storedPrototype):
              * runtime/WeakGCMap.h:
              (JSC::WeakGCMap::uncheckedGet):
              (JSC::WeakGCMap::isValid):
              (JSC::::get):
              (JSC::::take):
              (JSC::::set):
              (JSC::::uncheckedRemove):
              * runtime/WriteBarrier.h: Removed.
      2011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r77006 and r77020.
              http://trac.webkit.org/changeset/77006
              http://trac.webkit.org/changeset/77020
              https://bugs.webkit.org/show_bug.cgi?id=53360
      
              "Broke Windows tests" (Requested by rniwa on #webkit).
      
              * JSValueWrapper.cpp:
              (JSValueWrapper::JSObjectMark):
      2011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r77006 and r77020.
              http://trac.webkit.org/changeset/77006
              http://trac.webkit.org/changeset/77020
              https://bugs.webkit.org/show_bug.cgi?id=53360
      
              "Broke Windows tests" (Requested by rniwa on #webkit).
      
              * WebView/WebScriptDebugDelegate.mm:
              (-[WebScriptCallFrame scopeChain]):
      2011-01-28  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r77006 and r77020.
              http://trac.webkit.org/changeset/77006
              http://trac.webkit.org/changeset/77020
              https://bugs.webkit.org/show_bug.cgi?id=53360
      
              "Broke Windows tests" (Requested by rniwa on #webkit).
      
              * ForwardingHeaders/runtime/WriteBarrier.h: Removed.
              * WebCore.exp.in:
              * bindings/js/DOMWrapperWorld.h:
              * bindings/js/JSAudioConstructor.cpp:
              (WebCore::JSAudioConstructor::JSAudioConstructor):
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::markDOMNodesForDocument):
              (WebCore::markDOMObjectWrapper):
              (WebCore::markDOMNodeWrapper):
              * bindings/js/JSDOMGlobalObject.cpp:
              (WebCore::JSDOMGlobalObject::markChildren):
              (WebCore::JSDOMGlobalObject::setInjectedScript):
              (WebCore::JSDOMGlobalObject::injectedScript):
              * bindings/js/JSDOMGlobalObject.h:
              (WebCore::JSDOMGlobalObject::JSDOMGlobalObjectData::JSDOMGlobalObjectData):
              (WebCore::getDOMConstructor):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::setLocation):
              (WebCore::DialogHandler::dialogCreated):
              * bindings/js/JSDOMWindowShell.cpp:
              (WebCore::JSDOMWindowShell::JSDOMWindowShell):
              (WebCore::JSDOMWindowShell::setWindow):
              (WebCore::JSDOMWindowShell::markChildren):
              (WebCore::JSDOMWindowShell::unwrappedObject):
              * bindings/js/JSDOMWindowShell.h:
              (WebCore::JSDOMWindowShell::window):
              (WebCore::JSDOMWindowShell::setWindow):
              * bindings/js/JSDeviceMotionEventCustom.cpp:
              (WebCore::createAccelerationObject):
              (WebCore::createRotationRateObject):
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSEventListener::JSEventListener):
              (WebCore::JSEventListener::markJSFunction):
              * bindings/js/JSEventListener.h:
              (WebCore::JSEventListener::jsFunction):
              * bindings/js/JSHTMLDocumentCustom.cpp:
              (WebCore::JSHTMLDocument::setAll):
              * bindings/js/JSImageConstructor.cpp:
              (WebCore::JSImageConstructor::JSImageConstructor):
              * bindings/js/JSImageDataCustom.cpp:
              (WebCore::toJS):
              * bindings/js/JSJavaScriptCallFrameCustom.cpp:
              (WebCore::JSJavaScriptCallFrame::scopeChain):
              (WebCore::JSJavaScriptCallFrame::scopeType):
              * bindings/js/JSNodeFilterCondition.cpp:
              (WebCore::JSNodeFilterCondition::markAggregate):
              (WebCore::JSNodeFilterCondition::acceptNode):
              * bindings/js/JSNodeFilterCondition.h:
              * bindings/js/JSNodeFilterCustom.cpp:
              * bindings/js/JSOptionConstructor.cpp:
              (WebCore::JSOptionConstructor::JSOptionConstructor):
              * bindings/js/JSSQLResultSetRowListCustom.cpp:
              (WebCore::JSSQLResultSetRowList::item):
              * bindings/js/ScriptCachedFrameData.cpp:
              (WebCore::ScriptCachedFrameData::restore):
              * bindings/js/ScriptObject.cpp:
              (WebCore::ScriptGlobalObject::set):
              * bindings/js/SerializedScriptValue.cpp:
              (WebCore::CloneDeserializer::putProperty):
              * bindings/scripts/CodeGeneratorJS.pm:
              * bridge/qt/qt_runtime.cpp:
              (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
              (JSC::Bindings::QtRuntimeMetaMethod::markChildren):
              (JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
              (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
              * bridge/qt/qt_runtime.h:
              * bridge/runtime_root.cpp:
              (JSC::Bindings::RootObject::invalidate):
              * bridge/runtime_root.h:
              * dom/Document.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3857b1ea
    • oliver@apple.com's avatar
      Fixed Qt build. · e0c483d0
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0c483d0
  3. 08 Jan, 2011 1 commit
  4. 06 Jan, 2011 1 commit
    • robert@webkit.org's avatar
      2011-01-06 Robert Hogan <robert@webkit.org> · d1487c73
      robert@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [Qt] Introduce QDRTNode for passing WebCore::Node across JS bridge
      
              This allows LayoutTestController to pass WebCore::Node back to
              layout tests.
      
              Also amend nodesFromRect-links-and-text.html and
              nodesFromRect-inner-documents.html so that they do not produce
              platform-specific results.
      
              Unskip:
              fast/dom/nodesFromRect-links-and-text.html
              fast/dom/nodesFromRect-inner-documents.html
      
              https://bugs.webkit.org/show_bug.cgi?id=48957
      
              * fast/dom/nodesFromRect-inner-documents-expected.txt:
              * fast/dom/nodesFromRect-inner-documents.html:
              * fast/dom/nodesFromRect-links-and-text-expected.txt:
              * fast/dom/nodesFromRect-links-and-text.html:
              * fast/dom/resources/nodesFromRect.js:
              (check):
              (getTopFor):
              (getBottomFor):
              * platform/qt/Skipped:
      2011-01-06  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Antonio Gomes.
      
              [Qt] Introduce QDRTNode for passing WebCore::Node across JS bridge
      
              This allows LayoutTestController to pass WebCore::Node back to
              layout tests.
      
              Also amend nodesFromRect-links-and-text.html and
              nodesFromRect-inner-documents.html so that they do not produce
              platform-specific results.
      
              Unskip:
              fast/dom/nodesFromRect-links-and-text.html
              fast/dom/nodesFromRect-inner-documents.html
      
              https://bugs.webkit.org/show_bug.cgi?id=48957
      
              * bridge/qt/qt_runtime.cpp:
              (JSC::Bindings::QtDRTNodeRuntime::create):
              (JSC::Bindings::QtDRTNodeRuntime::get):
              (JSC::Bindings::convertValueToQVariant):
              (JSC::Bindings::convertQVariantToValue):
      2011-01-06  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Antonio Gomes.
      
              [Qt] Introduce QDRTNode for passing WebCore::Node across JS bridge
      
              This allows LayoutTestController to pass WebCore::Node back to
              layout tests.
      
              Also amend nodesFromRect-links-and-text.html and
              nodesFromRect-inner-documents.html so that they do not produce
              platform-specific results.
      
              Unskip:
              fast/dom/nodesFromRect-links-and-text.html
              fast/dom/nodesFromRect-inner-documents.html
      
              https://bugs.webkit.org/show_bug.cgi?id=48957
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (QDRTNode::QDRTNode):
              (QDRTNode::~QDRTNode):
              (DumpRenderTreeSupportQt::nodesFromRect):
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@75189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1487c73
  5. 31 Oct, 2010 1 commit
  6. 25 Oct, 2010 1 commit
    • rniwa@webkit.org's avatar
      2010-10-25 Ryosuke Niwa <rniwa@webkit.org> · 03a7e59a
      rniwa@webkit.org authored
              Unreviewed Qt build fix for r70496.
      
              * bridge/qt/qt_instance.cpp:
              (JSC::Bindings::QtInstance::numberValue):
              * bridge/qt/qt_pixmapruntime.cpp:
              (JSC::Bindings::QtPixmapWidthField::valueFromInstance):
              (JSC::Bindings::QtPixmapHeightField::valueFromInstance):
              * bridge/qt/qt_runtime.cpp:
              (JSC::Bindings::convertValueToQVariant):
              (JSC::Bindings::convertQVariantToValue):
              (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter):
              (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@70503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03a7e59a
  7. 07 Sep, 2010 1 commit
    • kent.hansen@nokia.com's avatar
      2010-09-07 Kent Hansen <kent.hansen@nokia.com> · 8f8acc93
      kent.hansen@nokia.com authored
              Reviewed by Andreas Kling.
      
              [Qt] tst_QWebFrame::connectAndDisconnect() fails on WebKit trunk because __qt_sender__ is never set
              https://bugs.webkit.org/show_bug.cgi?id=44697
      
              When the signal handler is a JS function, __qt_sender__ is stuffed into a temporary
              object that's pushed onto the function's scope before the function is invoked, and
              popped again afterwards.
      
              We were pushing this new scope object _after_ calling JSFunction::getCallData(),
              and relying on JSC::call() to use the fresh scope chain from the function object.
              However, this is no longer the case; JSC::call() uses the scope chain passed in
              the CallData argument. Hence, we need to set up the scope before the function's
              CallData is queried.
      
              * bridge/qt/qt_runtime.cpp:
              (JSC::Bindings::QtConnectionObject::execute):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66875 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f8acc93
  8. 25 Aug, 2010 1 commit
  9. 14 Aug, 2010 1 commit
  10. 11 Aug, 2010 1 commit
  11. 10 Aug, 2010 1 commit
  12. 24 Jul, 2010 1 commit
  13. 19 Jul, 2010 1 commit
  14. 19 Jun, 2010 1 commit
    • robert@webkit.org's avatar
      2010-06-02 Robert Hogan <robert@webkit.org> · d1b70443
      robert@webkit.org authored
              Reviewed by Adam Barth.
      
              [Qt] Support evaluateScriptInIsolatedWorld()
      
              https://bugs.webkit.org/show_bug.cgi?id=40079
      
              This initial implementation passes 25 of the 27 tests in
              http/tests/isolatedworld as well as four others that use the
              call in LayoutTests.
      
              Further work/investigation is required to support the two
              remaining tests.
      
              * platform/qt/Skipped:
      2010-06-02  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Adam Barth.
      
              [Qt] Support evaluateScriptInIsolatedWorld()
      
              https://bugs.webkit.org/show_bug.cgi?id=40079
      
              getOwnPropertyNames() crashes if PropertyNameArray is size 0. This change allows
              http/tests/world-reuse.html and didClearWindowObject.html to fail instead of crash.
      
              * WebCore.pro: Add qwebscriptworld.*
              * bridge/qt/qt_runtime.cpp:
              (JSC::Bindings::convertValueToQVariant):
      2010-06-02  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Adam Barth.
      
              [Qt] Support evaluateScriptInIsolatedWorld()
      
              https://bugs.webkit.org/show_bug.cgi?id=40079
      
              * Api/headers.pri:
              * Api/qwebframe.cpp:
              (QWebFrame::evaluateScriptInIsolatedWorld):
              * Api/qwebframe.h:
              * Api/qwebscriptworld.cpp: Added.
              (QWebScriptWorld::QWebScriptWorld):
              (QWebScriptWorld::world):
              (QWebScriptWorld::~QWebScriptWorld):
              * Api/qwebscriptworld.h: Added.
              * Api/qwebscriptworld_p.h: Added.
              (QWebScriptWorldPrivate::QWebScriptWorldPrivate):
              (QWebScriptWorldPrivate::~QWebScriptWorldPrivate):
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
      2010-06-02  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Adam Barth.
      
              [Qt] Support evaluateScriptInIsolatedWorld()
      
              https://bugs.webkit.org/show_bug.cgi?id=40079
      
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::evaluateScriptInIsolatedWorld):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1b70443
  15. 14 Jun, 2010 1 commit
  16. 13 Jun, 2010 1 commit
    • eric@webkit.org's avatar
      2010-06-13 Noam Rosenthal <noam.rosenthal@nokia.com> · cf872146
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] tests/hybridPixmap fails
              https://bugs.webkit.org/show_bug.cgi?id=37316
      
              The problem was that JSC::Instance::createRuntimeObject was never called.
              This is fixed by overloading newRuntimeObject and calling Instance::createRuntimeObject
              in between, instead of creating the runtime object directly inside the static function
              QtPixmapInstance::createRuntimeObject, which had to be renamed as to not overshadow the virtual function.
      
              This fixes an existing test, tests/hybridPixmap
      
              * bridge/qt/qt_pixmapruntime.cpp:
              (JSC::Bindings::QtPixmapInstance::newRuntimeObject):
              (JSC::Bindings::QtPixmapInstance::createPixmapRuntimeObject):
              * bridge/qt/qt_pixmapruntime.h:
              * bridge/qt/qt_runtime.cpp:
              (JSC::Bindings::convertQVariantToValue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@61089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf872146
  17. 06 Jun, 2010 2 commits
  18. 03 Jun, 2010 2 commits
  19. 29 May, 2010 3 commits
  20. 21 May, 2010 1 commit
  21. 14 May, 2010 1 commit
  22. 26 Apr, 2010 1 commit
    • eric@webkit.org's avatar
      2010-04-26 Bruno Schmidt <bruno.schmidt@gmail.com> · 4303ff5a
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Exposing an QVariantMap containing QObjectStar to Javascript
              causes Segmentation Fault
              https://bugs.webkit.org/show_bug.cgi?id=34729
      
              If an QVariantMap containing QObjectStar is added to the to QtWebkit
              Javascript, it's use causes Segmentation Fault.
              It happens because, in the case QMetaType::QVariantMap, the "root"
              object that is inside of a PassRefPtr is passed recursively inside a
              loop to recover the content of the map, but the PassRefPtr semantics
              prohibit its use inside a loop, so the "root" object mus be passed
              using the method "PassRefPtr::get" in order to keep the current
              reference.
      
              * bridge/qt/qt_runtime.cpp:
              (JSC::Bindings::convertValueToQVariant):
              (JSC::Bindings::convertQVariantToValue): change to root.get()
      2010-04-26  Bruno Schmidt  <bruno.schmidt@gmail.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Exposing an QVariantMap containing QObjectStar to Javascript
              causes Segmentation Fault
              https://bugs.webkit.org/show_bug.cgi?id=34729
      
              If an QVariantMap containing QObjectStar is added to the to QtWebkit
              Javascript, it's use causes Segmentation Fault.
              It happens because, in the case QMetaType::QVariantMap, the "root"
              object that is inside of a PassRefPtr is passed recursively inside a
              loop to recover the content of the map, but the PassRefPtr semantics
              prohibit its use inside a loop, so the "root" object mus be passed
              using the method "PassRefPtr::get" in order to keep the current
              reference.
      
              * tests/qwebframe/tst_qwebframe.cpp:
              (MyQObject::MyQObject): new property variantMapProperty
              (MyQObject::variantMapProperty): read variantMapProperty
              (MyQObject::setVariantMapProperty): write variantMapProperty
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4303ff5a
  23. 15 Apr, 2010 1 commit
    • eric@webkit.org's avatar
      2010-04-15 Bruno Schmidt <bruno.schmidt@gmail.com> · 1c041ea2
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Null QObjects properties cause Segmentation Fault
              https://bugs.webkit.org/show_bug.cgi?id=34730
      
              QObjects exported to the QWebkit javascript with properties that are
              a null "QObject*" cause Segmentation Fault.
      
              If an QObject is added to the javascript context and it contains
              properties of the type QObject* with NULL value, calling the property
              causes Segmentation Fault.
              So now the code below properly checks for null pointers:
      
              * bridge/qt/qt_instance.cpp:
              (JSC::Bindings::QtInstance::getClass): may return NULL
              (JSC::Bindings::QtInstance::getMethod): may return jsNull()
              (JSC::Bindings::QtInstance::stringValue): may return jsNull()
              (JSC::Bindings::QtInstance::booleanValue): may return false
              * bridge/qt/qt_runtime.cpp:
              (JSC::Bindings::convertValueToQVariant):
              (JSC::Bindings::convertQVariantToValue): May return jsNull on QObjectStar
      2010-04-15  Bruno Schmidt  <bruno.schmidt@gmail.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Null QObjects properties cause Segmentation Fault
              https://bugs.webkit.org/show_bug.cgi?id=34730
      
              QObjects exported to the QWebkit javascript with properties that are
              a null "QObject*" cause Segmentation Fault.
      
              If an QObject is added to the javascript context and it contains
              properties of the type QObject* with NULL value, calling the property
              causes Segmentation Fault.
      
              Follow the tests for the corrections done over WebCore.
      
              * tests/qwebframe/tst_qwebframe.cpp:
              (MyQObject::MyQObject): init the field m_objectStar
              (MyQObject::objectStarProperty): read the Object* prop
              (MyQObject::setObjectStarProperty): write the Object* prop
              (tst_QWebFrame::getSetStaticProperty): new tests for the new prop
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c041ea2
  24. 11 Mar, 2010 1 commit
  25. 02 Mar, 2010 1 commit
    • oliver@apple.com's avatar
      2010-03-02 Oliver Hunt <oliver@apple.com> · 83693dd7
      oliver@apple.com authored
              Reviewed by NOBODY (Build fix).
      
              Update Qt bridge to new named getter signature
      
              * bridge/qt/qt_runtime.cpp:
              (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter):
              (JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
              (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
              (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter):
              * bridge/qt/qt_runtime.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55404 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83693dd7
  26. 22 Feb, 2010 1 commit
  27. 15 Feb, 2010 1 commit
    • eric@webkit.org's avatar
      2010-02-15 Noam Rosenthal <noam.rosenthal@nokia.com> · 948175d2
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] QtWebkit bridge: enable passing a QWebElement to a signal/slot/property
              https://bugs.webkit.org/show_bug.cgi?id=34901
      
              When a signal/slot/property is of type QWebElement, it can seamlessly
              connect with JS objects that hold a WebCore element.
      
              New tests, see WebKit/qt/ChangeLog
      
              * bridge/qt/qt_runtime.cpp:
              (JSC::Bindings::QtWebElementRuntime::create): A proxy to QWebElement
              constructor
              (JSC::Bindings::QtWebElementRuntime::get): A proxy to
              QWebElement::element
              (JSC::Bindings::convertValueToQVariant): handle QWebElement
              (JSC::Bindings::convertQVariantToValue): handle QWebElement
      2010-02-15  Noam Rosenthal  <noam.rosenthal@nokia.com>
      
              Reviewed by Simon Hausmann.
      
              [Qt] QtWebkit bridge: enable passing a QWebElement to a signal/slot/property
              Add Q_DECLARE_METATYPE to QWebElement, add relevant tests to
              tst_qwebframe
              https://bugs.webkit.org/show_bug.cgi?id=34901
      
              * Api/qwebelement.h: declare metatype
              * tests/qwebframe/tst_qwebframe.cpp:
              (MyQObject::webElementProperty): new test for QWebElement
              (MyQObject::setWebElementProperty): new test for QWebElement
              (MyQObject::myOverloadedSlot): new test for QWebElement
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@54775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      948175d2
  28. 29 Jan, 2010 1 commit
  29. 27 Jan, 2010 1 commit
    • eric@webkit.org's avatar
      2010-01-27 Kent Hansen <kent.hansen@nokia.com> · 82e6b783
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Meta-methods can't be introspected using ES5 API
              https://bugs.webkit.org/show_bug.cgi?id=34087
      
              Add getOwnPropertyDescriptor() and getOwnPropertyNames() reimplementations.
      
              Tests are in WebKit/qt/tests/qwebframe
      
              * bridge/qt/qt_runtime.cpp:
              (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
              (JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyNames):
              (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):
              (JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyNames):
              * bridge/qt/qt_runtime.h:
      2010-01-27  Kent Hansen  <kent.hansen@nokia.com>
      
              Reviewed by Simon Hausmann.
      
              [Qt] Meta-methods can't be introspected using ES5 API
              https://bugs.webkit.org/show_bug.cgi?id=34087
      
              Test that Object.getOwnPropertyDescriptor and
              Object.getOwnPropertyNames work with meta-methods.
      
              * tests/qwebframe/tst_qwebframe.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82e6b783
  30. 21 Jan, 2010 1 commit
    • hausmann@webkit.org's avatar
      WebCore: [Qt] Adding QPixmap/QImage support for the Qt hybrid layer · 25868b61
      hausmann@webkit.org authored
             Allows accesing QPixmap and QImage based arguments from Qt signals,
             slots and properties
             This is done by an intermediate object that can be turned into
             web-based objects by calling either toHTMLImageElement() or
             toDataURL()
      https://bugs.webkit.org/show_bug.cgi?id=32461
      
      Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2010-01-21
      Reviewed by Simon Hausmann.
      
      Tests are in WebKit/qt/tests/hybridPixmap
      
      * WebCore.pro:
      * bridge/qt/qt_pixmapruntime.cpp: Added.
      (JSC::Bindings::QtPixmapWidthField::name): "width"
      (JSC::Bindings::QtPixmapWidthField::valueFromInstance): width of
      pixmap
      (JSC::Bindings::QtPixmapWidthField::setValueToInstance): nothing
      (JSC::Bindings::QtPixmapHeightField::name): "height"
      (JSC::Bindings::QtPixmapHeightField::valueFromInstance): height of
      pixmap
      (JSC::Bindings::QtPixmapHeightField::setValueToInstance): nothing
      (JSC::Bindings::QtPixmapRuntimeMethod::numParameters): 0
      (JSC::Bindings::QtPixmapCreateElementMethod::name): toHTMLImageElement
      (JSC::Bindings::QtPixmapCreateElementMethod::invoke): creates an HTML
      element from the QPixmap
      (JSC::Bindings::QtPixmapToDataUrlMethod::name): "toDataURL"
      (JSC::Bindings::QtPixmapToDataUrlMethod::invoke): encodes the image to
      a base64 data url
      (JSC::Bindings::QtPixmapToStringMethod::name): "toString"
      (JSC::Bindings::QtPixmapToStringMethod::invoke): [Qt Native Pixmap
      w,h]
      
      (JSC::Bindings::QtPixmapRuntimeObjectImp::createStructure):
      runtime-object broilerplate
      (JSC::Bindings::QtPixmapRuntimeObjectImp::classInfo): ditto
      (JSC::Bindings::QtPixmapRuntimeObjectImp::QtPixmapRuntimeObjectImp):
      ditto
      (JSC::Bindings::): ditto
      (JSC::Bindings::QtPixmapClass::QtPixmapClass): class for the
      intermediate pixmap-holder
      (JSC::Bindings::QtPixmapInstance::getClass): ditto
      (JSC::Bindings::QtPixmapInstance::invokeMethod): ditto
      (JSC::Bindings::QtPixmapClass::methodsNamed): toHTMLImageElement,
      toDataURL
      (JSC::Bindings::QtPixmapClass::fieldNamed): width, height
      (JSC::Bindings::QtPixmapInstance::getPropertyNames):
              toHTMLImageElement, toDataURL, width, height
      (JSC::Bindings::QtPixmapInstance::defaultValue): nothing
      (JSC::Bindings::QtPixmapInstance::valueOf): toString
      (JSC::Bindings::data): holds a QVariant of type QImage/QPixmap
      (JSC::Bindings::QtPixmapInstance::width): width of the image/pixmap
      (JSC::Bindings::QtPixmapInstance::height): height of the image/pixmap
      (JSC::Bindings::QtPixmapInstance::toPixmap): converts to a QPixmap
      (JSC::Bindings::QtPixmapInstance::toImage): converts to a QImage
      (JSC::Bindings::QtPixmapInstance::variantFromObject): makes sure this
      is the right type of object, and creates a QVariant
      (JSC::Bindings::QtPixmapInstance::createRuntimeObject): creates a new
      intermediate pixmap holder from a QVariant
      (JSC::Bindings::QtPixmapInstance::canHandle): returns true if a
      QPixmap/QImage is required
      * bridge/qt/qt_pixmapruntime.h: Added.
      * bridge/qt/qt_runtime.cpp: hooks for the bridge
      (JSC::Bindings::convertValueToQVariant): handle QPixmap/QImage if the
      object is the intermediate pixmap holder or an HTMLImageElement
      (JSC::Bindings::convertQVariantToValue): creates the intermediate
      object from a QVariant of type QImage/QPixmap
      
      WebKit/qt: [Qt] Adding QPixmap/QImage support for the Qt hybrid layer
      https://bugs.webkit.org/show_bug.cgi?id=32461
      
      Patch by No'am Rosenthal <noam.rosenthal@nokia.com> on 2010-01-21
      Reviewed by Simon Hausmann.
      
      * tests/hybridPixmap: Added.
      * tests/hybridPixmap/hybridPixmap.pro: Added.
      * tests/hybridPixmap/resources.qrc: Added.
      * tests/hybridPixmap/test.html: Added.
      * tests/hybridPixmap/tst_hybridPixmap.cpp: Added.
      (tst_hybridPixmap::tst_hybridPixmap): tests most of the use cases for
      hybrid pixmap/image manipulation
      (tst_hybridPixmap::init): QTestLib initialization
      (tst_hybridPixmap::cleanup): QTestLib cleanup
      (tst_hybridPixmap::hybridPixmap): run the html file
      * tests/hybridPixmap/widget.cpp: Added.
      (Widget::Widget):
      (Widget::refreshJS):
      (Widget::start):
      (Widget::completeTest):
      (Widget::setPixmap):
      (Widget::pixmap):
      (Widget::setImage):
      (Widget::image):
      (Widget::~Widget):
      (Widget::changeEvent):
      (Widget::compare):
      (Widget::imageSlot):
      (Widget::pixmapSlot):
      (Widget::randomSlot):
      * tests/hybridPixmap/widget.h: Added.
      * tests/hybridPixmap/widget.ui: Added.
      * tests/tests.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25868b61
  31. 20 Jan, 2010 1 commit
    • steveblock@google.com's avatar
      Fixes style in WebCore/bridge/Bridge · 0479f6d3
      steveblock@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=33839
      
      Reviewed by David Levin.
      
      No new tests, style fixes only.
      
      * bridge/Bridge.cpp: Modified.
      * bridge/Bridge.h: Modified.
      * bridge/c/c_instance.cpp: Modified.
      (JSC::Bindings::CInstance::invokeMethod): Modified. Use renamed m_rootObject member
      (JSC::Bindings::CInstance::invokeDefaultMethod): Modified. Use renamed m_rootObject member
      (JSC::Bindings::CInstance::invokeConstruct): Modified. Use renamed m_rootObject member
      * bridge/jni/jni_runtime.cpp: Modified.
      (JavaArray::JavaArray): Modified. Use renamed m_rootObject member
      (JavaArray::rootObject): Modified. Use renamed m_rootObject member
      * bridge/objc/objc_instance.mm: Modified.
      (ObjcInstance::invokeMethod): Modified. Use renamed m_rootObject member
      (ObjcInstance::invokeDefaultMethod): Modified. Use renamed m_rootObject member
      (ObjcInstance::getValueOfUndefinedField): Modified. Use renamed m_rootObject member
      * bridge/objc/objc_runtime.mm: Modified.
      (JSC::Bindings::ObjcArray::valueAt): Modified. Use renamed m_rootObject member
      * bridge/qt/qt_runtime.cpp: Modified.
      (JSC::Bindings::::rootObject): Modified. Use renamed m_rootObject member
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0479f6d3
  32. 19 Jan, 2010 1 commit
  33. 06 Nov, 2009 2 commits