1. 16 Dec, 2007 22 commits
    • mrowe@apple.com's avatar
      2007-12-16 Rodney Dawes <dobey@wayofthemonkey.com> · d37943a8
      mrowe@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              http://bugs.webkit.org/show_bug.cgi?id=16389
              Bug 16389: Common Implementation of NetscapePlugInStreamLoader
      
              * WebCore.vcproj/WebCore.vcproj: Remove NetscapePlugInStreamLoaderWin.cpp.
              * loader/NetscapePlugInStreamLoader.cpp: Copy method implementations from NetscapePlugInStreamLoaderWin.cpp.
              * loader/win/NetscapePlugInStreamLoaderWin.cpp: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d37943a8
    • mrowe@apple.com's avatar
      2007-12-16 Dimitri Glazkov <dimitri@glazkov.com> · 1d5abfb3
      mrowe@apple.com authored
              Reviewed by Adam Roben.
      
              Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
      
              * FindSafari/FindSafari.cpp:
              (_tmain):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d5abfb3
    • mrowe@apple.com's avatar
      2007-12-16 Brent Fulgham <bfulgham@gmail.com> · 8e501e95
      mrowe@apple.com authored
              Reviewed by Adam Roben.
      
              http://bugs.webkit.org/show_bug.cgi?id=16315
              FindSafari needs a path-only option.
      
              * FindSafari/FindSafari.cpp:
              (_tmain):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e501e95
    • darin@apple.com's avatar
      * fast/js/regexp-overflow-expected.txt: Updated. I accidentally checked in an · 78db8437
      darin@apple.com authored
              out-of-date file last time.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78db8437
    • darin@apple.com's avatar
      Reviewed by Darin Adler. · 3a8a8100
      darin@apple.com authored
              Fix http://bugs.webkit.org/show_bug.cgi?id=16433.
              Bug 16433: LOW_BANDWIDTH_DISPLAY build is broken
      
              * dom/Document.cpp:
              (WebCore::Document::Document):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::addLowBandwidthDisplayRequest):
              (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a8a8100
    • darin@apple.com's avatar
      JavaScriptCore: · 9be07b6f
      darin@apple.com authored
              Reviewed by Maciej.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=16459
                REGRESSION: assertion failure with regexp with \B in a case-ignoring character range
                <rdar://problem/5646361>
      
              The problem was that \B was not handled properly in character classes.
      
              Test: fast/js/regexp-overflow.html
      
              * pcre/pcre_compile.cpp:
              (check_escape): Added handling of ESC_b and ESC_B in character classes here.
              Allows us to get rid of the handling of \b in character classes from all the
              call sites that handle it separately and to handle \B properly as well.
              (compileBranch): Remove the ESC_b handling, since it's not needed any more.
              (calculateCompiledPatternLengthAndFlags): Ditto.
      
      LayoutTests:
      
              Reviewed by Maciej.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=16459
                REGRESSION: assertion failure with regexp with \B in a case-ignoring character range
                <rdar://problem/5646361>
      
              * fast/js/regexp-overflow-expected.txt: Updated.
              * fast/js/resources/regexp-overflow.js: Added test cases.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9be07b6f
    • mrowe@apple.com's avatar
      2007-12-16 Grace Kloba <klobag@gmail.com> · 46633d3f
      mrowe@apple.com authored
              Reviewed by Darin Adler.
      
              Fix http://bugs.webkit.org/show_bug.cgi?id=16433.
              Bug 16433: LOW_BANDWIDTH_DISPLAY build is broken
      
              * dom/Document.cpp:
              (WebCore::Document::Document):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::addLowBandwidthDisplayRequest):
              (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46633d3f
    • mrowe@apple.com's avatar
      2007-12-16 Brent Fulgham <bfulgham@gmail.com> · bcf22bdc
      mrowe@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              http://bugs.webkit.org/show_bug.cgi?id=16446.
      
              * building/debug.html:  Update to expand the win32 debugging instructions.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcf22bdc
    • mrowe@apple.com's avatar
      Fix http://bugs.webkit.org/show_bug.cgi?id=16448 ([GTK] Celtic Kane JavaScript... · a9afe980
      mrowe@apple.com authored
      Fix http://bugs.webkit.org/show_bug.cgi?id=16448 ([GTK] Celtic Kane JavaScript performance on Array test is slow relative to Mac).
      
      Reviewed by Maciej Stachowiak.
      
      * kjs/array_instance.cpp:
      (KJS::compareByStringPairForQSort):
      (KJS::ArrayInstance::sort): Convert JSValue's to strings once up front and then sort the
      results.  This avoids calling toString twice per comparison, but requires a temporary buffer
      so we only use this approach in cases where the array being sorted is not too large.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9afe980
    • darin@apple.com's avatar
      WebCore: · aa170ad0
      darin@apple.com authored
              Reviewed by Darin.
      
              More of http://bugs.webkit.org/show_bug.cgi?id=16385
              Cleanup kjs_window
      
              - Move PausedTimeouts into its own file and put it in the WebCore namespace.
      
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * bindings/js/PausedTimeouts.cpp: Copied from bindings/js/kjs_window.cpp.
              * bindings/js/PausedTimeouts.h: Copied from bindings/js/kjs_window.h.
              * bindings/js/kjs_window.cpp:
              (KJS::Window::pauseTimeouts):
              * bindings/js/kjs_window.h:
              * history/CachedPage.cpp:
              * history/CachedPage.h:
              * page/Chrome.cpp:
      
      LayoutTests:
      
              Reviewed by Maciej.
      
              - tests for the argument handling of the executeSql function
      
              * storage/execute-sql-args-expected.txt: Added.
              * storage/execute-sql-args.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa170ad0
    • darin@apple.com's avatar
      - try to get the system color test passing on the buildbot · a242fca3
      darin@apple.com authored
              I fear this test may be vulnerable to slight platform differences.
      
              * platform/mac-tiger/fast: Added.
              * platform/mac-tiger/fast/css: Added.
              * platform/mac-tiger/fast/css/css2-system-color-expected.checksum: Copied from platform/mac/fast/css/css2-system-color-expected.checksum.
              * platform/mac-tiger/fast/css/css2-system-color-expected.png: Copied from platform/mac/fast/css/css2-system-color-expected.png.
              * platform/mac-tiger/fast/css/css2-system-color-expected.txt: Copied from platform/mac/fast/css/css2-system-color-expected.txt.
              Then updated to match what the buildbot says.
      
              * platform/mac/fast/css/css2-system-color-expected.txt: Updated to match
              results I'm getting locally on my Leopard machine.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a242fca3
    • weinig@apple.com's avatar
      Reviewed by Darin. · a1ad3df6
      weinig@apple.com authored
              More of http://bugs.webkit.org/show_bug.cgi?id=16385
              Cleanup kjs_window
      
              - Move PausedTimeouts into its own file and put it in the WebCore namespace.
      
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * bindings/js/PausedTimeouts.cpp: Copied from bindings/js/kjs_window.cpp.
              * bindings/js/PausedTimeouts.h: Copied from bindings/js/kjs_window.h.
              * bindings/js/kjs_window.cpp:
              (KJS::Window::pauseTimeouts):
              * bindings/js/kjs_window.h:
              * history/CachedPage.cpp:
              * history/CachedPage.h:
              * page/Chrome.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1ad3df6
    • bdakin@apple.com's avatar
      WebCore: · bbb4c7d4
      bdakin@apple.com authored
              Reviewed by Geoff.
      
              Make relative-size SVGs work in border-image.
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calculateBackgroundSize):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::paintBorderImage):
      
      LayoutTests:
      
              Reviewed by Geoff.
      
              Tests for SVG as border-image.
      
              * fast/borders/resources/green-fixed-size-rect.svg: Added.
              * fast/borders/resources/green-relative-size-rect.svg: Added.
              * fast/borders/svg-as-border-image-2.html: Added.
              * fast/borders/svg-as-border-image.html: Added.
              * platform/mac/fast/borders/svg-as-border-image-2-expected.checksum: Added.
              * platform/mac/fast/borders/svg-as-border-image-2-expected.png: Added.
              * platform/mac/fast/borders/svg-as-border-image-2-expected.txt: Added.
              * platform/mac/fast/borders/svg-as-border-image-expected.checksum: Added.
              * platform/mac/fast/borders/svg-as-border-image-expected.png: Added.
              * platform/mac/fast/borders/svg-as-border-image-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbb4c7d4
    • ggaren@apple.com's avatar
      Reviewed by Darin Adler and Maciej Stachowiak. · 3ab2bcee
      ggaren@apple.com authored
              
              More refactoring to support global variable optimization.
              
              Changed SymbolTable to use RefPtr<UString::Rep> as its key instead of
              UString::Rep*. With globals, the symbol table can outlast the
              declaration node for any given symbol, so the symbol table needs to ref
              its symbol names.
              
              In support, specialized HashMaps with RefPtr keys to allow lookup
              via raw pointer, avoiding refcount churn.
              
              SunSpider reports a .6% speedup (prolly just noise).
      
              * JavaScriptCore.vcproj/WTF/WTF.vcproj: Added new file: wtf/RefPtrHashMap.h
              * JavaScriptCore.xcodeproj/project.pbxproj: ditto
      
              * kjs/JSVariableObject.cpp:
              (KJS::JSVariableObject::getPropertyNames): Symbol table keys are RefPtrs now.
      
              * kjs/SymbolTable.h: Modified key traits to match RefPtr. Added a
              static Rep* for null, which helps compute the deletedValue() trait.
      
              * wtf/HashMap.h: #include the RefPtr specialization so everyone can use it.
      
              * wtf/RefPtrHashMap.h: Copied from wtf/HashMap.h. Added overloaded versions
              of find(), contains(), get(), set(), add(), remove(), and take() that take
              raw pointers as keys.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ab2bcee
    • darin@apple.com's avatar
      - fix Tiger build (my fault it was broken) · 78225e8d
      darin@apple.com authored
              * rendering/RenderThemeMac.mm: Define NSUInteger if on Tiger.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      78225e8d
    • darin@apple.com's avatar
      WebCore: · 0053725e
      darin@apple.com authored
              Reviewed by Darin.
              
              http://bugs.webkit.org/show_bug.cgi?id=6129
              Incomplete implementation of CSS 2.1 system colors
      
              Test: fast/css/css2-system-color.html
              
              Based on original patch by Rob Buis.
              
              System colors are retrieved from NSColor as appropriate. If the color is a pattern color
              (and therefore NSColor won't let us retrieve a color from it) we draw a 1x1 image of the
              color and sample that to get a solid color.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::):
              (WebCore::colorForCSSValue):
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::systemColor):
              * rendering/RenderTheme.h:
              * rendering/RenderThemeMac.h:
              * rendering/RenderThemeMac.mm:
              (WebCore::getSystemColor):
              (WebCore::RenderThemeMac::platformColorsDidChange):
              (WebCore::RenderThemeMac::systemColor):
      
      LayoutTests:
      
              Reviewed by Darin.
              
              http://bugs.webkit.org/show_bug.cgi?id=6129
              Incomplete implementation of CSS 2.1 system colors
              
              Add layout test for this bug and update tests for new system-derived colors
      
              * fast/css/css2-system-color.html: Added.
              * platform/mac/fast/css/css2-system-color-expected.checksum: Added.
              * platform/mac/fast/css/css2-system-color-expected.png: Added.
              * platform/mac/fast/css/css2-system-color-expected.txt: Added.
              * platform/mac/fast/css/css2-system-fonts-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug103533-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0053725e
    • mitz@apple.com's avatar
      WebCore: · 401574d1
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=16426
                Divs with overflow:auto: scrollbars not correctly updated when contents change
      
              Test: fast/overflow/scrollbar-position-update.html
      
              * platform/mac/PlatformScrollBarMac.mm:
              (WebCore::PlatformScrollbar::updateThumbProportion): Update the
              NSScroller's value for the new proportions.
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::updateScrollInfoAfterLayout): Removed unnecessary
              repaint(). Scrollbars repaint themselves as needed.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=16426
                Divs with overflow:auto: scrollbars not correctly updated when contents change
      
              * fast/overflow/scrollbar-position-update.html: Added.
              * platform/mac-leopard/fast/overflow: Added.
              * platform/mac-leopard/fast/overflow/scrollbar-position-update-expected.checksum: Added.
              * platform/mac-leopard/fast/overflow/scrollbar-position-update-expected.png: Added.
              * platform/mac/fast/overflow/scrollbar-position-update-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28774 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      401574d1
    • darin@apple.com's avatar
      - try to fix the build · ad17aeb8
      darin@apple.com authored
              * WebView.cpp:
              (wxWebView::OnKeyEvents): Add a WebCore prefix.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28773 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad17aeb8
    • ap@webkit.org's avatar
      Reviewed by Darin. · 2a62d72f
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=14140
              <rdar://problem/5270958> REGRESSION: Complex system KeyBindings don't work properly
      
      WebCore:
              * dom/KeyboardEvent.h:
              (WebCore::KeypressCommand::KeypressCommand):
              (WebCore::KeyboardEvent::keypressCommands):
              Change stored command class to preserve complete information about commands.
      
              * editing/EditorCommand.cpp: (WebCore::CommandEntry::): Mark InsertText as a text insertion
              command, which it is. Previously, we couldn't do it because WebKit didn't really treat insertText:
              as a command.
      
              * page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Copy commands saved while interpreting
              a keydown event into keypress, to avoid losing state when running interpretKeyEvents: again.
      
      WebKit:
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): Made command replaying work
              when handling keypress, too.
              (-[WebHTMLView doCommandBySelector:]): Adapted for the new way to store commands in events.
              (-[WebHTMLView insertText:]): Append a command, not replace the whole existing vector. Also,
              restore the state for additional commands to be saved correctly.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28772 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a62d72f
    • ap@webkit.org's avatar
      Reviewed by Darin. · 9dd32eaa
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=16162
              Problems with float parsing on Linux (locale-dependent parsing was used).
      
              * kjs/dtoa.cpp: Removed USE_LOCALE to reduce future confusion.
              * kjs/lexer.cpp: (KJS::Lexer::lex): Parse with kjs_strtod, not the system one.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28771 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9dd32eaa
    • ap@webkit.org's avatar
      Reviewed by Darin. · 6611b3d5
      ap@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=16462
              REGRESSION: access keys broken on Windows
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28770 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6611b3d5
    • alp@webkit.org's avatar
      2007-12-16 Xan Lopez <xan@gnome.org> · e6e9606d
      alp@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              http://bugs.webkit.org/show_bug.cgi?id=16454
              [GTK] Text input doesn't work consistently on PPC
      
              * platform/gtk/KeyEventGtk.cpp:
              (WebCore::singleCharacterString):
      
              UChar is 2 bytes (UTF-16), so transform accordingly from
              gunichar (UCS-4). Fixes keyboard input on big endian systems.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28769 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6e9606d
  2. 15 Dec, 2007 18 commits