1. 18 Feb, 2007 1 commit
  2. 17 Feb, 2007 12 commits
    • hyatt's avatar
      Fix textarea resizers to not fill with black by making sure the fill color starts off as · 7f6829ee
      hyatt authored
              transparent instead of black.
      
              Reviewed by aroben
      
              * platform/graphics/GraphicsContext.cpp:
              (WebCore::GraphicsContextState::GraphicsContextState):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f6829ee
    • aroben's avatar
      Added missing Radar references to ChangeLogs. · a90311f4
      aroben authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a90311f4
    • aroben's avatar
      2007-02-17 Lars Knoll <lars@trolltech.com> · ed43c0aa
      aroben authored
      LayoutTests:
      
              Reviewed by Adam.
      
              test for http://bugs.webkit.org/show_bug.cgi?id=11476
              <img> tags nested inside <map> where not showing up
      
              * fast/images/image-in-map-expected.checksum: Added.
              * fast/images/image-in-map-expected.png: Added.
              * fast/images/image-in-map-expected.txt: Added.
              * fast/images/image-in-map.html: Added.
      
      WebCore:
      
              Reviewed by Adam.
      
              fix http://bugs.webkit.org/show_bug.cgi?id=11476
              <img> tags nested inside <map> where not showing up
      
              Test: fast/images/image-in-map.html
      
              * html/HTMLMapElement.cpp:
              (WebCore::HTMLMapElement::checkDTD):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed43c0aa
    • weinig's avatar
      LayoutTests: · e2750b3c
      weinig authored
              Reviewed by Maciej.
      
              http://bugs.webkit.org/show_bug.cgi?id=12733
              XPath namespace is attached to a wrong step
      
              * fast/xpath/namespace-vs-predicate-expected.txt: Added.
              * fast/xpath/namespace-vs-predicate.xhtml: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              http://bugs.webkit.org/show_bug.cgi?id=12733
              XPath namespace is attached to a wrong step
      
              * xml/XPathGrammar.y: NAMETEST is different from other NodeTests in that its
              resulting type is an expanded name, rather than a string. It is not really possible 
              to store the namespace inside Parser, because it gets used in wrong steps then.
      
              * xml/XPathParser.cpp:
              (WebCore::XPath::Parser::expandQName):
              * xml/XPathParser.h:
              Moved code that expands a QName from XPathGrammar.y. Removed m_currentNamespaceURI.
      
              * xml/XPathStep.cpp:
              (WebCore::XPath::Step::Step):
              * xml/XPathStep.h:
              Added a constructor that takes a namespace.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2750b3c
    • adele's avatar
      LayoutTests: · 24f01150
      adele authored
              Reviewed by Maciej.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=12479
                ASSERTION FAILURE: resource->inCache() in WebCore::Cache::remove
      
              * fast/loader/resources/simultaneous-reloads-assert-frame.html: Added.
              * fast/loader/simultaneous-reloads-assert-expected.txt: Added.
              * fast/loader/simultaneous-reloads-assert.html: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12479
                ASSERTION FAILURE: resource->inCache() in WebCore::Cache::remove
      
              Test: fast/loader/simultaneous-reloads-assert.html
      
              * loader/Cache.cpp:
              (WebCore::Cache::remove): Replaced the assertion with a check whether the
              resource is in the cache. The resource could have been removed from the cache
              as a result of a reload occurring simultaneously in a different document.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24f01150
    • adele's avatar
      Reviewed by Adam. · 44dd43b3
      adele authored
              Fix for http://bugs.webkit.org/show_bug.cgi?id=12711
              Prettier and more distinct cursors
      
              * Resources/crossHairCursor.png: Added.
              * Resources/northEastSouthWestResizeCursor.png:
              * Resources/northWestSouthEastResizeCursor.png:
              * Resources/notAllowedCursor.png: Added.
              * page/EventHandler.cpp: (WebCore::selectCursor):
              * platform/Cursor.h:
              * platform/mac/CursorMac.mm:
              (WebCore::crossCursor):
              (WebCore::notAllowedCursor):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44dd43b3
    • adele's avatar
      LayoutTests: · 8c494ab4
      adele authored
              Reviewed by Darin.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=12780
                REGRESSION (r19341-r19385): Reproducible crash in "onselectstart" event
      
              * fast/events/shadow-boundary-crossing-expected.txt: Added.
              * fast/events/shadow-boundary-crossing.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12780
                REGRESSION (r19341-r19385): Reproducible crash in "onselectstart" event
      
              Test: fast/events/shadow-boundary-crossing.html
      
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchGenericEvent): Changed to use the new
              eventParentNode() function for constructing the chain of ancestors for
              capture and bubbling.
              * dom/Node.h:
              (WebCore::Node::eventParentNode): Added. Returns the node's parent for the
              purpose of of event capture and bubbling. The base class implementation is
              to return the parent node.
              * ksvg2/svg/SVGElement.h:
              (WebCore::SVGElement::eventParentNode): Added. Since in SVG events bubble
              to and can be captured across the shadow DOM boundary, returns the shadow parent
              for shadow nodes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c494ab4
    • hyatt's avatar
      Improve textarea resizer painting. · 82c49cb6
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82c49cb6
    • kjk's avatar
      JavaScriptCore: · 67f5d5a8
      kjk authored
              Reviewed by Adam Roben.
      
              Fix crashes on ARM due to different struct packing. Based on a patch
              by Mike Emmel.
              * kjs/ustring.cpp: compile-time assert to make sure sizeof(UChar) == 2
              * kjs/ustring.h: pack UChar struct to ensure that sizeof(UChar) == 2
              * wtf/Assertions.h: add COMPILE_ASSERT macro for compile-time assertions
      
        WebCore:
      
              Reviewed by Adam Roben.
      
              Fix crashes on ARM due to different struct packing. Based on a patch
              from Mike Emmel.
      
              * platform/DeprecatedString.cpp: compile-time assert to make sure sizeof(DeprecatedChar) == 2
              * platform/DeprecatedString.h: pack DeprecatedChar struct to ensure that
              sizeof(DeprecatedChar) == 2. Move _internalBuffer in DeprecatedStringData
              to the end, to avoid crashes on ARM due to different struct packing.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67f5d5a8
    • adele's avatar
      LayoutTests: · 81f23c3f
      adele authored
              Reviewed by Mitz.
      
              Fix for http://bugs.webkit.org/show_bug.cgi?id=11534
              <rdar://problem/4946947> REGRESSION: Readonly text fields don't scroll when selecting content
      
              * fast/forms/input-readonly-autoscroll-expected.checksum: Added.
              * fast/forms/input-readonly-autoscroll-expected.png: Added.
              * fast/forms/input-readonly-autoscroll-expected.txt: Added.
              * fast/forms/input-readonly-autoscroll.html: Added.
      
      WebCore:
      
              Reviewed by Mitz.
      
              Fix for http://bugs.webkit.org/show_bug.cgi?id=11534
              <rdar://problem/4946947> REGRESSION: Readonly text fields don't scroll when selecting content
      
              Test: fast/forms/input-readonly-autoscroll.html
      
              Implemented autoscroll methods for RenderTextControl, so this works on non-editable text controls.
      
              * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::autoscroll):
              * rendering/RenderTextControl.h: (WebCore::RenderTextControl::shouldAutoscroll):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81f23c3f
    • kjk's avatar
      Reviewed by Adam Roben. · 487ce430
      kjk authored
              Curl networking improvements inspired by Mike Emmel's patches in
              http://bugs.webkit.org/show_bug.cgi?id=11332.
              Fix FrameLoaderClientGdk due to changed FrameLoaderClient API.
      
              * loader/gdk/FrameLoaderClientGdk.cpp: Massage for changed API.
              (WebCore::FrameLoaderClientGdk::saveViewStateToItem):
              (WebCore::FrameLoaderClientGdk::restoreViewState):
              (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme):
              (WebCore::FrameLoaderClientGdk::willUseArchive):
              * loader/gdk/FrameLoaderClientGdk.h: Ditto.
              * platform/network/ResourceHandleInternal.h: Remember url and custom headers
              for the request lifetime and free them at the end.
              (WebCore::ResourceHandleInternal::ResourceHandleInternal):
              * platform/network/gdk/ResourceHandleCurl.cpp: Ditto.
              (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
              * platform/network/gdk/ResourceHandleManager.cpp: url improvements:
              - remove m_useSimple code-path since it wasn't used anywhere
              - don't use hashmap for keeping track of outstanding jobs - curl does it anyway
              - set custom headers from request
              - enable gzip and deflate through Accept-Encoding
              - setup curl to share cookies and DNS cache between requests
              - enable persisting of cookies in a file (if client provides file name
                for cookies via ResourceHandleManager::setCookieJarFileName())
              (WebCore::ResourceHandleManager::ResourceHandleManager):
              (WebCore::ResourceHandleManager::setCookieJarFileName):
              (WebCore::ResourceHandleManager::downloadTimerCallback):
              (WebCore::ResourceHandleManager::removeFromCurl):
              (WebCore::ResourceHandleManager::setupPUT):
              (WebCore::ResourceHandleManager::setupPOST):
              (WebCore::ResourceHandleManager::add):
              (WebCore::ResourceHandleManager::cancel):
              * platform/network/gdk/ResourceHandleManager.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      487ce430
    • kjk's avatar
      Reviewed by Adam Roben. · d6ae6006
      kjk authored
              Gdk fixes.
      
              * page/gdk/EventHandlerGdk.cpp: Comment out chatty message.
              (WebCore::EventHandler::handleDrag):
              * platform/gdk/EditorClientGdk.cpp: Enable entering text into text field.
              (WebCore::EditorClientGdk::shouldInsertText):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6ae6006
  3. 16 Feb, 2007 12 commits
    • kjk's avatar
      Reviewed by Adam Roben. · 7c46dde8
      kjk authored
              Move Path implementation from TemporaryLinkStubs.cpp to
              its own file.
              Implement setLineCap, setLineJoin and setMiterLimit for
              cairo's GraphicsContext.
      
              * WebCoreSources.bkl:
              * platform/gdk/TemporaryLinkStubs.cpp:
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::setPlatformFillColor):
              (WebCore::GraphicsContext::setPlatformStrokeColor):
              (WebCore::GraphicsContext::setLineCap):
              (WebCore::GraphicsContext::setLineJoin):
              (WebCore::GraphicsContext::setMiterLimit):
              * platform/graphics/cairo/PathCairo.cpp: Added.
              (WebCore::Path::Path):
              (WebCore::Path::~Path):
              (WebCore::Path::contains):
              (WebCore::Path::translate):
              (WebCore::Path::boundingRect):
              (WebCore::Path::operator=):
              (WebCore::Path::clear):
              (WebCore::Path::moveTo):
              (WebCore::Path::addLineTo):
              (WebCore::Path::addQuadCurveTo):
              (WebCore::Path::addBezierCurveTo):
              (WebCore::Path::addArcTo):
              (WebCore::Path::closeSubpath):
              (WebCore::Path::addArc):
              (WebCore::Path::addRect):
              (WebCore::Path::addEllipse):
              (WebCore::Path::transform):
              (WebCore::Path::apply):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c46dde8
    • staikos's avatar
      Fix uninitialized variable · 8740848d
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8740848d
    • adachan's avatar
      2007-02-16 Ada Chan <adachan@apple.com> · 73b2a5c4
      adachan authored
              Reviewed by Adam and Maciej.
      
              Use a RefPtr to store the old hover node.
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::updateHoverActiveState):
              
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73b2a5c4
    • darin's avatar
      Reviewed by Adele. · 3f6601d2
      darin authored
              - fix <rdar://problem/4990864> ASSERT in FormDelegate.m while dragging text between frames
      
              This symptom is specific to Safari, so no layout test.
      
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::doApply): Only call textWillBeDeletedInTextField if the
              text field is focused.
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::aboutToUnload): Only call textFieldDidEndEditing if the text
              field is focused.
              (WebCore::HTMLInputElement::dispatchBlurEvent): Remove unneeded type cast.
              (WebCore::HTMLInputElement::defaultEventHandler): Only call doTextFieldCommandFromEvent if
              the text field is focused.
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::subtreeHasChanged): Only call textDidChangeInTextArea,
              textFieldDidBeginEditing, and textDidChangeInTextField if the element is focused.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f6601d2
    • hyatt's avatar
      API tweaks to widget and scrollview. · 6e8650da
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e8650da
    • sullivan's avatar
      Reviewed by Tim Hatcher · 23550278
      sullivan authored
              - fixed <rdar://problem/4811446> "Check Grammar" checkbox in Spelling+Grammar window doesn't 
              live update with menu change in WebKit
      
              * WebView/WebView.mm:
              (-[WebView setGrammarCheckingEnabled:]):
              Use sekrit AppKit knowledge to tell NSSpellChecker about the change, since there's no API
              for this yet. Also restructured a little to avoid extra work when the value hasn't changed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23550278
    • andersca's avatar
      Reviewed by Adam. · 687e2539
      andersca authored
              <rdar://problem/4943985> 
              REGRESSION: Dragging standalone images to Finder fails to download the image file
              
              Set the data and response on the image resource. Also, since this is platform-independent we don't need to do it in 
              ImageDocumentMac.mm
              
              * loader/ImageDocument.cpp:
              (WebCore::ImageTokenizer::finish):
              * loader/mac/ImageDocumentMac.h:
              * loader/mac/ImageDocumentMac.mm:
              (WebCore::finishImageLoad):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      687e2539
    • darin's avatar
      Reviewed by Anders. · fa0c87f8
      darin authored
              - fix <rdar://problem/5000216> JavaScriptGlue framework started turning all CFNumbers
                into signed 32bit values
      
              Circumstantial evidence seems to indicate that JavaScriptGlue was depending on a bug
              in CFNumber where CFNumberIsFloatType was returning true for 64-bit integer values.
      
              * JSUtils.cpp: (JSObjectKJSValue): Removed the call to CFNumberIsFloatType in the
              conversion of numeric values, and always use kCFNumberDoubleType, since double is
              the internal format of numbers in JavaScriptCore. There's no value to having a
              separate code path for integers. There's also no reason to check the return value
              from CFNumberGetValue -- if it returns false it still does the best it can to convert
              to a double, which is what we want.
      
              * UserObjectImp.cpp: (UserObjectImp::toString): Removed a similar code path that
              tried to handle integers separate from double. Instead, always use a double. For
              compatibility, use a format without a decimal point when CFNumberIsFloatType returns
              false. Also removed a bogus cast to float; the "%f" format string takes a double,
              not a float, so all the cast did was cut down on precision.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa0c87f8
    • harrison's avatar
      Reviewed by Adam. · 8d8f0eb5
      harrison authored
              <rdar://problem/5004746> Need mechanism to protect against WebKit calls from secondary threads (DOM APIs)
      
              * platform/mac/LoggingMac.mm:
              (WebCore::_WebCoreThreadViolationCheck):
              Change the default to log the violations.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d8f0eb5
    • adele's avatar
      Reviewed by Mitz. · aafff2d6
      adele authored
              Fixed: http://bugs.webkit.org/show_bug.cgi?id=12768
              <rdar://problem/4995250> REGRESSION: Crash occurs at WebCore::RenderLayer::scrollToOffset() when leaving page that has focus in field
      
              No test case added.  This crash doesn't occur in DumpRenderTree because the B/F cache is turned off.
      
              * dom/Node.cpp: (WebCore::Node::willRemove): Check that the document is not in the page cache before 
      
              * dom/Element.cpp: (WebCore::Element::updateFocusAppearance): Added restorePreviousSelection argument, with appropriate default values.
              * dom/Element.h: ditto.
              * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateFocusAppearance): ditto.
              * html/HTMLInputElement.h: ditto.
              * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateFocusAppearance): ditto.
              * html/HTMLTextAreaElement.h: ditto.
      
              * page/PageState.cpp: (WebCore::PageState::restore): Call updateFocusAppearance on the focused node for this page.  Pass true for the
                restorePreviousSelection argument.
      
              * rendering/RenderLayer.cpp: Added ASSERTS and nil checks on the RenderView.  It shouldn't be null, but if it is, 
                we'll fail silently on release builds.
              (WebCore::RenderLayer::updateLayerPositions):
              (WebCore::RenderLayer::scrollToOffset):
              (WebCore::RenderLayer::windowClipRect):
              (WebCore::RenderLayer::calculateClipRects):
              (WebCore::RenderLayer::calculateRects):
              (WebCore::RenderLayer::intersectsDamageRect):
              (WebCore::RenderLayer::absoluteBoundingBox):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aafff2d6
    • andersca's avatar
      Reviewed by Mitz. · d329ced0
      andersca authored
              http://bugs.webkit.org/show_bug.cgi?id=12788
              REGRESSION: Going back one page in history has a noticeable delay
              
              Um...if all elements in two vectors are equal, then I guess we could say that
              the two vectors are equal too.
              
              * wtf/Vector.h:
              (WTF::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d329ced0
    • andersca's avatar
      Reviewed by Darin. · ba53ca87
      andersca authored
              <rdar://problem/4993055> auto_refcount_underflow_error: WebCore::FrameLoader::continueAfterNavigationPolicy () over-releases under GC
      
              Add ::adoptNS and ::adoptCF methods to RetainPtr to indicate what type of reference to adopt.
              
              * platform/cf/RetainPtr.h:
              (WebCore::):
              (WebCore::adoptNSReference):
              (WebCore::RetainPtr::RetainPtr):
              (WebCore::::adoptCF):
              (WebCore::::adoptNS):
              * platform/mac/FileChooserMac.mm:
              (WebCore::FileChooser::FileChooser):
              * platform/network/mac/ResourceErrorMac.mm:
              (WebCore::ResourceError::operator NSError*):
              * platform/network/mac/ResourceRequestMac.mm:
              (WebCore::ResourceRequest::doUpdatePlatformRequest):
              * platform/network/mac/ResourceResponseMac.mm:
              (WebCore::ResourceResponse::nsURLResponse):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba53ca87
  4. 15 Feb, 2007 15 commits
    • beidson's avatar
      Reviewed by Lost Objective-C Hippyness (or hippiness) · 0b92ab03
      beidson authored
              Oh boy, did I ever botch this one up...
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): Null check the FrameView
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b92ab03
    • beidson's avatar
      Reviewed by Adam's complaint · 64b69d80
      beidson authored
              aroben wanted me to do an early return, instead.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64b69d80
    • beidson's avatar
      Reviewed by Adele · 5b084168
      beidson authored
              Forgot to bring the null check with me when I backed this code out of 
              the FrameLoaderClient
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): null check the HistoryItem
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b084168
    • beidson's avatar
      WebCore: · aa9510fd
      beidson authored
              Reviewed by Adam
      
              Save scroll state for back/forward navigation in FrameLoader, not the client
      
             * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): Actually save the scroll position
               here instead of asking the FrameLoaderClient
              (WebCore::FrameLoader::restoreScrollPositionAndViewState): Ditto
      
              * loader/FrameLoaderClient.h: Renamed/repurposed 2 methods
      
              * platform/graphics/svg/SVGImageEmptyClients.h:
              (WebCore::SVGEmptyFrameLoaderClient::restoreViewState): Ditto
              (WebCore::SVGEmptyFrameLoaderClient::saveViewStateToItem): Ditto
      
      WebKit:
      
              Reviewed by Adam
      
              Save scroll state for back/forward navigation in FrameLoader, not the client
      
              * WebCoreSupport/WebFrameLoaderClient.h: Renamed the save/restore methods
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::saveViewStateToItem): Save viewstate only
              (WebFrameLoaderClient::restoreViewState): Restore viewstate only
      
      WebKitQt:
      
              Reviewed by Adam
      
              Moved scroll state down into the cross platform FrameLoader - 
              Blind attempt at keeping Qt building
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::restoreViewState):
              (WebCore::FrameLoaderClientQt::saveViewStateToItem):
              * WebCoreSupport/FrameLoaderClientQt.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa9510fd
    • bdash's avatar
      2007-02-16 Mark Rowe <mrowe@apple.com> · 2c96ed0b
      bdash authored
              Not reviewed.
      
              <rdar://problem/4982312> leaks bot should run in normal mode, rather than quiet mode
      
              * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Switch back to default verbosity for output of leaks tests.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c96ed0b
    • justing's avatar
      LayoutTests: · 9634eb54
      justing authored
              Reviewed by harrison
              
              <rdar://problem/4989774>
              REGRESSION: Pasting a image into a plain text message can place image on a new line
      
              Added:
              * editing/pasteboard/4989774-expected.checksum: Added.
              * editing/pasteboard/4989774-expected.png: Added.
              * editing/pasteboard/4989774-expected.txt: Added.
              * editing/pasteboard/4989774.html: Added.
              Equivalent trees:
              * editing/deleting/delete-3857753-fix-expected.txt:
              * editing/pasteboard/paste-list-001-expected.txt:
              * editing/pasteboard/paste-table-001-expected.txt:
              * editing/pasteboard/paste-text-001-expected.txt:
              * editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
              * editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
              * editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
      
      WebCore:
      
              Reviewed by harrison
              
              <rdar://problem/4989774>
              REGRESSION: Pasting a image into a plain text message can place image on a new line
      
              <span><img><span><img></span></span> will appear as two
              images on different lines because of a layout/rendering
              bug.  This patch avoids the bug by producing cleaner
              markup so that the paste code can safely remove the style 
              spans.
      
              * editing/markup.cpp:
              (WebCore::createMarkup): Get the default style from the
              editable root or body instead of the document element.
              This produces cleaner markup since we don't inline the 
              root's styles.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9634eb54
    • kjk's avatar
      Reviewed by Adam Roben. · 89b3cb48
      kjk authored
              Add gdk version of ContextMenuClient based on qt version.
      
              * WebCoreSources.bkl:
              * page/gdk/ContextMenuClientGdk.cpp: Added.
              (WebCore::ContextMenuClientGdk::contextMenuDestroyed):
              (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems):
              (WebCore::ContextMenuClientGdk::contextMenuItemSelected):
              (WebCore::ContextMenuClientGdk::downloadURL):
              (WebCore::ContextMenuClientGdk::copyImageToClipboard):
              (WebCore::ContextMenuClientGdk::searchWithGoogle):
              (WebCore::ContextMenuClientGdk::lookUpInDictionary):
              (WebCore::ContextMenuClientGdk::speak):
              (WebCore::ContextMenuClientGdk::stopSpeaking):
              * page/gdk/ContextMenuClientGdk.h: Added.
              * webcore-base.bkl: curl is needed when building webcore_base files.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89b3cb48
    • kdecker's avatar
      · 391c73c5
      kdecker authored
             Reviewed by Darin.
      
             Fixed: <rdar://problem/4983883> Background of a .mov window should not be white
      
             * loader/PluginDocument.cpp: 
             (WebCore::PluginTokenizer::createDocumentStructure): Set a background color of gray
             for full frame plug-ins, which makes it easier on the eyes. It's also the same 
             gray that PDFKit uses, too.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      391c73c5
    • weinig's avatar
      Reviewed by Darin. · 9dd188ed
      weinig authored
              - fix http://bugs.webkit.org/show_bug.cgi?id=12625
                REGRESSION: Crash when closing the web inspector with text selected
      
              The problem was that selectionRect() was being called on a render tree that
              had pending style changes. The changes were committed as a side effect in
              the middle of traversing the render tree, and the current object got
              deleted as a result. The solution is to update the render tree before
              starting to traverse it.
      
              The inspector was affected because it makes style changes in response to
              an AppKit notification that's sent right before the windowDidResignKey:
              notification, under which WebKit calls selectionRect(). I couldn't recreate
              the same conditions (having uncommitted style changes in the tree when the
              window becomes inactive) using HTML/JS in Safari, hence the lack of
              a regression test to go with this patch.
      
              * rendering/RenderView.cpp:
              (WebCore::RenderView::selectionRect): Added call to updateRendering().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9dd188ed
    • weinig's avatar
      Reviewed by Darin. · 8668d3cc
      weinig authored
              - fix http://bugs.webkit.org/show_bug.cgi?id=10127
                REGRESSION: Crash undoing delete in textarea
      
              Document::removeMarkers() was using a Vector iterator (which is just a
              pointer) and inserting into the Vector at the same time, which made the
              iterator invalid as the Vector's data buffer was relocated.
              
              Replaced all instances of Vector<DocumentMarker>::iterator with indices.
      
              * dom/Document.cpp:
              (WebCore::Document::addMarker):
              (WebCore::Document::copyMarkers):
              (WebCore::Document::removeMarkers):
              (WebCore::Document::repaintMarkers):
              (WebCore::Document::shiftMarkers):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8668d3cc
    • darin's avatar
      * projects/performance/index.html: Fix i-Bench link. · 714678a0
      darin authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      714678a0
    • weinig's avatar
      LayoutTests: · 9695cd91
      weinig authored
              Reviewed by Darin.
      
              - updated results for http://bugs.webkit.org/show_bug.cgi?id=12777
                REGRESSION (r18574): User profile pages display incorrectly at ebay.ca
      
              * tables/mozilla/bugs/bug45486-expected.checksum:
              * tables/mozilla/bugs/bug45486-expected.png:
              * tables/mozilla/bugs/bug45486-expected.txt:
              * tables/mozilla_expected_failures/core/col_span2-expected.txt:
      
      WebCore:
      
              Reviewed by Darin.
      
              - http://bugs.webkit.org/show_bug.cgi?id=12777
                REGRESSION (r18574): User profile pages display incorrectly at ebay.ca
      
              Fixes existing layout tests: tables/mozilla/bugs/bug45486.html
                                           tables/mozilla_expected_failures/core/col_span2.html
      
              * rendering/AutoTableLayout.cpp:
              (WebCore::AutoTableLayout::calcEffectiveWidth): Fixed a mismatch between which
              columns count as percentage columns when adding up the total percent and
              which columns count as percentage columns when converting non-percentage
              columns to effectively-percentage.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9695cd91
    • ggaren's avatar
      Reviewed by Beth Dakin. · 71ae795a
      ggaren authored
              
              * DumpRenderTree/DumpRenderTree.m: Don't ignore NSAttributedString WebCore::Node
              leaks anymore, either, since r19486 fixed them, too.
              (shouldIgnoreWebCoreNodeLeaks):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71ae795a
    • darin's avatar
      * Scripts/run-webkit-tests: Don't ignore NSAttributedString leaks any more. Those were · fd443d60
      darin authored
              fixed by change 19486.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd443d60
    • ggaren's avatar
      Reviewed by Beth Dakin. · 7d1fbd5b
      ggaren authored
              
              Ignore another leak, seen recently on the buildbot.
      
              * Scripts/run-webkit-tests:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d1fbd5b