1. 27 Jul, 2011 13 commits
  2. 26 Jul, 2011 27 commits
    • commit-queue@webkit.org's avatar
      [chromium] REGRESSION(90963): Content layers are not redrawn after losing the compositor context · 033c3d3a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65224
      
      Patch by James Robinson <jamesr@chromium.org> on 2011-07-26
      Reviewed by Kenneth Russell.
      
      There's no automated way to test lost compositor contexts (yet), but to test manually open up the poster circle
      page and kill the GPU process.
      
      * platform/graphics/chromium/ContentLayerChromium.cpp:
      (WebCore::ContentLayerChromium::cleanupResources):
      * platform/graphics/chromium/ContentLayerChromium.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      033c3d3a
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r91805. · 9b07b189
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/91805
      https://bugs.webkit.org/show_bug.cgi?id=65226
      
      Breaks @ symbols and changes other font rendering on Windows
      (Requested by enne on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-26
      
      Source/WebCore:
      
      * platform/graphics/chromium/FontChromiumWin.cpp:
      (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::TransparencyAwareFontPainter):
      (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::init):
      (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::initializeForGDI):
      (WebCore::TransparencyAwareFontPainter::TransparencyAwareFontPainter::~TransparencyAwareFontPainter):
      (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::TransparencyAwareGlyphPainter):
      (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::~TransparencyAwareGlyphPainter):
      (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
      (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::hdc):
      (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::TransparencyAwareUniscribePainter):
      (WebCore::TransparencyAwareFontPainter::TransparencyAwareUniscribePainter::~TransparencyAwareUniscribePainter):
      (WebCore::drawGlyphsWin):
      (WebCore::Font::drawComplexText):
      * platform/graphics/chromium/UniscribeHelper.cpp:
      (WebCore::UniscribeHelper::draw):
      * platform/graphics/skia/PlatformContextSkia.cpp:
      (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
      * platform/graphics/skia/PlatformContextSkia.h:
      * platform/graphics/skia/SkiaFontWin.cpp:
      (WebCore::windowsCanHandleDrawTextShadow):
      (WebCore::windowsCanHandleTextDrawing):
      (WebCore::windowsCanHandleTextDrawingWithoutShadow):
      * platform/graphics/skia/SkiaFontWin.h:
      
      LayoutTests:
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b07b189
    • enne@google.com's avatar
      Unreviewed, rolling out r91812. · 553e9727
      enne@google.com authored
      http://trac.webkit.org/changeset/91812
      https://bugs.webkit.org/show_bug.cgi?id=65210
      
      Breaks OSX GPU tests.
      
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::drawLayers):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      553e9727
    • abarth@webkit.org's avatar
      Fix ChangeLog. · 27cd294a
      abarth@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91820 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27cd294a
    • abarth@webkit.org's avatar
      enne tells me that she already rebaselined this test. The 10.5 bot is · 6b2ada6a
      abarth@webkit.org authored
      just behind because dglazkov broke NRWT on Python 2.5.
      
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b2ada6a
    • abarth@webkit.org's avatar
      Switch to an older idiom that works on Python 2.5. · 4185a546
      abarth@webkit.org authored
      * Scripts/webkitpy/layout_tests/models/test_configuration.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91818 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4185a546
    • commit-queue@webkit.org's avatar
      JSC command-line tool does not come with any facility for · fb6118b1
      commit-queue@webkit.org authored
      measuring time precisely.
      https://bugs.webkit.org/show_bug.cgi?id=65223
      
      Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-26
      Reviewed by Gavin Barraclough.
      
      Exposed WTF::currentTime() as currentTimePrecise().
      
      * jsc.cpp:
      (GlobalObject::GlobalObject):
      (functionPreciseTime):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91817 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb6118b1
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r91809. · c7e3fed0
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/91809
      https://bugs.webkit.org/show_bug.cgi?id=65225
      
      Does not build on Chromium Windows (Requested by abarth on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-26
      
      Source/WebCore:
      
      * dom/WheelEvent.cpp:
      (WebCore::WheelEvent::WheelEvent):
      (WebCore::WheelEvent::initWheelEvent):
      * dom/WheelEvent.h:
      * page/EventHandler.cpp:
      (WebCore::EventHandler::EventHandler):
      (WebCore::EventHandler::handleGestureEvent):
      (WebCore::EventHandler::handleTouchEvent):
      (WebCore::EventHandler::resetGestureRecognizer):
      * page/EventHandler.h:
      * page/FrameView.cpp:
      (WebCore::FrameView::reset):
      * platform/PlatformGestureEvent.h:
      * platform/PlatformGestureRecognizer.h:
      * platform/chromium/FramelessScrollView.h:
      * platform/chromium/GestureRecognizerChromium.cpp:
      (WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
      (WebCore::InnerGestureRecognizer::reset):
      (WebCore::InnerGestureRecognizer::dispatchSyntheticClick):
      (WebCore::InnerGestureRecognizer::processTouchEventForGesture):
      (WebCore::InnerGestureRecognizer::scrollViaTouchMotion):
      (WebCore::touchDown):
      (WebCore::noGesture):
      (WebCore::click):
      (WebCore::isClickOrScroll):
      (WebCore::inScroll):
      * platform/chromium/GestureRecognizerChromium.h:
      (WebCore::GestureRecognizerChromium::reset):
      (WebCore::GestureRecognizerChromium::processTouchEventForGesture):
      * platform/chromium/PopupMenuChromium.cpp:
      * platform/chromium/PopupMenuChromium.h:
      * platform/mac/ScrollAnimatorMac.mm:
      (WebCore::ScrollAnimatorMac::handleGestureEvent):
      
      Source/WebKit/chromium:
      
      * features.gypi:
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::createFrameView):
      * src/WebPopupMenuImpl.cpp:
      (WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
      (WebKit::WebPopupMenuImpl::handleInputEvent):
      * src/WebPopupMenuImpl.h:
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::WebViewImpl):
      (WebKit::WebViewImpl::touchEvent):
      * src/WebViewImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7e3fed0
    • gyuyoung.kim@samsung.com's avatar
      [EFL] Fix pointer operator coding style in ewk_view. · 0e263b44
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=65163
      
      Move '*' operator to variable according to efl coding style. In addition,
      add a space between * and variable in type casting.
      
      Reviewed by Kent Tamura.
      
      * ewk/ewk_view.cpp:
      (_ewk_view_smart_changed):
      (_ewk_view_repaints_resize):
      (_ewk_view_repaint_add):
      (_ewk_view_repaints_flush):
      (_ewk_view_scrolls_resize):
      (_ewk_view_scroll_add):
      (_ewk_view_scrolls_flush):
      (_ewk_view_smart_focus_in):
      (_ewk_view_smart_focus_out):
      (_ewk_view_smart_mouse_wheel):
      (_ewk_view_smart_mouse_down):
      (_ewk_view_smart_mouse_up):
      (_ewk_view_smart_mouse_move):
      (_ewk_view_smart_key_down):
      (_ewk_view_smart_key_up):
      (_ewk_view_smart_add_console_message):
      (_ewk_view_smart_run_javascript_alert):
      (_ewk_view_smart_run_javascript_confirm):
      (_ewk_view_smart_should_interrupt_javascript):
      (_ewk_view_smart_run_javascript_prompt):
      (_ewk_view_on_focus_in):
      (_ewk_view_on_focus_out):
      (_ewk_view_on_mouse_wheel):
      (_ewk_view_on_mouse_down):
      (_ewk_view_on_mouse_up):
      (_ewk_view_on_mouse_move):
      (_ewk_view_on_key_down):
      (_ewk_view_on_key_up):
      (_ewk_view_core_frame_new):
      (_ewk_view_priv_new):
      (_ewk_view_priv_del):
      (_ewk_view_smart_add):
      (_ewk_view_smart_del):
      (_ewk_view_smart_resize):
      (_ewk_view_smart_move):
      (_ewk_view_smart_calculate):
      (_ewk_view_smart_contents_resize):
      (_ewk_view_smart_zoom_set):
      (_ewk_view_smart_flush):
      (_ewk_view_smart_pre_render_region):
      (_ewk_view_smart_pre_render_relative_radius):
      (_ewk_view_smart_pre_render_cancel):
      (_ewk_view_zoom_animated_mark_stop):
      (_ewk_view_zoom_animated_finish):
      (_ewk_view_zoom_animated_current):
      (_ewk_view_zoom_animator_cb):
      (_ewk_view_zoom_animation_start):
      (_ewk_view_viewport_attributes_compute):
      (ewk_view_base_smart_set):
      (ewk_view_fixed_layout_size_set):
      (ewk_view_fixed_layout_size_get):
      (ewk_view_theme_set):
      (ewk_view_theme_get):
      (ewk_view_frame_main_get):
      (ewk_view_frame_focused_get):
      (ewk_view_uri_set):
      (ewk_view_uri_get):
      (ewk_view_title_get):
      (ewk_view_editable_get):
      (ewk_view_bg_color_set):
      (ewk_view_bg_color_get):
      (ewk_view_text_search):
      (ewk_view_text_matches_mark):
      (ewk_view_text_matches_unmark_all):
      (ewk_view_text_matches_highlight_set):
      (ewk_view_text_matches_highlight_get):
      (ewk_view_editable_set):
      (ewk_view_selection_get):
      (_ewk_view_editor_command):
      (ewk_view_execute_editor_command):
      (ewk_view_context_menu_forward_event):
      (ewk_view_load_progress_get):
      (ewk_view_stop):
      (ewk_view_reload):
      (ewk_view_reload_full):
      (ewk_view_back):
      (ewk_view_forward):
      (ewk_view_navigate):
      (ewk_view_back_possible):
      (ewk_view_forward_possible):
      (ewk_view_navigate_possible):
      (ewk_view_history_enable_get):
      (ewk_view_history_enable_set):
      (ewk_view_history_get):
      (ewk_view_zoom_get):
      (ewk_view_zoom_set):
      (ewk_view_zoom_weak_smooth_scale_get):
      (ewk_view_zoom_weak_smooth_scale_set):
      (ewk_view_zoom_weak_set):
      (ewk_view_zoom_animated_mark_start):
      (ewk_view_zoom_animated_mark_end):
      (ewk_view_zoom_animated_mark_current):
      (ewk_view_zoom_animated_mark_stop):
      (ewk_view_zoom_animated_set):
      (ewk_view_zoom_text_only_get):
      (ewk_view_zoom_text_only_set):
      (ewk_view_pre_render_region):
      (ewk_view_pre_render_relative_radius):
      (ewk_view_pre_render_cancel):
      (ewk_view_setting_user_agent_get):
      (ewk_view_setting_user_agent_set):
      (ewk_view_setting_user_stylesheet_get):
      (ewk_view_setting_user_stylesheet_set):
      (ewk_view_setting_auto_load_images_get):
      (ewk_view_setting_auto_load_images_set):
      (ewk_view_setting_auto_shrink_images_get):
      (ewk_view_setting_auto_shrink_images_set):
      (ewk_view_setting_enable_auto_resize_window_get):
      (ewk_view_setting_enable_auto_resize_window_set):
      (ewk_view_setting_enable_scripts_get):
      (ewk_view_setting_enable_scripts_set):
      (ewk_view_setting_enable_plugins_get):
      (ewk_view_setting_enable_plugins_set):
      (ewk_view_setting_enable_frame_flattening_get):
      (ewk_view_setting_enable_frame_flattening_set):
      (ewk_view_setting_scripts_window_open_get):
      (ewk_view_setting_scripts_window_open_set):
      (ewk_view_setting_resizable_textareas_get):
      (ewk_view_setting_resizable_textareas_set):
      (ewk_view_setting_private_browsing_get):
      (ewk_view_setting_private_browsing_set):
      (ewk_view_setting_offline_app_cache_get):
      (ewk_view_setting_offline_app_cache_set):
      (ewk_view_setting_caret_browsing_get):
      (ewk_view_setting_caret_browsing_set):
      (ewk_view_setting_encoding_custom_get):
      (ewk_view_setting_encoding_custom_set):
      (ewk_view_setting_encoding_default_get):
      (ewk_view_setting_encoding_default_set):
      (ewk_view_setting_encoding_detector_set):
      (ewk_view_setting_encoding_detector_get):
      (ewk_view_setting_enable_developer_extras_get):
      (ewk_view_setting_enable_developer_extras_set):
      (ewk_view_setting_font_minimum_size_get):
      (ewk_view_setting_font_minimum_size_set):
      (ewk_view_setting_font_minimum_logical_size_get):
      (ewk_view_setting_font_minimum_logical_size_set):
      (ewk_view_setting_font_default_size_get):
      (ewk_view_setting_font_default_size_set):
      (ewk_view_setting_font_monospace_size_get):
      (ewk_view_setting_font_monospace_size_set):
      (ewk_view_setting_font_standard_get):
      (ewk_view_setting_font_standard_set):
      (ewk_view_setting_font_cursive_get):
      (ewk_view_setting_font_cursive_set):
      (ewk_view_setting_font_fantasy_get):
      (ewk_view_setting_font_fantasy_set):
      (ewk_view_setting_font_monospace_get):
      (ewk_view_setting_font_monospace_set):
      (ewk_view_setting_font_serif_get):
      (ewk_view_setting_font_serif_set):
      (ewk_view_setting_font_sans_serif_get):
      (ewk_view_setting_font_sans_serif_set):
      (ewk_view_setting_spatial_navigation_get):
      (ewk_view_setting_spatial_navigation_set):
      (ewk_view_setting_local_storage_get):
      (ewk_view_setting_local_storage_set):
      (ewk_view_setting_page_cache_get):
      (ewk_view_setting_page_cache_set):
      (ewk_view_setting_local_storage_database_path_get):
      (ewk_view_setting_local_storage_database_path_set):
      (ewk_view_smart_data_get):
      (ewk_view_repaints_get):
      (ewk_view_scroll_requests_get):
      (ewk_view_repaint_add):
      (ewk_view_layout_if_needed_recursive):
      (ewk_view_scrolls_process):
      (ewk_view_paint_context_new):
      (ewk_view_paint_context_free):
      (ewk_view_paint_context_save):
      (ewk_view_paint_context_restore):
      (ewk_view_paint_context_clip):
      (ewk_view_paint_context_paint):
      (ewk_view_paint_context_paint_contents):
      (ewk_view_paint_context_scale):
      (ewk_view_paint_context_translate):
      (ewk_view_paint):
      (ewk_view_paint_contents):
      (ewk_view_ready):
      (ewk_view_input_method_state_set):
      (ewk_view_title_set):
      (ewk_view_uri_changed):
      (ewk_view_load_started):
      (ewk_view_frame_main_load_started):
      (ewk_view_load_provisional):
      (ewk_view_load_show):
      (ewk_view_frame_main_cleared):
      (ewk_view_frame_main_icon_received):
      (ewk_view_load_finished):
      (ewk_view_load_error):
      (ewk_view_load_progress_changed):
      (ewk_view_restore_state):
      (ewk_view_window_create):
      (ewk_view_window_close):
      (ewk_view_mouse_link_hover_in):
      (ewk_view_mouse_link_hover_out):
      (ewk_view_toolbars_visible_set):
      (ewk_view_toolbars_visible_get):
      (ewk_view_statusbar_visible_set):
      (ewk_view_statusbar_visible_get):
      (ewk_view_statusbar_text_set):
      (ewk_view_scrollbars_visible_set):
      (ewk_view_scrollbars_visible_get):
      (ewk_view_menubar_visible_set):
      (ewk_view_menubar_visible_get):
      (ewk_view_tooltip_text_set):
      (ewk_view_add_console_message):
      (ewk_view_run_javascript_alert):
      (ewk_view_run_javascript_confirm):
      (ewk_view_run_javascript_prompt):
      (ewk_view_should_interrupt_javascript):
      (ewk_view_exceeded_database_quota):
      (ewk_view_run_open_panel):
      (ewk_view_repaint):
      (ewk_view_scroll):
      (ewk_view_core_page_get):
      (ewk_view_frame_create):
      (ewk_view_plugin_create):
      (ewk_view_popup_new):
      (ewk_view_popup_destroy):
      (ewk_view_popup_selected_set):
      (ewk_view_download_request):
      (ewk_view_viewport_attributes_set):
      (ewk_view_viewport_attributes_get):
      (ewk_view_zoom_range_set):
      (ewk_view_zoom_range_min_get):
      (ewk_view_zoom_range_max_get):
      (ewk_view_user_scalable_set):
      (ewk_view_user_scalable_get):
      (ewk_view_device_pixel_ratio_get):
      (ewk_view_navigation_policy_decision):
      (ewk_view_page_rect_get):
      (ewk_view_need_touch_events_set):
      (ewk_view_need_touch_events_get):
      (ewk_view_mode_set):
      (ewk_view_mode_get):
      (ewk_view_editor_client_selection_changed):
      * ewk/ewk_view.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e263b44
    • dslomov@google.com's avatar
      [V8][Chromium] Run workers in a separate v8::Isolate · 3a309686
      dslomov@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=65004
      This patch allocates a new v8::Isolate for every worker and enters it on worker thread.
      
      Reviewed by David Levin.
      
      Covered by existing chromium tests.
      
      * bindings/v8/DOMDataStore.cpp:
      (WebCore::DOMDataStore::DOMDataStore):
      (WebCore::DOMDataStore::~DOMDataStore):
      * bindings/v8/StaticDOMDataStore.cpp:
      (WebCore::StaticDOMDataStore::StaticDOMDataStore):
      (WebCore::StaticDOMDataStore::~StaticDOMDataStore):
      * bindings/v8/StaticDOMDataStore.h:
      * bindings/v8/V8Binding.h:
      (WebCore::V8BindingPerIsolateData::registerDOMDataStore):
      (WebCore::V8BindingPerIsolateData::unregisterDOMDataStore):
      * bindings/v8/V8DOMMap.cpp:
      (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
      (WebCore::DOMDataStoreHandle::~DOMDataStoreHandle):
      * bindings/v8/WorkerContextExecutionProxy.cpp:
      (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
      (WebCore::WorkerContextExecutionProxy::initV8):
      * bindings/v8/WorkerContextExecutionProxy.h:
      * bindings/v8/WorkerScriptController.cpp:
      (WebCore::WorkerScriptController::WorkerScriptController):
      (WebCore::WorkerScriptController::~WorkerScriptController):
      * bindings/v8/WorkerScriptController.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a309686
    • abarth@webkit.org's avatar
      This test appears to fail on Leopard only. · 00cfe517
      abarth@webkit.org authored
      * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00cfe517
    • jamesr@google.com's avatar
      [chromium] Avoid clearing the framebuffer when compositing in release builds · 08ad5b20
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=65210
      
      Reviewed by Kenneth Russell.
      
      We clear the default framebuffer to blue when compositing so it's
      easier to spot regions we miss. This is useful for debugging, but eats
      bandwidth unnecessarily in release builds.
      
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::drawLayers):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08ad5b20
    • jpfau@apple.com's avatar
      New XML tokenizer · 1e7227ca
      jpfau@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=64566
      
      Reviewed by Adam Barth.
      
      Add tokenizer for XML and tests in NewXMLDocumentParser for printing results of tokenization.
      
      * GNUmakefile.list.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * xml/parser/NewXMLDocumentParser.cpp:
      (WebCore::NewXMLDocumentParser::NewXMLDocumentParser):
      (WebCore::NewXMLDocumentParser::append):
      * xml/parser/NewXMLDocumentParser.h:
      * xml/parser/XMLToken.h:
      * xml/parser/XMLTokenizer.cpp: Added.
      (WebCore::XMLTokenizer::XMLTokenizer):
      (WebCore::::shouldSkipNullCharacters):
      (WebCore::XMLTokenizer::nextToken):
      (WebCore::XMLTokenizer::bufferCharacter):
      (WebCore::XMLTokenizer::parseError):
      * xml/parser/XMLTokenizer.h: Added.
      (WebCore::XMLTokenizer::create):
      (WebCore::XMLTokenizer::gotError):
      (WebCore::XMLTokenizer::shouldSkipNullCharacters):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e7227ca
    • gyuyoung.kim@samsung.com's avatar
      Add an exception to coding style check for EFL port. · 851bbe5a
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=65162
      
      Add an exception of whitespace/declaration for EFL port. Because,
      '*' operator is next to variable in EFL coding style.
      
      Reviewed by Kent Tamura.
      
      * Scripts/webkitpy/style/checker.py:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      851bbe5a
    • commit-queue@webkit.org's avatar
      [chromium] Layering violations in gesture recognizer · 0e94b756
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65044
      
      Patch by Robert Kroeger <rjkroege@chromium.org> on 2011-07-26
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Divided the gesture recognizer up to correct a layering
      violation by moving gesture implementation from it to
      EventHandler::handleGestureEvent so that the gesture recognizer
      could simply be an engine for generating gesture events from
      touch events.
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::EventHandler):
      Removed construction of gesture recognizer.
      (WebCore::EventHandler::handleGestureEvent):
      Extended for new gesture events added in this patch.
      (WebCore::EventHandler::handleTouchEvent):
      Removed call into gesture recognizer.
      * page/EventHandler.h:
      * page/FrameView.cpp:
      (WebCore::FrameView::reset):
      Removed code to reset gesture recognizer.
      * platform/PlatformGestureEvent.h:
      (WebCore::PlatformGestureEvent::PlatformGestureEvent):
      (WebCore::PlatformGestureEvent::deltaX):
      (WebCore::PlatformGestureEvent::deltaY):
      (WebCore::PlatformGestureEvent::shiftKey):
      (WebCore::PlatformGestureEvent::ctrlKey):
      (WebCore::PlatformGestureEvent::altKey):
      (WebCore::PlatformGestureEvent::metaKey):
      Added additional gesture types and parameters.
      * platform/PlatformGestureRecognizer.h:
      * platform/chromium/FramelessScrollView.h:
      Added support for displatching gesture and touch events.
      * platform/chromium/GestureRecognizerChromium.cpp:
      (WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
      (WebCore::InnerGestureRecognizer::reset):
      (WebCore::InnerGestureRecognizer::constructClickGestureEvent):
      (WebCore::InnerGestureRecognizer::processTouchEventForGestures):
      Removed all depedencies on EventHandler. Instead, create gesture
      events from touch event stream.
      (WebCore::InnerGestureRecognizer::constructScrollGesture):
      (WebCore::touchDown):
      (WebCore::noGesture):
      (WebCore::click):
      (WebCore::isClickOrScroll):
      (WebCore::inScroll):
      (WebCore::GestureRecognizerChromium::processTouchEventForGestures):
      (WebCore::GestureRecognizerChromium::reset):
      * platform/chromium/GestureRecognizerChromium.h:
      * platform/chromium/PopupMenuChromium.cpp:
      Added support to handle touch events and gesture events.
      (WebCore::PopupContainer::handleTouchEvent):
      (WebCore::PopupContainer::handleGestureEvent):
      (WebCore::PopupListBox::handleTouchEvent):
      (WebCore::PopupListBox::handleGestureEvent):
      * platform/chromium/PopupMenuChromium.h:
      * platform/mac/ScrollAnimatorMac.mm:
      (WebCore::ScrollAnimatorMac::handleGestureEvent):
      Ignores the newly added gesture event types.
      
      Source/WebKit/chromium:
      
      Moved gesture recognition higher up the event delivery code
      path so that recognition of gestures is completely separated
      from gesture handling.
      
      * features.gypi:
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::createFrameView):
      Added code to reset the gesture recognizer to preserve parallel
      layout test execution.
      * src/WebPopupMenuImpl.cpp:
      Support dispatching touch and gesture events to Popups.
      (WebKit::WebPopupMenuImpl::WebPopupMenuImpl):
      (WebKit::WebPopupMenuImpl::TouchEvent):
      (WebKit::WebPopupMenuImpl::handleInputEvent):
      * src/WebPopupMenuImpl.h:
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::WebViewImpl):
      Added gesture recognition creation.
      (WebKit::WebViewImpl::touchEvent):
      Added recognition of gestures and dispatch of gesture events.
      (WebKit::WebViewImpl::resetGestureRecognizer):
      * src/WebViewImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e94b756
    • joepeck@webkit.org's avatar
      Restore Composited Layers Faster from PageCache · 6ddbf430
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65216
      
      Reviewed by Simon Fraser.
      
      Restore the layer tree hierarchy a little sooner, when
      restoring from the page cache. This more closely matches
      original restore behavior.
      
      Existing test showed no change.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::restoreBackingStores):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ddbf430
    • commit-queue@webkit.org's avatar
      DFG speculative JIT never emits inline double comparisons, even when it · b16861ec
      commit-queue@webkit.org authored
      would be obvious more efficient to do so.
      https://bugs.webkit.org/show_bug.cgi?id=65212
      
      Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-26
      Reviewed by Gavin Barraclough.
      
      This handles the obvious case of inlining double comparisons: it only addresses
      the speculative JIT, and only for fused compare/branch sequences.  But it does
      handle the case where both operands are double (and there is no slow path),
      or where one operand is double and the other is unknown type (in which case it
      attempts to unbox the double, otherwise taking slow path).  This is an 0.8%
      speed-up on SunSpider.
      
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::convertToDouble):
      (JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
      (JSC::DFG::SpeculativeJIT::compare):
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT.h:
      (JSC::DFG::SpeculativeJIT::isRegisterDataFormatDouble):
      (JSC::DFG::SpeculativeJIT::shouldSpeculateInteger):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b16861ec
    • commit-queue@webkit.org's avatar
      [Qt] Add option to turn on disk caching in QtTestBrowser · f5e17721
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65007
      
      Patch by Keith Kyzivat <keith.kyzivat@nokia.com> on 2011-07-26
      Reviewed by Noam Rosenthal.
      
      Add menu item and command line option to turn on disk caching in
      QtTestBrowser. Simple QNetworkDiskCache added to the page's
      QNetworkAccssManager.
      
      * QtTestBrowser/launcherwindow.cpp:
      (LauncherWindow::initializeView):
      (LauncherWindow::createChrome):
      (LauncherWindow::setDiskCache):
      * QtTestBrowser/launcherwindow.h:
      (WindowOptions::WindowOptions):
      * QtTestBrowser/main.cpp:
      (LauncherApplication::handleUserOptions):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5e17721
    • commit-queue@webkit.org's avatar
      [skia] never draw with GDI, so that all text can be gpu-accelerated · 9323ca0a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65203
      
      Patch by Mike Reed <reed@google.com> on 2011-07-26
      Reviewed by Kenneth Russell.
      
      No new tests. existing tests apply to the new drawing path
      
      * platform/graphics/chromium/FontChromiumWin.cpp:
      (WebCore::TransparencyAwareFontPainter::TransparencyAwareGlyphPainter::drawGlyphs):
      * platform/graphics/skia/SkiaFontWin.cpp:
      (WebCore::windowsCanHandleDrawTextShadow):
      (WebCore::windowsCanHandleTextDrawing):
      (WebCore::windowsCanHandleTextDrawingWithoutShadow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9323ca0a
    • commit-queue@webkit.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=64969 · a8436a50
      commit-queue@webkit.org authored
      DFG JIT generates inefficient code for speculation failures.
      
      Patch by Filip Pizlo <fpizlo@apple.com> on 2011-07-26
      Reviewed by Gavin Barraclough.
      
      This implements a speculation failure strategy where (1) values spilled on
      non-speculative but not spilled on speculative are spilled, (2) values that
      are in registers on both paths are rearranged without ever touching memory,
      and (3) values spilled on speculative but not spilled on non-speculative are
      filled.
      
      The register shuffling is the most interesting part of this patch.  It
      constructs a permutation graph for registers.  Each node represents a
      register, and each directed edge corresponds to the register's value having
      to be moved to a different register as part of the shuffling.  This is a
      directed graph where each node may only have 0 or 1 incoming edges, and
      0 or 1 outgoing edges.  The algorithm then first finds maximal non-cyclic
      subgraphs where all nodes in the subgraph are reachable from a start node.
      Such subgraphs always resemble linked lists, and correspond to simply
      moving the value in the second-to-last register into the last register, and
      then moving the value in the third-to-last register into the second-to-last
      register, and so on.  Once these subgraphs are taken care of, the remaining
      subgraphs are cycles, and are handled using either (a) conversion or no-op
      if the cycle involves one node, (b) swap if it involves two nodes, or (c)
      a cyclic shuffle involving a scratch register if there are three or more
      nodes.
      
      * dfg/DFGGenerationInfo.h:
      (JSC::DFG::needDataFormatConversion):
      * dfg/DFGJITCompiler.cpp:
      (JSC::DFG::GeneralizedRegister::GeneralizedRegister):
      (JSC::DFG::GeneralizedRegister::createGPR):
      (JSC::DFG::GeneralizedRegister::createFPR):
      (JSC::DFG::GeneralizedRegister::dump):
      (JSC::DFG::GeneralizedRegister::findInSpeculationCheck):
      (JSC::DFG::GeneralizedRegister::findInEntryLocation):
      (JSC::DFG::GeneralizedRegister::previousDataFormat):
      (JSC::DFG::GeneralizedRegister::nextDataFormat):
      (JSC::DFG::GeneralizedRegister::convert):
      (JSC::DFG::GeneralizedRegister::moveTo):
      (JSC::DFG::GeneralizedRegister::swapWith):
      (JSC::DFG::ShuffledRegister::ShuffledRegister):
      (JSC::DFG::ShuffledRegister::isEndOfNonCyclingPermutation):
      (JSC::DFG::ShuffledRegister::handleNonCyclingPermutation):
      (JSC::DFG::ShuffledRegister::handleCyclingPermutation):
      (JSC::DFG::ShuffledRegister::lookup):
      (JSC::DFG::lookupForRegister):
      (JSC::DFG::NodeToRegisterMap::Tuple::Tuple):
      (JSC::DFG::NodeToRegisterMap::NodeToRegisterMap):
      (JSC::DFG::NodeToRegisterMap::set):
      (JSC::DFG::NodeToRegisterMap::end):
      (JSC::DFG::NodeToRegisterMap::find):
      (JSC::DFG::NodeToRegisterMap::clear):
      (JSC::DFG::JITCompiler::jumpFromSpeculativeToNonSpeculative):
      (JSC::DFG::JITCompiler::linkSpeculationChecks):
      * dfg/DFGJITCompiler.h:
      * dfg/DFGNonSpeculativeJIT.cpp:
      (JSC::DFG::EntryLocation::EntryLocation):
      * dfg/DFGNonSpeculativeJIT.h:
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculationCheck::SpeculationCheck):
      * dfg/DFGSpeculativeJIT.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8436a50
    • kbr@google.com's avatar
      Float32Array(ArrayBuffer, index, length) constructor working incorrectly. · abbc6c8f
      kbr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=57042
      
      Reviewed by James Robinson.
      
      Source/WebCore: 
      
      * bindings/js/JSArrayBufferViewHelper.h:
      (WebCore::constructArrayBufferViewWithArrayBufferArgument):
      * bindings/v8/custom/V8ArrayBufferViewCustom.h:
      (WebCore::constructWebGLArrayWithArrayBufferArgument):
      
      LayoutTests: 
      
      * fast/canvas/webgl/array-unit-tests-expected.txt:
      * fast/canvas/webgl/array-unit-tests.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abbc6c8f
    • crogers@google.com's avatar
      V8 custom bindings for AudioNode must do proper object checking and throw... · 9d6d3a48
      crogers@google.com authored
      V8 custom bindings for AudioNode must do proper object checking and throw exception in case of error
      https://bugs.webkit.org/show_bug.cgi?id=65222
      
      Reviewed by James Robinson.
      
      No new tests - this fixes upcoming audionode.html layout test
      
      * bindings/v8/custom/V8AudioNodeCustom.cpp:
      (WebCore::V8AudioNode::connectCallback):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d6d3a48
    • crogers@google.com's avatar
      AudioContext is not correctly accounting for hardware resources · 4f2bc03c
      crogers@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=65217
      
      Reviewed by Kenneth Russell.
      
      No new tests since audio API is not yet implemented.
      
      * webaudio/AudioContext.cpp:
      (WebCore::AudioContext::create):
      (WebCore::AudioContext::AudioContext):
      (WebCore::AudioContext::lazyInitialize):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f2bc03c
    • macpherson@chromium.org's avatar
      Handle CSS Properties that can be either auto or a primitive value in CSSStyleApplyProperty · c0b61460
      macpherson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65164
      
      Reviewed by Dimitri Glazkov.
      
      No new tests / refactoring only.
      
      * css/CSSPrimitiveValueMappings.h:
      Add casts to/from various numeric types.
      (WebCore::CSSPrimitiveValue::operator short):
      (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
      (WebCore::CSSPrimitiveValue::operator unsigned short):
      (WebCore::CSSPrimitiveValue::operator int):
      (WebCore::CSSPrimitiveValue::operator float):
      * css/CSSStyleApplyProperty.cpp:
      Add class to handle properties that set an "auto" boolean on RenderStyle.
      (WebCore::ApplyPropertyAuto::ApplyPropertyAuto):
      (WebCore::ApplyPropertyAuto::applyInheritValue):
      (WebCore::ApplyPropertyAuto::applyInitialValue):
      (WebCore::ApplyPropertyAuto::applyValue):
      (WebCore::ApplyPropertyAuto::hasAuto):
      (WebCore::ApplyPropertyAuto::setAuto):
      (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
      * css/CSSStyleSelector.cpp:
      Remove existing implementations.
      (WebCore::CSSStyleSelector::applyProperty):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0b61460
    • psolanki@apple.com's avatar
      Add protection space authentication callback code to CFNetwork loader on Mac · b5f869c4
      psolanki@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=65190
      <rdar://problem/9842424>
      
      Reviewed by Oliver Hunt.
      
      Port over protection space authentication callback code from ResourceHandleMac.mm to
      ResourceHandleCFNet.cpp.
      
      * platform/network/ResourceHandle.h:
      * platform/network/cf/ResourceHandleCFNet.cpp:
      (WebCore::canRespondToProtectionSpace):
      (WebCore::ResourceHandle::createCFURLConnection):
      (WebCore::ResourceHandle::canAuthenticateAgainstProtectionSpace):
      (WebCore::WebCoreSynchronousLoaderClient::canAuthenticateAgainstProtectionSpace):
      * platform/network/mac/ResourceHandleMac.mm:
      (-[WebCoreResourceHandleAsDelegate connection:canAuthenticateAgainstProtectionSpace:]): Add logging.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5f869c4
    • enne@google.com's avatar
      [chromium] Check in expectations for font-family-pictograph. · 49c1326f
      enne@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=65197
      
      Unreviewed gardening.
      
      * platform/chromium-linux/fast/css/font-family-pictograph-expected.png: Added.
      * platform/chromium-linux/fast/css/font-family-pictograph-expected.txt: Added.
      * platform/chromium-mac/fast/css/font-family-pictograph-expected.png: Added.
      * platform/chromium-mac/fast/css/font-family-pictograph-expected.txt: Added.
      * platform/chromium-win/fast/css/font-family-pictograph-expected.png: Added.
      * platform/chromium-win/fast/css/font-family-pictograph-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49c1326f
    • abarth@webkit.org's avatar
      Add support for download='filename' attribute in anchors. · 2d422e7f
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=64580
      
      Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-07-26
      Reviewed by Adam Barth.
      
      Source/WebCore: 
      
      The download attribute allows the author of the hyperlink to cause the
      browser to download the linked URL.  The author can also supply a
      suggested file name in the attribute value.  This feature is a recent
      addition to HTML to better support offline applications that use blob
      URLs.  Traditionally, web sites use the HTTP Content-Disposition header
      to trigger downloads, but that option isn't available when working
      offline.
      
      There is some question about whether we should initiate a download when
      we receive a DOM-created click event.  This patch does initiate the
      download, but we might revise that decision in the future as part of a
      larger change in how WebKit treats the interaction between default
      event handlers and DOM-created events.
      
      Tests: fast/dom/HTMLAnchorElement/anchor-download.html
             fast/dom/HTMLAnchorElement/anchor-nodownload.html
             fast/dom/HTMLAnchorElement/anchor-download-unset.html
             fast/dom/HTMLAnchorElement/anchor-nodownload-set.html
      
      * html/HTMLAnchorElement.cpp:
      (WebCore::HTMLAnchorElement::defaultEventHandler):
      (WebCore::HTMLAnchorElement::handleClick):
      * html/HTMLAnchorElement.h:
      * html/HTMLAnchorElement.idl:
      * html/HTMLAttributeNames.in:
      * loader/EmptyClients.h:
      (WebCore::EmptyFrameLoaderClient::startDownload):
      * loader/FrameLoaderClient.h:
      
      Source/WebKit/chromium: 
      
      * features.gypi:
      * public/WebFrameClient.h:
      (WebKit::WebFrameClient::loadURLExternally):
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
      (WebKit::FrameLoaderClientImpl::startDownload):
      * src/FrameLoaderClientImpl.h:
      
      Source/WebKit/efl: 
      
      * WebCoreSupport/FrameLoaderClientEfl.cpp:
      (WebCore::FrameLoaderClientEfl::startDownload):
      * WebCoreSupport/FrameLoaderClientEfl.h:
      
      Source/WebKit/gtk: 
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::startDownload):
      * WebCoreSupport/FrameLoaderClientGtk.h:
      
      Source/WebKit/haiku: 
      
      * WebCoreSupport/FrameLoaderClientHaiku.cpp:
      (WebCore::FrameLoaderClientHaiku::startDownload):
      * WebCoreSupport/FrameLoaderClientHaiku.h:
      
      Source/WebKit/qt: 
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::startDownload):
      * WebCoreSupport/FrameLoaderClientQt.h:
      
      Source/WebKit/win: 
      
      * WebFrame.cpp:
      (WebFrame::startDownload):
      * WebFrame.h:
      
      Source/WebKit/wince: 
      
      * WebCoreSupport/FrameLoaderClientWinCE.cpp:
      (WebKit::FrameLoaderClientWinCE::startDownload):
      * WebCoreSupport/FrameLoaderClientWinCE.h:
      
      Source/WebKit/wx: 
      
      * WebKitSupport/FrameLoaderClientWx.cpp:
      (WebCore::FrameLoaderClientWx::startDownload):
      * WebKitSupport/FrameLoaderClientWx.h:
      
      Source/WebKit2: 
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::startDownload):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      
      Tools: 
      
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::loadURLExternally):
      * DumpRenderTree/chromium/WebViewHost.h:
      
      LayoutTests: 
      
      * fast/dom/HTMLAnchorElement/anchor-download-expected.txt: Added.
      * fast/dom/HTMLAnchorElement/anchor-download.html: Added.
      * fast/dom/HTMLAnchorElement/anchor-nodownload-expected.txt: Added.
      * fast/dom/HTMLAnchorElement/anchor-nodownload.html: Added.
      * fast/dom/HTMLAnchorElement/anchor-download-unset-expected.txt: Added.
      * fast/dom/HTMLAnchorElement/anchor-download-unset.html: Added.
      * fast/dom/HTMLAnchorElement/anchor-nodownload-set-expected.txt: Added.
      * fast/dom/HTMLAnchorElement/anchor-nodownload-set.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d422e7f