1. 04 Apr, 2013 40 commits
    • commit-queue@webkit.org's avatar
      [BlackBerry] DOMSupport::isFixedPositionOrHasFixedPositionAncestor stops... · d163f0f7
      commit-queue@webkit.org authored
      [BlackBerry] DOMSupport::isFixedPositionOrHasFixedPositionAncestor stops traversing render tree when it hits an iframe element
      https://bugs.webkit.org/show_bug.cgi?id=113944
      
      Patch by Andrew Lo <anlo@rim.com> on 2013-04-04
      Reviewed by Rob Buis.
      Internally reviewed by Mike Fenton.
      
      Internal PR 320732.
      When checking whether a RenderObject is fixed position or has a fixed position
      ancestor, we traverse the render tree upwards.
      
      When we reach the root of the tree, check whether the root is an
      iframe and has an element owner. If so, we also need to continue iterating
      up the tree from the owner to see if the iframe is a descendant of a fixed
      position element.
      
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::isFixedPositionOrHasFixedPositionAncestor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d163f0f7
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Add support for getting page contents as string · bedac6ee
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106752
      
      Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-04-04
      Reviewed by Andreas Kling.
      
      Modified ewk_view_page_contents_get() API to get page contents as string.
      EWK_PAGE_CONTENTS_TYPE_STRING is added to Ewk_Page_Contents_Type.
      Now, we can use both EWK_PAGE_CONTENTS_TYPE_MHTML and EWK_PAGE_CONTENTS_TYPE_STRING
      for getting page contents.
      
      * UIProcess/API/efl/ewk_view.cpp:
      (Ewk_Page_Contents_Context):
      (ewkViewPageContentsAsMHTMLCallback):
      (ewkViewPageContentsAsStringCallback):
      (ewk_view_page_contents_get):
      * UIProcess/API/efl/ewk_view.h:
      * UIProcess/API/efl/tests/test_ewk2_view.cpp:
      (PageContentsAsMHTMLCallback):
      (PageContentsAsStringCallback):
      (TEST_F):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bedac6ee
    • benjamin@webkit.org's avatar
      Change class_as_selector-expected.html to be a ref-test · 75f883a0
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113970
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
      Reviewed by Geoffrey Garen.
      
      The test checks style can be applied to text with a CSS class.
      The reference is done by applying a style attribute directly
      on each element.
      
      * css1/basic/class_as_selector-expected.html: Added.
      * platform/efl/css1/basic/class_as_selector-expected.png: Removed.
      * platform/efl/css1/basic/class_as_selector-expected.txt: Removed.
      * platform/gtk/css1/basic/class_as_selector-expected.txt: Removed.
      * platform/mac/css1/basic/class_as_selector-expected.png: Removed.
      * platform/mac/css1/basic/class_as_selector-expected.txt: Removed.
      * platform/qt/css1/basic/class_as_selector-expected.png: Removed.
      * platform/qt/css1/basic/class_as_selector-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75f883a0
    • benjamin@webkit.org's avatar
      Unskip 3 backface-visibility tests on OS X · 72a072f5
      benjamin@webkit.org authored
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
      
      * platform/mac/TestExpectations:
      The 3 pixel tests pass on WebKit1 and WebKit2.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72a072f5
    • benjamin@webkit.org's avatar
      Update WebKit.org's contact page · 09ad5d3c
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113968
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
      Reviewed by Geoffrey Garen.
      
      * contact.html:
      -Add a direct link to our archives on Gmane.
      -References the ports mailing-lists. This may reduces the emails
       erroneously sent to webkit-dev.
      -Add a link to our "reporting bug page".
      -Get rid of the link to CIA. The website is dead.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09ad5d3c
    • rniwa@webkit.org's avatar
      Remove the rebaseline queue server since nobody except maybe one person from Google uses it. · b662f68b
      rniwa@webkit.org authored
      Rubber stamped by Benjamin Poulain.
      
      * RebaselineQueueServer: Removed.
      * RebaselineQueueServer/app.yaml: Removed.
      * RebaselineQueueServer/handlers: Removed.
      * RebaselineQueueServer/handlers/__init__.py: Removed.
      * RebaselineQueueServer/handlers/builderqueue.py: Removed.
      * RebaselineQueueServer/handlers/pages.py: Removed.
      * RebaselineQueueServer/index.yaml: Removed.
      * RebaselineQueueServer/main.py: Removed.
      * RebaselineQueueServer/model: Removed.
      * RebaselineQueueServer/model/__init__.py: Removed.
      * RebaselineQueueServer/model/queueentry.py: Removed.
      * RebaselineQueueServer/static: Removed.
      * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
      * RebaselineQueueServer/static/styles.css: Removed.
      * RebaselineQueueServer/templates: Removed.
      * RebaselineQueueServer/templates/builder-picker.html: Removed.
      * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
      * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
      * RebaselineQueueServer/templates/home.html: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b662f68b
    • rniwa@webkit.org's avatar
      Fix setup-commit-queue and temporarily disable testing on commit-queue · 3c38b70e
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113979
      
      Reviewed by Benjamin Poulain.
      
      Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
      and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
      
      * EWSTools/setup-commit-queue.sh:
      * Scripts/webkitpy/tool/bot/commitqueuetask.py:
      (CommitQueueTask.run):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c38b70e
    • andersca@apple.com's avatar
      Work around a bug in the bindings generation script. · 80ef3f52
      andersca@apple.com authored
      * WebCore.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80ef3f52
    • dino@apple.com's avatar
      Don't dispatch delayed click if snapshotted plugin was triggered by a click on the label · 435c2ed6
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113982
      
      Reviewed by Tim Horton.
      
      We regressed the way clicks were sent on to restarted plugins when we moved to a
      Shadow Root - we were always sending the click. We should only send the click
      on if the user clicked on the main plugin content, and not send it when you
      click directly on the label.
      
      * html/HTMLPlugInImageElement.cpp:
      (WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Keep a reference to the container and label.
      (WebCore::HTMLPlugInImageElement::partOfSnapshotLabel): New method that detects if a Node was part
          of the snapshot label.
      (WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Only record the event if you should forward it on.
      * html/HTMLPlugInImageElement.h:
      (HTMLPlugInImageElement): New parameter to userDidClickSnapshot and member variables for shadow content.
      * rendering/RenderSnapshottedPlugIn.cpp:
      (WebCore::RenderSnapshottedPlugIn::handleEvent): Ask the plugin if the clicked target was the snapshot label.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      435c2ed6
    • ch.dumez@sisa.samsung.com's avatar
      Unreviewed EFL build fix. · c36d7496
      ch.dumez@sisa.samsung.com authored
      Add missing include for FloatRect.h.
      
      * platform/efl/PlatformScreenEfl.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c36d7496
    • timothy_horton@apple.com's avatar
      Unreviewed build fix. · 24256593
      timothy_horton@apple.com authored
      * platform/graphics/GlyphPageTreeNode.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24256593
    • ch.dumez@sisa.samsung.com's avatar
      Unreviewed EFL build fix. · e30151a0
      ch.dumez@sisa.samsung.com authored
      We had undefined reference to `JSC::CodeOrigin::maximumBytecodeIndex'.
      
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::findClosureCallForReturnPC):
      (JSC::CodeBlock::bytecodeOffset):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147690 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e30151a0
    • andersca@apple.com's avatar
      Another build fix. · 34a27388
      andersca@apple.com authored
      * platform/graphics/FontCache.cpp:
      * platform/graphics/SimpleFontData.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34a27388
    • andersca@apple.com's avatar
      Fix build. · 4b213c90
      andersca@apple.com authored
      * WebCore.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b213c90
    • commit-queue@webkit.org's avatar
      [BlackBerry] Adjust fatfinger result priority · a832f327
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113957
      
      Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-04
      Reviewed by Rob Buis.
      
      RIM PR 224781
      Internally Reviewed by Genevieve Mak.
      
      Change fatfigner algorithm, return the clickable element rather than
      its parent anchor. Modify taphighlight and context menu node selection
      accordingly.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::webContext):
      * WebKitSupport/FatFingers.cpp:
      (BlackBerry::WebKit::FatFingers::findBestPoint):
      * WebKitSupport/FatFingers.h:
      * WebKitSupport/TouchEventHandler.cpp:
      (BlackBerry::WebKit::elementForTapHighlight):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a832f327
    • ggaren@apple.com's avatar
      Removed empty files from the build · ac8d2fa7
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113978
      
      Reviewed by Anders Carlsson.
      
      Anders made a list of all the empty files that are slowing down the Mac
      build, and I grepped them away.
      
      * WebCore.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac8d2fa7
    • dpranke@chromium.org's avatar
      temporarily make flakiness dashboard work again webkit.org bots · 9f49bfcf
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113972
      
      Reviewed by Ojan Vafai.
      
      This patch disables the chromium.org layout test bots TestExpectations
      parsing temporarily until we can work out the right way to split into
      two instances for webkit.org and chromium.org and figure out which
      code to delete where :).
      
      * TestResultServer/static-dashboards/flakiness_dashboard.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f49bfcf
    • andersca@apple.com's avatar
      Prune unneeded header #includes · 0920f1b1
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113973
      
      Reviewed by Geoffrey Garen.
      
      Reduce the amount of headers included by other headers by:
      - Moving implicit and explicit constructors and destructors into .cpp files so member variable constructors/destructors
        don't have to be declared.
      - Move CachedResourceClient subclasses out into separate headers so that their respective CachedResource subclasses don't
        have to be included by the classes that derive from those subclasses.
      - Remove headers that were never needed in the first place.
      
      * Modules/webaudio/AudioContext.h:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSDOMWindowCustom.cpp:
      * css/CSSFontFaceSource.h:
      * html/canvas/CanvasPattern.cpp:
      (WebCore::CanvasPattern::create):
      (WebCore::CanvasPattern::CanvasPattern):
      (WebCore::CanvasPattern::~CanvasPattern):
      * html/canvas/CanvasPattern.h:
      (WebCore::CanvasPattern::pattern):
      (WebCore::CanvasPattern::originClean):
      * html/parser/HTMLScriptRunner.h:
      * loader/ImageLoader.h:
      * loader/LinkLoader.h:
      * loader/TextTrackLoader.h:
      * loader/cache/CachedFont.cpp:
      * loader/cache/CachedFont.h:
      * loader/cache/CachedFontClient.h: Added.
      (WebCore::CachedFontClient::~CachedFontClient):
      (WebCore::CachedFontClient::expectedType):
      (WebCore::CachedFontClient::resourceClientType):
      (WebCore::CachedFontClient::fontLoaded):
      * loader/cache/CachedResourceHandle.cpp:
      (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
      (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
      (WebCore::CachedResourceHandleBase::setResource):
      * loader/cache/CachedResourceHandle.h:
      (WebCore::CachedResourceHandleBase::get):
      (WebCore::CachedResourceHandleBase::operator!):
      (WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
      (WebCore::CachedResourceHandleBase::operator=):
      (WebCore::CachedResourceHandle::CachedResourceHandle):
      (WebCore::CachedResourceHandle::get):
      (WebCore::CachedResourceHandle::operator->):
      (WebCore::CachedResourceHandle::operator=):
      (WebCore::CachedResourceHandle::operator==):
      (WebCore::CachedResourceHandle::operator!=):
      (WebCore::operator==):
      (WebCore::operator!=):
      * loader/cache/CachedSVGDocument.h:
      * loader/cache/CachedSVGDocumentReference.h:
      * loader/cache/CachedSVGDocumentClient.h: Added.
      (WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
      (WebCore::CachedSVGDocumentClient::expectedType):
      (WebCore::CachedSVGDocumentClient::resourceClientType):
      * loader/cache/CachedStyleSheetClient.h:
      * platform/PlatformScreen.h:
      * platform/audio/HRTFElevation.cpp:
      * platform/audio/HRTFKernel.cpp:
      (WebCore::HRTFKernel::fftSize):
      * platform/audio/HRTFKernel.h:
      * platform/audio/ReverbConvolverStage.cpp:
      (WebCore::ReverbConvolverStage::~ReverbConvolverStage):
      * platform/audio/ReverbConvolverStage.h:
      * platform/graphics/FontPlatformData.h:
      * platform/graphics/GraphicsContext3D.h:
      * platform/graphics/Path.cpp:
      * platform/graphics/Path.h:
      * platform/graphics/Pattern.cpp:
      * platform/graphics/Pattern.h:
      * platform/graphics/filters/FilterOperation.cpp:
      (WebCore::ReferenceFilterOperation::ReferenceFilterOperation):
      (WebCore::ReferenceFilterOperation::~ReferenceFilterOperation):
      (WebCore::ReferenceFilterOperation::setCachedSVGDocumentReference):
      * platform/graphics/filters/FilterOperation.h:
      * platform/graphics/transforms/AffineTransform.h:
      * plugins/DOMMimeType.h:
      * rendering/RenderLayerFilterInfo.h:
      * rendering/style/StyleCachedShader.h:
      * svg/SVGFEImageElement.h:
      * svg/SVGFontFaceUriElement.h:
      * svg/SVGUseElement.h:
      * xml/parser/XMLDocumentParser.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0920f1b1
    • ch.dumez@sisa.samsung.com's avatar
      [Cairo] Stop passing raw pointers to BitmapImage::create() · 515641e4
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113945
      
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      BitmapImage::create() was updated in r147643 to take a PassRefPtr<cairo_surface_t>
      in argument instead of a cairo_surface_t*. This patch updates several call sites
      so that they now pass in a smart pointer instead of a raw one to avoid silent
      converting from cairo_surface_t* to PassRefPtr<cairo_surface_t>.
      
      No new tests, no behavior change.
      
      * platform/graphics/cairo/ImageBufferCairo.cpp:
      (WebCore::ImageBufferData::ImageBufferData): Use RefPtr to m_surface to avoid manual
      memory handling.
      (WebCore::ImageBuffer::ImageBuffer):
      (WebCore::ImageBuffer::~ImageBuffer):
      (WebCore::ImageBuffer::copyImage):
      (WebCore::ImageBuffer::clip):
      (WebCore::ImageBuffer::platformTransformColorSpace):
      (WebCore::getImageData):
      (WebCore::ImageBuffer::putByteArray):
      * platform/graphics/cairo/ImageBufferDataCairo.h:
      (ImageBufferData):
      * platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
      (ImageGStreamer::ImageGStreamer):
      * platform/graphics/gtk/ImageBufferGtk.cpp:
      (WebCore::ImageBuffer::toDataURL):
      
      Source/WebKit2:
      
      Pass a smart pointer in to BitmapImage::create() instead of a raw one
      for the cairo surface. The factory method prototype was updated for
      cairo in r147643.
      
      * Shared/cairo/ShareableBitmapCairo.cpp:
      (WebKit::ShareableBitmap::createImage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      515641e4
    • simon.fraser@apple.com's avatar
      Page content missing when flipping from an empty layer to a tiled layer · ca3e5e1e
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113977
      <rdar://problem/13444219>
      
      Source/WebCore:
      
      Reviewed by Tim Horton.
      
      Some articles on USA Today were missing content on load, when a large GraphicsLayer
      which did not draw content needed to draw content (and become tiled in the process).
      
      The bug was an ordering dependency in GraphicsLayerCA::commitLayerChangesBeforeSublayers().
      swapFromOrToTiledLayer() sets some dirty flags, but for some properties which have
      already been committed in the current flush cycle.
      
      Fix by moving the swapFromOrToTiledLayer() to the top of the commit, which is
      safe since it only consults GraphicsLayer properties, not CALayer properties.
      
      Test: compositing/tiling/empty-to-tiled.html
      
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
      (WebCore::GraphicsLayerCA::updateGeometry):
      (WebCore::GraphicsLayerCA::updateLayerDrawsContent):
      (WebCore::GraphicsLayerCA::updateContentsScale):
      * platform/graphics/ca/GraphicsLayerCA.h:
      (GraphicsLayerCA):
      
      LayoutTests:
      
      Reviewed by Tim Horton.
      
      Ref test that adds visible content to a larger layer.
      
      * compositing/tiling/empty-to-tiled-expected.html: Added.
      * compositing/tiling/empty-to-tiled.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca3e5e1e
    • ch.dumez@sisa.samsung.com's avatar
      Regression(r147639) Causes assertion hit in HashTable · 9fad4429
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113954
      
      Reviewed by Benjamin Poulain.
      
      Lookup the key in the hash table again after the recursive call to
      getCachedFontPlatformData() as it may have altered the hash map and
      invalidated the previous iterator we had.
      
      No new tests, covered by existing tests.
      
      * platform/graphics/FontCache.cpp:
      (WebCore::FontCache::getCachedFontPlatformData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9fad4429
    • rniwa@webkit.org's avatar
      Fix webkitpy tests after r147678. · 0512a6ed
      rniwa@webkit.org authored
      * Scripts/webkitpy/tool/commands/queues_unittest.py:
      (CommitQueueTest.test_commit_queue):
      (test_manual_reject_during_processing):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0512a6ed
    • eric.carlson@apple.com's avatar
      Unreviewed, fix a test and some results missed in r147675 · bb2bdfa8
      eric.carlson@apple.com authored
      * media/media-captions-expected.txt:
      * media/video-controls-captions-trackmenu-localized.html:
      * platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb2bdfa8
    • rniwa@webkit.org's avatar
      The commit queue should use Mac MountainLion port · 325f7ea3
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113971
      
      Reviewed by Lucas Forschler.
      
      * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
      * Scripts/webkitpy/tool/commands/queues.py:
      (CommitQueue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      325f7ea3
    • ggaren@apple.com's avatar
      Stop pretending that statements return a value · d786e6b6
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113969
      
      Reviewed by Oliver Hunt.
      
      Expressions have an intrinsic value, which they return to their parent
      in the AST.
      
      Statements just execute for effect in sequence.
      
      This patch moves emitBytecode into the ExpressionNode and StatementNode
      subclasses, and changes the SatementNode subclass to return void. This
      eliminates some cruft where we used to return 0, or try to save a bogus
      register and return it, as if a statement had a consuming parent in the
      AST.
      
      * bytecompiler/BytecodeGenerator.h:
      (JSC::BytecodeGenerator::emitNode):
      (BytecodeGenerator):
      (JSC::BytecodeGenerator::emitNodeInConditionContext):
      * bytecompiler/NodesCodegen.cpp:
      (JSC::ConstStatementNode::emitBytecode):
      (JSC::BlockNode::emitBytecode):
      (JSC::EmptyStatementNode::emitBytecode):
      (JSC::DebuggerStatementNode::emitBytecode):
      (JSC::ExprStatementNode::emitBytecode):
      (JSC::VarStatementNode::emitBytecode):
      (JSC::IfNode::emitBytecode):
      (JSC::IfElseNode::emitBytecode):
      (JSC::DoWhileNode::emitBytecode):
      (JSC::WhileNode::emitBytecode):
      (JSC::ForNode::emitBytecode):
      (JSC::ForInNode::emitBytecode):
      (JSC::ContinueNode::emitBytecode):
      (JSC::BreakNode::emitBytecode):
      (JSC::ReturnNode::emitBytecode):
      (JSC::WithNode::emitBytecode):
      (JSC::CaseClauseNode::emitBytecode):
      (JSC::CaseBlockNode::emitBytecodeForBlock):
      (JSC::SwitchNode::emitBytecode):
      (JSC::LabelNode::emitBytecode):
      (JSC::ThrowNode::emitBytecode):
      (JSC::TryNode::emitBytecode):
      (JSC::ScopeNode::emitStatementsBytecode):
      (JSC::ProgramNode::emitBytecode):
      (JSC::EvalNode::emitBytecode):
      (JSC::FunctionBodyNode::emitBytecode):
      (JSC::FuncDeclNode::emitBytecode):
      * parser/NodeConstructors.h:
      (JSC::PropertyListNode::PropertyListNode):
      (JSC::ArgumentListNode::ArgumentListNode):
      * parser/Nodes.h:
      (Node):
      (ExpressionNode):
      (StatementNode):
      (ConstStatementNode):
      (BlockNode):
      (EmptyStatementNode):
      (DebuggerStatementNode):
      (ExprStatementNode):
      (VarStatementNode):
      (IfNode):
      (IfElseNode):
      (DoWhileNode):
      (WhileNode):
      (ForNode):
      (ForInNode):
      (ContinueNode):
      (BreakNode):
      (ReturnNode):
      (WithNode):
      (LabelNode):
      (ThrowNode):
      (TryNode):
      (ProgramNode):
      (EvalNode):
      (FunctionBodyNode):
      (FuncDeclNode):
      (CaseBlockNode):
      (SwitchNode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d786e6b6
    • benjamin@webkit.org's avatar
      Make fast/events/tabindex-focus-blur-all.html disallow Java so the test runs... · b9163c71
      benjamin@webkit.org authored
      Make fast/events/tabindex-focus-blur-all.html disallow Java so the test runs the same regardless of platform/port
      https://bugs.webkit.org/show_bug.cgi?id=113950
      
      Patch by Dave Michael <dmichael@chromium.org> on 2013-04-04
      Reviewed by Jer Noble.
      
      This hopefully fixes the test failure seen on Apple Mountain Lion WK2:
      http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r147640%20(7636)/results.html
      that was introduced in https://bugs.webkit.org/show_bug.cgi?id=32292
      
      * fast/events/resources/tabindex-focus-blur-all.js: Make the test disallow Java execution. Otherwise, <applet> is focusible on platforms that support Java by default and not focusible elsewhere.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9163c71
    • eric.carlson@apple.com's avatar
      [Mac] add "automatic" text track menu item · 44f8c684
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113822
      
      Reviewed by Jer Noble.
      
      Source/WebCore: 
      
      No new tests, existing tests updated.
      
      * English.lproj/Localizable.strings: Add new track menu item.
      
      * html/HTMLMediaElement.cpp: 
      (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_captionDisplayMode.
      (WebCore::HTMLMediaElement::finishParsingChildren): LoadTextTrackResource -> ConfigureTextTracks.
      (WebCore::HTMLMediaElement::scheduleDelayedAction): Ditto.
      (WebCore::HTMLMediaElement::loadTimerFired): Ditto.
      (WebCore::HTMLMediaElement::loadInternal): Ditto. Flag the caption menu as invalid so it will
          be rebuilt again.
      (WebCore::HTMLMediaElement::mediaPlayerDidAddTrack): LoadTextTrackResource -> ConfigureTextTracks.
      (WebCore::HTMLMediaElement::didAddTrack): Ditto.
      (WebCore::HTMLMediaElement::configureTextTrackGroup): Deal with new track display modes.
      (WebCore::HTMLMediaElement::HTMLMediaElement::hasClosedCaptions): Minor cleanup.
      (WebCore::HTMLMediaElement::configureTextTrackGroup): Add some logging.
      (WebCore::HTMLMediaElement::configureTextTracks): Call updateActiveTextTrackCues so cue display
          is updated.
      (WebCore::HTMLMediaElement::captionPreferencesChanged): Deal with new track display modes.
      (WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Add some logging.
      * html/HTMLMediaElement.h: Ditto.
      
      * html/shadow/MediaControlElementTypes.cpp: Remove trackIndexAttributeName and trackListIndexForElement.
      * html/shadow/MediaControlElementTypes.h: Ditto.
      
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler): Don't use track index,
          everything we need is in the track<->element map now.
      (WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Ditto. Always rebuild the 
          track list because clear the map each time the menu goes away because it refs every track.
      (WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Don't set the track
          index attribute on the menu items, just use the map.
      * html/shadow/MediaControlElements.h:
      
      * html/shadow/MediaControlsApple.cpp:
      (WebCore::MediaControlsApple::changedClosedCaptionsVisibility): resetTrackListMenu is gone.
      (WebCore::MediaControlsApple::reset): Ditto.
      (WebCore::MediaControlsApple::closedCaptionTracksChanged): Ditto.
      
      * html/track/TextTrack.cpp:
      (WebCore::TextTrack::captionMenuOffItem): New, static TextTrack used for the menu "Off" item.
      (WebCore::TextTrack::captionMenuAutomaticItem): New, static TextTrack used for the menu "Automatic" item.
      * html/track/TextTrack.h:
      
      * page/CaptionUserPreferences.cpp:
      (WebCore::CaptionUserPreferences::shouldShowCaptions): Removed, we use captionDisplayMode instead.
      (WebCore::CaptionUserPreferences::captionDisplayMode): New.
      (WebCore::CaptionUserPreferences::setCaptionDisplayMode): New.
      (WebCore::CaptionUserPreferences::setPreferredLanguage): Make the parameter a const reference.
      (WebCore::CaptionUserPreferences::textTrackSelectionScore): Return 0 if the user doesn't want
          captions or subtitles.
      (WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Take language as a parameter
          instead of assuming that it is always the entire language list.
      * page/CaptionUserPreferences.h:
      
      * page/CaptionUserPreferencesMac.h:
      * page/CaptionUserPreferencesMac.mm:
      (WebCore::CaptionUserPreferencesMac::shouldShowCaptions): Removed, we use captionDisplayMode instead.
      (WebCore::CaptionUserPreferencesMac::captionDisplayMode): New.
      (WebCore::CaptionUserPreferencesMac::setCaptionDisplayMode): New.
      (WebCore::CaptionUserPreferencesMac::setPreferredLanguage): Make the parameter a const reference.
      (WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Deal with "Automatic" mode.
          captions or subtitles.
      (WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Take language as a parameter
          instead of assuming that it is always the entire language list.
      (WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): Insert "Off" and "Automatic" items.
      
      * platform/LocalizedStrings.cpp:
      (WebCore::textTrackAutomaticMenuItemText): New.
      * platform/LocalizedStrings.h:
      
      * platform/graphics/MediaPlayer.cpp:
      (WebCore::MediaPlayer::languageOfPrimaryAudioTrack): New.
      * platform/graphics/MediaPlayer.h:
      * platform/graphics/MediaPlayerPrivate.h:
      
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Return the language
          of the main audio track.
      
      LayoutTests: 
      
      * media/media-captions.html: Opportunistic fix - don't look at state until we get the 'canplaythrough'
          event because the media engine state may not have been processed until that time.
      * media/track/track-cue-container-rendering-position.html: Don't assume that a cue has been 
          rendered immediately when the 'canplaythrough' event comes through.
      * media/track/track-cue-rendering-mode-changed.html: Ditto.
      * media/track/track-in-band-expected.txt: Don't check if cues have loaded, it doesn't matter
          for this test.
      * media/track/track-in-band.html: Ditto.
      * media/track/track-user-preferences-expected.txt: Changed name of utility function from 
          menuIndexForLanguage to indexOfMenuItemBeginningWith.
      * media/track/track-user-preferences.html: Move menuIndexForLanguage to trackmenu-test.js and
          change name to indexOfMenuItemBeginningWith. Clarify the message logged when a track loads
          but it should not.
      * media/trackmenu-test.js: Move some functions here from track-user-preferences.html
      (trackMenuList):
      (indexOfMenuItemBeginningWith):
      (selectCaptionMenuItem):
      * media/video-controls-captions-trackmenu-sorted.html: Update for new menu item.
      * media/video-controls-captions-trackmenu.html: Ditto.
      * platform/mac/media/video-controls-captions-trackmenu-expected.txt: Ditto.
      * platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44f8c684
    • glenn@skynav.com's avatar
      [EFL] Unreviewed gardening. Rebaseline after r147588. Remove overridden pixel results. · 85dcc593
      glenn@skynav.com authored
      * platform/efl/fast/text/international/003-expected.png: Removed.
      * platform/efl/fast/text/international/text-combine-image-test-expected.png: Removed.
      * platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85dcc593
    • glenn@skynav.com's avatar
      [EFL] Unreviewed gardening. Rebaseline after r147588. Update pixel expectations. · a3b38062
      glenn@skynav.com authored
      * platform/efl-wk1/fast/text/international/003-expected.png: Added.
      * platform/efl-wk1/fast/text/international/text-combine-image-test-expected.png: Added.
      * platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
      * platform/efl-wk2/fast/text/international/003-expected.png: Added.
      * platform/efl-wk2/fast/text/international/text-combine-image-test-expected.png: Added.
      * platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3b38062
    • dpranke@chromium.org's avatar
      turn off running tests on chromium linux EWS bots · 79fc007a
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113959
      
      Reviewed by Geoffrey Garen.
      
      Now that the Chromium port is no longer being maintained
      there's little point in running the tests. Soon we should
      just shut this bot off altogether.
      
      * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
      (ChromiumLinuxEWS):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79fc007a
    • ap@apple.com's avatar
      REGRESSION (r146580): Assertion using SecurityOrigin::create, URL string is not valid · f55d8e99
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=113961
      
              Reviewed by Geoff Garen.
      
              * page/SecurityOrigin.cpp:
              (WebCore::SecurityOrigin::createFromDatabaseIdentifier):
              (WebCore::SecurityOrigin::create):
              Don't use ParsedURLString, because http://host:80/ is normalized to http://host/,
              so it's not a parsed URL string.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f55d8e99
    • oliver@apple.com's avatar
      Exception stack unwinding doesn't handle inline callframes correctly · 49a2c14b
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113952
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore:
      
      The basic problem here is that the exception stack unwinding was
      attempting to be "clever" and avoid doing a correct stack walk
      as it "knew" inline callframes couldn't have exception handlers.
      
      This used to be safe as the exception handling machinery was
      designed to fail gently and just claim that no handler existed.
      This was "safe" and even "correct" inasmuch as we currently
      don't run any code with exception handlers through the dfg.
      
      This patch fixes the logic by simply making everything uniformly
      use the safe stack walking machinery, and making the correct
      boundary checks occur everywhere that they should.
      
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::findClosureCallForReturnPC):
      (JSC::CodeBlock::bytecodeOffset):
      * interpreter/Interpreter.cpp:
      (JSC):
      (JSC::Interpreter::dumpRegisters):
      (JSC::Interpreter::unwindCallFrame):
      (JSC::getCallerInfo):
      (JSC::Interpreter::getStackTrace):
      (JSC::Interpreter::retrieveCallerFromVMCode):
      
      LayoutTests:
      
      Yay tests!
      
      * fast/js/js-correct-exception-handler-expected.txt: Added.
      * fast/js/js-correct-exception-handler.html: Added.
      * fast/js/script-tests/js-correct-exception-handler.js: Added.
      (throwEventually):
      (f.g):
      (f):
      (test):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49a2c14b
    • ggaren@apple.com's avatar
      Removed a defunct comment · e9150c77
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113948
      
      Reviewed by Oliver Hunt.
      
      This is also a convenient way to test the EWS.
      
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9150c77
    • glenn@skynav.com's avatar
      [EFL] Unreviewed gardening. Rebaseline after r147588. · 3454a256
      glenn@skynav.com authored
      * platform/efl-wk1/fast/text/international: Added.
      * platform/efl-wk1/fast/text/international/003-expected.txt: Added.
      * platform/efl-wk1/fast/text/international/text-combine-image-test-expected.txt: Added.
      * platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
      * platform/efl-wk2/fast/text/international/003-expected.txt: Added.
      * platform/efl-wk2/fast/text/international/text-combine-image-test-expected.txt: Added.
      * platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
      * platform/efl/fast/text/international/003-expected.txt: Removed.
      * platform/efl/fast/text/international/text-combine-image-test-expected.txt: Removed.
      * platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3454a256
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r147662. · 9eb48e04
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/147662
      https://bugs.webkit.org/show_bug.cgi?id=113955
      
      The change r147662  breaks fast/regions/fixed-pos-elem-in-
      region.html (Requested by benjaminp on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-04
      
      Source/WebCore:
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::inlineLogicalWidth):
      
      LayoutTests:
      
      * fast/inline/inline-with-empty-inline-children-expected.txt:
      * fast/inline/inline-with-empty-inline-children.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9eb48e04
    • roger_fong@apple.com's avatar
      Unreviewed. AppleWin port gardening. · 2b505bba
      roger_fong@apple.com authored
      * platform/win/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b505bba
    • roger_fong@apple.com's avatar
      Unreviewed. AppleWin port gardening. · 6c958e45
      roger_fong@apple.com authored
      * platform/win/TestExpectations:
      * platform/win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c958e45
    • timothy_horton@apple.com's avatar
      REGRESSION (r147373): Auto-sizing doesn't always respect minimum width changes · ee280ae1
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113947
      <rdar://problem/13579024>
      
      Reviewed by Anders Carlsson.
      
      Reset the FrameView size to the minimum auto-sizing size
      before performing auto-sizing. We were already resetting the height,
      but not the width, instead using the FrameView's current width.
      
      This means that changing the minimum width without also manually
      resizing the FrameView will never see the width change.
      
      Auto-sizing tests are not working on Mac yet.
      
      * page/FrameView.cpp:
      (WebCore::FrameView::autoSizeIfEnabled):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee280ae1
    • mrobinson@webkit.org's avatar
      [GTK] Remove the gyp build · bf36d591
      mrobinson@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113942
      
      Reviewed by Gustavo Noronha Silva.
      
      Source/JavaScriptCore:
      
      * JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Removed.
      * JavaScriptCore.gyp/redirect-stdout.sh: Removed.
      
      Source/ThirdParty/ANGLE:
      
      * ANGLE.gyp/ANGLE.gyp: Removed.
      * ANGLE.gypi: Removed.
      
      Source/WebCore:
      
      * WebCore.gyp/WebCoreGTK.gyp: Removed.
      
      Source/WebKit/gtk:
      
      * gyp/Configuration.gypi.in: Removed.
      * gyp/Dependencies.gyp: Removed.
      * gyp/GNUmakefile: Removed.
      * gyp/autogen.sh: Removed.
      * gyp/configure.ac: Removed.
      * gyp/run-gyp: Removed.
      
      Source/WTF:
      
      * WTF.gyp/WTFGTK.gyp: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf36d591
    • robert@webkit.org's avatar
      REGRESSION(r142152): Text wraps in menu · d063ec6c
      robert@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113706
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::inlineLogicalWidth): Empty inline elements add their inline border/padding/margin to the width of the
      line when we iterate through them in nextLineBreak(), so no need to add them again here when climbing back up
      from their first child looking for border/padding/margin to add. (An empty inline element can have floating children.)
      
      LayoutTests:
      
      * fast/inline/inline-with-empty-inline-children-expected.txt:
      * fast/inline/inline-with-empty-inline-children.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d063ec6c