1. 07 Jun, 2011 25 commits
    • thakis@chromium.org's avatar
      2011-06-07 Nico Weber <thakis@chromium.org> · d0e4d419
      thakis@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
              https://bugs.webkit.org/show_bug.cgi?id=62210
      
              The change to TestEventPrinter fixes a latent bug, because
              objects are deleted through the TestEventPrinter type, but none
              of the subclasses have destructors or non-POD members.
      
              The changes to NotificationPresenter and WebViewHost do _not_ to fix a
              real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
              discussed at http://codereview.chromium.org/7094005/, we prefer making
              leaf class destructors virtual over making the leaf classes final.
      
              * DumpRenderTree/chromium/NotificationPresenter.cpp:
              (NotificationPresenter::~NotificationPresenter):
              * DumpRenderTree/chromium/NotificationPresenter.h:
              * DumpRenderTree/chromium/TestEventPrinter.cpp:
              (TestEventPrinter::~TestEventPrinter):
              * DumpRenderTree/chromium/TestEventPrinter.h:
              * DumpRenderTree/chromium/WebViewHost.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0e4d419
    • commit-queue@webkit.org's avatar
      2011-06-07 Lucas De Marchi <lucas.demarchi@profusion.mobi> · 82075114
      commit-queue@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [EFL] Remove Ecore_X bits from PlatformScreenEfl
              https://bugs.webkit.org/show_bug.cgi?id=61649
      
              Remove the need for Ecore_X and some X calls by always using
              new functions available in EFL to get the screen size.
      
              * Source/cmake/FindEFL.cmake: Bump ecore and ecore-evas versions.
      2011-06-07  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
      
              Reviewed by Antonio Gomes.
      
              [EFL] Remove Ecore_X bits from PlatformScreenEfl
              https://bugs.webkit.org/show_bug.cgi?id=61649
      
              Remove the need for Ecore_X and some X calls by always using
              new functions available in EFL to get the screen size.
      
              No new tests since the same functionality are done inside EFL now.
      
              * platform/efl/PlatformScreenEfl.cpp:
              (WebCore::screenRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82075114
    • carlosgc@webkit.org's avatar
      2011-06-07 Carlos Garcia Campos <cgarcia@igalia.com> · 9c8a9a96
      carlosgc@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Move moduleMixesGtkSymbols() from PluginPackage to PluginView
              https://bugs.webkit.org/show_bug.cgi?id=62200
      
              In WebKit2 PluginPackage is used by the UI process to load plugins
              in order to get information about them, but it doesn't use any GTK
              symbol. So the UI process should be able to load plugins even when
              building with GTK3, but we should not allow the plugin view to use
              the plugin if it mixes GTK2 and GTK3 symbols.
      
              * plugins/PluginPackage.h:
              (WebCore::PluginPackage::module): New method to return the
              platform module.
              * plugins/gtk/PluginPackageGtk.cpp:
              (WebCore::PluginPackage::load): Remove moduleMixesGtkSymbols().
              * plugins/gtk/PluginViewGtk.cpp:
              (WebCore::PluginView::updatePluginWidget): Check whether plugin
              was successfully loaded before trying to create the drawable.
              (WebCore::PluginView::paint): Return early if plugin didn't start
              or was not successfully loaded.
              (WebCore::PluginView::handleKeyboardEvent): Ditto.
              (WebCore::PluginView::handleMouseEvent): Ditto.
              (WebCore::PluginView::handleFocusInEvent): Ditto.
              (WebCore::PluginView::handleFocusOutEvent): Ditto.
              (WebCore::moduleMixesGtkSymbols):
              (WebCore::PluginView::platformStart): Check whether module is
              mixing GTK+ 2 and GTK+ 3 symbols.
      2011-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Move moduleMixesGtkSymbols() from PluginPackage to PluginView
              https://bugs.webkit.org/show_bug.cgi?id=62200
      
              In WebKit2 PluginPackage is used by the UI process to load plugins
              in order to get information about them, but it doesn't use any GTK
              symbol. So the UI process should be able to load plugins even when
              building with GTK3, but we should not allow the plugin view to use
              the plugin if it mixes GTK2 and GTK3 symbols.
      
              * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
              (WebKit::moduleMixesGtkSymbols):
              (WebKit::NetscapePlugin::platformPostInitialize): Check whether
              the module is mixing GTK+ 2 and GTK+ 3 symbols.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c8a9a96
    • commit-queue@webkit.org's avatar
      2011-06-07 Sheriff Bot <webkit.review.bot@gmail.com> · 9454154c
      commit-queue@webkit.org authored
              Unreviewed, rolling out r88238.
              http://trac.webkit.org/changeset/88238
              https://bugs.webkit.org/show_bug.cgi?id=62216
      
              Broke a couple of inspector tests (Requested by apavlov on
              #webkit).
      
              * http/tests/inspector/inspect-iframe-from-different-domain.html:
              * inspector/elements/elements-delete-inline-style.html:
              * inspector/elements/elements-panel-styles.html:
              * inspector/styles/styles-add-invalid-property.html:
              * inspector/styles/styles-cancel-editing.html:
              * inspector/styles/styles-commit-editing.html:
              * inspector/styles/styles-computed-trace.html:
              * inspector/styles/styles-disable-inherited.html:
              * inspector/styles/styles-disable-then-change.html:
              * inspector/styles/styles-disable-then-delete.html:
              * inspector/styles/styles-disable-then-enable.html:
              * inspector/styles/styles-iframe.html:
              * inspector/styles/styles-update-from-js-expected.txt:
              * inspector/styles/styles-update-from-js.html:
              * inspector/styles/styles-url-linkify.html:
      2011-06-07  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r88238.
              http://trac.webkit.org/changeset/88238
              https://bugs.webkit.org/show_bug.cgi?id=62216
      
              Broke a couple of inspector tests (Requested by apavlov on
              #webkit).
      
              * inspector/front-end/StylesSidebarPane.js:
              (WebInspector.StylesSidebarPane.prototype.update):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9454154c
    • commit-queue@webkit.org's avatar
      2011-06-07 Dinu Jacob <dinu.jacob@nokia.com> · 52b68336
      commit-queue@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Inform ChromeClient touch events are not needed by the webpage when navigating away from the page instead of in both Document:detach/CachedFrame
              https://bugs.webkit.org/show_bug.cgi?id=61543
      
              Inform chrome client that touch events are not needed by the webpage
              when navigating away from the page only once to avoid the flag being
              overwritten later if a page is removed from the page cache
      
              * dom/Document.cpp:
              (WebCore::Document::detach):
              * history/CachedFrame.cpp:
              (WebCore::CachedFrame::CachedFrame):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::transitionToCommitted):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52b68336
    • commit-queue@webkit.org's avatar
      2011-06-07 Ryuan Choi <ryuan.choi@samsung.com> · e8ae9bd7
      commit-queue@webkit.org authored
              Reviewed by Antonio Gomes.
      
              [EFL] Remove JSC dependency from WebKit/efl
              https://bugs.webkit.org/show_bug.cgi?id=62173
      
              Change JSC::initializeThreading() and WTF::initializeMainThread() to
              WebCore::ScriptController::initializeThreading() which contains these
              functions and remove JSC dependency to build webkit/efl with v8.
      
              * ewk/ewk_main.cpp:
              (_ewk_init_body):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8ae9bd7
    • xan@webkit.org's avatar
      2011-06-07 Xan Lopez <xlopez@igalia.com> · 8d7a1229
      xan@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] "webkithittestresult.h" is malformed
              https://bugs.webkit.org/show_bug.cgi?id=62117
      
              * webkit/webkithittestresult.h: fix typo in GET_CLASS macro.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d7a1229
    • apavlov@chromium.org's avatar
      2011-06-07 Alexander Pavlov <apavlov@chromium.org> · f7d4d69e
      apavlov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: node selection is slow in the Elements panel.
              https://bugs.webkit.org/show_bug.cgi?id=60813
      
              * http/tests/inspector/inspect-iframe-from-different-domain.html:
              * inspector/elements/elements-delete-inline-style.html:
              * inspector/elements/elements-panel-styles.html:
              * inspector/styles/styles-add-invalid-property.html:
              * inspector/styles/styles-cancel-editing.html:
              * inspector/styles/styles-commit-editing.html:
              * inspector/styles/styles-computed-trace.html:
              * inspector/styles/styles-disable-inherited.html:
              * inspector/styles/styles-disable-then-change.html:
              * inspector/styles/styles-disable-then-delete.html:
              * inspector/styles/styles-disable-then-enable.html:
              * inspector/styles/styles-iframe.html:
              * inspector/styles/styles-update-from-js-expected.txt:
              * inspector/styles/styles-update-from-js.html:
              * inspector/styles/styles-url-linkify.html:
      2011-06-07  Alexander Pavlov  <apavlov@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: node selection is slow in the Elements panel.
              https://bugs.webkit.org/show_bug.cgi?id=60813
      
              Schedule full style updates rather than request all node styles from the backend immediately.
      
              * inspector/front-end/StylesSidebarPane.js:
              (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles):
              (WebInspector.StylesSidebarPane.prototype.update):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7d4d69e
    • yurys@chromium.org's avatar
      2011-06-07 Yury Semikhatsky <yurys@chromium.org> · 95d450f7
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: remove duplicate breakpoints from localStorage
              https://bugs.webkit.org/show_bug.cgi?id=62206
      
              Perform one-time breakpoint storage cleanup to get rid of duplicate breakpoints in
              case when settings version is less than 1.
      
              * inspector/front-end/Settings.js:
              (WebInspector.Settings):
              (WebInspector.Settings.prototype._set):
              (WebInspector.Settings.prototype._migrateSettings.splitObjects):
              (WebInspector.Settings.prototype._migrateSettings.removeDuplicateObjects):
              (WebInspector.Settings.prototype._migrateSettings):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95d450f7
    • ossy@webkit.org's avatar
      [WK2] Unreviewed. Skip failing tests because of unimplemented features. · 7005e59c
      ossy@webkit.org authored
      * platform/mac-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7005e59c
    • yurys@chromium.org's avatar
      2011-06-03 Yury Semikhatsky <yurys@chromium.org> · f39b192f
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              [Chromium] Web Inspector: correctly handle disconnect from worker when script execution is paused
              https://bugs.webkit.org/show_bug.cgi?id=62019
      
              Dispatch disconnecFrontend message in debugger task mode to make sure
              it is processed even if execution is paused.
      
              * bindings/v8/WorkerScriptDebugServer.cpp:
              (WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
              (WebCore::WorkerScriptDebugServer::quitMessageLoopOnPause):
              * bindings/v8/WorkerScriptDebugServer.h:
      2011-06-03  Yury Semikhatsky  <yurys@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              [Chromium] Web Inspector: correctly handle disconnect from worker when script execution is paused
              https://bugs.webkit.org/show_bug.cgi?id=62019
      
              Dispatch disconnecFrontend message in debugger task mode to make sure
              it is processed even if execution is paused.
      
              * src/WebWorkerImpl.cpp:
              (WebKit::WebWorkerImpl::detachDevTools):
              (WebKit::WebWorkerImpl::dispatchDevToolsMessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f39b192f
    • commit-queue@webkit.org's avatar
      2011-06-07 Felician Marton <marton.felician.zoltan@stud.u-szeged.hu> · d14d5ff7
      commit-queue@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              SVG animation beginElement() does not restart the animation after endElement().
              https://bugs.webkit.org/show_bug.cgi?id=43452
      
              Added test for animation beginElement. It should restart the animation even if the animation is stopped by endElement() previously.
      
              * svg/animations/animate-endElement-beginElement-expected.txt: Added.
              * svg/animations/animate-endElement-beginElement.html: Added.
              * svg/animations/script-tests/animate-endElement-beginElement.js: Added.
      2011-06-07  Felician Marton  <marton.felician.zoltan@stud.u-szeged.hu>
      
              Reviewed by Nikolas Zimmermann.
      
              SVG animation beginElement() does not restart the animation after endElement().
              https://bugs.webkit.org/show_bug.cgi?id=43452
      
              Test: svg/animations/animate-endElement-beginElement.html
      
              Calling beginElement() after calling endElement() previously does not restarted the animation when animation
              element's end attribute doesn't contains a bigger value than the current animation time.
      
              * svg/animation/SVGSMILElement.cpp:
              (WebCore::SVGSMILElement::findInstanceTime):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d14d5ff7
    • andreas.kling@nokia.com's avatar
      2011-06-07 Andreas Kling <andreas.kling@nokia.com> · ae3f3e10
      andreas.kling@nokia.com authored
              Reviewed by Laszlo Gombos.
      
              [Qt] Fix Symbian build with RVCT 2.x
              https://bugs.webkit.org/show_bug.cgi?id=62205
      
              RVCT 2.x doesn't support (or need) the --signed_bitfields command-line
              option, so restrict it to version 4.x of the compiler.
      
              * Source/WebKit.pri:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae3f3e10
    • commit-queue@webkit.org's avatar
      2011-06-07 Naoki Takano <takano.naoki@gmail.com> · a64e65ad
      commit-queue@webkit.org authored
              Reviewed by Kent Tamura.
      
              [Chromium] Click event is not fired for a menulist <select>
              https://bugs.webkit.org/show_bug.cgi?id=60563
      
              Tests: SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange in webkit_unit_tests.
      
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupContainer::showPopup): Set m_focusedNode from m_frameView.
              (WebCore::PopupListBox::handleMouseReleaseEvent): Call dispatchMouseEvent to forward the event only if select popup.
              (WebCore::PopupListBox::acceptIndex): Change to return accepted or not.
      2011-06-07  Naoki Takano  <takano.naoki@gmail.com>
      
              Reviewed by Kent Tamura.
      
              [Chromium] Click event is not fired for a menulist <select>
              https://bugs.webkit.org/show_bug.cgi?id=60563
      
              * tests/PopupMenuTest.cpp:
              (WebKit::TestPopupMenuClient::TestPopupMenuClient): Initialize m_node.
              (WebKit::TestPopupMenuClient::valueChanged): To fire 'change' event, forward the event like RenderMenuList.
              (WebKit::TestPopupMenuClient::itemIsEnabled): Change to return true or false according to disabled item or not.
              (WebKit::TestPopupMenuClient::setDisabledIndex): Set disabled index to simulate disabled item.
              (WebKit::TestPopupMenuClient::setFocusedNode): Set focused node to dispatch the event.
              (WebKit::SelectPopupMenuTest::SelectPopupMenuTest): Add baseURL.
              (WebKit::SelectPopupMenuTest::TearDown): Add UnregisterAllMockedURLs() call.
              (WebKit::SelectPopupMenuTest::registerMockedURLLoad): To simulate html load, call RegisterMockedURL().
              (WebKit::SelectPopupMenuTest::serveRequests): Call ServeAsynchronousMockedRequests().
              (WebKit::SelectPopupMenuTest::loadFrame): Simulate load frame with url string.
              (WebKit::TEST_F): Implement SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange.
              * tests/data/select_event.html: Added for SelectItemEventFire and SelectItemKeyEvent.
              * tests/data/select_event_remove_on_change.html: Added SelectItemRemoveSelectOnChange.
              * tests/data/select_event_remove_on_click.html: Added SelectItemRemoveSelectOnChange.
              * WebKit.gyp: Added PopupMenuTest.cpp. Because webkit_support dependency is added, we can't build PopupMenuTest.cpp with Chromium-win (shared) configuration.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a64e65ad
    • abecsi@webkit.org's avatar
      2011-06-07 Andras Becsi <abecsi@webkit.org> · b585bc9d
      abecsi@webkit.org authored
              Reviewed by Yury Semikhatsky.
      
              REGRESSION(r88221): "Chromium debug compilation broken".
              https://bugs.webkit.org/show_bug.cgi?id=62197
      
              No new tests needed.
      
              * bindings/v8/V8GCController.cpp: Also rename call-sites.
              (WebCore::V8GCController::gcPrologue):
              (WebCore::V8GCController::gcEpilogue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b585bc9d
    • morrita@google.com's avatar
      2011-06-07 MORITA Hajime <morrita@google.com> · 33baef08
      morrita@google.com authored
              Unreviewed Skipped entry addition following r88225.
      
              * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33baef08
    • morrita@google.com's avatar
      2011-06-07 MORITA Hajime <morrita@google.com> · 606f64cc
      morrita@google.com authored
              Unreviewed, rolling out r88212 and r88219.
              http://trac.webkit.org/changeset/88212
              http://trac.webkit.org/changeset/88219
              https://bugs.webkit.org/show_bug.cgi?id=57439
      
              Tests get timeout on Snow Leopard
      
              * fast/replaced/no-focus-ring-embed-1-expected.txt: Removed.
              * fast/replaced/no-focus-ring-embed-1.html: Removed.
              * fast/replaced/no-focus-ring-embed-2-expected.txt: Removed.
              * fast/replaced/no-focus-ring-embed-2.html: Removed.
              * fast/replaced/no-focus-ring-iframe-expected.txt: Removed.
              * fast/replaced/no-focus-ring-iframe.html: Removed.
              * fast/replaced/no-focus-ring-object-1-expected.txt: Removed.
              * fast/replaced/no-focus-ring-object-1.html: Removed.
              * fast/replaced/no-focus-ring-object-2-expected.txt: Removed.
              * fast/replaced/no-focus-ring-object-2.html: Removed.
              * fast/replaced/outline-replaced-elements-expected.txt: Removed.
              * fast/replaced/outline-replaced-elements.html: Removed.
              * fast/replaced/resources/focus-test.js: Removed.
              * platform/mac/fast/replaced/outline-replaced-elements-expected.png: Removed.
      2011-06-07  MORITA Hajime  <morrita@google.com>
      
              Unreviewed, rolling out r88212 and r88219.
              http://trac.webkit.org/changeset/88212
              http://trac.webkit.org/changeset/88219
              https://bugs.webkit.org/show_bug.cgi?id=57439
      
              Tests get timeout at Snow Leopard
      
              * css/html.css:
              (html:focus, body:focus, input[readonly]:focus):
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::paint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      606f64cc
    • mario@webkit.org's avatar
      2011-06-07 Mario Sanchez Prada <msanchez@igalia.com> · c508b8b9
      mario@webkit.org authored
              Unreviewed, added new baseline for GTK after r88175.
      
              * platform/gtk/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
              * platform/gtk/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c508b8b9
    • mario@webkit.org's avatar
      2011-06-07 Mario Sanchez Prada <msanchez@igalia.com> · d5f297aa
      mario@webkit.org authored
              Unreviewed, skip tests crashing in GTK bots because of an ASSERT.
      
              Also relocated one skipped test into its right category, together
              with the new one being skipped now.
      
              * platform/gtk/Skipped: SKipped test
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5f297aa
    • morrita@google.com's avatar
      2011-06-06 MORITA Hajime <morrita@google.com> · 7333a2bb
      morrita@google.com authored
              Reviewed by Kent Tamura.
      
              Verify cloning <details> and <summary> works.
              https://bugs.webkit.org/show_bug.cgi?id=61985
      
              * fast/html/details-clone-expected.txt: Added.
              * fast/html/details-clone.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7333a2bb
    • abecsi@webkit.org's avatar
      2011-06-07 Andras Becsi <abecsi@webkit.org> · f96674be
      abecsi@webkit.org authored
              Rubber-stamped by Csaba Osztrogonác.
      
              [Qt][V8] Fix the build after 88221.
      
              No new tests needed.
      
              * WebCore.pro: Remove non-existing files.
              * bindings/v8/V8DOMMap.cpp:
              (WebCore::removeAllDOMObjects): Also rename the definition of the function.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f96674be
    • commit-queue@webkit.org's avatar
      2011-06-06 Sheriff Bot <webkit.review.bot@gmail.com> · 8c9ab4bf
      commit-queue@webkit.org authored
              Unreviewed, rolling out r88222.
              http://trac.webkit.org/changeset/88222
              https://bugs.webkit.org/show_bug.cgi?id=62192
      
              Broke compile on Mac (Requested by abarth on #webkit).
      
              * Scripts/webkit2/messages.py:
              * Shared/WebCoreArgumentCoders.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c9ab4bf
    • noam.rosenthal@nokia.com's avatar
      2011-06-06 Noam Rosenthal <noam.rosenthal@nokia.com> · 8c80cc5f
      noam.rosenthal@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
              https://bugs.webkit.org/show_bug.cgi?id=61694
      
              Add ArgumentCoders for TransformOperation, including all the subclasses,
              and TransformOperations.
      
              * Scripts/webkit2/messages.py:
              * Shared/WebCoreArgumentCoders.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c80cc5f
    • commit-queue@webkit.org's avatar
      2011-06-06 Dmitry Lomov <dslomov@google.com> · ed8644a2
      commit-queue@webkit.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=62164
              Remove "multi-threaded" logic in V8 DOMData, DOMDataStore and friends
              This functionality is untested and unused:
              This is an old code from Lockers-based implementation of WebWorkers in
              V8 bindings, to make sure that DOM objects are released on the right thread
              even though GC could have happened on any thread. It is currently unused (since
              current model is one worker per process) and is being removed because new implementation
              of WebWorkers will be using V8 isolates.
      
              * WebCore.gypi:
              * bindings/v8/ChildThreadDOMData.cpp: Removed.
              * bindings/v8/ChildThreadDOMData.h: Removed.
              * bindings/v8/DOMData.cpp:
              (WebCore::DOMData::DOMData):
              (WebCore::DOMData::getCurrent):
              (WebCore::DOMData::getMainThreadStore):
              * bindings/v8/DOMData.h:
              (WebCore::DOMData::getStore):
              (WebCore::DOMData::getCurrentMainThreadStore):
              (WebCore::DOMData::handleWeakObject):
              * bindings/v8/DOMDataStore.cpp:
              (WebCore::DOMDataStore::DOMDataStore):
              (WebCore::DOMDataStore::~DOMDataStore):
              (WebCore::DOMDataStore::weakNodeCallback):
              * bindings/v8/DOMDataStore.h:
              * bindings/v8/MainThreadDOMData.cpp: Removed.
              * bindings/v8/MainThreadDOMData.h: Removed.
              * bindings/v8/V8DOMMap.cpp:
              (WebCore::getDOMDataStore):
              (WebCore::visitDOMNodes):
              (WebCore::visitDOMObjects):
              (WebCore::visitActiveDOMObjects):
              (WebCore::visitDOMSVGElementInstances):
              * bindings/v8/V8DOMMap.h:
              * bindings/v8/V8GCController.cpp:
              (WebCore::V8GCController::gcPrologue):
              (WebCore::V8GCController::gcEpilogue):
              * bindings/v8/WorkerScriptController.cpp:
              (WebCore::WorkerScriptController::~WorkerScriptController):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed8644a2
    • thakis@chromium.org's avatar
      2011-06-06 Nico Weber <thakis@chromium.org> · 0e53ed43
      thakis@chromium.org authored
              Reviewed by Adam Barth.
      
              [chromium] Make VideoFrameChromium's destructor virtual
              https://bugs.webkit.org/show_bug.cgi?id=62186
      
              This fixes a real bug, since WebMediaPlayerClientImpl::putCurrentFrame
              deletes a VideoFrameChromium subclass type through this interface
              class, causing ~VideoFrameChromiumImpl's destructor not to run.
              (VideoFrameChroimumImpl happens to not have a destructor or any
              non-POD member variables, so it's more a latent bug.)
      
              * platform/graphics/chromium/VideoFrameChromium.cpp:
              (WebCore::VideoFrameChromium::~VideoFrameChromium):
              * platform/graphics/chromium/VideoFrameChromium.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e53ed43
  2. 06 Jun, 2011 15 commits