1. 21 Jan, 2011 36 commits
    • aroben@apple.com's avatar
      Rename WKCACFLayerRenderer[Client] to CACFLayerTreeHost[Client] · d0defa32
      aroben@apple.com authored
      Also renamed a few functions and data members to match.
      
      Fixes <http://webkit.org/b/52898> WKCACFLayerRenderer sounds like a render object, but isn't
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      * WebCore.vcproj/WebCore.vcproj: Updated files' names and paths.
      
      * WebCore.vcproj/WebCoreQuartzCore.vsprops: Added platform/graphics/ca/win to the include
      path.
      
      * WebCore.vcproj/copyForwardingHeaders.cmd: Copy headers from platform/graphics/ca/win, too.
      
      * platform/graphics/ca/win/CACFLayerTreeHost.cpp: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.cpp.
      * platform/graphics/ca/win/CACFLayerTreeHost.h: Renamed from Source/WebCore/platform/graphics/win/WKCACFLayerRenderer.h.
      
      * platform/graphics/ca/win/PlatformCALayerWin.cpp:
      * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
      * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
      Updated for renames.
      
      Source/WebKit/win:
      
      Update for WKCACFLayerRenderer -> CACFLayerTreeHost rename
      
      Also renamed WebView::m_layerRenderer to WebView::m_layerTreeHost to match.
      
      * WebPreferences.cpp:
      * WebView.cpp:
      (WebView::setAcceleratedCompositing): Also made sure to remove our HWND from the layer tree
      host before we get rid of the layer tree host itself.
      * WebView.h:
      
      Source/WebKit2:
      
      Update for WKCACFLayerRenderer -> CACFLayerView rename
      
      * WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp: Just removed all the unnecessary
       #includes.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0defa32
    • xan@webkit.org's avatar
      2011-01-21 Xan Lopez <xlopez@igalia.com> · e08a35f7
      xan@webkit.org authored
              Reviewed by Martin Robinson.
      
              Remove unnecessary <stdio.h> include
              https://bugs.webkit.org/show_bug.cgi?id=52884
      
              * jit/JIT.cpp: remove unnecessary include.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e08a35f7
    • commit-queue@webkit.org's avatar
      2011-01-21 Patrick Gansterer <paroga@paroga.com> · 6e0c4d42
      commit-queue@webkit.org authored
              Original patch from François Sausset  <sausset@gmail.com>
      
              Reviewed by Darin Adler.
      
              Code cleaning in rendering/mathml/RenderMathMLFraction.cpp
              https://bugs.webkit.org/show_bug.cgi?id=52201
      
              Replace unneeded doubles by floats and remove unneeded casts.
      
              * rendering/mathml/RenderMathMLFraction.cpp:
              (WebCore::RenderMathMLFraction::paint):
              * rendering/mathml/RenderMathMLFraction.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76368 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e0c4d42
    • levin@chromium.org's avatar
      Proposal: Require cross-organizational seconds for reviewer nominations · 306fbc54
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=47597
      
      Reviewed by Darin Adler.
      
      This changes the committer/reviewer policy to require an additional
      reviewer supporting a reviewer nomination to work for a different
      company and different project affiliation from the nominee.
      
      This means reviewer nominations would require four supporting reviewers,
      one of which knows the reviewer through the community (irc, email, bugs)
      ensuring that the nominee has the open-source collaboration skills
      we so highly value here in WebKit.
      
      * coding/commit-review-policy.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      306fbc54
    • dglazkov@chromium.org's avatar
      2011-01-21 Dimitri Glazkov <dglazkov@chromium.org> · b06e5712
      dglazkov@chromium.org authored
              Reviewed by Darin Adler.
      
              REGRESSION(r73618): Clicking on a search input causes a crash.
              https://bugs.webkit.org/show_bug.cgi?id=52905
      
              * fast/dom/search-shadow-host-crash-expected.txt: Added.
              * fast/dom/search-shadow-host-crash.html: Added.
      2011-01-21  Dimitri Glazkov  <dglazkov@chromium.org>
      
              Reviewed by Darin Adler.
      
              REGRESSION(r73618): Clicking on a search input causes a crash.
              https://bugs.webkit.org/show_bug.cgi?id=52905
      
              The problem is caused by TextControlInnerElement being used both as
              shadow root and an element in a shadow subtree. The code assumed it is
              only used as a shadow root.
      
              Since this code is all just workaround for in-progress conversion to
              new shadow DOM, I am just adding a check. This code will disappear
              completely once bug 52788 is fixed.
      
              Test: fast/dom/search-shadow-host-crash.html
      
              * dom/Node.cpp:
              (WebCore::Node::setShadowHost): Added an ASSERT for early detection
                  of attempting to stomp on the parentNode.
              * rendering/TextControlInnerElements.cpp:
              (WebCore::TextControlInnerElement::detach): Added a check to only
                  clear shadow host if we have one.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b06e5712
    • dglazkov@chromium.org's avatar
      2011-01-21 Dimitri Glazkov <dglazkov@chromium.org> · 4bfecc51
      dglazkov@chromium.org authored
              Updated slider expectations after r76147.
      
              * platform/chromium/test_expectations.txt: Removed test that will start passing.
              * platform/chromium-win/fast/forms/slider-mouse-events-expected.txt: Updated expectation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bfecc51
    • xji@chromium.org's avatar
      2011-01-21 Xiaomei Ji <xji@chromium.org> · 28bc4e4e
      xji@chromium.org authored
              Unreviewed.
      
              Rebaseline for leopard after r76319.
      
              * platform/mac-leopard/fast/dom/52776-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28bc4e4e
    • tony@chromium.org's avatar
      2011-01-21 Tony Chang <tony@chromium.org> · 9cb4c57a
      tony@chromium.org authored
              Unreviewed, updating chromium DEPS so we can pull in linux theme changes.
      
              * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cb4c57a
    • darin@apple.com's avatar
      Fix Mac build. · 09706441
      darin@apple.com authored
      * MiniBrowser/mac/BrowserWindowController.m:
      (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09706441
    • darin@apple.com's avatar
      WebKit2: Implement showModalDialog · 3ed100bb
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52855
      
      Reviewed by Dan Bernstein.
      
      Source/WebKit2: 
      
      * Shared/WebPageCreationParameters.h: Added canRunModal.
      
      * UIProcess/API/C/WKPage.h: Added a runModal function pointer to
      WKPageUIClient. Also removed a lot of redundant typedefs and added
      a new one, WKPageCallback, for callbacks without arguments or return
      values.
      
      * UIProcess/API/qt/qwkpage.cpp:
      (QWKPage::QWKPage): Added a runModal function pointer of 0.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::creationParameters): Set canRunModal
      based on return value of WebUIClient::canRunModal.
      
      * UIProcess/WebPageProxy.h: Added runModal.
      Calls WebUIClient::runModal.
      
      * UIProcess/WebPageProxy.messages.in: Added RunModal message.
      Also removed the periods from the phrases in the comments
      as Maciej requested a while back.
      
      * UIProcess/WebUIClient.cpp:
      (WebKit::WebUIClient::canRunModal): Added. Returns true or false
      based on whether a runModal function was supplied in the
      WKPageUIClient structure.
      (WebKit::WebUIClient::runModal): Added. Calls the runModal
      function from the WKPageUIClient structure.
      * UIProcess/WebUIClient.h: Declared the above functions.
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::canRunModal): Call through to WebPage.
      (WebKit::WebChromeClient::runModal): Ditto.
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage): Initialize m_canRunModal based on the
      creation parameters. Initialize m_isRunningModal to false.
      (WebKit::WebPage::close): Stop the nested run loop if we are running modal.
      (WebKit::WebPage::runModal): Send a message to ask the UI process to run
      modal and then start a nested run loop. It gets stopped when the page is closed.
      * WebProcess/WebPage/WebPage.h: Defined the canRunModal function
      and declared the runModal function.
      
      Tools: 
      
      This fixes WebKitTestRunner to compile, but more work is probably
      needed to get it to pass the tests.
      
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::runModal): Added. Calls through to the
      platform-specific version of runModal.
      (WTR::TestController::createOtherPage): Changed to be a private
      static member function so it can refer to runModal, which is
      a private static member function.
      (WTR::TestController::initialize): Pass 0 for the runModal
      function since we don't need to run the main window modal.
      I suspect this is wrong and will need to change.
      * WebKitTestRunner/TestController.h: Added declarations for
      the functions added above.
      * WebKitTestRunner/mac/TestControllerMac.mm:
      (WTR::TestController::runModal): Added. Untested implementation.
      * WebKitTestRunner/qt/TestControllerQt.cpp:
      (WTR::TestController::runModal): Added.
      * WebKitTestRunner/win/TestControllerWin.cpp:
      (WTR::TestController::runModal): Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ed100bb
    • commit-queue@webkit.org's avatar
      2011-01-21 Kenji Imasaki <imasaki@chromium.org> · f3809d85
      commit-queue@webkit.org authored
              Reviewed by David Levin.
      
              remove non-flaky tests from test expectation file
              https://bugs.webkit.org/show_bug.cgi?id=52746
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3809d85
    • aroben@apple.com's avatar
      Replace some "sync compositing state" terminology with "flush pending GraphicsLayer changes" · 4b7ddcc7
      aroben@apple.com authored
      This seems to be the direction in which our code is moving. I chose "GraphicsLayer" as
      opposed to just "layer" because there are cases where we flush changes to CACFLayers that
      don't have a corresponding GraphicsLayer.
      
      Fixes <http://webkit.org/b/52894> "Sync compositing state" terminology in
      WKCACFLayerRenderer and friends is confusing
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      * platform/graphics/win/WKCACFLayerRenderer.cpp:
      (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
      (WebCore::WKCACFLayerRenderer::render):
      Updated for renames.
      
      (WebCore::WKCACFLayerRenderer::flushPendingGraphicsLayerChangesSoon): Renamed from
      syncCompositingStateSoon, and updated for other renames.
      
      * platform/graphics/win/WKCACFLayerRenderer.h: Renamed m_syncLayerChanges to
      * m_shouldFlushPendingGraphicsLayerChanges.
      (WebCore::WKCACFLayerRendererClient::flushPendingGraphicsLayerChanges): Renamed from
      syncCompositingState.
      
      Source/WebKit/win:
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::scheduleCompositingLayerSync): Updated for WebView changes.
      
      * WebView.cpp:
      (WebView::paint): Updated for rename.
      (WebView::flushPendingGraphicsLayerChangesSoon): Renamed from scheduleCompositingLayerSync.
      (WebView::notifySyncRequired): Updated for rename.
      (WebView::flushPendingGraphicsLayerChanges): Renamed from syncCompositingState.
      
      * WebView.h: Did the renames.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b7ddcc7
    • aroben@apple.com's avatar
      Clean up PlatformCAAnimationWin · 9b984730
      aroben@apple.com authored
      Fixes <http://webkit.org/b/52904> PlatformCAAnimationWin is leaky and inefficient
      
      Reviewed by Simon Fraser.
      
      * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
      (toCACFFillModeType):
      (fromCACFFillModeType):
      (toCACFValueFunctionType):
      (fromCACFValueFunctionType):
      Changed to take and return CFStringRefs. There's no need to convert to WebCore::String just
      so we can later convert back to CFStringRef.
      
      (toCACFTimingFunction): Fixed leaks by changing this to return a RetainPtr and adopting the
      results of CACFTimingFunctionCreate.
      (PlatformCAAnimation::PlatformCAAnimation): Changed not to needlessly roundtrip through
      WebCore::String. Also changed an ASSERT(0) to ASSERT_NOT_REACHED().
      
      (PlatformCAAnimation::setFillMode):
      (PlatformCAAnimation::setTimingFunction):
      (PlatformCAAnimation::setValueFunction):
      (PlatformCAAnimation::setTimingFunctions):
      Updated for changes to the above conversion functions.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b984730
    • commit-queue@webkit.org's avatar
      2011-01-21 Charlie Reis <creis@chromium.org> · 987fd772
      commit-queue@webkit.org authored
              Reviewed by Darin Fisher.
      
              FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
              https://bugs.webkit.org/show_bug.cgi?id=48812
      
              Test that we avoid updating back/forward list on a canceled navigation
              if a new navigation is already in process.  Also update forward-and-cancel
              to go forward, ensuring back/forward state is reset if user clicks stop.
      
              * http/tests/navigation/back-twice-without-commit-expected.txt: Added.
              * http/tests/navigation/back-twice-without-commit.html: Added.
              * http/tests/navigation/forward-and-cancel-expected.txt:
              * http/tests/navigation/forward-and-cancel.html: Go forward after stop, not back.
              * http/tests/navigation/resources/back-twice-page-2.html: Added.
              * http/tests/navigation/resources/back-twice-page-3.html: Added.
              * http/tests/navigation/resources/forward-and-cancel-frames.html: Reduced delay.
      2011-01-21  Charlie Reis  <creis@chromium.org>
      
              Reviewed by Darin Fisher.
      
              FrameLoader::checkLoadCompleteForThisFrame uses wrong history item
              https://bugs.webkit.org/show_bug.cgi?id=48812
      
              Most calls to stopAllLoaders now clear the history's provisional item(s).
              We can now avoid resetting the back/forward state if a new navigation
              is in progress.
      
              Test: http/tests/navigation/back-twice-without-commit.html
              Test: http/tests/navigation/forward-and-cancel.html
      
              * loader/FrameLoader.cpp:
              * loader/FrameLoader.h:
              * loader/FrameLoaderTypes.h:
              * WebCore.exp.in: Update stopAllLoaders signature.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      987fd772
    • mihaip@chromium.org's avatar
      2011-01-20 Mihai Parparita <mihaip@chromium.org> · f6cc8ed6
      mihaip@chromium.org authored
              Reviewed by Eric Seidel.
      
              [Chromium] Update expectations for compositing/geometry/limit-layer-bounds-overflow-repaint.html
              https://bugs.webkit.org/show_bug.cgi?id=52860
      
              The test hasn't had a timeout in a while, remove that expectation so
              that we can more easily see if this re-occurs.
      
              Also rebaseline for chromium-gpu-mac (it has the green as 0,128,0, just
              like chromium-gpu-win and -linux, for some reason the mac expectation
              has it as 17,128,4).
      
              * platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Removed.
              * platform/chromium-gpu-win/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Removed.
              * platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.checksum.
              * platform/chromium-gpu/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png: Renamed from LayoutTests/platform/chromium-gpu-linux/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png.
              * platform/chromium-gpu/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6cc8ed6
    • rniwa@webkit.org's avatar
      2011-01-21 Ryosuke Niwa <rniwa@webkit.org> · f1183874
      rniwa@webkit.org authored
              Unreviewed; Reverted the last change to the text expectation.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1183874
    • rniwa@webkit.org's avatar
      2011-01-21 Ryosuke Niwa <rniwa@webkit.org> · 77f00f66
      rniwa@webkit.org authored
              Unreviewed Chromium test expectation update.
      
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77f00f66
    • rniwa@webkit.org's avatar
      2011-01-21 Ryosuke Niwa <rniwa@webkit.org> · ba438915
      rniwa@webkit.org authored
              Unreviewed Chromium rebaselines for 76319.
      
              * platform/chromium-linux/fast/dom/52776-expected.checksum: Added.
              * platform/chromium-linux/fast/dom/52776-expected.png: Added.
              * platform/chromium-linux/fast/dom/52776-expected.txt: Added.
              * platform/chromium-mac/fast/dom/52776-expected.checksum: Added.
              * platform/chromium-mac/fast/dom/52776-expected.png: Added.
              * platform/chromium-mac/fast/dom/52776-expected.txt: Added.
              * platform/chromium-win/fast/dom/52776-expected.checksum: Added.
              * platform/chromium-win/fast/dom/52776-expected.png: Added.
              * platform/chromium-win/fast/dom/52776-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba438915
    • tony@chromium.org's avatar
      2011-01-21 Tony Chang <tony@chromium.org> · 41456563
      tony@chromium.org authored
              Unreviewed, these tests were fixed in r76330.  Still one unknown
              failure.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41456563
    • carlosgc@webkit.org's avatar
      2011-01-21 Carlos Garcia Campos <cgarcia@igalia.com> · 2988e573
      carlosgc@webkit.org authored
              Reviewed by Martin Robinson.
      
              [GTK] Show caps lock indicator in password fields
              https://bugs.webkit.org/show_bug.cgi?id=52878
      
              Test: manual-tests/password-caps-lock.html
      
              * platform/gtk/KeyEventGtk.cpp:
              (WebCore::PlatformKeyboardEvent::currentCapsLockState): Implement
              currentCapsLockState() using GDK API.
              * platform/gtk/RenderThemeGtk.cpp:
              (WebCore::RenderThemeGtk::paintCapsLockIndicator): Paint an icon
              in the password field when the caps lock modifier is locked.
              * platform/gtk/RenderThemeGtk.h:
      2011-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
      
              Reviewed by Martin Robinson.
      
              [GTK] Show caps lock indicator in password fields
              https://bugs.webkit.org/show_bug.cgi?id=52878
      
              Test: manual-tests/password-caps-lock.html
      
              * webkit/webkitwebview.cpp:
              (webkit_web_view_key_release_event): Call
              capsLockStateMayHaveChanged() when caps lock key is pressed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2988e573
    • jberlin@webkit.org's avatar
      Modify the Windows-specific results after http://trac.webkit.org/changeset/76208 in order to · 955e4a72
      jberlin@webkit.org authored
      get the bots green. Unreviewed.
      https://bugs.webkit.org/show_bug.cgi?id=52557
      
      * platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
      * platform/win/fast/dom/prototype-inheritance-2-expected.txt:
      * platform/win/fast/dom/prototype-inheritance-expected.txt:
      * platform/win/fast/js/global-constructors-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      955e4a72
    • jberlin@webkit.org's avatar
      Add Windows-specific results for fast/dom/52776.html to get the bot green. Unreviewed. · 189e1c7d
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=52776
      
      * platform/win/fast/dom/52776-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      189e1c7d
    • podivilov@chromium.org's avatar
      2011-01-21 Pavel Podivilov <podivilov@chromium.org> · f949fa7f
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: move sticky breakpoints management from InspectorController to InspectorBrowserDebuggerAgent.
              https://bugs.webkit.org/show_bug.cgi?id=52874
      
              This is the first step of debugger api refactoring (see bug 52879).
              JavaScript breakpoints are still in the same list as native breakpoints and are restored by InspectorBrowserDebuggerAgent.
              The second step will be to move sticky JavaScript breakpoints to InspectorDebuggerAgent.
      
              * inspector/Inspector.idl:
              * inspector/InspectorBrowserDebuggerAgent.cpp:
              (WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
              (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
              (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::discardBindings):
              (WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
              (WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
              (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
              (WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
              * inspector/InspectorBrowserDebuggerAgent.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::restoreInspectorStateFromCookie):
              (WebCore::InspectorController::connectFrontend):
              (WebCore::InspectorController::didCommitLoad):
              (WebCore::InspectorController::enableDebugger):
              (WebCore::InspectorController::resume):
              (WebCore::InspectorController::inspectedURL):
              * inspector/InspectorController.h:
              * inspector/InspectorState.cpp:
              (WebCore::InspectorState::InspectorState):
              * inspector/InspectorState.h:
              * inspector/front-end/BreakpointManager.js:
              (WebInspector.BreakpointManager):
              (WebInspector.BreakpointManager.prototype._saveBreakpoints):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f949fa7f
    • jknotten@chromium.org's avatar
      2011-01-21 John Knottenbelt <jknotten@chromium.org> · 5fca8891
      jknotten@chromium.org authored
              Reviewed by Jeremy Orlow.
      
              Turn off uninitialized errors for ARM linux build.
              https://bugs.webkit.org/show_bug.cgi?id=52893
      
              Fix ARM compiler breakage.
      
              * WebCore.gyp/WebCore.gyp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fca8891
    • mnaganov@chromium.org's avatar
      2011-01-21 Mikhail Naganov <mnaganov@chromium.org> · 8c8802b9
      mnaganov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Add layout test for the CPU profiler.
      
              This test replaces DevToolsSanityTest.TestProfilerTab from
              Chromium's interactive_ui_tests.
      
              https://bugs.webkit.org/show_bug.cgi?id=52634
      
              * inspector/cpu-profiler-profiling-expected.txt: Added.
              * inspector/cpu-profiler-profiling.html: Added.
      
      [Relanding, this time the test should work in Chromium]
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c8802b9
    • mnaganov@chromium.org's avatar
      2011-01-21 Mikhail Naganov <mnaganov@chromium.org> · 83d221f9
      mnaganov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: [Chromium] REGRESSION: Using the "Back" button
              while profiling causes renderer crash.
      
              https://bugs.webkit.org/show_bug.cgi?id=52808
      
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
              (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83d221f9
    • loislo@chromium.org's avatar
      2011-01-20 Ilya Tikhonovsky <loislo@chromium.org> · 043f7d3c
      loislo@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.
      
              There are some places in WebCore where we still using direct InspectorController calls.
              The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
              Inspector facade for WebCore.
      
              https://bugs.webkit.org/show_bug.cgi?id=52869
      
              * inspector/InspectorController.cpp:
              * inspector/InspectorController.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::addProfileImpl):
              (WebCore::InspectorInstrumentation::profilerEnabledImpl):
              (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::addProfile):
              (WebCore::InspectorInstrumentation::profilerEnabled):
              (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
              * page/Console.cpp:
              (WebCore::Console::profile):
              (WebCore::Console::profileEnd):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      043f7d3c
    • ossy@webkit.org's avatar
      Unreviewed. · 7a5a5b6f
      ossy@webkit.org authored
      [Qt] editing/selection/rtl-move-selection-right-left.html fails
      https://bugs.webkit.org/show_bug.cgi?id=52883
      
      * platform/qt/Skipped: editing/selection/rtl-move-selection-right-left.html added until fix.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a5a5b6f
    • sergio@webkit.org's avatar
      2011-01-21 Sergio Villar Senin <svillar@igalia.com> · 42aa7803
      sergio@webkit.org authored
              Unreviewed.
      
              [GTK] http/tests/security/drag-drop-same-unique-origin.html fails on bots.
              https://bugs.webkit.org/show_bug.cgi?id=52882
      
              Skipping http/tests/security/drag-drop-same-unique-origin.html for gtk.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42aa7803
    • podivilov@chromium.org's avatar
      2011-01-12 Pavel Podivilov <podivilov@chromium.org> · 2343e67d
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: breakpoints are restored incorrectly when reverting live edit.
              https://bugs.webkit.org/show_bug.cgi?id=52300
      
              Fix breakpoints restoring when reverting to old revision by using text diff.
              Move live edit logic from ScriptsPanel to DebuggerModel.
              Eliminate unnecessary editLine delegate in TextViewer.
      
              * inspector/front-end/DebuggerModel.js:
              (WebInspector.DebuggerModel):
              (WebInspector.DebuggerModel.prototype.reset):
              (WebInspector.DebuggerModel.prototype.editScriptSource):
              (WebInspector.DebuggerModel.prototype._updateScriptSource):
              (WebInspector.DebuggerModel.prototype.get callFrames):
              (WebInspector.DebuggerModel.prototype.pausedScript):
              (WebInspector.DebuggerModel.prototype.resumedScript):
              * inspector/front-end/Script.js:
              (WebInspector.Script.prototype.get source):
              * inspector/front-end/ScriptView.js:
              (WebInspector.ScriptView):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame):
              (WebInspector.SourceFrame.prototype._createViewerIfNeeded):
              (WebInspector.SourceFrame.prototype._doubleClick.didEditLine):
              (WebInspector.SourceFrame.prototype._doubleClick):
              * inspector/front-end/SourceView.js:
              (WebInspector.SourceView):
              * inspector/front-end/TextViewer.js:
              (WebInspector.TextViewer):
              (WebInspector.TextViewer.prototype._handleKeyDown):
              (WebInspector.TextViewer.prototype.editLine.finishEditing):
              (WebInspector.TextViewer.prototype.editLine):
              (WebInspector.TextChunk.prototype._createRow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2343e67d
    • commit-queue@webkit.org's avatar
      2011-01-21 Adam Klein <adamk@chromium.org> · 4ceaac17
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              [chromium] Rename ChromiumBridge to PlatformBridge
              https://bugs.webkit.org/show_bug.cgi?id=52471
      
              No tests added as this is a rename; no change in behavior.
      
              * WebCore.gypi:
              * bindings/v8/V8DOMWindowShell.cpp:
              (WebCore::reportFatalErrorInV8):
              * page/PageGroup.cpp:
              (WebCore::PageGroup::isLinkVisited):
              * platform/android/PlatformBridge.h:
              * platform/audio/chromium/AudioBusChromium.cpp:
              (WebCore::createBusFromInMemoryAudioFile):
              * platform/chromium/ChromiumBridge.h: Removed.
              * platform/chromium/ChromiumDataObjectLegacy.cpp:
              (WebCore::ChromiumDataObjectLegacy::getData):
              * platform/chromium/DragDataChromium.cpp:
              (WebCore::DragData::asURL):
              * platform/chromium/FileSystemChromium.cpp:
              (WebCore::deleteFile):
              (WebCore::deleteEmptyDirectory):
              (WebCore::getFileSize):
              (WebCore::getFileModificationTime):
              (WebCore::revealFolderInOS):
              (WebCore::directoryName):
              (WebCore::pathByAppendingComponent):
              (WebCore::makeAllDirectories):
              (WebCore::fileExists):
              (WebCore::openFile):
              (WebCore::closeFile):
              (WebCore::seekFile):
              (WebCore::truncateFile):
              (WebCore::readFromFile):
              (WebCore::writeToFile):
              * platform/chromium/LanguageChromium.cpp:
              (WebCore::platformDefaultLanguage):
              * platform/chromium/LinkHashChromium.cpp:
              (WebCore::visitedLinkHash):
              * platform/chromium/MIMETypeRegistryChromium.cpp:
              (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
              (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
              (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
              (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
              (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
              * platform/chromium/PasteboardChromium.cpp:
              (WebCore::Pasteboard::writeSelection):
              (WebCore::Pasteboard::writePlainText):
              (WebCore::Pasteboard::writeURL):
              (WebCore::Pasteboard::writeImage):
              (WebCore::Pasteboard::canSmartReplace):
              (WebCore::Pasteboard::plainText):
              (WebCore::Pasteboard::documentFragment):
              * platform/chromium/PlatformBridge.h:
              * platform/chromium/PlatformScreenChromium.cpp:
              (WebCore::screenDepth):
              (WebCore::screenDepthPerComponent):
              (WebCore::screenIsMonochrome):
              (WebCore::screenRect):
              (WebCore::screenAvailableRect):
              * platform/chromium/ReadableDataObject.cpp:
              (WebCore::ReadableDataObject::getData):
              (WebCore::ReadableDataObject::urlTitle):
              (WebCore::ReadableDataObject::htmlBaseUrl):
              (WebCore::ReadableDataObject::filenames):
              (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
              * platform/chromium/SSLKeyGeneratorChromium.cpp:
              (WebCore::signedPublicKeyAndChallengeString):
              * platform/chromium/ScrollbarThemeChromium.cpp:
              * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
              (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
              (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
              (WebCore::ScrollbarThemeChromiumLinux::paintButton):
              (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
              (WebCore::ScrollbarThemeChromiumLinux::buttonSize):
              (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
              * platform/chromium/ScrollbarThemeChromiumMac.mm:
              (WebCore::scrollbarStateToThemeState):
              (WebCore::ScrollbarThemeChromiumMac::paint):
              * platform/chromium/ScrollbarThemeChromiumWin.cpp:
              (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
              (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
              (WebCore::ScrollbarThemeChromiumWin::paintButton):
              (WebCore::ScrollbarThemeChromiumWin::paintThumb):
              (WebCore::ScrollbarThemeChromiumWin::buttonSize):
              * platform/chromium/SharedTimerChromium.cpp:
              (WebCore::setSharedTimerFiredFunction):
              (WebCore::setSharedTimerFireTime):
              (WebCore::stopSharedTimer):
              * platform/chromium/SuddenTerminationChromium.cpp:
              (WebCore::disableSuddenTermination):
              (WebCore::enableSuddenTermination):
              * platform/chromium/SystemTimeChromium.cpp:
              (WebCore::currentTime):
              * platform/chromium/WritableDataObject.cpp:
              (WebCore::WritableDataObject::setData):
              * platform/graphics/chromium/CrossProcessFontLoading.mm:
              * platform/graphics/chromium/FontCacheChromiumWin.cpp:
              (WebCore::fontContainsCharacter):
              (WebCore::FillLogFont):
              * platform/graphics/chromium/FontCacheLinux.cpp:
              (WebCore::FontCache::getFontDataForCharacters):
              * platform/graphics/chromium/FontChromiumWin.cpp:
              (WebCore::Font::drawGlyphs):
              * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
              (WebCore::FontPlatformData::scriptFontProperties):
              * platform/graphics/chromium/FontPlatformDataLinux.cpp:
              (WebCore::FontPlatformData::querySystemForRenderStyle):
              * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
              (WebCore::fillBMPGlyphs):
              * platform/graphics/chromium/ImageChromium.cpp:
              (WebCore::Image::loadPlatformResource):
              * platform/graphics/chromium/ImageChromiumMac.mm:
              (WebCore::Image::loadPlatformResource):
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              (WebCore::SimpleFontData::platformInit):
              (WebCore::SimpleFontData::determinePitch):
              (WebCore::SimpleFontData::platformWidthForGlyph):
              * platform/graphics/chromium/UniscribeHelperTextRun.cpp:
              (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
              * platform/graphics/skia/FontCustomPlatformData.cpp:
              (WebCore::FontCustomPlatformData::fontPlatformData):
              * platform/network/chromium/CookieJarChromium.cpp:
              (WebCore::setCookies):
              (WebCore::cookies):
              (WebCore::cookieRequestHeaderFieldValue):
              (WebCore::cookiesEnabled):
              (WebCore::getRawCookies):
              (WebCore::deleteCookie):
              * platform/network/chromium/DNSChromium.cpp:
              (WebCore::prefetchDNS):
              * platform/qt/PlatformBridge.h:
              * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
              (WebCore::SQLiteFileSystem::deleteDatabaseFile):
              (WebCore::SQLiteFileSystem::getDatabaseFileSize):
              * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
              (chromiumOpen):
              (chromiumDelete):
              (chromiumAccess):
              * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
              * plugins/chromium/PluginDataChromium.cpp:
              (WebCore::PluginCache::plugins):
              * rendering/RenderThemeChromiumMac.mm:
              (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
              * rendering/RenderThemeChromiumSkia.cpp:
              (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
              (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
              (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
              (WebCore::RenderThemeChromiumWin::systemColor):
              (WebCore::RenderThemeChromiumWin::paintButton):
              (WebCore::RenderThemeChromiumWin::paintSliderTrack):
              (WebCore::menuListButtonWidth):
              (WebCore::RenderThemeChromiumWin::paintMenuList):
              (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
              (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
              (WebCore::RenderThemeChromiumWin::paintProgressBar):
              * storage/chromium/IDBFactoryBackendInterface.cpp:
              (WebCore::IDBFactoryBackendInterface::create):
              (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
              * storage/chromium/IDBKeyPathBackendImpl.cpp:
              (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
      2011-01-21  Adam Klein  <adamk@chromium.org>
      
              Reviewed by Eric Seidel.
      
              [chromium] Rename ChromiumBridge to PlatformBridge
              https://bugs.webkit.org/show_bug.cgi?id=52471
      
              * WebKit.gyp:
              * src/AssertMatchingEnums.cpp:
              * src/PlatformBridge.cpp:
              (WebCore::toChromeClientImpl):
              (WebCore::toWebWidgetClient):
              (WebCore::getCookieJar):
              (WebCore::PlatformBridge::cacheMetadata):
              (WebCore::PlatformBridge::clipboardIsFormatAvailable):
              (WebCore::PlatformBridge::clipboardReadPlainText):
              (WebCore::PlatformBridge::clipboardReadHTML):
              (WebCore::PlatformBridge::clipboardWriteSelection):
              (WebCore::PlatformBridge::clipboardWritePlainText):
              (WebCore::PlatformBridge::clipboardWriteURL):
              (WebCore::PlatformBridge::clipboardWriteImage):
              (WebCore::PlatformBridge::clipboardWriteData):
              (WebCore::PlatformBridge::clipboardReadAvailableTypes):
              (WebCore::PlatformBridge::clipboardReadData):
              (WebCore::PlatformBridge::clipboardReadFilenames):
              (WebCore::PlatformBridge::setCookies):
              (WebCore::PlatformBridge::cookies):
              (WebCore::PlatformBridge::cookieRequestHeaderFieldValue):
              (WebCore::PlatformBridge::rawCookies):
              (WebCore::PlatformBridge::deleteCookie):
              (WebCore::PlatformBridge::cookiesEnabled):
              (WebCore::PlatformBridge::prefetchDNS):
              (WebCore::PlatformBridge::fileExists):
              (WebCore::PlatformBridge::deleteFile):
              (WebCore::PlatformBridge::deleteEmptyDirectory):
              (WebCore::PlatformBridge::getFileSize):
              (WebCore::PlatformBridge::revealFolderInOS):
              (WebCore::PlatformBridge::getFileModificationTime):
              (WebCore::PlatformBridge::directoryName):
              (WebCore::PlatformBridge::pathByAppendingComponent):
              (WebCore::PlatformBridge::makeAllDirectories):
              (WebCore::PlatformBridge::getAbsolutePath):
              (WebCore::PlatformBridge::isDirectory):
              (WebCore::PlatformBridge::filePathToURL):
              (WebCore::PlatformBridge::openFile):
              (WebCore::PlatformBridge::closeFile):
              (WebCore::PlatformBridge::seekFile):
              (WebCore::PlatformBridge::truncateFile):
              (WebCore::PlatformBridge::readFromFile):
              (WebCore::PlatformBridge::writeToFile):
              (WebCore::PlatformBridge::ensureFontLoaded):
              (WebCore::PlatformBridge::getFontFamilyForCharacters):
              (WebCore::PlatformBridge::getRenderStyleForStrike):
              (WebCore::PlatformBridge::loadFont):
              (WebCore::PlatformBridge::databaseOpenFile):
              (WebCore::PlatformBridge::databaseDeleteFile):
              (WebCore::PlatformBridge::databaseGetFileAttributes):
              (WebCore::PlatformBridge::databaseGetFileSize):
              (WebCore::PlatformBridge::idbFactory):
              (WebCore::PlatformBridge::idbShutdown):
              (WebCore::PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath):
              (WebCore::PlatformBridge::signedPublicKeyAndChallengeString):
              (WebCore::PlatformBridge::computedDefaultLanguage):
              (WebCore::PlatformBridge::layoutTestMode):
              (WebCore::PlatformBridge::isSupportedImageMIMEType):
              (WebCore::PlatformBridge::isSupportedJavaScriptMIMEType):
              (WebCore::PlatformBridge::isSupportedNonImageMIMEType):
              (WebCore::PlatformBridge::mimeTypeForExtension):
              (WebCore::PlatformBridge::mimeTypeFromFile):
              (WebCore::PlatformBridge::preferredExtensionForMIMEType):
              (WebCore::PlatformBridge::plugins):
              (WebCore::PlatformBridge::pluginScriptableObject):
              (WebCore::PlatformBridge::loadPlatformImageResource):
              (WebCore::PlatformBridge::loadPlatformAudioResource):
              (WebCore::PlatformBridge::decodeAudioFileData):
              (WebCore::PlatformBridge::sandboxEnabled):
              (WebCore::PlatformBridge::setSharedTimerFiredFunction):
              (WebCore::PlatformBridge::setSharedTimerFireTime):
              (WebCore::PlatformBridge::stopSharedTimer):
              (WebCore::PlatformBridge::decrementStatsCounter):
              (WebCore::PlatformBridge::incrementStatsCounter):
              (WebCore::PlatformBridge::histogramCustomCounts):
              (WebCore::PlatformBridge::histogramEnumeration):
              (WebCore::PlatformBridge::suddenTerminationChanged):
              (WebCore::PlatformBridge::currentTime):
              (WebCore::PlatformBridge::paintButton):
              (WebCore::PlatformBridge::paintMenuList):
              (WebCore::PlatformBridge::paintScrollbarArrow):
              (WebCore::PlatformBridge::paintScrollbarThumb):
              (WebCore::PlatformBridge::paintScrollbarTrack):
              (WebCore::PlatformBridge::paintSpinButton):
              (WebCore::PlatformBridge::paintTextField):
              (WebCore::PlatformBridge::paintTrackbar):
              (WebCore::PlatformBridge::paintProgressBar):
              (WebCore::WebThemePart):
              (WebCore::WebThemeState):
              (WebCore::GetWebThemeExtraParams):
              (WebCore::PlatformBridge::getThemePartSize):
              (WebCore::PlatformBridge::paintThemePart):
              (WebCore::PlatformBridge::traceEventBegin):
              (WebCore::PlatformBridge::traceEventEnd):
              (WebCore::PlatformBridge::visitedLinkHash):
              (WebCore::PlatformBridge::isLinkVisited):
              (WebCore::PlatformBridge::notifyJSOutOfMemory):
              (WebCore::PlatformBridge::memoryUsageMB):
              (WebCore::PlatformBridge::actualMemoryUsageMB):
              (WebCore::PlatformBridge::screenDepth):
              (WebCore::PlatformBridge::screenDepthPerComponent):
              (WebCore::PlatformBridge::screenIsMonochrome):
              (WebCore::PlatformBridge::screenRect):
              (WebCore::PlatformBridge::screenAvailableRect):
              (WebCore::PlatformBridge::popupsAllowed):
              (WebCore::WorkerContextProxy::create):
              * src/ResourceHandle.cpp:
              (WebCore::ResourceHandle::cacheMetadata):
              * src/WebFrameImpl.cpp:
              (WebKit::WebFrameImpl::WebFrameImpl):
              (WebKit::WebFrameImpl::~WebFrameImpl):
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ceaac17
    • eric@webkit.org's avatar
      2011-01-21 Eric Seidel <eric@webkit.org> · 7a1babed
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Split Host object off from WebKitPatch for easier re-use
              https://bugs.webkit.org/show_bug.cgi?id=52284
      
              new-run-webkit-tests and other tools are eventually going to want one of these.
              Basically you need to inherit from this class if you want to pretend to be a
              self.tool object for Steps/Commands.
      
              * Scripts/webkitpy/common/host.py: Added.
              * Scripts/webkitpy/tool/main.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a1babed
    • commit-queue@webkit.org's avatar
      2011-01-21 Helder Correia <helder@sencha.com> · c8061fbf
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] svg/css/text-gradient-shadow.svg needs expected results
              https://bugs.webkit.org/show_bug.cgi?id=52724
      
              * platform/qt/svg/css/text-gradient-shadow-expected.checksum: Added.
              * platform/qt/svg/css/text-gradient-shadow-expected.png: Added.
              * platform/qt/svg/css/text-gradient-shadow-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8061fbf
    • loislo@chromium.org's avatar
      2011-01-21 Sheriff Bot <webkit.review.bot@gmail.com> · 075d1183
      loislo@chromium.org authored
              Unreviewed, rolling out r76335.
              http://trac.webkit.org/changeset/76335
              https://bugs.webkit.org/show_bug.cgi?id=52875
      
              profiler tests were broken (Requested by loislo on #webkit).
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::addProfile):
              (WebCore::InspectorController::getCurrentUserInitiatedProfileName):
              * inspector/InspectorController.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
              (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForPage):
              * page/Console.cpp:
              (WebCore::Console::profile):
              (WebCore::Console::profileEnd):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      075d1183
    • yurys@chromium.org's avatar
      2011-01-21 Yury Semikhatsky <yurys@chromium.org> · 1b7f5418
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Make userscripts/window-onerror-for-isolated-world-*.html give consistent output
              https://bugs.webkit.org/show_bug.cgi?id=52870
      
              Call setTimeout from "load" event listener to make sure exception in the setTimeout
              callback happens after the one in the listener.
      
              * platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt:
              * platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt:
              * userscripts/window-onerror-for-isolated-world-1-expected.txt:
              * userscripts/window-onerror-for-isolated-world-1.html:
              * userscripts/window-onerror-for-isolated-world-2-expected.txt:
              * userscripts/window-onerror-for-isolated-world-2.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1b7f5418
    • loislo@chromium.org's avatar
      2011-01-21 Ilya Tikhonovsky <loislo@chromium.org> · c73ebd91
      loislo@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.
      
              There are some places in WebCore where we still using direct InspectorController calls.
              The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
              Inspector facade for WebCore.
      
              https://bugs.webkit.org/show_bug.cgi?id=52869
      
              * inspector/InspectorController.cpp:
              * inspector/InspectorController.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::addProfileImpl):
              (WebCore::InspectorInstrumentation::profilerEnabledImpl):
              (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::addProfile):
              (WebCore::InspectorInstrumentation::profilerEnabled):
              (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
              * page/Console.cpp:
              (WebCore::Console::profile):
              (WebCore::Console::profileEnd):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c73ebd91
  2. 20 Jan, 2011 4 commits
    • rniwa@webkit.org's avatar
      2011-01-20 Ryosuke Niwa <rniwa@webkit.org> · 4575e9df
      rniwa@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Added OwnPtrCommon.h because OwnArrayPtr::set calls deleteOwnedPtr.
      
              * wtf/OwnArrayPtr.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4575e9df
    • mjs@apple.com's avatar
      2011-01-20 Maciej Stachowiak <mjs@apple.com> · 602a037f
      mjs@apple.com authored
              Reviewed by Dan Bernstein.
      
              Skip a few more tests that are failing on the bots
              https://bugs.webkit.org/show_bug.cgi?id=52865
      
              * platform/mac-wk2/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      602a037f
    • paroga@webkit.org's avatar
      2011-01-20 Patrick Gansterer <paroga@webkit.org> · 7d853f58
      paroga@webkit.org authored
              Reviewed by Oliver Hunt.
      
              [WINCE] Remove obsolete JSVALUE32 code
              https://bugs.webkit.org/show_bug.cgi?id=52450
      
              Remove the "offset hack" in create_jit_stubs, since we
              only support JSVALUE32_64 in the meantime.
      
              * create_jit_stubs: Removed offset argument
              * jit/JITStubs.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d853f58
    • ggaren@apple.com's avatar
      2011-01-20 Geoffrey Garen <ggaren@apple.com> · 7c9ff4d4
      ggaren@apple.com authored
              Reviewed by Oliver Hunt.
      
              When marking conservatively, guard against reviving dead objects.
              https://bugs.webkit.org/show_bug.cgi?id=52840
              
              SunSpider and v8 say no change.
      
              * interpreter/RegisterFile.h:
              (JSC::RegisterFile::markCallFrames): Updated to use the ConservativeSet API.
      
              * runtime/Heap.cpp:
              (JSC::Heap::recordExtraCost): No need to guard against conservative
              marking reviving dead objects anymore, since the conservative marking
              mechanism guards against this now.
      
              (JSC::Heap::markConservatively):
              (JSC::Heap::markProtectedObjects):
              (JSC::Heap::markTempSortVectors): Don't drain the mark stack inside a
              marking function. We want to establish a separation of concerns between
              visiting roots and draining the mark stack.
      
              (JSC::Heap::markRoots): Gather the set of conservative references before
              clearning mark bits, because conservative marking now uses the mark bits
              to determine if a reference is valid, and avoid reviving dead objects.
      
              (JSC::Heap::collectAllGarbage): No need to guard against conservative
              marking reviving dead objects anymore, since the conservative marking
              mechanism guards against this now.
      
              * runtime/Heap.h: Updated to use the ConservativeSet API.
      
              * runtime/MachineStackMarker.cpp:
              (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
              (JSC::MachineStackMarker::markCurrentThreadConservatively):
              (JSC::MachineStackMarker::markOtherThreadConservatively):
              (JSC::MachineStackMarker::markMachineStackConservatively):
              * runtime/MachineStackMarker.h: Ditto.
      
              * runtime/MarkStack.h:
              (JSC::ConservativeSet::add):
              (JSC::ConservativeSet::mark): Added ConservativeSet, for gathering the
              set of conservative references. This is different from MarkStack, since
              we don't mark the set until it is completely gathered.
      
              * runtime/MarkedSpace.cpp:
              (JSC::MarkedSpace::freeBlock):
              (JSC::MarkedSpace::resizeBlocks):
              (JSC::MarkedSpace::markConservatively):
              * runtime/MarkedSpace.h: When marking conservatively, guard against
              reviving dead objects.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c9ff4d4