- 27 Mar, 2013 33 commits
-
-
eric.carlson@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=113406 Reviewed by Jer Noble. Source/WebCore: media/video-controls-captions-trackmenu-localized.html was updated to test this. * page/CaptionUserPreferencesMac.mm: (WebCore::trackDisplayName): Use the 'label' attribute for the menu text when necessary. LayoutTests: * media/video-controls-captions-trackmenu-localized.html: * platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sergio@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=113413 Reviewed by Ryosuke Niwa. Source/WebCore: Perform a "normal" insert instead of a replace when there is nothing to replace (like at the end of a line) as this case is not supported by the replacing code path. This will allow us to properly rebalance whitespaces in those cases. Updated the editing/execCommand/overtype.html test to check also this use case. * editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::setEndingSelectionWithoutValidation): (WebCore::InsertTextCommand::performTrivialReplace): (WebCore::InsertTextCommand::performOverwrite): (WebCore::InsertTextCommand::doApply): use the recently added setEndingSelectionWithoutValidation() to avoid code duplication. * editing/InsertTextCommand.h: (InsertTextCommand): LayoutTests: Updated the test to include the case of inserting a whitespace both in the middle or at the end of a line. * editing/execCommand/overtype-expected.txt: * editing/execCommand/overtype.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146999 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
[GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR https://bugs.webkit.org/show_bug.cgi?id=113421 Reviewed by Dirk Pranke. When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file. This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present in the GTK-specific TestExpectations files. To avoid this only enable the warnings only when not using WKTR. * Scripts/webkitpy/layout_tests/port/gtk.py: (GtkPort.warn_if_bug_missing_in_test_expectations): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rniwa@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=113358 Reviewed by Levi Weintraub. Add a performance test for selecting all. We wait for paint to happen by setTimeout(~, 0). Example outputs: RESULT Interactive: SelectAll: Time= 652.6 ms median= 644.5 ms, stdev= 54.6177144967 ms, min= 599.0 ms, max= 773.0 ms RESULT Interactive: SelectAll: Time= 654.4 ms median= 633.5 ms, stdev= 55.9223145368 ms, min= 600.0 ms, max= 769.0 ms RESULT Interactive: SelectAll: Time= 657.9 ms median= 640.0 ms, stdev= 54.1420159833 ms, min= 604.0 ms, max= 774.0 ms * Interactive/SelectAll.html: Added. * Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=113374 Reviewed by Geoffrey Garen. We used to do the right thing, but it appears that this regressed at some point. Since the FixupPhase now has the ability to outright remove spurious CheckStructures on array operations, it is profitable for the ByteCodeParser to insert CheckStructures whenver there is a chance that it might be profitable, and when the profiling tells us what structure to check. Also added some code for doing ArrayProfile debugging. This is a slightly speed-up. Maybe 3% on Mandreel. * bytecode/ArrayProfile.cpp: (JSC::ArrayProfile::computeUpdatedPrediction): * dfg/DFGArrayMode.h: (JSC::DFG::ArrayMode::benefitsFromStructureCheck): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dino@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=113392 <rdar://problem/13474743> Reviewed by Enrica Casucci. Some internal fonts on OS X have a family name that isn't listed in availableFontFamilies. In this case we should use the font name rather than the family name when looking for a match. * platform/mac/ThemeMac.h: NSFont category to provide a web-friendly family name. * platform/mac/ThemeMac.mm: (-[NSFont webCoreFamilyName]): Returns the font name for internal fonts, otherwise the family name. (WebCore::ThemeMac::controlFont): * rendering/RenderThemeMacShared.mm: Use the webCoreFamilyName. (WebCore::RenderThemeMacShared::systemFont): Ditto. (WebCore::RenderThemeMacShared::setFontFromControlSize): Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zandobersek@gmail.com authored
Addressing layout test failures that are specific to GTK-WK1 by moving the related expectations into the specific TestExpectations file or adjusting and moving the baselines into the GTK-WK1 baseline search path. * platform/gtk-wk1/TestExpectations: * platform/gtk-wk1/fast: Added. * platform/gtk-wk1/fast/media: Added. * platform/gtk-wk1/fast/media/mq-transform-02-expected.html: Copied from LayoutTests/platform/gtk/fast/media/mq-transform-02-expected.html. * platform/gtk-wk1/fast/media/mq-transform-03-expected.html: Copied from LayoutTests/platform/gtk/fast/media/mq-transform-03-expected.html. * platform/gtk-wk2/TestExpectations: * platform/gtk/TestExpectations: * platform/gtk/fast/dom/HTMLLinkElement/prefetch-expected.txt: Added. * platform/gtk/fast/dom/HTMLLinkElement/subresource-expected.txt: Added. * platform/gtk/fast/hidpi/clip-text-in-hidpi-expected.txt: * platform/gtk/fast/hidpi/image-set-background-dynamic-expected.txt: * platform/gtk/fast/hidpi/image-set-border-image-dynamic-expected.txt: * platform/gtk/fast/media/mq-transform-02-expected.html: Removed. * platform/gtk/fast/media/mq-transform-03-expected.html: Removed. * platform/gtk/fast/preloader: Added. * platform/gtk/fast/preloader/document-write-2-expected.txt: Added. * platform/gtk/fast/preloader/document-write-expected.txt: Added. * platform/gtk/fast/preloader/script-expected.txt: Added. * platform/gtk/http/tests/security/XFrameOptions: Removed. * platform/gtk/http/tests/security/XFrameOptions/x-frame-options-allowall-expected.txt: Removed. * platform/gtk/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146994 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
allan.jensen@digia.com authored
https://bugs.webkit.org/show_bug.cgi?id=113308 Reviewed by Alexey Proskuryakov. Use the C++11 static_assert for COMPILE_ASSERT when it is available. Note that even when compiling with C++11 support, static_assert will not always be available since Assertions.h may also be used outside of C++. C11 _Static_assert is enabled for GCC when it has C11 support (gcc>=4.7 -std=c11). * wtf/Assertions.h: * wtf/Compiler.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jer.noble@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=113355 Reviewed by Eric Carlson. No new tests; rebaselined existing tests against correct behavior. A prior commit set the "min-width:0" property on the time display elements, which, combined with the "-webkit-flex-box:0 0" setting, caused the flex-box container to collapse the width of the elements to zero. To achieve the desired effect of hiding the time display elements, first set the elements' min-width to the desired width, as the new flex-box spec treats the default value of "min-width:auto" as the intrinsic width, and will collapse the text display elements to the intrinsic width of its contained text node. The above allows the timeline container to collapse beyond the sum of its childrens' intrinsic width. Create a custom renderer that detects when this happens, and hide the time display controls. * css/mediaControls.css: * css/mediaControlsQuickTime.css: (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display): Set the "min-width:" property to equal the "width:" property. (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display): Ditto. * css/mediaControlsChromium.css: (audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display): Chromium assumes the time display controls are flex-boxes, so make that explicit. * html/shadow/MediaControlElementTypes.cpp: Removed MediaControlTimeDisplayElement::createRenderer(). * html/shadow/MediaControlElementTypes.h: (MediaControlTimeDisplayElement): Ditto. * html/shadow/MediaControlElements.cpp: (WebCore::MediaControlTimelineContainerElement::setTimeDisplaysHidden): Added, walks through the container's children and shows or hides time display elements. (WebCore::MediaControlTimelineContainerElement::createRenderer): Added, creates a RenderMediaControlTimelineContainer. (WebCore::getMediaControlTimeRemainingDisplayElementShadowPseudoId): Added, allow setTimeDisplaysHidden to query against children's shadowPseudoId(). (WebCore::MediaControlTimeRemainingDisplayElement::shadowPseudoId): Moved contents to getMediaControlTimeRemainingDisplayElementShadowPseudoId. (WebCore::getMediaControlCurrentTimeDisplayElementShadowPseudoId): Added, allow setTimeDisplaysHidden to query against children's shadowPseudoId(). (WebCore::MediaControlCurrentTimeDisplayElement::shadowPseudoId): Moved contents to getMediaControlCurrentTimeDisplayElementShadowPseudoId. * html/shadow/MediaControlElements.h: (MediaControlTimelineContainerElement): * rendering/RenderMediaControlElements.cpp: (WebCore::RenderMediaControlTimelineContainer::RenderMediaControlTimelineContainer): Added, simple constructor. (WebCore::RenderMediaControlTimelineContainer::layout): Detect when the controller's width is greater than a certain value, and show or hide the time display elements in response. * rendering/RenderMediaControlElements.h: (RenderMediaControlTimelineContainer): LayoutTests: Mac: Media Controls always hide time display elements https://bugs.webkit.org/show_bug.cgi?id=113355 Reviewed by Eric Carlson. Rebaseline mac results. * platform/mac/media/audio-controls-rendering-expected.png: * platform/mac/media/audio-controls-rendering-expected.txt: * platform/mac/media/controls-after-reload-expected.png: * platform/mac/media/controls-after-reload-expected.txt: * platform/mac/media/controls-strict-expected.png: * platform/mac/media/controls-strict-expected.txt: * platform/mac/media/controls-styling-strict-expected.png: Added. * platform/mac/media/controls-styling-strict-expected.txt: * platform/mac/media/controls-without-preload-expected.png: * platform/mac/media/controls-without-preload-expected.txt: * platform/mac/media/video-controls-rendering-expected.png: * platform/mac/media/video-controls-rendering-expected.txt: * platform/mac/media/video-display-toggle-expected.png: * platform/mac/media/video-display-toggle-expected.txt: * platform/mac/media/video-no-audio-expected.png: * platform/mac/media/video-no-audio-expected.txt: * platform/mac/media/video-playing-and-pause-expected.png: * platform/mac/media/video-playing-and-pause-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146992 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
* Scripts/webkitpy/common/config/committers.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=113195 Reviewed by Ryosuke Niwa. * BuildSlaveSupport/build.webkit.org-config/config.json: * BuildSlaveSupport/build.webkit.org-config/master.cfg: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=113191 Reviewed by Ryosuke Niwa. * BuildSlaveSupport/build.webkit.org-config/config.json: - Rename the slave due to its location change. - Update the platform of the slave. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunQtAPITests): Enable running WK2 API tests on Qt. (RunQtAPITests.start): (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder. (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.) git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rakuco@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=113403 Reviewed by Kenneth Rohde Christiansen. As of Evas 1.7.5, when Wayland is detected on the system, support for both Wayland SHM and Wayland EGL is automatically enabled in autoconf. The code, however, seems to depend on a few other flags which must be explicitly enabled. If those additional GL-related options are passed, we end up having issues on the WebKit side, so disable Wayland support for now. * efl/jhbuild.modules: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146988 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
loislo@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=113395 Reviewed by Pavel Feldman. Looks like FlameChart is more powerful and flexible instrument than plain old ProfileTree in DataGrid. The same action like 'look for the most expensive function in a frame' could be easily done with FlameChart and need number of clicks in DataGrid. So in an offline discussion we decided to place FlameChart on top of DataGrid. * inspector/front-end/CPUProfileView.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
https://bugs.webkit.org/show_bug.cgi?id=113339cfleizach@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=113361 Source/WebCore: Fix the red bots. No review. Ensure only pop-up buttons get the AXRequired attribute instead of all buttons. * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: (-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]): (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]): LayoutTests: Remove skipped tests. * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zarvai@inf.u-szeged.hu authored
* platform/qt/fast/frames/frame-set-scaling-rotate-expected.txt: Removed. * platform/qt/fast/frames/frame-set-scaling-skew-expected.txt: Removed. * platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.txt: Removed. * platform/qt/fast/line-grid/line-align-left-edges-expected.txt: Removed. * platform/qt/fast/reflections/reflection-masks-expected.txt: Removed. * platform/qt/fast/reflections/reflection-masks-opacity-expected.txt: Removed. * platform/qt/fast/reflections/reflection-masks-outset-expected.txt: Removed. * platform/qt/fast/repaint/background-misaligned-expected.txt: Removed. * platform/qt/fast/repaint/overhanging-float-detach-repaint-expected.txt: Removed. * platform/qt/fast/repaint/transform-absolute-child-expected.txt: Removed. * platform/qt/fast/replaced/border-radius-clip-content-edge-expected.txt: Removed. * platform/qt/fast/table/border-collapsing/equal-precedence-resolution-expected.txt: Removed. * platform/qt/fast/text/bidi-embedding-pop-and-push-same-2-expected.txt: Removed. * platform/qt/fast/writing-mode/block-level-images-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vsevik@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=113381 Reviewed by Pavel Feldman. Source/WebCore: Breakpoint manager now restores breakpoints on UISourceCodeAdded event. Breakpoint manager now only resets breakpoints in debugger when source mapping is changed to/from non identity one. * inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype._uiSourceCodeAdded): (WebInspector.BreakpointManager.prototype._resetBreakpoints): (WebInspector.BreakpointManager.prototype._uiSourceCodeMappingChanged): * inspector/front-end/CompilerScriptMapping.js: (WebInspector.CompilerScriptMapping.prototype.get isIdentity): * inspector/front-end/DefaultScriptMapping.js: (WebInspector.DefaultScriptMapping.prototype.isIdentity): * inspector/front-end/ResourceScriptMapping.js: (WebInspector.ResourceScriptMapping.prototype.isIdentity): * inspector/front-end/SASSSourceMapping.js: (WebInspector.SASSSourceMapping.prototype.isIdentity): * inspector/front-end/ScriptSnippetModel.js: (WebInspector.SnippetScriptMapping.prototype.isIdentity): * inspector/front-end/SourceMapping.js: (WebInspector.SourceMapping.prototype.isIdentity): * inspector/front-end/StylesSourceMapping.js: (WebInspector.StylesSourceMapping.prototype.isIdentity): * inspector/front-end/UISourceCode.js: (WebInspector.UISourceCode.prototype.setSourceMapping): LayoutTests: * inspector/debugger/breakpoint-manager-expected.txt: * inspector/debugger/breakpoint-manager.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Web Inspector: update Timeline.TimelineEvent definition to include DOM counters and native memory stats https://bugs.webkit.org/show_bug.cgi?id=113376 Reviewed by Vsevolod Vlasov. Fixed assertion failure in debug mode after r146975. * inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::innerAddRecordToTimeline): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
loislo@chromium.org authored
Web Inspector: FlameChart. Provide 15px padding left for the chart so developers will see the first divider with '0' title. https://bugs.webkit.org/show_bug.cgi?id=113404 Reviewed by Pavel Feldman. 15px paddingLeft was added to the code for the chart. * inspector/front-end/FlameChart.js: (WebInspector.FlameChart): (WebInspector.FlameChart.Calculator.prototype._updateBoundaries): (WebInspector.FlameChart.Calculator.prototype.computePosition): (WebInspector.FlameChart.prototype.draw): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dominik.rottsches@intel.com authored
http://trac.webkit.org/changeset/146864 https://bugs.webkit.org/show_bug.cgi?id=113391 causes crashes on Wk2 EFL release bot (Requested by drott on #webkit). Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-27 .: * Source/cmake/OptionsEfl.cmake: Tools: * Scripts/webkitperl/FeatureList.pm: LayoutTests: * platform/efl/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
rakuco@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=113396 Reviewed by Philippe Normand. So far, we were using the `MAKEFLAGS' environment variable to pass the number of compilation jobs we wanted to jhbuild. jhbuild itself, on the other hand, prefers to use the `jobs' variable from jhbuildrc for that. We now behave more closely to the rest of the WebKit tools by first checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is not set, just letting jhbuild itself figure out how many jobs to use. * efl/jhbuildrc: * gtk/jhbuildrc: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=113385 Unreviewed, EFL gardening. Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-03-27 * platform/efl/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=113297 Reviewed by Alexey Proskuryakov. Source/WebCore: HTMLFormControlElement::readOnly is not an implementation of 'readOnly' IDL attribute. It's confusing and we don't need to violate our naming convention. No new tests. Just a refactoring. * accessibility/AccessibilityNodeObject.cpp: (WebCore::AccessibilityNodeObject::isReadOnly): * html/BaseMultipleFieldsDateAndTimeInputType.cpp: (WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerReadOnly): * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): (WebCore::HTMLFormControlElement::parseAttribute): * html/HTMLFormControlElement.h: (WebCore::HTMLFormControlElement::isReadOnly): (WebCore::HTMLFormControlElement::isDisabledOrReadOnly): * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::matchesReadOnlyPseudoClass): (WebCore::HTMLInputElement::matchesReadWritePseudoClass): * html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::matchesReadOnlyPseudoClass): (WebCore::HTMLTextAreaElement::matchesReadWritePseudoClass): * html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::defaultEventHandler): (WebCore::SliderThumbElement::willRespondToMouseMoveEvents): (WebCore::SliderThumbElement::willRespondToMouseClickEvents): * html/shadow/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents): (WebCore::InputFieldSpeechButtonElement::setRecognitionResult): * html/shadow/TextFieldDecorationElement.cpp: (WebCore::TextFieldDecorationElement::updateImage): * rendering/RenderTextControl.cpp: (WebCore::updateUserModifyProperty): * rendering/RenderThemeMacShared.mm: (WebCore::RenderThemeMacShared::paintSearchFieldCancelButton): Source/WebKit/chromium: * src/WebFormControlElement.cpp: (WebKit::WebFormControlElement::isReadOnly): Source/WebKit/win: * DOMHTMLClasses.cpp: (DOMHTMLInputElement::readOnly): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zeno.albisser@digia.com authored
https://bugs.webkit.org/show_bug.cgi?id=112891 This patch is preparation work for removing WorkQueue related code from TestRunnerQt and replacing it with generic TestRunner code. Reviewed by Benjamin Poulain. Source/JavaScriptCore: * API/JSStringRefQt.cpp: (JSStringCreateWithQString): Adding a convenience function to create a JSStringRef from a QString. * API/JSStringRefQt.h: Tools: * DumpRenderTree/qt/TestRunnerQt.cpp: (TestRunnerQt::queueBackNavigation): (TestRunnerQt::queueForwardNavigation): (TestRunnerQt::queueLoadHTMLString): (TestRunnerQt::queueReload): (TestRunnerQt::queueLoadingScript): (TestRunnerQt::queueNonLoadingScript): (TestRunner::queueLoad): * DumpRenderTree/qt/TestRunnerQt.h: (TestRunnerQt): * DumpRenderTree/qt/WorkQueueItemQt.cpp: (LoadItem::invoke): (LoadHTMLStringItem::invoke): (LoadAlternateHTMLStringItem::invoke): (ReloadItem::invoke): (ScriptItem::invoke): (BackForwardItem::invoke): * DumpRenderTree/qt/WorkQueueItemQt.h: (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem): (LoadAlternateHTMLStringItem): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
Web Inspector: update Timeline.TimelineEvent definition to include DOM counters and native memory stats https://bugs.webkit.org/show_bug.cgi?id=113376 Reviewed by Vsevolod Vlasov. Added missing fields to Timeline.TimelineEvent type definition in Inspector.json * inspector/Inspector.json: * inspector/InspectorTimelineAgent.cpp: (WebCore::InspectorTimelineAgent::innerAddRecordToTimeline): (WebCore::InspectorTimelineAgent::setDOMCounters): Switched InspectorTimelineAgent to the new typed event builders. (WebCore::InspectorTimelineAgent::setNativeHeapStatistics): * inspector/InspectorTimelineAgent.h: (InspectorTimelineAgent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vsevik@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=113368 Reviewed by Pavel Feldman. Source/WebCore: Added a missed line and a test. * inspector/front-end/BreakpointManager.js: (WebInspector.BreakpointManager.prototype._projectWillReset): LayoutTests: * inspector/debugger/breakpoint-manager.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=113348 Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-27 Reviewed by Vsevolod Vlasov. No new tests. - Append additional "<class>-start" class to the first highlighted span and "<class>-end" class to the last highlighted span to provide a way to set up a css classes with borders. - Increment end column of the markup range to simulate inclusive range. * inspector/front-end/CodeMirrorTextEditor.js: (WebInspector.CodeMirrorTextEditor.prototype.highlightRange): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=112815 Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-27 Reviewed by Vsevolod Vlasov. No new tests: no change in behaviour. - Add TextEditor.isClean and TextEditor.markClean methods - Implement these methods in DefaultTextEditor - Implement these methods in CodeMirrorTextEditor * inspector/front-end/CodeMirrorTextEditor.js: (WebInspector.CodeMirrorTextEditor.prototype.isClean): (WebInspector.CodeMirrorTextEditor.prototype.markClean): * inspector/front-end/DefaultTextEditor.js: (WebInspector.DefaultTextEditor.prototype.isClean): (WebInspector.DefaultTextEditor.prototype.markClean): * inspector/front-end/TextEditor.js: (WebInspector.TextEditor.prototype.isClean): (WebInspector.TextEditor.prototype.markClean): * inspector/front-end/TextEditorModel.js: (WebInspector.TextEditorModel.endsWithBracketRegex.): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
loislo@chromium.org authored
Unreviewed. Web Inspector. rename method Timeline.Calculator.grandMinimumBoundary to Timeline.Calculator.zeroTime No changes in behaviour. * inspector/front-end/FlameChart.js: (WebInspector.FlameChart.Calculator.prototype.zeroTime): (WebInspector.FlameChart.OverviewCalculator.prototype.zeroTime): * inspector/front-end/NetworkPanel.js: (WebInspector.NetworkBaseCalculator.prototype.zeroTime): * inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.updateDividers): (WebInspector.TimelineGrid.Calculator.prototype.zeroTime): * inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewCalculator.prototype.zeroTime): * inspector/front-end/TimelinePanel.js: (WebInspector.TimelineCalculator.prototype.zeroTime): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
loislo@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=113315 Reviewed by Pavel Feldman. Now when TimelineGrid is able to draw dividers with any offset we could cut away paddingLeft member of Timeline.Calculator and clear the code of TimelineGrid. * inspector/front-end/TimelineGrid.js: (WebInspector.TimelineGrid.prototype.updateDividers): * inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelineCalculator.prototype.computePosition): (WebInspector.TimelineCalculator.prototype.setDisplayWindow): (WebInspector.TimelineCalculator.prototype.grandMinimumBoundary): * inspector/front-end/inspectorCommon.css: (.resources-dividers-label-bar): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=112982 Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-03-27 Reviewed by Noam Rosenthal. Covered by existing WebGL tests. Source/WebCore: This patch adds support to pass GraphicsSurface flags during it's client creation. This would be helpful to determine cases when blending can be disabled on client side i.e When AlphaSupport is disabled during Graphics Surface creation. With GLX, we rely on Window to provide us with necessary information on client side. This might not be the case on other platforms or when not using Window on X. This patch doesn't change original behaviour of creating GraphicsSurface client with default flags GraphicsSurface::SupportsTextureTarget and GraphicsSurface::SupportsSharing. * platform/graphics/texmap/TextureMapperPlatformLayer.h: (WebCore::TextureMapperPlatformLayer::graphicsSurfaceFlags): * platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: (WebCore::CoordinatedGraphicsLayer::createCanvasIfNeeded): * platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp: (WebCore::CoordinatedGraphicsScene::createCanvasIfNeeded): * platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h: (CoordinatedGraphicsLayerState): * platform/graphics/efl/GraphicsContext3DPrivate.cpp: (WebCore): (WebCore::GraphicsContext3DPrivate::graphicsSurfaceFlags): * platform/graphics/efl/GraphicsContext3DPrivate.h: (GraphicsContext3DPrivate): * platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp: (WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate): (WebCore::GraphicsSurfacePrivate::initializeClient): Source/WebKit2: This patch adds support to pass GraphicsSurface flags during it's client creation. * Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp: (CoreIPC::::encode): (CoreIPC::::decode): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tasak@google.com authored
https://bugs.webkit.org/show_bug.cgi?id=113275 Source/WebCore: If a text node is distributed, its parent node for rendering and styling might have no style. In the case, styleForText should return default style. Reviewed by Hajime Morrita. Test: fast/dom/shadow/text-node-distributed-crash.html * css/StyleResolver.cpp: (WebCore::StyleResolver::styleForText): Check whether a parent node has any style or not. If not, return default style. This is the same behavior as styleForElement. LayoutTests: Reviewed by Hajime Morrita. * fast/dom/shadow/text-node-distributed-crash-expected.txt: Added. * fast/dom/shadow/text-node-distributed-crash.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
yurys@chromium.org authored
* platform/chromium-win/fast/replaced/border-radius-clip-content-edge-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 26 Mar, 2013 7 commits
-
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=113304 Patch by Takeshi Yoshino <tyoshino@chromium.org> on 2013-03-26 Reviewed by Kent Tamura. socket_stream of Chromium buffers send data up to 32KiB (exact) bytes. However, SocketStreamHandleInternal::send() method now keeps in-flight send data not greater than m_maxPendingSendAllowed - 1 that is 32KiB - 1. This means that SocketStreamHandleInternal consumes the buffered data in SocketStreamHandleBase by 32KiB - 1. It makes memory copy operations unaligned unnecessarily. It should just use the allowed size fully. * platform/network/chromium/SocketStreamHandle.cpp: (WebCore::SocketStreamHandleInternal::send): (WebCore): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
oliver@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=113277 Reviewed by Benjamin Poulain. Simple patch to add a size based constructor for RefCountedArray so that we can create an sharable array without a copy. * wtf/RefCountedArray.h: (RefCountedArray): (WTF::RefCountedArray::RefCountedArray): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pdr@google.com authored
Unreviewed rebaseline of test expectations after r146955 * platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png: * platform/chromium-mac/fast/replaced/border-radius-clip-content-edge-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
* WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hayato@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=113171 Reviewed by Dimitri Glazkov. Source/WebCore: HitTestRequest is widely used in WebCore, but AllowShadowContents flag is not turned on by default. In most places, we can set the flag on. This change makes HitTests allow shadow contents by default. To track all existing HitTests which do not allow shadow contents, and discourage such a HitTest in the future, I've introduced disallowShadowContenet flag so that callers must turn on this flag explicitly if they want to disallow shadow contents in their HitTests. This change should be refactoring and should not include any behavior changes. After this change, we'll investigate each place where disallowShadowContents is used step by step and get rid of the flag if it is okay to remove. No new tests, no behavior change. * dom/Document.h: (Document): * dom/TreeScope.cpp: (WebCore::nodeFromPoint): * editing/FrameSelection.cpp: (WebCore::FrameSelection::contains): * page/DragController.cpp: (WebCore::elementUnderMouse): (WebCore::DragController::canProcessDrag): (WebCore::DragController::startDrag): * page/EventHandler.cpp: (WebCore::EventHandler::handleMouseDraggedEvent): (WebCore::EventHandler::eventMayStartDrag): (WebCore::EventHandler::updateSelectionForMouseDrag): (WebCore::EventHandler::hitTestResultAtPoint): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseDoubleClickEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent): (WebCore::EventHandler::updateDragAndDrop): (WebCore::EventHandler::isInsideScrollbar): (WebCore::EventHandler::handleWheelEvent): (WebCore::EventHandler::handleGestureEvent): (WebCore::EventHandler::handleGestureLongPress): (WebCore::EventHandler::handleGestureScrollBegin): (WebCore::EventHandler::bestClickableNodeForTouchPoint): (WebCore::EventHandler::bestContextMenuNodeForTouchPoint): (WebCore::EventHandler::bestZoomableAreaForTouchPoint): (WebCore::EventHandler::sendContextMenuEvent): (WebCore::EventHandler::sendContextMenuEventForKey): (WebCore::EventHandler::hoverTimerFired): (WebCore::EventHandler::dragSourceEndedAt): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::handleTouchEvent): (WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled): * page/EventHandler.h: (EventHandler): * page/FocusController.cpp: (WebCore::updateFocusCandidateIfNeeded): * page/Frame.cpp: (WebCore::Frame::visiblePositionForPoint): * page/TouchDisambiguation.cpp: (WebCore::findGoodTouchTargets): * rendering/HitTestRequest.h: (WebCore::HitTestRequest::disallowsShadowContent): * rendering/HitTestResult.cpp: (WebCore::HitTestResult::addNodeToRectBasedTestResult): * rendering/RenderFlowThread.cpp: (WebCore::RenderFlowThread::hitTestFlowThreadPortionInRegion): * rendering/svg/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::hitTestClipContent): * testing/Internals.cpp: (WebCore::Internals::nodesFromRect): Source/WebKit/blackberry: * Api/WebPage.cpp: (BlackBerry::WebKit::WebPagePrivate::hitTestResult): * WebKitSupport/FatFingers.cpp: (BlackBerry::WebKit::FatFingers::getNodesFromRect): * WebKitSupport/ProximityDetector.cpp: (BlackBerry::WebKit::ProximityDetector::findBestPoint): * WebKitSupport/SelectionHandler.cpp: (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping): Source/WebKit/chromium: * src/ContextMenuClientImpl.cpp: (WebKit::selectMisspelledWord): * src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::visiblePositionForWindowPoint): * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::isRectTopmost): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::computeBlockBounds): (WebKit::WebViewImpl::bestTapNode): Source/WebKit/efl: * ewk/ewk_frame.cpp: (ewk_frame_hit_test_new): Source/WebKit/gtk: * webkit/webkitwebinspector.cpp: (webkit_web_inspector_inspect_coordinates): * webkit/webkitwebview.cpp: (prepareMouseEventForFrame): (webkit_web_view_get_hit_test_result): Source/WebKit/mac: * WebView/WebFrame.mm: (-[WebFrame elementAtPoint:]): * WebView/WebHTMLView.mm: (-[WebHTMLView elementAtPoint:allowShadowContent:]): Source/WebKit/qt: * WebCoreSupport/QWebFrameAdapter.cpp: (QWebFrameAdapter::hitTestContent): Source/WebKit/win: * WebView.cpp: (WebView::gestureNotify): Source/WebKit2: * WebProcess/WebPage/WebFrame.cpp: (WebKit::WebFrame::hitTest): * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::highlightPotentialActivation): (WebKit::WebPage::findZoomableAreaForPoint): (WebKit::WebPage::determinePrimarySnapshottedPlugIn): * WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::shouldDelayWindowOrderingEvent): (WebKit::WebPage::acceptsFirstMouse): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=112996 Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-03-26 Reviewed by Rob Buis. PR 312552 Internally Reviewed by Anthony Scian. NavigatorContentUtilsClientBlackBerry is new'ed in WebPagePrivate::init(), but not deleted anywhere. Fixed by creating an OwnPtr for it. Also fixed some webkit-style errors. * Api/WebPage.cpp: (BlackBerry::WebKit::WebPagePrivate::init): * Api/WebPage_p.h: (WebCore): (WebPagePrivate): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mark.lam@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=113361. Not Reviewed. * platform/mac/TestExpectations: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@146958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-