1. 05 Apr, 2013 11 commits
    • mhahnenberg@apple.com's avatar
      tryCacheGetByID sets StructureStubInfo accessType to an incorrect value · d0be74de
      mhahnenberg@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114068
      
      Reviewed by Geoffrey Garen.
      
      In the case where we have a non-Value cacheable property, we set the StructureStubInfo accessType to 
      get_by_id_self, but then we don't patch self and instead patch in a get_by_id_self_fail. This leads to 
      incorrect profiling data so when the DFG compiles the function, it uses a GetByOffset rather than a GetById, 
      which leads to loading a GetterSetter directly out of an object.
      
      Source/JavaScriptCore: 
      
      * jit/JITStubs.cpp:
      (JSC::tryCacheGetByID):
      (JSC::DEFINE_STUB_FUNCTION):
      
      LayoutTests: 
      
      * fast/js/jit-set-profiling-access-type-only-for-get-by-id-self-expected.txt: Added.
      * fast/js/jit-set-profiling-access-type-only-for-get-by-id-self.html: Added.
      * fast/js/script-tests/jit-set-profiling-access-type-only-for-get-by-id-self.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147816 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0be74de
    • cfleizach@apple.com's avatar
      AX: Make SVG Group containers accessible elements · b2b0b4d9
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113939
      
      Reviewed by Simon Fraser.
      
      Source/WebCore: 
      
      SVG group containers are currently not exposed in the AX tree. 
      When an SVG element has a <title> child, that is not being used for the AX label.
      When hit-testing, from Accessibility, SVG groups are never returned.
      
      All these issues are fixed for Mac and iOS.
      There are two tests because right now iOS skips all the top-level accessibility tests
      due to fundamental architectural differences.
      
      Tests: accessibility/svg-group-element-with-title.html
             platform/iphone-simulator/accessibility/svg-group-element-with-title.html
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::alternativeText):
      (WebCore::AccessibilityNodeObject::accessibilityDescription):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::accessibilityHitTest):
      (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
      * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
      (-[WebAccessibilityObjectWrapper isSVGGroupElement]):
      (-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
      (-[WebAccessibilityObjectWrapper accessibilityClickPoint]):
      * rendering/HitTestRequest.h:
          Add a new option, AccessibilityHitTest, that will allow us to override normal behavior.
      * rendering/svg/RenderSVGContainer.cpp:
      (WebCore::RenderSVGContainer::nodeAtFloatPoint):
         Allow a SVG group to be the node at a point, for accessibility hit tests.
      
      Tools: 
      
      Implement axController.elementAtPoint for iOS.
      Implement a correct version of clickPoint for iOS.
      
      * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
      (AccessibilityController::elementAtPoint):
      * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
      (AccessibilityUIElement::clickPointX):
      (AccessibilityUIElement::clickPointY):
      
      LayoutTests: 
      
      * accessibility/svg-group-element-with-title-expected.txt: Added.
      * accessibility/svg-group-element-with-title.html: Added.
      * platform/iphone-simulator/accessibility/svg-group-element-with-title-expected.txt: Added.
      * platform/iphone-simulator/accessibility/svg-group-element-with-title.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2b0b4d9
    • cfleizach@apple.com's avatar
      WebSpeech: event.elapsedTime is always 1364484608 · 16399b98
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=114045
      
      Reviewed by Tim Horton.
      
      Source/WebCore:
      
      We were calculating elapsed time incorrectly.
      
      Test: platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html
      
      * Modules/speech/SpeechSynthesis.cpp:
      (WebCore::SpeechSynthesis::fireEvent):
      
      LayoutTests:
      
      * platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time-expected.txt: Added.
      * platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16399b98
    • cfleizach@apple.com's avatar
      WebSpeech: crash at WebCore::SpeechSynthesis::speak · e73c07ab
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113937
      
      Reviewed by Tim Horton.
      
      Source/WebCore:
      
      Protect against the case when invalid data is passed in.
      
      Test: platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html
      
      * Modules/speech/SpeechSynthesis.cpp:
      (WebCore::SpeechSynthesis::speak):
      * Modules/speech/SpeechSynthesisUtterance.cpp:
      (WebCore::SpeechSynthesisUtterance::setVoice):
      
      LayoutTests:
      
      * platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance-expected.txt: Added.
      * platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e73c07ab
    • commit-queue@webkit.org's avatar
      [EFL] Enable indexed database · 6e763e91
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107248
      
      Patch by Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> on 2013-04-05
      Reviewed by Alexis Menard.
      
      .:
      
      * Source/cmake/OptionsEfl.cmake:
      
      Tools:
      
      * Scripts/webkitperl/FeatureList.pm:
      
      LayoutTests:
      
      * platform/efl-wk1/TestExpectations:
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e763e91
    • zoltan@webkit.org's avatar
      [regression] Security: Heap-use-after-free in WebCore::RenderBlock::logicalRightOffsetForLine · 50d1bc7d
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=111594
      
      Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-04-05
      Reviewed by David Hyatt.
      
      Source/WebCore: 
      
      Swapping the bases was causing any floats in the right base to be
      lost, so change the code so that it no longer swaps the bases.
      
      Test: fast/ruby/float-object-doesnt-crash.html
      
      * rendering/RenderRubyRun.cpp:
      (WebCore::RenderRubyRun::removeChild): Don't swap the bases anymore.
      
      LayoutTests: 
      
      Add test to verify that the use-after-free is fixed. Note that it will
      only crash when run under a memory checking tool like ASAN.
      
      * fast/ruby/float-object-doesnt-crash-expected.txt: Added.
      * fast/ruby/float-object-doesnt-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147765 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50d1bc7d
    • betravis@adobe.com's avatar
      [css exclusions] Dynamically removing shape-inside should cause relayout of... · 1e4305c2
      betravis@adobe.com authored
      [css exclusions] Dynamically removing shape-inside should cause relayout of child blocks' inline content
      https://bugs.webkit.org/show_bug.cgi?id=111029
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Preserve a removed ExclusionShapeInsideInfo for one additional layout pass
      so that it can notify descendant inline content to relayout. This patch adds
      a new 'needsRemoval' boolean to ExclusionShapeInsideInfo, which is set when
      a style change removes but does not replace a shape-inside. When determining
      whether a block needs to relayout inline children, ExclusionShapeInsideInfos with
      the needsRemoval boolean set are included, but at other times (such as during
      inline layout), they are ignored.
      
      Added tests to the existing dynamic shape testfile
      fast/exclusions/shape-inside/shape-inside-dynamic-nested.html
      
      * rendering/ExclusionShapeInsideInfo.h:
      (WebCore::ExclusionShapeInsideInfo::setNeedsRemoval): Get/Set the
      needsRemoval boolean.
      (WebCore::ExclusionShapeInsideInfo::needsRemoval): Ditto.
      (ExclusionShapeInsideInfo):
      (WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo):
      Initialize the needsRemoval boolean.
      * rendering/LayoutState.cpp:
      (WebCore::LayoutState::LayoutState): Propagate removed shape insides
      for layout correctly. You only need to track one at a time, and a
      removed shape inside should not take precedence over a set shape-inside.
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange):
      Set the ExclusionShapeInsideInfo needsRemoval boolean, rather than immediately
      removing the info.
      (WebCore::exclusionInfoRequiresRelayout): Account for the needsRemoval
      boolean as another way of requiring relayout.
      (WebCore::RenderBlock::updateRegionsAndExclusionsBeforeChildLayout):
      Look up whether an ExclusionShapeInsideInfo has been removed.
      (WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout):
      Remove any ExclusionShapeInsides marked for removal after a layout pass.
      (WebCore):
      (WebCore::RenderBlock::layoutBlock): Call the new updateRegionsAndExclusions
      Before/After methods.
      * rendering/RenderBlock.h:
      (WebCore::RenderBlock::exclusionShapeInsideInfo): Filter the result based
      on whether it should include removed infos.
      (RenderBlock):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Ditto.
      * rendering/RenderDeprecatedFlexibleBox.cpp:
      (WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
      Same as RenderBlock::layoutBlock.
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::layoutBlock): Ditto.
      * rendering/RenderGrid.cpp:
      (WebCore::RenderGrid::layoutBlock): Ditto.
      
      LayoutTests:
      
      Test that removed shape-insides correctly cause relayout in their blocks'
      inline content.
      
      * fast/exclusions/shape-inside/shape-inside-dynamic-nested-expected.html:
      * fast/exclusions/shape-inside/shape-inside-dynamic-nested.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147758 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1e4305c2
    • commit-queue@webkit.org's avatar
      [CSS Regions] Elements in a region should be assignable to a named flow · e0da8c77
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=74144
      
      Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-04-05
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      DOM children of a region must not be rendered as children of the region, but can be collected in flow threads.
      
      NodeRenderingContext::parentRenderer now creates the parent render flow thread if it doesn't exist.
      
      Element::moveToFlowThreadIsNeeded is a virtual method that is overriden in PseudoElement to return false and
      in SVGElement so only svg root elements can directly be collected by a render flow thread.
      
      RenderObject::canDOMChildrenHaveRenderParent exists to optimize the code so nodes inside regions (and maybe
      other types of renderers in the future) can still have renderers if they need to be in a flow thread while the
      rest of renderers that can't have children skip the new instructions.
      
      Tests: fast/regions/flow-body-in-html.html . To test the duplicate bug #103685.
             fast/regions/region-content-flown-into-region.html
             fast/regions/universal-selector-children-to-the-same-region.html . To test the duplicate bug #103685.
      
      * dom/Element.cpp:
      (WebCore::Element::moveToFlowThreadIsNeeded):
      * dom/Element.h:
      * dom/NodeRenderingContext.cpp:
      (WebCore::NodeRenderingContext::parentRenderer): the renderer that will be the parent for this node's renderer.
      In the case of RenderFlowThreads, it may need to create it.
      (WebCore::NodeRenderingContext::shouldCreateRenderer): In a region, only the children that need to be in a flow
      thread should have a renderer.
      (WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
      (WebCore::NodeRenderingContext::moveToFlowThread):
      * dom/NodeRenderingContext.h:
      (NodeRenderingContext):
      * dom/PseudoElement.h: pseudo-elements cannot be directly collected into a named flow.
      * dom/Text.cpp:
      (WebCore::Text::textRendererIsNeeded):
      (WebCore::Text::updateTextRenderer): Because calling textRendererIsNeeded(NodeRenderingContext(...)) on a
      non-const l-value NodeRenderingContext cannot be done on a temporary object on the stack.
      * dom/Text.h:
      * rendering/FlowThreadController.cpp:
      (WebCore::FlowThreadController::isContentNodeRegisteredWithAnyNamedFlow):
      * rendering/FlowThreadController.h:
      * rendering/RenderObject.h:
      (WebCore::RenderObject::canDOMChildrenHaveRenderParent): Even if this render object can't have render children,
      the children in the DOM tree may have a render parent (that is different from this render object).
      * rendering/RenderRegion.h:
      * svg/SVGElement.cpp:
      (WebCore::SVGElement::moveToFlowThreadIsNeeded): Allow only svg root elements to be directly collected by a
      render flow thread.
      * svg/SVGElement.h:
      (SVGElement):
      
      LayoutTests:
      
      * fast/regions/flow-body-in-html-expected.txt: Added.
      * fast/regions/flow-body-in-html.html: Added. To test the duplicate bug #103685.
      * fast/regions/region-content-flown-into-region-expected.html: Added.
      * fast/regions/region-content-flown-into-region.html: Added.
      * fast/regions/universal-selector-children-to-the-same-region-expected.txt: Added.
      * fast/regions/universal-selector-children-to-the-same-region.html: Added. To test the duplicate bug #103685.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0da8c77
    • commit-queue@webkit.org's avatar
      Source/WebCore: Updating mouse cursor on style changes without emitting fake mousemove event · d9a17e16
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=101857
      
      Patch by Aivo Paas <aivopaas@gmail.com> on 2013-04-05
      Reviewed by Allan Sandfeld Jensen.
      
      Mouse cursor changes in styles used to be reflected in UI through dispatching a fake
      mousemove event. The old approach has some flaws: it emits a mousemove event in
      javascript when there is no mouse movement involved (bug 85343); the fake mousemove
      event is cancelled while there is a mouse button held down - cursor won't change
      until mouse is moved or the button released (bug 53341).
      
      The new approach does not use the fake mousemove event. Instead, it uses only the logic
      needed for the actual cursor change to happen.
      
      EventHandler::selectCursor was refactored to not take a whole mouse event but instead work with
      HitTestResult so that EventHandler::updateCursor must not create a useless PlatformEvent.
      
      Fixes: https://bugs.webkit.org/show_bug.cgi?id=85343 (mousemove event on cursor change)
             https://bugs.webkit.org/show_bug.cgi?id=53341 (no cursor change when mouse button down)
      
      Tests: fast/events/mouse-cursor-change.html
             fast/events/mouse-cursor-no-mousemove.html
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::EventHandler):
      (WebCore::EventHandler::clear):
      (WebCore::EventHandler::cursorUpdateTimerFired):
      (WebCore::EventHandler::updateCursor):
      (WebCore::EventHandler::selectCursor):
      (WebCore::EventHandler::handleMouseMoveEvent):
      (WebCore::EventHandler::scheduleCursorUpdate):
      * page/EventHandler.h:
      * page/FrameView.cpp:
      (WebCore::FrameView::shouldSetCursor):
      * page/FrameView.h:
      * page/MouseEventWithHitTestResults.cpp:
      (WebCore::MouseEventWithHitTestResults::isOverLink):
      * rendering/HitTestResult.cpp:
      (WebCore::HitTestResult::isOverLink):
      * rendering/HitTestResult.h:
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::styleDidChange):
      
      LayoutTests: Updating mouse cursor on style changes without emitting fake mousemove event
      https://bugs.webkit.org/show_bug.cgi?id=101857
      Changing CSS cursor should work no matter is mouse button is pressed or not
      https://bugs.webkit.org/show_bug.cgi?id=53341
      
      Patch by Aivo Paas <aivopaas@gmail.com> on 2013-04-05
      Reviewed by Allan Sandfeld Jensen.
      
      Added tests for changing cursor on mousemove, mousedown, mouseup and mousemove
      while mouse button being held down. Also added test to verify that a mousemove
      event is not fired for changing cursor when mouse is not moving.
      
      * fast/events/mouse-cursor-change-expected.txt: Added.
      * fast/events/mouse-cursor-change.html: Added.
      * fast/events/mouse-cursor-no-mousemove-expected.txt: Added.
      * fast/events/mouse-cursor-no-mousemove.html: Added.
      * platform/mac/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147739 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9a17e16
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 36d6ddfb
      zandobersek@gmail.com authored
      * platform/gtk/TestExpectations: Removing a couple of expectations for tests that are now passing.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36d6ddfb
    • commit-queue@webkit.org's avatar
      [EFL] New baseline for accessibility/aria-option-role.html · 0c7f910c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114006
      
      Unreviewed, EFL gardening.
      
      Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-04-05
      
      * platform/efl-wk1/TestExpectations:
      * platform/efl-wk2/TestExpectations:
      * platform/efl/accessibility/aria-option-role-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c7f910c
  2. 04 Apr, 2013 24 commits
    • benjamin@webkit.org's avatar
      Change class_as_selector-expected.html to be a ref-test · 75f883a0
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113970
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
      Reviewed by Geoffrey Garen.
      
      The test checks style can be applied to text with a CSS class.
      The reference is done by applying a style attribute directly
      on each element.
      
      * css1/basic/class_as_selector-expected.html: Added.
      * platform/efl/css1/basic/class_as_selector-expected.png: Removed.
      * platform/efl/css1/basic/class_as_selector-expected.txt: Removed.
      * platform/gtk/css1/basic/class_as_selector-expected.txt: Removed.
      * platform/mac/css1/basic/class_as_selector-expected.png: Removed.
      * platform/mac/css1/basic/class_as_selector-expected.txt: Removed.
      * platform/qt/css1/basic/class_as_selector-expected.png: Removed.
      * platform/qt/css1/basic/class_as_selector-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75f883a0
    • benjamin@webkit.org's avatar
      Unskip 3 backface-visibility tests on OS X · 72a072f5
      benjamin@webkit.org authored
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
      
      * platform/mac/TestExpectations:
      The 3 pixel tests pass on WebKit1 and WebKit2.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72a072f5
    • simon.fraser@apple.com's avatar
      Page content missing when flipping from an empty layer to a tiled layer · ca3e5e1e
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113977
      <rdar://problem/13444219>
      
      Source/WebCore:
      
      Reviewed by Tim Horton.
      
      Some articles on USA Today were missing content on load, when a large GraphicsLayer
      which did not draw content needed to draw content (and become tiled in the process).
      
      The bug was an ordering dependency in GraphicsLayerCA::commitLayerChangesBeforeSublayers().
      swapFromOrToTiledLayer() sets some dirty flags, but for some properties which have
      already been committed in the current flush cycle.
      
      Fix by moving the swapFromOrToTiledLayer() to the top of the commit, which is
      safe since it only consults GraphicsLayer properties, not CALayer properties.
      
      Test: compositing/tiling/empty-to-tiled.html
      
      * platform/graphics/ca/GraphicsLayerCA.cpp:
      (WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
      (WebCore::GraphicsLayerCA::updateGeometry):
      (WebCore::GraphicsLayerCA::updateLayerDrawsContent):
      (WebCore::GraphicsLayerCA::updateContentsScale):
      * platform/graphics/ca/GraphicsLayerCA.h:
      (GraphicsLayerCA):
      
      LayoutTests:
      
      Reviewed by Tim Horton.
      
      Ref test that adds visible content to a larger layer.
      
      * compositing/tiling/empty-to-tiled-expected.html: Added.
      * compositing/tiling/empty-to-tiled.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca3e5e1e
    • eric.carlson@apple.com's avatar
      Unreviewed, fix a test and some results missed in r147675 · bb2bdfa8
      eric.carlson@apple.com authored
      * media/media-captions-expected.txt:
      * media/video-controls-captions-trackmenu-localized.html:
      * platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb2bdfa8
    • benjamin@webkit.org's avatar
      Make fast/events/tabindex-focus-blur-all.html disallow Java so the test runs... · b9163c71
      benjamin@webkit.org authored
      Make fast/events/tabindex-focus-blur-all.html disallow Java so the test runs the same regardless of platform/port
      https://bugs.webkit.org/show_bug.cgi?id=113950
      
      Patch by Dave Michael <dmichael@chromium.org> on 2013-04-04
      Reviewed by Jer Noble.
      
      This hopefully fixes the test failure seen on Apple Mountain Lion WK2:
      http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r147640%20(7636)/results.html
      that was introduced in https://bugs.webkit.org/show_bug.cgi?id=32292
      
      * fast/events/resources/tabindex-focus-blur-all.js: Make the test disallow Java execution. Otherwise, <applet> is focusible on platforms that support Java by default and not focusible elsewhere.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9163c71
    • eric.carlson@apple.com's avatar
      [Mac] add "automatic" text track menu item · 44f8c684
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113822
      
      Reviewed by Jer Noble.
      
      Source/WebCore: 
      
      No new tests, existing tests updated.
      
      * English.lproj/Localizable.strings: Add new track menu item.
      
      * html/HTMLMediaElement.cpp: 
      (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_captionDisplayMode.
      (WebCore::HTMLMediaElement::finishParsingChildren): LoadTextTrackResource -> ConfigureTextTracks.
      (WebCore::HTMLMediaElement::scheduleDelayedAction): Ditto.
      (WebCore::HTMLMediaElement::loadTimerFired): Ditto.
      (WebCore::HTMLMediaElement::loadInternal): Ditto. Flag the caption menu as invalid so it will
          be rebuilt again.
      (WebCore::HTMLMediaElement::mediaPlayerDidAddTrack): LoadTextTrackResource -> ConfigureTextTracks.
      (WebCore::HTMLMediaElement::didAddTrack): Ditto.
      (WebCore::HTMLMediaElement::configureTextTrackGroup): Deal with new track display modes.
      (WebCore::HTMLMediaElement::HTMLMediaElement::hasClosedCaptions): Minor cleanup.
      (WebCore::HTMLMediaElement::configureTextTrackGroup): Add some logging.
      (WebCore::HTMLMediaElement::configureTextTracks): Call updateActiveTextTrackCues so cue display
          is updated.
      (WebCore::HTMLMediaElement::captionPreferencesChanged): Deal with new track display modes.
      (WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Add some logging.
      * html/HTMLMediaElement.h: Ditto.
      
      * html/shadow/MediaControlElementTypes.cpp: Remove trackIndexAttributeName and trackListIndexForElement.
      * html/shadow/MediaControlElementTypes.h: Ditto.
      
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler): Don't use track index,
          everything we need is in the track<->element map now.
      (WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Ditto. Always rebuild the 
          track list because clear the map each time the menu goes away because it refs every track.
      (WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Don't set the track
          index attribute on the menu items, just use the map.
      * html/shadow/MediaControlElements.h:
      
      * html/shadow/MediaControlsApple.cpp:
      (WebCore::MediaControlsApple::changedClosedCaptionsVisibility): resetTrackListMenu is gone.
      (WebCore::MediaControlsApple::reset): Ditto.
      (WebCore::MediaControlsApple::closedCaptionTracksChanged): Ditto.
      
      * html/track/TextTrack.cpp:
      (WebCore::TextTrack::captionMenuOffItem): New, static TextTrack used for the menu "Off" item.
      (WebCore::TextTrack::captionMenuAutomaticItem): New, static TextTrack used for the menu "Automatic" item.
      * html/track/TextTrack.h:
      
      * page/CaptionUserPreferences.cpp:
      (WebCore::CaptionUserPreferences::shouldShowCaptions): Removed, we use captionDisplayMode instead.
      (WebCore::CaptionUserPreferences::captionDisplayMode): New.
      (WebCore::CaptionUserPreferences::setCaptionDisplayMode): New.
      (WebCore::CaptionUserPreferences::setPreferredLanguage): Make the parameter a const reference.
      (WebCore::CaptionUserPreferences::textTrackSelectionScore): Return 0 if the user doesn't want
          captions or subtitles.
      (WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Take language as a parameter
          instead of assuming that it is always the entire language list.
      * page/CaptionUserPreferences.h:
      
      * page/CaptionUserPreferencesMac.h:
      * page/CaptionUserPreferencesMac.mm:
      (WebCore::CaptionUserPreferencesMac::shouldShowCaptions): Removed, we use captionDisplayMode instead.
      (WebCore::CaptionUserPreferencesMac::captionDisplayMode): New.
      (WebCore::CaptionUserPreferencesMac::setCaptionDisplayMode): New.
      (WebCore::CaptionUserPreferencesMac::setPreferredLanguage): Make the parameter a const reference.
      (WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Deal with "Automatic" mode.
          captions or subtitles.
      (WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Take language as a parameter
          instead of assuming that it is always the entire language list.
      (WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): Insert "Off" and "Automatic" items.
      
      * platform/LocalizedStrings.cpp:
      (WebCore::textTrackAutomaticMenuItemText): New.
      * platform/LocalizedStrings.h:
      
      * platform/graphics/MediaPlayer.cpp:
      (WebCore::MediaPlayer::languageOfPrimaryAudioTrack): New.
      * platform/graphics/MediaPlayer.h:
      * platform/graphics/MediaPlayerPrivate.h:
      
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Return the language
          of the main audio track.
      
      LayoutTests: 
      
      * media/media-captions.html: Opportunistic fix - don't look at state until we get the 'canplaythrough'
          event because the media engine state may not have been processed until that time.
      * media/track/track-cue-container-rendering-position.html: Don't assume that a cue has been 
          rendered immediately when the 'canplaythrough' event comes through.
      * media/track/track-cue-rendering-mode-changed.html: Ditto.
      * media/track/track-in-band-expected.txt: Don't check if cues have loaded, it doesn't matter
          for this test.
      * media/track/track-in-band.html: Ditto.
      * media/track/track-user-preferences-expected.txt: Changed name of utility function from 
          menuIndexForLanguage to indexOfMenuItemBeginningWith.
      * media/track/track-user-preferences.html: Move menuIndexForLanguage to trackmenu-test.js and
          change name to indexOfMenuItemBeginningWith. Clarify the message logged when a track loads
          but it should not.
      * media/trackmenu-test.js: Move some functions here from track-user-preferences.html
      (trackMenuList):
      (indexOfMenuItemBeginningWith):
      (selectCaptionMenuItem):
      * media/video-controls-captions-trackmenu-sorted.html: Update for new menu item.
      * media/video-controls-captions-trackmenu.html: Ditto.
      * platform/mac/media/video-controls-captions-trackmenu-expected.txt: Ditto.
      * platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44f8c684
    • glenn@skynav.com's avatar
      [EFL] Unreviewed gardening. Rebaseline after r147588. Remove overridden pixel results. · 85dcc593
      glenn@skynav.com authored
      * platform/efl/fast/text/international/003-expected.png: Removed.
      * platform/efl/fast/text/international/text-combine-image-test-expected.png: Removed.
      * platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85dcc593
    • glenn@skynav.com's avatar
      [EFL] Unreviewed gardening. Rebaseline after r147588. Update pixel expectations. · a3b38062
      glenn@skynav.com authored
      * platform/efl-wk1/fast/text/international/003-expected.png: Added.
      * platform/efl-wk1/fast/text/international/text-combine-image-test-expected.png: Added.
      * platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
      * platform/efl-wk2/fast/text/international/003-expected.png: Added.
      * platform/efl-wk2/fast/text/international/text-combine-image-test-expected.png: Added.
      * platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3b38062
    • oliver@apple.com's avatar
      Exception stack unwinding doesn't handle inline callframes correctly · 49a2c14b
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113952
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore:
      
      The basic problem here is that the exception stack unwinding was
      attempting to be "clever" and avoid doing a correct stack walk
      as it "knew" inline callframes couldn't have exception handlers.
      
      This used to be safe as the exception handling machinery was
      designed to fail gently and just claim that no handler existed.
      This was "safe" and even "correct" inasmuch as we currently
      don't run any code with exception handlers through the dfg.
      
      This patch fixes the logic by simply making everything uniformly
      use the safe stack walking machinery, and making the correct
      boundary checks occur everywhere that they should.
      
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::findClosureCallForReturnPC):
      (JSC::CodeBlock::bytecodeOffset):
      * interpreter/Interpreter.cpp:
      (JSC):
      (JSC::Interpreter::dumpRegisters):
      (JSC::Interpreter::unwindCallFrame):
      (JSC::getCallerInfo):
      (JSC::Interpreter::getStackTrace):
      (JSC::Interpreter::retrieveCallerFromVMCode):
      
      LayoutTests:
      
      Yay tests!
      
      * fast/js/js-correct-exception-handler-expected.txt: Added.
      * fast/js/js-correct-exception-handler.html: Added.
      * fast/js/script-tests/js-correct-exception-handler.js: Added.
      (throwEventually):
      (f.g):
      (f):
      (test):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49a2c14b
    • glenn@skynav.com's avatar
      [EFL] Unreviewed gardening. Rebaseline after r147588. · 3454a256
      glenn@skynav.com authored
      * platform/efl-wk1/fast/text/international: Added.
      * platform/efl-wk1/fast/text/international/003-expected.txt: Added.
      * platform/efl-wk1/fast/text/international/text-combine-image-test-expected.txt: Added.
      * platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
      * platform/efl-wk2/fast/text/international/003-expected.txt: Added.
      * platform/efl-wk2/fast/text/international/text-combine-image-test-expected.txt: Added.
      * platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
      * platform/efl/fast/text/international/003-expected.txt: Removed.
      * platform/efl/fast/text/international/text-combine-image-test-expected.txt: Removed.
      * platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3454a256
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r147662. · 9eb48e04
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/147662
      https://bugs.webkit.org/show_bug.cgi?id=113955
      
      The change r147662  breaks fast/regions/fixed-pos-elem-in-
      region.html (Requested by benjaminp on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-04
      
      Source/WebCore:
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::inlineLogicalWidth):
      
      LayoutTests:
      
      * fast/inline/inline-with-empty-inline-children-expected.txt:
      * fast/inline/inline-with-empty-inline-children.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9eb48e04
    • roger_fong@apple.com's avatar
      Unreviewed. AppleWin port gardening. · 2b505bba
      roger_fong@apple.com authored
      * platform/win/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b505bba
    • roger_fong@apple.com's avatar
      Unreviewed. AppleWin port gardening. · 6c958e45
      roger_fong@apple.com authored
      * platform/win/TestExpectations:
      * platform/win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c958e45
    • robert@webkit.org's avatar
      REGRESSION(r142152): Text wraps in menu · d063ec6c
      robert@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113706
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::inlineLogicalWidth): Empty inline elements add their inline border/padding/margin to the width of the
      line when we iterate through them in nextLineBreak(), so no need to add them again here when climbing back up
      from their first child looking for border/padding/margin to add. (An empty inline element can have floating children.)
      
      LayoutTests:
      
      * fast/inline/inline-with-empty-inline-children-expected.txt:
      * fast/inline/inline-with-empty-inline-children.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d063ec6c
    • cfleizach@apple.com's avatar
      AX:File upload button has wrong label · 3591b2be
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113924
      
      Reviewed by David Kilzer.
      
      Source/WebCore: 
      
      Allow the label and value to be returned for file upload controls on iOS.
      Due to the different AX APIs, we can expose a bit more information on iOS.
      
      Test: platform/iphone-simulator/accessibility/file-upload-button.html
      
      * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
      (-[WebAccessibilityObjectWrapper stringValueShouldBeUsedInLabel]):
      (-[WebAccessibilityObjectWrapper fileUploadButtonReturnsValueInTitle]):
      * accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
      (-[WebAccessibilityObjectWrapperBase fileUploadButtonReturnsValueInTitle]):
      (-[WebAccessibilityObjectWrapperBase accessibilityTitle]):
      
      LayoutTests: 
      
      * platform/iphone-simulator/accessibility/file-upload-button-expected.txt: Added.
      * platform/iphone-simulator/accessibility/file-upload-button.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3591b2be
    • eae@chromium.org's avatar
      Source/WebCore: Change RenderFrameSet::computeEdgeInfo to use m-rows/m_cols directly · 54cd3900
      eae@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113825
      
      Reviewed by Eric Seidel.
      
      Tests: fast/frames/invalid-frameset-compute-edge.html
      
      * rendering/RenderFrameSet.cpp:
      (WebCore::RenderFrameSet::computeEdgeInfo):
      
      LayoutTests: Change RenderFrameSet::computeEdgeInfo to use m-rows/m_cols directly
      https://bugs.webkit.org/show_bug.cgi?id=113825
              
      Reviewed by Eric Seidel.
              
      Add test for accessing an invalid frame.
      
      * fast/frames/invalid-frameset-compute-edge-expected.html: Added.
      * fast/frames/invalid-frameset-compute-edge.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54cd3900
    • ch.dumez@sisa.samsung.com's avatar
      [Cairo] Fix canvas drawing of SVG-based patterns and remove NativeImageCairo · 2e39cc2b
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113929
      
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      Make (Pass)NativeImagePtr typedefs to (Pass)RefPtr<cairo_surface_t> instead
      of NativeImageCairo*. Now that we switch to using smart pointers,
      NativeImageCairo is removed as it made no sense to make it ref counted when
      it merely held a single ref counted member.
      
      Now that Cairo is using smart pointers for (Pass)NativeImagePtr, this patch
      also enables the implementation of SVGImage::nativeImageForCurrentFrame()
      for USE(CAIRO) as well. This effectively fixes canvas drawing of SVG-based
      patterns for Cairo-based ports.
      
      No new tests, covered by svg/canvas/canvas-pattern-svg.html.
      
      * GNUmakefile.list.am: Remove NativeImageCairo.* for GTK.
      
      * PlatformEfl.cmake: Remove NativeImageCairo.* for EFL.
      
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      Remove NativeImageCairo.* for Win.
      
      * platform/graphics/BitmapImage.cpp:
      (WebCore::FrameData::reportMemoryUsage):
      Update MemoryClassInfo::addRawBuffer() call now that m_frame is a RefPtr
      for USE(CAIRO).
      
      * platform/graphics/BitmapImage.h:
      (BitmapImage):
      Remove factory method taking a cairo_surface_t* in argument. This is useless
      now that PassNativeImagePtr is a typedef to PassRefPtr<cairo_surface_t> and
      there is already a factory method taking a PassNativeImagePtr in argument.
      
      * platform/graphics/NativeImagePtr.h:
      (WebCore):
      Make PassNativeImagePtr a typedef to PassRefPtr<cairo_surface_t> and
      NativeImagePtr a typedef to RefPtr<cairo_surface_t>, instead of
      NativeImageCairo*. Moving to smart pointers is needed to enable implementation
      of SVGImage::nativeImageForCurrentFrame() for Cairo.
      
      * platform/graphics/cairo/BitmapImageCairo.cpp:
      (WebCore::BitmapImage::BitmapImage):
      (WebCore::BitmapImage::draw):
      (WebCore::BitmapImage::checkForSolidColor):
      (WebCore::FrameData::clear):
      * platform/graphics/cairo/GraphicsContext3DCairo.cpp:
      (WebCore::GraphicsContext3D::ImageExtractor::extractImage):
      * platform/graphics/cairo/ImageCairo.cpp:
      (WebCore::Image::drawPattern):
      Update Cairo graphics code to reflect the (Pass)NativeImagePtr type changes.
      
      * platform/graphics/cairo/NativeImageCairo.cpp: Removed.
      * platform/graphics/cairo/NativeImageCairo.h: Removed.
      
      * platform/graphics/cairo/PatternCairo.cpp:
      (WebCore::Pattern::createPlatformPattern):
      * platform/graphics/efl/GraphicsContext3DEfl.cpp:
      (WebCore::GraphicsContext3D::ImageExtractor::extractImage):
      * platform/graphics/efl/ImageEfl.cpp:
      (WebCore::BitmapImage::getEvasObject):
      * platform/graphics/gtk/ImageGtk.cpp:
      (WebCore::BitmapImage::getGdkPixbuf):
      * platform/graphics/texmap/TextureMapperGL.cpp:
      (WebCore::BitmapTextureGL::updateContents):
      * platform/graphics/win/ImageCairoWin.cpp:
      (WebCore::BitmapImage::create):
      (WebCore::BitmapImage::drawFrameMatchingSourceSize):
      * platform/gtk/DragImageGtk.cpp:
      (WebCore::createDragImageFromImage):
      * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
      (WebCore::ImageFrame::asNewNativeImage):
      * platform/win/DragImageCairoWin.cpp:
      (WebCore::createDragImageFromImage):
      Update code to reflect the (Pass)NativeImagePtr type changes.
      
      * svg/graphics/SVGImage.cpp:
      (WebCore):
      * svg/graphics/SVGImage.h:
      Enable SVGImage::nativeImageForCurrentFrame() for USE(CAIRO).
      
      Source/WebKit:
      
      Remove outdated symbols now that NativeImageCairo was removed.
      
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
      
      Source/WebKit/efl:
      
      Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
      instead of NativeImageCairo*.
      
      * ewk/ewk_history.cpp:
      (ewk_history_item_icon_surface_get):
      (ewk_history_item_icon_object_add):
      * ewk/ewk_settings.cpp:
      (ewk_settings_icon_database_icon_surface_get):
      (ewk_settings_icon_database_icon_object_get):
      
      Source/WebKit/gtk:
      
      Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
      instead of NativeImageCairo*.
      
      * webkit/webkitfavicondatabase.cpp:
      (getIconPixbufSynchronously):
      
      Source/WebKit/win:
      
      Remove outdated symbols now that NativeImageCairo was removed.
      
      * WebKit.vcproj/WebKitExports.def.in:
      
      Source/WebKit2:
      
      Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
      instead of NativeImageCairo*.
      
      * Shared/gtk/ArgumentCodersGtk.cpp:
      (CoreIPC::decodeImage):
      * UIProcess/API/C/cairo/WKIconDatabaseCairo.cpp:
      (WKIconDatabaseTryGetCairoSurfaceForURL):
      * UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
      (getIconSurfaceSynchronously):
      
      LayoutTests:
      
      Add EFL / GTK pixels results for svg/canvas/canvas-pattern-svg.html now that
      the test passes for cairo-based ports.
      
      * platform/efl/svg/canvas/canvas-pattern-svg-expected.png: Added.
      * platform/gtk/svg/canvas/canvas-pattern-svg-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e39cc2b
    • commit-queue@webkit.org's avatar
      REGRESSION (r145870): Can't get insertion point to appear in some input and textareas on wordpress · 75547ee1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113591
      
      Patch by Xidorn Quan <quanxunzhen@gmail.com> on 2013-04-04
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Since a child node could overflow its ancestor, it is not wise to check
      one's radii boundary before checking whether the given point intersects
      its children. This patch moves the related code down to fix the bug.
      
      Test: fast/borders/border-radius-child.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::nodeAtPoint):
      
      LayoutTests:
      
      * fast/borders/border-radius-child-expected.txt: Added.
      * fast/borders/border-radius-child.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75547ee1
    • ch.dumez@sisa.samsung.com's avatar
      Regression(r142765) Broke Custom SVG cursors and SVG canvas drawing for Chromium · 8637f0dc
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113420
      
      Reviewed by Stephen White.
      
      Source/WebCore:
      
      Introduce a PassNativeImagePtr typedef that is used in place of NativeImagePtr
      for method arguments and return values. This is needed as Skia now maps
      NativeImagePtr to RefPtr<NativeImageSkia> and PassNativeImagePtr to
      PassRefPtr<NativeImageSkia>. We move towards ref counted smart pointers so that
      SVGImage::nativeImageForCurrentFrame() can transfer ownership of the native
      image to the caller if needed (e.g. for SVGImage).
      
      Provide nativeImageForCurrentFrame() implementation for SVGImage. SVGImage no
      longer holds the native image internally, to save memory. It is therefore created
      when nativeImageForCurrentFrame() is called and ownership is passed to the
      caller. For now, this implementation is only enabled for Skia as others are using
      raw pointers for PassNativeImagePtr.
      
      Test: svg/canvas/canvas-pattern-svg.html
      
      * loader/icon/IconDatabase.cpp:
      (WebCore::IconDatabase::synchronousNativeIconForPageURL):
      Return a PassNativeImagePtr instead of NativeImagePtr.
      
      * loader/icon/IconDatabase.h:
      (IconDatabase):
      * loader/icon/IconDatabaseBase.h:
      (WebCore::IconDatabaseBase::synchronousNativeIconForPageURL):
      Return a PassNativeImagePtr instead of NativeImagePtr.
      
      * platform/chromium/DragImageChromiumSkia.cpp:
      (WebCore::createDragImageFromImage):
      Store return value of nativeImageForCurrentFrame() in a RefPtr instead of a raw
      one.
      
      * platform/chromium/PasteboardChromium.cpp:
      (WebCore::Pasteboard::writeImage):
      Store return value of nativeImageForCurrentFrame() in a RefPtr<NativeImageSkia>
      instead of a NativeImagePtr. While these are equivalent, the former is more
      readable in Skia-specific code.
      
      * platform/graphics/BitmapImage.cpp:
      (WebCore::BitmapImage::frameAtIndex):
      Return a PassNativeImagePtr instead of a NativeImagePtr.
      
      (WebCore::BitmapImage::nativeImageForCurrentFrame):
      Return a PassNativeImagePtr instead of a NativeImagePtr.
      
      * platform/graphics/BitmapImage.h:
      (WebCore::BitmapImage::create):
      Take a PassNativeImagePtr in argument instead of a NativeImagePtr.
      
      (BitmapImage): Ditto.
      
      * platform/graphics/GraphicsContext.h:
      (GraphicsContext): Ditto.
      
      * platform/graphics/GraphicsContext3D.h:
      (ImageExtractor):
      Keep NativeImageSkia in a RefPtr instead of OwnPtr, now that it is refcounted.
      
      * platform/graphics/Image.h:
      (WebCore::Image::nativeImageForCurrentFrame):
      Return a PassNativeImagePtr instead of a NativeImagePtr.
      
      * platform/graphics/ImageBuffer.h:
      (ImageBuffer):
      Have copyNativeImage() return a PassNativeImagePtr instead of a NativeImagePtr.
      
      * platform/graphics/ImageSource.cpp:
      (WebCore::ImageSource::createFrameAtIndex):
      Return a PassNativeImagePtr instead of a NativeImagePtr.
      
      * platform/graphics/ImageSource.h:
      Have createFrameAtIndex() return a PassNativeImagePtr instead of a NativeImagePtr.
      
      * platform/graphics/NativeImagePtr.h:
      Map NativeImagePtr to a RefPtr<NativeImageSkia> instead of NativeImageSkia* for Skia.
      Introduce new PassNativeImagePtr that maps to PassRefPtr<NativeImageSkia> for Skia
      and is equivalent to NativeImagePtr for other ports. We now use smart pointers for
      the native image so that SVGImage::nativeImageForCurrentFrame() can pass ownership
      of the native image to the caller, unlike BitmapImage::nativeImageForCurrentFrame().
      
      * platform/graphics/blackberry/ImageBlackBerry.cpp:
      (WebCore::ImageFrame::asNewNativeImage):
      Return a PassNativeImagePtr instead of a NativeImagePtr.
      
      (WebCore::BitmapImage::BitmapImage):
      Take a PassNativeImagePtr instead of a NativeImagePtr in argument.
      
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::drawNativeImage): Ditto.
      
      * platform/graphics/cg/ImageBufferCG.cpp:
      (WebCore::ImageBuffer::copyNativeImage):
      Take a PassNativeImagePtr instead of a NativeImagePtr in argument.
      
      * platform/graphics/chromium/GraphicsLayerChromium.cpp:
      (WebCore::GraphicsLayerChromium::setContentsToImage):
      Store return value of nativeImageForCurrentFrame() in a RefPtr instead of a raw one.
      
      * platform/graphics/filters/skia/FEBlendSkia.cpp:
      (WebCore::FEBlend::platformApplySkia): Ditto.
      
      * platform/graphics/filters/skia/FEColorMatrixSkia.cpp:
      (WebCore::FEColorMatrix::platformApplySkia): Ditto.
      
      * platform/graphics/filters/skia/FEComponentTransferSkia.cpp:
      (WebCore::FEComponentTransfer::platformApplySkia): Ditto.
      
      * platform/graphics/filters/skia/FEDisplacementMapSkia.cpp:
      (WebCore::FEDisplacementMap::platformApplySkia): Ditto.
      
      * platform/graphics/filters/skia/FELightingSkia.cpp:
      (WebCore::FELighting::platformApplySkia): Ditto.
      
      * platform/graphics/qt/ImageDecoderQt.cpp:
      (WebCore::ImageFrame::asNewNativeImage):
      Return a PassNativeImagePtr instead of a NativeImagePtr.
      
      * platform/graphics/qt/StillImageQt.cpp:
      (WebCore::StillImage::nativeImageForCurrentFrame):
      Return a PassNativeImagePtr instead of a NativeImagePtr.
      
      * platform/graphics/qt/StillImageQt.h:
      (StillImage): Ditto.
      
      * platform/graphics/skia/GraphicsContext3DSkia.cpp:
      (WebCore::GraphicsContext3D::ImageExtractor::extractImage):
      No longer need to adopt the return value of asNewNativeImage() now
      that it returns a PassRefPtr instead of a raw one.
      
      * platform/graphics/skia/ImageBufferSkia.cpp:
      (WebCore::ImageBuffer::copyImage):
      (WebCore::ImageBuffer::draw):
      (WebCore::ImageBuffer::drawPattern):
      Call NativeImageSkia::create() factory method now that the constructor
      is private.
      
      * platform/graphics/skia/ImageSkia.cpp:
      (WebCore::FrameData::clear):
      Just call clear() on m_frame instead of explicitely deleting it now
      that it is a RefPtr.
      
      (WebCore::Image::drawPattern):
      Store return value of nativeImageForCurrentFrame() in a RefPtr instead
      of a raw one.
      
      (WebCore::BitmapImage::BitmapImage):
      (WebCore::BitmapImage::checkForSolidColor):
      Store return value of frameAtIndex() in a RefPtr instead of a raw one.
      
      (WebCore::BitmapImage::draw):
      Store return value of nativeImageForCurrentFrame() in a RefPtr instead
      of a raw one.
      
      * platform/graphics/skia/NativeImageSkia.cpp:
      Add new constructor taking all members in argument. This is used for
      cloning a NativeImageSkia object.
      
      (WebCore::NativeImageSkia::NativeImageSkia):
      (WebCore::NativeImageSkia::deepSkBitmapCopy):
      Add convenience function to make a deep copy of a SkBitmap.
      
      * platform/graphics/skia/NativeImageSkia.h:
      (WebCore):
      (WebCore::NativeImageSkia::create):
      (NativeImageSkia):
      Make NativeImageSkia subclass RefCounted. Make the constructor private
      and add a factory method instead that returns a PassRefPtr.
      
      (WebCore::NativeImageSkia::clone):
      Add a clone() method now that NativeImageSkia is refcounted and is no
      longer copyable.
      
      * platform/graphics/skia/PatternSkia.cpp:
      (WebCore::Pattern::platformPattern):
      Store return value of nativeImageForCurrentFrame() in a RefPtr instead
      of a raw one.
      
      * platform/graphics/wince/ImageWinCE.cpp:
      (WebCore::ImageFrame::asNewNativeImage):
      Return a PassNativeImagePtr instead of a NativeImagePtr.
      
      * platform/image-decoders/ImageDecoder.h:
      (ImageFrame):
      Have asNewNativeImage() return a PassNativeImagePtr instead of a
      NativeImagePtr.
      
      (WebCore::ImageFrame::getAddr):
      (WebCore::ImageFrame::setSkBitmap):
      (WebCore::ImageFrame::getSkBitmap):
      (WebCore::ImageFrame::width):
      (WebCore::ImageFrame::height):
      Update use of m_bitmap now that it is a pointer type and call
      NativeImageSkia::create() to construct a NativeImageSkia object now
      that the constructor is private.
      
      * platform/image-decoders/cairo/ImageDecoderCairo.cpp:
      (WebCore::ImageFrame::asNewNativeImage):
      Return a PassNativeImagePtr instead of a NativeImagePtr.
      
      * platform/image-decoders/openvg/ImageDecoderOpenVG.cpp:
      (WebCore::ImageFrame::asNewNativeImage): Ditto.
      
      * platform/image-decoders/skia/ImageDecoderSkia.cpp:
      (WebCore::ImageFrame::ImageFrame):
      Initialize m_bitmap in the constructor now that it is a pointer
      type and we need NativeImageSkia's default constructor to be
      called.
      
      (WebCore::ImageFrame::operator=):
      Call NativeImageSkia's new clone() method to copy m_bitmap as
      NativeImageSkia is now RefCounted and no longer copyable.
      
      (WebCore::ImageFrame::clearPixelData):
      (WebCore::ImageFrame::zeroFillPixelData):
      (WebCore::ImageFrame::copyBitmapData):
      (WebCore::ImageFrame::setSize):
      Update use of m_bitmap now that it is a pointer type.
      
      (WebCore::ImageFrame::asNewNativeImage):
      Return a PassNativeImagePtr instead of a NativeImagePtr.
      Call NativeImageSkia's clone method now that it is no longer
      copyable.
      
      (WebCore::ImageFrame::setHasAlpha):
      (WebCore::ImageFrame::setStatus):
      Update use of m_bitmap now that it is a pointer type.
      
      * platform/image-decoders/wx/ImageDecoderWx.cpp:
      (WebCore::ImageFrame::asNewNativeImage):
      Return a PassNativeImagePtr instead of a NativeImagePtr.
      
      * svg/graphics/SVGImage.cpp:
      (WebCore):
      (WebCore::SVGImage::nativeImageForCurrentFrame):
      Add implementation of nativeImageForCurrentFrame() for SVGImage as
      it is needed for SVG custom cursor support and Canvas drawing of
      patterns containing SVG images. As SVGImage no longer keep the
      native image internally to save memory, the implementation creates
      the native image when nativeImageForCurrentFrame() and passes
      its ownership to the caller.
      
      * svg/graphics/SVGImage.h:
      Override Image::nativeImageForCurrentFrame() and remove dummy
      implementation of frameAtIndex() as it is not needed / used.
      
      * svg/graphics/SVGImageForContainer.cpp:
      (WebCore::SVGImageForContainer::nativeImageForCurrentFrame):
      Add implementation of nativeImageForCurrentFrame() which merely
      forwards the call to the Image being contained.
      
      * svg/graphics/SVGImageForContainer.h:
      Override Image::nativeImageForCurrentFrame().
      
      Source/WebKit/chromium:
      
      Update code now that Image::nativeImageForCurrentFrame() and
      ImageFrame::asNewNativeImage() return a smart pointer instead
      of a raw one.
      
      * src/WebImageDecoder.cpp:
      (WebKit::WebImageDecoder::getFrameAtIndex):
      * src/WebImageSkia.cpp:
      (WebKit::WebImage::fromData):
      (WebKit::WebImage::framesFromData):
      (WebKit::WebImage::operator=):
      * tests/DeferredImageDecoderTest.cpp:
      (WebCore::TEST_F):
      * tests/DragImageTest.cpp:
      (WebCore::TestImage::TestImage):
      (WebCore::TestImage::nativeImageForCurrentFrame):
      (TestImage):
      * tests/ImageLayerChromiumTest.cpp:
      (WebCore::TestImage::TestImage):
      (WebCore::TestImage::nativeImageForCurrentFrame):
      (TestImage):
      * tests/PlatformContextSkiaTest.cpp:
      (WebCore::TEST):
      
      LayoutTests:
      
      Add layout test to check that drawing canvas patterns containing SVG images works.
      
      * platform/chromium-linux/svg/canvas/canvas-pattern-svg-expected.png: Added.
      * svg/canvas/canvas-pattern-svg-expected.txt: Added.
      * svg/canvas/canvas-pattern-svg.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8637f0dc
    • commit-queue@webkit.org's avatar
      [SOUP] inspector/timeline/timeline-receive-response-event.html fails · bc757216
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113860
      
      Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-04
      Reviewed by Xan Lopez.
      
      Copy the results of inspector/timeline/timeline-receive-response-event.html
      to the efl and gtk platform dir.
      Because test files are bigger than buffer size of ResourceHandleSoup.
      
      * platform/efl/TestExpectations:
      * platform/efl/inspector/timeline/timeline-receive-response-event-expected.txt: Added.
      * platform/gtk/TestExpectations:
      * platform/gtk/inspector/timeline/timeline-receive-response-event-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc757216
    • jochen@chromium.org's avatar
      [EFL][Qt] The layout test fast/loader/url-selected-user-gesture.html is failing. · d1c03cb5
      jochen@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113930
      
      Reviewed by Antti Koivisto.
      
      * fast/loader/url-selected-user-gesture.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1c03cb5
    • commit-queue@webkit.org's avatar
      [Qt] WebSocket errors should be logged to console · 6906c324
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113842
      
      Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-04
      Reviewed by Jocelyn Turcotte.
      
      Source/WebCore:
      
      Pass the reason of a failure to SocketStreamError instance
      and notify it via SocketStreamHandleClient::didFailSocketStream().
      
      Test : http/tests/inspector/console-websocket-error.html
      
      * platform/network/qt/SocketStreamError.h:
      (WebCore::SocketStreamError::SocketStreamError):
      * platform/network/qt/SocketStreamHandleQt.cpp:
      (WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
      (WebCore::SocketStreamHandlePrivate::socketErrorCallback):
      
      LayoutTests:
      
      * platform/qt/TestExpectations:
      * platform/qt/http/tests/inspector/console-websocket-error-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6906c324
    • kadam@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. · 056c5876
      kadam@inf.u-szeged.hu authored
      * platform/qt/TestExpectations: Skipped some failing tests.
      * platform/qt/fast/borders/rtl-border-04-expected.png: Updated after r147588.
      * platform/qt/fast/borders/rtl-border-04-expected.txt: Updated after r147588.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      056c5876
    • glenn@skynav.com's avatar
      [Mac] Unreviewed gardening. Rebaseline after r147588. · 67d69c64
      glenn@skynav.com authored
      * platform/mac-lion/fast/text/international/text-combine-image-test-expected.png:
      * platform/mac-lion/fast/text/international/text-combine-image-test-expected.txt:
      * platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
      * platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
      * platform/mac-wk2/fast/text: Added.
      * platform/mac-wk2/fast/text/international: Added.
      * platform/mac-wk2/fast/text/international/003-expected.png: Added.
      * platform/mac-wk2/fast/text/international/text-combine-image-test-expected.png: Added.
      * platform/mac-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
      * platform/mac/fast/text/international/003-expected.png:
      * platform/mac/fast/text/international/003-expected.txt:
      * platform/mac/fast/text/international/text-combine-image-test-expected.png: Added.
      * platform/mac/fast/text/international/text-combine-image-test-expected.txt:
      * platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
      * platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67d69c64
  3. 03 Apr, 2013 5 commits
    • gyuyoung.kim@samsung.com's avatar
      [EFL] Add a decoration image to search input field · f6ba88c9
      gyuyoung.kim@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=113552
      
      Reviewed by Laszlo Gombos.
      
      Source/WebCore:
      
      Though EFL port has a decoration image for search input field, we didn't use it.
      Start to show it.
      
      Tests: fast/forms/search-cancel-button-style-sharing.html
             fast/forms/search-rtl.html
             fast/css/input-search-padding.html
             fast/css/text-input-with-webkit-border-radius.html
             fast/css/text-overflow-input.html
             fast/forms/box-shadow-override.html
             fast/forms/control-restrict-line-height.html
             fast/forms/input-appearance-height.html
             fast/forms/placeholder-position.html
             fast/forms/placeholder-pseudo-style.html
             fast/forms/search-styled.html
             fast/forms/search-vertical-alignment.html
             fast/forms/searchfield-heights.html
             fast/repaint/search-field-cancel.html
             fast/replaced/width100percent-searchfield.html
      
      * platform/efl/RenderThemeEfl.cpp:
      (WebCore):
      (WebCore::RenderThemeEfl::supportsDataListUI):
      (WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):
      
      LayoutTests:
      
      Rebaseline related to input search field.
      
      * platform/efl/fast/css/input-search-padding-expected.png:
      * platform/efl/fast/css/input-search-padding-expected.txt:
      * platform/efl/fast/css/text-input-with-webkit-border-radius-expected.png:
      * platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
      * platform/efl/fast/css/text-overflow-input-expected.png:
      * platform/efl/fast/css/text-overflow-input-expected.txt:
      * platform/efl/fast/forms/box-shadow-override-expected.png:
      * platform/efl/fast/forms/box-shadow-override-expected.txt:
      * platform/efl/fast/forms/control-restrict-line-height-expected.png:
      * platform/efl/fast/forms/control-restrict-line-height-expected.txt:
      * platform/efl/fast/forms/input-appearance-height-expected.png:
      * platform/efl/fast/forms/input-appearance-height-expected.txt:
      * platform/efl/fast/forms/placeholder-position-expected.png:
      * platform/efl/fast/forms/placeholder-position-expected.txt:
      * platform/efl/fast/forms/placeholder-pseudo-style-expected.png:
      * platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
      * platform/efl/fast/forms/search-cancel-button-style-sharing-expected.png:
      * platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
      * platform/efl/fast/forms/searchfield-heights-expected.png:
      * platform/efl/fast/forms/searchfield-heights-expected.txt:
      * platform/efl/fast/repaint/search-field-cancel-expected.png:
      * platform/efl/fast/repaint/search-field-cancel-expected.txt:
      * platform/efl/fast/replaced/width100percent-searchfield-expected.png:
      * platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6ba88c9
    • gyuyoung.kim@samsung.com's avatar
      Unreviewed gardening. Below tests aren't related to bug 87619. It just needs to do rebaseline. · 849e547f
      gyuyoung.kim@samsung.com authored
      * platform/efl/TestExpectations:
      * platform/efl/fast/forms/number/number-appearance-rtl-expected.png:
      * platform/efl/fast/forms/number/number-appearance-rtl-expected.txt:
      * platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
      * platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
      * platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
      * platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      849e547f
    • tkent@chromium.org's avatar
      Input value/placeholder is not redrawn when the input height grows · 67f16926
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=113845
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Test: fast/forms/text/text-height-grow.html
      
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::styleDidChange):
      We need relayout of the inner text element.
      
      LayoutTests:
      
      * fast/forms/text/text-height-grow-expected.html: Added.
      * fast/forms/text/text-height-grow.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67f16926
    • glenn@skynav.com's avatar
      [GTK] Unreviewed gardening. Rebaseline after r147588. · e90aa924
      glenn@skynav.com authored
      * platform/gtk-wk1/fast/writing-mode: Added.
      * platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e90aa924
    • glenn@skynav.com's avatar
      [Chromium] Unreviewed gardening. Rebaseline after r147588. · 2653f8e4
      glenn@skynav.com authored
      * platform/chromium-mac-lion/fast/text/international/003-expected.png:
      * platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.png:
      * platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.txt:
      * platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
      * platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
      * platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.png: Removed.
      * platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
      * platform/chromium-mac/fast/text/international/003-expected.png:
      * platform/chromium-mac/fast/text/international/003-expected.txt: Added.
      * platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
      * platform/chromium-mac/fast/text/international/text-combine-image-test-expected.txt:
      * platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
      * platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
      * platform/chromium-win/fast/text/international/003-expected.png:
      * platform/chromium-win/fast/text/international/003-expected.txt:
      * platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
      * platform/chromium/TestExpectations:
      * platform/chromium/fast/text/international/003-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2653f8e4