- 07 Jul, 2011 28 commits
-
-
caseq@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=64089 Reviewed by Pavel Feldman. * inspector/front-end/networkPanel.css: (.data-grid.network-log-grid tr.filler td): (.network.panel .sidebar): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jchaffraix@webkit.org authored
Reviewed by David Hyatt. Partial layout when a flex-box has visibility: collapse https://bugs.webkit.org/show_bug.cgi?id=63776 Source/WebCore: Tests: fast/flexbox/crash-button-input-autofocus.html fast/flexbox/crash-button-keygen.html fast/flexbox/crash-button-relayout.html The issue is that FlexBoxIterator would skip any child if it has visibility: collapsed. However if one of the child is anonymous, it may wrap some other child that would be skipped. Now FlexBoxIterator is called during the layout phase and thus some nodes would not relayouted as expected. * rendering/RenderDeprecatedFlexibleBox.cpp: (WebCore::FlexBoxIterator::next): When iterating, don't skip anonymous content as there may be real content hiding below. LayoutTests: Those tests checks some variation of the same underlying issue. * fast/flexbox/crash-button-input-autofocus-expected.txt: Added. * fast/flexbox/crash-button-input-autofocus.html: Added. * fast/flexbox/crash-button-keygen-expected.txt: Added. * fast/flexbox/crash-button-keygen.html: Added. * fast/flexbox/crash-button-relayout-expected.txt: Added. * fast/flexbox/crash-button-relayout.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vsevik@chromium.org authored
Web Inspector: URL links in styles open new tab instead of showing resources panel. https://bugs.webkit.org/show_bug.cgi?id=64090 Reviewed by Pavel Feldman. * inspector/styles/styles-url-linkify-expected.txt: * inspector/styles/styles-url-linkify.html: 2011-07-07 Vsevolod Vlasov <vsevik@chromium.org> Web Inspector: URL links in styles open new tab instead of showing resources panel. https://bugs.webkit.org/show_bug.cgi?id=64090 Reviewed by Pavel Feldman. * inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.linkifyURL): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abecsi@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=64103 Unreviewed gardening. * platform/qt/Skipped: Skip test. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
caseq@chromium.org authored
Web Inspector: active panel does not receive resize event when drawer is resized https://bugs.webkit.org/show_bug.cgi?id=64094 Reviewed by Pavel Feldman. * inspector/front-end/Drawer.js: (WebInspector.Drawer.prototype._statusBarDragging): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
Fixes <http://webkit.org/b/26755> webkit-patch's commit messages are less readable than commit-log-editor's Reviewed by David Kilzer. * Scripts/webkitpy/common/checkout/checkout.py: (Checkout.commit_message_for_this_commit): Run commit-log-editor, passing it the paths of the modified ChangeLogs, to generate the commit message, rather than trying to generate one ourselves. * Scripts/webkitpy/common/checkout/checkout_unittest.py: Updated the expected commit message to match commit-log-editor's format. (CommitMessageForThisCommitTest.setUp): Write the ChangeLogs into Tools and LayoutTests directories so we can see how the various entries get labeled in the commit message. (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Create a mock SCM instance that knows how to find commit-log-editor and pass it to our Checkout instance. Don't bother capturing output, since there shouldn't be any. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90564 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
When specified, commit-log-editor takes a set of ChangeLog paths on the command line, generates a commit message from those ChangeLogs, prints it to stdout, and exits. Prep work for fixing <http://webkit.org/b/26755> webkit-patch's commit messages are less readable than commit-log-editor's Reviewed by David Kilzer. * Scripts/commit-log-editor: Changed to use Getopt::Long to parse options. Added --print-log option, which calls through to createCommitMessage, prints the result, and exits. (printUsageAndExit): Renamed from "usage" for clarity. Beefed up the usage statement to explain commit-log-editor's 2.5 (normal, --print-log, and --help) modes of operation. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
aroben@apple.com authored
As a bonus, we now skip a bunch of work in the case where we are generating a commit message for staged git changes. Prep work for fixing <http://webkit.org/b/26755> webkit-patch's commit messages are less readable than commit-log-editor's Reviewed by David Kilzer. * Scripts/commit-log-editor: Moved the default definition of $endl up toward the top of the file so that it will be defined even if we aren't operating on an existing log message. Moved a bunch of top-level code to generate the commit message from here... (createCommitMessage): ...to here. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Web Inspector: prevent default action during drag'n'drop in the Elements panel. https://bugs.webkit.org/show_bug.cgi?id=64081 Reviewed by Yury Semikhatsky. * inspector/front-end/ElementsTreeOutline.js: (WebInspector.ElementsTreeOutline): (WebInspector.ElementsTreeOutline.prototype._ondragstart): (WebInspector.ElementsTreeOutline.prototype._ondragover): (WebInspector.ElementsTreeOutline.prototype._ondragend): * inspector/front-end/treeoutline.js: (TreeOutline.prototype.treeElementFromPoint): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zimmermann@webkit.org authored
Move remaining enums out of SVG*Element classes https://bugs.webkit.org/show_bug.cgi?id=64075 Reviewed by Dirk Schulze. Move remaining enums out of SVG*Element classes. This is a preparation patch for bug 63797. Also move the SVGPropertyTraits template specializations for enum types before the class definition in the header, otherwhise we can't use SVGPropertyTraits<FooType>::fromString/toString in the DECLARE_ANIMATED* macros, which is needed soon. No new tests, just refactoring. * rendering/svg/RenderSVGResourceGradient.cpp: (WebCore::RenderSVGResourceGradient::applyResource): * rendering/svg/RenderSVGResourceGradient.h: * rendering/svg/RenderSVGResourceMarker.cpp: (WebCore::RenderSVGResourceMarker::angle): (WebCore::RenderSVGResourceMarker::markerTransformation): * rendering/svg/RenderSVGResourceMarker.h: (WebCore::RenderSVGResourceMarker::markerUnits): * rendering/svg/RenderSVGTextPath.cpp: (WebCore::RenderSVGTextPath::RenderSVGTextPath): (WebCore::RenderSVGTextPath::exactAlignment): (WebCore::RenderSVGTextPath::stretchMethod): * rendering/svg/SVGRenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeCommonGradientProperties): * rendering/svg/SVGTextChunkBuilder.cpp: (WebCore::SVGTextChunkBuilder::addTextChunk): * rendering/svg/SVGTextLayoutEngine.cpp: (WebCore::SVGTextLayoutEngine::parentDefinesTextLength): (WebCore::SVGTextLayoutEngine::beginTextPathLayout): * svg/GradientAttributes.h: (WebCore::GradientAttributes::GradientAttributes): (WebCore::GradientAttributes::spreadMethod): (WebCore::GradientAttributes::setSpreadMethod): * svg/SVGComponentTransferFunctionElement.h: * svg/SVGFEBlendElement.h: * svg/SVGFEColorMatrixElement.h: * svg/SVGFECompositeElement.h: * svg/SVGFEConvolveMatrixElement.h: * svg/SVGFEDisplacementMapElement.h: * svg/SVGFEMorphologyElement.h: * svg/SVGFETurbulenceElement.h: * svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::SVGGradientElement): * svg/SVGGradientElement.h: * svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::parseMappedAttribute): (WebCore::SVGMarkerElement::setOrientToAuto): (WebCore::SVGMarkerElement::setOrientToAngle): (WebCore::SVGMarkerElement::synchronizeOrientType): (WebCore::SVGMarkerElement::orientTypeAnimated): * svg/SVGMarkerElement.h: * svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::SVGTextContentElement): * svg/SVGTextContentElement.h: * svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::SVGTextPathElement): * svg/SVGTextPathElement.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xan@webkit.org authored
Unreviewed. Enable inspector tests again (they should work now), and skip test that is timing out in all GTK+ bots. * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
loislo@chromium.org authored
Web Inspector: Protocol: pointers to optional "in" parameters passing to the backend methods should be NULL if they are not specified in the message. https://bugs.webkit.org/show_bug.cgi?id=64083 Reviewed by Pavel Feldman. * inspector/CodeGeneratorInspector.pm: (generateBackendFunction): (generateArgumentGetters): * inspector/InspectorCSSAgent.cpp: (WebCore::InspectorCSSAgent::getStylesForNode): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vsevik@chromium.org authored
Web Inspector: Move resetting NetworkResourcesData out of tests unrelated to replacement testing. https://bugs.webkit.org/show_bug.cgi?id=64078 Reviewed by Pavel Feldman. * http/tests/inspector/network-test.js: (initialize_NetworkTest.InspectorTest.resetInspectorResourcesData.nextStep): (initialize_NetworkTest.InspectorTest.resetInspectorResourcesData): (resetInspectorResourcesData): * http/tests/inspector/network/network-clear-cache-expected.txt: * http/tests/inspector/network/network-clear-cache.html-disabled: * http/tests/inspector/network/network-clear-cookies-expected.txt: * http/tests/inspector/network/network-clear-cookies.html-disabled: * http/tests/inspector/network/network-embed-expected.txt: * http/tests/inspector/network/network-embed.html: * http/tests/inspector/network/network-xhr-async-expected.txt: * http/tests/inspector/network/network-xhr-async.html: * http/tests/inspector/network/network-xhr-sync-expected.txt: * http/tests/inspector/network/network-xhr-sync.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
loislo@chromium.org authored
Web Inspector: Searching on the Network panel doesn't do anything? https://bugs.webkit.org/show_bug.cgi?id=55489 This is initial implementation of search in Network panel. It is pretty simple search only for names and paths. Reviewed by Pavel Feldman. * inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype.refresh): (WebInspector.NetworkPanel.prototype._reset): (WebInspector.NetworkPanel.prototype._updateOffscreenRows): (WebInspector.NetworkPanel.prototype._matchResource): (WebInspector.NetworkPanel.prototype._clearSearchMatchedList): (WebInspector.NetworkPanel.prototype._highlightNthMatchedResource): (WebInspector.NetworkPanel.prototype.performSearch): (WebInspector.NetworkDataGridNode.prototype.createCells): * inspector/front-end/utilities.js: (String.prototype.escapeHTML): (): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vsevik@chromium.org authored
Web Inspector: Resources panel shows only one resource when multiple resources have the same url. https://bugs.webkit.org/show_bug.cgi?id=63936 Reviewed by Pavel Feldman. * http/tests/inspector/resource-tree/resource-tree-non-unique-url-expected.txt: Added. * http/tests/inspector/resource-tree/resource-tree-non-unique-url.html: Added. * http/tests/inspector/resource-tree/resource-tree-test.js: (initialize_ResourceTreeTest.InspectorTest.dumpResourcesTree): * http/tests/inspector/resource-tree/resources/resource-tree-non-unique-url-iframe.html: Added. * http/tests/inspector/resource-tree/resources/styles-non-unique-url.css: Added. (body): 2011-07-07 Vsevolod Vlasov <vsevik@chromium.org> Web Inspector: Resources panel shows only one resource when multiple resources have the same url. https://bugs.webkit.org/show_bug.cgi?id=63936 Reviewed by Pavel Feldman. Test: http/tests/inspector/resource-tree/resource-tree-non-unique-url.html * inspector/front-end/ResourcesPanel.js: (WebInspector.FrameTreeElement.prototype.appendResource): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
GTK: media/video-src-invalid-poster.html Failed https://bugs.webkit.org/show_bug.cgi?id=61160 Wait for loadstart event to check the poster dimensions and avoid a potential timeout of the test. * media/video-src-invalid-poster-expected.txt: * media/video-src-invalid-poster.html: * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vsevik@chromium.org authored
Web Inspector: Add support for clearing cache and cookies from network panel. https://bugs.webkit.org/show_bug.cgi?id=63999 Added clear cache and cookies tests. Since no port currently supports this functionality, the tests are disabled. Reviewed by Pavel Feldman. * http/tests/inspector/network/network-clear-cache-expected.txt: Added. * http/tests/inspector/network/network-clear-cache.html-disabled: Added. * http/tests/inspector/network/network-clear-cookies-expected.txt: Added. * http/tests/inspector/network/network-clear-cookies.html-disabled: Added. * http/tests/inspector/network/resources/random-cached.php: Added. * http/tests/inspector/network/resources/set-cookie.php: Added. 2011-07-07 Vsevolod Vlasov <vsevik@chromium.org> Web Inspector: Add support for clearing cache and cookies from network panel. https://bugs.webkit.org/show_bug.cgi?id=63999 Reviewed by Pavel Feldman. * English.lproj/localizedStrings.js: * inspector/Inspector.json: * inspector/InspectorClient.h: (WebCore::InspectorClient::clearBrowserCache): (WebCore::InspectorClient::clearBrowserCookies): * inspector/InspectorController.cpp: (WebCore::InspectorController::InspectorController): * inspector/InspectorResourceAgent.cpp: (WebCore::InspectorResourceAgent::clearBrowserCache): (WebCore::InspectorResourceAgent::clearBrowserCookies): (WebCore::InspectorResourceAgent::InspectorResourceAgent): * inspector/InspectorResourceAgent.h: (WebCore::InspectorResourceAgent::create): * inspector/front-end/NetworkPanel.js: (WebInspector.NetworkPanel.prototype._contextMenu): (WebInspector.NetworkPanel.prototype._clearBrowserCache): (WebInspector.NetworkPanel.prototype._clearBrowserCookies): * inspector/front-end/Settings.js: 2011-07-07 Vsevolod Vlasov <vsevik@chromium.org> Web Inspector: Add support for clearing cache and cookies from network panel. https://bugs.webkit.org/show_bug.cgi?id=63999 Reviewed by Pavel Feldman. * public/WebDevToolsAgentClient.h: (WebKit::WebDevToolsAgentClient::clearBrowserCache): (WebKit::WebDevToolsAgentClient::clearBrowserCookies): * src/InspectorClientImpl.cpp: (WebKit::InspectorClientImpl::clearBrowserCache): (WebKit::InspectorClientImpl::clearBrowserCookies): * src/InspectorClientImpl.h: * src/WebDevToolsAgentImpl.cpp: (WebKit::WebDevToolsAgentImpl::clearBrowserCache): (WebKit::WebDevToolsAgentImpl::clearBrowserCookies): * src/WebDevToolsAgentImpl.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Added more key bindings for input[type=range]. https://bugs.webkit.org/show_bug.cgi?id=52262 Added PageUp/PageDown/Home/End key bindings tests for input[type=range]. Reviewed by Kent Tamura. * fast/forms/range-keyoperation-expected.txt: Regenerated. * fast/forms/range-keyoperation.html: Added more key bindings tests. 2011-07-07 Shinya Kawanaka <shinyak@google.com> Added more key bindings for input[type=range]. https://bugs.webkit.org/show_bug.cgi?id=52262 Added PageUp/PageDown/Home/End key bindings for input[type=range]. PageUp/PageDown change value by about 10%. Home/End change value to minimum/maximum. Reviewed by Kent Tamura. * html/RangeInputType.cpp: (WebCore::RangeInputType::handleKeydownEvent): Added key bindings. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
carlosgc@webkit.org authored
[GTK] Open links in a new window when clicking with the middle button in MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=63988 Reviewed by Martin Robinson. * MiniBrowser/gtk/BrowserWindow.c: (browserWindowConstructed): (decidePolicyForNavigationAction): Ignore the action if a link is clicked with the middle buttonm and open the link in a new window. (browserWindowPolicyClientInit): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
[Qt] [WK2] Improve the handling of touch events to use them as main input https://bugs.webkit.org/show_bug.cgi?id=63991 Reviewed by Kenneth Rohde Christiansen. Promote touch event for use as primary input. The touch events now use the responsiveness timer like the other input events. The touch events also have a callback to the UI signaling if the event was used or not: PageClient::doneWithTouchEvent(). This is similar to what is done with key events (PageClient::doneWithKeyEvent()). * Shared/NativeWebTouchEvent.h: Copied from Source/WebKit2/Shared/qt/WebEventFactoryQt.h. (WebKit::NativeWebTouchEvent::nativeEvent): * Shared/qt/NativeWebTouchEventQt.cpp: Copied from Source/WebKit2/Shared/qt/WebEventFactoryQt.h. (WebKit::NativeWebTouchEvent::NativeWebTouchEvent): * Shared/qt/WebEventFactoryQt.cpp: (WebKit::webEventTypeForEvent): (WebKit::WebEventFactory::createWebTouchEvent): * Shared/qt/WebEventFactoryQt.h: * UIProcess/PageClient.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::handleTouchEvent): (WebKit::WebPageProxy::didReceiveEvent): * UIProcess/WebPageProxy.h: * UIProcess/qt/qdesktopwebpageproxy.cpp: (QDesktopWebPageProxy::doneWithTouchEvent): * UIProcess/qt/qdesktopwebpageproxy.h: * UIProcess/qt/qtouchwebpageproxy.cpp: (QTouchWebPageProxy::doneWithTouchEvent): (QTouchWebPageProxy::touchEvent): * UIProcess/qt/qtouchwebpageproxy.h: * WebKit2.pro: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Remove style_references.py https://bugs.webkit.org/show_bug.cgi?id=64070 Reviewed by Eric Seidel. We never really adopted the _references design, and this file is a bit of an orphan at this point. * Scripts/check-webkit-style: * Scripts/webkitpy/style/checker.py: * Scripts/webkitpy/style/checker_unittest.py: * Scripts/webkitpy/style/checkers/python.py: * Scripts/webkitpy/style/checkers/test_expectations.py: * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: * Scripts/webkitpy/style/main_unittest.py: * Scripts/webkitpy/style_references.py: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=64056 Unreviewed. I had written this unittest prior to landing my change, but had named it qt_unitest.py, so it wasn't running (nor was it added to my git repo). Once I fixe the name of the unittest file, it was very easy to fix the error in webkit.py (which already had a FIXME). * Scripts/webkitpy/layout_tests/port/qt_unittest.py: Added. * Scripts/webkitpy/layout_tests/port/webkit.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Unreviewed. Add more debug logging about which test expectations we're using. * Scripts/webkitpy/layout_tests/models/test_expectations.py: * Scripts/webkitpy/layout_tests/port/webkit.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Remove unexpected_results.json https://bugs.webkit.org/show_bug.cgi?id=64065 Reviewed by Eric Seidel. No one should be using this file any more. This patch removes it from the face of the earth. This patch also removes two NRWT-specific command line options that were implemented using unexpected_results.json. * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py: * Scripts/webkitpy/layout_tests/controllers/manager.py: * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: * Scripts/webkitpy/tool/commands/rebaselineserver.py: * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
REGRESSION(90520): chromium GPU tests produce output in the LayoutTests directory https://bugs.webkit.org/show_bug.cgi?id=64067 Reviewed by Eric Seidel. The author of r90520 forgot to change the chromium_gpu.py implemenation of this method as well. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Fix InspectorInstrumentation compilation. https://bugs.webkit.org/show_bug.cgi?id=64033 Reviewed by Yury Semikhatsky. No new tests. just compile fix. * inspector/InspectorInstrumentation.cpp: (WebCore::InspectorInstrumentation::didInvalidateStyleAttrImpl): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests https://bugs.webkit.org/show_bug.cgi?id=64056 Reviewed by Adam Barth. This fixes the MacPort's version of baseline_search_path to include wk2 fallback like WebKitPort's does. This also re-works the QtPort to set self._name (as other ports do) so that WebKitPort's default implementations will understand Qt operating system flavors correctly (including when running wk2 tests). In trying to test this, I realized that nearly all of our port-tests use the default FileSystem(), User() and Executive() objects, which is really bad, because they expose details of your system in the unittest results! Once I fixed many of the Port() calls to pass MockFileSystem(), then MacPort.test_tests_for_other_platforms started failing, and I had to teach MockFileSystem.glob how to handle directories to make it work again. I removed the useless PortTestCase.test_baseline_search_path and replaced it with more useful test_baseline_search_path tests in MacPortTest and QtPortTest. * Scripts/webkitpy/common/config/ports.py: * Scripts/webkitpy/common/system/filesystem_mock.py: * Scripts/webkitpy/layout_tests/port/chromium_linux.py: * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: * Scripts/webkitpy/layout_tests/port/mac.py: * Scripts/webkitpy/layout_tests/port/mac_unittest.py: * Scripts/webkitpy/layout_tests/port/port_testcase.py: * Scripts/webkitpy/layout_tests/port/qt.py: * Scripts/webkitpy/layout_tests/port/test_files.py: * Scripts/webkitpy/layout_tests/port/win.py: * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: * Scripts/webkitpy/tool/mocktool.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Wean rebaseline-server off unexpected_results.json https://bugs.webkit.org/show_bug.cgi?id=64063 Reviewed by Eric Seidel. In the process of changing this code to use full_results.json, I noticed that the code was broken (because it wasn't tested). This patch also adds test coverage for the broken code. * Scripts/webkitpy/tool/commands/rebaselineserver.py: * Scripts/webkitpy/tool/servers/rebaselineserver.py: * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 06 Jul, 2011 12 commits
-
-
commit-queue@webkit.org authored
Reviewed by David Hyatt. [CSSRegions] Parse flow property https://bugs.webkit.org/show_bug.cgi?id=61730 * fast/regions/script-tests/TEMPLATE.html: Added. * fast/regions/script-tests/webkit-flow-parsing.js: Added. (test): (testComputedStyle): (testNotInherited): * fast/regions/webkit-flow-parsing-expected.txt: Added. * fast/regions/webkit-flow-parsing.html: Added. 2011-07-06 Mihnea Ovidenie <mihnea@adobe.com> Reviewed by David Hyatt. [CSSRegions] Parse flow property https://bugs.webkit.org/show_bug.cgi?id=61730 Test: fast/regions/webkit-flow-parsing.html * css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseFlowThread): * css/CSSParser.h: * css/CSSPropertyNames.in: * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): * rendering/style/RenderStyle.cpp: (WebCore::RenderStyle::diff): * rendering/style/RenderStyle.h: (WebCore::InheritedFlags::flowThread): (WebCore::InheritedFlags::setFlowThread): (WebCore::InheritedFlags::initialFlowThread): * rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): * rendering/style/StyleRareNonInheritedData.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Unreviewed. Rolled DEPS. * DEPS: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Wean resultsjsonparser off unexpected_results.json https://bugs.webkit.org/show_bug.cgi?id=64061 Reviewed by Eric Seidel. We're about to delete unexpected_results.json, so we need to remove all the users. * Scripts/webkitpy/common/config/ports.py: * Scripts/webkitpy/common/net/resultsjsonparser.py: * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py: * Scripts/webkitpy/layout_tests/models/test_expectations.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Cleanup result_summary.py https://bugs.webkit.org/show_bug.cgi?id=64057 Reviewed by Eric Seidel. This class had a bunch of out-of-date docstrings that no longer make any sense. * Scripts/webkitpy/layout_tests/models/result_summary.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Tweak the ChangeLog for DEPS rolls to say "Unreviewed" so that the patches can be landed by the commit-queue. * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
[ShadowContentElement] Redundant RenderText objects are created on the content boundaries. https://bugs.webkit.org/show_bug.cgi?id=63977 Reviewed by Dimitri Glazkov. This test have two set of fixture DOM tree: One is for shadow tree which has one content element, another is for light DOM tree, whose root is to have a shadow DOM. Then the test makes 2 complete DOM trees (DOM tree with shadow and flattened dom) for each combination of the fixture items. And compare their layout result. * fast/dom/shadow/content-element-renderers-expected.txt: Added. * fast/dom/shadow/content-element-renderers.html: Added. 2011-07-06 MORITA Hajime <morrita@google.com> [ShadowContentElement] Redundant RenderText objects are created on the content boundaries. https://bugs.webkit.org/show_bug.cgi?id=63977 Reviewed by Dimitri Glazkov. NodeRenderingContext::nextRenderer() and previousRenderer() didn't work well when it crosses content elements: - It doesn't step into forwarded children of ShadowContentElement. - It doesn't step out from traversing forwarded children to neighbors of the content element of that forwarded chidren. This change makes it to step into and out from content element. Test: fast/dom/shadow/content-element-renderers.html * dom/NodeRenderingContext.cpp: (WebCore::firstRendererOf): Added (WebCore::lastRendererOf): Added (WebCore::NodeRenderingContext::nextRenderer): (WebCore::NodeRenderingContext::previousRenderer): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
ASSERT_NOT_REACHED running test 262 https://bugs.webkit.org/show_bug.cgi?id=63951 Added a test to check compliance with reserved words in strict mode. Updated test results. Reviewed by Gavin Barraclough. * fast/js/kde/parse-expected.txt: * fast/js/reserved-words-as-property-expected.txt: * fast/js/reserved-words-strict-expected.txt: Added. * fast/js/reserved-words-strict.html: Added. * fast/js/script-tests/reserved-words-strict.js: Added. (isReserved): * platform/chromium/fast/js/reserved-words-strict-expected.txt: Added. * sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T1-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T2-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T3-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T4-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.2_White_Space/S7.2_A5_T5-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T1-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T2-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T3-expected.txt: * sputnik/Conformance/07_Lexical_Conventions/7.3_Line_Terminators/S7.3_A6_T4-expected.txt: * sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T13-expected.txt: 2011-07-06 Juan C. Montemayor <jmont@apple.com> ASSERT_NOT_REACHED running test 262 https://bugs.webkit.org/show_bug.cgi?id=63951 Added a case to the switch statement where the code was failing. Fixed some logic as well that gave faulty error messages. Reviewed by Gavin Barraclough. * parser/JSParser.cpp: (JSC::JSParser::getTokenName): (JSC::JSParser::updateErrorMessageSpecialCase): (JSC::JSParser::updateErrorMessage): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Normalize callers of logging.getLogger to use __name__ https://bugs.webkit.org/show_bug.cgi?id=64054 Reviewed by Eric Seidel. Most callers were already using __name__. This patch makes everyone consistent. * Scripts/webkitpy/common/checkout/diff_parser.py: * Scripts/webkitpy/common/checkout/scm/svn.py: * Scripts/webkitpy/common/net/statusserver.py: * Scripts/webkitpy/common/system/executive.py: * Scripts/webkitpy/common/system/file_lock.py: * Scripts/webkitpy/common/system/user.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: * Scripts/webkitpy/layout_tests/models/result_summary.py: * Scripts/webkitpy/layout_tests/models/test_expectations.py: * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/port/chromium_linux.py: * Scripts/webkitpy/layout_tests/port/chromium_mac.py: * Scripts/webkitpy/layout_tests/port/chromium_win.py: * Scripts/webkitpy/layout_tests/port/gtk.py: * Scripts/webkitpy/layout_tests/port/http_lock.py: * Scripts/webkitpy/layout_tests/port/mac.py: * Scripts/webkitpy/layout_tests/port/qt.py: * Scripts/webkitpy/layout_tests/port/server_process.py: * Scripts/webkitpy/layout_tests/port/webkit.py: * Scripts/webkitpy/layout_tests/port/win.py: * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: * Scripts/webkitpy/layout_tests/servers/http_server.py: * Scripts/webkitpy/layout_tests/servers/http_server_base.py: * Scripts/webkitpy/layout_tests/servers/websocket_server.py: * Scripts/webkitpy/layout_tests/views/printing.py: * Scripts/webkitpy/python24/versioning.py: * Scripts/webkitpy/style/checker.py: * Scripts/webkitpy/style/checkers/test_expectations.py: * Scripts/webkitpy/style/patchreader.py: * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
DFG JIT implementation of op_call results in regressions on sunspider controlflow-recursive. https://bugs.webkit.org/show_bug.cgi?id=64039 Reviewed by Gavin Barraclough. * dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::isSmallInt32Constant): (JSC::DFG::ByteCodeParser::parseBlock): * dfg/DFGSpeculativeJIT.h: (JSC::DFG::SpeculativeJIT::isInteger): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Move model classes out of layout_package and into models https://bugs.webkit.org/show_bug.cgi?id=64053 Reviewed by Eric Seidel. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: * Scripts/webkitpy/common/net/layouttestresults.py: * Scripts/webkitpy/common/net/layouttestresults_unittest.py: * Scripts/webkitpy/common/net/resultsjsonparser.py: * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py: * Scripts/webkitpy/layout_tests/controllers/manager.py: * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: * Scripts/webkitpy/layout_tests/controllers/worker.py: * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py: * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py: * Scripts/webkitpy/layout_tests/layout_package/result_summary.py: Removed. * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Removed. * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: Removed. * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Removed. * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Removed. * Scripts/webkitpy/layout_tests/layout_package/test_input.py: Removed. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: * Scripts/webkitpy/layout_tests/layout_package/test_results.py: Removed. * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py: Removed. * Scripts/webkitpy/layout_tests/models: Added. * Scripts/webkitpy/layout_tests/models/__init__.py: Added. * Scripts/webkitpy/layout_tests/models/result_summary.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/result_summary.py. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py. * Scripts/webkitpy/layout_tests/models/test_failures.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures.py. * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py. * Scripts/webkitpy/layout_tests/models/test_input.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_input.py. * Scripts/webkitpy/layout_tests/models/test_results.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results.py. * Scripts/webkitpy/layout_tests/models/test_results_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py. * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/views/printing.py: * Scripts/webkitpy/layout_tests/views/printing_unittest.py: * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: * Scripts/webkitpy/style_references.py: * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py: * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: * Scripts/webkitpy/tool/commands/queues_unittest.py: * Scripts/webkitpy/tool/commands/rebaseline.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
gyuyoung.kim@samsung.com authored
[EFL] Add Fullscreen API feature https://bugs.webkit.org/show_bug.cgi?id=63975 This is just to add disabled ENABLE_FULLSCREEN_API to OptionEFl.cmake. ENABLE_FULLSCREEN_API will be enabled after finishing missing implementations. Reviewed by Adam Barth. * Source/cmake/OptionsEfl.cmake: Add disabled ENABLE_FULLSCREEN_API feature. * Source/cmakeconfig.h.cmake: ditto. 2011-07-06 Gyuyoung Kim <gyuyoung.kim@samsung.com> [EFL] Add Fullscreen API feature https://bugs.webkit.org/show_bug.cgi?id=63975 Add needed files for enabling ENABLE_FULLSCREEN_API feature. Reviewed by Adam Barth. * CMakeLists.txt: Add RenderFullScreen.cpp, fullscreen.css git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eae@chromium.org authored
Switch absoluteRects to to new layout types https://bugs.webkit.org/show_bug.cgi?id=64035 Reviewed by Eric Seidel. Move absoluteRects over to new layout unit abstraction. Add flooredLayoutPoint, mapped to flooredIntPoint. No new tests, no functionality changes. * rendering/LayoutTypes.h: (WebCore::flooredLayoutPoint): * rendering/RenderBlock.cpp: (WebCore::RenderBlock::absoluteRects): * rendering/RenderBlock.h: * rendering/RenderBox.cpp: (WebCore::RenderBox::absoluteRects): * rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): * rendering/RenderInline.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::absoluteBoundingBoxRect): * rendering/RenderObject.h: (WebCore::RenderObject::absoluteRects): * rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects): * rendering/RenderText.h: * rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects): * rendering/RenderView.h: * rendering/svg/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::absoluteRects): * rendering/svg/RenderSVGBlock.h: * rendering/svg/RenderSVGModelObject.cpp: (WebCore::RenderSVGModelObject::absoluteRects): * rendering/svg/RenderSVGModelObject.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@90530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-