1. 26 Jan, 2009 5 commits
    • hyatt@apple.com's avatar
      2009-01-26 David Hyatt <hyatt@apple.com> · d0301a5e
      hyatt@apple.com authored
              Drop support for display:compact.
      
              (1) display:compact is no longer part of CSS2.1.
              (2) Shipping Safari has completely broken compact support with severely broken rendering
              (all of the compact text just piles on top of the text in the inserted block and on top of itself as well).
              (3) This has been broken in WebKit for years (ever since blocks converted to painting lines directly) without
              anyone even noticing.
      
              Reviewed by Eric Seidel
      
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::placeBoxesHorizontally):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::handleSpecialChild):
              (WebCore::RenderBlock::handleRunInChild):
              (WebCore::RenderBlock::layoutBlockChildren):
              (WebCore::RenderBlock::paint):
              (WebCore::RenderBlock::paintObject):
              (WebCore::RenderBlock::nodeAtPoint):
              (WebCore::RenderBlock::positionForCoordinates):
              (WebCore::shouldCheckLines):
              (WebCore::getHeightForLineCount):
              (WebCore::RenderBlock::renderName):
              * rendering/RenderBlock.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::sizesToIntrinsicWidth):
              * rendering/RenderBox.h:
              (WebCore::RenderBox::width):
              (WebCore::RenderBox::height):
              (WebCore::RenderBox::size):
              (WebCore::RenderBox::frameRect):
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::paintLines):
              (WebCore::RenderFlow::hitTestLines):
              (WebCore::RenderFlow::absoluteClippedOverflowRect):
              (WebCore::RenderFlow::linesBoundingBox):
              * rendering/RenderObject.h:
              (WebCore::RenderObject::isInline):
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::computeHorizontalPositionsForLine):
              (WebCore::RenderBlock::layoutInlineChildren):
              * rendering/bidi.h:
              (WebCore::BidiRun::BidiRun):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0301a5e
    • darin@chromium.org's avatar
      2009-01-26 Adam Langley <agl@google.com> · d9112996
      darin@chromium.org authored
              Reviewed by Nikolas Zimmermann.
      
              gtk2drawing: fix compiler warnings
      
              g_object_set_data expects a gpointer as the last argument. Cast the
                TRUE/FALSE values to avoid a warning.
              gtk_tree_view_column_new doesn't return a GtkWidget.
      
              * platform/gtk/gtk2drawing.c:
              (setup_widget_prototype):
              (moz_gtk_get_combo_box_inner_button):
              (moz_gtk_get_combo_box_button_inner_widgets):
              (ensure_combo_box_widgets):
              (moz_gtk_get_combo_box_entry_inner_widgets):
              (moz_gtk_get_combo_box_entry_arrow):
              (ensure_combo_box_entry_widgets):
              (ensure_toolbar_widget):
              (ensure_menu_bar_item_widget):
              (ensure_menu_popup_widget):
              (ensure_menu_item_widget):
              (ensure_image_menu_item_widget):
              (ensure_menu_separator_widget):
              (ensure_check_menu_item_widget):
              (ensure_tree_header_cell_widget):
              (moz_gtk_entry_paint):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9112996
    • hyatt@apple.com's avatar
      2009-01-26 David Hyatt <hyatt@apple.com> · 831beecd
      hyatt@apple.com authored
              Change display:run-in handling so that we no longer reuse RenderBlock as though it is an inline flow.
              Instead we create a new RenderInline, move the RenderBlock's children underneath it, and then set the
              inline as the new element's renderer.
      
              Reviewed by Dan Bernstein
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::handleRunInChild):
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::renderName):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      831beecd
    • dglazkov@chromium.org's avatar
      2009-01-26 Dimitri Glazkov <dglazkov@chromium.org> · bda75dc2
      dglazkov@chromium.org authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=23480
              Add missing method stubs to BackForwardListChromium.
      
              * history/BackForwardListChromium.cpp:
              (WebCore::BackForwardList::backItem):
              (WebCore::BackForwardList::forwardItem):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bda75dc2
    • darin@apple.com's avatar
      2009-01-25 Darin Adler <darin@apple.com> · 9b977f45
      darin@apple.com authored
              Try to fix Tiger buildbot.
      
              * WebCore.xcodeproj/project.pbxproj: Turn off cast-qual for WebDashboardRegion.m.
              * page/mac/WebDashboardRegion.m:
              (typeName): Added.
              (-[WebDashboardRegion description]): Use typeName.
              (-[WebDashboardRegion isEqual:]): Added comment.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b977f45
  2. 25 Jan, 2009 13 commits
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · 3db1ca14
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=23535
              Strengthen debug checks in KURL
      
              Covered (and prompted) by existing tests.
      
              * platform/KURL.cpp:
              (WebCore::checkEncodedString): Check that the first character of the URL is an allowed
              first scheme character, not just that it isn't a slash.
              (WebCore::KURL::KURL): Assert that parsing didn't affect the string (which must be the case
              because of parsing being idempotent).
      
              * page/SecurityOrigin.cpp:
              (WebCore::SecurityOrigin::create): Added a check for the URL being valid - if it is not, an
              empty security origin is created.
              (WebCore::SecurityOrigin::createFromString): Parse the string as URL, do not just convert
              it - it is not guaranteed to be properly encoded.
      
              * dom/Document.cpp: (WebCore::Document::updateBaseURL): As documentURI is an arbitrary
              string, it needs to be parsed into an URL, not just converted into one.
      
              * html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::createPattern):
              Create the security origin with createFromString() instead of create(). I do not know where
              the string comes from and whether it might not be properly encoded, but this change can't
              hurt, and makes the code slightly more clear.
      
              * xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::accessControlCheck): Create the security
              origin with createFromString() instead of create(). The string comes from an HTTP response
              header, so it may not be a properly encoded URL.
      
              * loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): Do not try to request using
              invalid URLs.
      
              * page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Updated to call
              SecurityOrigin::createFromString() (no change in behavior).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3db1ca14
    • mrowe@apple.com's avatar
      Improve the consistency of settings in our .xcconfig files. · 08809b99
      mrowe@apple.com authored
      Rubber-stamped by Dan Bernstein.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08809b99
    • hyatt@apple.com's avatar
      WebCore: · 8b2cd1fe
      hyatt@apple.com authored
      2009-01-25  David Hyatt  <hyatt@apple.com>
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=23524, lots of missing content in table sections.
      
              The new table code created a bug involving  markAllDescendantsWithFloatsForLayout, namely that it could
              end up marking ancestors of a block as needing layout when that block was still in the process of
              doing a layout.
      
              The fix is to add a parameter to markAllDescendantsWithFloatsForLayout that says whether or not
              we are "mid-layout."  If this flag is set, then the method will make sure to do only local dirtying
              of objects to avoid accidentally marking a clean ancestor as needing layout again.
      
              Ultimately the second parameter to setNeedsLayout and setChildNeedsLayout should just be removed,
              with a check of whether or not we are mid-layout being done by those methods instead.
      
              Reviewed by Oliver Hunt
      
              Added fast/repaint/dynamic-table-vertical-alignment-change.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::collapseMargins):
              (WebCore::RenderBlock::clearFloatsIfNeeded):
              (WebCore::RenderBlock::layoutBlockChildren):
              (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
              * rendering/RenderBlock.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::removeFromObjectLists):
              * rendering/RenderObject.h:
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::layoutRows):
      
      LayoutTests:
      
      2009-01-25  David Hyatt  <hyatt@apple.com>
      
              Add layout test for https://bugs.webkit.org/show_bug.cgi?id=23524.
      
              Reviewed by Oliver Hunt
      
              * fast/repaint/dynamic-table-vertical-alignment-change.html: Added.
              * platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.checksum: Added.
              * platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.png: Added.
              * platform/mac/fast/repaint/dynamic-table-vertical-alignment-change-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b2cd1fe
    • darin@apple.com's avatar
      JavaScriptCore: · 9f6b66c7
      darin@apple.com authored
      2009-01-25  Darin Adler  <darin@apple.com>
      
              Reviewed by Mark Rowe.
      
              Bug 23352: Turn on more compiler warnings in the Mac build
              https://bugs.webkit.org/show_bug.cgi?id=23352
      
              Turn on the following warnings:
      
                  -Wcast-qual
                  -Wextra-tokens
                  -Wformat=2
                  -Winit-self
                  -Wmissing-noreturn
                  -Wpacked
                  -Wrendundant-decls
      
              * Configurations/Base.xcconfig: Added the new warnings. Switched to -Wextra instead of
              -W for clarity since we don't have to support the older versions of gcc that require the
              old -W syntax. Since we now use -Wformat=2, removed -Wformat-security. Also removed
              -Wno-format-y2k since we can have that one on now.
      
      WebCore:
      
      2009-01-25  Darin Adler  <darin@apple.com>
      
              Reviewed by Mark Rowe.
      
              Bug 23352: Turn on more compiler warnings in the Mac build
              https://bugs.webkit.org/show_bug.cgi?id=23352
      
              Turn on the following warnings:
      
                  -Wcast-qual
                  -Wextra-tokens
                  -Wformat=2
                  -Winit-self
                  -Wmissing-noreturn
                  -Wpacked
                  -Wrendundant-decls
      
              * Configurations/Base.xcconfig: Added the new warnings. Switched to -Wextra instead of
              -W for clarity since we don't have to support the older versions of gcc that require the
              old -W syntax. Since we now use -Wformat=2, removed -Wformat-security. Also removed
              -Wno-format-y2k since we can have that one on now.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f6b66c7
    • mitz@apple.com's avatar
      WebCore: · 2f1fee03
      mitz@apple.com authored
              Reviewed by Oliver Hunt.
      
              - fix <rdar://problem/6525618> REGRESSION (r39566): NewsFire crashes in
                string hashing code when opening a Digg RSS article
      
              Test: fast/loader/null-request-after-willSendRequest.html
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::loadItem): Null-check the request returned from
              the client's willSendRequest method.
      
      LayoutTests:
      
              Reviewed by Oliver Hunt.
      
              - test for <rdar://problem/6525618> REGRESSION (r39566): NewsFire crashes in
                string hashing code when opening a Digg RSS article
      
              * fast/loader/null-request-after-willSendRequest-expected.txt: Added.
              * fast/loader/null-request-after-willSendRequest.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f1fee03
    • hyatt@apple.com's avatar
      2009-01-25 David Hyatt <hyatt@apple.com> · e007fb25
      hyatt@apple.com authored
              Fix for <rdar://problem/6525392> REGRESSION (r40180): Scroll wheel events over text scroll the page
              instead of the ancestor overflow (23525)
              
              Make sure that we always call scroll() on the nearest enclosing RenderBox.  No test case is possible
              here, since wheel scrolling is currently untestable (the offset varies from machine to machine).
      
              Reviewed by Dan Bernstein
      
              * page/EventHandler.cpp:
              (WebCore::scrollAndAcceptEvent):
              (WebCore::EventHandler::scrollOverflow):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::enclosingBox):
              * rendering/RenderObject.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e007fb25
    • darin@apple.com's avatar
      2009-01-25 Darin Adler <darin@apple.com> · 38d96eff
      darin@apple.com authored
              Reviewed by Dan Bernstein.
      
              Bug 23538: REGRESSION (r39969): Garbage text instead of blank content rendered when plug-ins are disabled
              https://bugs.webkit.org/show_bug.cgi?id=23538
              rdar://problem/6523719
      
              I'm not sure how to make a regression test for this, since it depends on plug-ins being disabled.
      
              The main problem here is that when plug-ins were disabled, the code ignored the classId attribute and
              the <embed> element entirely. That resulted in a page treating a Flash document as plain HTML rather
              than doing fallback.
      
              * rendering/RenderPartObject.cpp:
              (WebCore::createClassIdToTypeMap): Added. Broke this out into a separate function so we could get rid of an
              inelegant if statement.
              (WebCore::activeXType): Added. To avoid repeating the MIME type for ActiveX and possibly having a typo.
              (WebCore::havePlugin): Added. Helper function to make sure we don't forget the null check.
              (WebCore::serviceTypeForClassId): Give this function a return value since that's a more natural way to
              return a string than an "out" parameter.  Fixed the logic to only prefer the ActiveX type over the
              type guessed from the classId when there actually is an ActiveX plug-in to use. The old function assumed
              there was one, which I presume right for Chrome on Windows when plug-ins are enabled, but wrong in many
              other cases, and wrong all the time for all clients on Mac. We don't want to assume either way. Use the
              new havePlugin function so we handle the case where pluginData is 0.
              (WebCore::shouldUseEmbedDescendant): Renamed. Simplified the comment. Changed to use serviceTypeForClassId
              instead of the old version that used an out parameter. Always use the <embed> if there isn't a plug-in
              that knows how to handle <object> elements.
              (WebCore::RenderPartObject::updateWidget): Removed null checks of pluginData. The two functions that
              use this data still need to be called; they still do something even if no plug-ins are present. And
              they have now been corrected to handle 0 properly.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38d96eff
    • darin@apple.com's avatar
      2009-01-25 Darin Adler <darin@apple.com> · 4ce38c5a
      darin@apple.com authored
              * rendering/RenderMenuList.cpp: Fix build by adding back needed include.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ce38c5a
    • darin@apple.com's avatar
      JavaScriptCore: · ba165bd3
      darin@apple.com authored
      2009-01-25  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              Bug 23352: Turn on more compiler warnings in the Mac build
              https://bugs.webkit.org/show_bug.cgi?id=23352
      
              Fourth patch: Deal with the last few stray warnings.
      
              * parser/Parser.cpp: Only declare jscyyparse if it's not already declared.
              This makes both separate compilation and all-in-one compilation work with the
              -Wredundant-decls warning.
      
      WebCore:
      
      2009-01-25  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              Bug 23352: Turn on more compiler warnings in the Mac build
              https://bugs.webkit.org/show_bug.cgi?id=23352
      
              Fourth patch: Deal with the last few stray warnings.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::firstLineBlock): Handle the const_cast a little better.
              Also make the local variable be a RenderBlock so the cast is closer to the code
              that guarantees it's correct.
      
              * rendering/SVGRenderTreeAsText.cpp:
              (WebCore::writeStyle): Put the enum into a local variable that's a built-in
              type before using it with TextStream, so we don't get a warning due to -Wsign-promo.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba165bd3
    • darin@apple.com's avatar
      WebCore: · 36744d67
      darin@apple.com authored
      2009-01-25  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              Bug 23522: use checked casts for render tree
              https://bugs.webkit.org/show_bug.cgi?id=23522
      
              Step one: RenderText.
      
              Also change set of RenderFlow* to be a ListHashSet as the comment in the
              header indicated.
      
              * dom/CharacterData.cpp:
              (WebCore::CharacterData::setData): Use toRenderText.
              (WebCore::CharacterData::appendData): Ditto.
              (WebCore::CharacterData::insertData): Ditto.
              (WebCore::CharacterData::deleteData): Ditto.
              (WebCore::CharacterData::replaceData): Ditto.
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::getUpperLeftCorner): Ditto.
              (WebCore::ContainerNode::getLowerRightCorner): Ditto.
              * dom/Position.cpp:
              (WebCore::nextRenderedEditable): Ditto.
              (WebCore::previousRenderedEditable): Ditto.
              (WebCore::Position::renderedOffset): Ditto. Also use function members
              instead of data members of InlineTextBox.
              (WebCore::Position::upstream): Ditto.
              (WebCore::Position::downstream): Ditto.
              (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): Ditto.
              (WebCore::Position::inRenderedText): Ditto.
              (WebCore::Position::isRenderedCharacter): Ditto.
              (WebCore::searchAheadForBetterMatch): Ditto.
              (WebCore::Position::getInlineBoxAndOffset): Ditto.
      
              * dom/Range.cpp: Added include of VisiblePosition.h now that it's no longer
              included in RenderObject.h.
      
              * dom/Text.cpp:
              (WebCore::Text::splitText): Use toRenderText.
              (WebCore::Text::recalcStyle): Ditto.
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::deleteInsignificantText): Ditto.
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::debugRenderer): Ditto.
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::handleTextNode): Ditto.
              (WebCore::TextIterator::handleTextBox): Ditto.
              (WebCore::TextIterator::emitText): Ditto.
              (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto.
      
              * editing/VisiblePosition.cpp: Added include of FloatQuad.h now that it's
              no longer included in RenderObject.h.
              * inspector/InspectorController.cpp: Ditto.
              * page/Frame.cpp: Ditto.
              * rendering/RenderBox.cpp: Ditto.
              * rendering/RenderInline.cpp: Ditto.
              * rendering/RenderPath.cpp: Ditto.
              * rendering/RenderSVGContainer.cpp: Ditto.
              * rendering/RenderSVGImage.cpp: Ditto.
              * rendering/RenderSVGInlineText.cpp: Ditto.
              * rendering/RenderSVGTSpan.cpp: Ditto.
              * rendering/RenderSVGText.cpp: Ditto.
              * rendering/RenderSVGTextPath.cpp: Ditto.
              * rendering/RenderTableCell.cpp: Ditto.
              * rendering/RenderView.cpp: Ditto.
      
              * editing/visible_units.cpp:
              (WebCore::startPositionForLine): Use function members instead of data
              members of InlineTextBox.
              (WebCore::endPositionForLine): Ditto.
              (WebCore::startOfParagraph): Use toRenderText.
              (WebCore::endOfParagraph): Ditto.
      
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Use toRenderText.
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::placeBoxesHorizontally): Ditto.
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::deleteLine): Ditto.
              (WebCore::InlineTextBox::extractLine): Ditto.
              (WebCore::InlineTextBox::attachLine): Ditto.
              (WebCore::InlineTextBox::placeEllipsisBox): Ditto.
              (WebCore::InlineTextBox::paintDecoration): Ditto.
              (WebCore::InlineTextBox::paintCompositionUnderline): Ditto.
              (WebCore::InlineTextBox::offsetForPosition): Ditto.
              (WebCore::InlineTextBox::positionForOffset): Ditto.
      
              * rendering/InlineTextBox.h: Made most members private. Use toRenderText.
      
              * rendering/RenderArena.cpp:
              (WebCore::RenderArena::allocate): Use static_cast instead of C-style cast.
              (WebCore::RenderArena::free): Ditto.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::addContinuationWithOutline): Use ListHashSet<RenderFlow*>
              instead of RenderFlowSequencedSet.
              (WebCore::RenderBlock::paintContinuationOutlines): Ditto.
              (WebCore::stripTrailingSpace): Ditto.
              (WebCore::RenderBlock::calcInlinePrefWidths): Ditto.
              (WebCore::RenderBlock::updateFirstLetter): Ditto.
      
              * rendering/RenderContainer.cpp:
              (WebCore::RenderContainer::addChild): Use toRenderText.
      
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::dirtyLinesFromChangedChild): Use ListHashSet<RenderFlow*>
              instead of RenderFlowSequencedSet.
              (WebCore::RenderFlow::paintLines): Ditto.
      
              * rendering/RenderMenuList.cpp: Removed some unneeded includes.
      
              * rendering/RenderMenuList.h: Added now-needed forward declaration of RenderText.
              Made more members private.
      
              * rendering/RenderObject.cpp: Updated includes.
              (WebCore::RenderObject::isEditable): Use toRenderText.
              (WebCore::RenderObject::positionForPoint): Made non-inline so we wouldn't have to
              include VisiblePosition.h in the header just for this.
      
              * rendering/RenderObject.h: Removed unneeded includes and forward declarations.
              Changed special vertical position values to be constants rather than an enum.
              Eliminated RenderFlowSequencedSet, and changed clients to use ListHashSet<RenderFlow*>.
      
              * rendering/RenderText.cpp:
              (WebCore::RenderText::findNextInlineTextBox): Use function members instead of
              data members of InlineTextBox.
              (WebCore::RenderText::positionForCoordinates): Ditto.
              (WebCore::isInlineFlowOrEmptyText): Use toRenderText.
              (WebCore::RenderText::previousCharacter): Use function members instead of
              data members of InlineTextBox.
              (WebCore::RenderText::position): Ditto.
              (WebCore::RenderText::caretMinOffset): Ditto.
              (WebCore::RenderText::caretMaxOffset): Ditto.
              (WebCore::RenderText::caretMaxRenderedOffset): Ditto.
      
              * rendering/RenderText.h: Added definition of toRenderText.
      
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::textWithHardLineBreaks): Use toRenderText.
              * rendering/RenderTreeAsText.cpp:
              (WebCore::operator<<): Use toRenderText and toRenderBox.
              (WebCore::writeTextRun): Ditto.
              (WebCore::write): Ditto.
      
              * rendering/bidi.cpp:
              (WebCore::InlineIterator::increment): Use toRenderText.
              (WebCore::InlineIterator::current): Ditto.
              (WebCore::checkMidpoints): Ditto.
              (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto.
              (WebCore::RenderBlock::layoutInlineChildren): Ditto.
              (WebCore::RenderBlock::determineStartPosition): Ditto.
              (WebCore::shouldSkipWhitespaceAfterStartObject): Ditto.
              (WebCore::RenderBlock::findNextLineBreak): Ditto.
      
      WebKit/mac:
      
      2009-01-25  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              Bug 23522: use checked casts for render tree
              https://bugs.webkit.org/show_bug.cgi?id=23522
      
              Step one: RenderText.
      
              * WebView/WebRenderNode.mm:
              (copyRenderNode): Use toRenderText.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36744d67
    • hausmann@webkit.org's avatar
      2009-01-25 Thiago Macieira <thiago.macieira@nokia.com> · 6d1ffbe3
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Fix gcc compiler warning (deprecated conversion from constant string to char*)
      
              "" cannot be stored in a char*
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d1ffbe3
    • ap@webkit.org's avatar
      Remove a slightly misleading comment from ChangeLog - the issue is related to... · eaa1c244
      ap@webkit.org authored
      Remove a slightly misleading comment from ChangeLog - the issue is related to bug 23500, but not the same.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eaa1c244
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · e7e20111
      ap@webkit.org authored
              <rdar://problem/5954398> REGRESSION: 1.1% PLT regression from 33577 and 33578 (encoding fixes)
      
      WebCore:
              Changed single argument KURL constructors back to always expect an already encoded string,
              eliminating extra conversions.
      
              This is a rather unstable situation, as it is often unclear whether a given string is safe
              to convert to KURL without resolving. I think that going forward, the solution is to try to
              keep encoded URLs as KURL instances, and not as strings.
      
              * platform/KURL.h: Updated comments.
      
              * platform/KURL.cpp:
              (WebCore::KURL::KURL): In debug builds, verify that the passed string is ASCII-only. The
              intention is to verify that it is already parsed and encoded by KURL or equivalent code, but
              since encoding is scheme-dependent, such a verification would be quite complicated.
              Don't encode the string as UTF-8, as it supposed to be ASCII-only.
              Removed a hack that made strings beginning with "/" turn into "file:" URLs. I didn't find
              any reason for it to exist, but I saw several cases where this code path was taken
              inadvertently (see examples in LayoutTests/ChangeLog).
              (WebCore::KURL::setProtocol): Using a user-provided string without validation or encoding
              is clearly wrong here (e.g., the "protocol" can be set to a full URL, effectively replacing
              the old one), and an already encoded string is expected by parse().
              In debug builds, non-ASCII input will make an assertion in parse() fail. Added a FIXME.
              (WebCore::KURL::setHost): Ditto.
              (WebCore::KURL::setPort): Ditto.
              (WebCore::KURL::setHostAndPort): Ditto.
              (WebCore::KURL::setUser): Ditto.
              (WebCore::KURL::setPass): Ditto.
              (WebCore::KURL::setRef): Ditto.
              (WebCore::KURL::setQuery): Ditto.
              (WebCore::KURL::setPath): Ditto.  Note that problems described in bug 23500 mask some of
              the problems in release builds currently, as the incorrectly parsed URL is ignored. 
              (WebCore::KURL::parse): Verify that the passed string is already encoded.
      
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::parseMappedAttribute):
              (WebCore::HTMLLinkElement::process):
              * html/HTMLLinkElement.h:
              Changed to avoid using invalid URLs (this was causing problems on DNS prefetch tests, see
              LayoutTests/ChangeLog).
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::init): Create an empty KURL without indirection for a small speedup.
              (WebCore::FrameLoader::requestFrame): Resolve and encode javascript URLs properly, now that
              String to KURL conversion requires the string to be already encoded.
      
              * page/DOMWindow.cpp: (WebCore::DOMWindow::postMessage): Resolve and encode the origin.
              HTML5 seems a little unclear on how this should work (it talks about "either parsing it as
              a URL, or resolving it", and then somehow compares unaltered targetOrigin string to a
              security origin object), so I just made the code as close to what we already had as possible.
      
      LayoutTests:
              * http/tests/misc/dns-prefetch-control-expected.txt:
              * http/tests/misc/dns-prefetch-control.html:
              Google documentation for DNS Prefetch makes use of net-path relative URLs (//server-name),
              explaining that scheme is not necessary. This is of course true, but this test uses data:
              subframes, and data: is a non-hierachical scheme, so resolving such URLs fails, resulting
              in a KURL object that is not valid. WebKit used to ignore this, and tried to create a URL
              from this string again, now with a single argument KURL constructor, which resulted in a
              valid file: URL, which was successfully used! Both issues have been corrected in WebCore,
              so I had to change the test to no longer use relative net-path URLs.
      
              * http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
              * http/tests/security/postMessage/invalid-origin-throws-exception.html:
              URLs that start with "/" are no longer converted to "file:" ones, so the results now
              match Firefox.
      
              * http/tests/uri/resolve-encoding-relative-expected.txt: Added.
              * http/tests/uri/resolve-encoding-relative.html: Added.
              Added a test to cover some cases of relative URL resolving that were not covered before.
              Expected results are taken from Firefox 3, and WebKit doesn't match in how fragments are
              encoded (we use document encoding, while Firefox uses UTF-8). Since fragments are not
              sent in HTTP requests, this is not too dangerous, but the Firefox behavior looks more
              consistent.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7e20111
  3. 24 Jan, 2009 4 commits
    • darin@apple.com's avatar
      2009-01-24 Darin Adler <darin@apple.com> · b879470c
      darin@apple.com authored
              Try to fix Qt build.
      
              * WebCore.pro: Added JSTextCustom.cpp.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b879470c
    • cmarrin@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=23467 · 3ec14ff9
      cmarrin@apple.com authored
              Change styleAvailable functionality to be a linked list
              rather than scanning every CompositeAnimation for 
              Animations that are waiting for styleAvailable. This has
              potential for large performance improvement in cases where
              there are many animations firing at once. But it will also
              help in my next fix, which is to synchronize software and
              accelerated animations.
      
              I also changed slightly when the beginAnimationUpdate and
              endAnimationUpdate calls are made. But this has no real
              effect on performance or behavior.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ec14ff9
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · 97804f24
      ap@webkit.org authored
              <rdar://problem/6368059> REGRESSION: URL encoding problems on http://www.cineman.ch
      
              Test: http/tests/xmlhttprequest/encode-request-url-2.html
      
              * platform/KURL.cpp:
              (WebCore::appendASCII): Added a helper function.
              (WebCore::KURL::KURL): Explicitly encode the URL to call two-argument parse() with better
              specified behavior.
              (WebCore::KURL::init): Ditto. This avoids trying to round-trip an URL encoded into a byte
              stream, but not yet transformed to ASCII-only using percent escapes. Since different parts
              of the byte stream can use different encodings, round-tripping is not possible.
              (WebCore::KURL::parse): Reverted an earlier change that made the single-argument version of
              this function convert the string to utf-8. I think that on the remanining code paths, it is
              correct to assume that the string is all ASCII, but I'm not yet confident enough to drop a
              FIXME warning.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97804f24
    • jmalonzo@webkit.org's avatar
      2009-01-24 Jan Michael Alonzo <jmalonzo@webkit.org> · 04e97901
      jmalonzo@webkit.org authored
              Gtk build fix after r40170
      
              * GNUmakefile.am: Removed editing/RemoveNodeAttributeCommand.cpp
              and editing/RemoveNodeAttributeCommand.h
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04e97901
  4. 23 Jan, 2009 18 commits
    • treat@webkit.org's avatar
      Fix the Qt build after r40205. · 0243b430
      treat@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0243b430
    • beidson@apple.com's avatar
      2009-01-23 Brady Eidson <beidson@apple.com> · 9c206a9b
      beidson@apple.com authored
              Reviewed by Darin Adler
      
              In CachedPage, break off per-Frame pieces of data into a CachedFrame object.
      
              * GNUmakefile.am:
              * WebCore.base.exp:
              * WebCore.pro:
              * WebCore.scons:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
      
              * history/CachedFrame.cpp: Added.
              (WebCore::cachedFrameCounter):
              (WebCore::CachedFrame::CachedFrame):
              (WebCore::CachedFrame::~CachedFrame):
              (WebCore::CachedFrame::restore):
              (WebCore::CachedFrame::clear):
              (WebCore::CachedFrame::setCachedFramePlatformData):
              (WebCore::CachedFrame::cachedFramePlatformData):
              * history/CachedFrame.h: Added.
              (WebCore::CachedFrame::document):
              (WebCore::CachedFrame::documentLoader):
              (WebCore::CachedFrame::view):
              (WebCore::CachedFrame::mousePressNode):
              (WebCore::CachedFrame::url):
              (WebCore::CachedFrame::domWindow):
      
              * history/CachedPage.cpp:
              (WebCore::CachedPage::CachedPage):
              (WebCore::CachedPage::restore):
              (WebCore::CachedPage::clear):
              (WebCore::CachedPage::setCachedFramePlatformData):
              (WebCore::CachedPage::cachedFramePlatformData):
              * history/CachedPage.h:
              (WebCore::CachedPage::document):
              (WebCore::CachedPage::documentLoader):
              (WebCore::CachedPage::view):
              (WebCore::CachedPage::mousePressNode):
              (WebCore::CachedPage::url):
              (WebCore::CachedPage::domWindow):
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::cachePageForHistoryItem): Setting the DocumentLoader independently of
                creating a CachedPage was a historical relic.  Take the opportunity to clean that up.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c206a9b
    • hyatt@apple.com's avatar
      2009-01-23 David Hyatt <hyatt@apple.com> · fee9b3e7
      hyatt@apple.com authored
              Add ASSERTs to catch anyone trying to obtain the width/height of an inline flow.  Fix up all the places
              that triggered the ASSERT (since all of these places are effectively regressions from my landing that
              devirtualized width()/height()).
      
              Reviewed by Adele
      
              * dom/Position.cpp:
              (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
              * editing/DeleteButtonController.cpp:
              (WebCore::isDeletableElement):
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::isKeyboardFocusable):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::clientWidth):
              (WebCore::RenderBox::clientHeight):
              (WebCore::RenderBox::scrollWidth):
              (WebCore::RenderBox::scrollHeight):
              (WebCore::RenderBox::absoluteOutlineBounds):
              * rendering/RenderBox.h:
              (WebCore::RenderBox::width):
              (WebCore::RenderBox::height):
              (WebCore::RenderBox::size):
              (WebCore::RenderBox::frameRect):
              (WebCore::RenderBox::borderBoundingBox):
              * rendering/RenderFlow.h:
              (WebCore::RenderFlow::borderBoundingBox):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::updateLayerPosition):
              * rendering/RenderScrollbarPart.cpp:
              (WebCore::RenderScrollbarPart::styleWillChange):
              * rendering/RenderScrollbarPart.h:
              * wml/WMLAElement.cpp:
              (WebCore::WMLAElement::isKeyboardFocusable):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fee9b3e7
    • darin@apple.com's avatar
      2009-01-23 Darin Adler <darin@apple.com> · dc74ae0c
      darin@apple.com authored
              Reviewed by Anders Carlsson.
      
              Bug 23352: Turn on more compiler warnings in the Mac build
              https://bugs.webkit.org/show_bug.cgi?id=23352
      
              Second patch: Slightly less simple cases of various warnings.
      
              * bridge/jni/jni_runtime.h:
              (JSC::Bindings::JavaString::_commonInit): Use reinterpret_cast here and avoid casting
              away const.
      
              * dom/XMLTokenizerLibxml2.cpp:
              (WebCore::PendingCallbacks::appendStartElementNSCallback): Use static_cast instead of
              reinterpret_cast; this is casting the result of malloc, and the idiom is to use
              static_cast, which works because we're casting from void*.
              (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): Use const_cast instead
              C-style casts.
      
              * xml/XSLTUnicodeSort.cpp:
              (inlineXSLTTransformError): Tweak soft linking of xsltTransformError to use a macro
              instead of redefining the function.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc74ae0c
    • darin@apple.com's avatar
      2009-01-23 Darin Adler <darin@apple.com> · 54c04c98
      darin@apple.com authored
              Reviewed by Anders Carlsson.
      
              Bug 23475: fast/text/find-backwards.html fails with ICU disabled SearchBuffer
              https://bugs.webkit.org/show_bug.cgi?id=23475
      
              * editing/TextIterator.cpp:
              (WebCore::SearchBuffer::search): Set the character start flag to false to
              ensure we won't ever return the same result twice. There are other ways we
              could accomplish this, mentioned in the comment, but this one was the smallest
              and cleanest I could think of.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54c04c98
    • darin@apple.com's avatar
      2009-01-23 Darin Adler <darin@apple.com> · 322543e0
      darin@apple.com authored
              Reviewed by Anders Carlsson.
      
              Bug 23510: REGRESSION (r40171): CDATASection objects not getting proper JavaScript wrappers
              https://bugs.webkit.org/show_bug.cgi?id=23510
      
              That patch fixed the optimization that's supposed to give a faster path for
              allocating the wrappers for DOM Text objects. But CDATASection is the one
              subclass of Text objects.
      
              * GNUmakefile.am: Added JSCDATASectionCustom.cpp.
              * WebCore.scons: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * WebCoreSources.bkl: Ditto.
      
              * bindings/js/JSCDATASectionCustom.cpp: Copied from bindings/js/JSTextCustom.cpp.
              (WebCore::toJSNewlyCreated): Changed to do CDATASection, not Text.
      
              * bindings/scripts/CodeGeneratorJS.pm: Added another toJSNewlyCreated function
              for CDATASection. We don't want to have to check when creating a wrapper for a
              Text object whether it's a CDATASection object or not, so we need to do this overload
              at compile time.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      322543e0
    • zimmermann@webkit.org's avatar
      Reviewed by Eric Seidel. · aca557cc
      zimmermann@webkit.org authored
      Add a base class for WML form control elements: WMLFormControlElement (as it's designed in HTML as well).
      WMLFormControlElement inherits from WMLElement and FormControlElement (just like the HTMLFormControlElement equivalent).
      
      WMLInputElement / WMLOptionElement / WMLOptGroupElement are supposed to inherit from the new WMLFormControlElement class.
      Now WMLInputElement & WMLOptGroupElement only inherit from WMLElement and FormControlElement, but WMLOptionElement inherits
      from WMLEventHandlingElement (which in turn inherits from WMLElement) and FormControlElement. In order to introduce a shared
      base class, WMLEventHandlingElement is no longer allowed to inherit from WMLElement directly. Instead it should turn into
      another base class, just like FormControlElement.
      
      Add a base class for form control elements 'with state': FormControlElementWithState, serving as base class for
      HTMLFormControlElementWithState and WMLFormControlElementWithState. -> Make Document operate on FormControlElementWithState
      objects instead of HTMLFormControlElementWithState objects, to support save/restore control state for non HTMLFormControlElements.
      
      Rename isGenericFormElement() to isFormControlElement(), and move it to Element.h
      Add new virtual function isFormControlElementWithState() to Element.h.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aca557cc
    • cfleizach@apple.com's avatar
      Bug 23509: Crash at -[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:] · bfdeb0be
      cfleizach@apple.com authored
      Move null checking into makeRange
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bfdeb0be
    • treat@webkit.org's avatar
      ed609dc3
    • treat@webkit.org's avatar
      8b4d2ebb
    • treat@webkit.org's avatar
      Fix the Qt build after r40168. · c5ae4fa6
      treat@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c5ae4fa6
    • beidson@apple.com's avatar
      WebCore: · 94faeb95
      beidson@apple.com authored
      2009-01-23  Brady Eidson  <beidson@apple.com>
      
              Rubberstamped by Darin Adler
      
              Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
      
              * GNUmakefile.am:
              * WebCore.base.exp:
              * WebCore.order:
              * WebCore.xcodeproj/project.pbxproj:
      
              * history/CachedFramePlatformData.h: Copied from WebCore/history/CachedPagePlatformData.h.
              (WebCore::CachedFramePlatformData::~CachedFramePlatformData):
              * history/CachedPagePlatformData.h: Removed.
      
              * history/CachedPage.cpp:
              (WebCore::CachedPage::clear):
              (WebCore::CachedPage::setCachedFramePlatformData):
              (WebCore::CachedPage::cachedFramePlatformData):
              * history/CachedPage.h:
      
      WebKit:
      
      2009-01-23  Brady Eidson  <beidson@apple.com>
      
              Rubberstamped by Darin Adler
      
              Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
      
              * WebKit.xcodeproj/project.pbxproj:
      
      WebKit/mac:
      
      2009-01-23  Brady Eidson  <beidson@apple.com>
      
              Rubberstamped by Darin Adler
      
              Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
      
              * WebCoreSupport/WebCachedFramePlatformData.h: Copied from WebKit/mac/WebCoreSupport/WebCachedPagePlatformData.h.
              (WebCachedFramePlatformData::WebCachedFramePlatformData):
              * WebCoreSupport/WebCachedPagePlatformData.h: Removed.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::savePlatformDataToCachedPage):
              (WebFrameLoaderClient::transitionToCommittedFromCachedPage):
      
              * WebKit.order:
      
      WebKit/win:
      
      2009-01-23  Brady Eidson  <beidson@apple.com>
      
              Rubberstamped by Darin Adler
      
              Rename CachedPagePlatformData to CachedFramePlatformData to more accurately reflect its true role.
      
              * WebCachedFramePlatformData.h: Copied from WebKit/win/WebCachedPagePlatformData.h.
              (WebCachedFramePlatformData::WebCachedFramePlatformData):
              * WebCachedPagePlatformData.h: Removed.
      
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::savePlatformDataToCachedPage):
      
              * WebKit.vcproj/WebKit.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94faeb95
    • kevino@webkit.org's avatar
      Reviewed by Kevin Ollivier. · 9a3fe848
      kevino@webkit.org authored
      Fix drawing in situations where sub-portions of the bitmap are to be drawn to the screen.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9a3fe848
    • kevino@webkit.org's avatar
      Build fixes for recent changes. · 96468e96
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96468e96
    • hyatt@apple.com's avatar
      Fix Windows bustage. · 86d7b1d3
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86d7b1d3
    • hyatt@apple.com's avatar
      Fix Windows bustage. · 4e223059
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e223059
    • eric.carlson@apple.com's avatar
      2009-01-23 Eric Carlson <eric.carlson@apple.com> · 4ad79468
      eric.carlson@apple.com authored
              Reviewed by Adele Peterson
              
              Fix for https://bugs.webkit.org/show_bug.cgi?id=23407
      
              Implement QTMovieWin::hasVideo so the controller on an audio-only <video> element 
              is never hidden (as with an <audio> element).
      
              Test: media/video-controls-visible-audio-only.html
      
              * platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
              (WebCore::MediaPlayerPrivate::hasVideo):
              * platform/graphics/win/QTMovieWin.cpp:
              (QTMovieWin::hasVideo):
              * platform/graphics/win/QTMovieWin.h:
      
      2009-01-23  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Adele Peterson
      
              Test for behavior of <video> element controller when a media file has
              only audio.
              https://bugs.webkit.org/show_bug.cgi?id=23407
      
              * media/video-controls-visible-audio-only.html: Added.
              * platform/mac/media/video-controls-visible-audio-only-expected.checksum: Added.
              * platform/mac/media/video-controls-visible-audio-only-expected.png: Added.
              * platform/mac/media/video-controls-visible-audio-only-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ad79468
    • hyatt@apple.com's avatar
      2009-01-23 David Hyatt <hyatt@apple.com> · 0c305637
      hyatt@apple.com authored
              Make toRenderBox a non-member function.  Rename toConstRenderBox to just also be called toRenderBox.
      
              Reviewed by Oliver Hunt
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::sizingBox):
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::getUpperLeftCorner):
              (WebCore::ContainerNode::getLowerRightCorner):
              * dom/Element.cpp:
              (WebCore::Element::scrollByUnits):
              * dom/Position.cpp:
              (WebCore::endsOfNodeAreVisuallyDistinctPositions):
              (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
              (WebCore::Position::isCandidate):
              * editing/DeleteButtonController.cpp:
              (WebCore::isDeletableElement):
              * editing/EditorCommand.cpp:
              (WebCore::verticalScrollDistance):
              * editing/TextIterator.cpp:
              (WebCore::shouldEmitExtraNewlineForNode):
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::isKeyboardFocusable):
              * html/HTMLFormControlElement.cpp:
              (WebCore::HTMLFormControlElement::isFocusable):
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::width):
              (WebCore::HTMLFrameElementBase::height):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::doAccessibilityHitTest):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMouseDraggedEvent):
              (WebCore::EventHandler::autoscrollTimerFired):
              (WebCore::EventHandler::updateAutoscrollRenderer):
              (WebCore::EventHandler::stopAutoscrollTimer):
              (WebCore::EventHandler::scrollOverflow):
              * page/FrameView.cpp:
              (WebCore::FrameView::layout):
              * page/animation/AnimationBase.cpp:
              (WebCore::blendFunc):
              * rendering/InlineBox.cpp:
              (WebCore::InlineBox::adjustPosition):
              * rendering/InlineBox.h:
              (WebCore::InlineBox::renderBox):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::clearFloats):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::offsetFromContainer):
              (WebCore::RenderBox::computeAbsoluteRepaintRect):
              (WebCore::RenderBox::containingBlockWidthForPositioned):
              (WebCore::RenderBox::containingBlockHeightForPositioned):
              (WebCore::RenderBox::calcAbsoluteHorizontal):
              (WebCore::RenderBox::calcAbsoluteVertical):
              (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
              (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
              * rendering/RenderBox.h:
              (WebCore::toRenderBox):
              (WebCore::RenderBox::previousSiblingBox):
              (WebCore::RenderBox::nextSiblingBox):
              (WebCore::RenderBox::parentBox):
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::absoluteClippedOverflowRect):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::updateLayerPosition):
              (WebCore::RenderLayer::resize):
              (WebCore::RenderLayer::boundingBox):
              * rendering/RenderObject.cpp:
              (WebCore::addLayers):
              (WebCore::RenderObject::removeLayers):
              (WebCore::RenderObject::moveLayers):
              (WebCore::RenderObject::findNextLayer):
              (WebCore::RenderObject::enclosingLayer):
              (WebCore::RenderObject::setNeedsLayout):
              (WebCore::RenderObject::setNeedsPositionedMovementLayout):
              (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
              (WebCore::RenderObject::getAbsoluteRepaintRectWithOutline):
              (WebCore::RenderObject::computeAbsoluteRepaintRect):
              (WebCore::RenderObject::localToAbsolute):
              (WebCore::RenderObject::absoluteToLocal):
              (WebCore::RenderObject::localToAbsoluteQuad):
              (WebCore::RenderObject::offsetFromContainer):
              (WebCore::RenderObject::removeFromObjectLists):
              (WebCore::RenderObject::destroy):
              (WebCore::RenderObject::updateHitTestResult):
              (WebCore::RenderObject::addDashboardRegions):
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::layoutRows):
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::hitTestMediaControlPart):
              (WebCore::RenderTheme::baselinePosition):
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::hitTestMediaControlPart):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::externalRepresentation):
              * rendering/bidi.cpp:
              (WebCore::inlineWidth):
              (WebCore::RenderBlock::computeHorizontalPositionsForLine):
              (WebCore::requiresLineBox):
              (WebCore::RenderBlock::findNextLineBreak):
              * svg/SVGLength.cpp:
              (WebCore::SVGLength::PercentageOfViewport):
              * wml/WMLAElement.cpp:
              (WebCore::WMLAElement::isKeyboardFocusable):
              * wml/WMLInputElement.cpp:
              (WebCore::isInputFocusable):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c305637