1. 05 May, 2009 1 commit
    • ap@webkit.org's avatar
      Reviewed by Dave Hyatt. · d0295906
      ap@webkit.org authored
              <rdar://problem/6576889> REGRESSION (r35185): Cannot watch Flash movies on omg.yahoo.com
      
              The problem was caused by missing <head> element - we used to create it when moving a
              misplaced <style> element, but we now handle those in place. Other browsers always create
              a <head> element.
      
              There is no guarantee that a <head> element always exists - first, it can be removed with
              removeChild or innerHTML, and also, we don't currently create it for frameset documents, or
              for manually created ones (e.g. ImageDocument).
      
              Test: fast/parser/head-element-for-yahoo-player.html
      
      WebKit:
              * dom/Document.cpp: (WebCore::Document::implicitClose): Create a <head> element for about:blank.
              A removed comment talked about rdar://3758785, but that problem doesn't re-occur even if this
              code is removed completely.
      
              * html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::checkDTD): No longer allow <script>
              elements as children of <html>. This isn't directly related to this bug, but it was easier
              to fix both at once (IE and Firefox both don't allow such mispositioned <script> elements).
      
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::handleError): Move <script> to <head> if <body> hasn't been created yet.
              Create a <head> it a <body> is created implicitly to contain some other element.
              (WebCore::HTMLParser::bodyCreateErrorCheck): Ensure that a <head> exists when <body> is
              explicitly present in source.
              (WebCore::HTMLParser::createHead): Do the work even if <html> element hasn't been created yet.
      
      LayoutTests:
              * fast/parser/head-element-for-yahoo-player-expected.txt: Added.
              * fast/parser/head-element-for-yahoo-player.html: Added.
              Test the regression case (a misplaced <style> that used to create <head> implicitly).
      
              * editing/selection/select-all-005.html: Use a new index when selecting the body.
      
              * fast/dom/Document/document-write-doctype-expected.txt:
              * fast/dom/Document/resources/document-write-doctype.js:
              Removed checks for "Gecko quirk" of implicitly adding HEAD - that not a quirk, but standard
              behavior per HTML5.
      
              * editing/execCommand/create-list-1-expected.txt:
              * platform/mac/editing/deleting/4845371-expected.txt:
              * platform/mac/editing/deleting/4866671-expected.txt:
              * platform/mac/editing/deleting/4875189-expected.txt:
              * platform/mac/editing/deleting/5026848-1-expected.txt:
              * platform/mac/editing/deleting/5026848-2-expected.txt:
              * platform/mac/editing/deleting/5026848-3-expected.txt:
              * platform/mac/editing/deleting/5032066-expected.txt:
              * platform/mac/editing/deleting/5091898-expected.txt:
              * platform/mac/editing/deleting/5099303-expected.txt:
              * platform/mac/editing/deleting/5115601-expected.txt:
              * platform/mac/editing/deleting/5126166-expected.txt:
              * platform/mac/editing/deleting/5156801-2-expected.txt:
              * platform/mac/editing/deleting/5168598-expected.txt:
              * platform/mac/editing/deleting/5272440-expected.txt:
              * platform/mac/editing/deleting/5300379-expected.txt:
              * platform/mac/editing/deleting/5390681-expected.txt:
              * platform/mac/editing/deleting/5408255-expected.txt:
              * platform/mac/editing/deleting/5433862-2-expected.txt:
              * platform/mac/editing/deleting/5483370-expected.txt:
              * platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
              * platform/mac/editing/deleting/delete-block-table-expected.txt:
              * platform/mac/editing/deleting/delete-hr-expected.txt:
              * platform/mac/editing/deleting/delete-mixed-editable-content-001-expected.txt:
              * platform/mac/editing/deleting/delete-to-select-table-expected.txt:
              * platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
              * platform/mac/editing/deleting/merge-endOfParagraph-expected.txt:
              * platform/mac/editing/deleting/merge-no-br-expected.txt:
              * platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
              * platform/mac/editing/execCommand/4641880-1-expected.txt:
              * platform/mac/editing/execCommand/4641880-2-expected.txt:
              * platform/mac/editing/execCommand/4747450-expected.txt:
              * platform/mac/editing/execCommand/4786404-1-expected.txt:
              * platform/mac/editing/execCommand/4786404-2-expected.txt:
              * platform/mac/editing/execCommand/4916402-expected.txt:
              * platform/mac/editing/execCommand/4916541-expected.txt:
              * platform/mac/editing/execCommand/4916583-expected.txt:
              * platform/mac/editing/execCommand/4920488-expected.txt:
              * platform/mac/editing/execCommand/4920742-1-expected.txt:
              * platform/mac/editing/execCommand/4924441-expected.txt:
              * platform/mac/editing/execCommand/5049671-expected.txt:
              * platform/mac/editing/execCommand/5080333-1-expected.txt:
              * platform/mac/editing/execCommand/5080333-2-expected.txt:
              * platform/mac/editing/execCommand/5119244-expected.txt:
              * platform/mac/editing/execCommand/5120591-expected.txt:
              * platform/mac/editing/execCommand/5136770-expected.txt:
              * platform/mac/editing/execCommand/5142012-1-expected.txt:
              * platform/mac/editing/execCommand/5142012-2-expected.txt:
              * platform/mac/editing/execCommand/5142012-3-expected.txt:
              * platform/mac/editing/execCommand/5144139-1-expected.txt:
              * platform/mac/editing/execCommand/5164796-expected.txt:
              * platform/mac/editing/execCommand/5207369-expected.txt:
              * platform/mac/editing/execCommand/5210032-expected.txt:
              * platform/mac/editing/execCommand/5432254-1-expected.txt:
              * platform/mac/editing/execCommand/5432254-2-expected.txt:
              * platform/mac/editing/execCommand/5481523-expected.txt:
              * platform/mac/editing/execCommand/5482524-expected.txt:
              * platform/mac/editing/execCommand/5569741-expected.txt:
              * platform/mac/editing/execCommand/5573879-expected.txt:
              * platform/mac/editing/execCommand/5700414-1-expected.txt:
              * platform/mac/editing/execCommand/5700414-2-expected.txt:
              * platform/mac/editing/execCommand/insert-list-empty-div-expected.txt:
              * platform/mac/editing/input/5576619-expected.txt:
              * platform/mac/editing/inserting/12882-expected.txt:
              * platform/mac/editing/inserting/4840662-expected.txt:
              * platform/mac/editing/inserting/4875189-1-expected.txt:
              * platform/mac/editing/inserting/4875189-2-expected.txt:
              * platform/mac/editing/inserting/4959067-expected.txt:
              * platform/mac/editing/inserting/4960120-1-expected.txt:
              * platform/mac/editing/inserting/4960120-2-expected.txt:
              * platform/mac/editing/inserting/5002441-expected.txt:
              * platform/mac/editing/inserting/5058163-2-expected.txt:
              * platform/mac/editing/inserting/5156401-2-expected.txt:
              * platform/mac/editing/inserting/5549929-2-expected.txt:
              * platform/mac/editing/inserting/5549929-3-expected.txt:
              * platform/mac/editing/inserting/5607069-2-expected.txt:
              * platform/mac/editing/inserting/5607069-3-expected.txt:
              * platform/mac/editing/inserting/editable-html-element-expected.txt:
              * platform/mac/editing/inserting/editable-inline-element-expected.txt:
              * platform/mac/editing/inserting/edited-whitespace-1-expected.txt:
              * platform/mac/editing/inserting/editing-empty-divs-expected.txt:
              * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt:
              * platform/mac/editing/pasteboard/4806874-expected.txt:
              * platform/mac/editing/pasteboard/4861080-expected.txt:
              * platform/mac/editing/pasteboard/4944770-1-expected.txt:
              * platform/mac/editing/pasteboard/4944770-2-expected.txt:
              * platform/mac/editing/pasteboard/4947130-expected.txt:
              * platform/mac/editing/pasteboard/4989774-expected.txt:
              * platform/mac/editing/pasteboard/5027857-expected.txt:
              * platform/mac/editing/pasteboard/5032095-expected.txt:
              * platform/mac/editing/pasteboard/5065605-expected.txt:
              * platform/mac/editing/pasteboard/5071074-2-expected.txt:
              * platform/mac/editing/pasteboard/5071074-expected.txt:
              * platform/mac/editing/pasteboard/5075944-2-expected.txt:
              * platform/mac/editing/pasteboard/5075944-3-expected.txt:
              * platform/mac/editing/pasteboard/5075944-expected.txt:
              * platform/mac/editing/pasteboard/5134759-expected.txt:
              * platform/mac/editing/pasteboard/5156401-1-expected.txt:
              * platform/mac/editing/pasteboard/5247341-expected.txt:
              * platform/mac/editing/pasteboard/5387578-expected.txt:
              * platform/mac/editing/pasteboard/5478250-expected.txt:
              * platform/mac/editing/pasteboard/5483567-expected.txt:
              * platform/mac/editing/pasteboard/5601583-1-expected.txt:
              * platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt:
              * platform/mac/editing/pasteboard/input-field-1-expected.txt:
              * platform/mac/editing/pasteboard/merge-after-delete-1-expected.txt:
              * platform/mac/editing/pasteboard/merge-after-delete-2-expected.txt:
              * platform/mac/editing/pasteboard/merge-after-delete-expected.txt:
              * platform/mac/editing/pasteboard/merge-start-blockquote-expected.txt:
              * platform/mac/editing/pasteboard/paste-unrendered-select-expected.txt:
              * platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.txt:
              * platform/mac/editing/pasteboard/select-element-1-expected.txt:
              * platform/mac/editing/selection/13804-expected.txt:
              * platform/mac/editing/selection/14971-expected.txt:
              * platform/mac/editing/selection/4397952-expected.txt:
              * platform/mac/editing/selection/4818145-expected.txt:
              * platform/mac/editing/selection/4866671-expected.txt:
              * platform/mac/editing/selection/4889598-expected.txt:
              * platform/mac/editing/selection/4895428-1-expected.txt:
              * platform/mac/editing/selection/4895428-2-expected.txt:
              * platform/mac/editing/selection/4895428-3-expected.txt:
              * platform/mac/editing/selection/4895428-4-expected.txt:
              * platform/mac/editing/selection/4932260-1-expected.txt:
              * platform/mac/editing/selection/4932260-2-expected.txt:
              * platform/mac/editing/selection/4932260-3-expected.txt:
              * platform/mac/editing/selection/4947387-expected.txt:
              * platform/mac/editing/selection/4960116-expected.txt:
              * platform/mac/editing/selection/4975120-expected.txt:
              * platform/mac/editing/selection/4983858-expected.txt:
              * platform/mac/editing/selection/5007143-2-expected.txt:
              * platform/mac/editing/selection/5007143-expected.txt:
              * platform/mac/editing/selection/5057506-2-expected.txt:
              * platform/mac/editing/selection/5057506-expected.txt:
              * platform/mac/editing/selection/5076323-1-expected.txt:
              * platform/mac/editing/selection/5076323-2-expected.txt:
              * platform/mac/editing/selection/5076323-3-expected.txt:
              * platform/mac/editing/selection/5081257-1-expected.txt:
              * platform/mac/editing/selection/5081257-2-expected.txt:
              * platform/mac/editing/selection/5099303-expected.txt:
              * platform/mac/editing/selection/5109817-expected.txt:
              * platform/mac/editing/selection/5136696-expected.txt:
              * platform/mac/editing/selection/5195166-1-expected.txt:
              * platform/mac/editing/selection/5195166-2-expected.txt:
              * platform/mac/editing/selection/5234383-1-expected.txt:
              * platform/mac/editing/selection/5234383-2-expected.txt:
              * platform/mac/editing/selection/5240265-expected.txt:
              * platform/mac/editing/selection/5333725-expected.txt:
              * platform/mac/editing/selection/5354455-1-expected.txt:
              * platform/mac/editing/selection/addRange-expected.txt:
              * platform/mac/editing/selection/caret-before-select-expected.txt:
              * platform/mac/editing/selection/contains-boundaries-expected.txt:
              * platform/mac/editing/selection/drag-select-1-expected.txt:
              * platform/mac/editing/selection/editable-html-element-expected.txt:
              * platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt:
              * platform/mac/editing/selection/inline-closest-leaf-child-expected.txt:
              * platform/mac/editing/selection/mixed-editability-6-expected.txt:
              * platform/mac/editing/selection/mixed-editability-7-expected.txt:
              * platform/mac/editing/selection/move-by-sentence-linebreak-expected.txt:
              * platform/mac/editing/selection/select-all-005-expected.txt:
              * platform/mac/editing/selection/table-caret-1-expected.txt:
              * platform/mac/editing/selection/table-caret-2-expected.txt:
              * platform/mac/editing/selection/table-caret-3-expected.txt:
              * platform/mac/editing/selection/wrapped-line-caret-1-expected.txt:
              * platform/mac/editing/selection/wrapped-line-caret-2-expected.txt:
              * platform/mac/editing/style/4916887-expected.txt:
              * platform/mac/editing/style/5017613-1-expected.txt:
              * platform/mac/editing/style/5017613-2-expected.txt:
              * platform/mac/editing/style/5046875-1-expected.txt:
              * platform/mac/editing/style/5046875-2-expected.txt:
              * platform/mac/editing/style/5065910-expected.txt:
              * platform/mac/editing/style/5084241-expected.txt:
              * platform/mac/editing/style/5091898-expected.txt:
              * platform/mac/editing/style/5228141-expected.txt:
              * platform/mac/editing/style/5279521-expected.txt:
              * platform/mac/editing/style/font-family-with-space-expected.txt:
              * platform/mac/editing/style/fontsize-1-expected.txt:
              * platform/mac/editing/style/highlight-expected.txt:
              * platform/mac/editing/style/non-inheritable-styles-expected.txt:
              * platform/mac/editing/undo/5378473-expected.txt:
              * platform/mac/fast/block/float/relative-painted-twice-expected.txt:
              * platform/mac/fast/dom/delete-contents-expected.txt:
              * platform/mac/fast/events/context-no-deselect-expected.txt:
              * platform/mac/fast/events/label-focus-expected.txt:
              * platform/mac/fast/forms/input-appearance-focus-expected.txt:
              * platform/mac/fast/forms/input-text-click-inside-expected.txt:
              * platform/mac/fast/forms/input-text-click-outside-expected.txt:
              * platform/mac/fast/forms/input-text-double-click-expected.txt:
              * platform/mac/fast/forms/input-text-drag-down-expected.txt:
              * platform/mac/fast/forms/input-text-option-delete-expected.txt:
              * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
              * platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
              * platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt:
              * platform/mac/fast/forms/textfield-overflow-expected.txt:
              * platform/mac/fast/inline/25277-2-expected.txt:
              * platform/mac/fast/inline/25277-expected.txt:
              * platform/mac/fast/lists/drag-into-marker-expected.txt:
              * platform/mac/fast/overflow/overflow-focus-ring-expected.txt:
              * platform/mac/fast/repaint/4776765-expected.txt:
              * platform/mac/fast/repaint/selection-after-delete-expected.txt:
              * platform/mac/fast/repaint/selection-after-remove-expected.txt:
              * platform/qt/editing/deleting/4845371-expected.txt:
              * platform/qt/editing/deleting/4866671-expected.txt:
              * platform/qt/editing/deleting/4875189-expected.txt:
              * platform/qt/editing/deleting/5026848-1-expected.txt:
              * platform/qt/editing/deleting/5026848-2-expected.txt:
              * platform/qt/editing/deleting/5026848-3-expected.txt:
              * platform/qt/editing/deleting/5032066-expected.txt:
              * platform/qt/editing/deleting/5091898-expected.txt:
              * platform/qt/editing/deleting/5099303-expected.txt:
              * platform/qt/editing/deleting/5115601-expected.txt:
              * platform/qt/editing/deleting/5126166-expected.txt:
              * platform/qt/editing/deleting/5144139-2-expected.txt:
              * platform/qt/editing/deleting/5156801-2-expected.txt:
              * platform/qt/editing/deleting/5168598-expected.txt:
              * platform/qt/editing/deleting/5272440-expected.txt:
              * platform/qt/editing/deleting/5300379-expected.txt:
              * platform/qt/editing/deleting/5390681-expected.txt:
              * platform/qt/editing/deleting/5408255-expected.txt:
              * platform/qt/editing/deleting/delete-at-start-or-end-expected.txt:
              * platform/qt/editing/deleting/delete-block-table-expected.txt:
              * platform/qt/editing/deleting/delete-hr-expected.txt:
              * platform/qt/editing/deleting/delete-link-1-expected.txt:
              * platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.txt:
              * platform/qt/editing/deleting/delete-to-select-table-expected.txt:
              * platform/qt/editing/deleting/deletionUI-single-instance-expected.txt:
              * platform/qt/editing/deleting/merge-endOfParagraph-expected.txt:
              * platform/qt/editing/deleting/merge-no-br-expected.txt:
              * platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
              * platform/qt/editing/execCommand/4641880-1-expected.txt:
              * platform/qt/editing/execCommand/4641880-2-expected.txt:
              * platform/qt/editing/execCommand/4747450-expected.txt:
              * platform/qt/editing/execCommand/4786404-1-expected.txt:
              * platform/qt/editing/execCommand/4786404-2-expected.txt:
              * platform/qt/editing/execCommand/4916402-expected.txt:
              * platform/qt/editing/execCommand/4916541-expected.txt:
              * platform/qt/editing/execCommand/4916583-expected.txt:
              * platform/qt/editing/execCommand/4920488-expected.txt:
              * platform/qt/editing/execCommand/4920742-1-expected.txt:
              * platform/qt/editing/execCommand/4924441-expected.txt:
              * platform/qt/editing/execCommand/5049671-expected.txt:
              * platform/qt/editing/execCommand/5062376-expected.txt:
              * platform/qt/editing/execCommand/5080333-1-expected.txt:
              * platform/qt/editing/execCommand/5080333-2-expected.txt:
              * platform/qt/editing/execCommand/5119244-expected.txt:
              * platform/qt/editing/execCommand/5120591-expected.txt:
              * platform/qt/editing/execCommand/5136770-expected.txt:
              * platform/qt/editing/execCommand/5142012-1-expected.txt:
              * platform/qt/editing/execCommand/5142012-2-expected.txt:
              * platform/qt/editing/execCommand/5142012-3-expected.txt:
              * platform/qt/editing/execCommand/5144139-1-expected.txt:
              * platform/qt/editing/execCommand/5164796-expected.txt:
              * platform/qt/editing/execCommand/5207369-expected.txt:
              * platform/qt/editing/execCommand/5210032-expected.txt:
              * platform/qt/editing/execCommand/5432254-1-expected.txt:
              * platform/qt/editing/execCommand/5432254-2-expected.txt:
              * platform/qt/editing/execCommand/insert-list-empty-div-expected.txt:
              * platform/qt/editing/inserting/12882-expected.txt:
              * platform/qt/editing/inserting/4840662-expected.txt:
              * platform/qt/editing/inserting/4875189-1-expected.txt:
              * platform/qt/editing/inserting/4875189-2-expected.txt:
              * platform/qt/editing/inserting/4959067-expected.txt:
              * platform/qt/editing/inserting/4960120-1-expected.txt:
              * platform/qt/editing/inserting/4960120-2-expected.txt:
              * platform/qt/editing/inserting/5002441-expected.txt:
              * platform/qt/editing/inserting/5058163-2-expected.txt:
              * platform/qt/editing/inserting/5156401-2-expected.txt:
              * platform/qt/editing/inserting/editable-html-element-expected.txt:
              * platform/qt/editing/inserting/editable-inline-element-expected.txt:
              * platform/qt/editing/inserting/edited-whitespace-1-expected.txt:
              * platform/qt/editing/inserting/editing-empty-divs-expected.txt:
              * platform/qt/editing/inserting/insert-before-link-1-expected.txt:
              * platform/qt/editing/pasteboard/4806874-expected.txt:
              * platform/qt/editing/pasteboard/4840662-expected.txt:
              * platform/qt/editing/pasteboard/4944770-1-expected.txt:
              * platform/qt/editing/pasteboard/4989774-expected.txt:
              * platform/qt/editing/pasteboard/5027857-expected.txt:
              * platform/qt/editing/pasteboard/5032095-expected.txt:
              * platform/qt/editing/pasteboard/5065605-expected.txt:
              * platform/qt/editing/pasteboard/5071074-2-expected.txt:
              * platform/qt/editing/pasteboard/5071074-expected.txt:
              * platform/qt/editing/pasteboard/5075944-2-expected.txt:
              * platform/qt/editing/pasteboard/5075944-3-expected.txt:
              * platform/qt/editing/pasteboard/5075944-expected.txt:
              * platform/qt/editing/pasteboard/5134759-expected.txt:
              * platform/qt/editing/pasteboard/5156401-1-expected.txt:
              * platform/qt/editing/pasteboard/5245519-expected.txt:
              * platform/qt/editing/pasteboard/5247341-expected.txt:
              * platform/qt/editing/pasteboard/5387578-expected.txt:
              * platform/qt/editing/pasteboard/5478250-expected.txt:
              * platform/qt/editing/pasteboard/5483567-expected.txt:
              * platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt:
              * platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
              * platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
              * platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
              * platform/qt/editing/pasteboard/merge-start-blockquote-expected.txt:
              * platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt:
              * platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt:
              * platform/qt/editing/selection/13804-expected.txt:
              * platform/qt/editing/selection/4397952-expected.txt:
              * platform/qt/editing/selection/4818145-expected.txt:
              * platform/qt/editing/selection/4866671-expected.txt:
              * platform/qt/editing/selection/4889598-expected.txt:
              * platform/qt/editing/selection/4895428-2-expected.txt:
              * platform/qt/editing/selection/4895428-3-expected.txt:
              * platform/qt/editing/selection/4932260-1-expected.txt:
              * platform/qt/editing/selection/4932260-2-expected.txt:
              * platform/qt/editing/selection/4932260-3-expected.txt:
              * platform/qt/editing/selection/4960116-expected.txt:
              * platform/qt/editing/selection/4983858-expected.txt:
              * platform/qt/editing/selection/5007143-2-expected.txt:
              * platform/qt/editing/selection/5007143-expected.txt:
              * platform/qt/editing/selection/5076323-1-expected.txt:
              * platform/qt/editing/selection/5076323-2-expected.txt:
              * platform/qt/editing/selection/5076323-3-expected.txt:
              * platform/qt/editing/selection/5081257-1-expected.txt:
              * platform/qt/editing/selection/5081257-2-expected.txt:
              * platform/qt/editing/selection/5099303-expected.txt:
              * platform/qt/editing/selection/5136696-expected.txt:
              * platform/qt/editing/selection/5195166-1-expected.txt:
              * platform/qt/editing/selection/5195166-2-expected.txt:
              * platform/qt/editing/selection/5234383-1-expected.txt:
              * platform/qt/editing/selection/5234383-2-expected.txt:
              * platform/qt/editing/selection/5240265-expected.txt:
              * platform/qt/editing/selection/addRange-expected.txt:
              * platform/qt/editing/selection/caret-before-select-expected.txt:
              * platform/qt/editing/selection/editable-html-element-expected.txt:
              * platform/qt/editing/selection/mixed-editability-6-expected.txt:
              * platform/qt/editing/selection/mixed-editability-7-expected.txt:
              * platform/qt/editing/selection/move-by-sentence-linebreak-expected.txt:
              * platform/qt/editing/selection/select-all-005-expected.txt:
              * platform/qt/editing/selection/table-caret-1-expected.txt:
              * platform/qt/editing/selection/table-caret-2-expected.txt:
              * platform/qt/editing/selection/table-caret-3-expected.txt:
              * platform/qt/editing/style/4916887-expected.txt:
              * platform/qt/editing/style/5017613-1-expected.txt:
              * platform/qt/editing/style/5017613-2-expected.txt:
              * platform/qt/editing/style/5046875-1-expected.txt:
              * platform/qt/editing/style/5046875-2-expected.txt:
              * platform/qt/editing/style/5065910-expected.txt:
              * platform/qt/editing/style/5084241-expected.txt:
              * platform/qt/editing/style/5228141-expected.txt:
              * platform/qt/editing/style/5279521-expected.txt:
              * platform/qt/editing/style/font-family-with-space-expected.txt:
              * platform/qt/editing/style/fontsize-1-expected.txt:
              * platform/qt/editing/style/highlight-expected.txt:
              * platform/qt/editing/style/non-inheritable-styles-expected.txt:
              * platform/qt/editing/undo/5378473-expected.txt:
              * platform/qt/fast/dom/delete-contents-expected.txt:
              * platform/qt/fast/events/label-focus-expected.txt:
              * platform/qt/fast/forms/input-appearance-focus-expected.txt:
              * platform/qt/fast/forms/input-maxlength-2-expected.txt:
              * platform/qt/fast/forms/input-text-click-inside-expected.txt:
              * platform/qt/fast/forms/input-text-option-delete-expected.txt:
              * platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
              * platform/qt/fast/forms/textfield-drag-into-disabled-expected.txt:
              * platform/qt/fast/forms/textfield-overflow-expected.txt:
              * platform/qt/fast/overflow/overflow-focus-ring-expected.txt:
              * platform/qt/fast/repaint/4776765-expected.txt:
              * platform/qt/fast/repaint/selection-after-delete-expected.txt:
              * platform/qt/fast/repaint/selection-after-remove-expected.txt:
              * platform/win/editing/deleting/5168598-expected.txt:
              * platform/win/editing/inserting/4960120-1-expected.txt:
              * platform/win/editing/inserting/5607069-2-expected.txt:
              * platform/win/editing/inserting/5607069-3-expected.txt:
              * platform/win/editing/inserting/typing-tab-designmode-forms-expected.txt:
              * platform/win/editing/pasteboard/4806874-expected.txt:
              * platform/win/editing/selection/4895428-3-expected.txt:
              * platform/win/editing/selection/5136696-expected.txt:
              * platform/win/editing/selection/drag-select-1-expected.txt:
              * platform/win/fast/events/context-no-deselect-expected.txt:
              * platform/win/fast/events/label-focus-expected.txt:
              * platform/win/fast/forms/input-appearance-focus-expected.txt:
              * platform/win/fast/forms/input-text-click-inside-expected.txt:
              * platform/win/fast/forms/input-text-click-outside-expected.txt:
              * platform/win/fast/forms/input-text-double-click-expected.txt:
              * platform/win/fast/forms/input-text-drag-down-expected.txt:
              * platform/win/fast/forms/input-text-option-delete-expected.txt:
              * platform/win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
              * platform/win/fast/forms/input-text-self-emptying-click-expected.txt:
              * platform/win/fast/forms/textfield-drag-into-disabled-expected.txt:
              * platform/win/fast/forms/textfield-overflow-expected.txt:
              Updated BODY element index in test output (for some tests, it increased because of the
              implicitly added <head>, and for others, it decreased because mispositoned <script> is being
              moved into <head>).
      
              * webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive:
              * webarchive/archive-empty-frame-dom-expected.webarchive:
              Updated to include the implicitly added <head> elements.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0295906
  2. 03 Oct, 2007 1 commit
  3. 19 Apr, 2007 1 commit
    • weinig's avatar
      LayoutTests: · 28ce873d
      weinig authored
              Reviewed by Hyatt
      
              - updated results for http://bugs.webkit.org/show_bug.cgi?id=13291
                REGRESSION (r19595): WebViewDidBeginEditingNotification not posted when focusing with the mouse
      
              * editing/deleting/4845371-expected.txt:
              * editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
              * editing/deleting/delete-3608430-fix-expected.txt:
              * editing/deleting/delete-3608445-fix-expected.txt:
              * editing/deleting/delete-3608462-fix-expected.txt:
              * editing/deleting/delete-3775172-fix-expected.txt:
              * editing/deleting/delete-3800834-fix-expected.txt:
              * editing/deleting/delete-3857753-fix-expected.txt:
              * editing/deleting/delete-3865854-fix-expected.txt:
              * editing/deleting/delete-3928305-fix-expected.txt:
              * editing/deleting/delete-3959464-fix-expected.txt:
              * editing/deleting/delete-4038408-fix-expected.txt:
              * editing/deleting/delete-4083333-fix-expected.txt:
              * editing/deleting/delete-after-span-ws-001-expected.txt:
              * editing/deleting/delete-after-span-ws-002-expected.txt:
              * editing/deleting/delete-after-span-ws-003-expected.txt:
              * editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
              * editing/deleting/delete-and-undo-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
              * editing/deleting/delete-at-start-or-end-expected.txt:
              * editing/deleting/delete-block-contents-001-expected.txt:
              * editing/deleting/delete-block-contents-002-expected.txt:
              * editing/deleting/delete-block-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-001-expected.txt:
              * editing/deleting/delete-block-merge-contents-002-expected.txt:
              * editing/deleting/delete-block-merge-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-004-expected.txt:
              * editing/deleting/delete-block-merge-contents-005-expected.txt:
              * editing/deleting/delete-block-merge-contents-006-expected.txt:
              * editing/deleting/delete-block-merge-contents-007-expected.txt:
              * editing/deleting/delete-block-merge-contents-008-expected.txt:
              * editing/deleting/delete-block-merge-contents-009-expected.txt:
              * editing/deleting/delete-block-merge-contents-010-expected.txt:
              * editing/deleting/delete-block-merge-contents-011-expected.txt:
              * editing/deleting/delete-block-merge-contents-012-expected.txt:
              * editing/deleting/delete-block-merge-contents-013-expected.txt:
              * editing/deleting/delete-block-merge-contents-014-expected.txt:
              * editing/deleting/delete-block-merge-contents-015-expected.txt:
              * editing/deleting/delete-block-merge-contents-016-expected.txt:
              * editing/deleting/delete-block-merge-contents-017-expected.txt:
              * editing/deleting/delete-block-merge-contents-018-expected.txt:
              * editing/deleting/delete-block-merge-contents-019-expected.txt:
              * editing/deleting/delete-block-merge-contents-020-expected.txt:
              * editing/deleting/delete-block-merge-contents-021-expected.txt:
              * editing/deleting/delete-block-merge-contents-022-expected.txt:
              * editing/deleting/delete-block-merge-contents-023-expected.txt:
              * editing/deleting/delete-block-merge-contents-024-expected.txt:
              * editing/deleting/delete-block-table-expected.txt:
              * editing/deleting/delete-br-001-expected.txt:
              * editing/deleting/delete-br-002-expected.txt:
              * editing/deleting/delete-br-003-expected.txt:
              * editing/deleting/delete-br-004-expected.txt:
              * editing/deleting/delete-br-005-expected.txt:
              * editing/deleting/delete-br-006-expected.txt:
              * editing/deleting/delete-br-007-expected.txt:
              * editing/deleting/delete-br-008-expected.txt:
              * editing/deleting/delete-br-009-expected.txt:
              * editing/deleting/delete-br-010-expected.txt:
              * editing/deleting/delete-br-011-expected.txt:
              * editing/deleting/delete-br-012-expected.txt:
              * editing/deleting/delete-by-word-001-expected.txt:
              * editing/deleting/delete-by-word-002-expected.txt:
              * editing/deleting/delete-character-001-expected.txt:
              * editing/deleting/delete-contiguous-ws-001-expected.txt:
              * editing/deleting/delete-first-list-item-expected.txt:
              * editing/deleting/delete-hr-expected.txt:
              * editing/deleting/delete-image-001-expected.txt:
              * editing/deleting/delete-image-002-expected.txt:
              * editing/deleting/delete-image-003-expected.txt:
              * editing/deleting/delete-image-004-expected.txt:
              * editing/deleting/delete-leading-ws-001-expected.txt:
              * editing/deleting/delete-line-001-expected.txt:
              * editing/deleting/delete-line-002-expected.txt:
              * editing/deleting/delete-line-003-expected.txt:
              * editing/deleting/delete-line-004-expected.txt:
              * editing/deleting/delete-line-005-expected.txt:
              * editing/deleting/delete-line-006-expected.txt:
              * editing/deleting/delete-line-007-expected.txt:
              * editing/deleting/delete-line-008-expected.txt:
              * editing/deleting/delete-line-009-expected.txt:
              * editing/deleting/delete-line-010-expected.txt:
              * editing/deleting/delete-line-011-expected.txt:
              * editing/deleting/delete-line-012-expected.txt:
              * editing/deleting/delete-line-013-expected.txt:
              * editing/deleting/delete-line-014-expected.txt:
              * editing/deleting/delete-line-015-expected.txt:
              * editing/deleting/delete-line-016-expected.txt:
              * editing/deleting/delete-line-017-expected.txt:
              * editing/deleting/delete-line-end-ws-001-expected.txt:
              * editing/deleting/delete-line-end-ws-002-expected.txt:
              * editing/deleting/delete-link-1-expected.txt:
              * editing/deleting/delete-listitem-001-expected.txt:
              * editing/deleting/delete-listitem-002-expected.txt:
              * editing/deleting/delete-mixed-editable-content-001-expected.txt:
              * editing/deleting/delete-select-all-001-expected.txt:
              * editing/deleting/delete-select-all-002-expected.txt:
              * editing/deleting/delete-select-all-003-expected.txt:
              * editing/deleting/delete-selection-001-expected.txt:
              * editing/deleting/delete-tab-001-expected.txt:
              * editing/deleting/delete-tab-002-expected.txt:
              * editing/deleting/delete-tab-003-expected.txt:
              * editing/deleting/delete-tab-004-expected.txt:
              * editing/deleting/delete-to-end-of-paragraph-expected.txt:
              * editing/deleting/delete-to-select-table-expected.txt:
              * editing/deleting/delete-trailing-ws-001-expected.txt:
              * editing/deleting/delete-trailing-ws-002-expected.txt:
              * editing/deleting/delete-ws-fixup-001-expected.txt:
              * editing/deleting/delete-ws-fixup-002-expected.txt:
              * editing/deleting/delete-ws-fixup-003-expected.txt:
              * editing/deleting/delete-ws-fixup-004-expected.txt:
              * editing/deleting/forward-delete-expected.txt:
              * editing/deleting/list-item-1-expected.txt:
              * editing/deleting/merge-different-styles-expected.txt:
              * editing/deleting/merge-endOfParagraph-expected.txt:
              * editing/deleting/merge-into-empty-block-1-expected.txt:
              * editing/deleting/merge-into-empty-block-2-expected.txt:
              * editing/deleting/merge-no-br-expected.txt:
              * editing/deleting/merge-unrendered-space-expected.txt:
              * editing/deleting/paragraph-in-preserveNewline-expected.txt:
              * editing/deleting/pruning-after-merge-1-expected.txt:
              * editing/deleting/pruning-after-merge-2-expected.txt:
              * editing/deleting/smart-delete-001-expected.txt:
              * editing/deleting/smart-delete-002-expected.txt:
              * editing/deleting/smart-delete-003-expected.txt:
              * editing/deleting/smart-delete-004-expected.txt:
              * editing/deleting/table-cells-expected.txt:
              * editing/deleting/transpose-empty-expected.txt:
              * editing/deleting/whitespace-pre-1-expected.txt:
              * editing/execCommand/4641880-1-expected.txt:
              * editing/execCommand/4641880-2-expected.txt:
              * editing/execCommand/boldSelection-expected.txt:
              * editing/execCommand/create-list-from-range-selection-expected.txt:
              * editing/execCommand/create-list-with-hr-expected.txt:
              * editing/execCommand/createLink-expected.txt:
              * editing/execCommand/format-block-expected.txt:
              * editing/execCommand/format-block-from-range-selection-expected.txt:
              * editing/execCommand/format-block-with-braces-expected.txt:
              * editing/execCommand/format-block-with-trailing-br-expected.txt:
              * editing/execCommand/hilitecolor-expected.txt:
              * editing/execCommand/indent-empty-root-expected.txt:
              * editing/execCommand/indent-list-item-expected.txt:
              * editing/execCommand/indent-selection-expected.txt:
              * editing/execCommand/insert-list-and-stitch-expected.txt:
              * editing/execCommand/insert-list-with-id-expected.txt:
              * editing/execCommand/insertHTML-expected.txt:
              * editing/execCommand/insertHorizontalRule-expected.txt:
              * editing/execCommand/insertImage-expected.txt:
              * editing/execCommand/italicizeByCharacter-expected.txt:
              * editing/execCommand/modifyForeColorByCharacter-expected.txt:
              * editing/execCommand/nsresponder-indent-expected.txt:
              * editing/execCommand/nsresponder-outdent-expected.txt:
              * editing/execCommand/outdent-selection-expected.txt:
              * editing/execCommand/print-expected.txt:
              * editing/execCommand/queryCommandState-01-expected.txt:
              * editing/execCommand/remove-formatting-2-expected.txt:
              * editing/execCommand/remove-formatting-expected.txt:
              * editing/execCommand/remove-list-from-range-selection-expected.txt:
              * editing/execCommand/remove-list-item-1-expected.txt:
              * editing/execCommand/remove-list-items-expected.txt:
              * editing/execCommand/selectAll-expected.txt:
              * editing/execCommand/strikethroughSelection-expected.txt:
              * editing/execCommand/switch-list-type-expected.txt:
              * editing/execCommand/unlink-expected.txt:
              * editing/input/firstrectforcharacterrange-plain-expected.txt:
              * editing/input/firstrectforcharacterrange-styled-expected.txt:
              * editing/input/wrapped-line-char-rect-expected.txt:
              * editing/inserting/4278698-expected.txt:
              * editing/inserting/before-after-input-element-expected.txt:
              * editing/inserting/editable-html-element-expected.txt:
              * editing/inserting/editing-empty-divs-expected.txt:
              * editing/inserting/insert-3654864-fix-expected.txt:
              * editing/inserting/insert-3659587-fix-expected.txt:
              * editing/inserting/insert-3775316-fix-expected.txt:
              * editing/inserting/insert-3778059-fix-expected.txt:
              * editing/inserting/insert-3786362-fix-expected.txt:
              * editing/inserting/insert-3800346-fix-expected.txt:
              * editing/inserting/insert-3851164-fix-expected.txt:
              * editing/inserting/insert-3907422-fix-expected.txt:
              * editing/inserting/insert-after-delete-001-expected.txt:
              * editing/inserting/insert-at-end-01-expected.txt:
              * editing/inserting/insert-at-end-02-expected.txt:
              * editing/inserting/insert-before-link-1-expected.txt:
              * editing/inserting/insert-br-001-expected.txt:
              * editing/inserting/insert-br-002-expected.txt:
              * editing/inserting/insert-br-003-expected.txt:
              * editing/inserting/insert-br-004-expected.txt:
              * editing/inserting/insert-br-005-expected.txt:
              * editing/inserting/insert-br-006-expected.txt:
              * editing/inserting/insert-br-007-expected.txt:
              * editing/inserting/insert-br-008-expected.txt:
              * editing/inserting/insert-br-009-expected.txt:
              * editing/inserting/insert-br-at-tabspan-001-expected.txt:
              * editing/inserting/insert-br-at-tabspan-002-expected.txt:
              * editing/inserting/insert-br-at-tabspan-003-expected.txt:
              * editing/inserting/insert-br-quoted-001-expected.txt:
              * editing/inserting/insert-br-quoted-002-expected.txt:
              * editing/inserting/insert-br-quoted-003-expected.txt:
              * editing/inserting/insert-br-quoted-004-expected.txt:
              * editing/inserting/insert-br-quoted-005-expected.txt:
              * editing/inserting/insert-br-quoted-006-expected.txt:
              * editing/inserting/insert-div-001-expected.txt:
              * editing/inserting/insert-div-002-expected.txt:
              * editing/inserting/insert-div-003-expected.txt:
              * editing/inserting/insert-div-004-expected.txt:
              * editing/inserting/insert-div-005-expected.txt:
              * editing/inserting/insert-div-006-expected.txt:
              * editing/inserting/insert-div-007-expected.txt:
              * editing/inserting/insert-div-008-expected.txt:
              * editing/inserting/insert-div-009-expected.txt:
              * editing/inserting/insert-div-010-expected.txt:
              * editing/inserting/insert-div-011-expected.txt:
              * editing/inserting/insert-div-012-expected.txt:
              * editing/inserting/insert-div-013-expected.txt:
              * editing/inserting/insert-div-014-expected.txt:
              * editing/inserting/insert-div-015-expected.txt:
              * editing/inserting/insert-div-016-expected.txt:
              * editing/inserting/insert-div-017-expected.txt:
              * editing/inserting/insert-div-018-expected.txt:
              * editing/inserting/insert-div-019-expected.txt:
              * editing/inserting/insert-div-020-expected.txt:
              * editing/inserting/insert-div-021-expected.txt:
              * editing/inserting/insert-div-022-expected.txt:
              * editing/inserting/insert-div-023-expected.txt:
              * editing/inserting/insert-div-024-expected.txt:
              * editing/inserting/insert-div-025-expected.txt:
              * editing/inserting/insert-div-026-expected.txt:
              * editing/inserting/insert-div-027-expected.txt:
              * editing/inserting/insert-paragraph-01-expected.txt:
              * editing/inserting/insert-paragraph-02-expected.txt:
              * editing/inserting/insert-paragraph-03-expected.txt:
              * editing/inserting/insert-paragraph-04-expected.txt:
              * editing/inserting/insert-space-in-empty-doc-expected.txt:
              * editing/inserting/insert-tab-001-expected.txt:
              * editing/inserting/insert-tab-002-expected.txt:
              * editing/inserting/insert-tab-003-expected.txt:
              * editing/inserting/insert-tab-004-expected.txt:
              * editing/inserting/insert-text-at-tabspan-001-expected.txt:
              * editing/inserting/insert-text-at-tabspan-002-expected.txt:
              * editing/inserting/insert-text-at-tabspan-003-expected.txt:
              * editing/inserting/insert-text-with-newlines-expected.txt:
              * editing/inserting/line-break-expected.txt:
              * editing/inserting/multiple-lines-selected-expected.txt:
              * editing/inserting/paragraph-separator-01-expected.txt:
              * editing/inserting/paragraph-separator-02-expected.txt:
              * editing/inserting/paragraph-separator-03-expected.txt:
              * editing/inserting/paragraph-separator-in-table-1-expected.txt:
              * editing/inserting/paragraph-separator-in-table-2-expected.txt:
              * editing/inserting/redo-expected.txt:
              * editing/inserting/return-key-with-selection-001-expected.txt:
              * editing/inserting/return-key-with-selection-002-expected.txt:
              * editing/inserting/return-key-with-selection-003-expected.txt:
              * editing/inserting/typing-001-expected.txt:
              * editing/inserting/typing-002-expected.txt:
              * editing/inserting/typing-003-expected.txt:
              * editing/inserting/typing-around-br-001-expected.txt:
              * editing/inserting/typing-around-image-001-expected.txt:
              * editing/pasteboard/3976872-expected.txt:
              * editing/pasteboard/4076267-2-expected.txt:
              * editing/pasteboard/4076267-3-expected.txt:
              * editing/pasteboard/4076267-expected.txt:
              * editing/pasteboard/4242293-1-expected.txt:
              * editing/pasteboard/4242293-expected.txt:
              * editing/pasteboard/4631972-expected.txt:
              * editing/pasteboard/4641033-expected.txt:
              * editing/pasteboard/4700297-expected.txt:
              * editing/pasteboard/4744008-expected.txt:
              * editing/pasteboard/8145-1-expected.txt:
              * editing/pasteboard/8145-2-expected.txt:
              * editing/pasteboard/8145-3-expected.txt:
              * editing/pasteboard/bad-placeholder-expected.txt:
              * editing/pasteboard/block-wrappers-necessary-expected.txt:
              * editing/pasteboard/copy-in-password-field-expected.txt:
              * editing/pasteboard/copy-standalone-image-expected.txt:
              * editing/pasteboard/cut-text-001-expected.txt:
              * editing/pasteboard/displaced-generic-placeholder-expected.txt:
              * editing/pasteboard/displaced-placeholder-expected.txt:
              * editing/pasteboard/display-block-on-spans-expected.txt:
              * editing/pasteboard/drag-drop-modifies-page-expected.txt:
              * editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
              * editing/pasteboard/drop-link-expected.txt:
              * editing/pasteboard/emacs-cntl-y-001-expected.txt:
              * editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
              * editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
              * editing/pasteboard/interchange-newline-1-expected.txt:
              * editing/pasteboard/interchange-newline-2-expected.txt:
              * editing/pasteboard/interchange-newline-3-expected.txt:
              * editing/pasteboard/interchange-newline-4-expected.txt:
              * editing/pasteboard/merge-after-delete-1-expected.txt:
              * editing/pasteboard/merge-after-delete-2-expected.txt:
              * editing/pasteboard/merge-after-delete-expected.txt:
              * editing/pasteboard/merge-end-3-expected.txt:
              * editing/pasteboard/merge-end-4-expected.txt:
              * editing/pasteboard/merge-end-5-expected.txt:
              * editing/pasteboard/merge-end-blockquote-expected.txt:
              * editing/pasteboard/merge-end-borders-expected.txt:
              * editing/pasteboard/merge-end-list-expected.txt:
              * editing/pasteboard/merge-end-table-expected.txt:
              * editing/pasteboard/merge-start-blockquote-expected.txt:
              * editing/pasteboard/merge-start-list-expected.txt:
              * editing/pasteboard/nested-blocks-with-text-area-expected.txt:
              * editing/pasteboard/nested-blocks-with-text-field-expected.txt:
              * editing/pasteboard/paste-4035648-fix-expected.txt:
              * editing/pasteboard/paste-4038267-fix-expected.txt:
              * editing/pasteboard/paste-4039777-fix-expected.txt:
              * editing/pasteboard/paste-RTFD-expected.txt:
              * editing/pasteboard/paste-TIFF-expected.txt:
              * editing/pasteboard/paste-line-endings-001-expected.txt:
              * editing/pasteboard/paste-line-endings-002-expected.txt:
              * editing/pasteboard/paste-line-endings-003-expected.txt:
              * editing/pasteboard/paste-line-endings-004-expected.txt:
              * editing/pasteboard/paste-line-endings-005-expected.txt:
              * editing/pasteboard/paste-line-endings-006-expected.txt:
              * editing/pasteboard/paste-line-endings-007-expected.txt:
              * editing/pasteboard/paste-line-endings-008-expected.txt:
              * editing/pasteboard/paste-line-endings-009-expected.txt:
              * editing/pasteboard/paste-line-endings-010-expected.txt:
              * editing/pasteboard/paste-list-001-expected.txt:
              * editing/pasteboard/paste-match-style-001-expected.txt:
              * editing/pasteboard/paste-match-style-002-expected.txt:
              * editing/pasteboard/paste-pre-001-expected.txt:
              * editing/pasteboard/paste-pre-002-expected.txt:
              * editing/pasteboard/paste-table-001-expected.txt:
              * editing/pasteboard/paste-table-002-expected.txt:
              * editing/pasteboard/paste-table-003-expected.txt:
              * editing/pasteboard/paste-text-001-expected.txt:
              * editing/pasteboard/paste-text-002-expected.txt:
              * editing/pasteboard/paste-text-003-expected.txt:
              * editing/pasteboard/paste-text-004-expected.txt:
              * editing/pasteboard/paste-text-005-expected.txt:
              * editing/pasteboard/paste-text-006-expected.txt:
              * editing/pasteboard/paste-text-007-expected.txt:
              * editing/pasteboard/paste-text-008-expected.txt:
              * editing/pasteboard/paste-text-009-expected.txt:
              * editing/pasteboard/paste-text-010-expected.txt:
              * editing/pasteboard/paste-text-011-expected.txt:
              * editing/pasteboard/paste-text-012-expected.txt:
              * editing/pasteboard/paste-text-013-expected.txt:
              * editing/pasteboard/paste-text-014-expected.txt:
              * editing/pasteboard/paste-text-015-expected.txt:
              * editing/pasteboard/paste-text-016-expected.txt:
              * editing/pasteboard/paste-text-017-expected.txt:
              * editing/pasteboard/paste-text-018-expected.txt:
              * editing/pasteboard/paste-text-019-expected.txt:
              * editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
              * editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
              * editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
              * editing/pasteboard/paste-xml-expected.txt:
              * editing/pasteboard/pasting-object-expected.txt:
              * editing/pasteboard/pasting-tabs-expected.txt:
              * editing/pasteboard/prevent-block-nesting-01-expected.txt:
              * editing/pasteboard/quirks-mode-br-1-expected.txt:
              * editing/pasteboard/quirks-mode-br-2-expected.txt:
              * editing/pasteboard/smart-paste-001-expected.txt:
              * editing/pasteboard/smart-paste-002-expected.txt:
              * editing/pasteboard/smart-paste-003-expected.txt:
              * editing/pasteboard/smart-paste-004-expected.txt:
              * editing/pasteboard/smart-paste-005-expected.txt:
              * editing/pasteboard/smart-paste-006-expected.txt:
              * editing/pasteboard/smart-paste-007-expected.txt:
              * editing/pasteboard/smart-paste-008-expected.txt:
              * editing/pasteboard/styled-element-markup-expected.txt:
              * editing/pasteboard/subframe-dragndrop-1-expected.txt:
              * editing/pasteboard/testcase-9507-expected.txt:
              * editing/pasteboard/undoable-fragment-removes-expected.txt:
              * editing/pasteboard/unrendered-br-expected.txt:
              * editing/selection/3690703-2-expected.txt:
              * editing/selection/3690703-expected.txt:
              * editing/selection/3690719-expected.txt:
              * editing/selection/4397952-expected.txt:
              * editing/selection/4932260-1-expected.txt:
              * editing/selection/4932260-2-expected.txt:
              * editing/selection/4932260-3-expected.txt:
              * editing/selection/4947387-expected.txt:
              * editing/selection/6476-expected.txt:
              * editing/selection/7152-1-expected.txt:
              * editing/selection/7152-2-expected.txt:
              * editing/selection/after-line-wrap-expected.txt:
              * editing/selection/caret-rtl-2-expected.txt:
              * editing/selection/caret-rtl-expected.txt:
              * editing/selection/click-before-and-after-table-expected.txt:
              * editing/selection/click-start-of-line-expected.txt:
              * editing/selection/designmode-no-caret-expected.txt:
              * editing/selection/editable-links-expected.txt:
              * editing/selection/editable-non-editable-crash-expected.txt:
              * editing/selection/end-of-document-expected.txt:
              * editing/selection/expanding-selections-expected.txt:
              * editing/selection/expanding-selections2-expected.txt:
              * editing/selection/extend-by-character-001-expected.txt:
              * editing/selection/extend-by-character-002-expected.txt:
              * editing/selection/extend-by-character-003-expected.txt:
              * editing/selection/extend-by-character-004-expected.txt:
              * editing/selection/extend-by-character-005-expected.txt:
              * editing/selection/extend-by-character-006-expected.txt:
              * editing/selection/extend-by-sentence-001-expected.txt:
              * editing/selection/extend-by-word-001-expected.txt:
              * editing/selection/extend-by-word-002-expected.txt:
              * editing/selection/fake-doubleclick-expected.txt:
              * editing/selection/fake-drag-expected.txt:
              * editing/selection/iframe-expected.txt:
              * editing/selection/image-before-linebreak-expected.txt:
              * editing/selection/inline-table-expected.txt:
              * editing/selection/leave-requested-block-expected.txt:
              * editing/selection/mixed-editability-1-expected.txt:
              * editing/selection/mixed-editability-3-expected.txt:
              * editing/selection/mixed-editability-4-expected.txt:
              * editing/selection/mixed-editability-5-expected.txt:
              * editing/selection/move-3875618-fix-expected.txt:
              * editing/selection/move-3875641-fix-expected.txt:
              * editing/selection/move-backwords-by-word-001-expected.txt:
              * editing/selection/move-between-blocks-no-001-expected.txt:
              * editing/selection/move-between-blocks-yes-001-expected.txt:
              * editing/selection/move-by-character-001-expected.txt:
              * editing/selection/move-by-character-002-expected.txt:
              * editing/selection/move-by-character-003-expected.txt:
              * editing/selection/move-by-character-004-expected.txt:
              * editing/selection/move-by-character-005-expected.txt:
              * editing/selection/move-by-character-6-expected.txt:
              * editing/selection/move-by-line-001-expected.txt:
              * editing/selection/move-by-line-002-expected.txt:
              * editing/selection/move-by-word-001-expected.txt:
              * editing/selection/previous-line-position-expected.txt:
              * editing/selection/replace-selection-1-expected.txt:
              * editing/selection/replaced-boundaries-1-expected.txt:
              * editing/selection/replaced-boundaries-2-expected.txt:
              * editing/selection/replaced-boundaries-3-expected.txt:
              * editing/selection/select-all-001-expected.txt:
              * editing/selection/select-all-002-expected.txt:
              * editing/selection/select-all-003-expected.txt:
              * editing/selection/select-all-004-expected.txt:
              * editing/selection/select-all-005-expected.txt:
              * editing/selection/select-all-006-expected.txt:
              * editing/selection/select-all-iframe-expected.txt:
              * editing/selection/select-box-expected.txt:
              * editing/selection/select-element-paragraph-boundary-expected.txt:
              * editing/selection/select-missing-image-expected.txt:
              * editing/selection/selection-3748164-fix-expected.txt:
              * editing/selection/skip-non-editable-1-expected.txt:
              * editing/selection/skip-non-editable-2-expected.txt:
              * editing/selection/table-caret-1-expected.txt:
              * editing/selection/table-caret-2-expected.txt:
              * editing/selection/table-caret-3-expected.txt:
              * editing/selection/triple-click-in-pre-expected.txt:
              * editing/selection/unrendered-001-expected.txt:
              * editing/selection/unrendered-002-expected.txt:
              * editing/selection/unrendered-003-expected.txt:
              * editing/selection/unrendered-004-expected.txt:
              * editing/selection/unrendered-005-expected.txt:
              * editing/selection/unrendered-space-expected.txt:
              * editing/spelling/spelling-expected.txt:
              * editing/style/apple-style-editable-mix-expected.txt:
              * editing/style/block-style-001-expected.txt:
              * editing/style/block-style-002-expected.txt:
              * editing/style/block-style-003-expected.txt:
              * editing/style/block-style-004-expected.txt:
              * editing/style/block-style-005-expected.txt:
              * editing/style/block-style-006-expected.txt:
              * editing/style/block-styles-007-expected.txt:
              * editing/style/create-block-for-style-001-expected.txt:
              * editing/style/create-block-for-style-002-expected.txt:
              * editing/style/create-block-for-style-003-expected.txt:
              * editing/style/create-block-for-style-004-expected.txt:
              * editing/style/create-block-for-style-005-expected.txt:
              * editing/style/create-block-for-style-006-expected.txt:
              * editing/style/create-block-for-style-007-expected.txt:
              * editing/style/create-block-for-style-008-expected.txt:
              * editing/style/create-block-for-style-009-expected.txt:
              * editing/style/create-block-for-style-010-expected.txt:
              * editing/style/create-block-for-style-011-expected.txt:
              * editing/style/create-block-for-style-012-expected.txt:
              * editing/style/create-block-for-style-013-expected.txt:
              * editing/style/designmode-expected.txt:
              * editing/style/non-inheritable-styles-expected.txt:
              * editing/style/relative-font-size-change-001-expected.txt:
              * editing/style/relative-font-size-change-002-expected.txt:
              * editing/style/relative-font-size-change-003-expected.txt:
              * editing/style/relative-font-size-change-004-expected.txt:
              * editing/style/remove-underline-across-paragraph-expected.txt:
              * editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
              * editing/style/remove-underline-after-paragraph-expected.txt:
              * editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
              * editing/style/remove-underline-expected.txt:
              * editing/style/remove-underline-from-stylesheet-expected.txt:
              * editing/style/remove-underline-in-bold-expected.txt:
              * editing/style/smoosh-styles-001-expected.txt:
              * editing/style/smoosh-styles-002-expected.txt:
              * editing/style/smoosh-styles-003-expected.txt:
              * editing/style/style-3681552-fix-001-expected.txt:
              * editing/style/style-3681552-fix-002-expected.txt:
              * editing/style/style-3690704-fix-expected.txt:
              * editing/style/style-3998892-fix-expected.txt:
              * editing/style/style-boundary-001-expected.txt:
              * editing/style/style-boundary-002-expected.txt:
              * editing/style/style-boundary-003-expected.txt:
              * editing/style/style-boundary-004-expected.txt:
              * editing/style/style-boundary-005-expected.txt:
              * editing/style/table-selection-expected.txt:
              * editing/style/typing-style-001-expected.txt:
              * editing/style/typing-style-002-expected.txt:
              * editing/style/typing-style-003-expected.txt:
              * editing/style/unbold-in-bold-expected.txt:
              * editing/style/underline-expected.txt:
              * editing/undo/4063751-expected.txt:
              * editing/undo/redo-typing-001-expected.txt:
              * editing/undo/undo-iframe-location-change-expected.txt:
              * editing/undo/undo-misspellings-expected.txt:
              * editing/undo/undo-typing-001-expected.txt:
              * editing/unsupported-content/list-delete-001-expected.txt:
              * editing/unsupported-content/list-delete-002-expected.txt:
              * editing/unsupported-content/list-delete-003-expected.txt:
              * editing/unsupported-content/list-type-after-expected.txt:
              * editing/unsupported-content/list-type-before-expected.txt:
              * editing/unsupported-content/table-delete-001-expected.txt:
              * editing/unsupported-content/table-delete-002-expected.txt:
              * editing/unsupported-content/table-delete-003-expected.txt:
              * editing/unsupported-content/table-type-after-expected.txt:
              * editing/unsupported-content/table-type-before-expected.txt:
              * fast/forms/focus-selection-input-expected.txt:
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=13291
                REGRESSION (r19595): WebViewDidBeginEditingNotification not posted when focusing with the mouse
      
              Covered by editing tests.
      
              * dom/Document.cpp:
              (WebCore::Document::setFocusedNode): Moved the call to Editor::didBeginEditing()
              back into here.
              * dom/Element.cpp:
              (WebCore::Element::updateFocusAppearance): Removed the call to didBeginEditing().
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::updateFocusAppearance): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28ce873d
  4. 03 Apr, 2007 1 commit
    • justing's avatar
      LayoutTests: · d9d6f5d8
      justing authored
              Reviewed by darin
              
              <rdar://problem/5107422> 
              TOT REGRESSION: Delete key fails to delete text, and cursor disappears in Mail.app
      
              moveParagraphs no longer calls shouldInsert:
              * editing/deleting/delete-3857753-fix-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
              * editing/deleting/delete-block-merge-contents-001-expected.txt:
              * editing/deleting/delete-block-merge-contents-002-expected.txt:
              * editing/deleting/delete-block-merge-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-004-expected.txt:
              * editing/deleting/delete-block-merge-contents-005-expected.txt:
              * editing/deleting/delete-block-merge-contents-006-expected.txt:
              * editing/deleting/delete-block-merge-contents-007-expected.txt:
              * editing/deleting/delete-block-merge-contents-008-expected.txt:
              * editing/deleting/delete-block-merge-contents-009-expected.txt:
              * editing/deleting/delete-block-merge-contents-010-expected.txt:
              * editing/deleting/delete-block-merge-contents-012-expected.txt:
              * editing/deleting/delete-block-merge-contents-013-expected.txt:
              * editing/deleting/delete-block-merge-contents-014-expected.txt:
              * editing/deleting/delete-block-merge-contents-015-expected.txt:
              * editing/deleting/delete-block-merge-contents-016-expected.txt:
              * editing/deleting/delete-block-merge-contents-017-expected.txt:
              * editing/deleting/delete-block-merge-contents-018-expected.txt:
              * editing/deleting/delete-block-merge-contents-019-expected.txt:
              * editing/deleting/delete-block-merge-contents-020-expected.txt:
              * editing/deleting/delete-block-merge-contents-021-expected.txt:
              * editing/deleting/delete-block-merge-contents-022-expected.txt:
              * editing/deleting/delete-block-table-expected.txt:
              * editing/deleting/delete-br-010-expected.txt:
              * editing/deleting/delete-line-002-expected.txt:
              * editing/deleting/delete-line-004-expected.txt:
              * editing/deleting/delete-line-006-expected.txt:
              * editing/deleting/delete-line-007-expected.txt:
              * editing/deleting/delete-line-008-expected.txt:
              * editing/deleting/delete-line-011-expected.txt:
              * editing/deleting/delete-line-012-expected.txt:
              * editing/deleting/delete-listitem-001-expected.txt:
              * editing/deleting/delete-to-end-of-paragraph-expected.txt:
              * editing/deleting/merge-different-styles-expected.txt:
              * editing/deleting/merge-no-br-expected.txt:
              * editing/deleting/pruning-after-merge-1-expected.txt:
              * editing/deleting/pruning-after-merge-2-expected.txt:
              * editing/execCommand/create-list-from-range-selection-expected.txt:
              * editing/execCommand/create-list-with-hr-expected.txt:
              * editing/execCommand/format-block-expected.txt:
              * editing/execCommand/format-block-from-range-selection-expected.txt:
              * editing/execCommand/format-block-with-braces-expected.txt:
              * editing/execCommand/format-block-with-trailing-br-expected.txt:
              * editing/execCommand/indent-list-item-expected.txt:
              * editing/execCommand/indent-selection-expected.txt:
              * editing/execCommand/insert-list-and-stitch-expected.txt:
              * editing/execCommand/insert-list-with-id-expected.txt:
              * editing/execCommand/nsresponder-indent-expected.txt:
              * editing/execCommand/outdent-selection-expected.txt:
              * editing/execCommand/queryCommandState-01-expected.txt:
              * editing/execCommand/remove-list-1-expected.txt:
              * editing/execCommand/remove-list-from-range-selection-expected.txt:
              * editing/execCommand/remove-list-item-1-expected.txt:
              * editing/execCommand/remove-list-items-expected.txt:
              * editing/execCommand/switch-list-type-expected.txt:
              * editing/inserting/insert-3907422-fix-expected.txt:
              * editing/inserting/insert-div-026-expected.txt:
              * editing/inserting/multiple-lines-selected-expected.txt:
              * editing/inserting/return-key-with-selection-001-expected.txt:
              * editing/inserting/return-key-with-selection-002-expected.txt:
              * editing/pasteboard/4076267-2-expected.txt:
              * editing/pasteboard/4700297-expected.txt:
              * editing/pasteboard/8145-3-expected.txt:
              * editing/pasteboard/display-block-on-spans-expected.txt:
              * editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
              * editing/pasteboard/interchange-newline-1-expected.txt:
              * editing/pasteboard/interchange-newline-2-expected.txt:
              * editing/pasteboard/merge-after-delete-1-expected.txt:
              * editing/pasteboard/merge-after-delete-2-expected.txt:
              * editing/pasteboard/merge-after-delete-expected.txt:
              * editing/pasteboard/merge-end-1-expected.txt:
              * editing/pasteboard/merge-end-2-expected.txt:
              * editing/pasteboard/merge-end-3-expected.txt:
              * editing/pasteboard/merge-end-4-expected.txt:
              * editing/pasteboard/merge-end-5-expected.txt:
              * editing/pasteboard/merge-end-blockquote-expected.txt:
              * editing/pasteboard/merge-end-borders-expected.txt:
              * editing/pasteboard/merge-end-list-expected.txt:
              * editing/pasteboard/merge-end-table-expected.txt:
              * editing/pasteboard/paste-line-endings-007-expected.txt:
              * editing/pasteboard/paste-line-endings-008-expected.txt:
              * editing/pasteboard/paste-line-endings-009-expected.txt:
              * editing/pasteboard/paste-match-style-001-expected.txt:
              * editing/pasteboard/paste-text-002-expected.txt:
              * editing/pasteboard/paste-text-003-expected.txt:
              * editing/pasteboard/paste-text-004-expected.txt:
              * editing/pasteboard/paste-text-005-expected.txt:
              * editing/pasteboard/paste-text-006-expected.txt:
              * editing/pasteboard/paste-text-008-expected.txt:
              * editing/pasteboard/paste-text-009-expected.txt:
              * editing/pasteboard/paste-text-010-expected.txt:
              * editing/pasteboard/smart-paste-001-expected.txt:
              * editing/pasteboard/smart-paste-002-expected.txt:
              * editing/pasteboard/smart-paste-003-expected.txt:
              * editing/pasteboard/smart-paste-004-expected.txt:
              * editing/pasteboard/smart-paste-005-expected.txt:
              * editing/pasteboard/smart-paste-006-expected.txt:
              * editing/pasteboard/smart-paste-007-expected.txt:
              * editing/pasteboard/smart-paste-008-expected.txt:
              * editing/style/create-block-for-style-001-expected.txt:
              * editing/style/create-block-for-style-002-expected.txt:
              * editing/style/create-block-for-style-003-expected.txt:
              * editing/style/create-block-for-style-004-expected.txt:
              * editing/style/create-block-for-style-007-expected.txt:
              * editing/style/create-block-for-style-009-expected.txt:
              * editing/style/create-block-for-style-010-expected.txt:
              * editing/style/create-block-for-style-011-expected.txt:
              * editing/style/create-block-for-style-012-expected.txt:
              * editing/style/create-block-for-style-013-expected.txt:
              * editing/style/smoosh-styles-001-expected.txt:
              * editing/style/smoosh-styles-002-expected.txt:
              * editing/style/style-boundary-005-expected.txt:
              * editing/unsupported-content/list-delete-001-expected.txt:
      
      WebCore:
      
              Reviewed by darin
              
              <rdar://problem/5107422> 
              TOT REGRESSION: Delete key fails to delete text, and cursor disappears in Mail.app
              <rdar://problem/5107413> 
              TOT REGRESSION: Crash deleting text in email (infinite recursion in shouldInsertNode)
      
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::moveParagraphs):
              Back out the call to shouldInsert until we
              add WebViewInsertActionMoved, because Mail returns
              NO from shouldInsert for WebViewInsertActionPasted
              to override our Paste operation.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d9d6f5d8
  5. 29 Mar, 2007 1 commit
    • justing's avatar
      LayoutTests: · b7701503
      justing authored
              Reviewed by john
      
              <rdar://problem/5032066> <Delete> should work between To Dos
      
              Demonstrates the fix:
              * editing/deleting/5032066-expected.checksum: Added.
              * editing/deleting/5032066-expected.png: Added.
              * editing/deleting/5032066-expected.txt: Added.
              * editing/deleting/5032066.html: Added.
              
              Fixed:
              * editing/deleting/delete-block-table-expected.checksum:
              * editing/deleting/delete-block-table-expected.png:
              * editing/deleting/delete-block-table-expected.txt:
              
              shouldInsertNode:... now being called during moves:
              * editing/deleting/delete-3857753-fix-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
              * editing/deleting/delete-block-merge-contents-001-expected.txt:
              * editing/deleting/delete-block-merge-contents-002-expected.txt:
              * editing/deleting/delete-block-merge-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-004-expected.txt:
              * editing/deleting/delete-block-merge-contents-005-expected.txt:
              * editing/deleting/delete-block-merge-contents-006-expected.txt:
              * editing/deleting/delete-block-merge-contents-007-expected.txt:
              * editing/deleting/delete-block-merge-contents-008-expected.txt:
              * editing/deleting/delete-block-merge-contents-009-expected.txt:
              * editing/deleting/delete-block-merge-contents-010-expected.txt:
              * editing/deleting/delete-block-merge-contents-012-expected.txt:
              * editing/deleting/delete-block-merge-contents-013-expected.txt:
              * editing/deleting/delete-block-merge-contents-014-expected.txt:
              * editing/deleting/delete-block-merge-contents-015-expected.txt:
              * editing/deleting/delete-block-merge-contents-016-expected.txt:
              * editing/deleting/delete-block-merge-contents-017-expected.txt:
              * editing/deleting/delete-block-merge-contents-018-expected.txt:
              * editing/deleting/delete-block-merge-contents-019-expected.txt:
              * editing/deleting/delete-block-merge-contents-020-expected.txt:
              * editing/deleting/delete-block-merge-contents-021-expected.txt:
              * editing/deleting/delete-block-merge-contents-022-expected.txt:
              * editing/deleting/delete-br-010-expected.txt:
              * editing/deleting/delete-line-002-expected.txt:
              * editing/deleting/delete-line-004-expected.txt:
              * editing/deleting/delete-line-006-expected.txt:
              * editing/deleting/delete-line-007-expected.txt:
              * editing/deleting/delete-line-008-expected.txt:
              * editing/deleting/delete-line-011-expected.txt:
              * editing/deleting/delete-line-012-expected.txt:
              * editing/deleting/delete-listitem-001-expected.txt:
              * editing/deleting/delete-to-end-of-paragraph-expected.txt:
              * editing/deleting/merge-different-styles-expected.txt:
              * editing/deleting/merge-no-br-expected.txt:
              * editing/deleting/pruning-after-merge-1-expected.txt:
              * editing/deleting/pruning-after-merge-2-expected.txt:
              * editing/execCommand/create-list-from-range-selection-expected.txt:
              * editing/execCommand/create-list-with-hr-expected.txt:
              * editing/execCommand/format-block-expected.txt:
              * editing/execCommand/format-block-from-range-selection-expected.txt:
              * editing/execCommand/format-block-with-braces-expected.txt:
              * editing/execCommand/format-block-with-trailing-br-expected.txt:
              * editing/execCommand/indent-list-item-expected.txt:
              * editing/execCommand/indent-selection-expected.txt:
              * editing/execCommand/insert-list-and-stitch-expected.txt:
              * editing/execCommand/insert-list-with-id-expected.txt:
              * editing/execCommand/nsresponder-indent-expected.txt:
              * editing/execCommand/outdent-selection-expected.txt:
              * editing/execCommand/queryCommandState-01-expected.txt:
              * editing/execCommand/remove-list-1-expected.txt:
              * editing/execCommand/remove-list-from-range-selection-expected.txt:
              * editing/execCommand/remove-list-item-1-expected.txt:
              * editing/execCommand/remove-list-items-expected.txt:
              * editing/execCommand/switch-list-type-expected.txt:
              * editing/inserting/insert-3907422-fix-expected.txt:
              * editing/inserting/insert-div-026-expected.txt:
              * editing/inserting/multiple-lines-selected-expected.txt:
              * editing/inserting/return-key-with-selection-001-expected.txt:
              * editing/inserting/return-key-with-selection-002-expected.txt:
              * editing/pasteboard/4076267-2-expected.txt:
              * editing/pasteboard/4700297-expected.txt:
              * editing/pasteboard/8145-3-expected.txt:
              * editing/pasteboard/display-block-on-spans-expected.txt:
              * editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
              * editing/pasteboard/interchange-newline-1-expected.txt:
              * editing/pasteboard/interchange-newline-2-expected.txt:
              * editing/pasteboard/merge-after-delete-1-expected.txt:
              * editing/pasteboard/merge-after-delete-2-expected.txt:
              * editing/pasteboard/merge-after-delete-expected.txt:
              * editing/pasteboard/merge-end-1-expected.txt:
              * editing/pasteboard/merge-end-2-expected.txt:
              * editing/pasteboard/merge-end-3-expected.txt:
              * editing/pasteboard/merge-end-4-expected.txt:
              * editing/pasteboard/merge-end-5-expected.txt:
              * editing/pasteboard/merge-end-blockquote-expected.txt:
              * editing/pasteboard/merge-end-borders-expected.txt:
              * editing/pasteboard/merge-end-list-expected.txt:
              * editing/pasteboard/merge-end-table-expected.txt:
              * editing/pasteboard/paste-line-endings-007-expected.txt:
              * editing/pasteboard/paste-line-endings-008-expected.txt:
              * editing/pasteboard/paste-line-endings-009-expected.txt:
              * editing/pasteboard/paste-match-style-001-expected.txt:
              * editing/pasteboard/paste-text-002-expected.txt:
              * editing/pasteboard/paste-text-003-expected.txt:
              * editing/pasteboard/paste-text-004-expected.txt:
              * editing/pasteboard/paste-text-005-expected.txt:
              * editing/pasteboard/paste-text-006-expected.txt:
              * editing/pasteboard/paste-text-008-expected.txt:
              * editing/pasteboard/paste-text-009-expected.txt:
              * editing/pasteboard/paste-text-010-expected.txt:
              * editing/pasteboard/smart-paste-001-expected.txt:
              * editing/pasteboard/smart-paste-002-expected.txt:
              * editing/pasteboard/smart-paste-003-expected.txt:
              * editing/pasteboard/smart-paste-004-expected.txt:
              * editing/pasteboard/smart-paste-005-expected.txt:
              * editing/pasteboard/smart-paste-006-expected.txt:
              * editing/pasteboard/smart-paste-007-expected.txt:
              * editing/pasteboard/smart-paste-008-expected.txt:
              * editing/style/create-block-for-style-001-expected.txt:
              * editing/style/create-block-for-style-002-expected.txt:
              * editing/style/create-block-for-style-003-expected.txt:
              * editing/style/create-block-for-style-004-expected.txt:
              * editing/style/create-block-for-style-007-expected.txt:
              * editing/style/create-block-for-style-009-expected.txt:
              * editing/style/create-block-for-style-010-expected.txt:
              * editing/style/create-block-for-style-011-expected.txt:
              * editing/style/create-block-for-style-012-expected.txt:
              * editing/style/create-block-for-style-013-expected.txt:
              * editing/style/smoosh-styles-001-expected.txt:
              * editing/style/smoosh-styles-002-expected.txt:
              * editing/style/style-boundary-005-expected.txt:
              * editing/unsupported-content/list-delete-001-expected.txt:
      
      WebCore:
      
              Reviewed by john
      
              <rdar://problem/5032066> Delete should work between ToDos
              
              Stop selecting the table when the user attempts to delete
              the line break just after it, instead, extend the selection
              into the last table cell.
              Let deletion merge content into table cells (as long as 
              its not from another table cell).  
              Start calling shouldInsertNode:replacingDOMRange:givenAction: 
              when moving content with moveParagraphs, so that Mail can 
              modify content before it is moved into a ToDo during a delete.
      
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::moveParagraphs): Ask the
              delegate before performing the move.  This will let Mail
              prevent styles from entering a ToDo.
              Added a FIXME about adding a new WebViewInsertAction
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializePositionData):
              Allow merging into table cells from content not in a table.
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::modifyExtendingRightForward):
              Don't select the table when extending by character/word from
              just before it.  This code was here to make it easier to select
              tables in order to delete them, but the deletion UI makes it 
              largely unnecessary.
              (WebCore::SelectionController::modifyExtendingLeftBackward):
              Ditto.
              * editing/TypingCommand.cpp:
              (WebCore::isFirstPositionAfterTable): Added.
              (WebCore::isLastPositionBeforeTable): Ditto.
              (WebCore::TypingCommand::deleteKeyPressed): When pressing
              the delete key with a caret at the beginning of a paragraph
              just after a table, move the paragraph into the last table
              cell.
              Do not do this if it would mean moving a block table.
              Removed some old irrelevant comments.
              * editing/htmlediting.cpp: Removed unused functions.
              * editing/htmlediting.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7701503
  6. 13 Feb, 2007 1 commit
    • darin's avatar
      - update test results for Hyatt's focus node enhancement (fix for 12149) · e20f1beb
      darin authored
                518 of tests had extra "begin editing" delegate callbacks.
      
              * editing: Updated test results of many tests in this directory.
      
              - removed tests for rolled-out fix for rdar://problem/4922454
      
              * http/tests/security/local-JavaScript-from-remote-expected.txt: Removed.
              * http/tests/security/local-JavaScript-from-remote.html: Removed.
              * http/tests/security/local-iFrame-from-remote-expected.txt: Removed.
              * http/tests/security/local-iFrame-from-remote.html: Removed.
              * http/tests/security/local-image-from-remote-expected.txt: Removed.
              * http/tests/security/local-image-from-remote.html: Removed.
              * http/tests/security/resources/compass.jpg: Removed.
              * http/tests/security/resources/green250x50.png: Removed.
              * http/tests/security/resources/localPage.html: Removed.
              * http/tests/security/resources/localScript.js: Removed.
              * http/tests/security/resources/red200x100.png: Removed.
              * http/tests/security/resources/showRefererImage.php: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@19605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e20f1beb
  7. 02 Nov, 2006 1 commit
    • ggaren's avatar
      LayoutTests: · f38d7c7b
      ggaren authored
              Reviewed by Justin Garcia.
              
              Used a PERL script to add calls to opt into dumping of editing callbacks
              in all editing tests that didn't do so already. This is required now that 
              dumping of editing callbacks is opt-in.
              
              Updated editing.js so that any test that calls runEditingTest() opt into
              dumping of editing callbacks.
              
              Updated results in all non-editing tests to remove dumping of editing callbacks.
              
              Updated results in all editing tests to reflect minor DOM changes due to new
              <script> elements.
              
              [ many tests and results modified ]
      
      WebKitTools:
      
              Reviewed by Justin Garcia.
              
              Made dumping of editing callbacks opt-in, so that editing spew doesn't 
              cloud non-editing tests.
      
              * DumpRenderTree/DumpRenderTree.m:
              (+[LayoutTestController isSelectorExcludedFromWebScript:]):
              (-[LayoutTestController shouldDumpEditingCallbacks]):
              (runTest):
              * DumpRenderTree/EditingDelegate.m:
              (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]):
              (-[EditingDelegate webView:shouldEndEditingInDOMRange:]):
              (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]):
              (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]):
              (-[EditingDelegate webView:shouldDeleteDOMRange:]):
              (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]):
              (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]):
              (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]):
              (-[EditingDelegate webViewDidBeginEditing:]):
              (-[EditingDelegate webViewDidChange:]):
              (-[EditingDelegate webViewDidEndEditing:]):
              (-[EditingDelegate webViewDidChangeTypingStyle:]):
              (-[EditingDelegate webViewDidChangeSelection:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@17562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f38d7c7b
  8. 05 Sep, 2006 1 commit
    • justing's avatar
      LayoutTests: · 397edaa4
      justing authored
              Reviewed by thatcher
              
              Setup for <rdar://problem/4344550> Misspellings aren't marked after undo delete
      
              Fixed:
              * editing/pasteboard/4641033-expected.checksum:
              * editing/pasteboard/4641033-expected.png:
              * editing/execCommand/outdent-selection-expected.checksum:
              * editing/execCommand/outdent-selection-expected.png:
      
              Added a didChangeSelection notification that was absent before:
              * editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
              * editing/deleting/delete-3608430-fix-expected.txt:
              * editing/deleting/delete-3608462-fix-expected.txt:
              * editing/deleting/delete-3775172-fix-expected.txt:
              * editing/deleting/delete-3800834-fix-expected.txt:
              * editing/deleting/delete-3857753-fix-expected.txt:
              * editing/deleting/delete-3865854-fix-expected.txt:
              * editing/deleting/delete-3928305-fix-expected.txt:
              * editing/deleting/delete-3959464-fix-expected.txt:
              * editing/deleting/delete-4038408-fix-expected.txt:
              * editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
              * editing/deleting/delete-block-contents-001-expected.txt:
              * editing/deleting/delete-block-contents-002-expected.txt:
              * editing/deleting/delete-block-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-001-expected.txt:
              * editing/deleting/delete-block-merge-contents-002-expected.txt:
              * editing/deleting/delete-block-merge-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-004-expected.txt:
              * editing/deleting/delete-block-merge-contents-005-expected.txt:
              * editing/deleting/delete-block-merge-contents-006-expected.txt:
              * editing/deleting/delete-block-merge-contents-007-expected.txt:
              * editing/deleting/delete-block-merge-contents-008-expected.txt:
              * editing/deleting/delete-block-merge-contents-009-expected.txt:
              * editing/deleting/delete-block-merge-contents-010-expected.txt:
              * editing/deleting/delete-block-merge-contents-012-expected.txt:
              * editing/deleting/delete-block-merge-contents-013-expected.txt:
              * editing/deleting/delete-block-merge-contents-014-expected.txt:
              * editing/deleting/delete-block-merge-contents-015-expected.txt:
              * editing/deleting/delete-block-merge-contents-016-expected.txt:
              * editing/deleting/delete-block-merge-contents-017-expected.txt:
              * editing/deleting/delete-block-merge-contents-018-expected.txt:
              * editing/deleting/delete-block-merge-contents-019-expected.txt:
              * editing/deleting/delete-block-merge-contents-020-expected.txt:
              * editing/deleting/delete-block-merge-contents-021-expected.txt:
              * editing/deleting/delete-block-merge-contents-022-expected.txt:
              * editing/deleting/delete-block-merge-contents-023-expected.txt:
              * editing/deleting/delete-block-merge-contents-024-expected.txt:
              * editing/deleting/delete-block-table-expected.txt:
              * editing/deleting/delete-br-008-expected.txt:
              * editing/deleting/delete-br-010-expected.txt:
              * editing/deleting/delete-br-011-expected.txt:
              * editing/deleting/delete-first-list-item-expected.txt:
              * editing/deleting/delete-image-001-expected.txt:
              * editing/deleting/delete-image-002-expected.txt:
              * editing/deleting/delete-image-003-expected.txt:
              * editing/deleting/delete-image-004-expected.txt:
              * editing/deleting/delete-line-001-expected.txt:
              * editing/deleting/delete-line-002-expected.txt:
              * editing/deleting/delete-line-003-expected.txt:
              * editing/deleting/delete-line-004-expected.txt:
              * editing/deleting/delete-line-005-expected.txt:
              * editing/deleting/delete-line-006-expected.txt:
              * editing/deleting/delete-line-007-expected.txt:
              * editing/deleting/delete-line-008-expected.txt:
              * editing/deleting/delete-line-009-expected.txt:
              * editing/deleting/delete-line-010-expected.txt:
              * editing/deleting/delete-line-011-expected.txt:
              * editing/deleting/delete-line-012-expected.txt:
              * editing/deleting/delete-line-013-expected.txt:
              * editing/deleting/delete-line-014-expected.txt:
              * editing/deleting/delete-line-015-expected.txt:
              * editing/deleting/delete-line-016-expected.txt:
              * editing/deleting/delete-line-017-expected.txt:
              * editing/deleting/delete-listitem-001-expected.txt:
              * editing/deleting/delete-listitem-002-expected.txt:
              * editing/deleting/delete-mixed-editable-content-001-expected.txt:
              * editing/deleting/delete-select-all-001-expected.txt:
              * editing/deleting/delete-select-all-002-expected.txt:
              * editing/deleting/delete-select-all-003-expected.txt:
              * editing/deleting/merge-different-styles-expected.txt:
              * editing/deleting/merge-endOfParagraph-expected.txt:
              * editing/deleting/merge-no-br-expected.txt:
              * editing/deleting/pruning-after-merge-1-expected.txt:
              * editing/deleting/pruning-after-merge-2-expected.txt:
              * editing/deleting/table-cells-expected.txt:
              * editing/execCommand/boldSelection-expected.txt:
              * editing/execCommand/create-list-from-range-selection-expected.txt:
              * editing/execCommand/createLink-expected.txt:
              * editing/execCommand/format-block-expected.txt:
              * editing/execCommand/format-block-from-range-selection-expected.txt:
              * editing/execCommand/format-block-with-braces-expected.txt:
              * editing/execCommand/format-block-with-trailing-br-expected.txt:
              * editing/execCommand/hilitecolor-expected.txt:
              * editing/execCommand/indent-list-item-expected.txt:
              * editing/execCommand/indent-selection-expected.txt:
              * editing/execCommand/insert-list-and-stitch-expected.txt:
              * editing/execCommand/insert-list-with-id-expected.txt:
              * editing/execCommand/insertHTML-expected.txt:
              * editing/execCommand/insertHorizontalRule-expected.txt:
              * editing/execCommand/remove-formatting-expected.txt:
              * editing/execCommand/remove-list-from-range-selection-expected.txt:
              * editing/execCommand/remove-list-items-expected.txt:
              * editing/execCommand/strikethroughSelection-expected.txt:
              * editing/execCommand/switch-list-type-expected.txt:
              * editing/execCommand/unlink-expected.txt:
              * editing/input/text-input-controller-expected.txt:
              * editing/inserting/insert-3654864-fix-expected.txt:
              * editing/inserting/insert-3659587-fix-expected.txt:
              * editing/inserting/insert-3775316-fix-expected.txt:
              * editing/inserting/insert-3851164-fix-expected.txt:
              * editing/inserting/insert-3907422-fix-expected.txt:
              * editing/inserting/insert-after-delete-001-expected.txt:
              * editing/inserting/insert-div-001-expected.txt:
              * editing/inserting/insert-div-002-expected.txt:
              * editing/inserting/insert-div-003-expected.txt:
              * editing/inserting/insert-div-005-expected.txt:
              * editing/inserting/insert-div-007-expected.txt:
              * editing/inserting/insert-div-009-expected.txt:
              * editing/inserting/insert-div-010-expected.txt:
              * editing/inserting/insert-div-020-expected.txt:
              * editing/inserting/insert-div-023-expected.txt:
              * editing/inserting/insert-div-024-expected.txt:
              * editing/inserting/insert-div-025-expected.txt:
              * editing/inserting/insert-div-026-expected.txt:
              * editing/inserting/multiple-lines-selected-expected.txt:
              * editing/inserting/paragraph-separator-03-expected.txt:
              * editing/inserting/paragraph-separator-in-table-2-expected.txt:
              * editing/inserting/redo-expected.txt:
              * editing/inserting/return-key-with-selection-001-expected.txt:
              * editing/inserting/return-key-with-selection-002-expected.txt:
              * editing/inserting/return-key-with-selection-003-expected.txt:
              * editing/pasteboard/3976872-expected.txt:
              * editing/pasteboard/4076267-3-expected.txt:
              * editing/pasteboard/4076267-expected.txt:
              * editing/pasteboard/4700297-expected.txt:
              * editing/pasteboard/8145-3-expected.txt:
              * editing/pasteboard/block-wrappers-necessary-expected.txt:
              * editing/pasteboard/copy-paste-bidi-expected.txt:
              * editing/pasteboard/displaced-generic-placeholder-expected.txt:
              * editing/pasteboard/displaced-placeholder-expected.txt:
              * editing/pasteboard/display-block-on-spans-expected.txt:
              * editing/pasteboard/drag-drop-modifies-page-expected.txt:
              * editing/pasteboard/interchange-newline-2-expected.txt:
              * editing/pasteboard/merge-after-delete-1-expected.txt:
              * editing/pasteboard/merge-after-delete-2-expected.txt:
              * editing/pasteboard/merge-after-delete-expected.txt:
              * editing/pasteboard/merge-end-3-expected.txt:
              * editing/pasteboard/merge-end-5-expected.txt:
              * editing/pasteboard/merge-end-blockquote-expected.txt:
              * editing/pasteboard/merge-end-list-expected.txt:
              * editing/pasteboard/merge-end-table-expected.txt:
              * editing/pasteboard/paste-4035648-fix-expected.txt:
              * editing/pasteboard/paste-4039777-fix-expected.txt:
              * editing/pasteboard/paste-line-endings-001-expected.txt:
              * editing/pasteboard/paste-line-endings-006-expected.txt:
              * editing/pasteboard/paste-match-style-001-expected.txt:
              * editing/pasteboard/paste-match-style-002-expected.txt:
              * editing/pasteboard/paste-pre-001-expected.txt:
              * editing/pasteboard/paste-pre-002-expected.txt:
              * editing/pasteboard/paste-table-002-expected.txt:
              * editing/pasteboard/paste-table-003-expected.txt:
              * editing/pasteboard/paste-text-006-expected.txt:
              * editing/pasteboard/paste-text-007-expected.txt:
              * editing/pasteboard/paste-text-010-expected.txt:
              * editing/pasteboard/paste-text-011-expected.txt:
              * editing/pasteboard/paste-text-015-expected.txt:
              * editing/pasteboard/paste-text-016-expected.txt:
              * editing/pasteboard/paste-text-017-expected.txt:
              * editing/pasteboard/paste-text-018-expected.txt:
              * editing/pasteboard/prevent-block-nesting-01-expected.txt:
              * editing/pasteboard/smart-paste-003-expected.txt:
              * editing/pasteboard/smart-paste-004-expected.txt:
              * editing/pasteboard/smart-paste-005-expected.txt:
              * editing/pasteboard/smart-paste-006-expected.txt:
              * editing/pasteboard/smart-paste-007-expected.txt:
              * editing/pasteboard/smart-paste-008-expected.txt:
              * editing/pasteboard/testcase-9507-expected.txt:
              * editing/pasteboard/undoable-fragment-removes-expected.txt:
              * editing/selection/expanding-selections-expected.txt:
              * editing/selection/expanding-selections2-expected.txt:
              * editing/selection/node-removal-1-expected.txt:
              * editing/selection/node-removal-2-expected.txt:
              * editing/selection/select-all-iframe-expected.txt:
              * editing/selection/skip-non-editable-1-expected.txt:
              * editing/selection/triple-click-in-pre-expected.txt:
              * editing/style/apple-style-editable-mix-expected.txt:
              * editing/style/block-style-004-expected.txt:
              * editing/style/block-style-005-expected.txt:
              * editing/style/block-style-006-expected.txt:
              * editing/style/create-block-for-style-001-expected.txt:
              * editing/style/create-block-for-style-002-expected.txt:
              * editing/style/create-block-for-style-003-expected.txt:
              * editing/style/create-block-for-style-004-expected.txt:
              * editing/style/create-block-for-style-007-expected.txt:
              * editing/style/create-block-for-style-009-expected.txt:
              * editing/style/create-block-for-style-010-expected.txt:
              * editing/style/create-block-for-style-011-expected.txt:
              * editing/style/create-block-for-style-012-expected.txt:
              * editing/style/create-block-for-style-013-expected.txt:
              * editing/style/designmode-expected.txt:
              * editing/style/relative-font-size-change-001-expected.txt:
              * editing/style/relative-font-size-change-002-expected.txt:
              * editing/style/remove-underline-across-paragraph-expected.txt:
              * editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
              * editing/style/remove-underline-after-paragraph-expected.txt:
              * editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
              * editing/style/remove-underline-from-stylesheet-expected.txt:
              * editing/style/smoosh-styles-001-expected.txt:
              * editing/style/smoosh-styles-002-expected.txt:
              * editing/style/smoosh-styles-003-expected.txt:
              * editing/style/style-3681552-fix-001-expected.txt:
              * editing/style/style-3681552-fix-002-expected.txt:
              * editing/style/style-3690704-fix-expected.txt:
              * editing/style/style-3998892-fix-expected.txt:
              * editing/style/style-boundary-001-expected.txt:
              * editing/style/style-boundary-003-expected.txt:
              * editing/style/style-boundary-004-expected.txt:
              * editing/style/typing-style-001-expected.txt:
              * editing/style/typing-style-003-expected.txt:
              * editing/undo/undo-misspellings-expected.txt:
              * editing/unsupported-content/list-delete-001-expected.txt:
              * editing/unsupported-content/list-delete-002-expected.txt:
              * editing/unsupported-content/list-delete-003-expected.txt:
              * editing/unsupported-content/table-delete-001-expected.txt:
              * editing/unsupported-content/table-delete-002-expected.txt:
              * editing/unsupported-content/table-delete-003-expected.txt:
              * fast/forms/attributed-strings-expected.txt:
              * fast/forms/cursor-position-expected.txt:
              * fast/forms/drag-into-textarea-expected.txt:
              * fast/forms/input-appearance-maxlength-expected.txt:
              * fast/forms/input-paste-undo-expected.txt:
              * fast/forms/input-selection-restore-expected.txt:
              * fast/forms/input-text-paste-maxlength-expected.txt:
              * fast/forms/selection-functions-expected.txt:
              * fast/forms/text-field-setvalue-crash-expected.txt:
              * fast/forms/textarea-paste-newline-expected.txt:
      
      WebCore:
      
              Reviewed by thatcher
              
              Setup for <rdar://problem/4344550> Misspellings aren't marked after undo delete
              
              Fixes:
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=6498>
              SelectionController's setters should notify delegates of selection changes
              
              Moved setSelection from Frame to SelectionController.
              I haven't moved any of the work that's done as a result of a 
              Selection change to SelectionController yet.
              Make fewer uses of SelectionControllers.  They're now only used for 
              the Frame's selection, the Page's drag caret, and functions that
              need to do Selection expansion.
      
              * bindings/js/kjs_window.cpp:
              (KJS::Selection::getValueProperty):
              (KJS::Selection::toString):
              (KJS::SelectionFunc::callAsFunction):
              * bridge/mac/FrameMac.h:
              * bridge/mac/FrameMac.mm:
              (WebCore::FrameMac::advanceToNextMisspelling):
              (WebCore::FrameMac::dispatchCPPEvent):
              (WebCore::FrameMac::fontForSelection):
              (WebCore::FrameMac::baseWritingDirectionForSelectionStart):
              (WebCore::FrameMac::markMisspellingsInAdjacentWords):
              (WebCore::FrameMac::markMisspellings):
              (WebCore::FrameMac::respondToChangedSelection):
              (WebCore::FrameMac::shouldChangeSelection):
              (WebCore::FrameMac::shouldDeleteSelection):
              (WebCore::FrameMac::respondToChangedContents):
              * bridge/mac/PageMac.mm:
              (WebCore::Page::Page):
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject accessibilityAttributeValue:]):
              (-[WebCoreAXObject doAXTextMarkerRangeForLine:]):
              (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]):
              (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]):
              (-[WebCoreAXObject doSetAXSelectedTextMarkerRange:]):
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge isSelectionEditable]):
              (-[WebCoreFrameBridge isSelectionRichlyEditable]):
              (-[WebCoreFrameBridge selectionState]):
              (-[WebCoreFrameBridge deselectText]):
              (-[WebCoreFrameBridge selectedAttributedString]):
              (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]):
              (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]):
              (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]):
              (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:verticalDistance:]):
              (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]):
              (-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]):
              (-[WebCoreFrameBridge selectedDOMRange]):
              (-[WebCoreFrameBridge selectNSRange:]):
              (-[WebCoreFrameBridge selectedNSRange]):
              (-[WebCoreFrameBridge selectionAffinity]):
              (-[WebCoreFrameBridge replaceSelectionWithText:selectReplacement:smartReplace:]):
              (-[WebCoreFrameBridge setSelectionToDragCaret]):
              (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
              (-[WebCoreFrameBridge moveDragCaretToPoint:]):
              (-[WebCoreFrameBridge removeDragCaret]):
              (-[WebCoreFrameBridge dragCaretDOMRange]):
              (-[WebCoreFrameBridge isDragCaretRichlyEditable]):
              (-[WebCoreFrameBridge editableDOMRangeForPoint:]):
              (-[WebCoreFrameBridge ensureSelectionVisible]):
              (-[WebCoreFrameBridge rangeOfCharactersAroundCaret]):
              * bridge/win/PageWin.cpp:
              (WebCore::Page::Page):
              * dom/Document.cpp:
              (WebCore::Document::updateSelection):
              (WebCore::Document::clearSelectionIfNeeded):
              (WebCore::Document::notifyBeforeNodeRemoval):
              * dom/Element.cpp:
              (WebCore::Element::updateFocusAppearance):
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::EditCommand):
              * editing/JSEditor.cpp:
              * editing/ModifySelectionListLevel.cpp:
              (WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel):
              (WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel):
              * editing/Selection.cpp:
              (WebCore::Selection::setBase):
              (WebCore::Selection::setExtent):
              * editing/Selection.h:
              (WebCore::Selection::extent):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::SelectionController):
              (WebCore::SelectionController::moveTo):
              (WebCore::SelectionController::setSelection):
              (WebCore::SelectionController::nodeWillBeRemoved):
              (WebCore::SelectionController::modify):
              (WebCore::SelectionController::clear):
              (WebCore::SelectionController::setBase):
              (WebCore::SelectionController::setExtent):
              * editing/SelectionController.h:
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::insertText):
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::caretRect):
              * editing/VisiblePosition.h:
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::defaultEventHandler):
              * page/Frame.cpp:
              (WebCore::Frame::selectedText):
              (WebCore::Frame::hasSelection):
              (WebCore::Frame::selectionController):
              (WebCore::Frame::dragCaretController):
              (WebCore::Frame::notifyRendererOfSelectionChange):
              (WebCore::Frame::invalidateSelection):
              (WebCore::Frame::clearCaretRectIfNeeded):
              (WebCore::Frame::setFocusNodeIfNeeded):
              (WebCore::Frame::selectionLayoutChanged):
              (WebCore::Frame::caretBlinkTimerFired):
              (WebCore::Frame::paintCaret):
              (WebCore::Frame::paintDragCaret):
              (WebCore::Frame::isPointInsideSelection):
              (WebCore::Frame::selectClosestWordFromMouseEvent):
              (WebCore::Frame::handleMousePressEventDoubleClick):
              (WebCore::Frame::handleMousePressEventTripleClick):
              (WebCore::Frame::handleMousePressEventSingleClick):
              (WebCore::Frame::handleMouseMoveEvent):
              (WebCore::Frame::handleMouseReleaseEvent):
              (WebCore::Frame::selectAll):
              (WebCore::Frame::selectContentsOfNode):
              (WebCore::Frame::shouldChangeSelection):
              (WebCore::Frame::shouldDeleteSelection):
              (WebCore::Frame::isSelectionInPasswordField):
              (WebCore::Frame::appliedEditing):
              (WebCore::Frame::unappliedEditing):
              (WebCore::Frame::reappliedEditing):
              (WebCore::Frame::computeAndSetTypingStyle):
              (WebCore::Frame::applyStyle):
              (WebCore::Frame::applyParagraphStyle):
              (WebCore::Frame::selectionListState):
              (WebCore::Frame::selectionHasStyle):
              (WebCore::Frame::selectionComputedStyle):
              (WebCore::Frame::selectFrameElementInParentIfFullySelected):
              (WebCore::Frame::currentForm):
              (WebCore::Frame::revealSelection):
              (WebCore::Frame::centerSelectionInVisibleArea):
              (WebCore::Frame::styleForSelectionStart):
              (WebCore::Frame::setSelectionFromNone):
              (WebCore::Frame::findString):
              * page/Frame.h:
              * page/FramePrivate.h:
              (WebCore::FramePrivate::FramePrivate):
              * page/FrameView.cpp:
              (WebCore::FrameView::clear):
              * page/Page.cpp:
              (WebCore::Page::dragCaretController):
              * page/Page.h:
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintCaret):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::autoscroll):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::selectionStart):
              (WebCore::RenderTextControl::selectionEnd):
              (WebCore::RenderTextControl::setSelectionRange):
              (WebCore::RenderTextControl::selectionChanged):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::writeSelection):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@16237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      397edaa4
  9. 07 Jul, 2006 1 commit
    • lweintraub's avatar
      LayoutTests: · 1bb7d0bf
      lweintraub authored
              Reviewed by justin
      
              Deletion editing deligates now show up!
      
              * editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
              * editing/deleting/delete-3608430-fix-expected.txt:
              * editing/deleting/delete-3608445-fix-expected.txt:
              * editing/deleting/delete-3608462-fix-expected.txt:
              * editing/deleting/delete-3775172-fix-expected.txt:
              * editing/deleting/delete-3800834-fix-expected.txt:
              * editing/deleting/delete-3857753-fix-expected.txt:
              * editing/deleting/delete-3865854-fix-expected.txt:
              * editing/deleting/delete-3928305-fix-expected.txt:
              * editing/deleting/delete-3959464-fix-expected.txt:
              * editing/deleting/delete-4038408-fix-expected.txt:
              * editing/deleting/delete-4083333-fix-expected.txt:
              * editing/deleting/delete-after-span-ws-001-expected.txt:
              * editing/deleting/delete-after-span-ws-002-expected.txt:
              * editing/deleting/delete-after-span-ws-003-expected.txt:
              * editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
              * editing/deleting/delete-and-undo-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
              * editing/deleting/delete-block-contents-001-expected.txt:
              * editing/deleting/delete-block-contents-002-expected.txt:
              * editing/deleting/delete-block-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-001-expected.txt:
              * editing/deleting/delete-block-merge-contents-002-expected.txt:
              * editing/deleting/delete-block-merge-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-004-expected.txt:
              * editing/deleting/delete-block-merge-contents-005-expected.txt:
              * editing/deleting/delete-block-merge-contents-006-expected.txt:
              * editing/deleting/delete-block-merge-contents-007-expected.txt:
              * editing/deleting/delete-block-merge-contents-008-expected.txt:
              * editing/deleting/delete-block-merge-contents-009-expected.txt:
              * editing/deleting/delete-block-merge-contents-010-expected.txt:
              * editing/deleting/delete-block-merge-contents-012-expected.txt:
              * editing/deleting/delete-block-merge-contents-013-expected.txt:
              * editing/deleting/delete-block-merge-contents-014-expected.txt:
              * editing/deleting/delete-block-merge-contents-015-expected.txt:
              * editing/deleting/delete-block-merge-contents-016-expected.txt:
              * editing/deleting/delete-block-merge-contents-017-expected.txt:
              * editing/deleting/delete-block-merge-contents-018-expected.txt:
              * editing/deleting/delete-block-merge-contents-019-expected.txt:
              * editing/deleting/delete-block-merge-contents-020-expected.txt:
              * editing/deleting/delete-block-merge-contents-021-expected.txt:
              * editing/deleting/delete-block-merge-contents-022-expected.txt:
              * editing/deleting/delete-block-merge-contents-023-expected.txt:
              * editing/deleting/delete-block-merge-contents-024-expected.txt:
              * editing/deleting/delete-br-001-expected.txt:
              * editing/deleting/delete-br-002-expected.txt:
              * editing/deleting/delete-br-003-expected.txt:
              * editing/deleting/delete-br-004-expected.txt:
              * editing/deleting/delete-br-005-expected.txt:
              * editing/deleting/delete-br-006-expected.txt:
              * editing/deleting/delete-br-007-expected.txt:
              * editing/deleting/delete-br-008-expected.txt:
              * editing/deleting/delete-br-009-expected.txt:
              * editing/deleting/delete-br-010-expected.txt:
              * editing/deleting/delete-br-011-expected.txt:
              * editing/deleting/delete-character-001-expected.txt:
              * editing/deleting/delete-contiguous-ws-001-expected.txt:
              * editing/deleting/delete-image-001-expected.txt:
              * editing/deleting/delete-image-002-expected.txt:
              * editing/deleting/delete-image-003-expected.txt:
              * editing/deleting/delete-image-004-expected.txt:
              * editing/deleting/delete-leading-ws-001-expected.txt:
              * editing/deleting/delete-line-001-expected.txt:
              * editing/deleting/delete-line-002-expected.txt:
              * editing/deleting/delete-line-003-expected.txt:
              * editing/deleting/delete-line-004-expected.txt:
              * editing/deleting/delete-line-005-expected.txt:
              * editing/deleting/delete-line-006-expected.txt:
              * editing/deleting/delete-line-007-expected.txt:
              * editing/deleting/delete-line-008-expected.txt:
              * editing/deleting/delete-line-009-expected.txt:
              * editing/deleting/delete-line-010-expected.txt:
              * editing/deleting/delete-line-011-expected.txt:
              * editing/deleting/delete-line-012-expected.txt:
              * editing/deleting/delete-line-013-expected.txt:
              * editing/deleting/delete-line-014-expected.txt:
              * editing/deleting/delete-line-015-expected.txt:
              * editing/deleting/delete-line-016-expected.txt:
              * editing/deleting/delete-line-017-expected.txt:
              * editing/deleting/delete-line-end-ws-001-expected.txt:
              * editing/deleting/delete-line-end-ws-002-expected.txt:
              * editing/deleting/delete-listitem-001-expected.txt:
              * editing/deleting/delete-listitem-002-expected.txt:
              * editing/deleting/delete-select-all-001-expected.txt:
              * editing/deleting/delete-select-all-002-expected.txt:
              * editing/deleting/delete-select-all-003-expected.txt:
              * editing/deleting/delete-selection-001-expected.txt:
              * editing/deleting/delete-tab-001-expected.txt:
              * editing/deleting/delete-tab-002-expected.txt:
              * editing/deleting/delete-tab-003-expected.txt:
              * editing/deleting/delete-tab-004-expected.txt:
              * editing/deleting/delete-trailing-ws-001-expected.txt:
              * editing/deleting/delete-trailing-ws-002-expected.txt:
              * editing/deleting/delete-ws-fixup-001-expected.txt:
              * editing/deleting/delete-ws-fixup-002-expected.txt:
              * editing/deleting/delete-ws-fixup-003-expected.txt:
              * editing/deleting/delete-ws-fixup-004-expected.txt:
              * editing/deleting/forward-delete-expected.txt:
              * editing/deleting/merge-different-styles-expected.txt:
              * editing/deleting/merge-endOfParagraph-expected.txt:
              * editing/deleting/merge-into-empty-block-1-expected.txt:
              * editing/deleting/merge-into-empty-block-2-expected.txt:
              * editing/deleting/merge-no-br-expected.txt:
              * editing/deleting/merge-unrendered-space-expected.txt:
              * editing/deleting/pruning-after-merge-1-expected.txt:
              * editing/deleting/pruning-after-merge-2-expected.txt:
              * editing/deleting/smart-delete-001-expected.txt:
              * editing/deleting/smart-delete-002-expected.txt:
              * editing/deleting/table-cells-expected.txt:
              * editing/execCommand/insertHTML-expected.txt:
              * editing/input/text-input-controller-expected.txt:
              * editing/inserting/insert-3775316-fix-expected.txt:
              * editing/inserting/insert-3851164-fix-expected.txt:
              * editing/inserting/insert-after-delete-001-expected.txt:
              * editing/inserting/insert-div-021-expected.txt:
              * editing/inserting/insert-div-026-expected.txt:
              * editing/pasteboard/4076267-2-expected.txt:
              * editing/pasteboard/4076267-3-expected.txt:
              * editing/pasteboard/4076267-expected.txt:
              * editing/pasteboard/paste-table-002-expected.txt:
              * editing/pasteboard/paste-text-015-expected.txt:
              * editing/selection/move-between-blocks-no-001-expected.txt:
              * editing/selection/select-all-iframe-expected.txt:
              * editing/style/block-style-005-expected.txt:
              * editing/style/smoosh-styles-001-expected.txt:
              * editing/style/smoosh-styles-002-expected.txt:
              * editing/style/style-3681552-fix-002-expected.txt:
              * editing/style/typing-style-001-expected.txt:
              * editing/style/typing-style-002-expected.txt:
              * editing/unsupported-content/list-delete-001-expected.txt:
              * editing/unsupported-content/list-delete-002-expected.txt:
              * editing/unsupported-content/list-delete-003-expected.txt:
              * editing/unsupported-content/table-delete-001-expected.txt:
              * editing/unsupported-content/table-delete-002-expected.txt:
              * editing/unsupported-content/table-delete-003-expected.txt:
              * fast/forms/input-text-option-delete-expected.checksum:
              * fast/forms/input-text-option-delete-expected.txt:
      
      WebCore:
      
              Reviewed by justin
      
              Allowed deletion typing commands to take in a granularity
      
              * bridge/mac/WebCoreFrameBridge.h: Pass granularity across the bridge
              * bridge/mac/WebCoreFrameBridge.mm: Ditto
              (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]):
              (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]):
              * editing/TypingCommand.cpp: Constructors take in a granularity
              (WebCore::TypingCommand::TypingCommand):
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/TypingCommand.h: ditto
              * page/Frame.h: Fixed bug that shouldDeleteSelection wasn't virtual
      
      WebKit:
      
              Reviewed by justin
      
              Finished moving deletion selection expansion across the bridge... say that 3 times fast.
      
              * WebView/WebHTMLView.m:  Pass granularity to WebCore to handle expansion
              (-[WebHTMLView _deleteRange:killRing:prepend:smartDeleteOK:deletionAction:granularity:]):
              (-[WebHTMLView _deleteSelection]):
              (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):
              (-[NSArray deleteToMark:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bb7d0bf
  10. 02 Jun, 2006 1 commit
    • ddkilzer's avatar
      LayoutTests: · 249f410d
      ddkilzer authored
              Reviewed by mjs.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
              Finish renaming of RenderCanvas to RenderView
      
              * editing/selection/7152-1-expected.checksum: Layout changed due to text change in HTML file.
              * editing/selection/7152-1-expected.png: Ditto.
              * editing/selection/7152-1-expected.txt: Ditto.
              * editing/selection/7152-1.html: Changed text in HTML content.
              * editing/selection/7152-2-expected.checksum: Layout changed due to text change in HTML file.
              * editing/selection/7152-2-expected.png: Ditto.
              * editing/selection/7152-2-expected.txt: Ditto.
              * editing/selection/7152-2.html: Changed text in HTML content.
              * *-expected.txt: Replaced "RenderCanvas" with "RenderView" in 3023 more files.
      
      WebCore:
      
              Reviewed by mjs.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
              Finish renaming of RenderCanvas to RenderView
      
              * rendering/RenderView.h: Changed renderName from "RenderCanvas" to "RenderView".
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      249f410d
  11. 14 Apr, 2006 1 commit
  12. 04 Apr, 2006 1 commit
    • justing's avatar
      LayoutTests: · 217ded8c
      justing authored
              Reviewed by darin
      
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=6608>
              REGRESSION: Line disappears when deleting
      
              Added:
              * editing/deleting/merge-different-styles-expected.checksum: Added.
              * editing/deleting/merge-different-styles-expected.png: Added.
              * editing/deleting/merge-different-styles-expected.txt: Added.
              * editing/deleting/merge-different-styles.html: Added.
              * editing/deleting/merge-no-br-expected.checksum: Added.
              * editing/deleting/merge-no-br-expected.png: Added.
              * editing/deleting/merge-no-br-expected.txt: Added.
              * editing/deleting/merge-no-br.html: Added.
              * editing/deleting/merge-whitespace-pre-expected.checksum: Added.
              * editing/deleting/merge-whitespace-pre-expected.png: Added.
              * editing/deleting/merge-whitespace-pre-expected.txt: Added.
              * editing/deleting/merge-whitespace-pre.html: Added.
      
              Fixes (not enough style on nodes for the fixes to be reflected in pixel results):
              * editing/deleting/delete-block-merge-contents-005-expected.txt:
              * editing/deleting/delete-block-merge-contents-006-expected.txt:
              * editing/deleting/delete-block-merge-contents-008-expected.txt:
      
              Equivalent render trees:
              * editing/deleting/delete-3857753-fix-expected.txt:
              * editing/inserting/insert-div-026-expected.txt:
              
              Forgot to checkin these new expected results after fixing the DRT bug:
              * fast/lists/drag-into-marker-expected.checksum:
              * fast/lists/drag-into-marker-expected.png:
              * fast/lists/drag-into-marker-expected.txt:
      
      WebCore:
      
              Reviewed by darin
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=6608>
              REGRESSION: Line disappears when deleting
              
              Rewrote moveNodesAfterNode to address these problems:
              It moved nodes without preserving their style. 
              It traversed over siblings looking for a br to know when
              to stop merging.  If the br was burried inside a span, it 
              wouldn't find it.  If the text is whitespace:pre, it wouldn't
              stop.
              In theory it would crash if the "enclosingInlineElements" of the start of the
              selection to delete and the end of the selection to delete were the
              same.  We think that this will fix these:
              <rdar://problems/3950559&4498113>
              CrashTracer: 2116 crashes in Mail at com.apple.WebCore: khtml::CompositeEditCommand::insertNodeAfter + 32
              CrashTracer: 1569 crashes in Mail at com.apple.WebCore: khtml::DeleteSelectionCommand::moveNodesAfterNode + 340
              But we haven't been able to construct a reproducible case.
              
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Moved from ReplaceSelectionCommand.
              (WebCore::CompositeEditCommand::prune): Ditto.
              * editing/CompositeEditCommand.h:
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::mergeParagraphs):
              (WebCore::DeleteSelectionCommand::doApply):
              * editing/DeleteSelectionCommand.h:
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/ReplaceSelectionCommand.h:
              (WebCore::):
              * editing/markup.cpp:
              (WebCore::createMarkup): 
              Was crashing when passed a collapsed range.  I early return an empty string instead.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      217ded8c