1. 05 May, 2009 1 commit
    • ap@webkit.org's avatar
      Reviewed by Dave Hyatt. · d0295906
      ap@webkit.org authored
              <rdar://problem/6576889> REGRESSION (r35185): Cannot watch Flash movies on omg.yahoo.com
      
              The problem was caused by missing <head> element - we used to create it when moving a
              misplaced <style> element, but we now handle those in place. Other browsers always create
              a <head> element.
      
              There is no guarantee that a <head> element always exists - first, it can be removed with
              removeChild or innerHTML, and also, we don't currently create it for frameset documents, or
              for manually created ones (e.g. ImageDocument).
      
              Test: fast/parser/head-element-for-yahoo-player.html
      
      WebKit:
              * dom/Document.cpp: (WebCore::Document::implicitClose): Create a <head> element for about:blank.
              A removed comment talked about rdar://3758785, but that problem doesn't re-occur even if this
              code is removed completely.
      
              * html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::checkDTD): No longer allow <script>
              elements as children of <html>. This isn't directly related to this bug, but it was easier
              to fix both at once (IE and Firefox both don't allow such mispositioned <script> elements).
      
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::handleError): Move <script> to <head> if <body> hasn't been created yet.
              Create a <head> it a <body> is created implicitly to contain some other element.
              (WebCore::HTMLParser::bodyCreateErrorCheck): Ensure that a <head> exists when <body> is
              explicitly present in source.
              (WebCore::HTMLParser::createHead): Do the work even if <html> element hasn't been created yet.
      
      LayoutTests:
              * fast/parser/head-element-for-yahoo-player-expected.txt: Added.
              * fast/parser/head-element-for-yahoo-player.html: Added.
              Test the regression case (a misplaced <style> that used to create <head> implicitly).
      
              * editing/selection/select-all-005.html: Use a new index when selecting the body.
      
              * fast/dom/Document/document-write-doctype-expected.txt:
              * fast/dom/Document/resources/document-write-doctype.js:
              Removed checks for "Gecko quirk" of implicitly adding HEAD - that not a quirk, but standard
              behavior per HTML5.
      
              * editing/execCommand/create-list-1-expected.txt:
              * platform/mac/editing/deleting/4845371-expected.txt:
              * platform/mac/editing/deleting/4866671-expected.txt:
              * platform/mac/editing/deleting/4875189-expected.txt:
              * platform/mac/editing/deleting/5026848-1-expected.txt:
              * platform/mac/editing/deleting/5026848-2-expected.txt:
              * platform/mac/editing/deleting/5026848-3-expected.txt:
              * platform/mac/editing/deleting/5032066-expected.txt:
              * platform/mac/editing/deleting/5091898-expected.txt:
              * platform/mac/editing/deleting/5099303-expected.txt:
              * platform/mac/editing/deleting/5115601-expected.txt:
              * platform/mac/editing/deleting/5126166-expected.txt:
              * platform/mac/editing/deleting/5156801-2-expected.txt:
              * platform/mac/editing/deleting/5168598-expected.txt:
              * platform/mac/editing/deleting/5272440-expected.txt:
              * platform/mac/editing/deleting/5300379-expected.txt:
              * platform/mac/editing/deleting/5390681-expected.txt:
              * platform/mac/editing/deleting/5408255-expected.txt:
              * platform/mac/editing/deleting/5433862-2-expected.txt:
              * platform/mac/editing/deleting/5483370-expected.txt:
              * platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
              * platform/mac/editing/deleting/delete-block-table-expected.txt:
              * platform/mac/editing/deleting/delete-hr-expected.txt:
              * platform/mac/editing/deleting/delete-mixed-editable-content-001-expected.txt:
              * platform/mac/editing/deleting/delete-to-select-table-expected.txt:
              * platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
              * platform/mac/editing/deleting/merge-endOfParagraph-expected.txt:
              * platform/mac/editing/deleting/merge-no-br-expected.txt:
              * platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
              * platform/mac/editing/execCommand/4641880-1-expected.txt:
              * platform/mac/editing/execCommand/4641880-2-expected.txt:
              * platform/mac/editing/execCommand/4747450-expected.txt:
              * platform/mac/editing/execCommand/4786404-1-expected.txt:
              * platform/mac/editing/execCommand/4786404-2-expected.txt:
              * platform/mac/editing/execCommand/4916402-expected.txt:
              * platform/mac/editing/execCommand/4916541-expected.txt:
              * platform/mac/editing/execCommand/4916583-expected.txt:
              * platform/mac/editing/execCommand/4920488-expected.txt:
              * platform/mac/editing/execCommand/4920742-1-expected.txt:
              * platform/mac/editing/execCommand/4924441-expected.txt:
              * platform/mac/editing/execCommand/5049671-expected.txt:
              * platform/mac/editing/execCommand/5080333-1-expected.txt:
              * platform/mac/editing/execCommand/5080333-2-expected.txt:
              * platform/mac/editing/execCommand/5119244-expected.txt:
              * platform/mac/editing/execCommand/5120591-expected.txt:
              * platform/mac/editing/execCommand/5136770-expected.txt:
              * platform/mac/editing/execCommand/5142012-1-expected.txt:
              * platform/mac/editing/execCommand/5142012-2-expected.txt:
              * platform/mac/editing/execCommand/5142012-3-expected.txt:
              * platform/mac/editing/execCommand/5144139-1-expected.txt:
              * platform/mac/editing/execCommand/5164796-expected.txt:
              * platform/mac/editing/execCommand/5207369-expected.txt:
              * platform/mac/editing/execCommand/5210032-expected.txt:
              * platform/mac/editing/execCommand/5432254-1-expected.txt:
              * platform/mac/editing/execCommand/5432254-2-expected.txt:
              * platform/mac/editing/execCommand/5481523-expected.txt:
              * platform/mac/editing/execCommand/5482524-expected.txt:
              * platform/mac/editing/execCommand/5569741-expected.txt:
              * platform/mac/editing/execCommand/5573879-expected.txt:
              * platform/mac/editing/execCommand/5700414-1-expected.txt:
              * platform/mac/editing/execCommand/5700414-2-expected.txt:
              * platform/mac/editing/execCommand/insert-list-empty-div-expected.txt:
              * platform/mac/editing/input/5576619-expected.txt:
              * platform/mac/editing/inserting/12882-expected.txt:
              * platform/mac/editing/inserting/4840662-expected.txt:
              * platform/mac/editing/inserting/4875189-1-expected.txt:
              * platform/mac/editing/inserting/4875189-2-expected.txt:
              * platform/mac/editing/inserting/4959067-expected.txt:
              * platform/mac/editing/inserting/4960120-1-expected.txt:
              * platform/mac/editing/inserting/4960120-2-expected.txt:
              * platform/mac/editing/inserting/5002441-expected.txt:
              * platform/mac/editing/inserting/5058163-2-expected.txt:
              * platform/mac/editing/inserting/5156401-2-expected.txt:
              * platform/mac/editing/inserting/5549929-2-expected.txt:
              * platform/mac/editing/inserting/5549929-3-expected.txt:
              * platform/mac/editing/inserting/5607069-2-expected.txt:
              * platform/mac/editing/inserting/5607069-3-expected.txt:
              * platform/mac/editing/inserting/editable-html-element-expected.txt:
              * platform/mac/editing/inserting/editable-inline-element-expected.txt:
              * platform/mac/editing/inserting/edited-whitespace-1-expected.txt:
              * platform/mac/editing/inserting/editing-empty-divs-expected.txt:
              * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt:
              * platform/mac/editing/pasteboard/4806874-expected.txt:
              * platform/mac/editing/pasteboard/4861080-expected.txt:
              * platform/mac/editing/pasteboard/4944770-1-expected.txt:
              * platform/mac/editing/pasteboard/4944770-2-expected.txt:
              * platform/mac/editing/pasteboard/4947130-expected.txt:
              * platform/mac/editing/pasteboard/4989774-expected.txt:
              * platform/mac/editing/pasteboard/5027857-expected.txt:
              * platform/mac/editing/pasteboard/5032095-expected.txt:
              * platform/mac/editing/pasteboard/5065605-expected.txt:
              * platform/mac/editing/pasteboard/5071074-2-expected.txt:
              * platform/mac/editing/pasteboard/5071074-expected.txt:
              * platform/mac/editing/pasteboard/5075944-2-expected.txt:
              * platform/mac/editing/pasteboard/5075944-3-expected.txt:
              * platform/mac/editing/pasteboard/5075944-expected.txt:
              * platform/mac/editing/pasteboard/5134759-expected.txt:
              * platform/mac/editing/pasteboard/5156401-1-expected.txt:
              * platform/mac/editing/pasteboard/5247341-expected.txt:
              * platform/mac/editing/pasteboard/5387578-expected.txt:
              * platform/mac/editing/pasteboard/5478250-expected.txt:
              * platform/mac/editing/pasteboard/5483567-expected.txt:
              * platform/mac/editing/pasteboard/5601583-1-expected.txt:
              * platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt:
              * platform/mac/editing/pasteboard/input-field-1-expected.txt:
              * platform/mac/editing/pasteboard/merge-after-delete-1-expected.txt:
              * platform/mac/editing/pasteboard/merge-after-delete-2-expected.txt:
              * platform/mac/editing/pasteboard/merge-after-delete-expected.txt:
              * platform/mac/editing/pasteboard/merge-start-blockquote-expected.txt:
              * platform/mac/editing/pasteboard/paste-unrendered-select-expected.txt:
              * platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.txt:
              * platform/mac/editing/pasteboard/select-element-1-expected.txt:
              * platform/mac/editing/selection/13804-expected.txt:
              * platform/mac/editing/selection/14971-expected.txt:
              * platform/mac/editing/selection/4397952-expected.txt:
              * platform/mac/editing/selection/4818145-expected.txt:
              * platform/mac/editing/selection/4866671-expected.txt:
              * platform/mac/editing/selection/4889598-expected.txt:
              * platform/mac/editing/selection/4895428-1-expected.txt:
              * platform/mac/editing/selection/4895428-2-expected.txt:
              * platform/mac/editing/selection/4895428-3-expected.txt:
              * platform/mac/editing/selection/4895428-4-expected.txt:
              * platform/mac/editing/selection/4932260-1-expected.txt:
              * platform/mac/editing/selection/4932260-2-expected.txt:
              * platform/mac/editing/selection/4932260-3-expected.txt:
              * platform/mac/editing/selection/4947387-expected.txt:
              * platform/mac/editing/selection/4960116-expected.txt:
              * platform/mac/editing/selection/4975120-expected.txt:
              * platform/mac/editing/selection/4983858-expected.txt:
              * platform/mac/editing/selection/5007143-2-expected.txt:
              * platform/mac/editing/selection/5007143-expected.txt:
              * platform/mac/editing/selection/5057506-2-expected.txt:
              * platform/mac/editing/selection/5057506-expected.txt:
              * platform/mac/editing/selection/5076323-1-expected.txt:
              * platform/mac/editing/selection/5076323-2-expected.txt:
              * platform/mac/editing/selection/5076323-3-expected.txt:
              * platform/mac/editing/selection/5081257-1-expected.txt:
              * platform/mac/editing/selection/5081257-2-expected.txt:
              * platform/mac/editing/selection/5099303-expected.txt:
              * platform/mac/editing/selection/5109817-expected.txt:
              * platform/mac/editing/selection/5136696-expected.txt:
              * platform/mac/editing/selection/5195166-1-expected.txt:
              * platform/mac/editing/selection/5195166-2-expected.txt:
              * platform/mac/editing/selection/5234383-1-expected.txt:
              * platform/mac/editing/selection/5234383-2-expected.txt:
              * platform/mac/editing/selection/5240265-expected.txt:
              * platform/mac/editing/selection/5333725-expected.txt:
              * platform/mac/editing/selection/5354455-1-expected.txt:
              * platform/mac/editing/selection/addRange-expected.txt:
              * platform/mac/editing/selection/caret-before-select-expected.txt:
              * platform/mac/editing/selection/contains-boundaries-expected.txt:
              * platform/mac/editing/selection/drag-select-1-expected.txt:
              * platform/mac/editing/selection/editable-html-element-expected.txt:
              * platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt:
              * platform/mac/editing/selection/inline-closest-leaf-child-expected.txt:
              * platform/mac/editing/selection/mixed-editability-6-expected.txt:
              * platform/mac/editing/selection/mixed-editability-7-expected.txt:
              * platform/mac/editing/selection/move-by-sentence-linebreak-expected.txt:
              * platform/mac/editing/selection/select-all-005-expected.txt:
              * platform/mac/editing/selection/table-caret-1-expected.txt:
              * platform/mac/editing/selection/table-caret-2-expected.txt:
              * platform/mac/editing/selection/table-caret-3-expected.txt:
              * platform/mac/editing/selection/wrapped-line-caret-1-expected.txt:
              * platform/mac/editing/selection/wrapped-line-caret-2-expected.txt:
              * platform/mac/editing/style/4916887-expected.txt:
              * platform/mac/editing/style/5017613-1-expected.txt:
              * platform/mac/editing/style/5017613-2-expected.txt:
              * platform/mac/editing/style/5046875-1-expected.txt:
              * platform/mac/editing/style/5046875-2-expected.txt:
              * platform/mac/editing/style/5065910-expected.txt:
              * platform/mac/editing/style/5084241-expected.txt:
              * platform/mac/editing/style/5091898-expected.txt:
              * platform/mac/editing/style/5228141-expected.txt:
              * platform/mac/editing/style/5279521-expected.txt:
              * platform/mac/editing/style/font-family-with-space-expected.txt:
              * platform/mac/editing/style/fontsize-1-expected.txt:
              * platform/mac/editing/style/highlight-expected.txt:
              * platform/mac/editing/style/non-inheritable-styles-expected.txt:
              * platform/mac/editing/undo/5378473-expected.txt:
              * platform/mac/fast/block/float/relative-painted-twice-expected.txt:
              * platform/mac/fast/dom/delete-contents-expected.txt:
              * platform/mac/fast/events/context-no-deselect-expected.txt:
              * platform/mac/fast/events/label-focus-expected.txt:
              * platform/mac/fast/forms/input-appearance-focus-expected.txt:
              * platform/mac/fast/forms/input-text-click-inside-expected.txt:
              * platform/mac/fast/forms/input-text-click-outside-expected.txt:
              * platform/mac/fast/forms/input-text-double-click-expected.txt:
              * platform/mac/fast/forms/input-text-drag-down-expected.txt:
              * platform/mac/fast/forms/input-text-option-delete-expected.txt:
              * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
              * platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
              * platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt:
              * platform/mac/fast/forms/textfield-overflow-expected.txt:
              * platform/mac/fast/inline/25277-2-expected.txt:
              * platform/mac/fast/inline/25277-expected.txt:
              * platform/mac/fast/lists/drag-into-marker-expected.txt:
              * platform/mac/fast/overflow/overflow-focus-ring-expected.txt:
              * platform/mac/fast/repaint/4776765-expected.txt:
              * platform/mac/fast/repaint/selection-after-delete-expected.txt:
              * platform/mac/fast/repaint/selection-after-remove-expected.txt:
              * platform/qt/editing/deleting/4845371-expected.txt:
              * platform/qt/editing/deleting/4866671-expected.txt:
              * platform/qt/editing/deleting/4875189-expected.txt:
              * platform/qt/editing/deleting/5026848-1-expected.txt:
              * platform/qt/editing/deleting/5026848-2-expected.txt:
              * platform/qt/editing/deleting/5026848-3-expected.txt:
              * platform/qt/editing/deleting/5032066-expected.txt:
              * platform/qt/editing/deleting/5091898-expected.txt:
              * platform/qt/editing/deleting/5099303-expected.txt:
              * platform/qt/editing/deleting/5115601-expected.txt:
              * platform/qt/editing/deleting/5126166-expected.txt:
              * platform/qt/editing/deleting/5144139-2-expected.txt:
              * platform/qt/editing/deleting/5156801-2-expected.txt:
              * platform/qt/editing/deleting/5168598-expected.txt:
              * platform/qt/editing/deleting/5272440-expected.txt:
              * platform/qt/editing/deleting/5300379-expected.txt:
              * platform/qt/editing/deleting/5390681-expected.txt:
              * platform/qt/editing/deleting/5408255-expected.txt:
              * platform/qt/editing/deleting/delete-at-start-or-end-expected.txt:
              * platform/qt/editing/deleting/delete-block-table-expected.txt:
              * platform/qt/editing/deleting/delete-hr-expected.txt:
              * platform/qt/editing/deleting/delete-link-1-expected.txt:
              * platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.txt:
              * platform/qt/editing/deleting/delete-to-select-table-expected.txt:
              * platform/qt/editing/deleting/deletionUI-single-instance-expected.txt:
              * platform/qt/editing/deleting/merge-endOfParagraph-expected.txt:
              * platform/qt/editing/deleting/merge-no-br-expected.txt:
              * platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
              * platform/qt/editing/execCommand/4641880-1-expected.txt:
              * platform/qt/editing/execCommand/4641880-2-expected.txt:
              * platform/qt/editing/execCommand/4747450-expected.txt:
              * platform/qt/editing/execCommand/4786404-1-expected.txt:
              * platform/qt/editing/execCommand/4786404-2-expected.txt:
              * platform/qt/editing/execCommand/4916402-expected.txt:
              * platform/qt/editing/execCommand/4916541-expected.txt:
              * platform/qt/editing/execCommand/4916583-expected.txt:
              * platform/qt/editing/execCommand/4920488-expected.txt:
              * platform/qt/editing/execCommand/4920742-1-expected.txt:
              * platform/qt/editing/execCommand/4924441-expected.txt:
              * platform/qt/editing/execCommand/5049671-expected.txt:
              * platform/qt/editing/execCommand/5062376-expected.txt:
              * platform/qt/editing/execCommand/5080333-1-expected.txt:
              * platform/qt/editing/execCommand/5080333-2-expected.txt:
              * platform/qt/editing/execCommand/5119244-expected.txt:
              * platform/qt/editing/execCommand/5120591-expected.txt:
              * platform/qt/editing/execCommand/5136770-expected.txt:
              * platform/qt/editing/execCommand/5142012-1-expected.txt:
              * platform/qt/editing/execCommand/5142012-2-expected.txt:
              * platform/qt/editing/execCommand/5142012-3-expected.txt:
              * platform/qt/editing/execCommand/5144139-1-expected.txt:
              * platform/qt/editing/execCommand/5164796-expected.txt:
              * platform/qt/editing/execCommand/5207369-expected.txt:
              * platform/qt/editing/execCommand/5210032-expected.txt:
              * platform/qt/editing/execCommand/5432254-1-expected.txt:
              * platform/qt/editing/execCommand/5432254-2-expected.txt:
              * platform/qt/editing/execCommand/insert-list-empty-div-expected.txt:
              * platform/qt/editing/inserting/12882-expected.txt:
              * platform/qt/editing/inserting/4840662-expected.txt:
              * platform/qt/editing/inserting/4875189-1-expected.txt:
              * platform/qt/editing/inserting/4875189-2-expected.txt:
              * platform/qt/editing/inserting/4959067-expected.txt:
              * platform/qt/editing/inserting/4960120-1-expected.txt:
              * platform/qt/editing/inserting/4960120-2-expected.txt:
              * platform/qt/editing/inserting/5002441-expected.txt:
              * platform/qt/editing/inserting/5058163-2-expected.txt:
              * platform/qt/editing/inserting/5156401-2-expected.txt:
              * platform/qt/editing/inserting/editable-html-element-expected.txt:
              * platform/qt/editing/inserting/editable-inline-element-expected.txt:
              * platform/qt/editing/inserting/edited-whitespace-1-expected.txt:
              * platform/qt/editing/inserting/editing-empty-divs-expected.txt:
              * platform/qt/editing/inserting/insert-before-link-1-expected.txt:
              * platform/qt/editing/pasteboard/4806874-expected.txt:
              * platform/qt/editing/pasteboard/4840662-expected.txt:
              * platform/qt/editing/pasteboard/4944770-1-expected.txt:
              * platform/qt/editing/pasteboard/4989774-expected.txt:
              * platform/qt/editing/pasteboard/5027857-expected.txt:
              * platform/qt/editing/pasteboard/5032095-expected.txt:
              * platform/qt/editing/pasteboard/5065605-expected.txt:
              * platform/qt/editing/pasteboard/5071074-2-expected.txt:
              * platform/qt/editing/pasteboard/5071074-expected.txt:
              * platform/qt/editing/pasteboard/5075944-2-expected.txt:
              * platform/qt/editing/pasteboard/5075944-3-expected.txt:
              * platform/qt/editing/pasteboard/5075944-expected.txt:
              * platform/qt/editing/pasteboard/5134759-expected.txt:
              * platform/qt/editing/pasteboard/5156401-1-expected.txt:
              * platform/qt/editing/pasteboard/5245519-expected.txt:
              * platform/qt/editing/pasteboard/5247341-expected.txt:
              * platform/qt/editing/pasteboard/5387578-expected.txt:
              * platform/qt/editing/pasteboard/5478250-expected.txt:
              * platform/qt/editing/pasteboard/5483567-expected.txt:
              * platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt:
              * platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
              * platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
              * platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
              * platform/qt/editing/pasteboard/merge-start-blockquote-expected.txt:
              * platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt:
              * platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt:
              * platform/qt/editing/selection/13804-expected.txt:
              * platform/qt/editing/selection/4397952-expected.txt:
              * platform/qt/editing/selection/4818145-expected.txt:
              * platform/qt/editing/selection/4866671-expected.txt:
              * platform/qt/editing/selection/4889598-expected.txt:
              * platform/qt/editing/selection/4895428-2-expected.txt:
              * platform/qt/editing/selection/4895428-3-expected.txt:
              * platform/qt/editing/selection/4932260-1-expected.txt:
              * platform/qt/editing/selection/4932260-2-expected.txt:
              * platform/qt/editing/selection/4932260-3-expected.txt:
              * platform/qt/editing/selection/4960116-expected.txt:
              * platform/qt/editing/selection/4983858-expected.txt:
              * platform/qt/editing/selection/5007143-2-expected.txt:
              * platform/qt/editing/selection/5007143-expected.txt:
              * platform/qt/editing/selection/5076323-1-expected.txt:
              * platform/qt/editing/selection/5076323-2-expected.txt:
              * platform/qt/editing/selection/5076323-3-expected.txt:
              * platform/qt/editing/selection/5081257-1-expected.txt:
              * platform/qt/editing/selection/5081257-2-expected.txt:
              * platform/qt/editing/selection/5099303-expected.txt:
              * platform/qt/editing/selection/5136696-expected.txt:
              * platform/qt/editing/selection/5195166-1-expected.txt:
              * platform/qt/editing/selection/5195166-2-expected.txt:
              * platform/qt/editing/selection/5234383-1-expected.txt:
              * platform/qt/editing/selection/5234383-2-expected.txt:
              * platform/qt/editing/selection/5240265-expected.txt:
              * platform/qt/editing/selection/addRange-expected.txt:
              * platform/qt/editing/selection/caret-before-select-expected.txt:
              * platform/qt/editing/selection/editable-html-element-expected.txt:
              * platform/qt/editing/selection/mixed-editability-6-expected.txt:
              * platform/qt/editing/selection/mixed-editability-7-expected.txt:
              * platform/qt/editing/selection/move-by-sentence-linebreak-expected.txt:
              * platform/qt/editing/selection/select-all-005-expected.txt:
              * platform/qt/editing/selection/table-caret-1-expected.txt:
              * platform/qt/editing/selection/table-caret-2-expected.txt:
              * platform/qt/editing/selection/table-caret-3-expected.txt:
              * platform/qt/editing/style/4916887-expected.txt:
              * platform/qt/editing/style/5017613-1-expected.txt:
              * platform/qt/editing/style/5017613-2-expected.txt:
              * platform/qt/editing/style/5046875-1-expected.txt:
              * platform/qt/editing/style/5046875-2-expected.txt:
              * platform/qt/editing/style/5065910-expected.txt:
              * platform/qt/editing/style/5084241-expected.txt:
              * platform/qt/editing/style/5228141-expected.txt:
              * platform/qt/editing/style/5279521-expected.txt:
              * platform/qt/editing/style/font-family-with-space-expected.txt:
              * platform/qt/editing/style/fontsize-1-expected.txt:
              * platform/qt/editing/style/highlight-expected.txt:
              * platform/qt/editing/style/non-inheritable-styles-expected.txt:
              * platform/qt/editing/undo/5378473-expected.txt:
              * platform/qt/fast/dom/delete-contents-expected.txt:
              * platform/qt/fast/events/label-focus-expected.txt:
              * platform/qt/fast/forms/input-appearance-focus-expected.txt:
              * platform/qt/fast/forms/input-maxlength-2-expected.txt:
              * platform/qt/fast/forms/input-text-click-inside-expected.txt:
              * platform/qt/fast/forms/input-text-option-delete-expected.txt:
              * platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
              * platform/qt/fast/forms/textfield-drag-into-disabled-expected.txt:
              * platform/qt/fast/forms/textfield-overflow-expected.txt:
              * platform/qt/fast/overflow/overflow-focus-ring-expected.txt:
              * platform/qt/fast/repaint/4776765-expected.txt:
              * platform/qt/fast/repaint/selection-after-delete-expected.txt:
              * platform/qt/fast/repaint/selection-after-remove-expected.txt:
              * platform/win/editing/deleting/5168598-expected.txt:
              * platform/win/editing/inserting/4960120-1-expected.txt:
              * platform/win/editing/inserting/5607069-2-expected.txt:
              * platform/win/editing/inserting/5607069-3-expected.txt:
              * platform/win/editing/inserting/typing-tab-designmode-forms-expected.txt:
              * platform/win/editing/pasteboard/4806874-expected.txt:
              * platform/win/editing/selection/4895428-3-expected.txt:
              * platform/win/editing/selection/5136696-expected.txt:
              * platform/win/editing/selection/drag-select-1-expected.txt:
              * platform/win/fast/events/context-no-deselect-expected.txt:
              * platform/win/fast/events/label-focus-expected.txt:
              * platform/win/fast/forms/input-appearance-focus-expected.txt:
              * platform/win/fast/forms/input-text-click-inside-expected.txt:
              * platform/win/fast/forms/input-text-click-outside-expected.txt:
              * platform/win/fast/forms/input-text-double-click-expected.txt:
              * platform/win/fast/forms/input-text-drag-down-expected.txt:
              * platform/win/fast/forms/input-text-option-delete-expected.txt:
              * platform/win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
              * platform/win/fast/forms/input-text-self-emptying-click-expected.txt:
              * platform/win/fast/forms/textfield-drag-into-disabled-expected.txt:
              * platform/win/fast/forms/textfield-overflow-expected.txt:
              Updated BODY element index in test output (for some tests, it increased because of the
              implicitly added <head>, and for others, it decreased because mispositoned <script> is being
              moved into <head>).
      
              * webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive:
              * webarchive/archive-empty-frame-dom-expected.webarchive:
              Updated to include the implicitly added <head> elements.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0295906
  2. 29 Apr, 2009 2 commits
    • mitz@apple.com's avatar
      WebCore: · 3d9a5082
      mitz@apple.com authored
              Reviewed by Simon Fraser.
      
              - WebCore part of <rdar://problem/6609509> Select All and then Delete
                should put Mail editing back into the same state as a new message
      
              Test: editing/deleting/in-visibly-empty-root.html
      
              * WebCore.base.exp: Exported VisibleSelection::isAll(bool).
              * editing/SelectionController.h:
              (WebCore::SelectionController::isAll): Added. Calls through to
              VisibleSelection.
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::makeEditableRootEmpty): Added. Removes all children
              of the root editable element the selection is in, other than a
              placeholder. Returns true iff it did anything.
              (WebCore::TypingCommand::deleteKeyPressed): When there is only a single
              visible position in the root editable element, but it has children other
              than a placeholder, remove those children.
              * editing/TypingCommand.h:
              * editing/VisiblePosition.h:
              Added a StayInEditableContent enum and a FIXME.
              * editing/VisibleSelection.cpp:
              (WebCore::VisibleSelection::isAll): Added. Returns whether the
              selection encompasses all visible positions, either in the document or
              in the editable root.
              * editing/VisibleSelection.h:
      
      WebKit/mac:
      
              Reviewed by Simon Fraser.
      
              - WebKit part of <rdar://problem/6609509> Select All and then Delete
                should put Mail editing back into the same state as a new message
      
              * WebView/WebView.mm:
              (-[WebView _selectionIsCaret]): Added.
              (-[WebView _selectionIsAll]): Added. Returns whether the selection
              encompasses the entire document.
              * WebView/WebViewPrivate.h:
      
      LayoutTests:
      
              Reviewed by Simon Fraser.
      
              - test and updated results for <rdar://problem/6609509> Select All and
                then Delete should put Mail editing back into the same state as a new
                message
      
              * editing/deleting/in-visibly-empty-root-expected.txt: Added.
              * editing/deleting/in-visibly-empty-root.html: Added.
              * platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d9a5082
    • ojan@chromium.org's avatar
      Reviewed by Dan Bernstein. · 149606a8
      ojan@chromium.org authored
              Make textarea and text input metrics more closely match IEs.
      
              This involves:
              -set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
              -set textarea width to cols*avgCharWidth
              -Make default CSS match IEs
              -Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.
      
              Those values for textarea and inputs were derived by doing a ton of manual
              testing of IE's width values for various textareas and fonts. On Windows we match
              IE exactly except for a couple fonts of the ~12 tested.
      
              To get the average and max character width of a font, we do the following
              for each platform:
              -Win: TextMetrics expose avgCharWidth and maxCharWidth
              -SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
                  maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
              -Linux: avgCharWidth = width of an '0', fallback on m_xHeight
                  maxCharWidth = max of avgCharWidth and m_ascent
              -Mac: Calculate the avgCharWidth and grab the maxCharWidth off the font.
                  If either one is non-positive, then calculate the value using the Linux approach.
      
              Tests: fast/forms/text-control-intrinsic-widths.html
                     fast/forms/textarea-metrics.html
                     svg/custom/svg-fonts-in-text-controls.html
      
              * css/html4.css:
              * css/themeWin.css:
              * platform/graphics/SimpleFontData.cpp:
              (WebCore::SimpleFontData::SimpleFontData):
              (WebCore::SimpleFontData::initCharWidths):
              * platform/graphics/SimpleFontData.h:
              (WebCore::SimpleFontData::maxCharWidth):
              (WebCore::SimpleFontData::avgCharWidth):
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/chromium/SimpleFontDataLinux.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/gtk/SimpleFontDataGtk.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/gtk/SimpleFontDataPango.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/qt/SimpleFontDataQt.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataCGWin.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataCairoWin.cpp:
              (WebCore::SimpleFontData::platformInit):
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataWin.cpp:
              (WebCore::SimpleFontData::initGDIFont):
              * platform/graphics/wx/SimpleFontDataWx.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::calcPrefWidths):
              * rendering/RenderTextControlMultiLine.cpp:
              (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::preferredContentWidth):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      149606a8
  3. 28 Apr, 2009 1 commit
    • adele@apple.com's avatar
      WebCore: · e2bc16bb
      adele@apple.com authored
      2009-04-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Fix for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
      
              Test: editing/deleting/type-delete-after-quote.html
      
              When a selection is deleted that contains a whole number paragraphs plus a line break, we refrain from merging paragraphs after the delete,
              since it is unclear to most users that such a selection actually ends at the start of the next paragraph.  However, when a user hits delete 
              with a caret selection, they actually do expect the start of that paragraph to be merged into the paragraph before it.  We can tell that 
              we're in this state because the TypingCommand creates the selection to delete but it doesn't change the endingSelection.  So we can tell
              that if we started with a caret selection, then we're not in this special case where we have to protect the user from unexpected behavior 
              from deleting a range they selected.
      
              * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData):
      
      LayoutTests:
      
      2009-04-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Test for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
      
              * editing/deleting/type-delete-after-quote.html: Added.
              * platform/mac/editing/deleting/delete-4038408-fix-expected.txt: This expected result change reflects a change in how the editing is done, 
                but the document structure remains the same, and there are no visible changes to the result.
              * platform/mac/editing/deleting/type-delete-after-quote-expected.checksum: Added.
              * platform/mac/editing/deleting/type-delete-after-quote-expected.png: Added.
              * platform/mac/editing/deleting/type-delete-after-quote-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2bc16bb
  4. 25 Apr, 2009 1 commit
    • adele@apple.com's avatar
      WebCore: · 0f007fae
      adele@apple.com authored
      2009-04-25  Adele Peterson  <adele@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Fix for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
              https://bugs.webkit.org/show_bug.cgi?id=25396
      
              Test: editing/deleting/delete-br-013.html
      
              * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs):
               Only preserve an empty paragraph's style when moving paragraphs around if the selection is still 
               in an empty paragraph after the move occurs.  This was causing the empty paragraph's style to overwrite
               the previous paragraph's style during a delete of an empty paragraph.
      
      LayoutTests:
      
      2009-04-25  Adele Peterson  <adele@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Test for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
              https://bugs.webkit.org/show_bug.cgi?id=25396
      
              * editing/deleting/delete-br-013.html: Added.
              * platform/mac/editing/deleting/delete-br-013-expected.checksum: Added.
              * platform/mac/editing/deleting/delete-br-013-expected.png: Added.
              * platform/mac/editing/deleting/delete-br-013-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f007fae
  5. 24 Apr, 2009 3 commits
  6. 23 Apr, 2009 2 commits
    • kmccullough@apple.com's avatar
      2009-04-23 Kevin McCullough <kmccullough@apple.com> · f44c9f3d
      kmccullough@apple.com authored
              - Windows build fix.  Mac only tests go in platform/mac
      
              * editing/deleting/deletionUI-borders.html: Removed.
              * editing/deleting/deletionUI-differing-background.html: Removed.
              * editing/deleting/deletionUI-minimum-size.html: Removed.
              * platform/mac/editing/deleting/deletionUI-borders.html: Copied from editing/deleting/deletionUI-borders.html.
              * platform/mac/editing/deleting/deletionUI-differing-background.html: Copied from editing/deleting/deletionUI-differing-background.html.
              * platform/mac/editing/deleting/deletionUI-minimum-size.html: Copied from editing/deleting/deletionUI-minimum-size.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f44c9f3d
    • kmccullough@apple.com's avatar
      WebCore: · db684073
      kmccullough@apple.com authored
      2009-04-23  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Adam Roben.
      
              <rdar://problem/6808109> "Deletion UI" is not available for many
              portions of HTML content
      
              This patch makes the deletion UI show up in some new situations:
              1) If a block's background color is different from its parent's
              2) If a block has a background image.
              3) If a block has a single visible border.
              However the block must now not only be at least a minimum width and
              height, but also exceed a minimum area.  In practice this has led to
              much better element selection. 
      
              * editing/DeleteButtonController.cpp:
              (WebCore::isDeletableElement):
      
      LayoutTests:
      
      2009-04-23  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Adam Roben.
      
              <rdar://problem/6808109> "Deletion UI" is not available for many
              portions of HTML content
      
              This patch makes the deletion UI show up in some new situations:
              1) If a block's background color is different from its parent's
              2) If a block has a background image.
              3) If a block has a single visible border.
              However the block must now not only be at least a minimum width and
              height, but also exceed a minimum area.  In practice this has led to
              much better element selection.
      
              * editing/deleting/deletionUI-borders.html: Added.
              * editing/deleting/deletionUI-differing-background.html: Added.
              * editing/deleting/deletionUI-minimum-size.html: Added.
              * editing/deleting/resources: Added.
              * editing/deleting/resources/deletionUI-helpers.js: Added.
              (debug):
              (determineDeletionUIExistence):
              * platform/mac/editing/deleting/deletionUI-borders-expected.txt: Added.
              * platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Added.
              * platform/mac/editing/deleting/deletionUI-minimum-size-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db684073
  7. 20 Apr, 2009 2 commits
    • ggaren@apple.com's avatar
      WebCore: · 38f70292
      ggaren@apple.com authored
      2009-04-20  Geoffrey Garen  <ggaren@apple.com>
      
              Approved by Mark Rowe, Cameron Zwarich, Oliver Hunt, and Ojan Vafai.
              
              Used svn merge to roll out revisions 42678, 42690, 42694, 42697 because
              they broke the Tiger and Windows buildbots.
      
              * css/html4.css:
              * css/themeWin.css:
              * platform/graphics/SimpleFontData.cpp:
              * platform/graphics/SimpleFontData.h:
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              * platform/graphics/chromium/SimpleFontDataLinux.cpp:
              * platform/graphics/gtk/SimpleFontDataGtk.cpp:
              * platform/graphics/gtk/SimpleFontDataPango.cpp:
              * platform/graphics/mac/SimpleFontDataMac.mm:
              * platform/graphics/qt/SimpleFontDataQt.cpp:
              * platform/graphics/win/SimpleFontDataCGWin.cpp:
              * platform/graphics/win/SimpleFontDataCairoWin.cpp:
              * platform/graphics/win/SimpleFontDataWin.cpp:
              * platform/graphics/wx/SimpleFontDataWx.cpp:
              * rendering/RenderTextControl.cpp:
              * rendering/RenderTextControlMultiLine.cpp:
              * rendering/RenderTextControlSingleLine.cpp:
      
      LayoutTests:
      
      2009-04-20  Geoffrey Garen  <ggaren@apple.com>
      
              Approved by Mark Rowe, Cameron Zwarich, Oliver Hunt, and Ojan Vafai.
              
              Used svn merge to roll out revisions 42678, 42690, 42694, 42697 because
              they broke the Tiger and Windows buildbots.
      
              * fast/forms/drag-out-of-textarea.html:
              * fast/forms/resources/TEMPLATE.html: Removed.
              * fast/forms/resources/text-control-intrinsic-widths.js: Removed.
              * fast/forms/resources/textarea-metrics.js: Removed.
              * fast/forms/search-abs-pos-cancel-button.html:
              * fast/forms/text-control-intrinsic-widths-expected.txt: Removed.
              * fast/forms/text-control-intrinsic-widths.html: Removed.
              * fast/forms/textarea-metrics-expected.txt: Removed.
              * fast/forms/textarea-metrics.html: Removed.
              * fast/forms/textarea-width.html:
              * fast/replaced/table-percent-height-expected.txt:
              * fast/replaced/table-percent-height.html:
              * platform/mac-leopard/fast/forms/input-text-maxlength-expected.checksum:
              * platform/mac-leopard/fast/forms/input-text-maxlength-expected.png:
              * platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt:
              * platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.checksum:
              * platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.png:
              * platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt:
              * platform/mac/editing/deleting/5168598-expected.checksum:
              * platform/mac/editing/deleting/5168598-expected.png:
              * platform/mac/editing/deleting/5168598-expected.txt:
              * platform/mac/editing/inserting/4960120-1-expected.checksum:
              * platform/mac/editing/inserting/4960120-1-expected.png:
              * platform/mac/editing/inserting/4960120-1-expected.txt:
              * platform/mac/editing/inserting/5607069-2-expected.checksum:
              * platform/mac/editing/inserting/5607069-2-expected.png:
              * platform/mac/editing/inserting/5607069-2-expected.txt:
              * platform/mac/editing/inserting/5607069-3-expected.checksum:
              * platform/mac/editing/inserting/5607069-3-expected.png:
              * platform/mac/editing/inserting/5607069-3-expected.txt:
              * platform/mac/editing/inserting/before-after-input-element-expected.checksum:
              * platform/mac/editing/inserting/before-after-input-element-expected.png:
              * platform/mac/editing/inserting/before-after-input-element-expected.txt:
              * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.checksum:
              * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.png:
              * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt:
              * platform/mac/editing/pasteboard/4806874-expected.checksum:
              * platform/mac/editing/pasteboard/4806874-expected.png:
              * platform/mac/editing/pasteboard/4806874-expected.txt:
              * platform/mac/editing/pasteboard/drop-text-without-selection-expected.checksum:
              * platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
              * platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
              * platform/mac/editing/pasteboard/input-field-1-expected.checksum:
              * platform/mac/editing/pasteboard/input-field-1-expected.png:
              * platform/mac/editing/pasteboard/input-field-1-expected.txt:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.png:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.txt:
              * platform/mac/editing/pasteboard/pasting-tabs-expected.checksum:
              * platform/mac/editing/pasteboard/pasting-tabs-expected.png:
              * platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
              * platform/mac/editing/selection/3690703-2-expected.checksum:
              * platform/mac/editing/selection/3690703-2-expected.png:
              * platform/mac/editing/selection/3690703-2-expected.txt:
              * platform/mac/editing/selection/3690703-expected.checksum:
              * platform/mac/editing/selection/3690703-expected.png:
              * platform/mac/editing/selection/3690703-expected.txt:
              * platform/mac/editing/selection/3690719-expected.checksum:
              * platform/mac/editing/selection/3690719-expected.png:
              * platform/mac/editing/selection/3690719-expected.txt:
              * platform/mac/editing/selection/4895428-3-expected.checksum:
              * platform/mac/editing/selection/4895428-3-expected.png:
              * platform/mac/editing/selection/4895428-3-expected.txt:
              * platform/mac/editing/selection/4975120-expected.checksum:
              * platform/mac/editing/selection/4975120-expected.png:
              * platform/mac/editing/selection/4975120-expected.txt:
              * platform/mac/editing/selection/5136696-expected.checksum:
              * platform/mac/editing/selection/5136696-expected.png:
              * platform/mac/editing/selection/5136696-expected.txt:
              * platform/mac/editing/selection/5213963-expected.checksum:
              * platform/mac/editing/selection/5213963-expected.png:
              * platform/mac/editing/selection/5213963-expected.txt:
              * platform/mac/editing/selection/drag-select-1-expected.checksum:
              * platform/mac/editing/selection/drag-select-1-expected.png:
              * platform/mac/editing/selection/drag-select-1-expected.txt:
              * platform/mac/editing/selection/drag-text-delay-expected.checksum:
              * platform/mac/editing/selection/drag-text-delay-expected.png:
              * platform/mac/editing/selection/drag-text-delay-expected.txt:
              * platform/mac/editing/selection/select-from-textfield-outwards-expected.checksum:
              * platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
              * platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
              * platform/mac/fast/block/margin-collapse/103-expected.txt:
              * platform/mac/fast/css/line-height-expected.checksum:
              * platform/mac/fast/css/line-height-expected.png:
              * platform/mac/fast/css/line-height-expected.txt:
              * platform/mac/fast/css/resize-corner-tracking-expected.checksum:
              * platform/mac/fast/css/resize-corner-tracking-expected.png:
              * platform/mac/fast/css/resize-corner-tracking-expected.txt:
              * platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum:
              * platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
              * platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
              * platform/mac/fast/dom/isindex-002-expected.checksum:
              * platform/mac/fast/dom/isindex-002-expected.png:
              * platform/mac/fast/dom/isindex-002-expected.txt:
              * platform/mac/fast/dynamic/008-expected.checksum:
              * platform/mac/fast/dynamic/008-expected.png:
              * platform/mac/fast/dynamic/008-expected.txt:
              * platform/mac/fast/events/autoscroll-expected.checksum:
              * platform/mac/fast/events/autoscroll-expected.png:
              * platform/mac/fast/events/autoscroll-expected.txt:
              * platform/mac/fast/events/context-no-deselect-expected.checksum:
              * platform/mac/fast/events/context-no-deselect-expected.png:
              * platform/mac/fast/events/context-no-deselect-expected.txt:
              * platform/mac/fast/events/label-focus-expected.checksum:
              * platform/mac/fast/events/label-focus-expected.png:
              * platform/mac/fast/events/label-focus-expected.txt:
              * platform/mac/fast/forms/basic-textareas-expected.checksum:
              * platform/mac/fast/forms/basic-textareas-expected.png:
              * platform/mac/fast/forms/basic-textareas-expected.txt:
              * platform/mac/fast/forms/box-shadow-override-expected.checksum:
              * platform/mac/fast/forms/box-shadow-override-expected.png:
              * platform/mac/fast/forms/box-shadow-override-expected.txt:
              * platform/mac/fast/forms/control-restrict-line-height-expected.checksum:
              * platform/mac/fast/forms/control-restrict-line-height-expected.png:
              * platform/mac/fast/forms/control-restrict-line-height-expected.txt:
              * platform/mac/fast/forms/encoding-test-expected.checksum:
              * platform/mac/fast/forms/encoding-test-expected.png:
              * platform/mac/fast/forms/encoding-test-expected.txt:
              * platform/mac/fast/forms/fieldset-align-expected.checksum:
              * platform/mac/fast/forms/fieldset-align-expected.png:
              * platform/mac/fast/forms/fieldset-align-expected.txt:
              * platform/mac/fast/forms/form-element-geometry-expected.checksum:
              * platform/mac/fast/forms/form-element-geometry-expected.png:
              * platform/mac/fast/forms/form-element-geometry-expected.txt:
              * platform/mac/fast/forms/input-align-expected.checksum:
              * platform/mac/fast/forms/input-align-expected.png:
              * platform/mac/fast/forms/input-align-expected.txt:
              * platform/mac/fast/forms/input-appearance-bkcolor-expected.checksum:
              * platform/mac/fast/forms/input-appearance-bkcolor-expected.png:
              * platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
              * platform/mac/fast/forms/input-appearance-default-bkcolor-expected.checksum:
              * platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png:
              * platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
              * platform/mac/fast/forms/input-appearance-disabled-expected.checksum:
              * platform/mac/fast/forms/input-appearance-disabled-expected.png:
              * platform/mac/fast/forms/input-appearance-disabled-expected.txt:
              * platform/mac/fast/forms/input-appearance-focus-expected.checksum:
              * platform/mac/fast/forms/input-appearance-focus-expected.png:
              * platform/mac/fast/forms/input-appearance-focus-expected.txt:
              * platform/mac/fast/forms/input-appearance-height-expected.checksum:
              * platform/mac/fast/forms/input-appearance-height-expected.png:
              * platform/mac/fast/forms/input-appearance-height-expected.txt:
              * platform/mac/fast/forms/input-appearance-preventDefault-expected.checksum:
              * platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
              * platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
              * platform/mac/fast/forms/input-appearance-readonly-expected.checksum:
              * platform/mac/fast/forms/input-appearance-readonly-expected.png:
              * platform/mac/fast/forms/input-appearance-readonly-expected.txt:
              * platform/mac/fast/forms/input-appearance-selection-expected.checksum:
              * platform/mac/fast/forms/input-appearance-selection-expected.png:
              * platform/mac/fast/forms/input-appearance-selection-expected.txt:
              * platform/mac/fast/forms/input-appearance-visibility-expected.checksum:
              * platform/mac/fast/forms/input-appearance-visibility-expected.png:
              * platform/mac/fast/forms/input-appearance-visibility-expected.txt:
              * platform/mac/fast/forms/input-appearance-width-expected.checksum:
              * platform/mac/fast/forms/input-appearance-width-expected.png:
              * platform/mac/fast/forms/input-appearance-width-expected.txt:
              * platform/mac/fast/forms/input-baseline-expected.checksum:
              * platform/mac/fast/forms/input-baseline-expected.png:
              * platform/mac/fast/forms/input-baseline-expected.txt:
              * platform/mac/fast/forms/input-disabled-color-expected.checksum:
              * platform/mac/fast/forms/input-disabled-color-expected.png:
              * platform/mac/fast/forms/input-disabled-color-expected.txt:
              * platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.checksum:
              * platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
              * platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
              * platform/mac/fast/forms/input-paste-undo-expected.checksum:
              * platform/mac/fast/forms/input-paste-undo-expected.png:
              * platform/mac/fast/forms/input-paste-undo-expected.txt:
              * platform/mac/fast/forms/input-readonly-autoscroll-expected.checksum:
              * platform/mac/fast/forms/input-readonly-autoscroll-expected.png:
              * platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
              * platform/mac/fast/forms/input-readonly-dimmed-expected.checksum:
              * platform/mac/fast/forms/input-readonly-dimmed-expected.png:
              * platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
              * platform/mac/fast/forms/input-readonly-empty-expected.checksum:
              * platform/mac/fast/forms/input-readonly-empty-expected.png:
              * platform/mac/fast/forms/input-readonly-empty-expected.txt:
              * platform/mac/fast/forms/input-spaces-expected.checksum:
              * platform/mac/fast/forms/input-spaces-expected.png:
              * platform/mac/fast/forms/input-spaces-expected.txt:
              * platform/mac/fast/forms/input-table-expected.txt:
              * platform/mac/fast/forms/input-text-click-inside-expected.checksum:
              * platform/mac/fast/forms/input-text-click-inside-expected.png:
              * platform/mac/fast/forms/input-text-click-inside-expected.txt:
              * platform/mac/fast/forms/input-text-click-outside-expected.checksum:
              * platform/mac/fast/forms/input-text-click-outside-expected.png:
              * platform/mac/fast/forms/input-text-click-outside-expected.txt:
              * platform/mac/fast/forms/input-text-double-click-expected.checksum:
              * platform/mac/fast/forms/input-text-double-click-expected.png:
              * platform/mac/fast/forms/input-text-double-click-expected.txt:
              * platform/mac/fast/forms/input-text-drag-down-expected.checksum:
              * platform/mac/fast/forms/input-text-drag-down-expected.png:
              * platform/mac/fast/forms/input-text-drag-down-expected.txt:
              * platform/mac/fast/forms/input-text-option-delete-expected.checksum:
              * platform/mac/fast/forms/input-text-option-delete-expected.png:
              * platform/mac/fast/forms/input-text-option-delete-expected.txt:
              * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.checksum:
              * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
              * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
              * platform/mac/fast/forms/input-text-self-emptying-click-expected.checksum:
              * platform/mac/fast/forms/input-text-self-emptying-click-expected.png:
              * platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
              * platform/mac/fast/forms/input-text-word-wrap-expected.checksum:
              * platform/mac/fast/forms/input-text-word-wrap-expected.png:
              * platform/mac/fast/forms/input-text-word-wrap-expected.txt:
              * platform/mac/fast/forms/input-type-change2-expected.checksum:
              * platform/mac/fast/forms/input-type-change2-expected.png:
              * platform/mac/fast/forms/input-type-change2-expected.txt:
              * platform/mac/fast/forms/input-type-text-min-width-expected.checksum:
              * platform/mac/fast/forms/input-type-text-min-width-expected.png:
              * platform/mac/fast/forms/input-type-text-min-width-expected.txt:
              * platform/mac/fast/forms/input-value-expected.checksum:
              * platform/mac/fast/forms/input-value-expected.png:
              * platform/mac/fast/forms/input-value-expected.txt:
              * platform/mac/fast/forms/input-width-expected.checksum:
              * platform/mac/fast/forms/input-width-expected.png:
              * platform/mac/fast/forms/input-width-expected.txt:
              * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
              * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
              * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
              * platform/mac/fast/forms/negativeLineHeight-expected.checksum:
              * platform/mac/fast/forms/negativeLineHeight-expected.png:
              * platform/mac/fast/forms/negativeLineHeight-expected.txt:
              * platform/mac/fast/forms/password-placeholder-expected.checksum:
              * platform/mac/fast/forms/password-placeholder-expected.png:
              * platform/mac/fast/forms/password-placeholder-expected.txt:
              * platform/mac/fast/forms/password-placeholder-text-security-expected.checksum:
              * platform/mac/fast/forms/password-placeholder-text-security-expected.png:
              * platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
              * platform/mac/fast/forms/placeholder-pseudo-style-expected.checksum:
              * platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
              * platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
              * platform/mac/fast/forms/placeholder-set-attribute-expected.checksum:
              * platform/mac/fast/forms/placeholder-set-attribute-expected.png:
              * platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
              * platform/mac/fast/forms/placeholder-set-value-expected.checksum:
              * platform/mac/fast/forms/placeholder-set-value-expected.png:
              * platform/mac/fast/forms/placeholder-set-value-expected.txt:
              * platform/mac/fast/forms/search-cancel-button-style-sharing-expected.checksum:
              * platform/mac/fast/forms/search-cancel-button-style-sharing-expected.png:
              * platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
              * platform/mac/fast/forms/search-display-none-cancel-button-expected.checksum:
              * platform/mac/fast/forms/search-display-none-cancel-button-expected.png:
              * platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
              * platform/mac/fast/forms/search-placeholder-value-changed-expected.checksum:
              * platform/mac/fast/forms/search-placeholder-value-changed-expected.png:
              * platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
              * platform/mac/fast/forms/search-rtl-expected.checksum:
              * platform/mac/fast/forms/search-rtl-expected.png:
              * platform/mac/fast/forms/search-rtl-expected.txt:
              * platform/mac/fast/forms/search-transformed-expected.checksum:
              * platform/mac/fast/forms/search-transformed-expected.png:
              * platform/mac/fast/forms/search-transformed-expected.txt:
              * platform/mac/fast/forms/search-zoomed-expected.checksum:
              * platform/mac/fast/forms/search-zoomed-expected.png:
              * platform/mac/fast/forms/search-zoomed-expected.txt:
              * platform/mac/fast/forms/searchfield-heights-expected.checksum:
              * platform/mac/fast/forms/searchfield-heights-expected.png:
              * platform/mac/fast/forms/searchfield-heights-expected.txt:
              * platform/mac/fast/forms/tabbing-input-iframe-expected.checksum:
              * platform/mac/fast/forms/tabbing-input-iframe-expected.png:
              * platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
              * platform/mac/fast/forms/textAreaLineHeight-expected.checksum:
              * platform/mac/fast/forms/textAreaLineHeight-expected.png:
              * platform/mac/fast/forms/textAreaLineHeight-expected.txt:
              * platform/mac/fast/forms/textarea-align-expected.checksum:
              * platform/mac/fast/forms/textarea-align-expected.png:
              * platform/mac/fast/forms/textarea-align-expected.txt:
              * platform/mac/fast/forms/textarea-rows-cols-expected.checksum:
              * platform/mac/fast/forms/textarea-rows-cols-expected.png:
              * platform/mac/fast/forms/textarea-rows-cols-expected.txt:
              * platform/mac/fast/forms/textarea-scroll-height-expected.checksum:
              * platform/mac/fast/forms/textarea-scroll-height-expected.png:
              * platform/mac/fast/forms/textarea-scroll-height-expected.txt:
              * platform/mac/fast/forms/textarea-scrollbar-expected.checksum:
              * platform/mac/fast/forms/textarea-scrollbar-expected.png:
              * platform/mac/fast/forms/textarea-scrollbar-expected.txt:
              * platform/mac/fast/forms/textarea-scrolled-type-expected.checksum:
              * platform/mac/fast/forms/textarea-scrolled-type-expected.png:
              * platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
              * platform/mac/fast/forms/textarea-setinnerhtml-expected.checksum:
              * platform/mac/fast/forms/textarea-setinnerhtml-expected.png:
              * platform/mac/fast/forms/textarea-setinnerhtml-expected.txt:
              * platform/mac/fast/forms/textarea-width-expected.checksum:
              * platform/mac/fast/forms/textarea-width-expected.png:
              * platform/mac/fast/forms/textarea-width-expected.txt:
              * platform/mac/fast/forms/textfield-drag-into-disabled-expected.checksum:
              * platform/mac/fast/forms/textfield-drag-into-disabled-expected.png:
              * platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt:
              * platform/mac/fast/forms/textfield-outline-expected.checksum:
              * platform/mac/fast/forms/textfield-outline-expected.png:
              * platform/mac/fast/forms/textfield-outline-expected.txt:
              * platform/mac/fast/forms/textfield-overflow-expected.checksum:
              * platform/mac/fast/forms/textfield-overflow-expected.png:
              * platform/mac/fast/forms/textfield-overflow-expected.txt:
              * platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
              * platform/mac/fast/invalid/residual-style-expected.txt:
              * platform/mac/fast/lists/dynamic-marker-crash-expected.checksum:
              * platform/mac/fast/lists/dynamic-marker-crash-expected.png:
              * platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
              * platform/mac/fast/overflow/overflow-x-y-expected.checksum:
              * platform/mac/fast/overflow/overflow-x-y-expected.png:
              * platform/mac/fast/overflow/overflow-x-y-expected.txt:
              * platform/mac/fast/parser/comment-in-textarea-expected.checksum:
              * platform/mac/fast/parser/comment-in-textarea-expected.png:
              * platform/mac/fast/parser/comment-in-textarea-expected.txt:
              * platform/mac/fast/parser/entity-comment-in-textarea-expected.checksum:
              * platform/mac/fast/parser/entity-comment-in-textarea-expected.png:
              * platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
              * platform/mac/fast/parser/open-comment-in-textarea-expected.checksum:
              * platform/mac/fast/parser/open-comment-in-textarea-expected.png:
              * platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
              * platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
              * platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
              * platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
              * platform/mac/fast/repaint/search-field-cancel-expected.checksum:
              * platform/mac/fast/repaint/search-field-cancel-expected.png:
              * platform/mac/fast/repaint/search-field-cancel-expected.txt:
              * platform/mac/fast/repaint/subtree-root-skipped-expected.checksum:
              * platform/mac/fast/repaint/subtree-root-skipped-expected.png:
              * platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
              * platform/mac/fast/replaced/replaced-breaking-expected.checksum:
              * platform/mac/fast/replaced/replaced-breaking-expected.png:
              * platform/mac/fast/replaced/replaced-breaking-expected.txt:
              * platform/mac/fast/replaced/replaced-breaking-mixture-expected.checksum:
              * platform/mac/fast/replaced/replaced-breaking-mixture-expected.png:
              * platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
              * platform/mac/fast/replaced/width100percent-searchfield-expected.checksum:
              * platform/mac/fast/replaced/width100percent-searchfield-expected.png:
              * platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
              * platform/mac/fast/replaced/width100percent-textarea-expected.checksum:
              * platform/mac/fast/replaced/width100percent-textarea-expected.png:
              * platform/mac/fast/replaced/width100percent-textarea-expected.txt:
              * platform/mac/fast/replaced/width100percent-textfield-expected.checksum:
              * platform/mac/fast/replaced/width100percent-textfield-expected.png:
              * platform/mac/fast/replaced/width100percent-textfield-expected.txt:
              * platform/mac/fast/table/003-expected.checksum:
              * platform/mac/fast/table/003-expected.png:
              * platform/mac/fast/table/003-expected.txt:
              * platform/mac/fast/table/colspanMinWidth-expected.checksum:
              * platform/mac/fast/table/colspanMinWidth-expected.png:
              * platform/mac/fast/table/colspanMinWidth-expected.txt:
              * platform/mac/fast/table/spanOverlapRepaint-expected.checksum:
              * platform/mac/fast/table/spanOverlapRepaint-expected.png:
              * platform/mac/fast/table/spanOverlapRepaint-expected.txt:
              * platform/mac/fast/table/text-field-baseline-expected.checksum:
              * platform/mac/fast/table/text-field-baseline-expected.png:
              * platform/mac/fast/table/text-field-baseline-expected.txt:
              * platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.checksum:
              * platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.png:
              * platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
              * platform/mac/fast/text/textIteratorNilRenderer-expected.checksum:
              * platform/mac/fast/text/textIteratorNilRenderer-expected.png:
              * platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
              * platform/mac/fast/transforms/transformed-focused-text-input-expected.checksum:
              * platform/mac/fast/transforms/transformed-focused-text-input-expected.png:
              * platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
              * platform/mac/http/tests/navigation/anchor-basic-expected.checksum:
              * platform/mac/http/tests/navigation/anchor-basic-expected.png:
              * platform/mac/http/tests/navigation/anchor-basic-expected.txt:
              * platform/mac/http/tests/navigation/anchor-frames-expected.txt:
              * platform/mac/http/tests/navigation/anchor-goback-expected.checksum:
              * platform/mac/http/tests/navigation/anchor-goback-expected.png:
              * platform/mac/http/tests/navigation/anchor-goback-expected.txt:
              * platform/mac/http/tests/navigation/anchor-subframeload-expected.txt:
              * platform/mac/http/tests/navigation/javascriptlink-basic-expected.checksum:
              * platform/mac/http/tests/navigation/javascriptlink-basic-expected.png:
              * platform/mac/http/tests/navigation/javascriptlink-basic-expected.txt:
              * platform/mac/http/tests/navigation/javascriptlink-frames-expected.checksum:
              * platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
              * platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
              * platform/mac/http/tests/navigation/javascriptlink-goback-expected.checksum:
              * platform/mac/http/tests/navigation/javascriptlink-goback-expected.png:
              * platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt:
              * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.checksum:
              * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.png:
              * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.txt:
              * platform/mac/http/tests/navigation/metaredirect-basic-expected.checksum:
              * platform/mac/http/tests/navigation/metaredirect-basic-expected.png:
              * platform/mac/http/tests/navigation/metaredirect-basic-expected.txt:
              * platform/mac/http/tests/navigation/metaredirect-frames-expected.checksum:
              * platform/mac/http/tests/navigation/metaredirect-frames-expected.png:
              * platform/mac/http/tests/navigation/metaredirect-frames-expected.txt:
              * platform/mac/http/tests/navigation/metaredirect-goback-expected.checksum:
              * platform/mac/http/tests/navigation/metaredirect-goback-expected.png:
              * platform/mac/http/tests/navigation/metaredirect-goback-expected.txt:
              * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.checksum:
              * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.png:
              * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.txt:
              * platform/mac/http/tests/navigation/post-goback2-expected.checksum:
              * platform/mac/http/tests/navigation/post-goback2-expected.png:
              * platform/mac/http/tests/navigation/post-goback2-expected.txt:
              * platform/mac/http/tests/navigation/postredirect-goback2-expected.checksum:
              * platform/mac/http/tests/navigation/postredirect-goback2-expected.png:
              * platform/mac/http/tests/navigation/postredirect-goback2-expected.txt:
              * platform/mac/http/tests/navigation/redirect302-basic-expected.checksum:
              * platform/mac/http/tests/navigation/redirect302-basic-expected.png:
              * platform/mac/http/tests/navigation/redirect302-basic-expected.txt:
              * platform/mac/http/tests/navigation/redirect302-frames-expected.checksum:
              * platform/mac/http/tests/navigation/redirect302-frames-expected.png:
              * platform/mac/http/tests/navigation/redirect302-frames-expected.txt:
              * platform/mac/http/tests/navigation/redirect302-goback-expected.checksum:
              * platform/mac/http/tests/navigation/redirect302-goback-expected.png:
              * platform/mac/http/tests/navigation/redirect302-goback-expected.txt:
              * platform/mac/http/tests/navigation/redirect302-subframeload-expected.checksum:
              * platform/mac/http/tests/navigation/redirect302-subframeload-expected.png:
              * platform/mac/http/tests/navigation/redirect302-subframeload-expected.txt:
              * platform/mac/http/tests/navigation/relativeanchor-basic-expected.checksum:
              * platform/mac/http/tests/navigation/relativeanchor-basic-expected.png:
              * platform/mac/http/tests/navigation/relativeanchor-basic-expected.txt:
              * platform/mac/http/tests/navigation/relativeanchor-frames-expected.txt:
              * platform/mac/http/tests/navigation/relativeanchor-goback-expected.checksum:
              * platform/mac/http/tests/navigation/relativeanchor-goback-expected.png:
              * platform/mac/http/tests/navigation/relativeanchor-goback-expected.txt:
              * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.checksum:
              * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.png:
              * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.txt:
              * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.checksum:
              * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.png:
              * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.txt:
              * platform/mac/http/tests/navigation/success200-basic-expected.checksum:
              * platform/mac/http/tests/navigation/success200-basic-expected.png:
              * platform/mac/http/tests/navigation/success200-basic-expected.txt:
              * platform/mac/http/tests/navigation/success200-frames-expected.checksum:
              * platform/mac/http/tests/navigation/success200-frames-expected.png:
              * platform/mac/http/tests/navigation/success200-frames-expected.txt:
              * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.checksum:
              * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.png:
              * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt:
              * platform/mac/http/tests/navigation/success200-goback-expected.checksum:
              * platform/mac/http/tests/navigation/success200-goback-expected.png:
              * platform/mac/http/tests/navigation/success200-goback-expected.txt:
              * platform/mac/http/tests/navigation/success200-loadsame-expected.checksum:
              * platform/mac/http/tests/navigation/success200-loadsame-expected.png:
              * platform/mac/http/tests/navigation/success200-loadsame-expected.txt:
              * platform/mac/http/tests/navigation/success200-reload-expected.checksum:
              * platform/mac/http/tests/navigation/success200-reload-expected.png:
              * platform/mac/http/tests/navigation/success200-reload-expected.txt:
              * platform/mac/http/tests/navigation/success200-subframeload-expected.checksum:
              * platform/mac/http/tests/navigation/success200-subframeload-expected.png:
              * platform/mac/http/tests/navigation/success200-subframeload-expected.txt:
              * platform/mac/http/tests/navigation/timerredirect-basic-expected.checksum:
              * platform/mac/http/tests/navigation/timerredirect-basic-expected.png:
              * platform/mac/http/tests/navigation/timerredirect-basic-expected.txt:
              * platform/mac/http/tests/navigation/timerredirect-frames-expected.checksum:
              * platform/mac/http/tests/navigation/timerredirect-frames-expected.png:
              * platform/mac/http/tests/navigation/timerredirect-frames-expected.txt:
              * platform/mac/http/tests/navigation/timerredirect-goback-expected.checksum:
              * platform/mac/http/tests/navigation/timerredirect-goback-expected.png:
              * platform/mac/http/tests/navigation/timerredirect-goback-expected.txt:
              * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.checksum:
              * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.png:
              * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.txt:
              * platform/mac/svg/custom/inline-svg-in-xhtml-expected.checksum:
              * platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
              * platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
              * platform/mac/svg/hixie/mixed/003-expected.checksum:
              * platform/mac/svg/hixie/mixed/003-expected.png:
              * platform/mac/svg/hixie/mixed/003-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug1188-expected.png:
              * platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug12384-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug12384-expected.png:
              * platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug18359-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug18359-expected.png:
              * platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug194024-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug194024-expected.png:
              * platform/mac/tables/mozilla/bugs/bug194024-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug24200-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug24200-expected.png:
              * platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug2479-2-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug2479-2-expected.png:
              * platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug2479-3-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug2479-3-expected.png:
              * platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug28928-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug28928-expected.png:
              * platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug30559-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug30559-expected.png:
              * platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug30692-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug30692-expected.png:
              * platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug4382-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug4382-expected.png:
              * platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug4527-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug4527-expected.png:
              * platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug46368-1-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug46368-1-expected.png:
              * platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug46368-2-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug46368-2-expected.png:
              * platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug51037-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug51037-expected.png:
              * platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug55545-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug55545-expected.png:
              * platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug59354-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug59354-expected.png:
              * platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug7342-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug7342-expected.png:
              * platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug96334-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug96334-expected.png:
              * platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug99948-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug99948-expected.png:
              * platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
              * platform/mac/tables/mozilla/dom/tableDom-expected.checksum:
              * platform/mac/tables/mozilla/dom/tableDom-expected.png:
              * platform/mac/tables/mozilla/dom/tableDom-expected.txt:
              * platform/mac/tables/mozilla/other/move_row-expected.checksum:
              * platform/mac/tables/mozilla/other/move_row-expected.png:
              * platform/mac/tables/mozilla/other/move_row-expected.txt:
              * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
              * platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.checksum:
              * platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
              * platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
              * platform/win/Skipped:
              * svg/custom/resources/svg-fonts-in-text-controls.js:
              * svg/custom/svg-fonts-in-text-controls-expected.txt:
              * svg/custom/svg-fonts-in-text-controls.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38f70292
    • eric@webkit.org's avatar
      Reviewed by Dan Bernstein. · 596d7208
      eric@webkit.org authored
              Make textarea and text input metrics more closely match IEs.
              https://bugs.webkit.org/show_bug.cgi?id=15312
      
              This involves:
              -set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
              -set textarea width to cols*avgCharWidth
              -Make default CSS match IEs
              -Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.
      
              Those values for textarea and inputs were derived by doing a ton of manual
              testing of IE's width values for various textareas and fonts.
      
              To get the average and max character width of a font, we do the following
              for each platform:
              -Win: TextMetrics expose avgCharWidth and maxCharWidth
              -SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
                  maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
              -Linux: avgCharWidth = width of an '0', fallback on m_xHeight
                  maxCharWidth = max of avgCharWidth and m_ascent
              -Mac: look in the OS/2 table for avgCharWidth and grab the maxCharWidth off the font.
                  If either one is not there, then calculate the value using the Linux approach.
      
              Linux ports could probably dig into the OS/2 table as well, but I'll leave
              that up to them to implement.
      
              Tests: fast/forms/text-control-intrinsic-widths.html
                     fast/forms/textarea-metrics.html
                     svg/custom/svg-fonts-in-text-controls.html
      
              * css/html4.css:
              * css/themeWin.css:
              * platform/graphics/SimpleFontData.cpp:
              (WebCore::SimpleFontData::SimpleFontData):
              (WebCore::SimpleFontData::initCharWidths):
              * platform/graphics/SimpleFontData.h:
              (WebCore::SimpleFontData::maxCharWidth):
              (WebCore::SimpleFontData::avgCharWidth):
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/chromium/SimpleFontDataLinux.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/gtk/SimpleFontDataGtk.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/gtk/SimpleFontDataPango.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/qt/SimpleFontDataQt.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataCGWin.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataCairoWin.cpp:
              (WebCore::SimpleFontData::platformInit):
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataWin.cpp:
              (WebCore::SimpleFontData::initGDIFont):
              * platform/graphics/wx/SimpleFontDataWx.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::calcPrefWidths):
              * rendering/RenderTextControlMultiLine.cpp:
              (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::preferredContentWidth):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      596d7208
  8. 09 Apr, 2009 1 commit
    • mitz@apple.com's avatar
      WebCore: · aa6ce3d8
      mitz@apple.com authored
      2009-04-09  Dan Bernstein  <mitz@apple.com>
      
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/6166612> Text boxes' metrics should be based on
                the actual fonts used in them, not just the primary font
      
              Covered by many existing layout tests
      
              * platform/graphics/Font.cpp:
              (WebCore::Font::floatWidth): Added a fallbackFonts parameter. If the
              platform supports collecting fallback fonts in its complex font path
              and fallbackFonts is not null, all fallback fonts used for the text run
              will be added to it.
      
              * platform/graphics/Font.h:
              (WebCore::Font::width): Ditto.
      
              * platform/graphics/FontFastPath.cpp:
              (WebCore::Font::glyphDataForCharacter): Removed an unnecessary namespace
              qualifier.
              (WebCore::Font::floatWidthForSimpleText): Added a fallbackFonts
              parameter, which is passed down to WidthIterator.
      
              * platform/graphics/WidthIterator.cpp:
              (WebCore::WidthIterator::WidthIterator): Added a fallbackFonts parameter
              and used it to initialize the m_fallbackFonts member.
              (WebCore::WidthIterator::advance): Track the fonts being used and add
              any fallback fonts to the m_fallbackFonts set. Make sure to only add
              non-small-caps fonts.
      
              * platform/graphics/WidthIterator.h:
      
              * platform/graphics/chromium/FontChromiumWin.cpp:
              (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
              implementation that returns false, meaning this platform's
              implementation of floatWidthForComplexText() does not populate the
              fallbackFonts set.
              (WebCore::Font::floatWidthForComplexText): Updated for the new
              prototype.
      
              * platform/graphics/chromium/FontLinux.cpp: Ditto.
      
              * platform/graphics/gtk/FontGtk.cpp: Ditto.
      
              * platform/graphics/mac/CoreTextController.cpp:
              (WebCore::CoreTextController::CoreTextController): Added a fallbackFonts
              parameter and used it to initialize the m_fallbackFonts member.
              (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Add
              fallback fonts to m_fallbackFonts.
      
              * platform/graphics/mac/CoreTextController.h:
      
              * platform/graphics/mac/FontMac.mm:
              (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
              implementation that returns true, indicating that the Mac
              implementations of floatWidthForComplexText() populate the fallbackFonts
              set.
              * platform/graphics/mac/FontMacATSUI.mm:
              (WebCore::ATSULayoutParameters::ATSULayoutParameters): Added a
              fallbackFonts parameter and used it to initialize the m_fallbackFonts
              member.
              (WebCore::ATSULayoutParameters::initialize): Add fallback fonts to
              m_fallbackFonts.
              (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
              parameter, which is passed down to ATSULayoutParameters.
      
              * platform/graphics/mac/FontMacCoreText.cpp:
              (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
              parameter, which is passed down to CoreTextController.
      
              * platform/graphics/win/FontWin.cpp:
              (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
              implementation that returns true, indicating that the
              UniscribeController-based implementations of floatWidthForComplexText()
              populate the fallbackFonts set.
              (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
              parameter, which is passed down to UniscribeController.
      
              * platform/graphics/win/UniscribeController.cpp:
              (WebCore::UniscribeController::UniscribeController): Added a
              fallbackfonts parameter and used it to initialize m_fallbackFonts.
              (WebCore::UniscribeController::advance): Add fallback fonts to
              m_fallbackFonts.
      
              * platform/graphics/win/UniscribeController.h:
              
              * platform/graphics/wx/FontWx.cpp:
              (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
              implementation that returns false, meaning this platform's
              implementation of floatWidthForComplexText() does not populate the
              fallbackFonts set.
              (WebCore::Font::floatWidthForComplexText): Updated for the new
              prototype.
      
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::computeLogicalBoxHeights): For an InlineTextBox
              with multiple fonts, compute a common baseline and line height by
              considering all fonts' ascents and descents (and line spacing, if
              applicable).
      
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::setFallbackFonts): Added. Temporarily stores
              the set of fallback fonts in a vector.
              (WebCore::InlineTextBox::takeFallbackFonts): Added. Returns the fallback
              fonts previously stored and removes them from storage.
      
              * rendering/InlineTextBox.h:
      
              * rendering/RenderText.cpp:
              (WebCore::RenderText::RenderText): Initialized the
              m_knownNotToUseFallbackFonts to false.
              (WebCore::RenderText::styleDidChange): Reset
              m_knownNotToUseFallbackFonts to false if the style difference is such that
              affects layout.
              (WebCore::RenderText::widthFromCache): Added a fallbackFonts parameter,
              which is passed down to Font::width().
              (WebCore::RenderText::trimmedPrefWidths): Updated for the change to
              widthFromCache().
              (WebCore::RenderText::calcPrefWidths): Made this call a private version
              of calcPrefWidths() that takes a fallbackFonts parameter and set the
              m_knownNotToUseFallbackFonts to true if the set comes back empty.
              The private version passes the fallbackFonts set to widthFromCache().
              (WebCore::RenderText::setText): Reset m_knownNotToUseFallbackFonts to
              false.
              (WebCore::RenderText::createFallbackFontMetricsBox): Added.
              (WebCore::RenderText::width): Added a fallbackFonts parameter, which is
              passed down to calcPrefWidths(), widthFromCache() and Font::width().
              Set m_knownNotToUseFallbackFonts to true when appropriate.
      
              * rendering/RenderText.h:
      
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::constructLine): Added an assertion and a continue
              statement to remove one level of indentation.
              (WebCore::RenderBlock::computeHorizontalPositionsForLine): Temporarily
              store the set of fallback fonts in the InlineTextBox.
              (WebCore::RenderBlock::computeVerticalPositionsForLine): Added an
              assertion.
      
      LayoutTests:
      
      2009-04-09  Dan Bernstein  <mitz@apple.com>
      
              Reviewed by Dave Hyatt.
      
              - updated results for <rdar://problem/6166612> Text boxes' metrics should be based on
                the actual fonts used in them, not just the primary font
      
              * editing/selection/extend-selection-bidi-expected.txt:
              * fast/text/offsetForPosition-cluster-at-zero-expected.txt:
              * platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.checksum:
              * platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.png:
              * platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.txt:
              * platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
              * platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.png:
              * platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt:
              * platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.checksum:
              * platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.png:
              * platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt:
              * platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum:
              * platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.png:
              * platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
              * platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
              * platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
              * platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
              * platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum:
              * platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png:
              * platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
              * platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
              * platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
              * platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
              * platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum:
              * platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png:
              * platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
              * platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum:
              * platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png:
              * platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
              * platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum:
              * platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png:
              * platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
              * platform/mac/css2.1/t0905-c414-flt-02-c-expected.checksum:
              * platform/mac/css2.1/t0905-c414-flt-02-c-expected.png:
              * platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt:
              * platform/mac/css2.1/t0905-c414-flt-03-c-expected.checksum:
              * platform/mac/css2.1/t0905-c414-flt-03-c-expected.png:
              * platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt:
              * platform/mac/css2.1/t0905-c414-flt-04-c-expected.checksum:
              * platform/mac/css2.1/t0905-c414-flt-04-c-expected.png:
              * platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt:
              * platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum:
              * platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png:
              * platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt:
              * platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum:
              * platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.png:
              * platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.txt:
              * platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
              * platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
              * platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
              * platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
              * platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
              * platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
              * platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.checksum:
              * platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png:
              * platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
              * platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum:
              * platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
              * platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
              * platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.checksum:
              * platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.png:
              * platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.txt:
              * platform/mac/css2.1/t090501-c414-flt-01-b-expected.checksum:
              * platform/mac/css2.1/t090501-c414-flt-01-b-expected.png:
              * platform/mac/css2.1/t090501-c414-flt-01-b-expected.txt:
              * platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
              * platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
              * platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
              * platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
              * platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
              * platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt:
              * platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
              * platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
              * platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt:
              * platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
              * platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
              * platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt:
              * platform/mac/css2.1/t1202-counter-03-b-expected.checksum:
              * platform/mac/css2.1/t1202-counter-03-b-expected.png:
              * platform/mac/css2.1/t1202-counter-03-b-expected.txt:
              * platform/mac/css2.1/t1202-counter-04-b-expected.checksum:
              * platform/mac/css2.1/t1202-counter-04-b-expected.png:
              * platform/mac/css2.1/t1202-counter-04-b-expected.txt:
              * platform/mac/css2.1/t1202-counter-09-b-expected.checksum:
              * platform/mac/css2.1/t1202-counter-09-b-expected.png:
              * platform/mac/css2.1/t1202-counter-09-b-expected.txt:
              * platform/mac/css2.1/t1202-counters-03-b-expected.checksum:
              * platform/mac/css2.1/t1202-counters-03-b-expected.png:
              * platform/mac/css2.1/t1202-counters-03-b-expected.txt:
              * platform/mac/css2.1/t1202-counters-04-b-expected.checksum:
              * platform/mac/css2.1/t1202-counters-04-b-expected.png:
              * platform/mac/css2.1/t1202-counters-04-b-expected.txt:
              * platform/mac/css2.1/t1202-counters-09-b-expected.checksum:
              * platform/mac/css2.1/t1202-counters-09-b-expected.png:
              * platform/mac/css2.1/t1202-counters-09-b-expected.txt:
              * platform/mac/editing/deleting/5144139-2-expected.checksum:
              * platform/mac/editing/deleting/5144139-2-expected.png:
              * platform/mac/editing/deleting/5144139-2-expected.txt:
              * platform/mac/editing/input/devanagari-ligature-expected.checksum:
              * platform/mac/editing/input/devanagari-ligature-expected.png:
              * platform/mac/editing/input/devanagari-ligature-expected.txt:
              * platform/mac/editing/pasteboard/copy-paste-bidi-expected.checksum:
              * platform/mac/editing/pasteboard/copy-paste-bidi-expected.png:
              * platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt:
              * platform/mac/editing/selection/caret-rtl-2-expected.checksum:
              * platform/mac/editing/selection/caret-rtl-2-expected.png:
              * platform/mac/editing/selection/caret-rtl-2-expected.txt:
              * platform/mac/editing/selection/caret-rtl-expected.checksum:
              * platform/mac/editing/selection/caret-rtl-expected.png:
              * platform/mac/editing/selection/caret-rtl-expected.txt:
              * platform/mac/editing/selection/extend-selection-bidi-expected.checksum:
              * platform/mac/editing/selection/extend-selection-bidi-expected.png:
              * platform/mac/fast/css/beforeSelectorOnCodeElement-expected.checksum:
              * platform/mac/fast/css/beforeSelectorOnCodeElement-expected.png:
              * platform/mac/fast/css/beforeSelectorOnCodeElement-expected.txt:
              * platform/mac/fast/css/rtl-ordering-expected.checksum:
              * platform/mac/fast/css/rtl-ordering-expected.png:
              * platform/mac/fast/css/rtl-ordering-expected.txt:
              * platform/mac/fast/css/text-overflow-ellipsis-expected.checksum:
              * platform/mac/fast/css/text-overflow-ellipsis-expected.png:
              * platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
              * platform/mac/fast/css/text-security-expected.checksum:
              * platform/mac/fast/css/text-security-expected.png:
              * platform/mac/fast/css/text-security-expected.txt:
              * platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum:
              * platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
              * platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
              * platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
              * platform/mac/fast/encoding/invalid-UTF-8-expected.png:
              * platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
              * platform/mac/fast/events/updateLayoutForHitTest-expected.checksum:
              * platform/mac/fast/events/updateLayoutForHitTest-expected.png:
              * platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
              * platform/mac/fast/forms/select-visual-hebrew-expected.checksum:
              * platform/mac/fast/forms/select-visual-hebrew-expected.png:
              * platform/mac/fast/forms/select-visual-hebrew-expected.txt:
              * platform/mac/fast/forms/select-writing-direction-natural-expected.checksum:
              * platform/mac/fast/forms/select-writing-direction-natural-expected.png:
              * platform/mac/fast/forms/select-writing-direction-natural-expected.txt:
              * platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum:
              * platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
              * platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
              * platform/mac/fast/lists/w3-list-styles-expected.checksum:
              * platform/mac/fast/lists/w3-list-styles-expected.png:
              * platform/mac/fast/lists/w3-list-styles-expected.txt:
              * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum:
              * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png:
              * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
              * platform/mac/fast/text/capitalize-boundaries-expected.checksum:
              * platform/mac/fast/text/capitalize-boundaries-expected.png:
              * platform/mac/fast/text/capitalize-boundaries-expected.txt:
              * platform/mac/fast/text/cg-fallback-bolding-expected.checksum:
              * platform/mac/fast/text/cg-fallback-bolding-expected.png:
              * platform/mac/fast/text/cg-fallback-bolding-expected.txt:
              * platform/mac/fast/text/complex-text-opacity-expected.checksum:
              * platform/mac/fast/text/complex-text-opacity-expected.png:
              * platform/mac/fast/text/complex-text-opacity-expected.txt:
              * platform/mac/fast/text/in-rendered-text-rtl-expected.checksum:
              * platform/mac/fast/text/in-rendered-text-rtl-expected.png:
              * platform/mac/fast/text/in-rendered-text-rtl-expected.txt:
              * platform/mac/fast/text/international/001-expected.checksum:
              * platform/mac/fast/text/international/001-expected.png:
              * platform/mac/fast/text/international/001-expected.txt:
              * platform/mac/fast/text/international/002-expected.checksum:
              * platform/mac/fast/text/international/002-expected.png:
              * platform/mac/fast/text/international/002-expected.txt:
              * platform/mac/fast/text/international/003-expected.checksum:
              * platform/mac/fast/text/international/003-expected.png:
              * platform/mac/fast/text/international/003-expected.txt:
              * platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
              * platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
              * platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
              * platform/mac/fast/text/international/bidi-L2-run-reordering-expected.checksum:
              * platform/mac/fast/text/international/bidi-L2-run-reordering-expected.png:
              * platform/mac/fast/text/international/bidi-L2-run-reordering-expected.txt:
              * platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
              * platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
              * platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
              * platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
              * platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
              * platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
              * platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
              * platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
              * platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
              * platform/mac/fast/text/international/bidi-european-terminators-expected.checksum:
              * platform/mac/fast/text/international/bidi-european-terminators-expected.png:
              * platform/mac/fast/text/international/bidi-european-terminators-expected.txt:
              * platform/mac/fast/text/international/bidi-fallback-font-weight-expected.checksum:
              * platform/mac/fast/text/international/bidi-fallback-font-weight-expected.png:
              * platform/mac/fast/text/international/bidi-fallback-font-weight-expected.txt:
              * platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
              * platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
              * platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
              * platform/mac/fast/text/international/bidi-innertext-expected.checksum:
              * platform/mac/fast/text/international/bidi-innertext-expected.png:
              * platform/mac/fast/text/international/bidi-innertext-expected.txt:
              * platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
              * platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
              * platform/mac/fast/text/international/bidi-linebreak-001-expected.txt:
              * platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
              * platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
              * platform/mac/fast/text/international/bidi-linebreak-002-expected.txt:
              * platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
              * platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
              * platform/mac/fast/text/international/bidi-linebreak-003-expected.txt:
              * platform/mac/fast/text/international/bidi-listbox-atsui-expected.checksum:
              * platform/mac/fast/text/international/bidi-listbox-atsui-expected.png:
              * platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt:
              * platform/mac/fast/text/international/bidi-listbox-expected.checksum:
              * platform/mac/fast/text/international/bidi-listbox-expected.png:
              * platform/mac/fast/text/international/bidi-listbox-expected.txt:
              * platform/mac/fast/text/international/bidi-menulist-expected.checksum:
              * platform/mac/fast/text/international/bidi-menulist-expected.png:
              * platform/mac/fast/text/international/bidi-menulist-expected.txt:
              * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum:
              * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
              * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
              * platform/mac/fast/text/international/bidi-override-expected.checksum:
              * platform/mac/fast/text/international/bidi-override-expected.png:
              * platform/mac/fast/text/international/bidi-override-expected.txt:
              * platform/mac/fast/text/international/hindi-spacing-expected.checksum:
              * platform/mac/fast/text/international/hindi-spacing-expected.png:
              * platform/mac/fast/text/international/hindi-spacing-expected.txt:
              * platform/mac/fast/text/international/rtl-caret-expected.checksum:
              * platform/mac/fast/text/international/rtl-caret-expected.png:
              * platform/mac/fast/text/international/rtl-caret-expected.txt:
              * platform/mac/fast/text/international/thai-line-breaks-expected.checksum:
              * platform/mac/fast/text/international/thai-line-breaks-expected.png:
              * platform/mac/fast/text/international/thai-line-breaks-expected.txt:
              * platform/mac/fast/text/international/wrap-CJK-001-expected.checksum:
              * platform/mac/fast/text/international/wrap-CJK-001-expected.png:
              * platform/mac/fast/text/international/wrap-CJK-001-expected.txt:
              * platform/mac/fast/text/wide-zero-width-space-expected.checksum:
              * platform/mac/fast/text/wide-zero-width-space-expected.png:
              * platform/mac/fast/text/wide-zero-width-space-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa6ce3d8
  9. 10 Mar, 2009 1 commit
    • bdakin@apple.com's avatar
      WebCore: · 01af3029
      bdakin@apple.com authored
      2009-03-10  Beth Dakin  <bdakin@apple.com>
      
              Reviewed by Darin Adler.
      
              Fix for <rdar://problem/6624769> REGRESSION (Safari 4 PB): No 
              scroll bar appears for long line of text with NOWRAP set
      
              This is a regression from http://trac.webkit.org/changeset/32226
              I talked with Dan about the original change, and we decided that 
              the best fix was to remove his small potential-optimization that 
              only created a separate line box for whitespace under certain 
              circumstances. This new code will always create a separate line 
              box.
      
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::layoutInlineChildren):
      
      LayoutTests:
      
      2009-03-10  Beth Dakin  <bdakin@apple.com>
      
              Reviewed by Darin Adler.
      
              Test changes for <rdar://problem/6624769> REGRESSION (Safari 4 PB): 
              No scroll bar appears for long line of text with NOWRAP set
      
              New test:
              * fast/inline/long-wrapped-line.html: Added.
              * platform/mac/fast/inline/long-wrapped-line-expected.checksum: Added.
              * platform/mac/fast/inline/long-wrapped-line-expected.png: Added.
              * platform/mac/fast/inline/long-wrapped-line-expected.txt: Added.
      
              
              These tests all have changed results from the patch. Now trailing 
              whitespace always has its own linebox instead of sometimes sharing 
              a linebox with text.
              * platform/mac/editing/deleting/5206311-1-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-022-expected.txt:
              * platform/mac/editing/deleting/delete-block-table-expected.txt:
              * platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
              * platform/mac/editing/deleting/delete-line-end-ws-001-expected.txt:
              * platform/mac/editing/deleting/delete-line-end-ws-002-expected.txt:
              * platform/mac/editing/deleting/delete-to-select-table-expected.txt:
              * platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt:
              * platform/mac/editing/deleting/delete-ws-fixup-002-expected.txt:
              * platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
              * platform/mac/editing/deleting/forward-delete-expected.txt:
              * platform/mac/editing/execCommand/5482023-expected.txt:
              * platform/mac/editing/execCommand/boldSelection-expected.txt:
              * platform/mac/editing/execCommand/italicizeByCharacter-expected.txt:
              * platform/mac/editing/execCommand/modifyForeColorByCharacter-expected.txt:
              * platform/mac/editing/execCommand/print-expected.txt:
              * platform/mac/editing/execCommand/selectAll-expected.txt:
              * platform/mac/editing/execCommand/strikethroughSelection-expected.txt:
              * platform/mac/editing/input/emacs-ctrl-o-expected.txt:
              * platform/mac/editing/inserting/12882-expected.txt:
              * platform/mac/editing/inserting/editable-html-element-expected.txt:
              * platform/mac/editing/inserting/insert-div-019-expected.txt:
              * platform/mac/editing/inserting/insert-div-020-expected.txt:
              * platform/mac/editing/inserting/insert-div-021-expected.txt:
              * platform/mac/editing/inserting/insert-div-022-expected.txt:
              * platform/mac/editing/inserting/insert-div-023-expected.txt:
              * platform/mac/editing/inserting/insert-div-024-expected.txt:
              * platform/mac/editing/inserting/insert-div-025-expected.txt:
              * platform/mac/editing/inserting/insert-div-027-expected.txt:
              * platform/mac/editing/inserting/typing-003-expected.txt:
              * platform/mac/editing/pasteboard/4989774-expected.txt:
              * platform/mac/editing/pasteboard/5028447-expected.txt:
              * platform/mac/editing/pasteboard/merge-end-3-expected.txt:
              * platform/mac/editing/pasteboard/paste-table-003-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-012-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-013-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-014-expected.txt:
              * platform/mac/editing/selection/4947387-expected.txt:
              * platform/mac/editing/selection/4983858-expected.txt:
              * platform/mac/editing/selection/5081257-1-expected.txt:
              * platform/mac/editing/selection/5081257-2-expected.txt:
              * platform/mac/editing/selection/5136696-expected.txt:
              * platform/mac/editing/selection/5234383-1-expected.txt:
              * platform/mac/editing/selection/5234383-2-expected.txt:
              * platform/mac/editing/selection/7152-1-expected.txt:
              * platform/mac/editing/selection/7152-2-expected.txt:
              * platform/mac/editing/selection/after-line-wrap-expected.txt:
              * platform/mac/editing/selection/click-start-of-line-expected.txt:
              * platform/mac/editing/selection/drag-in-iframe-expected.txt:
              * platform/mac/editing/selection/editable-html-element-expected.txt:
              * platform/mac/editing/selection/editable-non-editable-crash-expected.txt:
              * platform/mac/editing/selection/end-of-document-expected.txt:
              * platform/mac/editing/selection/extend-by-character-003-expected.txt:
              * platform/mac/editing/selection/extend-by-character-005-expected.txt:
              * platform/mac/editing/selection/extend-by-word-002-expected.txt:
              * platform/mac/editing/selection/mixed-editability-1-expected.txt:
              * platform/mac/editing/selection/move-by-character-003-expected.txt:
              * platform/mac/editing/selection/move-by-character-005-expected.txt:
              * platform/mac/editing/selection/select-all-001-expected.txt:
              * platform/mac/editing/selection/select-all-002-expected.txt:
              * platform/mac/editing/selection/select-all-003-expected.txt:
              * platform/mac/editing/selection/wrapped-line-caret-1-expected.txt:
              * platform/mac/editing/selection/wrapped-line-caret-2-expected.txt:
              * platform/mac/editing/style/apple-style-editable-mix-expected.txt:
              * platform/mac/editing/style/create-block-for-style-001-expected.txt:
              * platform/mac/editing/style/create-block-for-style-002-expected.txt:
              * platform/mac/editing/style/create-block-for-style-003-expected.txt:
              * platform/mac/editing/style/create-block-for-style-004-expected.txt:
              * platform/mac/editing/style/create-block-for-style-005-expected.txt:
              * platform/mac/editing/style/create-block-for-style-006-expected.txt:
              * platform/mac/editing/style/create-block-for-style-007-expected.txt:
              * platform/mac/editing/style/create-block-for-style-008-expected.txt:
              * platform/mac/editing/style/create-block-for-style-009-expected.txt:
              * platform/mac/editing/style/create-block-for-style-010-expected.txt:
              * platform/mac/editing/style/create-block-for-style-011-expected.txt:
              * platform/mac/editing/style/create-block-for-style-012-expected.txt:
              * platform/mac/editing/style/create-block-for-style-013-expected.txt:
              * platform/mac/editing/style/relative-font-size-change-001-expected.txt:
              * platform/mac/editing/style/relative-font-size-change-002-expected.txt:
              * platform/mac/editing/style/relative-font-size-change-003-expected.txt:
              * platform/mac/editing/style/relative-font-size-change-004-expected.txt:
              * platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
              * platform/mac/editing/undo/undo-combined-delete-expected.txt:
              * platform/mac/editing/undo/undo-delete-boundary-expected.txt:
              * platform/mac/editing/undo/undo-delete-expected.txt:
              * platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
              * platform/mac/editing/undo/undo-forward-delete-expected.txt:
              * platform/mac/fast/block/float/editable-text-overlapping-float-expected.txt:
              * platform/mac/fast/clip/outline-overflowClip-expected.txt:
              * platform/mac/fast/forms/negativeLineHeight-expected.txt:
              * platform/mac/fast/forms/textAreaLineHeight-expected.txt:
              * platform/mac/fast/forms/textarea-rows-cols-expected.txt:
              * platform/mac/fast/lists/drag-into-marker-expected.txt:
              * platform/mac/fast/parser/comment-in-textarea-expected.txt:
              * platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
              * platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
              * platform/mac/fast/repaint/inline-outline-repaint-expected.txt:
              * platform/mac/fast/repaint/selection-after-delete-expected.txt:
              * platform/mac/fast/repaint/selection-after-remove-expected.txt:
              * platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
              * platform/mac/fast/text/trailing-white-space-expected.txt:
              * platform/mac/fast/text/whitespace/pre-wrap-line-test-expected.txt:
              * platform/mac/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
              * platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
              * platform/mac/fast/text/whitespace/tab-character-basics-expected.txt:
              * platform/mac/http/tests/navigation/anchor-goback-expected.txt:
              * platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt:
              * platform/mac/http/tests/navigation/metaredirect-goback-expected.txt:
              * platform/mac/http/tests/navigation/post-goback2-expected.txt:
              * platform/mac/http/tests/navigation/postredirect-goback2-expected.txt:
              * platform/mac/http/tests/navigation/redirect302-goback-expected.txt:
              * platform/mac/http/tests/navigation/success200-goback-expected.txt:
              * platform/mac/http/tests/navigation/timerredirect-goback-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01af3029
  10. 05 Mar, 2009 1 commit
    • justin.garcia@apple.com's avatar
      WebCore: · 0e8bd790
      justin.garcia@apple.com authored
      2009-03-05  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin Adler.
              
              WebViewDidChangeSelectionNotifications weren't being sent for commands that change the selection's position
              within the document without changing its position in the DOM.  For example, pressing return in (caret marked by ^):
              <div contentEditable="true"><div>^Hello</div></div>
              Undo was being enabled, shouldDeleteDOMRange called, etc. when doing no-op deletes (a delete in an empty document 
              for example). 
      
              Changes to layout tests demonstrate fix.
              
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::apply): Don't call applyEditing for a TypingCommand.  The TypingCommand knows whether or
              not it did work that needs to be applied.
              * editing/Editor.cpp:
              (WebCore::Editor::appliedEditing): Moved code (but did not alter) to changeSelectionAfterCommand.
              (WebCore::Editor::unappliedEditing): Ditto.
              (WebCore::Editor::reappliedEditing): Ditto.
              (WebCore::Editor::changeSelectionAfterCommand): Moved code from *appliedEditing into here.  Also call out to
              EditorClient::respondToChangedSelection() for commands that changed the selection's position in the document
              even if they did not change it's position in the DOM.  Any TypingCommand that gets this far changed it's position
              in the document.
              * editing/Editor.h:
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::TypingCommand): Removed unused m_appliedEditing.
              (WebCore::TypingCommand::typingAddedToOpenCommand): Always apply editing.  We won't get this far if we don't need to.
              (WebCore::TypingCommand::deleteKeyPressed): Don't do any of the things that only make sense for Range selections, like
              adding to the killring and responding to a change in selections if the delete was a no-op.
              (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
              * editing/TypingCommand.h:
      
      LayoutTests:
      
      2009-03-05  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin Adler.
              
              WebViewDidChangeSelectionNotification isn't always called.
              Undo was enabled, shouldDeleteDOMRange was called, etc. for no-op backward and forward deletes.
      
              * platform/mac/editing/deleting/delete-4038408-fix-expected.txt:
              * platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
              * platform/mac/editing/deleting/delete-br-002-expected.txt:
              * platform/mac/editing/deleting/delete-br-004-expected.txt:
              * platform/mac/editing/deleting/delete-br-005-expected.txt:
              * platform/mac/editing/deleting/delete-br-006-expected.txt:
              * platform/mac/editing/deleting/delete-br-009-expected.txt:
              * platform/mac/editing/deleting/delete-br-010-expected.txt:
              * platform/mac/editing/deleting/delete-hr-expected.txt:
              * platform/mac/editing/deleting/delete-tab-004-expected.txt:
              * platform/mac/editing/deleting/forward-delete-expected.txt:
              * platform/mac/editing/deleting/merge-into-empty-block-1-expected.txt:
              * platform/mac/editing/deleting/merge-into-empty-block-2-expected.txt:
              * platform/mac/editing/inserting/editing-empty-divs-expected.txt:
              * platform/mac/editing/inserting/insert-3800346-fix-expected.txt:
              * platform/mac/editing/inserting/insert-br-004-expected.txt:
              * platform/mac/editing/inserting/insert-br-005-expected.txt:
              * platform/mac/editing/inserting/insert-br-006-expected.txt:
              * platform/mac/editing/inserting/insert-br-008-expected.txt:
              * platform/mac/editing/inserting/insert-div-006-expected.txt:
              * platform/mac/editing/inserting/insert-div-008-expected.txt:
              * platform/mac/editing/inserting/insert-div-010-expected.txt:
              * platform/mac/editing/inserting/insert-div-011-expected.txt:
              * platform/mac/editing/inserting/insert-div-013-expected.txt:
              * platform/mac/editing/inserting/insert-div-015-expected.txt:
              * platform/mac/editing/inserting/insert-div-019-expected.txt:
              * platform/mac/editing/inserting/insert-div-021-expected.txt:
              * platform/mac/editing/inserting/insert-paragraph-01-expected.txt:
              * platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
              * platform/mac/editing/inserting/insert-paragraph-05-expected.txt:
              * platform/mac/editing/inserting/insert-tab-004-expected.txt:
              * platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
              * platform/mac/editing/inserting/line-break-expected.txt:
              * platform/mac/editing/pasteboard/3976872-expected.txt:
              * platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
              * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-010-expected.txt:
              * platform/mac/editing/style/block-style-006-expected.txt:
              * platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
              * platform/mac/editing/undo/undo-combined-delete-expected.txt:
              * platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
              * platform/mac/editing/undo/undo-forward-delete-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e8bd790
  11. 13 Feb, 2009 1 commit
  12. 06 Feb, 2009 1 commit
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · 73ecea19
      ap@webkit.org authored
              <rdar://problem/6438271> Improve backspace handling of accented characters
      
              Test: platform/mac/editing/deleting/backward-delete.html
      
              This change makes WebKit behave like AppKit on the Mac. Other platforms are not affected,
              because the current behavior matches their standards (tested on Windows, assumed elsewhere).
      
              * dom/Position.cpp:
              (WebCore::Position::previous):
              (WebCore::Position::next):
              (WebCore::Position::uncheckedPreviousOffsetForBackwardDeletion):
              * dom/Position.h:
              Added a new option for previous(), used to move to a next position for backward deletion.
              Renamed EUsingComposedCharacters to PositionMoveType.
      
              * editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed):
              Use previous(BackwardDeletion) to find a proper range to delete. Also, simplified a check
              surrounding this code a little.
      
              * editing/htmlediting.cpp:
              (WebCore::nextVisuallyDistinctCandidate):
              (WebCore::previousVisuallyDistinctCandidate):
              Adjusted for renamed enum values.
      
              * rendering/RenderObject.cpp:
              * rendering/RenderObject.h:
              * rendering/RenderText.h:
              Added previousOffsetForBackwardDeletion().
      
              * rendering/RenderText.cpp: (WebCore::RenderText::previousOffsetForBackwardDeletion):
              On PLATFORM(MAC), use an algorithm that matches the one AppKit has for backward deletion.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      73ecea19
  13. 31 Jan, 2009 1 commit
  14. 21 Nov, 2008 1 commit
    • justin.garcia@apple.com's avatar
      WebCore: · e248230a
      justin.garcia@apple.com authored
      2008-11-21  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin Adler.
      
              <rdar://problem/5381788> Match NSTextView editing behavior at the end of hyperlink text
              
              Change link editing behavior to match TextEdit and MS Word when editing before and after 
              a link (Pages has two caret positions at link boundaries, Thunderbird and FF behave like we 
              used to, so it's difficult to get out of link editing mode):
              When inserting before or after a link, always insert content outside of the link.  This
              makes it impossible to get stuck in link editing mode, while making it slightly more 
              difficult to edit link labels.  WebKit editors that care about this can add UI for editing 
              link labels, like GMail and GoogleDocs have done.  We never actually had any bugs complaining
              about how it was difficult to edit link labels at the start/end, the code was just introduced 
              with another bug fix without much thought.
              
              Don't remember removed links anymore, no other editor does this and it made it 
              difficult/impossible to get out of link editing mode.  This code was added to fix
              <rdar://problem/4069359>, which is fixed instead by removing the styles from an 
              enclosing anchor element from those styles that we remember when we delete content.
      
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
              * editing/CompositeEditCommand.h:
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::removeEnclosingAnchorStyle):
              (WebCore::DeleteSelectionCommand::saveTypingStyleState):
              (WebCore::DeleteSelectionCommand::doApply):
              * editing/DeleteSelectionCommand.h:
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::apply):
              * editing/Editor.cpp:
              (WebCore::Editor::appliedEditing):
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::prepareForTextInsertion):
              (WebCore::InsertTextCommand::input):
              * editing/RemoveFormatCommand.cpp:
              (WebCore::RemoveFormatCommand::doApply):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::setSelection):
              * editing/SelectionController.h:
      
      LayoutTests:
      
      2008-11-21  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin Adler.
              
              <rdar://problem/5381788> Match NSTextView editing behavior at the end of hyperlink text
              
              Removed tests for behaviors that we're no longer interested in:
              * editing/deleting/delete-link-1.html: Removed.
              * platform/mac/editing/deleting/delete-link-1-expected.checksum: Removed.
              * platform/mac/editing/deleting/delete-link-1-expected.png: Removed.
              * platform/mac/editing/deleting/delete-link-1-expected.txt: Removed.
              * editing/execCommand/19653-4-expected.txt: Removed.
              * editing/execCommand/19653-4.html: Removed.
              
              Reflects new behavior (don't remember removed anchors):
              * platform/mac/editing/deleting/5168598-expected.txt:
              
              Reflects new behavior.  Also made this test cross-platform:
              * editing/inserting/insert-before-link-1-expected.txt: Added.
              * editing/inserting/insert-before-link-1.html:
              * platform/mac/editing/inserting/insert-before-link-1-expected.checksum: Removed.
              * platform/mac/editing/inserting/insert-before-link-1-expected.png: Removed.
              * platform/mac/editing/inserting/insert-before-link-1-expected.txt: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e248230a
  15. 20 Nov, 2008 1 commit
    • justin.garcia@apple.com's avatar
      WebCore: · ba2601a0
      justin.garcia@apple.com authored
      2008-11-20  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Beth Dakin.
              
              Preparation for:
              <rdar://problem/2610675> Blank line that is quoted can't be deleted
              
              To fix this we need to make changes to the code that creates selections to delete
              when the user does a backward or forward delete with a caret selection.  For certain
              caret positions, we now want to remove something other than the standard "caret extended
              backward/forward by one unit".  The problem is that there were two pieces of code 
              responsible for doing this, one in Editor::deleteWithDirection, and another inside 
              TypingCommand::deleteKeyPressed.  The code in deleteWithDirection is a recent 
              addition (r19172), and adding it there caused regressions because it prevented the 
              code in deleteKeyPressed from ever running.  The regressions were never caught because 
              JS deletion uses deleteKeyPressed while manual deletion uses deleteWithDirection.
              
              This patch removes selection creation code from deleteWithDirection so that deleteKeyPressed
              can handle it.  That required moving code to handle the kill ring down into deleteKeyPressed.
              
              Follow up patches will fix <rdar://problem/2610675>, and attempt to eliminate the rest of the 
              discrepancies between the behavior of JS deletions and manual deletions, so that we 
              have better test coverage.
      
              * editing/Editor.cpp:
              (WebCore::Editor::deleteWithDirection): Early return if m_frame->document() is null, instead
              of checking for that periodically throughout the function.  There's really nothing to be done
              if it's null anyway.
              Move kill ring code down into deleteKeyPressed.
              * editing/Editor.h:
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::TypingCommand):
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              (WebCore::TypingCommand::doApply):
              * editing/TypingCommand.h:
              (WebCore::TypingCommand::create):
      
      LayoutTests:
      
      2008-11-20  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Beth Dakin.
              
              <rdar://problem/2610675> Blank line that is quoted can't be deleted
              
              The old selection modification code for caret case deletions set the selection
              about to be deleted on the frame, instead of just setting the endingSelection.
      
              * platform/mac/editing/deleting/delete-by-word-001-expected.txt:
              * platform/mac/editing/deleting/delete-by-word-002-expected.txt:
              * platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt:
              * platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
              * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba2601a0
  16. 12 Nov, 2008 1 commit
    • justin.garcia@apple.com's avatar
      WebCore: · 7e95c7be
      justin.garcia@apple.com authored
      2008-11-12  Justin Garcia  <justin.garcia@apple.com>
       
              Reviewed by Beth Dakin.
       
              <rdar://problem/5495723> Selecting and deleting quoted text quotes other text
              <rdar://problem/4775313> Deleting lines from the bottom of a messages leaves the last blank line quoted
              
              We don't want to merge into a block if it will mean changing the quote level of content after deleting 
              selections that contain a whole number paragraphs plus a line break, since it is unclear to most users 
              that such a selection actually ends at the start of the next paragraph.  Instead we want to completely
              remove the selected paragraph(s) and all evidence of the first one's quote level.  This matches TextEdit behavior 
              for indented paragraphs.
       
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializePositionData): For the selections described above, do not
              try to merge after the deletion.  Instead try and prune the start block or blocks if they've been emptied
              so that we remove evidence of the deleted paragraphs' quote level.
              (WebCore::DeleteSelectionCommand::mergeParagraphs): Try and prune the start block(s) if necessary.  Also 
              make sure that the caret is placed correctly so that it ends up on the same line that the deleted selection 
              started on, instead of one higher.
              * editing/DeleteSelectionCommand.h:
              * editing/htmlediting.cpp:
              (WebCore::numEnclosingMailBlockquotes): Added.
              * editing/htmlediting.h:
      
      LayoutTests:
      
      2008-11-12  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Beth Dakin.
              
              <rdar://problem/5495723> Selecting and deleting quoted text quotes other text
              <rdar://problem/4775313> Deleting lines from the bottom of a messages leaves the last blank line quoted
      
              * editing/deleting/5495723-expected.txt: Added.
              * editing/deleting/5495723.html: Added.
              * platform/mac/editing/deleting/delete-4038408-fix-expected.txt: Change demonstrates that we
              now behave correctly when pressing delete when the caret is just after empty quoted paragraphs.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e95c7be
  17. 05 Nov, 2008 1 commit
  18. 19 Jun, 2008 1 commit
    • justin.garcia@apple.com's avatar
      WebCore: · d1eac9a5
      justin.garcia@apple.com authored
      2008-06-19  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by John.
      
              <https://bugs.webkit.org/show_bug.cgi?id=19653>
              Typing style lost when creating list from, indenting or outdenting an empty paragraph
              
              There were two problems.  First, moveParagraphs didn't preserve the style of empty paragraphs.
              Second, indent, outdent and list creation returned false from preservesTypingStyle.
              The second problem couldn't be fixed by just adding preservesTypingStyle() { return true; }
              to those commands, though, because of other bugs.
              
              Cleaned up the implementation of typing style enough to remove FIXMEs for:
              
              <rdar://problem/3769899> Implementation of typing style needs improvement 
              
              which has actually been closed for some time now anyway.
              
              * dom/Document.cpp: Removed an unused header.
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::moveParagraphs): Preserve the style of an empty paragraph, too.
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::saveTypingStyleState): Removed FIXME.
              (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): 
              Removed FIXME.  
              If there is a typing style to apply after a delete, apply it to any line break that acts as a paragraph
              placeholder, not only one that was inserted by deletion.  This fixes a bug where deleting
              <div><b>Bold</b><br></div>, changing the selection and then coming back and typing wouldn't 
              produce bold text.  
              Don't set the EditCommand's typingStyle, it has been removed (more on that later).
              (WebCore::DeleteSelectionCommand::doApply): We don't need to pass calculateTypingStyleAfterDelete
              the inserted placeholder because it will find it.
              (WebCore::DeleteSelectionCommand::preservesTypingStyle): Normally deletion doesn't preserve the 
              typing style that was present before it.  For example, type a character, Bold, then delete the 
              character and start typing.  The Bold typing style shouldn't stick around.  We got this right before 
              purely by chance. Deletion should preserve a typing style that *it* sets, however.
              * editing/DeleteSelectionCommand.h: No longer need to pass calculateTypingStyleAfterDelete
              the inserted placeholder.
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::apply): 
              Clearing or not clearing a removed anchor should not be determined by whether or not a command 
              preservesTypingStyle().  For example, the deletion that removed an anchor (and stored it), may 
              not preserve the typing style, but that doesn't mean that it should then go and clear the removed 
              anchor.  All high level commands, and all commands that a TypingCommand spawns, except for
              text insertions, which should restore a removed anchor, should clear it.
              There is no longer a typing style on EditCommand, removed code that cleared it.  Code that clears the 
              *actual* typing style is now in Editor::appliedEditing, just like before.
              There is no longer a typing style on EditCommand, removed code to set one.
              (WebCore::EditCommand::styleAtPosition): Removed FIXME.
              * editing/EditCommand.h: 
              Removed code assosiated with m_typingStyle.
              Made preservesTypingStyle() public, so that we can call it from Editor::appliedEditing().
              * editing/Editor.cpp:
              (WebCore::Editor::appliedEditing):
              Removed code to preserve the removedAnchor during the call to setSelection, because we no longer
              request to clear the typing style with that call.  Also removed the FIXME about this.
              Before, a command would set the Frame's typing style by setting its own typingStyle, and then 
              letting code here, in appliedEditing pick that up and set it on the Frame.  Now, the command 
              itself sets the Frame's typing style.  Deletion is the only command that does this right now.
              * editing/IndentOutdentCommand.h:
              (WebCore::IndentOutdentCommand::preservesTypingStyle): Added, returns true.
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::doApply): Removed FIXME.
              * editing/InsertListCommand.h:
              (WebCore::InsertListCommand::preservesTypingStyle): Added.
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::applyStyleAfterInsertion): Removed FIXME.
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::input): Removed FIXME.
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply): Removed FIXME and also added one about clearing
              the typing style here.  It seems like it's something that could wait until after the command
              has been performed, since there is no code between this point and the end of the operation
              that queries or uses the typing style.
      
      LayoutTests:
      
      2008-06-19  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by John.
              
              https://bugs.webkit.org/show_bug.cgi?id=19653
              Typing style lost when creating list from, indenting or outdenting an empty paragraph
      
              These demonstrate fixes:
              * editing/execCommand/19653-1-expected.txt: Added.
              * editing/execCommand/19653-1.html: Added.
              * editing/execCommand/19653-2-expected.txt: Added.
              * editing/execCommand/19653-2.html: Added.
              * editing/execCommand/19653-3-expected.txt: Added.
              * editing/execCommand/19653-3.html: Added.
              * editing/execCommand/19653-4-expected.txt: Added.
              * editing/execCommand/19653-4.html: Added.
              Changed to an equivalent but more bloated DOM because of a pre-existing bug in ApplyStyleCommand:
              * platform/mac/editing/deleting/delete-br-011-expected.txt:
              Fixed a bug where the typing style wasn't applied to the placeholder in an empty paragraph,
              so typing would create text with the right style, but if you were to change the selection
              and then come back and start typing, the style would be wrong.  The size of the caret was
              also wrong as a result:
              * platform/mac/editing/deleting/delete-br-012-expected.txt:
              * platform/mac/editing/deleting/delete-br-012-expected.png:
              * platform/mac/editing/deleting/delete-br-012-expected.checksum:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@34681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1eac9a5
  19. 18 Apr, 2008 1 commit
    • mitz@apple.com's avatar
      WebCore: · c13ea5f8
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=17921
                Extra white space at the end of right-aligned or justified text with -webkit-line-break: after-white-space
      
              Test: fast/text/trailing-white-space.html
      
              Made trailing white space on the line always behave like it has the base
              bidi level of the block, meaning it will always go on the right (left)
              of the line in a left-to-right (right-to-left) block. Made the trailing
              white space vanish when it is next to a margin that the text should
              be touching, and made its width not count when computing the center
              point for center alignment.
      
              * platform/text/BidiResolver.h:
              (WebCore::::prependRun): Added.
              * rendering/RenderBlock.h:
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::computeHorizontalPositionsForLine): Changed the
              logicallyLastRun parameter to an optional trailingSpaceRun and changed
              the alignment logic to implement the above rules.
              (WebCore::RenderBlock::layoutInlineChildren): Added code to identify
              when there is trailing white space that needs to be split into its own
              run and optionally re-ordered.
              (WebCore::RenderBlock::findNextLineBreak): Removed code that split some
              trailing space into a separate run in one special case.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test and updated results for https://bugs.webkit.org/show_bug.cgi?id=17921
                Extra white space at the end of right-aligned or justified text with -webkit-line-break: after-white-space
      
              * fast/text/trailing-white-space.html: Added.
              * http/tests/misc/acid3-expected.txt:
              * platform/mac/editing/deleting/delete-block-table-expected.txt:
              * platform/mac/editing/deleting/delete-to-select-table-expected.txt:
              * platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
              * platform/mac/editing/execCommand/5482023-expected.txt:
              * platform/mac/editing/execCommand/boldSelection-expected.txt:
              * platform/mac/editing/execCommand/italicizeByCharacter-expected.txt:
              * platform/mac/editing/execCommand/modifyForeColorByCharacter-expected.txt:
              * platform/mac/editing/execCommand/print-expected.txt:
              * platform/mac/editing/execCommand/selectAll-expected.txt:
              * platform/mac/editing/execCommand/strikethroughSelection-expected.txt:
              * platform/mac/editing/inserting/editable-html-element-expected.txt:
              * platform/mac/editing/inserting/insert-div-027-expected.txt:
              * platform/mac/editing/pasteboard/5028447-expected.txt:
              * platform/mac/editing/pasteboard/block-wrappers-necessary-expected.checksum:
              * platform/mac/editing/pasteboard/block-wrappers-necessary-expected.png:
              * platform/mac/editing/pasteboard/block-wrappers-necessary-expected.txt:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.png:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.txt:
              * platform/mac/editing/selection/5081257-1-expected.txt:
              * platform/mac/editing/selection/after-line-wrap-expected.txt:
              * platform/mac/editing/selection/mixed-editability-1-expected.txt:
              * platform/mac/editing/selection/select-all-001-expected.txt:
              * platform/mac/editing/selection/select-all-002-expected.txt:
              * platform/mac/editing/selection/select-all-003-expected.txt:
              * platform/mac/editing/style/apple-style-editable-mix-expected.txt:
              * platform/mac/editing/style/create-block-for-style-012-expected.checksum:
              * platform/mac/editing/style/create-block-for-style-012-expected.png:
              * platform/mac/editing/style/create-block-for-style-012-expected.txt:
              * platform/mac/fast/clip/outline-overflowClip-expected.txt:
              * platform/mac/fast/forms/textarea-rows-cols-expected.txt:
              * platform/mac/fast/replaced/width100percent-textarea-expected.txt:
              * platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
              * platform/mac/fast/text/justified-text-rect-expected.txt:
              * platform/mac/fast/text/trailing-white-space-expected.checksum: Added.
              * platform/mac/fast/text/trailing-white-space-expected.png: Added.
              * platform/mac/fast/text/trailing-white-space-expected.txt: Added.
              * platform/mac/fast/text/whitespace/pre-wrap-last-char-expected.txt:
              * platform/mac/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
              * platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@32226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c13ea5f8
  20. 15 Feb, 2008 1 commit
    • justin.garcia@apple.com's avatar
      WebCore: · 16711cb5
      justin.garcia@apple.com authored
              Reviewed by Dan Bernstein.
      
              <rdar://problem/5738768> REGRESSION (r30062): Crash in InlineTextBox::isLineBreak() when Undoing a replace
              
              Rolled out <http://trac.webkit.org/projects/webkit/changeset/29667>
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::nodeWillBeRemoved):
      
      LayoutTests:
      
              Reviewed by Dan Bernstein.
              
              <rdar://problem/5738768> REGRESSION (r30062): Crash in InlineTextBox::isLineBreak() when Undoing a replace
              
              Disabled:
              * editing/selection/inconsistent-in-removeChildNode.html: Removed.
              * editing/selection/inconsistent-in-removeChildNode.html-disabled: Added.
              
              Demonstrates fix:
              * editing/undo/5738768-expected.txt: Added.
              * editing/undo/5738768.html: Added.
              
              During a shouldChangeSelection call, the old selection is no longer null because
              nodeWillBeRemoved doesn't blow it away:
              * platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
              * platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
              * platform/mac/editing/style/remove-underline-in-bold-expected.txt:
      
              During a shouldChangeSelection call, the old selection is now null because
              nodeWillBeRemoved blows it away:
              * platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
              
              More instances of <rdar://problem/5729315>, where, during a shouldChangeSelection 
              call content that held the old selection is still around but it wouldn't make sense
              to leave the selection there, so we shouldn't call shouldChangeSelection at all:
              * platform/mac/editing/style/remove-underline-expected.txt:
              * platform/mac/editing/style/unbold-in-bold-expected.txt:
      
              Similar changes, but ones where I've also updated pixel results for old, unrelated fixes:
              * platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt:
              * platform/mac/editing/deleting/delete-leading-ws-001-expected.checksum:
              * platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
              * platform/mac/editing/deleting/delete-line-011-expected.checksum:
              * platform/mac/editing/deleting/delete-line-011-expected.txt:
              * platform/mac/editing/execCommand/paste-1-expected.checksum:
              * platform/mac/editing/execCommand/paste-1-expected.txt:
              * platform/mac/editing/execCommand/paste-2-expected.checksum:
              * platform/mac/editing/execCommand/paste-2-expected.txt:
              * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.checksum:
              * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
              * platform/mac/editing/pasteboard/paste-RTFD-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-012-expected.checksum:
              * platform/mac/editing/selection/4960116-expected.checksum:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16711cb5
  21. 13 Feb, 2008 1 commit
    • justin.garcia@apple.com's avatar
      WebCore: · 0f2d8fe0
      justin.garcia@apple.com authored
              Reviewed by Oliver Hunt.
      
              Fixes the editing/deleting/5729680.html failure.  It succeeds when run by itself
              but fails when run with other tests because FramePrivate's m_selectionGranularity
              isn't reset when a Frame receives a new document.  It was also uninitialized in
              the constructor.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::clear): Initialize m_selectionGranularity.
              * page/Frame.cpp:
              (WebCore::FramePrivate::FramePrivate): Ditto.
      
      LayoutTests:
      
              Reviewed by Oliver Hunt.
      
              * platform/mac/editing/deleting/table-cells-expected.checksum: Fixed.  Before, a space was 
              incorrectly removed by a delete (this isn't a smart delete).
              * platform/mac/editing/deleting/table-cells-expected.png:
              * platform/mac/editing/deleting/table-cells-expected.txt:
              * platform/mac/editing/pasteboard/input-field-1-expected.checksum: Fixed.  Before a space 
              was incorrectly added by paste (this isn't a smart paste).
              * platform/mac/editing/pasteboard/input-field-1-expected.png:
              * platform/mac/editing/pasteboard/input-field-1-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f2d8fe0
  22. 07 Feb, 2008 1 commit
    • justin.garcia@apple.com's avatar
      WebCore: · 765eaa63
      justin.garcia@apple.com authored
              Reviewed by Darin Adler.
      
              <rdar://problem/5195056> Huge plain text pastes are slow
              
              This was fixed in r27369 and then r29367 and r29667 caused performance to
              regress.
      
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::apply): Only updateLayout() for high level commands.
              (WebCore::EditCommand::unapply): Ditto.
              (WebCore::EditCommand::reapply): Ditto.
              * editing/Editor.cpp:
              (WebCore::Editor::appliedEditing): Added a note about shouldChangeSelection calls 
              that shouldn't be made, a bug I filed as <rdar://problem/5729315>.
              (WebCore::Editor::unappliedEditing): Ditto.
              (WebCore::Editor::reappliedEditing): Ditto.
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::nodeWillBeRemoved): Don't try to test the selection
              base and extent with the expensive isCandidate operation if the node that will
              be removed is in a fragment, since such a removal is guaranteed to have no effect
              on a selection.  This is to speed up the paste operation, which does many removes from
              a fragment.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
              
              <rdar://problem/5195056> Huge plain text pastes are slow
              
              The changes made for this fix exposed several more cases of:
              <rdar://problem/5729315> Some shouldChangeSelectedDOMRange contain Ranges for selections that are no longer valid
      
              * platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
              * platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
              * platform/mac/editing/deleting/delete-4083333-fix-expected.txt:
              * platform/mac/editing/execCommand/find-after-replace-expected.txt:
              * platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
              * platform/mac/editing/selection/replace-selection-1-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      765eaa63
  23. 19 Jan, 2008 1 commit
    • mitz@apple.com's avatar
      WebCore: · 93dd3e6f
      mitz@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              - fix <rdar://problem/5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116
      
              Test: editing/selection/inconsistent-in-removeChildNode.html
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::nodeWillBeRemoved): If the selection
              base or extent are not visible any more, adjust the selection.
      
      LayoutTests:
      
              Reviewed by Maciej Stachowiak.
      
              - test and updated results for <rdar://problem/5645813> CrashTracer: [USER] 6 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::destroy + 116
      
              * editing/selection/inconsistent-in-removeChildNode.html: Added.
              * platform/mac-leopard/editing/pasteboard/paste-RTFD-expected.txt:
              * platform/mac-leopard/editing/selection: Added.
              * platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.checksum: Added.
              * platform/mac-leopard/editing/selection/inconsistent-in-removeChildNode-expected.png: Added.
              * platform/mac/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
              * platform/mac/editing/deleting/delete-3608462-fix-expected.txt:
              * platform/mac/editing/deleting/delete-4083333-fix-expected.txt:
              * platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
              * platform/mac/editing/deleting/delete-line-011-expected.txt:
              * platform/mac/editing/execCommand/find-after-replace-expected.txt:
              * platform/mac/editing/execCommand/paste-1-expected.txt:
              * platform/mac/editing/execCommand/paste-2-expected.txt:
              * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
              * platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt: Added.
              * platform/mac/editing/selection/move-between-blocks-no-001-expected.txt:
              * platform/mac/editing/selection/replace-selection-1-expected.txt:
              * platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
              * platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
              * platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
              * platform/mac/editing/style/remove-underline-expected.txt:
              * platform/mac/editing/style/remove-underline-in-bold-expected.txt:
              * platform/mac/editing/style/unbold-in-bold-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93dd3e6f
  24. 17 Jan, 2008 1 commit
    • mitz@apple.com's avatar
      Reviewed by Dave Hyatt. · da56eb99
      mitz@apple.com authored
              - make more test pass on Windows by using @font-face to force font
                fallback to match Mac OS X.
      
              * editing/deleting/5144139-2.html:
              * fast/encoding/invalid-UTF-8.html:
              * fast/events/updateLayoutForHitTest.html:
              * fast/forms/select-visual-hebrew.html:
              * fast/forms/select-writing-direction-natural.html:
              * fast/forms/visual-hebrew-text-field.html:
              * fast/text/in-rendered-text-rtl.html:
              * fast/text/international/bidi-L2-run-reordering.html:
              * fast/text/international/bidi-LDB-2-CSS.html:
              * fast/text/international/bidi-LDB-2-HTML.html:
              * fast/text/international/bidi-LDB-2-formatting-characters.html:
              * fast/text/international/bidi-european-terminators.html:
              * fast/text/international/bidi-ignored-for-first-child-inline.html:
              * fast/text/international/bidi-innertext.html:
              * fast/text/international/bidi-listbox-atsui.html:
              * fast/text/international/bidi-listbox.html:
              * fast/text/international/bidi-menulist.html:
              * fast/text/international/bidi-override.html:
              * fast/text/international/resources: Added.
              * fast/text/international/resources/Mac-compatible-font-fallback.css: Added.
              * fast/text/international/rtl-caret.html:
              * platform/mac/editing/deleting/5144139-2-expected.txt:
              * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da56eb99
  25. 31 Dec, 2007 1 commit
    • mitz@apple.com's avatar
      WebCore: · 873f442f
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=14134
                <rdar://problem/5655160> REGRESSION (r25353): Whitespace nodes ignored between inline list items
      
              Test: fast/dynamic/create-renderer-for-whitespace-only-text.html
      
              * dom/Node.cpp:
              (WebCore::Node::attach): Added code to check if this node's renderer
              has become the "previous renderer" of any sibling text node, and if so,
              ensure that that node gets a renderer if it now needs one.
              (WebCore::Node::createRendererIfNeeded): Removed the assertion that the
              node is not attached.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test and updated results for http://bugs.webkit.org/show_bug.cgi?id=14134
                <rdar://problem/5655160> REGRESSION (r25353): Whitespace nodes ignored between inline list items
      
              * fast/dynamic/create-renderer-for-whitespace-only-text.html: Added.
              * fast/dynamic/style-access-late-stylesheet-load-expected.txt:
              * platform/mac-leopard/fast/dynamic: Added.
              * platform/mac-leopard/fast/dynamic/create-renderer-for-whitespace-only-text-expected.checksum: Added.
              * platform/mac-leopard/fast/dynamic/create-renderer-for-whitespace-only-text-expected.png: Added.
              * platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
              * platform/mac/editing/inserting/editable-html-element-expected.txt:
              * platform/mac/editing/inserting/editing-empty-divs-expected.txt:
              * platform/mac/editing/pasteboard/paste-TIFF-expected.txt:
              * platform/mac/editing/selection/4983858-expected.txt:
              * platform/mac/editing/selection/5136696-expected.txt:
              * platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:
              * platform/mac/editing/style/remove-underline-across-paragraph-expected.txt:
              * platform/mac/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
              * platform/mac/editing/style/remove-underline-after-paragraph-expected.txt:
              * platform/mac/editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
              * platform/mac/editing/style/remove-underline-from-stylesheet-expected.txt:
              * platform/mac/fast/dynamic/create-renderer-for-whitespace-only-text-expected.txt: Added.
              * platform/mac/fast/dynamic/move-node-with-selection-expected.txt:
              * platform/mac/fast/forms/input-align-expected.txt:
              * platform/mac/fast/inline/positionedLifetime-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      873f442f
  26. 12 Dec, 2007 1 commit
    • justin.garcia@apple.com's avatar
      WebCore: · 99a05541
      justin.garcia@apple.com authored
              Reviewed by Darin Adler.
      
              <rdar://problem/5433862> Mail crashes at WebCore::highestAncestor() when deleting a particular selection
      
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::removePreviouslySelectedEmptyTableRows):
              Don't remove the table row that contained the end of the selection if it is where we are
              about to place the ending selection.
              Don't remove all empty rows after the row that contained the start of the selection,
              they might come after the row that contained the end of the selection.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              <rdar://problem/5433862> Mail crashes at WebCore::highestAncestor() when deleting a particular selection
      
              * editing/deleting/5433862-1-expected.txt: Added.
              * editing/deleting/5433862-1.html: Added.
              * editing/deleting/5433862-2.html: Added.
              * platform/mac/editing/deleting/5433862-2-expected.checksum: Added.
              * platform/mac/editing/deleting/5433862-2-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@28670 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99a05541
  27. 24 Oct, 2007 1 commit
  28. 12 Oct, 2007 1 commit
    • justing's avatar
      WebCore: · 7d4a4343
      justing authored
              Reviewed by Harrison.
              
              <rdar://problem/5483370> GoogleDocs: Deleting cell text in a table row also removes any empty rows beneath the row being edited
              <rdar://problem/5482524> GoogleDocs: A hang occurs when applying list to selected table
              
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::removePreviouslySelectedEmptyTableRows):
              * editing/InsertListCommand.cpp:
              (WebCore::InsertListCommand::modifyRange):
              (WebCore::InsertListCommand::doApply):
      
      LayoutTests:
      
              Reviewed by Harrison.
              
              <rdar://problem/5483370> GoogleDocs: Deleting cell text in a table row also removes any empty rows beneath the row being edited
              <rdar://problem/5482524> GoogleDocs: A hang occurs when applying list to selected table
      
              * editing/deleting/5483370.html: Added.
              * editing/pasteboard/5483567.html-disabled: Removed.
              * editing/execCommand/5482524.html: Added.
              * platform/mac/editing/deleting/5483370-expected.checksum: Added.
              * platform/mac/editing/deleting/5483370-expected.png: Added.
              * platform/mac/editing/deleting/5483370-expected.txt: Added.
              * platform/mac/editing/execCommand/5482524-expected.checksum: Added.
              * platform/mac/editing/execCommand/5482524-expected.png: Added.
              * platform/mac/editing/execCommand/5482524-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@26558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d4a4343
  29. 03 Oct, 2007 2 commits
  30. 07 Sep, 2007 1 commit
    • oliver's avatar
      RS=Same · bb6c86a5
      oliver authored
              r25382 moved a number of tests from platform/mac back to the cross-platform
              directories, but did not commit the platform/mac changes themselves.
              
              This patch actually does.
              
              * platform/mac/editing/execCommand/nsresponder-outdent-expected.txt: Removed.
              * platform/mac/editing/execCommand/nsresponder-indent-expected.checksum: Removed.
              * platform/mac/editing/execCommand/nsresponder-outdent-expected.checksum: Removed.
              * platform/mac/editing/execCommand/nsresponder-indent-expected.png: Removed.
              * platform/mac/editing/execCommand/nsresponder-outdent-expected.png: Removed.
              * platform/mac/editing/execCommand/nsresponder-indent.html: Removed.
              * platform/mac/editing/execCommand/nsresponder-outdent.html: Removed.
              * platform/mac/editing/execCommand/nsresponder-indent-expected.txt: Removed.
              * platform/mac/editing/selection/5195166-1-expected.png: Removed.
              * platform/mac/editing/selection/5195166-2-expected.png: Removed.
              * platform/mac/editing/selection/select-line-expected.txt: Removed.
              * platform/mac/editing/selection/selection-actions-expected.checksum: Removed.
              * platform/mac/editing/selection/selection-actions.html: Removed.
              * platform/mac/editing/selection/4947387-expected.txt: Removed.
              * platform/mac/editing/selection/4947387-expected.png: Removed.
              * platform/mac/editing/selection/5195166-1-expected.checksum: Removed.
              * platform/mac/editing/selection/5195166-2-expected.checksum: Removed.
              * platform/mac/editing/selection/selection-actions-expected.txt: Removed.
              * platform/mac/editing/selection/5195166-1.html: Removed.
              * platform/mac/editing/selection/5195166-2.html: Removed.
              * platform/mac/editing/selection/selection-actions-expected.png: Removed.
              * platform/mac/editing/selection/select-line.html: Removed.
              * platform/mac/editing/selection/4947387-expected.checksum: Removed.
              * platform/mac/editing/selection/5195166-1-expected.txt: Removed.
              * platform/mac/editing/selection/4947387.html: Removed.
              * platform/mac/editing/selection/5195166-2-expected.txt: Removed.
              * platform/mac/editing/deleting/smart-delete-003-expected.checksum: Removed.
              * platform/mac/editing/deleting/smart-delete-004-expected.checksum: Removed.
              * platform/mac/editing/deleting/smart-delete-003.html: Removed.
              * platform/mac/editing/deleting/smart-delete-004.html: Removed.
              * platform/mac/editing/deleting/5300379-expected.checksum: Removed.
              * platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.checksum: Removed.
              * platform/mac/editing/deleting/5300379.html: Removed.
              * platform/mac/editing/deleting/delete-to-end-of-paragraph.html: Removed.
              * platform/mac/editing/deleting/smart-delete-003-expected.txt: Removed.
              * platform/mac/editing/deleting/smart-delete-004-expected.txt: Removed.
              * platform/mac/editing/deleting/5300379-expected.txt: Removed.
              * platform/mac/editing/deleting/smart-delete-003-expected.png: Removed.
              * platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
              * platform/mac/editing/deleting/smart-delete-004-expected.png: Removed.
              * platform/mac/editing/deleting/5300379-expected.png: Removed.
              * platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb6c86a5
  31. 04 Sep, 2007 1 commit
    • oliver's avatar
      RS=Adam · f3d01a86
      oliver authored
              
              Moving a number of mac specific tests into LayoutTests/platform/mac so that they
              don't need to be in the windows Skiplist.
              
              This includes most of the tests that used textInputController as it is a test
              of the mac-specific NSTextInput API.
      
              * editing/deleting/5300379-expected.checksum: Removed.
              * editing/deleting/5300379-expected.png: Removed.
              * editing/deleting/5300379-expected.txt: Removed.
              * editing/deleting/5300379.html: Removed.
              * editing/deleting/delete-to-end-of-paragraph-expected.checksum: Removed.
              * editing/deleting/delete-to-end-of-paragraph-expected.png: Removed.
              * editing/deleting/delete-to-end-of-paragraph-expected.txt: Removed.
              * editing/deleting/delete-to-end-of-paragraph.html: Removed.
              * editing/deleting/smart-delete-003-expected.checksum: Removed.
              * editing/deleting/smart-delete-003-expected.png: Removed.
              * editing/deleting/smart-delete-003-expected.txt: Removed.
              * editing/deleting/smart-delete-003.html: Removed.
              * editing/deleting/smart-delete-004-expected.checksum: Removed.
              * editing/deleting/smart-delete-004-expected.png: Removed.
              * editing/deleting/smart-delete-004-expected.txt: Removed.
              * editing/deleting/smart-delete-004.html: Removed.
              * editing/execCommand/nsresponder-indent-expected.checksum: Removed.
              * editing/execCommand/nsresponder-indent-expected.png: Removed.
              * editing/execCommand/nsresponder-indent-expected.txt: Removed.
              * editing/execCommand/nsresponder-indent.html: Removed.
              * editing/execCommand/nsresponder-outdent-expected.checksum: Removed.
              * editing/execCommand/nsresponder-outdent-expected.png: Removed.
              * editing/execCommand/nsresponder-outdent-expected.txt: Removed.
              * editing/execCommand/nsresponder-outdent.html: Removed.
              * editing/input/firstrectforcharacterrange-plain-expected.txt: Removed.
              * editing/input/firstrectforcharacterrange-plain.html: Removed.
              * editing/input/firstrectforcharacterrange-styled-expected.txt: Removed.
              * editing/input/firstrectforcharacterrange-styled.html: Removed.
              * editing/input/mac: Removed.
              * editing/input/mac/hangul-enter-confirms-and-sends-keypress-expected.txt: Removed.
              * editing/input/mac/hangul-enter-confirms-and-sends-keypress.html: Removed.
              * editing/input/mac/hangul.js: Removed.
              * editing/input/mac/kotoeri-enter-to-confirm-and-newline-expected.txt: Removed.
              * editing/input/mac/kotoeri-enter-to-confirm-and-newline.html: Removed.
              * editing/input/mac/kotoeri.js: Removed.
              * editing/input/mac/logger.js: Removed.
              * editing/input/range-for-empty-document-expected.txt: Removed.
              * editing/input/range-for-empty-document.html: Removed.
              * editing/input/replace-invalid-range-expected.txt: Removed.
              * editing/input/replace-invalid-range.html: Removed.
              * editing/input/text-input-controller-expected.txt: Removed.
              * editing/input/text-input-controller.html: Removed.
              * editing/input/wrapped-line-char-rect-expected.txt: Removed.
              * editing/input/wrapped-line-char-rect.html: Removed.
              * editing/selection/4947387-expected.checksum: Removed.
              * editing/selection/4947387-expected.png: Removed.
              * editing/selection/4947387-expected.txt: Removed.
              * editing/selection/4947387.html: Removed.
              * editing/selection/5195166-1-expected.checksum: Removed.
              * editing/selection/5195166-1-expected.png: Removed.
              * editing/selection/5195166-1-expected.txt: Removed.
              * editing/selection/5195166-1.html: Removed.
              * editing/selection/5195166-2-expected.checksum: Removed.
              * editing/selection/5195166-2-expected.png: Removed.
              * editing/selection/5195166-2-expected.txt: Removed.
              * editing/selection/5195166-2.html: Removed.
              * editing/selection/select-line-expected.txt: Removed.
              * editing/selection/select-line.html: Removed.
              * editing/selection/selection-actions-expected.checksum: Removed.
              * editing/selection/selection-actions-expected.png: Removed.
              * editing/selection/selection-actions-expected.txt: Removed.
              * editing/selection/selection-actions.html: Removed.
              * fast/AppleScript: Removed.
              * fast/AppleScript/001-expected.txt: Removed.
              * fast/AppleScript/001.html: Removed.
              * fast/AppleScript/array-expected.txt: Removed.
              * fast/AppleScript/array.html: Removed.
              * fast/AppleScript/date-expected.txt: Removed.
              * fast/AppleScript/date.html: Removed.
              * fast/dom/character-index-for-point-expected.txt: Removed.
              * fast/dom/character-index-for-point.html: Removed.
              * fast/dom/wrapper-identity-expected.txt: Removed.
              * fast/dom/wrapper-identity.html: Removed.
              * fast/dom/wrapper-round-tripping-expected.txt: Removed.
              * fast/dom/wrapper-round-tripping.html: Removed.
              * fast/encoding/char-decoding-mac-expected.txt: Removed.
              * fast/encoding/char-decoding-mac.html: Removed.
              * fast/forms/attributed-strings-expected.txt: Removed.
              * fast/forms/attributed-strings.html: Removed.
              * fast/objc: Removed.
              * fast/objc/longlongTest-expected.txt: Removed.
              * fast/objc/longlongTest.html: Removed.
              * fast/text/attributed-substring-from-range-001-expected.txt: Removed.
              * fast/text/attributed-substring-from-range-001.html: Removed.
              * fast/text/attributed-substring-from-range-expected.txt: Removed.
              * fast/text/attributed-substring-from-range-in-textfield-expected.txt: Removed.
              * fast/text/attributed-substring-from-range-in-textfield.html: Removed.
              * fast/text/attributed-substring-from-range.html: Removed.
              * fast/text/justified-text-rect-expected.checksum: Removed.
              * fast/text/justified-text-rect-expected.png: Removed.
              * fast/text/justified-text-rect-expected.txt: Removed.
              * fast/text/justified-text-rect.html: Removed.
              * platform/mac/editing/deleting/5300379-expected.checksum: Copied from editing/deleting/5300379-expected.checksum.
              * platform/mac/editing/deleting/5300379-expected.png: Copied from editing/deleting/5300379-expected.png.
              * platform/mac/editing/deleting/5300379-expected.txt: Copied from editing/deleting/5300379-expected.txt.
              * platform/mac/editing/deleting/5300379.html: Copied from editing/deleting/5300379.html.
              * platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.checksum: Copied from editing/deleting/delete-to-end-of-paragraph-expected.checksum.
              * platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.png: Copied from editing/deleting/delete-to-end-of-paragraph-expected.png.
              * platform/mac/editing/deleting/delete-to-end-of-paragraph-expected.txt: Copied from editing/deleting/delete-to-end-of-paragraph-expected.txt.
              * platform/mac/editing/deleting/delete-to-end-of-paragraph.html: Copied from editing/deleting/delete-to-end-of-paragraph.html.
              * platform/mac/editing/deleting/smart-delete-003-expected.checksum: Copied from editing/deleting/smart-delete-003-expected.checksum.
              * platform/mac/editing/deleting/smart-delete-003-expected.png: Copied from editing/deleting/smart-delete-003-expected.png.
              * platform/mac/editing/deleting/smart-delete-003-expected.txt: Copied from editing/deleting/smart-delete-003-expected.txt.
              * platform/mac/editing/deleting/smart-delete-003.html: Copied from editing/deleting/smart-delete-003.html.
              * platform/mac/editing/deleting/smart-delete-004-expected.checksum: Copied from editing/deleting/smart-delete-004-expected.checksum.
              * platform/mac/editing/deleting/smart-delete-004-expected.png: Copied from editing/deleting/smart-delete-004-expected.png.
              * platform/mac/editing/deleting/smart-delete-004-expected.txt: Copied from editing/deleting/smart-delete-004-expected.txt.
              * platform/mac/editing/deleting/smart-delete-004.html: Copied from editing/deleting/smart-delete-004.html.
              * platform/mac/editing/execCommand/nsresponder-indent-expected.checksum: Copied from editing/execCommand/nsresponder-indent-expected.checksum.
              * platform/mac/editing/execCommand/nsresponder-indent-expected.png: Copied from editing/execCommand/nsresponder-indent-expected.png.
              * platform/mac/editing/execCommand/nsresponder-indent-expected.txt: Copied from editing/execCommand/nsresponder-indent-expected.txt.
              * platform/mac/editing/execCommand/nsresponder-indent.html: Copied from editing/execCommand/nsresponder-indent.html.
              * platform/mac/editing/execCommand/nsresponder-outdent-expected.checksum: Copied from editing/execCommand/nsresponder-outdent-expected.checksum.
              * platform/mac/editing/execCommand/nsresponder-outdent-expected.png: Copied from editing/execCommand/nsresponder-outdent-expected.png.
              * platform/mac/editing/execCommand/nsresponder-outdent-expected.txt: Copied from editing/execCommand/nsresponder-outdent-expected.txt.
              * platform/mac/editing/execCommand/nsresponder-outdent.html: Copied from editing/execCommand/nsresponder-outdent.html.
              * platform/mac/editing/input: Copied from editing/input/mac.
              * platform/mac/editing/input/firstrectforcharacterrange-plain-expected.txt: Copied from editing/input/firstrectforcharacterrange-plain-expected.txt.
              * platform/mac/editing/input/firstrectforcharacterrange-plain.html: Copied from editing/input/firstrectforcharacterrange-plain.html.
              * platform/mac/editing/input/firstrectforcharacterrange-styled-expected.txt: Copied from editing/input/firstrectforcharacterrange-styled-expected.txt.
              * platform/mac/editing/input/firstrectforcharacterrange-styled.html: Copied from editing/input/firstrectforcharacterrange-styled.html.
              * platform/mac/editing/input/range-for-empty-document-expected.txt: Copied from editing/input/range-for-empty-document-expected.txt.
              * platform/mac/editing/input/range-for-empty-document.html: Copied from editing/input/range-for-empty-document.html.
              * platform/mac/editing/input/replace-invalid-range-expected.txt: Copied from editing/input/replace-invalid-range-expected.txt.
              * platform/mac/editing/input/replace-invalid-range.html: Copied from editing/input/replace-invalid-range.html.
              * platform/mac/editing/input/text-input-controller-expected.txt: Copied from editing/input/text-input-controller-expected.txt.
              * platform/mac/editing/input/text-input-controller.html: Copied from editing/input/text-input-controller.html.
              * platform/mac/editing/input/wrapped-line-char-rect-expected.txt: Copied from editing/input/wrapped-line-char-rect-expected.txt.
              * platform/mac/editing/input/wrapped-line-char-rect.html: Copied from editing/input/wrapped-line-char-rect.html.
              * platform/mac/editing/selection/4947387-expected.checksum: Copied from editing/selection/4947387-expected.checksum.
              * platform/mac/editing/selection/4947387-expected.png: Copied from editing/selection/4947387-expected.png.
              * platform/mac/editing/selection/4947387-expected.txt: Copied from editing/selection/4947387-expected.txt.
              * platform/mac/editing/selection/4947387.html: Copied from editing/selection/4947387.html.
              * platform/mac/editing/selection/5195166-1-expected.checksum: Copied from editing/selection/5195166-1-expected.checksum.
              * platform/mac/editing/selection/5195166-1-expected.png: Copied from editing/selection/5195166-1-expected.png.
              * platform/mac/editing/selection/5195166-1-expected.txt: Copied from editing/selection/5195166-1-expected.txt.
              * platform/mac/editing/selection/5195166-1.html: Copied from editing/selection/5195166-1.html.
              * platform/mac/editing/selection/5195166-2-expected.checksum: Copied from editing/selection/5195166-2-expected.checksum.
              * platform/mac/editing/selection/5195166-2-expected.png: Copied from editing/selection/5195166-2-expected.png.
              * platform/mac/editing/selection/5195166-2-expected.txt: Copied from editing/selection/5195166-2-expected.txt.
              * platform/mac/editing/selection/5195166-2.html: Copied from editing/selection/5195166-2.html.
              * platform/mac/editing/selection/select-line-expected.txt: Copied from editing/selection/select-line-expected.txt.
              * platform/mac/editing/selection/select-line.html: Copied from editing/selection/select-line.html.
              * platform/mac/editing/selection/selection-actions-expected.checksum: Copied from editing/selection/selection-actions-expected.checksum.
              * platform/mac/editing/selection/selection-actions-expected.png: Copied from editing/selection/selection-actions-expected.png.
              * platform/mac/editing/selection/selection-actions-expected.txt: Copied from editing/selection/selection-actions-expected.txt.
              * platform/mac/editing/selection/selection-actions.html: Copied from editing/selection/selection-actions.html.
              * platform/mac/fast/AppleScript: Copied from fast/AppleScript.
              * platform/mac/fast/dom: Added.
              * platform/mac/fast/dom/character-index-for-point-expected.txt: Copied from fast/dom/character-index-for-point-expected.txt.
              * platform/mac/fast/dom/character-index-for-point.html: Copied from fast/dom/character-index-for-point.html.
              * platform/mac/fast/dom/wrapper-identity-expected.txt: Copied from fast/dom/wrapper-identity-expected.txt.
              * platform/mac/fast/dom/wrapper-identity.html: Copied from fast/dom/wrapper-identity.html.
              * platform/mac/fast/dom/wrapper-round-tripping-expected.txt: Copied from fast/dom/wrapper-round-tripping-expected.txt.
              * platform/mac/fast/dom/wrapper-round-tripping.html: Copied from fast/dom/wrapper-round-tripping.html.
              * platform/mac/fast/encoding: Added.
              * platform/mac/fast/encoding/char-decoding-mac-expected.txt: Copied from fast/encoding/char-decoding-mac-expected.txt.
              * platform/mac/fast/encoding/char-decoding-mac.html: Copied from fast/encoding/char-decoding-mac.html.
              * platform/mac/fast/forms: Added.
              * platform/mac/fast/forms/attributed-strings-expected.txt: Copied from fast/forms/attributed-strings-expected.txt.
              * platform/mac/fast/forms/attributed-strings.html: Copied from fast/forms/attributed-strings.html.
              * platform/mac/fast/objc: Copied from fast/objc.
              * platform/mac/fast/text: Added.
              * platform/mac/fast/text/attributed-substring-from-range-001-expected.txt: Copied from fast/text/attributed-substring-from-range-001-expected.txt.
              * platform/mac/fast/text/attributed-substring-from-range-001.html: Copied from fast/text/attributed-substring-from-range-001.html.
              * platform/mac/fast/text/attributed-substring-from-range-expected.txt: Copied from fast/text/attributed-substring-from-range-expected.txt.
              * platform/mac/fast/text/attributed-substring-from-range-in-textfield-expected.txt: Copied from fast/text/attributed-substring-from-range-in-textfield-expected.txt.
              * platform/mac/fast/text/attributed-substring-from-range-in-textfield.html: Copied from fast/text/attributed-substring-from-range-in-textfield.html.
              * platform/mac/fast/text/attributed-substring-from-range.html: Copied from fast/text/attributed-substring-from-range.html.
              * platform/mac/fast/text/justified-text-rect-expected.checksum: Copied from fast/text/justified-text-rect-expected.checksum.
              * platform/mac/fast/text/justified-text-rect-expected.png: Copied from fast/text/justified-text-rect-expected.png.
              * platform/mac/fast/text/justified-text-rect-expected.txt: Copied from fast/text/justified-text-rect-expected.txt.
              * platform/mac/fast/text/justified-text-rect.html: Copied from fast/text/justified-text-rect.html.
              * platform/mac/plugins: Added.
              * platform/mac/plugins/pluginDocumentView-deallocated-dataSource-expected.txt: Copied from plugins/pluginDocumentView-deallocated-dataSource-expected.txt.
              * platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html: Copied from plugins/pluginDocumentView-deallocated-dataSource.html.
              * platform/win/Skipped:
              * plugins/pluginDocumentView-deallocated-dataSource-expected.txt: Removed.
              * plugins/pluginDocumentView-deallocated-dataSource.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3d01a86
  32. 31 Aug, 2007 1 commit
    • aliceli1's avatar
      WebCore: · 3fe7bd33
      aliceli1 authored
              Reviewed by Tim Hatcher.
      
              Fixed <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() after dropping a selected image over container's close box
      
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::show):
              Factored out the code in ::show() that created and styled the elements of the Deletion UI
      
              (WebCore::DeleteButtonController::createDeletionUI):
              Neglecting to move the append of the deletionUI elements into the same clause that handles the creation
              of them ended up creating multiple elements at were repeatedly appended to the target, resulting in a 
              bloated table deletion UI which was slow to show and hide. 
      
              * editing/DeleteButtonController.h:
              (WebCore::DeleteButtonController::enabled):
              Restore this function to how it used to be pre-r25305, sans asserts
      
              * editing/EditCommand.cpp:
              Add disable/enable sandwich when undoing/redoing commands too
              (WebCore::EditCommand::unapply):
              (WebCore::EditCommand::reapply):
      
      LayoutTests:
      
              Reviewed by Tim Hatcher.
      
              Test for <rdar://problem/5420682> Mail crashes at WebCore::InsertLineBreakCommand::doApply() after dropping a selected image over container's close box
      
              * editing/deleting/deletionUI-single-instance.html: Added.
              * platform/mac/editing/deleting/deletionUI-single-instance-expected.checksum: Added.
              * platform/mac/editing/deleting/deletionUI-single-instance-expected.png: Added.
              * platform/mac/editing/deleting/deletionUI-single-instance-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fe7bd33
  33. 23 Aug, 2007 1 commit
    • justing's avatar
      WebCore: · 4855c4f9
      justing authored
              Reviewed by Adele.
      
              <rdar://problem/5156801> REGRESSION: Crash at DeleteSelectionCommand::doApply() when deleting table content
      
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::handleGeneralDelete): Use a RefPtr
              for node.  If the node to be removed contains the selection, and if
              the next node to be removed (nextNode) is inside the deletion UI,
              removing node will remove nextNode from the document.  nextNode is
              a RefPtr, but node isn't and when nextNode falls out of scope the node
              that node points to will be destroyed and we'll end up using a stale pointer.
              Long term we should probably just disable the deletion UI before editing 
              operations because the undo of the removal of node in the situation 
              described above relies on the presence of the deletion UI, but it isn't 
              present because its added and removed in a non-undoable way.
      
      LayoutTests:
      
              Reviewed by Adele.
              
              <rdar://problem/5156801> REGRESSION: Crash at DeleteSelectionCommand::doApply() when deleting table content
      
              * editing/deleting/5156801-2.html: Added.
              * platform/mac/editing/deleting: Added.
              * platform/mac/editing/deleting/5156801-2-expected.checksum: Added.
              * platform/mac/editing/deleting/5156801-2-expected.png: Added.
              * platform/mac/editing/deleting/5156801-2-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@25203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4855c4f9