1. 05 May, 2009 1 commit
    • ap@webkit.org's avatar
      Reviewed by Dave Hyatt. · d0295906
      ap@webkit.org authored
              <rdar://problem/6576889> REGRESSION (r35185): Cannot watch Flash movies on omg.yahoo.com
      
              The problem was caused by missing <head> element - we used to create it when moving a
              misplaced <style> element, but we now handle those in place. Other browsers always create
              a <head> element.
      
              There is no guarantee that a <head> element always exists - first, it can be removed with
              removeChild or innerHTML, and also, we don't currently create it for frameset documents, or
              for manually created ones (e.g. ImageDocument).
      
              Test: fast/parser/head-element-for-yahoo-player.html
      
      WebKit:
              * dom/Document.cpp: (WebCore::Document::implicitClose): Create a <head> element for about:blank.
              A removed comment talked about rdar://3758785, but that problem doesn't re-occur even if this
              code is removed completely.
      
              * html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::checkDTD): No longer allow <script>
              elements as children of <html>. This isn't directly related to this bug, but it was easier
              to fix both at once (IE and Firefox both don't allow such mispositioned <script> elements).
      
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::handleError): Move <script> to <head> if <body> hasn't been created yet.
              Create a <head> it a <body> is created implicitly to contain some other element.
              (WebCore::HTMLParser::bodyCreateErrorCheck): Ensure that a <head> exists when <body> is
              explicitly present in source.
              (WebCore::HTMLParser::createHead): Do the work even if <html> element hasn't been created yet.
      
      LayoutTests:
              * fast/parser/head-element-for-yahoo-player-expected.txt: Added.
              * fast/parser/head-element-for-yahoo-player.html: Added.
              Test the regression case (a misplaced <style> that used to create <head> implicitly).
      
              * editing/selection/select-all-005.html: Use a new index when selecting the body.
      
              * fast/dom/Document/document-write-doctype-expected.txt:
              * fast/dom/Document/resources/document-write-doctype.js:
              Removed checks for "Gecko quirk" of implicitly adding HEAD - that not a quirk, but standard
              behavior per HTML5.
      
              * editing/execCommand/create-list-1-expected.txt:
              * platform/mac/editing/deleting/4845371-expected.txt:
              * platform/mac/editing/deleting/4866671-expected.txt:
              * platform/mac/editing/deleting/4875189-expected.txt:
              * platform/mac/editing/deleting/5026848-1-expected.txt:
              * platform/mac/editing/deleting/5026848-2-expected.txt:
              * platform/mac/editing/deleting/5026848-3-expected.txt:
              * platform/mac/editing/deleting/5032066-expected.txt:
              * platform/mac/editing/deleting/5091898-expected.txt:
              * platform/mac/editing/deleting/5099303-expected.txt:
              * platform/mac/editing/deleting/5115601-expected.txt:
              * platform/mac/editing/deleting/5126166-expected.txt:
              * platform/mac/editing/deleting/5156801-2-expected.txt:
              * platform/mac/editing/deleting/5168598-expected.txt:
              * platform/mac/editing/deleting/5272440-expected.txt:
              * platform/mac/editing/deleting/5300379-expected.txt:
              * platform/mac/editing/deleting/5390681-expected.txt:
              * platform/mac/editing/deleting/5408255-expected.txt:
              * platform/mac/editing/deleting/5433862-2-expected.txt:
              * platform/mac/editing/deleting/5483370-expected.txt:
              * platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
              * platform/mac/editing/deleting/delete-block-table-expected.txt:
              * platform/mac/editing/deleting/delete-hr-expected.txt:
              * platform/mac/editing/deleting/delete-mixed-editable-content-001-expected.txt:
              * platform/mac/editing/deleting/delete-to-select-table-expected.txt:
              * platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
              * platform/mac/editing/deleting/merge-endOfParagraph-expected.txt:
              * platform/mac/editing/deleting/merge-no-br-expected.txt:
              * platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
              * platform/mac/editing/execCommand/4641880-1-expected.txt:
              * platform/mac/editing/execCommand/4641880-2-expected.txt:
              * platform/mac/editing/execCommand/4747450-expected.txt:
              * platform/mac/editing/execCommand/4786404-1-expected.txt:
              * platform/mac/editing/execCommand/4786404-2-expected.txt:
              * platform/mac/editing/execCommand/4916402-expected.txt:
              * platform/mac/editing/execCommand/4916541-expected.txt:
              * platform/mac/editing/execCommand/4916583-expected.txt:
              * platform/mac/editing/execCommand/4920488-expected.txt:
              * platform/mac/editing/execCommand/4920742-1-expected.txt:
              * platform/mac/editing/execCommand/4924441-expected.txt:
              * platform/mac/editing/execCommand/5049671-expected.txt:
              * platform/mac/editing/execCommand/5080333-1-expected.txt:
              * platform/mac/editing/execCommand/5080333-2-expected.txt:
              * platform/mac/editing/execCommand/5119244-expected.txt:
              * platform/mac/editing/execCommand/5120591-expected.txt:
              * platform/mac/editing/execCommand/5136770-expected.txt:
              * platform/mac/editing/execCommand/5142012-1-expected.txt:
              * platform/mac/editing/execCommand/5142012-2-expected.txt:
              * platform/mac/editing/execCommand/5142012-3-expected.txt:
              * platform/mac/editing/execCommand/5144139-1-expected.txt:
              * platform/mac/editing/execCommand/5164796-expected.txt:
              * platform/mac/editing/execCommand/5207369-expected.txt:
              * platform/mac/editing/execCommand/5210032-expected.txt:
              * platform/mac/editing/execCommand/5432254-1-expected.txt:
              * platform/mac/editing/execCommand/5432254-2-expected.txt:
              * platform/mac/editing/execCommand/5481523-expected.txt:
              * platform/mac/editing/execCommand/5482524-expected.txt:
              * platform/mac/editing/execCommand/5569741-expected.txt:
              * platform/mac/editing/execCommand/5573879-expected.txt:
              * platform/mac/editing/execCommand/5700414-1-expected.txt:
              * platform/mac/editing/execCommand/5700414-2-expected.txt:
              * platform/mac/editing/execCommand/insert-list-empty-div-expected.txt:
              * platform/mac/editing/input/5576619-expected.txt:
              * platform/mac/editing/inserting/12882-expected.txt:
              * platform/mac/editing/inserting/4840662-expected.txt:
              * platform/mac/editing/inserting/4875189-1-expected.txt:
              * platform/mac/editing/inserting/4875189-2-expected.txt:
              * platform/mac/editing/inserting/4959067-expected.txt:
              * platform/mac/editing/inserting/4960120-1-expected.txt:
              * platform/mac/editing/inserting/4960120-2-expected.txt:
              * platform/mac/editing/inserting/5002441-expected.txt:
              * platform/mac/editing/inserting/5058163-2-expected.txt:
              * platform/mac/editing/inserting/5156401-2-expected.txt:
              * platform/mac/editing/inserting/5549929-2-expected.txt:
              * platform/mac/editing/inserting/5549929-3-expected.txt:
              * platform/mac/editing/inserting/5607069-2-expected.txt:
              * platform/mac/editing/inserting/5607069-3-expected.txt:
              * platform/mac/editing/inserting/editable-html-element-expected.txt:
              * platform/mac/editing/inserting/editable-inline-element-expected.txt:
              * platform/mac/editing/inserting/edited-whitespace-1-expected.txt:
              * platform/mac/editing/inserting/editing-empty-divs-expected.txt:
              * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt:
              * platform/mac/editing/pasteboard/4806874-expected.txt:
              * platform/mac/editing/pasteboard/4861080-expected.txt:
              * platform/mac/editing/pasteboard/4944770-1-expected.txt:
              * platform/mac/editing/pasteboard/4944770-2-expected.txt:
              * platform/mac/editing/pasteboard/4947130-expected.txt:
              * platform/mac/editing/pasteboard/4989774-expected.txt:
              * platform/mac/editing/pasteboard/5027857-expected.txt:
              * platform/mac/editing/pasteboard/5032095-expected.txt:
              * platform/mac/editing/pasteboard/5065605-expected.txt:
              * platform/mac/editing/pasteboard/5071074-2-expected.txt:
              * platform/mac/editing/pasteboard/5071074-expected.txt:
              * platform/mac/editing/pasteboard/5075944-2-expected.txt:
              * platform/mac/editing/pasteboard/5075944-3-expected.txt:
              * platform/mac/editing/pasteboard/5075944-expected.txt:
              * platform/mac/editing/pasteboard/5134759-expected.txt:
              * platform/mac/editing/pasteboard/5156401-1-expected.txt:
              * platform/mac/editing/pasteboard/5247341-expected.txt:
              * platform/mac/editing/pasteboard/5387578-expected.txt:
              * platform/mac/editing/pasteboard/5478250-expected.txt:
              * platform/mac/editing/pasteboard/5483567-expected.txt:
              * platform/mac/editing/pasteboard/5601583-1-expected.txt:
              * platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt:
              * platform/mac/editing/pasteboard/input-field-1-expected.txt:
              * platform/mac/editing/pasteboard/merge-after-delete-1-expected.txt:
              * platform/mac/editing/pasteboard/merge-after-delete-2-expected.txt:
              * platform/mac/editing/pasteboard/merge-after-delete-expected.txt:
              * platform/mac/editing/pasteboard/merge-start-blockquote-expected.txt:
              * platform/mac/editing/pasteboard/paste-unrendered-select-expected.txt:
              * platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.txt:
              * platform/mac/editing/pasteboard/select-element-1-expected.txt:
              * platform/mac/editing/selection/13804-expected.txt:
              * platform/mac/editing/selection/14971-expected.txt:
              * platform/mac/editing/selection/4397952-expected.txt:
              * platform/mac/editing/selection/4818145-expected.txt:
              * platform/mac/editing/selection/4866671-expected.txt:
              * platform/mac/editing/selection/4889598-expected.txt:
              * platform/mac/editing/selection/4895428-1-expected.txt:
              * platform/mac/editing/selection/4895428-2-expected.txt:
              * platform/mac/editing/selection/4895428-3-expected.txt:
              * platform/mac/editing/selection/4895428-4-expected.txt:
              * platform/mac/editing/selection/4932260-1-expected.txt:
              * platform/mac/editing/selection/4932260-2-expected.txt:
              * platform/mac/editing/selection/4932260-3-expected.txt:
              * platform/mac/editing/selection/4947387-expected.txt:
              * platform/mac/editing/selection/4960116-expected.txt:
              * platform/mac/editing/selection/4975120-expected.txt:
              * platform/mac/editing/selection/4983858-expected.txt:
              * platform/mac/editing/selection/5007143-2-expected.txt:
              * platform/mac/editing/selection/5007143-expected.txt:
              * platform/mac/editing/selection/5057506-2-expected.txt:
              * platform/mac/editing/selection/5057506-expected.txt:
              * platform/mac/editing/selection/5076323-1-expected.txt:
              * platform/mac/editing/selection/5076323-2-expected.txt:
              * platform/mac/editing/selection/5076323-3-expected.txt:
              * platform/mac/editing/selection/5081257-1-expected.txt:
              * platform/mac/editing/selection/5081257-2-expected.txt:
              * platform/mac/editing/selection/5099303-expected.txt:
              * platform/mac/editing/selection/5109817-expected.txt:
              * platform/mac/editing/selection/5136696-expected.txt:
              * platform/mac/editing/selection/5195166-1-expected.txt:
              * platform/mac/editing/selection/5195166-2-expected.txt:
              * platform/mac/editing/selection/5234383-1-expected.txt:
              * platform/mac/editing/selection/5234383-2-expected.txt:
              * platform/mac/editing/selection/5240265-expected.txt:
              * platform/mac/editing/selection/5333725-expected.txt:
              * platform/mac/editing/selection/5354455-1-expected.txt:
              * platform/mac/editing/selection/addRange-expected.txt:
              * platform/mac/editing/selection/caret-before-select-expected.txt:
              * platform/mac/editing/selection/contains-boundaries-expected.txt:
              * platform/mac/editing/selection/drag-select-1-expected.txt:
              * platform/mac/editing/selection/editable-html-element-expected.txt:
              * platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt:
              * platform/mac/editing/selection/inline-closest-leaf-child-expected.txt:
              * platform/mac/editing/selection/mixed-editability-6-expected.txt:
              * platform/mac/editing/selection/mixed-editability-7-expected.txt:
              * platform/mac/editing/selection/move-by-sentence-linebreak-expected.txt:
              * platform/mac/editing/selection/select-all-005-expected.txt:
              * platform/mac/editing/selection/table-caret-1-expected.txt:
              * platform/mac/editing/selection/table-caret-2-expected.txt:
              * platform/mac/editing/selection/table-caret-3-expected.txt:
              * platform/mac/editing/selection/wrapped-line-caret-1-expected.txt:
              * platform/mac/editing/selection/wrapped-line-caret-2-expected.txt:
              * platform/mac/editing/style/4916887-expected.txt:
              * platform/mac/editing/style/5017613-1-expected.txt:
              * platform/mac/editing/style/5017613-2-expected.txt:
              * platform/mac/editing/style/5046875-1-expected.txt:
              * platform/mac/editing/style/5046875-2-expected.txt:
              * platform/mac/editing/style/5065910-expected.txt:
              * platform/mac/editing/style/5084241-expected.txt:
              * platform/mac/editing/style/5091898-expected.txt:
              * platform/mac/editing/style/5228141-expected.txt:
              * platform/mac/editing/style/5279521-expected.txt:
              * platform/mac/editing/style/font-family-with-space-expected.txt:
              * platform/mac/editing/style/fontsize-1-expected.txt:
              * platform/mac/editing/style/highlight-expected.txt:
              * platform/mac/editing/style/non-inheritable-styles-expected.txt:
              * platform/mac/editing/undo/5378473-expected.txt:
              * platform/mac/fast/block/float/relative-painted-twice-expected.txt:
              * platform/mac/fast/dom/delete-contents-expected.txt:
              * platform/mac/fast/events/context-no-deselect-expected.txt:
              * platform/mac/fast/events/label-focus-expected.txt:
              * platform/mac/fast/forms/input-appearance-focus-expected.txt:
              * platform/mac/fast/forms/input-text-click-inside-expected.txt:
              * platform/mac/fast/forms/input-text-click-outside-expected.txt:
              * platform/mac/fast/forms/input-text-double-click-expected.txt:
              * platform/mac/fast/forms/input-text-drag-down-expected.txt:
              * platform/mac/fast/forms/input-text-option-delete-expected.txt:
              * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
              * platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
              * platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt:
              * platform/mac/fast/forms/textfield-overflow-expected.txt:
              * platform/mac/fast/inline/25277-2-expected.txt:
              * platform/mac/fast/inline/25277-expected.txt:
              * platform/mac/fast/lists/drag-into-marker-expected.txt:
              * platform/mac/fast/overflow/overflow-focus-ring-expected.txt:
              * platform/mac/fast/repaint/4776765-expected.txt:
              * platform/mac/fast/repaint/selection-after-delete-expected.txt:
              * platform/mac/fast/repaint/selection-after-remove-expected.txt:
              * platform/qt/editing/deleting/4845371-expected.txt:
              * platform/qt/editing/deleting/4866671-expected.txt:
              * platform/qt/editing/deleting/4875189-expected.txt:
              * platform/qt/editing/deleting/5026848-1-expected.txt:
              * platform/qt/editing/deleting/5026848-2-expected.txt:
              * platform/qt/editing/deleting/5026848-3-expected.txt:
              * platform/qt/editing/deleting/5032066-expected.txt:
              * platform/qt/editing/deleting/5091898-expected.txt:
              * platform/qt/editing/deleting/5099303-expected.txt:
              * platform/qt/editing/deleting/5115601-expected.txt:
              * platform/qt/editing/deleting/5126166-expected.txt:
              * platform/qt/editing/deleting/5144139-2-expected.txt:
              * platform/qt/editing/deleting/5156801-2-expected.txt:
              * platform/qt/editing/deleting/5168598-expected.txt:
              * platform/qt/editing/deleting/5272440-expected.txt:
              * platform/qt/editing/deleting/5300379-expected.txt:
              * platform/qt/editing/deleting/5390681-expected.txt:
              * platform/qt/editing/deleting/5408255-expected.txt:
              * platform/qt/editing/deleting/delete-at-start-or-end-expected.txt:
              * platform/qt/editing/deleting/delete-block-table-expected.txt:
              * platform/qt/editing/deleting/delete-hr-expected.txt:
              * platform/qt/editing/deleting/delete-link-1-expected.txt:
              * platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.txt:
              * platform/qt/editing/deleting/delete-to-select-table-expected.txt:
              * platform/qt/editing/deleting/deletionUI-single-instance-expected.txt:
              * platform/qt/editing/deleting/merge-endOfParagraph-expected.txt:
              * platform/qt/editing/deleting/merge-no-br-expected.txt:
              * platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
              * platform/qt/editing/execCommand/4641880-1-expected.txt:
              * platform/qt/editing/execCommand/4641880-2-expected.txt:
              * platform/qt/editing/execCommand/4747450-expected.txt:
              * platform/qt/editing/execCommand/4786404-1-expected.txt:
              * platform/qt/editing/execCommand/4786404-2-expected.txt:
              * platform/qt/editing/execCommand/4916402-expected.txt:
              * platform/qt/editing/execCommand/4916541-expected.txt:
              * platform/qt/editing/execCommand/4916583-expected.txt:
              * platform/qt/editing/execCommand/4920488-expected.txt:
              * platform/qt/editing/execCommand/4920742-1-expected.txt:
              * platform/qt/editing/execCommand/4924441-expected.txt:
              * platform/qt/editing/execCommand/5049671-expected.txt:
              * platform/qt/editing/execCommand/5062376-expected.txt:
              * platform/qt/editing/execCommand/5080333-1-expected.txt:
              * platform/qt/editing/execCommand/5080333-2-expected.txt:
              * platform/qt/editing/execCommand/5119244-expected.txt:
              * platform/qt/editing/execCommand/5120591-expected.txt:
              * platform/qt/editing/execCommand/5136770-expected.txt:
              * platform/qt/editing/execCommand/5142012-1-expected.txt:
              * platform/qt/editing/execCommand/5142012-2-expected.txt:
              * platform/qt/editing/execCommand/5142012-3-expected.txt:
              * platform/qt/editing/execCommand/5144139-1-expected.txt:
              * platform/qt/editing/execCommand/5164796-expected.txt:
              * platform/qt/editing/execCommand/5207369-expected.txt:
              * platform/qt/editing/execCommand/5210032-expected.txt:
              * platform/qt/editing/execCommand/5432254-1-expected.txt:
              * platform/qt/editing/execCommand/5432254-2-expected.txt:
              * platform/qt/editing/execCommand/insert-list-empty-div-expected.txt:
              * platform/qt/editing/inserting/12882-expected.txt:
              * platform/qt/editing/inserting/4840662-expected.txt:
              * platform/qt/editing/inserting/4875189-1-expected.txt:
              * platform/qt/editing/inserting/4875189-2-expected.txt:
              * platform/qt/editing/inserting/4959067-expected.txt:
              * platform/qt/editing/inserting/4960120-1-expected.txt:
              * platform/qt/editing/inserting/4960120-2-expected.txt:
              * platform/qt/editing/inserting/5002441-expected.txt:
              * platform/qt/editing/inserting/5058163-2-expected.txt:
              * platform/qt/editing/inserting/5156401-2-expected.txt:
              * platform/qt/editing/inserting/editable-html-element-expected.txt:
              * platform/qt/editing/inserting/editable-inline-element-expected.txt:
              * platform/qt/editing/inserting/edited-whitespace-1-expected.txt:
              * platform/qt/editing/inserting/editing-empty-divs-expected.txt:
              * platform/qt/editing/inserting/insert-before-link-1-expected.txt:
              * platform/qt/editing/pasteboard/4806874-expected.txt:
              * platform/qt/editing/pasteboard/4840662-expected.txt:
              * platform/qt/editing/pasteboard/4944770-1-expected.txt:
              * platform/qt/editing/pasteboard/4989774-expected.txt:
              * platform/qt/editing/pasteboard/5027857-expected.txt:
              * platform/qt/editing/pasteboard/5032095-expected.txt:
              * platform/qt/editing/pasteboard/5065605-expected.txt:
              * platform/qt/editing/pasteboard/5071074-2-expected.txt:
              * platform/qt/editing/pasteboard/5071074-expected.txt:
              * platform/qt/editing/pasteboard/5075944-2-expected.txt:
              * platform/qt/editing/pasteboard/5075944-3-expected.txt:
              * platform/qt/editing/pasteboard/5075944-expected.txt:
              * platform/qt/editing/pasteboard/5134759-expected.txt:
              * platform/qt/editing/pasteboard/5156401-1-expected.txt:
              * platform/qt/editing/pasteboard/5245519-expected.txt:
              * platform/qt/editing/pasteboard/5247341-expected.txt:
              * platform/qt/editing/pasteboard/5387578-expected.txt:
              * platform/qt/editing/pasteboard/5478250-expected.txt:
              * platform/qt/editing/pasteboard/5483567-expected.txt:
              * platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt:
              * platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
              * platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
              * platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
              * platform/qt/editing/pasteboard/merge-start-blockquote-expected.txt:
              * platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt:
              * platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt:
              * platform/qt/editing/selection/13804-expected.txt:
              * platform/qt/editing/selection/4397952-expected.txt:
              * platform/qt/editing/selection/4818145-expected.txt:
              * platform/qt/editing/selection/4866671-expected.txt:
              * platform/qt/editing/selection/4889598-expected.txt:
              * platform/qt/editing/selection/4895428-2-expected.txt:
              * platform/qt/editing/selection/4895428-3-expected.txt:
              * platform/qt/editing/selection/4932260-1-expected.txt:
              * platform/qt/editing/selection/4932260-2-expected.txt:
              * platform/qt/editing/selection/4932260-3-expected.txt:
              * platform/qt/editing/selection/4960116-expected.txt:
              * platform/qt/editing/selection/4983858-expected.txt:
              * platform/qt/editing/selection/5007143-2-expected.txt:
              * platform/qt/editing/selection/5007143-expected.txt:
              * platform/qt/editing/selection/5076323-1-expected.txt:
              * platform/qt/editing/selection/5076323-2-expected.txt:
              * platform/qt/editing/selection/5076323-3-expected.txt:
              * platform/qt/editing/selection/5081257-1-expected.txt:
              * platform/qt/editing/selection/5081257-2-expected.txt:
              * platform/qt/editing/selection/5099303-expected.txt:
              * platform/qt/editing/selection/5136696-expected.txt:
              * platform/qt/editing/selection/5195166-1-expected.txt:
              * platform/qt/editing/selection/5195166-2-expected.txt:
              * platform/qt/editing/selection/5234383-1-expected.txt:
              * platform/qt/editing/selection/5234383-2-expected.txt:
              * platform/qt/editing/selection/5240265-expected.txt:
              * platform/qt/editing/selection/addRange-expected.txt:
              * platform/qt/editing/selection/caret-before-select-expected.txt:
              * platform/qt/editing/selection/editable-html-element-expected.txt:
              * platform/qt/editing/selection/mixed-editability-6-expected.txt:
              * platform/qt/editing/selection/mixed-editability-7-expected.txt:
              * platform/qt/editing/selection/move-by-sentence-linebreak-expected.txt:
              * platform/qt/editing/selection/select-all-005-expected.txt:
              * platform/qt/editing/selection/table-caret-1-expected.txt:
              * platform/qt/editing/selection/table-caret-2-expected.txt:
              * platform/qt/editing/selection/table-caret-3-expected.txt:
              * platform/qt/editing/style/4916887-expected.txt:
              * platform/qt/editing/style/5017613-1-expected.txt:
              * platform/qt/editing/style/5017613-2-expected.txt:
              * platform/qt/editing/style/5046875-1-expected.txt:
              * platform/qt/editing/style/5046875-2-expected.txt:
              * platform/qt/editing/style/5065910-expected.txt:
              * platform/qt/editing/style/5084241-expected.txt:
              * platform/qt/editing/style/5228141-expected.txt:
              * platform/qt/editing/style/5279521-expected.txt:
              * platform/qt/editing/style/font-family-with-space-expected.txt:
              * platform/qt/editing/style/fontsize-1-expected.txt:
              * platform/qt/editing/style/highlight-expected.txt:
              * platform/qt/editing/style/non-inheritable-styles-expected.txt:
              * platform/qt/editing/undo/5378473-expected.txt:
              * platform/qt/fast/dom/delete-contents-expected.txt:
              * platform/qt/fast/events/label-focus-expected.txt:
              * platform/qt/fast/forms/input-appearance-focus-expected.txt:
              * platform/qt/fast/forms/input-maxlength-2-expected.txt:
              * platform/qt/fast/forms/input-text-click-inside-expected.txt:
              * platform/qt/fast/forms/input-text-option-delete-expected.txt:
              * platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
              * platform/qt/fast/forms/textfield-drag-into-disabled-expected.txt:
              * platform/qt/fast/forms/textfield-overflow-expected.txt:
              * platform/qt/fast/overflow/overflow-focus-ring-expected.txt:
              * platform/qt/fast/repaint/4776765-expected.txt:
              * platform/qt/fast/repaint/selection-after-delete-expected.txt:
              * platform/qt/fast/repaint/selection-after-remove-expected.txt:
              * platform/win/editing/deleting/5168598-expected.txt:
              * platform/win/editing/inserting/4960120-1-expected.txt:
              * platform/win/editing/inserting/5607069-2-expected.txt:
              * platform/win/editing/inserting/5607069-3-expected.txt:
              * platform/win/editing/inserting/typing-tab-designmode-forms-expected.txt:
              * platform/win/editing/pasteboard/4806874-expected.txt:
              * platform/win/editing/selection/4895428-3-expected.txt:
              * platform/win/editing/selection/5136696-expected.txt:
              * platform/win/editing/selection/drag-select-1-expected.txt:
              * platform/win/fast/events/context-no-deselect-expected.txt:
              * platform/win/fast/events/label-focus-expected.txt:
              * platform/win/fast/forms/input-appearance-focus-expected.txt:
              * platform/win/fast/forms/input-text-click-inside-expected.txt:
              * platform/win/fast/forms/input-text-click-outside-expected.txt:
              * platform/win/fast/forms/input-text-double-click-expected.txt:
              * platform/win/fast/forms/input-text-drag-down-expected.txt:
              * platform/win/fast/forms/input-text-option-delete-expected.txt:
              * platform/win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
              * platform/win/fast/forms/input-text-self-emptying-click-expected.txt:
              * platform/win/fast/forms/textfield-drag-into-disabled-expected.txt:
              * platform/win/fast/forms/textfield-overflow-expected.txt:
              Updated BODY element index in test output (for some tests, it increased because of the
              implicitly added <head>, and for others, it decreased because mispositoned <script> is being
              moved into <head>).
      
              * webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive:
              * webarchive/archive-empty-frame-dom-expected.webarchive:
              Updated to include the implicitly added <head> elements.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0295906
  2. 04 May, 2009 1 commit
  3. 29 Apr, 2009 2 commits
    • mitz@apple.com's avatar
      WebCore: · 3d9a5082
      mitz@apple.com authored
              Reviewed by Simon Fraser.
      
              - WebCore part of <rdar://problem/6609509> Select All and then Delete
                should put Mail editing back into the same state as a new message
      
              Test: editing/deleting/in-visibly-empty-root.html
      
              * WebCore.base.exp: Exported VisibleSelection::isAll(bool).
              * editing/SelectionController.h:
              (WebCore::SelectionController::isAll): Added. Calls through to
              VisibleSelection.
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::makeEditableRootEmpty): Added. Removes all children
              of the root editable element the selection is in, other than a
              placeholder. Returns true iff it did anything.
              (WebCore::TypingCommand::deleteKeyPressed): When there is only a single
              visible position in the root editable element, but it has children other
              than a placeholder, remove those children.
              * editing/TypingCommand.h:
              * editing/VisiblePosition.h:
              Added a StayInEditableContent enum and a FIXME.
              * editing/VisibleSelection.cpp:
              (WebCore::VisibleSelection::isAll): Added. Returns whether the
              selection encompasses all visible positions, either in the document or
              in the editable root.
              * editing/VisibleSelection.h:
      
      WebKit/mac:
      
              Reviewed by Simon Fraser.
      
              - WebKit part of <rdar://problem/6609509> Select All and then Delete
                should put Mail editing back into the same state as a new message
      
              * WebView/WebView.mm:
              (-[WebView _selectionIsCaret]): Added.
              (-[WebView _selectionIsAll]): Added. Returns whether the selection
              encompasses the entire document.
              * WebView/WebViewPrivate.h:
      
      LayoutTests:
      
              Reviewed by Simon Fraser.
      
              - test and updated results for <rdar://problem/6609509> Select All and
                then Delete should put Mail editing back into the same state as a new
                message
      
              * editing/deleting/in-visibly-empty-root-expected.txt: Added.
              * editing/deleting/in-visibly-empty-root.html: Added.
              * platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d9a5082
    • ojan@chromium.org's avatar
      Reviewed by Dan Bernstein. · 149606a8
      ojan@chromium.org authored
              Make textarea and text input metrics more closely match IEs.
      
              This involves:
              -set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
              -set textarea width to cols*avgCharWidth
              -Make default CSS match IEs
              -Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.
      
              Those values for textarea and inputs were derived by doing a ton of manual
              testing of IE's width values for various textareas and fonts. On Windows we match
              IE exactly except for a couple fonts of the ~12 tested.
      
              To get the average and max character width of a font, we do the following
              for each platform:
              -Win: TextMetrics expose avgCharWidth and maxCharWidth
              -SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
                  maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
              -Linux: avgCharWidth = width of an '0', fallback on m_xHeight
                  maxCharWidth = max of avgCharWidth and m_ascent
              -Mac: Calculate the avgCharWidth and grab the maxCharWidth off the font.
                  If either one is non-positive, then calculate the value using the Linux approach.
      
              Tests: fast/forms/text-control-intrinsic-widths.html
                     fast/forms/textarea-metrics.html
                     svg/custom/svg-fonts-in-text-controls.html
      
              * css/html4.css:
              * css/themeWin.css:
              * platform/graphics/SimpleFontData.cpp:
              (WebCore::SimpleFontData::SimpleFontData):
              (WebCore::SimpleFontData::initCharWidths):
              * platform/graphics/SimpleFontData.h:
              (WebCore::SimpleFontData::maxCharWidth):
              (WebCore::SimpleFontData::avgCharWidth):
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/chromium/SimpleFontDataLinux.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/gtk/SimpleFontDataGtk.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/gtk/SimpleFontDataPango.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/qt/SimpleFontDataQt.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataCGWin.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataCairoWin.cpp:
              (WebCore::SimpleFontData::platformInit):
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataWin.cpp:
              (WebCore::SimpleFontData::initGDIFont):
              * platform/graphics/wx/SimpleFontDataWx.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::calcPrefWidths):
              * rendering/RenderTextControlMultiLine.cpp:
              (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::preferredContentWidth):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      149606a8
  4. 28 Apr, 2009 1 commit
    • adele@apple.com's avatar
      WebCore: · e2bc16bb
      adele@apple.com authored
      2009-04-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Fix for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
      
              Test: editing/deleting/type-delete-after-quote.html
      
              When a selection is deleted that contains a whole number paragraphs plus a line break, we refrain from merging paragraphs after the delete,
              since it is unclear to most users that such a selection actually ends at the start of the next paragraph.  However, when a user hits delete 
              with a caret selection, they actually do expect the start of that paragraph to be merged into the paragraph before it.  We can tell that 
              we're in this state because the TypingCommand creates the selection to delete but it doesn't change the endingSelection.  So we can tell
              that if we started with a caret selection, then we're not in this special case where we have to protect the user from unexpected behavior 
              from deleting a range they selected.
      
              * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData):
      
      LayoutTests:
      
      2009-04-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Test for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
      
              * editing/deleting/type-delete-after-quote.html: Added.
              * platform/mac/editing/deleting/delete-4038408-fix-expected.txt: This expected result change reflects a change in how the editing is done, 
                but the document structure remains the same, and there are no visible changes to the result.
              * platform/mac/editing/deleting/type-delete-after-quote-expected.checksum: Added.
              * platform/mac/editing/deleting/type-delete-after-quote-expected.png: Added.
              * platform/mac/editing/deleting/type-delete-after-quote-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2bc16bb
  5. 25 Apr, 2009 1 commit
    • adele@apple.com's avatar
      WebCore: · 0f007fae
      adele@apple.com authored
      2009-04-25  Adele Peterson  <adele@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Fix for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
              https://bugs.webkit.org/show_bug.cgi?id=25396
      
              Test: editing/deleting/delete-br-013.html
      
              * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs):
               Only preserve an empty paragraph's style when moving paragraphs around if the selection is still 
               in an empty paragraph after the move occurs.  This was causing the empty paragraph's style to overwrite
               the previous paragraph's style during a delete of an empty paragraph.
      
      LayoutTests:
      
      2009-04-25  Adele Peterson  <adele@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Test for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
              https://bugs.webkit.org/show_bug.cgi?id=25396
      
              * editing/deleting/delete-br-013.html: Added.
              * platform/mac/editing/deleting/delete-br-013-expected.checksum: Added.
              * platform/mac/editing/deleting/delete-br-013-expected.png: Added.
              * platform/mac/editing/deleting/delete-br-013-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f007fae
  6. 24 Apr, 2009 6 commits
    • kmccullough@apple.com's avatar
      2009-04-24 Kevin McCullough <kmccullough@apple.com> · 0cc0765f
      kmccullough@apple.com authored
              When I moved the files I forgot to update the location of the image!
      
              * platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Added.
              * platform/mac/editing/deleting/deletionUI-differing-background.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cc0765f
    • kmccullough@apple.com's avatar
      2009-04-24 Kevin McCullough <kmccullough@apple.com> · 82d4be76
      kmccullough@apple.com authored
              - Build fix.  Removed this test until I can figure out why it's failing.
      
              * platform/mac-leopard/editing/deleting/deletionUI-differing-background-expected.txt: Removed.
              * platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Removed.
              * platform/mac/editing/deleting/deletionUI-differing-background.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82d4be76
    • adele@apple.com's avatar
      2009-04-24 Adele Peterson <adele@apple.com> · 05e163df
      adele@apple.com authored
              Reviewed by Dan Bernstein.
      
              Updating these pixel results to the generated results on Leopard.
      
              * platform/mac/editing/inserting/5510537-expected.checksum:
              * platform/mac/editing/inserting/5510537-expected.png:
              * platform/mac/editing/inserting/6703873-expected.checksum:
              * platform/mac/editing/inserting/6703873-expected.png:
              * platform/mac/editing/selection/select-all-iframe-expected.checksum:
              * platform/mac/editing/selection/select-all-iframe-expected.png:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05e163df
    • adele@apple.com's avatar
      WebCore: · b90bbf34
      adele@apple.com authored
      2009-04-24  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Fix for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup
      
              Test: editing/pasteboard/paste-blockquote-after-blockquote.html
      
              When we have matching quote levels, its ok to merge the starts of the inserted and existing blocks more frequently.
              But we should only merge here if the selection start was inside a mail blockquote.  This prevents against removing a 
              blockquote from newly pasted quoted content that was pasted into an unquoted position.  If that unquoted position happens 
              to be right after another blockquote, we don't want to merge and risk stripping a valid block (and newline) from the pasted content.
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::shouldMergeStart): Also added an early return to always return false when we're already moving paragraphs.
              (WebCore::ReplaceSelectionCommand::doApply): Removed redundant check for when we're moving paragraphs.
              * editing/ReplaceSelectionCommand.h:
      
      LayoutTests:
      
      2009-04-24  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Test for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup
      
              * editing/pasteboard/paste-blockquote-after-blockquote.html: Added.
              * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.checksum: Added.
              * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.png: Added.
              * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b90bbf34
    • adele@apple.com's avatar
      2009-04-23 Adele Peterson <adele@apple.com> · cb3d86bb
      adele@apple.com authored
              Reviewed by Dan Bernstein.
      
              Updating test to make it easier to see the blockquote in the results.
      
              * editing/pasteboard/paste-blockquote-into-blockquote-3.html:
              * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
              * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
              * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb3d86bb
    • mrowe@apple.com's avatar
      Move deletionUI-helpers.js in to the correct location so that the · b7072c8f
      mrowe@apple.com authored
      tests that use it can find it.
      
      * platform/mac/editing/deleting/resources/deletionUI-helpers.js: Renamed from LayoutTests/editing/deleting/resources/deletionUI-helpers.js.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7072c8f
  7. 23 Apr, 2009 2 commits
    • kmccullough@apple.com's avatar
      2009-04-23 Kevin McCullough <kmccullough@apple.com> · f44c9f3d
      kmccullough@apple.com authored
              - Windows build fix.  Mac only tests go in platform/mac
      
              * editing/deleting/deletionUI-borders.html: Removed.
              * editing/deleting/deletionUI-differing-background.html: Removed.
              * editing/deleting/deletionUI-minimum-size.html: Removed.
              * platform/mac/editing/deleting/deletionUI-borders.html: Copied from editing/deleting/deletionUI-borders.html.
              * platform/mac/editing/deleting/deletionUI-differing-background.html: Copied from editing/deleting/deletionUI-differing-background.html.
              * platform/mac/editing/deleting/deletionUI-minimum-size.html: Copied from editing/deleting/deletionUI-minimum-size.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f44c9f3d
    • kmccullough@apple.com's avatar
      WebCore: · db684073
      kmccullough@apple.com authored
      2009-04-23  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Adam Roben.
      
              <rdar://problem/6808109> "Deletion UI" is not available for many
              portions of HTML content
      
              This patch makes the deletion UI show up in some new situations:
              1) If a block's background color is different from its parent's
              2) If a block has a background image.
              3) If a block has a single visible border.
              However the block must now not only be at least a minimum width and
              height, but also exceed a minimum area.  In practice this has led to
              much better element selection. 
      
              * editing/DeleteButtonController.cpp:
              (WebCore::isDeletableElement):
      
      LayoutTests:
      
      2009-04-23  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Adam Roben.
      
              <rdar://problem/6808109> "Deletion UI" is not available for many
              portions of HTML content
      
              This patch makes the deletion UI show up in some new situations:
              1) If a block's background color is different from its parent's
              2) If a block has a background image.
              3) If a block has a single visible border.
              However the block must now not only be at least a minimum width and
              height, but also exceed a minimum area.  In practice this has led to
              much better element selection.
      
              * editing/deleting/deletionUI-borders.html: Added.
              * editing/deleting/deletionUI-differing-background.html: Added.
              * editing/deleting/deletionUI-minimum-size.html: Added.
              * editing/deleting/resources: Added.
              * editing/deleting/resources/deletionUI-helpers.js: Added.
              (debug):
              (determineDeletionUIExistence):
              * platform/mac/editing/deleting/deletionUI-borders-expected.txt: Added.
              * platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Added.
              * platform/mac/editing/deleting/deletionUI-minimum-size-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db684073
  8. 21 Apr, 2009 3 commits
    • darin@apple.com's avatar
      WebCore: · b0d40808
      darin@apple.com authored
      2009-04-21  Darin Adler  <darin@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Bug 25162: REGRESSION (r41176-r41242): Drag-selection above/below the line does not select to beginning/end
              https://bugs.webkit.org/show_bug.cgi?id=25162
              rdar://problem/6764354
      
              * page/Settings.cpp:
              (WebCore::Settings::Settings): Initialize editing behavior to Mac-style for PLATFORM(MAC).
              Later we may want to change this default to encompass other versions running on Mac.
      
              * page/Settings.h: Added EditingBehavior, setEditingBehavior, editingBehavior, and
              m_editingBehavior. Also moved m_maximumDecodedImageSize out of the middle of all
              the bit fields.
      
              * platform/graphics/IntPoint.h: Added a constructor to turn an IntSize into an IntPoint.
              I'm not sure the distinction here is serving us well at the moment. When converting from
              global to local coordinates you want to do IntPoint - IntPoint and have the result be
              another IntPoint, not an IntSize. And so on.
      
              * rendering/RenderBlock.cpp:
              (WebCore::positionForPointRespectingEditingBoundaries): Changed to use pointers more and
              separate coordinates less.
              (WebCore::RenderBlock::positionForPointWithInlineChildren): Turned into a member function.
              Added separate cases to support the Mac and Windows behavior.
              (WebCore::RenderBlock::positionForPoint): Updated for the change above. Also moved the
              computation of pointInContents closer to the place it's used.
      
              * rendering/RenderBlock.h: Updated for the new private member function.
      
      LayoutTests:
      
      2009-04-21  Darin Adler  <darin@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Bug 25162: REGRESSION (r41176-r41242): Drag-selection above/below the line does not select to beginning/end
              https://bugs.webkit.org/show_bug.cgi?id=25162
              rdar://problem/6764354
      
              * editing/selection/resources/click-in-margins-inside-editable-div.js:
              Updated to expect different results on the Mac.
              * editing/selection/resources/click-in-padding-with-multiple-line-boxes.js: Ditto.
      
              * fast/css-generated-content/positioned-background-hit-test-crash.html: Clear the selection at
              the end of the test so the result won't include a caret.
      
              * platform/mac/editing/selection/click-in-margins-inside-editable-div-expected.txt:
              * platform/mac/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
              Copied from LayoutTests/editing/selection. Then changed to expect the different Mac results.
      
              * platform/mac/editing/selection/select-from-textfield-outwards-expected.checksum:
              * platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
              * platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
              Changed to expect the different Mac results.
      
              * platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.txt:
              Changed to expect no caret.
      
              * platform/win/editing/selection/click-in-margins-inside-editable-div-expected.txt:
              * platform/win/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
              Copied from editing/selection.
      
              * platform/win/editing/selection/select-from-textfield-outwards-expected.checksum:
              * platform/win/editing/selection/select-from-textfield-outwards-expected.png:
              * platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
              Copied from platform/mac/editing/selection.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0d40808
    • darin@apple.com's avatar
      2009-04-21 Darin Adler <darin@apple.com> · 58322639
      darin@apple.com authored
              Reviewed by Adele Peterson.
      
              Fix some tests that are depending on Mac vs. Windows selection quirks accidentally.
              Added failing tests to the skipped list for SnowLeopard.
      
              * editing/resources/select-all-iframe-src.html: Moved.
              * editing/selection/resources/select-all-iframe-src.html: Moved from
              editing/resources/select-all-iframe-src.html, since this is used by a test in the
              selection directory. Changed mouse coordinates to be farther to the right so we
              don't depend on the rule for what's selected when you click below text on the last line.
              * editing/selection/select-all-iframe.html: Updated for new location of file above.
      
              * fast/events/standalone-image-drag-to-editable.html: Changed mouse coordinates to be
              farther to the right so we don't depend on the rule for what's selected when you click
              below text on the last line.
      
              * platform/mac-snowleopard/Skipped: Added some tests to the Skipped list.
      
              * svg/custom/pointer-events-path.svg: Clear the selection at the end of the test so it's
              not in the test results. Also removed unneeded use of the layout test controller.
      
              * platform/mac/editing/selection/select-all-iframe-expected.checksum: Generated new results.
              * platform/mac/editing/selection/select-all-iframe-expected.png: Ditto.
              * platform/mac/editing/selection/select-all-iframe-expected.txt: Ditto.
              * platform/mac/fast/events/standalone-image-drag-to-editable-expected.checksum: Ditto.
              * platform/mac/fast/events/standalone-image-drag-to-editable-expected.png: Ditto.
              * platform/mac/fast/events/standalone-image-drag-to-editable-expected.txt: Ditto.
              * platform/mac/svg/custom/pointer-events-path-expected.checksum: Ditto.
              * platform/mac/svg/custom/pointer-events-path-expected.png: Ditto.
              * platform/mac/svg/custom/pointer-events-path-expected.txt: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58322639
    • justin.garcia@apple.com's avatar
      WebCore: · 08d8dad8
      justin.garcia@apple.com authored
      2009-04-21  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=19644
              Text copied with Select All pastes with a indent but shouldn't
              <rdar://problem/6102483> 
              Pasting the content of an HTML message in Mail causes addition nested <div> elements to be added
              
              To improve selectall/copy/paste fidelity of certain pages, we began wrapping copied content with
              a div that held properties and attributes from the fully selected body.  To fix the above issues, 
              only do this if if the body has certain properties or attributes.  We'll begin adding to this list as 
              necessary.  For now it's just background colors and images.  Tested copy/paste of nytimes, wired,
              arstechnica, and several others.
              
              Massive nesting can still happen, it will just be much less common.
      
              * editing/markup.cpp:
              (WebCore::createMarkup): 
      
      LayoutTests:
      
      2009-04-21  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=19644
              Text copied with Select All pastes with a indent but shouldn't
              <rdar://problem/6102483> 
              Pasting the content of an HTML message in Mail causes addition nested <div> elements to be added
      
              * editing/pasteboard/19644-1-expected.txt: Added.
              * editing/pasteboard/19644-1.html: Added.
              * editing/pasteboard/19644-2-expected.txt: Added.
              * editing/pasteboard/19644-2.html: Added.
              * platform/mac/editing/inserting/insert-3907422-fix-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-015-expected.checksum:
              * platform/mac/editing/pasteboard/paste-text-015-expected.png:
              * platform/mac/editing/pasteboard/paste-text-015-expected.txt:
              * platform/mac/editing/style/font-family-with-space-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08d8dad8
  9. 20 Apr, 2009 2 commits
    • ggaren@apple.com's avatar
      WebCore: · 38f70292
      ggaren@apple.com authored
      2009-04-20  Geoffrey Garen  <ggaren@apple.com>
      
              Approved by Mark Rowe, Cameron Zwarich, Oliver Hunt, and Ojan Vafai.
              
              Used svn merge to roll out revisions 42678, 42690, 42694, 42697 because
              they broke the Tiger and Windows buildbots.
      
              * css/html4.css:
              * css/themeWin.css:
              * platform/graphics/SimpleFontData.cpp:
              * platform/graphics/SimpleFontData.h:
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              * platform/graphics/chromium/SimpleFontDataLinux.cpp:
              * platform/graphics/gtk/SimpleFontDataGtk.cpp:
              * platform/graphics/gtk/SimpleFontDataPango.cpp:
              * platform/graphics/mac/SimpleFontDataMac.mm:
              * platform/graphics/qt/SimpleFontDataQt.cpp:
              * platform/graphics/win/SimpleFontDataCGWin.cpp:
              * platform/graphics/win/SimpleFontDataCairoWin.cpp:
              * platform/graphics/win/SimpleFontDataWin.cpp:
              * platform/graphics/wx/SimpleFontDataWx.cpp:
              * rendering/RenderTextControl.cpp:
              * rendering/RenderTextControlMultiLine.cpp:
              * rendering/RenderTextControlSingleLine.cpp:
      
      LayoutTests:
      
      2009-04-20  Geoffrey Garen  <ggaren@apple.com>
      
              Approved by Mark Rowe, Cameron Zwarich, Oliver Hunt, and Ojan Vafai.
              
              Used svn merge to roll out revisions 42678, 42690, 42694, 42697 because
              they broke the Tiger and Windows buildbots.
      
              * fast/forms/drag-out-of-textarea.html:
              * fast/forms/resources/TEMPLATE.html: Removed.
              * fast/forms/resources/text-control-intrinsic-widths.js: Removed.
              * fast/forms/resources/textarea-metrics.js: Removed.
              * fast/forms/search-abs-pos-cancel-button.html:
              * fast/forms/text-control-intrinsic-widths-expected.txt: Removed.
              * fast/forms/text-control-intrinsic-widths.html: Removed.
              * fast/forms/textarea-metrics-expected.txt: Removed.
              * fast/forms/textarea-metrics.html: Removed.
              * fast/forms/textarea-width.html:
              * fast/replaced/table-percent-height-expected.txt:
              * fast/replaced/table-percent-height.html:
              * platform/mac-leopard/fast/forms/input-text-maxlength-expected.checksum:
              * platform/mac-leopard/fast/forms/input-text-maxlength-expected.png:
              * platform/mac-leopard/fast/forms/input-text-maxlength-expected.txt:
              * platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.checksum:
              * platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.png:
              * platform/mac-leopard/fast/forms/input-text-paste-maxlength-expected.txt:
              * platform/mac/editing/deleting/5168598-expected.checksum:
              * platform/mac/editing/deleting/5168598-expected.png:
              * platform/mac/editing/deleting/5168598-expected.txt:
              * platform/mac/editing/inserting/4960120-1-expected.checksum:
              * platform/mac/editing/inserting/4960120-1-expected.png:
              * platform/mac/editing/inserting/4960120-1-expected.txt:
              * platform/mac/editing/inserting/5607069-2-expected.checksum:
              * platform/mac/editing/inserting/5607069-2-expected.png:
              * platform/mac/editing/inserting/5607069-2-expected.txt:
              * platform/mac/editing/inserting/5607069-3-expected.checksum:
              * platform/mac/editing/inserting/5607069-3-expected.png:
              * platform/mac/editing/inserting/5607069-3-expected.txt:
              * platform/mac/editing/inserting/before-after-input-element-expected.checksum:
              * platform/mac/editing/inserting/before-after-input-element-expected.png:
              * platform/mac/editing/inserting/before-after-input-element-expected.txt:
              * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.checksum:
              * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.png:
              * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt:
              * platform/mac/editing/pasteboard/4806874-expected.checksum:
              * platform/mac/editing/pasteboard/4806874-expected.png:
              * platform/mac/editing/pasteboard/4806874-expected.txt:
              * platform/mac/editing/pasteboard/drop-text-without-selection-expected.checksum:
              * platform/mac/editing/pasteboard/drop-text-without-selection-expected.png:
              * platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
              * platform/mac/editing/pasteboard/input-field-1-expected.checksum:
              * platform/mac/editing/pasteboard/input-field-1-expected.png:
              * platform/mac/editing/pasteboard/input-field-1-expected.txt:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.png:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-area-expected.txt:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.png:
              * platform/mac/editing/pasteboard/nested-blocks-with-text-field-expected.txt:
              * platform/mac/editing/pasteboard/pasting-tabs-expected.checksum:
              * platform/mac/editing/pasteboard/pasting-tabs-expected.png:
              * platform/mac/editing/pasteboard/pasting-tabs-expected.txt:
              * platform/mac/editing/selection/3690703-2-expected.checksum:
              * platform/mac/editing/selection/3690703-2-expected.png:
              * platform/mac/editing/selection/3690703-2-expected.txt:
              * platform/mac/editing/selection/3690703-expected.checksum:
              * platform/mac/editing/selection/3690703-expected.png:
              * platform/mac/editing/selection/3690703-expected.txt:
              * platform/mac/editing/selection/3690719-expected.checksum:
              * platform/mac/editing/selection/3690719-expected.png:
              * platform/mac/editing/selection/3690719-expected.txt:
              * platform/mac/editing/selection/4895428-3-expected.checksum:
              * platform/mac/editing/selection/4895428-3-expected.png:
              * platform/mac/editing/selection/4895428-3-expected.txt:
              * platform/mac/editing/selection/4975120-expected.checksum:
              * platform/mac/editing/selection/4975120-expected.png:
              * platform/mac/editing/selection/4975120-expected.txt:
              * platform/mac/editing/selection/5136696-expected.checksum:
              * platform/mac/editing/selection/5136696-expected.png:
              * platform/mac/editing/selection/5136696-expected.txt:
              * platform/mac/editing/selection/5213963-expected.checksum:
              * platform/mac/editing/selection/5213963-expected.png:
              * platform/mac/editing/selection/5213963-expected.txt:
              * platform/mac/editing/selection/drag-select-1-expected.checksum:
              * platform/mac/editing/selection/drag-select-1-expected.png:
              * platform/mac/editing/selection/drag-select-1-expected.txt:
              * platform/mac/editing/selection/drag-text-delay-expected.checksum:
              * platform/mac/editing/selection/drag-text-delay-expected.png:
              * platform/mac/editing/selection/drag-text-delay-expected.txt:
              * platform/mac/editing/selection/select-from-textfield-outwards-expected.checksum:
              * platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
              * platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
              * platform/mac/fast/block/margin-collapse/103-expected.txt:
              * platform/mac/fast/css/line-height-expected.checksum:
              * platform/mac/fast/css/line-height-expected.png:
              * platform/mac/fast/css/line-height-expected.txt:
              * platform/mac/fast/css/resize-corner-tracking-expected.checksum:
              * platform/mac/fast/css/resize-corner-tracking-expected.png:
              * platform/mac/fast/css/resize-corner-tracking-expected.txt:
              * platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.checksum:
              * platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
              * platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
              * platform/mac/fast/dom/isindex-002-expected.checksum:
              * platform/mac/fast/dom/isindex-002-expected.png:
              * platform/mac/fast/dom/isindex-002-expected.txt:
              * platform/mac/fast/dynamic/008-expected.checksum:
              * platform/mac/fast/dynamic/008-expected.png:
              * platform/mac/fast/dynamic/008-expected.txt:
              * platform/mac/fast/events/autoscroll-expected.checksum:
              * platform/mac/fast/events/autoscroll-expected.png:
              * platform/mac/fast/events/autoscroll-expected.txt:
              * platform/mac/fast/events/context-no-deselect-expected.checksum:
              * platform/mac/fast/events/context-no-deselect-expected.png:
              * platform/mac/fast/events/context-no-deselect-expected.txt:
              * platform/mac/fast/events/label-focus-expected.checksum:
              * platform/mac/fast/events/label-focus-expected.png:
              * platform/mac/fast/events/label-focus-expected.txt:
              * platform/mac/fast/forms/basic-textareas-expected.checksum:
              * platform/mac/fast/forms/basic-textareas-expected.png:
              * platform/mac/fast/forms/basic-textareas-expected.txt:
              * platform/mac/fast/forms/box-shadow-override-expected.checksum:
              * platform/mac/fast/forms/box-shadow-override-expected.png:
              * platform/mac/fast/forms/box-shadow-override-expected.txt:
              * platform/mac/fast/forms/control-restrict-line-height-expected.checksum:
              * platform/mac/fast/forms/control-restrict-line-height-expected.png:
              * platform/mac/fast/forms/control-restrict-line-height-expected.txt:
              * platform/mac/fast/forms/encoding-test-expected.checksum:
              * platform/mac/fast/forms/encoding-test-expected.png:
              * platform/mac/fast/forms/encoding-test-expected.txt:
              * platform/mac/fast/forms/fieldset-align-expected.checksum:
              * platform/mac/fast/forms/fieldset-align-expected.png:
              * platform/mac/fast/forms/fieldset-align-expected.txt:
              * platform/mac/fast/forms/form-element-geometry-expected.checksum:
              * platform/mac/fast/forms/form-element-geometry-expected.png:
              * platform/mac/fast/forms/form-element-geometry-expected.txt:
              * platform/mac/fast/forms/input-align-expected.checksum:
              * platform/mac/fast/forms/input-align-expected.png:
              * platform/mac/fast/forms/input-align-expected.txt:
              * platform/mac/fast/forms/input-appearance-bkcolor-expected.checksum:
              * platform/mac/fast/forms/input-appearance-bkcolor-expected.png:
              * platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
              * platform/mac/fast/forms/input-appearance-default-bkcolor-expected.checksum:
              * platform/mac/fast/forms/input-appearance-default-bkcolor-expected.png:
              * platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
              * platform/mac/fast/forms/input-appearance-disabled-expected.checksum:
              * platform/mac/fast/forms/input-appearance-disabled-expected.png:
              * platform/mac/fast/forms/input-appearance-disabled-expected.txt:
              * platform/mac/fast/forms/input-appearance-focus-expected.checksum:
              * platform/mac/fast/forms/input-appearance-focus-expected.png:
              * platform/mac/fast/forms/input-appearance-focus-expected.txt:
              * platform/mac/fast/forms/input-appearance-height-expected.checksum:
              * platform/mac/fast/forms/input-appearance-height-expected.png:
              * platform/mac/fast/forms/input-appearance-height-expected.txt:
              * platform/mac/fast/forms/input-appearance-preventDefault-expected.checksum:
              * platform/mac/fast/forms/input-appearance-preventDefault-expected.png:
              * platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
              * platform/mac/fast/forms/input-appearance-readonly-expected.checksum:
              * platform/mac/fast/forms/input-appearance-readonly-expected.png:
              * platform/mac/fast/forms/input-appearance-readonly-expected.txt:
              * platform/mac/fast/forms/input-appearance-selection-expected.checksum:
              * platform/mac/fast/forms/input-appearance-selection-expected.png:
              * platform/mac/fast/forms/input-appearance-selection-expected.txt:
              * platform/mac/fast/forms/input-appearance-visibility-expected.checksum:
              * platform/mac/fast/forms/input-appearance-visibility-expected.png:
              * platform/mac/fast/forms/input-appearance-visibility-expected.txt:
              * platform/mac/fast/forms/input-appearance-width-expected.checksum:
              * platform/mac/fast/forms/input-appearance-width-expected.png:
              * platform/mac/fast/forms/input-appearance-width-expected.txt:
              * platform/mac/fast/forms/input-baseline-expected.checksum:
              * platform/mac/fast/forms/input-baseline-expected.png:
              * platform/mac/fast/forms/input-baseline-expected.txt:
              * platform/mac/fast/forms/input-disabled-color-expected.checksum:
              * platform/mac/fast/forms/input-disabled-color-expected.png:
              * platform/mac/fast/forms/input-disabled-color-expected.txt:
              * platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.checksum:
              * platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.png:
              * platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
              * platform/mac/fast/forms/input-paste-undo-expected.checksum:
              * platform/mac/fast/forms/input-paste-undo-expected.png:
              * platform/mac/fast/forms/input-paste-undo-expected.txt:
              * platform/mac/fast/forms/input-readonly-autoscroll-expected.checksum:
              * platform/mac/fast/forms/input-readonly-autoscroll-expected.png:
              * platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
              * platform/mac/fast/forms/input-readonly-dimmed-expected.checksum:
              * platform/mac/fast/forms/input-readonly-dimmed-expected.png:
              * platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
              * platform/mac/fast/forms/input-readonly-empty-expected.checksum:
              * platform/mac/fast/forms/input-readonly-empty-expected.png:
              * platform/mac/fast/forms/input-readonly-empty-expected.txt:
              * platform/mac/fast/forms/input-spaces-expected.checksum:
              * platform/mac/fast/forms/input-spaces-expected.png:
              * platform/mac/fast/forms/input-spaces-expected.txt:
              * platform/mac/fast/forms/input-table-expected.txt:
              * platform/mac/fast/forms/input-text-click-inside-expected.checksum:
              * platform/mac/fast/forms/input-text-click-inside-expected.png:
              * platform/mac/fast/forms/input-text-click-inside-expected.txt:
              * platform/mac/fast/forms/input-text-click-outside-expected.checksum:
              * platform/mac/fast/forms/input-text-click-outside-expected.png:
              * platform/mac/fast/forms/input-text-click-outside-expected.txt:
              * platform/mac/fast/forms/input-text-double-click-expected.checksum:
              * platform/mac/fast/forms/input-text-double-click-expected.png:
              * platform/mac/fast/forms/input-text-double-click-expected.txt:
              * platform/mac/fast/forms/input-text-drag-down-expected.checksum:
              * platform/mac/fast/forms/input-text-drag-down-expected.png:
              * platform/mac/fast/forms/input-text-drag-down-expected.txt:
              * platform/mac/fast/forms/input-text-option-delete-expected.checksum:
              * platform/mac/fast/forms/input-text-option-delete-expected.png:
              * platform/mac/fast/forms/input-text-option-delete-expected.txt:
              * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.checksum:
              * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.png:
              * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
              * platform/mac/fast/forms/input-text-self-emptying-click-expected.checksum:
              * platform/mac/fast/forms/input-text-self-emptying-click-expected.png:
              * platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
              * platform/mac/fast/forms/input-text-word-wrap-expected.checksum:
              * platform/mac/fast/forms/input-text-word-wrap-expected.png:
              * platform/mac/fast/forms/input-text-word-wrap-expected.txt:
              * platform/mac/fast/forms/input-type-change2-expected.checksum:
              * platform/mac/fast/forms/input-type-change2-expected.png:
              * platform/mac/fast/forms/input-type-change2-expected.txt:
              * platform/mac/fast/forms/input-type-text-min-width-expected.checksum:
              * platform/mac/fast/forms/input-type-text-min-width-expected.png:
              * platform/mac/fast/forms/input-type-text-min-width-expected.txt:
              * platform/mac/fast/forms/input-value-expected.checksum:
              * platform/mac/fast/forms/input-value-expected.png:
              * platform/mac/fast/forms/input-value-expected.txt:
              * platform/mac/fast/forms/input-width-expected.checksum:
              * platform/mac/fast/forms/input-width-expected.png:
              * platform/mac/fast/forms/input-width-expected.txt:
              * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
              * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
              * platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
              * platform/mac/fast/forms/negativeLineHeight-expected.checksum:
              * platform/mac/fast/forms/negativeLineHeight-expected.png:
              * platform/mac/fast/forms/negativeLineHeight-expected.txt:
              * platform/mac/fast/forms/password-placeholder-expected.checksum:
              * platform/mac/fast/forms/password-placeholder-expected.png:
              * platform/mac/fast/forms/password-placeholder-expected.txt:
              * platform/mac/fast/forms/password-placeholder-text-security-expected.checksum:
              * platform/mac/fast/forms/password-placeholder-text-security-expected.png:
              * platform/mac/fast/forms/password-placeholder-text-security-expected.txt:
              * platform/mac/fast/forms/placeholder-pseudo-style-expected.checksum:
              * platform/mac/fast/forms/placeholder-pseudo-style-expected.png:
              * platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
              * platform/mac/fast/forms/placeholder-set-attribute-expected.checksum:
              * platform/mac/fast/forms/placeholder-set-attribute-expected.png:
              * platform/mac/fast/forms/placeholder-set-attribute-expected.txt:
              * platform/mac/fast/forms/placeholder-set-value-expected.checksum:
              * platform/mac/fast/forms/placeholder-set-value-expected.png:
              * platform/mac/fast/forms/placeholder-set-value-expected.txt:
              * platform/mac/fast/forms/search-cancel-button-style-sharing-expected.checksum:
              * platform/mac/fast/forms/search-cancel-button-style-sharing-expected.png:
              * platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
              * platform/mac/fast/forms/search-display-none-cancel-button-expected.checksum:
              * platform/mac/fast/forms/search-display-none-cancel-button-expected.png:
              * platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
              * platform/mac/fast/forms/search-placeholder-value-changed-expected.checksum:
              * platform/mac/fast/forms/search-placeholder-value-changed-expected.png:
              * platform/mac/fast/forms/search-placeholder-value-changed-expected.txt:
              * platform/mac/fast/forms/search-rtl-expected.checksum:
              * platform/mac/fast/forms/search-rtl-expected.png:
              * platform/mac/fast/forms/search-rtl-expected.txt:
              * platform/mac/fast/forms/search-transformed-expected.checksum:
              * platform/mac/fast/forms/search-transformed-expected.png:
              * platform/mac/fast/forms/search-transformed-expected.txt:
              * platform/mac/fast/forms/search-zoomed-expected.checksum:
              * platform/mac/fast/forms/search-zoomed-expected.png:
              * platform/mac/fast/forms/search-zoomed-expected.txt:
              * platform/mac/fast/forms/searchfield-heights-expected.checksum:
              * platform/mac/fast/forms/searchfield-heights-expected.png:
              * platform/mac/fast/forms/searchfield-heights-expected.txt:
              * platform/mac/fast/forms/tabbing-input-iframe-expected.checksum:
              * platform/mac/fast/forms/tabbing-input-iframe-expected.png:
              * platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
              * platform/mac/fast/forms/textAreaLineHeight-expected.checksum:
              * platform/mac/fast/forms/textAreaLineHeight-expected.png:
              * platform/mac/fast/forms/textAreaLineHeight-expected.txt:
              * platform/mac/fast/forms/textarea-align-expected.checksum:
              * platform/mac/fast/forms/textarea-align-expected.png:
              * platform/mac/fast/forms/textarea-align-expected.txt:
              * platform/mac/fast/forms/textarea-rows-cols-expected.checksum:
              * platform/mac/fast/forms/textarea-rows-cols-expected.png:
              * platform/mac/fast/forms/textarea-rows-cols-expected.txt:
              * platform/mac/fast/forms/textarea-scroll-height-expected.checksum:
              * platform/mac/fast/forms/textarea-scroll-height-expected.png:
              * platform/mac/fast/forms/textarea-scroll-height-expected.txt:
              * platform/mac/fast/forms/textarea-scrollbar-expected.checksum:
              * platform/mac/fast/forms/textarea-scrollbar-expected.png:
              * platform/mac/fast/forms/textarea-scrollbar-expected.txt:
              * platform/mac/fast/forms/textarea-scrolled-type-expected.checksum:
              * platform/mac/fast/forms/textarea-scrolled-type-expected.png:
              * platform/mac/fast/forms/textarea-scrolled-type-expected.txt:
              * platform/mac/fast/forms/textarea-setinnerhtml-expected.checksum:
              * platform/mac/fast/forms/textarea-setinnerhtml-expected.png:
              * platform/mac/fast/forms/textarea-setinnerhtml-expected.txt:
              * platform/mac/fast/forms/textarea-width-expected.checksum:
              * platform/mac/fast/forms/textarea-width-expected.png:
              * platform/mac/fast/forms/textarea-width-expected.txt:
              * platform/mac/fast/forms/textfield-drag-into-disabled-expected.checksum:
              * platform/mac/fast/forms/textfield-drag-into-disabled-expected.png:
              * platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt:
              * platform/mac/fast/forms/textfield-outline-expected.checksum:
              * platform/mac/fast/forms/textfield-outline-expected.png:
              * platform/mac/fast/forms/textfield-outline-expected.txt:
              * platform/mac/fast/forms/textfield-overflow-expected.checksum:
              * platform/mac/fast/forms/textfield-overflow-expected.png:
              * platform/mac/fast/forms/textfield-overflow-expected.txt:
              * platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
              * platform/mac/fast/invalid/residual-style-expected.txt:
              * platform/mac/fast/lists/dynamic-marker-crash-expected.checksum:
              * platform/mac/fast/lists/dynamic-marker-crash-expected.png:
              * platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
              * platform/mac/fast/overflow/overflow-x-y-expected.checksum:
              * platform/mac/fast/overflow/overflow-x-y-expected.png:
              * platform/mac/fast/overflow/overflow-x-y-expected.txt:
              * platform/mac/fast/parser/comment-in-textarea-expected.checksum:
              * platform/mac/fast/parser/comment-in-textarea-expected.png:
              * platform/mac/fast/parser/comment-in-textarea-expected.txt:
              * platform/mac/fast/parser/entity-comment-in-textarea-expected.checksum:
              * platform/mac/fast/parser/entity-comment-in-textarea-expected.png:
              * platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
              * platform/mac/fast/parser/open-comment-in-textarea-expected.checksum:
              * platform/mac/fast/parser/open-comment-in-textarea-expected.png:
              * platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
              * platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum:
              * platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
              * platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
              * platform/mac/fast/repaint/search-field-cancel-expected.checksum:
              * platform/mac/fast/repaint/search-field-cancel-expected.png:
              * platform/mac/fast/repaint/search-field-cancel-expected.txt:
              * platform/mac/fast/repaint/subtree-root-skipped-expected.checksum:
              * platform/mac/fast/repaint/subtree-root-skipped-expected.png:
              * platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
              * platform/mac/fast/replaced/replaced-breaking-expected.checksum:
              * platform/mac/fast/replaced/replaced-breaking-expected.png:
              * platform/mac/fast/replaced/replaced-breaking-expected.txt:
              * platform/mac/fast/replaced/replaced-breaking-mixture-expected.checksum:
              * platform/mac/fast/replaced/replaced-breaking-mixture-expected.png:
              * platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
              * platform/mac/fast/replaced/width100percent-searchfield-expected.checksum:
              * platform/mac/fast/replaced/width100percent-searchfield-expected.png:
              * platform/mac/fast/replaced/width100percent-searchfield-expected.txt:
              * platform/mac/fast/replaced/width100percent-textarea-expected.checksum:
              * platform/mac/fast/replaced/width100percent-textarea-expected.png:
              * platform/mac/fast/replaced/width100percent-textarea-expected.txt:
              * platform/mac/fast/replaced/width100percent-textfield-expected.checksum:
              * platform/mac/fast/replaced/width100percent-textfield-expected.png:
              * platform/mac/fast/replaced/width100percent-textfield-expected.txt:
              * platform/mac/fast/table/003-expected.checksum:
              * platform/mac/fast/table/003-expected.png:
              * platform/mac/fast/table/003-expected.txt:
              * platform/mac/fast/table/colspanMinWidth-expected.checksum:
              * platform/mac/fast/table/colspanMinWidth-expected.png:
              * platform/mac/fast/table/colspanMinWidth-expected.txt:
              * platform/mac/fast/table/spanOverlapRepaint-expected.checksum:
              * platform/mac/fast/table/spanOverlapRepaint-expected.png:
              * platform/mac/fast/table/spanOverlapRepaint-expected.txt:
              * platform/mac/fast/table/text-field-baseline-expected.checksum:
              * platform/mac/fast/table/text-field-baseline-expected.png:
              * platform/mac/fast/table/text-field-baseline-expected.txt:
              * platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.checksum:
              * platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.png:
              * platform/mac/fast/text/international/rtl-white-space-pre-wrap-expected.txt:
              * platform/mac/fast/text/textIteratorNilRenderer-expected.checksum:
              * platform/mac/fast/text/textIteratorNilRenderer-expected.png:
              * platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
              * platform/mac/fast/transforms/transformed-focused-text-input-expected.checksum:
              * platform/mac/fast/transforms/transformed-focused-text-input-expected.png:
              * platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
              * platform/mac/http/tests/navigation/anchor-basic-expected.checksum:
              * platform/mac/http/tests/navigation/anchor-basic-expected.png:
              * platform/mac/http/tests/navigation/anchor-basic-expected.txt:
              * platform/mac/http/tests/navigation/anchor-frames-expected.txt:
              * platform/mac/http/tests/navigation/anchor-goback-expected.checksum:
              * platform/mac/http/tests/navigation/anchor-goback-expected.png:
              * platform/mac/http/tests/navigation/anchor-goback-expected.txt:
              * platform/mac/http/tests/navigation/anchor-subframeload-expected.txt:
              * platform/mac/http/tests/navigation/javascriptlink-basic-expected.checksum:
              * platform/mac/http/tests/navigation/javascriptlink-basic-expected.png:
              * platform/mac/http/tests/navigation/javascriptlink-basic-expected.txt:
              * platform/mac/http/tests/navigation/javascriptlink-frames-expected.checksum:
              * platform/mac/http/tests/navigation/javascriptlink-frames-expected.png:
              * platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
              * platform/mac/http/tests/navigation/javascriptlink-goback-expected.checksum:
              * platform/mac/http/tests/navigation/javascriptlink-goback-expected.png:
              * platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt:
              * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.checksum:
              * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.png:
              * platform/mac/http/tests/navigation/javascriptlink-subframeload-expected.txt:
              * platform/mac/http/tests/navigation/metaredirect-basic-expected.checksum:
              * platform/mac/http/tests/navigation/metaredirect-basic-expected.png:
              * platform/mac/http/tests/navigation/metaredirect-basic-expected.txt:
              * platform/mac/http/tests/navigation/metaredirect-frames-expected.checksum:
              * platform/mac/http/tests/navigation/metaredirect-frames-expected.png:
              * platform/mac/http/tests/navigation/metaredirect-frames-expected.txt:
              * platform/mac/http/tests/navigation/metaredirect-goback-expected.checksum:
              * platform/mac/http/tests/navigation/metaredirect-goback-expected.png:
              * platform/mac/http/tests/navigation/metaredirect-goback-expected.txt:
              * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.checksum:
              * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.png:
              * platform/mac/http/tests/navigation/metaredirect-subframeload-expected.txt:
              * platform/mac/http/tests/navigation/post-goback2-expected.checksum:
              * platform/mac/http/tests/navigation/post-goback2-expected.png:
              * platform/mac/http/tests/navigation/post-goback2-expected.txt:
              * platform/mac/http/tests/navigation/postredirect-goback2-expected.checksum:
              * platform/mac/http/tests/navigation/postredirect-goback2-expected.png:
              * platform/mac/http/tests/navigation/postredirect-goback2-expected.txt:
              * platform/mac/http/tests/navigation/redirect302-basic-expected.checksum:
              * platform/mac/http/tests/navigation/redirect302-basic-expected.png:
              * platform/mac/http/tests/navigation/redirect302-basic-expected.txt:
              * platform/mac/http/tests/navigation/redirect302-frames-expected.checksum:
              * platform/mac/http/tests/navigation/redirect302-frames-expected.png:
              * platform/mac/http/tests/navigation/redirect302-frames-expected.txt:
              * platform/mac/http/tests/navigation/redirect302-goback-expected.checksum:
              * platform/mac/http/tests/navigation/redirect302-goback-expected.png:
              * platform/mac/http/tests/navigation/redirect302-goback-expected.txt:
              * platform/mac/http/tests/navigation/redirect302-subframeload-expected.checksum:
              * platform/mac/http/tests/navigation/redirect302-subframeload-expected.png:
              * platform/mac/http/tests/navigation/redirect302-subframeload-expected.txt:
              * platform/mac/http/tests/navigation/relativeanchor-basic-expected.checksum:
              * platform/mac/http/tests/navigation/relativeanchor-basic-expected.png:
              * platform/mac/http/tests/navigation/relativeanchor-basic-expected.txt:
              * platform/mac/http/tests/navigation/relativeanchor-frames-expected.txt:
              * platform/mac/http/tests/navigation/relativeanchor-goback-expected.checksum:
              * platform/mac/http/tests/navigation/relativeanchor-goback-expected.png:
              * platform/mac/http/tests/navigation/relativeanchor-goback-expected.txt:
              * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.checksum:
              * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.png:
              * platform/mac/http/tests/navigation/slowmetaredirect-basic-expected.txt:
              * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.checksum:
              * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.png:
              * platform/mac/http/tests/navigation/slowtimerredirect-basic-expected.txt:
              * platform/mac/http/tests/navigation/success200-basic-expected.checksum:
              * platform/mac/http/tests/navigation/success200-basic-expected.png:
              * platform/mac/http/tests/navigation/success200-basic-expected.txt:
              * platform/mac/http/tests/navigation/success200-frames-expected.checksum:
              * platform/mac/http/tests/navigation/success200-frames-expected.png:
              * platform/mac/http/tests/navigation/success200-frames-expected.txt:
              * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.checksum:
              * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.png:
              * platform/mac/http/tests/navigation/success200-frames-loadsame-expected.txt:
              * platform/mac/http/tests/navigation/success200-goback-expected.checksum:
              * platform/mac/http/tests/navigation/success200-goback-expected.png:
              * platform/mac/http/tests/navigation/success200-goback-expected.txt:
              * platform/mac/http/tests/navigation/success200-loadsame-expected.checksum:
              * platform/mac/http/tests/navigation/success200-loadsame-expected.png:
              * platform/mac/http/tests/navigation/success200-loadsame-expected.txt:
              * platform/mac/http/tests/navigation/success200-reload-expected.checksum:
              * platform/mac/http/tests/navigation/success200-reload-expected.png:
              * platform/mac/http/tests/navigation/success200-reload-expected.txt:
              * platform/mac/http/tests/navigation/success200-subframeload-expected.checksum:
              * platform/mac/http/tests/navigation/success200-subframeload-expected.png:
              * platform/mac/http/tests/navigation/success200-subframeload-expected.txt:
              * platform/mac/http/tests/navigation/timerredirect-basic-expected.checksum:
              * platform/mac/http/tests/navigation/timerredirect-basic-expected.png:
              * platform/mac/http/tests/navigation/timerredirect-basic-expected.txt:
              * platform/mac/http/tests/navigation/timerredirect-frames-expected.checksum:
              * platform/mac/http/tests/navigation/timerredirect-frames-expected.png:
              * platform/mac/http/tests/navigation/timerredirect-frames-expected.txt:
              * platform/mac/http/tests/navigation/timerredirect-goback-expected.checksum:
              * platform/mac/http/tests/navigation/timerredirect-goback-expected.png:
              * platform/mac/http/tests/navigation/timerredirect-goback-expected.txt:
              * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.checksum:
              * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.png:
              * platform/mac/http/tests/navigation/timerredirect-subframeload-expected.txt:
              * platform/mac/svg/custom/inline-svg-in-xhtml-expected.checksum:
              * platform/mac/svg/custom/inline-svg-in-xhtml-expected.png:
              * platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
              * platform/mac/svg/hixie/mixed/003-expected.checksum:
              * platform/mac/svg/hixie/mixed/003-expected.png:
              * platform/mac/svg/hixie/mixed/003-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug1188-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug1188-expected.png:
              * platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug12384-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug12384-expected.png:
              * platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug18359-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug18359-expected.png:
              * platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug194024-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug194024-expected.png:
              * platform/mac/tables/mozilla/bugs/bug194024-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug24200-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug24200-expected.png:
              * platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug2479-2-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug2479-2-expected.png:
              * platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug2479-3-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug2479-3-expected.png:
              * platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug28928-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug28928-expected.png:
              * platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug30559-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug30559-expected.png:
              * platform/mac/tables/mozilla/bugs/bug30559-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug30692-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug30692-expected.png:
              * platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug4382-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug4382-expected.png:
              * platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug4527-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug4527-expected.png:
              * platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug46368-1-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug46368-1-expected.png:
              * platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug46368-2-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug46368-2-expected.png:
              * platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug51037-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug51037-expected.png:
              * platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug55545-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug55545-expected.png:
              * platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug59354-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug59354-expected.png:
              * platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug7342-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug7342-expected.png:
              * platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug96334-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug96334-expected.png:
              * platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
              * platform/mac/tables/mozilla/bugs/bug99948-expected.checksum:
              * platform/mac/tables/mozilla/bugs/bug99948-expected.png:
              * platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
              * platform/mac/tables/mozilla/dom/tableDom-expected.checksum:
              * platform/mac/tables/mozilla/dom/tableDom-expected.png:
              * platform/mac/tables/mozilla/dom/tableDom-expected.txt:
              * platform/mac/tables/mozilla/other/move_row-expected.checksum:
              * platform/mac/tables/mozilla/other/move_row-expected.png:
              * platform/mac/tables/mozilla/other/move_row-expected.txt:
              * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
              * platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.checksum:
              * platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
              * platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
              * platform/win/Skipped:
              * svg/custom/resources/svg-fonts-in-text-controls.js:
              * svg/custom/svg-fonts-in-text-controls-expected.txt:
              * svg/custom/svg-fonts-in-text-controls.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38f70292
    • eric@webkit.org's avatar
      Reviewed by Dan Bernstein. · 596d7208
      eric@webkit.org authored
              Make textarea and text input metrics more closely match IEs.
              https://bugs.webkit.org/show_bug.cgi?id=15312
      
              This involves:
              -set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
              -set textarea width to cols*avgCharWidth
              -Make default CSS match IEs
              -Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.
      
              Those values for textarea and inputs were derived by doing a ton of manual
              testing of IE's width values for various textareas and fonts.
      
              To get the average and max character width of a font, we do the following
              for each platform:
              -Win: TextMetrics expose avgCharWidth and maxCharWidth
              -SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
                  maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
              -Linux: avgCharWidth = width of an '0', fallback on m_xHeight
                  maxCharWidth = max of avgCharWidth and m_ascent
              -Mac: look in the OS/2 table for avgCharWidth and grab the maxCharWidth off the font.
                  If either one is not there, then calculate the value using the Linux approach.
      
              Linux ports could probably dig into the OS/2 table as well, but I'll leave
              that up to them to implement.
      
              Tests: fast/forms/text-control-intrinsic-widths.html
                     fast/forms/textarea-metrics.html
                     svg/custom/svg-fonts-in-text-controls.html
      
              * css/html4.css:
              * css/themeWin.css:
              * platform/graphics/SimpleFontData.cpp:
              (WebCore::SimpleFontData::SimpleFontData):
              (WebCore::SimpleFontData::initCharWidths):
              * platform/graphics/SimpleFontData.h:
              (WebCore::SimpleFontData::maxCharWidth):
              (WebCore::SimpleFontData::avgCharWidth):
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/chromium/SimpleFontDataLinux.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/gtk/SimpleFontDataGtk.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/gtk/SimpleFontDataPango.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/qt/SimpleFontDataQt.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataCGWin.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataCairoWin.cpp:
              (WebCore::SimpleFontData::platformInit):
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataWin.cpp:
              (WebCore::SimpleFontData::initGDIFont):
              * platform/graphics/wx/SimpleFontDataWx.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::calcPrefWidths):
              * rendering/RenderTextControlMultiLine.cpp:
              (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::preferredContentWidth):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      596d7208
  10. 16 Apr, 2009 2 commits
  11. 15 Apr, 2009 1 commit
    • justin.garcia@apple.com's avatar
      WebCore: · 14e64dcc
      justin.garcia@apple.com authored
      2009-04-15  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=25204
              Create a fast path for ReplaceSelectionCommand that merges text nodes
              
              During simple pastes, where we're just pasting a text node into a run of text, we would split the current
              text and insert the new node in between.  This is slow and we hit this bug:
      
              https://bugs.webkit.org/show_bug.cgi?id=6148
      
              in the layout and rendering code where adjacent text nodes don't shape correctly in Arabic.
              
              This change creates a fast path for ReplaceSelectionCommand that inserts text directly into the
              text node that holds the selection (very similar to the fast path we wrote for InsertTextCommand).
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              (WebCore::ReplaceSelectionCommand::performTrivialReplace):
              * editing/ReplaceSelectionCommand.h:
              * editing/TextIterator.cpp:
      
      LayoutTests:
      
      2009-04-15  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Dan Bernstein.
              
              https://bugs.webkit.org/show_bug.cgi?id=25204
              Create a fast path for ReplaceSelectionCommand that merges text nodes
              
              Simplified DOM/Render trees:
              * editing/pasteboard/4840662-expected.txt:
              * platform/mac/editing/pasteboard/bad-placeholder-expected.txt:
              * platform/mac/editing/pasteboard/paste-match-style-001-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-019-expected.txt:
              * platform/mac/editing/pasteboard/paste-xml-expected.txt:
      
              Removed redundant styles that were generated during nesting prevention that is no longer needed:
              * platform/mac/editing/pasteboard/4076267-2-expected.txt:
              * platform/mac/editing/pasteboard/5156401-1-expected.txt:
              
              No longer incorrectly uncollapsing unrendered whitespace:
              * editing/pasteboard/paste-into-anchor-text-expected.txt:
              * platform/mac/editing/pasteboard/5387578-expected.txt:
              
              No longer invalidating the old selected DOM range during a paste:
              * editing/pasteboard/copy-in-password-field-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14e64dcc
  12. 14 Apr, 2009 1 commit
    • adele@apple.com's avatar
      2009-04-13 Adele Peterson <adele@apple.com> · 44641760
      adele@apple.com authored
              Reviewed by Darin Adler.
      
              Fix for <rdar://problem/6703873> Triple-click quoted line and type Return creates an extra quoted blank line
      
              Test: editing/inserting/6703873.html
      
              * editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply):
              If the startNode's original parent is now empty, we can remove it.  Its already been cloned and copied with the startNode,
              so we only need to keep it around if it actually holds some original content, otherwise it will look like an extra empty 
              container in the document.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44641760
  13. 13 Apr, 2009 1 commit
    • adele@apple.com's avatar
      WebCore: · dbe21c6f
      adele@apple.com authored
      2009-04-13  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Fix for <rdar://problem/5510537> Typing return at start of block quote yields empty quoted line
      
              Test: editing/inserting/5510537.html
      
              * editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): If the break insertion position
              is at the beginning of the topmost quote, then just insert the <br> before the blockquote.  Otherwise, if the break
              insertion position is at the beginning of any quote, adjust the position so the break comes before the current quote level
              so we don't end up with an empty line in that quote in addition to the new line we're adding with the <br>.
      
      LayoutTests:
      
      2009-04-13  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Test for <rdar://problem/5510537> Typing return at start of block quote yields empty quoted line
      
              * editing/inserting/5510537.html: Added.
              * platform/mac/editing/inserting/5510537-expected.checksum: Added.
              * platform/mac/editing/inserting/5510537-expected.png: Added.
              * platform/mac/editing/inserting/5510537-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbe21c6f
  14. 11 Apr, 2009 1 commit
    • adele@apple.com's avatar
      WebCore: · 65426e30
      adele@apple.com authored
      2009-04-11  Adele Peterson  <adele@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Fix for <rdar://problem/6609479> Pressing return inside a table cell that's inside quoted content will split the table
      
              Test: editing/inserting/6609479.html
      
              Don't break a blockquote if pasting or inserting into a table.
      
              * editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply):
              * editing/TypingCommand.cpp: (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
      
      LayoutTests:
      
      2009-04-11  Adele Peterson  <adele@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Tests for <rdar://problem/6609479> Pressing return inside a table cell that's inside quoted content will split the table
      
              * editing/inserting/5418891.html: Changed test so it doesn't involve tables.
              * editing/inserting/6609479-expected.txt: Added.
              * editing/inserting/6609479.html: Added.
              * platform/mac/editing/inserting/5418891-expected.checksum:
              * platform/mac/editing/inserting/5418891-expected.png:
              * platform/mac/editing/inserting/5418891-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65426e30
  15. 09 Apr, 2009 1 commit
    • mitz@apple.com's avatar
      WebCore: · aa6ce3d8
      mitz@apple.com authored
      2009-04-09  Dan Bernstein  <mitz@apple.com>
      
              Reviewed by Dave Hyatt.
      
              - fix <rdar://problem/6166612> Text boxes' metrics should be based on
                the actual fonts used in them, not just the primary font
      
              Covered by many existing layout tests
      
              * platform/graphics/Font.cpp:
              (WebCore::Font::floatWidth): Added a fallbackFonts parameter. If the
              platform supports collecting fallback fonts in its complex font path
              and fallbackFonts is not null, all fallback fonts used for the text run
              will be added to it.
      
              * platform/graphics/Font.h:
              (WebCore::Font::width): Ditto.
      
              * platform/graphics/FontFastPath.cpp:
              (WebCore::Font::glyphDataForCharacter): Removed an unnecessary namespace
              qualifier.
              (WebCore::Font::floatWidthForSimpleText): Added a fallbackFonts
              parameter, which is passed down to WidthIterator.
      
              * platform/graphics/WidthIterator.cpp:
              (WebCore::WidthIterator::WidthIterator): Added a fallbackFonts parameter
              and used it to initialize the m_fallbackFonts member.
              (WebCore::WidthIterator::advance): Track the fonts being used and add
              any fallback fonts to the m_fallbackFonts set. Make sure to only add
              non-small-caps fonts.
      
              * platform/graphics/WidthIterator.h:
      
              * platform/graphics/chromium/FontChromiumWin.cpp:
              (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
              implementation that returns false, meaning this platform's
              implementation of floatWidthForComplexText() does not populate the
              fallbackFonts set.
              (WebCore::Font::floatWidthForComplexText): Updated for the new
              prototype.
      
              * platform/graphics/chromium/FontLinux.cpp: Ditto.
      
              * platform/graphics/gtk/FontGtk.cpp: Ditto.
      
              * platform/graphics/mac/CoreTextController.cpp:
              (WebCore::CoreTextController::CoreTextController): Added a fallbackFonts
              parameter and used it to initialize the m_fallbackFonts member.
              (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Add
              fallback fonts to m_fallbackFonts.
      
              * platform/graphics/mac/CoreTextController.h:
      
              * platform/graphics/mac/FontMac.mm:
              (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
              implementation that returns true, indicating that the Mac
              implementations of floatWidthForComplexText() populate the fallbackFonts
              set.
              * platform/graphics/mac/FontMacATSUI.mm:
              (WebCore::ATSULayoutParameters::ATSULayoutParameters): Added a
              fallbackFonts parameter and used it to initialize the m_fallbackFonts
              member.
              (WebCore::ATSULayoutParameters::initialize): Add fallback fonts to
              m_fallbackFonts.
              (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
              parameter, which is passed down to ATSULayoutParameters.
      
              * platform/graphics/mac/FontMacCoreText.cpp:
              (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
              parameter, which is passed down to CoreTextController.
      
              * platform/graphics/win/FontWin.cpp:
              (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
              implementation that returns true, indicating that the
              UniscribeController-based implementations of floatWidthForComplexText()
              populate the fallbackFonts set.
              (WebCore::Font::floatWidthForComplexText): Added a fallbackFonts
              parameter, which is passed down to UniscribeController.
      
              * platform/graphics/win/UniscribeController.cpp:
              (WebCore::UniscribeController::UniscribeController): Added a
              fallbackfonts parameter and used it to initialize m_fallbackFonts.
              (WebCore::UniscribeController::advance): Add fallback fonts to
              m_fallbackFonts.
      
              * platform/graphics/win/UniscribeController.h:
              
              * platform/graphics/wx/FontWx.cpp:
              (WebCore::Font::canReturnFallbackFontsForComplexText): Added an
              implementation that returns false, meaning this platform's
              implementation of floatWidthForComplexText() does not populate the
              fallbackFonts set.
              (WebCore::Font::floatWidthForComplexText): Updated for the new
              prototype.
      
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::computeLogicalBoxHeights): For an InlineTextBox
              with multiple fonts, compute a common baseline and line height by
              considering all fonts' ascents and descents (and line spacing, if
              applicable).
      
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::setFallbackFonts): Added. Temporarily stores
              the set of fallback fonts in a vector.
              (WebCore::InlineTextBox::takeFallbackFonts): Added. Returns the fallback
              fonts previously stored and removes them from storage.
      
              * rendering/InlineTextBox.h:
      
              * rendering/RenderText.cpp:
              (WebCore::RenderText::RenderText): Initialized the
              m_knownNotToUseFallbackFonts to false.
              (WebCore::RenderText::styleDidChange): Reset
              m_knownNotToUseFallbackFonts to false if the style difference is such that
              affects layout.
              (WebCore::RenderText::widthFromCache): Added a fallbackFonts parameter,
              which is passed down to Font::width().
              (WebCore::RenderText::trimmedPrefWidths): Updated for the change to
              widthFromCache().
              (WebCore::RenderText::calcPrefWidths): Made this call a private version
              of calcPrefWidths() that takes a fallbackFonts parameter and set the
              m_knownNotToUseFallbackFonts to true if the set comes back empty.
              The private version passes the fallbackFonts set to widthFromCache().
              (WebCore::RenderText::setText): Reset m_knownNotToUseFallbackFonts to
              false.
              (WebCore::RenderText::createFallbackFontMetricsBox): Added.
              (WebCore::RenderText::width): Added a fallbackFonts parameter, which is
              passed down to calcPrefWidths(), widthFromCache() and Font::width().
              Set m_knownNotToUseFallbackFonts to true when appropriate.
      
              * rendering/RenderText.h:
      
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::constructLine): Added an assertion and a continue
              statement to remove one level of indentation.
              (WebCore::RenderBlock::computeHorizontalPositionsForLine): Temporarily
              store the set of fallback fonts in the InlineTextBox.
              (WebCore::RenderBlock::computeVerticalPositionsForLine): Added an
              assertion.
      
      LayoutTests:
      
      2009-04-09  Dan Bernstein  <mitz@apple.com>
      
              Reviewed by Dave Hyatt.
      
              - updated results for <rdar://problem/6166612> Text boxes' metrics should be based on
                the actual fonts used in them, not just the primary font
      
              * editing/selection/extend-selection-bidi-expected.txt:
              * fast/text/offsetForPosition-cluster-at-zero-expected.txt:
              * platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.checksum:
              * platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.png:
              * platform/mac-leopard/fast/text/atsui-multiple-renderers-expected.txt:
              * platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
              * platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.png:
              * platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt:
              * platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.checksum:
              * platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.png:
              * platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt:
              * platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.checksum:
              * platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.png:
              * platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
              * platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
              * platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
              * platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
              * platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum:
              * platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png:
              * platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
              * platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
              * platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
              * platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
              * platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum:
              * platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png:
              * platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
              * platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum:
              * platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png:
              * platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
              * platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum:
              * platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png:
              * platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
              * platform/mac/css2.1/t0905-c414-flt-02-c-expected.checksum:
              * platform/mac/css2.1/t0905-c414-flt-02-c-expected.png:
              * platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt:
              * platform/mac/css2.1/t0905-c414-flt-03-c-expected.checksum:
              * platform/mac/css2.1/t0905-c414-flt-03-c-expected.png:
              * platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt:
              * platform/mac/css2.1/t0905-c414-flt-04-c-expected.checksum:
              * platform/mac/css2.1/t0905-c414-flt-04-c-expected.png:
              * platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt:
              * platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum:
              * platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png:
              * platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt:
              * platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum:
              * platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.png:
              * platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.txt:
              * platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
              * platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
              * platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
              * platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
              * platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
              * platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
              * platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.checksum:
              * platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png:
              * platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
              * platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum:
              * platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
              * platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
              * platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.checksum:
              * platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.png:
              * platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.txt:
              * platform/mac/css2.1/t090501-c414-flt-01-b-expected.checksum:
              * platform/mac/css2.1/t090501-c414-flt-01-b-expected.png:
              * platform/mac/css2.1/t090501-c414-flt-01-b-expected.txt:
              * platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
              * platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
              * platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
              * platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
              * platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
              * platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt:
              * platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
              * platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
              * platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt:
              * platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
              * platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
              * platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt:
              * platform/mac/css2.1/t1202-counter-03-b-expected.checksum:
              * platform/mac/css2.1/t1202-counter-03-b-expected.png:
              * platform/mac/css2.1/t1202-counter-03-b-expected.txt:
              * platform/mac/css2.1/t1202-counter-04-b-expected.checksum:
              * platform/mac/css2.1/t1202-counter-04-b-expected.png:
              * platform/mac/css2.1/t1202-counter-04-b-expected.txt:
              * platform/mac/css2.1/t1202-counter-09-b-expected.checksum:
              * platform/mac/css2.1/t1202-counter-09-b-expected.png:
              * platform/mac/css2.1/t1202-counter-09-b-expected.txt:
              * platform/mac/css2.1/t1202-counters-03-b-expected.checksum:
              * platform/mac/css2.1/t1202-counters-03-b-expected.png:
              * platform/mac/css2.1/t1202-counters-03-b-expected.txt:
              * platform/mac/css2.1/t1202-counters-04-b-expected.checksum:
              * platform/mac/css2.1/t1202-counters-04-b-expected.png:
              * platform/mac/css2.1/t1202-counters-04-b-expected.txt:
              * platform/mac/css2.1/t1202-counters-09-b-expected.checksum:
              * platform/mac/css2.1/t1202-counters-09-b-expected.png:
              * platform/mac/css2.1/t1202-counters-09-b-expected.txt:
              * platform/mac/editing/deleting/5144139-2-expected.checksum:
              * platform/mac/editing/deleting/5144139-2-expected.png:
              * platform/mac/editing/deleting/5144139-2-expected.txt:
              * platform/mac/editing/input/devanagari-ligature-expected.checksum:
              * platform/mac/editing/input/devanagari-ligature-expected.png:
              * platform/mac/editing/input/devanagari-ligature-expected.txt:
              * platform/mac/editing/pasteboard/copy-paste-bidi-expected.checksum:
              * platform/mac/editing/pasteboard/copy-paste-bidi-expected.png:
              * platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt:
              * platform/mac/editing/selection/caret-rtl-2-expected.checksum:
              * platform/mac/editing/selection/caret-rtl-2-expected.png:
              * platform/mac/editing/selection/caret-rtl-2-expected.txt:
              * platform/mac/editing/selection/caret-rtl-expected.checksum:
              * platform/mac/editing/selection/caret-rtl-expected.png:
              * platform/mac/editing/selection/caret-rtl-expected.txt:
              * platform/mac/editing/selection/extend-selection-bidi-expected.checksum:
              * platform/mac/editing/selection/extend-selection-bidi-expected.png:
              * platform/mac/fast/css/beforeSelectorOnCodeElement-expected.checksum:
              * platform/mac/fast/css/beforeSelectorOnCodeElement-expected.png:
              * platform/mac/fast/css/beforeSelectorOnCodeElement-expected.txt:
              * platform/mac/fast/css/rtl-ordering-expected.checksum:
              * platform/mac/fast/css/rtl-ordering-expected.png:
              * platform/mac/fast/css/rtl-ordering-expected.txt:
              * platform/mac/fast/css/text-overflow-ellipsis-expected.checksum:
              * platform/mac/fast/css/text-overflow-ellipsis-expected.png:
              * platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
              * platform/mac/fast/css/text-security-expected.checksum:
              * platform/mac/fast/css/text-security-expected.png:
              * platform/mac/fast/css/text-security-expected.txt:
              * platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum:
              * platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
              * platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
              * platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
              * platform/mac/fast/encoding/invalid-UTF-8-expected.png:
              * platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
              * platform/mac/fast/events/updateLayoutForHitTest-expected.checksum:
              * platform/mac/fast/events/updateLayoutForHitTest-expected.png:
              * platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
              * platform/mac/fast/forms/select-visual-hebrew-expected.checksum:
              * platform/mac/fast/forms/select-visual-hebrew-expected.png:
              * platform/mac/fast/forms/select-visual-hebrew-expected.txt:
              * platform/mac/fast/forms/select-writing-direction-natural-expected.checksum:
              * platform/mac/fast/forms/select-writing-direction-natural-expected.png:
              * platform/mac/fast/forms/select-writing-direction-natural-expected.txt:
              * platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum:
              * platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
              * platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
              * platform/mac/fast/lists/w3-list-styles-expected.checksum:
              * platform/mac/fast/lists/w3-list-styles-expected.png:
              * platform/mac/fast/lists/w3-list-styles-expected.txt:
              * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum:
              * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png:
              * platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
              * platform/mac/fast/text/capitalize-boundaries-expected.checksum:
              * platform/mac/fast/text/capitalize-boundaries-expected.png:
              * platform/mac/fast/text/capitalize-boundaries-expected.txt:
              * platform/mac/fast/text/cg-fallback-bolding-expected.checksum:
              * platform/mac/fast/text/cg-fallback-bolding-expected.png:
              * platform/mac/fast/text/cg-fallback-bolding-expected.txt:
              * platform/mac/fast/text/complex-text-opacity-expected.checksum:
              * platform/mac/fast/text/complex-text-opacity-expected.png:
              * platform/mac/fast/text/complex-text-opacity-expected.txt:
              * platform/mac/fast/text/in-rendered-text-rtl-expected.checksum:
              * platform/mac/fast/text/in-rendered-text-rtl-expected.png:
              * platform/mac/fast/text/in-rendered-text-rtl-expected.txt:
              * platform/mac/fast/text/international/001-expected.checksum:
              * platform/mac/fast/text/international/001-expected.png:
              * platform/mac/fast/text/international/001-expected.txt:
              * platform/mac/fast/text/international/002-expected.checksum:
              * platform/mac/fast/text/international/002-expected.png:
              * platform/mac/fast/text/international/002-expected.txt:
              * platform/mac/fast/text/international/003-expected.checksum:
              * platform/mac/fast/text/international/003-expected.png:
              * platform/mac/fast/text/international/003-expected.txt:
              * platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
              * platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
              * platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
              * platform/mac/fast/text/international/bidi-L2-run-reordering-expected.checksum:
              * platform/mac/fast/text/international/bidi-L2-run-reordering-expected.png:
              * platform/mac/fast/text/international/bidi-L2-run-reordering-expected.txt:
              * platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
              * platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
              * platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
              * platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
              * platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
              * platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
              * platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
              * platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
              * platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
              * platform/mac/fast/text/international/bidi-european-terminators-expected.checksum:
              * platform/mac/fast/text/international/bidi-european-terminators-expected.png:
              * platform/mac/fast/text/international/bidi-european-terminators-expected.txt:
              * platform/mac/fast/text/international/bidi-fallback-font-weight-expected.checksum:
              * platform/mac/fast/text/international/bidi-fallback-font-weight-expected.png:
              * platform/mac/fast/text/international/bidi-fallback-font-weight-expected.txt:
              * platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
              * platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
              * platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
              * platform/mac/fast/text/international/bidi-innertext-expected.checksum:
              * platform/mac/fast/text/international/bidi-innertext-expected.png:
              * platform/mac/fast/text/international/bidi-innertext-expected.txt:
              * platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
              * platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
              * platform/mac/fast/text/international/bidi-linebreak-001-expected.txt:
              * platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
              * platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
              * platform/mac/fast/text/international/bidi-linebreak-002-expected.txt:
              * platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
              * platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
              * platform/mac/fast/text/international/bidi-linebreak-003-expected.txt:
              * platform/mac/fast/text/international/bidi-listbox-atsui-expected.checksum:
              * platform/mac/fast/text/international/bidi-listbox-atsui-expected.png:
              * platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt:
              * platform/mac/fast/text/international/bidi-listbox-expected.checksum:
              * platform/mac/fast/text/international/bidi-listbox-expected.png:
              * platform/mac/fast/text/international/bidi-listbox-expected.txt:
              * platform/mac/fast/text/international/bidi-menulist-expected.checksum:
              * platform/mac/fast/text/international/bidi-menulist-expected.png:
              * platform/mac/fast/text/international/bidi-menulist-expected.txt:
              * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum:
              * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
              * platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
              * platform/mac/fast/text/international/bidi-override-expected.checksum:
              * platform/mac/fast/text/international/bidi-override-expected.png:
              * platform/mac/fast/text/international/bidi-override-expected.txt:
              * platform/mac/fast/text/international/hindi-spacing-expected.checksum:
              * platform/mac/fast/text/international/hindi-spacing-expected.png:
              * platform/mac/fast/text/international/hindi-spacing-expected.txt:
              * platform/mac/fast/text/international/rtl-caret-expected.checksum:
              * platform/mac/fast/text/international/rtl-caret-expected.png:
              * platform/mac/fast/text/international/rtl-caret-expected.txt:
              * platform/mac/fast/text/international/thai-line-breaks-expected.checksum:
              * platform/mac/fast/text/international/thai-line-breaks-expected.png:
              * platform/mac/fast/text/international/thai-line-breaks-expected.txt:
              * platform/mac/fast/text/international/wrap-CJK-001-expected.checksum:
              * platform/mac/fast/text/international/wrap-CJK-001-expected.png:
              * platform/mac/fast/text/international/wrap-CJK-001-expected.txt:
              * platform/mac/fast/text/wide-zero-width-space-expected.checksum:
              * platform/mac/fast/text/wide-zero-width-space-expected.png:
              * platform/mac/fast/text/wide-zero-width-space-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa6ce3d8
  16. 17 Mar, 2009 2 commits
    • eric@webkit.org's avatar
      2009-03-17 Ojan Vafai <ojan@chromium.org> · d2bb5a0a
      eric@webkit.org authored
              Reviewed by Adele Peterson.
      
              Put the padding inside scrollbars on textareas.
              https://bugs.webkit.org/show_bug.cgi?id=24370
      
              Put the padding inside the scrollbars on textareas. This is done by moving the
              overflow from the shadowNode to the RenderTextControlMultiline. As a result,
              all of the scroll handing methods that RenderTextControl overrides can be moved
              down into RenderTextControlSingleLine since RenderTextControlMultiline can now
              just use RenderBlock's versions. This also allows RenderTextControlMultiLine to
              no longer need a custom layout method since the shadowNode can now just size
              like a regular DIV.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::adjustRenderStyle):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::styleDidChange):
              (WebCore::RenderTextControl::selection):
              (WebCore::RenderTextControl::calcHeight):
              (WebCore::RenderTextControl::hitInnerTextElement):
              * rendering/RenderTextControl.h:
              * rendering/RenderTextControlMultiLine.cpp:
              (WebCore::RenderTextControlMultiLine::nodeAtPoint):
              (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
              * rendering/RenderTextControlMultiLine.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::styleDidChange):
              (WebCore::RenderTextControlSingleLine::autoscroll):
              (WebCore::RenderTextControlSingleLine::scrollWidth):
              (WebCore::RenderTextControlSingleLine::scrollHeight):
              (WebCore::RenderTextControlSingleLine::scrollLeft):
              (WebCore::RenderTextControlSingleLine::scrollTop):
              (WebCore::RenderTextControlSingleLine::setScrollLeft):
              (WebCore::RenderTextControlSingleLine::setScrollTop):
              (WebCore::RenderTextControlSingleLine::scroll):
              * rendering/RenderTextControlSingleLine.h:
              * rendering/TextControlInnerElements.cpp:
              (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock):
              (WebCore::RenderTextControlInnerBlock::positionForPoint):
              (WebCore::TextControlInnerTextElement::createRenderer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2bb5a0a
    • adele@apple.com's avatar
      WebCore: · 0677d680
      adele@apple.com authored
      2009-03-17  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=24655
              <rdar://problem/6633727> Hitting return at the end of a line with an anchor jumps me to the bottom of the message
      
              Test: editing/inserting/6633727.html
      
              This changes does a few things:
              1) Renames pos to insertionPosition.
              2) Eliminates "startNode".  It doesn't work well to consider the node separately from the insertionPosition.  
                 The insertionPosition gets updated at various times, and it seems likely that startNode can get out of sync.
              3) Before building up a list of ancestors to move around when we insert the new block, make sure to use the deepest
                 representation of the insertionPosition, so all ancestor nodes are correctly included.
      
              * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
      
      LayoutTests:
      
      2009-03-17  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Test for https://bugs.webkit.org/show_bug.cgi?id=24655
              <rdar://problem/6633727> Hitting return at the end of a line with an anchor jumps me to the bottom of the message
      
              * editing/inserting/6633727.html: Added.
              * platform/mac/editing/inserting/6633727-expected.checksum: Added.
              * platform/mac/editing/inserting/6633727-expected.png: Added.
              * platform/mac/editing/inserting/6633727-expected.txt: Added.
      
              Updated results.  The behavior for these tests doesn't change, but the render tree is slightly different.
      
              * platform/mac/editing/inserting/insert-div-021-expected.txt:
              * platform/mac/editing/style/block-styles-007-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0677d680
  17. 15 Mar, 2009 1 commit
  18. 13 Mar, 2009 1 commit
    • adele@apple.com's avatar
      WebCore: · c9f6c06e
      adele@apple.com authored
      2009-03-13  Adele Peterson  <adele@apple.com>
      
              Reviewed by Justin Garcia.
      
              Fix for <rdar://problem/5089327> Color of quoted content is wrong when pasted inside other quoted content
      
              Test: editing/pasteboard/5089327.html
      
              Handle spans being pasted within a quoted region in the same way we handle "paste as quotation" content.
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::handleStyleSpansBeforeInsertion):
              (WebCore::ReplaceSelectionCommand::handleStyleSpans):
      
      LayoutTests:
      
      2009-03-13  Adele Peterson  <adele@apple.com>
      
              Reviewed by Justin Garcia.
      
              Tests for <rdar://problem/5089327> Color of quoted content is wrong when pasted inside other quoted content
      
              * editing/pasteboard/5089327.html: Added.
              * platform/mac/editing/pasteboard/5089327-expected.checksum: Added.
              * platform/mac/editing/pasteboard/5089327-expected.png: Added.
              * platform/mac/editing/pasteboard/5089327-expected.txt: Added.
      
              Updated colors for pasted content.
      
              * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.checksum:
              * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
              * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.txt:
              * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.checksum:
              * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-expected.png:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9f6c06e
  19. 11 Mar, 2009 1 commit
    • mitz@apple.com's avatar
      JavaScriptCore: · b1706741
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - WTF support for fixing <rdar://problem/3919124> Thai text selection
                in Safari is incorrect
      
              * wtf/unicode/icu/UnicodeIcu.h:
              (WTF::Unicode::hasLineBreakingPropertyComplexContext): Added. Returns
              whether the character has Unicode line breaking property value SA
              ("Complex Context").
              * wtf/unicode/qt4/UnicodeQt4.h:
              (WTF::Unicode::hasLineBreakingPropertyComplexContext): Added an
              implementation that always returns false.
      
      WebCore:
      
              Reviewed by Darin Adler.
      
              - WebCore part of fixing <rdar://problem/3919124> Thai text selection
                in Safari is incorrect
      
              Test: platform/mac/editing/selection/word-thai.html
      
              Tested on Mac, but should work on all ICU platforms (or more precisely
              on all platforms that implement
              WTF::Unicode::hasLineBreakingPropertyComplexContext() correctly).
      
              * editing/TextIterator.cpp:
              (WebCore::BackwardsCharacterIterator::BackwardsCharacterIterator):
              Added.
              (WebCore::BackwardsCharacterIterator::range): Added.
              (WebCore::BackwardsCharacterIterator::advance): Added.
      
              * editing/TextIterator.h: Added BackwardsCharacterIterator with the
              minimal functionality required for this patch.
              (WebCore::BackwardsCharacterIterator::atEnd): Added.
      
              * editing/visible_units.cpp:
              (WebCore::firstNonComplexContextLineBreak): Added this helper function
              that returns the index of the first character in the string whose
              Unicode line breaking property value is not SA ("Complex Context"), or
              the length of the string if there is no such character.
              (WebCore::lastNonComplexContextLineBreak): Added this helper function
              that returns the index of the last character in the string whose
              Unicode line breaking property value is not SA ("Complex Context"), or
              -1 if there is no such character.
              (WebCore::previousBoundary): Changed the signature of the search
              function to include an offset parameter. Renamed the 'exception' local
              variable to 'ec' and changed its type to ExceptionCode. Extend the
              string forwards until the first character with Unicode line breaking
              property value other than SA. This gives the boundary search function
              enough context in the forward direction. Changed to use a
              BackwardsCharacterIterator for translating the backwards offset into
              a position.
              (WebCore::nextBoundary): Changed the signature of the search
              function to include an offset parameter. Extend the string backwards
              until the first character with Unicode line breaking property value
              other than SA. This gives the boundary search function enough context in
              the backwards direction. Restricted the workaround for <rdar://5192593>
              only to the line break case, because it was causing an extra character
              to be selected following a word that ended with a combining mark.
              (WebCore::startWordBoundary): Added an offset parameter. Check that
              going backwards from the given offset, there is a character with Unicode
              line breaking property value other than SA, and otherwise return 0 to
              request more context.
              (WebCore::endWordBoundary): Similar, but in reverse.
              (WebCore::previousWordPositionBoundary): Similar.
              (WebCore::nextWordPositionBoundary): Similar.
              (WebCore::startSentenceBoundary): Updated for the new search function
              signature.
              (WebCore::endSentenceBoundary): Ditto.
              (WebCore::previousSentencePositionBoundary): Ditto.
              (WebCore::nextSentencePositionBoundary): Ditto.
      
      LayoutTests:
      
              Reviewed by Darin Adler.
      
              - test for <rdar://problem/3919124> Thai text selection in Safari is
                incorrect
      
              * platform/mac/editing/selection/word-thai-expected.txt: Added.
              * platform/mac/editing/selection/word-thai.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1706741
  20. 10 Mar, 2009 1 commit
    • bdakin@apple.com's avatar
      WebCore: · 01af3029
      bdakin@apple.com authored
      2009-03-10  Beth Dakin  <bdakin@apple.com>
      
              Reviewed by Darin Adler.
      
              Fix for <rdar://problem/6624769> REGRESSION (Safari 4 PB): No 
              scroll bar appears for long line of text with NOWRAP set
      
              This is a regression from http://trac.webkit.org/changeset/32226
              I talked with Dan about the original change, and we decided that 
              the best fix was to remove his small potential-optimization that 
              only created a separate line box for whitespace under certain 
              circumstances. This new code will always create a separate line 
              box.
      
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::layoutInlineChildren):
      
      LayoutTests:
      
      2009-03-10  Beth Dakin  <bdakin@apple.com>
      
              Reviewed by Darin Adler.
      
              Test changes for <rdar://problem/6624769> REGRESSION (Safari 4 PB): 
              No scroll bar appears for long line of text with NOWRAP set
      
              New test:
              * fast/inline/long-wrapped-line.html: Added.
              * platform/mac/fast/inline/long-wrapped-line-expected.checksum: Added.
              * platform/mac/fast/inline/long-wrapped-line-expected.png: Added.
              * platform/mac/fast/inline/long-wrapped-line-expected.txt: Added.
      
              
              These tests all have changed results from the patch. Now trailing 
              whitespace always has its own linebox instead of sometimes sharing 
              a linebox with text.
              * platform/mac/editing/deleting/5206311-1-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-018-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-021-expected.txt:
              * platform/mac/editing/deleting/delete-block-merge-contents-022-expected.txt:
              * platform/mac/editing/deleting/delete-block-table-expected.txt:
              * platform/mac/editing/deleting/delete-leading-ws-001-expected.txt:
              * platform/mac/editing/deleting/delete-line-end-ws-001-expected.txt:
              * platform/mac/editing/deleting/delete-line-end-ws-002-expected.txt:
              * platform/mac/editing/deleting/delete-to-select-table-expected.txt:
              * platform/mac/editing/deleting/delete-ws-fixup-001-expected.txt:
              * platform/mac/editing/deleting/delete-ws-fixup-002-expected.txt:
              * platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
              * platform/mac/editing/deleting/forward-delete-expected.txt:
              * platform/mac/editing/execCommand/5482023-expected.txt:
              * platform/mac/editing/execCommand/boldSelection-expected.txt:
              * platform/mac/editing/execCommand/italicizeByCharacter-expected.txt:
              * platform/mac/editing/execCommand/modifyForeColorByCharacter-expected.txt:
              * platform/mac/editing/execCommand/print-expected.txt:
              * platform/mac/editing/execCommand/selectAll-expected.txt:
              * platform/mac/editing/execCommand/strikethroughSelection-expected.txt:
              * platform/mac/editing/input/emacs-ctrl-o-expected.txt:
              * platform/mac/editing/inserting/12882-expected.txt:
              * platform/mac/editing/inserting/editable-html-element-expected.txt:
              * platform/mac/editing/inserting/insert-div-019-expected.txt:
              * platform/mac/editing/inserting/insert-div-020-expected.txt:
              * platform/mac/editing/inserting/insert-div-021-expected.txt:
              * platform/mac/editing/inserting/insert-div-022-expected.txt:
              * platform/mac/editing/inserting/insert-div-023-expected.txt:
              * platform/mac/editing/inserting/insert-div-024-expected.txt:
              * platform/mac/editing/inserting/insert-div-025-expected.txt:
              * platform/mac/editing/inserting/insert-div-027-expected.txt:
              * platform/mac/editing/inserting/typing-003-expected.txt:
              * platform/mac/editing/pasteboard/4989774-expected.txt:
              * platform/mac/editing/pasteboard/5028447-expected.txt:
              * platform/mac/editing/pasteboard/merge-end-3-expected.txt:
              * platform/mac/editing/pasteboard/paste-table-003-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-012-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-013-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-014-expected.txt:
              * platform/mac/editing/selection/4947387-expected.txt:
              * platform/mac/editing/selection/4983858-expected.txt:
              * platform/mac/editing/selection/5081257-1-expected.txt:
              * platform/mac/editing/selection/5081257-2-expected.txt:
              * platform/mac/editing/selection/5136696-expected.txt:
              * platform/mac/editing/selection/5234383-1-expected.txt:
              * platform/mac/editing/selection/5234383-2-expected.txt:
              * platform/mac/editing/selection/7152-1-expected.txt:
              * platform/mac/editing/selection/7152-2-expected.txt:
              * platform/mac/editing/selection/after-line-wrap-expected.txt:
              * platform/mac/editing/selection/click-start-of-line-expected.txt:
              * platform/mac/editing/selection/drag-in-iframe-expected.txt:
              * platform/mac/editing/selection/editable-html-element-expected.txt:
              * platform/mac/editing/selection/editable-non-editable-crash-expected.txt:
              * platform/mac/editing/selection/end-of-document-expected.txt:
              * platform/mac/editing/selection/extend-by-character-003-expected.txt:
              * platform/mac/editing/selection/extend-by-character-005-expected.txt:
              * platform/mac/editing/selection/extend-by-word-002-expected.txt:
              * platform/mac/editing/selection/mixed-editability-1-expected.txt:
              * platform/mac/editing/selection/move-by-character-003-expected.txt:
              * platform/mac/editing/selection/move-by-character-005-expected.txt:
              * platform/mac/editing/selection/select-all-001-expected.txt:
              * platform/mac/editing/selection/select-all-002-expected.txt:
              * platform/mac/editing/selection/select-all-003-expected.txt:
              * platform/mac/editing/selection/wrapped-line-caret-1-expected.txt:
              * platform/mac/editing/selection/wrapped-line-caret-2-expected.txt:
              * platform/mac/editing/style/apple-style-editable-mix-expected.txt:
              * platform/mac/editing/style/create-block-for-style-001-expected.txt:
              * platform/mac/editing/style/create-block-for-style-002-expected.txt:
              * platform/mac/editing/style/create-block-for-style-003-expected.txt:
              * platform/mac/editing/style/create-block-for-style-004-expected.txt:
              * platform/mac/editing/style/create-block-for-style-005-expected.txt:
              * platform/mac/editing/style/create-block-for-style-006-expected.txt:
              * platform/mac/editing/style/create-block-for-style-007-expected.txt:
              * platform/mac/editing/style/create-block-for-style-008-expected.txt:
              * platform/mac/editing/style/create-block-for-style-009-expected.txt:
              * platform/mac/editing/style/create-block-for-style-010-expected.txt:
              * platform/mac/editing/style/create-block-for-style-011-expected.txt:
              * platform/mac/editing/style/create-block-for-style-012-expected.txt:
              * platform/mac/editing/style/create-block-for-style-013-expected.txt:
              * platform/mac/editing/style/relative-font-size-change-001-expected.txt:
              * platform/mac/editing/style/relative-font-size-change-002-expected.txt:
              * platform/mac/editing/style/relative-font-size-change-003-expected.txt:
              * platform/mac/editing/style/relative-font-size-change-004-expected.txt:
              * platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
              * platform/mac/editing/undo/undo-combined-delete-expected.txt:
              * platform/mac/editing/undo/undo-delete-boundary-expected.txt:
              * platform/mac/editing/undo/undo-delete-expected.txt:
              * platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
              * platform/mac/editing/undo/undo-forward-delete-expected.txt:
              * platform/mac/fast/block/float/editable-text-overlapping-float-expected.txt:
              * platform/mac/fast/clip/outline-overflowClip-expected.txt:
              * platform/mac/fast/forms/negativeLineHeight-expected.txt:
              * platform/mac/fast/forms/textAreaLineHeight-expected.txt:
              * platform/mac/fast/forms/textarea-rows-cols-expected.txt:
              * platform/mac/fast/lists/drag-into-marker-expected.txt:
              * platform/mac/fast/parser/comment-in-textarea-expected.txt:
              * platform/mac/fast/parser/entity-comment-in-textarea-expected.txt:
              * platform/mac/fast/parser/open-comment-in-textarea-expected.txt:
              * platform/mac/fast/repaint/inline-outline-repaint-expected.txt:
              * platform/mac/fast/repaint/selection-after-delete-expected.txt:
              * platform/mac/fast/repaint/selection-after-remove-expected.txt:
              * platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt:
              * platform/mac/fast/text/trailing-white-space-expected.txt:
              * platform/mac/fast/text/whitespace/pre-wrap-line-test-expected.txt:
              * platform/mac/fast/text/whitespace/pre-wrap-overflow-selection-expected.txt:
              * platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
              * platform/mac/fast/text/whitespace/tab-character-basics-expected.txt:
              * platform/mac/http/tests/navigation/anchor-goback-expected.txt:
              * platform/mac/http/tests/navigation/javascriptlink-goback-expected.txt:
              * platform/mac/http/tests/navigation/metaredirect-goback-expected.txt:
              * platform/mac/http/tests/navigation/post-goback2-expected.txt:
              * platform/mac/http/tests/navigation/postredirect-goback2-expected.txt:
              * platform/mac/http/tests/navigation/redirect302-goback-expected.txt:
              * platform/mac/http/tests/navigation/success200-goback-expected.txt:
              * platform/mac/http/tests/navigation/timerredirect-goback-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01af3029
  21. 05 Mar, 2009 2 commits
    • justin.garcia@apple.com's avatar
      When we replace a bit of selected text with a string of the same length, we... · 7a84935f
      justin.garcia@apple.com authored
      When we replace a bit of selected text with a string of the same length, we now send a selection change notification.  The selection endpoints aren't changing their positions in the DOM or their offsets in the document, but they're probably changing visually (unless the text is fixed width), so it seems right to send the notification.
      
      On the other hand, this happens during a setMarkedText call, which shouldn't even touch the selection.  But that's a different (and known) bug.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a84935f
    • justin.garcia@apple.com's avatar
      WebCore: · 0e8bd790
      justin.garcia@apple.com authored
      2009-03-05  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin Adler.
              
              WebViewDidChangeSelectionNotifications weren't being sent for commands that change the selection's position
              within the document without changing its position in the DOM.  For example, pressing return in (caret marked by ^):
              <div contentEditable="true"><div>^Hello</div></div>
              Undo was being enabled, shouldDeleteDOMRange called, etc. when doing no-op deletes (a delete in an empty document 
              for example). 
      
              Changes to layout tests demonstrate fix.
              
              * editing/EditCommand.cpp:
              (WebCore::EditCommand::apply): Don't call applyEditing for a TypingCommand.  The TypingCommand knows whether or
              not it did work that needs to be applied.
              * editing/Editor.cpp:
              (WebCore::Editor::appliedEditing): Moved code (but did not alter) to changeSelectionAfterCommand.
              (WebCore::Editor::unappliedEditing): Ditto.
              (WebCore::Editor::reappliedEditing): Ditto.
              (WebCore::Editor::changeSelectionAfterCommand): Moved code from *appliedEditing into here.  Also call out to
              EditorClient::respondToChangedSelection() for commands that changed the selection's position in the document
              even if they did not change it's position in the DOM.  Any TypingCommand that gets this far changed it's position
              in the document.
              * editing/Editor.h:
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::TypingCommand): Removed unused m_appliedEditing.
              (WebCore::TypingCommand::typingAddedToOpenCommand): Always apply editing.  We won't get this far if we don't need to.
              (WebCore::TypingCommand::deleteKeyPressed): Don't do any of the things that only make sense for Range selections, like
              adding to the killring and responding to a change in selections if the delete was a no-op.
              (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto.
              * editing/TypingCommand.h:
      
      LayoutTests:
      
      2009-03-05  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin Adler.
              
              WebViewDidChangeSelectionNotification isn't always called.
              Undo was enabled, shouldDeleteDOMRange was called, etc. for no-op backward and forward deletes.
      
              * platform/mac/editing/deleting/delete-4038408-fix-expected.txt:
              * platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
              * platform/mac/editing/deleting/delete-br-002-expected.txt:
              * platform/mac/editing/deleting/delete-br-004-expected.txt:
              * platform/mac/editing/deleting/delete-br-005-expected.txt:
              * platform/mac/editing/deleting/delete-br-006-expected.txt:
              * platform/mac/editing/deleting/delete-br-009-expected.txt:
              * platform/mac/editing/deleting/delete-br-010-expected.txt:
              * platform/mac/editing/deleting/delete-hr-expected.txt:
              * platform/mac/editing/deleting/delete-tab-004-expected.txt:
              * platform/mac/editing/deleting/forward-delete-expected.txt:
              * platform/mac/editing/deleting/merge-into-empty-block-1-expected.txt:
              * platform/mac/editing/deleting/merge-into-empty-block-2-expected.txt:
              * platform/mac/editing/inserting/editing-empty-divs-expected.txt:
              * platform/mac/editing/inserting/insert-3800346-fix-expected.txt:
              * platform/mac/editing/inserting/insert-br-004-expected.txt:
              * platform/mac/editing/inserting/insert-br-005-expected.txt:
              * platform/mac/editing/inserting/insert-br-006-expected.txt:
              * platform/mac/editing/inserting/insert-br-008-expected.txt:
              * platform/mac/editing/inserting/insert-div-006-expected.txt:
              * platform/mac/editing/inserting/insert-div-008-expected.txt:
              * platform/mac/editing/inserting/insert-div-010-expected.txt:
              * platform/mac/editing/inserting/insert-div-011-expected.txt:
              * platform/mac/editing/inserting/insert-div-013-expected.txt:
              * platform/mac/editing/inserting/insert-div-015-expected.txt:
              * platform/mac/editing/inserting/insert-div-019-expected.txt:
              * platform/mac/editing/inserting/insert-div-021-expected.txt:
              * platform/mac/editing/inserting/insert-paragraph-01-expected.txt:
              * platform/mac/editing/inserting/insert-paragraph-03-expected.txt:
              * platform/mac/editing/inserting/insert-paragraph-05-expected.txt:
              * platform/mac/editing/inserting/insert-tab-004-expected.txt:
              * platform/mac/editing/inserting/insert-text-with-newlines-expected.txt:
              * platform/mac/editing/inserting/line-break-expected.txt:
              * platform/mac/editing/pasteboard/3976872-expected.txt:
              * platform/mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
              * platform/mac/editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-010-expected.txt:
              * platform/mac/editing/style/block-style-006-expected.txt:
              * platform/mac/editing/undo/undo-combined-delete-boundary-expected.txt:
              * platform/mac/editing/undo/undo-combined-delete-expected.txt:
              * platform/mac/editing/undo/undo-forward-delete-boundary-expected.txt:
              * platform/mac/editing/undo/undo-forward-delete-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e8bd790
  22. 26 Feb, 2009 2 commits
    • adele@apple.com's avatar
      2009-02-26 Adele Peterson <adele@apple.com> · ce0487ad
      adele@apple.com authored
              Reviewed by Alice Liu.
      
              Make the success/failure of this test more obvious.
      
              * editing/selection/designmode-no-caret.html:
              * platform/mac/editing/selection/designmode-no-caret-expected.checksum:
              * platform/mac/editing/selection/designmode-no-caret-expected.png:
              * platform/mac/editing/selection/designmode-no-caret-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ce0487ad
    • adele@apple.com's avatar
      WebKit/mac: · 9f1b90c2
      adele@apple.com authored
      2009-02-26  Adele Peterson  <adele@apple.com>
      
              Reviewed by Geoff Garen.
      
              Fix for <rdar://problem/6618166>
              https://bugs.webkit.org/show_bug.cgi?id=24216
              (REGRESSION r36919) Safari 4 Beta causes MSN Messenger's text entry field to lose focus after entering a message
      
              During a series of firstResponder changes, at some point while the WebHTMLView was losing first responder status,
              we incorrectly marked the page as active, and then when the WebHTMLView became first responder again, setActive did nothing.
              This change restores behavior from before r36919 to check if the WebHTMLView is in the middle of losing first responder when calling setActive.
      
              In addition to updating editing/selection/designmode-no-caret.html results, I also made sure the test cases that were 
              fixed in r36919 and r38570 are still fixed.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView resignFirstResponder]): Keep track if we're in the process of resigning first responder.
              (-[WebHTMLView _isResigningFirstResponder]): Added.
              * WebView/WebHTMLViewInternal.h:
              * WebView/WebView.mm: (-[WebView _updateFocusedAndActiveStateForFrame:]): Don't set the page to be active
              if the document view is currently resigning first responder.
      
      LayoutTests:
      
      2009-02-26  Adele Peterson  <adele@apple.com>
      
              Reviewed by Geoff Garen.
      
              Updating results for <rdar://problem/6618166>
              https://bugs.webkit.org/show_bug.cgi?id=24216
              (REGRESSION r36919) Safari 4 Beta causes MSN Messenger's text entry field to lose focus after entering a message
      
              We changed these results shortly after r36919, but the original result is actually correct.
              The test's text indicates that we expect a caret to be placed in this case.
      
              * platform/mac/editing/selection/designmode-no-caret-expected.checksum:
              * platform/mac/editing/selection/designmode-no-caret-expected.png:
              * platform/mac/editing/selection/designmode-no-caret-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f1b90c2
  23. 24 Feb, 2009 1 commit
    • eric@webkit.org's avatar
      2009-02-05 Ojan Vafai <ojan@chromium.org> and Eric Seidel <eric@webkit.org> · 2da7e4aa
      eric@webkit.org authored
              Reviewed by Dave Hyatt.
      
              Make cursor positions match IE6/IE7/FF3 when clicking in margins/padding
              around divs inside editable regions.
              https://bugs.webkit.org/show_bug.cgi?id=23605
      
              Fix clicks outside editable regions from focusing the editable region.
              https://bugs.webkit.org/show_bug.cgi?id=23607
      
              Removed editing/selection/contenteditable-click-outside.html as it's
              not as useful as our new tests.
      
              Clean up RenderBlock::positionForCoordinates to remove dead code,
              duplicate code, and generally make it more readable.
      
              Tests: editing/selection/click-in-margins-inside-editable-div.html
                     editing/selection/click-in-padding-with-multiple-line-boxes.html
                     editing/selection/click-outside-editable-div.html
      
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::canonicalPosition):
              * rendering/RenderBlock.cpp:
              (WebCore::positionForPointRespectingEditingBoundaries):
              (WebCore::positionForPointWithInlineChildren):
              (WebCore::RenderBlock::positionForCoordinates):
              (WebCore::RenderBlock::updateFirstLetter):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2da7e4aa
  24. 16 Feb, 2009 2 commits
    • justin.garcia@apple.com's avatar
      WebCore: · 66fb4b04
      justin.garcia@apple.com authored
      2009-02-16  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Mark Rowe.
      
              https://bugs.webkit.org/show_bug.cgi?id=16309
              HTML5: The third execCommand argument for insert{un}orderedlist should be ignored
              
              When we originally implemented this command, MSDN documentation said that IE set the
              id attribute of inserted lists to the third argument to execCommand, but IE doesn't
              do this nor do any other browsers.
      
              * editing/EditorCommand.cpp:
              (WebCore::executeInsertOrderedList):
              (WebCore::executeInsertUnorderedList):
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::outdentParagraph):
              * editing/InsertListCommand.cpp:
              (WebCore::InsertListCommand::insertList):
              (WebCore::InsertListCommand::InsertListCommand):
              (WebCore::InsertListCommand::doApply):
              * editing/InsertListCommand.h:
              (WebCore::InsertListCommand::create):
      
      LayoutTests:
      
      2009-02-16  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Mark Rowe.
              
              https://bugs.webkit.org/show_bug.cgi?id=16309
              HTML5: The third execCommand argument for insert{un}orderedlist should be ignored
      
              * editing/execCommand/insert-list-with-id-expected.txt: Added.
              * editing/execCommand/insert-list-with-id.html:
              * platform/mac/editing/execCommand/insert-list-with-id-expected.checksum: Removed.
              * platform/mac/editing/execCommand/insert-list-with-id-expected.png: Removed.
              * platform/mac/editing/execCommand/insert-list-with-id-expected.txt: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66fb4b04
    • justin.garcia@apple.com's avatar
      WebCore: · e5d0a05b
      justin.garcia@apple.com authored
      2009-02-16  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=15381
              execCommand justify modifies the contentEditable node
      
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): Avoid modifying not just
              the body element, but any root editable element.
      
      LayoutTests:
      
      2009-02-16  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Eric Seidel.
              
              https://bugs.webkit.org/show_bug.cgi?id=15381
              execCommand justify modifies the contentEditable node
      
              * editing/execCommand/15381-expected.txt: Added.
              * editing/execCommand/15381.html: Added.
              
              Made this test cross platform and changed it to reflect the fix:
              * editing/execCommand/5062376-expected.txt: Added.
              * editing/execCommand/5062376.html:
              * platform/mac/editing/execCommand/5062376-expected.checksum: Removed.
              * platform/mac/editing/execCommand/5062376-expected.png: Removed.
              * platform/mac/editing/execCommand/5062376-expected.txt: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5d0a05b
  25. 13 Feb, 2009 1 commit