1. 05 May, 2009 2 commits
    • ap@webkit.org's avatar
      Reviewed by Dave Hyatt. · d0295906
      ap@webkit.org authored
              <rdar://problem/6576889> REGRESSION (r35185): Cannot watch Flash movies on omg.yahoo.com
      
              The problem was caused by missing <head> element - we used to create it when moving a
              misplaced <style> element, but we now handle those in place. Other browsers always create
              a <head> element.
      
              There is no guarantee that a <head> element always exists - first, it can be removed with
              removeChild or innerHTML, and also, we don't currently create it for frameset documents, or
              for manually created ones (e.g. ImageDocument).
      
              Test: fast/parser/head-element-for-yahoo-player.html
      
      WebKit:
              * dom/Document.cpp: (WebCore::Document::implicitClose): Create a <head> element for about:blank.
              A removed comment talked about rdar://3758785, but that problem doesn't re-occur even if this
              code is removed completely.
      
              * html/HTMLHtmlElement.cpp: (WebCore::HTMLHtmlElement::checkDTD): No longer allow <script>
              elements as children of <html>. This isn't directly related to this bug, but it was easier
              to fix both at once (IE and Firefox both don't allow such mispositioned <script> elements).
      
              * html/HTMLParser.cpp:
              (WebCore::HTMLParser::handleError): Move <script> to <head> if <body> hasn't been created yet.
              Create a <head> it a <body> is created implicitly to contain some other element.
              (WebCore::HTMLParser::bodyCreateErrorCheck): Ensure that a <head> exists when <body> is
              explicitly present in source.
              (WebCore::HTMLParser::createHead): Do the work even if <html> element hasn't been created yet.
      
      LayoutTests:
              * fast/parser/head-element-for-yahoo-player-expected.txt: Added.
              * fast/parser/head-element-for-yahoo-player.html: Added.
              Test the regression case (a misplaced <style> that used to create <head> implicitly).
      
              * editing/selection/select-all-005.html: Use a new index when selecting the body.
      
              * fast/dom/Document/document-write-doctype-expected.txt:
              * fast/dom/Document/resources/document-write-doctype.js:
              Removed checks for "Gecko quirk" of implicitly adding HEAD - that not a quirk, but standard
              behavior per HTML5.
      
              * editing/execCommand/create-list-1-expected.txt:
              * platform/mac/editing/deleting/4845371-expected.txt:
              * platform/mac/editing/deleting/4866671-expected.txt:
              * platform/mac/editing/deleting/4875189-expected.txt:
              * platform/mac/editing/deleting/5026848-1-expected.txt:
              * platform/mac/editing/deleting/5026848-2-expected.txt:
              * platform/mac/editing/deleting/5026848-3-expected.txt:
              * platform/mac/editing/deleting/5032066-expected.txt:
              * platform/mac/editing/deleting/5091898-expected.txt:
              * platform/mac/editing/deleting/5099303-expected.txt:
              * platform/mac/editing/deleting/5115601-expected.txt:
              * platform/mac/editing/deleting/5126166-expected.txt:
              * platform/mac/editing/deleting/5156801-2-expected.txt:
              * platform/mac/editing/deleting/5168598-expected.txt:
              * platform/mac/editing/deleting/5272440-expected.txt:
              * platform/mac/editing/deleting/5300379-expected.txt:
              * platform/mac/editing/deleting/5390681-expected.txt:
              * platform/mac/editing/deleting/5408255-expected.txt:
              * platform/mac/editing/deleting/5433862-2-expected.txt:
              * platform/mac/editing/deleting/5483370-expected.txt:
              * platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
              * platform/mac/editing/deleting/delete-block-table-expected.txt:
              * platform/mac/editing/deleting/delete-hr-expected.txt:
              * platform/mac/editing/deleting/delete-mixed-editable-content-001-expected.txt:
              * platform/mac/editing/deleting/delete-to-select-table-expected.txt:
              * platform/mac/editing/deleting/deletionUI-single-instance-expected.txt:
              * platform/mac/editing/deleting/merge-endOfParagraph-expected.txt:
              * platform/mac/editing/deleting/merge-no-br-expected.txt:
              * platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
              * platform/mac/editing/execCommand/4641880-1-expected.txt:
              * platform/mac/editing/execCommand/4641880-2-expected.txt:
              * platform/mac/editing/execCommand/4747450-expected.txt:
              * platform/mac/editing/execCommand/4786404-1-expected.txt:
              * platform/mac/editing/execCommand/4786404-2-expected.txt:
              * platform/mac/editing/execCommand/4916402-expected.txt:
              * platform/mac/editing/execCommand/4916541-expected.txt:
              * platform/mac/editing/execCommand/4916583-expected.txt:
              * platform/mac/editing/execCommand/4920488-expected.txt:
              * platform/mac/editing/execCommand/4920742-1-expected.txt:
              * platform/mac/editing/execCommand/4924441-expected.txt:
              * platform/mac/editing/execCommand/5049671-expected.txt:
              * platform/mac/editing/execCommand/5080333-1-expected.txt:
              * platform/mac/editing/execCommand/5080333-2-expected.txt:
              * platform/mac/editing/execCommand/5119244-expected.txt:
              * platform/mac/editing/execCommand/5120591-expected.txt:
              * platform/mac/editing/execCommand/5136770-expected.txt:
              * platform/mac/editing/execCommand/5142012-1-expected.txt:
              * platform/mac/editing/execCommand/5142012-2-expected.txt:
              * platform/mac/editing/execCommand/5142012-3-expected.txt:
              * platform/mac/editing/execCommand/5144139-1-expected.txt:
              * platform/mac/editing/execCommand/5164796-expected.txt:
              * platform/mac/editing/execCommand/5207369-expected.txt:
              * platform/mac/editing/execCommand/5210032-expected.txt:
              * platform/mac/editing/execCommand/5432254-1-expected.txt:
              * platform/mac/editing/execCommand/5432254-2-expected.txt:
              * platform/mac/editing/execCommand/5481523-expected.txt:
              * platform/mac/editing/execCommand/5482524-expected.txt:
              * platform/mac/editing/execCommand/5569741-expected.txt:
              * platform/mac/editing/execCommand/5573879-expected.txt:
              * platform/mac/editing/execCommand/5700414-1-expected.txt:
              * platform/mac/editing/execCommand/5700414-2-expected.txt:
              * platform/mac/editing/execCommand/insert-list-empty-div-expected.txt:
              * platform/mac/editing/input/5576619-expected.txt:
              * platform/mac/editing/inserting/12882-expected.txt:
              * platform/mac/editing/inserting/4840662-expected.txt:
              * platform/mac/editing/inserting/4875189-1-expected.txt:
              * platform/mac/editing/inserting/4875189-2-expected.txt:
              * platform/mac/editing/inserting/4959067-expected.txt:
              * platform/mac/editing/inserting/4960120-1-expected.txt:
              * platform/mac/editing/inserting/4960120-2-expected.txt:
              * platform/mac/editing/inserting/5002441-expected.txt:
              * platform/mac/editing/inserting/5058163-2-expected.txt:
              * platform/mac/editing/inserting/5156401-2-expected.txt:
              * platform/mac/editing/inserting/5549929-2-expected.txt:
              * platform/mac/editing/inserting/5549929-3-expected.txt:
              * platform/mac/editing/inserting/5607069-2-expected.txt:
              * platform/mac/editing/inserting/5607069-3-expected.txt:
              * platform/mac/editing/inserting/editable-html-element-expected.txt:
              * platform/mac/editing/inserting/editable-inline-element-expected.txt:
              * platform/mac/editing/inserting/edited-whitespace-1-expected.txt:
              * platform/mac/editing/inserting/editing-empty-divs-expected.txt:
              * platform/mac/editing/inserting/typing-tab-designmode-forms-expected.txt:
              * platform/mac/editing/pasteboard/4806874-expected.txt:
              * platform/mac/editing/pasteboard/4861080-expected.txt:
              * platform/mac/editing/pasteboard/4944770-1-expected.txt:
              * platform/mac/editing/pasteboard/4944770-2-expected.txt:
              * platform/mac/editing/pasteboard/4947130-expected.txt:
              * platform/mac/editing/pasteboard/4989774-expected.txt:
              * platform/mac/editing/pasteboard/5027857-expected.txt:
              * platform/mac/editing/pasteboard/5032095-expected.txt:
              * platform/mac/editing/pasteboard/5065605-expected.txt:
              * platform/mac/editing/pasteboard/5071074-2-expected.txt:
              * platform/mac/editing/pasteboard/5071074-expected.txt:
              * platform/mac/editing/pasteboard/5075944-2-expected.txt:
              * platform/mac/editing/pasteboard/5075944-3-expected.txt:
              * platform/mac/editing/pasteboard/5075944-expected.txt:
              * platform/mac/editing/pasteboard/5134759-expected.txt:
              * platform/mac/editing/pasteboard/5156401-1-expected.txt:
              * platform/mac/editing/pasteboard/5247341-expected.txt:
              * platform/mac/editing/pasteboard/5387578-expected.txt:
              * platform/mac/editing/pasteboard/5478250-expected.txt:
              * platform/mac/editing/pasteboard/5483567-expected.txt:
              * platform/mac/editing/pasteboard/5601583-1-expected.txt:
              * platform/mac/editing/pasteboard/copy-paste-bidi-expected.txt:
              * platform/mac/editing/pasteboard/input-field-1-expected.txt:
              * platform/mac/editing/pasteboard/merge-after-delete-1-expected.txt:
              * platform/mac/editing/pasteboard/merge-after-delete-2-expected.txt:
              * platform/mac/editing/pasteboard/merge-after-delete-expected.txt:
              * platform/mac/editing/pasteboard/merge-start-blockquote-expected.txt:
              * platform/mac/editing/pasteboard/paste-unrendered-select-expected.txt:
              * platform/mac/editing/pasteboard/prevent-block-nesting-01-expected.txt:
              * platform/mac/editing/pasteboard/select-element-1-expected.txt:
              * platform/mac/editing/selection/13804-expected.txt:
              * platform/mac/editing/selection/14971-expected.txt:
              * platform/mac/editing/selection/4397952-expected.txt:
              * platform/mac/editing/selection/4818145-expected.txt:
              * platform/mac/editing/selection/4866671-expected.txt:
              * platform/mac/editing/selection/4889598-expected.txt:
              * platform/mac/editing/selection/4895428-1-expected.txt:
              * platform/mac/editing/selection/4895428-2-expected.txt:
              * platform/mac/editing/selection/4895428-3-expected.txt:
              * platform/mac/editing/selection/4895428-4-expected.txt:
              * platform/mac/editing/selection/4932260-1-expected.txt:
              * platform/mac/editing/selection/4932260-2-expected.txt:
              * platform/mac/editing/selection/4932260-3-expected.txt:
              * platform/mac/editing/selection/4947387-expected.txt:
              * platform/mac/editing/selection/4960116-expected.txt:
              * platform/mac/editing/selection/4975120-expected.txt:
              * platform/mac/editing/selection/4983858-expected.txt:
              * platform/mac/editing/selection/5007143-2-expected.txt:
              * platform/mac/editing/selection/5007143-expected.txt:
              * platform/mac/editing/selection/5057506-2-expected.txt:
              * platform/mac/editing/selection/5057506-expected.txt:
              * platform/mac/editing/selection/5076323-1-expected.txt:
              * platform/mac/editing/selection/5076323-2-expected.txt:
              * platform/mac/editing/selection/5076323-3-expected.txt:
              * platform/mac/editing/selection/5081257-1-expected.txt:
              * platform/mac/editing/selection/5081257-2-expected.txt:
              * platform/mac/editing/selection/5099303-expected.txt:
              * platform/mac/editing/selection/5109817-expected.txt:
              * platform/mac/editing/selection/5136696-expected.txt:
              * platform/mac/editing/selection/5195166-1-expected.txt:
              * platform/mac/editing/selection/5195166-2-expected.txt:
              * platform/mac/editing/selection/5234383-1-expected.txt:
              * platform/mac/editing/selection/5234383-2-expected.txt:
              * platform/mac/editing/selection/5240265-expected.txt:
              * platform/mac/editing/selection/5333725-expected.txt:
              * platform/mac/editing/selection/5354455-1-expected.txt:
              * platform/mac/editing/selection/addRange-expected.txt:
              * platform/mac/editing/selection/caret-before-select-expected.txt:
              * platform/mac/editing/selection/contains-boundaries-expected.txt:
              * platform/mac/editing/selection/drag-select-1-expected.txt:
              * platform/mac/editing/selection/editable-html-element-expected.txt:
              * platform/mac/editing/selection/inconsistent-in-removeChildNode-expected.txt:
              * platform/mac/editing/selection/inline-closest-leaf-child-expected.txt:
              * platform/mac/editing/selection/mixed-editability-6-expected.txt:
              * platform/mac/editing/selection/mixed-editability-7-expected.txt:
              * platform/mac/editing/selection/move-by-sentence-linebreak-expected.txt:
              * platform/mac/editing/selection/select-all-005-expected.txt:
              * platform/mac/editing/selection/table-caret-1-expected.txt:
              * platform/mac/editing/selection/table-caret-2-expected.txt:
              * platform/mac/editing/selection/table-caret-3-expected.txt:
              * platform/mac/editing/selection/wrapped-line-caret-1-expected.txt:
              * platform/mac/editing/selection/wrapped-line-caret-2-expected.txt:
              * platform/mac/editing/style/4916887-expected.txt:
              * platform/mac/editing/style/5017613-1-expected.txt:
              * platform/mac/editing/style/5017613-2-expected.txt:
              * platform/mac/editing/style/5046875-1-expected.txt:
              * platform/mac/editing/style/5046875-2-expected.txt:
              * platform/mac/editing/style/5065910-expected.txt:
              * platform/mac/editing/style/5084241-expected.txt:
              * platform/mac/editing/style/5091898-expected.txt:
              * platform/mac/editing/style/5228141-expected.txt:
              * platform/mac/editing/style/5279521-expected.txt:
              * platform/mac/editing/style/font-family-with-space-expected.txt:
              * platform/mac/editing/style/fontsize-1-expected.txt:
              * platform/mac/editing/style/highlight-expected.txt:
              * platform/mac/editing/style/non-inheritable-styles-expected.txt:
              * platform/mac/editing/undo/5378473-expected.txt:
              * platform/mac/fast/block/float/relative-painted-twice-expected.txt:
              * platform/mac/fast/dom/delete-contents-expected.txt:
              * platform/mac/fast/events/context-no-deselect-expected.txt:
              * platform/mac/fast/events/label-focus-expected.txt:
              * platform/mac/fast/forms/input-appearance-focus-expected.txt:
              * platform/mac/fast/forms/input-text-click-inside-expected.txt:
              * platform/mac/fast/forms/input-text-click-outside-expected.txt:
              * platform/mac/fast/forms/input-text-double-click-expected.txt:
              * platform/mac/fast/forms/input-text-drag-down-expected.txt:
              * platform/mac/fast/forms/input-text-option-delete-expected.txt:
              * platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
              * platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
              * platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt:
              * platform/mac/fast/forms/textfield-overflow-expected.txt:
              * platform/mac/fast/inline/25277-2-expected.txt:
              * platform/mac/fast/inline/25277-expected.txt:
              * platform/mac/fast/lists/drag-into-marker-expected.txt:
              * platform/mac/fast/overflow/overflow-focus-ring-expected.txt:
              * platform/mac/fast/repaint/4776765-expected.txt:
              * platform/mac/fast/repaint/selection-after-delete-expected.txt:
              * platform/mac/fast/repaint/selection-after-remove-expected.txt:
              * platform/qt/editing/deleting/4845371-expected.txt:
              * platform/qt/editing/deleting/4866671-expected.txt:
              * platform/qt/editing/deleting/4875189-expected.txt:
              * platform/qt/editing/deleting/5026848-1-expected.txt:
              * platform/qt/editing/deleting/5026848-2-expected.txt:
              * platform/qt/editing/deleting/5026848-3-expected.txt:
              * platform/qt/editing/deleting/5032066-expected.txt:
              * platform/qt/editing/deleting/5091898-expected.txt:
              * platform/qt/editing/deleting/5099303-expected.txt:
              * platform/qt/editing/deleting/5115601-expected.txt:
              * platform/qt/editing/deleting/5126166-expected.txt:
              * platform/qt/editing/deleting/5144139-2-expected.txt:
              * platform/qt/editing/deleting/5156801-2-expected.txt:
              * platform/qt/editing/deleting/5168598-expected.txt:
              * platform/qt/editing/deleting/5272440-expected.txt:
              * platform/qt/editing/deleting/5300379-expected.txt:
              * platform/qt/editing/deleting/5390681-expected.txt:
              * platform/qt/editing/deleting/5408255-expected.txt:
              * platform/qt/editing/deleting/delete-at-start-or-end-expected.txt:
              * platform/qt/editing/deleting/delete-block-table-expected.txt:
              * platform/qt/editing/deleting/delete-hr-expected.txt:
              * platform/qt/editing/deleting/delete-link-1-expected.txt:
              * platform/qt/editing/deleting/delete-mixed-editable-content-001-expected.txt:
              * platform/qt/editing/deleting/delete-to-select-table-expected.txt:
              * platform/qt/editing/deleting/deletionUI-single-instance-expected.txt:
              * platform/qt/editing/deleting/merge-endOfParagraph-expected.txt:
              * platform/qt/editing/deleting/merge-no-br-expected.txt:
              * platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
              * platform/qt/editing/execCommand/4641880-1-expected.txt:
              * platform/qt/editing/execCommand/4641880-2-expected.txt:
              * platform/qt/editing/execCommand/4747450-expected.txt:
              * platform/qt/editing/execCommand/4786404-1-expected.txt:
              * platform/qt/editing/execCommand/4786404-2-expected.txt:
              * platform/qt/editing/execCommand/4916402-expected.txt:
              * platform/qt/editing/execCommand/4916541-expected.txt:
              * platform/qt/editing/execCommand/4916583-expected.txt:
              * platform/qt/editing/execCommand/4920488-expected.txt:
              * platform/qt/editing/execCommand/4920742-1-expected.txt:
              * platform/qt/editing/execCommand/4924441-expected.txt:
              * platform/qt/editing/execCommand/5049671-expected.txt:
              * platform/qt/editing/execCommand/5062376-expected.txt:
              * platform/qt/editing/execCommand/5080333-1-expected.txt:
              * platform/qt/editing/execCommand/5080333-2-expected.txt:
              * platform/qt/editing/execCommand/5119244-expected.txt:
              * platform/qt/editing/execCommand/5120591-expected.txt:
              * platform/qt/editing/execCommand/5136770-expected.txt:
              * platform/qt/editing/execCommand/5142012-1-expected.txt:
              * platform/qt/editing/execCommand/5142012-2-expected.txt:
              * platform/qt/editing/execCommand/5142012-3-expected.txt:
              * platform/qt/editing/execCommand/5144139-1-expected.txt:
              * platform/qt/editing/execCommand/5164796-expected.txt:
              * platform/qt/editing/execCommand/5207369-expected.txt:
              * platform/qt/editing/execCommand/5210032-expected.txt:
              * platform/qt/editing/execCommand/5432254-1-expected.txt:
              * platform/qt/editing/execCommand/5432254-2-expected.txt:
              * platform/qt/editing/execCommand/insert-list-empty-div-expected.txt:
              * platform/qt/editing/inserting/12882-expected.txt:
              * platform/qt/editing/inserting/4840662-expected.txt:
              * platform/qt/editing/inserting/4875189-1-expected.txt:
              * platform/qt/editing/inserting/4875189-2-expected.txt:
              * platform/qt/editing/inserting/4959067-expected.txt:
              * platform/qt/editing/inserting/4960120-1-expected.txt:
              * platform/qt/editing/inserting/4960120-2-expected.txt:
              * platform/qt/editing/inserting/5002441-expected.txt:
              * platform/qt/editing/inserting/5058163-2-expected.txt:
              * platform/qt/editing/inserting/5156401-2-expected.txt:
              * platform/qt/editing/inserting/editable-html-element-expected.txt:
              * platform/qt/editing/inserting/editable-inline-element-expected.txt:
              * platform/qt/editing/inserting/edited-whitespace-1-expected.txt:
              * platform/qt/editing/inserting/editing-empty-divs-expected.txt:
              * platform/qt/editing/inserting/insert-before-link-1-expected.txt:
              * platform/qt/editing/pasteboard/4806874-expected.txt:
              * platform/qt/editing/pasteboard/4840662-expected.txt:
              * platform/qt/editing/pasteboard/4944770-1-expected.txt:
              * platform/qt/editing/pasteboard/4989774-expected.txt:
              * platform/qt/editing/pasteboard/5027857-expected.txt:
              * platform/qt/editing/pasteboard/5032095-expected.txt:
              * platform/qt/editing/pasteboard/5065605-expected.txt:
              * platform/qt/editing/pasteboard/5071074-2-expected.txt:
              * platform/qt/editing/pasteboard/5071074-expected.txt:
              * platform/qt/editing/pasteboard/5075944-2-expected.txt:
              * platform/qt/editing/pasteboard/5075944-3-expected.txt:
              * platform/qt/editing/pasteboard/5075944-expected.txt:
              * platform/qt/editing/pasteboard/5134759-expected.txt:
              * platform/qt/editing/pasteboard/5156401-1-expected.txt:
              * platform/qt/editing/pasteboard/5245519-expected.txt:
              * platform/qt/editing/pasteboard/5247341-expected.txt:
              * platform/qt/editing/pasteboard/5387578-expected.txt:
              * platform/qt/editing/pasteboard/5478250-expected.txt:
              * platform/qt/editing/pasteboard/5483567-expected.txt:
              * platform/qt/editing/pasteboard/copy-paste-bidi-expected.txt:
              * platform/qt/editing/pasteboard/merge-after-delete-1-expected.txt:
              * platform/qt/editing/pasteboard/merge-after-delete-2-expected.txt:
              * platform/qt/editing/pasteboard/merge-after-delete-expected.txt:
              * platform/qt/editing/pasteboard/merge-start-blockquote-expected.txt:
              * platform/qt/editing/pasteboard/paste-unrendered-select-expected.txt:
              * platform/qt/editing/pasteboard/prevent-block-nesting-01-expected.txt:
              * platform/qt/editing/selection/13804-expected.txt:
              * platform/qt/editing/selection/4397952-expected.txt:
              * platform/qt/editing/selection/4818145-expected.txt:
              * platform/qt/editing/selection/4866671-expected.txt:
              * platform/qt/editing/selection/4889598-expected.txt:
              * platform/qt/editing/selection/4895428-2-expected.txt:
              * platform/qt/editing/selection/4895428-3-expected.txt:
              * platform/qt/editing/selection/4932260-1-expected.txt:
              * platform/qt/editing/selection/4932260-2-expected.txt:
              * platform/qt/editing/selection/4932260-3-expected.txt:
              * platform/qt/editing/selection/4960116-expected.txt:
              * platform/qt/editing/selection/4983858-expected.txt:
              * platform/qt/editing/selection/5007143-2-expected.txt:
              * platform/qt/editing/selection/5007143-expected.txt:
              * platform/qt/editing/selection/5076323-1-expected.txt:
              * platform/qt/editing/selection/5076323-2-expected.txt:
              * platform/qt/editing/selection/5076323-3-expected.txt:
              * platform/qt/editing/selection/5081257-1-expected.txt:
              * platform/qt/editing/selection/5081257-2-expected.txt:
              * platform/qt/editing/selection/5099303-expected.txt:
              * platform/qt/editing/selection/5136696-expected.txt:
              * platform/qt/editing/selection/5195166-1-expected.txt:
              * platform/qt/editing/selection/5195166-2-expected.txt:
              * platform/qt/editing/selection/5234383-1-expected.txt:
              * platform/qt/editing/selection/5234383-2-expected.txt:
              * platform/qt/editing/selection/5240265-expected.txt:
              * platform/qt/editing/selection/addRange-expected.txt:
              * platform/qt/editing/selection/caret-before-select-expected.txt:
              * platform/qt/editing/selection/editable-html-element-expected.txt:
              * platform/qt/editing/selection/mixed-editability-6-expected.txt:
              * platform/qt/editing/selection/mixed-editability-7-expected.txt:
              * platform/qt/editing/selection/move-by-sentence-linebreak-expected.txt:
              * platform/qt/editing/selection/select-all-005-expected.txt:
              * platform/qt/editing/selection/table-caret-1-expected.txt:
              * platform/qt/editing/selection/table-caret-2-expected.txt:
              * platform/qt/editing/selection/table-caret-3-expected.txt:
              * platform/qt/editing/style/4916887-expected.txt:
              * platform/qt/editing/style/5017613-1-expected.txt:
              * platform/qt/editing/style/5017613-2-expected.txt:
              * platform/qt/editing/style/5046875-1-expected.txt:
              * platform/qt/editing/style/5046875-2-expected.txt:
              * platform/qt/editing/style/5065910-expected.txt:
              * platform/qt/editing/style/5084241-expected.txt:
              * platform/qt/editing/style/5228141-expected.txt:
              * platform/qt/editing/style/5279521-expected.txt:
              * platform/qt/editing/style/font-family-with-space-expected.txt:
              * platform/qt/editing/style/fontsize-1-expected.txt:
              * platform/qt/editing/style/highlight-expected.txt:
              * platform/qt/editing/style/non-inheritable-styles-expected.txt:
              * platform/qt/editing/undo/5378473-expected.txt:
              * platform/qt/fast/dom/delete-contents-expected.txt:
              * platform/qt/fast/events/label-focus-expected.txt:
              * platform/qt/fast/forms/input-appearance-focus-expected.txt:
              * platform/qt/fast/forms/input-maxlength-2-expected.txt:
              * platform/qt/fast/forms/input-text-click-inside-expected.txt:
              * platform/qt/fast/forms/input-text-option-delete-expected.txt:
              * platform/qt/fast/forms/input-text-self-emptying-click-expected.txt:
              * platform/qt/fast/forms/textfield-drag-into-disabled-expected.txt:
              * platform/qt/fast/forms/textfield-overflow-expected.txt:
              * platform/qt/fast/overflow/overflow-focus-ring-expected.txt:
              * platform/qt/fast/repaint/4776765-expected.txt:
              * platform/qt/fast/repaint/selection-after-delete-expected.txt:
              * platform/qt/fast/repaint/selection-after-remove-expected.txt:
              * platform/win/editing/deleting/5168598-expected.txt:
              * platform/win/editing/inserting/4960120-1-expected.txt:
              * platform/win/editing/inserting/5607069-2-expected.txt:
              * platform/win/editing/inserting/5607069-3-expected.txt:
              * platform/win/editing/inserting/typing-tab-designmode-forms-expected.txt:
              * platform/win/editing/pasteboard/4806874-expected.txt:
              * platform/win/editing/selection/4895428-3-expected.txt:
              * platform/win/editing/selection/5136696-expected.txt:
              * platform/win/editing/selection/drag-select-1-expected.txt:
              * platform/win/fast/events/context-no-deselect-expected.txt:
              * platform/win/fast/events/label-focus-expected.txt:
              * platform/win/fast/forms/input-appearance-focus-expected.txt:
              * platform/win/fast/forms/input-text-click-inside-expected.txt:
              * platform/win/fast/forms/input-text-click-outside-expected.txt:
              * platform/win/fast/forms/input-text-double-click-expected.txt:
              * platform/win/fast/forms/input-text-drag-down-expected.txt:
              * platform/win/fast/forms/input-text-option-delete-expected.txt:
              * platform/win/fast/forms/input-text-scroll-left-on-blur-expected.txt:
              * platform/win/fast/forms/input-text-self-emptying-click-expected.txt:
              * platform/win/fast/forms/textfield-drag-into-disabled-expected.txt:
              * platform/win/fast/forms/textfield-overflow-expected.txt:
              Updated BODY element index in test output (for some tests, it increased because of the
              implicitly added <head>, and for others, it decreased because mispositoned <script> is being
              moved into <head>).
      
              * webarchive/adopt-attribute-styled-body-webarchive-expected.webarchive:
              * webarchive/archive-empty-frame-dom-expected.webarchive:
              Updated to include the implicitly added <head> elements.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0295906
    • eric@webkit.org's avatar
      Reviewed by Simon Fraser. · 491b1ff4
      eric@webkit.org authored
              Remove the vestigial calculateLocalTransform()
              https://bugs.webkit.org/show_bug.cgi?id=25532
      
              RenderSVGContainer is now the only render which needs this
              function, but it no longer returns the unused bool.
      
              calculateLocalTransform() previously was called by the DOM before
              transform updates were part of layout().
      
              * rendering/RenderForeignObject.cpp:
              (WebCore::RenderForeignObject::layout):
              * rendering/RenderForeignObject.h:
              (WebCore::RenderForeignObject::localTransform):
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::layout):
              * rendering/RenderPath.h:
              * rendering/RenderSVGContainer.cpp:
              * rendering/RenderSVGContainer.h:
              (WebCore::RenderSVGContainer::calculateLocalTransform):
              * rendering/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::layout):
              * rendering/RenderSVGImage.h:
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::layout):
              * rendering/RenderSVGText.h:
              * rendering/RenderSVGTransformableContainer.cpp:
              (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
              * rendering/RenderSVGTransformableContainer.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      491b1ff4
  2. 04 May, 2009 3 commits
    • eric@webkit.org's avatar
      Reviewed by George Staikos. · d404a6ef
      eric@webkit.org authored
              Remove broken absoluteTransform() code from RenderSVGInlineText
              https://bugs.webkit.org/show_bug.cgi?id=25532
      
              This improved SVG text focus rings.
              This also improved SVG.getScreenCTM() results.
      
              SVGSVGElement::getScreenCTM was passing "true" for the second argument in
              localToAbsolute, which is "fixed" it meant to pass "true" for the
              third argument (useTransforms).  That change alone caused no layout test changes, however
              before I fixed this, it was hitting ASSERT(!fixed) in RenderSVGRoot::mapLocalToContainer
      
              mapLocalToContainer implementations really should be shared,
              but I'll do that in a later patch.
      
              * rendering/RenderSVGInlineText.cpp:
              (WebCore::RenderSVGInlineText::styleDidChange):
              (WebCore::RenderSVGInlineText::absoluteQuads):
              (WebCore::RenderSVGInlineText::computeRepaintRectForRange):
              (WebCore::RenderSVGInlineText::computeRepaintQuadForRange):
              * rendering/RenderSVGInlineText.h:
              * rendering/RenderSVGRoot.cpp:
              (WebCore::RenderSVGRoot::mapLocalToContainer):
              * rendering/RenderSVGRoot.h:
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::mapLocalToContainer):
              * rendering/RenderSVGText.h:
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::getScreenCTM):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d404a6ef
    • eric@webkit.org's avatar
      Reviewed by George Staikos. · 3789d50c
      eric@webkit.org authored
              Simplify RenderForeignObject::paint and fix a repaint bug.
              Paint now calls applyTransformToPaintInfo which correctly transforms the damage rect.
              https://bugs.webkit.org/show_bug.cgi?id=16939
      
              * rendering/RenderForeignObject.cpp:
              (WebCore::RenderForeignObject::paint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3789d50c
    • eric@webkit.org's avatar
      2009-05-03 Hironori Bono <hbono@chromium.org> · 4383c398
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Test: editing/spelling/spellcheck-attribute.html
      
              Bug 14552: Add a way to disable spell checking for specific element
              https://bugs.webkit.org/show_bug.cgi?id=14552
      
              For compatibility with Firefox, this code ascends the DOM tree when an element does
              not have its "spellcheck" attribute.
      
              * editing/Editor.cpp:
              (WebCore::markMisspellingsOrBadGrammar): Retrieve the value of the "spellcheck"
              attribute of an element before calling a spell checker or a grammar checker.
              * html/HTMLAttributeNames.in: Add a "spellcheck" attribute.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43168 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4383c398
  3. 30 Apr, 2009 1 commit
  4. 29 Apr, 2009 3 commits
    • mitz@apple.com's avatar
      WebCore: · 3d9a5082
      mitz@apple.com authored
              Reviewed by Simon Fraser.
      
              - WebCore part of <rdar://problem/6609509> Select All and then Delete
                should put Mail editing back into the same state as a new message
      
              Test: editing/deleting/in-visibly-empty-root.html
      
              * WebCore.base.exp: Exported VisibleSelection::isAll(bool).
              * editing/SelectionController.h:
              (WebCore::SelectionController::isAll): Added. Calls through to
              VisibleSelection.
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::makeEditableRootEmpty): Added. Removes all children
              of the root editable element the selection is in, other than a
              placeholder. Returns true iff it did anything.
              (WebCore::TypingCommand::deleteKeyPressed): When there is only a single
              visible position in the root editable element, but it has children other
              than a placeholder, remove those children.
              * editing/TypingCommand.h:
              * editing/VisiblePosition.h:
              Added a StayInEditableContent enum and a FIXME.
              * editing/VisibleSelection.cpp:
              (WebCore::VisibleSelection::isAll): Added. Returns whether the
              selection encompasses all visible positions, either in the document or
              in the editable root.
              * editing/VisibleSelection.h:
      
      WebKit/mac:
      
              Reviewed by Simon Fraser.
      
              - WebKit part of <rdar://problem/6609509> Select All and then Delete
                should put Mail editing back into the same state as a new message
      
              * WebView/WebView.mm:
              (-[WebView _selectionIsCaret]): Added.
              (-[WebView _selectionIsAll]): Added. Returns whether the selection
              encompasses the entire document.
              * WebView/WebViewPrivate.h:
      
      LayoutTests:
      
              Reviewed by Simon Fraser.
      
              - test and updated results for <rdar://problem/6609509> Select All and
                then Delete should put Mail editing back into the same state as a new
                message
      
              * editing/deleting/in-visibly-empty-root-expected.txt: Added.
              * editing/deleting/in-visibly-empty-root.html: Added.
              * platform/mac/editing/deleting/delete-at-start-or-end-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d9a5082
    • eric@webkit.org's avatar
      Reviewed by Oliver Hunt. · 1fce1e2a
      eric@webkit.org authored
              Re-write image-clipped-hit.svg to be dumpAsText() (and clean up the code to be less insane)
      
              * platform/mac/svg/custom/image-clipped-hit-expected.checksum: Removed.
              * platform/mac/svg/custom/image-clipped-hit-expected.png: Removed.
              * platform/mac/svg/custom/image-clipped-hit-expected.txt: Removed.
              * platform/qt/svg/custom/image-clipped-hit-expected.txt: Removed.
              * svg/custom/image-clipped-hit.svg:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fce1e2a
    • ojan@chromium.org's avatar
      Reviewed by Dan Bernstein. · 149606a8
      ojan@chromium.org authored
              Make textarea and text input metrics more closely match IEs.
      
              This involves:
              -set text input width to size*avgCharWidth + maxCharWidth - avgCharWidth
              -set textarea width to cols*avgCharWidth
              -Make default CSS match IEs
              -Correctly initializing m_avgCharWidth and m_maxCharWidth for each platform and SVG.
      
              Those values for textarea and inputs were derived by doing a ton of manual
              testing of IE's width values for various textareas and fonts. On Windows we match
              IE exactly except for a couple fonts of the ~12 tested.
      
              To get the average and max character width of a font, we do the following
              for each platform:
              -Win: TextMetrics expose avgCharWidth and maxCharWidth
              -SVG: avgCharWidth = width of an '0', fallback on width of a space glyph, then m_xHeight
                  maxCharWidth = width of a 'W' for roman fonts, fallback on m_ascent
              -Linux: avgCharWidth = width of an '0', fallback on m_xHeight
                  maxCharWidth = max of avgCharWidth and m_ascent
              -Mac: Calculate the avgCharWidth and grab the maxCharWidth off the font.
                  If either one is non-positive, then calculate the value using the Linux approach.
      
              Tests: fast/forms/text-control-intrinsic-widths.html
                     fast/forms/textarea-metrics.html
                     svg/custom/svg-fonts-in-text-controls.html
      
              * css/html4.css:
              * css/themeWin.css:
              * platform/graphics/SimpleFontData.cpp:
              (WebCore::SimpleFontData::SimpleFontData):
              (WebCore::SimpleFontData::initCharWidths):
              * platform/graphics/SimpleFontData.h:
              (WebCore::SimpleFontData::maxCharWidth):
              (WebCore::SimpleFontData::avgCharWidth):
              * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/chromium/SimpleFontDataLinux.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/gtk/SimpleFontDataGtk.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/gtk/SimpleFontDataPango.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/mac/SimpleFontDataMac.mm:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/qt/SimpleFontDataQt.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataCGWin.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataCairoWin.cpp:
              (WebCore::SimpleFontData::platformInit):
              (WebCore::SimpleFontData::platformCharWidthInit):
              * platform/graphics/win/SimpleFontDataWin.cpp:
              (WebCore::SimpleFontData::initGDIFont):
              * platform/graphics/wx/SimpleFontDataWx.cpp:
              (WebCore::SimpleFontData::platformCharWidthInit):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::calcPrefWidths):
              * rendering/RenderTextControlMultiLine.cpp:
              (WebCore::RenderTextControlMultiLine::createInnerTextStyle):
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::preferredContentWidth):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      149606a8
  5. 28 Apr, 2009 8 commits
    • ddkilzer@apple.com's avatar
      2009-04-28 David Carson <dacarson@apple.com> · 6bdbd41d
      ddkilzer@apple.com authored
              Reviewed by David Hyatt.
      
              Restore alignment to device pixel boundaries.
              https://bugs.webkit.org/show_bug.cgi?id=25458
      
              Adjust the adjusted destination rect to be device pixel aligned.
      
              * platform/graphics/cg/ImageCG.cpp:
              (WebCore::BitmapImage::draw):
      
      2009-04-28  David Carson  <dacarson@apple.com>
      
              Reviewed by David Kilzer.
      
              Restore alignment to device pixel boundaries.
              https://bugs.webkit.org/show_bug.cgi?id=25458
      
              Updated test results with progressions.
      
              * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.checksum:
              * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.png:
              Yin-yang image shifted slightly to pixel boundaries.
      
              * platform/mac/svg/custom/focus-ring-expected.checksum:
              * platform/mac/svg/custom/focus-ring-expected.png:
              Focus rings drawn around rotated "focus text" and checkered
              images shifted slightly to pixel boundaries.
      
              * platform/mac/svg/custom/image-small-width-height-expected.checksum:
              * platform/mac/svg/custom/image-small-width-height-expected.png:
              Checkered images shifted slightly to pixel boundaries.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bdbd41d
    • ddkilzer@apple.com's avatar
      Added missing pixel test results. · f4ac8875
      ddkilzer@apple.com authored
              * platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.checksum: Added.
              * platform/mac/fast/css-generated-content/beforeAfter-interdocument-expected.png: Added.
              * platform/mac/fast/table/cell-coalescing-expected.checksum: Added.
              * platform/mac/fast/table/cell-coalescing-expected.png: Added.
              * platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.checksum: Added.
              * platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.png: Added.
              * platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.checksum: Added.
              * platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.png: Added.
              * platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.checksum: Added.
              * platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f4ac8875
    • adele@apple.com's avatar
      WebCore: · e2bc16bb
      adele@apple.com authored
      2009-04-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Fix for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
      
              Test: editing/deleting/type-delete-after-quote.html
      
              When a selection is deleted that contains a whole number paragraphs plus a line break, we refrain from merging paragraphs after the delete,
              since it is unclear to most users that such a selection actually ends at the start of the next paragraph.  However, when a user hits delete 
              with a caret selection, they actually do expect the start of that paragraph to be merged into the paragraph before it.  We can tell that 
              we're in this state because the TypingCommand creates the selection to delete but it doesn't change the endingSelection.  So we can tell
              that if we started with a caret selection, then we're not in this special case where we have to protect the user from unexpected behavior 
              from deleting a range they selected.
      
              * editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData):
      
      LayoutTests:
      
      2009-04-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Test for <rdar://problem/6617298> Typing delete on an unquoted blank line unquotes the preceding, quoted blank line
      
              * editing/deleting/type-delete-after-quote.html: Added.
              * platform/mac/editing/deleting/delete-4038408-fix-expected.txt: This expected result change reflects a change in how the editing is done, 
                but the document structure remains the same, and there are no visible changes to the result.
              * platform/mac/editing/deleting/type-delete-after-quote-expected.checksum: Added.
              * platform/mac/editing/deleting/type-delete-after-quote-expected.png: Added.
              * platform/mac/editing/deleting/type-delete-after-quote-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2bc16bb
    • eric@webkit.org's avatar
      Reviewed by Simon Fraser. · 7741322e
      eric@webkit.org authored
              Add text gradient test to cover
              https://bugs.webkit.org/show_bug.cgi?id=25403
      
              * platform/mac/svg/text/text-gradient-positioning-expected.checksum: Added.
              * platform/mac/svg/text/text-gradient-positioning-expected.png: Added.
              * platform/mac/svg/text/text-gradient-positioning-expected.txt: Added.
              * svg/text/text-gradient-positioning.svg: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7741322e
    • eric@webkit.org's avatar
      Reviewed by David Hyatt. · 4cba012a
      eric@webkit.org authored
              Add text repaint test to cover
              https://bugs.webkit.org/show_bug.cgi?id=16188
      
              * platform/mac/svg/text/text-repaint-rects-expected.checksum: Added.
              * platform/mac/svg/text/text-repaint-rects-expected.png: Added.
              * platform/mac/svg/text/text-repaint-rects-expected.txt: Added.
              * svg/text/text-repaint-rects.xhtml: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cba012a
    • eric@webkit.org's avatar
      Reviewed by Sam Weinig. · e4efafe1
      eric@webkit.org authored
              Fix foreignObject transform order
              https://bugs.webkit.org/show_bug.cgi?id=25433
      
              Transforms were being applied in the wrong order.
              When mapping from local to parent, first apply the viewport transform
              then map from the viewport box to the parent box.
      
              * rendering/RenderForeignObject.cpp:
              (WebCore::RenderForeignObject::localToParentTransform):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4efafe1
    • eric@webkit.org's avatar
      Reviewed by Simon Fraser. · 55e39b23
      eric@webkit.org authored
              Simplify how SVG containers paint
              https://bugs.webkit.org/show_bug.cgi?id=25431
      
              Moved filterBoundingBox() from RenderSVGModelObject to SVGRenderSupport to share with other classes.
              Gave RenderSVGText a modern clippedOverflowRectForRepaint and computeRectForRepaint.
              RenderSVGText now applies transforms at paint() time instead of during chunk draw time
              this should be much more efficient.
      
              Fixed the order in which RenderSVGViewportContainer applied
              transforms and clips.  We now clip to the viewport first and apply
              all transforms at once.  Also since the viewport logic is now only
              inside RenderSVGViewportContainer (instead of inside RenderSVGContainer)
              we always know we have a viewport.  We now use only viewportSize instead of
              viewport() since RenderSVGViewportContainers can't have x/y offsets.
      
              We now correctly transform the PaintInfo::rect (damage rect) when applying transforms.
              This allowed us to apply the transform during text paint() instead of at chunk paint
              time. Previously we had to apply the transform during chunk paint time because
              RenderBlock (superclass of RenderSVGBlock) would check intersection with the damageRect
              before telling any of the inlines to draw.  Now that we adjust the damage rect correctly
              we pass the intersection check correctly!  (This probably fixed some <text> redraw bugs
              but since I still have a bunch of those to fix, I've not tried to write additional tests
              to cover these potential fixes yet.)
      
              SVGRootInlineBox no longer needs to deal with transforms at chunk paint time, yay!
      
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::repaintRectInLocalCoordinates):
              (WebCore::RenderPath::paint):
              * rendering/RenderSVGContainer.cpp:
              (WebCore::RenderSVGContainer::paint):
              (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
              * rendering/RenderSVGContainer.h:
              (WebCore::RenderSVGContainer::applyViewportClip):
              * rendering/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::layout):
              (WebCore::RenderSVGImage::repaintRectInLocalCoordinates):
              (WebCore::RenderSVGImage::clippedOverflowRectForRepaint):
              (WebCore::RenderSVGImage::computeRectForRepaint):
              * rendering/RenderSVGImage.h:
              * rendering/RenderSVGModelObject.cpp:
              * rendering/RenderSVGModelObject.h:
              * rendering/RenderSVGRoot.cpp:
              (WebCore::RenderSVGRoot::layout):
              (WebCore::RenderSVGRoot::selfWillPaint):
              (WebCore::RenderSVGRoot::paint):
              (WebCore::RenderSVGRoot::viewportSize):
              (WebCore::RenderSVGRoot::calcViewport):
              (WebCore::RenderSVGRoot::localToBorderBoxTransform):
              (WebCore::RenderSVGRoot::parentOriginToBorderBox):
              (WebCore::RenderSVGRoot::borderOriginToContentBox):
              (WebCore::RenderSVGRoot::localToRepaintContainerTransform):
              (WebCore::RenderSVGRoot::localToParentTransform):
              (WebCore::RenderSVGRoot::computeRectForRepaint):
              (WebCore::RenderSVGRoot::nodeAtPoint):
              * rendering/RenderSVGRoot.h:
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::clippedOverflowRectForRepaint):
              (WebCore::RenderSVGText::computeRectForRepaint):
              (WebCore::RenderSVGText::paint):
              (WebCore::RenderSVGText::repaintRectInLocalCoordinates):
              * rendering/RenderSVGText.h:
              (WebCore::RenderSVGText::localToParentTransform):
              (WebCore::RenderSVGText::localTransform):
              * rendering/RenderSVGViewportContainer.cpp:
              (WebCore::RenderSVGViewportContainer::applyViewportClip):
              * rendering/RenderSVGViewportContainer.h:
              * rendering/SVGRenderSupport.cpp:
              (WebCore::filterBoundingBoxForRenderer):
              (WebCore::applyTransformToPaintInfo):
              * rendering/SVGRenderSupport.h:
              * rendering/SVGRootInlineBox.cpp:
              (WebCore::SVGRootInlineBoxPaintWalker::chunkStartCallback):
              (WebCore::SVGRootInlineBox::paint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55e39b23
    • cfleizach@apple.com's avatar
  6. 27 Apr, 2009 3 commits
  7. 25 Apr, 2009 2 commits
    • simon.fraser@apple.com's avatar
      2009-04-24 Simon Fraser <simon.fraser@apple.com> · d6af9987
      simon.fraser@apple.com authored
              Reviewed by Darin Adler
      
              https://bugs.webkit.org/show_bug.cgi?id=25390
      
              Fix point mapping and hit testing through transforms and perspective
              with ENABLE_3D_RENDERING. Previously the code did the more efficient
              move(), rather than getTransformFromContainer(), when the object had
              no transform. However, this skipped the application of perspective
              when the immediate child of the perspective element had no transform
              itself.
      
              Test: transforms/3d/point-mapping/3d-point-mapping-3.html
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::mapLocalToContainer):
              (WebCore::RenderBox::mapAbsoluteToLocalPoint):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::createLocalTransformState):
              Call shouldUseTransformFromContainer() to determine if we need to
              go through the more expensive getTransformFromContainer() code
              path.
      
              * rendering/RenderObject.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::shouldUseTransformFromContainer):
              New method that indicates whether we need use getTransformFromContainer()
              when mapping points through renderers, and hit testing.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6af9987
    • adele@apple.com's avatar
      WebCore: · 0f007fae
      adele@apple.com authored
      2009-04-25  Adele Peterson  <adele@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Fix for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
              https://bugs.webkit.org/show_bug.cgi?id=25396
      
              Test: editing/deleting/delete-br-013.html
      
              * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs):
               Only preserve an empty paragraph's style when moving paragraphs around if the selection is still 
               in an empty paragraph after the move occurs.  This was causing the empty paragraph's style to overwrite
               the previous paragraph's style during a delete of an empty paragraph.
      
      LayoutTests:
      
      2009-04-25  Adele Peterson  <adele@apple.com>
      
              Reviewed by Oliver Hunt.
      
              Test for <rdar://problem/6712771> REGRESSION(34681): Text is no longer underlined after delete
              https://bugs.webkit.org/show_bug.cgi?id=25396
      
              * editing/deleting/delete-br-013.html: Added.
              * platform/mac/editing/deleting/delete-br-013-expected.checksum: Added.
              * platform/mac/editing/deleting/delete-br-013-expected.png: Added.
              * platform/mac/editing/deleting/delete-br-013-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f007fae
  8. 24 Apr, 2009 10 commits
    • eric@webkit.org's avatar
      Reviewed by Simon Fraser. · 9259404a
      eric@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=25383
              Changing SVG size via JS does not update CSS width/height
      
              Add an ugly hack to fix CSS width/height updates from JS.
      
              We can't easily call setAttribute when width/height changes
              as that would cause infinite recursion (as we'd try to set
              the animation storage from the attributes)
      
              For now, when we get notification that JS changed width/height
              we copy what parseMappedAttribute does and update the CSS values as well.
      
              A better fix for this would be:
              https://bugs.webkit.org/show_bug.cgi?id=25383
      
              * svg/SVGSVGElement.cpp:
              (WebCore::updateCSSForAttribute):
              (WebCore::SVGSVGElement::svgAttributeChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9259404a
    • ggaren@apple.com's avatar
      2009-04-24 Geoffrey Garen <ggaren@apple.com> · d2f34334
      ggaren@apple.com authored
              Rubber stamped by Eric Seidel.
              
              Updated test to turn the buildbot green after Eric's last check-in.
      
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2f34334
    • eric@webkit.org's avatar
      Reviewed by Simon Fraser. · 1afc9f24
      eric@webkit.org authored
              Fix RenderSVGImage to dump with full bounds and style information.
              https://bugs.webkit.org/show_bug.cgi?id=25377
      
              No functional changes, we're just now including more info in render tree dumps.
      
              * rendering/RenderObject.h:
              (WebCore::RenderObject::isSVGImage):
              * rendering/RenderSVGImage.h:
              (WebCore::RenderSVGImage::isSVGImage):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::write):
              * rendering/SVGRenderTreeAsText.cpp:
              (WebCore::operator<<):
              (WebCore::write):
              * rendering/SVGRenderTreeAsText.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1afc9f24
    • simon.fraser@apple.com's avatar
      2009-04-24 Pierre d'Herbemont <pdherbemont@apple.com> · fa764cc2
      simon.fraser@apple.com authored
              Reviewed by Simon Fraser
      
              <rdar://problem/6805928> Re-export layout test MPEG-4 file to remove unusual edit
      
              Use better mp4 test file for media tests. The original mp4 file had an unusual
              edit (non-zero start time) which is not supported by all media engines. The new
              movie should also give more useful pixel test results.
      
              * media/content/test.mp4: Update the movie.
              * media/progress-event-total-expected.txt: Update test results to match movie duration and
              content changes.
              * media/progress-event-total.html: Ditto.
              * media/video-currentTime-set-expected.txt: Ditto.
              * media/video-loop-expected.txt: Ditto.
              * platform/mac/media/video-aspect-ratio-expected.checksum: Ditto.
              * platform/mac/media/video-aspect-ratio-expected.png: Ditto.
              * platform/mac/media/video-controls-rendering-expected.checksum: Ditto.
              * platform/mac/media/video-controls-rendering-expected.png: Ditto.
              * platform/mac/media/video-display-toggle-expected.checksum: Ditto.
              * platform/mac/media/video-display-toggle-expected.png: Ditto.
              * platform/mac/media/video-empty-source-expected.checksum: Ditto.
              * platform/mac/media/video-layer-crash-expected.checksum: Ditto.
              * platform/mac/media/video-layer-crash-expected.png: Ditto.
              * platform/mac/media/video-transformed-expected.checksum: Ditto.
              * platform/mac/media/video-transformed-expected.png: Ditto.
              * platform/mac/media/video-zoom-expected.checksum: Ditto.
              * platform/mac/media/video-zoom-expected.png: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa764cc2
    • kmccullough@apple.com's avatar
      2009-04-24 Kevin McCullough <kmccullough@apple.com> · 0cc0765f
      kmccullough@apple.com authored
              When I moved the files I forgot to update the location of the image!
      
              * platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Added.
              * platform/mac/editing/deleting/deletionUI-differing-background.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cc0765f
    • kmccullough@apple.com's avatar
      2009-04-24 Kevin McCullough <kmccullough@apple.com> · 82d4be76
      kmccullough@apple.com authored
              - Build fix.  Removed this test until I can figure out why it's failing.
      
              * platform/mac-leopard/editing/deleting/deletionUI-differing-background-expected.txt: Removed.
              * platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Removed.
              * platform/mac/editing/deleting/deletionUI-differing-background.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42832 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82d4be76
    • adele@apple.com's avatar
      2009-04-24 Adele Peterson <adele@apple.com> · 05e163df
      adele@apple.com authored
              Reviewed by Dan Bernstein.
      
              Updating these pixel results to the generated results on Leopard.
      
              * platform/mac/editing/inserting/5510537-expected.checksum:
              * platform/mac/editing/inserting/5510537-expected.png:
              * platform/mac/editing/inserting/6703873-expected.checksum:
              * platform/mac/editing/inserting/6703873-expected.png:
              * platform/mac/editing/selection/select-all-iframe-expected.checksum:
              * platform/mac/editing/selection/select-all-iframe-expected.png:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42822 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05e163df
    • adele@apple.com's avatar
      WebCore: · b90bbf34
      adele@apple.com authored
      2009-04-24  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Fix for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup
      
              Test: editing/pasteboard/paste-blockquote-after-blockquote.html
      
              When we have matching quote levels, its ok to merge the starts of the inserted and existing blocks more frequently.
              But we should only merge here if the selection start was inside a mail blockquote.  This prevents against removing a 
              blockquote from newly pasted quoted content that was pasted into an unquoted position.  If that unquoted position happens 
              to be right after another blockquote, we don't want to merge and risk stripping a valid block (and newline) from the pasted content.
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::shouldMergeStart): Also added an early return to always return false when we're already moving paragraphs.
              (WebCore::ReplaceSelectionCommand::doApply): Removed redundant check for when we're moving paragraphs.
              * editing/ReplaceSelectionCommand.h:
      
      LayoutTests:
      
      2009-04-24  Adele Peterson  <adele@apple.com>
      
              Reviewed by Darin Adler.
      
              Test for <rdar://problem/5089327> Newline gets stripped when pasting whole lines in certain markup
      
              * editing/pasteboard/paste-blockquote-after-blockquote.html: Added.
              * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.checksum: Added.
              * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.png: Added.
              * platform/mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b90bbf34
    • adele@apple.com's avatar
      2009-04-23 Adele Peterson <adele@apple.com> · cb3d86bb
      adele@apple.com authored
              Reviewed by Dan Bernstein.
      
              Updating test to make it easier to see the blockquote in the results.
      
              * editing/pasteboard/paste-blockquote-into-blockquote-3.html:
              * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.checksum:
              * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.png:
              * platform/mac/editing/pasteboard/paste-blockquote-into-blockquote-3-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb3d86bb
    • mrowe@apple.com's avatar
      Move deletionUI-helpers.js in to the correct location so that the · b7072c8f
      mrowe@apple.com authored
      tests that use it can find it.
      
      * platform/mac/editing/deleting/resources/deletionUI-helpers.js: Renamed from LayoutTests/editing/deleting/resources/deletionUI-helpers.js.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7072c8f
  9. 23 Apr, 2009 2 commits
    • kmccullough@apple.com's avatar
      2009-04-23 Kevin McCullough <kmccullough@apple.com> · f44c9f3d
      kmccullough@apple.com authored
              - Windows build fix.  Mac only tests go in platform/mac
      
              * editing/deleting/deletionUI-borders.html: Removed.
              * editing/deleting/deletionUI-differing-background.html: Removed.
              * editing/deleting/deletionUI-minimum-size.html: Removed.
              * platform/mac/editing/deleting/deletionUI-borders.html: Copied from editing/deleting/deletionUI-borders.html.
              * platform/mac/editing/deleting/deletionUI-differing-background.html: Copied from editing/deleting/deletionUI-differing-background.html.
              * platform/mac/editing/deleting/deletionUI-minimum-size.html: Copied from editing/deleting/deletionUI-minimum-size.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f44c9f3d
    • kmccullough@apple.com's avatar
      WebCore: · db684073
      kmccullough@apple.com authored
      2009-04-23  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Adam Roben.
      
              <rdar://problem/6808109> "Deletion UI" is not available for many
              portions of HTML content
      
              This patch makes the deletion UI show up in some new situations:
              1) If a block's background color is different from its parent's
              2) If a block has a background image.
              3) If a block has a single visible border.
              However the block must now not only be at least a minimum width and
              height, but also exceed a minimum area.  In practice this has led to
              much better element selection. 
      
              * editing/DeleteButtonController.cpp:
              (WebCore::isDeletableElement):
      
      LayoutTests:
      
      2009-04-23  Kevin McCullough  <kmccullough@apple.com>
      
              Reviewed by Adam Roben.
      
              <rdar://problem/6808109> "Deletion UI" is not available for many
              portions of HTML content
      
              This patch makes the deletion UI show up in some new situations:
              1) If a block's background color is different from its parent's
              2) If a block has a background image.
              3) If a block has a single visible border.
              However the block must now not only be at least a minimum width and
              height, but also exceed a minimum area.  In practice this has led to
              much better element selection.
      
              * editing/deleting/deletionUI-borders.html: Added.
              * editing/deleting/deletionUI-differing-background.html: Added.
              * editing/deleting/deletionUI-minimum-size.html: Added.
              * editing/deleting/resources: Added.
              * editing/deleting/resources/deletionUI-helpers.js: Added.
              (debug):
              (determineDeletionUIExistence):
              * platform/mac/editing/deleting/deletionUI-borders-expected.txt: Added.
              * platform/mac/editing/deleting/deletionUI-differing-background-expected.txt: Added.
              * platform/mac/editing/deleting/deletionUI-minimum-size-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db684073
  10. 22 Apr, 2009 2 commits
  11. 21 Apr, 2009 4 commits
    • weinig@apple.com's avatar
      WebCore: · 770cf313
      weinig@apple.com authored
      2009-04-21  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix for <rdar://problem/5874009>
              Add port 3659 (apple-sasl / PasswordServer) to the list of blocked ports.
      
              * platform/network/ResourceHandle.cpp:
              (WebCore::portAllowed):
      
      LayoutTests:
      
      2009-04-21  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Update test and results for <rdar://problem/5874009>
              Add port 3659 (apple-sasl / PasswordServer) to the list of blocked ports.
      
              * platform/mac-tiger/security/block-test-expected.txt:
              * platform/mac/security/block-test-expected.txt:
              * security/block-test.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42737 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      770cf313
    • darin@apple.com's avatar
      WebCore: · b0d40808
      darin@apple.com authored
      2009-04-21  Darin Adler  <darin@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Bug 25162: REGRESSION (r41176-r41242): Drag-selection above/below the line does not select to beginning/end
              https://bugs.webkit.org/show_bug.cgi?id=25162
              rdar://problem/6764354
      
              * page/Settings.cpp:
              (WebCore::Settings::Settings): Initialize editing behavior to Mac-style for PLATFORM(MAC).
              Later we may want to change this default to encompass other versions running on Mac.
      
              * page/Settings.h: Added EditingBehavior, setEditingBehavior, editingBehavior, and
              m_editingBehavior. Also moved m_maximumDecodedImageSize out of the middle of all
              the bit fields.
      
              * platform/graphics/IntPoint.h: Added a constructor to turn an IntSize into an IntPoint.
              I'm not sure the distinction here is serving us well at the moment. When converting from
              global to local coordinates you want to do IntPoint - IntPoint and have the result be
              another IntPoint, not an IntSize. And so on.
      
              * rendering/RenderBlock.cpp:
              (WebCore::positionForPointRespectingEditingBoundaries): Changed to use pointers more and
              separate coordinates less.
              (WebCore::RenderBlock::positionForPointWithInlineChildren): Turned into a member function.
              Added separate cases to support the Mac and Windows behavior.
              (WebCore::RenderBlock::positionForPoint): Updated for the change above. Also moved the
              computation of pointInContents closer to the place it's used.
      
              * rendering/RenderBlock.h: Updated for the new private member function.
      
      LayoutTests:
      
      2009-04-21  Darin Adler  <darin@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Bug 25162: REGRESSION (r41176-r41242): Drag-selection above/below the line does not select to beginning/end
              https://bugs.webkit.org/show_bug.cgi?id=25162
              rdar://problem/6764354
      
              * editing/selection/resources/click-in-margins-inside-editable-div.js:
              Updated to expect different results on the Mac.
              * editing/selection/resources/click-in-padding-with-multiple-line-boxes.js: Ditto.
      
              * fast/css-generated-content/positioned-background-hit-test-crash.html: Clear the selection at
              the end of the test so the result won't include a caret.
      
              * platform/mac/editing/selection/click-in-margins-inside-editable-div-expected.txt:
              * platform/mac/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
              Copied from LayoutTests/editing/selection. Then changed to expect the different Mac results.
      
              * platform/mac/editing/selection/select-from-textfield-outwards-expected.checksum:
              * platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
              * platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
              Changed to expect the different Mac results.
      
              * platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.txt:
              Changed to expect no caret.
      
              * platform/win/editing/selection/click-in-margins-inside-editable-div-expected.txt:
              * platform/win/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
              Copied from editing/selection.
      
              * platform/win/editing/selection/select-from-textfield-outwards-expected.checksum:
              * platform/win/editing/selection/select-from-textfield-outwards-expected.png:
              * platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
              Copied from platform/mac/editing/selection.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0d40808
    • darin@apple.com's avatar
      2009-04-21 Darin Adler <darin@apple.com> · 58322639
      darin@apple.com authored
              Reviewed by Adele Peterson.
      
              Fix some tests that are depending on Mac vs. Windows selection quirks accidentally.
              Added failing tests to the skipped list for SnowLeopard.
      
              * editing/resources/select-all-iframe-src.html: Moved.
              * editing/selection/resources/select-all-iframe-src.html: Moved from
              editing/resources/select-all-iframe-src.html, since this is used by a test in the
              selection directory. Changed mouse coordinates to be farther to the right so we
              don't depend on the rule for what's selected when you click below text on the last line.
              * editing/selection/select-all-iframe.html: Updated for new location of file above.
      
              * fast/events/standalone-image-drag-to-editable.html: Changed mouse coordinates to be
              farther to the right so we don't depend on the rule for what's selected when you click
              below text on the last line.
      
              * platform/mac-snowleopard/Skipped: Added some tests to the Skipped list.
      
              * svg/custom/pointer-events-path.svg: Clear the selection at the end of the test so it's
              not in the test results. Also removed unneeded use of the layout test controller.
      
              * platform/mac/editing/selection/select-all-iframe-expected.checksum: Generated new results.
              * platform/mac/editing/selection/select-all-iframe-expected.png: Ditto.
              * platform/mac/editing/selection/select-all-iframe-expected.txt: Ditto.
              * platform/mac/fast/events/standalone-image-drag-to-editable-expected.checksum: Ditto.
              * platform/mac/fast/events/standalone-image-drag-to-editable-expected.png: Ditto.
              * platform/mac/fast/events/standalone-image-drag-to-editable-expected.txt: Ditto.
              * platform/mac/svg/custom/pointer-events-path-expected.checksum: Ditto.
              * platform/mac/svg/custom/pointer-events-path-expected.png: Ditto.
              * platform/mac/svg/custom/pointer-events-path-expected.txt: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58322639
    • justin.garcia@apple.com's avatar
      WebCore: · 08d8dad8
      justin.garcia@apple.com authored
      2009-04-21  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=19644
              Text copied with Select All pastes with a indent but shouldn't
              <rdar://problem/6102483> 
              Pasting the content of an HTML message in Mail causes addition nested <div> elements to be added
              
              To improve selectall/copy/paste fidelity of certain pages, we began wrapping copied content with
              a div that held properties and attributes from the fully selected body.  To fix the above issues, 
              only do this if if the body has certain properties or attributes.  We'll begin adding to this list as 
              necessary.  For now it's just background colors and images.  Tested copy/paste of nytimes, wired,
              arstechnica, and several others.
              
              Massive nesting can still happen, it will just be much less common.
      
              * editing/markup.cpp:
              (WebCore::createMarkup): 
      
      LayoutTests:
      
      2009-04-21  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=19644
              Text copied with Select All pastes with a indent but shouldn't
              <rdar://problem/6102483> 
              Pasting the content of an HTML message in Mail causes addition nested <div> elements to be added
      
              * editing/pasteboard/19644-1-expected.txt: Added.
              * editing/pasteboard/19644-1.html: Added.
              * editing/pasteboard/19644-2-expected.txt: Added.
              * editing/pasteboard/19644-2.html: Added.
              * platform/mac/editing/inserting/insert-3907422-fix-expected.txt:
              * platform/mac/editing/pasteboard/paste-text-015-expected.checksum:
              * platform/mac/editing/pasteboard/paste-text-015-expected.png:
              * platform/mac/editing/pasteboard/paste-text-015-expected.txt:
              * platform/mac/editing/style/font-family-with-space-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08d8dad8