1. 11 Feb, 2011 28 commits
    • jberlin@webkit.org's avatar
      Add Windows XP specific results for fast/dom/52776.html to get the bot green. Unreviewed. · d0174970
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=52776
      
      * platform/win-xp/fast/dom: Added.
      * platform/win-xp/fast/dom/52776-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0174970
    • commit-queue@webkit.org's avatar
      2011-02-11 Andrey Adaikin <aandrey@google.com> · 08ba0bd3
      commit-queue@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [REGRESSION] click on error message in console doesn't scroll into view
              https://bugs.webkit.org/show_bug.cgi?id=54089
      
              * inspector/front-end/Drawer.js:
              (WebInspector.Drawer.prototype.show.animationFinished):
              (WebInspector.Drawer.prototype.show):
              (WebInspector.Drawer.prototype.hide):
              (WebInspector.Drawer.prototype.resize):
              (WebInspector.Drawer.prototype.immediatelyFinishAnimation):
              (WebInspector.Drawer.prototype._cancelAnimationIfNeeded):
              (WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
              (WebInspector.Drawer.prototype._animateDrawerHeight):
              (WebInspector.Drawer.prototype._statusBarDragging):
              * inspector/front-end/inspector.js:
              (WebInspector.animateStyle):
              (WebInspector.animateStyle.forceComplete):
              (WebInspector.animateStyle.cancel):
              (WebInspector.showSourceLine):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08ba0bd3
    • japhet@chromium.org's avatar
      2011-02-10 Nate Chapin <japhet@chromium.org> · af889b91
      japhet@chromium.org authored
              Reviewed by Adam Barth.
      
              Make DocumentWriter a member of DocumentLoader
              instead of FrameLoader.
              https://bugs.webkit.org/show_bug.cgi?id=50489
      
              Refactor, no new tests.
      
              * bindings/ScriptControllerBase.cpp:
              (WebCore::ScriptController::executeIfJavaScriptURL):
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::explicitClose):
              (WebCore::Document::lastModified):
              (WebCore::Document::initSecurityContext):
              (WebCore::Document::updateURLForPushOrReplaceState):
              * dom/Document.h:
              (WebCore::Document::setDocumentLoader):
              (WebCore::Document::loader):
              * html/MediaDocument.cpp:
              (WebCore::MediaDocument::replaceMediaElementTimerFired):
              * html/PluginDocument.cpp:
              (WebCore::PluginDocumentParser::createDocumentStructure):
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::DocumentLoader):
              (WebCore::DocumentLoader::finishedLoading):
              (WebCore::DocumentLoader::commitData):
              (WebCore::DocumentLoader::setupForReplaceByMIMEType):
              (WebCore::DocumentLoader::setFrame):
              * loader/DocumentLoader.h:
              (WebCore::DocumentLoader::writer):
              * loader/DocumentWriter.cpp:
              (WebCore::DocumentWriter::begin):
              * loader/DocumentWriter.h:
              (WebCore::DocumentWriter::setFrame):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::FrameLoader):
              (WebCore::FrameLoader::init):
              (WebCore::FrameLoader::clear):
              (WebCore::FrameLoader::receivedFirstData):
              (WebCore::FrameLoader::transitionToCommitted):
              (WebCore::FrameLoader::open):
              (WebCore::FrameLoader::finishedLoadingDocument):
              (WebCore::FrameLoader::addExtraFieldsToRequest):
              * loader/FrameLoader.h:
              (WebCore::FrameLoader::notifier):
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::dataChanged):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af889b91
    • sergio@webkit.org's avatar
      2011-02-11 Sergio Villar Senin <svillar@igalia.com> · 4628603f
      sergio@webkit.org authored
              Unreviewed.
      
              Added two tests to the skipped file that started to fail only in
              64-bit debug bot. Rounding issues are most likely the source of
              differences between 32 and 64bit bots.
      
              * platform/gtk/Skipped: added
              svg/W3C-SVG-1.1-SE/types-dom-02-f.svg and
              svg/W3C-SVG-1.1-SE/types-dom-05-b.svg
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4628603f
    • ager@chromium.org's avatar
      2011-02-11 Mads Ager <ager@chromium.org> · 1557a03f
      ager@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Remove unnecessary chromium layout test rebaselines
              https://bugs.webkit.org/show_bug.cgi?id=54278
      
              * platform/chromium/fast/js/ToNumber-expected.txt: Removed.
              * platform/chromium/fast/js/parseFloat-expected.txt: Removed.
              * platform/chromium/fast/js/regexp-look-ahead-empty-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1557a03f
    • pfeldman@chromium.org's avatar
      2011-02-11 Pavel Feldman <pfeldman@chromium.org> · 1f855b54
      pfeldman@chromium.org authored
              Not reviewed: unflake inspector test (2).
      
              * inspector/command-line-api.html:
              * inspector/elements-tests2.js:
              (initialize_ElementTest.InspectorTest.selectElementAndRun):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f855b54
    • pfeldman@chromium.org's avatar
      2011-02-11 Pavel Feldman <pfeldman@chromium.org> · d71c2d0a
      pfeldman@chromium.org authored
              Not reviewed: unflake inspector test.
      
              * inspector/command-line-api-expected.txt:
              * inspector/command-line-api.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d71c2d0a
    • jberlin@webkit.org's avatar
      [Windows 7 Release Tests] fast/dom/Window/window-property-descriptors.html, · c1f94735
      jberlin@webkit.org authored
      fast/js/global-function-resolve.html,
      fast/js/var-declarations-shadowing.html,
      and security/crypto-random-values.html failing since r78321.
      https://bugs.webkit.org/show_bug.cgi?id=54285
      
      Unreviewed, landing expected failing results to get the bots green.
      
      * platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
      * platform/win/fast/js/global-function-resolve-expected.txt: Added.
      * platform/win/fast/js/var-declarations-shadowing-expected.txt: Added.
      * platform/win/security: Added.
      * platform/win/security/crypto-random-values-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1f94735
    • pfeldman@chromium.org's avatar
      2011-02-10 Pavel Feldman <pfeldman@chromium.org> · 840f348a
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: make InspectorAgent own sub-agents, align agent creation/deletion routines.
              https://bugs.webkit.org/show_bug.cgi?id=54227
      
              * dom/Document.cpp:
              (WebCore::Document::finishedParsing):
              * inspector/InspectorAgent.cpp:
              (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
              (WebCore::InspectorAgent::setFrontend):
              (WebCore::InspectorAgent::disconnectFrontend):
              (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
              (WebCore::InspectorAgent::didCommitLoad):
              (WebCore::InspectorAgent::domContentLoadedEventFired):
              (WebCore::InspectorAgent::loadEventFired):
              (WebCore::InspectorAgent::startTimelineProfiler):
              (WebCore::InspectorAgent::stopTimelineProfiler):
              * inspector/InspectorAgent.h:
              * inspector/InspectorCSSAgent.cpp:
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::InspectorDOMAgent):
              (WebCore::InspectorDOMAgent::startListening):
              (WebCore::InspectorDOMAgent::stopListening):
              (WebCore::InspectorDOMAgent::mainDOMContentLoaded):
              (WebCore::InspectorDOMAgent::loadEventFired):
              * inspector/InspectorDOMAgent.h:
              (WebCore::InspectorDOMAgent::create):
              * inspector/InspectorDOMStorageAgent.cpp:
              (WebCore::InspectorDOMStorageAgent::~InspectorDOMStorageAgent):
              * inspector/InspectorDOMStorageAgent.h:
              (WebCore::InspectorDOMStorageAgent::create):
              * inspector/InspectorDOMStorageResource.h:
              * inspector/InspectorDatabaseAgent.cpp:
              (WebCore::InspectorDatabaseAgent::~InspectorDatabaseAgent):
              (WebCore::InspectorDatabaseAgent::executeSQL):
              (WebCore::InspectorDatabaseAgent::selectDatabase):
              (WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
              * inspector/InspectorDatabaseAgent.h:
              (WebCore::InspectorDatabaseAgent::FrontendProvider::create):
              (WebCore::InspectorDatabaseAgent::FrontendProvider::~FrontendProvider):
              (WebCore::InspectorDatabaseAgent::FrontendProvider::frontend):
              (WebCore::InspectorDatabaseAgent::FrontendProvider::clearFrontend):
              (WebCore::InspectorDatabaseAgent::FrontendProvider::FrontendProvider):
              (WebCore::InspectorDatabaseAgent::create):
              * inspector/InspectorDatabaseResource.cpp:
              (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
              (WebCore::InspectorDatabaseResource::bind):
              * inspector/InspectorDatabaseResource.h:
              * inspector/InspectorInstrumentation.cpp:
              (WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
              (WebCore::InspectorInstrumentation::loadEventFiredImpl):
              * inspector/InspectorInstrumentation.h:
              (WebCore::InspectorInstrumentation::domContentLoadedEventFired):
              (WebCore::InspectorInstrumentation::loadEventFired):
              * inspector/InspectorState.cpp:
              (WebCore::InspectorState::InspectorState):
              (WebCore::InspectorState::mute):
              (WebCore::InspectorState::updateCookie):
              * inspector/InspectorState.h:
              (WebCore::InspectorState::~InspectorState):
              * inspector/InspectorTimelineAgent.cpp:
              (WebCore::InspectorTimelineAgent::restore):
              (WebCore::InspectorTimelineAgent::~InspectorTimelineAgent):
              (WebCore::InspectorTimelineAgent::didCommitLoad):
              (WebCore::InspectorTimelineAgent::setFrontend):
              (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
              * inspector/InspectorTimelineAgent.h:
              (WebCore::InspectorTimelineAgent::create):
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::dispatchLoadEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      840f348a
    • pfeldman@chromium.org's avatar
      2011-02-11 Pavel Feldman <pfeldman@chromium.org> · 6d06460f
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: command line API $0 regressed.
              https://bugs.webkit.org/show_bug.cgi?id=54283
      
              * inspector/command-line-api-expected.txt:
              * inspector/command-line-api.html:
      2011-02-11  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: command line API $0 regressed.
              https://bugs.webkit.org/show_bug.cgi?id=54283
      
              * inspector/InjectedScriptSource.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d06460f
    • ossy@webkit.org's avatar
      [Qt] Increase the timeout of Qt API tests to 120 seconds. · c37206d7
      ossy@webkit.org authored
      Reviewed by Andreas Kling.
      
      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c37206d7
    • abarth@webkit.org's avatar
      2011-02-11 Adam Barth <abarth@webkit.org> · 8f1c9702
      abarth@webkit.org authored
              Reviewed by Andreas Kling.
      
              CryptographicRandomNumber has its threading ifdefs backwards
              https://bugs.webkit.org/show_bug.cgi?id=54280
      
              Turns out we want the mutex when thread is enabled.  :)
      
              * wtf/CryptographicallyRandomNumber.cpp:
              (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomNumber):
              (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomValues):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f1c9702
    • commit-queue@webkit.org's avatar
      2011-02-11 Janne Koskinen <janne.p.koskinen@digia.com> · 1f1d3b75
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt][S60] Vertical borders of buttons and frames are misaligned
              https://bugs.webkit.org/show_bug.cgi?id=51169
      
              Force anti-aliasing for lines and rects when using OpenVG backend on Symbian.
              OpenVG cannot guarantee rendering to be on pixel in floating point co-ordinates
              without anti-aliasing. Patch idea by Laszlo Agocs.
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f1d3b75
    • mario@webkit.org's avatar
      2011-02-11 Mario Sanchez Prada <msanchez@igalia.com> · f47dc69d
      mario@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] events missing when a document is (re)loaded
              https://bugs.webkit.org/show_bug.cgi?id=25831
      
              Added new layout test to check the right signals are emitted.
      
              * platform/gtk/accessibility/document-reload-events-expected.txt: Added.
              * platform/gtk/accessibility/document-reload-events.html: Added.
      2011-02-11  Mario Sanchez Prada  <msanchez@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] events missing when a document is (re)loaded
              https://bugs.webkit.org/show_bug.cgi?id=25831
      
              Make sure webArea returns a proper name and that a signal
              'state-change::defunct' is emitted when detaching the wrapper.
      
              Test: platform/gtk/accessibility/document-reload-events.html
      
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (webkit_accessible_get_name): Returns the current document's title
              as fallback mechanism for webArea objects.
              (webkit_accessible_detach): Emit 'state-change::defunct' function
              as soon as the wrapper is detached from the related core object.
      2011-02-11  Mario Sanchez Prada  <msanchez@igalia.com>
      
              Reviewed by Xan Lopez.
      
              [GTK] events missing when a document is (re)loaded
              https://bugs.webkit.org/show_bug.cgi?id=25831
      
              Emit the right signals when reloading a document.
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::notifyAccessibilityStatus): New function, to make sure
              the signals involved in reloading a document are properly emitted.
              (WebKit::notifyStatus): Also notify accessibility if enabled.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f47dc69d
    • abarth@webkit.org's avatar
      2011-02-11 Adam Barth <abarth@webkit.org> · 210df5f6
      abarth@webkit.org authored
              Turns out that expectation isn't Qt specific.
      
              * http/tests/security/cross-frame-access-put-expected.txt:
              * platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      210df5f6
    • abarth@webkit.org's avatar
      2011-02-11 Adam Barth <abarth@webkit.org> · 24af58a1
      abarth@webkit.org authored
              Update Qt expected results for window.crypto.
      
              * platform/qt/fast/dom/Window/window-properties-expected.txt:
              * platform/qt/fast/dom/prototype-inheritance-expected.txt:
              * platform/qt/http/tests/security/cross-frame-access-put-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      24af58a1
    • pfeldman@chromium.org's avatar
      2011-02-11 Pavel Feldman <pfeldman@chromium.org> · 44f8d299
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: command line's API inspect() is broken.
              https://bugs.webkit.org/show_bug.cgi?id=54275
      
              * http/tests/inspector/inspector-test2.js:
              (initialize_InspectorTest.InspectorTest.evaluateInConsoleAndDump):
              * inspector/command-line-api-expected.txt: Added.
              * inspector/command-line-api.html: Added.
      2011-02-11  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: command line's API inspect() is broken.
              https://bugs.webkit.org/show_bug.cgi?id=54275
      
              Test: inspector/command-line-api.html
      
              * inspector/InjectedScriptSource.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44f8d299
    • abarth@webkit.org's avatar
      2011-02-11 Adam Barth <abarth@webkit.org> · 45206199
      abarth@webkit.org authored
              Turns out window.crypto is supposed to be readonly.
      
              * page/DOMWindow.idl:
      2011-02-11  Adam Barth  <abarth@webkit.org>
      
              Update test expectations to show window.crypto.
      
              * fast/dom/Window/window-properties-expected.txt:
              * fast/dom/prototype-inheritance-2-expected.txt:
              * fast/dom/prototype-inheritance-expected.txt:
              * http/tests/security/cross-frame-access-put-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45206199
    • sergio@webkit.org's avatar
      2011-02-11 Sergio Villar Senin <svillar@igalia.com> · 001396d6
      sergio@webkit.org authored
              Unreviewed.
      
              Added new test expectations for the GTK port.
      
              * platform/gtk/fast/box-shadow/inset-box-shadows-expected.checksum: Added.
              * platform/gtk/fast/box-shadow/inset-box-shadows-expected.png: Added.
              * platform/gtk/fast/box-shadow/inset-box-shadows-expected.txt: Added.
              * platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.checksum: Added.
              * platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
              * platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.txt: Added.
              * platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.checksum: Added.
              * platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.png: Added.
              * platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Added.
              * platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.checksum: Added.
              * platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.png: Added.
              * platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Added.
              * platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.checksum: Added.
              * platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
              * platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      001396d6
    • abarth@webkit.org's avatar
      2011-02-11 Adam Barth <abarth@webkit.org> · 458636f5
      abarth@webkit.org authored
              Actually add Crypto.cpp to the Windows build.  I'm terrible.
      
              * WebCore.vcproj/WebCore.vcproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78325 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      458636f5
    • abarth@webkit.org's avatar
      Fix typo · 4d78e088
      abarth@webkit.org authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78324 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d78e088
    • abarth@webkit.org's avatar
      2011-02-11 Adam Barth <abarth@webkit.org> · aa5a9e22
      abarth@webkit.org authored
              Attempt to fix the Windows build.  Apparently we don't support
              conditional attributes on functions.  This patch makes the whole Crypto
              interface conditional on ArrayBuffer support.
      
              * page/DOMWindow.idl:
              * page/Crypto.cpp:
              * page/Crypto.h:
              * page/Crypto.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78323 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa5a9e22
    • antti@apple.com's avatar
      Enable ancestor identifier filtering for tree building · 61ac637b
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=54241
              
      Reviewed by Dave Hyatt.
      
      Call CSSStyleSelector::push/popParent() during tree building too, fix up the parent
      element stack as needed.
              
      This roughly halves the remaining time in style matching over a typical page load.
      
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::pushParentStackFrame):
      (WebCore::CSSStyleSelector::popParentStackFrame):
      (WebCore::CSSStyleSelector::pushParent):
      (WebCore::CSSStyleSelector::popParent):
      * css/CSSStyleSelector.h:
      (WebCore::CSSStyleSelector::ParentStackFrame::ParentStackFrame):
      * dom/Document.h:
      (WebCore::Document::styleSelectorIfExists):
      * dom/Element.cpp:
      (WebCore::Element::beginParsingChildren):
      (WebCore::Element::finishParsingChildren):
      * dom/Element.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78322 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61ac637b
    • abarth@webkit.org's avatar
      2011-02-10 Adam Barth <abarth@webkit.org> · ba712d32
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              WebKit should have a cryptographic RNG
              https://bugs.webkit.org/show_bug.cgi?id=22049
      
              Test crypto.getRandomValues API.  It's pretty hard to write a
              deterministic API for a randomized API, but this test should catch some
              regressions.
      
              * security/crypto-random-values-expected.txt: Added.
              * security/crypto-random-values.html: Added.
      2011-02-10  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              WebKit should have a cryptographic RNG
              https://bugs.webkit.org/show_bug.cgi?id=22049
      
              Teach JavaScriptCore how to export this function.
      
              * JavaScriptCore.exp:
              * JavaScriptCore.xcodeproj/project.pbxproj:
      2011-02-10  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              WebKit should have a cryptographic RNG
              https://bugs.webkit.org/show_bug.cgi?id=22049
      
              Add crypto.getRandomValues.  Yes, all these diffs are required to
              expose a single function to the DOM.
      
              Test: security/crypto-random-values.html
      
              * Android.mk:
              * CMakeLists.txt:
              * DerivedSources.cpp:
              * DerivedSources.make:
              * ForwardingHeaders/wtf/CryptographicallyRandomNumber.h: Added.
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pri:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSDOMWindowCustom.cpp:
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              * config.h:
              * page/Crypto.cpp: Added.
              (WebCore::Crypto::Crypto):
              (WebCore::Crypto::getRandomValues):
              * page/Crypto.h: Added.
              (WebCore::Crypto::create):
              * page/Crypto.idl: Added.
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::clear):
              (WebCore::DOMWindow::crypto):
              * page/DOMWindow.h:
              (WebCore::DOMWindow::optionalCrypto):
              * page/DOMWindow.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78321 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba712d32
    • commit-queue@webkit.org's avatar
      2011-02-11 Ryuan Choi <ryuan.choi@samsung.com> · 3043e530
      commit-queue@webkit.org authored
              Unreviewed build fix.
      
              [GTK] Build break with 2.18.3
              https://bugs.webkit.org/show_bug.cgi?id=54057
      
              * platform/gtk/ScrollbarThemeGtk2.cpp: Include GtkVersioning.h
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78320 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3043e530
    • commit-queue@webkit.org's avatar
      2011-02-11 Cosmin Truta <ctruta@chromium.org> · cfd41329
      commit-queue@webkit.org authored
              Reviewed by Adam Barth.
      
              Templatize KURLGooglePrivate::init
              https://bugs.webkit.org/show_bug.cgi?id=53749
      
              No new tests. Refactoring.
      
              * platform/KURLGoogle.cpp:
              (WebCore::KURLGooglePrivate::init):
              * platform/KURLGooglePrivate.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78319 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cfd41329
    • mjs@apple.com's avatar
      2011-02-10 Maciej Stachowiak <mjs@apple.com> · b34d7ccc
      mjs@apple.com authored
              Reviewed by Dan Bernstein.
      
              Temporarily skip a test that fails in WebKit2 due to a recent regression
              https://bugs.webkit.org/show_bug.cgi?id=54276
      
              * platform/mac-wk2/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78318 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b34d7ccc
    • aestes@apple.com's avatar
      2011-02-10 Andy Estes <aestes@apple.com> · 62683828
      aestes@apple.com authored
              Reviewed by Eric Seidel.
      
              Convert ContainerNode::firstElementChild() to a free function.
              https://bugs.webkit.org/show_bug.cgi?id=54269
      
              No new tests. No change in behavior.
      
              It seemed incorrect to have a method on ContainerNode that had the
              concept of an Element but couldn't return an Element*, but a method on
              Element could not be called by holders of ContainerNodes or other
              non-Element ContainerNode subclasses. A free function can both return
              an Element* and be called by anyone with a ContainerNode*.
      
              * dom/ContainerNode.h:
              (WebCore::ContainerNode::lastChild):
              (WebCore::Node::lastChild):
              * dom/Document.cpp:
              (WebCore::Document::cacheDocumentElement):
              * dom/Element.cpp:
              (WebCore::Element::firstElementChild):
              * dom/Element.h:
              (WebCore::firstElementChild):
              * html/parser/HTMLTreeBuilder.cpp:
              (WebCore::HTMLTreeBuilder::FragmentParsingContext::finished):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@78317 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62683828
  2. 10 Feb, 2011 12 commits