1. 24 Apr, 2012 40 commits
    • robert@webkit.org's avatar
      CSS 2.1 failure: table-columns-example-001 fails · ceeb5dc8
      robert@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83978
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Tests: css2.1/20110323/table-columns-example-001.html
             fast/css/table-rules-attribute-groups-with-frame.html
             fast/css/table-rules-attribute-groups.html
             fast/css/table-rules-attribute-none-with-frame.html
             fast/css/table-rules-attribute-with-frame1.html
             fast/css/table-rules-attribute-with-frame2.html
             fast/css/table-rules-attribute.html
      
      WebKit does not implement the 'cols', 'rows', and 'all' rules attributes correctly
      for cells that are adjacent to the table's edges. The solution is to follow the hint in the
      spec at http://www.w3.org/TR/CSS21/tables.html#columns and set the table's border to
      hidden when the rules attribute is set to one of 'cols', 'rows' or 'all', and the table itself
      has no explicit border. Border collapsing will take care of the rest as 'hidden' always wins in
      border-conflict resolution. It's not completely clear from the spec that an explicit table border
      should trump a cols rule but doing so is consistent with FF and Opera at least. A 'rules' attribute
      is trumped by anything specified for the 'frame' attribute so need to ensure that is respected too.
      
      In short, any 'rules' attribute means a hidden table border unless there's a frame or border attribute.
      
      * html/HTMLTableElement.cpp:
      (WebCore::HTMLTableElement::additionalAttributeStyle):
      
      LayoutTests:
      
      * css2.1/20110323/table-columns-example-001-expected.html: Added.
      * css2.1/20110323/table-columns-example-001.htm: Added.
      * fast/css/table-rules-attribute-expected.html: Added.
      * fast/css/table-rules-attribute-groups-expected.html: Added.
      * fast/css/table-rules-attribute-groups-with-frame-expected.png: Added.
      * fast/css/table-rules-attribute-groups-with-frame-expected.txt: Added.
      * fast/css/table-rules-attribute-groups-with-frame.html: Added.
      * fast/css/table-rules-attribute-groups.html: Added.
      * fast/css/table-rules-attribute-none-with-frame-expected.html: Added.
      * fast/css/table-rules-attribute-none-with-frame.html: Added.
      * fast/css/table-rules-attribute-with-frame1-expected.png: Added.
      * fast/css/table-rules-attribute-with-frame1-expected.txt: Added.
      * fast/css/table-rules-attribute-with-frame1.html: Added.
      * fast/css/table-rules-attribute-with-frame2-expected.png: Added.
      * fast/css/table-rules-attribute-with-frame2-expected.txt: Added.
      * fast/css/table-rules-attribute-with-frame2.html: Added.
        These test the correct interaction of a rules attribute with a frame attribute. 'cols' is used
        for the test, but each of cols, rows, and all have the same effect on the table's borders. It wasn't
        possible to create reftests for all of them because of the different behaviour of the frame attr to
        a simple border, probably due to painting order.
      * fast/css/table-rules-attribute.html: Added.
        This tests correct rendering of the rules attribute on a table without its own border. It
        also tests border collapsing on tables with a rules attribute.
      * platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
      * platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
         This is a progression - the table's border is hidden.
      * platform/chromium/test_expectations.txt:
      * platform/gtk/test_expectations.txt:
      * platform/mac/Skipped:
      * platform/mac/test_expectations.txt:
      * platform/qt/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115091 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ceeb5dc8
    • commit-queue@webkit.org's avatar
      [EFL] Rebaseline background tests · 2432c580
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84686
      
      Unreviewed rebaseline.
      
      Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-04-24
      
      * platform/efl/Skipped:
      * platform/efl/fast/backgrounds/001-expected.txt:
      * platform/efl/fast/backgrounds/animated-gif-as-background-expected.png:
      * platform/efl/fast/backgrounds/animated-svg-as-mask-expected.txt:
      * platform/efl/fast/backgrounds/background-leakage-expected.txt:
      * platform/efl/fast/backgrounds/background-leakage-transforms-expected.txt:
      * platform/efl/fast/backgrounds/background-origin-root-element-expected.txt:
      * platform/efl/fast/backgrounds/background-position-1-expected.png:
      * platform/efl/fast/backgrounds/background-position-parsing-expected.txt:
      * platform/efl/fast/backgrounds/background-position-rounding-expected.png:
      * platform/efl/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
      * platform/efl/fast/backgrounds/mask-box-image-expected.png: Added.
      * platform/efl/fast/backgrounds/mask-box-image-expected.txt: Added.
      * platform/efl/fast/backgrounds/mask-composite-expected.png:
      * platform/efl/fast/backgrounds/opacity-on-document-element-expected.txt:
      * platform/efl/fast/backgrounds/positioned-root-expected.png: Removed.
      * platform/efl/fast/backgrounds/positioned-root-expected.txt: Removed.
      * platform/efl/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.txt:
      * platform/efl/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
      * platform/efl/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
      * platform/efl/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
      * platform/efl/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
      * platform/efl/fast/backgrounds/repeat/noRepeatCorrectClip-expected.png:
      * platform/efl/fast/backgrounds/size/backgroundSize15-expected.txt:
      * platform/efl/fast/backgrounds/size/backgroundSize16-expected.txt:
      * platform/efl/fast/backgrounds/size/backgroundSize17-expected.png:
      * platform/efl/fast/backgrounds/size/backgroundSize17-expected.txt: Removed.
      * platform/efl/fast/backgrounds/size/backgroundSize18-expected.png:
      * platform/efl/fast/backgrounds/size/backgroundSize18-expected.txt: Removed.
      * platform/efl/fast/backgrounds/size/backgroundSize19-expected.png:
      * platform/efl/fast/backgrounds/size/backgroundSize19-expected.txt: Removed.
      * platform/efl/fast/backgrounds/size/backgroundSize20-expected.png:
      * platform/efl/fast/backgrounds/size/backgroundSize20-expected.txt: Removed.
      * platform/efl/fast/backgrounds/size/backgroundSize21-expected.png:
      * platform/efl/fast/backgrounds/size/backgroundSize21-expected.txt: Removed.
      * platform/efl/fast/backgrounds/size/backgroundSize22-expected.png:
      * platform/efl/fast/backgrounds/size/backgroundSize22-expected.txt: Removed.
      * platform/efl/fast/backgrounds/size/contain-and-cover-expected.png: Added.
      * platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
      * platform/efl/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
      * platform/efl/fast/backgrounds/size/zero-expected.txt:
      * platform/efl/fast/backgrounds/solid-color-context-restore-expected.png:
      * platform/efl/fast/backgrounds/solid-color-context-restore-expected.txt:
      * platform/efl/fast/backgrounds/svg-as-mask-expected.txt: Removed.
      * platform/efl/fast/backgrounds/table-root-expected.png: Removed.
      * platform/efl/fast/backgrounds/table-root-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2432c580
    • timothy@apple.com's avatar
      Stop installing localizedStrings.js in Production builds. · f3b2b0d6
      timothy@apple.com authored
      <rdar://problem/11296649>
      
      Reviewed by Joseph Pecoraro.
      
      * Configurations/WebCore.xcconfig: Added EXCLUDED_SOURCE_FILE_NAMES_Production_macosx
      and modified EXCLUDED_SOURCE_FILE_NAMES to look for CONFIGURATION variant.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115089 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3b2b0d6
    • kbr@google.com's avatar
      fast/dom/Window/window-postmessage-clone.html failing on Mac after r114992 · 014c6d42
      kbr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84741
      
      Not reviewed. Rebaseline only; verified locally.
      
      * fast/dom/Window/window-postmessage-clone-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115088 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      014c6d42
    • kling@webkit.org's avatar
      Unreviewed, skip unsupported inspector heap profiler test on mac. · acbd90bf
      kling@webkit.org authored
      * platform/mac/Skipped: Skip inspector/profiler/heap-snapshot-comparison-dom-groups-change.html
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      acbd90bf
    • commit-queue@webkit.org's avatar
      [chromium] Add a description field in WebURLError and show failure description... · 22bc20f7
      commit-queue@webkit.org authored
      [chromium] Add a description field in WebURLError and show failure description in the inspector network tab.
      https://bugs.webkit.org/show_bug.cgi?id=84566
      
      Patch by Yuzhu Shen <yzshen@chromium.org> on 2012-04-24
      Reviewed by Pavel Feldman.
      
      Source/Platform:
      
      * chromium/public/WebURLError.h:
      (WebURLError):
      
      Source/WebCore:
      
      * inspector/front-end/NetworkPanel.js:
      (WebInspector.NetworkDataGridNode.prototype._refreshStatusCell):
      * platform/chromium/support/WebURLError.cpp:
      (WebKit::WebURLError::operator=):
      (WebKit::WebURLError::operator ResourceError):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115086 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      22bc20f7
    • rwlbuis@webkit.org's avatar
      [SVG] getBBox on a <g> within symbol returns 0 but with defs it works correctly · f32c2290
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72796
      
      SVG <use> of <symbol> containing <linearGradient> renders black
      https://bugs.webkit.org/show_bug.cgi?id=82775
      
      Source/WebCore:
      
      Reviewed by Dirk Schulze.
      
      Create RenderSVGHiddenContainer for each <symbol>, which allows creation of child renderers too. This fixes
      both bugs since the bbox can be calculated at all times now and gradients in <symbol> are always created.
      This does allocate more memory but in general <symbol> is not used a lot and they tend to be small subtrees.
      
      Patch by Leo Yang.
      
      Tests: svg/custom/bbox-of-g-in-symbol.svg
             svg/custom/gradient-in-symbol-expected.svg
             svg/custom/gradient-in-symbol.svg
      
      * svg/SVGSymbolElement.cpp:
      (WebCore::SVGSymbolElement::createRenderer):
      (WebCore):
      * svg/SVGSymbolElement.h:
      (SVGSymbolElement):
      
      LayoutTests:
      
      Add a new test for each bug. Also rebaseline some test results since
      RenderSVGHiddenContainer is dumped now.
      
      Reviewed by Dirk Schulze.
      
      * platform/chromium/test_expectations.txt:
      * platform/mac/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
      * platform/mac/svg/carto.net/button-expected.txt:
      * platform/mac/svg/carto.net/colourpicker-expected.txt:
      * platform/mac/svg/carto.net/slider-expected.txt:
      * platform/mac/svg/carto.net/window-expected.txt:
      * platform/mac/svg/custom/embedding-external-svgs-expected.txt:
      * platform/mac/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
      * platform/mac/svg/custom/relative-sized-use-on-symbol-expected.txt:
      * platform/mac/svg/custom/relative-sized-use-without-attributes-on-symbol-expected.txt:
      * platform/mac/svg/custom/struct-use-09-b-expected.txt: Removed.
      * platform/mac/svg/custom/use-clipped-hit-expected.txt:
      * platform/mac/svg/custom/use-css-events-expected.txt:
      * platform/mac/svg/custom/use-modify-target-symbol-expected.txt:
      * platform/mac/svg/custom/use-on-disallowed-foreign-object-5-expected.txt:
      * platform/mac/svg/custom/use-on-g-containing-symbol-expected.txt:
      * platform/mac/svg/custom/use-on-symbol-expected.txt:
      * platform/mac/svg/custom/use-on-symbol-inside-pattern-expected.txt:
      * platform/mac/svg/custom/use-recalcStyle-crash-expected.txt:
      * platform/mac/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
      * platform/mac/svg/custom/use-symbol-overflow-expected.txt:
      * platform/qt/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
      * platform/qt/svg/carto.net/button-expected.txt:
      * platform/qt/svg/carto.net/colourpicker-expected.txt:
      * platform/qt/svg/carto.net/slider-expected.txt:
      * platform/qt/svg/carto.net/window-expected.txt:
      * platform/qt/svg/custom/relative-sized-shadow-tree-content-with-symbol-expected.txt:
      * platform/qt/svg/custom/use-on-g-containing-symbol-expected.txt:
      * platform/qt/svg/custom/use-on-symbol-expected.txt:
      * platform/qt/svg/custom/use-recalcStyle-crash-expected.txt:
      * platform/qt/svg/custom/use-referencing-nonexisting-symbol-expected.txt:
      * platform/qt/svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt:
      * platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt:
      * platform/qt/svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt:
      * svg/custom/bbox-of-g-in-symbol-expected.txt: Added.
      * svg/custom/bbox-of-g-in-symbol.svg: Added.
      * svg/custom/deep-dynamic-updates-expected.txt:
      * svg/custom/gradient-in-symbol-expected.svg: Added.
      * svg/custom/gradient-in-symbol.svg: Added.
      * svg/custom/use-in-symbol-with-offset-expected.txt:
      * svg/custom/use-setAttribute-crash-expected.txt:
      * svg/custom/use-transfer-width-height-properties-to-svg2-expected.txt:
      * svg/custom/use-transfer-width-height-properties-to-symbol-expected.txt:
      * svg/custom/use-transfer-width-height-properties-to-symbol1-expected.txt:
      * svg/custom/use-transfer-width-height-properties-to-symbol2-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115085 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f32c2290
    • beidson@apple.com's avatar
      <rdar://problem/10120155> and https://bugs.webkit.org/show_bug.cgi?id=82664 ... · 2a75a96b
      beidson@apple.com authored
      <rdar://problem/10120155> and https://bugs.webkit.org/show_bug.cgi?id=82664  Need DOMWindow mechanism to supplement UserScripts for page cache notifications
      
      Source/WebCore:
      
      This patch creates a new object type "DOMWindowExtension" which extends DOMWindowProperty.
      A DOMWindowExtension is tied to a particular DOMWindow and represents extensibility in that
      DOMWindow within a particular DOMWrapperWorld.
      
      It is a token object meant designed to notify clients of the various events in the lifetime
      of a DOMWindow property such as creation, disconnecting for the page cache, reconnecting
      when restoring from the page cache, and DOMWindow destruction.
      
      Reviewed by Sam Weinig.
      
      New WebKit API test DOMWindowExtensionBasic added.
      
      Add hooks for 4 new client calls regarding DOMWindowExtensions and global object lifetime:
      * loader/FrameLoaderClient.h:
      (WebCore::FrameLoaderClient::dispatchCanCreateGlobalObject):
      (WebCore::FrameLoaderClient::dispatchWillDisconnectDOMWindowExtensionFromGlobalObject):
      (WebCore::FrameLoaderClient::dispatchDidReconnectDOMWindowExtensionToGlobalObject):
      (WebCore::FrameLoaderClient::dispatchWillDestroyGlobalObjectForDOMWindowExtension):
      
      At the same time "DidClearWindowObject" is called, also notify clients that the global object is available:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::receivedFirstData):
      (WebCore::FrameLoader::dispatchGlobalObjectAvailableInAllWorlds):
      * loader/FrameLoader.h:
      
       DOMWindowProperties might want to unregister themselves during these notifications, so copy
       the set to a Vector. While this technique is arguably fragile, its certainly less fragile than
       mutating a set while iterating it:
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::willDetachPage):
      (WebCore::DOMWindow::disconnectDOMWindowProperties):
      (WebCore::DOMWindow::reconnectDOMWindowProperties):
      
       Implement the DOMWindowExtension object. It acts like a DOMWindowProperty with the added capability
       of remembering what Frame it used to be connected to so it can *always* notify clients on willDetachPage:
      * page/DOMWindowExtension.cpp: Added.
      (WebCore::DOMWindowExtension::DOMWindowExtension):
      (WebCore::DOMWindowExtension::~DOMWindowExtension):
      (WebCore::DOMWindowExtension::disconnectFrame):
      (WebCore::DOMWindowExtension::reconnectFrame):
      (WebCore::DOMWindowExtension::willDetachPage):
      * page/DOMWindowExtension.h: Added.
      (WebCore::DOMWindowExtension::create):
      (WebCore::DOMWindowExtension::world):
      
       Project files:
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.exp.in:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      
      Source/WebKit2:
      
      Reviewed by Sam Weinig.
      
      - Adds a new API object WKBundleDOMWindowExtension
      - Exposes callbacks about the lifetime of DOMWindowExtensions through BundlePageLoaderClient
      
      Add new API casts:
      * Shared/API/c/WKBase.h:
      * Shared/APIClientTraits.cpp:
      * Shared/APIObject.h:
      * WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
      
      Add API for the new DOMWindowExtension object:
      * WebProcess/InjectedBundle/API/c/WKBundleDOMWindowExtension.cpp: Added.
      (WKBundleDOMWindowExtensionGetTypeID):
      (WKBundleDOMWindowExtensionCreate):
      (WKBundleDOMWindowExtensionGetFrame):
      (WKBundleDOMWindowExtensionGetScriptWorld):
      * WebProcess/InjectedBundle/API/c/WKBundleDOMWindowExtension.h: Added.
      
      Add implementation for that API which wraps the WebCore::DOMWindowExtension:
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp: Added.
      (WebKit::allExtensions):
      (WebKit::InjectedBundleDOMWindowExtension::create):
      (WebKit::InjectedBundleDOMWindowExtension::get):
      (WebKit::InjectedBundleDOMWindowExtension::InjectedBundleDOMWindowExtension):
      (WebKit::InjectedBundleDOMWindowExtension::~InjectedBundleDOMWindowExtension):
      (WebKit::InjectedBundleDOMWindowExtension::frame):
      (WebKit::InjectedBundleDOMWindowExtension::world):
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h: Added.
      (InjectedBundleDOMWindowExtension):
      (WebKit::InjectedBundleDOMWindowExtension::type):
      
      Add new BundlePageLoaderClient methods:
      * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
      * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
      (WebKit::InjectedBundlePageLoaderClient::didCreateGlobalObjectForFrame):
      (WebKit::InjectedBundlePageLoaderClient::willDisconnectDOMWindowExtensionFromGlobalObject):
      (WebKit::InjectedBundlePageLoaderClient::didReconnectDOMWindowExtensionToGlobalObject):
      (WebKit::InjectedBundlePageLoaderClient::willDestroyGlobalObjectForDOMWindowExtension):
      * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
      (InjectedBundlePageLoaderClient):
      
      Implement the 4 new callbacks from WebCore which notify the BundlePageLoaderClient:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchGlobalObjectAvailable):
      (WebKit::WebFrameLoaderClient::dispatchWillDisconnectDOMWindowExtensionFromGlobalObject):
      (WebKit::WebFrameLoaderClient::dispatchDidReconnectDOMWindowExtensionToGlobalObject):
      (WebKit::WebFrameLoaderClient::dispatchWillDestroyGlobalObjectForDOMWindowExtension):
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      
      Project Files:
      * CMakeLists.txt:
      * GNUmakefile.am:
      * Target.pri:
      * WebKit2.xcodeproj/project.pbxproj:
      * win/WebKit2.vcproj:
      
      Tools:
      
      Reviewed by Sam Weinig.
      
      Add a new bundle test that stresses the basics of the WKBundleDOMWindowExtension API.
      
      It makes sure new extensions can be added at the right times, and that all of the expected
      callbacks are made.
      
      * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: Added.
      (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record all messages sent from the bundle.
      (TestWebKitAPI::TEST): Run a page through some basic exercises, then compared messages sent from the
         bundle to a set of known expected messages.
      
      Listen to all the new client callbacks, create some extensions, and monitor their lifetimes:
      * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: Added.
      (TestWebKitAPI::DOMWindowExtensionBasic::DOMWindowExtensionBasic):
      (TestWebKitAPI::DOMWindowExtensionBasic::frameLoadFinished):
      (TestWebKitAPI::DOMWindowExtensionBasic::sendExtensionStateMessage):
      (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
      (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
      (TestWebKitAPI::DOMWindowExtensionBasic::updateExtensionStateRecord):
      (TestWebKitAPI::DOMWindowExtensionBasic::sendBundleMessage):
      (TestWebKitAPI::DOMWindowExtensionBasic::didCreateGlobalObjectForFrame):
      (TestWebKitAPI::DOMWindowExtensionBasic::willDisconnectDOMWindowExtensionFromGlobalObject):
      (TestWebKitAPI::DOMWindowExtensionBasic::didReconnectDOMWindowExtensionToGlobalObject):
      (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
      (TestWebKitAPI::didFinishLoadForFrameCallback):
      (TestWebKitAPI::didCreateGlobalObjectForFrameCallback):
      (TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
      (TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
      (TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):
      
      * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
      (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Make this method static, as it always should have been.
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a75a96b
    • abecsi@webkit.org's avatar
      [Qt][WK2] Implement axis locking on the WebView for pan gestures · c181c892
      abecsi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84350
      
      Reviewed by Kenneth Rohde Christiansen.
      
      If a pan gesture has sufficient velocity along one axis the WebView
      should automatically lock the page movement to that axis.
      This locking should be maintained until the ongoing pan gesture ends.
      
      This patch implements a simple axis locker which adjusts the positions
      sent to the Flickable to the initial reference position according to the
      direction an velocity information it gathered from incoming touch events.
      
      The FlickableAxisLocker makes use of the velocity information of the touch point
      if available, else an approximate velocity of the incoming event is
      calculated.
      
      * UIProcess/API/qt/qquickwebview.cpp:
      (QQuickWebViewPrivate::FlickableAxisLocker::FlickableAxisLocker):
      (QQuickWebViewPrivate::FlickableAxisLocker::touchVelocity):
      (QQuickWebViewPrivate::FlickableAxisLocker::update):
      (QQuickWebViewPrivate::FlickableAxisLocker::setReferencePosition):
      (QQuickWebViewPrivate::FlickableAxisLocker::reset):
      (QQuickWebViewPrivate::FlickableAxisLocker::adjust):
      (QQuickWebViewPrivate::QQuickWebViewPrivate):
      (QQuickWebView::touchEvent):
      (QQuickWebView::handleFlickableMousePress):
      (QQuickWebView::handleFlickableMouseMove):
      (QQuickWebView::handleFlickableMouseRelease):
      * UIProcess/API/qt/qquickwebview_p_p.h:
      (QQuickWebViewPrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115082 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c181c892
    • pdr@google.com's avatar
      Update svg-ellipse-non-scale-stroke expectations · 45aa45e7
      pdr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=82628
      
      Unreviewed update of test expectations.
      
      
      * platform/chromium/test_expectations.txt:
      * platform/gtk/svg/hittest/svg-ellipse-non-scale-stroke-expected.txt: Removed.
      * platform/gtk/test_expectations.txt:
      * svg/hittest/svg-ellipse-non-scale-stroke-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45aa45e7
    • commit-queue@webkit.org's avatar
      [chromium] Don't keep pointers to released layer tree · e0a36f31
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84715
      
      Patch by Sami Kyostila <skyostil@chromium.org> on 2012-04-24
      Reviewed by Adrienne Walker.
      
      Source/WebCore:
      
      As part of tree synchronization, CCLayerTreeHostImpl loses ownership of
      the previous tree (as per releaseRootLayer()). After this point we
      should not retain any pointers to the old tree, because they are
      effectively invalid as soon as the root layer is released.
      
      For processing scroll updates we need to keep track of which layer is
      being scrolled, and this state needs to survive tree synchronizations.
      Instead of keeping a direct pointer to the scrolled layer, we now save
      the id of that layer and use it to look up the same layer from the new
      tree.
      
      Unit test: CCLayerTreeHostImplTest.replaceTreeWhileScrolling
      
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
      (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
      (WebCore::CCLayerTreeHostImpl::setRootLayer):
      (WebCore::CCLayerTreeHostImpl::releaseRootLayer):
      (WebCore::CCLayerTreeHostImpl::scrollBegin):
      (WebCore::CCLayerTreeHostImpl::scrollEnd):
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
      (CCLayerTreeHostImpl):
      
      Source/WebKit/chromium:
      
      Added new unit test to check that we can keep scrolling even if the layer
      tree is replaced from under us.
      
      * tests/CCLayerTreeHostImplTest.cpp:
      (WebKitTests::TEST_F):
      (WebKitTests):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115080 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0a36f31
    • achicu@adobe.com's avatar
      [CSS Filters] Move m_filter and related fields from RenderLayer to a different... · 3d4731a4
      achicu@adobe.com authored
      [CSS Filters] Move m_filter and related fields from RenderLayer to a different structure and only allocate it when needed
      https://bugs.webkit.org/show_bug.cgi?id=84460
      
      Reviewed by Dean Jackson.
      
      The new RenderLayerFilterInfo is meant to be allocated only when needed by filters. The link to the RenderLayerFilterInfo
      is maintained using a HashMap and a single boolean in the RenderLayer class.
      
      No new tests, just extracted a couple of fields inside the RenderLayer to a separate class.
      
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * rendering/FilterEffectRenderer.cpp:
      (WebCore::FilterEffectRendererHelper::prepareFilterEffect):
      (WebCore::FilterEffectRendererHelper::beginFilterEffect):
      (WebCore::FilterEffectRendererHelper::applyFilterEffect):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::RenderLayer):
      (WebCore::RenderLayer::~RenderLayer):
      (WebCore::RenderLayer::paintsWithFilters):
      (WebCore::RenderLayer::requiresFullLayerImageForFilters):
      (WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
      (WebCore::RenderLayer::paintLayerContents):
      (WebCore::RenderLayer::updateOrRemoveFilterEffect):
      * rendering/RenderLayer.h:
      (WebCore::RenderLayer::filterRenderer):
      (RenderLayer):
      (WebCore::RenderLayer::filterInfo):
      (WebCore::RenderLayer::ensureFilterInfo):
      (WebCore::RenderLayer::removeFilterInfoIfNeeded):
      (WebCore::RenderLayer::hasFilterInfo):
      (WebCore::RenderLayer::setHasFilterInfo):
      * rendering/RenderLayerFilterInfo.cpp: Added.
      (WebCore):
      (WebCore::RenderLayerFilterInfo::filterInfoForRenderLayer):
      (WebCore::RenderLayerFilterInfo::createFilterInfoForRenderLayerIfNeeded):
      (WebCore::RenderLayerFilterInfo::removeFilterInfoForRenderLayer):
      (WebCore::RenderLayerFilterInfo::RenderLayerFilterInfo):
      (WebCore::RenderLayerFilterInfo::~RenderLayerFilterInfo):
      (WebCore::RenderLayerFilterInfo::setRenderer):
      * rendering/RenderLayerFilterInfo.h: Added.
      (WebCore):
      (RenderLayerFilterInfo):
      (WebCore::RenderLayerFilterInfo::dirtySourceRect):
      (WebCore::RenderLayerFilterInfo::addDirtySourceRect):
      (WebCore::RenderLayerFilterInfo::resetDirtySourceRect):
      (WebCore::RenderLayerFilterInfo::renderer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115079 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d4731a4
    • darin@apple.com's avatar
      Iterating a HashMap<String, X> involves a string equality comparison to check for the empty value · 706431c2
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84524
      
      Reviewed by Antti Koivisto.
      
      Added a new algorithm for checking for empty buckets that can be specialized.
      Specialized it for String. We may later want to do the same thing for KURL.
      It's not important to do it for AtomicString, since AtomicString's == function
      is already a simple pointer equality compare. We may also later want to do
      something similar for pairs that have String objects in them.
      
      * wtf/HashTable.h:
      (WTF::HashTable::isEmptyBucket): Call the new isHashTraitsEmptyValue function, which
      will do something more efficient for String.
      
      * wtf/HashTraits.h: Added hasIsEmptyValueFunction to hash traits, with a default value
      of false. This allows us to continue to get automatic comparison with the appropriate
      emptyValue result for all existing traits, but supply a custom isEmptyValue function
      for HashTraits<String>. Putting an isEmptyValue function into the traits would require
      overriding it in every class that has a custom value for emptyValue. Specialized
      HashTraits for String to add hasIsEmptyValueFunction and declare, but not define, the
      isEmptyValue function.
      (WTF::isHashTraitsEmptyValue): Added a function that uses the HashTraitsEmptyValueChecker
      struct to use either == combined with the emptyValue function or the isEmptyValue function.
      
      * wtf/text/StringHash.h: Removed unneeded includes and sorted the using statements at
      the bottom of the file.
      (WTF::HashTraits<String>::isEmptyValue): Define this function here, since here we have
      included the WTFString.h header; the HashTraits.h header compiles without WTFString.h.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      706431c2
    • haraken@chromium.org's avatar
      [V8] Pass Isolate around in SerializedScriptValue.cpp (Part1) · c312f2a8
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84663
      
      Reviewed by Nate Chapin.
      
      The objective is to pass Isolate to toV8() in SerializedScriptValue.cpp.
      
      Part1: Add an Isolate argument to SerializedScriptValue::create(),
      SerializedScriptValue::deserialize(), etc.
      Part2: Add an m_isolate member to SerializedScriptValue::Writer()
      and SerializedScriptValue::Reader().
      Part3: Pass Isolate to toV8().
      
      This patch fixes Part1.
      
      No tests. No change in behavior.
      
      * bindings/v8/SerializedScriptValue.cpp:
      (WebCore::SerializedScriptValue::create):
      (WebCore::SerializedScriptValue::undefinedValue):
      (WebCore::SerializedScriptValue::booleanValue):
      (WebCore::SerializedScriptValue::numberValue):
      (WebCore::SerializedScriptValue::SerializedScriptValue):
      (WebCore::SerializedScriptValue::deserialize):
      (WebCore::SerializedScriptValue::deserializeForInspector):
      * bindings/v8/SerializedScriptValue.h:
      (SerializedScriptValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c312f2a8
    • mnaganov@chromium.org's avatar
      [Chromium] Unreviewed test expectations update. · 0e655b35
      mnaganov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84735
      
      Mark http/tests/inspector/change-iframe-src.html as flaky on Windows
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115076 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e655b35
    • carlosgc@webkit.org's avatar
      [GTK] Build and run TestWebKitAPI unit tests · 2f2682a8
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84325
      
      Reviewed by Philippe Normand.
      
      .:
      
      * GNUmakefile.am: Include makefiles to build gtest and
      TestWebKitAPI. Add BUILDING_WEBKIT2__ macro to compilation when
      building WebKit2.
      
      Source/ThirdParty:
      
      * gtest/GNUmakefile.am: Added.
      
      Tools:
      
      We only build WTF unit tests for now. WebKit2 tests will be
      enabled in a follow up patch.
      
      * Scripts/run-gtk-tests:
      (TestRunner): Add TestWebKitAPI/WTF to the list of directories
      containing unit tests.
      (TestRunner._run_test_glib): Run glib tests using gtester.
      (TestRunner._run_test_google): Run google tests.
      (TestRunner._run_test): Use _run_test_glib or _run_test_google
      depending on whether given test is glib or google test
      * TestWebKitAPI/GNUmakefile.am: Added.
      * TestWebKitAPI/config.h: Use #ifdef instead of # to fix a compile
      warning with -Wundef. Include WebKit2 headers only when building
      WebKit2.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f2682a8
    • haraken@chromium.org's avatar
      [V8][Refactoring] Remove deserializeAndSetProperty() · a7c3f40d
      haraken@chromium.org authored
      from SerializedScriptValue.cpp
      https://bugs.webkit.org/show_bug.cgi?id=84662
      
      Reviewed by Nate Chapin.
      
      SerializedScriptValue::deserializeAndSetProperty() is no
      longer used. This patch removes it.
      
      No tests. No change in behavior.
      
      * bindings/v8/SerializedScriptValue.cpp:
      * bindings/v8/SerializedScriptValue.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115074 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7c3f40d
    • haraken@chromium.org's avatar
      [V8] Pass Isolate to setDOMException() in CodeGeneratorV8.pm · adfc6f26
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84660
      
      Reviewed by Nate Chapin.
      
      The objective is to pass Isolate around in V8 bindings.
      This patch passes Isolate to setDOMException() in CodeGeneratorV8.pm.
      
      Test: bindings/scripts/test/TestEventTarget.idl
            bindings/scripts/test/TestObj.idl
            bindings/scripts/test/TestInterface.idl
      
      * bindings/scripts/CodeGeneratorV8.pm: Modified as described above.
      (GenerateSetDOMException):
      (GenerateNormalAttrGetter):
      (GenerateNormalAttrSetter):
      (GenerateFunctionCallback):
      (GenerateParametersCheck):
      (GenerateFunctionCallString):
      
      * bindings/scripts/test/V8/V8TestEventTarget.cpp:
      Updated run-bindings-tests results.
      (WebCore::TestEventTargetV8Internal::itemCallback):
      (WebCore::TestEventTargetV8Internal::dispatchEventCallback):
      * bindings/scripts/test/V8/V8TestInterface.cpp: Ditto.
      (WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):
      * bindings/scripts/test/V8/V8TestObj.cpp: Ditto.
      (WebCore::TestObjV8Internal::attrWithGetterExceptionAttrGetter):
      (WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetter):
      (WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetter):
      (WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrGetter):
      (WebCore::TestObjV8Internal::stringAttrWithGetterExceptionAttrSetter):
      (WebCore::TestObjV8Internal::stringAttrWithSetterExceptionAttrSetter):
      (WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrGetter):
      (WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrGetter):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrGetter):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
      (WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
      (WebCore::TestObjV8Internal::methodWithExceptionCallback):
      (WebCore::TestObjV8Internal::withScriptStateVoidExceptionCallback):
      (WebCore::TestObjV8Internal::withScriptStateObjExceptionCallback):
      (WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateObjExceptionCallback):
      (WebCore::TestObjV8Internal::getSVGDocumentCallback):
      (WebCore::TestObjV8Internal::strictFunctionCallback):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adfc6f26
    • mnaganov@chromium.org's avatar
      [Chromium] Unreviewed test expectations update. · 56377adf
      mnaganov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84733
      
      Mark fast/canvas/canvas-composite.html as flaky on Vista.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56377adf
    • commit-queue@webkit.org's avatar
      [Qt][WK2] Convert touch-point area · 263dbdf2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84434
      
      Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-24
      Reviewed by Kenneth Rohde Christiansen.
      
      Fix failing test after r114917 by also adding the new EventSender API
      to WebKitTestRunner.
      
      * WebKitTestRunner/EventSenderProxy.h:
      (EventSenderProxy):
      * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
      * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
      (WTR::EventSendingController::setTouchPointRadius):
      * WebKitTestRunner/InjectedBundle/EventSendingController.h:
      (EventSendingController):
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
      * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
      (WTR::EventSenderProxy::addTouchPoint):
      (WTR::EventSenderProxy::updateTouchPoint):
      (WTR::EventSenderProxy::setTouchPointRadius):
      (WTR::EventSenderProxy::clearTouchPoints):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      263dbdf2
    • philn@webkit.org's avatar
      Unreviewed, GTK test_expectations update. · b5765e9f
      philn@webkit.org authored
      * platform/gtk/test_expectations.txt: One more drag&drop test
      failing and mark fast/events/panScroll-click-hyperlink.html as
      missing result.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115070 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5765e9f
    • haraken@chromium.org's avatar
      [V8] Pass Isolate to setDOMException() (Part2) · 6c330604
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84658
      
      Reviewed by Nate Chapin.
      
      The objective is to pass Isolate around in V8 bindings.
      This patch passes Isolate to setDOMException() in custom
      binding code.
      
      No tests. No change in behavior.
      
      * bindings/v8/V8Collection.cpp:
      (WebCore::toOptionsCollectionSetter):
      * bindings/v8/V8Collection.h:
      (WebCore):
      * bindings/v8/custom/V8ArrayBufferViewCustom.h:
      (WebCore::constructWebGLArrayWithArrayBufferArgument):
      (WebCore::setWebGLArrayHelper):
      * bindings/v8/custom/V8DOMWindowCustom.cpp:
      (WebCore::WindowSetTimeoutImpl):
      * bindings/v8/custom/V8DataViewCustom.cpp:
      (WebCore::V8DataView::getInt8Callback):
      (WebCore::V8DataView::getUint8Callback):
      (WebCore::V8DataView::setInt8Callback):
      (WebCore::V8DataView::setUint8Callback):
      * bindings/v8/custom/V8DirectoryEntrySyncCustom.cpp:
      (WebCore::V8DirectoryEntrySync::getDirectoryCallback):
      (WebCore::V8DirectoryEntrySync::getFileCallback):
      * bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
      (WebCore::V8HTMLCanvasElement::toDataURLCallback):
      * bindings/v8/custom/V8HTMLElementCustom.cpp:
      (WebCore::V8HTMLElement::itemValueAccessorSetter):
      * bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
      (WebCore::V8HTMLOptionsCollection::addCallback):
      (WebCore::V8HTMLOptionsCollection::lengthAccessorSetter):
      (WebCore::V8HTMLOptionsCollection::indexedPropertySetter):
      * bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
      (WebCore::V8HTMLSelectElement::indexedPropertySetter):
      * bindings/v8/custom/V8NodeCustom.cpp:
      (WebCore::V8Node::insertBeforeCallback):
      (WebCore::V8Node::replaceChildCallback):
      (WebCore::V8Node::removeChildCallback):
      (WebCore::V8Node::appendChildCallback):
      * bindings/v8/custom/V8SQLTransactionCustom.cpp:
      (WebCore::V8SQLTransaction::executeSqlCallback):
      * bindings/v8/custom/V8WebKitMutationObserverCustom.cpp:
      (WebCore::V8WebKitMutationObserver::observeCallback):
      * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
      (WebCore::V8XMLHttpRequest::responseAccessorGetter):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c330604
    • haraken@chromium.org's avatar
      [V8] Pass Isolate to setDOMException() (Part1) · ad8ad875
      haraken@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84656
      
      Reviewed by Nate Chapin.
      
      The objective is to pass Isolate around in V8 bindings.
      This patch passes Isolate to setDOMException() in custom binding code.
      
      No tests. No change in behavior.
      
      * bindings/v8/custom/V8LocationCustom.cpp:
      (WebCore::V8Location::protocolAccessorSetter):
      * bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:
      (WebCore::V8SQLTransactionSync::executeSqlCallback):
      * bindings/v8/custom/V8SVGLengthCustom.cpp:
      (WebCore::V8SVGLength::valueAccessorGetter):
      (WebCore::V8SVGLength::valueAccessorSetter):
      (WebCore::V8SVGLength::convertToSpecifiedUnitsCallback):
      * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
      (WebCore::getObjectParameter):
      (WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
      (WebCore::V8WebGLRenderingContext::getExtensionCallback):
      (WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
      (WebCore::V8WebGLRenderingContext::getParameterCallback):
      (WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
      (WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
      (WebCore::V8WebGLRenderingContext::getUniformCallback):
      (WebCore::vertexAttribAndUniformHelperf):
      (WebCore::uniformHelperi):
      (WebCore::uniformMatrixHelper):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad8ad875
    • mifenton@rim.com's avatar
      [BlackBerry] Add additional details including the bounds of the box for caretPositionChanged. · e526ce84
      mifenton@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84728
      
      Reviewed by Antonio Gomes.
      
      PR 138988.
      
      Update caretPositionChanged to include the limit of the input field
      for single line inputs.
      
      Reviewed Internally by Gen Mak.
      
      * Api/WebPageClient.h:
      * WebKitSupport/InputHandler.cpp:
      (BlackBerry::WebKit::InputHandler::boundingBoxForInputField):
      (WebKit):
      * WebKitSupport/InputHandler.h:
      (InputHandler):
      * WebKitSupport/SelectionHandler.cpp:
      (BlackBerry::WebKit::SelectionHandler::clippingRectForVisibleContent):
      (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e526ce84
    • charles.wei@torchmobile.com.cn's avatar
      [BlackBerry] Input Range element expects mouse events · 4576c73c
      charles.wei@torchmobile.com.cn authored
      https://bugs.webkit.org/show_bug.cgi?id=84571
      
      Reviewed by Antonio Gomes.
      
      .:
      
      Input element with Range type expects mouse events to
      drag the handle. Note that Input Range could appear
      in both the web page directly, or in some shadow tree,
      like the MediaControlTimeline and MediaControlVolume.
      * ManualTests/blackberry/slider-thumb-consumes-event.html: Added.
      
      Source/WebKit/blackberry:
      
      Input element with Range type expects mouse events to
      drag the handle. Note that Input Range could appear
      in both the web page directly, or in some shadow tree,
      like the MediaControlTimeline and MediaControlVolume.
      * WebKitSupport/TouchEventHandler.cpp:
      (BlackBerry::WebKit::isRangeControlElement):
      (WebKit):
      (BlackBerry::WebKit::elementExpectsMouseEvents):
      (BlackBerry::WebKit::shouldConvertTouchToMouse):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4576c73c
    • pfeldman@chromium.org's avatar
      Web Inspector: encapsulate live location into the Script. · 1325afa0
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84722
      
      Reviewed by Yury Semikhatsky.
      
      Source/WebCore:
      
      Live location is just a location on the script. The way it is implemented today involves too many indirections.
      
      * inspector/front-end/CompilerScriptMapping.js:
      * inspector/front-end/DebuggerModel.js:
      (WebInspector.DebuggerModel.prototype.setBreakpointByScriptLocation):
      (WebInspector.DebuggerModel.prototype.scriptForId):
      * inspector/front-end/DebuggerPresentationModel.js:
      (WebInspector.DebuggerPresentationModel.prototype.createLiveLocation):
      (WebInspector.DebuggerPresentationModel.prototype._addConsoleMessageToScript):
      (WebInspector.DebuggerPresentationModel.prototype._debuggerPaused):
      (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
      (WebInspector.PresentationCallFrame.prototype.uiLocation):
      (WebInspector.DebuggerPresentationModel.CallFramePlacard):
      (WebInspector.DebuggerPresentationModel.Linkifier.prototype.linkifyRawLocation):
      * inspector/front-end/RawSourceCode.js:
      * inspector/front-end/ResourceScriptMapping.js:
      (WebInspector.ResourceScriptMapping.prototype.addScript):
      (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeChanged):
      (WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode):
      * inspector/front-end/Script.js:
      (WebInspector.Script):
      (WebInspector.Script.prototype.isInlineScript):
      (WebInspector.Script.prototype.setSourceMapping):
      (WebInspector.Script.prototype.createLocation):
      (WebInspector.Script.Location):
      (WebInspector.Script.Location.prototype.dispose):
      (WebInspector.Script.Location.prototype._update):
      * inspector/front-end/ScriptMapping.js:
      (WebInspector.UILocation):
      (WebInspector.SourceMapping):
      (WebInspector.SourceMapping.prototype.rawLocationToUILocation):
      (WebInspector.SourceMapping.prototype.uiLocationToRawLocation):
      (WebInspector.MainScriptMapping):
      (WebInspector.MainScriptMapping.prototype.addScript):
      (WebInspector.MainScriptMapping.prototype.reset):
      * inspector/front-end/SnippetsModel.js:
      (WebInspector.SnippetsScriptMapping.prototype._createUISourceCodeForScript):
      
      LayoutTests:
      
      * http/tests/inspector/debugger-test.js:
      (initialize_DebuggerTest):
      * inspector/debugger/linkifier.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1325afa0
    • yurys@chromium.org's avatar
      Web Inspector: a bunch of heap profiler cleanups · 635ad3d7
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84730
      
      - HeapSnapshotProviderProxy passed explicitely as a parameter to HeapSnapshotGridNode
      constructor
      - Removed dead code
      - Removed unused parameters
      - Added more closure compiler annotations
      - Extracted code finding cycled among node ancestors into a separate method
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/HeapSnapshot.js:
      (WebInspector.HeapSnapshot.prototype.createEdgesProvider):
      (WebInspector.HeapSnapshot.prototype.createRetainingEdgesProvider):
      (WebInspector.HeapSnapshot.prototype.createNodesProviderForDominator):
      (WebInspector.HeapSnapshotEdgesProvider):
      * inspector/front-end/HeapSnapshotDataGrids.js:
      * inspector/front-end/HeapSnapshotGridNodes.js:
      (WebInspector.HeapSnapshotGridNode):
      (WebInspector.HeapSnapshotGenericObjectNode):
      (WebInspector.HeapSnapshotObjectNode):
      (WebInspector.HeapSnapshotObjectNode.prototype._findAncestorWithSameSnapshotNodeId):
      (WebInspector.HeapSnapshotInstanceNode):
      (WebInspector.HeapSnapshotConstructorNode):
      (WebInspector.HeapSnapshotDiffNode):
      (WebInspector.HeapSnapshotDiffNode._createProvider):
      (WebInspector.HeapSnapshotDominatorObjectNode):
      * inspector/front-end/HeapSnapshotProxy.js:
      (WebInspector.HeapSnapshotWorker):
      (WebInspector.HeapSnapshotProxy.prototype.createNodesProviderForDominator):
      * inspector/front-end/utilities.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      635ad3d7
    • mnaganov@chromium.org's avatar
      [Chromium] Unreviewed test expectations update. · ac73dadd
      mnaganov@chromium.org authored
      The following tests have been marked as crashing in debug mode only:
      
          http/tests/websocket/tests/hixie76/workers/close-in-onmessage-crash.html
          http/tests/websocket/tests/hixie76/workers/close-in-worker.html
          http/tests/websocket/tests/hixie76/workers/worker-handshake-challenge-randomness.html
          http/tests/websocket/tests/hixie76/workers/worker-simple.html
          media/media-controller-playback.html
          media/track/track-cues-missed.html
          media/track/track-cues-pause-on-exit.html
          media/track/track-cues-sorted-before-dispatch.html
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac73dadd
    • adamk@chromium.org's avatar
      Fix includes in StrongInlines.h and ScriptValue.h · f56527de
      adamk@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84659
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore:
      
      * heap/StrongInlines.h: Include JSGlobalData.h, since JSGlobalData's
      definiition is required here.
      
      Source/WebCore:
      
      This change was prompted by an attempt to use ScriptValue.h from a
      WebCore header file and running into trouble with the (as it turns out
      unnecessary) include of JSDOMBinding.h.
      
      * bindings/js/ScriptValue.cpp: Add include of JSDOMBinding.h, now that
      it's not included by the header.
      * bindings/js/ScriptValue.h: Remove unnecessary include of JSDOMBinding.h.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f56527de
    • antti@apple.com's avatar
      Move MediaList CSSOM wrapper ownership to parent rule or stylesheet · 743b54c9
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=84716
      
      Reviewed by Anders Carlsson.
      
      MediaList CSSOM wrapper should be owned by a rule or a stylesheet, not by the underlying 
      MediaQuerySet.
              
      Remove the ref forwarding from MediaList in favor of regular refcounting. Use the usual
      pattern where the parent wrapper refs the child wrapper and zeroes the backpointer
      on destruction. 
      
      * bindings/js/JSDOMBinding.h:
      (WebCore::root):
      * css/CSSImportRule.cpp:
      (WebCore::CSSImportRule::~CSSImportRule):
      (WebCore::CSSImportRule::media):
      * css/CSSImportRule.h:
      (StyleRuleImport):
      (CSSImportRule):
      * css/CSSMediaRule.cpp:
      (WebCore::CSSMediaRule::~CSSMediaRule):
      (WebCore::CSSMediaRule::media):
      * css/CSSMediaRule.h:
      (CSSMediaRule):
      * css/CSSStyleSheet.cpp:
      (WebCore::CSSStyleSheet::~CSSStyleSheet):
      (WebCore::CSSStyleSheet::media):
      * css/CSSStyleSheet.h:
      (CSSStyleSheet):
      * css/MediaList.cpp:
      (WebCore::MediaQuerySet::mediaText):
      (WebCore::MediaList::MediaList):
      (WebCore):
      (WebCore::MediaList::notifyChanged):
      * css/MediaList.h:
      (MediaQuerySet):
      (WebCore::MediaList::create):
      (WebCore::MediaList::parentRule):
      (WebCore::MediaList::clearParentStyleSheet):
      (WebCore::MediaList::clearParentRule):
      (WebCore::MediaList::queries):
      (MediaList):
      * css/StyleRule.h:
      (WebCore::StyleRuleMedia::mediaQueries):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      743b54c9
    • commit-queue@webkit.org's avatar
      [Qt] Tap-to zoom should navigate when appropiate · b7b46031
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84602
      
      Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-04-24
      Reviewed by Simon Hausmann.
      
      When a zoomable area is returned and has the same zoom-level as the current,
      examine if the using this target would expose currently unexposed parts of
      the zoom-target. If it does, pan to that area instead of zooming back.
      
      * UIProcess/qt/QtViewportInteractionEngine.cpp:
      (WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7b46031
    • carlosgc@webkit.org's avatar
      [GTK] Should pass canvas/philip/tests/toDataURL.jpeg.alpha.html · 015d7d8c
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=83973
      
      Reviewed by Philippe Normand.
      
      Source/WebCore:
      
      Test: canvas/philip/tests/toDataURL.jpeg.alpha.html
      
      * platform/graphics/gtk/ImageBufferGtk.cpp:
      (WebCore::encodeImage): Convert ARGB32 cairo surface into RGB24
      when encoding JPEG images since JPEG encoder doesn't support alpha
      channel.
      
      LayoutTests:
      
      * platform/gtk/test_expectations.txt: Unskip
      canvas/philip/tests/toDataURL.jpeg.alpha.html
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      015d7d8c
    • carlosgc@webkit.org's avatar
      [GTK] Add WebKitCookieManager::changed signal to WebKit2 GTK+ API · d05b3406
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=82598
      
      Reviewed by Philippe Normand.
      
      Source/WebCore:
      
      * GNUmakefile.list.am: Add new files to compilation.
      * platform/gtk/TemporaryLinkStubs.cpp: Remove stubs for
      setCookieStoragePrivateBrowsingEnabled,
      startObservingCookieChanges and stopObservingCookieChanges.
      * platform/network/soup/CookieStorageSoup.cpp: Added.
      (WebCore::setCookieStoragePrivateBrowsingEnabled):
      (WebCore::soupCookiesChanged): Notify cookies changes using
      platform strategies.
      (WebCore::startObservingCookieChanges): Connect to changed signal
      of the soup cookie jar.
      (WebCore::stopObservingCookieChanges): Disconnect signals handlers
      for changed signals of the soup cookie jar.
      
      Source/WebKit2:
      
      * UIProcess/API/gtk/WebKitCookieManager.cpp:
      (webkitCookieManagerFinalize): Stop observing cookie changes.
      (webkit_cookie_manager_class_init): Add
      WebKitCookieManager::changed signal.
      (cookiesDidChange): Emit WebKitCookieManager::changed signal.
      (webkitCookieManagerCreate): Implement WKCookieManagerClient and
      start observing cookie changes.
      * UIProcess/API/gtk/tests/TestCookieManager.cpp:
      (testCookieManagerCookiesChanged):
      (beforeAll):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d05b3406
    • commit-queue@webkit.org's avatar
      Unreviewed. Rolled DEPS. · 718136a7
      commit-queue@webkit.org authored
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-24
      
      * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      718136a7
    • alexis.menard@openbossa.org's avatar
      Rename CSSStyleApplyProperty files to StyleBuilder. · 2e481213
      alexis.menard@openbossa.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84721
      
      Reviewed by Antti Koivisto.
      
      r115043 renamed CSSStyleApplyProperty class to StyleBuilder. This
      patch rename the files to match the new class name.
      
      No new tests : renaming of files, no behavior changes expected.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * css/CSSAllInOne.cpp:
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::collectMatchingRulesForList):
      * css/StyleBuilder.cpp: Renamed from Source/WebCore/css/CSSStyleApplyProperty.cpp.
      (WebCore):
      (ApplyPropertyExpanding):
      (WebCore::ApplyPropertyExpanding::applyInheritValue):
      (WebCore::ApplyPropertyExpanding::applyInitialValue):
      (WebCore::ApplyPropertyExpanding::applyValue):
      (WebCore::ApplyPropertyExpanding::createHandler):
      (ApplyPropertyDefaultBase):
      (WebCore::ApplyPropertyDefaultBase::setValue):
      (WebCore::ApplyPropertyDefaultBase::value):
      (WebCore::ApplyPropertyDefaultBase::initial):
      (WebCore::ApplyPropertyDefaultBase::applyInheritValue):
      (WebCore::ApplyPropertyDefaultBase::applyInitialValue):
      (WebCore::ApplyPropertyDefaultBase::applyValue):
      (WebCore::ApplyPropertyDefaultBase::createHandler):
      (ApplyPropertyDefault):
      (WebCore::ApplyPropertyDefault::setValue):
      (WebCore::ApplyPropertyDefault::applyValue):
      (WebCore::ApplyPropertyDefault::createHandler):
      (ApplyPropertyNumber):
      (WebCore::ApplyPropertyNumber::setValue):
      (WebCore::ApplyPropertyNumber::applyValue):
      (WebCore::ApplyPropertyNumber::createHandler):
      (ApplyPropertyStyleImage):
      (WebCore::ApplyPropertyStyleImage::applyValue):
      (WebCore::ApplyPropertyStyleImage::createHandler):
      (ApplyPropertyAuto):
      (WebCore::ApplyPropertyAuto::setValue):
      (WebCore::ApplyPropertyAuto::value):
      (WebCore::ApplyPropertyAuto::hasAuto):
      (WebCore::ApplyPropertyAuto::setAuto):
      (WebCore::ApplyPropertyAuto::applyInheritValue):
      (WebCore::ApplyPropertyAuto::applyInitialValue):
      (WebCore::ApplyPropertyAuto::applyValue):
      (WebCore::ApplyPropertyAuto::createHandler):
      (ApplyPropertyClip):
      (WebCore::ApplyPropertyClip::convertToLength):
      (WebCore::ApplyPropertyClip::applyInheritValue):
      (WebCore::ApplyPropertyClip::applyInitialValue):
      (WebCore::ApplyPropertyClip::applyValue):
      (WebCore::ApplyPropertyClip::createHandler):
      (WebCore::defaultInitialColor):
      (ApplyPropertyColor):
      (WebCore::ApplyPropertyColor::applyInheritValue):
      (WebCore::ApplyPropertyColor::applyInitialValue):
      (WebCore::ApplyPropertyColor::applyValue):
      (WebCore::ApplyPropertyColor::applyColorValue):
      (WebCore::ApplyPropertyColor::createHandler):
      (ApplyPropertyDirection):
      (WebCore::ApplyPropertyDirection::applyValue):
      (WebCore::ApplyPropertyDirection::createHandler):
      (ApplyPropertyLength):
      (WebCore::ApplyPropertyLength::setValue):
      (WebCore::ApplyPropertyLength::applyValue):
      (WebCore::ApplyPropertyLength::createHandler):
      (ApplyPropertyString):
      (WebCore::ApplyPropertyString::setValue):
      (WebCore::ApplyPropertyString::applyValue):
      (WebCore::ApplyPropertyString::createHandler):
      (ApplyPropertyBorderRadius):
      (WebCore::ApplyPropertyBorderRadius::setValue):
      (WebCore::ApplyPropertyBorderRadius::applyValue):
      (WebCore::ApplyPropertyBorderRadius::createHandler):
      (FillLayerAccessorTypes):
      (ApplyPropertyFillLayer):
      (WebCore::ApplyPropertyFillLayer::applyInheritValue):
      (WebCore::ApplyPropertyFillLayer::applyInitialValue):
      (WebCore::ApplyPropertyFillLayer::applyValue):
      (WebCore::ApplyPropertyFillLayer::createHandler):
      (ApplyPropertyComputeLength):
      (WebCore::ApplyPropertyComputeLength::setValue):
      (WebCore::ApplyPropertyComputeLength::applyValue):
      (WebCore::ApplyPropertyComputeLength::createHandler):
      (ApplyPropertyFont):
      (WebCore::ApplyPropertyFont::applyInheritValue):
      (WebCore::ApplyPropertyFont::applyInitialValue):
      (WebCore::ApplyPropertyFont::applyValue):
      (WebCore::ApplyPropertyFont::createHandler):
      (ApplyPropertyFontSize):
      (WebCore::ApplyPropertyFontSize::largerFontSize):
      (WebCore::ApplyPropertyFontSize::smallerFontSize):
      (WebCore::ApplyPropertyFontSize::applyInheritValue):
      (WebCore::ApplyPropertyFontSize::applyInitialValue):
      (WebCore::ApplyPropertyFontSize::applyValue):
      (WebCore::ApplyPropertyFontSize::createHandler):
      (ApplyPropertyFontWeight):
      (WebCore::ApplyPropertyFontWeight::applyValue):
      (WebCore::ApplyPropertyFontWeight::createHandler):
      (ApplyPropertyFontVariantLigatures):
      (WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
      (WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
      (WebCore::ApplyPropertyFontVariantLigatures::applyValue):
      (WebCore::ApplyPropertyFontVariantLigatures::createHandler):
      (ApplyPropertyBorderImage):
      (WebCore::ApplyPropertyBorderImage::applyValue):
      (WebCore::ApplyPropertyBorderImage::createHandler):
      (ApplyPropertyBorderImageModifier):
      (WebCore::ApplyPropertyBorderImageModifier::getValue):
      (WebCore::ApplyPropertyBorderImageModifier::setValue):
      (WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
      (WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
      (WebCore::ApplyPropertyBorderImageModifier::applyValue):
      (WebCore::ApplyPropertyBorderImageModifier::createHandler):
      (ApplyPropertyBorderImageSource):
      (WebCore::ApplyPropertyBorderImageSource::applyValue):
      (WebCore::ApplyPropertyBorderImageSource::createHandler):
      (ApplyPropertyCounter):
      (WebCore::ApplyPropertyCounter::emptyFunction):
      (WebCore::ApplyPropertyCounter::applyInheritValue):
      (WebCore::ApplyPropertyCounter::applyValue):
      (WebCore::ApplyPropertyCounter::createHandler):
      (ApplyPropertyCursor):
      (WebCore::ApplyPropertyCursor::applyInheritValue):
      (WebCore::ApplyPropertyCursor::applyInitialValue):
      (WebCore::ApplyPropertyCursor::applyValue):
      (WebCore::ApplyPropertyCursor::createHandler):
      (ApplyPropertyTextAlign):
      (WebCore::ApplyPropertyTextAlign::applyValue):
      (WebCore::ApplyPropertyTextAlign::createHandler):
      (ApplyPropertyTextDecoration):
      (WebCore::ApplyPropertyTextDecoration::applyValue):
      (WebCore::ApplyPropertyTextDecoration::createHandler):
      (ApplyPropertyUnicodeBidi):
      (WebCore::ApplyPropertyUnicodeBidi::applyValue):
      (WebCore::ApplyPropertyUnicodeBidi::createHandler):
      (ApplyPropertyLineHeight):
      (WebCore::ApplyPropertyLineHeight::applyValue):
      (WebCore::ApplyPropertyLineHeight::createHandler):
      (ApplyPropertyPageSize):
      (WebCore::ApplyPropertyPageSize::mmLength):
      (WebCore::ApplyPropertyPageSize::inchLength):
      (WebCore::ApplyPropertyPageSize::getPageSizeFromName):
      (WebCore::ApplyPropertyPageSize::applyInheritValue):
      (WebCore::ApplyPropertyPageSize::applyInitialValue):
      (WebCore::ApplyPropertyPageSize::applyValue):
      (WebCore::ApplyPropertyPageSize::createHandler):
      (ApplyPropertyTextEmphasisStyle):
      (WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
      (WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
      (WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
      (WebCore::ApplyPropertyTextEmphasisStyle::createHandler):
      (ApplyPropertyAnimation):
      (WebCore::ApplyPropertyAnimation::setValue):
      (WebCore::ApplyPropertyAnimation::value):
      (WebCore::ApplyPropertyAnimation::test):
      (WebCore::ApplyPropertyAnimation::clear):
      (WebCore::ApplyPropertyAnimation::initial):
      (WebCore::ApplyPropertyAnimation::map):
      (WebCore::ApplyPropertyAnimation::accessAnimations):
      (WebCore::ApplyPropertyAnimation::animations):
      (WebCore::ApplyPropertyAnimation::applyInheritValue):
      (WebCore::ApplyPropertyAnimation::applyInitialValue):
      (WebCore::ApplyPropertyAnimation::applyValue):
      (WebCore::ApplyPropertyAnimation::createHandler):
      (ApplyPropertyOutlineStyle):
      (WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
      (WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
      (WebCore::ApplyPropertyOutlineStyle::applyValue):
      (WebCore::ApplyPropertyOutlineStyle::createHandler):
      (ApplyPropertyResize):
      (WebCore::ApplyPropertyResize::applyValue):
      (WebCore::ApplyPropertyResize::createHandler):
      (ApplyPropertyVerticalAlign):
      (WebCore::ApplyPropertyVerticalAlign::applyValue):
      (WebCore::ApplyPropertyVerticalAlign::createHandler):
      (ApplyPropertyAspectRatio):
      (WebCore::ApplyPropertyAspectRatio::applyInheritValue):
      (WebCore::ApplyPropertyAspectRatio::applyInitialValue):
      (WebCore::ApplyPropertyAspectRatio::applyValue):
      (WebCore::ApplyPropertyAspectRatio::createHandler):
      (ApplyPropertyZoom):
      (WebCore::ApplyPropertyZoom::resetEffectiveZoom):
      (WebCore::ApplyPropertyZoom::applyInheritValue):
      (WebCore::ApplyPropertyZoom::applyInitialValue):
      (WebCore::ApplyPropertyZoom::applyValue):
      (WebCore::ApplyPropertyZoom::createHandler):
      (ApplyPropertyDisplay):
      (WebCore::ApplyPropertyDisplay::isValidDisplayValue):
      (WebCore::ApplyPropertyDisplay::applyInheritValue):
      (WebCore::ApplyPropertyDisplay::applyInitialValue):
      (WebCore::ApplyPropertyDisplay::applyValue):
      (WebCore::ApplyPropertyDisplay::createHandler):
      (ApplyPropertyFlex):
      (WebCore::ApplyPropertyFlex::applyInheritValue):
      (WebCore::ApplyPropertyFlex::applyInitialValue):
      (WebCore::ApplyPropertyFlex::applyValue):
      (WebCore::ApplyPropertyFlex::createHandler):
      (WebCore::ApplyPropertyFlex::getFlexValue):
      (WebCore::StyleBuilder::sharedStyleBuilder):
      (WebCore::StyleBuilder::StyleBuilder):
      * css/StyleBuilder.h: Renamed from Source/WebCore/css/CSSStyleApplyProperty.h.
      (WebCore):
      (PropertyHandler):
      (WebCore::PropertyHandler::PropertyHandler):
      (WebCore::PropertyHandler::applyInheritValue):
      (WebCore::PropertyHandler::applyInitialValue):
      (WebCore::PropertyHandler::applyValue):
      (WebCore::PropertyHandler::isValid):
      (WebCore::PropertyHandler::inheritFunction):
      (WebCore::PropertyHandler::initialFunction):
      (WebCore::PropertyHandler::applyFunction):
      (StyleBuilder):
      (WebCore::StyleBuilder::propertyHandler):
      (WebCore::StyleBuilder::index):
      (WebCore::StyleBuilder::valid):
      (WebCore::StyleBuilder::setPropertyHandler):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e481213
    • mnaganov@chromium.org's avatar
      [Chromium] Unreviewed test expectations update. · 6d1dfd53
      mnaganov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84726
      
      Mark webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_start_cmd as failing on Windows.
      
      * Scripts/webkitpy/test/test_finder.py:
      (TestFinder._default_names):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d1dfd53
    • fmalita@chromium.org's avatar
      WebCore::EventTarget::addEventListener crash · 3f804c33
      fmalita@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84171
      
      Source/WebCore:
      
      Reviewed by Nikolas Zimmermann.
      
      Test: svg/custom/use-tref-crash.svg
      
      Adding tref target event listeners while building the shadow tree is
      problematic, because SVGUseElement::buildShadowAndInstanceTree() only
      sets the element instance<->shadow element association at a later time.
      
      Fortunately, buildShadowAndInstanceTree() also propagates the event
      handlers (transferEventListenersToShadowTree) - so we can simply skip
      them in SVGTRefElement::buildPendingResource() for shadow elements.
      
      * svg/SVGTRefElement.cpp:
      (WebCore::SVGTRefElement::buildPendingResource):
      
      LayoutTests:
      
      Reviewed by Nikolas Zimmermann.
      
      * svg/custom/use-tref-crash-expected.txt: Added.
      * svg/custom/use-tref-crash.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f804c33
    • tkent@chromium.org's avatar
      Clickable area of a calendar picker indicator is too small. · 21717db7
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84677
      
      Reviewed by Kentaro Hara.
      
      Test: fast/forms/date/date-appearance.html is affected.
      
      * css/html.css:
      (input::-webkit-calendar-picker-indicator):
      - Remove unnecessary disaplay:inline-block.
      - Add paddings instead of the margin.
      (input::-webkit-calendar-picker-indicator:hover):
      Add hover style.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21717db7
    • mnaganov@chromium.org's avatar
      [Chromium] Unreviewed test expectations update. · d63a4b65
      mnaganov@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=84724
      
      Mark platform/chromium/media/video-frame-size-change.html as flaky on Mac 10.6.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d63a4b65
    • mnaganov@chromium.org's avatar
      [Chromium] Unreviewed test expectations update. · 6b0f92e5
      mnaganov@chromium.org authored
      http://crbug.com/31623
      
      Mark http/tests/appcache/remove-cache.html as flaky on Mac 10.6.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@115050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b0f92e5