1. 30 Oct, 2008 1 commit
  2. 29 Oct, 2008 5 commits
    • andersca@apple.com's avatar
      2008-10-29 Anders Carlsson <andersca@apple.com> · 9afaff46
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Remove an unused forward class declaration.
              
              * Plugins/WebBaseNetscapePluginView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9afaff46
    • andersca@apple.com's avatar
      2008-10-29 Anders Carlsson <andersca@apple.com> · 4558c152
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Remove WebBaseNetscapePluginViewInternal.h and WebBaseNetscapePluginViewPrivate.h.
      
              * Plugins/WebBaseNetscapePluginView.h:
              * Plugins/WebBaseNetscapePluginViewInternal.h: Removed.
              * Plugins/WebBaseNetscapePluginViewPrivate.h: Removed.
              * Plugins/WebNetscapePluginEventHandler.mm:
              * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
              * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
              * Plugins/npapi.mm:
              * WebView/WebHTMLView.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4558c152
    • andersca@apple.com's avatar
      2008-10-29 Anders Carlsson <andersca@apple.com> · e2b89383
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Remove WebNetscapePluginEmbeddedView, it adds nothing extra now. 
              
              Remove WebNetscapePlugInStreamLoaderClient since WebNetscapePluginStream is the client now.
              
              * Plugins/WebBaseNetscapePluginStream.h:
              * Plugins/WebBaseNetscapePluginStream.mm:
              * Plugins/WebBaseNetscapePluginView.h:
              * Plugins/WebKitPluginContainerView.h:
              * Plugins/WebNetscapePluginEmbeddedView.h: Removed.
              * Plugins/WebNetscapePluginEmbeddedView.mm: Removed.
              * Plugins/WebNetscapePluginEventHandler.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (NetscapePluginWidget::NetscapePluginWidget):
              (NetscapePluginWidget::handleEvent):
              (WebFrameLoaderClient::createPlugin):
              * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h: Removed.
              * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm: Removed.
              * WebView/WebHTMLView.mm:
              (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2b89383
    • andersca@apple.com's avatar
      2008-10-29 Anders Carlsson <andersca@apple.com> · cd46164f
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Remove the WebBaseNetscapePluginStream Objective-C object.
              
              * Plugins/WebBaseNetscapePluginStream.h:
              (WebNetscapePluginStream::create):
              * Plugins/WebBaseNetscapePluginStream.mm:
              (WebNetscapePluginStream::WebNetscapePluginStream):
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
              (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
              (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd46164f
    • beidson@apple.com's avatar
      2008-10-29 Brady Eidson <beidson@apple.com> · 31e1eb47
      beidson@apple.com authored
              Reviewed by Sam Weinig
      
              https://bugs.webkit.org/show_bug.cgi?id=21952
              
              Address an outstanding FIXME by removing unused SPI
      
              * History/WebHistory.mm:
              (-[WebHistory _addItemForURL:title:]): Fold addItem: into this method
      
              * History/WebHistoryPrivate.h: Removed unused/unneccessary SPI
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31e1eb47
  3. 28 Oct, 2008 5 commits
    • justin.garcia@apple.com's avatar
      WebCore: · 2876864e
      justin.garcia@apple.com authored
      2008-10-28  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin Adler.
      
              <rdar://problem/5188560> REGRESSION: Spell checker doesn't clear spelling/grammar marker after error is marked as Ignored
      
              * editing/Editor.cpp:
              (WebCore::Editor::ignoreSpelling): Remove misspelling markers from the word.
              (WebCore::Editor::learnSpelling): Added a FIXME about <rdar://problem/5396072>, which 
              will probably require a change more complicated than just marking the learned word as 
              misspelled.  I'll address it with a separate patch.
              * editing/EditorCommand.cpp:
              (WebCore::executeIgnoreSpelling): Added.
              (WebCore::CommandEntry::): Added an entry for IgnoreSpelling.
      
      WebKit/mac:
      
      2008-10-28  Justin Garcia  <justin.garcia@apple.com>
      
              Reviewed by Darin Adler.
              
              <rdar://problem/5188560> REGRESSION: Spell checker doesn't clear spelling/grammar marker after error is marked as Ignored
      
              * WebView/WebHTMLView.mm: IgnoreSpelling is now a WebCore command.  That command handles
              calling back into WebKit to perform the cross platform work that was removed in this change.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2876864e
    • cwzwarich@webkit.org's avatar
      2008-10-28 Cameron Zwarich <zwarich@apple.com> · ba054bbd
      cwzwarich@webkit.org authored
              Reviewed by Mark Rowe.
      
              Move ForwardingHeaders to their correct location after the creation of
              the runtime directory in JavaScriptCore.
      
              WebCore:
      
              * ForwardingHeaders/kjs/ArrayPrototype.h: Removed.
              * ForwardingHeaders/kjs/BooleanObject.h: Removed.
              * ForwardingHeaders/kjs/CallData.h: Removed.
              * ForwardingHeaders/kjs/ConstructData.h: Removed.
              * ForwardingHeaders/kjs/DateInstance.h: Removed.
              * ForwardingHeaders/kjs/Error.h: Removed.
              * ForwardingHeaders/kjs/FunctionConstructor.h: Removed.
              * ForwardingHeaders/kjs/FunctionPrototype.h: Removed.
              * ForwardingHeaders/kjs/InternalFunction.h: Removed.
              * ForwardingHeaders/kjs/JSArray.h: Removed.
              * ForwardingHeaders/kjs/JSFunction.h: Removed.
              * ForwardingHeaders/kjs/JSGlobalObject.h: Removed.
              * ForwardingHeaders/kjs/JSNumberCell.h: Removed.
              * ForwardingHeaders/kjs/JSObject.h: Removed.
              * ForwardingHeaders/kjs/JSString.h: Removed.
              * ForwardingHeaders/kjs/JSValue.h: Removed.
              * ForwardingHeaders/kjs/ObjectPrototype.h: Removed.
              * ForwardingHeaders/kjs/PropertyMap.h: Removed.
              * ForwardingHeaders/kjs/PrototypeFunction.h: Removed.
              * ForwardingHeaders/kjs/StringObject.h: Removed.
              * ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h: Removed.
              * ForwardingHeaders/kjs/StringPrototype.h: Removed.
              * ForwardingHeaders/kjs/StructureID.h: Removed.
              * ForwardingHeaders/runtime: Added.
              * ForwardingHeaders/runtime/ArrayPrototype.h: Copied from ForwardingHeaders/kjs/ArrayPrototype.h.
              * ForwardingHeaders/runtime/BooleanObject.h: Copied from ForwardingHeaders/kjs/BooleanObject.h.
              * ForwardingHeaders/runtime/CallData.h: Copied from ForwardingHeaders/kjs/CallData.h.
              * ForwardingHeaders/runtime/ConstructData.h: Copied from ForwardingHeaders/kjs/ConstructData.h.
              * ForwardingHeaders/runtime/DateInstance.h: Copied from ForwardingHeaders/kjs/DateInstance.h.
              * ForwardingHeaders/runtime/Error.h: Copied from ForwardingHeaders/kjs/Error.h.
              * ForwardingHeaders/runtime/FunctionConstructor.h: Copied from ForwardingHeaders/kjs/FunctionConstructor.h.
              * ForwardingHeaders/runtime/FunctionPrototype.h: Copied from ForwardingHeaders/kjs/FunctionPrototype.h.
              * ForwardingHeaders/runtime/InternalFunction.h: Copied from ForwardingHeaders/kjs/InternalFunction.h.
              * ForwardingHeaders/runtime/JSArray.h: Copied from ForwardingHeaders/kjs/JSArray.h.
              * ForwardingHeaders/runtime/JSFunction.h: Copied from ForwardingHeaders/kjs/JSFunction.h.
              * ForwardingHeaders/runtime/JSGlobalObject.h: Copied from ForwardingHeaders/kjs/JSGlobalObject.h.
              * ForwardingHeaders/runtime/JSNumberCell.h: Copied from ForwardingHeaders/kjs/JSNumberCell.h.
              * ForwardingHeaders/runtime/JSObject.h: Copied from ForwardingHeaders/kjs/JSObject.h.
              * ForwardingHeaders/runtime/JSString.h: Copied from ForwardingHeaders/kjs/JSString.h.
              * ForwardingHeaders/runtime/JSValue.h: Copied from ForwardingHeaders/kjs/JSValue.h.
              * ForwardingHeaders/runtime/ObjectPrototype.h: Copied from ForwardingHeaders/kjs/ObjectPrototype.h.
              * ForwardingHeaders/runtime/PropertyMap.h: Copied from ForwardingHeaders/kjs/PropertyMap.h.
              * ForwardingHeaders/runtime/PrototypeFunction.h: Copied from ForwardingHeaders/kjs/PrototypeFunction.h.
              * ForwardingHeaders/runtime/StringObject.h: Copied from ForwardingHeaders/kjs/StringObject.h.
              * ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h: Copied from ForwardingHeaders/kjs/StringObjectThatMasqueradesAsUndefined.h.
              * ForwardingHeaders/runtime/StringPrototype.h: Copied from ForwardingHeaders/kjs/StringPrototype.h.
              * ForwardingHeaders/runtime/StructureID.h: Copied from ForwardingHeaders/kjs/StructureID.h.
              * bindings/js/JSCSSStyleDeclarationCustom.cpp:
              * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
              * bindings/js/JSClipboardCustom.cpp:
              * bindings/js/JSConsoleCustom.cpp:
              * bindings/js/JSCustomPositionCallback.h:
              * bindings/js/JSCustomPositionErrorCallback.h:
              * bindings/js/JSCustomSQLStatementCallback.h:
              * bindings/js/JSCustomSQLStatementErrorCallback.h:
              * bindings/js/JSCustomSQLTransactionErrorCallback.h:
              * bindings/js/JSCustomVoidCallback.h:
              * bindings/js/JSCustomXPathNSResolver.h:
              * bindings/js/JSDOMBinding.cpp:
              * bindings/js/JSDOMBinding.h:
              * bindings/js/JSDOMGlobalObject.h:
              * bindings/js/JSDOMWindowBase.cpp:
              * bindings/js/JSDOMWindowCustom.cpp:
              * bindings/js/JSDOMWindowShell.cpp:
              * bindings/js/JSDatabaseCustom.cpp:
              * bindings/js/JSEventListener.cpp:
              * bindings/js/JSEventTarget.h:
              * bindings/js/JSHTMLDocumentCustom.cpp:
              * bindings/js/JSHistoryCustom.cpp:
              * bindings/js/JSInspectedObjectWrapper.cpp:
              * bindings/js/JSJavaScriptCallFrameCustom.cpp:
              * bindings/js/JSLocationCustom.cpp:
              * bindings/js/JSNodeFilterCondition.h:
              * bindings/js/JSQuarantinedObjectWrapper.cpp:
              * bindings/js/JSQuarantinedObjectWrapper.h:
              * bindings/js/JSXMLHttpRequestCustom.cpp:
              * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
              * bindings/objc/WebScriptObject.mm:
              * bindings/objc/WebScriptObjectPrivate.h:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bridge/NP_jsobject.cpp:
              * bridge/c/c_instance.cpp:
              * bridge/c/c_utility.cpp:
              * bridge/c/c_utility.h:
              * bridge/jni/jni_instance.cpp:
              * bridge/jni/jni_jsobject.h:
              * bridge/jni/jni_jsobject.mm:
              * bridge/jni/jni_runtime.cpp:
              * bridge/jni/jni_utility.cpp:
              * bridge/jni/jni_utility.h:
              * bridge/objc/objc_instance.mm:
              * bridge/objc/objc_runtime.h:
              * bridge/objc/objc_runtime.mm:
              * bridge/objc/objc_utility.h:
              * bridge/objc/objc_utility.mm:
              * bridge/runtime.h:
              * bridge/runtime_array.cpp:
              * bridge/runtime_array.h:
              * bridge/runtime_method.cpp:
              * bridge/runtime_method.h:
              * bridge/runtime_object.cpp:
              * bridge/runtime_object.h:
              * bridge/runtime_root.cpp:
              * inspector/JavaScriptCallFrame.cpp:
              * inspector/JavaScriptProfile.cpp:
              * inspector/JavaScriptProfile.h:
              * inspector/JavaScriptProfileNode.cpp:
              * inspector/JavaScriptProfileNode.h:
              * loader/FrameLoader.cpp:
              * page/Console.cpp:
              * plugins/PluginView.cpp:
              * plugins/gtk/PluginViewGtk.cpp:
              * plugins/qt/PluginViewQt.cpp:
              * plugins/win/PluginViewWin.cpp:
      
              WebKit/mac:
      
              * ForwardingHeaders/kjs/JSFunction.h: Removed.
              * ForwardingHeaders/kjs/JSObject.h: Removed.
              * ForwardingHeaders/kjs/JSString.h: Removed.
              * ForwardingHeaders/kjs/JSValue.h: Removed.
              * ForwardingHeaders/runtime: Added.
              * ForwardingHeaders/runtime/JSFunction.h: Copied from ForwardingHeaders/kjs/JSFunction.h.
              * ForwardingHeaders/runtime/JSObject.h: Copied from ForwardingHeaders/kjs/JSObject.h.
              * ForwardingHeaders/runtime/JSString.h: Copied from ForwardingHeaders/kjs/JSString.h.
              * ForwardingHeaders/runtime/JSValue.h: Copied from ForwardingHeaders/kjs/JSValue.h.
              * WebView/WebScriptDebugDelegate.mm:
              * WebView/WebScriptDebugger.mm:
              * WebView/WebView.mm:
      
              WebKit/win:
      
              * WebScriptCallFrame.h:
      
              WebKit/wx:
      
              * WebFrame.cpp:
              * WebView.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ba054bbd
    • adele@apple.com's avatar
      WebCore: · dfda2f4f
      adele@apple.com authored
      2008-10-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by John Sullivan.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
              "files" string for multifile uploads needs to be localized
      
              * page/mac/WebCoreViewFactory.h:
              * platform/LocalizedStrings.h:
              * platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):
              * platform/gtk/LocalizedStringsGtk.cpp: (WebCore::multipleFileUploadText):
              * platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth):
              * platform/mac/LocalizedStringsMac.mm: (WebCore::multipleFileUploadText):
              * platform/qt/Localizations.cpp: (WebCore::multipleFileUploadText):
              * platform/wx/LocalizedStringsWx.cpp: (WebCore::multipleFileUploadText):
      
      WebKit:
      
      2008-10-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by John Sullivan.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
              "files" string for multifile uploads needs to be localized
      
              * English.lproj/Localizable.strings: Updated with new string.
      
      WebKit/mac:
      
      2008-10-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by John Sullivan.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
              "files" string for multifile uploads needs to be localized
      
              * WebCoreSupport/WebViewFactory.mm: (-[WebViewFactory multipleFileUploadTextForNumberOfFiles:]):
              Added.
      
      WebKit/win:
      
      2008-10-28  Adele Peterson  <adele@apple.com>
      
              Reviewed by John Sullivan.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21880
              "files" string for multifile uploads needs to be localized
      
              * WebCoreLocalizedStrings.cpp: (multipleFileUploadText):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfda2f4f
    • timothy@apple.com's avatar
      Make the JavaScript profiler opt-in, so it does not slow down JavaScript all the time. · 7dec1b92
      timothy@apple.com authored
      Make the Profiles panel in the Web Inspector have an enable screen.
      Profiling now needs to be enabled before console.profile() works.
      
      WebCore:
      
      2008-10-27  Timothy Hatcher  <timothy@apple.com>
      
              Make the Profiles panel in the Web Inspector have an enable screen.
              Profiling now needs to be enabled before console.profile() works.
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
              not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * English.lproj/localizedStrings.js: New strings.
              * WebCore.base.exp: New and changed exports.
              * WebCore.vcproj/WebCore.vcproj: Add the PanelEnablerView.js file.
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::supportsProfiling): Call InspectorController:profilerEnabled.
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController): Initialize the m_startProfiling
              Timer to call InspectorController::startUserInitiatedProfiling.
              (WebCore::InspectorController::startUserInitiatedProfilingSoon): Start a one-shot timer
              that calls InspectorController::startUserInitiatedProfiling.
              (WebCore::InspectorController::startUserInitiatedProfiling): Recompile all JavaScript
              and enable the profiler if the profiler was not enabled.
              (WebCore::InspectorController::stopUserInitiatedProfiling): Rearrange code for readability.
              (WebCore::InspectorController::enableProfiler): Recompile all the JavaScript functions
              if the skipRecompile argument is false. Call the profilerWasEnabled script function.
              (WebCore::InspectorController::disableProfiler): Recompile all the JavaScript functions.
              Call the profilerWasEnabled script function.
              (WebCore::InspectorController::disableDebugger): Set m_attachDebuggerWhenShown to false,
              so it won't be started later.
              * inspector/InspectorController.h:
              (WebCore::InspectorController::profilerEnabled): Return enabled() && m_profilerEnabled.
              * inspector/front-end/Images/debuggingButtons.png: Remove.
              * inspector/front-end/Images/enableButtons.png: Added.
              * inspector/front-end/Images/profilesSilhouette.png: Added.
              * inspector/front-end/Images/scriptsSilhouette.png: Added.
              * inspector/front-end/PanelEnablerView.js: Added.
              (WebInspector.PanelEnablerView):
              (WebInspector.PanelEnablerView.prototype._enableButtonCicked): Fire the "enable clicked"
              event so listeners can do their thing.
              (WebInspector.PanelEnablerView.prototype._windowResized): Test if the icon should be hidden.
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel): Create the PanelEnablerView and the strings needed for it.
              (WebInspector.ProfilesPanel.prototype.get statusBarItems): Include the enableToggleButton.
              (WebInspector.ProfilesPanel.prototype.profilerWasEnabled): Call reset and populateInterface.
              (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): Call reset.
              (WebInspector.ProfilesPanel.prototype.reset): Call _updateInterface.
              (WebInspector.ProfilesPanel.prototype.setRecordingProfile): Moved in the code, no changes.
              (WebInspector.ProfilesPanel.prototype._updateInterface): Update the toggle button and
              show/hide other buttons. Also show/hide the PanelEnablerView.
              (WebInspector.ProfilesPanel.prototype._enableProfiling): Call _toggleProfiling if not enabled.
              (WebInspector.ProfilesPanel.prototype._toggleProfiling): Call InspectorController's
              disableProfiler or enableProfiler.
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel): Replace the overlay element with a PanelEnablerView. Replace the
              debuggingButton with the enableToggleButton.
              (WebInspector.ScriptsPanel.prototype.get statusBarItems): Replace the debuggingButton with
              the enableToggleButton.
              (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): Hide/show the pauseOnExceptionButton
              when needed. Replace the overlay element with a PanelEnablerView. Replace the debuggingButton
              with the enableToggleButton.
              (WebInspector.ScriptsPanel.prototype._enableDebugging): Call _toggleDebugging when not enabled.
              (WebInspector.ScriptsPanel.prototype._toggleDebugging): Remove the call to _clearInterface,
              since reset is called from debuggerWasEnabled and debuggerWasDisabled.
              * inspector/front-end/View.js: Inherit from WebInspector.Object.
              * inspector/front-end/WebKit.qrc: Add the PanelEnablerView.js file.
              * inspector/front-end/inspector.css: New styles for the PanelEnablerView.
              * inspector/front-end/inspector.html: Add the PanelEnablerView.js file.
              * inspector/front-end/inspector.js:
              (WebInspector.profilerWasEnabled): Added. Calls the ProfilesPanel.
              (WebInspector.profilerWasDisabled): Ditto.
              * page/Console.cpp:
              (WebCore::Console::error): Remove null check for m_frame, since m_frame isn't used.
              (WebCore::Console::info): Ditto.
              (WebCore::Console::log): Ditto.
              (WebCore::Console::assertCondition): Ditto.
              (WebCore::Console::dirxml): Remove null check for m_frame and use this->page().
              (WebCore::Console::count): Ditto.
              (WebCore::Console::profile): Return early if InspectorController::profilerEnabled is false.
              (WebCore::Console::profileEnd): Ditto.
              (WebCore::Console::warn): Remove null check for m_frame, since m_frame isn't used.
              * page/Settings.cpp:
              (WebCore::Settings::Settings): Remove initialization of m_didInitializeDeveloperExtrasEnabled.
              (WebCore::Settings::setDeveloperExtrasEnabled): Remove code that recompiled functions.
              Now just sets the member boolean.
              * page/Settings.h: Remove m_didInitializeDeveloperExtrasEnabled.
      
      WebKit/mac:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Add WebInspector methods to enable the profiler.
      
              https://bugs.webkit.org/show_bug.cgi?id=21927
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
              not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * WebInspector/WebInspector.h:
              * WebInspector/WebInspector.mm:
              (-[WebInspector isJavaScriptProfilingEnabled]): Added. Calls InspectorController::profilerEnabled.
              (-[WebInspector setJavaScriptProfilingEnabled:]): Added. Call InspectorController's disableProfiler
              or enableProfiler methods.
      
      WebKit/win:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Add IWebInspector methods to enable the profiler.
      
              https://bugs.webkit.org/show_bug.cgi?id=21927
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
              not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * WebInspector.cpp:
              (WebInspector::isJavaScriptProfilingEnabled): Added. Calls InspectorController::profilerEnabled.
              (WebInspector::setJavaScriptProfilingEnabled): Added. Call InspectorController's disableProfiler
              or enableProfiler methods.
              * WebInspector.h:
      
      WebKitTools:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Add support for enabling the profiler, so the profiling tests can continue
              work now that the profiler is not always enabled.
      
              https://bugs.webkit.org/show_bug.cgi?id=21927
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it does
              not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Make the editor use spaces.
              * DumpRenderTree/LayoutTestController.cpp:
              (setJavaScriptProfilingEnabledCallback): Added. Calls LayoutTestController::setJavaScriptProfilingEnabled.
              (LayoutTestController::staticFunctions): Added setJavaScriptProfilingEnabled to the script class.
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setJavaScriptProfilingEnabled): Stubbed out with a FIXME.
              * DumpRenderTree/mac/DumpRenderTree.mm:
              (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
              * DumpRenderTree/win/DumpRenderTree.cpp:
              (resetWebViewToConsistentStateBeforeTesting): Disables the developer extras and disables the profiler.
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::setJavaScriptProfilingEnabled): Toggles the developer extras and profiler.
      
      LayoutTests:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Update profiler tests to opt-in to profiling and clean up the output.
      
              https://bugs.webkit.org/show_bug.cgi?id=21927
      
              <rdar://problem/6211578> Make the JavaScript profiler opt-in, so it
              does not slow down JavaScript all the time
      
              Reviewed by Darin Adler and Kevin McCullough.
      
              * fast/profiler/anonymous-event-handler-expected.txt:
              * fast/profiler/anonymous-event-handler.html:
              * fast/profiler/anonymous-function-called-from-different-contexts-expected.txt:
              * fast/profiler/anonymous-function-called-from-different-contexts.html:
              * fast/profiler/anonymous-function-calls-built-in-functions-expected.txt:
              * fast/profiler/anonymous-function-calls-built-in-functions.html:
              * fast/profiler/anonymous-function-calls-eval-expected.txt:
              * fast/profiler/anonymous-function-calls-eval.html:
              * fast/profiler/apply-expected.txt:
              * fast/profiler/apply.html:
              * fast/profiler/built-in-function-calls-anonymous-expected.txt:
              * fast/profiler/built-in-function-calls-anonymous.html:
              * fast/profiler/built-in-function-calls-user-defined-function-expected.txt:
              * fast/profiler/built-in-function-calls-user-defined-function.html:
              * fast/profiler/call-expected.txt:
              * fast/profiler/call-nodelist-as-function-expected.txt:
              * fast/profiler/call-nodelist-as-function.html:
              * fast/profiler/call.html:
              * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt:
              * fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html:
              * fast/profiler/compare-multiple-profiles-expected.txt:
              * fast/profiler/compare-multiple-profiles.html:
              * fast/profiler/constructor-expected.txt:
              * fast/profiler/constructor.html:
              * fast/profiler/dead-time-expected.txt:
              * fast/profiler/dead-time.html:
              * fast/profiler/document-dot-write-expected.txt:
              * fast/profiler/document-dot-write.html:
              * fast/profiler/event-handler-expected.txt:
              * fast/profiler/event-handler.html:
              * fast/profiler/execution-context-and-eval-on-same-line-expected.txt:
              * fast/profiler/execution-context-and-eval-on-same-line.html:
              * fast/profiler/heavy-view-expected.txt:
              * fast/profiler/heavy-view.html:
              * fast/profiler/inline-event-handler-expected.txt:
              * fast/profiler/inline-event-handler.html:
              * fast/profiler/many-calls-in-the-same-scope-expected.txt:
              * fast/profiler/many-calls-in-the-same-scope.html:
              * fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
              * fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html:
              * fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
              * fast/profiler/multiple-and-different-scoped-function-calls.html:
              * fast/profiler/multiple-frames-expected.txt:
              * fast/profiler/multiple-frames.html:
              * fast/profiler/nested-anonymous-functon-expected.txt:
              * fast/profiler/nested-anonymous-functon.html:
              * fast/profiler/nested-start-and-stop-profiler-expected.txt:
              * fast/profiler/nested-start-and-stop-profiler.html:
              * fast/profiler/no-execution-context-expected.txt:
              * fast/profiler/no-execution-context.html:
              * fast/profiler/one-execution-context-expected.txt:
              * fast/profiler/one-execution-context.html:
              * fast/profiler/profile-calls-in-included-file-expected.txt:
              * fast/profiler/profile-calls-in-included-file.html:
              * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt:
              * fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html:
              * fast/profiler/profiling-from-a-nested-location-expected.txt:
              * fast/profiler/profiling-from-a-nested-location.html:
              * fast/profiler/resources/profiler-test-JS-resources.js:
              (endTest): Remove some whitespace.
              (insertGivenText): Hide the output of this method, sicne it is not important to the test.
              (insertNewText): Ditto.
              (printHeavyProfilesDataWithoutTime): Output plain text an not console.log.
              (printProfilesDataWithoutTime): Ditto.
              (printProfileNodeWithoutTime): Ditto.
              * fast/profiler/simple-event-call-expected.txt:
              * fast/profiler/simple-event-call.html:
              * fast/profiler/simple-no-level-change-expected.txt:
              * fast/profiler/simple-no-level-change.html:
              * fast/profiler/start-and-stop-profiler-multiple-times-expected.txt:
              * fast/profiler/start-and-stop-profiler-multiple-times.html:
              * fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt:
              * fast/profiler/start-and-stop-profiling-in-the-same-function.html:
              * fast/profiler/start-but-dont-stop-profiling-expected.txt:
              * fast/profiler/start-but-dont-stop-profiling.html:
              * fast/profiler/stop-profiling-after-setTimeout-expected.txt:
              * fast/profiler/stop-profiling-after-setTimeout.html:
              * fast/profiler/stop-then-function-call-expected.txt:
              * fast/profiler/stop-then-function-call.html:
              * fast/profiler/throw-exception-from-eval-expected.txt:
              * fast/profiler/throw-exception-from-eval.html:
              * fast/profiler/two-execution-contexts-expected.txt:
              * fast/profiler/two-execution-contexts.html:
              * fast/profiler/user-defined-function-calls-built-in-functions-expected.txt:
              * fast/profiler/user-defined-function-calls-built-in-functions.html:
              * fast/profiler/window-dot-eval-expected.txt:
              * fast/profiler/window-dot-eval.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dec1b92
    • timothy@apple.com's avatar
      Rename a few methods related to attaching and detaching the debugger. Also... · 0a8972d0
      timothy@apple.com authored
      Rename a few methods related to attaching and detaching the debugger. Also adds stub methods for enabling and disabling the profiler.
      
      WebCore:
      
      2008-10-27  Timothy Hatcher  <timothy@apple.com>
      
              Rename a few methods related to attaching and detaching the debugger. Also
              adds stub methods for enabling and disabling the profiler.
      
              * Rename attachDebugger to enableDebugger.
              * Rename detachDebugger to disableDebugger.
              * Rename the debuggerAttached getter to debuggerEnabled.
              * Rename the debuggerAttached callback to debuggerWasEnabled.
              * Rename the debuggerDetached callback to debuggerWasDisabled.
      
              Reviewed by Darin Adler.
      
              * WebCore.base.exp:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              (WebCore::InspectorController::setWindowVisible):
              (WebCore::InspectorController::windowScriptObjectAvailable):
              (WebCore::InspectorController::close):
              (WebCore::InspectorController::enableProfiler):
              (WebCore::InspectorController::disableProfiler):
              (WebCore::InspectorController::enableDebugger):
              (WebCore::InspectorController::disableDebugger):
              (WebCore::InspectorController::pauseInDebugger):
              (WebCore::InspectorController::resumeDebugger):
              (WebCore::InspectorController::stepOverStatementInDebugger):
              (WebCore::InspectorController::stepIntoStatementInDebugger):
              (WebCore::InspectorController::stepOutOfFunctionInDebugger):
              * inspector/InspectorController.h:
              (WebCore::InspectorController::profilerEnabled):
              (WebCore::InspectorController::debuggerEnabled):
              * inspector/front-end/BreakpointsSidebarPane.js:
              (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
              (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint):
              (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
              * inspector/front-end/Object.js:
              * inspector/front-end/ProfilesPanel.js:
              (WebInspector.ProfilesPanel):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype.get statusBarItems):
              (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled):
              (WebInspector.ScriptsPanel.prototype.debuggerWasDetached):
              (WebInspector.ScriptsPanel.prototype.reset):
              (WebInspector.ScriptsPanel.prototype.canShowResource):
              (WebInspector.ScriptsPanel.prototype._updatePauseOnExceptionsButton):
              (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons):
              (WebInspector.ScriptsPanel.prototype._toggleDebugging):
              * inspector/front-end/View.js:
              * inspector/front-end/inspector.css:
              * inspector/front-end/inspector.html:
              * inspector/front-end/inspector.js:
              (WebInspector.addResource):
              (WebInspector.debuggerWasEnabled):
              (WebInspector.debuggerWasDisabled):
      
      WebKit/mac:
      
      2008-10-27  Timothy Hatcher  <timothy@apple.com>
      
              Rename a few methods related to attaching and detaching the debugger.
      
              * Rename attachDebugger to enableDebugger.
              * Rename detachDebugger to disableDebugger.
              * Rename the debuggerAttached getter to debuggerEnabled.
      
              Reviewed by Darin Adler.
      
              * WebInspector/WebInspector.mm:
              (-[WebInspector isDebuggingJavaScript]):
              (-[WebInspector startDebuggingJavaScript:]):
              (-[WebInspector stopDebuggingJavaScript:]):
      
      WebKit/win:
      
      2008-10-27  Timothy Hatcher  <timothy@apple.com>
      
              Rename a few methods related to attaching and detaching the debugger.
      
              * Rename attachDebugger to enableDebugger.
              * Rename detachDebugger to disableDebugger.
              * Rename the debuggerAttached getter to debuggerEnabled.
      
              Reviewed by Darin Adler.
      
              * WebInspector.cpp:
              (WebInspector::isDebuggingJavaScript):
              (WebInspector::toggleDebuggingJavaScript):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a8972d0
  4. 27 Oct, 2008 6 commits
    • andersca@apple.com's avatar
      2008-10-27 Anders Carlsson <andersca@apple.com> · 503b58d2
      andersca@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              Use the C++ stream object for JS requests as well.
              
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
              (-[WebBaseNetscapePluginView destroyStream:reason:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      503b58d2
    • andersca@apple.com's avatar
      2008-10-27 Anders Carlsson <andersca@apple.com> · 208b92ff
      andersca@apple.com authored
              Reviewed by Dan Bernstein.
              
              Use the C++ stream object in WebBaseNetscapePluginView. Use a HashSet of RefPtrs to keep track of the streams.
              
              * Plugins/WebBaseNetscapePluginStream.mm:
              (WebNetscapePluginStream::~WebNetscapePluginStream):
              (WebNetscapePluginStream::setPlugin):
              (WebNetscapePluginStream::startStream):
              (WebNetscapePluginStream::destroyStream):
              (WebNetscapePluginStream::destroyStreamWithReason):
              (WebNetscapePluginStream::cancelLoadAndDestroyStreamWithError):
              (WebNetscapePluginStream::deliverData):
              * Plugins/WebBaseNetscapePluginView.h:
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView stop]):
              (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]):
              (-[WebBaseNetscapePluginView disconnectStream:]):
              (-[WebBaseNetscapePluginView dealloc]):
              (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
              (-[WebBaseNetscapePluginView pluginView:receivedData:]):
              (-[WebBaseNetscapePluginView pluginView:receivedError:]):
              (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]):
              (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      208b92ff
    • andersca@apple.com's avatar
      2008-10-27 Anders Carlsson <andersca@apple.com> · 9c716837
      andersca@apple.com authored
              Reviewed by Mitz Pettel.
              
              Move code from dealloc and finalize to the WebNetscapePluginStream destructor.
              
              * Plugins/WebBaseNetscapePluginStream.h:
              * Plugins/WebBaseNetscapePluginStream.mm:
              (WebNetscapePluginStream::~WebNetscapePluginStream):
              (-[WebBaseNetscapePluginStream dealloc]):
              (-[WebBaseNetscapePluginStream finalize]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c716837
    • andersca@apple.com's avatar
      2008-10-27 Anders Carlsson <andersca@apple.com> · e695a406
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Get rid of WebNetscapePlugInStreamLoaderClient, the plug-in stream is its own client.
              
              * Plugins/WebBaseNetscapePluginStream.h:
              * Plugins/WebBaseNetscapePluginStream.mm:
              (WebNetscapePluginStream::WebNetscapePluginStream):
              (-[WebBaseNetscapePluginStream dealloc]):
              (-[WebBaseNetscapePluginStream finalize]):
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView pluginView:receivedError:]):
              (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]):
              (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
              (-[WebBaseNetscapePluginView destroyStream:reason:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e695a406
    • andersca@apple.com's avatar
      2008-10-27 Anders Carlsson <andersca@apple.com> · 922a50eb
      andersca@apple.com authored
              Reviewed by Darin Adler.
      
              Change the Obj-C init methods to simply call WebNetscapePluginStream::create.
              
              * Plugins/WebBaseNetscapePluginStream.h:
              (WebNetscapePluginStream::create):
              * Plugins/WebBaseNetscapePluginStream.mm:
              (-[WebBaseNetscapePluginStream initWithFrameLoader:]):
              (WebNetscapePluginStream::WebNetscapePluginStream):
              (-[WebBaseNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      922a50eb
    • andersca@apple.com's avatar
      2008-10-27 Anders Carlsson <andersca@apple.com> · 71d0d106
      andersca@apple.com authored
              Reviewed by Kevin Decker.
      
              Convert more code over to C++.
              
              * Plugins/WebBaseNetscapePluginStream.h:
              (WebNetscapePluginStream::plugin):
              (WebNetscapePluginStream::setRequestURL):
              Convert to C++.
      
              * Plugins/WebBaseNetscapePluginStream.mm:
              (WebNetscapePluginStream::start):
              (WebNetscapePluginStream::stop):
              Ditto.
              
              (WebNetscapePluginStream::startStreamWithResponse):
              Ditto.
              
              (-[WebBaseNetscapePluginStream startStreamWithResponse:]):
              Call the C++ version.
              
              (-[WebBaseNetscapePluginStream impl]):
              New accessor for the C++ class.
              
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView pluginView:receivedData:]):
              (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
              (-[WebBaseNetscapePluginView destroyStream:reason:]):
              Call the C++ methods.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71d0d106
  5. 25 Oct, 2008 1 commit
    • weinig@apple.com's avatar
      WebCore: · d75fed72
      weinig@apple.com authored
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              Move file choosing into WebKit ChromeClient.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyChromeClient::runOpenPanel):
              * page/Chrome.cpp:
              (WebCore::Chrome::runOpenPanel):
              * page/Chrome.h:
              * page/ChromeClient.h:
              * page/mac/ChromeMac.mm:
              * platform/FileChooser.h:
              * platform/mac/FileChooserMac.mm:
              * platform/qt/FileChooserQt.cpp:
              * platform/win/FileChooserWin.cpp:
              * platform/wx/TemporaryLinkStubs.cpp:
              * rendering/RenderFileUploadControl.cpp:
              (WebCore::RenderFileUploadControl::click):
      
      WebKit/gtk:
      
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::runOpenPanel):
              * WebCoreSupport/ChromeClientGtk.h:
      
      WebKit/mac:
      
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::runOpenPanel):
      
      WebKit/qt:
      
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::runOpenPanel):
              * WebCoreSupport/ChromeClientQt.h:
      
      WebKit/win:
      
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              * WebCoreSupport/WebChromeClient.cpp:
              (WebChromeClient::runOpenPanel):
              * WebCoreSupport/WebChromeClient.h:
      
      WebKit/wx:
      
      2008-10-24  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=21759
              Layering violation: FileChooser should not depend on Document/Frame/Page
      
              * WebKitSupport/ChromeClientWx.cpp:
              (WebCore::ChromeClientWx::runOpenPanel):
              * WebKitSupport/ChromeClientWx.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d75fed72
  6. 24 Oct, 2008 6 commits
    • andersca@apple.com's avatar
      2008-10-24 Anders Carlsson <andersca@apple.com> · 6e12c0d6
      andersca@apple.com authored
              Fix Tiger build.
              
              * WebView/WebUIDelegate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e12c0d6
    • andersca@apple.com's avatar
      WebCore: · 4348c6a8
      andersca@apple.com authored
      2008-10-24  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam Weinig.
      
              <rdar://problem/5440917> Support NPN_Construct
                      
              * WebCore.NPAPI.exp:
              Export _NPN_Construct.
              
              * bridge/NP_jsobject.cpp:
              (_NPN_Construct):
              Implement this.
              
              * bridge/c/c_instance.cpp:
              (JSC::Bindings::CInstance::supportsConstruct):
              (JSC::Bindings::CInstance::invokeConstruct):
              Have this call the appropriate NPClass method.
              
              * bridge/npruntime.h:
              Add NPN_Construct.
      
              * bridge/npruntime_impl.h:
              Add _NPN_Construct.
              
              * bridge/runtime.h:
              (JSC::Bindings::Instance::supportsConstruct):
              (JSC::Bindings::Instance::invokeConstruct):
              New methods.
              
              * bridge/runtime_object.cpp:
              (JSC::callRuntimeConstructor):
              Call the native instance.
              
              (JSC::RuntimeObjectImp::getConstructData):
              Implement this.
              
              * bridge/runtime_object.h:
              Add new method declarations.
              
              * plugins/gtk/PluginPackageGtk.cpp:
              (WebCore::PluginPackage::load):
              * plugins/qt/PluginPackageQt.cpp:
              (WebCore::PluginPackage::load):
              * plugins/win/PluginPackageWin.cpp:
              (WebCore::PluginPackage::load):
              Initialize m_pluginFuncs.construct.
      
      WebKit/mac:
      
      2008-10-24  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam Weinig.
      
              <rdar://problem/5440917> Support NPN_Construct
              
              Set construct.
              
              * Plugins/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage load]):
      
      WebKitTools:
      
      2008-10-24  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam Weinig.
              
              <rdar://problem/5440917> Support NPN_Construct
              
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
              (testCallback):
              Fix a memory leak.
              
              (testConstruct):
              New test method that treats it first argument as a constructor and invokes it with the rest of the arguments.
              
              (pluginInvoke):
              Handle testConstruct.
              
              * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp:
              (testGetProperty):
              Add objectPointer property.
              
              (testEnumerate):
              Only enumerate the two first properties.
              
              (testConstruct):
              Add a simple construct implementation that just returns the test object.
      
      LayoutTests:
      
      2008-10-24  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Sam Weinig.
      
              <rdar://problem/5440917> Support NPN_Construct
              
              Add testcase.
              
              * plugins/netscape-construct-expected.txt: Added.
              * plugins/netscape-construct.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37869 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4348c6a8
    • mrowe@apple.com's avatar
      <rdar://problem/6119711> Remove the dependency on Foundation's private... · d71d3ff4
      mrowe@apple.com authored
      <rdar://problem/6119711> Remove the dependency on Foundation's private __COCOA_FORMAL_PROTOCOLS__ define.
      
      Rubber-stamped by Tim Hatcher.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d71d3ff4
    • adele@apple.com's avatar
      WebCore: · 497541bd
      adele@apple.com authored
      2008-10-24  Adele Peterson  <adele@apple.com>
      
              Reviewed by Sam Weinig.
      
              WebCore part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
      
              This change adds support for multiple file selection in an <input type="file"> control when the "multiple" attribute is used.
              This is consistent with the direction HTML5 will be going in the future.
      
              The initial implementation here will show "n files" as the text next to the control when multiple files are selected.  You can view
              the individual files in a tooltip for now.  Improvements to this control will come later.  
      
              Web developers will be able to access the FileList from the HTMLInputElement element, where they can get a base name and a size for each file.  
              These FileList Files can also be sent in an XMLHTTPRequest.
      
              * manual-tests/post-multi-file-upload.html: Added.
              * manual-tests/resources/multiFileResources: Added.
              * manual-tests/resources/multiFileResources/post-echo-and-notify-done.cgi: Added.
              * manual-tests/resources/multiFileResources/testFile1.html: Added.
              * manual-tests/resources/multiFileResources/testFile2.html: Added.
              * manual-tests/resources/multiFileResources/testFile3.html: Added.
      
              * WebCore.base.exp: Added support to export the new "chooseFilenames" method to be used in WebKit.
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::parseMappedAttribute): Add support for the multiple attribute.
              (WebCore::HTMLInputElement::value): Added comments.  The HTML5 spec says that value shouldn't apply for the file upload control,
              but we don't want to break the behavior for existing websites that may rely on this.
              (WebCore::HTMLInputElement::setValue): ditto.
              (WebCore::HTMLInputElement::setValueFromRenderer): This is no longer used for file upload controls. setFileListFromRenderer is used instead.
              (WebCore::HTMLInputElement::setFileListFromRenderer): Added. 
              * html/HTMLInputElement.h:
      
              * page/Chrome.cpp: (WebCore::Chrome::setToolTip): Show a tooltip with the file name list for the multi-file upload control.
      
              * page/DragController.cpp: (WebCore::DragController::concludeDrag): Updated to support multiple files.
      
              * platform/FileChooser.cpp: Add support for maintaining a list of file paths that can be retrieved by the renderer.
              (WebCore::FileChooser::FileChooser):
              (WebCore::FileChooser::create):
              (WebCore::FileChooser::clear):
              (WebCore::FileChooser::chooseFile):
              (WebCore::FileChooser::chooseFiles):
              (WebCore::FileChooser::chooseIcon):
              * platform/FileChooser.h:
              (WebCore::FileChooser::filePaths):
              (WebCore::FileChooser::allowsMultipleFiles):
      
              * platform/graphics/Icon.h:
              * platform/graphics/mac/IconMac.mm: (WebCore::Icon::newIconForFiles): Returns a generic icon for multiple files.
              * platform/graphics/gtk/IconGtk.cpp: (WebCore::Icon::newIconForFiles): stubbed out.
              * platform/graphics/qt/IconQt.cpp: (WebCore::Icon::newIconForFiles): ditto.
              * platform/graphics/win/IconWin.cpp: (WebCore::Icon::newIconForFiles): ditto.
      
              * platform/gtk/FileChooserGtk.cpp: (WebCore::FileChooser::basenameForWidth):  Updated to deal with new filenames vector.
              * platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): ditto.
              * platform/qt/FileChooserQt.cpp:
              (WebCore::FileChooser::openFileChooser):
              (WebCore::FileChooser::basenameForWidth):
              * platform/win/FileChooserWin.cpp: (WebCore::FileChooser::basenameForWidth):
      
              * platform/network/mac/FormDataStreamMac.mm: (WebCore::disassociateStreamWithResourceHandle):
              Removed unnecessary assertion.  This can get hit when connectionDidFinishLoading and cancel
              both get called for the same ResourceHandle.  This getting called twice has no negative effect.
      
              * rendering/RenderFileUploadControl.cpp:
              (WebCore::RenderFileUploadControl::valueChanged):  Calls setFileListFromRenderer.
              (WebCore::RenderFileUploadControl::allowsMultipleFiles):  Added.
              (WebCore::RenderFileUploadControl::updateFromElement):  Uses the new filenames call from FileChooser.
              (WebCore::RenderFileUploadControl::receiveDroppedFiles):  Updated to support multiple files.
              * rendering/RenderFileUploadControl.h:
      
      WebKit/mac:
      
      2008-10-24  Adele Peterson  <adele@apple.com>
      
              Reviewed by Sam Weinig.
      
              WebKit part of fix for <rdar://problem/5839256> FILE CONTROL: multi-file upload.
      
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::runOpenPanel):
              (-[WebOpenPanelResultListener chooseFilenames:]):
              * WebView/WebUIDelegate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      497541bd
    • timothy@apple.com's avatar
      Add a mechanism to store and retrieve preferences for the Web Inspector. · f454001b
      timothy@apple.com authored
      WebCore:
      
      2008-10-24  Timothy Hatcher  <timothy@apple.com>
      
              Add a mechanism to ask the InspectorClient for key/value setting pairs.
              These settings can be strings, numbers, booleans or string vectors. The
              settings are also bridged to and from JavaScript.
      
              https://bugs.webkit.org/show_bug.cgi?id=21856
      
              Reviewed by Darin Adler.
      
              * WebCore.base.exp: Expose the String CFStringRef constructor.
              * inspector/InspectorClient.h:
              (WebCore::InspectorClient::populateSetting): Added, pure virtual.
              (WebCore::InspectorClient::storeSetting): Ditto.
              (WebCore::InspectorClient::removeSetting): Ditto.
              * inspector/InspectorController.cpp:
              (WebCore::setting): Calls InspectorController::setting and wraps the result in script types.
              (WebCore::setSetting): Calls InspectorController::setSetting after converting from script types.
              (WebCore::InspectorController::InspectorController): Increment a global static
              to track the number of live InspectorControllers.
              (WebCore::InspectorController::~InspectorController): Decrement the global static
              that tracks the number of live InspectorControllers. Delete the setting cache if there
              are no more live controllers.
              (WebCore::InspectorController::setting): Check the cache and return the setting from there,
              otherwise make a new Setting and ask the client to populate it.
              (WebCore::InspectorController::setSetting): Change the cache and ask the client to store it.
              (WebCore::InspectorController::windowScriptObjectAvailable): Add setting and setSetting
              to the InspectorController script class.
              * inspector/InspectorController.h:
              (WebCore::InspectorController::Setting::Setting):
              (WebCore::InspectorController::Setting::operator=):
              (WebCore::InspectorController::Setting::type): Return m_type.
              (WebCore::InspectorController::Setting::string): Return m_string. Assert the type is correct.
              (WebCore::InspectorController::Setting::stringVector): Return m_stringVector.
              Assert the type is correct.
              (WebCore::InspectorController::Setting::doubleValue): Return m_simpleContent.m_double.
              Assert the type is correct.
              (WebCore::InspectorController::Setting::integerValue): Return m_simpleContent.m_integer.
              Assert the type is correct.
              (WebCore::InspectorController::Setting::booleanValue): Return m_simpleContent.m_boolean.
              Assert the type is correct.
              (WebCore::InspectorController::Setting::set): Overloaded for each data type, sets the right
              field and the type.
              * loader/EmptyClients.h:
              (WebCore::EmptyInspectorClient::populateSetting): Added, empty method.
              (WebCore::EmptyInspectorClient::storeSetting): Ditto.
              (WebCore::EmptyInspectorClient::removeSetting): Ditto.
      
      WebKit:
      
      2008-10-24  Timothy Hatcher  <timothy@apple.com>
      
              Implement new InspectorClient methods to work with Settings.
      
              https://bugs.webkit.org/show_bug.cgi?id=21856
      
              Reviewed by Darin Adler.
      
              * WebKit.xcodeproj/project.pbxproj: Add the new InspectorClientCF.cpp file.
      
      WebKit/gtk:
      
      2008-10-24  Timothy Hatcher  <timothy@apple.com>
      
              Stub out new InspectorClient methods.
      
              https://bugs.webkit.org/show_bug.cgi?id=21856
      
              Reviewed by Darin Adler.
      
              * WebCoreSupport/InspectorClientGtk.cpp:
              (WebKit::InspectorClient::populateSetting): Not implemented.
              (WebKit::InspectorClient::storeSetting): Ditto.
              (WebKit::InspectorClient::removeSetting): Ditto.
              * WebCoreSupport/InspectorClientGtk.h:
      
      WebKit/mac:
      
      2008-10-24  Timothy Hatcher  <timothy@apple.com>
      
              Implement new InspectorClient methods to work with Settings.
      
              https://bugs.webkit.org/show_bug.cgi?id=21856
      
              Reviewed by Darin Adler.
      
              * WebCoreSupport/WebInspectorClient.h: Add the new methods and
              guard the ObjC parts of the header.
      
      WebKit/qt:
      
      2008-10-24  Timothy Hatcher  <timothy@apple.com>
      
              Stub out new InspectorClient methods.
      
              https://bugs.webkit.org/show_bug.cgi?id=21856
      
              Reviewed by Darin Adler.
      
              * WebCoreSupport/InspectorClientQt.cpp:
              (WebCore::InspectorClientQt::populateSetting): Not implemented.
              (WebCore::InspectorClientQt::storeSetting): Ditto.
              (WebCore::InspectorClientQt::removeSetting): Ditto.
              * WebCoreSupport/InspectorClientQt.h:
      
      WebKit/win:
      
      2008-10-24  Timothy Hatcher  <timothy@apple.com>
      
              Implement new InspectorClient methods to work with Settings.
      
              https://bugs.webkit.org/show_bug.cgi?id=21856
      
              Reviewed by Adam Roben.
      
              * WebKit.vcproj/WebKit.vcproj: Add the new InspectorClientCF.cpp file.
              * WebCoreSupport/WebInspectorClient.h: Add the new methods.
      
      WebKit/wx:
      
      2008-10-24  Timothy Hatcher  <timothy@apple.com>
      
              Stub out new InspectorClient methods.
      
              https://bugs.webkit.org/show_bug.cgi?id=21856
      
              Reviewed by Darin Adler.
      
              * WebKitSupport/InspectorClientWx.cpp:
              (WebCore::InspectorClient::populateSetting): Not implemented.
              (WebCore::InspectorClient::storeSetting): Ditto.
              (WebCore::InspectorClient::removeSetting): Ditto.
              * WebKitSupport/InspectorClientWx.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f454001b
    • darin@apple.com's avatar
      JavaScriptCore: · 44331f8b
      darin@apple.com authored
      2008-10-24  Darin Adler  <darin@apple.com>
      
              - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
      
              * API/APICast.h:
              * API/JSCallbackConstructor.h:
              * API/JSCallbackFunction.cpp:
              * API/JSCallbackFunction.h:
              * API/JSCallbackObject.h:
              * API/JSCallbackObjectFunctions.h:
              * API/JSContextRef.cpp:
              * API/JSObjectRef.cpp:
              * API/JSValueRef.cpp:
              * VM/CTI.cpp:
              * VM/CTI.h:
              * VM/CodeBlock.cpp:
              * VM/CodeBlock.h:
              * VM/CodeGenerator.cpp:
              * VM/CodeGenerator.h:
              * VM/ExceptionHelpers.cpp:
              * VM/ExceptionHelpers.h:
              * VM/JSPropertyNameIterator.cpp:
              * VM/JSPropertyNameIterator.h:
              * VM/Machine.cpp:
              * VM/Machine.h:
              * VM/Register.h:
              * kjs/ArgList.cpp:
              * kjs/ArgList.h:
              * kjs/Arguments.cpp:
              * kjs/Arguments.h:
              * kjs/ArrayConstructor.cpp:
              * kjs/ArrayPrototype.cpp:
              * kjs/BooleanConstructor.cpp:
              * kjs/BooleanConstructor.h:
              * kjs/BooleanObject.h:
              * kjs/BooleanPrototype.cpp:
              * kjs/CallData.cpp:
              * kjs/CallData.h:
              * kjs/ConstructData.cpp:
              * kjs/ConstructData.h:
              * kjs/DateConstructor.cpp:
              * kjs/DateInstance.h:
              * kjs/DatePrototype.cpp:
              * kjs/DatePrototype.h:
              * kjs/DebuggerCallFrame.cpp:
              * kjs/DebuggerCallFrame.h:
              * kjs/ErrorConstructor.cpp:
              * kjs/ErrorPrototype.cpp:
              * kjs/ExecState.cpp:
              * kjs/ExecState.h:
              * kjs/FunctionConstructor.cpp:
              * kjs/FunctionPrototype.cpp:
              * kjs/FunctionPrototype.h:
              * kjs/GetterSetter.cpp:
              * kjs/GetterSetter.h:
              * kjs/InternalFunction.h:
              * kjs/JSActivation.cpp:
              * kjs/JSActivation.h:
              * kjs/JSArray.cpp:
              * kjs/JSArray.h:
              * kjs/JSCell.cpp:
              * kjs/JSCell.h:
              * kjs/JSFunction.cpp:
              * kjs/JSFunction.h:
              * kjs/JSGlobalData.h:
              * kjs/JSGlobalObject.cpp:
              * kjs/JSGlobalObject.h:
              * kjs/JSGlobalObjectFunctions.cpp:
              * kjs/JSGlobalObjectFunctions.h:
              * kjs/JSImmediate.cpp:
              * kjs/JSImmediate.h:
              * kjs/JSNotAnObject.cpp:
              * kjs/JSNotAnObject.h:
              * kjs/JSNumberCell.cpp:
              * kjs/JSNumberCell.h:
              * kjs/JSObject.cpp:
              * kjs/JSObject.h:
              * kjs/JSStaticScopeObject.cpp:
              * kjs/JSStaticScopeObject.h:
              * kjs/JSString.cpp:
              * kjs/JSString.h:
              * kjs/JSValue.h:
              * kjs/JSVariableObject.h:
              * kjs/JSWrapperObject.h:
              * kjs/MathObject.cpp:
              * kjs/MathObject.h:
              * kjs/NativeErrorConstructor.cpp:
              * kjs/NumberConstructor.cpp:
              * kjs/NumberConstructor.h:
              * kjs/NumberObject.cpp:
              * kjs/NumberObject.h:
              * kjs/NumberPrototype.cpp:
              * kjs/ObjectConstructor.cpp:
              * kjs/ObjectPrototype.cpp:
              * kjs/ObjectPrototype.h:
              * kjs/PropertyMap.h:
              * kjs/PropertySlot.cpp:
              * kjs/PropertySlot.h:
              * kjs/RegExpConstructor.cpp:
              * kjs/RegExpConstructor.h:
              * kjs/RegExpMatchesArray.h:
              * kjs/RegExpObject.cpp:
              * kjs/RegExpObject.h:
              * kjs/RegExpPrototype.cpp:
              * kjs/Shell.cpp:
              * kjs/StringConstructor.cpp:
              * kjs/StringObject.cpp:
              * kjs/StringObject.h:
              * kjs/StringObjectThatMasqueradesAsUndefined.h:
              * kjs/StringPrototype.cpp:
              * kjs/StructureID.cpp:
              * kjs/StructureID.h:
              * kjs/collector.cpp:
              * kjs/collector.h:
              * kjs/completion.h:
              * kjs/grammar.y:
              * kjs/interpreter.cpp:
              * kjs/interpreter.h:
              * kjs/lookup.cpp:
              * kjs/lookup.h:
              * kjs/nodes.h:
              * kjs/operations.cpp:
              * kjs/operations.h:
              * kjs/protect.h:
              * profiler/ProfileGenerator.cpp:
              * profiler/Profiler.cpp:
              * profiler/Profiler.h:
              Use JSValue* instead of JSValuePtr.
      
      JavaScriptGlue:
      
      2008-10-24  Darin Adler  <darin@apple.com>
      
              - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
      
              * JSObject.cpp:
              (nativeCallFunction):
              * JSUtils.cpp:
              (KJSValueToJSObject):
              (JSObjectKJSValue):
              (KJSValueToCFTypeInternal):
              (KJSValueToCFType):
              * JSUtils.h:
              * JSValueWrapper.cpp:
              (JSValueWrapper::JSValueWrapper):
              (JSValueWrapper::GetValue):
              (JSValueWrapper::JSObjectCopyProperty):
              (JSValueWrapper::JSObjectSetProperty):
              (JSValueWrapper::JSObjectCallFunction):
              * JSValueWrapper.h:
              * UserObjectImp.cpp:
              (UserObjectImp::callAsFunction):
              (UserObjectImp::userObjectGetter):
              (UserObjectImp::getOwnPropertySlot):
              (UserObjectImp::put):
              (UserObjectImp::toPrimitive):
              * UserObjectImp.h:
              (UserObjectImp::createStructureID):
              Use JSValue* instead of JSValuePtr.
      
      WebCore:
      
      2008-10-24  Darin Adler  <darin@apple.com>
      
              - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
      
              * bindings/js/JSAttrCustom.cpp:
              * bindings/js/JSCSSRuleCustom.cpp:
              * bindings/js/JSCSSStyleDeclarationCustom.cpp:
              * bindings/js/JSCSSValueCustom.cpp:
              * bindings/js/JSCanvasPixelArrayCustom.h:
              * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
              * bindings/js/JSClipboardCustom.cpp:
              * bindings/js/JSConsoleCustom.cpp:
              * bindings/js/JSCustomSQLStatementCallback.cpp:
              * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
              * bindings/js/JSCustomSQLTransactionCallback.cpp:
              * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
              * bindings/js/JSCustomVoidCallback.cpp:
              * bindings/js/JSCustomVoidCallback.h:
              * bindings/js/JSCustomXPathNSResolver.cpp:
              * bindings/js/JSCustomXPathNSResolver.h:
              * bindings/js/JSDOMApplicationCacheCustom.cpp:
              * bindings/js/JSDOMBinding.cpp:
              * bindings/js/JSDOMBinding.h:
              * bindings/js/JSDOMWindowBase.cpp:
              * bindings/js/JSDOMWindowBase.h:
              * bindings/js/JSDOMWindowCustom.cpp:
              * bindings/js/JSDOMWindowCustom.h:
              * bindings/js/JSDOMWindowShell.cpp:
              * bindings/js/JSDOMWindowShell.h:
              * bindings/js/JSDatabaseCustom.cpp:
              * bindings/js/JSDedicatedWorkerCustom.cpp:
              * bindings/js/JSDocumentCustom.cpp:
              * bindings/js/JSElementCustom.cpp:
              * bindings/js/JSEventCustom.cpp:
              * bindings/js/JSEventListener.cpp:
              * bindings/js/JSEventTarget.cpp:
              * bindings/js/JSEventTarget.h:
              * bindings/js/JSEventTargetBase.h:
              * bindings/js/JSEventTargetNodeCustom.cpp:
              * bindings/js/JSHTMLAllCollection.h:
              * bindings/js/JSHTMLAppletElementCustom.cpp:
              * bindings/js/JSHTMLCollectionCustom.cpp:
              * bindings/js/JSHTMLDocumentCustom.cpp:
              * bindings/js/JSHTMLEmbedElementCustom.cpp:
              * bindings/js/JSHTMLFormElementCustom.cpp:
              * bindings/js/JSHTMLFrameElementCustom.cpp:
              * bindings/js/JSHTMLFrameSetElementCustom.cpp:
              * bindings/js/JSHTMLIFrameElementCustom.cpp:
              * bindings/js/JSHTMLInputElementCustom.cpp:
              * bindings/js/JSHTMLObjectElementCustom.cpp:
              * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
              * bindings/js/JSHTMLSelectElementCustom.cpp:
              * bindings/js/JSHTMLSelectElementCustom.h:
              * bindings/js/JSHistoryCustom.cpp:
              * bindings/js/JSImageDataCustom.cpp:
              * bindings/js/JSInspectedObjectWrapper.cpp:
              * bindings/js/JSInspectedObjectWrapper.h:
              * bindings/js/JSInspectorCallbackWrapper.cpp:
              * bindings/js/JSInspectorCallbackWrapper.h:
              * bindings/js/JSJavaScriptCallFrameCustom.cpp:
              * bindings/js/JSLocationCustom.cpp:
              * bindings/js/JSMessagePortCustom.cpp:
              * bindings/js/JSMimeTypeArrayCustom.cpp:
              * bindings/js/JSNamedNodeMapCustom.cpp:
              * bindings/js/JSNamedNodesCollection.cpp:
              * bindings/js/JSNamedNodesCollection.h:
              * bindings/js/JSNavigatorCustom.cpp:
              * bindings/js/JSNodeCustom.cpp:
              * bindings/js/JSNodeFilterCondition.cpp:
              * bindings/js/JSNodeFilterCondition.h:
              * bindings/js/JSNodeFilterCustom.cpp:
              * bindings/js/JSNodeIteratorCustom.cpp:
              * bindings/js/JSNodeListCustom.cpp:
              * bindings/js/JSPluginArrayCustom.cpp:
              * bindings/js/JSPluginCustom.cpp:
              * bindings/js/JSPluginElementFunctions.cpp:
              * bindings/js/JSPluginElementFunctions.h:
              * bindings/js/JSQuarantinedObjectWrapper.cpp:
              * bindings/js/JSQuarantinedObjectWrapper.h:
              * bindings/js/JSRGBColor.cpp:
              * bindings/js/JSRGBColor.h:
              * bindings/js/JSSQLResultSetRowListCustom.cpp:
              * bindings/js/JSSQLTransactionCustom.cpp:
              * bindings/js/JSSVGElementInstanceCustom.cpp:
              * bindings/js/JSSVGLengthCustom.cpp:
              * bindings/js/JSSVGMatrixCustom.cpp:
              * bindings/js/JSSVGPathSegCustom.cpp:
              * bindings/js/JSSVGPathSegListCustom.cpp:
              * bindings/js/JSSVGPointListCustom.cpp:
              * bindings/js/JSSVGTransformListCustom.cpp:
              * bindings/js/JSStorageCustom.cpp:
              * bindings/js/JSStyleSheetCustom.cpp:
              * bindings/js/JSStyleSheetListCustom.cpp:
              * bindings/js/JSTextCustom.cpp:
              * bindings/js/JSTreeWalkerCustom.cpp:
              * bindings/js/JSXMLHttpRequestCustom.cpp:
              * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
              * bindings/js/JSXSLTProcessorCustom.cpp:
              * bindings/js/ScheduledAction.cpp:
              * bindings/js/ScheduledAction.h:
              * bindings/js/ScriptController.cpp:
              * bindings/js/ScriptController.h:
              * bindings/objc/WebScriptObject.mm:
              * bindings/objc/WebScriptObjectPrivate.h:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bridge/NP_jsobject.cpp:
              * bridge/c/c_instance.cpp:
              * bridge/c/c_instance.h:
              * bridge/c/c_runtime.cpp:
              * bridge/c/c_runtime.h:
              * bridge/c/c_utility.cpp:
              * bridge/c/c_utility.h:
              * bridge/jni/jni_instance.cpp:
              * bridge/jni/jni_instance.h:
              * bridge/jni/jni_jsobject.h:
              * bridge/jni/jni_jsobject.mm:
              * bridge/jni/jni_objc.mm:
              * bridge/jni/jni_runtime.cpp:
              * bridge/jni/jni_runtime.h:
              * bridge/jni/jni_utility.cpp:
              * bridge/jni/jni_utility.h:
              * bridge/objc/WebScriptObject.h:
              * bridge/objc/objc_class.h:
              * bridge/objc/objc_class.mm:
              * bridge/objc/objc_instance.h:
              * bridge/objc/objc_instance.mm:
              * bridge/objc/objc_runtime.h:
              * bridge/objc/objc_runtime.mm:
              * bridge/objc/objc_utility.h:
              * bridge/objc/objc_utility.mm:
              * bridge/qt/qt_class.cpp:
              * bridge/qt/qt_class.h:
              * bridge/qt/qt_instance.cpp:
              * bridge/qt/qt_instance.h:
              * bridge/qt/qt_runtime.cpp:
              * bridge/qt/qt_runtime.h:
              * bridge/runtime.cpp:
              * bridge/runtime.h:
              * bridge/runtime_array.cpp:
              * bridge/runtime_array.h:
              * bridge/runtime_method.cpp:
              * bridge/runtime_method.h:
              * bridge/runtime_object.cpp:
              * bridge/runtime_object.h:
              * bridge/testqtbindings.cpp:
              * inspector/JavaScriptCallFrame.cpp:
              * inspector/JavaScriptCallFrame.h:
              * inspector/JavaScriptProfile.cpp:
              * inspector/JavaScriptProfile.h:
              * inspector/JavaScriptProfileNode.cpp:
              * inspector/JavaScriptProfileNode.h:
              * loader/FrameLoader.cpp:
              * loader/FrameLoader.h:
              * page/Console.cpp:
              * page/Console.h:
              * plugins/MimeTypeArray.h:
              * plugins/Plugin.h:
              * plugins/PluginArray.h:
              * plugins/PluginView.cpp:
              * xml/XMLHttpRequest.cpp:
              Use JSValue* instead of JSValuePtr.
      
      WebKit/mac:
      
      2008-10-24  Darin Adler  <darin@apple.com>
      
              - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
      
              * WebView/WebFrame.mm:
              (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
              * WebView/WebScriptDebugDelegate.mm:
              (-[WebScriptCallFrame _convertValueToObjcValue:]):
              (-[WebScriptCallFrame exception]):
              (-[WebScriptCallFrame evaluateWebScript:]):
              * WebView/WebView.mm:
              (aeDescFromJSValue):
              (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
              Use JSValue* instead of JSValuePtr.
      
      WebKit/qt:
      
      2008-10-24  Darin Adler  <darin@apple.com>
      
              - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
      
              * Api/qwebframe.cpp:
              (QWebFrame::evaluateJavaScript): Use JSValue* instead of JSValuePtr.
      
      WebKit/win:
      
      2008-10-24  Darin Adler  <darin@apple.com>
      
              - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
      
              * WebScriptCallFrame.cpp:
              (WebScriptCallFrame::jsValueToString):
              (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString):
              (WebScriptCallFrame::valueForVariable):
              (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
              * WebScriptCallFrame.h:
              * WebView.cpp:
              (WebView::stringByEvaluatingJavaScriptFromString):
              Use JSValue* instead of JSValuePtr.
      
      WebKit/wx:
      
      2008-10-24  Darin Adler  <darin@apple.com>
      
              - finish rolling out https://bugs.webkit.org/show_bug.cgi?id=21732
      
              * WebFrame.cpp: (wxWebFrame::RunScript): Use JSValue* instead of JSValuePtr.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44331f8b
  7. 23 Oct, 2008 1 commit
  8. 20 Oct, 2008 2 commits
    • weinig@apple.com's avatar
      WebCore: · 5ed91735
      weinig@apple.com authored
      2008-10-20  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Remove FrameLoaderClient::detachedFromParent4.  It is no longer used by any port.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyFrameLoaderClient::detachedFromParent4):.
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::detachFromParent):
              * loader/FrameLoaderClient.h:
      
      WebKit/gtk:
      
      2008-10-20  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Remove FrameLoaderClient::detachedFromParent4.  It is no longer used by any port.
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              * WebCoreSupport/FrameLoaderClientGtk.h:
      
      WebKit/mac:
      
      2008-10-20  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Remove FrameLoaderClient::detachedFromParent4.  It is no longer used by any port.
      
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
      
      WebKit/qt:
      
      2008-10-20  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Remove FrameLoaderClient::detachedFromParent4.  It is no longer used by any port.
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              * WebCoreSupport/FrameLoaderClientQt.h:
      
      WebKit/win:
      
      2008-10-20  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Remove FrameLoaderClient::detachedFromParent4.  It is no longer used by any port.
      
              * WebFrame.cpp:
              * WebFrame.h:
      
      WebKit/wx:
      
      2008-10-20  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Anders Carlsson.
      
              Remove FrameLoaderClient::detachedFromParent4.  It is no longer used by any port.
      
              * WebKitSupport/FrameLoaderClientWx.cpp:
              * WebKitSupport/FrameLoaderClientWx.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37754 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ed91735
    • ap@webkit.org's avatar
      Reviewed by Oliver Hunt. · cf4aafb4
      ap@webkit.org authored
              <rdar://problem/6277777> REGRESSION (r36954): XMLHttpRequest not working when
              certain WebView delegate actions are taken
      
              * WebView/WebFrame.mm: (-[WebFrame _attachScriptDebugger]): Don't accidentally create
              a window shell if there is none yet.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf4aafb4
  9. 19 Oct, 2008 2 commits
    • darin@apple.com's avatar
      JavaScriptCore: · 989a6f84
      darin@apple.com authored
      2008-10-19  Darin Adler  <darin@apple.com>
      
              Reviewed by Oliver Hunt.
      
              - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
                improve performance by eliminating JSValue as a base class for JSCell
      
              Remove most uses of JSValue, which will be removed in a future patch.
      
              * VM/Machine.cpp:
              (JSC::fastToUInt32): Call toUInt32SlowCase function; no longer a member
              of JSValue.
              * kjs/JSNumberCell.h:
              (JSC::JSNumberCell::toInt32): Ditto.
              (JSC::JSNumberCell::toUInt32): Ditto.
      
              * kjs/JSValue.cpp:
              (JSC::toInt32SlowCase): Made a non-member function.
              (JSC::JSValue::toInt32SlowCase): Changed to call non-member function.
              (JSC::toUInt32SlowCase): More of the same.
              (JSC::JSValue::toUInt32SlowCase): Ditto.
      
              * kjs/JSValue.h: Moved static member function so they are no longer
              member functions at all.
      
              * VM/CTI.h: Removed forward declaration of JSValue.
              * VM/ExceptionHelpers.h: Ditto.
              * kjs/CallData.h: Ditto.
              * kjs/ConstructData.h: Ditto.
              * kjs/JSGlobalObjectFunctions.h: Ditto.
              * kjs/PropertyMap.h: Ditto.
              * kjs/StructureID.h: Ditto.
              * kjs/collector.h: Ditto.
              * kjs/completion.h: Ditto.
      
              * kjs/grammar.y:
              (JSC::makeBitwiseNotNode): Call new non-member toInt32 function.
              (JSC::makeLeftShiftNode): More of the same.
              (JSC::makeRightShiftNode): Ditto.
      
              * kjs/protect.h: Added a specialization for ProtectedPtr<JSValuePtr>
              so this can be used with JSValuePtr.
      
      JavaScriptGlue:
      
      2008-10-19  Darin Adler  <darin@apple.com>
      
              Reviewed by Oliver Hunt.
      
              - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
                improve performance by eliminating JSValue as a base class for JSCell
      
              Remove most uses of JSValue, which will be removed in a future patch.
      
              * JSValueWrapper.h: Use JSValuePtr instead of JSValue*.
      
      WebCore:
      
      2008-10-19  Darin Adler  <darin@apple.com>
      
              Reviewed by Oliver Hunt.
      
              - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
                improve performance by eliminating JSValue as a base class for JSCell
      
              Remove most uses of JSValue, which will be removed in a future patch.
      
              * bindings/js/JSCustomXPathNSResolver.h: Removed declaration of JSValue
              and used JSValuePtr instead.
              * bindings/js/JSEventTarget.h: Ditto.
              * bindings/js/JSNodeFilterCondition.h: Ditto.
              * bindings/js/ScheduledAction.h: Ditto.
              * bindings/js/ScriptController.h: Ditto.
              * bindings/objc/WebScriptObjectPrivate.h: Ditto.
              * bridge/c/c_utility.h: Ditto.
              * bridge/jni/jni_jsobject.h: Ditto.
              * bridge/jni/jni_utility.h: Ditto.
              * bridge/objc/WebScriptObject.h: Ditto.
              * dom/Traversal.h: Ditto.
              * inspector/InspectorController.cpp: Ditto.
              * inspector/JavaScriptProfile.h: Ditto.
              * inspector/JavaScriptProfileNode.h: Ditto.
              * loader/FrameLoader.h: Ditto.
              * page/Console.h: Ditto.
              * plugins/MimeTypeArray.h: Ditto.
              * plugins/Plugin.h: Ditto.
              * plugins/PluginArray.h: Ditto.
              * plugins/PluginView.cpp:
              (WebCore::getString): Ditto.
              (WebCore::PluginView::performRequest): Ditto.
              * plugins/gtk/PluginViewGtk.cpp: Ditto.
              * plugins/qt/PluginViewQt.cpp: Ditto.
              * plugins/win/PluginViewWin.cpp: Ditto.
      
              * bridge/qt/qt_class.cpp:
              (JSC::Bindings::QtClass::fallbackObject): Use JSValuePtr and JSObject*
              instead of JSValue*.
              * bridge/qt/qt_class.h: Ditto.
              * bridge/qt/qt_instance.cpp:
              (JSC::Bindings::QtInstance::mark): Ditto.
              (JSC::Bindings::QtInstance::invokeMethod): Ditto.
              (JSC::Bindings::QtInstance::defaultValue): Ditto.
              (JSC::Bindings::QtInstance::stringValue): Ditto.
              (JSC::Bindings::QtInstance::numberValue): Ditto.
              (JSC::Bindings::QtInstance::booleanValue): Ditto.
              (JSC::Bindings::QtInstance::valueOf): Ditto.
              (JSC::Bindings::QtField::valueFromInstance): Ditto.
              (JSC::Bindings::QtField::setValueToInstance): Ditto.
              * bridge/qt/qt_instance.h: Ditto.
              * bridge/qt/qt_runtime.cpp: Ditto.
              (JSC::Bindings::valueRealType): Ditto.
              (JSC::Bindings::convertValueToQVariant): Ditto.
              (JSC::Bindings::convertQVariantToValue): Ditto.
              (JSC::Bindings::findMethodIndex): Ditto.
              (JSC::Bindings::QtRuntimeMetaMethod::call): Ditto.
              (JSC::Bindings::QtRuntimeMetaMethod::lengthGetter): Ditto.
              (JSC::Bindings::QtRuntimeMetaMethod::connectGetter): Ditto.
              (JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter): Ditto.
              (JSC::Bindings::QtRuntimeConnectionMethod::call): Ditto.
              (JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter): Ditto.
              (JSC::Bindings::QtArray::setValueAt): Ditto.
              (JSC::Bindings::QtArray::valueAt): Ditto.
              * bridge/qt/qt_runtime.h: Ditto.
      
              * bridge/testqtbindings.cpp:
              (main): Use JSValuePtr.
      
      WebKit/mac:
      
      2008-10-19  Darin Adler  <darin@apple.com>
      
              Reviewed by Oliver Hunt.
      
              - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
                improve performance by eliminating JSValue as a base class for JSCell
      
              Remove most uses of JSValue, which will be removed in a future patch.
      
              * WebView/WebFrame.mm:
              (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
              Use JSValuePtr instead of JSValue.
              * WebView/WebScriptDebugger.h: Removed declaration of JSValue.
      
      WebKit/qt:
      
      2008-10-19  Darin Adler  <darin@apple.com>
      
              Reviewed by Oliver Hunt.
      
              - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
                improve performance by eliminating JSValue as a base class for JSCell
      
              Remove most uses of JSValue, which will be removed in a future patch.
      
              * Api/qwebframe.cpp:
              (QWebFrame::evaluateJavaScript): Use JSValuePtr.
      
      WebKit/win:
      
      2008-10-19  Darin Adler  <darin@apple.com>
      
              Reviewed by Oliver Hunt.
      
              - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
                improve performance by eliminating JSValue as a base class for JSCell
      
              Remove most uses of JSValue, which will be removed in a future patch.
      
              * WebScriptCallFrame.cpp:
              (WebScriptCallFrame::jsValueToString): Use JSValuePtr.
              (WebScriptCallFrame::stringByEvaluatingJavaScriptFromString): Ditto.
              (WebScriptCallFrame::valueForVariable): Put more code inside and ifdef.
              (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString): Ditto.
              * WebScriptCallFrame.h: Use JSValuePtr.
      
              * WebView.cpp:
              (WebView::stringByEvaluatingJavaScriptFromString): Use JSValuePtr.
      
      WebKit/wx:
      
      2008-10-19  Darin Adler  <darin@apple.com>
      
              Reviewed by Oliver Hunt.
      
              - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
                improve performance by eliminating JSValue as a base class for JSCell
      
              Remove most uses of JSValue, which will be removed in a future patch.
      
              * WebFrame.cpp:
              (wxWebFrame::RunScript): Use JSValuePtr.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      989a6f84
    • darin@apple.com's avatar
      JavaScriptCore: · 5c465b09
      darin@apple.com authored
      2008-10-18  Darin Adler  <darin@apple.com>
      
              Reviewed by Oliver Hunt.
      
              - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
                improve performance by eliminating JSValue as a base class for JSCell
      
              Tweak a little more to get closer to where we can make JSValuePtr a class.
      
              * API/APICast.h:
              (toJS): Change back to JSValue* here, since we're converting the
              pointer type.
              * VM/CTI.cpp:
              (JSC::CTI::unlinkCall): Call asPointer.
              * VM/CTI.h: Cast to JSValue* here, since it's a pointer cast.
              * kjs/DebuggerCallFrame.h:
              (JSC::DebuggerCallFrame::DebuggerCallFrame): Call noValue.
              * kjs/JSGlobalData.cpp:
              (JSC::JSGlobalData::JSGlobalData): Call noValue.
              * kjs/JSImmediate.cpp:
              (JSC::JSImmediate::toObject): Remove unneeded const_cast.
              * kjs/JSWrapperObject.h:
              (JSC::JSWrapperObject::JSWrapperObject): Call noValue.
      
      JavaScriptGlue:
      
      2008-10-18  Darin Adler  <darin@apple.com>
      
              Reviewed by Oliver Hunt.
      
              - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
                improve performance by eliminating JSValue as a base class for JSCell
      
              Tweak a little more to get closer to where we can make JSValuePtr a class.
      
              * JSObject.cpp:
              (nativeCallFunction): Call asObject.
      
              * JSUtils.cpp:
              (KJSValueToJSObject): Use JSValuePtr and asObject.
              (JSObjectKJSValue): Ditto.
              (KJSValueToCFTypeInternal): Ditto.
              (KJSValueToCFType): Ditto.
              * JSUtils.h: Ditto.
      
              * UserObjectImp.cpp:
              (UserObjectImp::callAsFunction): Use JSValuePtr and asObject.
              (UserObjectImp::userObjectGetter): Ditto.
              (UserObjectImp::getOwnPropertySlot): Ditto.
              (UserObjectImp::put): Ditto.
              (UserObjectImp::toPrimitive): Ditto.
              * UserObjectImp.h: Ditto.
      
      WebCore:
      
      2008-10-18  Darin Adler  <darin@apple.com>
      
              Reviewed by Oliver Hunt.
      
              - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
                improve performance by eliminating JSValue as a base class for JSCell
      
              Tweak a little more to get closer to where we can make JSValuePtr a class.
      
              * bindings/js/JSAudioConstructor.cpp:
              (WebCore::JSAudioConstructor::JSAudioConstructor): Use asObject.
              (WebCore::constructAudio): Ditto.
              * bindings/js/JSCSSStyleDeclarationCustom.cpp:
              (WebCore::JSCSSStyleDeclaration::nameGetter): Ditto.
      
              * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
              (WebCore::toHTMLCanvasStyle): Use asString and asObject.
              (WebCore::JSCanvasRenderingContext2D::setFillColor): Ditto.
              (WebCore::JSCanvasRenderingContext2D::setStrokeColor): Ditto.
              (WebCore::JSCanvasRenderingContext2D::drawImage): Ditto.
              (WebCore::JSCanvasRenderingContext2D::drawImageFromRect): Ditto.
              (WebCore::JSCanvasRenderingContext2D::setShadow): Ditto.
              (WebCore::JSCanvasRenderingContext2D::createPattern): Ditto.
      
              * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
              (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent): Use JSValuePtr.
      
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::setDOMException): Use noValue.
      
              * bindings/js/JSDOMBinding.h:
              (WebCore::getDOMPrototype): Use asObject.
      
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::showModalDialog): Use noValue.
              (jsDOMWindowBaseEvent): Use asObject.
              (jsDOMWindowBaseImage): Ditto.
              (jsDOMWindowBaseMessageChannel): Ditto.
              (jsDOMWindowBaseOption): Ditto.
              (jsDOMWindowBaseXMLHttpRequest): Ditto.
              (jsDOMWindowBaseAudio): Ditto.
              (jsDOMWindowBaseXSLTProcessor): Ditto.
              (WebCore::JSDOMWindowBase::childFrameGetter): Ditto.
              (WebCore::JSDOMWindowBase::indexGetter): Ditto.
              (WebCore::JSDOMWindowBase::namedItemGetter): Ditto.
              (WebCore::JSDOMWindowBase::getOwnPropertySlot): Ditto.
              (WebCore::JSDOMWindowBase::findJSEventListener): Ditto.
              (WebCore::JSDOMWindowBase::findOrCreateJSEventListener): Ditto.
              (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener): Ditto.
              (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener): Ditto.
              (windowProtoFuncOpen): Use noValue.
              (WebCore::toJSDOMWindow): Use asObject.
      
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::setTimeoutOrInterval): Use asString.
              (WebCore::toDOMWindow): Use asObject.
      
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSAbstractEventListener::handleEvent): Use noValue.
              (WebCore::JSLazyEventListener::parseCode): Use asObject.
      
              * bindings/js/JSHTMLCollectionCustom.cpp:
              (WebCore::JSHTMLCollection::nameGetter): Use asObject.
              * bindings/js/JSHTMLDocumentCustom.cpp:
              (WebCore::JSHTMLDocument::nameGetter): Ditto.
              * bindings/js/JSHTMLElementCustom.cpp:
              (WebCore::JSHTMLElement::pushEventHandlerScope): Ditto.
              * bindings/js/JSHTMLFormElementCustom.cpp:
              (WebCore::JSHTMLFormElement::nameGetter): Ditto.
              * bindings/js/JSHTMLFrameSetElementCustom.cpp:
              (WebCore::JSHTMLFrameSetElement::nameGetter): Ditto.
              * bindings/js/JSHTMLOptionElementConstructor.cpp:
              (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor): Ditto.
              (WebCore::constructHTMLOptionElement): Ditto.
              * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
              (WebCore::JSHTMLOptionsCollection::remove): Ditto.
              * bindings/js/JSImageConstructor.cpp:
              (WebCore::JSImageConstructor::JSImageConstructor): Ditto.
              (WebCore::constructImage): Ditto.
              * bindings/js/JSInspectedObjectWrapper.cpp:
              (WebCore::JSInspectedObjectWrapper::wrap): Ditto.
              * bindings/js/JSInspectorCallbackWrapper.cpp:
              (WebCore::JSInspectorCallbackWrapper::wrap): Ditto.
      
              * bindings/js/JSJavaScriptCallFrameCustom.cpp:
              (WebCore::JSJavaScriptCallFrame::evaluate): Use noValue.
      
              * bindings/js/JSMessageChannelConstructor.cpp:
              (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): Use asObject.
              (WebCore::JSMessageChannelConstructor::construct): Ditto.
              * bindings/js/JSMimeTypeArrayCustom.cpp:
              (WebCore::JSMimeTypeArray::nameGetter): Ditto.
              * bindings/js/JSNamedNodeMapCustom.cpp:
              (WebCore::JSNamedNodeMap::nameGetter): Ditto.
              * bindings/js/JSNamedNodesCollection.cpp:
              (WebCore::JSNamedNodesCollection::lengthGetter): Ditto.
              (WebCore::JSNamedNodesCollection::indexGetter): Ditto.
              * bindings/js/JSNodeFilterCustom.cpp:
              (WebCore::toNodeFilter): Ditto.
              * bindings/js/JSNodeListCustom.cpp:
              (WebCore::JSNodeList::nameGetter): Ditto.
              * bindings/js/JSPluginArrayCustom.cpp:
              (WebCore::JSPluginArray::nameGetter): Ditto.
              * bindings/js/JSPluginCustom.cpp:
              (WebCore::JSPlugin::nameGetter): Ditto.
              * bindings/js/JSPluginElementFunctions.cpp:
              (WebCore::runtimeObjectGetter): Ditto.
              (WebCore::runtimeObjectPropertyGetter): Ditto.
              * bindings/js/JSQuarantinedObjectWrapper.cpp:
              (WebCore::JSQuarantinedObjectWrapper::asWrapper): Ditto.
              (WebCore::JSQuarantinedObjectWrapper::getOwnPropertySlot): Ditto.
              (WebCore::JSQuarantinedObjectWrapper::construct): Ditto.
              * bindings/js/JSRGBColor.cpp:
              (jsRGBColorRed): Ditto.
              (jsRGBColorGreen): Ditto.
              (jsRGBColorBlue): Ditto.
      
              * bindings/js/JSSQLResultSetRowListCustom.cpp:
              (WebCore::JSSQLResultSetRowList::item): Use noValue.
      
              * bindings/js/JSStorageCustom.cpp:
              (WebCore::JSStorage::nameGetter): Use asObject.
              (WebCore::JSStorage::deleteProperty): Ditto.
              (WebCore::JSStorage::customPut): Ditto.
              * bindings/js/JSStyleSheetListCustom.cpp:
              (WebCore::JSStyleSheetList::nameGetter): Ditto.
              * bindings/js/JSXMLHttpRequestConstructor.cpp:
              (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): Ditto.
              * bindings/js/JSXSLTProcessorCustom.cpp:
              (WebCore::JSXSLTProcessor::importStylesheet): Ditto.
              (WebCore::JSXSLTProcessor::transformToFragment): Ditto.
              (WebCore::JSXSLTProcessor::transformToDocument): Ditto.
      
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::evaluate): Use noValue.
              * bindings/objc/DOMInternal.mm:
              (-[WebScriptObject _initializeScriptDOMNodeImp]): Ditto.
      
              * bindings/objc/WebScriptObject.mm:
              (-[WebScriptObject evaluateWebScript:]): Use JSValuePtr.
              (-[WebScriptObject valueForKey:]): Ditto.
              (-[WebScriptObject webScriptValueAtIndex:]): Ditto.
              (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
              Use asObject and asString.
      
              * bindings/scripts/CodeGeneratorJS.pm: Use asObject.
      
              * bridge/c/c_instance.h: Use JSValuePtr.
              * bridge/c/c_runtime.cpp:
              (JSC::Bindings::CField::setValueToInstance): Ditto.
      
              * bridge/c/c_utility.cpp:
              (JSC::Bindings::convertValueToNPVariant): Use asObject.
      
              * bridge/jni/jni_instance.cpp:
              (JavaInstance::booleanValue): Use JSValuePtr.
              (JavaInstance::invokeMethod): Ditto. And noValue.
              * bridge/jni/jni_jsobject.mm:
              (JavaJSObject::getSlot): Ditto.
              (JavaJSObject::convertValueToJObject): Ditto.
              * bridge/jni/jni_runtime.cpp:
              (JavaField::dispatchValueFromInstance): Ditto.
              (JavaField::valueFromInstance): Ditto.
              (JavaField::dispatchSetValueToInstance): Ditto.
              (JavaField::setValueToInstance): Ditto.
              (JavaArray::setValueAt): Ditto.
              (JavaArray::valueAt): Ditto.
              * bridge/jni/jni_runtime.h: Ditto.
      
              * bridge/jni/jni_utility.cpp:
              (JSC::Bindings::convertArrayInstanceToJavaArray): Take a JSArray*
              instead of a JSValue*.
              (JSC::Bindings::convertValueToJValue): Use asObject and asArray.
      
              * bridge/objc/objc_class.h: Use JSValuePtr.
              * bridge/objc/objc_instance.h: Ditto.
              * bridge/objc/objc_runtime.h: Ditto.
      
              * bridge/objc/objc_runtime.mm:
              (JSC::Bindings::callObjCFallbackObject): Use asObject.
      
              * bridge/objc/objc_utility.h: Use JSValuePtr.
              * bridge/objc/objc_utility.mm:
              (JSC::Bindings::convertValueToObjcValue): Use JSValuePtr and asObject.
              (JSC::Bindings::convertObjcValueToValue): Use jsUndefined() instead of 0.
      
              * bridge/runtime.cpp:
              (JSC::Bindings::Instance::getValueOfField): Use JSValuePtr.
              (JSC::Bindings::Instance::setValueOfField): Ditto.
      
              * bridge/runtime_array.cpp:
              (JSC::RuntimeArray::lengthGetter): Use JSValuePtr and asObject.
              (JSC::RuntimeArray::indexGetter): Ditto.
              * bridge/runtime_array.h: Ditto.
              * bridge/runtime_method.cpp:
              (JSC::RuntimeMethod::lengthGetter): Ditto.
              (JSC::callRuntimeMethod): Ditto.
              * bridge/runtime_object.cpp:
              (JSC::RuntimeObjectImp::fallbackObjectGetter): Ditto.
              (JSC::RuntimeObjectImp::fieldGetter): Ditto.
              (JSC::RuntimeObjectImp::methodGetter): Ditto.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::executeScript): Use noValue.
      
              * page/Console.cpp:
              (WebCore::Console::trace): Use asInternalFunction.
      
      WebKit/mac:
      
      2008-10-18  Darin Adler  <darin@apple.com>
      
              Reviewed by Oliver Hunt.
      
              - next step of https://bugs.webkit.org/show_bug.cgi?id=21732
                improve performance by eliminating JSValue as a base class for JSCell
      
              Tweak a little more to get closer to where we can make JSValuePtr a class.
      
              * WebView/WebScriptDebugDelegate.mm:
              (-[WebScriptCallFrame _convertValueToObjcValue:]): Use JSValuePtr.
              (-[WebScriptCallFrame exception]): Ditto.
              (-[WebScriptCallFrame evaluateWebScript:]): Ditto. And noValue.
              * WebView/WebScriptDebugger.mm:
              (WebScriptDebugger::WebScriptDebugger): Use new DebuggerCallFrame
              constructor that doesn't require explicitly passing an exception.
              * WebView/WebView.mm:
              (aeDescFromJSValue): Use JSValuePtr.
              (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c465b09
  10. 18 Oct, 2008 1 commit
    • mitz@apple.com's avatar
      WebCore: · 3076b4b5
      mitz@apple.com authored
              Reviewed by Sam Weinig.
      
              - WebCore part of https://bugs.webkit.org/show_bug.cgi?id=21736
                Long-dead decoded image data make up for most of the object cache's memory use over time
      
              Add a cache setting for how long decoded image data should be allowed to
              persist in memory after the image has died. By default, this is set to
              0, which means "forever".
      
              * loader/Cache.cpp:
              (WebCore::Cache::Cache): Initialize m_deadDecodedDataDeletionInterval.
              * loader/Cache.h:
              (WebCore::Cache::setDeadDecodedDataDeletionInterval): Added a setter.
              (WebCore::Cache::deadDecodedDataDeletionInterval): Added a getter.
              * loader/CachedImage.cpp:
              (WebCore::CachedImage::CachedImage): Initialize the decoded data
              deletion timer.
              (WebCore::CachedImage::decodedDataDeletionTimerFired): Added. Destroys
              the decoded image data.
              (WebCore::CachedImage::addClient): Stop the timer if it is active.
              (WebCore::CachedImage::allClientsRemoved): Start the decoded data
              deletion timer.
              * loader/CachedImage.h:
      
      WebKit/mac:
      
              Reviewed by Sam Weinig.
      
              - WebKit/mac part of https://bugs.webkit.org/show_bug.cgi?id=21736
                Long-dead decoded image data make up for most of the object cache's memory use over time
      
              * WebView/WebView.mm:
              (+[WebView _setCacheModel:]): In the primary web browser model, set the
              cache's dead decoded data deletion interval to 60 seconds.
      
      WebKit/win:
      
      2008-10-18  Dan Bernstein  <mitz@apple.com>
      
              Reviewed by Sam Weinig.
      
              - WebKit/win part of https://bugs.webkit.org/show_bug.cgi?id=21736
                Long-dead decoded image data make up for most of the object cache's memory use over time
      
              * WebView.cpp:
              (WebView::setCacheModel): In the primary web browser model,
              set the cache's dead decoded data deletion interval to 60 seconds.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3076b4b5
  11. 15 Oct, 2008 6 commits
    • mrowe@apple.com's avatar
      Fix a leak of a CFStringRef reported by the build bot. · 35b0f0eb
      mrowe@apple.com authored
      Reviewed by Jon Honeycutt.
      
      * Plugins/WebBaseNetscapePluginView.mm:
      (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]): Use a autoreleased
      NSString rather than manually releasing a CFStringRef when we're done with it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35b0f0eb
    • andersca@apple.com's avatar
      2008-10-15 Kenneth Russell <kenneth.russell@sun.com> · 089de61a
      andersca@apple.com authored
              Reviewed and landed by Anders Carlsson.
      
              https://bugs.webkit.org/show_bug.cgi?id=21572
              
              Initialize pluginFunc.size to the correct size before calling NP_GetEntryPoints.
              
              * Plugins/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage load]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      089de61a
    • mrowe@apple.com's avatar
      <rdar://problem/6272508> Crash occurs after loading flash content at http://www.macrumors.com/ · 44da9185
      mrowe@apple.com authored
      Restore some code related to the CoreGraphics drawing model that was misplaced in r37131.
      
      Reviewed by Dan Bernstein.
      
      * Plugins/WebBaseNetscapePluginView.mm:
      (-[WebBaseNetscapePluginView invalidateRegion:]):
      (-[WebBaseNetscapePluginView setVariable:value:]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44da9185
    • ggaren@apple.com's avatar
      JavaScriptCore: · 9f98034f
      ggaren@apple.com authored
      2008-10-15  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Cameron Zwarich.
      
              Fixed https://bugs.webkit.org/show_bug.cgi?id=21345
              Start the debugger without reloading the inspected page
      
              * JavaScriptCore.exp: New symbols.
              * JavaScriptCore.xcodeproj/project.pbxproj: New files.
      
              * VM/CodeBlock.h:
              (JSC::EvalCodeCache::get): Updated for tweak to parsing API.
      
              * kjs/CollectorHeapIterator.h: Added. An iterator for the object heap,
              which we use to find all the live functions and recompile them.
      
              * kjs/DebuggerCallFrame.cpp:
              (JSC::DebuggerCallFrame::evaluate): Updated for tweak to parsing API.
      
              * kjs/FunctionConstructor.cpp:
              (JSC::constructFunction): Updated for tweak to parsing API.
      
              * kjs/JSFunction.cpp:
              (JSC::JSFunction::JSFunction): Try to validate our SourceCode in debug
              builds by ASSERTing that it's syntactically valid. This doesn't catch
              all SourceCode bugs, but it catches a lot of them.
      
              * kjs/JSGlobalObjectFunctions.cpp:
              (JSC::globalFuncEval): Updated for tweak to parsing API.
      
              * kjs/Parser.cpp:
              (JSC::Parser::parse):
              * kjs/Parser.h:
              (JSC::Parser::parse): Tweaked the parser to make it possible to parse
              without an ExecState, and to allow the client to specify a debugger to
              notify (or not) about the source we parse. This allows the inspector
              to recompile even though no JavaScript is executing, then notify the
              debugger about all source code when it's done.
      
              * kjs/Shell.cpp:
              (prettyPrintScript): Updated for tweak to parsing API.
      
              * kjs/SourceRange.h:
              (JSC::SourceCode::isNull): Added to help with ASSERTs.
      
              * kjs/collector.cpp:
              (JSC::Heap::heapAllocate):
              (JSC::Heap::sweep):
              (JSC::Heap::primaryHeapBegin):
              (JSC::Heap::primaryHeapEnd):
              * kjs/collector.h:
              (JSC::): Moved a bunch of declarations around to enable compilation of
              CollectorHeapIterator.
      
              * kjs/interpreter.cpp:
              (JSC::Interpreter::checkSyntax):
              (JSC::Interpreter::evaluate): Updated for tweak to parsing API.
      
              * kjs/lexer.h:
              (JSC::Lexer::sourceCode): BUG FIX: Calculate SourceCode ranges relative
              to the SourceCode range in which we're lexing, otherwise nested functions
              that are compiled individually get SourceCode ranges that don't reflect
              their nesting.
      
              * kjs/nodes.cpp:
              (JSC::FunctionBodyNode::FunctionBodyNode):
              (JSC::FunctionBodyNode::finishParsing):
              (JSC::FunctionBodyNode::create):
              (JSC::FunctionBodyNode::copyParameters):
              * kjs/nodes.h:
              (JSC::ScopeNode::setSource):
              (JSC::FunctionBodyNode::parameterCount): Added some helper functions for
              copying one FunctionBodyNode's parameters to another. The recompiler uses
              these when calling "finishParsing".
      
      WebCore:
      
      2008-10-15  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Cameron Zwarich.
      
              Fixed https://bugs.webkit.org/show_bug.cgi?id=21345
              Start the debugger without reloading the inspected page
      
              * WebCore.base.exp: New symbols.
      
              * ForwardingHeaders/kjs/CollectorHeapIterator.h: Copied from ForwardingHeaders/kjs/ustring.h.
              * ForwardingHeaders/kjs/Parser.h: Copied from ForwardingHeaders/kjs/ustring.h.
              * WebCore.xcodeproj/project.pbxproj: New forwarding headers.
      
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::setWindowVisible):
              (WebCore::InspectorController::windowScriptObjectAvailable):
              (WebCore::InspectorController::startDebugging):
              * inspector/InspectorController.h: Renamed startDebuggingAndReloadInspectedPage
              to startDebugging, and changed its behavior to match.
      
              * inspector/JavaScriptDebugListener.h:
              * inspector/JavaScriptDebugServer.cpp:
              (WebCore::JavaScriptDebugServer::JavaScriptDebugServer):
              (WebCore::JavaScriptDebugServer::addListener):
              (WebCore::JavaScriptDebugServer::removeListener):
              (WebCore::JavaScriptDebugServer::recompileAllJSFunctions):
              (WebCore::JavaScriptDebugServer::willAddFirstListener):
              (WebCore::JavaScriptDebugServer::didRemoveLastListener):
              * inspector/JavaScriptDebugServer.h: Refactored the
              JavaScriptDebugServer to centralize handling of adding the first listener
              and removing the last. Then, added a feature to recompile all JS functions
              in these cases. This allows us to dynamically add and remove hooks like
              the debugger hooks without reloading the page.
      
              * inspector/front-end/ScriptsPanel.js:
              * English.lproj/localizedStrings.js: Updated for startDebuggingAndReloadInspectedPage =>
              startDebugging rename. Removed all UI that claimed that starting the
              debugger would reload the page.
      
      WebKit/mac:
      
      2008-10-15  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Cameron Zwarich.
      
              Fixed https://bugs.webkit.org/show_bug.cgi?id=21345
              Start the debugger without reloading the inspected page
      
              * WebInspector/WebInspector.mm:
              (-[WebInspector startDebuggingJavaScript:]): Updated for rename.
      
      WebKit/win:
      
      2008-10-15  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Cameron Zwarich.
      
              Fixed https://bugs.webkit.org/show_bug.cgi?id=21345
              Start the debugger without reloading the inspected page
      
              * WebInspector.cpp:
              (WebInspector::toggleDebuggingJavaScript): Updated for rename.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f98034f
    • bdakin@apple.com's avatar
      WebCore: · cf22dbac
      bdakin@apple.com authored
      2008-10-14  Maxime Britto  <britto@apple.com>
      
              Reviewed by Darin Adler, tweaked and landed by Beth.
      
              * WebCore.base.exp: Exposes two functions to be able to create a 
              selection from a point on the screen. Also exposes the new 
              TextIterator::currentNode function.
              * WebCore/editing/TextIterator.cpp:
              (TextIterator::currentNode) : New function that returns the current 
              text node or NULL if there is no text node.
      
      WebKit:
      
      2008-10-14  Maxime Britto  <britto@apple.com>
      
              Reviewed by Darin Adler.
      
              * WebKit.xcodeproj/project.pbxproj: Added two files for the 
              WebTextIterator, and made the WebTextIterator.h private
      
      WebKit/mac:
      
      2008-10-14  Maxime Britto  <britto@apple.com>
      
              Reviewed by Darin Adler.
      
              Added SPI to use WebCore's TextIterator with WebKit.
      
              * WebView/WebTextIterator.h: Added.
              * WebView/WebTextIterator.mm: Added.
              (-[WebTextIteratorPrivate dealloc]):
              (-[WebTextIterator dealloc]):
              (-[WebTextIterator initWithRange:]): Creates a TextIterator 
              instance
              (-[WebTextIterator advance]): Asks the iterator to advance() .
              (-[WebTextIterator currentNode]): Returns the current DOMNode from 
              the iterator
              (-[WebTextIterator currentText]): Returns the current text from the 
              iterator
              (-[WebTextIterator atEnd]): Indicated whether the iterator has 
              reached the end of the range.
              * WebView/WebView.h:
              * WebView/WebView.mm:
              (-[WebView textIteratorForRect:]): Returns a WebTextIterator with 
              the DOMRange contained in the rectangle given as a parameter.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf22dbac
    • timothy@apple.com's avatar
      Clean up user agent generation to simplify the _standardUserAgentWithApplicationName: · 497ea93c
      timothy@apple.com authored
              class method to not require a WebKit version.
      
              Reviewed by Darin Adler.
      
              * WebView/WebView.mm:
              (+[WebView _standardUserAgentWithApplicationName:]): Create the WebKit version.
              (-[WebView WebCore::_userAgentForURL:]): Use the simplified _standardUserAgentWithApplicationName:.
              Remove code that created the WebKit version.
              * WebView/WebViewPrivate.h: Change the method name of _standardUserAgentWithApplicationName:.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      497ea93c
  12. 14 Oct, 2008 1 commit
    • timothy@apple.com's avatar
      Make the user agent generation method a class method and cache the WebKit · 1f58664f
      timothy@apple.com authored
              version in a static to prevent generating it every time. This is needed
              clean up to fix <rdar://problem/6292331>. Moved all code to WebPrivate so
              the class method can be in the WebViewPrivate.h header.
      
              Reviewed by John Sullivan.
      
              * WebView/WebView.mm:
              (callGestalt): Moved. Same code.
              (createMacOSXVersionString): Moved. Same code.
              (createUserVisibleWebKitVersionString): Moved from _userVisibleBundleVersionFromFullVersion:
              and returns a copied string.
              (+[WebView _standardUserAgentWithApplicationName:andWebKitVersion:]): Made into a class method.
              (-[WebView WebCore::_userAgentForURL:]): Changed to cache the WebKit version.
              * WebView/WebViewPrivate.h: Added +_standardUserAgentWithApplicationName:andWebKitVersion:.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f58664f
  13. 13 Oct, 2008 1 commit
    • mjs@apple.com's avatar
      JavaScriptCore: · 268962eb
      mjs@apple.com authored
      2008-10-13  Maciej Stachowiak  <mjs@apple.com>
      
              Rubber stamped by Mark Rowe.
              
              - fixed <rdar://problem/5806316> JavaScriptCore should not force building with gcc 4.0
              - use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
      
              * Configurations/DebugRelease.xcconfig:
              * JavaScriptCore.xcodeproj/project.pbxproj:
      
      JavaScriptGlue:
      
      2008-10-13  Maciej Stachowiak  <mjs@apple.com>
      
              Rubber stamped by Mark Rowe.
              
              - use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
      
              * Configurations/DebugRelease.xcconfig:
      
      WebCore:
      
      2008-10-13  Maciej Stachowiak  <mjs@apple.com>
      
              Rubber stamped by Mark Rowe.
              
              - use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
      
              * Configurations/DebugRelease.xcconfig:
      
      WebKit/mac:
      
      2008-10-13  Maciej Stachowiak  <mjs@apple.com>
      
              Rubber stamped by Mark Rowe.
              
              - use gcc 4.2 when building with Xcode 3.1 or newer on Leopard, even though this is not the default
      
              * Configurations/DebugRelease.xcconfig:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      268962eb
  14. 11 Oct, 2008 1 commit
    • mitz@apple.com's avatar
      WebCore: · f0f7ed8e
      mitz@apple.com authored
              Reviewed by Sam Weinig.
      
              - rename WebCoreSetAlwaysUseATSU to WebCoreSetAlwaysUsesComplexTextCodePath
                and add a corresponding getter; add the same functions on Windows
      
              * WebCore.base.exp:
              * platform/graphics/Font.cpp:
              (WebCore::Font::setCodePath):
              (WebCore::codePath):
              (WebCore::Font::canUseGlyphCache):
              * platform/graphics/Font.h:
              * platform/mac/WebCoreTextRenderer.h:
              * platform/mac/WebCoreTextRenderer.mm:
              (WebCoreSetAlwaysUsesComplexTextCodePath):
              (WebCoreAlwaysUsesComplexTextCodePath):
              * platform/win/WebCoreTextRenderer.cpp:
              (WebCore::WebCoreSetAlwaysUsesComplexTextCodePath):
              (WebCore::WebCoreAlwaysUsesComplexTextCodePath):
              * platform/win/WebCoreTextRenderer.h:
      
      WebKit/mac:
      
              Reviewed by Sam Weinig.
      
              - rename _setAlwaysUseATSU to _setAlwaysUsesComplexTextCodePath and
                update it for the renamed WebCoreTextRenderer method; keep the old
                method around for clients that use it
      
              * WebView/WebView.mm:
              (+[WebView _setAlwaysUseATSU:]):
              (+[WebView _setAlwaysUsesComplexTextCodePath:]):
              * WebView/WebViewPrivate.h:
      
      WebKit/win:
      
              Reviewed by Sam Weinig.
      
              - add SPI for forcing the complex text code path to be used for all text
      
              * Interfaces/IWebViewPrivate.idl:
              * WebView.cpp:
              (WebView::setAlwaysUsesComplexTextCodePath):
              (WebView::alwaysUsesComplexTextCodePath):
              * WebView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0f7ed8e
  15. 09 Oct, 2008 1 commit
    • timothy@apple.com's avatar
      Annotate the Objective-C DOM APIs with the JavaScriptCore/WebKitAvailability.h... · 746258bd
      timothy@apple.com authored
      Annotate the Objective-C DOM APIs with the JavaScriptCore/WebKitAvailability.h availability macros and version macros.
      
      WebCore:
      
      2008-10-09  Timothy Hatcher  <timothy@apple.com>
      
              Annotate the Objective-C DOM APIs with the JavaScriptCore/WebKitAvailability.h
              availability macros and version macros.
      
              https://bugs.webkit.org/show_bug.cgi?id=21496
              rdar://problem/6259225
      
              Reviewed by Sam Weinig.
      
              * bindings/objc/DOMCSS.h: Add a version #if around catgory interface.
              * bindings/objc/DOMEventException.h: Include JavaScriptCore/WebKitAvailability.h
              and add an #if around the enum.
              * bindings/objc/DOMException.h: Ditto. Give the enum a name and remove the
              comment to match the other headers.
              * bindings/objc/DOMExtensions.h: Annotate the methods with version 3.0 or later.
              * bindings/objc/DOMObject.h: Add a version #if around class interface.
              * bindings/objc/DOMRangeException.h: Include JavaScriptCore/WebKitAvailability.h
              and add a version #if around the enum.
              * bindings/objc/DOMSVGException.h: Ditto. Use the latest version since SVG is new.
              * bindings/objc/DOMXPathException.h: Ditto. Use the 3.0 version.
              * bindings/objc/PublicDOMInterfaces.h: Annotate classes and protocols for
              when they where added to WebKit. Also annotate individual methods that are
              deprecated or where added after the class was added to WebKit.
              * bindings/objc/WebScriptObject.h: Include JavaScriptCore/WebKitAvailability.h
              since this header is included by most DOM headers. Annotate the JSObject method.
      
              * bindings/scripts/CodeGeneratorObjC.pm:
              (ReadPublicInterfaces): Parse out the availability macro for each function/property.
              And parse out the availability version for the class/protocol. Default to
              WEBKIT_VERSION_LATEST if the class is new.
              (GenerateHeader): Include JavaScriptCore/WebKitAvailability.h if needed. Add the
              interface availability version check if the class has a required version. Create
              a public interface key (used to lookup in $publicInterfaces) and make a declaration
              suffix that includes the availability macro (if needed). Use the "available in 1.3
              and later but deprecated in 3.0" macro instead of "deprecated in 10.5 and later" as
              the default availability macro for old style methods. Tweak line breaks in the generated
              headers to look good and not have too many extra lines.
      
      WebKit/mac:
      
      2008-10-09  Timothy Hatcher  <timothy@apple.com>
      
              Don't convert JavaScriptCore header include paths to WebKit paths. This was needed
              back when NPAPI and WebScriptObject migrated from JavaScriptCore. Also remove
              JavaScriptCore from the VPATH.
      
              Reviewed by Sam Weinig.
      
              * MigrateHeaders.make:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      746258bd