1. 30 Oct, 2008 11 commits
    • andersca@apple.com's avatar
      2008-10-29 Anders Carlsson <andersca@apple.com> · cd79e263
      andersca@apple.com authored
              Reviewed by Kevin Decker.
      
              * Plugins/WebBaseNetscapePluginStream.h:
              * Plugins/WebBaseNetscapePluginStream.mm:
              (WebNetscapePluginStream::WebNetscapePluginStream):
              (WebNetscapePluginStream::~WebNetscapePluginStream):
              (WebNetscapePluginStream::start):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38002 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd79e263
    • alp@webkit.org's avatar
      2008-10-30 Dirk Schulze <vbs85@gmx.de> · 3d557520
      alp@webkit.org authored
              Reviewed by Alp Toker.
      
              https://bugs.webkit.org/show_bug.cgi?id=21883
              [CAIRO] globalAlpha has to be stored and restored
      
              Cairo's globalAlpha has to be stored and reloaded on calling
              save() and restore(). We use the power of GraphicsContextState for this.
      
              * platform/graphics/GraphicsContextPrivate.h:
              (WebCore::GraphicsContextState::GraphicsContextState):
              * platform/graphics/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::fillPath):
              (WebCore::GraphicsContext::strokePath):
              (WebCore::GraphicsContext::setAlpha):
              (WebCore::GraphicsContext::getAlpha):
              * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
              (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38001 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d557520
    • alp@webkit.org's avatar
      2008-10-30 Alp Toker <alp@nuanti.com> · bb133e2f
      alp@webkit.org authored
              Rubber-stamped by Holger Freyther.
      
              Fix typo in recently added web inspector signal. dettach -> detach.
      
              * WebCoreSupport/InspectorClientGtk.cpp:
              (WebKit::InspectorClient::detachWindow):
              * webkit/webkitwebinspector.cpp:
              (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@38000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb133e2f
    • alp@webkit.org's avatar
      7180810c
    • alp@webkit.org's avatar
      Try naming VoidPtrPair struct to fix old gcc/MSVC builds · 246f439d
      alp@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      246f439d
    • alp@webkit.org's avatar
      2008-10-30 Alp Toker <alp@nuanti.com> · 127ac827
      alp@webkit.org authored
              Build fix attempt for older gcc on the trunk-mac-intel build bot
              (error: initializer for scalar variable requires one element).
      
              Modify the initializer syntax slightly with an additional comma.
      
              * VM/Machine.cpp:
              (JSC::Machine::cti_op_call_JSFunction):
              (JSC::Machine::cti_op_construct_JSConstruct):
              (JSC::Machine::cti_op_resolve_func):
              (JSC::Machine::cti_op_post_inc):
              (JSC::Machine::cti_op_resolve_with_base):
              (JSC::Machine::cti_op_post_dec):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      127ac827
    • alp@webkit.org's avatar
      2008-10-30 Alp Toker <alp@nuanti.com> · eb261eb5
      alp@webkit.org authored
              Rubber-stamped by Oliver Hunt.
      
              autotools build system change to enable JIT features by default. Can
              be disabled with --disable-jit (and is disabled automatically on
              unsupported platforms).
      
              * configure.ac:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37996 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb261eb5
    • alp@webkit.org's avatar
      2008-10-30 Alp Toker <alp@nuanti.com> · 5df2ad5d
      alp@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              https://bugs.webkit.org/show_bug.cgi?id=21571
              VoidPtrPair breaks CTI on Linux
      
              The VoidPtrPair return change made in r37457 does not work on Linux
              since POD structs aren't passed in registers.
      
              This patch uses a union to vectorize VoidPtrPair to a uint64_t and
              matches Darwin/MSVC fixing CTI/WREC on Linux.
      
              Alexey reports no measurable change in Mac performance with this fix.
      
              * VM/Machine.cpp:
              (JSC::Machine::cti_op_call_JSFunction):
              (JSC::Machine::cti_op_construct_JSConstruct):
              (JSC::Machine::cti_op_resolve_func):
              (JSC::Machine::cti_op_post_inc):
              (JSC::Machine::cti_op_resolve_with_base):
              (JSC::Machine::cti_op_post_dec):
              * VM/Machine.h:
              (JSC::):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37995 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5df2ad5d
    • ap@webkit.org's avatar
      Finish landing the previous renaming,... · 5f5cd22a
      ap@webkit.org authored
      Finish landing the previous renaming, createInlineEventHandler->createInlineEventListener (the files remained unsaved in Xcode).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37994 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f5cd22a
    • ap@webkit.org's avatar
      Reviewed by Maciej Stachowiak. · 771c2654
      ap@webkit.org authored
              Rename "attachedToEventTargetNode" to "isInline".
      
              Inline (onXXX) attributes are used not just with event target nodes, but also with Window,
              XMLHttpRequest, MessagePort et al.
      
              Also renamed createHTMLEventHandler() (which was a leftover from earlier isHTMLEvent ->
              attachedToEventTargetNode rename made for SVG) to createInlineEventListener().
              And also renamed EventTargetNode, Document and Window "eventListenerForType" methods to
              "inlineEventListenerForType", as they work with inline listeners.
      
              * bindings/js/JSDOMApplicationCacheCustom.cpp:
              (WebCore::JSDOMApplicationCache::addEventListener):
              (WebCore::JSDOMApplicationCache::removeEventListener):
              * bindings/js/JSMessagePortCustom.cpp:
              (WebCore::JSMessagePort::setOnmessage):
              (WebCore::JSMessagePort::setOnclose):
              * bindings/js/JSXMLHttpRequestCustom.cpp:
              (WebCore::JSXMLHttpRequest::addEventListener):
              (WebCore::JSXMLHttpRequest::removeEventListener):
              * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
              (WebCore::JSXMLHttpRequestUpload::addEventListener):
              (WebCore::JSXMLHttpRequestUpload::removeEventListener):
              Pass a correct value for this argument - callers used to be confused, because they didn't
              consider themselves event target nodes. This doesn't affect behavior however, as the only
              difference between inline and non-inline event handlers is that the former treat
              "return false" as "event.preventDefault()", which is not important to any of these objects.
      
              * bindings/js/JSEventListener.cpp: (WebCore::JSLazyEventListener::parseCode):
              Assert that isInline is true instead of checking its value, as the constructor of this class
              always sets it to true.
      
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::~JSDOMWindowBase):
              (WebCore::JSDOMWindowBase::findJSEventListener):
              (WebCore::JSDOMWindowBase::findOrCreateJSEventListener):
              (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener):
              (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener):
              (WebCore::JSDOMWindowBase::jsInlineEventListeners):
              (WebCore::JSDOMWindowBase::jsUnprotectedInlineEventListeners):
              * bindings/js/JSDOMWindowBase.h:
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSAbstractEventListener::handleEvent):
              (WebCore::JSAbstractEventListener::isInline):
              (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
              (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
              (WebCore::JSEventListener::JSEventListener):
              (WebCore::JSEventListener::~JSEventListener):
              (WebCore::JSLazyEventListener::parseCode):
              * bindings/js/JSEventListener.h:
              (WebCore::JSAbstractEventListener::JSAbstractEventListener):
              (WebCore::JSUnprotectedEventListener::create):
              (WebCore::JSEventListener::create):
              * bindings/js/ScriptController.cpp:
              (WebCore::ScriptController::createInlineEventHandler):
              * bindings/js/ScriptController.h:
              * dom/Document.cpp:
              (WebCore::Document::setWindowInlineEventListenerForType):
              (WebCore::Document::windowInlineEventListenerForType):
              (WebCore::Document::removeWindowInlineEventListenerForType):
              (WebCore::Document::createEventListener):
              (WebCore::Document::setWindowInlineEventListenerForTypeAndAttribute):
              * dom/Document.h:
              * dom/EventListener.h:
              (WebCore::EventListener::isInline):
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::removeInlineEventListenerForType):
              (WebCore::EventTargetNode::setInlineEventListenerForType):
              (WebCore::EventTargetNode::setInlineEventListenerForTypeAndAttribute):
              (WebCore::EventTargetNode::inlineEventListenerForType):
              (WebCore::EventTargetNode::on*): (many methods)
              (WebCore::EventTargetNode::setOn*): (many methods)
              * dom/EventTargetNode.h:
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplacementFragment::ReplacementFragment):
              * html/HTMLBodyElement.cpp:
              (WebCore::HTMLBodyElement::parseMappedAttribute):
              * html/HTMLButtonElement.cpp:
              (WebCore::HTMLButtonElement::parseMappedAttribute):
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::parseMappedAttribute):
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::parseMappedAttribute):
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::parseMappedAttribute):
              * html/HTMLFrameSetElement.cpp:
              (WebCore::HTMLFrameSetElement::parseMappedAttribute):
              * html/HTMLImageElement.cpp:
              (WebCore::HTMLImageElement::parseMappedAttribute):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::parseMappedAttribute):
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::parseMappedAttribute):
              * html/HTMLScriptElement.cpp:
              (WebCore::HTMLScriptElement::parseMappedAttribute):
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::parseMappedAttribute):
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::parseMappedAttribute):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::mouseButtonListener):
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::setInlineEventListenerForType):
              (WebCore::DOMWindow::inlineEventListenerForType):
              (WebCore::DOMWindow::on*): (many methods)
              (WebCore::DOMWindow::setOn*): (many methods)
              * page/DOMWindow.h:
              * svg/SVGElement.cpp:
              (WebCore::SVGElement::parseMappedAttribute):
              * svg/SVGElementInstance.cpp:
              (WebCore::SVGElementInstance::on*): (many methods)
              (WebCore::SVGElementInstance::setOn*): (many methods)
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::parseMappedAttribute):
              Rename things, as described above.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      771c2654
    • alp@webkit.org's avatar
      2008-10-30 Alp Toker <alp@nuanti.com> · 1ad44177
      alp@webkit.org authored
              Bump WebKit GTK+ version to 1.0.3.
      
              Fix version comments for the web inspector added in r37982. Available
              since 1.0.3, not 1.0.2.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37992 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ad44177
  2. 29 Oct, 2008 27 commits
    • oliver@apple.com's avatar
      Initial work to reduce cost of JSNumberCell allocation · 487b61b9
      oliver@apple.com authored
      Reviewed by Geoffrey Garen
      
      This does the initial work needed to bring more of number
      allocation into CTI code directly, rather than just falling
      back onto the slow paths if we can't guarantee that a number
      cell can be reused.
      
      Initial implementation only used by op_negate to make sure
      it all works.  In a negate heavy (though not dominated) test
      it results in a 10% win in the non-reusable cell case.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37991 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      487b61b9
    • sfalken@apple.com's avatar
      JavaScriptCore: · 621341ba
      sfalken@apple.com authored
      2008-10-29  Steve Falkenburg  <sfalken@apple.com>
      
              <rdar://problem/6326563> Crash on launch
      
              For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.
              
              Exporting data from a DLL on Windows requires specifying __declspec(dllimport) in the header used by
              callers, but __declspec(dllexport) when defined in the DLL implementation. By instead exporting
              the explicit lock/unlock functions, we can avoid this.
              
              Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.
              
              Reviewed by Darin Adler.
      
              * wtf/Threading.h:
              (WTF::lockAtomicallyInitializedStaticMutex):
              (WTF::unlockAtomicallyInitializedStaticMutex):
              * wtf/ThreadingWin.cpp:
              (WTF::lockAtomicallyInitializedStaticMutex):
              (WTF::unlockAtomicallyInitializedStaticMutex):
      
      WebKit/win:
      
      2008-10-29  Steve Falkenburg  <sfalken@apple.com>
      
              <rdar://problem/6326563> Crash on launch
              
              For Windows, export explicit functions rather than exporting data for atomicallyInitializedStaticMutex.
              
              Exporting data from a DLL on Windows requires specifying __declspec(dllimport) in the header used by
              callers, but __declspec(dllexport) when defined in the DLL implementation. By instead exporting
              the explicit lock/unlock functions, we can avoid this.
              
              Fixes a crash on launch, since we were previously erroneously exporting atomicallyInitializedStaticMutex as a function.
              
              Reviewed by Darin Adler.
      
              * WebKit.vcproj/WebKit.def:
              * WebKit.vcproj/WebKit_debug.def:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37990 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      621341ba
    • weinig@apple.com's avatar
      2008-10-29 Sam Weinig <sam@webkit.org> · a3b7bbb9
      weinig@apple.com authored
              Reviewed by Oliver Hunt.
      
              Remove direct use of PropertyMap.
      
              * JavaScriptCore.exp:
              * runtime/JSObject.cpp:
              (JSC::JSObject::mark):
              (JSC::JSObject::put):
              (JSC::JSObject::deleteProperty):
              (JSC::JSObject::getPropertyAttributes):
              (JSC::JSObject::removeDirect):
              * runtime/JSObject.h:
              (JSC::JSObject::getDirect):
              (JSC::JSObject::getDirectLocation):
              (JSC::JSObject::hasCustomProperties):
              (JSC::JSObject::JSObject):
              (JSC::JSObject::putDirect):
              * runtime/PropertyMap.cpp:
              (JSC::PropertyMap::get):
              * runtime/PropertyMap.h:
              (JSC::PropertyMap::isEmpty):
              (JSC::PropertyMap::get):
              * runtime/StructureID.cpp:
              (JSC::StructureID::dumpStatistics):
              * runtime/StructureID.h:
              (JSC::StructureID::propertyStorageSize):
              (JSC::StructureID::get):
              (JSC::StructureID::put):
              (JSC::StructureID::remove):
              (JSC::StructureID::isEmpty):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37989 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3b7bbb9
    • pewtermoose@webkit.org's avatar
      2008-10-29 Matt Lilek <webkit@mattlilek.com> · 835b1c74
      pewtermoose@webkit.org authored
              Not reviewed, build fix.
      
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37988 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      835b1c74
    • andersca@apple.com's avatar
      2008-10-29 Anders Carlsson <andersca@apple.com> · 9afaff46
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Remove an unused forward class declaration.
              
              * Plugins/WebBaseNetscapePluginView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37987 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9afaff46
    • andersca@apple.com's avatar
      2008-10-29 Anders Carlsson <andersca@apple.com> · 4558c152
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Remove WebBaseNetscapePluginViewInternal.h and WebBaseNetscapePluginViewPrivate.h.
      
              * Plugins/WebBaseNetscapePluginView.h:
              * Plugins/WebBaseNetscapePluginViewInternal.h: Removed.
              * Plugins/WebBaseNetscapePluginViewPrivate.h: Removed.
              * Plugins/WebNetscapePluginEventHandler.mm:
              * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
              * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
              * Plugins/npapi.mm:
              * WebView/WebHTMLView.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37986 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4558c152
    • weinig@apple.com's avatar
      2008-10-29 Sam Weinig <sam@webkit.org> · 8059db04
      weinig@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Rename and move the StructureID transition table to its own file.
      
              * GNUmakefile.am:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * runtime/StructureID.cpp:
              (JSC::StructureID::addPropertyTransition):
              * runtime/StructureID.h:
              (JSC::StructureID::):
              * runtime/StructureIDTransitionTable.h: Copied from runtime/StructureID.h.
              (JSC::StructureIDTransitionTableHash::hash):
              (JSC::StructureIDTransitionTableHash::equal):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37985 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8059db04
    • andersca@apple.com's avatar
      2008-10-29 Anders Carlsson <andersca@apple.com> · e2b89383
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Remove WebNetscapePluginEmbeddedView, it adds nothing extra now. 
              
              Remove WebNetscapePlugInStreamLoaderClient since WebNetscapePluginStream is the client now.
              
              * Plugins/WebBaseNetscapePluginStream.h:
              * Plugins/WebBaseNetscapePluginStream.mm:
              * Plugins/WebBaseNetscapePluginView.h:
              * Plugins/WebKitPluginContainerView.h:
              * Plugins/WebNetscapePluginEmbeddedView.h: Removed.
              * Plugins/WebNetscapePluginEmbeddedView.mm: Removed.
              * Plugins/WebNetscapePluginEventHandler.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (NetscapePluginWidget::NetscapePluginWidget):
              (NetscapePluginWidget::handleEvent):
              (WebFrameLoaderClient::createPlugin):
              * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h: Removed.
              * WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm: Removed.
              * WebView/WebHTMLView.mm:
              (-[NSArray _web_makePluginViewsPerformSelector:withObject:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37984 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2b89383
    • andersca@apple.com's avatar
      2008-10-29 Anders Carlsson <andersca@apple.com> · cd46164f
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Remove the WebBaseNetscapePluginStream Objective-C object.
              
              * Plugins/WebBaseNetscapePluginStream.h:
              (WebNetscapePluginStream::create):
              * Plugins/WebBaseNetscapePluginStream.mm:
              (WebNetscapePluginStream::WebNetscapePluginStream):
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView pluginView:receivedResponse:]):
              (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
              (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd46164f
    • zecke@webkit.org's avatar
      2008-10-29 Gustavo Noronha Silva <gns@gnome.org> · bcca41db
      zecke@webkit.org authored
              Reviewed by Holger Freyther.
      
              Added all the files that need to be installed for the Inspector to
              work.
      
      WebCore/ChangeLog:
      2008-10-29  Gustavo Noronha Silva  <gns@gnome.org>
      
              Reviewed and slightly changed by Holger Freyther.
      
              Added all the files that need to be installed for the Inspector to
              work.
      
              * GNUmakefile.am: Invoke the shell to get the files.
      
      WebKit/gtk:
      2008-10-29  Gustavo Noronha Silva  <gns@gnome.org>
      
              Reviewed and slightly changed by Holger Freyther.
      
              Implemented a new WebKitWebInspector class to provide a GObject
              API for the Web Inspector. Also implemented InspectorClient.
      
              * WebCoreSupport/InspectorClientGtk.cpp:
              (WebKit::notifyWebViewDestroyed):
              (WebKit::InspectorClient::InspectorClient):
              (WebKit::InspectorClient::inspectorDestroyed):
              (WebKit::InspectorClient::webViewDestroyed):
              (WebKit::InspectorClient::createPage):
              (WebKit::InspectorClient::showWindow):
              (WebKit::InspectorClient::closeWindow):
              (WebKit::InspectorClient::attachWindow):
              (WebKit::InspectorClient::detachWindow):
              (WebKit::InspectorClient::inspectedURLChanged):
              * WebCoreSupport/InspectorClientGtk.h:
              * webkit/webkit.h:
              * webkit/webkit-marshal.list:
              * webkit/webkitdefines.h:
              * webkit/webkitprivate.h:
              * webkit/webkitwebinspector.cpp: Added.
              (_WebKitWebInspectorPrivate::webkit_inspect_web_view_request_handled):
              (_WebKitWebInspectorPrivate::webkit_web_inspector_class_init):
              (_WebKitWebInspectorPrivate::webkit_web_inspector_init):
              (_WebKitWebInspectorPrivate::webkit_web_inspector_finalize):
              (_WebKitWebInspectorPrivate::webkit_web_inspector_set_property):
              (_WebKitWebInspectorPrivate::webkit_web_inspector_get_property):
              (_WebKitWebInspectorPrivate::webkit_web_inspector_set_web_view):
              * webkit/webkitwebinspector.h: Added.
              * webkit/webkitwebsettings.cpp:
              (_WebKitWebSettingsPrivate::):
              (_WebKitWebSettingsPrivate::webkit_web_settings_class_init):
              (_WebKitWebSettingsPrivate::webkit_web_settings_set_property):
              (_WebKitWebSettingsPrivate::webkit_web_settings_get_property):
              (_WebKitWebSettingsPrivate::webkit_web_settings_copy):
              * webkit/webkitwebview.cpp:
              * webkit/webkitwebview.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37982 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcca41db
    • weinig@apple.com's avatar
      2008-10-29 Sam Weinig <sam@webkit.org> · ed15b6df
      weinig@apple.com authored
              Reviewed by Cameron Zwarich.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=21958
              Pack bits in StructureID to reduce the size of each StructureID by 2 words.
      
              * runtime/PropertyMap.h:
              (JSC::PropertyMap::propertyMapSize):
              * runtime/StructureID.cpp:
              (JSC::StructureID::dumpStatistics): Add additional size statistics when dumping.
              (JSC::StructureID::StructureID):
              * runtime/StructureID.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed15b6df
    • darin@chromium.org's avatar
      2008-10-29 Andrew Scherkus <scherkus@chromium.org> · de67541e
      darin@chromium.org authored
              Reviewed by Darin Adler
      
              Add MediaPlayerPrivateChromium to MediaPlayer
              https://bugs.webkit.org/show_bug.cgi?id=21930
      
              * platform/graphics/MediaPlayer.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de67541e
    • justin.garcia@apple.com's avatar
      2008-10-29 Justin Garcia <justin.garcia@apple.com> · 8cba38d4
      justin.garcia@apple.com authored
              Reviewed by Darin Adler.
      
              Some preparation for:
              <rdar://problem/6104369> Hitting return at the end of a quoted line creates an extraneous quoted line
              
              Added an early return to avoid a level of if-nesting.  No other changes.  We probably don't
              need to rebalance whitespace before the early return but for now don't risk any change in behavior
              I'll revisit that later.
      
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockquoteCommand::doApply):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cba38d4
    • jhoneycutt@apple.com's avatar
      2008-10-29 Jon Honeycutt <jhoneycutt@apple.com> · fa3ac1af
      jhoneycutt@apple.com authored
              Export atomicallyInitializedStaticMutex.
      
              Rubber-stamped by Steve Falkenburg.
      
              * WebKit.vcproj/WebKit.def:
              * WebKit.vcproj/WebKit_debug.def:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa3ac1af
    • zecke@webkit.org's avatar
      2008-10-29 Mike Hommey <glandium@debian.org> · a05d596d
      zecke@webkit.org authored
              Reviewed by Holger Freyther.
      
              https://bugs.webkit.org/show_bug.cgi?id=21884
              Test presence and link against libpng.
      
              * GNUmakefile.am:
              * configure.ac:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a05d596d
    • kevino@webkit.org's avatar
      ce2e48a5
    • beidson@apple.com's avatar
      2008-10-29 Brady Eidson <beidson@apple.com> · 31e1eb47
      beidson@apple.com authored
              Reviewed by Sam Weinig
      
              https://bugs.webkit.org/show_bug.cgi?id=21952
              
              Address an outstanding FIXME by removing unused SPI
      
              * History/WebHistory.mm:
              (-[WebHistory _addItemForURL:title:]): Fold addItem: into this method
      
              * History/WebHistoryPrivate.h: Removed unused/unneccessary SPI
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31e1eb47
    • jmalonzo@webkit.org's avatar
      2008-10-29 Jan Michael Alonzo <jmalonzo@webkit.org> · dc065f3d
      jmalonzo@webkit.org authored
              Reviewed by Holger Freyther.
      
              Add --enable-optimizations to enable optimized builds. The default
              is to enable it for release builds, and disabled for debug builds.
              This option will allow builders to have a debug as well as
              optimized builds.
      
              * GNUmakefile.am:
              * configure.ac:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc065f3d
    • brettw@chromium.org's avatar
      95ee6813
    • timothy@apple.com's avatar
      Emit the WillExecuteStatement debugger hook before the "else" body when there... · dbc138a6
      timothy@apple.com authored
      Emit the WillExecuteStatement debugger hook before the "else" body when there is no block for the "else" body. This allows breakpoints on those statements in the Web Inspector.
      
      JavaScriptCore:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Emit the WillExecuteStatement debugger hook before the "else" body
              when there is no block for the "else" body. This allows breakpoints
              on those statements in the Web Inspector.
      
              https://bugs.webkit.org/show_bug.cgi?id=21944
      
              Reviewed by Maciej Stachowiak.
      
              * kjs/nodes.cpp:
              (JSC::IfElseNode::emitCode): Emit the WillExecuteStatement
              debugger hook before the else node if isn't a block.
      
      WebCore:
      
      2008-10-28  Timothy Hatcher  <timothy@apple.com>
      
              Add a manual test that checks breakpoints on a blockless body of
              an "else" statement.
      
              https://bugs.webkit.org/show_bug.cgi?id=21944
      
              Reviewed by Maciej Stachowiak.
      
              * manual-tests/inspector/debugger-pause-on-else-statements.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dbc138a6
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · 7c52f886
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=21921
              MessagePort messages are dispatched to documents that are not fully active
      
              Covered by corrected fast/events/message-port-inactive-document.html
      
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSAbstractEventListener::handleEvent): Don't dispatch messages to contexts
              that are not fully active.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c52f886
    • ap@webkit.org's avatar
      Build fix. · c08fcca8
      ap@webkit.org authored
              * JavaScriptCore.exp: Export HashTable::deleteTable().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c08fcca8
    • ap@webkit.org's avatar
      Reviewed by Sam Weinig. · 6b4b687b
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=21922
              Expose MessagePort global constructor
      
              Covered by existing dumper tests.
      
              * dom/MessagePort.idl:
              * page/DOMWindow.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b4b687b
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · c78a2070
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=21924
              HashTable internal index is not always deleted
      
              * bindings/js/JSDOMBinding.cpp: (WebCore::DOMObjectHashTableMap::~DOMObjectHashTableMap):
              Call deleteTable for HashTables that are being deleted.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c78a2070
    • ap@webkit.org's avatar
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · 3c120a80
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=21923
              Create an abstraction for script execution context
      
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              Added ScriptExecutionContext.{h,cpp}.
      
              * bindings/js/JSAudioConstructor.cpp:
              (WebCore::JSAudioConstructor::JSAudioConstructor):
              * bindings/js/JSAudioConstructor.h:
              * bindings/js/JSImageConstructor.cpp:
              (WebCore::JSImageConstructor::JSImageConstructor):
              * bindings/js/JSImageConstructor.h:
              * bindings/js/JSOptionConstructor.cpp:
              (WebCore::JSOptionConstructor::JSOptionConstructor):
              * bindings/js/JSOptionConstructor.h:
              * bindings/js/JSXMLHttpRequestConstructor.cpp:
              (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
              * bindings/js/JSXMLHttpRequestConstructor.h:
              Pass ScriptExecutionContext instead of Document to make getDOMConstructor() happy.
              Since these objects can only work within documents now, it is immediately converted back
              to Document.
      
              * bindings/js/JSMessageChannelConstructor.cpp:
              (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
              (WebCore::JSMessageChannelConstructor::construct):
              * bindings/js/JSMessageChannelConstructor.h:
              (WebCore::JSMessageChannelConstructor::scriptExecutionContext):
              MessageChannel needs to be supported in workers right away, so the constructor operates with
              it directly.
      
              * dom/ActiveDOMObject.cpp:
              (WebCore::ActiveDOMObject::ActiveDOMObject):
              (WebCore::ActiveDOMObject::~ActiveDOMObject):
              (WebCore::ActiveDOMObject::contextDestroyed):
              * dom/ActiveDOMObject.h:
              (WebCore::ActiveDOMObject::scriptExecutionContext):
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::markActiveObjectsForContext):
              (WebCore::markCrossHeapDependentObjectsForContext):
              Use ScriptExecutionContext instead of Document, now that ActiveDOMObject and MessagePort
              tracking is handled by ScriptExecutionContext.
      
              * bindings/js/JSDOMBinding.h: (WebCore::getDOMPrototype): Moved to JSDOMGlobalObject.
      
              * bindings/js/JSDOMGlobalObject.h:
              (WebCore::getDOMConstructor): Moved to this file, as constructors live in JSDOMGlobalObject.
              Also, the two-argument version that used to be in JSDOMWindowBase.cpp need to be accessible
              to worker context implementation.
              (WebCore::scriptExecutionContext): Added a pure virtual method to access
              ScriptExecutionContext, implemented by subclasses.
      
              * bindings/js/JSDOMWindowBase.h:
              * bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::scriptExecutionContext):
              Implement by returning the associated document. Note that this method currently gives bogus
              results after navigation - DOMWindow Frame reference is not zeroed out, so we get a document
              that is currently in the frame, not the one associated with this window.
      
              * bindings/js/JSDedicatedWorkerConstructor.cpp: Removed unnecessary include of DOMWindow.h.
      
              * bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::mark):
              Call markActiveObjectsForContext() by its new name.
      
              * dom/DedicatedWorker.cpp:
              (WebCore::DedicatedWorker::DedicatedWorker):
              (WebCore::DedicatedWorker::document):
              * dom/DedicatedWorker.h:
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::document):
              * xml/XMLHttpRequest.h:
              Added a document() function that upcasts ScriptExecutionContext, as these objects only work
              within documents currently (at least for XMLHttpRequest, this will change soon though).
      
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::~Document):
              Moved active object and MessagePort tracking up to ScriptExecutionContext, to share code
              with workers.
              
              * dom/Document.h:
              (WebCore::Document::isDocument):
              (WebCore::Document::refScriptExecutionContext):
              (WebCore::Document::derefScriptExecutionContext):
              Inherit from ScriptExecutionContext.
      
              * dom/MessageChannel.cpp:
              (WebCore::MessageChannel::MessageChannel):
              * dom/MessageChannel.h:
              (WebCore::MessageChannel::create):
              Use ScriptExecutionContext instead of Document.
      
              * dom/MessagePort.cpp:
              (WebCore::CloseMessagePortTimer::CloseMessagePortTimer): Make m_port a RefPtr, because
              MessagePort doesn't ref() itself when posting this event any more (this is a fix for an
              unrelated issue that was causing random crashes in layout tests).
              (WebCore::MessagePort::MessagePort):
              (WebCore::MessagePort::~MessagePort):
              (WebCore::MessagePort::associatedFrame):
              (WebCore::MessagePort::clone):
              (WebCore::MessagePort::postMessage):
              (WebCore::MessagePort::startConversation):
              (WebCore::MessagePort::start):
              (WebCore::MessagePort::contextDestroyed):
              (WebCore::MessagePort::dispatchMessages):
              * dom/MessagePort.h:
              (WebCore::MessagePort::create):
              (WebCore::MessagePort::scriptExecutionContext):
              Use ScriptExecutionContext instead of Document. This is a step toward making MessagePort
              work in worker contexts - we need to also make some its method thread safe for cross-thread
              messaging, and make event dispatching thread safe.
      
              * dom/ScriptExecutionContext.cpp: Added.
              * dom/ScriptExecutionContext.h: Added.
              ActiveDOMObject and MessagePort tracking is moved from Document.
              It is debatable whether ScriptExecutionContext should be a parent of Document or DOMWindow,
              but as I'm just moving Document code, and it is Document that is the main context object
              in our implementation currently.
              Changing ScriptExecutionContext to be a parent of DOMWindow causes a number of bugs that
              seem non-trivial to fix, and isn't really a part of this task.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c120a80
    • timothy@apple.com's avatar
      Attempt to fix the Windows build. · d077c81c
      timothy@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d077c81c
  3. 28 Oct, 2008 2 commits